Re: [PATCH] AMD SB700/SB800 SATA support 64bit DMA

2008-02-22 Thread Alan Cox
On Fri, 22 Feb 2008 12:55:20 +0800 "Huang, Shane" <[EMAIL PROTECTED]> wrote: > Jeff: > > SB700 SATA controller can support 64 bit DMA, the previous commit > badc2341579511a247f5993865aa68379e283c5c was added with > careless reference to SB600, which should be modified by this patch. Does the SB7

Re: What's needed for PMP support?

2008-02-22 Thread Alan Cox
> Heck, if .dev_select() took a *device* instead of a *port* > as it's parameter, then I could probably manage it fine in there. dev_select gets called during probing before the relevant structures are neccessarily set up. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in

Re: [PATCH] libata: automatically use DMADIR if drive/bridge requires it

2008-02-22 Thread Albert Lee
Tejun Heo wrote: > Back in 2.6.17-rc2, a libata module parameter was added for atapi_dmadir. > > That's nice, but most SATA devices which need it will tell us about it > in their IDENTIFY PACKET response, as bit-15 of word-62 of the > returned data (as per ATA7, ATA8 specifications). > > So for t

RE: [PATCH] AMD SB700/SB800 SATA support 64bit DMA

2008-02-22 Thread Huang, Shane
Alan: > > SB700 SATA controller can support 64 bit DMA, the previous commit > > badc2341579511a247f5993865aa68379e283c5c was added with > > careless reference to SB600, which should be modified by this patch. > > Does the SB700 have the same limits as the SB600 on 256 sectors in one > PRD entry

RE: [PATCH] AMD SB700/SB800 SATA support 64bit DMA

2008-02-22 Thread Shane Huang
Jeff and Tejun: I'm using my private mailbox to submit it before I set up the connection to our exchange mail server under linux. Please check whether this patch can be accepted. Thanks Shane CUT HERE SB700 SATA controller can support 64 bit DMA, the previous commit badc2341579511a24

Re: [PATCH] libata: automatically use DMADIR if drive/bridge requires it

2008-02-22 Thread Mark Lord
Albert Lee wrote: Tejun Heo wrote: Back in 2.6.17-rc2, a libata module parameter was added for atapi_dmadir. That's nice, but most SATA devices which need it will tell us about it in their IDENTIFY PACKET response, as bit-15 of word-62 of the returned data (as per ATA7, ATA8 specifications). S

Re: [PATCH] libata: automatically use DMADIR if drive/bridge requires it

2008-02-22 Thread Mark Lord
Mark Lord wrote: I have a funky looking thing here that says "SataLink SPiF223A" on it (). I wonder what it does? .. Well, after some experimentation, this one appears to be ATA-only, with no ATAPI support at all. Cheers - To unsubscribe from this list: send the line "unsubscribe linux-id

Re: new ata_port_operations for .pmp_{read,write} ?

2008-02-22 Thread Mark Lord
Mark Lord wrote: Tejun, Here's a first cut at this for discussion. You may prefer different names for the invoking functions inside libata-pmp.c, rather than simply pmp_read() and pmp_write(), but I've been up too long and couldn't think of a better name. An alternative to all this, might be t

Re: new ata_port_operations for .pmp_{read,write} ?

2008-02-22 Thread Mark Lord
Mark Lord wrote: Note that, while this does work for sata_mv, I'm still thinking about it. I'm not totally clear yet (more reading to do) as to how/when the ATA shadow/taskfile registers get updated to reflect those for the currently selected pmp.. It would seem that with other parts of libata

Re: ata-piix.c (and libata.ko) in RHEL5.1 (build 78 currently) - this kernel is 2.6.18 baqsed

2008-02-22 Thread Alan Cox
On Fri, Feb 22, 2008 at 09:52:45AM -0500, Richardson, Charlotte wrote: > There is a hack in its probe routine that disables this. I've disabled the > hack and ran a long test of > hotplugs yesterday (added and removed a DVD drive connected to the ESB2 IDE - > this is Intel > device 0x269E) for 26

Re: [PATCH] libata: automatically use DMADIR if drive/bridge requires it

2008-02-22 Thread Jeff Garzik
Mark Lord wrote: Albert Lee wrote: Tejun Heo wrote: Back in 2.6.17-rc2, a libata module parameter was added for atapi_dmadir. That's nice, but most SATA devices which need it will tell us about it in their IDENTIFY PACKET response, as bit-15 of word-62 of the returned data (as per ATA7, ATA8

Re: ata-piix.c (and libata.ko) in RHEL5.1 (build 78 currently) - this kernel is 2.6.18 baqsed

2008-02-22 Thread Mark Lord
Alan Cox wrote: On Fri, Feb 22, 2008 at 09:52:45AM -0500, Richardson, Charlotte wrote: There is a hack in its probe routine that disables this. I've disabled the hack and ran a long test of hotplugs yesterday (added and removed a DVD drive connected to the ESB2 IDE - this is Intel device 0x269

[PATCH] sata_fsl: fix build with ATA_VERBOSE_DEBUG

2008-02-22 Thread Anton Vorontsov
This patch fixes build and few warnings when ATA_VERBOSE_DEBUG is defined: CC drivers/ata/sata_fsl.o drivers/ata/sata_fsl.c: In function ‘sata_fsl_fill_sg’: drivers/ata/sata_fsl.c:338: warning: format ‘%x’ expects type ‘unsigned int’, but argument 3 has type ‘void *’ drivers/ata/sata_fsl.c

Re: ata-piix.c (and libata.ko) in RHEL5.1 (build 78 currently) - this kernel is 2.6.18 baqsed

2008-02-22 Thread Alan Cox
> 3) It is critical to ensure that the ATA "ctl" register is never > written to when no drive is attached. This means bracketing the SRST > sequence to first do a PCS detection before permitting the SRST. > If "ctl" is accessed with no drive attached, the machine locks up hard. At least for PATA

Re: ata-piix.c (and libata.ko) in RHEL5.1 (build 78 currently) - this kernel is 2.6.18 baqsed

2008-02-22 Thread Mark Lord
Alan Cox wrote: 3) It is critical to ensure that the ATA "ctl" register is never written to when no drive is attached. This means bracketing the SRST sequence to first do a PCS detection before permitting the SRST. If "ctl" is accessed with no drive attached, the machine locks up hard. At leas

Re: 2.6.25-rc2 + smartd = hang

2008-02-22 Thread Jeff Garzik
Anders Eriksson wrote: Hi, Trying out 2.6.25-rc2 smartd always causes my box to hang. I can switch vt:s and the keyboard seems to work. Using sysrq-e I noticed a callpath open -> ext3 -> journals -> sync_buffer -> io_scheduel -> generic_unplig_device. I'd guess the open stems from smartd.

Re: 2.6.25-rc2 + smartd = hang

2008-02-22 Thread Anders Eriksson
[EMAIL PROTECTED] said: > The sysrq-e output is probably just standard ext3 journalling unrelated to > the problem... what does dmesg say? lspci? What's your hardware setup? dmesg ; smartd ; dmesg yields no new entries in dmesg. It seems on disk accesses are dead. it still routes packets

[PATCH] hpt366: fix section mismatch warnings

2008-02-22 Thread Sam Ravnborg
hpt366: fix section mismatch warnings Fix following warnings: WARNING: o-sparc64/vmlinux.o(.data+0x195a38): Section mismatch in reference from the variable hpt37x_info.0 to the variable .devinit.data:hpt370 WARNING: o-sparc64/vmlinux.o(.data+0x195a40): Section mismatch in reference from the vari

Re: [MCP-55] IDE problem after bios update

2008-02-22 Thread Alan Cox
On Fri, 22 Feb 2008 20:57:54 +0100 Daniel Schroeder <[EMAIL PROTECTED]> wrote: > hi there, > > this is an asus m2n32-sli deluxe with nvidia chipset. After updating the > bios from 1503 to 1701 following in dmesg, and ide drive doesn't work. > Kernel is 2.6.24.2 If it broke with the BIOS change

[MCP-55] IDE problem after bios update

2008-02-22 Thread Daniel Schroeder
hi there, this is an asus m2n32-sli deluxe with nvidia chipset. After updating the bios from 1503 to 1701 following in dmesg, and ide drive doesn't work. Kernel is 2.6.24.2 ..snip... Feb 21 22:37:02 isla-magica Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2 Feb 21 22:37:02 isla-magi

Re: [PATCH] hpt366: fix section mismatch warnings

2008-02-22 Thread Sergei Shtylyov
Sam Ravnborg wrote: hpt366: fix section mismatch warnings Fix following warnings: WARNING: o-sparc64/vmlinux.o(.data+0x195a38): Section mismatch in reference from the variable hpt37x_info.0 to the variable .devinit.data:hpt370 WARNING: o-sparc64/vmlinux.o(.data+0x195a40): Section mismatch in

Re: [PATCH] hpt366: fix section mismatch warnings

2008-02-22 Thread Sam Ravnborg
> @@ -1570,11 +1570,13 @@ static int __devinit hpt366_init_one(struct pci_dev > *dev, const struct pci_devic > if (rev < 3) > info = &hpt36x; > else { > - static const struct hpt_info *hpt37x_info[] = > -

Re: [PATCH] hpt366: fix section mismatch warnings

2008-02-22 Thread Bartlomiej Zolnierkiewicz
On Friday 22 February 2008, Sergei Shtylyov wrote: > Sam Ravnborg wrote: > > > hpt366: fix section mismatch warnings > > > Fix following warnings: > > WARNING: o-sparc64/vmlinux.o(.data+0x195a38): Section mismatch in reference > > from the variable hpt37x_info.0 to the variable .devinit.data:hpt

[PATCH] libata-core: fix kernel-doc warning

2008-02-22 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix libata-core kernel-doc warning: Warning(linux-2.6.25-rc2-git6//drivers/ata/libata-core.c:168): No description found for parameter 'ap' Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- drivers/ata/libata-core.c |2 +- 1 file changed, 1 insertion(

ata_ram driver

2008-02-22 Thread Matthew Wilcox
I've ported the scsi_ram driver [1] to libata. It could use a lot more work -- there's a lot of stuff in the identify page that I haven't filled in, and there's a lot of commands it doesn't even try to execute. For example, when you unload the driver, you get the mildly disturbing messages: sd

[PATCH] qd65xx: remove commented out code

2008-02-22 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/legacy/qd65xx.c | 37 - 1 file changed, 37 deletions(-) Index: b/drivers/ide/legacy/qd65xx.c === --- a/drivers/ide/leg

[PATCH] ide: remove stale comments from ide-dma.c

2008-02-22 Thread Bartlomiej Zolnierkiewicz
- ide-dma.c is not a separate module - ide-dma.c is not PCI specific anymore - DMA is enabled by default nowadays - link for Intel Zappa BIOS is dead etc. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-dma.c | 48

[PATCH] ide: remove ide-tape documentation from Documentation/ide.txt

2008-02-22 Thread Bartlomiej Zolnierkiewicz
More complete documentation is available in Documentation/ide/ide-tape.txt. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- Documentation/ide.txt | 47 --- 1 file changed, 47 deletions(-) Index: b/Documentation/ide.txt ==

Re: 2.6.25-rc2 + smartd = hang

2008-02-22 Thread Mark Lord
Anders Eriksson wrote: [EMAIL PROTECTED] said: The sysrq-e output is probably just standard ext3 journalling unrelated to the problem... what does dmesg say? lspci? What's your hardware setup? dmesg ; smartd ; dmesg yields no new entries in dmesg. It seems on disk accesses are dead. it

Re: ata_ram driver

2008-02-22 Thread Mark Lord
Matthew Wilcox wrote: I've ported the scsi_ram driver [1] to libata. It could use a lot more work -- there's a lot of stuff in the identify page that I haven't filled in, and there's a lot of commands it doesn't even try to execute. For example, when you unload the driver, you get the mildly di

Re: [PATCH] ide: remove stale comments from ide-dma.c

2008-02-22 Thread Mark Lord
Bartlomiej Zolnierkiewicz wrote: - ide-dma.c is not a separate module - ide-dma.c is not PCI specific anymore - DMA is enabled by default nowadays - link for Intel Zappa BIOS is dead etc. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-dma.c | 48 -

Re: 2.6.25-rc2 + smartd = hang

2008-02-22 Thread Anders Eriksson
[EMAIL PROTECTED] said: > So that's using the old IDE drivers. And the network and USB are sharing > IRQ#11 with each other. > If you are going to be using newer kernels like this (2.6.23+), then you > might consider shifting those drives over to libata drivers. > This involves a little bit of w

Re: 2.6.25-rc2 + smartd = hang

2008-02-22 Thread Jeff Garzik
Anders Eriksson wrote: Is smartd prepared to handle /dev/sdX style devices? Yes. You need to pass "-d ata" to smartd and smartctl, if your scripts are not already doing so. If this is the prefered driver these days, maybe it shouldn't be marked experimental in the menu anymore? It's not

[PATCH] ide: remove redundant comment from ide_unregister()

2008-02-22 Thread Bartlomiej Zolnierkiewicz
Identical comment is present in ide_hwif_release_regions() documentation. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- goes after "hpt366: fix section mismatch warnings" patch in IDE quilt tree drivers/ide/ide.c |5 - 1 file changed, 5 deletions(-) Index: b/drivers/i

[PATCH] ide: skip probing port if "hdx=noprobe" was used for both devices on it

2008-02-22 Thread Bartlomiej Zolnierkiewicz
* Skip probing port if "hdx=noprobe" parameter was used for both devices on it. * Obsolete "idex=noprobe" parameter - it only works for ide_generic, cmd640 and PCI hosts in Compatibility mode (on alpha/x86/ia64/m32r/mips/ppc32). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- g

[PATCH] ide: remove obsoleted "idex=noprobe" kernel parameter

2008-02-22 Thread Bartlomiej Zolnierkiewicz
* Remove obsoleted "idex=noprobe" kernel parameter. * Remove no longer needed hwif->noprobe quirk from ide_hwif_configure() and hwif->noprobe checking from cmd640.c. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- goes before "ide: move default IDE ports setup to ide_generic ho

Re: [PATCH] ide: remove stale comments from ide-dma.c

2008-02-22 Thread Bartlomiej Zolnierkiewicz
On Friday 22 February 2008, Mark Lord wrote: > Bartlomiej Zolnierkiewicz wrote: > > - ide-dma.c is not a separate module > > > > - ide-dma.c is not PCI specific anymore > > > > - DMA is enabled by default nowadays > > > > - link for Intel Zappa BIOS is dead > > > > etc. > > > > Signed-off-by:

Re: new ata_port_operations for .pmp_{read,write} ?

2008-02-22 Thread Mark Lord
Mark Lord wrote: Mark Lord wrote: ... And for that matter, is it possible for sata_pmp_read() to be called while the link is active with another command ? Not today, it seems, but what about when hotplug polling gets implemented ? .. That's the one I'm most concerned about. Should I be? ...

Re: [PATCH] AMD SB700/SB800 SATA support 64bit DMA

2008-02-22 Thread Tejun Heo
Shane Huang wrote: > Jeff and Tejun: > > > I'm using my private mailbox to submit it before I set up > the connection to our exchange mail server under linux. > Please check whether this patch can be accepted. Patch looks fine to me. -- tejun - To unsubscribe from this list: send the line "uns

Re: new ata_port_operations for .pmp_{read,write} ?

2008-02-22 Thread Tejun Heo
Hello, Mark. Mark Lord wrote: >> This patch provides two new struct ata_port_operations methods for this, >> and modifies the code in libata-pmp to use them if provided. > ... > > Note that, while this does work for sata_mv, I'm still thinking about it. > > I'm not totally clear yet (more readin

Re: new ata_port_operations for .pmp_{read,write} ?

2008-02-22 Thread Tejun Heo
Hello, Mark. Mark Lord wrote: >>> And for that matter, is it possible for sata_pmp_read() to be called >>> while the link is active with another command ? Not today, it seems, >>> but what about when hotplug polling gets implemented ? >> .. >> That's the one I'm most concerned about. Should I be

Re: new ata_port_operations for .pmp_{read,write} ?

2008-02-22 Thread Jeff Garzik
Tejun Heo wrote: Yeah, this is an interesting problem. There are basically multiple sets of TF registers and the SFF way of assuming single set doesn't really work well and I don't really think adding ->pmp_read/write is the correct long term solution to the problem. We need to confine direct T

Re: new ata_port_operations for .pmp_{read,write} ?

2008-02-22 Thread Mark Lord
Mark Lord wrote: An alternative to all this, might be to expose the "select_pmp()" function shown in the sample code, and have libata-pmp.c call that, instead of having the new new .pmp_{read,write} functions. .. I wonder if this might be more viable than first thought. Say the LLD, be it ata

Re: 2.6.25-rc2 + smartd = hang

2008-02-22 Thread Andrey Borzenkov
Jeff Garzik wrote: >> If this is the prefered driver these days, maybe it shouldn't be marked >> experimental in the menu anymore? > > It's not marked experimental. > the comment on the very top of drivers/ata says: tristate "Serial ATA (prod) and Parallel ATA (experimental) drivers" this is a