Re: [PATCH] libata: Add a drivers/ide style DMA disable
On 08/22/2007 06:37 PM, Alan Cox wrote: This is useful when debugging, handling problem systems, or for distributions just to get the system installed so it can be sorted out later. This is a bit smarter than the old IDE one and lets you do libata.pata_dma=0 Disable all PATA DMA like old IDE libata.pata_dma=1 Disk DMA only libata.pata_dma=2 ATAPI DMA only libata.pata_dma=4 CF DMA only (or combinations thereof - 0,1,3 being the useful ones I suspect) This doesn't help distro installers with modular libata, as there's no good way to get the parameter to the driver. (libata.pata_dma=0 just causes unrecognized parameter message on boot.) - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] libata: Add a drivers/ide style DMA disable
This doesn't help distro installers with modular libata, as there's no good way to get the parameter to the driver. (libata.pata_dma=0 just causes unrecognized parameter message on boot.) And for how long have people been saying that Fedora needs to sort out passing module parameters from the boot command line via anaconda ? So I'm sorry but Mummy my installer sucks doesn't get sympathy. Distribution problem not kernel. Alan - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] libata: Add a drivers/ide style DMA disable
Chuck Ebbert wrote: On 08/22/2007 06:37 PM, Alan Cox wrote: This is useful when debugging, handling problem systems, or for distributions just to get the system installed so it can be sorted out later. This is a bit smarter than the old IDE one and lets you do libata.pata_dma=0Disable all PATA DMA like old IDE libata.pata_dma=1Disk DMA only libata.pata_dma=2ATAPI DMA only libata.pata_dma=4CF DMA only (or combinations thereof - 0,1,3 being the useful ones I suspect) This doesn't help distro installers with modular libata, as there's no good way to get the parameter to the driver. (libata.pata_dma=0 just causes unrecognized parameter message on boot.) Dunno how all those initrd black magics work but SUSE initrd manages to deliver module.param parameters on kernel command line to respective modules in initrd. I don't think it gets to modules which are loaded after root is mounted tho. -- tejun - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] libata: Add a drivers/ide style DMA disable
On 09/07/2007 06:47 PM, Jeff Garzik wrote: This is useful when debugging, handling problem systems, or for distributions just to get the system installed so it can be sorted out later. This is a bit smarter than the old IDE one and lets you do libata.pata_dma=0Disable all PATA DMA like old IDE libata.pata_dma=1Disk DMA only libata.pata_dma=2ATAPI DMA only libata.pata_dma=4CF DMA only FWIW -- as I noted to Alan personally at KS, I would rather drop the pata_ and have it apply to all, PATA or SATA. Not sure that's a good idea for people who need to use it as a workaround. E.g. they might have DMA working on some SATA devices but not on PATA, and only want to disable the PATA DMA. Either adding a separate sata_dma or additional bitfields for SATA would be useful. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] libata: Add a drivers/ide style DMA disable
On Friday 14 September 2007, Chuck Ebbert wrote: On 09/07/2007 06:47 PM, Jeff Garzik wrote: This is useful when debugging, handling problem systems, or for distributions just to get the system installed so it can be sorted out later. This is a bit smarter than the old IDE one and lets you do libata.pata_dma=0Disable all PATA DMA like old IDE 2.6.24 will have hdx=nodma libata.pata_dma=1Disk DMA only libata.pata_dma=2ATAPI DMA only libata.pata_dma=4CF DMA only FWIW -- as I noted to Alan personally at KS, I would rather drop the pata_ and have it apply to all, PATA or SATA. Not sure that's a good idea for people who need to use it as a workaround. E.g. they might have DMA working on some SATA devices but not on PATA, and only want to disable the PATA DMA. Either adding a separate sata_dma or additional bitfields for SATA would be useful. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] libata: Add a drivers/ide style DMA disable
Jeff Garzik wrote: FWIW -- as I noted to Alan personally at KS, I would rather drop the pata_ and have it apply to all, PATA or SATA. Having the distinction between sata and pata is also nice tho considering many modern machines mix the two and use the P part for ATAPI, CF kind of stuff. It's all just masks anyway, we can easily do both. As an aside, it would be nice to get the EH in shape where it can pause all ports, so we can finally allow userspace to submit SET FEATURES - XFER MODE and have it handled cleanly and properly. Aye aye sir, bumping up in the to-do list. BTW, I'm currently on airplane and won't be back home in about ten days. PMP patchset is regenerated but it has some problem integrating with the AN support and I need my gears to iron it out, so PMP patches will have to wait a bit more. FWIW, openSUSE 10.3 defaults to libata drivers and contains the PMP patches. It already received quite a bit of testing going through two betas, so I don't think the PMP patches would introduce too many serious regressions for non-PMP users. Thanks. -- tejun - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] libata: Add a drivers/ide style DMA disable
Tejun Heo wrote: Alan Cox wrote: This is useful when debugging, handling problem systems, or for distributions just to get the system installed so it can be sorted out later. This is a bit smarter than the old IDE one and lets you do libata.pata_dma=0 Disable all PATA DMA like old IDE libata.pata_dma=1 Disk DMA only libata.pata_dma=2 ATAPI DMA only libata.pata_dma=4 CF DMA only (or combinations thereof - 0,1,3 being the useful ones I suspect) (I've split CF as it seems to be a seperate case of pain and suffering different to the others and caused by assorted PIO wired adapters etc) SATA is not affected - for one its not clear it makes sense to disable DMA for SATA if even always possible, for two we've seen no failure evidence to justify needing to support this kind of hammer on SATA. Signed-off-by: Alan Cox [EMAIL PROTECTED] Acked-by: Tejun Heo [EMAIL PROTECTED] FWIW -- as I noted to Alan personally at KS, I would rather drop the pata_ and have it apply to all, PATA or SATA. It is far less useful on SATA, but I can still see a possibility that somebody might want to avoid DMA for whatever reason, chiefly, possibly keeping failing hardware alive by slowing things down via PIO. And being able to avoid the DMA protocols can be useful for debugging or other things. As an aside, it would be nice to get the EH in shape where it can pause all ports, so we can finally allow userspace to submit SET FEATURES - XFER MODE and have it handled cleanly and properly. Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] libata: Add a drivers/ide style DMA disable
Alan Cox wrote: This is useful when debugging, handling problem systems, or for distributions just to get the system installed so it can be sorted out later. This is a bit smarter than the old IDE one and lets you do libata.pata_dma=0 Disable all PATA DMA like old IDE libata.pata_dma=1 Disk DMA only libata.pata_dma=2 ATAPI DMA only libata.pata_dma=4 CF DMA only (or combinations thereof - 0,1,3 being the useful ones I suspect) (I've split CF as it seems to be a seperate case of pain and suffering different to the others and caused by assorted PIO wired adapters etc) SATA is not affected - for one its not clear it makes sense to disable DMA for SATA if even always possible, for two we've seen no failure evidence to justify needing to support this kind of hammer on SATA. Signed-off-by: Alan Cox [EMAIL PROTECTED] Acked-by: Tejun Heo [EMAIL PROTECTED] -- tejun - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
