[PATCH v2 1/2] HID: wacom: store the hid_device pointers of the sibling devices

2015-02-25 Thread Benjamin Tissoires
tablet, so there is no need to keep a list of hid-devices, plain pointers are sufficient. Tested-by: Josep Sanchez Ferreres josep.sanchez.ferre...@est.fib.upc.edu Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/wacom_sys.c | 25 +++-- drivers/hid

[PATCH v2 2/2] HID: wacom: add full support of the Wacom Bamboo PAD

2015-02-25 Thread Benjamin Tissoires
and BTN_RIGHT reported with the touch because they are placed under the touch interface and it looks like they belong to the touch part. Tested-by: Josep Sanchez Ferreres josep.sanchez.ferre...@est.fib.upc.edu Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/wacom_sys.c | 24

Re: [PATCH 1/4] HID: uclogic: Set quirks from inside the driver

2015-02-25 Thread Benjamin Tissoires
On Feb 25 2015 or thereabouts, Nikolai Kondrashov wrote: On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: Based on a patch from: Nikolai Kondrashov nikolai.kondras...@redhat.com Most of the tablets handled by hid-uclogic already uses MULTI_INPUT. *use Fot the ones which are not quirked

Re: [PATCH 2/4] HID: uclogic: merge hid-huion driver in hid-uclogic

2015-02-25 Thread Benjamin Tissoires
On Feb 25 2015 or thereabouts, Nikolai Kondrashov wrote: On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: From: Nikolai Kondrashov nikolai.kondras...@redhat.com Merge the hid-huion driver into hid-uclogic as all the devices supported by hid-huion are in fact UC-Logic devices. Signed-off

Re: [PATCH 3/4] HID: uclogic: present only the working interfaces on the Huion tablets

2015-02-25 Thread Benjamin Tissoires
On Feb 25 2015 or thereabouts, Nikolai Kondrashov wrote: On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: The Huion tablets show 3 interfaces. Only the first and the third are currently used. Also remove HID_QUIRK_MULTI_INPUT for the third interface to not create more than needed input nodes

Re: [PATCH 4/4] HID: uclogic: name the input nodes based on their tool

2015-02-25 Thread Benjamin Tissoires
On Feb 25 2015 or thereabouts, Nikolai Kondrashov wrote: On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: We append Pen, Pad, Mouse or Keyboard suffix to the appropriate input node to match what the Wacom driver does and be more convenient for the user to know which one is which. As I said

Re: [PATCH v2 2/2] HID: wacom: add full support of the Wacom Bamboo PAD

2015-02-25 Thread Benjamin Tissoires
On Feb 25 2015 or thereabouts, Ping Cheng wrote: On Wed, Feb 25, 2015 at 8:43 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: The stylus of this device works just fine out of the box. The touch is seen by default as a mouse with relative events and some gestures. The wireless

Re: [PATCH] HID: wacom: add full support of the Wacom Bamboo PAD

2015-02-20 Thread Benjamin Tissoires
had that allowed the pen to work, but without my latest patches). Cheers, Benjamin 2015-02-18 23:07 GMT+01:00 Benjamin Tissoires benjamin.tissoi...@redhat.com : On Feb 18 2015 or thereabouts, jsanchezf wrote: Hello Benjamin Following your instructions I managed to compile

Re: [PATCH 5/7] input: Add keycodes used by Lenovo Carbon X1 2014

2015-02-20 Thread Benjamin Tissoires
On Fri, Feb 20, 2015 at 9:44 AM, Bastien Nocera had...@hadess.net wrote: Signed-off-by: Bastien Nocera had...@hadess.net --- include/uapi/linux/input.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h index

Re: [PATCH 3/4] HID: uclogic: present only the working interfaces on the Huion tablets

2015-02-26 Thread Benjamin Tissoires
On Feb 25 2015 or thereabouts, Benjamin Tissoires wrote: On Feb 25 2015 or thereabouts, Nikolai Kondrashov wrote: On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: The Huion tablets show 3 interfaces. Only the first and the third are currently used. Also remove HID_QUIRK_MULTI_INPUT

[PATCH v3 2/2] HID: wacom: add full support of the Wacom Bamboo PAD

2015-02-26 Thread Benjamin Tissoires
and BTN_RIGHT reported with the touch because they are placed under the touch interface and it looks like they belong to the touch part. Tested-by: Josep Sanchez Ferreres josep.sanchez.ferre...@est.fib.upc.edu Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- changes in v3: - store

[PATCH v2 5/6] HID: uclogic: discard the extra Pen input node on Huion tablets

2015-02-26 Thread Benjamin Tissoires
Some Huion tablets present 2 HID Pen interfaces. Only one is used, so we can drop the unused one. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- New in v2 drivers/hid/hid-uclogic.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/hid/hid

[PATCH v2 4/6] HID: uclogic: apply quirk NO_EMPTY_INPUT

2015-02-26 Thread Benjamin Tissoires
to have it. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- New in v2 drivers/hid/hid-uclogic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/hid-uclogic.c b/drivers/hid/hid-uclogic.c index 90e2612..ada8a94 100644 --- a/drivers/hid/hid-uclogic.c +++ b/drivers/hid

[PATCH] HID: remove 2 unused usbh.h includes

2015-02-26 Thread Benjamin Tissoires
These 2 are left over from the USB dependency cleaning, so there is no need to keep them. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/hid-multitouch.c | 1 - drivers/hid/hid-steelseries.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/hid/hid

[PATCH v2 2/6] HID: uclogic: merge hid-huion driver in hid-uclogic

2015-02-26 Thread Benjamin Tissoires
From: Nikolai Kondrashov nikolai.kondras...@redhat.com Merge the hid-huion driver into hid-uclogic as all the devices supported by hid-huion are in fact UC-Logic devices. Signed-off-by: Nikolai Kondrashov nikolai.kondras...@redhat.com Signed-off-by: Benjamin Tissoires benjamin.tissoi

[PATCH v2 1/6] HID: uclogic: Set quirks from inside the driver

2015-02-26 Thread Benjamin Tissoires
that this tablet is not supported currently in this version (it needs the same command as a Huion to start forwarding events). Reviewed-by: Nikolai Kondrashov spbn...@gmail.com Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- no changes in v2 drivers/hid/hid-uclogic.c | 27

[PATCH v2 0/6] HID: huion/uclogic merge and few additions

2015-02-26 Thread Benjamin Tissoires
Hi, this is the v2 of the merge of Huion and UcLogic. I removed the previous 3/4 as mentioned during the review and added 3 more. Note that 6/6 could have been squashed in 2/6, but I kept it separate to keep the first 2 reviewed. Cheers, Benjamin Benjamin Tissoires (6): HID: uclogic: Set

Re: [DIGImend-devel] [PATCH 3/4]....

2015-02-26 Thread Benjamin Tissoires
Hi Vince, On Feb 26 2015 or thereabouts, Vince Herried wrote: I'm overwhelmed by these updates My understanding of the code is not that good. Currently i have a version of the code that gives two interfaces from my Huion h610. I have gotten the buttons to work using xsetwacom. I dont

Re: [PATCH] HID: wacom: add full support of the Wacom Bamboo PAD

2015-02-21 Thread Benjamin Tissoires
23:07 GMT+01:00 Benjamin Tissoires benjamin.tissoi...@redhat.com : On Feb 18 2015 or thereabouts, jsanchezf wrote: Hello Benjamin Following your instructions I managed to compile and install the wacom module properly (actually I had to run automake and autoconf to make

Re: [PATCH] HID: i2c-hid: Limit reads to wMaxInputLength bytes for input events

2015-02-20 Thread Benjamin Tissoires
Tissoires benjamin.tissoi...@redhat.com Signed-off-by: Seth Forshee seth.fors...@canonical.com Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Thanks! Benjamin --- drivers/hid/i2c-hid/i2c-hid.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/hid

[PATCH 1/4] HID: uclogic: Set quirks from inside the driver

2015-02-24 Thread Benjamin Tissoires
that this tablet is not supported currently in this version (it needs the same command than a Huion to start forwarding events). Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- Changes from the original patch: - apply HID_QUIRK_MULTI_INPUT for all devices - removed the quirks in usbhid

[PATCH 2/4] HID: uclogic: merge hid-huion driver in hid-uclogic

2015-02-24 Thread Benjamin Tissoires
From: Nikolai Kondrashov nikolai.kondras...@redhat.com Merge the hid-huion driver into hid-uclogic as all the devices supported by hid-huion are in fact UC-Logic devices. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- Changed from the original patch: - update Makefile

[PATCH 0/4] HID: huion/uclogic merge and few additions

2015-02-24 Thread Benjamin Tissoires
for the tablet I have is the switch to the button reporting mode, but I think that will need a little bit more testing from the users of the DIDImend project. Cheers, Benjamin Benjamin Tissoires (4): HID: uclogic: Set quirks from inside the driver HID: uclogic: merge hid-huion driver in hid-uclogic

[PATCH 4/4] HID: uclogic: name the input nodes based on their tool

2015-02-24 Thread Benjamin Tissoires
We append Pen, Pad, Mouse or Keyboard suffix to the appropriate input node to match what the Wacom driver does and be more convenient for the user to know which one is which. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/hid-uclogic.c | 40

[PATCH 3/4] HID: uclogic: present only the working interfaces on the Huion tablets

2015-02-24 Thread Benjamin Tissoires
The Huion tablets show 3 interfaces. Only the first and the third are currently used. Also remove HID_QUIRK_MULTI_INPUT for the third interface to not create more than needed input nodes. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/hid-uclogic.c | 5 + 1

Re: Inactive keyboard on Acer Aspire Switch 11

2015-02-26 Thread Benjamin Tissoires
On Thu, Feb 26, 2015 at 6:18 PM, Florian Echtler f...@butterbrot.org wrote: Hello everyone, I've recently bought an Acer Aspire Switch 11 convertible tablet/notebook hybrid device. Ubuntu 14.04.2 with kernel 3.16 runs almost perfectly, with one notable exception: on the keyboard dock, only

Re: quirk ALWAYS_POLL needed with an unexpectedly high number of mice

2015-03-27 Thread Benjamin Tissoires
On Fri, Mar 27, 2015 at 11:59 AM, Jean Delvare jdelv...@suse.de wrote: Le Friday 27 March 2015 à 16:10 +0100, Jiri Kosina a écrit : On Fri, 27 Mar 2015, Oliver Neukum wrote: Keeping things as is is fine by me but then I will need to add a lot of quirky devices. I am still surprised that

Re: proposal for deletion of drivers/hid/hid-ids.h

2015-03-26 Thread Benjamin Tissoires
On Thu, Mar 26, 2015 at 7:44 AM, Oliver Neukum oneu...@suse.de wrote: Hi, I would like to kill drivers/hid/hid-ids.h and replace it with numerical IDs in the files using it. There are two reasons for that. 1. It is a layering violation. There should not be a private data base for USB IDs

Re: [PATCH v2 0/7] New Lenovos 2015 touchpads: party time!

2015-03-19 Thread Benjamin Tissoires
On Mar 19 2015 or thereabouts, Yves-Alexis Perez wrote: On Thu, Mar 19, 2015 at 10:46:27AM -0400, Benjamin Tissoires wrote: On Mar 19 2015 or thereabouts, Yves-Alexis Perez wrote: So I have two questions/remarks about this: - if I don't use the touchpad, do I need xf86-input-synaptics

Re: HID: wacom: check for wacom-shared before following the pointer

2015-03-19 Thread Benjamin Tissoires
Hi Dan, On Mar 19 2015 or thereabouts, Dan Carpenter wrote: Hello Benjamin Tissoires, This is a semi-automatic email about new static checker warnings. The patch e2c7d8877e5c: HID: wacom: check for wacom-shared before following the pointer from Mar 5, 2015, leads to the following

Re: [PATCH] Input: synaptics - quirk for Thinkpad E440

2015-03-23 Thread Benjamin Tissoires
On Sat, Mar 21, 2015 at 9:24 AM, Ramiro Morales cra...@gmail.com wrote: On Thu, Mar 19, 2015 at 7:15 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: Then I am even more surprised that you need to quirk a late 2014 haswell refresh. Can you post your dmesg when booting the synaptics

Re: [PATCH 1/2] HID: i2c-hid: The interrupt should be level sensitive

2015-01-29 Thread Benjamin Tissoires
interrupt to be level sensitive. The Windows HID over I2C driver also seems to do the same. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- FWIW, this one is Acked-by: Benjamin Tissoires benjamin.tissoi...@redhat.com looks like we are going to drop 2/2, but this one

Re: [PATCH v3 2/5] input: synaptics - change default width value of cr48 sensors

2015-03-23 Thread Benjamin Tissoires
anything in the CR48 processing. Except for this one (which could be dropped IMO), the *rest* of the series is: Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Thanks for pushing this Gabriele. Cheers, Benjamin if (SYN_CAP_EXTENDED(priv-capabilities

Re: [PATCH v2] Input: set INPUT_PROP_POINTING_STICK in hid-lenovo

2015-04-13 Thread Benjamin Tissoires
is Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Cheers, Benjamin + /* set only for trackpoint device */ + __set_bit(INPUT_PROP_POINTER, hi-input-propbit); + __set_bit(INPUT_PROP_POINTING_STICK, hi-input-propbit

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-23 Thread Benjamin Tissoires
On Apr 23 2015 or thereabouts, Dmitry Torokhov wrote: On Thu, Apr 23, 2015 at 07:10:55PM +0200, Henrik Rydberg wrote: Creation, replacement and destruction of contacts is achieved by modifying the ABS_MT_TRACKING_ID of the associated slot. A non-negative tracking id is interpreted as a

Re: [PATCH 2/2] Input - synaptics: pin 3 touches when the firmware reports 3 fingers

2015-04-23 Thread Benjamin Tissoires
On Apr 23 2015 or thereabouts, Dmitry Torokhov wrote: On Wed, Apr 22, 2015 at 11:45:09AM -0400, Benjamin Tissoires wrote: Synaptics PS/2 touchpad can send only 2 touches in a report. They can detect 4 or 5 and this information is valuable. In commit 63c4fda3c0bb (Input: synaptics

Re: Logitech wireless adaptor ID 046d:c52b not showing up xfce-powermanager since kernel 3.19

2015-04-26 Thread Benjamin Tissoires
Hi, On Sun, Apr 26, 2015 at 1:47 PM, Friedrich Strohmaier damokles4-lis...@bits-fritz.de wrote: Hi all, I'm not familiar writing to kernel lists so bear with me ;o)) subject Since kernel update to 3.19 my logitech M570 trackball doesn't show up in xfce4-power-manager as doesn't my logitech

Re: [PATCH] Input :Added Check for EV_ABS event params

2015-04-22 Thread Benjamin Tissoires
On Wed, Apr 22, 2015 at 9:44 AM, Anshul Garg aksgarg1...@gmail.com wrote: Hello Mr. Dmitry , On Tue, Apr 21, 2015 at 11:59 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Anshul, On Tue, Apr 21, 2015 at 11:19:52AM -0700, Anshul Garg wrote: From: Anshul Garg aksgarg1...@gmail.com

[PATCH 2/2] Input - synaptics: pin 3 touches when the firmware reports 3 fingers

2015-04-22 Thread Benjamin Tissoires
and count the actual used slots (so 2). It then gets confused when receiving the BTN_TOOL_TRIPLETAP and DOUBLETAP information, and goes wild. We can pin the 3 slots until we get a total number of fingers below 2. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1212230 Signed-off-by: Benjamin

[PATCH 0/2] 2 somewhat related input fixes

2015-04-22 Thread Benjamin Tissoires
says. The first one is marked for stable given that it has been there forever (2011) and seems simple enough to be in stable. The second one is a regression introduced in 4.1-rc0, so that would be sweet to have it in 4.1 final. Cheers, Benjamin Benjamin Tissoires (2): Input - elantech: fix semi

[PATCH 1/2] Input - elantech: fix semi-mt protocol for v3 HW

2015-04-22 Thread Benjamin Tissoires
fingers when all the slots are used, but not when some are missing. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=90101 CC: sta...@vger.kernel.org Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/input/mouse/elantech.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 2/2] Input - synaptics: pin 3 touches when the firmware reports 3 fingers

2015-04-24 Thread Benjamin Tissoires
Hi Dmitry, [ adding more relevant people to the discussion ] On Apr 23 2015 or thereabouts, Benjamin Tissoires wrote: On Apr 23 2015 or thereabouts, Dmitry Torokhov wrote: On Wed, Apr 22, 2015 at 11:45:09AM -0400, Benjamin Tissoires wrote: Synaptics PS/2 touchpad can send only 2 touches

Re: keyboard not working with Thinkpad Helix (2nd gen) (also stylus)

2015-04-28 Thread Benjamin Tissoires
digitizer. Can you also provide the dmesg while appending to the kernel boot line i2c-hid.debug=1. We should see a little bit more what is happening. Cheers, Benjamin Best, Jonathan On Mon, Apr 27, 2015 at 7:34 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: Hi Jono, On Sun, Apr

Re: keyboard not working with Thinkpad Helix (2nd gen)

2015-04-28 Thread Benjamin Tissoires
, Cheers, John FWIW, I'll track down the other problems in the other threads. Cheers, Benjamin From abc7922e4972910a31eb54c673bc3b261fd919f7 Mon Sep 17 00:00:00 2001 From: Benjamin Tissoires benjamin.tissoi...@redhat.com Date: Tue, 28 Apr 2015 16:31:56 -0400 Subject: [PATCH] HID: lenovo: add

Re: Thinkpad Helix (2nd gen) Wacom stylus not working (was Re: keyboard not working with Thinkpad Helix (2nd gen) (also stylus))

2015-04-28 Thread Benjamin Tissoires
, right from the trackstick node, not the touchpad node. You can test that by running evemu-record (package evemu. in most distributions). If this is not working as expected with a 4.1-rc1 kernel, then I will need to fix that too :( Cheers, Benjamin On 29/04/15 01:28, Benjamin Tissoires wrote

Re: [PATCH 2/2] Input - synaptics: pin 3 touches when the firmware reports 3 fingers

2015-04-27 Thread Benjamin Tissoires
Hi Henrik, On Apr 25 2015 or thereabouts, Henrik Rydberg wrote: Benjamin, For old kernels this is not a problem because max_slots was 2 and libinput/ xorg-synaptics knew how to deal with that. Now that max_slot is 3, the clients ignore BTN_TOOL_TRIPLETAP and count the actual used

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-27 Thread Benjamin Tissoires
On Apr 23 2015 or thereabouts, Dmitry Torokhov wrote: On Thu, Apr 23, 2015 at 02:38:27PM -0400, Benjamin Tissoires wrote: On Apr 23 2015 or thereabouts, Dmitry Torokhov wrote: On Thu, Apr 23, 2015 at 07:10:55PM +0200, Henrik Rydberg wrote: Creation, replacement and destruction

Re: PROBLEM: Touchpad works just like a mouse

2015-04-27 Thread Benjamin Tissoires
alx 45056 0 - Live 0x mdio 16384 1 alx, Live 0x sdhci_acpi 16384 0 - Live 0x sdhci 45056 1 sdhci_acpi, Live 0x Cheers, David Zafra El 16/04/15 a las 16:44, Benjamin Tissoires escribió: Hi David, [Adding relevant people

Re: keyboard not working with Thinkpad Helix (2nd gen) (also stylus)

2015-04-27 Thread Benjamin Tissoires
Hi Jono, On Sun, Apr 26, 2015 at 2:16 PM, jono lej...@gmail.com wrote: The keyboard that this machine comes works fine under grub and windows but not linux. The keyboard is a Lenovo Thinkpad Helix Ultrabook Pro which also has a touchpad, extra battery, usb port etc. The touchpad, battery,

Re: [PATCH 1/2] Input: atmel_mxt_ts - add support for Google Pixel 2

2015-04-15 Thread Benjamin Tissoires
On Wed, Apr 15, 2015 at 6:43 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Thu, Apr 16, 2015 at 12:23:03AM +0200, Javier Martinez Canillas wrote: Hello Benjamin, On 04/15/2015 11:20 PM, Benjamin Tissoires wrote: Hi guys, On Wed, Apr 15, 2015 at 11:58 AM, Javier Martinez

Re: PROBLEM: Touchpad works just like a mouse

2015-04-16 Thread Benjamin Tissoires
Hi David, [Adding relevant people to the thread] according to the dmesg, there is a USB HID mouse (with Elan VID:PID 04F3:0232) connected to your laptop. I just want to confirm that you did not plugged any external USB mouse and that this one is your touchpad. If that's the case, we will need

Re: [PATCH 1/2] Input: atmel_mxt_ts - add support for Google Pixel 2

2015-04-15 Thread Benjamin Tissoires
Hi guys, On Wed, Apr 15, 2015 at 11:58 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Dmitry, On 04/08/2015 02:26 AM, Dmitry Torokhov wrote: This change allows atmel_mxt_ts to bind to ACPI-enumerated devices in Google Pixel 2 (2015). While newer version of ACPI

Re: Unusual Focaltech driver behavior

2015-04-17 Thread Benjamin Tissoires
On Fri, Apr 17, 2015 at 9:39 AM, Dmitry Tunin hanipouspi...@gmail.com wrote: Hi Dmitry, On Fri, Apr 17, 2015 at 5:56 AM, Dmitry Tunin hanipouspi...@gmail.com wrote: I noticed that myself and got some complaints like this. https://github.com/hanipouspilot/ubuntu-fixes/issues/2 General

Re: Unusual Focaltech driver behavior

2015-04-17 Thread Benjamin Tissoires
Hi Dmitry, On Fri, Apr 17, 2015 at 5:56 AM, Dmitry Tunin hanipouspi...@gmail.com wrote: I noticed that myself and got some complaints like this. https://github.com/hanipouspilot/ubuntu-fixes/issues/2 General issue is that when one finger is on the touchpad, movement of a second finger is

Re: [PATCH] Input: Fix multitouch support for Type Cover 3

2015-04-13 Thread Benjamin Tissoires
On Sun, Apr 12, 2015 at 6:04 PM, Felipe felipe.otame...@gmail.com wrote: Hi Benjamin, On Sat, Apr 11, 2015 at 11:08 AM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: Hi Felipe, On Sat, Apr 11, 2015 at 12:17 AM, Felipe Otamendi felipe.otame...@gmail.com wrote: Make the Type Cover

Re: Driver for Logitech M560

2015-04-13 Thread Benjamin Tissoires
that checkpatch will raise. Thanks for the submission. Cheers, Benjamin On 2015-04-09 19:35, Benjamin Tissoires wrote: Hi Antonio, On Thu, Apr 9, 2015 at 8:41 AM, Antonio Ospite a...@ao2.it wrote: On Fri, 05 Sep 2014 19:47:44 +0200 Goffredo Baroncelli kreij...@inwind.it wrote: On 09/03/2014

Re: [PATCH] Input: Fix multitouch support for Type Cover 3

2015-04-11 Thread Benjamin Tissoires
Hi Felipe, On Sat, Apr 11, 2015 at 12:17 AM, Felipe Otamendi felipe.otame...@gmail.com wrote: Make the Type Cover 3 use the hid multitouch driver, which is better suited for the touchpad. Also, since it has multiple reports under the same interface, allow the generic hid driver to handle

Re: [PATCH] Input: Fix multitouch support for Type Cover 3

2015-04-14 Thread Benjamin Tissoires
On Mon, Apr 13, 2015 at 11:47 AM, Felipe felipe.otame...@gmail.com wrote: On Mon, Apr 13, 2015 at 11:16 AM Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Sun, Apr 12, 2015 at 6:04 PM, Felipe felipe.otame...@gmail.com wrote: Hi Benjamin, On Sat, Apr 11, 2015 at 11:08 AM

Re: [PATCH 9/16] HID: logitech-hidpp: fix error return code

2015-04-05 Thread Benjamin Tissoires
\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when != ret *if(...) { ... when != ret = e2 when forall return ret; } // /smpl Signed-off-by: Julia Lawall julia.law...@lip6.fr --- Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Thanks

Re: [PATCH v2 0/7] New Lenovos 2015 touchpads: party time!

2015-04-09 Thread Benjamin Tissoires
On Apr 09 2015 or thereabouts, Yves-Alexis Perez wrote: On jeu., 2015-03-19 at 11:58 -0400, Benjamin Tissoires wrote: Am I right? Thanks for the information, I'll also try to point our kernel maintainers to that thread and ask them if it's possible to backport them to the 3.16 kernel

Re: [PATCH 0/5] HID: wacom: Support tablets with pen and touch on same interface

2015-06-08 Thread Benjamin Tissoires
On Jun 04 2015 or thereabouts, Jason Gerecke wrote: On 6/4/2015 7:18 AM, Benjamin Tissoires wrote: Hi Jason, On Jun 03 2015 or thereabouts, Jason Gerecke wrote: I've recently got my hands on a device which has an I2C sensor that sends both pen and touch reports from a single interface

Re: [PATCH 0/5] HID: wacom: Support tablets with pen and touch on same interface

2015-06-08 Thread Benjamin Tissoires
Hi again, On Jun 03 2015 or thereabouts, Jason Gerecke wrote: I've recently got my hands on a device which has an I2C sensor that sends both pen and touch reports from a single interface. To userspace, it shows up as a single input device which blends both the report types (e.g. it has

Re: [PATCH] Input: goodix - do not explicitly set evbits in input device

2015-06-10 Thread Benjamin Tissoires
; } - ts-input_dev-evbit[0] = BIT_MASK(EV_SYN) | - BIT_MASK(EV_KEY) | - BIT_MASK(EV_ABS); - Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Cheers, Benjamin input_set_abs_params(ts-input_dev

Re: [PATCH v2] alps: Do not divide trackpoint deltas reported by hardware by 2 for v7 devices

2015-06-04 Thread Benjamin Tissoires
-by: Rico Moorman rico.moor...@gmail.com Signed-off-by: Hans de Goede hdego...@redhat.com --- Changes in v2: -Also remove the comment why we were dividing the delta by 2 --- Looks good to me Reviewed-by: Benjamin Tissoires benjamin.tissoi...@gmail.com Cheers, Benjamin drivers/input/mouse/alps.c

Re: [PATCH 0/5] HID: wacom: Support tablets with pen and touch on same interface

2015-06-04 Thread Benjamin Tissoires
Hi Jason, On Jun 03 2015 or thereabouts, Jason Gerecke wrote: I've recently got my hands on a device which has an I2C sensor that sends both pen and touch reports from a single interface. To userspace, it shows up as a single input device which blends both the report types (e.g. it has

Re: [PATCH 5/5] HID: wacom: Introduce new 'touch_input' device

2015-06-04 Thread Benjamin Tissoires
Hi Jason, On Jun 03 2015 or thereabouts, Jason Gerecke wrote: Instead of having a single 'input_dev' device that will take either pen or touch data depending on the type of the device, create seperate devices devices for each. By splitting things like this, we can support devices (e.g. the

Re: [PATCH 2/5] HID: wacom: Treat features-device_type values as flags

2015-06-04 Thread Benjamin Tissoires
On Jun 03 2015 or thereabouts, Jason Gerecke wrote: The USB devices that this driver has historically supported segregate the pen and touch portions of the tablet. Oftentimes the segregation would be done at the interface level, though on occasion (e.g. Cintiq 24HDT) the tablet would combine

Re: [PATCH] USB: HID: Fix fields from pen report ID being interpreted for multitouch.

2015-06-09 Thread Benjamin Tissoires
On Tue, Jun 9, 2015 at 4:31 PM, Brent Adam brentadam...@gmail.com wrote: Fields like HID_DG_CONTACTCOUNT are outside of the physical collection, but within the application collection and report ID. Make sure to catch those fields that are not part of the mt_report_id and return 0 so they can

[PATCH 06/11] Input: synaptics-rmi4 - add a reset callback

2015-06-23 Thread Benjamin Tissoires
When a device is physically reset, the transport layer may need to reset its state too and also do extra work to make the device accessible on the bus. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/input/rmi4/rmi_bus.h| 1 + drivers/input/rmi4/rmi_driver.c | 8

[PATCH 00/11] Input: synaptics-rmi4: various fixes for the existing rmi4 branch

2015-06-23 Thread Benjamin Tissoires
/linux-i2c/msg20241.html [2] https://github.com/bentiss/linux branch synaptics-rmi4-smbus-v4.1-15-06-23 Benjamin Tissoires (11): Input: synaptics-rmi4 - embed the function modules in rmi_core Input: synaptics-rmi4 - add a common input device in rmi_driver Input: synaptics-rmi4 - explicitly

[PATCH 04/11] Input: synaptics-rmi4 - prevent oopses when irq arrives while the device is not bound

2015-06-23 Thread Benjamin Tissoires
If the device has been registered but is not populated, we should not process any incoming interrupt. Make sure the pointers we are following are valid. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/input/rmi4/rmi_driver.c | 3 +++ 1 file changed, 3 insertions

[PATCH 11/11] Input: synaptics-rmi4 - f11: add support for kernel tracking

2015-06-23 Thread Benjamin Tissoires
Kernel tracking is used in 2 use cases: - filter out jumps when the sensor is not relieable enough - provide a MT protocol B when the sensor is providing MT protocol A data Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/input/rmi4/rmi_f11.c | 152

[PATCH 03/11] Input: synaptics-rmi4 - explicitly request polling when needed

2015-06-23 Thread Benjamin Tissoires
-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/input/rmi4/rmi_driver.c | 18 +- drivers/input/rmi4/rmi_driver.h | 3 +++ include/linux/rmi.h | 3 +++ 3 files changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/input/rmi4/rmi_driver.c b

[PATCH 08/11] Input: synaptics-rmi4 - f11: use the unified input node if available

2015-06-23 Thread Benjamin Tissoires
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/input/rmi4/rmi_f11.c | 60 ++-- 1 file changed, 35 insertions(+), 25 deletions(-) diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c index c3b757b..061530a

[PATCH 10/11] Input: synaptics-rmi4 - f11: allow the top software button property to be set

2015-06-23 Thread Benjamin Tissoires
Currently, in PS/2 we only have the PNPIds list to detect the property. Unfortunately, it looks like the information is not embeded in the RMI4 protocol either, so allow the Top software buttons property to be set in the platform data. Signed-off-by: Benjamin Tissoires benjamin.tissoi

[PATCH 05/11] Input: synaptics-rmi4 - call rmi_driver_process_config_requests in enable_sensor

2015-06-23 Thread Benjamin Tissoires
The SMBus devices have their IRQs disabled after a reset. We need to configure them by calling rmi_driver_process_config_request() when enabling the sensor. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/input/rmi4/rmi_driver.c | 78

[PATCH 09/11] Input: synaptics-rmi4 - f11: clean up rmi_f11_finger_handler

2015-06-23 Thread Benjamin Tissoires
abs_bit and rel_bits should not be computed at each iteration of the for loop. finger_press_count is unused. Break out rmi_f11_parse_finger_state in its own function. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/input/rmi4/rmi_f11.c | 33

[PATCH 02/11] Input: synaptics-rmi4 - add a common input device in rmi_driver

2015-06-23 Thread Benjamin Tissoires
-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/input/rmi4/rmi_driver.c | 43 + drivers/input/rmi4/rmi_driver.h | 6 ++ drivers/input/rmi4/rmi_f01.c| 7 +++ include/linux/rmi.h | 2 ++ 4 files changed, 58 insertions(+) diff

[PATCH 01/11] Input: synaptics-rmi4 - embed the function modules in rmi_core

2015-06-23 Thread Benjamin Tissoires
separate anyway Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/input/rmi4/Kconfig | 5 + drivers/input/rmi4/Makefile | 2 +- drivers/input/rmi4/rmi_bus.c| 11 ++- drivers/input/rmi4/rmi_driver.h | 8 drivers/input/rmi4/rmi_f11.c| 10

Re: [PATCH 01/11] Input: synaptics-rmi4 - embed the function modules in rmi_core

2015-06-24 Thread Benjamin Tissoires
On Jun 24 2015 or thereabouts, Paul Bolle wrote: On Tue, 2015-06-23 at 15:17 -0400, Benjamin Tissoires wrote: drivers/input/rmi4/Kconfig | 5 + drivers/input/rmi4/Makefile | 2 +- drivers/input/rmi4/rmi_bus.c| 11 ++- drivers/input/rmi4/rmi_driver.h | 8

Re: [PATCH 2/2] Input - synaptics: pin 3 touches when the firmware reports 3 fingers

2015-06-11 Thread Benjamin Tissoires
On Apr 24 2015 or thereabouts, Benjamin Tissoires wrote: Hi Dmitry, [ adding more relevant people to the discussion ] On Apr 23 2015 or thereabouts, Benjamin Tissoires wrote: On Apr 23 2015 or thereabouts, Dmitry Torokhov wrote: On Wed, Apr 22, 2015 at 11:45:09AM -0400, Benjamin

Re: [PATCH] Input: elan_i2c - enable ELAN0600 acpi panels

2015-06-11 Thread Benjamin Tissoires
to do for Jurgen, but we could still enable Alessio's touchpad (the ELAN0600, below). Jiri, Dmitry? Cheers, Benjamin Dmitry Torokhov dmitry.torok...@gmail.com 於 2015年4月4日 上午5:05 寫道: On Tue, Mar 31, 2015 at 05:34:58PM -0400, Benjamin Tissoires wrote: ELAN0600 seems to work just fine

Re: [PATCH] HID: rmi: Disable populating F30 when the touchpad has physical buttons

2015-06-16 Thread Benjamin Tissoires
confirm that with this patch, INPUT_PROP_BUTTONPAD is not set for the Razer Blade touchpad? If so, then this is: Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Cheers, Benjamin drivers/hid/hid-rmi.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] Add driver for mouse logitech M560

2015-05-29 Thread Benjamin Tissoires
On Fri, May 29, 2015 at 10:38 AM, Jiri Kosina jkos...@suse.cz wrote: On Sun, 10 May 2015, Goffredo Baroncelli wrote: From: Goffredo Baroncelli kreij...@inwind.it The Logitech M560 is a wireless mouse designed for windows 8 which uses the unifying receiver. Compared to a standard one, some

Re: [PATCH v2 1/2] HID: wacom: Have wacom_{get,set}_report retry on -EAGAIN, not -EPIPE

2015-05-21 Thread Benjamin Tissoires
jason.gere...@wacom.com --- The series is: Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Thanks for the respin Jason! Cheers, Benjamin Changed in v2: - Renamed from HID: wacom: Allow wacom_{get,set}_report to retry on -EAGAIN - Changed retry conditions so that we no longer retry

Re: [PATCH] HID: usbhid: add Chicony/Pixart usb optical mouse that needs QUIRK_ALWAYS_POLL

2015-05-21 Thread Benjamin Tissoires
. Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Cheers, Benjamin #define USB_DEVICE_ID_CHICONY_TACTICAL_PAD 0x0418 #define USB_DEVICE_ID_CHICONY_MULTI_TOUCH 0xb19d #define USB_DEVICE_ID_CHICONY_WIRELESS 0x0618 diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid

Re: [PATCH] Add driver for mouse logitech M560

2015-05-21 Thread Benjamin Tissoires
On Thu, May 21, 2015 at 3:05 AM, Goffredo Baroncelli kreij...@libero.it wrote: On 2015-05-11 17:28, Benjamin Tissoires wrote: On Sun, May 10, 2015 at 12:49 PM, Goffredo Baroncelli kreij...@libero.it wrote: From: Goffredo Baroncelli kreij...@inwind.it [] Signed-off-by: Goffredo

Re: [PATCH] HID: gembird: add new driver to fix Gembird JPD-DualForce 2

2015-08-12 Thread Benjamin Tissoires
the axis in .input_mapping(). I went ahead with .report_fixup() first, so here it is. Reported-by: Orivej Desh ori...@gmx.fr Tested-by: Orivej Desh ori...@gmx.fr --- * Benjamin Tissoires so here are the fixes I mentioned yesterday. If you could give a quick shot and a tested

[PATCH v2] HID: gembird: add new driver to fix Gembird JPD-DualForce 2

2015-08-13 Thread Benjamin Tissoires
with .report_fixup() first, so here it is. Reported-by: Orivej Desh ori...@gmx.fr Tested-by: Orivej Desh ori...@gmx.fr Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/Kconfig | 6 +++ drivers/hid/Makefile | 1 + drivers/hid/hid-core.c| 1 + drivers/hid/hid

Re: PROBLEM: Missing events on thinkpad trackpoint buttons

2015-08-18 Thread Benjamin Tissoires
Hi Nick, thanks for the report. On Mon, Aug 17, 2015 at 10:31 PM, Nick Bowler nbow...@draconx.ca wrote: Hi, I'm not sure if this is actually a Linux issue but figured I'd at least report it here to start... I have a Lenovo Thinkpad X250, with the newfangled trackpoint buttons. I have a

Re: [PATCH 3/3] HID: Device attributes for hid-penmount

2015-08-19 Thread Benjamin Tissoires
On Wed, Aug 19, 2015 at 3:29 AM, John Sung penmount.to...@gmail.com wrote: Add two attributes, ver and cmd, to provide more convenient way to integrate with shell scripts. Please don't. If the user space wants to talk to the device, use the plain hidraw interface. Adding such a new API would

Re: PROBLEM: Missing events on thinkpad trackpoint buttons

2015-08-19 Thread Benjamin Tissoires
On Wed, Aug 19, 2015 at 10:10 AM, Nick Bowler nbow...@draconx.ca wrote: On 2015-08-19, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Tue, Aug 18, 2015 at 3:06 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: [...] On Mon, Aug 17, 2015 at 10:31 PM, Nick Bowler nbow

Re: [PATCH 1/3] HID: hid-penmount can support multi-touch devices

2015-08-19 Thread Benjamin Tissoires
On Wed, Aug 19, 2015 at 3:29 AM, John Sung penmount.to...@gmail.com wrote: Expand the functionality of hid-penmount to support both PenMount 6000 and PCI devices. Could you elaborate a little bit more here? From the look of your code, I think your panels should be handled by hid-multitouch

Re: PROBLEM: Missing events on thinkpad trackpoint buttons

2015-08-19 Thread Benjamin Tissoires
On Tue, Aug 18, 2015 at 3:06 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: Hi Nick, thanks for the report. On Mon, Aug 17, 2015 at 10:31 PM, Nick Bowler nbow...@draconx.ca wrote: Hi, I'm not sure if this is actually a Linux issue but figured I'd at least report it here

Re: PROBLEM: Missing events on thinkpad trackpoint buttons

2015-08-19 Thread Benjamin Tissoires
On Wed, Aug 19, 2015 at 5:27 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Aug 19, 2015 at 09:52:00AM -0400, Benjamin Tissoires wrote: On Tue, Aug 18, 2015 at 3:06 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: Hi Nick, thanks for the report. On Mon, Aug 17

[PATCH v2] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl

2015-08-21 Thread Benjamin Tissoires
allows user-space to skip unknown axes if not set. There is no need to copy the whole array temporarily into the kernel, but instead the caller issues several ioctl where we copy each value manually. Signed-off-by: David Herrmann dh.herrm...@gmail.com Signed-off-by: Benjamin Tissoires benjamin.tissoi

Re: [PATCH 3/3] HID: wacom: Remove WACOM_QUIRK_NO_INPUT

2015-08-03 Thread Benjamin Tissoires
) but since we ignore the HID descriptor for the wireless reciever anyway, this is not an issue. Signed-off-by: Jason Gerecke jason.gere...@wacom.com --- This series is a nice cleanup. For the 3 in this series: Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Cheers, Benjamin drivers

Re: [PATCH 2/9] Input: atmel_mxt_ts - use deep sleep mode when stopped

2015-08-11 Thread Benjamin Tissoires
Hi Nick, On Tue, Aug 11, 2015 at 11:55 AM, Nick Dyer nick.d...@itdev.co.uk wrote: On 11/08/15 15:24, Nick Dyer wrote: On 10/08/15 21:11, Benjamin Tissoires wrote: I am currently running v4.2-rc6, merged with Dmitry's and Jiri's tree. This patch completely kills my touchpad on the Pixel 2

[PATCH] HID: gembird: add new driver to fix Gembird JPD-DualForce 2

2015-08-11 Thread Benjamin Tissoires
with .report_fixup() first, so here it is. Reported-by: Orivej Desh ori...@gmx.fr Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- Hi, so here are the fixes I mentioned yesterday. If you could give a quick shot and a tested-by that would be even better. Jiri, I am not sure

Re: Missing axis on Gembird JPD-DUALFORCE2 since Linux 3.18

2015-08-11 Thread Benjamin Tissoires
On Mon, Aug 10, 2015 at 6:28 PM, Orivej Desh ori...@gmx.fr wrote: * Benjamin Tissoires Thanks for the logs. So, yes, it appears that your joypad as a weird report descriptor. It declares 2 Z axis, no Ry and one Rz. The first Z axis seems somewhat correlated to X, but does not seem to add

<    4   5   6   7   8   9   10   >