Re: [PATCH] Tosa keyboard support

2008-01-03 Thread Dmitry Torokhov
Hi Dmitry, Sorry for the slow response. On Dec 23, 2007 6:29 PM, Dmitry Baryshkov [EMAIL PROTECTED] wrote: From b213bef91e3f98c6104138050ad4eaa0a54e765d Mon Sep 17 00:00:00 2001 From: Dmitry Baryshkov [EMAIL PROTECTED] Date: Mon, 24 Dec 2007 02:15:34 +0300 Subject: [PATCH] Tosa keyboard

Re: support for Logitech Wave

2008-01-16 Thread Dmitry Torokhov
Hi Timo, On Tue, Jan 15, 2008 at 03:49:14PM +0200, Timo Aaltonen wrote: Hi I've got a Logitech Wave keyboard, that has a number of extra keys on it, and most of them fail to work with evdev. I get no output with xev or while trying to cat the input device. I've been told that it's

Re: [PATCH] input: psmouse: fix input_dev leak in lifebook driver

2008-01-16 Thread Dmitry Torokhov
On Wed, Jan 16, 2008 at 12:58:01PM -0500, Andres Salomon wrote: On Tue, 15 Jan 2008 17:04:01 -0500 Dmitry Torokhov [EMAIL PROTECTED] wrote: On Sat, Jan 12, 2008 at 03:12:52PM -0500, Andres Salomon wrote: The lifebook driver may register a second input device, but it never

Re: [BISECTED] Re: psmouse.c: GlidePoint at isa0060/serio1/input0 lost sync at byte 1

2008-01-16 Thread Dmitry Torokhov
On Wed, Jan 16, 2008 at 06:46:46PM +0100, Vegard Nossum wrote: I have now tried this patch. I don't see a sync error now, but the button still does not work as expected. Now the scroll down button acts like a middle button instead of scrolling down. I am sorry for the confusion; on my

Re: [BISECTED] Re: psmouse.c: GlidePoint at isa0060/serio1/input0 lost sync at byte 1

2008-01-17 Thread Dmitry Torokhov
On Thu, Jan 17, 2008 at 09:26:37PM +0100, Vegard Nossum wrote: On Jan 16, 2008 9:49 PM, Dmitry Torokhov [EMAIL PROTECTED] wrote: Hmm, it seems to work properly, I think it is now a setup issue to a certain degree. The touchpad now works in native mode (as opposed to Intellimouse emulation

Re: [PATCH] Input: Add Fujitsu-Siemens Amilo Pro 2010 to nomux list

2008-01-30 Thread Dmitry Torokhov
Hi Jiri, On Monday 28 January 2008, Jiri Kosina wrote: On Sun, 20 Jan 2008, Jiri Kosina wrote: Add Fujitsu-Siemens Amilo Pro 2010 to nomux list. Hi Dmitry, I don't see this patch in neither branch of your git tree ... is there anything wrong with it? No, it just was stuck in my

Re: [PATCH] Input/Touchscreen Driver: add support AD7877 touchscreen driver (resend to linux-input mailist)

2008-02-04 Thread Dmitry Torokhov
Hi Bryan, On Mon, Feb 04, 2008 at 05:52:38PM +0800, Bryan Wu wrote: + + spi_message_add_tail(req-xfer[0], req-msg); + spi_message_add_tail(req-xfer[1], req-msg); + + status = spi_sync(spi, req-msg); + + if (req-msg.status) + status = req-msg.status; + I think

Re: event devices not released

2008-02-11 Thread Dmitry Torokhov
Hi Erik, On Mon, Feb 11, 2008 at 01:47:41PM +0100, Erik Slagter wrote: Hi, I think I've found a bug :-/ Symptoms: when I remove (unplug) a USB keyboard or mouse, the corresponding event device seems to be closed but not released; when I plug the device back in, it gets a new input device

Re: [PATCH] Input: fix cobalt_btns loadable keymaps support

2008-02-11 Thread Dmitry Torokhov
Hi Yoichi, On Mon, Feb 11, 2008 at 09:54:04PM +0900, Yoichi Yuasa wrote: Fix cobalt_btns loadable keymaps support. Thank you for the patch. input_set_capability(input, EV_MSC, MSC_SCAN); __set_bit(EV_KEY, input-evbit); - for (i = 0; i ARRAY_SIZE(buttons_map); i++) -

Re: [PATCH] Input: fix cobalt_btns loadable keymaps support

2008-02-11 Thread Dmitry Torokhov
On Mon, Feb 11, 2008 at 11:00:27AM -0500, Dmitry Torokhov wrote: Hi Yoichi, On Mon, Feb 11, 2008 at 09:54:04PM +0900, Yoichi Yuasa wrote: Fix cobalt_btns loadable keymaps support. Thank you for the patch. input_set_capability(input, EV_MSC, MSC_SCAN); __set_bit(EV_KEY

Re: [PATCH 0/1] Input: xpad - Add a variation of Mad Catz Beat Pad

2012-07-06 Thread Dmitry Torokhov
, the device works as expected. Dmitry Torokhov, the current maintainer of input drivers, suggested that I include a change to add the usbhid quirk in my patch. Of course the good idea only ever comes after the fact. If I change usbhid to ignore this vendor:device unconditionally, then xpad

Re: [PATCH] keyboard: imx_keypad: Fix clock handling

2012-07-06 Thread Dmitry Torokhov
Hi Fabio, On Fri, Jul 06, 2012 at 12:40:28PM -0300, Fabio Estevam wrote: Adapt clock handling to the new i.mx clock framework and fix the following warning: input: imx-keypad as /devices/platform/imx-keypad/input/input0 [ cut here ]

Re: [PATCH] input: touchscreen ad7879 add option to correct xy axis

2012-07-07 Thread Dmitry Torokhov
On Fri, Jun 01, 2012 at 12:37:01PM +0200, michael.henner...@analog.com wrote: From: Michael Hennerich michael.henner...@analog.com Sebastian Zenker reported that driver swaps x and y samples when the touchscreen leads are connected in accordance with the datasheet specification. Transposed

Re: [PATCH] synaptics_usb: Remove TrackPoint name trailing whitespace

2012-07-07 Thread Dmitry Torokhov
On Fri, Jul 06, 2012 at 12:28:17PM -0500, Bob Ross wrote: The USB TrackPoint name string contains a space at the trailing end that can cause confusion/difficulty when creating udev rules. Example: Synaptics Inc. Composite TouchPad / TrackPoint (Stick) This patch removes the trailing

Re: input: eeti_ts.c build error

2012-07-07 Thread Dmitry Torokhov
: eeti_ts - do not use irq_to_gpio From: Dmitry Torokhov dmitry.torok...@gmail.com irq_to_gpio is not available on many platforms. Let's switch to using one-shot level interrupts with threaded IRQ handlers that should stay active as long as there is data. Reported-by: Olof Johansson o...@lixom.net

Re: [PATCH 2/6] input/spear_keyboard: fix clock handling during suspend/resume

2012-07-07 Thread Dmitry Torokhov
Hi Shiraz, On Mon, Jul 02, 2012 at 12:20:10PM +0530, Shiraz Hashim wrote: SPEAr keyboard should normally disable clock during suspend and enable it during resume. For cases where it is expected to act as a wakeup source the clock can remain in the same state i.e. kept enabled if it is being

Re: [patch -resend] Input: ff-memless - fix a couple min_t() casts

2012-07-07 Thread Dmitry Torokhov
On Wed, Jun 27, 2012 at 12:11:19PM +0300, Dan Carpenter wrote: envelope-attack_level is a u16 type. We're trying to clamp it here so it's between 0 and 0x7fff. Unfortunately, the cast to __s16 turns all the values larger than 0x7fff into negative numbers and min_t() thinks they are less than

Re: [PATCH v8] input: keyboard: Add keys driver for the LPC32xx SoC

2012-07-10 Thread Dmitry Torokhov
From: Dmitry Torokhov dmitry.torok...@gmail.com Signed-off-by: Dmitry Torokhov d...@mail.ru --- drivers/input/keyboard/lpc32xx-keys.c | 241 + 1 file changed, 126 insertions(+), 115 deletions(-) diff --git a/drivers/input/keyboard/lpc32xx-keys.c b/drivers/input

Re: [PATCH 1/1] Input: hanwang - add support for Art Master II tablet

2012-07-10 Thread Dmitry Torokhov
Hi, On Fri, Jun 29, 2012 at 10:14:06PM +0800, weixing wrote: switch (data[0]) { case 0x02: /* data packet */ switch (data[1]) { case 0x80: /* tool prox out */ - hanwang-current_id = 0; -

Re: [PATCH v8] input: keyboard: Add keys driver for the LPC32xx SoC

2012-07-10 Thread Dmitry Torokhov
On Tue, Jul 10, 2012 at 11:36:25AM +0200, Roland Stigge wrote: Hi Dmitry! On 07/10/2012 08:36 AM, Dmitry Torokhov wrote: +static void lpc32xx_mod_states(struct lpc32xx_kscan_drv *kscandat, int col) +{ + u8 key; + int row; + unsigned changed, scancode, keycode; + + key

Re: [PATCH 2/2] Input: bcm5974 - Add support for 2012 MacBook Pro Retina

2012-07-10 Thread Dmitry Torokhov
On Tue, Jul 10, 2012 at 12:11:55PM +0200, Jiri Kosina wrote: On Mon, 9 Jul 2012, Henrik Rydberg wrote: Add support for the 15'' MacBook Pro Retina model (MacBookPro10,1). Patch originally written by clipcarl (forums.opensuse.org). Signed-off-by: Henrik Rydberg rydb...@euromail.se

Re: [PATCH V7 4/4] input: add onkey support to 88PM80X PMIC

2012-07-10 Thread Dmitry Torokhov
Hi Qiao, On Tue, Jul 10, 2012 at 05:17:38PM +0800, Qiao Zhou wrote: add onkey support to MARVELL 88PM80X PMIC. Signed-off-by: Qiao Zhou zhouq...@marvell.com --- drivers/input/misc/88pm80x_onkey.c | 176 drivers/input/misc/Kconfig | 10 ++

Re: [PATCH v9] input: keyboard: Add keys driver for the LPC32xx SoC

2012-07-10 Thread Dmitry Torokhov
-xx- misc changes Signed-off-by: Dmitry Torokhov d...@mail.ru --- drivers/input/keyboard/lpc32xx-keys.c | 217 + 1 file changed, 115 insertions(+), 102 deletions(-) diff --git a/drivers/input/keyboard/lpc32xx-keys.c b/drivers/input/keyboard/lpc32xx-keys.c index

Re: [PATCH v9] input: keyboard: Add keys driver for the LPC32xx SoC

2012-07-11 Thread Dmitry Torokhov
On Wed, Jul 11, 2012 at 09:49:04AM +0200, Roland Stigge wrote: On 07/10/2012 10:55 PM, Dmitry Torokhov wrote: Hi Roland, On Tue, Jul 10, 2012 at 09:35:10PM +0200, Roland Stigge wrote: This patch adds a driver for the key scan interface of the LPC32xx SoC Could of more things

Re: [PATCH v4 1/1] Input: xpad - Handle all variations of Mad Catz Beat Pad

2012-07-11 Thread Dmitry Torokhov
On Wed, Jul 11, 2012 at 02:02:19PM +0700, Yuri Khan wrote: * Add this device to usbhid ignore list Signed-off-by: Yuri Khan yurivk...@gmail.com Acked-by: Jiri Kosina jkos...@suse.cz Applied, thank you Yuri. -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-input

Re: [PATCH v6] input: Add MELFAS mms114 touchscreen driver

2012-07-13 Thread Dmitry Torokhov
On Thu, Jun 28, 2012 at 04:46:34PM +0900, Joonyoung Shim wrote: This is a initial driver for new touchscreen chip mms114 of MELFAS. It uses I2C interface and supports 10 multi touch. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com

Re: [PATCH v2] Input: synaptics - use firmware data for Cr-48

2012-07-19 Thread Dmitry Torokhov
Hi Chung-Yih, On Thu, Jul 19, 2012 at 11:02:23AM +0800, Chung-Yih Wang (王崇懿) wrote: Hi Chase, Thanks for your great comments. You are right, it is impossible to get correct finger tracking if both fingers are moving. However, we think it still worth to have the firmware tracking of the

Re: [PATCH v2 2/2] input: Add support for the Semtech SX8634 controller

2012-07-23 Thread Dmitry Torokhov
Hi Thierry, On Mon, Jul 23, 2012 at 02:18:47PM +0200, Thierry Reding wrote: + + if (gpio_is_valid(sx-power_gpio)) { + err = gpio_request(sx-power_gpio, sx8634 power); + if (err 0) { + dev_err(client-dev, + failed

Re: [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN

2012-07-23 Thread Dmitry Torokhov
On Thu, Jul 19, 2012 at 05:36:12PM +0200, Daniel Mack wrote: On 17.07.2012 14:59, Daniel Mack wrote: On 13.07.2012 09:01, Dmitry Torokhov wrote: On Wed, May 02, 2012 at 09:36:51PM -0700, Dmitry Torokhov wrote: Hi Sven, On Sat, Apr 07, 2012 at 08:38:33PM +0200, Sven Neumann wrote: Hi

Re: [REPOST #3 PATCH v2] Input: atkbd - make repeat period more accurate.

2012-07-25 Thread Dmitry Torokhov
Hi George, On Sat, Jul 21, 2012 at 11:42:28PM -0400, George Spelvin wrote: This replaces some inaccurate lookup tables with an exact computation. Although the diff adds source comments, it shrinks binary size. (By only 50 bytes, but hey.) AT keyboard repeat rates are multiples of 1/240

Re: [PATCH v2 1/2] input: rotary-encoder: switch to devm_* allocation of GPIOs and IRQs

2012-07-25 Thread Dmitry Torokhov
On Wed, Jul 25, 2012 at 09:43:47AM +0200, Daniel Mack wrote: @@ -263,12 +243,7 @@ exit_free_mem: static int __devexit rotary_encoder_remove(struct platform_device *pdev) { struct rotary_encoder *encoder = platform_get_drvdata(pdev); - struct rotary_encoder_platform_data *pdata =

Re: [PATCH v2 1/2] input: rotary-encoder: switch to devm_* allocation of GPIOs and IRQs

2012-07-25 Thread Dmitry Torokhov
On Wed, Jul 25, 2012 at 06:07:24PM +0200, Daniel Mack wrote: On 25.07.2012 18:05, Dmitry Torokhov wrote: On Wed, Jul 25, 2012 at 09:43:47AM +0200, Daniel Mack wrote: @@ -263,12 +243,7 @@ exit_free_mem: static int __devexit rotary_encoder_remove(struct platform_device *pdev

Re: [PATCH] Input: gpio_keys - fix NULL pointer dereference for dt case

2012-08-06 Thread Dmitry Torokhov
On Mon, Aug 06, 2012 at 02:20:27PM +0530, Shubhrajyoti wrote: On Friday 03 August 2012 07:11 PM, Fabio Estevam wrote: Commit 30161f6b2e7d1 (Input: gpio_keys - clean up device tree parser) introduced the following kernel crash for a dt based kernel: .. Unable to handle kernel NULL pointer

Re: [PATCH] Input: omap4-keypad - don't leak in omap4_keypad_probe()

2012-08-08 Thread Dmitry Torokhov
On Wednesday, August 08, 2012 09:36:51 PM Jesper Juhl wrote: On Wed, 8 Aug 2012, Sachin Kamat wrote: On 7 August 2012 23:46, Jesper Juhl j...@chaosbits.net wrote: If omap4_keypad_parse_dt() does not return 0 (zero) in omap4_keypad_probe() we will leak the memory we allocated for

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

2012-08-14 Thread Dmitry Torokhov
On Tuesday, August 14, 2012 12:32:21 PM Ping Cheng wrote: On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg rydb...@euromail.se wrote: Many MT devices send a number of keys along with the mt information. This patch makes sure that there is room for them in the packet buffer.

Re: [PATCH 8/8] input: ab8500-ponkey: Rely on MFD core to convert IRQs to virtual

2012-08-21 Thread Dmitry Torokhov
to requesting an IRQ, but as we're no longer using Device Tree to collect our IRQ numbers, it's actually better to allow the core to do this during device registration time. So the IRQ number we pull from its resource has already been converted to a virtual IRQ. CC: Dmitry Torokhov

Re: [RFC PATCH 1/17] input: RMI4 public header file and documentation.

2012-08-22 Thread Dmitry Torokhov
On Wednesday, August 22, 2012 09:08:00 PM Linus Walleij wrote: On Sat, Aug 18, 2012 at 12:17 AM, Christopher Heiny che...@synaptics.com wrote: +/* Helper fn to convert a byte array representing a short in the RMI + * endian-ness to a short in the native processor's specific endianness. Is

Re: [PATCH] Input: Let the FT5x06 driver build without debugfs

2012-08-30 Thread Dmitry Torokhov
On Thu, Aug 30, 2012 at 03:26:21PM -0700, David Rientjes wrote: On Tue, 21 Aug 2012, Dmitry Torokhov wrote: On 08/17/2012 02:15 AM, Eric W. Biederman wrote: When testing to make certain my user namespace code works in various configurations I tripped over the tf5x06.c

Re: [PATCH 8/8] input: ab8500-ponkey: Rely on MFD core to convert IRQs to virtual

2012-08-30 Thread Dmitry Torokhov
no longer using Device Tree to collect our IRQ numbers, it's actually better to allow the core to do this during device registration time. So the IRQ number we pull from its resource has already been converted to a virtual IRQ. CC: Dmitry Torokhov dmitry.torok...@gmail.com

Re: [PATCH 8/8] input: ab8500-ponkey: Rely on MFD core to convert IRQs to virtual

2012-08-30 Thread Dmitry Torokhov
On Thu, Aug 30, 2012 at 04:02:21PM -0700, Dmitry Torokhov wrote: On Thu, Aug 30, 2012 at 02:12:04PM +0100, Lee Jones wrote: Sorry for the delay. Yes, this shoudl be fine, but since it is essentially a revert of the original patch it should be pushed in as such. How's

Re: [PATCH] Input: s3c2410_ts: Make s3c_ts_pmops const

2012-08-31 Thread Dmitry Torokhov
On Fri, Aug 31, 2012 at 03:17:17PM +0530, Sachin Kamat wrote: Fixes the following warning: WARNING: struct dev_pm_ops should normally be const Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Applied, thanks Sachin. --- drivers/input/touchscreen/s3c2410_ts.c |2 +- 1 files

Re: [PATCH] Input: usbtouchscreen - initialize eGalax devices

2012-08-31 Thread Dmitry Torokhov
On Fri, Aug 31, 2012 at 10:50:38PM +0400, Sergei Shtylyov wrote: Hello. On 08/31/2012 05:56 PM, Forest Bond wrote: From: Forest Bond forest.b...@rapidrollout.com Certain eGalax devices expose an interface with class HID and protocol None. Some work with usbhid and some work with

Re: [PATCH] Input: usbtouchscreen - initialize eGalax devices

2012-08-31 Thread Dmitry Torokhov
On Fri, Aug 31, 2012 at 06:53:53PM -0400, Forest Bond wrote: Hi, On Fri, Aug 31, 2012 at 04:04:58PM -0400, Alan Stern wrote: On Fri, 31 Aug 2012, Dmitry Torokhov wrote: + /* Send a check active packet. The response will be read + * later

Re: [PATCH 1/1] Input: joydev - fix axes values sent in initial js_event

2012-09-04 Thread Dmitry Torokhov
Hi Vojtech, On Tue, Aug 14, 2012 at 12:11:54AM +0200, Vojtech Bocek wrote: Initial input event has not yet arrived in joydev_connect() where values are set, which means default values of input_absinfo are used for init event, not the actual values from joystick. So what guarantees that

Re: [PATCH] Input: tegra: move platform data header

2012-09-05 Thread Dmitry Torokhov
On Tue, Sep 04, 2012 at 04:40:31PM -0600, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com Move the Tegra KBC platform data header out of arch/arm/mach-tegra, as a pre-requisite of single zImage. Signed-off-by: Stephen Warren swar...@nvidia.com Applied, thank you Stephen.

Re: [PATCH v2] Input: imx_keypad - Fix missing clk conversions

2012-09-05 Thread Dmitry Torokhov
On Tue, Sep 04, 2012 at 10:39:05AM -0300, Fabio Estevam wrote: commit a1e636e6d3 (Input: imx_keypad - adapt the new kpp clock name) missed to update clk_enable/clk_disable from imx_keypad_probe(). Fix it so that we do not get clk warnings at boot. Signed-off-by: Fabio Estevam

Re: [PATCH] Input: keyboard: omap-keypad: Fixed coding style issue.

2012-09-05 Thread Dmitry Torokhov
On Thu, Aug 23, 2012 at 08:20:21PM -0400, Josh wrote: Fixed spacing error on if statements and fixed tab error. Signed-off-by: Josh joshua.tayl...@gmail.com Applied, thank you Josh. --- drivers/input/keyboard/omap-keypad.c |8 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [PATCH v3 16/20] HID: Only dump input if someone is listening

2012-09-10 Thread Dmitry Torokhov
On Monday, September 10, 2012 10:49:13 PM Jiri Kosina wrote: On Mon, 10 Sep 2012, Henrik Rydberg wrote: how do you want to handle this? I am fine with all the HID changes. So either I can take it through my tree and add your Sigoff to the Input patches (if you are fine with those), or

Re: [PATCH v3 01/20] Input: Break out MT data

2012-09-12 Thread Dmitry Torokhov
On Sat, Sep 01, 2012 at 09:46:56PM +0200, Henrik Rydberg wrote: Move all MT-related things to a separate place. This saves some bytes for non-mt input devices, and prepares for new MT features. Signed-off-by: Henrik Rydberg rydb...@euromail.se ... @@ -1287,10 +1284,8 @@ struct input_dev {

Re: [PATCH v3 02/20] Input: Improve the events-per-packet estimate

2012-09-12 Thread Dmitry Torokhov
-by: Henrik Rydberg rydb...@euromail.se Makes sense. Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers/input/input-mt.c | 1 - drivers/input/input.c| 10 +++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/input/input-mt.c b/drivers/input/input-mt.c

Re: linux-next: Tree for Sept 12 (kernel-panic after pressing any key at X login)

2012-09-13 Thread Dmitry Torokhov
. Any pointer to an area where to dig into or any feedback in general is welcome! Kind Regards, - Sedat - [ CC Dmitry Torokhov (linux-input maintainer) plus linux-input ML ] By looking at my screenshot, someone could imagine that there is a problem coming from the input

Re: [PATCH v3 05/20] Input: Send events one packet at a time

2012-09-13 Thread Dmitry Torokhov
On Sat, Sep 01, 2012 at 09:47:00PM +0200, Henrik Rydberg wrote: On heavy event loads, such as a multitouch driver, the irqsoff latency can be as high as 250 us. By accumulating a frame worth of data before passing it on, the latency can be dramatically reduced. As a side effect, the special

Re: [PATCH v3 13/20] Input: bcm5974 - Drop pressure and width emulation

2012-09-13 Thread Dmitry Torokhov
On Sat, Sep 01, 2012 at 09:47:08PM +0200, Henrik Rydberg wrote: The ABS_PRESSURE and ABS_WIDTH have special scales, and were initially added solely for thumb and palm recognition in the synaptics driver. This never really get used, however, and userspace quickly moved to MT solutions instead.

Re: [PATCH] input: fix input_open_file() accessing out-of-bound buffers

2012-09-13 Thread Dmitry Torokhov
Hi David, On Thu, Sep 13, 2012 at 06:18:17PM +0200, David Herrmann wrote: Hi Dmitry On Thu, Sep 13, 2012 at 6:17 PM, David Herrmann dh.herrm...@googlemail.com wrote: The input_table array is very small and we cannot be sure that the file the user opens has a minor-ID below 256 (8 5).

Re: [PATCH 20/24] input: rpcmouse: use __iomem pointers for MMIO

2012-09-19 Thread Dmitry Torokhov
On Fri, Sep 14, 2012 at 11:34:48PM +0200, Arnd Bergmann wrote: ARM is moving to stricter checks on readl/write functions, so we need to use the correct types everywhere. Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc: linux-input@vger.kernel.org Signed-off-by: Arnd Bergmann a...@arndb.de

Re: [PATCH v2 0/3] input: Dynamic Minor Numbers

2012-09-21 Thread Dmitry Torokhov
minors; - mousedev and joydev also use dynamic minors. Thanks! -- Dmitry Input: extend the number of event (and other) devices From: Dmitry Torokhov dmitry.torok...@gmail.com Extend the amount of character devices, such as eventX, mouseX and jsX, from a hard limit of 32 per input handler

Re: [PATCH v2 0/3] input: Dynamic Minor Numbers

2012-09-21 Thread Dmitry Torokhov
On Friday, September 21, 2012 09:18:00 PM David Herrmann wrote: Hi Dmitry On Fri, Sep 21, 2012 at 11:22 AM, David Herrmann dh.herrm...@googlemail.com wrote: Hi Dmitry On Fri, Sep 21, 2012 at 10:07 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Thank you very much

Re: [GIT PULL] Input and HID updates for 3.7

2012-09-28 Thread Dmitry Torokhov
On Wed, Sep 19, 2012 at 11:52:01PM +0200, Jiri Kosina wrote: On Wed, 19 Sep 2012, Henrik Rydberg wrote: Hi Jiri, Please pull this tree to receive Input and HID updates for 3.7. The tree contains input core changes, Acked by Dmitry, which substantially reduces the irqsoff latency for

[git pull] Input updates for 3.7-rc0

2012-10-02 Thread Dmitry Torokhov
- defer calls gpio_to_irq() Input: rotary-encoder - use gpio_request_one() Input: rotary-encoder - add DT bindings David Herrmann (1): Input: uinput - return -EINVAL when read buffer size is too small Dmitry Torokhov (8): Input: gpio-keys-polled - constify pointers to platform

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

2012-10-03 Thread Dmitry Torokhov
Hi Benjamin, A few random comments... On Fri, Sep 14, 2012 at 03:41:43PM +0200, benjamin.tissoires wrote: From: Benjamin Tissoires benjamin.tissoi...@enac.fr Microsoft published the protocol specification of HID over i2c:

[PATCH 2/4] Input: mousedev - reformat structure initializers

2012-10-03 Thread Dmitry Torokhov
Reformat structure initializers to match the rest of input handlers Signed-off-by: Dmitry Torokhov d...@mail.ru --- drivers/input/mousedev.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c

[PATCH 4/4] Input: extend the number of event (and other) devices

2012-10-03 Thread Dmitry Torokhov
legacy range is exhausted they will start allocating minors from the dynamic range 256-1024. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers/input/evdev.c| 99 --- drivers/input/input.c| 114

Re: [PATCH 1/5] Input: wacom - Allow any multi-input Intuos device to set prox

2012-10-04 Thread Dmitry Torokhov
Hi Jason, On Mon, Oct 01, 2012 at 10:09:24AM -0700, Jason Gerecke wrote: On Fri, Sep 28, 2012 at 2:18 PM, Ping Cheng pingli...@gmail.com wrote: On Thu, Sep 6, 2012 at 3:53 PM, Jason Gerecke killert...@gmail.com wrote: The ability to set the proximity flag should apply to any device that

Re: [PATCH] USB: input: wacom_sys.c: format OLED image in kernel

2012-10-04 Thread Dmitry Torokhov
Hi Przemo, On Sun, Sep 09, 2012 at 03:37:18PM -0400, Przemo Firszt wrote: This patch adds a new way of handling Wacom Intuos4 family OLEDs. Previously the images had to be 'scrambled' by userland application. Now the 'scrambling' is done in the kernel module, so user space can send simple

Re: [PATCH] Input: Add Alps touchpad 73 03 0a support

2012-10-04 Thread Dmitry Torokhov
Hi Pavel, On Wed, Oct 03, 2012 at 11:37:50AM +0900, Pavel Bludov wrote: Hi Dmitry, the patch is trivial: E7 report is 73 03 0a command mode response is 88 08 1c absolute mode controlled by register c2c4 It looks like you mailer mangled the patch by line-wrapping it, and I would also need

Re: [PATCH] input: samsung-keypad: add clk_prepare and clk_unprepare

2012-10-04 Thread Dmitry Torokhov
On Wed, Oct 03, 2012 at 08:31:52AM +0900, Thomas Abraham wrote: Add calls to clk_prepare and clk_unprepare as required by commom clock framework. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Applied, thank you Thomas. --- drivers/input/keyboard/samsung-keypad.c | 11

Re: [PATCH] input: keyboard: gpio-keys: Try to parse IRQ from device tree

2012-10-05 Thread Dmitry Torokhov
Hi Tomasz, On Wed, Oct 03, 2012 at 01:20:00PM +0200, Tomasz Figa wrote: On modern platforms using device tree and non-legacy IRQ domains there is usually no way to perform direct translation between GPIO and IRQ, because the IRQ of interest is not mapped yet into sparse IRQ namespace. This

Re: [PATCH v4 RESEND 1/3] Input: egalax_ts: get gpio from devicetree

2012-10-10 Thread Dmitry Torokhov
Hi Hui, On Wed, Oct 10, 2012 at 05:12:01PM +0800, Hui Wang wrote: The irq_to_gpio() is old, most platforms use GENERIC_GPIO framework and don't support this API anymore. The i.MX6q sabrelite platform equips an egalax touchscreen controller, and this platform already transfered to

Re: [ebeam PATCH v2 1/2] hid: Blacklist eBeam devices

2012-10-10 Thread Dmitry Torokhov
Jiri, Are you OK with this change? Yann, Is the device usable at all with generic HID driver? If it isn't then maybe we should blacklist it unconditionally? Thanks. On Sat, Oct 06, 2012 at 03:14:46PM +0200, Yann Cantin wrote: Signed-off-by: Yann Cantin yann.can...@laposte.net ---

Re: [PATCH 07/10] input: Enable STMPE keypad driver for Device Tree

2012-10-10 Thread Dmitry Torokhov
col; } } } BTW, am I supposed to merge it or ack it? Thanks! Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc: linux-input@vger.kernel.org Acked-by: Linus Walleij linus.wall...@linaro.org Signed-off-by: Lee Jones lee.jo...@linaro.org

Re: [PATCH 2/3] Input: wm831x-ts - Convert to devm_kzalloc()

2012-10-11 Thread Dmitry Torokhov
On Wed, Oct 10, 2012 at 10:20:35PM +0900, Mark Brown wrote: Saves a little code and eliminates the possibility of introducing some leaks. *sigh* OK, I guess devm_* is here to stay and I have to get on with the program. I am still unhappy that half of the patches converting/using devm_* APIs

Re: [RFC PATCH 02/06] input/rmi4: Core files

2012-10-11 Thread Dmitry Torokhov
On Thu, Oct 11, 2012 at 04:15:56AM +, Christopher Heiny wrote: On Thursday, October 11, 2012 02:21:53 AM you wrote: On Sat, Oct 6, 2012 at 6:09 AM, Christopher Heiny che...@synaptics.com wrote: + +/** This is here because all those casts made for some ugly code. + */

Re: [RFC PATCH 01/06] input/rmi4: Public header and documentation

2012-10-11 Thread Dmitry Torokhov
On Thu, Oct 11, 2012 at 03:41:41AM +, Christopher Heiny wrote: Linus Walleij wrote: On Sat, Oct 6, 2012 at 6:09 AM, Christopher Heiny che...@synaptics.com wrote: +#ifdef CONFIG_RMI4_DEBUG +/** + * Utility routine to handle writes to read-only attributes. Hopefully + *

Re: [PATCH 2/3] Input: wm831x-ts - Convert to devm_kzalloc()

2012-10-11 Thread Dmitry Torokhov
On Thu, Oct 11, 2012 at 05:07:24PM +0900, Mark Brown wrote: On Thu, Oct 11, 2012 at 12:39:55AM -0700, Dmitry Torokhov wrote: On Wed, Oct 10, 2012 at 10:20:35PM +0900, Mark Brown wrote: Saves a little code and eliminates the possibility of introducing some leaks. *sigh* OK, I guess

Re: [PATCH 2/3] Input: wm831x-ts - Convert to devm_kzalloc()

2012-10-11 Thread Dmitry Torokhov
On Thu, Oct 11, 2012 at 05:33:24PM +0900, Mark Brown wrote: On Thu, Oct 11, 2012 at 01:27:49AM -0700, Dmitry Torokhov wrote: On Thu, Oct 11, 2012 at 05:07:24PM +0900, Mark Brown wrote: What's the error pattern you're seeing? I've not noticed much of an issue here

Re: [Patch v3 7/7] Onkey: DA9055 Onkey driver

2012-10-11 Thread Dmitry Torokhov
Hi Ashish, On Thu, Oct 11, 2012 at 04:15:16PM +0530, Ashish Jangam wrote: This is the ONKEY driver of the Dialog DA9055 PMIC and depends on the DA9055 MFD core driver. This patch is functionally tested on SMDK6410 board. Signed-off-by: David Dajun Chen dc...@diasemi.com Signed-off-by:

[git pull] Input updates for 3.7-rc0

2012-10-12 Thread Dmitry Torokhov
! Changelog: - Andy Shevchenko (1): Input: atmel_mxt_ts - simplify mxt_dump_message Dmitry Torokhov (5): Input: mousedev - factor out psaux code to reduce #ifdefery Input: mousedev - reformat structure initializers Input: mousedev - rename mixdev_open

Re: [PATCH] Input: gpio_keys: allocate pins

2012-10-12 Thread Dmitry Torokhov
linus.wall...@linaro.org Cc: Dmitry Torokhov dmitry.torok...@gmail.com (...) + /* request pin mux */ + pinctrl = devm_pinctrl_get_select_default(dev); + if (IS_ERR(pinctrl)) + dev_warn(dev, pins are not configured from the driver\n); I think

Re: [PATCH 1/2] input: gpio-keys: Disable hardware on suspend

2012-10-13 Thread Dmitry Torokhov
Hi Lee, On Thu, Oct 11, 2012 at 03:15:26PM +0100, Lee Jones wrote: From: Jonas Aaberg jonas.ab...@stericsson.com Disable hardware if active when suspending if the hw can not wake the system from suspend. Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc: linux-input@vger.kernel.org Acked

Re: [PATCH 2/2] input: qt2160: Add support for LEDs.

2012-10-16 Thread Dmitry Torokhov
Hi Javier, On Tuesday, October 16, 2012 05:19:31 PM Javier Martin wrote: Outputs x8..x0 of the qt2160 can have leds attached to it. This patch handles those outputs using EV_LED events. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/input/keyboard/qt2160.c | 38

Re: [PATCH] Input: serio - Add ARC PS/2 driver

2012-10-16 Thread Dmitry Torokhov
Hi Mischa, On Tue, Oct 16, 2012 at 05:44:58PM +0200, Mischa Jonker wrote: This adds support for the PS/2 block that is used in various ARC FPGA platforms. This looks very nicem just a few comments below. Signed-off-by: Mischa Jonker mischa.jon...@synopsys.com ---

Re: [PATCH 1/2] input: qt2160: Fix I2C write function.

2012-10-16 Thread Dmitry Torokhov
On Tue, Oct 16, 2012 at 05:19:30PM +0200, Javier Martin wrote: The previous implementation of qt2160_write() didn't work properly. Use a similar aproach as qt1070 instead. I think your editor lost the end of the sentence: ... qt2160_write() didn't work properly because ... :) Thanks! --

Re: [PATCH] Input: serio - Add ARC PS/2 driver

2012-10-18 Thread Dmitry Torokhov
Hi Mischa, On Wed, Oct 17, 2012 at 12:10:19PM +0200, Mischa Jonker wrote: This adds support for the PS/2 block that is used in various ARC FPGA platforms. Thank you for making changes. A few more comments below. Signed-off-by: Mischa Jonker mischa.jon...@synopsys.com ---

Re: [PATCH] Input: edt-ft5x06 - convert to use simple_open()

2012-10-18 Thread Dmitry Torokhov
On Wed, Oct 17, 2012 at 04:29:23PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn This removes an open coded simple_open() function and replaces file operations references to the function with simple_open() instead. dpatch engine is used to auto generate this

Re: [PATCH 5/5] xen-kbdfront: handle backend CLOSED without CLOSING

2012-10-19 Thread Dmitry Torokhov
-input@vger.kernel.org Cc: Dmitry Torokhov dmitry.torok...@gmail.com Hey Dmitry, Should I prep a git pull for you for this or are you OK giving an Ack for me to put this patch in my git pull for Linus? Sure, please merge with the rest through your tree. Acked-by: Dmitry Torokhov

Re: Multiple clients reading from /dev/input/eventX

2012-10-19 Thread Dmitry Torokhov
Hi SImon, On Fri, Oct 19, 2012 at 11:49:29AM -0400, si...@mungewell.org wrote: Hi all, I'm trying to track down a problem with SDL missing events from a gaming wheel. It looks like it's not seeing a 'section' of events and this results in an axis from the wheel/joystick being stuck on. If

Re: [PATCH 1/2] Input: matrix-keypad - remove const from pointer to array of gpios

2012-10-19 Thread Dmitry Torokhov
On Fri, Oct 19, 2012 at 12:36:12PM +0530, AnilKumar Ch wrote: Remove const from pointer to array of gpios in matrix_keypad_platform_data struct. This is required if we update row_gpios and col_gpios based on device tree data. Then don't. Set them up via non-const aliases instead. Thanks. --

[PATCH 1/2] char_dev: allow setting up and pinning parent devices

2012-10-21 Thread Dmitry Torokhov
object is freed. To achieve this allow setting a parent device for character devices and pin them when doing cdev_add() and unpin when last reference to cdev structure is being released. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- Sorry, messed up the first attempt to send... So, how

[PATCH 2/2] Input: fix use-after-free introduced with dynamic minor changes

2012-10-21 Thread Dmitry Torokhov
that it will stay pinned until character device is freed. Also, now that parent structure is pinned while character device exists we do not need to pin and unpin it every time user opens or closes it. Reported-by: Dave Jones da...@redhat.com Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com

[PATCH 1/2] char_dev: pin parent kobject

2012-10-21 Thread Dmitry Torokhov
. To achieve this let's pin kobject's parent when doing cdev_add() and unpin when last reference to cdev structure is being released. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- OK, so it looks like cdev kobject's parent is unused so we can just have users set themselves as parents

[PATCH 2/2] Input: fix use-after-free introduced with dynamic minor changes

2012-10-21 Thread Dmitry Torokhov
that it will stay pinned until character device is freed. Also, now that parent structure is pinned while character device exists we do not need to pin and unpin it every time user opens or closes it. Reported-by: Dave Jones da...@redhat.com Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-22 Thread Dmitry Torokhov
when instantiating platform device? Thanks. Cc: Felipe Balbi ba...@ti.com Cc: Dmitry Torokhov dmitry.torok...@gmail.com Signed-off-by: Sourav Poddar sourav.pod...@ti.com --- v1-v2 - Added PROBE_DEFER check drivers/input/keyboard/omap4-keypad.c | 11 +++ 1 files changed, 11

Re: [PATCH v1] Support Elan Touchscreen eKTF product.

2012-10-22 Thread Dmitry Torokhov
On Mon, Oct 22, 2012 at 11:47:42AM +0800, Jian-Jhong Ding wrote: Scott Liu scott@emc.com.tw writes: + +struct mt_device { + struct mt_slot curdata; /* placeholder of incoming data */ + __u8 num_received; /* how many contacts we received */ + __u8 num_expected; /*

Re: [PATCH v4] input: qt2160: Add support for LEDs.

2012-10-22 Thread Dmitry Torokhov
Hi Javier, On Mon, Oct 22, 2012 at 10:04:12AM +0200, Javier Martin wrote: Outputs x8..x0 of the qt2160 can have leds attached to it. This patch handles those outputs using the generic LED framework. The PWM controls available in the chip are used to achieve different levels of brightness.

[PATCH] Input: introduce managed input devices (add devres support)

2012-10-22 Thread Dmitry Torokhov
using devm_* framework do not have to mix 2 styles. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers/input/input.c | 175 ++ include/linux/input.h | 7 +- 2 files changed, 154 insertions(+), 28 deletions(-) diff --git

Re: [PATCH v4 1/1] Input: serio - Add ARC PS/2 driver

2012-10-23 Thread Dmitry Torokhov
? Thanks. -- Dmitry Input: arc_ps2 - switch to using managed resources Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers/input/serio/arc_ps2.c | 123 - 1 file changed, 59 insertions(+), 64 deletions(-) diff --git a/drivers/input/serio

Re: [Patch v4 7/7] Onkey: DA9055 Onkey driver

2012-10-23 Thread Dmitry Torokhov
On Tue, Oct 23, 2012 at 03:29:52PM +0530, Ashish Jangam wrote: Does this patch looks good? Yes, I just need to pull mainline to get the DA9055 bits (will happen at 3.7-rc3) and I will apply it. Thanks. On Fri, 2012-10-12 at 15:02 +0530, Ashish Jangam wrote: This is the ONKEY driver of the

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Dmitry Torokhov
On Tue, Oct 23, 2012 at 11:18:12AM +0200, Benoit Cousson wrote: Hi Dimitry, On 10/22/2012 05:50 PM, Dmitry Torokhov wrote: Hi Sourav, On Mon, Oct 22, 2012 at 06:43:00PM +0530, Sourav Poddar wrote: Adapt keypad to use pinctrl framework. Tested on omap4430 sdp with 3.7-rc1 kernel

Re: [RFC PATCH 01/06] input/rmi4: Public header and documentation

2012-10-23 Thread Dmitry Torokhov
On Tuesday, October 23, 2012 03:39:00 PM Christopher Heiny wrote: On 10/11/2012 01:20 AM, Dmitry Torokhov wrote: On Fri, Oct 05, 2012 at 09:09:58PM -0700, Christopher Heiny wrote: + + int (*write_block)(struct rmi_phys_device *phys, u16 addr, u8 *buf, + int len

Re: [RFC PATCH 02/06] input/rmi4: Core files

2012-10-23 Thread Dmitry Torokhov
On Tuesday, October 23, 2012 04:46:28 PM Christopher Heiny wrote: On 10/11/2012 01:13 AM, Dmitry Torokhov wrote: On Thu, Oct 11, 2012 at 04:15:56AM +, Christopher Heiny wrote: On Thursday, October 11, 2012 02:21:53 AM you wrote: On Sat, Oct 6, 2012 at 6:09 AM, Christopher Heiny che

  1   2   3   4   5   6   7   8   9   10   >