Re: [PATCH] Input: input.h: Fix EVIOCSFF macro inconsistency by using _IOW()

2015-10-14 Thread Dmitry Torokhov
On Thu, Sep 17, 2015 at 07:26:36PM +0200, Elias Vanderstuyft wrote: > Just like the EVIOCSABS(abs) macro, use the more compact > _IOW(..., type) instead of _IOC(_IOC_WRITE, ..., sizeof(type)) > for the EVIOCSFF macro. > > Signed-off-by: Elias Vanderstuyft Applied, thank

Re: [PATCH] Input: input.h: Fix EVIOCSFF macro inconsistency by using _IOW()

2015-09-26 Thread Elias Vanderstuyft
On Thu, Sep 17, 2015 at 7:26 PM, Elias Vanderstuyft wrote: > Just like the EVIOCSABS(abs) macro, use the more compact > _IOW(..., type) instead of _IOC(_IOC_WRITE, ..., sizeof(type)) > for the EVIOCSFF macro. > > Signed-off-by: Elias Vanderstuyft > --- >

[PATCH] Input: input.h: Fix EVIOCSFF macro inconsistency by using _IOW()

2015-09-17 Thread Elias Vanderstuyft
Just like the EVIOCSABS(abs) macro, use the more compact _IOW(..., type) instead of _IOC(_IOC_WRITE, ..., sizeof(type)) for the EVIOCSFF macro. Signed-off-by: Elias Vanderstuyft --- include/uapi/linux/input.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

EVIOCSFF macro inconsistency

2014-09-08 Thread Elias Vanderstuyft
Hi everyone, After inspecting the linux/input.h header file, I found that there is one single ioctl value macro that is inconsistent w.r.t. the other macros that do an IOC_WRITE : EVIOCSFF _IOC(_IOC_WRITE, 'E', 0x80, sizeof(struct ff_effect)) Why not define it as follows? : EVIOCSFF

Re: EVIOCSFF macro inconsistency

2014-09-08 Thread Dmitry Torokhov
Hi ELias, On Mon, Sep 08, 2014 at 08:14:13PM +0200, Elias Vanderstuyft wrote: Hi everyone, After inspecting the linux/input.h header file, I found that there is one single ioctl value macro that is inconsistent w.r.t. the other macros that do an IOC_WRITE : EVIOCSFF _IOC(_IOC_WRITE,

Re: EVIOCSFF macro inconsistency

2014-09-08 Thread Elias Vanderstuyft
On Mon, Sep 8, 2014 at 8:31 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Elias, On Mon, Sep 08, 2014 at 08:14:13PM +0200, Elias Vanderstuyft wrote: Hi everyone, After inspecting the linux/input.h header file, I found that there is one single ioctl value macro that is inconsistent

Re: EVIOCSFF macro inconsistency

2014-09-08 Thread Dmitry Torokhov
On Monday, September 08, 2014 09:03:11 PM Elias Vanderstuyft wrote: On Mon, Sep 8, 2014 at 8:31 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Elias, On Mon, Sep 08, 2014 at 08:14:13PM +0200, Elias Vanderstuyft wrote: Hi everyone, After inspecting the linux/input.h

Re: EVIOCSFF macro inconsistency

2014-09-08 Thread Elias Vanderstuyft
On Mon, Sep 8, 2014 at 10:24 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Monday, September 08, 2014 09:03:11 PM Elias Vanderstuyft wrote: On Mon, Sep 8, 2014 at 8:31 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Elias, On Mon, Sep 08, 2014 at 08:14:13PM +0200, Elias