[patch 0/3] 2.6.20 fix for PageUptodate memorder problem (try 4)

2007-02-14 Thread Nick Piggin
Various little cleanups and commenting fixes. Fixed up the patchset so each one, incrementally, should give a properly compiling and running kernel. I'd still like Hugh to ack the anon/swap changes when he can find the time. It would be desirable to get at least one ack as to the overall problem

[patch 1/3] mm: make read_cache_page synchronous

2007-02-14 Thread Nick Piggin
Ensure pages are uptodate after returning from read_cache_page, which allows us to cut out most of the filesystem-internal PageUptodate calls. I didn't have a great look down the call chains, but this appears to fixes 7 possible use-before uptodate in hfs, 2 in hfsplus, 1 in jfs, a few in

Re: GPL vs non-GPL device drivers

2007-02-14 Thread Neil Brown
On Wednesday February 14, [EMAIL PROTECTED] wrote: I am well aware of what Greg KHs position is, in fact he is the reason I started the whole rant. This is only a plea to the higher authorities. Linus, please save Linux! Linus is not in any position to do anything. The die is cast. You

[patch 2/3] fs: buffer don't PageUptodate without page locked

2007-02-14 Thread Nick Piggin
__block_write_full_page is calling SetPageUptodate without the page locked. This is unusual, but not incorrect, as PG_writeback is still set. However the next patch will require that SetPageUptodate always be called with the page locked. Simply don't bother setting the page uptodate in this case

[patch 3/3] mm: fix PageUptodate memorder

2007-02-14 Thread Nick Piggin
After running SetPageUptodate, preceeding stores to the page contents to actually bring it uptodate may not be ordered with the store to set the page uptodate. Therefore, another CPU which checks PageUptodate is true, then reads the page contents can get stale data. Fix this by ensuring

[PATCH] fix mempolicy's check on a system with memory-less-node take4

2007-02-14 Thread KAMEZAWA Hiroyuki
please ack if O.K. -Kame -- bind_zonelist() can create zero-length zonelist if there is a memory-less-node. This patch checks the length of zonelist. If length is 0, returns -EINVAL. Changelog: v3 - v4: - changes a name of a temporal void* variable as error_code Changelog: v2 - v3 - removed

Re: GPL vs non-GPL device drivers

2007-02-14 Thread Dave Jones
On Wed, Feb 14, 2007 at 10:46:13PM -0800, v j wrote: You don't get it do you. Our source code is meaningless to the Open Source community at large. Linux supports entire _architectures_ of which there are single figures of people using it. What makes your hardware special ? We are only

Re: GPL vs non-GPL device drivers

2007-02-14 Thread Arjan van de Ven
On Wed, 2007-02-14 at 21:16 -0800, v j wrote: This is in reference to the following thread: http://lkml.org/lkml/2006/12/14/63 I am not sure if this is ever addressed in LKML, but linux is _very_ popular in the embedded space. We (an embedded vendor) chose Linux 3 years back because of

Re: GPL vs non-GPL device drivers

2007-02-14 Thread Nick Piggin
Ben Nizette wrote: v j wrote: This is in reference to the following thread: http://lkml.org/lkml/2006/12/14/63 I am not sure if this is ever addressed in LKML, but linux is _very_ popular in the embedded space. We (an embedded vendor) chose Linux 3 years back because of its lack of royalty

Re: GPL vs non-GPL device drivers

2007-02-14 Thread Neil Brown
On Wednesday February 14, [EMAIL PROTECTED] wrote: On 2/14/07, Randy Dunlap [EMAIL PROTECTED] wrote: We seem to have different definitions of open and closed. Open = 3rd party Linux drivers can be loaded. Closed = No third party Linux drivers can be loaded. Loading a driver is not at

Re: [RFC][PATCH 6/6] automatic tuning applied to some kernel components

2007-02-14 Thread Eric W. Biederman
Nadia Derbey [EMAIL PROTECTED] writes: But, what do you do with Oracle that's asking maxfiles to be set to 0x1, while the default value might be enough for a system that's not running Oracle. I'm afraid that giving boot time values to the max_* tunables we will loose all the benefits

Re: GPL vs non-GPL device drivers

2007-02-14 Thread Trent Waddington
On 2/15/07, Neil Brown [EMAIL PROTECTED] wrote: [..] then it is less clear what people believe Another area where it is less clear what people believe is if you are distributing the module separately to the kernel, but, as I understand it, vj says he is not. But of course the person who's

Re: GPL vs non-GPL device drivers

2007-02-14 Thread Neil Brown
On Wednesday February 14, [EMAIL PROTECTED] wrote: You don't get it do you. Our source code is meaningless to the Open Source community at large. It is only useful to our tiny set of competitors that have nothing to do with Linux. The Embedded space is very specific. We are only _using_ Linux.

Re: [ANNOUNCE] GIT 1.5.0

2007-02-14 Thread Shawn O. Pearce
Jakub Narebski [EMAIL PROTECTED] wrote: Junio C Hamano wrote:  - git-blame learned a new option, --incremental, that tells it    to output the blames as they are assigned.  A sample script    to use it is also included as contrib/blameview. And there are example GUI blameview (Perk

Re: [PATCH 0/6] MODSIGN: Kernel module signing

2007-02-14 Thread Andreas Gruenbacher
On Wednesday 14 February 2007 20:13, Dave Jones wrote: I've not investigated it, but I hear rumours that suse has something similar. Actually, no. We don't belive that module signing adds significant value, and it also doesn't work well with external modules. (The external modules we really

Re: [PATCH 0/6] MODSIGN: Kernel module signing

2007-02-14 Thread Dave Jones
On Wed, Feb 14, 2007 at 09:35:40PM -0800, Andreas Gruenbacher wrote: On Wednesday 14 February 2007 20:13, Dave Jones wrote: I've not investigated it, but I hear rumours that suse has something similar. Actually, no. We don't belive that module signing adds significant value, ok, then

[PATCH 0/6] atl1: bugfix, cleanup, enhancement

2007-02-14 Thread Jay Cliburn
Jeff, Please accept the following patchset for the atl1 network device driver. * Drop unnecessary NET_PCI config * Fix incorrect hash table address * Read MAC address from register * Remove unused define * Add Attansic L1 device id to pci_ids * Bump version number This patchset contains changes

[PATCH 1/6] atl1: drop NET_PCI from Kconfig

2007-02-14 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] The atl1 driver doesn't need NET_PCI. Remove it from Kconfig. Noticed by Chad Sprouse. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] Signed-off-by: Chris Snook [EMAIL PROTECTED] --- drivers/net/Kconfig |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 2/6] atl1: fix bad ioread address

2007-02-14 Thread Jay Cliburn
From: Al Viro [EMAIL PROTECTED] An ioread32 statement reads the wrong address. Fix it. Signed-off-by: Al Viro [EMAIL PROTECTED] Signed-off-by: Jay Cliburn [EMAIL PROTECTED] Signed-off-by: Chris Snook [EMAIL PROTECTED] --- drivers/net/atl1/atl1_hw.c |2 +- 1 files changed, 1 insertions(+),

[PATCH 3/6] atl1: read MAC address from register

2007-02-14 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] On some Asus motherboards containing the L1 NIC, the MAC address is written by the BIOS directly to the MAC register during POST, and is not stored in eeprom. If we don't succeed in fetching the MAC address from eeprom or spi, try reading it directly from the

[PATCH 4/6] atl1: remove unused define

2007-02-14 Thread Jay Cliburn
From: Chris Snook [EMAIL PROTECTED] Remove unused define from atl1_main.c. Signed-off-by: Chris Snook [EMAIL PROTECTED] Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- drivers/net/atl1/atl1_main.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git

[PATCH 5/6] atl1: add L1 device id to pci_ids, then use it

2007-02-14 Thread Jay Cliburn
From: Chris Snook [EMAIL PROTECTED] Add device id for the Attansic L1 chip to pci_ids.h, then use it. Signed-off-by: Chris Snook [EMAIL PROTECTED] Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- drivers/net/atl1/atl1_main.c |2 +- include/linux/pci_ids.h |1 + 2 files changed, 2

[PATCH 6/6] atl1: bump version number

2007-02-14 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] Bump the version number. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- drivers/net/atl1/atl1_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c index

Re: [PATCH 0/6] MODSIGN: Kernel module signing

2007-02-14 Thread Andreas Gruenbacher
On Wednesday 14 February 2007 21:45, Dave Jones wrote: well, the situation for external modules is no worse than usual. They still work, they just aren't signed. Which from a distributor point of view, is actually a nice thing, as they stick out like a sore thumb in oops reports with (U)

Re: [PATCH 0/6] MODSIGN: Kernel module signing

2007-02-14 Thread Dave Jones
On Wed, Feb 14, 2007 at 10:14:53PM -0800, Andreas Gruenbacher wrote: On Wednesday 14 February 2007 21:45, Dave Jones wrote: well, the situation for external modules is no worse than usual. They still work, they just aren't signed. Which from a distributor point of view, is actually a

[PATCH 000/196] V4L/DVB updates

2007-02-14 Thread Mauro Carvalho Chehab
Linus, Please pull 'master' from: git://git.kernel.org:/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git master Basically, this series adds support for a bunch of newer cards and newer drivers, do some relevant cleanups on cx88 (improving source code readability and reducing binary code

Re: [PATCH 1/1] Fabric7 VIOC driver source code

2007-02-14 Thread Andrew Morton
On Wed, 07 Feb 2007 13:07:40 -0800 Sriram Chidambaram [EMAIL PROTECTED] wrote: This patch provides the Fabric7 VIOC driver source code. This git mbox patch is built against git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git The patch can be pulled from

Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

2007-02-14 Thread Eric W. Biederman
Jeremy Fitzhardinge [EMAIL PROTECTED] writes: Eric W. Biederman wrote: Ok. If that is all this may be a difference that makes no difference. binutils has a bad habit of looking at sections (which are fully optional) instead of segments on ET_EXEC and ET_DYN objects. Only ET_REL objects (.o

Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

2007-02-14 Thread Jeremy Fitzhardinge
Eric W. Biederman wrote: Reasonable and it's probably worth letting the binutils developer know. I do agree that it is weird. It might be that something in binutils doesn't like us dropping some of the notes. What do you mean by dropping some of the notes? I think the only notes (at

Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

2007-02-14 Thread Eric W. Biederman
Jeremy Fitzhardinge [EMAIL PROTECTED] writes: Eric W. Biederman wrote: Reasonable and it's probably worth letting the binutils developer know. I do agree that it is weird. It might be that something in binutils doesn't like us dropping some of the notes. What do you mean by dropping

Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

2007-02-14 Thread Jeremy Fitzhardinge
Eric W. Biederman wrote: I'm pretty certain we explicitly drop the weird GNU note that is automatically generated by gcc and specifies something informational. But that's something else again, since it appears as a PT_GNU_STACK phdr. I don't think anything we are doing is wrong but ld gets

Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

2007-02-14 Thread Eric W. Biederman
Jeremy Fitzhardinge [EMAIL PROTECTED] writes: Eric W. Biederman wrote: I'm pretty certain we explicitly drop the weird GNU note that is automatically generated by gcc and specifies something informational. But that's something else again, since it appears as a PT_GNU_STACK phdr. Not

[PATCH 1/2] autofs4 - fix another race between mount and expire

2007-02-14 Thread Ian Kent
Hi Andrew, Jeff Moyer has identified a race between mount and expire. What happens is that during an expire the situation can arise that a directory is removed and another lookup is done before the expire issues a completion status to the kernel module. In this case, since the the lookup gets a

[PATCH 2/2] autofs4 - check for directory re-create in lookup

2007-02-14 Thread Ian Kent
Hi Andrew, This problem was identified and fixed some time ago by Jeff Moyer but it fell through the cracks somehow. It is possible that a user space application could remove and re-create a directory during a request. To avoid returning a failure from lookup incorrectly when our current dentry

Re: [uml-devel] x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted

2007-02-14 Thread Andrew Morton
On Thu, 15 Feb 2007 04:43:41 +0100 Blaisorblade [EMAIL PROTECTED] wrote: I sent an equivalent patch in earlier today: Doh! Interesting this timing... Index: linux-2.6/arch/x86_64/ia32/ptrace32.c === ---

sata_nv ADMA controller lockup investigation

2007-02-14 Thread Robert Hancock
While testing out some libata FUA changes I was working on, I was inadvertently able to reproduce the kind of NCQ command timeouts in sata_nv that a few people have reported. I since verified that the FUA stuff had nothing to do with it as it still happens even with FUA disabled. However I'm

[PATCH 2.6.21-rc1 0/5] ehca patch set for 2.6.21-rc1

2007-02-14 Thread Hoang-Nam Nguyen
Hello Roland! Here is a patch set for ehca with the following changes resp. bug fixes: * Reworked irq handler to avoid/reduce missed irq events * Fix race condition bug in find_next_online_cpu() and other potential locking issue of scaling code * Allow scaling code to be configurable

[PATCH 2.6.21-rc1 1/5] ehca: reworked irq handler to avoid/reduce missed irq events

2007-02-14 Thread Hoang-Nam Nguyen
Hi, here is a patch for ehca with the reworked irq handler. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h | 18 +++-- ehca_eq.c |1 ehca_irq.c | 200 - ehca_irq.h |1

[PATCH 2.6.21-rc1 2/5] ehca: fix race condition/locking issues in scaling code

2007-02-14 Thread Hoang-Nam Nguyen
Hi, this patch fixes a race condition in find_next_cpu_online() and some other locking issues in scaling code. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_irq.c | 68 + 1 files changed, 33 insertions(+),

[PATCH 2.6.21-rc1 4/5] ehca: replace yield() by wait_for_completion()

2007-02-14 Thread Hoang-Nam Nguyen
Hi, this patch removes yield() and uses wait_for_completion() in order to wait for running completion handlers finished before destroying associated completion queue. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h |3 +++ ehca_cq.c |3 ++-

[PATCH 2.6.21-rc1 3/5] ehca: allow en/disabling scaling code via module parameter

2007-02-14 Thread Hoang-Nam Nguyen
Hi, here is a patch for ehca that allows users to en/disable scaling code when loading ib_ehca module. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- Kconfig|8 ehca_classes.h |1 + ehca_irq.c | 47

[PATCH 2.6.21-rc1 5/5] ehca: query_port() returns LINK_UP instead UNKNOWN

2007-02-14 Thread Hoang-Nam Nguyen
Hi, this patch sets port phys state as a result of ehca_query_port() to LINK_UP. On pSeries ehca actually represents a logical HCA, whose phys/link state always is LINK_UP. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_hca.c |3 +++ 1 files changed, 3

Re: [PATCH 2.6.21-rc1 1/5] ehca: reworked irq handler to avoid/reduce missed irq events

2007-02-14 Thread Christoph Hellwig
On Wed, Feb 14, 2007 at 05:40:47PM +0100, Hoang-Nam Nguyen wrote: Hi, here is a patch for ehca with the reworked irq handler. Thanks Nam This looks okay to me (and sorry for new replying earlier to you private mail) - To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: [PATCH 2.6.21-rc1 1/5] ehca: reworked irq handler to avoid/reduce missed irq events

2007-02-14 Thread Roland Dreier
Looks fine but this patch at least has serious whitespace damage... please resend a fixed version. - R. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH 2.6.21-rc1 4/5] ehca: replace yield() by wait_for_completion()

2007-02-14 Thread Christoph Hellwig
@@ -332,7 +333,7 @@ int ehca_destroy_cq(struct ib_cq *cq) spin_lock_irqsave(ehca_cq_idr_lock, flags); while (my_cq-nr_callbacks) { spin_unlock_irqrestore(ehca_cq_idr_lock, flags); - yield(); +

Re: [PATCH 2.6.21-rc1 4/5] ehca: replace yield() by wait_for_completion()

2007-02-14 Thread Roland Dreier
I agree with Christoph -- the use of wait_for_completion() in a loop makes no sense. When you send a new copy of this patch without whitespace damage, please fix that up too... - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED]

<    3   4   5   6   7   8