[PATCH 15/37] CacheFiles: Add missing copy_page export for ia64

2008-02-20 Thread David Howells
This one-line patch fixes the missing export of copy_page introduced by the cachefile patches. This patch is not yet upstream, but is required for cachefile on ia64. It will be pushed upstream when cachefile goes upstream. Signed-off-by: Prarit Bhargava [EMAIL PROTECTED] Signed-off-by: David

[PATCH 37/37] NFS: Add mount options to enable local caching on NFS

2008-02-20 Thread David Howells
Add NFS mount options to allow the local caching support to be enabled. The attached patch makes it possible for the NFS filesystem to be told to make use of the network filesystem local caching service (FS-Cache). To be able to use this, a recent nfsutils package is required. There are three

Re: [Rt2400-devel] 2.6.25-rc2 regression in rt61pci wireless driver

2008-02-20 Thread Dan Williams
On Tue, 2008-02-19 at 23:04 +, Chris Vine wrote: On Tue, 2008-02-19 at 20:46 +0100, Ivo van Doorn wrote: Hi, [added rt2400-devel (rt2x00 development mailinglist) to the CC list.] I have a series of tests I would like to request from you, you mentioned you already enabled

Re: [PATCH] PM: Remove unbalanced mutex_unlock() from dpm_resume()

2008-02-20 Thread Alan Stern
On Wed, 20 Feb 2008, Rafael J. Wysocki wrote: Hi Greg, Please consider taking the following fix for 2.6.25. Don't just consider it! :-) It's a real bug fix. Thanks, Rafael --- From: Rafael J. Wysocki [EMAIL PROTECTED] Remove an unnecessary unlocking of dpm_list_mtx in the error

Re: TG3 network data corruption regression 2.6.24/2.6.23.4

2008-02-20 Thread Tony Battersby
Matt Carlson wrote: Hi Tony. Can you give us the output of : sudo lspci -vvv - -s 03:01.0' 03:01.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5701 Gigabit Ethernet (rev 15) Subsystem: Compaq Computer Corporation NC7770 Gigabit Server Adapter (PCI-X, 10/100/1000-T)

Re: Improve init/Kconfig help descriptions [PATCH 6/9]

2008-02-20 Thread Paul Jackson
Nick wrote: Ok, I had just picked up on the legacy word in the option title and assumed that it meant deprecated. Just because something's old (and some newer equivalent exists) doesn't mean we're making funeral arrangements for it yet. Paul old man Jackson -- I

Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-20 Thread Peter Zijlstra
On Wed, 2008-02-20 at 08:30 -0800, Randy Dunlap wrote: On Wed, 20 Feb 2008 15:46:32 +0100 Peter Zijlstra wrote: grammar mistakes Thanks Randy! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] ehea: add kdump support

2008-02-20 Thread Jeff Garzik
Thomas Klein wrote: This patch adds kdump support to the ehea driver. As the firmware doesn't free resource handles automatically, the driver has to run an as simple as possible free resource function in case of a crash shutdown. The function iterates over two arrays freeing all resource handles

Re: [PATCH] drivers/net/cs89x0.c: compilation warning fix

2008-02-20 Thread Jeff Garzik
Leonardo Potenza wrote: From: Leonardo Potenza [EMAIL PROTECTED] Suppress the warning message about the 'netcard_portlist' defined but not used. Signed-off-by: Leonardo Potenza [EMAIL PROTECTED] --- When building cs89x0 as a module, the following warning message is generated:

Re: [PATCH] tlan: add static to function definitions

2008-02-20 Thread Jeff Garzik
Harvey Harrison wrote: The forward declarations were already marked static, make the definitions be static as well. Fixes the sparse warnings as well. drivers/net/tlan.c:1403:5: warning: symbol 'TLan_HandleInvalid' was not declared. Should it be static? drivers/net/tlan.c:1435:5: warning:

Re: [2.6 patch] net/phy/mdio_bus.c: fix a check-after-use

2008-02-20 Thread Jeff Garzik
Adrian Bunk wrote: This patch fixes a check-after-use spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 6beeb3ac577d74d72b2f91bd654eecb904c3c17e diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 6e9f619..963630c 100644 ---

tty pid problems

2008-02-20 Thread Oleg Nesterov
(Change the subject, cc Alan) On 02/19, [EMAIL PROTECTED] wrote: On Sun, 17 Feb 2008 21:11:14 MST, Eric W. Biederman said: Oleg Nesterov [EMAIL PROTECTED] writes: On 02/16, Oleg Nesterov wrote: On 02/15, Andrew Morton wrote: : BUG: unable to handle kernel paging request at

Re: tty pid problems

2008-02-20 Thread Oleg Nesterov
(sorry, the previous message was not finished) On 02/20, Oleg Nesterov wrote: (Change the subject, cc Alan) On 02/19, [EMAIL PROTECTED] wrote: On Sun, 17 Feb 2008 21:11:14 MST, Eric W. Biederman said: Oleg Nesterov [EMAIL PROTECTED] writes: On 02/16, Oleg Nesterov wrote: On

Re: pci/pcie/aer/aerdrv_acpi.c: inconsequent NULL checking

2008-02-20 Thread Greg KH
On Wed, Feb 20, 2008 at 09:56:28AM +0200, Adrian Bunk wrote: On Tue, Feb 19, 2008 at 09:47:58PM -0800, Greg KH wrote: On Tue, Feb 19, 2008 at 09:29:02PM +0200, Adrian Bunk wrote: The Coverity checker spotted the following inconsequent NULL checking introduced by commit

[PATCH] (for -mm only) put_pid: make sure we don't free the live pid

2008-02-20 Thread Oleg Nesterov
[PATCH] (for -mm only) put_pid: make sure we don't free the live pid Add the temporary (for -mm only) debugging code to catch the unbalanced put_pid()'s. At least those which can free the live pid. Signed-off-by: Oleg Nesterov [EMAIL PROTECTED] --- MM/kernel/pid.c~2008-02-20

[PATCH 24/37] NFS: Register NFS for caching and retrieve the top-level index

2008-02-20 Thread David Howells
Register NFS for caching and retrieve the top-level cache index object cookie. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/nfs/Makefile|1 + fs/nfs/fscache-index.c | 53 fs/nfs/fscache.h | 35

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-20 Thread Balbir Singh
John Stoffel wrote: Jan == Jan Engelhardt [EMAIL PROTECTED] writes: Jan On Feb 20 2008 20:50, Balbir Singh wrote: John Stoffel wrote: I know this is a pedantic comment, but why the heck is it called such a generic term as Memory Controller which doesn't give any indication of what it does.

Re: tty pid problems

2008-02-20 Thread Alan Cox
*ping* - Any further activity on this one? I got bit by it as well on the very first attempted boot of 25-rc2-mm1, the instant it tried to leave single-user and go multi-user. Valdis, any chance you can try the [PATCH] (for -mm only) put_pid: make sure we don't free the live pid

Re: [PATCH 2.6.24] block2mtd: removing a device and typo fixes

2008-02-20 Thread Jörn Engel
On Wed, 20 February 2008 14:43:39 +, Stephane Chazelas wrote: note that for loop, you have /dev/loop0, /dev/loop1... which makes it a pain to handle For block2mtd, you don't need several device files in /dev, you only need one to pass ioctls down to create mtd devices. That may end

Re: [PATCH 2.6.24] block2mtd: removing a device and typo fixes

2008-02-20 Thread Jörn Engel
On Wed, 20 February 2008 14:36:46 +, Stephane Chazelas wrote: At the moment, when we bind a mtd device to a block device, we don't increase the refcount. When a mtdblock on a block2mtd, the refcount is not increased either (the mtdblock's one is I guess). That is a bug then. Jörn --

[PATCH 1/1] file capabilities: simplify signal check

2008-02-20 Thread Serge E. Hallyn
From bd076c7245d02be0cc01b7c09bd7170ec5946492 Mon Sep 17 00:00:00 2001 From: Serge E. Hallyn [EMAIL PROTECTED] Date: Sun, 17 Feb 2008 20:28:07 -0500 Subject: [PATCH 1/1] file capabilities: simplify signal check Simplify the uid equivalence check in cap_task_kill(). Anyone can kill a process

Re: [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloats a lot

2008-02-20 Thread Jan Engelhardt
On Feb 20 2008 17:27, Patrick McHardy wrote: Striking. How can this even happen? A callsite which calls dev_alloc_skb(n) is just equivalent to __dev_alloc_skb(n, GFP_ATOMIC); which means there's like 4 (or 8 if it's long) bytes more on the stack. For a worst case, count in another

Re: [PATCH 0/2] percpu: Optimize percpu accesses v3

2008-02-20 Thread Thomas Gleixner
On Wed, 20 Feb 2008, Ingo Molnar wrote: * Mike Travis [EMAIL PROTECTED] wrote: This is the generic (non-x86) changes for zero-based per cpu variables. thanks Mike. I've put this into the -testing branch of x86.git. (so that we can see and test the impact of these patches, but they

[PATCH 21/37] NFS: Add comment banners to some NFS functions

2008-02-20 Thread David Howells
Add comment banners to some NFS functions so that they can be modified by the NFS fscache patches for further information. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/nfs/file.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git

Re: [PATCH] Add PCI_DEVICE_TABLE macro

2008-02-20 Thread Greg KH
On Mon, Feb 18, 2008 at 08:34:42AM +0100, Jonas Bonn wrote: And again, what does this buy us? Clarity and simplicity, I hope... there are a bunch of definitions scattered about the kernel that omit the __devinitdata modifier despite the documentation stating that it should always be there.

Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-20 Thread Randy Dunlap
On Wed, 20 Feb 2008 15:46:32 +0100 Peter Zijlstra wrote: Signed-off-by: Peter Zijlstra [EMAIL PROTECTED] --- Documentation/filesystems/Locking | 19 + Documentation/filesystems/vfs.txt | 17 include/linux/buffer_head.h |2 - include/linux/fs.h

Re: [PATCH] splice: fix problem with sys_tee and SPLICE_F_NONBLOCK

2008-02-20 Thread Patrick McManus
On Wed, 2008-02-20 at 10:35 +0100, Jens Axboe wrote: When non-blocking is set, ideally we want to return 0 if there's no hope of anymore data and EAGAIN if trying later may yield some data. So how about this instead? Thank you Jens and Johann. -Patrick -- To unsubscribe from this

Re: [PATCH 09/16] um: use get_personality()

2008-02-20 Thread Jeff Dike
On Wed, Feb 20, 2008 at 07:19:13PM +0800, WANG Cong wrote: Signed-off-by: WANG Cong [EMAIL PROTECTED] Looks good - you should add some sort of changelog though. Jeff -- Work email - jdike at linux dot intel dot com -- To unsubscribe from this list: send the

Re: hdparm-8.2 now available

2008-02-20 Thread Mark Lord
Greg Freemyer wrote: Mark, What kernel level is needed to support the new -N arg? .. I believe it should work with 2.4.0 or newer. But some kernels have a buggy implementation of it. Tried it on a Suse 2.6.22 kernel (possibly not patched with all the current security updates). Failed with:

[PATCH 19/37] CacheFiles: Export things for CacheFiles

2008-02-20 Thread David Howells
Export a number of functions for CacheFiles's use. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/super.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/super.c b/fs/super.c index 88811f6..1133b43 100644 --- a/fs/super.c +++ b/fs/super.c @@ -267,6 +267,7 @@

Re: [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloats a lot

2008-02-20 Thread Patrick McHardy
Jan Engelhardt wrote: On Feb 20 2008 15:47, Ilpo Järvinen wrote: -23668 392 funcs, 104 +, 23772 -, diff: -23668 --- dev_alloc_skb -static inline struct sk_buff *dev_alloc_skb(unsigned int length) -{ - return __dev_alloc_skb(length, GFP_ATOMIC); -} +extern struct sk_buff

Re: [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloats a lot

2008-02-20 Thread Jan Engelhardt
On Feb 20 2008 15:47, Ilpo Järvinen wrote: -23668 392 funcs, 104 +, 23772 -, diff: -23668 --- dev_alloc_skb -static inline struct sk_buff *dev_alloc_skb(unsigned int length) -{ - return __dev_alloc_skb(length, GFP_ATOMIC); -} +extern struct sk_buff *dev_alloc_skb(unsigned int length);

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-20 Thread John Stoffel
Balbir == Balbir Singh [EMAIL PROTECTED] writes: Balbir John Stoffel wrote: I know this is a pedantic comment, but why the heck is it called such a generic term as Memory Controller which doesn't give any indication of what it does. Shouldn't it be something like Memory Quota Controller,

Re: [2.6 patch] make stk_camera_{suspend,resume}() static

2008-02-20 Thread Jaime Velasco Juan
El mar. 19 de feb. de 2008, a las 21:29:08 +0200, Adrian Bunk escribió: This patch makes the needlessly global stk_camera_{suspend,resume}() static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Acked-by: Jaime Velasco Juan [EMAIL PROTECTED] thanks -- To unsubscribe from this list: send

Re: [Bug 10030] Suspend doesn't work when SD card is inserted

2008-02-20 Thread Alan Stern
On Tue, 19 Feb 2008 [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=10030 --- Comment #14 from [EMAIL PROTECTED] 2008-02-19 15:23 --- Thanks a lot for the debugging work! First, the patch triggers, which means that the problem discovered by Alan is

XFS makefile-2.6 lives on

2008-02-20 Thread Jeff Garzik
In current upstream, fs/xfs/Makefile-linux-2.6 is zero bytes, which means 'make distclean' deletes, and git promptly (and properly) squawks about a working tree/index difference. Would somebody please delete this file? Thanks, Jeff -- To unsubscribe from this list: send the line

Re: [PATCH 2.6.24] block2mtd: removing a device and typo fixes

2008-02-20 Thread Stephane Chazelas
2008-02-20 17:30:42 +0100, Jörn Engel: On Wed, 20 February 2008 14:43:39 +, Stephane Chazelas wrote: note that for loop, you have /dev/loop0, /dev/loop1... which makes it a pain to handle For block2mtd, you don't need several device files in /dev, you only need one to pass

Re: Disk schedulers

2008-02-20 Thread Zdenek Kabelac
2008/2/15, Zan Lynx [EMAIL PROTECTED]: On Fri, 2008-02-15 at 15:57 +0100, Prakash Punnoor wrote: On the day of Friday 15 February 2008 Jan Engelhardt hast written: On Feb 14 2008 17:21, Lukas Hejtmanek wrote: Hello, whom should I blame about disk schedulers? Also consider

Re: [PATCH] Add PCI_DEVICE_TABLE macro

2008-02-20 Thread Jeff Garzik
Greg KH wrote: On Mon, Feb 18, 2008 at 08:34:42AM +0100, Jonas Bonn wrote: And again, what does this buy us? Clarity and simplicity, I hope... there are a bunch of definitions scattered about the kernel that omit the __devinitdata modifier despite the documentation stating that it should

Re: pnp_bus_resume(): inconsequent NULL checking

2008-02-20 Thread Bjorn Helgaas
On Tuesday 19 February 2008 05:00:43 pm Rene Herman wrote: On 19-02-08 23:49, Adrian Bunk wrote: The Coverity checker spotted the following inconsequent NULL checking introduced by commit 5d38998ed15b31f524bde9a193d60150af30d916: -- snip -- ... static int

Re: USB regression (and other failures) in 2.6.2[45]* - mostly resolved

2008-02-20 Thread Andrew Buehler
(I suspect that some of the existing CC:s can now be dropped, and others might need to be added if indeed this is worth discussing on kernel lists at all, but I don't know what the protocol on that is so I have left all of them in for the moment.) On 2/20/2008 10:50 AM, Alan Stern wrote: On

Re: [rtc-linux] state of GEN_RTC vs rtc subsystem

2008-02-20 Thread Alessandro Zummo
On Wed, 20 Feb 2008 10:11:23 -0600 Kumar Gala [EMAIL PROTECTED] wrote: Is the functionality provided by drivers/char/gen_rtc.c completely handled by the rtc subsystem in drivers/rtc? I ask for two reasons: 1. should we make it mutually exclusive in Kconfig 2. I've enabled both and get

Re: [PATCH] x86: use explicit timing delay for pit accesses in kernel and pcspkr driver

2008-02-20 Thread H. Peter Anvin
Rene Herman wrote: _Something_ like this would seem to be the only remaining option. It seems fairly unuseful to #ifdef around that switch statement for kernels without support for the earlier families, but if you insist... Only remaining option other than the one we've had all along.

Re: [PATCH] x86: use explicit timing delay for pit accesses in kernel and pcspkr driver

2008-02-20 Thread Rene Herman
On 20-02-08 18:05, H. Peter Anvin wrote: Rene Herman wrote: _Something_ like this would seem to be the only remaining option. It seems fairly unuseful to #ifdef around that switch statement for kernels without support for the earlier families, but if you insist... Only remaining option

Re: [PATCH] correct inconsistent ntp interval/tick_length usage

2008-02-20 Thread Roman Zippel
Hi, On Tue, 19 Feb 2008, john stultz wrote: To better keep with your analogy, you'd have to imagine a scale that only reads in X pound increments. As long as X is fairly small, it should measure everyone's weight fairly well. However, if X is large, like say 50kg, then it won't weigh a 70kg

[UPDATED v2][PATCH 0/6] regulator: voltage and current regulator framework

2008-02-20 Thread Liam Girdwood
Version 2 with thanks to Sam Ravnborg, Mariusz Kozlowski, David Brownell and Laura Lawrence for their comments. This patch series provides a generic framework to allow device drivers to control voltage and current regulators on SoC based devices (e.g. phones, gps, media players). The intention

[PATCH 1/6] regulator: consumer driver regulator control framework.

2008-02-20 Thread Liam Girdwood
This framework provides voltage and current regulator control to allow consumer drivers to control their supply voltages and current levels. The framework is similar to the kernel clock interface in that client or consumer drivers can get() and put() a regulator (like they can with clocks atm).

[PATCH 2/6] regulator: regulator driver interface.

2008-02-20 Thread Liam Girdwood
This interface allows regulator drivers to register their voltage and current regulators with the core. It also has a notifier call chain for propagating regulator events to clients. Signed-off-by: Liam Girdwood [EMAIL PROTECTED] --- include/linux/regulator/regulator-drv.h | 119

[PATCH 3/6] regulator: platform level interface.

2008-02-20 Thread Liam Girdwood
This interface configures a regulator for use within a specific device. It allows for the creation of voltage and current domains (with constraints) for each regulator. Regulator constraints help prevent device damage by providing protection for over voltage or over current events caused by buggy

[PATCH 4/6] regulator: regulator core.

2008-02-20 Thread Liam Girdwood
This patch provides the regulator framework core. The core also provides a sysfs interface for userspace information. Signed-off-by: Liam Girdwood [EMAIL PROTECTED] --- drivers/regulator/reg-core.c | 1049 ++ 1 files changed, 1049 insertions(+), 0

[PATCH 5/6] regulator: regulator framework build.

2008-02-20 Thread Liam Girdwood
This patch adds support to build the regulator core. Signed-off-by: Liam Girdwood [EMAIL PROTECTED] --- drivers/Kconfig|2 ++ drivers/Makefile |1 + drivers/regulator/Kconfig | 32 drivers/regulator/Makefile |9 + 4

[PATCH 6/6] regulator: add maintainers.

2008-02-20 Thread Liam Girdwood
Added Liam Girdwood and Mark Brown as maintainers. Signed-off-by: Liam Girdwood [EMAIL PROTECTED] --- MAINTAINERS |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 082d1ee..1f7d3ce 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

Re: [PATCH 11/11v2] ata: fix sparse warnings in pata_legacy.c

2008-02-20 Thread Jeff Garzik
Harvey Harrison wrote: Use ld_qdi and ld_winbond to avoid shadowing static int variables qdi and winbond. The ld_ prefix refers to legacy_data. drivers/ata/pata_legacy.c:777:21: warning: symbol 'qdi' shadows an earlier one drivers/ata/pata_legacy.c:128:12: originally declared here

Re: [PATCH] libata: Register for dock events when the drive is inside a dock station

2008-02-20 Thread Jeff Garzik
Holger Macht wrote: On Thu 14. Feb - 13:40:48, Holger Macht wrote: If a device/bay is inside a docking station, we need to register for dock events additionally to bay events. If a dock event occurs, the dock driver will call the appropriate handler (ata_acpi_ap_notify() or

[PATCH] do_task_stat: don't take rcu_read_lock()

2008-02-20 Thread Oleg Nesterov
(depends on [PATCH 1/2] lock_task_sighand: add rcu lock/unlock, http://marc.info/?l=linux-kernelm=120335433821564) lock_task_sighand() was changed, and do_task_stat() doesn't need rcu_read_lock any longer. sighand-siglock protects all interesting fields. Except: it doesn't protect -tty-pgrp,

Re: [PATCH 5/6] regulator: regulator framework build.

2008-02-20 Thread Sam Ravnborg
diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile new file mode 100644 index 000..3f70871 --- /dev/null +++ b/drivers/regulator/Makefile @@ -0,0 +1,9 @@ +# +# Makefile for regulator drivers. +# + +obj-$(CONFIG_REGULATOR) += reg-core.o + Replace this +ifeq

[PATCH] ata: use clamp_t macro to avoid sparse warnings

2008-02-20 Thread Harvey Harrison
Nesting min_t/max_t macros produces many shadowed variable warnings due to use of __x. Add a clamp_t macro to linux/kernel.h and use it in the FIT macro. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- include/linux/kernel.h |9 + include/linux/libata.h |2 +- 2 files

Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-20 Thread Jeff Chua
On Feb 21, 2008 1:28 AM, Linus Torvalds [EMAIL PROTECTED] wrote: Try suspend-and-resume without X. Works without those two functions. Also, try it on one of the more modern laptops - even *with* X. Again, still works. Tested on Lenovo X60s. Basically, the kernel wants to be able to do what

Re: [PATCH] capabilities: implement per-process securebits

2008-02-20 Thread Serge E. Hallyn
Quoting Andrew G. Morgan ([EMAIL PROTECTED]): -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andrew Here is the patch to add per-process securebits again. This version includes Serge's argument type fix (thanks), but is otherwise unchanged from the one posted a couple of weeks back. It is

Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-20 Thread Jeff Chua
On Feb 20, 2008 2:19 PM, Jeff Chua I'll try the idle=poll to see if that works and will try some printk I don't know what exactly the i915_suspend() and i915_resume() are supposed to do because it works better without them. After inserting return 0; right at the top of those two

Re: [PATCH] ata: replace macro with static inline in libata.h

2008-02-20 Thread Jeff Garzik
Harvey Harrison wrote: Avoid ~70 sparse warnings like: drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier one drivers/ata/pata_ali.c:176:14: originally declared here Due to nesting min_t macro inside max_t macro which both use a __x identifier internally. Signed-off-by:

Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-20 Thread Jeff Chua
On Feb 21, 2008 1:17 AM, Jeff Chua [EMAIL PROTECTED] wrote: On Feb 20, 2008 2:19 PM, Jeff Chua I'll try the idle=poll to see if that works and will try some printk Tried idle=poll but it has not effect. Thanks, Jeff. -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-20 Thread Linus Torvalds
On Thu, 21 Feb 2008, Jeff Chua wrote: After inserting return 0; right at the top of those two functions, suspend (and power-off properly), and resume (without green screen) works just fine. I would like to know what they're for. Try suspend-and-resume without X. Also, try it on one of

Re: 2.6.25-rc[1,2]: failed to setup dm-crypt key mapping

2008-02-20 Thread Herbert Xu
On Wed, Feb 20, 2008 at 12:23:21PM +0100, Milan Broz wrote: It seems that some module dependency was lost, dm-crypt with async crypto depends now on crypto_blkcipher module for this configuration. Herbert, any following change required for dm-crypt or it is only crypto subsystem issue?

Re: Improve init/Kconfig help descriptions [PATCH 6/9]

2008-02-20 Thread serge
Quoting Nick Andrew ([EMAIL PROTECTED]): On Tue, Feb 19, 2008 at 06:04:57PM -0800, Paul Menage wrote: On Feb 19, 2008 7:12 AM, Nick Andrew [EMAIL PROTECTED] wrote: config CGROUPS [...] + When enabled, a new filesystem type cgroup is available + and can be mounted to

[PATCH] Fix a compile warning under gcc-4.2.3.

2008-02-20 Thread Joshua Roys
sound/core/init.c: In function ‘snd_card_disconnect’: sound/core/init.c:307: warning: the address of ‘snd_shutdown_f_ops’ will always evaluate as ‘true’ Signed-off-by: Joshua Roys [EMAIL PROTECTED] --- sound/core/init.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-20 Thread Adrian Bunk
On Wed, Feb 20, 2008 at 10:42:35AM -0500, Theodore Tso wrote: On Wed, Feb 20, 2008 at 04:38:52PM +0100, Stefan Richter wrote: Two things may largely eliminate the need for parallel branches. 1. Do infrastructure changes and whole tree wide refactoring etc. in a compatible manner with a

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-20 Thread Andi Kleen
OK, I'll queue a patch and try to explain various terms used by resource management. Don't make it too verbose or nobody will read it. It should be more like a one paragraph abstract on a scientific paper about the linux memory controller. But I think it should include some variant of the

Re: USB regression (and other failures) in 2.6.2[45]* - mostly resolved

2008-02-20 Thread Alan Stern
On Wed, 20 Feb 2008, Andrew Buehler wrote: What do you mean by does not see the drive? Its detect-hardware-and-report mode shows a HD size of 0 (which is what it has showed in cases where the kernel has not detected the drive), its detect-partitions-and-report mode shows no partitions and

Re: [PATCH 2.6.24] block2mtd: removing a device and typo fixes

2008-02-20 Thread Stephane Chazelas
2008-02-20 18:22:50 +0100, Jörn Engel: On Wed, 20 February 2008 17:02:31 +, Stephane Chazelas wrote: sorry, I wasn't very clear. With loop, you're doing an ioctl() to /dev/loopx so that /dev/loopx become a block device associated with a given file. Applying that strictly to

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-20 Thread Ray Lee
On Wed, Feb 20, 2008 at 7:20 AM, Balbir Singh [EMAIL PROTECTED] wrote: John Stoffel wrote: I know this is a pedantic comment, but why the heck is it called such a generic term as Memory Controller which doesn't give any indication of what it does. Shouldn't it be something like

Re: [PATCH 2.6.24] block2mtd: removing a device and typo fixes

2008-02-20 Thread Jörn Engel
On Wed, 20 February 2008 17:02:31 +, Stephane Chazelas wrote: sorry, I wasn't very clear. With loop, you're doing an ioctl() to /dev/loopx so that /dev/loopx become a block device associated with a given file. Applying that strictly to block2mtd wouldn't make sense. At the moment,

Re: [PATCH 2.6.25-rc2 3/9] config: Improve init/Kconfig help descriptions - namespaces

2008-02-20 Thread serge
Quoting Nick Andrew ([EMAIL PROTECTED]): Rewrite the help descriptions for clarity, accuracy and consistency. Kernel config options affected: - NAMESPACES - UTS_NS - IPC_NS - USER_NS - PID_NS Signed-off-by: Nick Andrew [EMAIL PROTECTED] --- Here's try #2 at the 3rd patch

[git patches] libata fixes

2008-02-20 Thread Jeff Garzik
Note: Tejun's change is a feature addition, but one that is IMO important for debugging and serious-bug workarounds. It's self-contained and should not affect anyone not using the new parm. Please pull from 'upstream-linus' branch of

Re: Plans for mISDN? Was: [PATCH 00/14] [ISDN] ...

2008-02-20 Thread Andi Kleen
mISDN has two problems, which are of course interrelated: a) complete lack of documentation for the in-kernel driver interface (equivalent of Documentation/isdn/INTERFACE) Most subsystems in the kernel would disqualify under that rule Did you ever look for full documentation on how to

Re: XFS makefile-2.6 lives on

2008-02-20 Thread Sam Ravnborg
Linus, please do so. It is too annoying to await next pull request from xfs. Sam On Wed, Feb 20, 2008 at 11:58:48AM -0500, Jeff Garzik wrote: In current upstream, fs/xfs/Makefile-linux-2.6 is zero bytes, which means 'make distclean' deletes, and git promptly (and properly)

Re: [PATCH 2.6.24] block2mtd: removing a device and typo fixes

2008-02-20 Thread Stephane Chazelas
2008-02-20 17:42:27 +0100, Jörn Engel: On Wed, 20 February 2008 14:36:46 +, Stephane Chazelas wrote: At the moment, when we bind a mtd device to a block device, we don't increase the refcount. When a mtdblock on a block2mtd, the refcount is not increased either (the mtdblock's one is

[PATCH] [kvm-devel] build #365 issue for v2.6.25-rc2-342-g5d9c4a7 in ./arch/x86/kvm/kvm.ko

2008-02-20 Thread Randy Dunlap
On Wed, 20 Feb 2008 16:07:03 +0200 Avi Kivity wrote: Looks like KVM conflicts with CONFIG_VOYAGER... Attached patch should fix. Subject: x86: disable KVM on Voyager Most classic Pentiums don't have hardware virtualization extension, and building kvm with voyager generates spurious

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-20 Thread Andi Kleen
I know this is a pedantic comment, but why the heck is it called such a generic term as Memory Controller which doesn't give any indication of what it does. I don't think it's pedantic. I would agree with you in fact that the Kconfig description is not very helpful, even with my warning

Re: [Bug 10030] Suspend doesn't work when SD card is inserted

2008-02-20 Thread Pierre Ossman
On Wed, 20 Feb 2008 11:42:56 -0500 (EST) Alan Stern [EMAIL PROTECTED] wrote: --- Comment #14 from [EMAIL PROTECTED] 2008-02-19 15:23 --- Thanks a lot for the debugging work! First, the patch triggers, which means that the problem discovered by Alan is troubling us.

[git patches] net driver fixes

2008-02-20 Thread Jeff Garzik
Note: this is based off of Linus's latest commit (5d9c4a7de64d398604a978d267a6987f1f4025b7), since all my previous submissions are now upstream (thanks!). Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-davem to receive

Re: 2.6.25-rc2: ohci1394 problem

2008-02-20 Thread Thomas Meyer
Stefan Richter schrieb: Thomas Meyer wrote at LKML: Hi. With 2.6.25-rc2 my kernel log consists mainly of: ohci1394: fw-host0: Unhandled interrupt(s) 0xfc7cfe0c ohci1394: fw-host0: Unrecoverable error! ohci1394: fw-host0: Async Rsp Tx Context died: ctrl[f0002a00] cmdptr[f0002a00] ohci1394:

[PATCH 1/2] FRV: Drop the .data.idt section for FRV

2008-02-20 Thread David Howells
From: David Howells [EMAIL PROTECTED] There is no .data.idt section for FRV, so drop it from the linker script. Signed-off-by: David Howells [EMAIL PROTECTED] --- arch/frv/kernel/vmlinux.lds.S |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git

Re: very poor ext3 write performance on big filesystems?

2008-02-20 Thread David Rees
On Wed, Feb 20, 2008 at 2:57 AM, Jan Engelhardt [EMAIL PROTECTED] wrote: But GNU tar does not handle acls and xattrs. So back to rsync/cp/mv. Huh? The version of tar on my Fedora 8 desktop (tar-1.17-7) does. Just add the --xattrs option (which turns on --acls and --selinux). -Dave -- To

Re: 2.6.25-rc2: ohci1394 problem

2008-02-20 Thread Stefan Richter
Thomas Meyer wrote: Stefan Richter schrieb: Thomas Meyer wrote at LKML: With 2.6.25-rc2 my kernel log consists mainly of: ohci1394: fw-host0: Unhandled interrupt(s) 0xfc7cfe0c There are junk interrupt events sent to ohci1394's IRQ handler. ... Do you have any hardware attached to the

Re: [QUESTION] FRV: linking error?

2008-02-20 Thread Cyrill Gorcunov
[David Howells - Wed, Feb 20, 2008 at 01:01:05PM +] | Cyrill Gorcunov [EMAIL PROTECTED] wrote: | | being see over vmlinux.lds for FRV architecture I found the string: | | . = ALIGN(4096); | .data.page_aligned : { *(.data.idt) } | | though the PAGE_SIZE is 16K. Can't figure out

Re: [QUESTION] FRV: linking error?

2008-02-20 Thread Cyrill Gorcunov
[David Howells - Wed, Feb 20, 2008 at 06:13:15PM +] | Cyrill Gorcunov [EMAIL PROTECTED] wrote: | | Sam, maybe we should just eliminate this section at least for FRV? | | You should have a patch in your inbox to do just that. | | David | Thanks David! I've got them all. I think Sam will

Re: [QUESTION] FRV: linking error?

2008-02-20 Thread David Howells
Cyrill Gorcunov [EMAIL PROTECTED] wrote: Sam, maybe we should just eliminate this section at least for FRV? You should have a patch in your inbox to do just that. David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: very poor ext3 write performance on big filesystems?

2008-02-20 Thread Jan Engelhardt
On Feb 20 2008 09:44, David Rees wrote: On Wed, Feb 20, 2008 at 2:57 AM, Jan Engelhardt [EMAIL PROTECTED] wrote: But GNU tar does not handle acls and xattrs. So back to rsync/cp/mv. Huh? The version of tar on my Fedora 8 desktop (tar-1.17-7) does. Just add the --xattrs option (which turns on

[PATCH 1/2] FRV: Drop the .data.idt section for FRV

2008-02-20 Thread David Howells
From: David Howells [EMAIL PROTECTED] There is no .data.idt section for FRV, so drop it from the linker script. Signed-off-by: David Howells [EMAIL PROTECTED] --- arch/frv/kernel/vmlinux.lds.S |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git

Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-20 Thread Linus Torvalds
On Thu, 21 Feb 2008, Jeff Chua wrote: Works without those two functions. Ahh. You're using the BIOS to re-initialize your video, aren't you? If STR works without X, then you have something else resuming graphics, and that may be what then interacts badly with the fact that the kernel

Re: 2.6.25-rc[1,2]: failed to setup dm-crypt key mapping

2008-02-20 Thread Milan Broz
Herbert Xu wrote: On Wed, Feb 20, 2008 at 12:23:21PM +0100, Milan Broz wrote: It seems that some module dependency was lost, dm-crypt with async crypto depends now on crypto_blkcipher module for this configuration. Herbert, any following change required for dm-crypt or it is only crypto

[PATCH 2/2] FRV: Change the timerfd syscalls to be the same as i386

2008-02-20 Thread David Howells
From: David Howells [EMAIL PROTECTED] Change the FRV timerfd syscalls to be the same as i386 timerfd syscalls. Signed-off-by: David Howells [EMAIL PROTECTED] --- arch/frv/kernel/entry.S |4 +++- include/asm-frv/unistd.h |4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff

Re: [RESEND] [PATCH] fix invalidate_inode_pages2_range not to clear ret

2008-02-20 Thread Jeff Moyer
Hisashi Hifumi [EMAIL PROTECTED] writes: Hi Andrew. DIO invalidates page cache through invalidate_inode_pages2_range(). invalidate_inode_pages2_range() sets ret=-EIO when invalidate_complete_page2() fails, but this ret is cleared if do_launder_page() succeed on a page of next index. In

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-20 Thread Dave Hansen
On Mon, 2008-02-18 at 11:00 +0100, Jan-Bernd Themann wrote: Dave Hansen [EMAIL PROTECTED] wrote on 15.02.2008 17:55:38: I've been thinking about that, and I don't think you really *need* to keep a comprehensive map like that. When the memory is in a particular configuration (range of

Re: linux-next: first tree

2008-02-20 Thread Randy Dunlap
to lkml. I hope I have addressed this issue by tagging each tree with its date i.e. todays was next-20080220. Also will you be producing any tarballs for these releases? If so I would say they would definatly need to be against some common base, like against the nearest official tag below

Re: [QUESTION] FRV: linking error?

2008-02-20 Thread Cyrill Gorcunov
[Sam Ravnborg - Wed, Feb 20, 2008 at 02:14:42PM +0100] | On Wed, Feb 20, 2008 at 01:01:05PM +, David Howells wrote: | Cyrill Gorcunov [EMAIL PROTECTED] wrote: | | being see over vmlinux.lds for FRV architecture I found the string: | | . = ALIGN(4096); | .data.page_aligned : {

Re: 2.6.25-rc[1,2]: failed to setup dm-crypt key mapping

2008-02-20 Thread Herbert Xu
On Wed, Feb 20, 2008 at 06:47:58PM +0100, Milan Broz wrote: I just tested one affected configuration and problem was in missing chainiv.ko module on ramdisk. Ah OK. We probably should merge chainiv into the blkcipher module too since it's the default IV generator. I'll take care of it.

Re: arch/x86/kernel/vsyscall_64.c: overeager NOP of syscalls

2008-02-20 Thread Thomas Gleixner
Arne, On Wed, 20 Feb 2008, Arne Georg Gleditsch wrote: I'm looking at 2.6.25-rc2. vsyscall_sysctl_change contains code to NOP out the actual system call instructions of the vsyscall page when vsyscall64 is enabled. This seems to interact badly with the fallback code in do_vgettimeofday

Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-20 Thread Jeff Chua
On Feb 21, 2008 1:52 AM, Linus Torvalds [EMAIL PROTECTED] wrote: Ahh. You're using the BIOS to re-initialize your video, aren't you? I don't know. Just pure simple s2ram without any options. Let's try to narrow it down to what the interaction is. Are you using something like

<    5   6   7   8   9   10   11   12   13   14   >