Re: [dm-devel] [PATCH] dm: verity support data device offset (Linux 3.4.7)

2012-08-08 Thread Milan Broz
On 08/08/2012 08:46 PM, Mikulas Patocka wrote: > The problem with the patch is that it changes interface to the userspace > tool. The userspace tool veritysetup already exists in recent cryptsetup > package, so we can't change the interface - you should change the patch so > that the starting d

[PATCH v2 18/41] TTY: pty, switch to tty_alloc_driver

2012-08-08 Thread Jiri Slaby
Switch to the new driver allocation interface, as this is one of the special call-sites. Here, we need TTY_DRIVER_DYNAMIC_ALLOC to not allocate tty_driver->ports, cdevs and potentially other structures because we reserve too many lines in pty. Instead, it provides the tty_port<->tty_struct link in

[PATCH v2 21/41] TTY: move cdev_add to tty_register_device

2012-08-08 Thread Jiri Slaby
We need the /dev/ node not to be available before we call tty_register_device. Otherwise we might race with open and tty_struct->port might not be available at that time. This is not an issue now, but would be a problem after "TTY: use tty_port_register_device" is applied. Signed-off-by: Jiri Sla

[PATCH v2 20/41] TTY: add support for unnumbered device nodes

2012-08-08 Thread Jiri Slaby
This allows drivers like ttyprintk to avoid hacks to create an unnumbered node in /dev. It used to set TTY_DRIVER_DYNAMIC_DEV in flags and call device_create on its own. That is incorrect, because TTY_DRIVER_DYNAMIC_DEV may be set only if tty_register_device is called explicitly. Signed-off-by: Ji

[PATCH v2 19/41] TTY: move allocations to tty_alloc_driver

2012-08-08 Thread Jiri Slaby
So now, that we have flags and know everything needed, keep a promise and move all the tables and ports allocation from tty_register_driver to tty_alloc_driver. Not only that it makes sense, but we need this for tty_port_link_device which needs tty_driver->ports but is to be called before tty_regi

Re: [PATCH] staging:ccg: Fix missing brackets for sizeof (found by sparse).

2012-08-08 Thread Jesper Juhl
On Wed, 8 Aug 2012, Marek Belisko wrote: > Fix following: > WARNING: sizeof fsg should be sizeof(fsg) > + memset(&fsg, 0, sizeof fsg); > > Signed-off-by: Marek Belisko > --- > drivers/staging/ccg/ccg.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/stag

[PATCH] staging:ccg: Fix missing brackets for sizeof (found by sparse).

2012-08-08 Thread Marek Belisko
Fix following: WARNING: sizeof fsg should be sizeof(fsg) + memset(&fsg, 0, sizeof fsg); Signed-off-by: Marek Belisko --- drivers/staging/ccg/ccg.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccg/ccg.c b/drivers/staging/ccg/ccg.c index 6a7aab8..81a

Re: [PATCH 18/41] TTY: pty, switch to tty_alloc_driver

2012-08-08 Thread Jiri Slaby
On 08/08/2012 05:37 PM, Alan Cox wrote: > On Tue, 7 Aug 2012 21:47:43 +0200 > Jiri Slaby wrote: > >> Switch to the new driver allocation interface, as this is one of the >> special call-sites. Here, we need TTY_DRIVER_EXCESSIVE_LINES to not >> allocate tty_driver->ports, cdevs and potentially ot

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Eric Dumazet
On Wed, 2012-08-08 at 15:59 -0400, Eric Paris wrote: > Seems wrong. We shouldn't ever need ifdef CONFIG_SECURITY in core > code. Sure but it seems include file misses an accessor for this. We could add it on a future cleanup patch, as Paul mentioned. > Ifndef CONF_SECURITY then security_sk_a

Re: [PATCH] sched: fix divide by zero at {thread_group,task}_times

2012-08-08 Thread Peter Zijlstra
On Wed, 2012-08-08 at 21:50 +0200, Mike Galbraith wrote: > 32bit built do_div() > and div64_u64() both sucked equally compared to 64bit /me peeks at div64_u64 fallback implementation and sees why, it still does a single div, it does some neat fls tricks. Ok, no point in avoiding this then.. I

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Eric Dumazet
On Wed, 2012-08-08 at 12:49 -0700, John Stultz wrote: > I can't comment on the patch itself, but I tested it against Linus' HEAD > and it seems to resolve the oops on shutdown for me. OK, thanks ! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mess

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Eric Dumazet
On Wed, 2012-08-08 at 15:50 -0400, Paul Moore wrote: > Yep. I was just trying to see if there was a way we could avoid having to > make it conditional on CONFIG_SECURITY, but I think this is a better approach > than the alternatives. > > I'm also looking into making sure we get a sane LSM labe

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Eric Paris
On Wed, Aug 8, 2012 at 3:38 PM, Eric Dumazet wrote: > On Wed, 2012-08-08 at 15:26 -0400, Paul Moore wrote: > diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c > index ba39a52..027a331 100644 > --- a/net/ipv4/ip_output.c > +++ b/net/ipv4/ip_output.c > @@ -1524,6 +1524,10 @@ void ip_send_uni

Re: rcu stalls seen with numasched_v2 patches applied.

2012-08-08 Thread Peter Zijlstra
On Tue, 2012-08-07 at 22:49 +0530, Srikar Dronamraju wrote: > Are you referring to this the commit 158e1645e (trim task_work: get rid of > hlist) No, to something like the below.. > I am also able to reproduce this on another 8 node machine too. Ship me one ;-) > Just to update, I had to rever

Re: [PATCH 2/2] floppy: error handling fixes on do_floppy_init

2012-08-08 Thread Vivek Goyal
On Wed, Aug 08, 2012 at 03:24:53PM -0300, Herton Ronaldo Krzesinski wrote: > While looking at commit 3f9a5aa ("floppy: Cleanup disk->queue before > caling put_disk() if add_disk() was never called") I noticed some > problems with the error handling and cleanup: > > * missing cleanup (put_disk) if

Re: [PATCH] Input: omap4-keypad - don't leak in omap4_keypad_probe()

2012-08-08 Thread Jesper Juhl
On Wed, 8 Aug 2012, Dmitry Torokhov wrote: > On Wednesday, August 08, 2012 09:36:51 PM Jesper Juhl wrote: > > On Wed, 8 Aug 2012, Sachin Kamat wrote: > > > On 7 August 2012 23:46, Jesper Juhl wrote: > > > > If omap4_keypad_parse_dt() does not return 0 (zero) in > > > > omap4_keypad_probe() we wil

Re: [PATCH v2] staging: gdm72xx: fix reference counting in gdm_wimax_event_init

2012-08-08 Thread Ben Chan
Hi, Does patch v2 make sense? Thanks, Ben On Wed, Jul 25, 2012 at 6:53 AM, Ben Chan wrote: > Hi Devendra, > > Thanks for cleaning up the driver. If I understand the code > correctly, the original author wanted to initialize wm_event once and > reuse it for multiple devices, and thus reference

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Paul Moore
On Wednesday, August 08, 2012 09:38:21 PM Eric Dumazet wrote: > On Wed, 2012-08-08 at 15:26 -0400, Paul Moore wrote: > > On Wednesday, August 08, 2012 12:14:42 PM John Stultz wrote: > > > So I bisected this down and it seems to be the following commit: > > > > > > commit be9f4a44e7d41cee50ddb5f038

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread John Stultz
On 08/08/2012 12:38 PM, Eric Dumazet wrote: On Wed, 2012-08-08 at 15:26 -0400, Paul Moore wrote: It looks the like there is a bug in ip_send_unicast_reply() which uses a inet_sock/sock struct which does not have the LSM data properly initialized. I'll put together a patch shortly. Something li

Re: [PATCH] sched: fix divide by zero at {thread_group,task}_times

2012-08-08 Thread Mike Galbraith
On Wed, 2012-08-08 at 11:27 +0200, Stanislaw Gruszka wrote: > On architectures where cputime_t is 64 bit type, is possible to trigger > divide by zero on do_div(temp, (__force u32) total) line, if total is a > non zero number but has lower 32 bit's zeroed. Removing casting is not > a good solution

Re: [PATCH] Input: omap4-keypad - don't leak in omap4_keypad_probe()

2012-08-08 Thread Dmitry Torokhov
On Wednesday, August 08, 2012 09:36:51 PM Jesper Juhl wrote: > On Wed, 8 Aug 2012, Sachin Kamat wrote: > > On 7 August 2012 23:46, Jesper Juhl wrote: > > > If omap4_keypad_parse_dt() does not return 0 (zero) in > > > omap4_keypad_probe() we will leak the memory we allocated for > > > 'keypad_data'

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Eric Dumazet
On Wed, 2012-08-08 at 15:26 -0400, Paul Moore wrote: > On Wednesday, August 08, 2012 12:14:42 PM John Stultz wrote: > > So I bisected this down and it seems to be the following commit: > > > > commit be9f4a44e7d41cee50ddb5f038fc2391cbbb4046 > > Author: Eric Dumazet > > Date: Thu Jul 19 07:34:03

Re: [PATCH] Input: omap4-keypad - don't leak in omap4_keypad_probe()

2012-08-08 Thread Jesper Juhl
On Wed, 8 Aug 2012, Sachin Kamat wrote: > On 7 August 2012 23:46, Jesper Juhl wrote: > > If omap4_keypad_parse_dt() does not return 0 (zero) in > > omap4_keypad_probe() we will leak the memory we allocated for > > 'keypad_data' with kzalloc() when we return and the variable goes out > > of scope.

[PATCH] time: Improve sanity checking of timekeeping inputs

2012-08-08 Thread John Stultz
Thomas, Ingo, Here's a fix against tip/timers/urgent that addresses timekeeping edge cases detected by both a bad BIOS and system fuzzing w/ trinity. Thanks to Sasha Levin and CAI Qian for finding and reporting these! Let me know if you have any tweaks you want to see. thanks -john Unexp

PROBLEM: snd_hda_intel bug during boot

2012-08-08 Thread Alexei Kornienko
Seems like I have a bug in audio driver on my laptop. Cause of this I don't have any sound card detected. Please find more details below: ** Version: Linux version 3.2.0-29-generic-pae (buildd@roseapple) (gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) ) #46-Ubuntu SMP Fri Jul 27 17:25:43 UTC 201

Re: [PATCH] rndis_wlan: Fix potential memory leak in update_pmkid()

2012-08-08 Thread Jussi Kivilinna
Quoting Alexey Khoroshilov : Do not leak memory by updating pointer with potentially NULL realloc return value. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Thanks! Acked-by: Jussi Kivilinna --- drivers/net/wireless/rndis_wlan.c |

Re: [PATCH 02/41] TTY: 68328serial, fix compilation

2012-08-08 Thread Jiri Slaby
On 08/08/2012 05:24 PM, Alan Cox wrote: > On Tue, 7 Aug 2012 21:47:27 +0200 > Jiri Slaby wrote: > >> tty_struct->termios is no longer a pointer. This was changed recently >> by "tty: move the termios object into the tty". But 68328serial was >> not changed, so we now have a compilation error: >>

Re: [PATCH] pci: Account for virtual buses in pci_acs_path_enabled

2012-08-08 Thread Don Dutile
On 08/08/2012 11:24 AM, Alex Williamson wrote: On Tue, 2012-08-07 at 23:00 -0700, Bjorn Helgaas wrote: On Tue, Aug 7, 2012 at 2:50 PM, Don Dutile wrote: On 08/06/2012 04:47 PM, Bjorn Helgaas wrote: On Sun, Aug 5, 2012 at 11:55 PM, Alex Williamson wrote: On Sun, 2012-08-05 at 23:30 -0600

Re: [PATCH] PM QoS: Add a metric : Bus Throughput.

2012-08-08 Thread Rafael J. Wysocki
On Wednesday, August 08, 2012, Jonghwa Lee wrote: > Bus throughput metric is added to PM QoS in order to control the > frequency of memory interfaces and busses with PM QoS. > > Signed-off-by: Jonghwa Lee > Signed-off-by: Kyungmin Park I said some time ago I didn't want any new global PM QoS cl

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Eric Dumazet
On Wed, 2012-08-08 at 12:14 -0700, John Stultz wrote: > On 08/07/2012 03:37 PM, John Stultz wrote: > > On 08/07/2012 03:17 PM, Serge E. Hallyn wrote: > >> Quoting Paul Moore (p...@paul-moore.com): > >>> On Tue, Aug 7, 2012 at 5:58 PM, John Stultz > >>> wrote: > On 08/07/2012 02:50 PM, Paul M

Re: [PATCH 1/2] ARM: build ssi-fiq.S in ARM mode to prevent CONFIG_THUMB2_KERNEL build breakage

2012-08-08 Thread Sascha Hauer
On Wed, Aug 08, 2012 at 12:32:39PM -0500, Matt Sealey wrote: > On Wed, Aug 8, 2012 at 1:55 AM, Sascha Hauer wrote: > >> .text > >> + .arm > >> .global imx_ssi_fiq_start > >> .global imx_ssi_fiq_end > >> .global imx_ssi_fiq_base >

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread Paul Moore
On Wednesday, August 08, 2012 12:14:42 PM John Stultz wrote: > So I bisected this down and it seems to be the following commit: > > commit be9f4a44e7d41cee50ddb5f038fc2391cbbb4046 > Author: Eric Dumazet > Date: Thu Jul 19 07:34:03 2012 + > > ipv4: tcp: remove per net tcp_sock > > >

Re: [PATCH 11/11] pm/drivers: fix use of SIMPLE_DEV_PM_OPS

2012-08-08 Thread Rafael J. Wysocki
On Wednesday, August 08, 2012, Arnd Bergmann wrote: > On Wednesday 08 August 2012, Takashi Iwai wrote: > > At Wed, 8 Aug 2012 16:22:29 +, > > Arnd Bergmann wrote: > > > > Laxman already posted a patch for this, which I'm hoping will make it > > > > into 3.6, through the I2C tree. > > > > > > >

Re: do_IRQ: 1.55 No irq handler for vector (irq -1)

2012-08-08 Thread Suresh Siddha
On Wed, 2012-08-08 at 13:04 +0200, Borislav Petkov wrote: > On Wed, Aug 08, 2012 at 10:58:37AM +0200, Robert Richter wrote: > > On 07.08.12 15:39:07, Suresh Siddha wrote: > > > Boris, Robert, can you check if the below patch makes both of your > > > systems happy again (essentially not allowing the

Re: [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500

2012-08-08 Thread Arnd Bergmann
On Wednesday 08 August 2012, Stephen Warren wrote: > I think that's all just: > > module_platform_driver(vt8500_gpio_driver); > > (except that _init uses platform_driver_probe() rather than > platform_driver_register(), which seems unusual. I guess that explains > the of_find_matching_node() abov

Re: [PATCH] netvm: check for page == NULL when propogating the skb->pfmemalloc flag

2012-08-08 Thread Rik van Riel
On 08/07/2012 04:55 AM, Mel Gorman wrote: Commit [c48a11c7: netvm: propagate page->pfmemalloc to skb] is responsible for the following bug triggered by a xen network driver [1.908592] BUG: unable to handle kernel NULL pointer dereference at 0010 [1.908643] IP: [] xennet_poll

Re: [PATCH] perf: Add a new sort order: SORT_INCLUSIVE (v6)

2012-08-08 Thread Arun Sharma
On 3/30/12 10:43 PM, Arun Sharma wrote: [ Meant to include v6 ChangeLog as well. Technical difficulties.. ] v6 ChangeLog: rebased to tip:perf/core and fixed a minor problem in computing the total period in hists__remove_entry_filter(). Needed to use period_self instead of period. This patch b

Re: NULL pointer dereference in selinux_ip_postroute_compat

2012-08-08 Thread John Stultz
On 08/07/2012 03:37 PM, John Stultz wrote: On 08/07/2012 03:17 PM, Serge E. Hallyn wrote: Quoting Paul Moore (p...@paul-moore.com): On Tue, Aug 7, 2012 at 5:58 PM, John Stultz wrote: On 08/07/2012 02:50 PM, Paul Moore wrote: On Tue, Aug 7, 2012 at 2:12 PM, John Stultz wrote: Hi, With

Re: [PATCH 11/11] pm/drivers: fix use of SIMPLE_DEV_PM_OPS

2012-08-08 Thread Arnd Bergmann
On Wednesday 08 August 2012, Takashi Iwai wrote: > At Wed, 8 Aug 2012 16:22:29 +, > Arnd Bergmann wrote: > > > Laxman already posted a patch for this, which I'm hoping will make it > > > into 3.6, through the I2C tree. > > > > > > http://www.spinics.net/lists/linux-i2c/msg09359.html > > > > O

Re: [PATCH 01/11] ARM: topology: mark init_cpu_topology as __init

2012-08-08 Thread Arnd Bergmann
On Wednesday 08 August 2012, Stephen Boyd wrote: > > On 08/08/12 07:47, Arnd Bergmann wrote: > > The init_cpu_topology function can be put into the __init section > > and discarded after boot, because it is only called from > > smp_prepare_cpus, which is also marked __init. This was reported > > b

Re: [PATCH 3/6] ARM: sa1100: include asm/io.h in hackkit leds code

2012-08-08 Thread Arnd Bergmann
On Wednesday 08 August 2012, Russell King - ARM Linux wrote: > On Wed, Aug 08, 2012 at 02:54:50PM +0200, Arnd Bergmann wrote: > > The sa1100 definition of the io_p2v macro has changed in v3.6, and this one > > file stopped working because of that. > > > > Without this patch, building hackkit_defco

Re: [PATCH 04/11] ARM: ux500: really kill snowball_of_platform_devs

2012-08-08 Thread Arnd Bergmann
On Wednesday 08 August 2012, Lee Jones wrote: > On Wed, Aug 08, 2012 at 04:47:21PM +0200, Arnd Bergmann wrote: > > Commit fc67a597a "ARM: ux500: Remove temporary snowball_of_platform_devs > > enablement structure" removed the only user of this variable, but did > > not actually remove the array its

[RFC PATCH 0/5] Improve hugepage allocation success rates under load V2

2012-08-08 Thread Mel Gorman
Changelog since V1 o Dropped kswapd related patch, basically a no-op and regresses if fixed (minchan) o Expanded changelogs a little Allocation success rates have been far lower since 3.4 due to commit [fe2c2a10: vmscan: reclaim at order 0 when compaction is enabled]. This commit was introduced f

[PATCH 2/5] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-08 Thread Mel Gorman
If allocation fails after compaction then compaction may be deferred for a number of allocation attempts. If there are subsequent failures, compact_defer_shift is increased to defer for longer periods. This patch uses that information to scale the number of pages reclaimed with compact_defer_shift

[PATCH 4/5] mm: have order > 0 compaction start off where it left

2012-08-08 Thread Mel Gorman
From: Rik van Riel This commit is already upstream as [7db8889a: mm: have order > 0 compaction start off where it left]. It's included in this series to provide context to the next patch as the series is based on 3.5. Order > 0 compaction stops when enough free pages of the correct page order ha

[PATCH 3/5] mm: compaction: Capture a suitable high-order page immediately when it is made available

2012-08-08 Thread Mel Gorman
While compaction is migrating pages to free up large contiguous blocks for allocation it races with other allocation requests that may steal these blocks or break them up. This patch alters direct compaction to capture a suitable free page as soon as it becomes available to reduce this race. It use

[PATCH 5/5] mm: have order > 0 compaction start near a pageblock with free pages

2012-08-08 Thread Mel Gorman
commit [7db8889a: mm: have order > 0 compaction start off where it left] introduced a caching mechanism to reduce the amount work the free page scanner does in compaction. However, it has a problem. Consider two process simultaneously scanning free pages

[PATCH 1/5] mm: compaction: Update comment in try_to_compact_pages

2012-08-08 Thread Mel Gorman
The comment about order applied when the check was order > PAGE_ALLOC_COSTLY_ORDER which has not been the case since [c5a73c3d: thp: use compaction for all allocation orders]. Fixing the comment while I'm in the general area. Signed-off-by: Mel Gorman Reviewed-by: Rik van Riel Reviewed-by: Minch

[PATCH] Fix error: unknown field reclaim_buffers specified in initializer

2012-08-08 Thread David Cullen
The reclaim_buffers field has been removed from struct drm_driver. Signed-off-by: David Cullen --- drivers/staging/omapdrm/omap_drv.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/omapdrm/omap_drv.c b/drivers/staging/omapdrm/omap_drv.c index 4beab94..44149ee 100644 --- a/

Re: [Qemu-devel] [PATCH v8 5/6] introduce a new qom device to deal with panicked event

2012-08-08 Thread Blue Swirl
On Wed, Aug 8, 2012 at 2:47 AM, Wen Congyang wrote: > If the target is x86/x86_64, the guest's kernel will write 0x01 to the > port KVM_PV_EVENT_PORT when it is panciked. This patch introduces a new > qom device kvm_pv_ioport to listen this I/O port, and deal with panicked > event according to pan

Re: [PATCH 6/8] arm: vt8500: Update arch-vt8500 to devicetree support.

2012-08-08 Thread Stephen Warren
On 08/07/2012 07:39 PM, Tony Prisk wrote: > Merged existing board files to a single dt-capable file. > Converted irq and timer code to devicetree. > Removed existing device files that are no longer required with > devicetree support. > > All existing platform devices are converted to devicetree nod

[PATCH] Documentation/accounting/getdelays.c: remember to close() socket on error in create_nl_socket()

2012-08-08 Thread Jesper Juhl
If the call to setsockopt() fails in Documentation/accounting/getdelays.c::create_nl_socket() we return -1 without closing the socket, thus leaking it when the 'fd' variable goes out of scope. Easily fixed by just jumping to the 'error' label instead of returning since we do the proper cleanup the

Re: [PATCH 5/8] video: vt8500: Add devicetree support for vt8500-fb and wm8505-fb

2012-08-08 Thread Stephen Warren
On 08/07/2012 07:39 PM, Tony Prisk wrote: > Update vt8500-fb, wm8505-fb and wmt-ge-rops to support device > tree bindings. > Small change in wm8505-fb.c to support WM8650 framebuffer color > format. That might warrant a separate patch? > diff --git a/drivers/video/vt8500lcdfb.c b/drivers/video/v

Re: [dm-devel] [PATCH] dm: verity support data device offset (Linux 3.4.7)

2012-08-08 Thread Mikulas Patocka
Hi The problem with the patch is that it changes interface to the userspace tool. The userspace tool veritysetup already exists in recent cryptsetup package, so we can't change the interface - you should change the patch so that the starting data block is the last argument and the argument is

Re: [PATCH 00/19] sched-numa rewrite

2012-08-08 Thread Rik van Riel
nux/kernel/people/andrea/autonuma/autonuma-vs-sched-numa-rewrite-20120808.pdf For the people who have not yet read that PDF: While the sched-numa code is relatively small and clean, the current version does not seem to offer a significant performance improvement over not having it, and in one of

[PATCH] microblaze: uartlite: avoid NULL pointer exception

2012-08-08 Thread Stephan Linz
'prop' is an pointer and can only be unset (NULL) after prop = of_get_property() when it goes wrong. Kernel oops in ulite_probe(): [1.016645] uartlite 8fff.debug: failed to get alias id, errno -19 [1.024246] Oops: kernel access of bad area, sig: 11 [1.029733] Registers dump: mode

[PATCH v2] microblaze: improve failure handling for GPIO reset

2012-08-08 Thread Stephan Linz
Early exit from of_platform_reset_gpio_probe() if there was no GPIO reset line configured. Avoid kernel oops in gpio_system_reset(): [ 96.603690] Restarting system. [ 96.606094] Machine restart... [ 96.608810] Oops: kernel access of bad area, sig: 11 [ 96.613662] Registers dump: mode=824

Re: [PATCH 1/8] arm: vt8500: Add device tree files for VIA/Wondermedia SoC's

2012-08-08 Thread Stephen Warren
On 08/07/2012 07:39 PM, Tony Prisk wrote: > Add device tree files for VT8500, WM8505 and WM8650 SoC's and > reference boards. > diff --git a/arch/arm/boot/dts/vt8500_ref.dts > b/arch/arm/boot/dts/vt8500_ref.dts It appears more typical to use "-" rather than "_" in the filename to join SoC and bo

Re: [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500

2012-08-08 Thread Stephen Warren
On 08/07/2012 07:39 PM, Tony Prisk wrote: > Converted the existing arch-vt8500 gpio to a platform_device. > Added support for WM8505 and WM8650 GPIO controllers. > diff --git a/drivers/gpio/gpio-vt8500.c b/drivers/gpio/gpio-vt8500.c > +static struct of_device_id vt8500_gpio_dt_ids[] = { > + {

[PATCH 1/2] floppy: don't call alloc_ordered_workqueue inside the alloc_disk loop

2012-08-08 Thread Herton Ronaldo Krzesinski
Since commit 070ad7e ("floppy: convert to delayed work and single-thread wq"), we end up calling alloc_ordered_workqueue multiple times inside the loop, which shouldn't be intended. Besides the leak, other side effect in the current code is if blk_init_queue fails, we would end up calling unregiste

[PATCH 2/2] floppy: error handling fixes on do_floppy_init

2012-08-08 Thread Herton Ronaldo Krzesinski
While looking at commit 3f9a5aa ("floppy: Cleanup disk->queue before caling put_disk() if add_disk() was never called") I noticed some problems with the error handling and cleanup: * missing cleanup (put_disk) if blk_init_queue fails, dr is decremented first in the error handling loop * if somet

[PATCH] dm: verity support data device offset (Linux 3.4.7)

2012-08-08 Thread Wesley Miaw
From: Wesley Miaw Add data device start block index to dm-verity target parameters to support verity targets where the data does not begin at sector 0 of the block device. Also fix the hash block index computation so it takes into account data offsets. Signed-off-by: Wesley Miaw --- Documentat

$SUBJ should have been "[PATCHSET] timer: clean up initializers and implement irqsafe timers"

2012-08-08 Thread Tejun Heo
Either I'm keeping forgetting adding Subject: tag or git-send-mail is somehow screwed up. Sorry about that. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/maj

Re: [PATCH] tpm: Do not dereference NULL pointer if acpi_os_map_memory() fails.

2012-08-08 Thread Kent Yoder
On Tue, Aug 07, 2012 at 10:50:56PM +0200, Jesper Juhl wrote: > In drivers/char/tpm/tpm_bios.c::read_log() we call > acpi_os_map_memory(). That call may fail for a number of reasons > (invallid address, out of memory etc). If the call fails it returns > NULL and we just pass that to memcpy() uncondi

[PATCH 2/4] timer: relocate declarations of init_timer_on_stack_key()

2012-08-08 Thread Tejun Heo
init_timer_on_stack_key() is used by init macro definitions. Move init_timer_on_stack_key() and destroy_timer_on_stack() declarations above init macro defs. This will make the next init cleanup patch easier to read. Signed-off-by: Tejun Heo --- include/linux/timer.h | 30 +++-

Re: [PATCH 11/11] pm/drivers: fix use of SIMPLE_DEV_PM_OPS

2012-08-08 Thread Kevin Hilman
Arnd Bergmann writes: > A few drivers use a construct like > > #ifdef CONFIG_PM > static int foo_suspend(struct device *pdev) > { > ... > } > static int foo_resume struct device *pdev) > { > ... > } > #endif > static SIMPLE_DEV_PM_OPS(foo_pm, foo_suspend, foo_resume); > > which l

[PATCH 3/4] timer: clean up timer initializers

2012-08-08 Thread Tejun Heo
Over time, timer initializers became messy with unnecessarily duplicated codes which are inconsistently spread across timer.h and timer.c. This patch cleans up timer initializers. * timer.c::__init_timer() is renamed to do_init_timer(). * __TIMER_INITIALIZER() added. It takes @flags and all ini

[PATCH 4/4] timer: implement TIMER_IRQSAFE

2012-08-08 Thread Tejun Heo
Timer internals are protected with irq-safe locks but timer execution isn't, so a timer being dequeued for execution and its execution aren't atomic against IRQs. This makes it impossible to wait for its completion from IRQ handlers and difficult to shoot down a timer from IRQ handlers. This issu

[PATCH 1/4] timer: generalize timer->base flags handling

2012-08-08 Thread Tejun Heo
To prepare for addition of another flag, generalize timer->base flags handling. * Rename from TBASE_*_FLAG to TIMER_* and make them LU constants. * Define and use TIMER_FLAG_MASK for flags masking so that multiple flags can be handled correctly. * Don't dereference timer->base directly even if

[no subject]

2012-08-08 Thread Tejun Heo
Timer internals are protected by irqsafe lock but the lock is naturally dropped and irq enabled while a timer is executed. This makes dequeueing timer for execution and the actual execution non-atomic against IRQs. No matter what the timer function does, IRQs can occur between timer dispatch and

Re: [PATCH v2] pinctrl/nomadik: add ASIC DB8450 pinctrl driver

2012-08-08 Thread Stephen Warren
On 08/08/2012 06:05 AM, Linus Walleij wrote: > From: Patrice Chotard > > This implements a subdriver for the DB8540 ASIC for the > Nomadik pin controller. > > Signed-off-by: Patrice Chotard > Signed-off-by: Linus Walleij Reviewed-by: Stephen Warren -- To unsubscribe from this list: send the

Re: [PATCH v2 15/23] xen/arm: receive Xen events on ARM

2012-08-08 Thread Stefano Stabellini
On Tue, 7 Aug 2012, Konrad Rzeszutek Wilk wrote: > On Mon, Aug 06, 2012 at 03:27:18PM +0100, Stefano Stabellini wrote: > > Compile events.c on ARM. > > Parse, map and enable the IRQ to get event notifications from the device > > tree (node "/xen"). > > > > Signed-off-by: Stefano Stabellini > > --

Re: What happened to TRIM support for raid linear/0/1/10?

2012-08-08 Thread Lutz Vieweg
On 08/08/2012 03:10 PM, Holger Kiehl wrote: Personally, I would think that TRIM support MD would be a very good thing. That's one thing I am waiting for, too. We had to implement a somewhat clumsy user-space application which does the trick for us - but that is an ugly work-around, as it has t

Re: [PATCH 0/4] i2c: tegra: required clock support for controller

2012-08-08 Thread Stephen Warren
On 08/08/2012 01:51 AM, Laxman Dewangan wrote: > The Tegra's i2c controller required two clock sources for proper > operation named as div-clk and fast-clk. > > Adding support to make sure that driver will get these clocks and > enable before any transfer and disable after transfer completed. Th

Re: [PATCH v3] irq_remap: disable IRQ remapping if any IOAPIC lacks an IOMMU

2012-08-08 Thread Yinghai Lu
On Wed, Aug 8, 2012 at 6:27 AM, Seth Forshee wrote: > The ACPI tables in the Macbook Air 5,1 define a single IOAPIC with id 2, > but the only remapping unit described in the DMAR table matches id 0. > Interrupt remapping fails as a result, and the kernel panics with the > message "timer doesn't wo

Re: [RFC 1/4] remoteproc: Bugfix assign device address to carveout (noiommu)

2012-08-08 Thread Sjur Brændeland
Hi Ohad, > Carveout did not set device address when IOMMU is not supported. > Fix this by assigning dma address to device address to carveout > if IOMMU is not supported. I realize that we have the same issue with the virtio rings. Are there any way we can assign the device address of the virtio

Re: [PATCH 01/11] ARM: topology: mark init_cpu_topology as __init

2012-08-08 Thread Stephen Boyd
On 08/08/12 07:47, Arnd Bergmann wrote: > The init_cpu_topology function can be put into the __init section > and discarded after boot, because it is only called from > smp_prepare_cpus, which is also marked __init. This was reported > by gcc after Vincent Guittot added the parse_dt_topology functi

Re: [RFC PATCH] tun: don't zeroize sock->file on detach

2012-08-08 Thread Yuchung Cheng
On Wed, Aug 8, 2012 at 5:53 AM, Stanislav Kinsbursky wrote: > Hi, Dave. > What about this patch? > > > On Wed, Jul 11, 2012 at 03:48:20PM +0400, Stanislav Kinsbursky wrote: >> >> This is a fix for bug, introduced in 3.4 kernel by commit >> 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among oth

RE: [PATCH 0/4] promote zcache from staging

2012-08-08 Thread Dan Magenheimer
> From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] Hi Seth -- Good discussion. Even though we disagree, I appreciate your enthusiasm and your good work on the kernel! > Subject: Re: [PATCH 0/4] promote zcache from staging > > On 08/07/2012 04:47 PM, Dan Magenheimer wrote: > > I notice

POSIX_FADV_DONTNEED causing excessive amounts of block I/O

2012-08-08 Thread Lutz Vieweg
I recently investigated the I/O performance of some software and noticed that "iotop" and "pidstat -d" reported way more write activity than the application could ever have written. Further investigation revealed that the application was using posix_fadvise(..., POSIX_FADV_DONTNEED) on regions of

Re: [PATCH v2 10/23] xen/arm: compile and run xenbus

2012-08-08 Thread Stefano Stabellini
On Wed, 8 Aug 2012, Daniel De Graaf wrote: > On 08/08/2012 01:19 PM, Stefano Stabellini wrote: > > On Wed, 8 Aug 2012, Daniel De Graaf wrote: > >> On 08/08/2012 12:51 PM, Stefano Stabellini wrote: > >>> On Tue, 7 Aug 2012, Daniel De Graaf wrote: > On 08/07/2012 02:21 PM, Konrad Rzeszutek Wilk

[PATCH 2/7] uprobes: kill dup_mmap()->uprobe_mmap(), simplify uprobe_mmap/munmap

2012-08-08 Thread Oleg Nesterov
1. Kill dup_mmap()->uprobe_mmap(), it was only needed to calculate new_mm->uprobes_state.count removed by the previous patch. If the forking process has a pending uprobe (int3) in vma, it will be copied by copy_page_range(), note that it checks vma->anon_vma so "Don't copy ptes" is not

[PATCH 7/7] uprobes: remove "verify" argument from set_orig_insn()

2012-08-08 Thread Oleg Nesterov
Nobody does set_orig_insn(verify => false), and I think nobody will. Remove this argument. IIUC set_orig_insn(verify => false) was needed to single-step without xol area. Signed-off-by: Oleg Nesterov --- include/linux/uprobes.h |2 +- kernel/events/uprobes.c | 20 +--- 2 fi

[PATCH 5/7] uprobes: introduce MMF_HAS_UPROBES

2012-08-08 Thread Oleg Nesterov
Add the new MMF_HAS_UPROBES flag. It is set by install_breakpoint() and it is copied by dup_mmap(), uprobe_pre_sstep_notifier() checks it to avoid the slow path if the task was never probed. Perhaps it makes sense to check it in valid_vma(is_register => false) as well. This needs the new dup_mmap(

[PATCH 3/7] uprobes: change uprobe_mmap() to ignore the errors but check fatal_signal_pending()

2012-08-08 Thread Oleg Nesterov
Once install_breakpoint() fails uprobe_mmap() "ignores" all other uprobes and returns the error. It was never really needed to to stop after the first error, and in fact it was always wrong at least in -ENOTSUPP case. Change uprobe_mmap() to ignore the errors and always return 0. This is not what

[PATCH 4/7] uprobes: do not use -EEXIST in install_breakpoint() paths

2012-08-08 Thread Oleg Nesterov
-EEXIST from install_breakpoint() no longer makes sense, all callers should simply treat it as "success". Change the code to return zero and simplify register_for_each_vma(). Signed-off-by: Oleg Nesterov --- kernel/events/uprobes.c | 16 +--- 1 files changed, 5 insertions(+), 11 de

[PATCH 6/7] uprobes: fold uprobe_reset_state() into uprobe_dup_mmap()

2012-08-08 Thread Oleg Nesterov
Now that we have uprobe_dup_mmap() we can fold uprobe_reset_state() into the new hook and remove it. mmput()->uprobe_clear_state() can't be called before dup_mmap(). Signed-off-by: Oleg Nesterov --- include/linux/uprobes.h |4 kernel/events/uprobes.c | 10 ++ kernel/fork.c

[PATCH 1/7] uprobes: kill uprobes_state->count

2012-08-08 Thread Oleg Nesterov
uprobes_state->count is only needed to avoid the slow path in uprobe_pre_sstep_notifier(). It is also checked in uprobe_munmap() but ironically its only goal to decrement this counter. However, it is very broken. Just some examples: - uprobe_mmap() can race with uprobe_unregister() and wrongly i

[PATCH 0/7] uprobes: kill uprobes_state->count, add MMF_HAS_UPROBES

2012-08-08 Thread Oleg Nesterov
Hello. Srikar, please review. This is the first part. The next series will teach uprobes to clear MMF_HAS_UPROBES, but perhaps we should simply remove uprobe_munmap() instead. A wrong MMF_HAS_UPROBES doesn't hurt unless the task hits the non-uprobe "int3", not sure it really makes sense to try to

Re: [PATCH 0/7] zram/zsmalloc promotion

2012-08-08 Thread Nitin Gupta
On 08/07/2012 11:12 PM, Minchan Kim wrote: > This patchset promotes zram/zsmalloc from staging. > Both are very clean and zram is used by many embedded product > for a long time. > > [1-3] are patches not merged into linux-next yet but needed > it as base for [4-5] which promotes zsmalloc. > Greg,

Re: [PATCH v2 10/23] xen/arm: compile and run xenbus

2012-08-08 Thread Daniel De Graaf
On 08/08/2012 01:19 PM, Stefano Stabellini wrote: > On Wed, 8 Aug 2012, Daniel De Graaf wrote: >> On 08/08/2012 12:51 PM, Stefano Stabellini wrote: >>> On Tue, 7 Aug 2012, Daniel De Graaf wrote: On 08/07/2012 02:21 PM, Konrad Rzeszutek Wilk wrote: > On Mon, Aug 06, 2012 at 03:27:13PM +0100

Re: [PATCH 1/2] ARM: build ssi-fiq.S in ARM mode to prevent CONFIG_THUMB2_KERNEL build breakage

2012-08-08 Thread Matt Sealey
On Wed, Aug 8, 2012 at 1:55 AM, Sascha Hauer wrote: >> .text >> + .arm >> .global imx_ssi_fiq_start >> .global imx_ssi_fiq_end >> .global imx_ssi_fiq_base > > I think it would be better to add a depends on !THUMB2_KERNEL to > SND_

Re: [PATCH 0/3] ARM: dt: tegra: cardhu: add entry for regulators

2012-08-08 Thread Stephen Warren
On 08/08/2012 12:48 AM, Laxman Dewangan wrote: > This patch series add the PMIC and fixed regulators for > cardhu board. There is multiple versions of cardhu baord named > as A01, A02, A03..and so on. Cardhu A01 and A03 are not supported. > Cardhu A02 and A04 have different sets of GPIO for regual

[RFC PATCHv2] QEMU Fix /usr/bin/xargs: etags: Argument list too long

2012-08-08 Thread David Cullen
Patch applies to commit 42a579a0f960081cd16fc945036e4780c3ad3202 When running "make ARCH=arm TAGS" in a cross chroot using qemu-arm-static, the following message is emitted: [user@host:/home/work/linux]: make ARCH=arm TAGS GEN TAGS /usr/bin/xargs: etags: Argument list too l

Re: [PATCH v2 21/23] xen: update xen_add_to_physmap interface

2012-08-08 Thread Stefano Stabellini
On Tue, 7 Aug 2012, Konrad Rzeszutek Wilk wrote: > On Mon, Aug 06, 2012 at 03:27:24PM +0100, Stefano Stabellini wrote: > > Update struct xen_add_to_physmap to be in sync with Xen's version of the > > structure. > > The size field was introduced by: > > > > changeset: 24164:707d27fe03e7 > > user:

Re: [PATCH] efikamx: reintroduce Genesi Efika MX Smarttop via device tree

2012-08-08 Thread Fabio Estevam
Matt, On Wed, Aug 8, 2012 at 1:55 PM, Matt Sealey wrote: ... > or any setup at all for this. What's stopping this right now is you > need a new U-Boot which we > didn't release or mainline because we are still testing it (old U-Boot > shipped on the boards > cannot boot device tree anyway). Whil

Re: [PATCH v2 10/23] xen/arm: compile and run xenbus

2012-08-08 Thread Stefano Stabellini
On Wed, 8 Aug 2012, Daniel De Graaf wrote: > On 08/08/2012 12:51 PM, Stefano Stabellini wrote: > > On Tue, 7 Aug 2012, Daniel De Graaf wrote: > >> On 08/07/2012 02:21 PM, Konrad Rzeszutek Wilk wrote: > >>> On Mon, Aug 06, 2012 at 03:27:13PM +0100, Stefano Stabellini wrote: > bind_evtchn_to_irq

Re: [PATCH 0/3] ARM: dt: tegra: cardhu: add entry for regulators

2012-08-08 Thread Stephen Warren
On 08/08/2012 12:48 AM, Laxman Dewangan wrote: > This patch series add the PMIC and fixed regulators for > cardhu board. There is multiple versions of cardhu baord named > as A01, A02, A03..and so on. Cardhu A01 and A03 are not supported. > Cardhu A02 and A04 have different sets of GPIO for regual

Re: [PATCH] can/softing: Fix potential memory leak in softing_load_fw()

2012-08-08 Thread Marc Kleine-Budde
On 08/08/2012 05:15 PM, Alexey Khoroshilov wrote: > Do not leak memory by updating pointer with potentially NULL realloc return > value. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Thanks for the work, applied to can/master. Marc --

Re: [PATCH 00/19] sched-numa rewrite

2012-08-08 Thread Andrea Arcangeli
people/andrea/autonuma/autonuma-vs-sched-numa-rewrite-20120808.pdf > These patches go on top of tip/master with origin/master (Linus' tree) merged > in. It applied clean (with git am) on top of 3.6-rc1 (0d7614f09c1ebdbaa1599a5aba7593f147bf96ee) which already had a pull of sched-core from ti

<    1   2   3   4   5   6   7   >