Signed-off-by: Stefan Achatz
---
drivers/hid/hid-roccat-kovaplus.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/hid-roccat-kovaplus.c
b/drivers/hid/hid-roccat-kovaplus.c
index 0c8e1ef..9660477 100644
--- a/drivers/hid/hid-roccat-kovaplus.c
+++
On Fri, Nov 01, 2013 at 06:06:58PM +0200, Victor Kaplansky wrote:
> "Paul E. McKenney" wrote on 10/31/2013
> 05:25:43 PM:
>
> > I really don't care about "fair" -- I care instead about the kernel
> > working reliably.
>
> Though I don't see how putting a memory barrier without deep
On Fri, Nov 01, 2013 at 03:56:34PM +0100, Peter Zijlstra wrote:
> On Wed, Oct 30, 2013 at 11:40:15PM -0700, Paul E. McKenney wrote:
> > > Now the whole crux of the question is if we need barrier A at all, since
> > > the STORES issued by the @buf writes are dependent on the ubuf->tail
> > > read.
On Fri, Nov 01, 2013 at 03:12:58PM +0200, Victor Kaplansky wrote:
> "Paul E. McKenney" wrote on 10/31/2013
> 08:16:02 AM:
>
> > > BTW, it is why you also don't need ACCESS_ONCE() around @tail, but only
> > > around
> > > @head read.
>
> Just to be sure, that we are talking about the same code -
[ Adding David Howells, Lech Fomicki, and Mark Batty on CC for their
thoughts given previous discussions. ]
On Sat, Nov 02, 2013 at 09:36:18AM -0700, Paul E. McKenney wrote:
> On Fri, Nov 01, 2013 at 03:12:58PM +0200, Victor Kaplansky wrote:
> > "Paul E. McKenney" wrote on 10/31/2013
> >
On Fri, Nov 01, 2013 at 11:30:17AM +0100, Peter Zijlstra wrote:
> On Fri, Nov 01, 2013 at 02:28:14AM -0700, Paul E. McKenney wrote:
> > > This is a completely untenable position.
> >
> > Indeed it is!
> >
> > C/C++ never was intended to be used for parallel programming,
>
> And yet pretty much
On Fri, Nov 01, 2013 at 05:11:29PM +0100, Peter Zijlstra wrote:
> On Wed, Oct 30, 2013 at 11:40:15PM -0700, Paul E. McKenney wrote:
> > > void kbuf_write(int sz, void *buf)
> > > {
> > > u64 tail = ACCESS_ONCE(ubuf->tail); /* last location userspace read */
> > > u64 offset = kbuf->head; /* we
On Fri, Nov 01, 2013 at 04:25:42PM +0200, Victor Kaplansky wrote:
> "Paul E. McKenney" wrote on 10/31/2013
> 08:40:15 AM:
>
> > > void ubuf_read(void)
> > > {
> > >u64 head, tail;
> > >
> > >tail = ACCESS_ONCE(ubuf->tail);
> > >head = ACCESS_ONCE(ubuf->head);
> > >
> > >/*
> > >
On Fri, Nov 01, 2013 at 05:18:19PM +0100, Peter Zijlstra wrote:
> On Wed, Oct 30, 2013 at 11:40:15PM -0700, Paul E. McKenney wrote:
> > The dependency you are talking about is via the "if" statement?
> > Even C/C++11 is not required to respect control dependencies.
> >
> > This one is a bit
On Tue, Oct 15, 2013 at 01:16:48PM -0700, Eric W. Biederman wrote:
> int vfs_rmdir(struct inode *dir, struct dentry *dentry)
> {
> int error = may_delete(dir, dentry, 1);
> @@ -3622,6 +3636,9 @@ retry:
> error = -ENOENT;
> goto exit3;
> }
> + error =
Hi Milosz,
Thanks for your comments.
We think SSD and fscache based write cache is definitely useful for
Ceph, since to some extent, write amplification slow down the write
performance of Ceph. Lustre has already introduced SSD based write
cache. SSD can be treated as an outer big cache
Exportfs fix from bfields. Please, pull from the usual place -
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus
Shortlog:
J. Bruce Fields (2):
vfs: split out vfs_getattr_nosec
exportfs: fix 32-bit nfsd handling of 64-bit inode numbers
Diffstat:
Drop packet instead of return NETDEV_TX_BUSY when tx failed.
Signed-off-by: ZHAO Gang
---
move function send_packet's work directly to et131x_tx(), also make
some changes to improve readability.
drivers/staging/et131x/et131x.c | 84 +++--
1 file changed, 22
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 26 --
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index ca3332e..8c2a4a5 100644
--- a/drivers/staging/et131x/et131x.c
+++
On Sat, Nov 2, 2013 at 2:26 PM, Mathias Krause wrote:
> On 64 bit systems the test for negative message sizes is bogus as the
> size, which may be positive when evaluated as a long, will get truncated
> to an int when passed to load_msg().
Quite frankly, wouldn't it be much nicer to just fix
On Fri, Nov 01, 2013 at 08:29:26PM -0400, Jason Cipriani wrote:
> In blkdiscard in util-linux, at least since version 2.23, the
> following code is used to retrieve a device's physical sector size:
>
> uint64_t secsize;
> ioctl(fd, BLKSSZGET, );
>
> On my machine (Ubuntu 12.04 --
On Wed, 2013-10-30 at 15:54 +0800, rogera...@realtek.com wrote:
> From: Roger Tseng
>
> In h_msb_read_page() in ms_block.c, flow never reaches case
> MSB_RP_RECIVE_STATUS_REG. This causes error when MEMSTICK_INT_ERR is
> encountered and status error bits are going to be examined, but the status
A couple of patches I'm about to push onto my linux-next branch. They
are bug fixes to patches I've already applied instead of rebasing the
branch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info
Commit 2361613206e6, "of/irq: Refactor interrupt-map parsing" introduced
a potential buffer overflow bug because it doesn't do sufficient range
checking on the input data. This patch adds the appropriate checking and
buffer size adjustments. If the bounds are out of range then warn
loudly.
On Fri, 1 Nov 2013 15:54:33 +0100, Jonas Jensen wrote:
> The MOXA UC-711X hardware(s) has an ethernet controller that seem
> to be developed internally. The IC used is "RTL8201CP".
>
> This patch adds an MDIO driver and also patches realtek to include
> RTL8201CP PHY driver.
>
> Signed-off-by:
Commit 2361613206e6, "of/irq: Refactor interrupt-map parsing" introduced
a bug. The irq parsing will fail for some nodes that don't have a reg
property. It is fixed by deferring the check for reg until it is
actually needed. Also adjust the testcase data to catch the bug.
Signed-off-by: Grant
On Wed, 30 Oct 2013 00:05:22 -0500, Rob Herring wrote:
> From: Rob Herring
>
> Platform devices created by DT code don't initialize dma_mask pointer to
> anything. Set it to coherent_dma_mask by default if the architecture
> code has not set it.
>
> Signed-off-by: Rob Herring
I believe this
On 11/1/13, 3:29 AM, Chenggang Qin wrote:
Copy the value to start and end to struct perf_session.
Why put the times in the session?
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On 11/1/13, 3:29 AM, Chenggang Qin wrote:
Add a field 'min_timestamp' in struct ordered_samples to record the minimial
timestamp of the samples in ordered_samples->samples.
why? How do you intend to use the field?
David
--
To unsubscribe from this list: send the line "unsubscribe
Christophe Leroy :
> The patch adds WAN support for Infineon FALC56 - PEF2256 E1 Chipset.
>
> Signed-off-by: Jerome Chantelauze
> Acked-by: Christophe Leroy
>
> diff -urN a/drivers/net/wan/pef2256.c b/drivers/net/wan/pef2256.c
> --- a/drivers/net/wan/pef2256.c 1970-01-01
On Sat, Nov 02, 2013 at 03:30:57PM -0600, Shuah Khan wrote:
> On 11/01/2013 04:06 PM, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 3.11.7 release.
> > There are 66 patches in this series, all will be posted as a response
> > to this one. If anyone has any
On 11/01/2013 03:43 PM, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 3.4.68 release.
There are 32 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be
On 11/01/2013 04:03 PM, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 3.10.18 release.
There are 54 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be
On 11/01/2013 04:06 PM, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 3.11.7 release.
There are 66 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be
Hi Linus,
this series fixes a bug in the IPC code that allows root to instantly crash
the system. The first patch fixes the bug, the second one prevents msgmax
from getting negative in the first place. As that *might* break existing
userspace (for good?!) it's a separate patch.
The cc list is
Negative message lengths make no sense, prevent them from being set.
They do more harm than gain.
In case a user wants to have "unlimited" message sizes she should
just use INT_MAX instead.
Signed-off-by: Mathias Krause
Cc: Andrew Morton
---
ipc/ipc_sysctl.c |6 +++---
1 file changed, 3
On 64 bit systems the test for negative message sizes is bogus as the
size, which may be positive when evaluated as a long, will get truncated
to an int when passed to load_msg(). So a long might very well contain a
positive value but when truncated to an int it would become negative.
That in
Aldo Iljazi wrote:
> Fixed a few coding style issues that checkpatch reported.
>
> Specifically:
>
> 1. line over 80 characters issue on the lines 9 and 10.
> 2. space prohibited before open square bracket '[' issue on the lines
> 31.
> 3. inserted space after comma on lines 32 to 156.
>
>
Fixed a few coding style issues that checkpatch reported.
Specifically:
1. line over 80 characters issue on the lines 9 and 10.
2. space prohibited before open square bracket '[' issue on the lines
31.
3. inserted space after comma on lines 32 to 156.
Signed-off-by: Aldo Iljazi
---
Fixed a few coding style issues that checkpatch reported.
Specifically:
1. line over 80 characters issue on the lines 9 and 10.
2. space prohibited before open square bracket '[' issue on the lines
31.
3. iserted space after comma on lines to 156
Signed-off-by: Aldo Iljazi
---
Fixed a few coding style issues that checkpatch reported.
Specifically:
1. line over 80 characters issue on the lines 9 and 10.
2. space prohibited before open square bracket '[' issue on the lines
30 to 155.
Signed-off-by: Aldo Iljazi
---
drivers/staging/ft1000/ft1000-pcmcia/boot.h | 263
On Sat, 2 Nov 2013 10:33:23 +1100 NeilBrown wrote:
> On Fri, 1 Nov 2013 10:16:44 -0700 Mark Rutland wrote:
>
> > Hi Neil,
> >
> > While I'm not fundamentally opposed to this binding, I have some issues with
> > its current form and would not want to see this version hit mainline.
> >
>
>
On Sun, Nov 03, 2013 at 07:22:10AM +1100, Benjamin Herrenschmidt wrote:
> On Sat, 2013-11-02 at 08:58 -0700, Greg Kroah-Hartman wrote:
> > Just loop through all the platform devices before registering it to
> > determine if you need to do this, the platform code can do this just
> > fine. If you
On Sat, 2013-11-02 at 08:58 -0700, Greg Kroah-Hartman wrote:
> Just loop through all the platform devices before registering it to
> determine if you need to do this, the platform code can do this just
> fine. If you try to register a duplicate name with the driver core,
> odds are it will
On Fri, Nov 01, 2013 at 03:01:10PM +0800, Jason Wang wrote:
> We don't validate iph->ihl which may lead a dead loop if we meet a IPIP
> skb whose iph->ihl is zero. Fix this by failing immediately when iph->ihl
> is evil (less than 5).
>
> This issue were introduced by commit
On Sat, 2013-11-02 at 17:40 -0200, Mauro Carvalho Chehab wrote:
> Em Sat, 02 Nov 2013 20:20:54 +0100
> Paul Bolle escreveu:
> > Those are obvious typos. Still present in v3.12-rc7. Perhaps you'd like
> > to send the trivial patch to fix this?
>
> Yes, it is a typo...
>
> > > Probably, it was
On 10/26/2013 6:51 AM, Tetsuo Handa wrote:
> Tetsuo Handa wrote:
>> I would send another one which uses only security_file_alloc/free .
> I sent it to James, Casey and Kees on "Fri, 18 Oct 2013 22:56:19 +0900" and
> waiting for your response. How long are we expected to remain vulnerable due
> to
Em Sat, 02 Nov 2013 20:20:54 +0100
Paul Bolle escreveu:
> On Sun, 2013-10-20 at 00:03 +0200, Martin Walch wrote:
> > drivers/media/common/siano/Kconfig:21-26
> > > config SMS_SIANO_DEBUGFS
> > > bool "Enable debugfs for smsdvb"
> > > depends on SMS_SIANO_MDTV
> > > depends on DEBUG_FS
> >
On Sun, 2013-10-20 at 00:03 +0200, Martin Walch wrote:
> drivers/media/common/siano/Kconfig:21-26
> > config SMS_SIANO_DEBUGFS
> > bool "Enable debugfs for smsdvb"
> > depends on SMS_SIANO_MDTV
> > depends on DEBUG_FS
> > depends on SMS_USB_DRV
> > depends on CONFIG_SMS_USB_DRV
From: Matthew Geddes
Signed-off-by: Matthew Geddes
---
drivers/input/tablet/wacom_wac.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
index c59b797..5015269 100644
--- a/drivers/input/tablet/wacom_wac.c
+++
On 13-11-01 01:16 AM, vaughan wrote:
On 11/01/2013 03:20 AM, Douglas Gilbert wrote:
On 13-10-31 11:56 AM, Christoph Hellwig wrote:
+struct semaphore or_sem; /* protect co-incident opens and
releases */
Seems like this should be a mutex.
Yes, it is being used as a mutex. However
On Saturday 02 of November 2013 13:47:09 Matt Porter wrote:
> On Sat, Nov 02, 2013 at 10:46:55PM +0530, Kishon Vijay Abraham I wrote:
> > Hi Tomasz,
> >
> > On Saturday 02 November 2013 06:44 PM, Tomasz Figa wrote:
> > >Hi Matt,
> > >
> > >On Friday 01 of November 2013 15:45:50 Matt Porter wrote:
On Sat, Nov 02, 2013 at 02:09:21PM +0100, Tomasz Figa wrote:
> Hi Matt.
>
> On Friday 01 of November 2013 15:45:54 Matt Porter wrote:
> > Adds support for the generic PHY subsystem. Generic PHY
> > support is probed and then the driver falls back to checking
> > for an old style USB PHY and pdata
On Sat, Nov 02, 2013 at 10:46:55PM +0530, Kishon Vijay Abraham I wrote:
> Hi Tomasz,
>
> On Saturday 02 November 2013 06:44 PM, Tomasz Figa wrote:
> >Hi Matt,
> >
> >On Friday 01 of November 2013 15:45:50 Matt Porter wrote:
> >>This adds a pair of APIs that allows the generic PHY subsystem to
>
From: Peter Huewe
- removing stale/inactive maintainers
- removing stale/outdated website
- regrouped maintainers
Signed-off-by: Peter Huewe
---
MAINTAINERS |8 ++--
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 936adb4..0f42b97 100644
From: Peter Huewe
If
status = acpi_get_name(handle, ACPI_FULL_PATHNAME, );
fails for whatever reason and does not return AE_OK
if (strstr(buffer.pointer, context) != NULL) {
does dereference a null pointer.
-> Check the return value and return the status to the caller
Found by coverity
Cc:
From: Peter Huewe
smatch complains:
/data/data-old/linux-2.6/drivers/char/tpm/tpm_ibmvtpm.c:510
ibmvtpm_crq_process() info: ignoring unreachable code.
-> The return is not necessary here, remove it
Signed-off-by: Peter Huewe
---
drivers/char/tpm/tpm_ibmvtpm.c |1 -
1 files changed, 0
From: Fengguang Wu
drivers/char/tpm/tpm_i2c_atmel.c:178:8-9: WARNING: return of 0/1 in function
'i2c_atmel_req_canceled' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: coccinelle/misc/boolreturn.cocci
CC: Jason
From: Peter Huewe
The 'get_burstcount' function can in some circumstances 'return -EBUSY' which
in tpm_stm_i2c_send is stored in an 'u32 burstcnt'
thus converting the signed value into an unsigned value, resulting
in 'burstcnt' being huge.
Changing the type to u32 only does not solve the problem
From: Peter Huewe
Depending on the implementation strcmp might return the difference between
two strings not only -1,0,1 consequently
if (strcmp (a,b) == -1)
might lead to taking the wrong branch
-> compare with < 0 instead,
which in any case is more canonical.
Cc: sta...@vger.kernel.org
Hi
02.11.2013, 20:59, "Michal Nazarewicz" :
>> Argh, why would we just don't do that? Its in-memory field, it can be
>> anything, I wouldn't be surprised if it even can be non-atomic because
>> of proper locks already being held
>
> If the driver does not require an atomic set_bit operation
Hi Tomasz,
On Saturday 02 November 2013 06:44 PM, Tomasz Figa wrote:
Hi Matt,
On Friday 01 of November 2013 15:45:50 Matt Porter wrote:
This adds a pair of APIs that allows the generic PHY subsystem to
provide information on the PHY bus width. The PHY provider driver may
use
> 01.11.2013, 23:30, "Andrew Morton" :
>> set_bit() operates on longs. So if we do
>>
>> struct foo { u32 a; u32 b; } f;
>> set_bit(0, (long *));
>>
>> then we'll scribble on f.b on a big-endian 64-bit machine.
On Sat, Nov 02 2013, Рустафа Джамурахметов wrote:
> Argh, why would we just don't do
> +@r depends on report || context@
> +expression E;
> +position p;
> +@@
> +if@p (E) {}
There should be a * in front of the if, to support context mode.
julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More
On Sat, Nov 02, 2013 at 08:44:46AM -0700, Greg KH wrote:
> > Oh, for me, it is not suitable to move a file system sub-directory to
> > "drivers/*/" sub-directory. And I can not find any sub-directory like
> > 'staging' under "fs" sub-directory, either.
> >
> > Do we have any sub-directory like
-Original Message-
From: open-is...@googlegroups.com [mailto:open-is...@googlegroups.com] On
Behalf Of Nicholas A. Bellinger
Sent: Friday, November 01, 2013 1:37 PM
To: Mike Christie
Cc: open-is...@googlegroups.com; linux-scsi; LKML; target-devel; Or Gerlitz
Subject: Re: scsi-mq +
On Sat, Nov 02, 2013 at 10:09:59AM +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2013-11-01 at 13:47 -0700, Greg Kroah-Hartman wrote:
>
> > > > On my device I seem to have some platform devices registered through
> > > > device-tree, and some registered through platform_device_add (e.g.
> > > >
Hello,
Let me first apologize again if this was already discussed. And I also
need to mention that I know almost nothing about elf/randomization/etc.
However,
On 10/29, Namhyung Kim wrote:
>
> # nm foo | grep -e glob$ -e str -e foo
> 006008bc D foo
> 006008a8 D glob
>
Hi Grygorii,
On Mon, Oct 14, 2013 at 5:55 PM, Grygorii Strashko
wrote:
> Hi Prabhakar Lad,
>
> On 10/11/2013 07:18 PM, Prabhakar Lad wrote:
>> Hi Linus,
>>
>> On 10/11/13, Linus Walleij wrote:
>>> On Fri, Oct 11, 2013 at 4:59 PM, Prabhakar Lad
>>> wrote:
On 10/11/13, Linus Walleij wrote:
On Fri, Nov 01, 2013 at 05:40:02PM -0600, Bjorn Helgaas wrote:
> On Tue, Oct 29, 2013 at 3:46 PM, Greg Kroah-Hartman
> wrote:
> > From: Greg Kroah-Hartman
> >
> > The PCI MSI sysfs code is a mess with kobjects for things that don't
> > really need to be kobjects. This patch creates attributes
From: KV Sujith
Add DT node for Davinci GPIO driver.
Signed-off-by: KV Sujith
Signed-off-by: Philip Avinash
Signed-off-by: Lad, Prabhakar
---
arch/arm/boot/dts/da850.dtsi | 15 +++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/da850.dtsi
On Sat, Nov 02, 2013 at 09:46:31PM +0800, Chen Gang wrote:
> On 11/01/2013 10:41 AM, Chen Gang wrote:
> > On 11/01/2013 04:45 AM, Greg KH wrote:
> >> On Thu, Oct 31, 2013 at 12:08:33PM -0700, Kees Cook wrote:
> >>> On Thu, Oct 31, 2013 at 12:06 PM, Al Viro wrote:
> On Thu, Oct 31, 2013 at
From: "Lad, Prabhakar"
This patch fixes the check for the offset in
gpio_to_irq_unbanked() function.
Signed-off-by: Lad, Prabhakar
---
drivers/gpio/gpio-davinci.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
From: KV Sujith
Add GPIO DT node and pinmux entries for DA850 EVM. GPIO is
configurable differently on different boards. So add GPIO
pinmuxing in dts file.
Signed-off-by: KV Sujith
Signed-off-by: Philip Avinash
Signed-off-by: Lad, Prabhakar
---
arch/arm/boot/dts/da850-evm.dts | 20
From: KV Sujith
This patch adds OF parser support for davinci gpio
driver and also appropriate documentation in gpio-davinci.txt
located at Documentation/devicetree/bindings/gpio/.
Signed-off-by: KV Sujith
Signed-off-by: Philip Avinash
[prabhakar.cse...@gmail.com: simplified the OF code,
From: "Lad, Prabhakar"
This patch converts the davinci gpio driver to use irqdomain
support.
Signed-off-by: Lad, Prabhakar
---
arch/arm/mach-davinci/da830.c |1 -
arch/arm/mach-davinci/da850.c |1 -
arch/arm/mach-davinci/dm355.c |1 -
From: "Lad, Prabhakar"
the devm_*() helper prints error messages in case of
errors no need to do the same in the driver.
Signed-off-by: Lad, Prabhakar
---
drivers/gpio/gpio-davinci.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-davinci.c
On Fri, Nov 01, 2013 at 07:31:26PM -0700, Guenter Roeck wrote:
> On Fri, Nov 01, 2013 at 03:06:36PM -0700, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 3.11.7 release.
> > There are 66 patches in this series, all will be posted as a response
> > to this one.
From: "Lad, Prabhakar"
Patches 1, 2 and 3 are newly added. This patch series does the following
a> Fixes check for offset for unbanked gpios.
b> Ports the driver to use irqdomain.
c> Adds dt binding support for gpio-davinci.
d> Adds DA850 dt support goio.
Changes for v4:
1: Added irqdomain
This script finds code like this, with an unnecessary if:
if (foo) {}
Provides report mode only, since patching often eliminates conditionals
that contain TODO comments or similar.
Signed-off-by: Josh Triplett
---
v2: Drop patch mode.
scripts/coccinelle/misc/unnecessary-if.cocci | 23
> I observed several where the patch seemed entirely correct, with no
> FIXME/TODO/XXX comments associated with the conditional.
>
> Nonetheless, I don't mind removing the patch mode if you don't think
> it's worthwhile. I'll send a v2.
I think it would be better without it.
thanks,
julia
--
To
On Sat, Nov 02, 2013 at 03:51:50PM +0100, Julia Lawall wrote:
> On Sat, 2 Nov 2013, Josh Triplett wrote:
>
> > This script matches code like:
> >
> > if (foo) {}
> >
> > and either eliminates it (if foo has no side effects) or replaces it
> > with foo (if foo has side effects).
> >
> > Works
On Sat, 2 Nov 2013, Josh Triplett wrote:
> This script matches code like:
>
> if (foo) {}
>
> and either eliminates it (if foo has no side effects) or replaces it
> with foo (if foo has side effects).
>
> Works perfectly in report mode; the results of patch mode are
> semantically correct but may
This script matches code like:
if (foo) {}
and either eliminates it (if foo has no side effects) or replaces it
with foo (if foo has side effects).
Works perfectly in report mode; the results of patch mode are
semantically correct but may still benefit from further simplification.
On 11/02/2013 02:32 AM, Joe Perches wrote:
> On Fri, 2013-11-01 at 19:20 +0800, Chen Gang wrote:
>> > Hello Joe:
> Hello Chen Gang.
>
>> > I meet a failure about "scripts/get_maintainers.pl", it is about the
>> > commit "750432d get_maintainer.pl incomplete output", if use original
>> >
On 11/01, David Long wrote:
>
> On 10/29/13 15:59, Oleg Nesterov wrote:
>>
>> Or. arm can actually reimplement set_swbp(). This doesn't mean the
>> duplication of write_opcode() code, we can simply export this helper.
>>
>
> That actually looks to me like the cleanest approach. I have changed
>
dev_kfree_skb_any is protected from NULL. No need to check for NULL while
calling this function.
Signed-off-by: Govindarajulu Varadarajan
---
drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c | 3 +--
drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c | 3 +--
On 11/01/2013 10:41 AM, Chen Gang wrote:
> On 11/01/2013 04:45 AM, Greg KH wrote:
>> On Thu, Oct 31, 2013 at 12:08:33PM -0700, Kees Cook wrote:
>>> On Thu, Oct 31, 2013 at 12:06 PM, Al Viro wrote:
On Thu, Oct 31, 2013 at 09:53:59AM -0700, Kees Cook wrote:
> If block (type sector_t)
dev_kfree_skb_irq is protected from NULL. No need to check for NULL
while calling this function.
Signed-off-by: Govindarajulu Varadarajan
---
drivers/net/ethernet/amd/ni65.c | 6 ++
drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 10 --
Signed-off-by: Govindarajulu Varadarajan
---
drivers/net/ethernet/sgi/ioc3-eth.c | 4 +---
drivers/net/usb/usbnet.c| 2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c
b/drivers/net/ethernet/sgi/ioc3-eth.c
index 6bd90f2..80dcfd9
dev_kfree_skb_any is protected from NULL. No need to check for NULL
while calling this function.
Signed-off-by: Govindarajulu Varadarajan
---
drivers/usb/gadget/u_ether.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/u_ether.c
dev_kfree_skb_any is protected from NULL. No need to check for NULL
while calling this function.
Signed-off-by: Govindarajulu Varadarajan
---
drivers/isdn/gigaset/ser-gigaset.c | 3 +--
drivers/isdn/hisax/hfc_usb.c | 6 ++
drivers/isdn/hisax/icc.c | 6 ++
dev_kfree_skb_any is protected from NULL. No need to check for NULL
while calling this function.
Signed-off-by: Govindarajulu Varadarajan
---
drivers/infiniband/hw/amso1100/c2.c | 6 ++
drivers/infiniband/hw/nes/nes_hw.c | 3 +--
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git
dev_kfree_skb_any is protected from NULL. No need to check for NULL
while calling this function.
Signed-off-by: Govindarajulu Varadarajan
---
drivers/net/ethernet/amd/lance.c | 9 +++--
drivers/net/ethernet/atheros/alx/main.c | 6 ++
Signed-off-by: Govindarajulu Varadarajan
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 66cad50..e651b8a 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3719,7 +3719,7 @@ sub
dev_kfree_skb_any is protected from NULL. No need to check for NULL
while calling this function.
Signed-off-by: Govindarajulu Varadarajan
---
drivers/s390/net/claw.c | 6 ++
drivers/s390/net/ctcm_mpc.c | 6 ++
drivers/s390/net/qeth_core_main.c | 6 ++
3 files
dev_kfree_skb_irq is protected from NULL. No need to check for NULL while
calling this function.
Signed-off-by: Govindarajulu Varadarajan
---
drivers/staging/slicoss/slicoss.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/slicoss/slicoss.c
dev_kfree_skb_irq is protected from NULL. No need to check for NULL
while calling this function.
Signed-off-by: Govindarajulu Varadarajan
---
drivers/usb/gadget/f_phonet.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/f_phonet.c
dev_kfree_skb_irq is protected from NULL. No need to check for NULL while
calling this function.
Signed-off-by: Govindarajulu Varadarajan
---
drivers/atm/eni.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c
index b1955ba..78a4445 100644
dev_kfree_skb_irq is not NULL safe. The following patch checks skb for NULL in
dev_kfree_skb_irq.
At many places we check for NULL before calling dev_kfree_skb_*(). Moving the
check to dev_kfree_skb_irq_*() removes the reddundant if condition and makes
code simpler.
Also dev_kfree_skb_any
Signed-off-by: Govindarajulu Varadarajan
---
net/core/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 0054c8c..63bd44d 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2146,7 +2146,7 @@ EXPORT_SYMBOL(__netif_schedule);
void
Hi Matt,
On Friday 01 of November 2013 15:45:50 Matt Porter wrote:
> This adds a pair of APIs that allows the generic PHY subsystem to
> provide information on the PHY bus width. The PHY provider driver may
> use phy_set_bus_width() to set the bus width that the PHY supports.
> The controller
Hi Matt.
On Friday 01 of November 2013 15:45:54 Matt Porter wrote:
> Adds support for the generic PHY subsystem. Generic PHY
> support is probed and then the driver falls back to checking
> for an old style USB PHY and pdata if not found.
>
> Signed-off-by: Matt Porter
> ---
>
> How does efivars backend handle "unlink(2)" in the pstore file system.
> pstore will call the backend->erase function passing the "id". The
> backend should then erase the right record from persistent storage.
>
> With the ((timestamp * 100 + part) * 100 + count function - you can
> easily
Hi Linus,
Sorry for this extemely late patch for 3.12 but it causes a SMP build of ARC
to panic in boot.
Greg, the patch as it is doesn't apply to 3.10 (but does to 3.11). So can you
please queue it up for 3.11 and I'll send a fixup for 3.10.
Thx,
-Vineet
Vineet Gupta (1):
ARC: Incorrect mm
1 - 100 of 212 matches
Mail list logo
