From: Andi Kleen
These data structures are accessed by different CPUs and have some
fields which are mostly read only and others which are frequently
written. Separate some common ones into separate cache line
to minimize false sharing while submitting a command.
This allows scsi_dispatch_cmd
From: Andi Kleen
The unlinked open inodes super block counter that was added some time ago
unfortunately becomes a very hot cache line in some delete heavy
high IOPs or tmpfs workloads with enough cores, when files
are frequently removed. With TSX it also causes plenty of aborts.
Turn the
On Fri, Jul 11, 2014 at 11:56:11AM -0700, Havard Skinnemoen wrote:
> > * max number of CMCIs per second a system can sustain fine, i.e. the 100
> > above
>
> What's the definition of "fine"? 1% performance hit? 10%? How can we
> make that decision without knowing how hard the users are pushing
>
Greg KH writes:
> On Fri, Jul 11, 2014 at 10:29:56AM +0200, Peter Zijlstra wrote:
>> On Fri, Jul 11, 2014 at 03:37:17PM +0800, Jiang Liu wrote:
>> > Any comments are welcomed!
>>
>> Why would anybody _ever_ have a memoryless node? That's ridiculous.
>
> I'm with Peter here, why would this be a
On Wed, Jul 09, 2014 at 07:12:09PM -0400, Trond Myklebust wrote:
> Oops. Sorry, the correct sub-sub-sub-sub-paragraph is this one:
>
> Permission to execute a file.
>
> Servers SHOULD allow a user the ability to read the data of the
> file when only the
On Fri, Jul 11, 2014 at 02:05:08PM -0500, Christoph Lameter wrote:
> The use case is pretty straightforward because we are trying to keep as
> much OS noise as possible off most processors. Processor 0 is the
> sacrificial lamb that will be used for all OS processing and hopefully all
> high
Dave,
Please pull this batch of updates intended for the 3.17 stream...
This is primarily a Bluetooth pull. Gustavo says:
"A lot of patches to 3.17. The bulk of changes here are for LE support.
The 6loWPAN over Bluetooth now has it own module, we also have support for
background
On Fri, Jul 11, 2014 at 07:39:29PM +0200, Vincent Guittot wrote:
> In my mind, arch_scale_cpu_freq was intend to scale the capacity of
> the CPU according to the current dvfs operating point.
> As it's no more use anywhere now that we have arch_scale_cpu, we could
> probably remove it .. and see
In the case of HDMI clocks, we want to bypass the RCG's ability
to divide the output clock and pass through the parent HDMI PLL
rate through. Add a simple set of clk_ops to configure the RCG to
do this. This removes the need to keep adding more frequency
entries to the tv_src clock whenever we
On 07/11/2014 03:54 PM, Daniel Kiper wrote:
Compiler complains in the following way when x86 32-bit kernel
with Xen support is build:
CC arch/x86/xen/enlighten.o
arch/x86/xen/enlighten.c: In function ‘xen_start_kernel’:
arch/x86/xen/enlighten.c:1726:3: warning: right shift count >=
- Original Message -
> From: "Thomas Gleixner"
> To: "LKML"
> Cc: "John Stultz" , "Peter Zijlstra"
> , "Steven Rostedt"
> , "Mathieu Desnoyers"
> Sent: Friday, July 11, 2014 9:45:19 AM
> Subject: [patch 54/55] timekeeping: Provide fast and NMI safe access to
> CLOCK_MONOTONIC[_RAW]
>
On Fri, Jul 11, 2014 at 04:03:46PM -0400, Boris Ostrovsky wrote:
> On 07/11/2014 03:54 PM, Daniel Kiper wrote:
> >Compiler complains in the following way when x86 32-bit kernel
> >with Xen support is build:
> >
> > CC arch/x86/xen/enlighten.o
> >arch/x86/xen/enlighten.c: In function
I'm going to reply with multiple mails so that we can keep the things
separate and not let replies grow out of proportion.
On Fri, Jul 11, 2014 at 11:56:11AM -0700, Havard Skinnemoen wrote:
> So a short burst of CMCIs would send us instantly into polling mode,
> which would probably be suboptimal
On Wed 2014-07-02 11:40:50, Christoph Hellwig wrote:
> On Wed, Jul 02, 2014 at 11:55:41AM -0400, Jeff Moyer wrote:
> > It's acceptable.
>
> It's not because it will then also affect other reads going on at the
> same time.
>
> The whole concept of ima is just broken, and if you want to do these
Please pull another nfsd bugfix from
git://linux-nfs.org/~bfields/linux.git for-3.16
Another xdr encoding regression that may cause incorrect encoding on
failures of certain readdirs.
--b.
Kinglong Mee (1):
nfsd: Fix bad
On Fri, 2014-07-11 at 12:31 -0700, Eric Northup wrote:
> On Fri, Jul 11, 2014 at 10:56 AM, Alex Williamson
> wrote:
> > Windows 8.1 guest with NVIDIA driver and GPU fails to boot with an
> > emulation failure. The KVM spew suggests the fault is with lack of
> > movntdq emulation (courtesy of
On Fri, Jul 11, 2014 at 12:22:17PM +0800, Wanpeng Li wrote:
> This bug can be trigger by L1 goes down directly w/ enable_shadow_vmcs.
>
> [ 6413.158950] kvm: vmptrld (null)/7800 failed
> [ 6413.158954] vmwrite error: reg 401e value 4 (err 1)
> [ 6413.158957] CPU: 0 PID: 4840
On 07/11/2014 08:33 AM, Greg KH wrote:
> On Fri, Jul 11, 2014 at 10:29:56AM +0200, Peter Zijlstra wrote:
>> > On Fri, Jul 11, 2014 at 03:37:17PM +0800, Jiang Liu wrote:
>>> > > Any comments are welcomed!
>> >
>> > Why would anybody _ever_ have a memoryless node? That's ridiculous.
> I'm with
On Fri, Jul 11, 2014 at 12:50:15AM +0300, Oded Gabbay wrote:
> This patch adds the interrupt handling module, in kfd_interrupt.c,
> and its related members in different data structures to the KFD
> driver.
>
> The KFD interrupt module maintains an internal interrupt ring per kfd
> device. The
Hi,
Here are two patches that follow earlier Xen dom0 EFI series and
fix some compiler warnings found during detailed build tests.
Both patches should be applied to:
git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/efi.git next
Daniel
PS I will be on vacation from 14th Jul till 25th
Add inline keyword to silence the following compiler
warnings if xen_efi_probe() is not used:
CC arch/x86/xen/setup.o
In file included from arch/x86/xen/xen-ops.h:7:0,
from arch/x86/xen/setup.c:31:
include/xen/xen-ops.h:43:35: warning: ‘xen_efi_probe’ defined but not used
Compiler complains in the following way when x86 32-bit kernel
with Xen support is build:
CC arch/x86/xen/enlighten.o
arch/x86/xen/enlighten.c: In function ‘xen_start_kernel’:
arch/x86/xen/enlighten.c:1726:3: warning: right shift count >= width of type
[enabled by default]
Such line
On Fri, Jul 11, 2014 at 12:43:14PM -0700, Paul E. McKenney wrote:
> On Fri, Jul 11, 2014 at 09:26:14PM +0200, Frederic Weisbecker wrote:
> > On Fri, Jul 11, 2014 at 12:08:16PM -0700, Paul E. McKenney wrote:
> > > On Fri, Jul 11, 2014 at 08:57:33PM +0200, Frederic Weisbecker wrote:
> > > > On Fri,
On Fri, Jul 11, 2014 at 12:06:40PM -0700, Tony Luck wrote:
> > + if (atomic_add_unless(_banks[i].poll_reader, 1, 1)) {
> > + m.status = mce_rdmsrl(MSR_IA32_MCx_STATUS(i));
>
> Same as yesterday. You may skip reading a bank because someone else
> is reading the
On Fri, Jul 11, 2014 at 09:26:14PM +0200, Frederic Weisbecker wrote:
> On Fri, Jul 11, 2014 at 12:08:16PM -0700, Paul E. McKenney wrote:
> > On Fri, Jul 11, 2014 at 08:57:33PM +0200, Frederic Weisbecker wrote:
> > > On Fri, Jul 11, 2014 at 11:45:28AM -0700, Paul E. McKenney wrote:
> > > > On Fri,
The advantage of kcalloc is, that will prevent integer overflows
which could result from the multiplication of number of elements
and size and it is also a bit nicer to read.
Signed-off-by: Himangi Saraogi
Acked-by: Julia Lawall
---
A patch on top of my char-misc tree as the kzalloc version is
On Fri, Jul 11, 2014 at 08:29:56AM +0200, Daniel Vetter wrote:
> On Thu, Jul 10, 2014 at 09:08:24PM +, Tian, Kevin wrote:
> > actually I'm curious whether it's still necessary to __detect__ PCH. Could
> > we assume a 1:1 mapping between GPU and PCH, e.g. BDW already hard
> > code the
Thanks Bartlomiej for the advice,
I will give it a try and see.
On 11/07/14 15:33, Bartlomiej Zolnierkiewicz wrote:
struct qcom_apq8064_sata_phy {
> >>+ void __iomem *mmio;
> >>+ struct clk *cfg_clk;
> >>+ struct device *dev;
> >>+};
> >>+
> >>+/* Helper function to do poll and timeout */
>
On Fri, Jul 11, 2014 at 08:54:01PM +0300, Andrey Utkin wrote:
> 2014-07-11 17:38 GMT+03:00 Ian Abbott :
> > Signed-off-by: Andrey Utkin
>
> I think it's incorrect that you have instantly placed my signoff
> statement on this new patch.
Ian gave you credit but also wrote in the changelog that he
On Fri, 2014-07-11 at 15:22 -0400, Jerome Glisse wrote:
> Just to be explicit, my point is that is you claim GPL in MODULE_LICENSE
> then this is a GPL licensed code, if you claim GPL with additional rights
> than this is dual licensed code. This is how i read and interpret this
> with additional
On 11/07/14 14:49, Linus Walleij wrote:
On Fri, Jul 11, 2014 at 1:48 PM, Srinivas Kandagatla
wrote:
On Qualcomm APQ8064 SOCs, SD card controller has an additional glue
called DML (Data Mover Local/Lite) to assist dma transfers.
This hardware needs to be setup before any dma transfer is
On Friday, July 11, 2014 02:31:06 PM Eric Paris wrote:
> On Fri, 2014-07-11 at 12:32 -0400, Paul Moore wrote:
> > On Friday, July 11, 2014 12:23:33 PM Eric Paris wrote:
...
> > > So we have a security interface that is damn near impossible to get
> > > right. Perfect.
> >
> > What? Having to
On 11/07/2014 09:34 μμ, Pavel Machek wrote:
> On Fri 2014-07-11 20:29:57, Stratos Karafotis wrote:
>> Hi Pavel!
>>
>> On 11/07/2014 07:57 μμ, Pavel Machek wrote:
>>> Hi!
>>>
Tested on Intel i7-3770 CPU @ 3.40GHz and on ARM quad core 1500MHz Krait
(Android smartphone).
Benchmarks on
On Fri, Jul 11, 2014 at 10:56 AM, Alex Williamson
wrote:
> Windows 8.1 guest with NVIDIA driver and GPU fails to boot with an
> emulation failure. The KVM spew suggests the fault is with lack of
> movntdq emulation (courtesy of Paolo):
>
> Code=02 00 00 b8 08 00 00 00 f3 0f 6f 44 0a f0 f3 0f 6f
On Wed 2014-06-18 20:59:08, Russell King - ARM Linux wrote:
> On Wed, Jun 18, 2014 at 09:09:58PM +0200, Pali Rohár wrote:
> > On Wednesday 18 June 2014 21:01:09 Russell King - ARM Linux
> > wrote:
> > > On Wed, Jun 18, 2014 at 06:54:24PM +0200, Pali Rohár wrote:
> > > > Machine name from board
On Thu 2014-06-19 00:10:39, Aaro Koskinen wrote:
> Hi,
>
> On Wed, Jun 18, 2014 at 09:22:29PM +0200, Pali Rohár wrote:
> > So without this patch DT migration for Nokia N900 cannot be done
> > without breaking userspace - which is not acceptable...
>
> I guess the fact is that the Nokia N900
On Mon 2014-07-07 10:39:08, Daniel Vetter wrote:
> On Fri, Jun 27, 2014 at 03:37:16PM +0200, Jiri Kosina wrote:
> > On Thu, 26 Jun 2014, Pavel Machek wrote:
> >
> > > Ok, so I have set up machines for ktest / autobisect, and found out that
> > > 3.16-rc1 no longer has that problem. Oh well,
On Fri, Jul 11, 2014 at 12:08:16PM -0700, Paul E. McKenney wrote:
> On Fri, Jul 11, 2014 at 08:57:33PM +0200, Frederic Weisbecker wrote:
> > On Fri, Jul 11, 2014 at 11:45:28AM -0700, Paul E. McKenney wrote:
> > > On Fri, Jul 11, 2014 at 08:25:43PM +0200, Frederic Weisbecker wrote:
> > > > On Fri,
From: Ionut Alexa
Fixed coding style issues.
Signed-off-by: Ionut Alexa
---
tools/thermal/tmon/tmon.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tools/thermal/tmon/tmon.c b/tools/thermal/tmon/tmon.c
index 09b7c32..bffd3d9 100644
---
From: Tom Gundersen
Date: Thu, 10 Jul 2014 23:01:06 +0200
> This passes down NET_NAME_USER (or NET_NAME_ENUM) to alloc_netdev(),
> for any device created over rtnetlink.
>
> Signed-off-by: Tom Gundersen
> ---
> drivers/net/veth.c | 11 ---
> include/net/rtnetlink.h | 1 +
>
From: Tom Gundersen
Date: Thu, 10 Jul 2014 23:01:03 +0200
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 30eedf6..392c784 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -6438,11 +6438,12 @@ void netdev_freemem(struct net_device *dev)
>
> /**
> * alloc_netdev_mqs -
On Fri, Jul 11, 2014 at 06:56:12PM +, Bridgman, John wrote:
> >From: Jerome Glisse [mailto:j.gli...@gmail.com]
> >Sent: Friday, July 11, 2014 2:52 PM
> >To: Bridgman, John
> >Cc: Oded Gabbay; David Airlie; Deucher, Alexander; linux-
> >ker...@vger.kernel.org; dri-de...@lists.freedesktop.org;
From: Ionut Alexa
Fixed coding style issues.
Signed-off-by: Ionut Alexa
---
kernel/cgroup.c | 36 ++--
1 file changed, 22 insertions(+), 14 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 70776ae..fb6a4fd 100644
--- a/kernel/cgroup.c
+++
On Fri, Jul 11, 2014 at 12:50:13AM +0300, Oded Gabbay wrote:
> This patch adds 2 new IOCTL to kfd driver.
>
> The first IOCTL is KFD_IOC_CREATE_QUEUE that is used by the user-mode
> application to create a compute queue on the GPU.
>
> The second IOCTL is KFD_IOC_DESTROY_QUEUE that is used by
On Fri, 11 Jul 2014, Tejun Heo wrote:
> On Fri, Jul 11, 2014 at 12:29:30PM -0500, Christoph Lameter wrote:
> > GFP_THISNODE is mostly used by allocators that need memory from specific
> > nodes. The use of numa_mem_id() there is useful because one will not
> > get any memory at all when
On Fri, Jul 11, 2014 at 02:05:08PM -0500, Christoph Lameter wrote:
> On Fri, 11 Jul 2014, Frederic Weisbecker wrote:
>
> > > That would imply that all no-nohz processors are housekeeping? So all
> > > processors with a tick are housekeeping?
> >
> > Well, now that I think about it again, I would
From: Konrad Rzeszutek Wilk
Cleanup the function a bit - also include the id of the
domain that is using the device.
Reviewed-by: David Vrabel
Signed-off-by: Konrad Rzeszutek Wilk
---
drivers/xen/xen-pciback/pci_stub.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff
From: Konrad Rzeszutek Wilk
Which hadn't been done with the initial commit.
Signed-off-by: Konrad Rzeszutek Wilk
---
v2: Dropped the parameters and one that is unlikeable.
---
Documentation/ABI/testing/sysfs-driver-pciback | 25
1 files changed, 25 insertions(+), 0
Please see this set of patches which are fixes to Xen pciback
for 3.17. They are also located at:
git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git
devel/pciback-3.17.v4
These patches do not include the PCI bus reset/slot code as we are still
discussing that.
Konrad Rzeszutek Wilk
alloc_trace_uprobe() sets TRACE_EVENT_FL_USE_CALL_FILTER for unknown
reason and this is simply wrong. Fortunately this has no effect because
register_uprobe_event() clears call->flags after that.
Kill both. This trace_uprobe was kzalloc'ed and we realy on this fact
anyway.
Signed-off-by: Oleg
filter_free_subsystem_preds() and filter_free_subsystem_filters()
can rely on file->system->subsystem and avoid strcmp().
Signed-off-by: Oleg Nesterov
---
kernel/trace/trace_events_filter.c |9 ++---
1 files changed, 2 insertions(+), 7 deletions(-)
diff --git
destroy_preds() makes no any sense.
The only caller, event_remove(), actually wants destroy_file_preds().
__trace_remove_event_call() does destroy_call_preds() which takes care
of call->filter.
And after the previous change we can simply remove destroy_preds() from
event_remove(), we are going
Remove destroy_call_preds(). Its only caller, __trace_remove_event_call(),
can use free_event_filter() and nullify ->filter by hand.
Perhaps we could keep this trivial helper although imo it is pointless, but
then it should be static in trace_events.c.
Signed-off-by: Oleg Nesterov
---
It seems that the only purpose of call_filter_disable() is to
make filter_disable() less clear and symmetrical, remove it.
Signed-off-by: Oleg Nesterov
---
kernel/trace/trace_events_filter.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git
Remove ftrace_event_call->files. It has no users, and in fact even
the commit ae63b31e4d0e "tracing: Separate out trace events from
global variables" which added this member did not use it.
Signed-off-by: Oleg Nesterov
---
include/linux/ftrace_event.h |1 -
1 files changed, 0 insertions(+),
On Fri, Jul 11, 2014 at 08:57:33PM +0200, Frederic Weisbecker wrote:
> On Fri, Jul 11, 2014 at 11:45:28AM -0700, Paul E. McKenney wrote:
> > On Fri, Jul 11, 2014 at 08:25:43PM +0200, Frederic Weisbecker wrote:
> > > On Fri, Jul 11, 2014 at 01:10:41PM -0500, Christoph Lameter wrote:
> > > > On Tue,
instance_rmdir() path destroys the event files but forgets to free
file->filter. Change remove_event_file_dir() to free_event_filter().
Signed-off-by: Oleg Nesterov
---
kernel/trace/trace_events.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git
Hello,
Sorry for delay, I was distracted by other problems.
To remind, we discussed the potential uprobes "mix perf/ftrace" changes and
found some off-topic problems. Lets start with ->filter fixes/cleanups.
So far I didn't even try to test this series, although it looks simple except
perhaps
From: Konrad Rzeszutek Wilk
A little cleanup. No functional difference.
Signed-off-by: Konrad Rzeszutek Wilk
---
drivers/xen/xen-pciback/pci_stub.c | 20 +++-
1 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/xen/xen-pciback/pci_stub.c
From: Konrad Rzeszutek Wilk
As commit 0a9fd0152929db372ff61b0d6c280fdd34ae8bdb
'xen/pciback: Document the entry points for 'pcistub_put_pci_dev''
explained there are four entry points in this function.
Two of them are when the user fiddles in the SysFS to
unbind a device which might be in use by
From: Konrad Rzeszutek Wilk
We had been printing it only if the device was built with
debug enabled. But this information is useful in the field
to troubleshoot.
Reviewed-by: David Vrabel
Signed-off-by: Konrad Rzeszutek Wilk
---
drivers/xen/xen-pciback/xenbus.c |2 +-
1 files changed, 1
> + if (atomic_add_unless(_banks[i].poll_reader, 1, 1)) {
> + m.status = mce_rdmsrl(MSR_IA32_MCx_STATUS(i));
Same as yesterday. You may skip reading a bank because someone else
is reading the same bank number, even though you don't share that bank
with them.
>-Original Message-
>From: Jerome Glisse [mailto:j.gli...@gmail.com]
>Sent: Friday, July 11, 2014 2:52 PM
>To: Bridgman, John
>Cc: Oded Gabbay; David Airlie; Deucher, Alexander; linux-
>ker...@vger.kernel.org; dri-de...@lists.freedesktop.org; Lewycky, Andrew;
>Joerg Roedel; Gabbay, Oded;
On Fri, 11 Jul 2014, Frederic Weisbecker wrote:
> > That would imply that all no-nohz processors are housekeeping? So all
> > processors with a tick are housekeeping?
>
> Well, now that I think about it again, I would really like to keep
> housekeeping
> to CPU 0 when nohz_full= is passed.
>-Original Message-
>From: Jerome Glisse [mailto:j.gli...@gmail.com]
>Sent: Friday, July 11, 2014 2:11 PM
>To: Bridgman, John
>Cc: Oded Gabbay; David Airlie; Deucher, Alexander; linux-
>ker...@vger.kernel.org; dri-de...@lists.freedesktop.org; Lewycky, Andrew;
>Joerg Roedel; Gabbay, Oded;
On Fri, Jul 11, 2014 at 11:45:28AM -0700, Paul E. McKenney wrote:
> On Fri, Jul 11, 2014 at 08:25:43PM +0200, Frederic Weisbecker wrote:
> > On Fri, Jul 11, 2014 at 01:10:41PM -0500, Christoph Lameter wrote:
> > > On Tue, 8 Jul 2014, Frederic Weisbecker wrote:
> > >
> > > > > I was figuring that
On Fri, Jul 11, 2014 at 8:35 AM, Borislav Petkov wrote:
> So, with roughly few hundred CMCIs per second, we can be generous and
> say we can handle 100 CMCIs per second just fine. Which would mean, if
> the CMCI handler takes 10ms, with 100 CMCIs per second, we spend the
> whole time handling
From: Konrad Rzeszutek Wilk
By default when CONFIG_XEN and CONFIG_XEN_PVHVM kernels are
run, they will enable the PV extensions (drivers, interrupts, timers,
etc) - which is the best option for the majority of
use cases.
However, in some cases (kexec not fully working, benchmarking)
we want to
On Fri, Jul 11, 2014 at 06:46:30PM +, Bridgman, John wrote:
> >From: Jerome Glisse [mailto:j.gli...@gmail.com]
> >Sent: Friday, July 11, 2014 2:11 PM
> >To: Bridgman, John
> >Cc: Oded Gabbay; David Airlie; Deucher, Alexander; linux-
> >ker...@vger.kernel.org; dri-de...@lists.freedesktop.org;
On Fri, Jul 11, 2014 at 12:50:12AM +0300, Oded Gabbay wrote:
> This patch adds the kfd mmap handler that maps the physical address
> of a doorbell page to a user-space virtual address. That virtual address
> belongs to the process that uses the doorbell page.
>
> This mmap handler is called only
On Fri, Jul 11, 2014 at 08:25:43PM +0200, Frederic Weisbecker wrote:
> On Fri, Jul 11, 2014 at 01:10:41PM -0500, Christoph Lameter wrote:
> > On Tue, 8 Jul 2014, Frederic Weisbecker wrote:
> >
> > > > I was figuring that a fair number of the kthreads might eventually
> > > > be using this, not
On Fri, Jul 11, 2014 at 01:44:08PM -, Thomas Gleixner wrote:
> From: John Stultz
> +/*
> + * timespec64_add_safe assumes both values are positive and checks
> + * for overflow. It will return TIME_T_MAX if the reutrn would be
^^
On Fri, Jul 11, 2014 at 11:12 AM, Andi Kleen wrote:
>> diff --git a/arch/x86/include/uapi/asm/sigcontext.h
>> b/arch/x86/include/uapi/asm/sigcontext.h
>> index 076b11f..df9908b 100644
>> --- a/arch/x86/include/uapi/asm/sigcontext.h
>> +++ b/arch/x86/include/uapi/asm/sigcontext.h
>
> I don't
This series is ver.5 of page table walker patchset.
I fixed the buffer overflow problem in mincore().
And I rebased this onto mmotm-2014-07-09-17-08.
Trinity shows no bug at least in my environment.
Thanks,
Naoya Horiguchi
Tree: g...@github.com:Naoya-Horiguchi/linux.git
Branch:
pagewalk.c can handle vma in itself, so we don't have to pass vma via
walk->private. And both of mem_cgroup_count_precharge() and
mem_cgroup_move_charge() do for each vma loop themselves, but now it's
done in pagewalk.c, so let's clean up them.
ChangeLog v4:
- use walk_page_range() instead of
Introduces walk_page_vma(), which is useful for the callers which want to
walk over a given vma. It's used by later patches.
ChangeLog v3:
- check walk_page_test's return value instead of walk->skip
Signed-off-by: Naoya Horiguchi
Acked-by: Kirill A. Shutemov
---
include/linux/mm.h | 1 +
clear_refs_write() has some prechecks to determine if we really walk over
a given vma. Now we have a test_walk() callback to filter vmas, so let's
utilize it.
ChangeLog v5:
- remove unused vma
ChangeLog v4:
- use walk_page_range instead of walk_page_vma with for loop
Signed-off-by: Naoya
pagewalk.c can handle vma in itself, so we don't have to pass vma via
walk->private. And show_smap() walks pages on vma basis, so using
walk_page_vma() is preferable.
ChangeLog v4:
- remove redundant vma
Signed-off-by: Naoya Horiguchi
Acked-by: Kirill A. Shutemov
---
fs/proc/task_mmu.c | 9
When posting new versions of patches, you must resubmit the entire
series, not just the patch which is changing.
Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
From: "Kirill A. Shutemov"
Currently pagewalker splits all THP pages on any clear_refs request. It's
not necessary. We can handle this on PMD level.
One side effect is that soft dirty will potentially see more dirty memory,
since we will mark whole THP page dirty at once.
Sanity checked with
This patch makes do_mincore() use walk_page_vma(), which reduces many lines
of code by using common page table walk code.
ChangeLog v5:
- fix buffer overflow
ChangeLog v4:
- remove redundant vma
ChangeLog v3:
- add NULL vma check in mincore_unmapped_range()
- don't use pte_entry()
ChangeLog
Just doing s/gather_hugetbl_stats/gather_hugetlb_stats/g, this makes code
grep-friendly.
Signed-off-by: Naoya Horiguchi
Acked-by: Kirill A. Shutemov
---
fs/proc/task_mmu.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git mmotm-2014-07-09-17-08.orig/fs/proc/task_mmu.c
Currently no user of page table walker sets ->pgd_entry() or ->pud_entry(),
so checking their existence in each loop is just wasting CPU cycle.
So let's remove it to reduce overhead.
Signed-off-by: Naoya Horiguchi
Acked-by: Kirill A. Shutemov
---
include/linux/mm.h | 6 --
mm/pagewalk.c
queue_pages_range() does page table walking in its own way now, but there
is some code duplicate. This patch applies page table walker to reduce
lines of code.
queue_pages_range() has to do some precheck to determine whether we really
walk over the vma or just skip it. Now we have test_walk()
Current implementation of page table walker has a fundamental problem
in vma handling, which started when we tried to handle vma(VM_HUGETLB).
Because it's done in pgd loop, considering vma boundary makes code
complicated and bug-prone.
>From the users viewpoint, some user checks some vma-related
We don't have to use mm_walk->private to pass vma to the callback function
because of mm_walk->vma. And walk_page_vma() is useful if we walk over a
single vma.
Signed-off-by: Naoya Horiguchi
Acked-by: Kirill A. Shutemov
---
arch/powerpc/mm/subpage-prot.c | 6 ++
1 file changed, 2
Page table walker has the information of the current vma in mm_walk, so
we don't have to call find_vma() in each pagemap_hugetlb_range() call.
NULL-vma check is omitted because we assume that we never run hugetlb_entry()
callback on the address without vma. And even if it were broken, null
pagewalk.c can handle vma in itself, so we don't have to pass vma via
walk->private. And show_numa_map() walks pages on vma basis, so using
walk_page_vma() is preferable.
ChangeLog v4:
- remove redundant vma
Signed-off-by: Naoya Horiguchi
Acked-by: Kirill A. Shutemov
---
fs/proc/task_mmu.c |
On Fri, 11 Jul 2014 20:09:26 +0200
Ard Biesheuvel wrote:
> On 11 July 2014 17:40, Ard Biesheuvel wrote:
> > On 11 July 2014 17:30, Steven Rostedt wrote:
> >> On Fri, 11 Jul 2014 08:12:40 -0700
> >> "Paul E. McKenney" wrote:
> >>
> >>> On Fri, Jul 11, 2014 at 01:38:12PM +0200, Ard Biesheuvel
On Fri 2014-07-11 20:29:57, Stratos Karafotis wrote:
> Hi Pavel!
>
> On 11/07/2014 07:57 μμ, Pavel Machek wrote:
> > Hi!
> >
> >> Tested on Intel i7-3770 CPU @ 3.40GHz and on ARM quad core 1500MHz Krait
> >> (Android smartphone).
> >> Benchmarks on Intel i7 shows a performance improvement on low
On 07/11/14 00:18, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20140710:
>
on x86_64:
CONFIG_DVB_AV7110=y
CONFIG_INPUT_EVDEV=m
drivers/built-in.o: In function `av7110_emit_keyup':
av7110_ir.c:(.text+0x76b608): undefined reference to `input_event'
av7110_ir.c:(.text+0x76b61a):
On Fri, 2014-07-11 at 12:32 -0400, Paul Moore wrote:
> On Friday, July 11, 2014 12:23:33 PM Eric Paris wrote:
> > On Fri, 2014-07-11 at 12:21 -0400, Paul Moore wrote:
> > > On Friday, July 11, 2014 12:16:47 PM Eric Paris wrote:
> > > > On Fri, 2014-07-11 at 12:11 -0400, Paul Moore wrote:
> > > > >
On Fri, Jul 11, 2014 at 01:10:41PM -0500, Christoph Lameter wrote:
> On Tue, 8 Jul 2014, Frederic Weisbecker wrote:
>
> > > I was figuring that a fair number of the kthreads might eventually
> > > be using this, not just for the grace-period kthreads.
> >
> > Ok makes sense. But can we just
Hello,
On Fri, Jul 11, 2014 at 12:29:30PM -0500, Christoph Lameter wrote:
> GFP_THISNODE is mostly used by allocators that need memory from specific
> nodes. The use of numa_mem_id() there is useful because one will not
> get any memory at all when attempting to allocate from a memoryless
> node
On 07/10/2014 06:53 PM, Steven Rostedt wrote:
On Thu, 10 Jul 2014 17:22:45 -0400
Josef Bacik wrote:
Hello,
I'm trying to build some custom tracing tools on top of trace-cmd but they
aren't really usefull outside of Facebook so I don't want to shove them into the
actual trace-cmd project.
On Fri, Jul 11, 2014 at 01:10:41PM -0500, Christoph Lameter wrote:
> On Tue, 8 Jul 2014, Frederic Weisbecker wrote:
>
> > > I was figuring that a fair number of the kthreads might eventually
> > > be using this, not just for the grace-period kthreads.
> >
> > Ok makes sense. But can we just
On Fri, Jul 11, 2014 at 12:50:11AM +0300, Oded Gabbay wrote:
> This patch adds the code base of the scheduler, which handles queue
> creation, deletion and scheduling on the CP of the GPU.
>
> Signed-off-by: Oded Gabbay
I would rather see all this squashed, this gave feeling that driver
can
Hi Linus,
Please pull the arm64 fixes below. Thanks.
The following changes since commit cd3de83f147601356395b57a8673e9c5ff1e59d1:
Linux 3.16-rc4 (2014-07-06 12:37:51 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux tags/arm64-fixes
> diff --git a/arch/x86/include/uapi/asm/sigcontext.h
> b/arch/x86/include/uapi/asm/sigcontext.h
> index 076b11f..df9908b 100644
> --- a/arch/x86/include/uapi/asm/sigcontext.h
> +++ b/arch/x86/include/uapi/asm/sigcontext.h
I don't think renaming fields in uapi/asm is acceptable. These
are likely
On Fri, Jul 11, 2014 at 1:38 AM, Fabio Coatti wrote:
> In data giovedì 10 luglio 2014 14:05:27, Bjorn Helgaas ha scritto:
>> ...
>> Fabio, can you pastebin your complete dmesg log?
>
> Sure, here you go:
>
> http://pastebin.com/FiL7N64b
I opened this bugzilla:
201 - 300 of 1880 matches
Mail list logo
