Re: [PATCH] Input: xpad - use LED API when identifying wireless controllers

2015-12-19 Thread Dmitry Torokhov
On Sat, Dec 19, 2015 at 10:17:09PM +0100, Clement Calmels wrote: > On Wed, 16 Dec 2015 14:44:08 -0800 > Dmitry Torokhov wrote: > > > When lighting up the segment identifying wireless controller, Instead > > of sending command directly to the controller, let's do it via LED > > API (usinf

Re: [PATCH v3 2/5] thermal: rockchip: fix a impossible condition caused by the warning

2015-12-19 Thread Caesar Wang
在 2015年12月04日 04:19, Dmitry Torokhov 写道: On Thu, Dec 03, 2015 at 04:48:40PM +0800, Caesar Wang wrote: As the Dan report the smatch check the thermal driver warning: drivers/thermal/rockchip_thermal.c:551 rockchip_configure_from_dt() warn: impossible condition '(thermal->tshut_temp > ((~0 >>

Re: [patch 3/5] futex: Document pi_state refcounting in requeue code

2015-12-19 Thread Darren Hart
On Sat, Dec 19, 2015 at 08:07:39PM -, Thomas Gleixner wrote: > Documentation of the pi_state refcounting in the requeue code is non > existent. Add it. > OK, one nitpic on this one I guess - 80 characters is pretty narrow as it is in my humble opinion, could we expand the newly added comment

Re: [patch 5/5] futex: Cleanup the goto confusion in requeue_pi()

2015-12-19 Thread Darren Hart
On Sun, Dec 20, 2015 at 06:40:07AM +0100, Mike Galbraith wrote: > On Sat, 2015-12-19 at 21:15 -0800, Darren Hart wrote: > > > As a follow-on, I think it might be worthwhile to create a symmetrical > > get_pi_state() to the put_pi_state(), rather than handling the atomic_inc > > directly. > >

Re: [BUG, bisect, linux-next] do_IRQ: No irq handler for vector

2015-12-19 Thread Jeremiah Mahler
Jiang Liu, On Thu, Dec 17, 2015 at 07:40:33PM -0800, Jeremiah Mahler wrote: > all, > > I just started getting these "No irq handler for vector" messages > after upgrading to linux-next 20151217+. > > > (from the first boot) > ... > [2.282652] [drm] Initialized drm 1.1.0 20060810 > [

Re: [PATCH] bluetooth:Fix variable assignment for internal function returns in the function l2cap_bredr_sig_cmd

2015-12-19 Thread Marcel Holtmann
Hi Nick, > This makes all internal functions that can return a error code to > properly signal this to the caller of the function l2cap_bredr_sig_cmd > by making their return value equal to the variable err before returning > to the caller of the function l2cap_bredr_sig_cmd with this value > as

Re: [PATCH powerpc/next v6 0/4] atomics: powerpc: Implement relaxed/acquire/release variants

2015-12-19 Thread Boqun Feng
On Fri, Dec 18, 2015 at 09:12:50AM -0800, Davidlohr Bueso wrote: > I've left this series testing overnight on a power7 box and so far so good, > nothing has broken. Davidlohr, thank you for your testing! Regards, Boqun signature.asc Description: PGP signature

Re: [PATCH 1/2] mm, oom: introduce oom reaper

2015-12-19 Thread Tetsuo Handa
Tetsuo Handa wrote: > Complete log is at http://I-love.SAKURA.ne.jp/tmp/serial-20151218.txt.xz . > -- > [ 438.304082] Killed process 12680 (oom_reaper-test) total-vm:4324kB, > anon-rss:120kB, file-rss:0kB, shmem-rss:0kB > [ 439.318951] oom_reaper: attempts=11 > [ 445.581171]

Re: [PATCH 01/14] Bluetooth: use list_for_each_entry*

2015-12-19 Thread Marcel Holtmann
Hi Geliang, > Use list_for_each_entry*() instead of list_for_each*() to simplify > the code. > > Signed-off-by: Geliang Tang > --- > net/bluetooth/af_bluetooth.c | 12 ++-- > net/bluetooth/cmtp/capi.c| 8 ++-- > net/bluetooth/hci_core.c | 8 +++- >

[PATCH] XFS: Use a signed return type for suffix_kstrtoint()

2015-12-19 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 20 Dec 2015 07:56:36 +0100 The return type "unsigned long" was used by the suffix_kstrtoint() function even though it will eventually return a negative error code. Improve this implementation detail by using the type "int" instead. This issue was detected by

Re: [patch 5/5] futex: Cleanup the goto confusion in requeue_pi()

2015-12-19 Thread Darren Hart
On Sat, Dec 19, 2015 at 09:15:24PM -0800, Darren Hart wrote: > > As a follow-on, I think it might be worthwhile to create a symmetrical > get_pi_state() to the put_pi_state(), rather than handling the atomic_inc > directly. > > And finally, while the break; in futex_requeue works, that function

Re: [patch 5/5] futex: Cleanup the goto confusion in requeue_pi()

2015-12-19 Thread Mike Galbraith
On Sat, 2015-12-19 at 21:15 -0800, Darren Hart wrote: > As a follow-on, I think it might be worthwhile to create a symmetrical > get_pi_state() to the put_pi_state(), rather than handling the atomic_inc > directly. Ditto, immediate thought was future auditors will look for it. -Mike --

Re: [PATCH] futex: Prevent pi_state from double freeing in case of error

2015-12-19 Thread Darren Hart
On Sat, Dec 19, 2015 at 07:24:38PM +0100, Thomas Gleixner wrote: > - Why are the reviews so sloppy and useless? > >The one I'm answering to is just hillarious and the other one picks >a random commit, claims that it inadvertantly introduced the issue >and is done with it. Really

RE: [PATCH v9 0/7] PCI: hv: New paravirtual PCI front-end for Hyper-V VMs

2015-12-19 Thread KY Srinivasan
> -Original Message- > From: Thomas Gleixner [mailto:t...@linutronix.de] > Sent: Saturday, December 19, 2015 12:21 PM > To: KY Srinivasan > Cc: Jake Oshins ; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com;

Re: [patch 5/5] futex: Cleanup the goto confusion in requeue_pi()

2015-12-19 Thread Darren Hart
On Sat, Dec 19, 2015 at 08:07:41PM -, Thomas Gleixner wrote: > out_unlock: does not only drop the locks, it also drops the refcount > on the pi_state. Really intuitive. > > Move the label after the put_pi_state() call and use 'break' in the > error handling path of the requeue loop. > >

[PATCH] README: remove LILO

2015-12-19 Thread Diego Viola
Remove LILO from the README in order to keep the booting section agnostic. LILO development has also officially stopped. Signed-off-by: Diego Viola --- README | 36 ++-- 1 file changed, 10 insertions(+), 26 deletions(-) diff --git a/README b/README index

[PATCH v2] sc16is7xx: fix incorrect register bits macro

2015-12-19 Thread Wills Wang
In datasheet, Modem Status Register MSR[4-7] reflect the modem pins CTS/DSR/RI/CD signal state. Signed-off-by: Wills Wang --- drivers/tty/serial/sc16is7xx.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial/sc16is7xx.c

RE: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-12-19 Thread Ramneek Mehresh
> -Original Message- > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Saturday, October 10, 2015 3:04 AM > To: Mehresh Ramneek-B31383 ; linux- > ker...@vger.kernel.org > Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux- > u...@vger.kernel.org; Mehresh Ramneek-B31383 >

Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance

2015-12-19 Thread H. Peter Anvin
On December 19, 2015 8:11:50 PM PST, ebied...@xmission.com wrote: >ebied...@xmission.com (Eric W. Biederman) writes: > In that system ptys simply did not work after boot when I tested associating /dev/ptmx with the first mount of the devpts >filesystem. >>> >>> Assuming userspace isn't

Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance

2015-12-19 Thread Eric W. Biederman
ebied...@xmission.com (Eric W. Biederman) writes: >>> In that system ptys simply did not work after boot when I tested >>> associating /dev/ptmx with the first mount of the devpts filesystem. >> >> Assuming userspace isn't broken by that patch, is a fixed association >> with first mount otherwise

[PATCH v6] Fix INT1 Recursion with unregistered breakpoints

2015-12-19 Thread Jeff Merkey
Please consider the attached patch. SUMMARY This patch corrects a hard lockup failure of the system kernel if the operating system receives a breakpoint exception at a code execution address which was not registered with the operating system. The patch allows kernel debuggers, application

Re: [PATCH v2 2/2] mfd: arizona: Update binding docs for selecting mono/stereo outputs

2015-12-19 Thread Rob Herring
On Mon, Dec 14, 2015 at 10:19:12AM +, Charles Keepax wrote: > Update the device tree binding documentation to include the wlf,out-mono > property that is used to specify whether each output is a mono or stereo > output. > > Signed-off-by: Charles Keepax > --- > > Changes since v1: > -

Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x

2015-12-19 Thread Rob Herring
On Tue, Dec 15, 2015 at 08:45:23PM +0300, Sergei Ianovich wrote: Nothing in this is specific to ICP, so the subject should be updated. > Signed-off-by: Sergei Ianovich > CC: Alexandre Belloni > --- >v4..v5 >* drop THIS_MODULE from struct platform driver >* use "dallas" for vendor

Re: [PATCH v3 9/9] phy: omap-usb2: use *syscon* framework API to power on/off the PHY

2015-12-19 Thread Rob Herring
On Tue, Dec 15, 2015 at 02:46:08PM +0530, Kishon Vijay Abraham I wrote: > Deprecate using phy-omap-control driver to power on/off the PHY, > and use *syscon* framework to do the same. This handles > powering on/off the PHY for the USB2 PHYs used in various TI SoCs. > > Signed-off-by: Kishon Vijay

Re: [PATCH v3 7/9] phy: ti-pipe3: use *syscon* framework API to set PCS value of the PHY

2015-12-19 Thread Rob Herring
On Tue, Dec 15, 2015 at 02:46:06PM +0530, Kishon Vijay Abraham I wrote: > Deprecate using phy-omap-control driver to set PCS value of the PHY > and start using *syscon* API to do the same. > > Signed-off-by: Kishon Vijay Abraham I > Acked-by: Roger Quadros > --- >

Re: [PATCH 1/2] devicetree: mxsfb: add reset-active property

2015-12-19 Thread Rob Herring
On Tue, Dec 15, 2015 at 05:24:56PM +, Mans Rullgard wrote: > Some boards connect the LCD_RESET pin to a reset input on the > display panel. On these boards, this pin must be set to the > proper level for the display to function. > > This adds an optional "reset-active" property to the

Re: [PATCH v3 6/9] phy: ti-pipe3: use *syscon* framework API to power on/off the PHY

2015-12-19 Thread Rob Herring
On Tue, Dec 15, 2015 at 02:46:05PM +0530, Kishon Vijay Abraham I wrote: > Deprecate using phy-omap-control driver to power on/off the PHY and > use *syscon* framework to do the same. > > Signed-off-by: Kishon Vijay Abraham I > --- > Documentation/devicetree/bindings/phy/ti-phy.txt | 10 ++- >

Re: [PATCH 1/2] irqchip: add documentation for TS-4800 interrupt controller

2015-12-19 Thread Rob Herring
On Fri, Dec 18, 2015 at 02:39:18PM -0500, Damien Riegel wrote: > This is an interrupt-controller implemented in an FPGA, to multiplex > interrupts generated from other IPs. The FPGA usually uses a GPIO as a > parent interrupt controller to notify that one of the multiplexed > interrupts has

Re: [PATCH 1/2] can: sja1000: add documentation for Technologic Systems version

2015-12-19 Thread Rob Herring
On Fri, Dec 18, 2015 at 03:17:24PM -0500, Damien Riegel wrote: > This commit adds documentation for the Technologic Systems version of > SJA1000. The difference with the NXP version is in the way the registers > are accessed. > > Signed-off-by: Damien Riegel > --- >

Re: [PATCH v5] mtd: support BB SRAM on ICP DAS LP-8x4x

2015-12-19 Thread Rob Herring
On Tue, Dec 15, 2015 at 09:58:53PM +0300, Sergei Ianovich wrote: > This provides an MTD device driver for 512kB of battery backed up SRAM > on ICPDAS LP-8X4X programmable automation controllers. > > SRAM chip is connected via FPGA and is not accessible without a driver, > unlike flash memory

Re: [PATCH v5] Fix INT1 Recursion with unregistered breakpoints

2015-12-19 Thread Jeff Merkey
> /* > + * Check if we got an execute breakpoint, if so > + * set the resume flag to avoid int1 recursion. > + */ > + if ((dr7 & (DR_RW_MASK << ((i * DR_CONTROL_SIZE) + > + DR_CONTROL_SHIFT))) == DR_RW_EXECUTE) >

[PATCH v5] Fix INT1 Recursion with unregistered breakpoints

2015-12-19 Thread Jeff Merkey
Please consider the attached patch. SUMMARY This patch corrects a hard lockup failure of the system kernel if the operating system receives a breakpoint exception at a code execution address which was not registered with the operating system. The patch allows kernel debuggers, application

Re: [Propose] Isolate core_pattern in mnt namespace.

2015-12-19 Thread Dongsheng Yang
On 12/20/2015 10:37 AM, Al Viro wrote: On Sun, Dec 20, 2015 at 10:14:29AM +0800, Dongsheng Yang wrote: On 12/17/2015 07:23 PM, Dongsheng Yang wrote: Hi guys, We are working on making core dump behaviour isolated in container. But the problem is, the /proc/sys/kernel/core_pattern is a

Re: [PATCH 18/43] MAINTAINERS: add kdbus

2015-12-19 Thread Fengguang Wu
On Sat, Dec 19, 2015 at 04:23:51PM -0800, Greg KH wrote: > On Sat, Dec 19, 2015 at 10:10:24AM +0800, Fengguang Wu wrote: > > On Fri, Dec 18, 2015 at 07:33:36AM -0800, Greg KH wrote: > > > On Fri, Dec 18, 2015 at 03:51:41PM +0800, Fengguang Wu wrote: > > > > CC: Greg Kroah-Hartman > > > >

Re: [PATCH 7/8] fs: make devpts/inode.c explicitly non-modular

2015-12-19 Thread Paul Gortmaker
[Re: [PATCH 7/8] fs: make devpts/inode.c explicitly non-modular] On 17/12/2015 (Thu 11:46) Peter Hurley wrote: > Hi Paul, > > On 12/17/2015 11:11 AM, Paul Gortmaker wrote: > > The Kconfig currently controlling compilation of this code is: > > > > config UNIX98_PTYS > > bool "Unix98 PTY

Re: [PATCH v4] Fix INT1 Recursion with unregistered breakpoints

2015-12-19 Thread Jeff Merkey
On 12/19/15, Jeff Merkey wrote: > On 12/19/15, Jeff Merkey wrote: >> On 12/19/15, Mike Galbraith wrote: >>> On Sat, 2015-12-19 at 19:13 -0700, Jeff Merkey wrote: >>> @@ -519,6 +528,18 @@ static int hw_breakpoint_handler(struct die_args *args) (dr6 & (~DR_TRAP_BITS)))

Re: [Propose] Isolate core_pattern in mnt namespace.

2015-12-19 Thread Al Viro
On Sun, Dec 20, 2015 at 10:14:29AM +0800, Dongsheng Yang wrote: > On 12/17/2015 07:23 PM, Dongsheng Yang wrote: > >Hi guys, > > We are working on making core dump behaviour isolated in > >container. But the problem is, the /proc/sys/kernel/core_pattern > >is a kernel wide setting, not belongs

Re: [PATCH v4] Fix INT1 Recursion with unregistered breakpoints

2015-12-19 Thread Jeff Merkey
On 12/19/15, Jeff Merkey wrote: > On 12/19/15, Mike Galbraith wrote: >> On Sat, 2015-12-19 at 19:13 -0700, Jeff Merkey wrote: >> >>> @@ -519,6 +528,18 @@ static int hw_breakpoint_handler(struct die_args >>> *args) >>> (dr6 & (~DR_TRAP_BITS))) >>> rc = NOTIFY_DONE; >>> >>> +

Re: [PATCH v4] Fix INT1 Recursion with unregistered breakpoints

2015-12-19 Thread Jeff Merkey
On 12/19/15, Mike Galbraith wrote: > On Sat, 2015-12-19 at 19:13 -0700, Jeff Merkey wrote: > >> @@ -519,6 +528,18 @@ static int hw_breakpoint_handler(struct die_args >> *args) >> (dr6 & (~DR_TRAP_BITS))) >> rc = NOTIFY_DONE; >> >> +/* >> +* if we are about to signal

Re: [PATCH v4] Fix INT1 Recursion with unregistered breakpoints

2015-12-19 Thread Mike Galbraith
On Sat, 2015-12-19 at 19:13 -0700, Jeff Merkey wrote: > @@ -519,6 +528,18 @@ static int hw_breakpoint_handler(struct die_args > *args) > (dr6 & (~DR_TRAP_BITS))) > rc = NOTIFY_DONE; > > + /* > + * if we are about to signal to > + * do_debug() to stop further

Re: [Propose] Isolate core_pattern in mnt namespace.

2015-12-19 Thread Dongsheng Yang
On 12/17/2015 07:23 PM, Dongsheng Yang wrote: Hi guys, We are working on making core dump behaviour isolated in container. But the problem is, the /proc/sys/kernel/core_pattern is a kernel wide setting, not belongs to a container. So we want to add core_pattern into mnt namespace.

Re: [PATCH] nvmem: delete unneeded IS_ERR test

2015-12-19 Thread Caesar Wang
Hi Julia, Thanks to check this, but there was a patch fixing it.:-) 在 2015年12月20日 05:19, Julia Lawall 写道: devm_kzalloc returns NULL rather than an ERR_PTR value. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,e; @@ * x =

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

2015-12-19 Thread Eduardo Valentin
Hello Sascha, On Fri, Dec 18, 2015 at 08:16:33AM +0100, Sascha Hauer wrote: > On Thu, Dec 17, 2015 at 11:23:31AM -0800, Eduardo Valentin wrote: > > On Wed, Dec 16, 2015 at 07:23:22PM +0800, Daniel Kurtz wrote: > > > On Mon, Nov 30, 2015 at 7:42 PM, Sascha Hauer > > > wrote: > > > > +Example:

[PATCH v4] Fix INT1 Recursion with unregistered breakpoints

2015-12-19 Thread Jeff Merkey
Please consider the attached patch. SUMMARY This patch corrects a hard lockup failure of the system kernel if the operating system receives a breakpoint exception at a code execution address which was not registered with the operating system. The patch allows kernel debuggers, application

Re: [PATCH] serial: atmel: remove module device table

2015-12-19 Thread Paul Gortmaker
[[PATCH] serial: atmel: remove module device table] On 18/12/2015 (Fri 15:49) Arnd Bergmann wrote: > A recent patch removed most of the module-specific code from the atmel > serial driver, but left the MODULE_DEVICE_TABLE in place, so we can't > build it any more: > >

Re: [PATCH] sc16is7xx: fix incorrect register bits macro

2015-12-19 Thread Greg KH
On Sat, Dec 19, 2015 at 07:20:06PM +0800, Wills Wang wrote: > In datasheet, Modem Status Register MSR[4-5] reflect the modem pins > CTS/DSR/RI/CD signal state. > > Signed-off-by: Wills Wang > --- > drivers/tty/serial/sc16is7xx.c | 12 ++-- > 1 file changed, 6 insertions(+), 6

[GIT PULL] TTY/Serial fixes for 4.4-rc6

2015-12-19 Thread Greg KH
The following changes since commit 527e9316f8ec44bd53d90fb9f611fa752bb9: Linux 4.4-rc4 (2015-12-06 15:43:12 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/ tags/tty-4.4-rc6 for you to fetch changes up to

[GIT PULL] USB driver fixes for 4.4-rc6

2015-12-19 Thread Greg KH
The following changes since commit 9f9499ae8e6415cefc4fe0a96ad0e27864353c89: Linux 4.4-rc5 (2015-12-13 17:42:58 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.4-rc6 for you to fetch changes up to

Re: [BUG] perf test 21("Test object code reading") failure on ARM64

2015-12-19 Thread Jan Stancek
On Sat, Dec 19, 2015 at 11:04:21AM +0800, xiakaixu wrote: > > >>>... > > > > Hi, > > > > What is your objdump version? > > Hi, > > Sorry for the late reply. > > # objdump --version > GNU objdump (GNU Binutils) 2.25. > > I am sure that the system is Little endian. > > I have attached a

Re: [PATCH 18/43] MAINTAINERS: add kdbus

2015-12-19 Thread Greg Kroah-Hartman
On Sat, Dec 19, 2015 at 10:10:24AM +0800, Fengguang Wu wrote: > On Fri, Dec 18, 2015 at 07:33:36AM -0800, Greg KH wrote: > > On Fri, Dec 18, 2015 at 03:51:41PM +0800, Fengguang Wu wrote: > > > CC: Greg Kroah-Hartman > > > Signed-off-by: Fengguang Wu > > > --- > > > MAINTAINERS | 10 ++

[PATCH] ARM64: Improve copy_page for 128 cache line sizes.

2015-12-19 Thread Andrew Pinski
Adding a check for the cache line size is not much overhead. Special case 128 byte cache line size. This improves copy_page by 85% on ThunderX compared to the original implementation. For LMBench, it improves between 4-10%. Signed-off-by: Andrew Pinski --- arch/arm64/lib/copy_page.S | 39

Klientskie bazi dannix Mnogo! Bistro! Nedorogo! tel/viber/whatsapp: +79139393506 Skype: prodawez389 Email: mamontova...@gmail.com Yznaite podrobnee!!! Zwonite!!

2015-12-19 Thread iluvy
Klientskie bazi dannix Mnogo! Bistro! Nedorogo! tel/viber/whatsapp: +79139393506 Skype: prodawez389 Email: gmartinov...@gmail.com Yznaite podrobnee!!! Zvonite!!!

Re: [PATCH v2 1/2] crypto: KEYS: convert public key to the akcipher api

2015-12-19 Thread kbuild test robot
Hi Tadeusz, [auto build test ERROR on crypto/master] [also build test ERROR on v4.4-rc5 next-20151218] url: https://github.com/0day-ci/linux/commits/Tadeusz-Struk/crypto-KEYS-convert-public-key-to-akcipher-api/20151213-103429 base:

RE: REPLY.

2015-12-19 Thread CAPT
I write to seek your assistance for safe keeping of two military trunk boxes valuable that will be of great benefit to both of us,i will explain further when you respond to my direct Email: captcaseythoree...@r7.com I would appreciate your urgent response. Capt.Casey Thoreen( US ARMY OFFICER

Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints

2015-12-19 Thread Jeff Merkey
I cleaned up the areas you identified and I am building and testing the the patch with the debugger test harness. As soon as it passes the build completes and it passes the test harness I will submit v4 of the patch. Jeff On 12/19/15, Thomas Gleixner wrote: > On Mon, 14 Dec 2015, Jeff Merkey

Re: [PATCH v4 1/2] serial: rewrite pxa2xx-uart to use 8250_core

2015-12-19 Thread Robert Jarzmik
Sergei Ianovich writes: > On Sat, 2015-12-19 at 20:31 +0100, Robert Jarzmik wrote: >> Sergei Ianovich writes: >> Thanks for spotting this. This is caused by a change in the latest >> > version of the patch (SERIAL_8250_PXA instead of SERIAL_PXA). This >> > change could be reverted. >> Actually

Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints

2015-12-19 Thread Jeff Merkey
On 12/19/15, Thomas Gleixner wrote: > On Mon, 14 Dec 2015, Jeff Merkey wrote: >> +/* >> +* check if we got an execute breakpoint >> +* from the dr7 register. if we did, set >> +* the resume flag to avoid int1 recursion. > > Malformatted comment as

Re: pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup()

2015-12-19 Thread SF Markus Elfring
>>> This introduces a compile warning. >> >> How do you think about to show the exact message you get? > > I can't actually compile it myself. It seems that I can understand your feedback also a bit better since I received the information from a background process like "kbuild test robot". Will

[GIT PULL REQUEST] md fixes for 4.4-rc

2015-12-19 Thread NeilBrown
The following changes since commit 9f9499ae8e6415cefc4fe0a96ad0e27864353c89: Linux 4.4-rc5 (2015-12-13 17:42:58 -0800) are available in the git repository at: git://neil.brown.name/md tags/md/4.4-rc5-fixes for you to fetch changes up to cb01c5496d2d9c0c862443561df16ff122db348f: Fix

Re: [PATCH] mm, oom: initiallize all new zap_details fields before use

2015-12-19 Thread Sasha Levin
On 12/19/2015 02:52 PM, Kirill A. Shutemov wrote: > On Fri, Dec 18, 2015 at 08:04:51PM -0500, Sasha Levin wrote: >> > Commit "mm, oom: introduce oom reaper" forgot to initialize the two new >> > fields >> > of struct zap_details in unmap_mapping_range(). This caused using stack >> > garbage >> >

Re: [PATCH] pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup()

2015-12-19 Thread kbuild test robot
Hi Markus, [auto build test WARNING on pinctrl/for-next] [also build test WARNING on v4.4-rc5 next-20151218] url: https://github.com/0day-ci/linux/commits/SF-Markus-Elfring/pinctrl-adi2-Use-a-signed-return-type-for-adi_gpio_irq_startup/20151220-010253 base:

Re: [PATCH v5] serial: support for 16550A serial ports on LP-8x4x

2015-12-19 Thread Sergei Ianovich
On Tue, 2015-12-15 at 22:51 +0100, Arnd Bergmann wrote: > On Wednesday 16 December 2015 00:04:45 Sergei Ianovich wrote: > > +Examples (from pxa27x-lp8x4x.dts): > > + > > +   uart@9050 { > > By convention, the name should be 'serial', not 'uart'. > arch/arm/boot/dts/pxa2xx.dtsi uses

Re: [PATCH] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2015-12-19 Thread Cong Wang
On Fri, Dec 18, 2015 at 11:34 AM, Vijay Pandurangan wrote: > Packets that arrive from real hardware devices have ip_summed == > CHECKSUM_UNNECESSARY if the hardware verified the checksums, or > CHECKSUM_NONE if the packet is bad or it was unable to verify it. The > current version of veth will

Re: [PATCH] veth: don't modify ip-summed; doing so treats packets with bad checksums as good.

2015-12-19 Thread Cong Wang
On Sat, Dec 19, 2015 at 1:01 PM, Cong Wang wrote: > On Fri, Dec 18, 2015 at 11:42 AM, Vijay Pandurangan wrote: >> Evan and I have demonstrated this bug on Kubernetes as well, so it's >> not just a problem in Mesos. (See >> https://github.com/kubernetes/kubernetes/issues/18898) >> > >

[PATCH] nvmem: delete unneeded IS_ERR test

2015-12-19 Thread Julia Lawall
devm_kzalloc returns NULL rather than an ERR_PTR value. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,e; @@ * x = devm_kzalloc(...) ... when != x = e * IS_ERR(x) // Signed-off-by: Julia Lawall --- drivers/nvmem/rockchip-efuse.c |

Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance

2015-12-19 Thread Eric W. Biederman
Peter Hurley writes: > On 12/11/2015 11:40 AM, Eric W. Biederman wrote: >> Forcing newinstance for every mount of the devpts filesystem actually >> requires the association between /dev/ptmx and the currently mounted >> instance of devpts at /dev/pts. Simply remembering the first mount of >>

Re: [PATCH] Input: xpad - use LED API when identifying wireless controllers

2015-12-19 Thread Clement Calmels
On Wed, 16 Dec 2015 14:44:08 -0800 Dmitry Torokhov wrote: > When lighting up the segment identifying wireless controller, Instead > of sending command directly to the controller, let's do it via LED > API (usinf led_set_brightness) so that LED object state is in sync > with controller state and

Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()

2015-12-19 Thread Dan Carpenter
On Sat, Dec 19, 2015 at 09:55:02PM +0100, SF Markus Elfring wrote: > > Just make it an int. > > Thanks for your suggestion. > > Will any more software developers prefer this data type > at some source code places? > Use s32 if the hardware spec specifies that you must. Otherwise prefer

[PATCH] IB/usnic: delete unneeded IS_ERR test

2015-12-19 Thread Julia Lawall
kzalloc doesn't return ERR_PTR, so there is no need to test for it. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,e; @@ * x = kzalloc(...) ... when != x = e * IS_ERR_OR_NULL(x) // Signed-off-by: Julia Lawall ---

Re: [PATCH] veth: don't modify ip-summed; doing so treats packets with bad checksums as good.

2015-12-19 Thread Cong Wang
On Fri, Dec 18, 2015 at 11:42 AM, Vijay Pandurangan wrote: > Evan and I have demonstrated this bug on Kubernetes as well, so it's > not just a problem in Mesos. (See > https://github.com/kubernetes/kubernetes/issues/18898) > Interesting... then this problem is much more serious than I thought.

[PATCH v2] RDS: don't pretend to use cpu notifiers

2015-12-19 Thread Santosh Shilimkar
From: Sebastian Andrzej Siewior It looks like an attempt to use CPU notifier here which was never completed. Nobody tried to wire it up completely since 2k9. So I unwind this code and get rid of everything not required. Oh look! 19 lines were removed while code still does the same thing.

Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()

2015-12-19 Thread SF Markus Elfring
> Just make it an int. Thanks for your suggestion. Will any more software developers prefer this data type at some source code places? > The caller also casts it to u32... Do you want to get rid of similar casts in affected functions? Regards, Markus -- To unsubscribe from this list: send

Re: net, ipv6: out of bounds access in secret_stable

2015-12-19 Thread Cong Wang
On Fri, Dec 18, 2015 at 5:13 PM, Sasha Levin wrote: > Hi Hannes, > > I've hit the following out of bounds access while fuzzing on the latest -next > kernel. > > This code was added in 3d1bec9932 ("ipv6: introduce secret_stable to > ipv6_devconf"). > > [ 459.553655] BUG: KASAN:

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2015-12-19 Thread Julian Margetson
On 12/19/2015 4:41 PM, Måns Rullgård wrote: Andy Shevchenko writes: On Sat, Dec 19, 2015 at 10:16 PM, Julian Margetson wrote: On 12/19/2015 3:07 PM, Måns Rullgård wrote: Julian Margetson writes: Total pages: 522752 [0.00] Kernel command line: root=/dev/sda8 console=ttyS0,115200

Re: [PATCH v2] x86/signal: Cleanup get_nr_restart_syscall

2015-12-19 Thread Andy Lutomirski
On Sat, Dec 19, 2015 at 6:43 AM, Dmitry V. Levin wrote: > Check for TS_COMPAT instead of TIF_IA32 to distinguish ia32 tasks > from 64-bit tasks. > Check for __X32_SYSCALL_BIT iff CONFIG_X86_X32_ABI is defined. LGTM. --Andy -- To unsubscribe from this list: send the line "unsubscribe

[PATCH v4 0/2] um: Protect memory mapped file

2015-12-19 Thread Mickaël Salaün
This series protect the memory mapped file. Changes since v3: * add Tristan Schmelcher's ack Changes since v2; addressed Tristan Schmelcher's comment: * remove the whole fchmod call [1/2] Changes since v1; addressed Richard Weinberger's comments: * add attacker model to the patch description

Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()

2015-12-19 Thread Sergei Shtylyov
Hello. On 12/19/2015 11:15 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Sat, 19 Dec 2015 21:10:20 +0100 The return type "u32" was used by the fhci_create_ep() function even though it will eventually return a negative error code. Improve this implementation detail by using the type

Re: pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup()

2015-12-19 Thread Dan Carpenter
On Sat, Dec 19, 2015 at 09:40:27PM +0100, SF Markus Elfring wrote: > > This introduces a compile warning. > > How do you think about to show the exact message you get? > I can't actually compile it myself. > > > These functions are supposed to return 1 if there is an IRQ pending. > > Change

Re: [PATCH] [media] gsc-m2m: Use an unsigned data type for a variable

2015-12-19 Thread Dan Carpenter
On Sat, Dec 19, 2015 at 04:23:11PM +0100, SF Markus Elfring wrote: > diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c > b/drivers/media/platform/exynos-gsc/gsc-m2m.c > index d82e717..f2c091c 100644 > --- a/drivers/media/platform/exynos-gsc/gsc-m2m.c > +++

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2015-12-19 Thread Måns Rullgård
Andy Shevchenko writes: > On Sat, Dec 19, 2015 at 10:16 PM, Julian Margetson wrote: >> On 12/19/2015 3:07 PM, Måns Rullgård wrote: >>> Julian Margetson writes: > Total pages: 522752 [0.00] Kernel command line: root=/dev/sda8 console=ttyS0,115200 console=tty1

Re: pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup()

2015-12-19 Thread SF Markus Elfring
> This introduces a compile warning. How do you think about to show the exact message you get? > These functions are supposed to return 1 if there is an IRQ pending. > Change the -EINVAL to 0. Is there any more source code clean-up needed around the comment "FIXME" in the affected function?

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2015-12-19 Thread Andy Shevchenko
On Sat, Dec 19, 2015 at 10:16 PM, Julian Margetson wrote: > On 12/19/2015 3:07 PM, Måns Rullgård wrote: >> Julian Margetson writes: >>> Total pages: 522752 >>> [0.00] Kernel command line: root=/dev/sda8 console=ttyS0,115200 >>> console=tty1 dw_dmac_core.dyndbg dw_dmac.dyndbg >> >>

[tip:x86/urgent] x86/paravirt: Prevent rtc_cmos platform device init on PV guests

2015-12-19 Thread tip-bot for David Vrabel
Commit-ID: d8c98a1d1488747625ad6044d423406e17e99b7a Gitweb: http://git.kernel.org/tip/d8c98a1d1488747625ad6044d423406e17e99b7a Author: David Vrabel AuthorDate: Fri, 11 Dec 2015 09:07:53 -0500 Committer: Thomas Gleixner CommitDate: Sat, 19 Dec 2015 21:35:13 +0100 x86/paravirt: Prevent

Re: [LKP] [lkp] [x86/irq] 4c24cee6b2: IP-Config: Auto-configuration of network failed

2015-12-19 Thread Thomas Gleixner
On Tue, 15 Dec 2015, Jiang Liu wrote: > Hi Boris and Ying, > Aha, found a possible regression. Could you please help to > apply the attached bugfix patch ontop of "cc22b9b83f6a x86/irq: > Enhance __assign_irq_vector() to rollback in case of failure"? > Hi Ying, I have push this patch to

Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()

2015-12-19 Thread Dan Carpenter
Just make it an int. The caller also casts it to u32... regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

RE: [PATCH v9 0/7] PCI: hv: New paravirtual PCI front-end for Hyper-V VMs

2015-12-19 Thread Thomas Gleixner
On Sat, 19 Dec 2015, KY Srinivasan wrote: > > From: Thomas Gleixner [mailto:t...@linutronix.de] > > On Tue, 15 Dec 2015, KY Srinivasan wrote: > > > > > > Of these 7 patches, Greg has committed all of the VMBUS > > > related supporting patches (3 patches). Thomas, can you > > > take the IRQ related

Re: [PATCH] staging-slicoss: Use a signed return type for slic_card_locate()

2015-12-19 Thread Dan Carpenter
It returns zero or negative error codes. The callers expect int. It is harmless. It should just be int. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] SCSI-lpfc: Use a signed return type for two functions

2015-12-19 Thread Dan Carpenter
It returns zero or negative error codes. The callers expect int. The current code is harmless. It should return an int. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2015-12-19 Thread Julian Margetson
On 12/19/2015 3:07 PM, Måns Rullgård wrote: Julian Margetson writes: On 12/19/2015 1:19 PM, Måns Rullgård wrote: Julian Margetson writes: On 12/19/2015 1:05 PM, Måns Rullgård wrote: Andy Shevchenko writes: On Sat, Dec 19, 2015 at 5:40 PM, Måns Rullgård wrote: OK, I've found

[PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()

2015-12-19 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 19 Dec 2015 21:10:20 +0100 The return type "u32" was used by the fhci_create_ep() function even though it will eventually return a negative error code. Improve this implementation detail by using the type "s32" instead. This issue was detected by using the

Re: [PATCH] ti-st: Use a signed return type for st_ll_sleep_state()

2015-12-19 Thread Dan Carpenter
It returns zero or negative error codes. The return value is never checked. Make it an int. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v4 1/2] serial: rewrite pxa2xx-uart to use 8250_core

2015-12-19 Thread Sergei Ianovich
On Sat, 2015-12-19 at 20:31 +0100, Robert Jarzmik wrote: > Sergei Ianovich writes: > Thanks for spotting this. This is caused by a change in the latest > > version of the patch (SERIAL_8250_PXA instead of SERIAL_PXA). This > > change could be reverted. > Actually I'm against the revert. > The

Re: [PATCH] pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup()

2015-12-19 Thread Dan Carpenter
This introduces a compile warning. These functions are supposed to return 1 if there is an IRQ pending. Change the -EINVAL to 0. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

[patch 3/5] futex: Document pi_state refcounting in requeue code

2015-12-19 Thread Thomas Gleixner
Documentation of the pi_state refcounting in the requeue code is non existent. Add it. Signed-off-by: Thomas Gleixner --- kernel/futex.c | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) --- a/kernel/futex.c +++ b/kernel/futex.c @@ -1709,6 +1709,8 @@

[patch 4/5] futex: Remove pointless put_pi_state calls in requeue()

2015-12-19 Thread Thomas Gleixner
In the error handling cases we neither have pi_state nor a reference to it. Remove the pointless code. Signed-off-by: Thomas Gleixner --- kernel/futex.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) --- a/kernel/futex.c +++ b/kernel/futex.c @@ -1737,9 +1737,9 @@ static int

[patch 5/5] futex: Cleanup the goto confusion in requeue_pi()

2015-12-19 Thread Thomas Gleixner
out_unlock: does not only drop the locks, it also drops the refcount on the pi_state. Really intuitive. Move the label after the put_pi_state() call and use 'break' in the error handling path of the requeue loop. Signed-off-by: Thomas Gleixner --- kernel/futex.c |5 +++-- 1 file changed, 3

[patch 1/5] futex: Drop refcount if requeue_pi() acquired the rtmutex

2015-12-19 Thread Thomas Gleixner
If the proxy lock in the requeue loop acquires the rtmutex for a waiter then it acquired also refcount on the pi_state related to the futex, but the waiter side does not drop the reference count. Add the missing free_pi_state() call. Signed-off-by: Thomas Gleixner Cc: sta...@vger.kernel.org ---

[patch 0/5] futex: Plug a pi_state leak and clarify the refcounting

2015-12-19 Thread Thomas Gleixner
A recent patch claimed that there is a double free in the requeue_pi code, which is not the case. While analysing the issue I found the contrary, i.e. a leak. This series fixes the leak and clarifies the code so it's more clear how that refcounting on the pi state works. Thanks, tglx

[patch 2/5] futex: Rename free_pi_state() to put_pi_state()

2015-12-19 Thread Thomas Gleixner
free_pi_state() is confusing as it is in fact only freeing/caching the pi state when the last reference is gone. Rename it to put_pi_state() which reflects better what it is doing. Signed-off-by: Thomas Gleixner --- kernel/futex.c | 17 ++--- 1 file changed, 10 insertions(+), 7

Re: [PATCH] mm, oom: initiallize all new zap_details fields before use

2015-12-19 Thread Kirill A. Shutemov
On Fri, Dec 18, 2015 at 08:04:51PM -0500, Sasha Levin wrote: > Commit "mm, oom: introduce oom reaper" forgot to initialize the two new fields > of struct zap_details in unmap_mapping_range(). This caused using stack > garbage > on the call to unmap_mapping_range_tree(). > > Signed-off-by: Sasha

  1   2   3   4   5   >