Re: [kernel-hardening] [PATCH v8 3/3] x86/refcount: Implement fast refcount overflow protection

2017-07-25 Thread Kees Cook
On Tue, Jul 25, 2017 at 5:03 AM, Li Kun wrote: > Hi Kees, > > > on 2017/7/25 2:35, Kees Cook wrote: >> >> +static __always_inline __must_check >> +int __refcount_add_unless(refcount_t *r, int a, int u) >> +{ >> + int c, new; >> + >> + c = atomic_read(&(r->refs)); >> + do { >> +

Re: [PATCH v2 2/4] cgroup: Allow bypass mode in subtree_control

2017-07-25 Thread Waiman Long
On 07/25/2017 01:13 PM, Tejun Heo wrote: > Hello, Waiman. > > On Mon, Jul 24, 2017 at 02:20:59PM -0400, Waiman Long wrote: >> As said in patch 3, enabling bypass mode at subtree_control delegate the >> authority of enabling controllers to the children. The children own the >> resource control files

Re: [RFC PATCH 1/5] ima: extend clone() with IMA namespace support

2017-07-25 Thread James Bottomley
On Tue, 2017-07-25 at 14:04 -0500, Serge E. Hallyn wrote: > On Tue, Jul 25, 2017 at 11:49:14AM -0700, James Bottomley wrote: > > > > On Tue, 2017-07-25 at 12:53 -0500, Serge E. Hallyn wrote: > > > > > > On Thu, Jul 20, 2017 at 06:50:29PM -0400, Mehmet Kayaalp wrote: > > > > > > > > > > > > From

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

2017-07-25 Thread Douglas Gilbert
On 2017-07-19 04:36 AM, Johannes Thumshirn wrote: On Wed, Jul 19, 2017 at 03:13:34AM -0500, Jason L Tibbitts III wrote: [ 46.304530] sg_is_valid_dxfer: dxfer_direction: -2, dxfer_len: 0 Ahh now I see the -2 (SG_DXFER_TO_DEV) is the crucial point here. It is 0 in your case. This would "fix"

Re: [RFC PATCH 1/5] ima: extend clone() with IMA namespace support

2017-07-25 Thread Serge E. Hallyn
On Tue, Jul 25, 2017 at 11:49:14AM -0700, James Bottomley wrote: > On Tue, 2017-07-25 at 12:53 -0500, Serge E. Hallyn wrote: > > On Thu, Jul 20, 2017 at 06:50:29PM -0400, Mehmet Kayaalp wrote: > > > > > > From: Yuqiong Sun > > > > > > Add new CONFIG_IMA_NS config option.  Let clone() create a ne

Re: [PATCH] f2fs: let __get_victim successfully get a segno in corner case

2017-07-25 Thread Jaegeuk Kim
On 07/14, Yunlong Song wrote: > Suppose that the valid blocks of each section are all over > sbi->fggc_threshold, > and even has_not_enough_free_secs is true, f2fs_gc cannot do its job since the > no_fggc_candidate always returns true. As a result, the reserved segments can > be > used up, and fi

Re: [PATCH tip/core/rcu 4/5] sys_membarrier: Add expedited option

2017-07-25 Thread Peter Zijlstra
On Tue, Jul 25, 2017 at 10:17:01AM -0700, Paul E. McKenney wrote: > > munmap() TLB invalidate is limited to those CPUs that actually ran > > threads of their process, while this is machine wide. > > Or those CPUs running threads of any process mapping the underlying file > or whatever. That does

Re: [RFC PATCH 1/5] ima: extend clone() with IMA namespace support

2017-07-25 Thread James Bottomley
On Tue, 2017-07-25 at 12:53 -0500, Serge E. Hallyn wrote: > On Thu, Jul 20, 2017 at 06:50:29PM -0400, Mehmet Kayaalp wrote: > > > > From: Yuqiong Sun > > > > Add new CONFIG_IMA_NS config option.  Let clone() create a new IMA > > namespace upon CLONE_NEWNS flag. Add ima_ns data structure in > > n

Re: [PATCH v3 00/10] x86: ORC unwinder (previously undwarf)

2017-07-25 Thread Kees Cook
On Tue, Jul 25, 2017 at 10:58 AM, Josh Poimboeuf wrote: > [ Adding Kees to CC for the hardened usercopy discussion. ] > > Kees, FYI: frame pointers may be disabled by default on x86 relatively > soon (presumably weeks or months) in favor of the ORC unwinder. So the > hardened usercopy stack walk

[RESEND PATCH v4 2/2] dt-bindings: mfd: Add bindings for ZII RAVE devices

2017-07-25 Thread Andrey Smirnov
Cc: cphe...@gmail.com Cc: Lucas Stach Cc: Nikita Yushchenko Cc: Rob Herring Cc: Mark Rutland Cc: devicet...@vger.kernel.org Acked-by: Rob Herring Acked-for-MFD-by: Lee Jones Signed-off-by: Andrey Smirnov --- .../devicetree/bindings/mfd/zii,rave-sp.txt| 39 ++ 1 f

[RESEND PATCH v4 0/2] ZII RAVE platform driver

2017-07-25 Thread Andrey Smirnov
Hi everyone, This patch series is v4 of the driver for supervisory processor found on RAVE series of devices from ZII. Supervisory processor is a PIC microcontroller connected to various electrical subsystems on RAVE devices whose firmware implements protocol to command/qery them. Changes since [

[RESEND PATCH v4 1/2] platform: Add driver for RAVE Supervisory Processor

2017-07-25 Thread Andrey Smirnov
Add a driver for RAVE Supervisory Processor, an MCU implementing varoius bits of housekeeping functionality (watchdoging, backlight control, LED control, etc) on RAVE family of products by Zodiac Inflight Innovations. This driver implementes core MFD/serdev device as well as communication subrouti

Re: [PATCH v2 12/25] dt-bindings: qcom_nandc: QPIC NAND documentation

2017-07-25 Thread Abhishek Sahu
On 2017-07-25 00:47, Rob Herring wrote: On Wed, Jul 19, 2017 at 05:18:00PM +0530, Abhishek Sahu wrote: 1. QPIC NAND will use compatible string "qcom,qpic-nandc-v1.4.0" 2. QPIC NAND will 3 BAM channels: command, data tx and data rx while EBI2 NAND uses only single ADM channel. 3. CRCI is only

Re: [PATCH v4 0/2] ZII RAVE platform driver

2017-07-25 Thread Andrey Smirnov
Rest of the series ended up missing proper "To:" field. I'll resend the series shortly. Please disregard this e-mail. Sorry about the noise. Andrey Smirnov On Tue, Jul 25, 2017 at 8:02 AM, Andrey Smirnov wrote: > Hi everyone, > > This patch series is v4 of the driver for supervisory processor fo

Re: [lkp-robot] [x86/refcount] b631e535c6: WARNING:at_net/netlink/af_netlink.c:#netlink_sock_destruct

2017-07-25 Thread Kees Cook
On Tue, Jul 25, 2017 at 3:43 AM, Hans Liljestrand wrote: > On Mon, Jul 24, 2017 at 08:21:16PM -0700, Kees Cook wrote: >> >> On Mon, Jul 24, 2017 at 6:03 AM, Hans Liljestrand >> wrote: >>> >>> On Sun, Jul 23, 2017 at 08:52:53PM -0700, Kees Cook wrote: Is 14afee4b6092f ("net: convert

[PATCH] netpoll: Fix device name check in netpoll_setup()

2017-07-25 Thread Matthias Kaehlcke
Apparently netpoll_setup() assumes that netpoll.dev_name is a pointer when checking if the device name is set: if (np->dev_name) { ... However the field is a character array, therefore the condition always yields true. Check instead whether the first byte of the array has a non-zero value. Sig

Re: [PATCH v2 13/23] percpu: generalize bitmap (un)populated iterators

2017-07-25 Thread Josef Bacik
On Mon, Jul 24, 2017 at 07:02:10PM -0400, Dennis Zhou wrote: > From: "Dennis Zhou (Facebook)" > > The area map allocator only used a bitmap for the backing page state. > The new bitmap allocator will use bitmaps to manage the allocation > region in addition to this. > > This patch generalizes th

[PATCH 1/2] lkdtm: Provide more complete coverage for REFCOUNT tests

2017-07-25 Thread Kees Cook
The existing REFCOUNT_* LKDTM tests were designed only for testing a narrow portion of CONFIG_REFCOUNT_FULL. This moves the tests to their own file and expands their testing to poke each boundary condition. Since the protections (CONFIG_REFCOUNT_FULL and x86-fast) use different saturation values a

[PATCH 0/2] lkdtm: Provide more complete coverage for REFCOUNT tests

2017-07-25 Thread Kees Cook
This is a short series to provide behavior and performance tests for refcount_t, taking into account both CONFIG_REFCOUNT_FULL and the new x86-fast protection. -Kees

Re: [PATCH v2 12/23] percpu: increase minimum percpu allocation size and align first regions

2017-07-25 Thread Josef Bacik
On Mon, Jul 24, 2017 at 07:02:09PM -0400, Dennis Zhou wrote: > From: "Dennis Zhou (Facebook)" > > This patch increases the minimum allocation size of percpu memory to > 4-bytes. This change will help minimize the metadata overhead > associated with the bitmap allocator. The assumption is that mos

[PATCH 2/2] lkdtm: Provide timing tests for atomic_t vs refcount_t

2017-07-25 Thread Kees Cook
While not a crash test, this does provide two tight atomic_t and refcount_t loops for performance comparisons: cd /sys/kernel/debug/provoke-crash perf stat -B -- cat <(echo ATOMIC_TIMING) > DIRECT perf stat -B -- cat <(echo REFCOUNT_TIMING) > DIRECT Looking a CPU cycles is

Re: [PATCH v2 11/23] percpu: introduce nr_empty_pop_pages to help empty page accounting

2017-07-25 Thread Josef Bacik
On Mon, Jul 24, 2017 at 07:02:08PM -0400, Dennis Zhou wrote: > From: "Dennis Zhou (Facebook)" > > pcpu_nr_empty_pop_pages is used to ensure there are a handful of free > pages around to serve atomic allocations. A new field, nr_empty_pop_pages, > is added to the pcpu_chunk struct to keep track of

[PATCH v2 2/3] drm/vc4: Add an ioctl for labeling GEM BOs for summary stats

2017-07-25 Thread Eric Anholt
This has proven immensely useful for debugging memory leaks and overallocation (which is a rather serious concern on the platform, given that we typically run at about 256MB of CMA out of up to 1GB total memory, with framebuffers that are about 8MB ecah). The state of the art without this is to du

Re: [PATCH v2 10/23] percpu: change the number of pages marked in the first_chunk pop bitmap

2017-07-25 Thread Josef Bacik
On Mon, Jul 24, 2017 at 07:02:07PM -0400, Dennis Zhou wrote: > From: "Dennis Zhou (Facebook)" > > The populated bitmap represents the state of the pages the chunk serves. > Prior, the bitmap was marked completely used as the first chunk was > allocated and immutable. This is misleading because th

[PATCH v2 1/3] drm/vc4: Start using u64_to_user_ptr.

2017-07-25 Thread Eric Anholt
Chris Wilson pointed out this little cleanup in a review of new code, so let's fix up the code I was copying from. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_gem.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/

Re: [PATCH] vc4: Add an ioctl for labeling GEM BOs for summary stats

2017-07-25 Thread Eric Anholt
Chris Wilson writes: > Quoting Eric Anholt (2017-06-22 21:50:54) >> This has proven immensely useful for debugging memory leaks and >> overallocation (which is a rather serious concern on the platform, >> given that we typically run at about 256MB of CMA out of up to 1GB >> total memory, with fra

[PATCH v2 3/3] drm/vc4: Convert more lock requirement comments to lockdep assertions.

2017-07-25 Thread Eric Anholt
Since I do my development with lockdep on, this will help make sure I don't introduce bugs here. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_bo.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c

Re: [PATCH] mm, oom: allow oom reaper to race with exit_mmap

2017-07-25 Thread Andrea Arcangeli
On Tue, Jul 25, 2017 at 05:45:14PM +0200, Michal Hocko wrote: > That problem is real though as reported by David. I'm not against fixing it, I just think it's not a major concern, and the solution doesn't seem optimal as measured by Kirill. I'm just skeptical it's the best to solve that tiny race

Re: [PATCH v2 09/23] percpu: combine percpu address checks

2017-07-25 Thread Josef Bacik
On Mon, Jul 24, 2017 at 07:02:06PM -0400, Dennis Zhou wrote: > From: "Dennis Zhou (Facebook)" > > The percpu address checks for the reserved and dynamic region chunks are > now specific to each region. The address checking logic can be combined > taking advantage of the global references to the d

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

2017-07-25 Thread Jason L Tibbitts III
> "JT" == Johannes Thumshirn writes: JT> Yes please (on top of the snippet I've sent you last). OK, I'm at 4.12 with 68c59fcea1f2c6a54c62aa896cc623c1b5bc9b47 cherry picked, plus the fix patch and the debug patch you've sent previously. To make sure we're on the same page, I'll include the pa

Re: [PATCH v2 08/23] percpu: modify base_addr to be region specific

2017-07-25 Thread Josef Bacik
On Mon, Jul 24, 2017 at 07:02:05PM -0400, Dennis Zhou wrote: > From: "Dennis Zhou (Facebook)" > > Originally, the first chunk was served by one or two chunks, each > given a region they are responsible for. Despite this, the arithmetic > was based off of the true base_addr of the chunk making it

Re: [tpmdd-devel] tpm: read burstcount from TPM_STS in one 32-bit transaction

2017-07-25 Thread Michal Suchánek
On Tue, 25 Jul 2017 10:36:11 -0700 James Bottomley wrote: > On Tue, 2017-07-25 at 15:04 +0200, Michal Suchánek wrote: > > Hello, > > > > in commit 9754d45e9970 ("tpm: read burstcount from TPM_STS in one > > 32-bit transaction") you change reading of two 8-bit values to one > > 32bit read. This i

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-25 Thread Franklin S Cooper Jr
On 07/25/2017 11:32 AM, Oliver Hartkopp wrote: > >> + max-data-speed:a positive non 0 value that determines the max >> data rate >> +that can be used in CAN-FD mode. A value of -1 implies >> +CAN-FD is not supported by the transceiver. >> + >> +Examples: > > (..) >

Re: [PATCH] iommu/of: Handle PCI aliases properly

2017-07-25 Thread Robin Murphy
On 31/05/17 18:52, Robin Murphy wrote: > When a PCI device has DMA quirks, we need to ensure that an upstream > IOMMU knows about all possible aliases, since the presence of a DMA > quirk does not preclude the device still also emitting transactions > (e.g. MSIs) on its 'real' RID. Similarly, the r

Re: v4.12: register_dcache lockdep problem on boot

2017-07-25 Thread Eric Wheeler
On Tue, 25 Jul 2017, Pavel Machek wrote: > Hi! > > I get this one during boot... > > Pavel > [ 12.717617] __lock_acquire+0x86/0x94a > [ 12.720466] lock_acquire+0x4a/0x66 > [ 12.723223] ? mca_reap+0x56/0x115 > [ 12.725972]

Re: [PATCH v2 07/23] percpu: setup_first_chunk rename schunk/dchunk to chunk

2017-07-25 Thread Josef Bacik
On Mon, Jul 24, 2017 at 07:02:04PM -0400, Dennis Zhou wrote: > From: "Dennis Zhou (Facebook)" > > There is no need to have the static chunk and dynamic chunk be named > separately as the allocations are sequential. This preemptively solves > the misnomer problem with the base_addrs being moved up

Re: [PATCH v2 06/23] percpu: end chunk area maps page aligned for the populated bitmap

2017-07-25 Thread Josef Bacik
On Mon, Jul 24, 2017 at 07:02:03PM -0400, Dennis Zhou wrote: > From: "Dennis Zhou (Facebook)" > > The area map allocator manages the first chunk area by hiding all but > the region it is responsible for serving in the area map. To align this > with the populated page bitmap, end_offset is introdu

Re: [PATCH tip/core/rcu 03/15] rcu: Drive TASKS_RCU directly off of PREEMPT

2017-07-25 Thread Steven Rostedt
On Mon, 24 Jul 2017 14:44:32 -0700 "Paul E. McKenney" wrote: > The actual use of TASKS_RCU is only when PREEMPT, otherwise RCU-sched > is used instead. This commit therefore makes synchronize_rcu_tasks() > and call_rcu_tasks() available always, but mapped to synchronize_sched() > and call_rcu_sc

Re: [PATCH v2 04/23] percpu: setup_first_chunk remove dyn_size and consolidate logic

2017-07-25 Thread Josef Bacik
On Mon, Jul 24, 2017 at 07:02:01PM -0400, Dennis Zhou wrote: > From: "Dennis Zhou (Facebook)" > > There is logic for setting variables in the static chunk init code that > could be consolidated with the dynamic chunk init code. This combines > this logic to setup for combining the allocation path

Re: bcache with existing ext4 filesystem

2017-07-25 Thread Eric Wheeler
On Tue, 25 Jul 2017, Pavel Machek wrote: > On Tue 2017-07-25 12:32:48, Vojtech Pavlik wrote: > > On Tue, Jul 25, 2017 at 08:43:04AM +0200, Pavel Machek wrote: > > > On Tue 2017-07-25 00:51:56, Theodore Ts'o wrote: > > > > On Mon, Jul 24, 2017 at 10:04:51PM +0200, Pavel Machek wrote: > > > > > Ques

Re: [PATCH tip/core/rcu 02/15] rcu: Use timer as backstop for NOCB deferred wakeups

2017-07-25 Thread Steven Rostedt
On Mon, 24 Jul 2017 14:44:31 -0700 "Paul E. McKenney" wrote: > The handling of RCU's no-CBs CPUs has a maintenance headache, namely > that if call_rcu() is invoked with interrupts disabled, the rcuo kthread > wakeup must be defered to a point where we can be sure that scheduler > locks are not he

[PATCH net-next v2 06/10] net: dsa: lan9303: added sysfs node swe_bcst_throt

2017-07-25 Thread Egil Hjelmeland
Allowing per-port access to Switch Engine Broadcast Throttling Register Also added lan9303_write_switch_reg_mask() Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 83 ++ 1 file changed, 83 insertions(+) diff --git a/drivers/net/dsa/la

Re: [PATCH v2 05/23] percpu: unify allocation of schunk and dchunk

2017-07-25 Thread Josef Bacik
On Mon, Jul 24, 2017 at 07:02:02PM -0400, Dennis Zhou wrote: > From: "Dennis Zhou (Facebook)" > > Create a common allocator for first chunk initialization, > pcpu_alloc_first_chunk. Comments for this function will be added in a > later patch once the bitmap allocator is added. > > Signed-off-by:

[PATCH v2] drm/hisilicon: fix build error without fbdev emulation

2017-07-25 Thread Arnd Bergmann
We cannot reference priv->fbdev outside of the #ifdef: drivers/net/virtio_net.c:1881:12: error: 'virtnet_restore_up' defined but not used [-Werror=unused-function] static int virtnet_restore_up(struct virtio_device *vdev) drivers/net/virtio_net.c:1859:13: error: 'virtnet_freeze_down' defined but

[PATCH net-next v2 02/10] net: dsa: lan9303: Do not disable/enable switch fabric port 0 at startup

2017-07-25 Thread Egil Hjelmeland
For some mysterious reason enable switch fabric port 0 TX fails to work, when the TX has previous been disabled. Resolved by not disable/enable switch fabric port 0 at startup. Port 1 and 2 are still disabled in early init. Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 7 --

Re: [PATCH v2 03/23] percpu: remove has_reserved from pcpu_chunk

2017-07-25 Thread Josef Bacik
On Mon, Jul 24, 2017 at 07:02:00PM -0400, Dennis Zhou wrote: > From: "Dennis Zhou (Facebook)" > > Prior this variable was used to manage statistics when the first chunk > had a reserved region. The previous patch introduced start_offset to > keep track of the offset by value rather than boolean.

Re: [PATCH v4.4.y] sched/cgroup: Move sched_online_group() back into css_online() to fix crash

2017-07-25 Thread Greg KH
On Thu, Jul 20, 2017 at 02:53:09PM +0100, Matt Fleming wrote: > From: Konstantin Khlebnikov > > commit 96b777452d8881480fd5be50112f791c17db4b6b upstream. > > Commit: > > 2f5177f0fd7e ("sched/cgroup: Fix/cleanup cgroup teardown/init") > > .. moved sched_online_group() from css_online() to css

Re: [PATCH] drm/hisilicon: fix build error without fbdev emulation

2017-07-25 Thread Arnd Bergmann
On Tue, Jul 25, 2017 at 5:53 PM, Daniel Vetter wrote: > On Tue, Jul 25, 2017 at 05:33:25PM +0200, Arnd Bergmann wrote: >> drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.

Re: [PATCH v2 02/23] percpu: introduce start_offset to pcpu_chunk

2017-07-25 Thread Josef Bacik
On Mon, Jul 24, 2017 at 07:01:59PM -0400, Dennis Zhou wrote: > From: "Dennis Zhou (Facebook)" > > The reserved chunk arithmetic uses a global variable > pcpu_reserved_chunk_limit that is set in the first chunk init code to > hide a portion of the area map. The bitmap allocator to come will > even

Re: [PATCH v2 01/23] percpu: setup_first_chunk enforce dynamic region must exist

2017-07-25 Thread Josef Bacik
On Mon, Jul 24, 2017 at 07:01:58PM -0400, Dennis Zhou wrote: > From: "Dennis Zhou (Facebook)" > > The first chunk is handled as a special case as it is composed of the > static, reserved, and dynamic regions. The code handles each case > individually. The next several patches will merge these cod

Re: bcache with existing ext4 filesystem

2017-07-25 Thread Theodore Ts'o
On Tue, Jul 25, 2017 at 03:46:04PM +0200, Pavel Machek wrote: > > Is there some field in ext2 superblock that changes every time > filesystem is changed? Is mtime changed by fsck/badblocks/...? No, there isn't. If we were writing the superblock every time the file system is changed it would be *

Re: [PATCH] alarmtimer: don't rate limit one-shot timers

2017-07-25 Thread Greg KH
On Tue, Jul 25, 2017 at 09:00:42AM +0200, Thomas Gleixner wrote: > On Mon, 24 Jul 2017, Greg KH wrote: > > > On Mon, Jul 24, 2017 at 02:41:10PM -0700, Greg Hackmann wrote: > > > On 07/24/2017 11:21 AM, Greg KH wrote: > > > > On Mon, Jul 24, 2017 at 10:19:24AM -0700, Greg Hackmann wrote: > > > > >

Re: [PATCH 05/11] ASoC: samsung: spdif: Handle return value of clk_prepare_enable.

2017-07-25 Thread Krzysztof Kozlowski
On Tue, Jul 25, 2017 at 03:44:32PM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > sound/soc/samsung/spdif.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > Reviewed-by: Krzysztof Kozl

Re: [PATCH v3 00/10] x86: ORC unwinder (previously undwarf)

2017-07-25 Thread Josh Poimboeuf
[ Adding Kees to CC for the hardened usercopy discussion. ] Kees, FYI: frame pointers may be disabled by default on x86 relatively soon (presumably weeks or months) in favor of the ORC unwinder. So the hardened usercopy stack walk will no longer work as advertised. Using the ORC unwinder for har

Re: [PATCH 04/11] ASoC: samsung: i2s: Handle return value of clk_prepare_enable.

2017-07-25 Thread Krzysztof Kozlowski
On Tue, Jul 25, 2017 at 03:44:31PM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > sound/soc/samsung/i2s.c | 19 +++ > 1 file changed, 15 insertions(+), 4 deletions(-) > Reviewed-by: Krz

Re: [RFC PATCH 1/5] ima: extend clone() with IMA namespace support

2017-07-25 Thread Serge E. Hallyn
On Thu, Jul 20, 2017 at 06:50:29PM -0400, Mehmet Kayaalp wrote: > From: Yuqiong Sun > > Add new CONFIG_IMA_NS config option. Let clone() create a new IMA > namespace upon CLONE_NEWNS flag. Add ima_ns data structure in nsproxy. > ima_ns is allocated and freed upon IMA namespace creation and exit.

[PATCH v1 2/3] ASoC: codecs: msm8916-analog: support jack detection

2017-07-25 Thread Damien Riegel
The audio codec in the PM8916 has a feature called Multi-Button Headset Control (MBHC). It can support of up to five buttons on a headset, and jack insertion/removal detection. This patch only supports the jack detection. A complete implementation is available in the Android kernel [1] for referen

[PATCH v1 3/3] ASoC: qcom: apq8016-sbc: enable jack detection

2017-07-25 Thread Damien Riegel
Now that the pm8916 audio codec has support for jack detection, let the sound card driver use it. Signed-off-by: Damien Riegel --- sound/soc/qcom/apq8016_sbc.c | 16 1 file changed, 16 insertions(+) diff --git a/sound/soc/qcom/apq8016_sbc.c b/sound/soc/qcom/apq8016_sbc.c index

[PATCH v1 1/3] ASoC: codecs: msm8916-analog: fix DIG_CLK_CTL_RXD3_CLK_EN define

2017-07-25 Thread Damien Riegel
The wrong bit is assigned to DIG_CLK_CTL_RXD3_CLK_EN, change it for the correct one. Signed-off-by: Damien Riegel --- sound/soc/codecs/msm8916-wcd-analog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-an

Re: [PATCH] powerpc/pseries: Fix of_node_put() underflow during pseries remove

2017-07-25 Thread Tyrel Datwyler
On 07/24/2017 09:47 PM, Michael Ellerman wrote: > Tyrel Datwyler writes: > >> On 07/24/2017 03:42 AM, Michael Ellerman wrote: >>> Laurent Vivier writes: >>> As for commit 68baf692c435 ("powerpc/pseries: Fix of_node_put() underflow during DLPAR remove"), the call to of_node_put() m

[PATCH v1 0/3] add jack detection to MSM8916 analog

2017-07-25 Thread Damien Riegel
This series adds support for the MBHC (Multi-Button Headset Control) of the PM8916's analog codec. This IP is capable to identify up to five buttons on a headset, but for now only the jack detection is supported. A complete implementation exists in the Android kernel, but it's quite complex and I'd

Re: [PATCH 03/11] ASoC: samsung: pcm: Handle return value of clk_prepare_enable.

2017-07-25 Thread Krzysztof Kozlowski
On Tue, Jul 25, 2017 at 03:44:30PM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > sound/soc/samsung/pcm.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > Reviewed-by: Krzysztof Kozlow

Re: [PATCH RFC] sched: Allow migrating kthreads into online but inactive CPUs

2017-07-25 Thread Paul E. McKenney
On Tue, Jul 25, 2017 at 06:58:21PM +0200, Peter Zijlstra wrote: > Hi, > > On Sat, Jun 17, 2017 at 08:10:08AM -0400, Tejun Heo wrote: > > Per-cpu workqueues have been tripping CPU affinity sanity checks while > > a CPU is being offlined. A per-cpu kworker ends up running on a CPU > > which isn't i

Re: [PATCH v2 2/2] ASoC: sun4i-i2s: Add support for H3

2017-07-25 Thread Code Kipper
On 25 July 2017 at 16:36, Maxime Ripard wrote: > Hi, > > On Sat, Jul 22, 2017 at 08:53:52AM +0200, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> The sun8i-h3 introduces a lot of changes to the i2s block such >> as different register locations, extended clock division and >> more operat

Re: [PATCH 02/11] ASoC: samsung: s3c24xx: Handle return value of clk_prepare_enable.

2017-07-25 Thread Krzysztof Kozlowski
On Tue, Jul 25, 2017 at 03:44:29PM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > sound/soc/samsung/s3c24xx-i2s.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > Reviewed-by: Krzy

Re: [PATCH v4 1/5] pwm-backlight: enable/disable the PWM before/after LCD enable toggle.

2017-07-25 Thread Jingoo Han
On Monday, July 24, 2017 11:14 AM, Daniel Thompson wrote: > On 21/07/17 11:48, Enric Balletbo i Serra wrote: > > Before this patch the enable signal was set before the PWM signal and > > vice-versa on power off. This sequence is wrong, at least, it is on > > the different panels datasheets that I c

Re: [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update from suspend_noirq

2017-07-25 Thread Grygorii Strashko
Hi Johan, On 07/25/2017 03:24 AM, Johan Hovold wrote: > On Mon, Jul 24, 2017 at 05:16:02PM -0500, Grygorii Strashko wrote: >> On 07/24/2017 04:52 AM, Johan Hovold wrote: >>> Since commit a8636c89648a ("PM / Runtime: Don't allow to suspend a >>> device with an active child"), which went into 4.10,

Re: [PATCH -mm -v3 02/12] mm, THP, swap: Support to reclaim swap space for THP swapped out

2017-07-25 Thread Rik van Riel
On Mon, 2017-07-24 at 13:18 +0800, Huang, Ying wrote: > From: Huang Ying > > The normal swap slot reclaiming can be done when the swap count > reaches SWAP_HAS_CACHE.  But for the swap slot which is backing a > THP, > all swap slots backing one THP must be reclaimed together, because > the > swap

Re: USB disk speed regression WD Elements - with bisect result 22547c4cc4fe20698a6a85a55b8788859134b8e4

2017-07-25 Thread Zdenek Kabelac
Dne 25.7.2017 v 19:02 Alan Stern napsal(a): On Tue, 25 Jul 2017, Zdenek Kabelac wrote: And in fact it's the very same commit - which adds this message (just check current 4.13 with and without this commit reverted) So here goes usbmon trace (aka 'cat /sys/kernel/debug/usb/usbmon/0u') no other

Re: [PATCH] ARM: OMAP2+: omap_device: drop broken RPM status update from suspend_noirq

2017-07-25 Thread Grygorii Strashko
On 07/25/2017 03:56 AM, Tony Lindgren wrote: * Tony Lindgren [170725 00:11]: * Grygorii Strashko [170724 15:17]: My personal thought here is that removing of pm_runtime_set_active() will not fix root cause of the problem, but rather hide it :( and, probably, real fix will be to update USB

Re: [PATCH 01/11] ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable.

2017-07-25 Thread Krzysztof Kozlowski
On Tue, Jul 25, 2017 at 03:44:28PM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > sound/soc/samsung/s3c2412-i2s.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/sa

[PATCH v3] go2001 hardware codec support

2017-07-25 Thread Thierry Escande
Hi, This patch introduces the go2001 hardware codec driver. Changes in v3: - Replace crop iotcl with selection ones - Use video dev device_caps field - Return v4l2_ctrl_subscribe_event() for default case - Fix start_streaming error handling - Remove empty ctrl ops callbacks - Avoid use of private

[PATCH v3] [media] v4l2: Add support for go2001 PCI codec driver

2017-07-25 Thread Thierry Escande
This patch adds support for the go2001 PCI codec driver. This hardware is present on ChromeOS based devices like the Acer ChromeBox and Acer/LG ChromeBase 24 devices. This chipset comes on a mini PCI-E card with Google as PCI vendor ID (0x1ae0). This driver comes from the ChromeOS v3.18 kernel tre

[RESEND PATCH v2 2/2] drm/exynos/decon: Add include guard to the Exynos7 header

2017-07-25 Thread Krzysztof Kozlowski
Although header is included only once but still having an include guard is a good practice. To avoid confusion, add SoC prefix to existing Exynos5433 header include guard. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Just re-order patches in patchset and slightly adjust include

[RESEND PATCH v2 1/2] drm/exynos/decon: Move headers from global to local place

2017-07-25 Thread Krzysztof Kozlowski
The DECON headers contain only defines for registers. There are no other drivers using them so this should be put locally to the Exynos DRM driver. Keeping headers local helps managing the code. Suggested-by: Marek Szyprowski Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Just r

Re: [tpmdd-devel] tpm: read burstcount from TPM_STS in one 32-bit transaction

2017-07-25 Thread James Bottomley
On Tue, 2017-07-25 at 15:04 +0200, Michal Suchánek wrote: > Hello, > > in commit 9754d45e9970 ("tpm: read burstcount from TPM_STS in one > 32-bit transaction") you change reading of two 8-bit values to one > 32bit read. This is obviously wrong wrt endianess unless the > underlying tpm_tis_read32 d

Re: [PATCH 3/5] arm64: dts: msm8996: Add modem smp2p nodes

2017-07-25 Thread Stephen Boyd
On 07/24/2017 10:47 PM, Bjorn Andersson wrote: > Signed-off-by: Bjorn Andersson > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 24 > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi > b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index

Re: [PATCH wq/for-4.13-fixes] workqueue: implicit ordered attribute should be overridable

2017-07-25 Thread Tejun Heo
On Sun, Jul 23, 2017 at 08:36:15AM -0400, Tejun Heo wrote: > 5c0338c68706 ("workqueue: restore WQ_UNBOUND/max_active==1 to be > ordered") automatically enabled ordered attribute for unbound > workqueues w/ max_active == 1. Because ordered workqueues reject > max_active and some attribute changes,

Re: [PATCH v2] ARM: sa1100/pxa: fix MTD_XIP build

2017-07-25 Thread Robert Jarzmik
Arnd Bergmann writes: > In commit 3169663ac5902 "ARM: sa11x0/pxa: convert OS timer registers > to IOMEM", the definition of the OSCR macro was changed to be an > __iomem pointer, but the same register is also used by the XIP > code. This patch does the corresponding change here as well. > > On PX

[PATCH cgroup/for-4.14] cgroup: add comment to cgroup_enable_threaded()

2017-07-25 Thread Tejun Heo
>From c705a00d77457b44ba3790fdf0627ecb8593a254 Mon Sep 17 00:00:00 2001 From: Tejun Heo Date: Tue, 25 Jul 2017 13:20:18 -0400 Explain cgroup_enable_threaded() and note that the function can never be called on the root cgroup. Signed-off-by: Tejun Heo Suggested-by: Waiman Long --- Hello, Waiman

[PATCH net-next v2 05/10] net: dsa: added dsa_net_device_to_dsa_port()

2017-07-25 Thread Egil Hjelmeland
Allowing dsa drivers to attach sysfs nodes. Signed-off-by: Egil Hjelmeland --- include/net/dsa.h | 1 + net/dsa/slave.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/include/net/dsa.h b/include/net/dsa.h index 88da272d20d0..a71c0a2401ee 100644 --- a/include/net/dsa.h +++ b/

Re: [PATCH tip/core/rcu 4/5] sys_membarrier: Add expedited option

2017-07-25 Thread Paul E. McKenney
On Tue, Jul 25, 2017 at 06:59:57PM +0200, Peter Zijlstra wrote: > On Tue, Jul 25, 2017 at 09:49:00AM -0700, Paul E. McKenney wrote: > > On Tue, Jul 25, 2017 at 06:33:18PM +0200, Peter Zijlstra wrote: > > > On Mon, Jul 24, 2017 at 02:58:16PM -0700, Paul E. McKenney wrote: > > > > The sys_membarrier(

Re: [PATCH] cgroup: remove unnecessary empty check when enabling threaded mode

2017-07-25 Thread Tejun Heo
On Sun, Jul 23, 2017 at 08:18:26AM -0400, Tejun Heo wrote: > cgroup_enable_threaded() checks that the cgroup doesn't have any tasks > or children and fails the operation if so. This test is unnecessary > because the first part is already checked by > cgroup_can_be_thread_root() and the latter is u

[PATCH net-next v2 08/10] net: dsa: lan9303: Added ALR/fdb/mdb handling

2017-07-25 Thread Egil Hjelmeland
Added functions for accessing / managing the lan9303 ALR (Address Logic Resolution). Implemented DSA methods: set_addr, port_fast_age, port_fdb_prepare, port_fdb_add, port_fdb_del, port_fdb_dump, port_mdb_prepare, port_mdb_add and port_mdb_del. Since the lan9303 do not offer reading specific ALR

Re: [PATCH v2 2/4] cgroup: Allow bypass mode in subtree_control

2017-07-25 Thread Tejun Heo
Hello, Waiman. On Mon, Jul 24, 2017 at 02:20:59PM -0400, Waiman Long wrote: > As said in patch 3, enabling bypass mode at subtree_control delegate the > authority of enabling controllers to the children. The children own the > resource control files directly. It will be more straight forward to B

[PATCH net-next v2 09/10] net: dsa: lan9303: Added Documentation/networking/dsa/lan9303.txt

2017-07-25 Thread Egil Hjelmeland
Signed-off-by: Egil Hjelmeland --- Documentation/networking/dsa/lan9303.txt | 63 1 file changed, 63 insertions(+) create mode 100644 Documentation/networking/dsa/lan9303.txt diff --git a/Documentation/networking/dsa/lan9303.txt b/Documentation/networking/dsa/l

[PATCH net-next v2 10/10] net: dsa: lan9303: Only allocate 3 ports

2017-07-25 Thread Egil Hjelmeland
Saving 2628 bytes. Signed-off-by: Egil Hjelmeland Reviewed-by: Florian Fainelli --- drivers/net/dsa/lan9303-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c index dc95973d62ed..ad7a4c72e1fb 100644 --- a

[PATCH] kselftest: exec: make exec test output conform to TAP13

2017-07-25 Thread Paul Elder
Convert exec test output to TAP13 format, using the ksft framework. Signed-off-by: Paul Elder --- Depends on Shuah Khan's patch: "[PATCH 2/3] selftests: kselftest framework: add API to return pass/fail/* counts" (http://www.spinics.net/lists/linux-kselftest/msg01964.html) tools/testing/selft

Re: [PATCH] vc4: Add an ioctl for labeling GEM BOs for summary stats

2017-07-25 Thread Chris Wilson
Quoting Eric Anholt (2017-06-22 21:50:54) > This has proven immensely useful for debugging memory leaks and > overallocation (which is a rather serious concern on the platform, > given that we typically run at about 256MB of CMA out of up to 1GB > total memory, with framebuffers that are about 8MB

RE: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

2017-07-25 Thread Mani, Rajmohan
Hi Lee, > Subject: Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470 > > On Fri, 21 Jul 2017, Mani, Rajmohan wrote: > > > On Wed, 19 Jul 2017, Rajmohan Mani wrote: > > > > > > > The TPS68470 device is an advanced power management unit that > > > > powers > > > a > > > > Compact Camera Module (C

Re: [PATCH] ARM64: meson-gxl: disable broken eee

2017-07-25 Thread crow
Hello, On Mon, Jul 24, 2017 at 8:32 PM, Jerome Brunet wrote: > On Mon, 2017-07-24 at 20:20 +0200, Martin Blumenstingl wrote: >> On Mon, Jul 24, 2017 at 6:09 PM, Jerome Brunet wrote: >> > On Mon, 2017-07-24 at 14:26 +0200, Neil Armstrong wrote: >> > > On 07/24/2017 02:06 PM, Neil Armstrong wrote:

Re: [PATCH] perf: qcom_l2: fix column exclusion check

2017-07-25 Thread Mark Rutland
On Mon, Jul 24, 2017 at 05:17:02PM -0400, Neil Leeder wrote: > The check for column exclusion did not verify that the event being > checked was an L2 event, and not a software event. > Software events should not be checked for column exclusion. > This resulted in a group with both software and L2 e

Re: [PATCH] mtd: remove unused variable in mtdswap

2017-07-25 Thread Brian Norris
On Tue, Jul 25, 2017 at 05:41:58PM +0200, Arnd Bergmann wrote: > The only user of this variable was removed, leading to a > new harmless warning: > > drivers/mtd/mtdswap.c: In function 'mtdswap_add_debugfs': > drivers/mtd/mtdswap.c:1317:17: error: unused variable 'dev' > [-Werror=unused-variable]

Re: USB disk speed regression WD Elements - with bisect result 22547c4cc4fe20698a6a85a55b8788859134b8e4

2017-07-25 Thread Alan Stern
On Tue, 25 Jul 2017, Zdenek Kabelac wrote: > And in fact it's the very same commit - which adds this message > (just check current 4.13 with and without this commit reverted) > > So here goes usbmon trace (aka 'cat /sys/kernel/debug/usb/usbmon/0u') > no other usb device has been touch so should

Re: [PATCH tip/core/rcu 4/5] sys_membarrier: Add expedited option

2017-07-25 Thread Peter Zijlstra
On Tue, Jul 25, 2017 at 09:49:00AM -0700, Paul E. McKenney wrote: > On Tue, Jul 25, 2017 at 06:33:18PM +0200, Peter Zijlstra wrote: > > On Mon, Jul 24, 2017 at 02:58:16PM -0700, Paul E. McKenney wrote: > > > The sys_membarrier() system call has proven too slow for some use > > > cases, which has pr

Re: [PATCH RFC] sched: Allow migrating kthreads into online but inactive CPUs

2017-07-25 Thread Peter Zijlstra
Hi, On Sat, Jun 17, 2017 at 08:10:08AM -0400, Tejun Heo wrote: > Per-cpu workqueues have been tripping CPU affinity sanity checks while > a CPU is being offlined. A per-cpu kworker ends up running on a CPU > which isn't its target CPU while the CPU is online but inactive. > > While the scheduler

Re: [PATCH tip/core/rcu 4/5] sys_membarrier: Add expedited option

2017-07-25 Thread Paul E. McKenney
On Tue, Jul 25, 2017 at 06:33:18PM +0200, Peter Zijlstra wrote: > On Mon, Jul 24, 2017 at 02:58:16PM -0700, Paul E. McKenney wrote: > > The sys_membarrier() system call has proven too slow for some use > > cases, which has prompted users to instead rely on TLB shootdown. > > Although TLB shootdown

Re: [PATCH 09/10] arm64: zynqmp: Add new uartps compatible string

2017-07-25 Thread Moritz Fischer
On Thu, Jul 20, 2017 at 02:17:08PM +0200, Michal Simek wrote: > Mainline kernel has r1p12 compatible string now. Use this new compatible > string and also append generic compatible string. > Keep in your mind that using this generic compatible string not all uart > features will be available. > >

Re: [PATCH tip/core/rcu 4/5] sys_membarrier: Add expedited option

2017-07-25 Thread Paul E. McKenney
On Tue, Jul 25, 2017 at 01:21:08PM +, Mathieu Desnoyers wrote: > - On Jul 24, 2017, at 5:58 PM, Paul E. McKenney > paul...@linux.vnet.ibm.com wrote: > > > The sys_membarrier() system call has proven too slow for some use > > cases, which has prompted users to instead rely on TLB shootdown

Re: [PATCH 01/10] arm64: zynqmp: Add references to cpu nodes

2017-07-25 Thread Moritz Fischer
On Thu, Jul 20, 2017 at 02:17:00PM +0200, Michal Simek wrote: > Add missing references to all cpu nodes. > > Signed-off-by: Michal Simek Reviewed-by: Moritz Fischer > --- > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

<    4   5   6   7   8   9   10   11   12   13   >