Re: [PATCH v9 02/10] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-10-30 Thread Corentin Labbe
On Fri, Oct 27, 2017 at 09:37:10AM -0500, Rob Herring wrote: > On Tue, Oct 24, 2017 at 07:57:06PM +0200, Corentin Labbe wrote: > > This patch add documentation about the MDIO switch used on sun8i-h3-emac > > for integrated PHY. > > > > Signed-off-by: Corentin Labbe > >

Re: Proposal: rename tpm1_eventlog.c and tpm2_eventlog.c

2017-10-30 Thread Nayna Jain
On 10/25/2017 03:51 AM, Jarkko Sakkinen wrote: I noticed when making slides for KS that the naming for event log stuff that the naming is so broken that it is hard to understand the code. Here it really would make sense to have a patch set just to clean up the cruft. Random examples of more

Re: [PATCH v9 02/10] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-10-30 Thread Corentin Labbe
On Fri, Oct 27, 2017 at 09:37:10AM -0500, Rob Herring wrote: > On Tue, Oct 24, 2017 at 07:57:06PM +0200, Corentin Labbe wrote: > > This patch add documentation about the MDIO switch used on sun8i-h3-emac > > for integrated PHY. > > > > Signed-off-by: Corentin Labbe > > --- > >

Re: Proposal: rename tpm1_eventlog.c and tpm2_eventlog.c

2017-10-30 Thread Nayna Jain
On 10/25/2017 03:51 AM, Jarkko Sakkinen wrote: I noticed when making slides for KS that the naming for event log stuff that the naming is so broken that it is hard to understand the code. Here it really would make sense to have a patch set just to clean up the cruft. Random examples of more

Re: KASAN: use-after-free Write in detach_if_pending

2017-10-30 Thread Eric Dumazet
On Mon, 2017-10-30 at 20:52 +0300, Dmitry Vyukov wrote: > syz fix: patch title > > then that's doable. If we agree on this format, then I am ready to > implement this. Yes please. David Miller and Linus never rebase their trees, for good reasons.

Re: KASAN: use-after-free Write in detach_if_pending

2017-10-30 Thread Eric Dumazet
On Mon, 2017-10-30 at 20:52 +0300, Dmitry Vyukov wrote: > syz fix: patch title > > then that's doable. If we agree on this format, then I am ready to > implement this. Yes please. David Miller and Linus never rebase their trees, for good reasons.

linux-next: manual merge of the drm tree with Linus' tree

2017-10-30 Thread Mark Brown
Hi Dave, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/scheduler/gpu_scheduler.c between commit: c94501279bb191c ("Revert "drm/amdgpu: discard commands of killed processes"") from Linus' tree (it even made it into -rc6 over a week ago!) and the fixes it

linux-next: manual merge of the drm tree with Linus' tree

2017-10-30 Thread Mark Brown
Hi Dave, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/scheduler/gpu_scheduler.c between commit: c94501279bb191c ("Revert "drm/amdgpu: discard commands of killed processes"") from Linus' tree (it even made it into -rc6 over a week ago!) and the fixes it

Re: [PATCH] net: ethernet: slicoss: remove redundant initialization of idx

2017-10-30 Thread Lino Sanfilippo
On 30.10.2017 19:04, Jakub Kicinski wrote: > On Sun, 29 Oct 2017 13:38:09 +, Colin King wrote: >> From: Colin Ian King >> >> Variable idx is being initialized and later on over-written by >> a new value in a do-loop without the initial value ever being >> read. Hence

Re: [PATCH] net: ethernet: slicoss: remove redundant initialization of idx

2017-10-30 Thread Lino Sanfilippo
On 30.10.2017 19:04, Jakub Kicinski wrote: > On Sun, 29 Oct 2017 13:38:09 +, Colin King wrote: >> From: Colin Ian King >> >> Variable idx is being initialized and later on over-written by >> a new value in a do-loop without the initial value ever being >> read. Hence the initializion is

linux-next: manual merge of the spi-nor tree with the imx-mxs tree

2017-10-30 Thread Mark Brown
Hi Cyrille, Today's linux-next merge of the spi-nor tree got a conflict in: Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt between commit: b07815d4eaf65 ("dt-bindings: mtd: add sst25wf040b and en25s64 to sip-nor list") from the imx-mxs tree and commit: 282e45dc64d1 ("mtd:

linux-next: manual merge of the spi-nor tree with the imx-mxs tree

2017-10-30 Thread Mark Brown
Hi Cyrille, Today's linux-next merge of the spi-nor tree got a conflict in: Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt between commit: b07815d4eaf65 ("dt-bindings: mtd: add sst25wf040b and en25s64 to sip-nor list") from the imx-mxs tree and commit: 282e45dc64d1 ("mtd:

RE: Updates your account.

2017-10-30 Thread Beatrice A. Jones
Dear Staff, Note that Microsoft Outlook Windows Updates is scheduled for today and installed on all users' workstations. Please Click here to Updates your account, Your device will prompt to restart after the update has been completely installed.

RE: Updates your account.

2017-10-30 Thread Beatrice A. Jones
Dear Staff, Note that Microsoft Outlook Windows Updates is scheduled for today and installed on all users' workstations. Please Click here to Updates your account, Your device will prompt to restart after the update has been completely installed.

Re: linux-next: manual merge of the net-next tree with Linus' tree

2017-10-30 Thread Mark Brown
On Mon, Oct 30, 2017 at 10:43:07AM -0700, Jakub Kicinski wrote: > On Mon, 30 Oct 2017 17:02:24 +, Mark Brown wrote: > > is submitted for merging. You may also want to consider cooperating > > with the maintainer of the conflicting tree to minimise any particularly > > complex conflicts. >

Re: linux-next: manual merge of the net-next tree with Linus' tree

2017-10-30 Thread Mark Brown
On Mon, Oct 30, 2017 at 10:43:07AM -0700, Jakub Kicinski wrote: > On Mon, 30 Oct 2017 17:02:24 +, Mark Brown wrote: > > is submitted for merging. You may also want to consider cooperating > > with the maintainer of the conflicting tree to minimise any particularly > > complex conflicts. >

[PATCH v2] sched/sysctl: Fix attributes of some extern declarations

2017-10-30 Thread Matthias Kaehlcke
The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate and sysctl_sched_time_avg includes the attribute const_debug. This attribute is not part of the extern declaration of these variables in include/linux/sched/sysctl.h, as a result clang generates warnings like this:

[PATCH v2] sched/sysctl: Fix attributes of some extern declarations

2017-10-30 Thread Matthias Kaehlcke
The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate and sysctl_sched_time_avg includes the attribute const_debug. This attribute is not part of the extern declaration of these variables in include/linux/sched/sysctl.h, as a result clang generates warnings like this:

Re: rseq event_counter field

2017-10-30 Thread Kyle Huey
On Sat, Oct 28, 2017 at 1:20 PM, Andy Lutomirski wrote: > Answering both emails here. > > Also, welcome Kyle. Kyle, how badly does rseq's proposed > event_counter break rr? For that matter, how badly does rseq without > an event_counter break rr? > > (Linus, if you care, I'm

Re: rseq event_counter field

2017-10-30 Thread Kyle Huey
On Sat, Oct 28, 2017 at 1:20 PM, Andy Lutomirski wrote: > Answering both emails here. > > Also, welcome Kyle. Kyle, how badly does rseq's proposed > event_counter break rr? For that matter, how badly does rseq without > an event_counter break rr? > > (Linus, if you care, I'm proposing that rseq

Re: [PATCH] rcu: Convert timers to use timer_setup()

2017-10-30 Thread Paul E. McKenney
On Wed, Oct 25, 2017 at 04:17:32PM +0200, Kees Cook wrote: > Sorry, I sent this and forgot that timer_setup_on_stack() is only in > -next. If this patch is okay, I can carry it in the timers tree. Given the fixes I called out, I am fine with your carrying it separately.

Re: [PATCH] rcu: Convert timers to use timer_setup()

2017-10-30 Thread Paul E. McKenney
On Wed, Oct 25, 2017 at 04:17:32PM +0200, Kees Cook wrote: > Sorry, I sent this and forgot that timer_setup_on_stack() is only in > -next. If this patch is okay, I can carry it in the timers tree. Given the fixes I called out, I am fine with your carrying it separately.

Re: [PATCH] net: ethernet: slicoss: remove redundant initialization of idx

2017-10-30 Thread Jakub Kicinski
On Sun, 29 Oct 2017 13:38:09 +, Colin King wrote: > From: Colin Ian King > > Variable idx is being initialized and later on over-written by > a new value in a do-loop without the initial value ever being > read. Hence the initializion is redundant and can be

Re: [PATCH] net: ethernet: slicoss: remove redundant initialization of idx

2017-10-30 Thread Jakub Kicinski
On Sun, 29 Oct 2017 13:38:09 +, Colin King wrote: > From: Colin Ian King > > Variable idx is being initialized and later on over-written by > a new value in a do-loop without the initial value ever being > read. Hence the initializion is redundant and can be removed. > Cleans up clang

Re: [PATCH] rcu: Convert timers to use timer_setup()

2017-10-30 Thread Paul E. McKenney
On Tue, Oct 24, 2017 at 02:32:04AM -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: "Paul E. McKenney"

Re: [PATCH] rcu: Convert timers to use timer_setup()

2017-10-30 Thread Paul E. McKenney
On Tue, Oct 24, 2017 at 02:32:04AM -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: "Paul E. McKenney" > Cc: Josh

Re: [PATCH v2] bcache: explicitly destroy mutex while exiting

2017-10-30 Thread Michael Lyle
Hi Liang-- On 10/30/2017 05:33 AM, Liang C wrote: > Hi Michael, > Would you please to include this patch in your tree for the next > release? It seems passed the review. Thank you. > > Thanks, > Liang Thanks for the reminder. It's in my bcache-for-next tree at https://github.com/mlyle/linux/

Re: [PATCH v2] bcache: explicitly destroy mutex while exiting

2017-10-30 Thread Michael Lyle
Hi Liang-- On 10/30/2017 05:33 AM, Liang C wrote: > Hi Michael, > Would you please to include this patch in your tree for the next > release? It seems passed the review. Thank you. > > Thanks, > Liang Thanks for the reminder. It's in my bcache-for-next tree at https://github.com/mlyle/linux/

Re: [ghes_copy_tofrom_phys] BUG: sleeping function called from invalid context at mm/page_alloc.c:4150

2017-10-30 Thread Linus Torvalds
On Mon, Oct 30, 2017 at 10:49 AM, Will Deacon wrote: > > FWIW, we discussed some of this back in 2015, because the TLB invalidation > looks busted to me too: Yeah, I think the basic issue is that ioremap() is not supposed to map *over* an existing mapping, it's designed to

Re: [ghes_copy_tofrom_phys] BUG: sleeping function called from invalid context at mm/page_alloc.c:4150

2017-10-30 Thread Linus Torvalds
On Mon, Oct 30, 2017 at 10:49 AM, Will Deacon wrote: > > FWIW, we discussed some of this back in 2015, because the TLB invalidation > looks busted to me too: Yeah, I think the basic issue is that ioremap() is not supposed to map *over* an existing mapping, it's designed to map pages into a new

Re: [Part2 PATCH v6.1 16/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-30 Thread Borislav Petkov
On Mon, Oct 30, 2017 at 12:49:14PM -0500, Brijesh Singh wrote: > If the buffer is allocated on the stack then there is no guarantee that static global is not allocated on the stack. > I can certainly move the allocation outside, but then it may increase the > code size in other functions. If its

Re: [Part2 PATCH v6.1 16/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-30 Thread Borislav Petkov
On Mon, Oct 30, 2017 at 12:49:14PM -0500, Brijesh Singh wrote: > If the buffer is allocated on the stack then there is no guarantee that static global is not allocated on the stack. > I can certainly move the allocation outside, but then it may increase the > code size in other functions. If its

Re: KASAN: use-after-free Write in detach_if_pending

2017-10-30 Thread Dmitry Vyukov
On Mon, Oct 30, 2017 at 8:47 PM, Eric Dumazet wrote: > On Mon, 2017-10-30 at 18:40 +0100, Dmitry Vyukov wrote: >> On Mon, Oct 30, 2017 at 6:30 PM, Eric Dumazet wrote: >> > On Mon, 2017-10-30 at 18:06 +0100, Dmitry Vyukov wrote: >> > >> >> Yes, but

Re: KASAN: use-after-free Write in detach_if_pending

2017-10-30 Thread Dmitry Vyukov
On Mon, Oct 30, 2017 at 8:47 PM, Eric Dumazet wrote: > On Mon, 2017-10-30 at 18:40 +0100, Dmitry Vyukov wrote: >> On Mon, Oct 30, 2017 at 6:30 PM, Eric Dumazet wrote: >> > On Mon, 2017-10-30 at 18:06 +0100, Dmitry Vyukov wrote: >> > >> >> Yes, but hashes in random trees also don't tell much. A

Re: [PATCH 03/27] Enforce module signatures if the kernel is locked down

2017-10-30 Thread Mimi Zohar
[Corrected Matthew Garrett's email address.  Cc'ed Bruno Meneguele] On Mon, 2017-10-30 at 17:00 +, David Howells wrote: > Mimi Zohar wrote: > > > This kernel_is_locked_down() check is being called for both the > > original and new module_load syscalls.  We need to

Re: [PATCH 03/27] Enforce module signatures if the kernel is locked down

2017-10-30 Thread Mimi Zohar
[Corrected Matthew Garrett's email address.  Cc'ed Bruno Meneguele] On Mon, 2017-10-30 at 17:00 +, David Howells wrote: > Mimi Zohar wrote: > > > This kernel_is_locked_down() check is being called for both the > > original and new module_load syscalls.  We need to be able > > differentiate

Re: [PATCH v3 00/13] dax: fix dma vs truncate and remove 'page-less' support

2017-10-30 Thread Dan Williams
On Mon, Oct 30, 2017 at 4:20 AM, Dave Chinner wrote: > On Mon, Oct 30, 2017 at 09:38:07AM +0100, Jan Kara wrote: >> Hi, >> >> On Mon 30-10-17 13:00:23, Dave Chinner wrote: >> > On Sun, Oct 29, 2017 at 04:46:44PM -0700, Dan Williams wrote: >> > > Coming back to this since Dave

Re: [PATCH v3 00/13] dax: fix dma vs truncate and remove 'page-less' support

2017-10-30 Thread Dan Williams
On Mon, Oct 30, 2017 at 4:20 AM, Dave Chinner wrote: > On Mon, Oct 30, 2017 at 09:38:07AM +0100, Jan Kara wrote: >> Hi, >> >> On Mon 30-10-17 13:00:23, Dave Chinner wrote: >> > On Sun, Oct 29, 2017 at 04:46:44PM -0700, Dan Williams wrote: >> > > Coming back to this since Dave has made clear that

[PATCH] pinctrl: pistachio: Use common error handling code in pistachio_gpio_register()

2017-10-30 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 30 Oct 2017 18:40:10 +0100 Adjust jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH] pinctrl: pistachio: Use common error handling code in pistachio_gpio_register()

2017-10-30 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 30 Oct 2017 18:40:10 +0100 Adjust jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pinctrl/pinctrl-pistachio.c

Re: [ghes_copy_tofrom_phys] BUG: sleeping function called from invalid context at mm/page_alloc.c:4150

2017-10-30 Thread Will Deacon
On Mon, Oct 30, 2017 at 10:46:31AM -0700, Linus Torvalds wrote: > On Mon, Oct 30, 2017 at 10:20 AM, Linus Torvalds > wrote: > > > > I will add a "might_sleep()" to ioremap_page_range() itself, so that > > we get this warning more reliably and much eailer. Right now

Re: [ghes_copy_tofrom_phys] BUG: sleeping function called from invalid context at mm/page_alloc.c:4150

2017-10-30 Thread Will Deacon
On Mon, Oct 30, 2017 at 10:46:31AM -0700, Linus Torvalds wrote: > On Mon, Oct 30, 2017 at 10:20 AM, Linus Torvalds > wrote: > > > > I will add a "might_sleep()" to ioremap_page_range() itself, so that > > we get this warning more reliably and much eailer. Right now it has > > been hidden by the

Re: [Part2 PATCH v6.1 16/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-30 Thread Brijesh Singh
On 10/30/2017 12:21 PM, Borislav Petkov wrote: ... Useless forward declarations. Actually its helpful in other patches. I was trying to avoid making too many code movement in other patches to eliminate the forward declarations. I guess I can fix in v7. static struct psp_device

Re: [Part2 PATCH v6.1 16/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-30 Thread Brijesh Singh
On 10/30/2017 12:21 PM, Borislav Petkov wrote: ... Useless forward declarations. Actually its helpful in other patches. I was trying to avoid making too many code movement in other patches to eliminate the forward declarations. I guess I can fix in v7. static struct psp_device

Re: KASAN: use-after-free Write in detach_if_pending

2017-10-30 Thread Eric Dumazet
On Mon, 2017-10-30 at 18:40 +0100, Dmitry Vyukov wrote: > On Mon, Oct 30, 2017 at 6:30 PM, Eric Dumazet wrote: > > On Mon, 2017-10-30 at 18:06 +0100, Dmitry Vyukov wrote: > > > >> Yes, but hashes in random trees also don't tell much. A tree can be > >> rebased so the hash

Re: KASAN: use-after-free Write in detach_if_pending

2017-10-30 Thread Eric Dumazet
On Mon, 2017-10-30 at 18:40 +0100, Dmitry Vyukov wrote: > On Mon, Oct 30, 2017 at 6:30 PM, Eric Dumazet wrote: > > On Mon, 2017-10-30 at 18:06 +0100, Dmitry Vyukov wrote: > > > >> Yes, but hashes in random trees also don't tell much. A tree can be > >> rebased so the hash will be lost. It can be

Re: [ghes_copy_tofrom_phys] BUG: sleeping function called from invalid context at mm/page_alloc.c:4150

2017-10-30 Thread Linus Torvalds
On Mon, Oct 30, 2017 at 10:20 AM, Linus Torvalds wrote: > > I will add a "might_sleep()" to ioremap_page_range() itself, so that > we get this warning more reliably and much eailer. Right now it has > been hidden by the fact that most of the time the time the page

Re: [ghes_copy_tofrom_phys] BUG: sleeping function called from invalid context at mm/page_alloc.c:4150

2017-10-30 Thread Linus Torvalds
On Mon, Oct 30, 2017 at 10:20 AM, Linus Torvalds wrote: > > I will add a "might_sleep()" to ioremap_page_range() itself, so that > we get this warning more reliably and much eailer. Right now it has > been hidden by the fact that most of the time the time the page tables > may be already

Re: linux-next: manual merge of the net-next tree with Linus' tree

2017-10-30 Thread Jakub Kicinski
On Mon, 30 Oct 2017 17:02:24 +, Mark Brown wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/netronome/nfp/flower/action.c > > between commit: > > d309ae5c6a0064 ("nfp: refuse offloading filters that redirects to upper >

Re: linux-next: manual merge of the net-next tree with Linus' tree

2017-10-30 Thread Jakub Kicinski
On Mon, 30 Oct 2017 17:02:24 +, Mark Brown wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/netronome/nfp/flower/action.c > > between commit: > > d309ae5c6a0064 ("nfp: refuse offloading filters that redirects to upper >

Re: [PATCH] sched/sysctl: Fix attributes of some extern declarations

2017-10-30 Thread Peter Zijlstra
On Mon, Oct 30, 2017 at 10:27:10AM -0700, Matthias Kaehlcke wrote: > El Mon, Oct 30, 2017 at 09:26:12AM +0100 Peter Zijlstra ha dit: > > > On Fri, Oct 27, 2017 at 04:40:20PM -0700, Matthias Kaehlcke wrote: > > > The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate > > > and

Re: [PATCH] sched/sysctl: Fix attributes of some extern declarations

2017-10-30 Thread Peter Zijlstra
On Mon, Oct 30, 2017 at 10:27:10AM -0700, Matthias Kaehlcke wrote: > El Mon, Oct 30, 2017 at 09:26:12AM +0100 Peter Zijlstra ha dit: > > > On Fri, Oct 27, 2017 at 04:40:20PM -0700, Matthias Kaehlcke wrote: > > > The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate > > > and

Re: [ghes_copy_tofrom_phys] BUG: sleeping function called from invalid context at mm/page_alloc.c:4150

2017-10-30 Thread Borislav Petkov
On Mon, Oct 30, 2017 at 10:20:40AM -0700, Linus Torvalds wrote: > I think this whole driver is garbage. This "driver" was supposed to implement the handle-hw-errors-in-fw glue crap. The thing is, no one has been using it properly because there's not even a single firmware vendor who has managed

Re: [ghes_copy_tofrom_phys] BUG: sleeping function called from invalid context at mm/page_alloc.c:4150

2017-10-30 Thread Borislav Petkov
On Mon, Oct 30, 2017 at 10:20:40AM -0700, Linus Torvalds wrote: > I think this whole driver is garbage. This "driver" was supposed to implement the handle-hw-errors-in-fw glue crap. The thing is, no one has been using it properly because there's not even a single firmware vendor who has managed

Re: KASAN: use-after-free Write in detach_if_pending

2017-10-30 Thread Dmitry Vyukov
On Mon, Oct 30, 2017 at 6:30 PM, Eric Dumazet wrote: > On Mon, 2017-10-30 at 18:06 +0100, Dmitry Vyukov wrote: > >> Yes, but hashes in random trees also don't tell much. A tree can be >> rebased so the hash will be lost. It can be a tree unknown to the >> system. Even if

Re: KASAN: use-after-free Write in detach_if_pending

2017-10-30 Thread Dmitry Vyukov
On Mon, Oct 30, 2017 at 6:30 PM, Eric Dumazet wrote: > On Mon, 2017-10-30 at 18:06 +0100, Dmitry Vyukov wrote: > >> Yes, but hashes in random trees also don't tell much. A tree can be >> rebased so the hash will be lost. It can be a tree unknown to the >> system. Even if we find the commit by

Re: KASAN: use-after-free Write in detach_if_pending

2017-10-30 Thread syzbot
On Mon, Oct 30, 2017 at 6:30 PM, Eric Dumazet wrote: On Mon, 2017-10-30 at 18:06 +0100, Dmitry Vyukov wrote: Yes, but hashes in random trees also don't tell much. A tree can be rebased so the hash will be lost. It can be a tree unknown to the system. Even if we find

Re: KASAN: use-after-free Write in detach_if_pending

2017-10-30 Thread syzbot
On Mon, Oct 30, 2017 at 6:30 PM, Eric Dumazet wrote: On Mon, 2017-10-30 at 18:06 +0100, Dmitry Vyukov wrote: Yes, but hashes in random trees also don't tell much. A tree can be rebased so the hash will be lost. It can be a tree unknown to the system. Even if we find the commit by hash, in

Re: 492b95e597 ("rcuperf: Set more user-friendly defaults"): WARNING: CPU: 0 PID: 1 at arch/x86/kernel/smp.c:128 native_smp_send_reschedule

2017-10-30 Thread Paul E. McKenney
On Wed, Oct 25, 2017 at 07:53:40AM +0200, Fengguang Wu wrote: > Hi Paul, > > On Tue, Oct 24, 2017 at 06:25:13AM -0700, Paul E. McKenney wrote: > >On Tue, Oct 24, 2017 at 04:49:52AM +0200, Fengguang Wu wrote: > >>Greetings, > >> > >>0day kernel testing robot got the below dmesg and the first bad

Re: 492b95e597 ("rcuperf: Set more user-friendly defaults"): WARNING: CPU: 0 PID: 1 at arch/x86/kernel/smp.c:128 native_smp_send_reschedule

2017-10-30 Thread Paul E. McKenney
On Wed, Oct 25, 2017 at 07:53:40AM +0200, Fengguang Wu wrote: > Hi Paul, > > On Tue, Oct 24, 2017 at 06:25:13AM -0700, Paul E. McKenney wrote: > >On Tue, Oct 24, 2017 at 04:49:52AM +0200, Fengguang Wu wrote: > >>Greetings, > >> > >>0day kernel testing robot got the below dmesg and the first bad

Re: [PATCH] net: ethernet: slicoss: remove redundant initialization of idx

2017-10-30 Thread Lino Sanfilippo
Hi Colin, On 29.10.2017 14:38, Colin King wrote: > From: Colin Ian King > > Variable idx is being initialized and later on over-written by > a new value in a do-loop without the initial value ever being > read. Hence the initializion is redundant and can be removed. >

Re: [PATCH] net: ethernet: slicoss: remove redundant initialization of idx

2017-10-30 Thread Lino Sanfilippo
Hi Colin, On 29.10.2017 14:38, Colin King wrote: > From: Colin Ian King > > Variable idx is being initialized and later on over-written by > a new value in a do-loop without the initial value ever being > read. Hence the initializion is redundant and can be removed. > Cleans up clang warning: >

Re: KASAN: use-after-free Write in detach_if_pending

2017-10-30 Thread Eric Dumazet
On Mon, 2017-10-30 at 18:06 +0100, Dmitry Vyukov wrote: > Yes, but hashes in random trees also don't tell much. A tree can be > rebased so the hash will be lost. It can be a tree unknown to the > system. Even if we find the commit by hash, in order to match it > against other trees we will have

Re: KASAN: use-after-free Write in detach_if_pending

2017-10-30 Thread Eric Dumazet
On Mon, 2017-10-30 at 18:06 +0100, Dmitry Vyukov wrote: > Yes, but hashes in random trees also don't tell much. A tree can be > rebased so the hash will be lost. It can be a tree unknown to the > system. Even if we find the commit by hash, in order to match it > against other trees we will have

Re: [PATCH v2 0/7] fix fanotify issues with the series in v4.12

2017-10-30 Thread Jan Kara
On Fri 27-10-17 13:53:20, Jan Kara wrote: > On Wed 25-10-17 16:31:39, Miklos Szeredi wrote: > > On Wed, Oct 25, 2017 at 10:41 AM, Miklos Szeredi > > wrote: > > > We discovered some problems in the latest fsnotify/fanotify codebase with > > > the help of a stress test (Xiong

Re: [PATCH v2 0/7] fix fanotify issues with the series in v4.12

2017-10-30 Thread Jan Kara
On Fri 27-10-17 13:53:20, Jan Kara wrote: > On Wed 25-10-17 16:31:39, Miklos Szeredi wrote: > > On Wed, Oct 25, 2017 at 10:41 AM, Miklos Szeredi > > wrote: > > > We discovered some problems in the latest fsnotify/fanotify codebase with > > > the help of a stress test (Xiong Zhou is working on

Re: [PATCH] sched/sysctl: Fix attributes of some extern declarations

2017-10-30 Thread Matthias Kaehlcke
El Mon, Oct 30, 2017 at 09:26:12AM +0100 Peter Zijlstra ha dit: > On Fri, Oct 27, 2017 at 04:40:20PM -0700, Matthias Kaehlcke wrote: > > The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate > > and sysctl_sched_time_avg includes the attribute const_debug. This > > attribute is

Re: [PATCH] sched/sysctl: Fix attributes of some extern declarations

2017-10-30 Thread Matthias Kaehlcke
El Mon, Oct 30, 2017 at 09:26:12AM +0100 Peter Zijlstra ha dit: > On Fri, Oct 27, 2017 at 04:40:20PM -0700, Matthias Kaehlcke wrote: > > The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate > > and sysctl_sched_time_avg includes the attribute const_debug. This > > attribute is

linux-next: manual merge of the net-next tree with Linus' tree

2017-10-30 Thread Mark Brown
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/ipv4/tcp_output.c between commit: 5889e2c0e441d8 ("tcp: call tcp_rate_skb_sent() when retransmit with unaligned skb->data") from Linus' tree and commit: e2080072ed2d98 ("tcp: new list for sent but unacked

linux-next: manual merge of the net-next tree with Linus' tree

2017-10-30 Thread Mark Brown
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/ipv4/tcp_output.c between commit: 5889e2c0e441d8 ("tcp: call tcp_rate_skb_sent() when retransmit with unaligned skb->data") from Linus' tree and commit: e2080072ed2d98 ("tcp: new list for sent but unacked

Re: [Part2 PATCH v6.1 16/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-30 Thread Borislav Petkov
On Sun, Oct 29, 2017 at 03:48:25PM -0500, Brijesh Singh wrote: > AMD's new Secure Encrypted Virtualization (SEV) feature allows the > memory contents of virtual machines to be transparently encrypted with a > key unique to the VM. The programming and management of the encryption > keys are handled

Re: [Part2 PATCH v6.1 16/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-30 Thread Borislav Petkov
On Sun, Oct 29, 2017 at 03:48:25PM -0500, Brijesh Singh wrote: > AMD's new Secure Encrypted Virtualization (SEV) feature allows the > memory contents of virtual machines to be transparently encrypted with a > key unique to the VM. The programming and management of the encryption > keys are handled

Re: [PATCH -v2 12/18] sched/fair: Rewrite PELT migration propagation

2017-10-30 Thread Peter Zijlstra
So after a bit of poking I ended up with something like the below; I think there's still a few open points, see XXX. But its better than we have now. Josef, could you see if this completely wrecks your workloads? --- Subject: sched: Update runnable propagation rule From: Vincent Guittot

Re: [PATCH -v2 12/18] sched/fair: Rewrite PELT migration propagation

2017-10-30 Thread Peter Zijlstra
So after a bit of poking I ended up with something like the below; I think there's still a few open points, see XXX. But its better than we have now. Josef, could you see if this completely wrecks your workloads? --- Subject: sched: Update runnable propagation rule From: Vincent Guittot Date:

Re: [PATCH v2 7/7] fanotify: clean up CONFIG_FANOTIFY_ACCESS_PERMISSIONS ifdefs

2017-10-30 Thread Jan Kara
On Wed 25-10-17 10:41:39, Miklos Szeredi wrote: > The only negative from this patch should be an addition of 32bytes to > 'struct fsnotify_group' if CONFIG_FANOTIFY_ACCESS_PERMISSIONS is not > defined. > > Signed-off-by: Miklos Szeredi I like this but some comments below.

Re: [ghes_copy_tofrom_phys] BUG: sleeping function called from invalid context at mm/page_alloc.c:4150

2017-10-30 Thread Linus Torvalds
On Mon, Oct 30, 2017 at 4:05 AM, Borislav Petkov wrote: > > Looks like Tyler broke it: > > 77b246b32b2c ("acpi: apei: check for pending errors when probing GHES > entries") > > and it went into 4.13 and -stable. I think this whole driver is garbage. It does ioremap_page_range()

Re: [PATCH v2 7/7] fanotify: clean up CONFIG_FANOTIFY_ACCESS_PERMISSIONS ifdefs

2017-10-30 Thread Jan Kara
On Wed 25-10-17 10:41:39, Miklos Szeredi wrote: > The only negative from this patch should be an addition of 32bytes to > 'struct fsnotify_group' if CONFIG_FANOTIFY_ACCESS_PERMISSIONS is not > defined. > > Signed-off-by: Miklos Szeredi I like this but some comments below. > @@ -338,11 +332,14

Re: [ghes_copy_tofrom_phys] BUG: sleeping function called from invalid context at mm/page_alloc.c:4150

2017-10-30 Thread Linus Torvalds
On Mon, Oct 30, 2017 at 4:05 AM, Borislav Petkov wrote: > > Looks like Tyler broke it: > > 77b246b32b2c ("acpi: apei: check for pending errors when probing GHES > entries") > > and it went into 4.13 and -stable. I think this whole driver is garbage. It does ioremap_page_range() in both NMI and

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

2017-10-30 Thread Doug Anderson
Hi, On Mon, Oct 30, 2017 at 1:32 AM, Felipe Balbi wrote: > > Hi, > > Doug Anderson writes: >> Hi, >> >> On Sat, Oct 28, 2017 at 8:51 AM, Stefan Wahren >> wrote: >>> Hi Doug, >>> >>> [add Felipe since this should go through his

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

2017-10-30 Thread Doug Anderson
Hi, On Mon, Oct 30, 2017 at 1:32 AM, Felipe Balbi wrote: > > Hi, > > Doug Anderson writes: >> Hi, >> >> On Sat, Oct 28, 2017 at 8:51 AM, Stefan Wahren >> wrote: >>> Hi Doug, >>> >>> [add Felipe since this should go through his tree] >> >> Ah. Sorry Felipe! I know you've landed some dwc2

Re: [PATCH] ARM: add a private asm/unaligned.h

2017-10-30 Thread Russell King - ARM Linux
On Mon, Oct 30, 2017 at 06:01:44PM +0100, Arnd Bergmann wrote: > Right, either fail the build or use the workaround from the gcc bugzilla, > passing -fno-store-merging to the broken compilers avoids the problem > reliably at the cost of slightly worse code. For the decompressor, we might > also

Re: [PATCH] ARM: add a private asm/unaligned.h

2017-10-30 Thread Russell King - ARM Linux
On Mon, Oct 30, 2017 at 06:01:44PM +0100, Arnd Bergmann wrote: > Right, either fail the build or use the workaround from the gcc bugzilla, > passing -fno-store-merging to the broken compilers avoids the problem > reliably at the cost of slightly worse code. For the decompressor, we might > also

[PATCH v3 1/2] usb: dwc2: host: Don't retry NAKed transactions right away

2017-10-30 Thread Douglas Anderson
On rk3288-veyron devices on Chrome OS it was found that plugging in an Arduino-based USB device could cause the system to lockup, especially if the CPU Frequency was at one of the slower operating points (like 100 MHz / 200 MHz). Upon tracing, I found that the following was happening: * The USB

[PATCH v3 1/2] usb: dwc2: host: Don't retry NAKed transactions right away

2017-10-30 Thread Douglas Anderson
On rk3288-veyron devices on Chrome OS it was found that plugging in an Arduino-based USB device could cause the system to lockup, especially if the CPU Frequency was at one of the slower operating points (like 100 MHz / 200 MHz). Upon tracing, I found that the following was happening: * The USB

linux-next: manual merge of the net-next tree with Linus' tree

2017-10-30 Thread Mark Brown
Hi all, Today's linux-next merge of the net-next tree got a conflict in: kernel/bpf/sockmap.c between commit: bfa640757e9378c ("bpf: rename sk_actions to align with bpf infrastructure") from Linus' tree and commit: 6aaae2b6c4330a4 ("bpf: rename bpf_compute_data_end into

linux-next: manual merge of the net-next tree with Linus' tree

2017-10-30 Thread Mark Brown
Hi all, Today's linux-next merge of the net-next tree got a conflict in: kernel/bpf/sockmap.c between commit: bfa640757e9378c ("bpf: rename sk_actions to align with bpf infrastructure") from Linus' tree and commit: 6aaae2b6c4330a4 ("bpf: rename bpf_compute_data_end into

[PATCH v3 2/2] usb: dwc2: host: Convert hcd_queue to timer_setup

2017-10-30 Thread Douglas Anderson
Convert the timers in hcd_queue to use the new timer_setup() call introduced in commit 686fef928bba ("timer: Prepare to change timer callback argument type"). Suggested-by: Stefan Wahren Signed-off-by: Douglas Anderson Cc: Kees Cook

[PATCH v3 2/2] usb: dwc2: host: Convert hcd_queue to timer_setup

2017-10-30 Thread Douglas Anderson
Convert the timers in hcd_queue to use the new timer_setup() call introduced in commit 686fef928bba ("timer: Prepare to change timer callback argument type"). Suggested-by: Stefan Wahren Signed-off-by: Douglas Anderson Cc: Kees Cook --- Changes in v3: - Convert hcd_queue to timer_setup new

Re: KASAN: use-after-free Write in detach_if_pending

2017-10-30 Thread Dmitry Vyukov
On Mon, Oct 30, 2017 at 5:36 PM, Eric Dumazet wrote: > On Mon, 2017-10-30 at 16:48 +0100, Dmitry Vyukov wrote: >> > >> > net-next tree : >> > >> > $ git log --oneline e7989f973ae1b90ec7c0b671c81.. -- drivers/net/tun.c >> > f8ddadc4db6c7b7029b6d0e0d9af24f74ad27ca2 Merge >>

Re: KASAN: use-after-free Write in detach_if_pending

2017-10-30 Thread Dmitry Vyukov
On Mon, Oct 30, 2017 at 5:36 PM, Eric Dumazet wrote: > On Mon, 2017-10-30 at 16:48 +0100, Dmitry Vyukov wrote: >> > >> > net-next tree : >> > >> > $ git log --oneline e7989f973ae1b90ec7c0b671c81.. -- drivers/net/tun.c >> > f8ddadc4db6c7b7029b6d0e0d9af24f74ad27ca2 Merge >> >

linux-next: manual merge of the net-next tree with Linus' tree

2017-10-30 Thread Mark Brown
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/netronome/nfp/flower/action.c between commit: d309ae5c6a0064 ("nfp: refuse offloading filters that redirects to upper devices") from Linus' tree and commit: 62d3f60b4d065c ("nfp: use struct

linux-next: manual merge of the net-next tree with Linus' tree

2017-10-30 Thread Mark Brown
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/netronome/nfp/flower/action.c between commit: d309ae5c6a0064 ("nfp: refuse offloading filters that redirects to upper devices") from Linus' tree and commit: 62d3f60b4d065c ("nfp: use struct

Re: [PATCH] ARM: add a private asm/unaligned.h

2017-10-30 Thread Arnd Bergmann
On Mon, Oct 30, 2017 at 4:50 PM, Russell King - ARM Linux wrote: > On Mon, Oct 30, 2017 at 04:09:43PM +0100, Arnd Bergmann wrote: >> On Fri, Oct 27, 2017 at 5:27 PM, Russell King - ARM Linux >> wrote: >> >> > >> > There's three things wrong, all of

Re: [PATCH] ARM: add a private asm/unaligned.h

2017-10-30 Thread Arnd Bergmann
On Mon, Oct 30, 2017 at 4:50 PM, Russell King - ARM Linux wrote: > On Mon, Oct 30, 2017 at 04:09:43PM +0100, Arnd Bergmann wrote: >> On Fri, Oct 27, 2017 at 5:27 PM, Russell King - ARM Linux >> wrote: >> >> > >> > There's three things wrong, all of which I have patches to address: >> > >> > 1.

[PATCH] Input: egalax-ts: Remove leading zero from 'egalax-ts@04' notation

2017-10-30 Thread Marco Franchi
Improve the binding example by removing the leading 0 from 'egalax-ts@04' notation, which fix the following build warning: Warning (unit_address_format): Node /egalax_ts@04 unit name should not have leading 0s Signed-off-by: Marco Franchi ---

[PATCH] Input: egalax-ts: Remove leading zero from 'egalax-ts@04' notation

2017-10-30 Thread Marco Franchi
Improve the binding example by removing the leading 0 from 'egalax-ts@04' notation, which fix the following build warning: Warning (unit_address_format): Node /egalax_ts@04 unit name should not have leading 0s Signed-off-by: Marco Franchi ---

Re: [PATCH 03/27] Enforce module signatures if the kernel is locked down

2017-10-30 Thread David Howells
Mimi Zohar wrote: > This kernel_is_locked_down() check is being called for both the > original and new module_load syscalls.  We need to be able > differentiate them.  This is fine for the original syscall, but for > the new syscall we would need an additional IMA check

Re: [PATCH 03/27] Enforce module signatures if the kernel is locked down

2017-10-30 Thread David Howells
Mimi Zohar wrote: > This kernel_is_locked_down() check is being called for both the > original and new module_load syscalls.  We need to be able > differentiate them.  This is fine for the original syscall, but for > the new syscall we would need an additional IMA check - >

Re: [PATCH] ARM: add a private asm/unaligned.h

2017-10-30 Thread Russell King - ARM Linux
On Mon, Oct 30, 2017 at 03:35:38PM +, Ard Biesheuvel wrote: > Well, that is disappointing. This means the ASSERT() does not work > reliably, and we're back to using a bunch of shell scripts to check > whether _edata appears at the end of the image. That didn't work too well here. While it

Re: [PATCH] ARM: add a private asm/unaligned.h

2017-10-30 Thread Russell King - ARM Linux
On Mon, Oct 30, 2017 at 03:35:38PM +, Ard Biesheuvel wrote: > Well, that is disappointing. This means the ASSERT() does not work > reliably, and we're back to using a bunch of shell scripts to check > whether _edata appears at the end of the image. That didn't work too well here. While it

<    2   3   4   5   6   7   8   9   10   11   >