Re: [PATCH v3 0/4] Fixes for omapdrm on OpenPandora and GTA04

2017-11-30 Thread Tony Lindgren
* Tomi Valkeinen [171130 10:56]: > On 28/11/17 17:48, H. Nikolaus Schaller wrote: > > Changes V3: > > * stay compatible with old DTB files which still use "toppoly" (suggested > > by Tomi Valkeinen) > > * replaced MODULE_ALIAS entries by MODULE_DEVICE_TABLE (suggested by Andrew > > F. Davis) > >

Re: [PATCH] of: overlay: fix memory leak of ovcs on error exit path

2017-11-30 Thread Rob Herring
On Thu, Nov 30, 2017 at 9:01 AM, Frank Rowand wrote: > On 11/30/17 08:37, Frank Rowand wrote: >> Hi Colin, Rob, >> >> On 11/30/17 07:18, Colin Ian King wrote: >>> On 30/11/17 12:14, Frank Rowand wrote: On 11/29/17 14:17, Colin King wrote: > From: Colin Ian King > > Currently if t

Re: [linux-sunxi] Cedrus driver

2017-11-30 Thread Maxime Ripard
Hi Thomas, On Wed, Nov 29, 2017 at 04:36:01PM +0100, Thomas van Kleef wrote: > > C) I'm not sure what you tried to do with the application of the > >request API patches (such as e1ca861c168f) but we want to have the > >whole commits in there, and not a patch adding all of them. This > >

Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string

2017-11-30 Thread Tony Lindgren
* H. Nikolaus Schaller [171128 18:35]: > Hi, > > > Am 28.11.2017 um 17:18 schrieb Tony Lindgren : > > > > * H. Nikolaus Schaller [171128 16:17]: > >> Hi Tony, > >> > >>> Am 28.11.2017 um 17:04 schrieb Tony Lindgren : > >>> > >>> * H. Nikolaus Schaller [171128 15:52]: > We can remove the

Re: [PATCH RT] crypto: limit more FPU-enabled sections

2017-11-30 Thread Sebastian Andrzej Siewior
On 2017-11-30 10:19:43 [-0500], Steven Rostedt wrote: … > It really shows that these functions are only used by RT. IMO it's bad > taste to have functions with the entire body encapsulated in #ifdefs. > > And the same goes for the other functions in this patch. No problem, I will change that. >

Re: Unlock-lock questions and the Linux Kernel Memory Model

2017-11-30 Thread Alan Stern
On Wed, 29 Nov 2017, Daniel Lustig wrote: > On 11/29/2017 12:42 PM, Paul E. McKenney wrote: > > On Wed, Nov 29, 2017 at 02:53:06PM -0500, Alan Stern wrote: > >> On Wed, 29 Nov 2017, Peter Zijlstra wrote: > >> > >>> On Wed, Nov 29, 2017 at 11:04:53AM -0800, Daniel Lustig wrote: > >>> > While w

Re: [PATCH] vfio/iommu_type1: report the IOMMU aperture info

2017-11-30 Thread Jean-Philippe Brucker
On 30/11/17 14:49, Pierre Morel wrote: [...] > Shouldn't the 52bit problem be reported by the iommu geometry? Yes, and most IOMMUs seem to set force_aperture. My comment was only about default values to adopt in case a new IOMMU driver doesn't set force_aperture to true. Thanks, Jean

Re: [PATCH RT] crypto: limit more FPU-enabled sections

2017-11-30 Thread Steven Rostedt
On Thu, 30 Nov 2017 15:22:17 +0100 Sebastian Andrzej Siewior wrote: > diff --git a/arch/x86/crypto/camellia_aesni_avx2_glue.c > b/arch/x86/crypto/camellia_aesni_avx2_glue.c > index 60907c139c4e..d7502c023475 100644 > --- a/arch/x86/crypto/camellia_aesni_avx2_glue.c > +++ b/arch/x86/crypto/camell

Re: [kernel-hardening] Re: [PATCH v3 2/2] Protected O_CREAT open in sticky directories

2017-11-30 Thread Ian Campbell
On Thu, 2017-11-30 at 15:39 +0100, Salvatore Mesoraca wrote: > 2017-11-27 1:26 GMT+01:00 Solar Designer : > > On Fri, Nov 24, 2017 at 12:43:47PM +0100, Salvatore Mesoraca wrote: > > > 2017-11-24 11:53 GMT+01:00 David Laight > > > : > > > > From: Alan Cox > > > > > Sent: 22 November 2017 16:52 > >

Re: [PATCH v7 2/4] KVM: X86: Add Paravirt TLB Shootdown

2017-11-30 Thread Radim Krčmář
2017-11-29 22:01-0800, Wanpeng Li: > From: Wanpeng Li > --- > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c > @@ -498,6 +498,34 @@ static void __init kvm_apf_trap_init(void) > update_intr_gate(X86_TRAP_PF, async_page_fault); > } > > +static DEFINE_PER_CPU(cpumask_var_t, __pv_

Re: [PATCH v6 2/4] KVM: X86: Add Paravirt TLB Shootdown

2017-11-30 Thread Radim Krčmář
2017-11-30 14:24+0800, Wanpeng Li: > 2017-11-30 0:21 GMT+08:00 Radim Krčmář : > > 2017-11-27 20:05-0800, Wanpeng Li: > >> From: Wanpeng Li > >> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c > >> @@ -498,6 +498,37 @@ static void __init kvm_apf_trap_init(void) > >> update_intr_gat

[PATCH v2] nvme-fc: don't require user to enter host_traddr

2017-11-30 Thread Johannes Thumshirn
One major usability difference between NVMf RDMA and FC is resolving the default host transport address in RDMA. This is perfectly doable in FC as well, as we already have all possible lport <-> rport combinations pre-populated so we can pick the first lport that has a connection to our desired rpo

Re: [Pv-drivers] [PATCH net-next] vmxnet3: increase default rx ring sizes

2017-11-30 Thread David Miller
From: Boon Ang Date: Wed, 29 Nov 2017 16:25:16 + > I hope the above explains our motivation. Let us know if you have > more questions. Please add these descriptive details to your commit message and resubmit.

Re: [PATCH] vfio/iommu_type1: report the IOMMU aperture info

2017-11-30 Thread Pierre Morel
On 30/11/2017 15:08, Alex Williamson wrote: On Thu, 30 Nov 2017 12:34:38 +0100 Pierre Morel wrote: When userland VFIO defines a new IOMMU for a guest it may want to specify to the guest the physical limits of the underlying host IOMMU to avoid access to forbidden memory ranges. Currently, the

Re: [PATCH] nvme-fc: don't require user to enter host_traddr

2017-11-30 Thread Hannes Reinecke
On 11/30/2017 03:56 PM, Johannes Thumshirn wrote: > One major usability difference between NVMf RDMA and FC is resolving > the default host transport address in RDMA. This is perfectly doable > in FC as well, as we already have all possible lport <-> rport > combinations pre-populated so we can pic

Re: [PATCH net-next 0/3] rxrpc: Fixes

2017-11-30 Thread David Miller
From: David Howells Date: Wed, 29 Nov 2017 15:33:43 + > Here are three patches for AF_RXRPC. One removes some whitespace, one > fixes terminal ACK generation and the third makes a couple of places > actually use the timeout value just determined rather than ignoring it. > > The patches can

Re: [PATCH/trivial] ledtrig-activity: Grammar s/a immediate/an immediate/

2017-11-30 Thread Pavel Machek
On Thu 2017-11-30 14:36:41, Geert Uytterhoeven wrote: > Fixes: 7df4f9a9f0667ee6 ("leds: ledtrig-activity: Add a system activity LED > trigger") > Signed-off-by: Geert Uytterhoeven ACK. Is it time we create scripts to pull all the english texts from kernel, so that we can run them through spell

Re: [PATCH] of: overlay: fix memory leak of ovcs on error exit path

2017-11-30 Thread Frank Rowand
On 11/30/17 08:37, Frank Rowand wrote: > Hi Colin, Rob, > > On 11/30/17 07:18, Colin Ian King wrote: >> On 30/11/17 12:14, Frank Rowand wrote: >>> On 11/29/17 14:17, Colin King wrote: From: Colin Ian King Currently if the call to of_resolve_phandles fails then then ovcs is not

Re: [PATCH] usbip: Fix USB device hang due to wrong enabling of scatter-gather

2017-11-30 Thread Shuah Khan
On 11/29/2017 07:22 PM, Yuyang Du wrote: > The previous USB3 SuperSpeed enabling patches mistakenly enabled > URB scatter-gather chaining, which is actually not supported by > the VHCI HCD. This patch fixes that. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197867 > Fixes: 03cd00d538a

[PATCH] x86/build: Don't verify mtools configuration file for isoimage

2017-11-30 Thread changbin . du
From: Changbin Du If mtools.conf is not generated before, 'make isoimage' could complain: Kernel: arch/x86/boot/bzImage is ready (#597) GENIMAGE arch/x86/boot/image.iso *** Missing file: arch/x86/boot/mtools.conf arch/x86/boot/Makefile:144: recipe for target 'isoimage' failed mtools.conf is

Re: [PATCH v2 0/5] Memory hotplug support for arm64 - complete patchset v2

2017-11-30 Thread Michal Hocko
On Thu 23-11-17 17:33:31, Andrea Reale wrote: > On Thu 23 Nov 2017, 17:02, Michal Hocko wrote: > > Hi Michal, > > > I will try to have a look but I do not expect to understand any of arm64 > > specific changes so I will focus on the generic code but it would help a > > _lot_ if the cover letter p

Re: [PATCH] usbip: fix usbip attach to find a port that matches the requested speed

2017-11-30 Thread Shuah Khan
On 11/30/2017 01:20 AM, Greg KH wrote: > On Wed, Nov 29, 2017 at 03:24:22PM -0700, Shuah Khan wrote: >> usbip attach fails to find a free port when the device on the first port >> is a USB_SPEED_SUPER device and non-super speed device is being attached. >> It keeps checking the first port and retur

Re: [PATCH 3/3] trace-cmd: Making stat to report when the stack tracer is ON

2017-11-30 Thread Steven Rostedt
On Thu, 30 Nov 2017 13:26:55 +0200 Vladislav Valtchev wrote: > I proposed die() because, by looking at the original code of read_proc(): > > static char read_proc(void) > { > char buf[1]; > int fd; > int n; > > fd = open(PROC_FILE, O_RDONLY); > if (fd < 0) >

[PATCH] nvme-fc: don't require user to enter host_traddr

2017-11-30 Thread Johannes Thumshirn
One major usability difference between NVMf RDMA and FC is resolving the default host transport address in RDMA. This is perfectly doable in FC as well, as we already have all possible lport <-> rport combinations pre-populated so we can pick the first lport that has a connection to our desired rpo

[PATCH v5 01/27] linkage: new macros for assembler symbols

2017-11-30 Thread Jiri Slaby
Introduce new C macros for annotations of functions and data in assembly. There is a long-standing mess in macros like ENTRY, END, ENDPROC and similar. They are used in different manners and sometimes incorrectly. So introduce macros with clear use to annotate assembly as follows: a) Support macr

[PATCH v5 03/27] x86: assembly, annotate relocate_kernel

2017-11-30 Thread Jiri Slaby
There are functions in relocate_kernel which are not annotated. This will not allow for automatic DWARF annotations. So annotate all the functions now. Note that these are not C-like functions, so we do not use FUNC, but CODE. Also they are not aligned, so we use NOALIGN versions: - SYM_CODE_START

[PATCH v5 02/27] x86: assembly, use SYM_DATA for data

2017-11-30 Thread Jiri Slaby
We make proper use of SYM_DATA on global data instead of marking them as ENTRY. ENTRY is intended for functions and shall be paired with ENDPROC. ENTRY also aligns symbols which creates unnecessary holes here between data. ENTRY from saved_eip in wakeup_32 and many saved_* in wakeup_64 is simply d

Re: [PATCH, RESEND 1/2] dvb-frontends: fix i2c access helpers for KASAN

2017-11-30 Thread Mauro Carvalho Chehab
Em Thu, 30 Nov 2017 15:06:15 +0100 Arnd Bergmann escreveu: > On Thu, Nov 30, 2017 at 1:49 PM, Mauro Carvalho Chehab > wrote: > >> Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715 > >> Signed-off-by: Arnd Bergmann > >> --- > >> I'm undecided here whether there should be a comment pointin

[PATCH v5 05/27] x86: assembly, annotate local pseudo-functions

2017-11-30 Thread Jiri Slaby
Use the newly added SYM_CODE_START_LOCAL* to annotate starts of all pseudo-functions (those ending END) which do not have ".globl" annotation. This is needed to balance END for tools that are about to generate debuginfo. Note that we switch from END to SYM_CODE_END so that everybody can see the pai

[PATCH v5 07/27] x86: boot, annotate local functions

2017-11-30 Thread Jiri Slaby
relocated and no_longmode are self-standing local functions, annotate them as such. Signed-off-by: Jiri Slaby Cc: "H. Peter Anvin" Cc: Thomas Gleixner Cc: Ingo Molnar Cc: x...@kernel.org --- arch/x86/boot/compressed/head_32.S | 3 ++- arch/x86/boot/compressed/head_64.S | 6 -- 2 files cha

[PATCH v5 06/27] x86: crypto, annotate local functions

2017-11-30 Thread Jiri Slaby
Use the newly added SYM_FUNC_START_LOCAL to annotate starts of all functions which do not have ".globl" annotation, but their ends are annotated by ENDPROC. This is needed to balance ENDPROC for tools that are about to generate debuginfo. To be symmetric, we also convert their ENDPROCs to the new

[PATCH v5 00/27] New macros for assembler symbols

2017-11-30 Thread Jiri Slaby
This series introduces new macros for assembly as was discussed [1]. The macros are introduced in the first patch of the series. The rest of patches start using these new macros in x86, converting *all* uses of the old macros to the new ones throughout the last patch. With every last user of some o

[PATCH v5 08/27] x86: assembly, annotate aliases

2017-11-30 Thread Jiri Slaby
_key_expansion_128 is an alias to _key_expansion_256a, __memcpy to memcpy, xen_syscall32_target to xen_sysenter_target, and so on. Annotate them all using the new SYM_FUNC_START_ALIAS, SYM_FUNC_START_LOCAL_ALIAS, and SYM_FUNC_END_ALIAS. This will make the tools generating the debuginfo happy. Sign

[PATCH v5 10/27] x86: head, annotate data appropriatelly

2017-11-30 Thread Jiri Slaby
Use the new SYM_DATA, SYM_DATA_START, and SYM_DATA_END in both 32 and 64 bit heads. In the 64-bit version, define also SYM_DATA_START_PAGE_ALIGNED locally using the new SYM_START. It is used in the code instead of NEXT_PAGE() which was defined in this file and has been using the obsolete macro GLO

[PATCH v5 09/27] x86: entry, annotate interrupt symbols properly

2017-11-30 Thread Jiri Slaby
* annotate functions properly by SYM_CODE_START, SYM_CODE_START_LOCAL* and SYM_CODE_END -- these are not C-like functions, so we have to annotate them using CODE. * use SYM_CODE_INNER_LABEL* for labels being in the middle of other functions [v4] alignments preserved Signed-off-by: Jiri Slab

[PATCH v5 12/27] x86: um, annotate data appropriatelly

2017-11-30 Thread Jiri Slaby
Use the new SYM_DATA_START and SYM_DATA_END_LABEL macros for vdso_start. We get: 2376 OBJECT GLOBAL DEFAULT4 vdso_start 0948 0 OBJECT GLOBAL DEFAULT4 vdso_end Signed-off-by: Jiri Slaby Cc: Jeff Dike Cc: Richard Weinberger Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Pe

Re: [Xen-devel] [PATCH V2] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-30 Thread Jan Beulich
>>> On 30.11.17 at 15:15, wrote: > On 11/30/2017 2:27 AM, Jan Beulich wrote: > On 29.11.17 at 18:38, wrote: > In the case of bus or slot reset, our goal is to reset connected PCIe > fabric/card/endpoint. > The connected card/endpoint can be multi-function device. So, same > wa

Re: [kernel-hardening] Re: [PATCH v5 next 5/5] net: modules: use request_module_cap() to load 'netdev-%s' modules

2017-11-30 Thread Djalal Harouni
On Thu, Nov 30, 2017 at 3:16 PM, Theodore Ts'o wrote: > On Thu, Nov 30, 2017 at 09:50:27AM +0100, Djalal Harouni wrote: >> In embedded systems we can't maintain a SELinux policy, distro man >> power hardly manage. We have abstracted seccomp etc, but the kernel >> inherited the difficult multiplex

Re: [PATCH v2 3/5] mm: memory_hotplug: memblock to track partially removed vmemmap mem

2017-11-30 Thread Michal Hocko
On Thu 23-11-17 11:14:38, Andrea Reale wrote: > When hot-removing memory we need to free vmemmap memory. > However, depending on the memory is being removed, it might > not be always possible to free a full vmemmap page / huge-page > because part of it might still be used. > > Commit ae9aae9eda2d

[PATCH v5 11/27] x86: boot, annotate data appropriatelly

2017-11-30 Thread Jiri Slaby
Use the new SYM_DATA, SYM_DATA_START, and SYM_DATA_END* macros for data. Now, the data in the object file look sane: Value Size TypeBind Vis Ndx Name 10 OBJECT GLOBAL DEFAULT3 efi32_boot_gdt 000a10 OBJECT LOCAL DEFAULT3 save_gdt 0014 8 OBJECT LOCAL D

[PATCH v5 24/27] x86_32: assembly, add ENDs to some functions and relabel with SYM_CODE_*

2017-11-30 Thread Jiri Slaby
All these are functions which are invoked from elsewhere, but they are not typical C functions. So we annotate them (as global) using the new SYM_CODE_START. All these were not balanced with any END, so mark their ends by SYM_CODE_END, appropriatelly. Signed-off-by: Jiri Slaby Reviewed-by: Boris

[PATCH v5 22/27] x86_64: assembly, change all ENTRY+END to SYM_CODE_*

2017-11-30 Thread Jiri Slaby
Here, we change all code which is not marked as functions. In other words, this code has been using END, not ENDPROC. So switch all of this to appropriate new markings SYM_CODE_START and SYM_CODE_END. Signed-off-by: Jiri Slaby Reviewed-by: Boris Ostrovsky [xen bits] Cc: Thomas Gleixner Cc: Ingo

[PATCH v5 21/27] x86_64: assembly, add ENDs to some functions and relabel with SYM_CODE_*

2017-11-30 Thread Jiri Slaby
All these are functions which are invoked from elsewhere, but they are not typical C functions. So we annotate them (as global) using the new SYM_CODE_START. All these were not balanced with any END, so mark their ends by SYM_CODE_END, appropriatelly. Signed-off-by: Jiri Slaby Reviewed-by: Boris

[PATCH v5 19/27] x86: assembly, make some functions local

2017-11-30 Thread Jiri Slaby
There is a couple of assembly functions, which are invoked only locally in the file they are defined. In C, we mark them "static". In assembly, annotate them using SYM_{FUNC,CODE}_START_LOCAL (and switch their ENDPROC to SYM_{FUNC,CODE}_END too). Whether FUNC or CODE depends on ENDPROC/END for a pa

[PATCH v5 20/27] x86: ftrace, mark function_hook as function

2017-11-30 Thread Jiri Slaby
Relabel function_hook to be marked really as a function. It is called from C and has the same expectations towards the stack etc. Signed-off-by: Jiri Slaby Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: x...@kernel.org --- arch/x86/kernel/ftrace_32.S | 4 ++-- arch/x86/kernel/ft

[PATCH v5 16/27] x86: assembly, use SYM_CODE_INNER_LABEL instead of GLOBAL

2017-11-30 Thread Jiri Slaby
GLOBAL had several meanings and is going away. In this patch, convert all the inner function labels marked with GLOBAL to use SYM_CODE_INNER_LABEL instead. Note that retint_user needs not be global, perhaps since commit 2ec67971facc ("x86/entry/64/compat: Remove most of the fast system call machin

Re: [PATCH] vfio/iommu_type1: report the IOMMU aperture info

2017-11-30 Thread Pierre Morel
On 30/11/2017 15:16, Pierre Morel wrote: On 30/11/2017 13:57, Jean-Philippe Brucker wrote: Hello, On 30/11/17 11:34, Pierre Morel wrote: [...] +/** + * vfio_get_aperture - report minimal aperture of a vfio_iommu + * @iommu: the current vfio_iommu + * @start: a pointer to the aperture start + *

Re: [PATCH v2 4/5] mm: memory_hotplug: Add memory hotremove probe device

2017-11-30 Thread Michal Hocko
On Thu 23-11-17 11:14:52, Andrea Reale wrote: > Adding a "remove" sysfs handle that can be used to trigger > memory hotremove manually, exactly simmetrically with > what happens with the "probe" device for hot-add. > > This is usueful for architecture that do not rely on > ACPI for memory hot-remo

[PATCH v5 14/27] x86: purgatory, start using annotations

2017-11-30 Thread Jiri Slaby
purgatory used no annotations. So include linux/linkage.h and annotate everything: * code by SYM_CODE_* * data by SYM_DATA_* Signed-off-by: Jiri Slaby Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: x...@kernel.org --- arch/x86/purgatory/entry64.S | 21 -

[PATCH v5 15/27] x86: assembly, do not annotate functions by GLOBAL

2017-11-30 Thread Jiri Slaby
GLOBAL is meant for global symbols, but not functions. Use the new macros SYM_FUNC_START* and SYM_CODE_START* (depending on the type of the function) which are dedicated for global functions. And since they both require a closing by SYM_*_END, we do this here too. startup_64, which does not use GL

[PATCH v5 13/27] x86: xen-pvh, annotate data appropriatelly

2017-11-30 Thread Jiri Slaby
Use the new SYM_DATA_START_LOCAL, and SYM_DATA_END* macros: 8 OBJECT LOCAL DEFAULT6 gdt 000832 OBJECT LOCAL DEFAULT6 gdt_start 0028 0 OBJECT LOCAL DEFAULT6 gdt_end 0028 256 OBJECT LOCAL DEFAULT6 early_stack 0128 0 OBJECT LOCAL DEFAULT6

[PATCH v5 26/27] x86_32: assembly, change all ENTRY+ENDPROC to SYM_FUNC_*

2017-11-30 Thread Jiri Slaby
These are all functions which are invoked from elsewhere, so we annotate them as global using the new SYM_FUNC_START (and their ENDPROC's by SYM_FUNC_END.) Now, we can finally force ENTRY/ENDPROC to be undefined on X86. Signed-off-by: Jiri Slaby Cc: "H. Peter Anvin" Cc: Thomas Gleixner Cc: Ing

[PATCH v5 27/27] x86: assembly, replace WEAK uses

2017-11-30 Thread Jiri Slaby
Use the new SYM_CODE_INNER_LABEL for WEAK entries in the middle of x86 assembly functions. And make sure WEAK is not defined for x86 anymore as these were the last users. Signed-off-by: Jiri Slaby Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: x...@kernel.org --- arch/x86/kerne

[PATCH v5 23/27] x86_64: assembly, change all ENTRY+ENDPROC to SYM_FUNC_*

2017-11-30 Thread Jiri Slaby
These are all functions which are invoked from elsewhere, so we annotate them as global using the new SYM_FUNC_START. And their ENDPROC's by SYM_FUNC_END. And make sure ENTRY/ENDPROC is not defined on X86_64, given these were the last users. Signed-off-by: Jiri Slaby Reviewed-by: Rafael J. Wysoc

[PATCH v5 25/27] x86_32: assembly, change all ENTRY+END to SYM_CODE_*

2017-11-30 Thread Jiri Slaby
Here, we change all code which is not marked as functions. In other words, this code has been using END, not ENDPROC. So switch all of this to appropriate new markings SYM_CODE_START and SYM_CODE_END. And since we removed the last user of END on X86, make sure, that END is not defined there. Sign

[PATCH v5 18/27] x86: assembly, remove GLOBAL macro

2017-11-30 Thread Jiri Slaby
Convert the remaining 32bit users and remove GLOBAL macro finally. In particular, this means to use SYM_ENTRY for the singlestepping hack region. Signed-off-by: Jiri Slaby Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: x...@kernel.org --- arch/x86/entry/entry_32.S | 4 ++--

[PATCH v5 04/27] x86: entry, annotate THUNKs

2017-11-30 Thread Jiri Slaby
Place SYM_CODE_START_NOALIGN and SYM_CODE_END around the THUNK macro body, given it generates: 1) non-C-like functions, and 2) was not marked as aligned. The common tail .L_restore is put inside SYM_CODE_START_LOCAL_NOALIGN and SYM_CODE_END too. The result: Value Size TypeBind Vis Nd

[PATCH v5 17/27] x86: realmode, use SYM_DATA_* instead of GLOBAL

2017-11-30 Thread Jiri Slaby
GLOBAL had several meanings and is going away. In this patch, convert all the data marked using GLOBAL to use SYM_DATA_START or SYM_DATA instead. Notes: * SYM_DATA_END_LABEL is used to generate tr_gdt_end too. * wakeup_idt is marked as LOCAL now as it is used only locally. Signed-off-by: Jiri Sla

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

2017-11-30 Thread David Miller
From: Corentin Labbe Date: Tue, 28 Nov 2017 17:48:22 +0100 > The driver expect "allwinner,leds-active-low" to be in PHY node, but > the binding doc expect it to be in MAC node. > > Since all board DT use it also in MAC node, the driver need to search > allwinner,leds-active-low in MAC node. > >

Re: [ 0.003333] BUG: KASAN: use-after-scope in console_unlock+0x605/0xcc0

2017-11-30 Thread Dmitry Vyukov
On Thu, Nov 30, 2017 at 3:30 PM, Fengguang Wu wrote: > On Thu, Nov 30, 2017 at 05:29:09PM +0900, Sergey Senozhatsky wrote: >> >> On (11/30/17 09:16), Dmitry Vyukov wrote: >> [..] >>> >>> > to be honest, this backtrace hardly makes any sense to me. >>> > >>> > vprintk_emit() >>> > reserve_standard

Re: [PATCH 6/7] smp/hotplug: Differentiate the AP-work lockdep class between up and down

2017-11-30 Thread Lai Jiangshan
On Thu, Sep 21, 2017 at 1:00 AM, Peter Zijlstra wrote: > With lockdep-crossrelease we get deadlock reports that span cpu-up and > cpu-down chains. Such deadlocks cannot possibly happen because cpu-up > and cpu-down are globally serialized. > > CPU0 CPU1CPU2 >

Re: [GIT PULL] Btrfs fixes for 4.15-rc2

2017-11-30 Thread David Sterba
On Wed, Nov 29, 2017 at 02:31:24PM -0800, Linus Torvalds wrote: > On Wed, Nov 29, 2017 at 11:28 AM, David Sterba wrote: > > > > With signed tag: for-4.15-rc2-tag > > > > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.15-rc2 > > Oh, please actually ask me to pull the signed

Re: [PATCH v2] gpio: davinci: Assign first bank regs for unbanked case

2017-11-30 Thread Linus Walleij
On Fri, Nov 10, 2017 at 12:13 PM, Keerthy wrote: > As per the re-design assign the first bank regs for unbanked > irq case. This was missed out in the original patch. > > Signed-off-by: Keerthy > Fixes: b5cf3fd827d2e1 ("gpio: davinci: Redesign driver to accommodate ngpios > in one gpio chip") >

Re: [alsa-devel] [RFC PATCH v2 1/7] ASoC: Intel: Fix Kconfig with top-level selector

2017-11-30 Thread Pierre-Louis Bossart
On 11/30/17 6:24 AM, Vinod Koul wrote: On Wed, Nov 29, 2017 at 08:52:58AM -0600, Pierre-Louis Bossart wrote: On 11/29/17 4:27 AM, Vinod Koul wrote: On Tue, Nov 28, 2017 at 07:45:45PM -0600, Pierre-Louis Bossart wrote: I am not sure about top level being default to Y... It's standard procedur

Re: [PATCH V1] drivers:mtd:spi-nor:checkup FSR error bits

2017-11-30 Thread Bean Huo (beanhuo)
Hi, Cyrille Finally, I get your comments, thanks. >Hi Bean, > >Le 11/11/2017 à 21:49, Bean Huo (beanhuo) a écrit : >> For the Micron SPI NOR, when the erase/program operation fails, >> especially, > >To be verified but I think you'd rather remove "the" words in this case: > >"For Micron SPI NOR m

Re: [RFC 0/2] of: Add whitelist

2017-11-30 Thread Rob Herring
On Wed, Nov 29, 2017 at 4:47 PM, Frank Rowand wrote: > On 11/29/17 04:20, Frank Rowand wrote: >> On 11/27/17 15:58, Alan Tull wrote: >>> Here's a proposal for a whitelist to lock down the dynamic device tree. >>> >>> For an overlay to be accepted, all of its targets are required to be >>> on a tar

Re: [PATCH v18 05/10] xbitmap: add more operations

2017-11-30 Thread Matthew Wilcox
On Thu, Nov 30, 2017 at 10:35:03PM +0900, Tetsuo Handa wrote: > According to xb_set_bit(), it seems to me that we are trying to avoid memory > allocation > for "struct ida_bitmap" when all set bits within a 1024-bits bitmap reside in > the first > 61 bits. > > But does such saving help? Is there

Re: [PATCH v3 2/2] Protected O_CREAT open in sticky directories

2017-11-30 Thread Salvatore Mesoraca
2017-11-27 1:26 GMT+01:00 Solar Designer : > On Fri, Nov 24, 2017 at 12:43:47PM +0100, Salvatore Mesoraca wrote: > > 2017-11-24 11:53 GMT+01:00 David Laight : > > > From: Alan Cox > > >> Sent: 22 November 2017 16:52 > > >> > > >> On Wed, 22 Nov 2017 09:01:46 +0100 Salvatore Mesoraca > > >> wrote:

Re: [PATCH] gpio: uniphier: fix mismatch between license text and MODULE_LICENSE

2017-11-30 Thread Linus Walleij
On Thu, Nov 23, 2017 at 11:01 AM, Masahiro Yamada wrote: > The comment block of this file indicates GPL-2.0 "only", while the > MODULE_LICENSE is GPL-2.0 "or later", as include/linux/module.h > describes as follows: > > "GPL" [GNU Public License v2 or later] > "GPL v

[PATCH 1/1] futex: futex_wake_op, fix sign_extend32 sign bits

2017-11-30 Thread Jiri Slaby
sign_extend32 counts the sign bit parameter from 0, not from 1. So we have to use "11" for 12th bit, not "12". This mistake means we have not allowed negative op and cmp args since commit 30d6e0a4190d ("futex: Remove duplicated code and fix undefined behaviour") till now. Fixes: 30d6e0a4190d ("fu

Re: [PATCH] list_lru: Prefetch neighboring list entries before acquiring lock

2017-11-30 Thread Matthew Wilcox
On Wed, Nov 29, 2017 at 09:17:34AM -0500, Waiman Long wrote: > The list_lru_del() function removes the given item from the LRU list. > The operation looks simple, but it involves writing into the cachelines > of the two neighboring list entries in order to get the deletion done. > That can take a w

Re: [PATCH] gpio: 74x164: Fix crash during .remove()

2017-11-30 Thread Linus Walleij
On Tue, Nov 21, 2017 at 3:18 PM, Geert Uytterhoeven wrote: > Commit 7ebc194d0fd4bb0f ("gpio: 74x164: Introduce 'enable-gpios' > property") added a new member gpiod_oe to the end of the struct > gen_74x164_chip, after the zero-length buffer array. > > However, this buffer is a flexible array, allo

Re: [PATCH] atm: lanai: use setup_timer instead of init_timer

2017-11-30 Thread Colin Ian King
On 30/11/17 14:23, David Miller wrote: > From: Colin King > Date: Fri, 24 Nov 2017 13:27:12 + > >> From: Colin Ian King >> >> Use setup_timer function instead of initializing timer with the >> function and data fields. >> >> Signed-off-by: Colin Ian King > > setup_timer() == -ENOEXIST. > -

Re: [PATCH RT] crypto: limit more FPU-enabled sections

2017-11-30 Thread Sebastian Andrzej Siewior
On 2017-11-30 15:22:17 [+0100], To linux-rt-us...@vger.kernel.org wrote: > Probably we should meassure the performance those ciphers in pure SW > mode and with this optimisations to see if it makes sense to keep them > for RT. This is only x86. We have the same fun with kernel_neon_begin() on the

Re: [ 0.003333] BUG: KASAN: use-after-scope in console_unlock+0x605/0xcc0

2017-11-30 Thread Fengguang Wu
On Thu, Nov 30, 2017 at 05:29:09PM +0900, Sergey Senozhatsky wrote: On (11/30/17 09:16), Dmitry Vyukov wrote: [..] > to be honest, this backtrace hardly makes any sense to me. > > vprintk_emit() > reserve_standard_io_resources() > __flush_tlb_all() >vprintk_emit() > __down_trylock_con

Re: [PATCH V4] mmc:host:sdhci-pci:Addition of Arasan PCI Controller with integrated phy.

2017-11-30 Thread Adrian Hunter
On 29/11/17 01:03, Atul Garg wrote: > The Arasan controller is based on a FPGA platform and has integrated phy > with specific registers used during initialization and > management of different modes. The phy and the controller are integrated > and registers are very specific to Arasan. > > Arasan

Re: [PATCH] rtc: add mxc driver for i.MX53

2017-11-30 Thread Russell King - ARM Linux
On Thu, Nov 30, 2017 at 01:36:22PM +, Patrick Brünn wrote: > >From: Philippe Ombredanne [mailto:pombreda...@nexb.com] > >Sent: Donnerstag, 30. November 2017 09:18 > >> > >>> +/* > >>> + * Copyright (C) 2004-2011 Freescale Semiconductor, Inc. All Rights > >Reserved. > >>> + */ > >>> + > >>> +/*

Re: [PATCH] atm: mpoa: remove 32-bit timekeeping

2017-11-30 Thread David Miller
From: Arnd Bergmann Date: Mon, 27 Nov 2017 15:02:17 +0100 > From: Tina Ruchandani > > net/atm/mpoa_* files use 'struct timeval' to store event > timestamps. struct timeval uses a 32-bit seconds field which will > overflow in the year 2038 and beyond. Morever, the timestamps are being > compared

Re: [PATCH] atm: eni: fix several indentation issues

2017-11-30 Thread David Miller
From: Colin King Date: Mon, 27 Nov 2017 13:15:10 + > From: Colin Ian King > > There are several statements that have incorrect indentation. Fix > these. > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH] openvswitch: use ktime_get_ts64() instead of ktime_get_ts()

2017-11-30 Thread David Miller
From: Arnd Bergmann Date: Mon, 27 Nov 2017 12:41:38 +0100 > timespec is deprecated because of the y2038 overflow, so let's convert > this one to ktime_get_ts64(). The code is already safe even on 32-bit > architectures, since it uses monotonic times. On 64-bit architectures, > nothing changes, wh

Re: [PATCH RESEND] net: phy: harmonize phy_id{,_mask} data type

2017-11-30 Thread David Miller
From: Richard Leitner Date: Mon, 27 Nov 2017 08:16:45 +0100 > From: Richard Leitner > > Previously phy_id was u32 and phy_id_mask was unsigned int. As the > phy_id_mask defines the important bits of the phy_id (and is therefore > the same size) these two variables should be the same data type.

Re: [PATCH] netxen: remove timespec usage

2017-11-30 Thread David Miller
From: Arnd Bergmann Date: Mon, 27 Nov 2017 12:39:57 +0100 > netxen_collect_minidump() evidently just wants to get a monotonic > timestamp. Using jiffies_to_timespec(jiffies, &ts) is not > appropriate here, since it will overflow after 2^32 jiffies, > which may be as short as 49 days of uptime. >

Re: [PATCH net-next] net: thunderx: Set max queue count taking XDP_TX into account

2017-11-30 Thread David Miller
From: Aleksey Makarov Date: Fri, 24 Nov 2017 15:04:03 +0300 > From: Sunil Goutham > > on T81 there are only 4 cores, hence setting max queue count to 4 > would leave nothing for XDP_TX. This patch fixes this by doubling > max queue count in above scenarios. > > Signed-off-by: Sunil Goutham >

RE: [PATCH] rtc: add mxc driver for i.MX53

2017-11-30 Thread Patrick Brünn
>From: Philippe Ombredanne [mailto:pombreda...@nexb.com] >Sent: Donnerstag, 30. November 2017 15:00 >On Thu, Nov 30, 2017 at 2:36 PM, Patrick Brünn >wrote: > >Thomas: >I tend to prefer as Linus pointed the // style throughout when there >is only a license and copyright involved. Here this would me

Re: [PATCH net-next] net: thunderx: Add support for xdp redirect

2017-11-30 Thread David Miller
From: Aleksey Makarov Date: Fri, 24 Nov 2017 15:03:26 +0300 > From: Sunil Goutham > > This patch adds support for XDP_REDIRECT. Flush is not > yet supported. > > Signed-off-by: Sunil Goutham > Signed-off-by: cjacob > Signed-off-by: Aleksey Makarov Applied.

[PATCH] chcr: ensure cntrl is initialized to fix bit-wise or'ing of garabage data

2017-11-30 Thread Colin King
From: Colin Ian King In the case where skb->ip_summed != CHECKSUM_PARTIAL then cntrl contains garbage value and this is possibly being bit-wise or'd and stored into cpl->ctrl1. Fix this by initializing cntrl to zero. Cleans up clang warning: drivers/crypto/chelsio/chcr_ipsec.c:374:9: warning: T

Re: dd: page allocation failure: order:0, mode:0x1080020(GFP_ATOMIC), nodemask=(null)

2017-11-30 Thread Michal Hocko
On Thu 30-11-17 22:01:03, Wu Fengguang wrote: > On Thu, Nov 30, 2017 at 02:50:16PM +0100, Michal Hocko wrote: > > On Thu 30-11-17 21:38:40, Wu Fengguang wrote: > > > Hello, > > > > > > It looks like a regression in 4.15.0-rc1 -- the test case simply run a > > > set of parallel dd's and there seems

Re: [PATCH] atm: firestream: use setup_timer instead of init_timer

2017-11-30 Thread David Miller
From: Colin King Date: Fri, 24 Nov 2017 13:13:45 + > From: Colin Ian King > > Use setup_timer function instead of initializing timer with the > function and data fields. > > Signed-off-by: Colin Ian King Likewise about setup_timer() no longer existing.

Re: [PATCH] atm: lanai: use setup_timer instead of init_timer

2017-11-30 Thread David Miller
From: Colin King Date: Fri, 24 Nov 2017 13:27:12 + > From: Colin Ian King > > Use setup_timer function instead of initializing timer with the > function and data fields. > > Signed-off-by: Colin Ian King setup_timer() == -ENOEXIST.

Re: [PATCH] atm: nicstar: use the setup_timer helper

2017-11-30 Thread David Miller
From: Colin King Date: Fri, 24 Nov 2017 08:59:25 + > From: Colin Ian King > > Replace init_timer and two explicit assignments with the setup_timer > helper. > > Signed-off-by: Colin Ian King setup_timer() no longer even exists in the tree.

[PATCH RT] crypto: limit more FPU-enabled sections

2017-11-30 Thread Sebastian Andrzej Siewior
Those crypto drivers use SSE/AVX/… for their crypto work and in order to do so in kernel they need to enable the "FPU" in kernel mode which disables preemption. There are two problems with the way they are used: - the while loop which processes X bytes may create latency spikes and should be avoi

[PATCH 2/2] epoll: use proper wake_up variant in ep_poll_callback

2017-11-30 Thread Christoph Hellwig
We do not hold ep->wq->lock, so we should not use wake_up_locked on it. Signed-off-by: Christoph Hellwig --- fs/eventpoll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index afd548ebc328..eaaa39616232 100644 --- a/fs/eventpoll.c +++ b/fs/ev

waitqueue lockdep annotation

2017-11-30 Thread Christoph Hellwig
Hi all, this series adds a strategic lockdep_assert_held to __wake_up_common to ensure callers really do hold the wait_queue_head lock when calling the unlocked wake_up variants. It turns out epoll did not do this for a fairly common path (hit all the time by systemd during bootup), so the second

[PATCH 1/2] sched/wait: assert the wait_queue_head lock is held in __wake_up_common

2017-11-30 Thread Christoph Hellwig
Better ensure we actually hold the lock using lockdep than just commenting on it. Due to the various exported _locked interfaces it is far too easy to get the locking wrong. Signed-off-by: Christoph Hellwig --- kernel/sched/wait.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/sch

Re: [PATCH/trivial] skbuff: Grammar s/are can/can/, s/change/changes/

2017-11-30 Thread David Miller
From: Geert Uytterhoeven Date: Thu, 30 Nov 2017 14:33:56 +0100 > Signed-off-by: Geert Uytterhoeven Applied, thanks Geert.

Re: [PATCH v2 0/3] KVM: x86: kvm_mwait_in_guest() cleanup

2017-11-30 Thread Michael S. Tsirkin
On Wed, Nov 29, 2017 at 10:23:40PM +0100, Radim Krčmář wrote: > This is a rebased version of an old series that simplified > kvm_mwait_in_guest: https://www.spinics.net/lists/kvm/msg149238.html > > AMD errata 400 patch was dropped thanks to Boris's review; > [2/3] got an expanded commit message an

Re: [PATCH] vfio/iommu_type1: report the IOMMU aperture info

2017-11-30 Thread Pierre Morel
On 30/11/2017 14:22, Auger Eric wrote: Hi Pierre, On 30/11/17 12:34, Pierre Morel wrote: When userland VFIO defines a new IOMMU for a guest it may want to specify to the guest the physical limits of the underlying host IOMMU to avoid access to forbidden memory ranges. Currently, the vfio_iommu_

Re: [kernel-hardening] Re: [PATCH v5 next 5/5] net: modules: use request_module_cap() to load 'netdev-%s' modules

2017-11-30 Thread Theodore Ts'o
On Thu, Nov 30, 2017 at 09:50:27AM +0100, Djalal Harouni wrote: > In embedded systems we can't maintain a SELinux policy, distro man > power hardly manage. We have abstracted seccomp etc, but the kernel > inherited the difficult multiplex things, plus all other paths that > trigger this. > Yes

Re: [Xen-devel] [PATCH V2] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-30 Thread Govinda Tatti
On 11/30/2017 2:27 AM, Jan Beulich wrote: On 29.11.17 at 18:38, wrote: In the case of bus or slot reset, our goal is to reset connected PCIe fabric/card/endpoint. The connected card/endpoint can be multi-function device. So, same walk-through and checking is needed irrespective of type of rese

Re: [PATCH] vfio/iommu_type1: report the IOMMU aperture info

2017-11-30 Thread Pierre Morel
On 30/11/2017 13:57, Jean-Philippe Brucker wrote: Hello, On 30/11/17 11:34, Pierre Morel wrote: [...] +/** + * vfio_get_aperture - report minimal aperture of a vfio_iommu + * @iommu: the current vfio_iommu + * @start: a pointer to the aperture start + * @end : a pointer to the aperture end + *

<    3   4   5   6   7   8   9   10   11   12   >