Re: [PATCH v2 4/6] fs/dcache: Avoid the try_lock loops in dentry_kill()

2018-02-22 Thread Al Viro
On Fri, Feb 23, 2018 at 02:22:43AM +, Al Viro wrote: > No. This is completely wrong. If somebody else has found the sucker > while we dropped the lock and even got around to playing with refcount, > they might have done more than that. > > In particular, they might have *dropped* their refe

Re: [PATCH] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-22 Thread Brian Norris
Hi Hans, Sorry if I'm a little slow to follow up here. This hasn't been my top priority... On Mon, Feb 19, 2018 at 11:17:24AM +0100, Hans de Goede wrote: > On 16-02-18 18:59, Brian Norris wrote: > > On Fri, Feb 16, 2018 at 01:10:20PM +0100, Hans de Goede wrote: > > > Ok, I've asked the reporter o

[git pull] drm fixes for v4.16-rc3

2018-02-22 Thread Dave Airlie
Hi Linus, A bunch of fixes for rc3, Exynos fixes for using monotonic timestamps, register definitions and removal of unused file ipu-v3 - minor changes, make some register arrays const+static, fix some leaks meson: fix for vsync atomic: fix for memory leak EDID parser: add quirks for some more no

Re: [PATCH v12 10/11] sparc64: Add support for ADI (Application Data Integrity)

2018-02-22 Thread kbuild test robot
Hi Khalid, I love your patch! Yet something to improve: [auto build test ERROR on sparc-next/master] [also build test ERROR on v4.16-rc2] [cannot apply to next-20180222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [PATCH] tee: correct max value for id allocation

2018-02-22 Thread Peng Fan
Hi Jens, Any comments on this patch? Thanks, Peng On Mon, Jan 15, 2018 at 05:27:35PM +0800, Peng Fan wrote: >The privileged dev id range is [TEE_NUM_DEVICES / 2, TEE_NUM_DEVICES). >The non-privileged dev id range is [0, TEE_NUM_DEVICES / 2). > >So when finding a slot for them, need to use differe

[PATCH] x86/intel_rdt: Fix incorrect returned value when creating rdgroup sub-directory in resctrl file system

2018-02-22 Thread Fenghua Yu
From: Wang Hui If no monitoring feature is detected because all monitoring features are disabled during boot time or there is no monitoring feature in hardware, creating rdtgroup sub-directory by "mkdir" command reports error: #mkdir /sys/fs/resctrl/p1 mkdir: cannot create directory ‘/sys/fs/res

Re: [PATCH v2 3/3] mm/sparse: Optimize memmap allocation during sparse_init()

2018-02-22 Thread Baoquan He
On 02/22/18 at 02:22pm, Dave Hansen wrote: > First of all, this is a much-improved changelog. Thanks for that! > > On 02/22/2018 01:11 AM, Baoquan He wrote: > > In sparse_init(), two temporary pointer arrays, usemap_map and map_map > > are allocated with the size of NR_MEM_SECTIONS. They are used

Re: [PATCH 5/9] scsi: ufs: add reference counting for scsi block requests

2018-02-22 Thread Asutosh Das (asd)
On 2/21/2018 6:48 PM, Stanislav Nijnikov wrote: -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Asutosh Das Sent: Wednesday, February 21, 2018 6:57 AM To: subha...@codeaurora.org; c...@codeaurora.org; vivek.gau...@codeau

linux-next: manual merge of the staging tree with Linus' tree

2018-02-22 Thread Stephen Rothwell
Hi Greg, Today's linux-next merge of the staging tree got a conflict in: drivers/staging/fsl-mc/bus/Kconfig between commit: 02b7b2844c2f ("staging: fsl-mc: fix build testing on x86") from Linus' tree and commit: 6bd067c48efe ("staging: fsl-mc: Move core bus out of staging") from the st

Re: [PATCH 0/7] drm/virtio: Checkpatch cleanup for virtio

2018-02-22 Thread Gurchetan Singh
Patches 1 to 7 are: Reviewed-by: Gurchetan Singh On Thu, Feb 22, 2018 at 3:59 PM, Rodrigo Siqueira wrote: > This patchset fixes warnings and errors found by checkpatch.pl in the > drm/virtio: > > * Removes return from void function; > * Adds */ in block comments to separate line; > * Adds blank

Re: [PATCH v2 4/6] fs/dcache: Avoid the try_lock loops in dentry_kill()

2018-02-22 Thread Al Viro
On Fri, Feb 23, 2018 at 12:50:23AM +0100, John Ogness wrote: > static struct dentry *dentry_kill(struct dentry *dentry) > __releases(dentry->d_lock) > { > - struct inode *inode = dentry->d_inode; > - struct dentry *parent = NULL; > + int saved_count = dentry->d_lockref.count;

Re: [PATCH] cpufreq: mediatek: Convert pr_warn() to pr_debug()

2018-02-22 Thread Sean Wang
On Thu, 2018-02-22 at 11:26 +0530, Viresh Kumar wrote: > With multi-platform build images, this shows a message on non mediatek > platforms, which is unnecessary. Convert pr_warn() to pr_debug() here. > > Signed-off-by: Viresh Kumar > --- > drivers/cpufreq/mediatek-cpufreq.c | 2 +- > 1 file cha

Re: [PATCH 00/11] KASan for arm

2018-02-22 Thread Liuwenliang (Abbott Liu)
On 2018/2/14 2:41 AM, Florian Fainelli [f.faine...@gmail.com] wrote: >Hi Abbott, > >Are you planning on picking up these patches and sending a second >version? I would be more than happy to provide test results once you >have something, this is very useful, thank you! >-- >Florian I'm sorry to r

[rcu:rcu/dev 27/27] kernel/rcu/tree_exp.h:461:16: error: implicit declaration of function 'ACCESS_ONCE'; did you mean '__READ_ONCE'?

2018-02-22 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/dev head: a57af56830b510f3dae7fa26313058c192f38f94 commit: a57af56830b510f3dae7fa26313058c192f38f94 [27/27] rcu: Parallelize expedited grace-period initialization config: i386-randconfig-x004-201807 (attached as .

linux-next: manual merge of the kvms390 tree with the nds32 tree

2018-02-22 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the kvms390 tree got a conflict in: drivers/video/console/Kconfig between commit: 2312dbf7462b ("drivers/video/concole: add negative dependency for VGA_CONSOLE on nds32") from the nds32 tree and commit: 2f1ca75f69f3 ("s390/setup : enable display supp

Re: [PATCH v2 3/6] fs/dcache: Avoid the try_lock loop in d_delete()

2018-02-22 Thread Al Viro
On Fri, Feb 23, 2018 at 12:50:22AM +0100, John Ogness wrote: > The trylock loop can be avoided with functionality similar to > lock_parent(). The fast path tries the trylock first, which is likely > to succeed. In the contended case it attempts locking in the correct > order. This requires to drop

Re: [PATCH 03/10] X86/nVMX: Update the PML table without mapping and unmapping the page

2018-02-22 Thread kbuild test robot
Hi KarimAllah, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/auto-latest] [also build test WARNING on v4.16-rc2 next-20180222] [cannot apply to kvm/linux-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the

Re: [PATCH net v3 2/2] tuntap: correctly add the missing xdp flush

2018-02-22 Thread Jason Wang
On 2018年02月23日 01:46, Jesper Dangaard Brouer wrote: On Thu, 22 Feb 2018 17:36:46 +0800 Jason Wang wrote: Commit 762c330d670e ("tuntap: add missing xdp flush") tries to fix the devmap stall caused by missed xdp flush by counting the pending xdp redirected packets and flush when it exceeds NAP

Re: [PATCH] srcu: remove never used variable

2018-02-22 Thread Zhouyi Zhou
Thanks Paul's encouragement, I will keep studying SRCU code. On Fri, Feb 23, 2018 at 9:20 AM, Paul E. McKenney wrote: > On Fri, Feb 23, 2018 at 09:04:05AM +0800, Zhouyi Zhou wrote: >> Thanks Paul for reviewing > > And thank you for your interest in SRCU! I am pretty sure that other > bugs still

Re: [PATCH 1/8] dt-bindings: scsi: hisi_sas: add an property of signal attenuation

2018-02-22 Thread Martin K. Petersen
> From: Xiaofei Tan > > For some new boards with hip07 chipset we are required to > set PHY config registers differently. The hw property which > determines how to set these registers is in the PHY signal > attenuation readings. > > This patch add an devicetree property, signal-attenuation, which

Re: [PATCH] MAINTAINERS: Update ASPEED entry with details

2018-02-22 Thread Wang, Haiyue
On 2018-02-23 08:11, Andrew Jeffery wrote: Hi Haiyue, On Thu, 22 Feb 2018, at 19:20, Wang, Haiyue wrote: Dear Andrew & Joel, Since you are ASPEED BMC experts, any time and interest in eSPI code review ? I've sent it before, but no more response. Intel recommends eSPI bus than LPC as I know.

Re: [PATCH v2 1/2] free_pcppages_bulk: do not hold lock when picking pages to free

2018-02-22 Thread Aaron Lu
On Thu, Feb 15, 2018 at 04:46:44AM -0800, Matthew Wilcox wrote: > On Thu, Jan 25, 2018 at 03:21:44PM +0800, Aaron Lu wrote: > > When freeing a batch of pages from Per-CPU-Pages(PCP) back to buddy, > > the zone->lock is held and then pages are chosen from PCP's migratetype > > list. While there is a

Re: [PATCH] mmc: dw_mmc: update kernel-doc comments for dw_mci

2018-02-22 Thread Shawn Lin
Hi Alexey, On 2018/2/23 3:45, Alexey Roslyakov wrote: cur_slot and num_slots has been removed from struct dw_mci in 42f989c002f2. Unfortunately, inline documentation was not updated so far. Fix @lock field documentation in Locking section. Move @mrq field of struct dw_mci_slot mention closer to

Re: [PATCH 04/10] KVM: Introduce a new guest mapping API

2018-02-22 Thread kbuild test robot
Hi KarimAllah, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/auto-latest] [also build test ERROR on v4.16-rc2 next-20180222] [cannot apply to kvm/linux-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system

Re: [PATCH v2 1/2] free_pcppages_bulk: do not hold lock when picking pages to free

2018-02-22 Thread Aaron Lu
On Thu, Feb 15, 2018 at 12:06:08PM +, Mel Gorman wrote: > On Thu, Jan 25, 2018 at 03:21:44PM +0800, Aaron Lu wrote: > > When freeing a batch of pages from Per-CPU-Pages(PCP) back to buddy, > > the zone->lock is held and then pages are chosen from PCP's migratetype > > list. While there is actua

[PATCH 2/4] Staging: gdm724x: hci: Changed camel-case to snake-case.

2018-02-22 Thread Quytelda Kahja
Changed a variable name from camel to snake case to fix a coding style issue. Signed-off-by: Quytelda Kahja --- drivers/staging/gdm724x/hci_packet.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/hci_packet.h b/drivers/staging/gdm724x/hci_packet.h in

[PATCH 3/4] Staging: gdm724x: Simplify the struct gdm_endian to a variable.

2018-02-22 Thread Quytelda Kahja
Since the testing for host endianness and in-driver conversion were removed in 77e8a50149a2, the gdm_endian struct contains only one member, and can therefore be simplified to a single u8 variable. Signed-off-by: Quytelda Kahja --- drivers/staging/gdm724x/gdm_endian.c | 24 --

[PATCH 4/4] Staging: gdm724x: LTE: Refactor gdm_lte_pdn_table().

2018-02-22 Thread Quytelda Kahja
Mostly this change just reverses the primary conditional so most of the code can be pulled back a tab, which fixes some code style warnings. Signed-off-by: Quytelda Kahja --- drivers/staging/gdm724x/gdm_lte.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --

[rcu] 11d88c8120: general_protection_fault:#[##]

2018-02-22 Thread kernel test robot
FYI, we noticed the following commit (built with gcc-7): commit: 11d88c812043b17c016b8dbe931244f74f082281 ("rcu: Parallelize expedited grace-period initialization") https://git.kernel.org/cgit/linux/kernel/git/paulmck/linux-rcu.git rcu/dev in testcase: boot on test machine: qemu-system-x86_64

Re: [PATCH 0/3] Improve and extend checkpatch.pl Kconfig help text checks

2018-02-22 Thread Ulf Magnusson
On Fri, Feb 16, 2018 at 10:14 PM, Joe Perches wrote: > On Fri, 2018-02-16 at 21:22 +0100, Ulf Magnusson wrote: >> Hello, >> >> This patchset contains some improvements for the Kconfig help text check in >> scripts/checkconfig.pl: > > Seems sensible enough to me. > Signed-off-by: Joe Perches Will

[PATCH 1/4] Staging: gdm724x: LTE: Fix trailing open parentheses.

2018-02-22 Thread Quytelda Kahja
Fix lines with a trailing open parenthesis, which is a coding style issue. Signed-off-by: Quytelda Kahja --- drivers/staging/gdm724x/gdm_lte.c | 44 +++ 1 file changed, 21 insertions(+), 23 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_lte.c b/driver

Re: [PATCH 04/10] KVM: Introduce a new guest mapping API

2018-02-22 Thread kbuild test robot
Hi KarimAllah, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/auto-latest] [also build test ERROR on v4.16-rc2 next-20180222] [cannot apply to kvm/linux-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system

Re: [PATCH] srcu: remove never used variable

2018-02-22 Thread Paul E. McKenney
On Fri, Feb 23, 2018 at 09:04:05AM +0800, Zhouyi Zhou wrote: > Thanks Paul for reviewing And thank you for your interest in SRCU! I am pretty sure that other bugs still remain. ;-) Thanx, Paul > Cheers > Zhouyi > > On Friday, February 23

[PATCH v2 2/2] ASoC: support ROHM BD28623 codec

2018-02-22 Thread Katsuhiro Suzuki
This patch adds support of the ROHM BD28623MUV Class D speaker amplifier for Flat-panel TVs. This IC delivers an output power of 20W + 20W. Signed-off-by: Katsuhiro Suzuki --- Changes in v2: - Fix lisence comment style - Use _cansleep() version for manipulating GPIO - Use ASoC component r

Re: [PATCH 0/7] fujitsu-laptop: Miscellaneous cleanups

2018-02-22 Thread Darren Hart
On Sun, Feb 18, 2018 at 08:55:09PM +0100, Michał Kępień wrote: > > To avoid just having to review everything again in a few months ;-) I've > > queued > > up patches 1-5. I'll await comments to 6 and a respin of 7 based on > > feedback. > > Thanks, I think I will post v2 of the entire series wit

[PATCH v2 0/2] ASoC: add support for ROHM BD28623 codec

2018-02-22 Thread Katsuhiro Suzuki
This patch adds support for ROHM BD28623MUV class D speaker amplifier codec driver. This driver only refers information of HW specification document that can be derivered at website of ROHM. http://www.rohm.com/web/global/products/-/product/BD28623MUV --- Changes in v2: - Change gpio properti

[PATCH v2 1/2] ASoC: add DT bindings documentation for ROHM BD28623 codec

2018-02-22 Thread Katsuhiro Suzuki
This patch adds DT bindings documentation for ROHM BD28623MUV class D speaker amplifier. Signed-off-by: Katsuhiro Suzuki --- Changes in v2: - Change gpio properties to optional - Change VCCA, VCCP-supply to mandatory --- .../devicetree/bindings/sound/rohm,bd28623.txt | 29 +

Re: [PATCH 1/2] Staging: gdm724x: Simplify the struct gdm_endian to a variable.

2018-02-22 Thread Quytelda Kahja
Sorry, it depends on the several patches I submitted earlier in that email thread, since they were in response to several suggestions for earlier patches. I will resend all of the patches in that thread as a consecutive patch series in response to this email to minimize confusion. Thank you, Quyt

Re: [PATCH] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems

2018-02-22 Thread kbuild test robot
Hi Evgeniy, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc2 next-20180222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Proposal - how to make usbip more resistant to misconfiguration

2018-02-22 Thread wzabo...@elektron.elka.pw.edu.pl
Hi, I have found that the https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891036 is not the only one related to misconfiguration of the usbip driver and tools. A few weeks ago the similar bug https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=878866 was discovered. It seems that the configuration

Re: [PATCH v2] [media] Delete unnecessary variable initialisations in seven functions

2018-02-22 Thread Alexey Klimov
On Thu, Feb 22, 2018 at 9:22 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 22 Feb 2018 21:45:47 +0100 > > Some local variables will be set to an appropriate value before usage. > Thus omit explicit initialisations at the beginning of these functions. > > Signed-off-by: Markus E

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

2018-02-22 Thread J. Bruce Fields
On Thu, Feb 22, 2018 at 06:39:43AM +, James Ettle wrote: > I only really posted this as a demo of a fix. I was hoping someone who > actually knows what they're doing in the kernel would pick it up and make it > proper. Whoops, sorry, I didn't realize that. But I don't see a problem with the

Re: [PATCH 1/1] mm, compaction: correct the bounds of __fragmentation_index()

2018-02-22 Thread Robert Harris
> On 19 Feb 2018, at 12:39, Michal Hocko wrote: > > On Mon 19-02-18 12:14:26, Robert Harris wrote: >> >> >>> On 19 Feb 2018, at 08:26, Michal Hocko wrote: >>> >>> On Sun 18-02-18 16:47:55, robert.m.har...@oracle.com wrote: From: "Robert M. Harris" __fragmentation_index() ca

[PATCH] MIPS: boot: Define __ASSEMBLY__ for its.S build

2018-02-22 Thread Kees Cook
The MIPS %.its.S compiler command did not define __ASSEMBLY__, which meant when compiler_types.h was added to kconfig.h, unexpected things appeared (e.g. struct declarations) which should not have been present. As done in the general %.S compiler command, __ASSEMBLY__ is now included here too. The

Re: [PATCH v2 0/6] fs/dcache: avoid trylock loops

2018-02-22 Thread Linus Torvalds
On Thu, Feb 22, 2018 at 3:50 PM, John Ogness wrote: > > This patchset removes all trylock loops from within the dcache code. I'm not hating it. It may be because I got used (resigned?) to this from the discussion around the previous version. But it looks ok to me. But this is very much an area

Re: [PATCH] riscv: Implement free_initrd_mem.

2018-02-22 Thread Palmer Dabbelt
On Tue, 20 Feb 2018 05:50:43 PST (-0800), s...@shealevy.com wrote: Signed-off-by: Shea Levy --- arch/riscv/mm/init.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c index c77df8142be2..1c832b541e95 100644 --- a/arch/riscv/mm/init.c +++ b/arc

Re: [GIT PULL] SCSI fixes for 4.16-rc2

2018-02-22 Thread Linus Torvalds
On Thu, Feb 22, 2018 at 11:28 AM, James Bottomley wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes When I pull that, I get something completely different from what you claim I should get. Much bigger, and a lot more commits. Hmm? Dropped. Linus

Re: [PATCH 2/2] ARM: dts: exynos: Fix unit addresses of PDMA nodes in Exynos5410

2018-02-22 Thread Chanwoo Choi
On 2018년 02월 23일 04:11, Krzysztof Kozlowski wrote: > Fix the unit addresses of PDMA nodes in Exynos5410 (the reg property is > correct) to get rid of DTC warnings like: > > arch/arm/boot/dts/exynos5410-odroidxu.dtb: Warning (simple_bus_reg): > Node /soc/amba/pdma@1268 simple-bus un

Re: [PATCH 1/2] ARM: dts: exynos: Fix address of PPMU ACP on Exynos4210

2018-02-22 Thread Chanwoo Choi
On 2018년 02월 23일 04:11, Krzysztof Kozlowski wrote: > Typo in unit address of PPMU ACP caused DTC warnings: > > arch/arm/boot/dts/exynos4412-odroidu3.dtb: > Warning (simple_bus_reg): Node /soc/ppmu_acp@10ae simple-bus unit > address format error, expected "106e" > > PPMU ACP (

Re: [PATCH 5/9] drm/xen-front: Implement handling of shared display buffers

2018-02-22 Thread Boris Ostrovsky
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > > static int __init xen_drv_init(void) > { > + /* At the moment we only support case with XEN_PAGE_SIZE == PAGE_SIZE */ > + BUILD_BUG_ON(XEN_PAGE_SIZE != PAGE_SIZE); Why BUILD_BUG_ON? This should simply not load if page sizes ar

Re: [RFC][PATCH 0/6] KEYS: Fixes

2018-02-22 Thread James Morris
On Thu, 22 Feb 2018, David Howells wrote: > I've posted an update that converts the min() to a min_t() and tagged it: > > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/tag/?h=keys-fixes-20180222-2 > > Do you want me to repost the patches? Nope, I

Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default

2018-02-22 Thread Bjorn Helgaas
On Fri, Feb 23, 2018 at 12:42:28AM +0100, Ulf Magnusson wrote: > On Fri, Feb 23, 2018 at 12:00 AM, Bjorn Helgaas wrote: > > On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote: > >> 'default N' should be 'default n', though they happen to have the same > >> effect here, due to undefined

Re: [PATCH v2] kconfig.h: Include compiler types to avoid missed struct attributes

2018-02-22 Thread Kees Cook
On Thu, Feb 22, 2018 at 4:03 PM, Kees Cook wrote: > On Thu, Feb 22, 2018 at 2:26 PM, kbuild test robot wrote: >> Hi Kees, >> >> I love your patch! Yet something to improve: >> >> [auto build test ERROR on linus/master] >> [also build test ERROR on v4.16-

Re: [PATCH 04/11] signal/parisc: Document a conflict with SI_USER with SIGFPE

2018-02-22 Thread Eric W. Biederman
Helge Deller writes: > * Eric W. Biederman : >> Setting si_code to 0 results in a userspace seeing an si_code of 0. >> This is the same si_code as SI_USER. Posix and common sense requires >> that SI_USER not be a signal specific si_code. As such this use of 0 >> for the si_code is a pretty horr

Re: [BUGFIX PATCH v2.1] tracing: probeevent: Fix to support minus offset from symbol

2018-02-22 Thread Namhyung Kim
Hi Masami, On Thu, Feb 22, 2018 at 04:45:01PM +0900, Masami Hiramatsu wrote: > In Documentation/trace/kprobetrace.txt, it says > > @SYM[+|-offs] : Fetch memory at SYM +|- offs (SYM should be a data symbol) > > However, the parser doesn't parse minus offset correctly, since > commit 2fba0c8867af

Re: [PATCH] MAINTAINERS: Update ASPEED entry with details

2018-02-22 Thread Andrew Jeffery
Hi Haiyue, On Thu, 22 Feb 2018, at 19:20, Wang, Haiyue wrote: > Dear Andrew & Joel, > > Since you are ASPEED BMC experts, any time and interest in eSPI code > review ? I've sent > > it before, but no more response. Intel recommends eSPI bus than LPC as I > know. I just kept > > the minimal eS

Re: [PATCH v2] kconfig.h: Include compiler types to avoid missed struct attributes

2018-02-22 Thread Kees Cook
On Thu, Feb 22, 2018 at 2:26 PM, kbuild test robot wrote: > Hi Kees, > > I love your patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.16-rc2 next-20180222] > [if your patch is applied to the wrong git tree, ple

[PATCH 6/7] drm/virtio: Remove multiple blank lines

2018-02-22 Thread Rodrigo Siqueira
This patch fixes the checkpatch.pl check: virtgpu_drv.c:116: CHECK: Please don't use multiple blank lines virtgpu_vq.c:599: CHECK: Please don't use multiple blank lines virtgpu_prime.c:42: CHECK: Please don't use multiple blank lines Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/virtio/vi

[PATCH 7/7] drm/virtio: Add spaces around operators

2018-02-22 Thread Rodrigo Siqueira
This patch fixes the checkpatch.pl check: virtgpu_ioctl.c:535: CHECK: spaces preferred around that '|' (ctx:VxV) virtgpu_vq.c:277: CHECK: spaces preferred around that '+' (ctx:VxV) ... Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 18 +- drivers/gp

[PATCH 5/7] drm/virtio: Replace 'unsigned' for 'unsigned int'

2018-02-22 Thread Rodrigo Siqueira
This patch fixes the checkpatch.pl warning: drivers/gpu/drm/virtio/virtgpu_display.c:64: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' ... Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/virtio/virtgpu_display.c | 4 ++-- drivers/gpu/drm/virtio/virtgpu_drv.h | 2 +- drivers/g

[PATCH 4/7] drm/virtio: Remove return from void function

2018-02-22 Thread Rodrigo Siqueira
This patch fixes the checkpatch.pl warning: virtgpu_ttm.c:181: WARNING: void function return statements are not generally useful ... Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/virtio/virtgpu_ttm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c

[PATCH 2/7] drm/virtio: Add blank line after variable declarations

2018-02-22 Thread Rodrigo Siqueira
This patch fixes the checkpatch.pl warnings: virtgpu_drv.c:57: WARNING: Missing a blank line after declarations virtgpu_display.c:99: WARNING: Missing a blank line after declarations ... Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/virtio/virtgpu_display.c | 1 + drivers/gpu/drm/virtio/v

[PATCH 3/7] drm/virtio: Add */ in block comments to separate line

2018-02-22 Thread Rodrigo Siqueira
This patch fixes the checkpatch.pl warning: virtgpu_ioctl.c:551: WARNING: Block comments use a trailing */ on a separate line ... Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 3 ++- drivers/gpu/drm/virtio/virtgpu_prime.c | 3 ++- drivers/gpu/drm/virtio/virtgpu_vq

[PATCH 1/7] drm/virtio: Add tabs at the start of a line

2018-02-22 Thread Rodrigo Siqueira
This patch fixes the checkpatch.pl errors: drivers/gpu/drm/virtio/virtgpu_drv.h:371: ERROR: code indent should use tabs where possible ... Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/virtio/virtgpu_display.c | 2 +- drivers/gpu/drm/virtio/virtgpu_drv.h | 6 +++--- 2 files changed, 4

[PATCH 0/7] drm/virtio: Checkpatch cleanup for virtio

2018-02-22 Thread Rodrigo Siqueira
This patchset fixes warnings and errors found by checkpatch.pl in the drm/virtio: * Removes return from void function; * Adds */ in block comments to separate line; * Adds blank line after variable declarations; * Adds tabs at the start of a line; * Replaces 'unsigned' for 'unsigned int'; * Remove

Re: [PATCH v2 1/3] mm/sparse: Add a static variable nr_present_sections

2018-02-22 Thread Baoquan He
On 02/22/18 at 01:24pm, Andrew Morton wrote: > On Thu, 22 Feb 2018 17:11:28 +0800 Baoquan He wrote: > > > It's used to record how many memory sections are marked as present > > during system boot up, and will be used in the later patch. > > > > --- a/mm/sparse.c > > +++ b/mm/sparse.c > > @@ -202

Re: [PATCH 0/2] rcu: Transform kfree_rcu() into kvfree_rcu()

2018-02-22 Thread Paul E. McKenney
On Wed, Feb 07, 2018 at 10:10:55AM -0800, Matthew Wilcox wrote: > On Wed, Feb 07, 2018 at 05:45:13PM +0100, Jesper Dangaard Brouer wrote: > > On Wed, 7 Feb 2018 08:57:00 -0500 > > Steven Rostedt wrote: > > > To me kvfree() is a special case and should not be used by RCU as a > > > generic function

Re: [PATCH] doc: process: Add "Root-caused-by" and "Suggested-by"

2018-02-22 Thread Joe Perches
On Thu, 2018-02-22 at 10:40 -0700, Jonathan Corbet wrote: > That said, we can add this one; I'll take the patch if I get an ack from > Joe. Meh-ed-by: Joe Perches

[PATCH v2 1/6] fs/dcache: Remove stale comment from dentry_kill()

2018-02-22 Thread John Ogness
Commit 0d98439ea3c6 ("vfs: use lockred "dead" flag to mark unrecoverably dead dentries") removed the `ref' parameter in dentry_kill() but its documentation remained. Remove it. Signed-off-by: John Ogness --- fs/dcache.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/dcache.c b/fs/dcache.c

[PATCH v2 5/6] fs/dcache: Avoid a try_lock loop in shrink_dentry_list()

2018-02-22 Thread John Ogness
shrink_dentry_list() holds dentry->d_lock and needs to acquire dentry->d_inode->i_lock. This cannot be done with a spin_lock() operation because it's the reverse of the regular lock order. To avoid ABBA deadlocks it is done with a trylock loop. Trylock loops are problematic in two scenarios: 1)

[PATCH v2 3/6] fs/dcache: Avoid the try_lock loop in d_delete()

2018-02-22 Thread John Ogness
d_delete() holds dentry->d_lock and needs to acquire dentry->d_inode->i_lock. This cannot be done with a spin_lock() operation because it's the reverse of the regular lock order. To avoid the ABBA deadlock it is done with a trylock loop. Trylock loops are problematic in two scenarios: 1) PREEMP

Re: [PATCH v7 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-02-22 Thread Jordan Crouse
On Wed, Feb 07, 2018 at 04:01:19PM +0530, Vivek Gautam wrote: > From: Sricharan R > > The smmu device probe/remove and add/remove master device callbacks > gets called when the smmu is not linked to its master, that is without > the context of the master device. So calling runtime apis in those p

[PATCH v2 0/6] fs/dcache: avoid trylock loops

2018-02-22 Thread John Ogness
Thank you Al Viro, Linus Torvalds, Peter Zijlstra, Amir Goldstein for the detailed feedback. Changes in v2: . dentry_lock_inode() - added quick out on trylock success - added comments to rcu section - expanded rcu coverage to all inode usage - if inode changes during d_lock window, res

[PATCH v2 2/6] fs/dcache: Move dentry_kill() below lock_parent()

2018-02-22 Thread John Ogness
A subsequent patch will modify dentry_kill() to call lock_parent(). Move the dentry_kill() implementation "as is" below lock_parent() first. This will help simplify the review of the subsequent patch with dentry_kill() changes. Signed-off-by: John Ogness --- fs/dcache.c | 62

[PATCH v2 6/6] fs/dcache: Avoid remaining try_lock loop in shrink_dentry_list()

2018-02-22 Thread John Ogness
shrink_dentry_list() holds dentry->d_lock and needs to acquire dentry->d_inode->i_lock. This cannot be done with a spin_lock() operation because it's the reverse of the regular lock order. To avoid ABBA deadlocks it is done with a trylock loop. Trylock loops are problematic in two scenarios: 1)

[PATCH v2 4/6] fs/dcache: Avoid the try_lock loops in dentry_kill()

2018-02-22 Thread John Ogness
dentry_kill() holds dentry->d_lock and needs to acquire both dentry->d_inode->i_lock and dentry->d_parent->d_lock. This cannot be done with spin_lock() operations because it's the reverse of the regular lock order. To avoid ABBA deadlocks it is done with two trylock loops. Trylock loops are proble

Re: [PATCH 4/9] drm/xen-front: Implement Xen event channel handling

2018-02-22 Thread Boris Ostrovsky
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > + > +static irqreturn_t evtchnl_interrupt_ctrl(int irq, void *dev_id) > +{ > + struct xen_drm_front_evtchnl *evtchnl = dev_id; > + struct xen_drm_front_info *front_info = evtchnl->front_info; > + struct xendispl_resp *resp; > +

Re: [PATCH V2] PCI: Add ACS quirk for Ampere root ports

2018-02-22 Thread Bjorn Helgaas
On Tue, Feb 20, 2018 at 07:19:27PM -0800, Feng Kan wrote: > The Ampere Computing PCIe root port does not support ACS at this point. > However, the hardware provides isolation and source validation through the > SMMU. The stream ID generated by the PCIe ports contain both the > bus/device/function n

Re: Removing architectures without upstream gcc support

2018-02-22 Thread Guenter Roeck
On Thu, Feb 22, 2018 at 04:45:06PM +0100, Arnd Bergmann wrote: > While building the cross-toolchains, I noticed that overall, we can build > almost > all linux target architectures with upstream binutils and gcc these days, > however there are still some exceptions, and I'd like to find out if any

Re: [PATCH] clk: tegra: fix pllu rate configuration

2018-02-22 Thread Stephen Warren
On 02/22/2018 04:04 PM, Marcel Ziswiler wrote: Turns out latest upstream U-Boot does not configure/enable pllu which leaves it at some default rate of 500 kHz: I assume this is only because U-Boot just happened not to access any USB devices. In other words, if you break into the U-Boot boot fl

Re: [PATCH v2 09/10] drivers: qcom: rpmh: add support for batch RPMH request

2018-02-22 Thread Evan Green
Hi Lina, On Thu, Feb 22, 2018 at 9:04 AM, Lina Iyer wrote: > On Wed, Feb 21 2018 at 23:25 +, Evan Green wrote: >> >> Hello Lina, >> >> On Thu, Feb 15, 2018 at 9:35 AM, Lina Iyer wrote: >>> >>> Platform drivers need make a lot of resource state requests at the same >>> time, say, at the start

Re: [RFC][PATCH 0/6] KEYS: Fixes

2018-02-22 Thread David Howells
I've posted an update that converts the min() to a min_t() and tagged it: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/tag/?h=keys-fixes-20180222-2 Do you want me to repost the patches? David

Re: [PATCH v2 07/10] drivers: qcom: rpmh: cache sleep/wake state requests

2018-02-22 Thread Evan Green
Hi Lina, On Thu, Feb 22, 2018 at 8:58 AM, Lina Iyer wrote: > On Wed, Feb 21 2018 at 22:07 +, Evan Green wrote: >> >> Hi Lina, >> >> On Thu, Feb 15, 2018 at 9:35 AM, Lina Iyer wrote: > > [...] > >>> +static struct cache_req *cache_rpm_request(struct rpmh_client *rc, >>> +

Re: [PATCH 6/6] KEYS: Use individual pages in big_key for crypto buffers

2018-02-22 Thread David Howells
David Howells wrote: > + l = min(len, PAGE_SIZE); Sigh. This needs to be a min_t(). David

Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default

2018-02-22 Thread Ulf Magnusson
On Fri, Feb 23, 2018 at 12:00 AM, Bjorn Helgaas wrote: > On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote: >> 'default N' should be 'default n', though they happen to have the same >> effect here, due to undefined symbols (N in this case) evaluating to n >> in a tristate sense. >> >>

[PATCH v8 1/3] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2018-02-22 Thread David Daney
From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Acked-by: Rob Herring Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- .../devicetree/bindings/net/cavium-bgx.txt | 61 ++ 1 file changed, 61 insert

[PATCH v8 3/3] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-*

2018-02-22 Thread David Daney
Signed-off-by: David Daney --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9a7f76eadae9..b36371ae590f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3259,6 +3259,12 @@ W: http://www.cavium.com S: Supported F: drivers/mmc/ho

[PATCH v8 0/3] netdev: octeon-ethernet: Add Cavium Octeon III support.

2018-02-22 Thread David Daney
We are adding the Cavium OCTEON-III network driver. Since interacting with the input and output queues is done via special CPU local memory, we also need to add support to the MIPS/Octeon architecture code. The four patch set to add this prerequisite code has been split out to a seperate patch se

Re: [PATCH] ARM: multi_v7_defconfig: Enable serial console on RPi 3

2018-02-22 Thread Eric Anholt
Eric Anholt writes: > [ Unknown signature status ] > Tuomas Tynkkynen writes: > >> The Raspberry Pi 3 uses the 8250-based auxilary UART of the BCM2837 SoC >> as the primary serial console of the board, so enable it in the >> multiplatform defconfig. >> >> Signed-off-by: Tuomas Tynkkynen > > Rev

[PATCH v3 1/2] dt-bindings: power: reset: gpio-poweroff: Add 'timeout-ms' property

2018-02-22 Thread Moritz Fischer
Add 'timeout-ms' property to support boards where the 3s timeout that the current driver defaults to is too short. Signed-off-by: Moritz Fischer --- Changes from v2: - Addressed Rob's feedback (timeout_ms -> timeout-ms) Changes from v1: - Addressed Rob's feedback (timeout -> timeout_ms) - Added

[PATCH v3 2/2] power: reset: gpio-poweroff: Support for timeout from device property

2018-02-22 Thread Moritz Fischer
Add support for reading a timeout value from device property. Fall back to previous default of 3s if nothing is specified. Signed-off-by: Moritz Fischer --- Changes from v2: - use device_property_read_{bool,u32} instead of of equivalent Changes from v1: - of_property_read_u32() overwrites the ou

Re: [PATCH 3/9] drm/xen-front: Read driver configuration from Xen store

2018-02-22 Thread Boris Ostrovsky
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > + > +static int cfg_connector(struct xen_drm_front_info *front_info, > + struct xen_drm_front_cfg_connector *connector, > + const char *path, int index) > +{ > + char *connector_path; > + > + connector_path = d

Re: [07/18] thunderbolt: Handle rejected Thunderbolt devices

2018-02-22 Thread Jeremy McNicoll
On Tue, Feb 13, 2018 at 08:00:07PM +0300, Mika Westerberg wrote: > The ICM firmware may reject devices for different reasons, even if we > have asked it to accept anything. If we notice a device is rejected, we > just log the event and bail out. > > Signed-off-by: Mika Westerberg > --- > drivers

Re: [PATCH RFC] riscv/barrier: Define __smp_{mb,rmb,wmb}

2018-02-22 Thread Palmer Dabbelt
On Tue, 20 Feb 2018 02:17:28 PST (-0800), parri.and...@gmail.com wrote: Introduce __smp_{mb,rmb,wmb}, and rely on the generic definitions for smp_{mb,rmb,wmb}. A first consequence is that smp_{mb,rmb,wmb} map to a compiler barrier on !SMP (while their definition remains unchanged on SMP). As a fu

Re: [RFC][PATCH 03/10] x86/mm: introduce "default" kernel PTE mask

2018-02-22 Thread Tom Lendacky
On 2/22/2018 4:26 PM, Dave Hansen wrote: > On 02/22/2018 02:21 PM, Nadav Amit wrote: >> Dave Hansen wrote: >>> From: Dave Hansen >>> The __PAGE_KERNEL_* page permissions are "raw". They contain bits >>> that may or may not be supported on the current processor. They >>> need to be filtered by a

[PATCH v8 3/4] staging: octeon: Remove USE_ASYNC_IOBDMA macro.

2018-02-22 Thread David Daney
Previous patch sets USE_ASYNC_IOBDMA to 1 unconditionally. Remove USE_ASYNC_IOBDMA from all if statements. Remove dead code caused by the change. Acked-by: Greg Kroah-Hartman Signed-off-by: David Daney --- drivers/staging/octeon/ethernet-defines.h | 6 --- drivers/staging/octeon/ethernet-rx.

[PATCH v8 1/4] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2018-02-22 Thread David Daney
From: Carlos Munoz LMTDMA/LMTST operations move data between cores and I/O devices: * LMTST operations can send an address and a variable length (up to 128 bytes) of data to an I/O device. * LMTDMA operations can send an address and a variable length (up to 128) of data to the I/O device and

[PATCH v8 0/4] Prerequisites for Cavium OCTEON-III network driver.

2018-02-22 Thread David Daney
We want to add the Cavium OCTEON-III network driver. But since interacting with the input and output queues is done via special CPU local memory, we also need to add support to the MIPS/Octeon architecture code. Aren't SoCs nice in this way? These are the prerequisite patches that are needed bef

[PATCH v8 2/4] MIPS: Octeon: Automatically provision CVMSEG space.

2018-02-22 Thread David Daney
Remove CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE and automatically calculate the amount of CVMSEG space needed. 1st 128-bytes: Use by IOBDMA 2nd 128-bytes: Reserved by kernel for scratch/TLS emulation. 3rd 128-bytes: OCTEON-III LMTLINE New config variable CONFIG_CAVIUM_OCTEON_EXTRA_CVMSEG provisions addit

[PATCH v8 4/4] MIPS: Octeon: Add a global resource manager.

2018-02-22 Thread David Daney
From: Carlos Munoz Add a global resource manager to manage tagged pointers within bootmem allocated memory. This is used by various functional blocks in the Octeon core like the FPA, Ethernet nexus, etc. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney ---

<    1   2   3   4   5   6   7   8   9   10   >