Re: [PATCH v2 09/10] coresight: perf: Remove set_buffer call back

2018-07-24 Thread Mathieu Poirier
On Mon, 23 Jul 2018 at 16:27, Suzuki K Poulose wrote: > > Mathieu, > > On 07/23/2018 07:22 PM, Mathieu Poirier wrote: > > On Fri, 20 Jul 2018 at 03:04, Suzuki K Poulose > > wrote: > >> > >> Mathieu, > >> > >> On 19/07/18 21:36, Mathieu Poirier wrote: > >>> On Tue, Jul 17, 2018 at 06:11:40PM

Re: [PATCH v2 09/10] coresight: perf: Remove set_buffer call back

2018-07-24 Thread Mathieu Poirier
On Mon, 23 Jul 2018 at 16:27, Suzuki K Poulose wrote: > > Mathieu, > > On 07/23/2018 07:22 PM, Mathieu Poirier wrote: > > On Fri, 20 Jul 2018 at 03:04, Suzuki K Poulose > > wrote: > >> > >> Mathieu, > >> > >> On 19/07/18 21:36, Mathieu Poirier wrote: > >>> On Tue, Jul 17, 2018 at 06:11:40PM

Re: [PATCH 20/20] signal: Don't restart fork when signals come in.

2018-07-24 Thread Eric W. Biederman
Linus Torvalds writes: > On Tue, Jul 24, 2018 at 10:58 AM Eric W. Biederman > wrote: >> >> Yes you are quite right. Easy enough to fix, but it definitely needs >> to be fixed. >> >> I will respin. > > Would you mind trying a slightly different approach for this? > > How about moving the

Re: [PATCH 20/20] signal: Don't restart fork when signals come in.

2018-07-24 Thread Eric W. Biederman
Linus Torvalds writes: > On Tue, Jul 24, 2018 at 10:58 AM Eric W. Biederman > wrote: >> >> Yes you are quite right. Easy enough to fix, but it definitely needs >> to be fixed. >> >> I will respin. > > Would you mind trying a slightly different approach for this? > > How about moving the

Re: [PATCH] dt-bindings: thermal: samsung: Add SPDX license identifier

2018-07-24 Thread Krzysztof Kozlowski
On Tue, Jul 24, 2018 at 06:46:35PM +0200, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Wednesday, July 18, 2018 10:02:50 PM Krzysztof Kozlowski wrote: > > Replace GPL license statement with SPDX license identifier (GPL-2.0+). > > > > Signed-off-by: Krzysztof Kozlowski > > --- > >

Re: [PATCH] dt-bindings: thermal: samsung: Add SPDX license identifier

2018-07-24 Thread Krzysztof Kozlowski
On Tue, Jul 24, 2018 at 06:46:35PM +0200, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Wednesday, July 18, 2018 10:02:50 PM Krzysztof Kozlowski wrote: > > Replace GPL license statement with SPDX license identifier (GPL-2.0+). > > > > Signed-off-by: Krzysztof Kozlowski > > --- > >

Re: [PATCHv3 1/3] mm: Introduce vma_init()

2018-07-24 Thread Andrew Morton
On Tue, 24 Jul 2018 15:11:37 +0300 "Kirill A. Shutemov" wrote: > Not all VMAs allocated with vm_area_alloc(). Some of them allocated on > stack or in data segment. > > The new helper can be use to initialize VMA properly regardless where > it was allocated. > > ... > > ---

Re: [PATCHv3 1/3] mm: Introduce vma_init()

2018-07-24 Thread Andrew Morton
On Tue, 24 Jul 2018 15:11:37 +0300 "Kirill A. Shutemov" wrote: > Not all VMAs allocated with vm_area_alloc(). Some of them allocated on > stack or in data segment. > > The new helper can be use to initialize VMA properly regardless where > it was allocated. > > ... > > ---

[PATCH] tracefs: Annotate tracefs_ops with __ro_after_init

2018-07-24 Thread Zubin Mithra
tracefs_ops is initialized inside tracefs_create_instance_dir and not modified after. tracefs_create_instance_dir allows for initialization only once, and is called from create_trace_instances(marked __init), which is called from tracer_init_tracefs(marked __init). Signed-off-by: Zubin Mithra

[PATCH] tracefs: Annotate tracefs_ops with __ro_after_init

2018-07-24 Thread Zubin Mithra
tracefs_ops is initialized inside tracefs_create_instance_dir and not modified after. tracefs_create_instance_dir allows for initialization only once, and is called from create_trace_instances(marked __init), which is called from tracer_init_tracefs(marked __init). Signed-off-by: Zubin Mithra

Re: [PATCH 3/3] tty: Mark goldfish_tty_line_count as const

2018-07-24 Thread Roman Kiryanov
> Then why not just make it a #define? With "const" the diff is smaller. > No need to waste the memory of a variable, right? I believe the compiler will produce the same binary for const and for #define if optimization is enabled.

Re: [PATCH 3/3] tty: Mark goldfish_tty_line_count as const

2018-07-24 Thread Roman Kiryanov
> Then why not just make it a #define? With "const" the diff is smaller. > No need to waste the memory of a variable, right? I believe the compiler will produce the same binary for const and for #define if optimization is enabled.

Re: [PATCH] dt-bindings: pinctrl: samsung: Add SPDX license identifier

2018-07-24 Thread Krzysztof Kozlowski
On Wed, Jul 18, 2018 at 10:03:50PM +0200, Krzysztof Kozlowski wrote: > Replace GPL license statement with SPDX license identifier (GPL-2.0). > > Signed-off-by: Krzysztof Kozlowski > --- > include/dt-bindings/pinctrl/samsung.h | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-)

Re: [PATCH] dt-bindings: pinctrl: samsung: Add SPDX license identifier

2018-07-24 Thread Krzysztof Kozlowski
On Wed, Jul 18, 2018 at 10:03:50PM +0200, Krzysztof Kozlowski wrote: > Replace GPL license statement with SPDX license identifier (GPL-2.0). > > Signed-off-by: Krzysztof Kozlowski > --- > include/dt-bindings/pinctrl/samsung.h | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-)

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

2018-07-24 Thread Boris Brezillon
On Tue, 24 Jul 2018 12:52:02 -0700 Brian Norris wrote: > > > Or even better: put this hack behind a DT flag, so that one has to > > > admit that their board design is broken before it will even do > > > anything. Proposal: "linux,badly-designed-flash-reset". > > > > I think we can remove the

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

2018-07-24 Thread Boris Brezillon
On Tue, 24 Jul 2018 12:52:02 -0700 Brian Norris wrote: > > > Or even better: put this hack behind a DT flag, so that one has to > > > admit that their board design is broken before it will even do > > > anything. Proposal: "linux,badly-designed-flash-reset". > > > > I think we can remove the

[PATCH] x86/bugs: protect against userspace-userspace spectreRSB

2018-07-24 Thread Jiri Kosina
From: Jiri Kosina The article "Spectre Returns! Speculation Attacks using the Return Stack Buffer" [1] describes two new (sub-)variants of spectrev2-like attack, making use solely of the RSB contents even on CPUs that don't fallback to BTB on RSB underflow (Skylake+). Mitigate

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-24 Thread Andrew Morton
On Tue, 24 Jul 2018 16:17:47 +0200 Michal Hocko wrote: > On Fri 20-07-18 17:09:02, Andrew Morton wrote: > [...] > > - Undocumented return value. > > > > - comment "failed to reap part..." is misleading - sounds like it's > > referring to something which happened in the past, is in fact > >

[PATCH] x86/bugs: protect against userspace-userspace spectreRSB

2018-07-24 Thread Jiri Kosina
From: Jiri Kosina The article "Spectre Returns! Speculation Attacks using the Return Stack Buffer" [1] describes two new (sub-)variants of spectrev2-like attack, making use solely of the RSB contents even on CPUs that don't fallback to BTB on RSB underflow (Skylake+). Mitigate

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-24 Thread Andrew Morton
On Tue, 24 Jul 2018 16:17:47 +0200 Michal Hocko wrote: > On Fri 20-07-18 17:09:02, Andrew Morton wrote: > [...] > > - Undocumented return value. > > > > - comment "failed to reap part..." is misleading - sounds like it's > > referring to something which happened in the past, is in fact > >

Re: [PATCH v3 2/3] PCI: Samsung SM961/PM961 NVMe disable before FLR quirk

2018-07-24 Thread Minwoo Im
Hi Alex, On Tue, 2018-07-24 at 10:14 -0600, Alex Williamson wrote: > The Samsung SM961/PM961 (960 EVO) sometimes fails to return from FLR > with the PCI config space reading back as -1.  A reproducible instance > of this behavior is resolved by clearing the enable bit in the NVMe > configuration

Re: [PATCH v3 2/3] PCI: Samsung SM961/PM961 NVMe disable before FLR quirk

2018-07-24 Thread Minwoo Im
Hi Alex, On Tue, 2018-07-24 at 10:14 -0600, Alex Williamson wrote: > The Samsung SM961/PM961 (960 EVO) sometimes fails to return from FLR > with the PCI config space reading back as -1.  A reproducible instance > of this behavior is resolved by clearing the enable bit in the NVMe > configuration

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

2018-07-24 Thread Brian Norris
Hi Boris, On Tue, Jul 24, 2018 at 01:18:11AM +0200, Boris Brezillon wrote: > On Mon, 23 Jul 2018 15:06:43 -0700 > Brian Norris wrote: > > On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon > > wrote: > > > but it still seems to improve things. Of course, that means the > > > user should try to

Re: [tip:x86/timers] sched/clock: Enable sched clock early

2018-07-24 Thread Guenter Roeck
0 PID: 0 Comm: swapper Not tainted 4.18.0-rc6-next-20180724 #1 Hardware name: ARM Integrator/CP (Device Tree) [] (unwind_backtrace) from [] (show_stack+0x10/0x18) [] (show_stack) from [] (dump_stack+0x18/0x24) [] (dump_stack) from [] (__warn+0xc8/0xf0) [] (__warn) from [] (warn_slowpath_nu

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

2018-07-24 Thread Brian Norris
Hi Boris, On Tue, Jul 24, 2018 at 01:18:11AM +0200, Boris Brezillon wrote: > On Mon, 23 Jul 2018 15:06:43 -0700 > Brian Norris wrote: > > On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon > > wrote: > > > but it still seems to improve things. Of course, that means the > > > user should try to

Re: [tip:x86/timers] sched/clock: Enable sched clock early

2018-07-24 Thread Guenter Roeck
0 PID: 0 Comm: swapper Not tainted 4.18.0-rc6-next-20180724 #1 Hardware name: ARM Integrator/CP (Device Tree) [] (unwind_backtrace) from [] (show_stack+0x10/0x18) [] (show_stack) from [] (dump_stack+0x18/0x24) [] (dump_stack) from [] (__warn+0xc8/0xf0) [] (__warn) from [] (warn_slowpath_nu

Re: [PATCH v6 9/9] x86: jump-labels: use macros instead of inline assembly

2018-07-24 Thread Ingo Molnar
* Nadav Amit wrote: > I’ll look into these issues, but I don’t see the config attached. Sorry - attached now. Thanks, Ingo # # Automatically generated file; DO NOT EDIT. # Linux/x86_64 4.18.0-rc6 Kernel Configuration # # # Compiler: gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 #

Re: [PATCH v6 9/9] x86: jump-labels: use macros instead of inline assembly

2018-07-24 Thread Ingo Molnar
* Nadav Amit wrote: > I’ll look into these issues, but I don’t see the config attached. Sorry - attached now. Thanks, Ingo # # Automatically generated file; DO NOT EDIT. # Linux/x86_64 4.18.0-rc6 Kernel Configuration # # # Compiler: gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 #

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-24 Thread patrickg
K, did significant poking. native_calibrate_cpu is getting precidence no matter what because on SKL server, native_calibrate_tsc is always returning zero (Note that there is a caveat 2 lines down). In native_calibrate_tsc, I'm seeing it always return zero after the `switch

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-24 Thread patrickg
K, did significant poking. native_calibrate_cpu is getting precidence no matter what because on SKL server, native_calibrate_tsc is always returning zero (Note that there is a caveat 2 lines down). In native_calibrate_tsc, I'm seeing it always return zero after the `switch

Re: [RFT v2 06/10] pinctrl: samsung: Write external wakeup interrupt mask

2018-07-24 Thread Krzysztof Kozlowski
On Mon, Jul 23, 2018 at 07:52:58PM +0200, Krzysztof Kozlowski wrote: > The pinctrl driver defines an IRQ chip which handles external wakeup > interrupts, therefore from logical point of view, it is the owner of > external interrupt mask. The register controlling the mask belongs to > Power

Re: [RFT v2 06/10] pinctrl: samsung: Write external wakeup interrupt mask

2018-07-24 Thread Krzysztof Kozlowski
On Mon, Jul 23, 2018 at 07:52:58PM +0200, Krzysztof Kozlowski wrote: > The pinctrl driver defines an IRQ chip which handles external wakeup > interrupts, therefore from logical point of view, it is the owner of > external interrupt mask. The register controlling the mask belongs to > Power

Re: [RFT v2 01/10] pinctrl: samsung: Define suspend and resume callbacks for all banks and SoCs

2018-07-24 Thread Krzysztof Kozlowski
On Mon, Jul 23, 2018 at 07:52:53PM +0200, Krzysztof Kozlowski wrote: > Suspend and resume callbacks in Exynos/S5Pv210 pin controller drivers, > save and restore state of registers. This operations should be done for > all banks which have external interrupts (as denoted by using >

Re: [RFT v2 01/10] pinctrl: samsung: Define suspend and resume callbacks for all banks and SoCs

2018-07-24 Thread Krzysztof Kozlowski
On Mon, Jul 23, 2018 at 07:52:53PM +0200, Krzysztof Kozlowski wrote: > Suspend and resume callbacks in Exynos/S5Pv210 pin controller drivers, > save and restore state of registers. This operations should be done for > all banks which have external interrupts (as denoted by using >

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

2018-07-24 Thread Brian Norris
Hi, On Tue, Jul 24, 2018 at 11:51:49AM +1000, NeilBrown wrote: > On Tue, Jul 24 2018, Boris Brezillon wrote: > > On Tue, 24 Jul 2018 08:46:33 +1000 > > NeilBrown wrote: > >> One possibility that occurred to me when I was exploring this issue is > >> to revert to 3-byte mode whenever 4-byte was

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

2018-07-24 Thread Brian Norris
Hi, On Tue, Jul 24, 2018 at 11:51:49AM +1000, NeilBrown wrote: > On Tue, Jul 24 2018, Boris Brezillon wrote: > > On Tue, 24 Jul 2018 08:46:33 +1000 > > NeilBrown wrote: > >> One possibility that occurred to me when I was exploring this issue is > >> to revert to 3-byte mode whenever 4-byte was

Re: [RFT v2 00/10] pinctrl: samsung: Remove ugly hack for sharing eint_wakeup_mask

2018-07-24 Thread Krzysztof Kozlowski
On Tue, Jul 24, 2018 at 11:18:13AM +0200, Marek Szyprowski wrote: > Hi Krzysztof, > > On 2018-07-23 19:52, Krzysztof Kozlowski wrote: > > Hi All, > > > > Changes since v1 > > > > 1. Add Tomasz's ack. > > 2. Reword description in patch 6/10. > > > > > > Tests > > = > > This is

Re: [RFT v2 00/10] pinctrl: samsung: Remove ugly hack for sharing eint_wakeup_mask

2018-07-24 Thread Krzysztof Kozlowski
On Tue, Jul 24, 2018 at 11:18:13AM +0200, Marek Szyprowski wrote: > Hi Krzysztof, > > On 2018-07-23 19:52, Krzysztof Kozlowski wrote: > > Hi All, > > > > Changes since v1 > > > > 1. Add Tomasz's ack. > > 2. Reword description in patch 6/10. > > > > > > Tests > > = > > This is

Re: [PATCH] delayacct: Fix crash in delayacct_blkio_end() after delayacct init failure

2018-07-24 Thread Tejun Heo
Hello, Andrew. On Tue, Jul 24, 2018 at 12:29:13PM -0700, Andrew Morton wrote: > How did you make this happen, btw? Fault injection, or did a small > GFP_KERNEL allocation fail? We have a group of machines which are pushing memory really hard and this actually triggered in prod on several of

Re: [PATCH] delayacct: Fix crash in delayacct_blkio_end() after delayacct init failure

2018-07-24 Thread Tejun Heo
Hello, Andrew. On Tue, Jul 24, 2018 at 12:29:13PM -0700, Andrew Morton wrote: > How did you make this happen, btw? Fault injection, or did a small > GFP_KERNEL allocation fail? We have a group of machines which are pushing memory really hard and this actually triggered in prod on several of

Re: [PATCH] delayacct: Fix crash in delayacct_blkio_end() after delayacct init failure

2018-07-24 Thread Andrew Morton
On Tue, 24 Jul 2018 10:55:42 -0700 Tejun Heo wrote: > While forking, if delayacct init fails due to memory shortage, it > continues expecting all delayacct users to check task->delays pointer > against NULL before dereferencing it, which all of them used to do. > > c96f5471ce7d ("delayacct:

Re: [PATCH] delayacct: Fix crash in delayacct_blkio_end() after delayacct init failure

2018-07-24 Thread Andrew Morton
On Tue, 24 Jul 2018 10:55:42 -0700 Tejun Heo wrote: > While forking, if delayacct init fails due to memory shortage, it > continues expecting all delayacct users to check task->delays pointer > against NULL before dereferencing it, which all of them used to do. > > c96f5471ce7d ("delayacct:

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-24 Thread David Howells
Casey Schaufler wrote: > >>> (1) Mount topology and reconfiguration change events. > >> With the possibility of unprivileged mounting you're going to have to > >> address access control on events. If root in a user namespace mounts a > >> filesystem you may have a case where the "real" user

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-24 Thread David Howells
Casey Schaufler wrote: > >>> (1) Mount topology and reconfiguration change events. > >> With the possibility of unprivileged mounting you're going to have to > >> address access control on events. If root in a user namespace mounts a > >> filesystem you may have a case where the "real" user

[PATCH v3] locking/rwsem: Exit read lock slowpath if queue empty & no writer

2018-07-24 Thread Waiman Long
It was discovered that a constant stream of readers with occassional writers pounding on a rwsem may cause many of the readers to enter the slowpath unnecessarily thus increasing latency and lowering performance. In the current code, a reader entering the slowpath critical section will

[PATCH v3] locking/rwsem: Exit read lock slowpath if queue empty & no writer

2018-07-24 Thread Waiman Long
It was discovered that a constant stream of readers with occassional writers pounding on a rwsem may cause many of the readers to enter the slowpath unnecessarily thus increasing latency and lowering performance. In the current code, a reader entering the slowpath critical section will

[PATCH v2] EDAC, sb_edac: Add support for systems with segmented PCI buses

2018-07-24 Thread Masayoshi Mizuma
From: Masayoshi Mizuma Currently, sb_edac driver does not support systems which has multi PCI segments. If the driver is loaded to such system, a slab-out-bounds happens [*]. This patch extends sb_edac driver to check whether segment number and bus number matches when deciding how to group

[PATCH v2] EDAC, sb_edac: Add support for systems with segmented PCI buses

2018-07-24 Thread Masayoshi Mizuma
From: Masayoshi Mizuma Currently, sb_edac driver does not support systems which has multi PCI segments. If the driver is loaded to such system, a slab-out-bounds happens [*]. This patch extends sb_edac driver to check whether segment number and bus number matches when deciding how to group

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-24 Thread Casey Schaufler
On 7/24/2018 9:00 AM, David Howells wrote: > Casey Schaufler wrote: > >>> (1) Mount topology and reconfiguration change events. >> With the possibility of unprivileged mounting you're going to have to >> address access control on events. If root in a user namespace mounts a >> filesystem you

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-24 Thread Casey Schaufler
On 7/24/2018 9:00 AM, David Howells wrote: > Casey Schaufler wrote: > >>> (1) Mount topology and reconfiguration change events. >> With the possibility of unprivileged mounting you're going to have to >> address access control on events. If root in a user namespace mounts a >> filesystem you

[PATCH v2 1/3] iio: adc: add support for mcp3911

2018-07-24 Thread Marcus Folkesson
MCP3911 is a dual channel Analog Front End (AFE) containing two synchronous sampling delta-sigma Analog-to-Digital Converters (ADC). Signed-off-by: Marcus Folkesson Signed-off-by: Kent Gustavsson --- Notes: v2: - cleanups and bugfixes (thanks Peter Meerwald-Stadler) - drop

[PATCH v2 1/3] iio: adc: add support for mcp3911

2018-07-24 Thread Marcus Folkesson
MCP3911 is a dual channel Analog Front End (AFE) containing two synchronous sampling delta-sigma Analog-to-Digital Converters (ADC). Signed-off-by: Marcus Folkesson Signed-off-by: Kent Gustavsson --- Notes: v2: - cleanups and bugfixes (thanks Peter Meerwald-Stadler) - drop

[PATCH v2 3/3] MAINTAINERS: Add entry for mcp3911 ADC driver

2018-07-24 Thread Marcus Folkesson
Add an entry for mcp3911 ADC driver and add myself and Kent Gustavsson as maintainers of this driver. Signed-off-by: Marcus Folkesson Signed-off-by: Kent Gustavsson --- Notes: v2: - no changes MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS

Re: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

2018-07-24 Thread Alan Tull
On Tue, Jul 24, 2018 at 9:17 AM, Appana Durga Kedareswara rao wrote: Hi Appana, Another minor thing. > + > +// Let's keep the coding style consistent by not having '***' > +/** > + * Also,

[PATCH v2 3/3] MAINTAINERS: Add entry for mcp3911 ADC driver

2018-07-24 Thread Marcus Folkesson
Add an entry for mcp3911 ADC driver and add myself and Kent Gustavsson as maintainers of this driver. Signed-off-by: Marcus Folkesson Signed-off-by: Kent Gustavsson --- Notes: v2: - no changes MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS

Re: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

2018-07-24 Thread Alan Tull
On Tue, Jul 24, 2018 at 9:17 AM, Appana Durga Kedareswara rao wrote: Hi Appana, Another minor thing. > + > +// Let's keep the coding style consistent by not having '***' > +/** > + * Also,

[PATCH v2 2/3] dt-bindings: iio: adc: add bindings for mcp3911

2018-07-24 Thread Marcus Folkesson
MCP3911 is a dual channel Analog Front End (AFE) containing two synchronous sampling delta-sigma Analog-to-Digital Converters (ADC). Signed-off-by: Marcus Folkesson Signed-off-by: Kent Gustavsson --- Notes: v2: - drop channel width - drop `external_vref` - replace

[PATCH v2 2/3] dt-bindings: iio: adc: add bindings for mcp3911

2018-07-24 Thread Marcus Folkesson
MCP3911 is a dual channel Analog Front End (AFE) containing two synchronous sampling delta-sigma Analog-to-Digital Converters (ADC). Signed-off-by: Marcus Folkesson Signed-off-by: Kent Gustavsson --- Notes: v2: - drop channel width - drop `external_vref` - replace

Re: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

2018-07-24 Thread Alan Tull
On Tue, Jul 24, 2018 at 1:31 PM, Appana Durga Kedareswara Rao wrote: > Hi Moritz, > > Thanks for the review... > > >> Can you please make the commit message such that you have full sentences? >> >> "Add support for readback of FPGA configuration data and registers" of >> example. > >

Re: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

2018-07-24 Thread Alan Tull
On Tue, Jul 24, 2018 at 1:31 PM, Appana Durga Kedareswara Rao wrote: > Hi Moritz, > > Thanks for the review... > > >> Can you please make the commit message such that you have full sentences? >> >> "Add support for readback of FPGA configuration data and registers" of >> example. > >

[PATCH] Input: stop telling users to snail-mail Vojtech

2018-07-24 Thread Dmitry Torokhov
I do not think Vojtech wants snail mail these days, even if the address were correct (I do not know if it is), so let's remove snail-mail instructions from the sources. Signed-off-by: Dmitry Torokhov --- drivers/input/evbug.c | 4

[PATCH] Input: stop telling users to snail-mail Vojtech

2018-07-24 Thread Dmitry Torokhov
I do not think Vojtech wants snail mail these days, even if the address were correct (I do not know if it is), so let's remove snail-mail instructions from the sources. Signed-off-by: Dmitry Torokhov --- drivers/input/evbug.c | 4

Re: [PATCH] EDAC, sb_edac: Fix out of bound in PCI multi segment env

2018-07-24 Thread Masayoshi Mizuma
Hi Tony, Thank you for your review! On 07/24/2018 01:01 PM, Tony Luck wrote: > On Thu, Jul 19, 2018 at 7:07 AM, Masayoshi Mizuma > wrote: >> From: Masayoshi Mizuma >> >> KASAN reported the following slab-out-of-bounds when sb_edac >> module was loaded on Broadwell machine which has two PCI

Re: [PATCH] EDAC, sb_edac: Fix out of bound in PCI multi segment env

2018-07-24 Thread Masayoshi Mizuma
Hi Tony, Thank you for your review! On 07/24/2018 01:01 PM, Tony Luck wrote: > On Thu, Jul 19, 2018 at 7:07 AM, Masayoshi Mizuma > wrote: >> From: Masayoshi Mizuma >> >> KASAN reported the following slab-out-of-bounds when sb_edac >> module was loaded on Broadwell machine which has two PCI

RE: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

2018-07-24 Thread Appana Durga Kedareswara Rao
Hi Moritz, Thanks for the review... > Can you please make the commit message such that you have full sentences? > > "Add support for readback of FPGA configuration data and registers" of > example. Sure will fix in v4. > > > > > Usage: > > Readback of PL configuration registers >

RE: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

2018-07-24 Thread Appana Durga Kedareswara Rao
Hi Moritz, Thanks for the review... > Can you please make the commit message such that you have full sentences? > > "Add support for readback of FPGA configuration data and registers" of > example. Sure will fix in v4. > > > > > Usage: > > Readback of PL configuration registers >

[PATCH v3] mtd/maps: fix solutionengine.c printk format warnings

2018-07-24 Thread Randy Dunlap
From: Randy Dunlap Fix 2 printk format warnings (this driver is currently only used by arch/sh/) by using "%pap" instead of "%lx". Fixes these build warnings: ../drivers/mtd/maps/solutionengine.c: In function 'init_soleng_maps': ../include/linux/kern_levels.h:5:18: warning: format '%lx'

Re: [PATCH 20/20] signal: Don't restart fork when signals come in.

2018-07-24 Thread Linus Torvalds
On Tue, Jul 24, 2018 at 10:58 AM Eric W. Biederman wrote: > > Yes you are quite right. Easy enough to fix, but it definitely needs > to be fixed. > > I will respin. Would you mind trying a slightly different approach for this? How about moving the "copy_signal()" and "copy_sighandler()" cases

Re: [PATCH 20/20] signal: Don't restart fork when signals come in.

2018-07-24 Thread Linus Torvalds
On Tue, Jul 24, 2018 at 10:58 AM Eric W. Biederman wrote: > > Yes you are quite right. Easy enough to fix, but it definitely needs > to be fixed. > > I will respin. Would you mind trying a slightly different approach for this? How about moving the "copy_signal()" and "copy_sighandler()" cases

[PATCH v3] mtd/maps: fix solutionengine.c printk format warnings

2018-07-24 Thread Randy Dunlap
From: Randy Dunlap Fix 2 printk format warnings (this driver is currently only used by arch/sh/) by using "%pap" instead of "%lx". Fixes these build warnings: ../drivers/mtd/maps/solutionengine.c: In function 'init_soleng_maps': ../include/linux/kern_levels.h:5:18: warning: format '%lx'

Re: + mm-proc-pid-smaps_rollup-convert-to-single-value-seq_file.patch added to -mm tree

2018-07-24 Thread Alexey Dobriyan
On Mon, Jul 23, 2018 at 04:55:48PM -0700, a...@linux-foundation.org wrote: > The patch titled > Subject: mm: /proc/pid/smaps_rollup: convert to single value seq_file > has been added to the -mm tree. Its filename is > mm-proc-pid-smaps_rollup-convert-to-single-value-seq_file.patch >

Re: + mm-proc-pid-smaps_rollup-convert-to-single-value-seq_file.patch added to -mm tree

2018-07-24 Thread Alexey Dobriyan
On Mon, Jul 23, 2018 at 04:55:48PM -0700, a...@linux-foundation.org wrote: > The patch titled > Subject: mm: /proc/pid/smaps_rollup: convert to single value seq_file > has been added to the -mm tree. Its filename is > mm-proc-pid-smaps_rollup-convert-to-single-value-seq_file.patch >

[PATCH v2 1/2] cpu/hotplug: Add a cpus_read_trylock() function

2018-07-24 Thread Waiman Long
There are use cases where it can be useful to have a cpus_read_trylock() function to work around circular lock dependency problem involving the cpu_hotplug_lock. Signed-off-by: Waiman Long --- include/linux/cpu.h | 2 ++ kernel/cpu.c| 6 ++ 2 files changed, 8 insertions(+) diff

[PATCH v2 1/2] cpu/hotplug: Add a cpus_read_trylock() function

2018-07-24 Thread Waiman Long
There are use cases where it can be useful to have a cpus_read_trylock() function to work around circular lock dependency problem involving the cpu_hotplug_lock. Signed-off-by: Waiman Long --- include/linux/cpu.h | 2 ++ kernel/cpu.c| 6 ++ 2 files changed, 8 insertions(+) diff

[PATCH v2 2/2] cpufreq: Fix a circular lock dependency problem

2018-07-24 Thread Waiman Long
With lockdep turned on, the following circular lock dependency problem was reported: [ 57.470040] == [ 57.502900] WARNING: possible circular locking dependency detected [ 57.535208] 4.18.0-0.rc3.1.el8+7.x86_64+debug #1 Tainted: G [

[PATCH v2 2/2] cpufreq: Fix a circular lock dependency problem

2018-07-24 Thread Waiman Long
With lockdep turned on, the following circular lock dependency problem was reported: [ 57.470040] == [ 57.502900] WARNING: possible circular locking dependency detected [ 57.535208] 4.18.0-0.rc3.1.el8+7.x86_64+debug #1 Tainted: G [

[PATCH v2 0/2] cpufreq: Fix a circular lock dependency problem

2018-07-24 Thread Waiman Long
v2: - Remove the retry loop in the store method. This patchset works around a circular lock dependency issue in the cpufreq driver reported by lockdep. The two locks involved are the cpu_hotplup_lock and the reference count of a sysfs file. The cpufreq_register_driver() function uses the lock

[PATCH v2 0/2] cpufreq: Fix a circular lock dependency problem

2018-07-24 Thread Waiman Long
v2: - Remove the retry loop in the store method. This patchset works around a circular lock dependency issue in the cpufreq driver reported by lockdep. The two locks involved are the cpu_hotplup_lock and the reference count of a sysfs file. The cpufreq_register_driver() function uses the lock

Re: [PATCH v3 2/2] clk: qcom: Add qspi (Quad SPI) clocks for sdm845

2018-07-24 Thread Doug Anderson
Hi, On Tue, Jul 24, 2018 at 10:45 AM, Douglas Anderson wrote: > Add both the interface and core clock. > > Signed-off-by: Douglas Anderson > (am from https://lore.kernel.org/patchwork/patch/966680/mbox) It's just the day for me being a screwup I guess. :( That line (obviously) doesn't

Re: [PATCH v3 2/2] clk: qcom: Add qspi (Quad SPI) clocks for sdm845

2018-07-24 Thread Doug Anderson
Hi, On Tue, Jul 24, 2018 at 10:45 AM, Douglas Anderson wrote: > Add both the interface and core clock. > > Signed-off-by: Douglas Anderson > (am from https://lore.kernel.org/patchwork/patch/966680/mbox) It's just the day for me being a screwup I guess. :( That line (obviously) doesn't

Re: + mm-proc-pid-smaps-factor-out-mem-stats-gathering.patch added to -mm tree

2018-07-24 Thread Alexey Dobriyan
On Mon, Jul 23, 2018 at 04:55:43PM -0700, a...@linux-foundation.org wrote: > > The patch titled > Subject: mm: /proc/pid/smaps: factor out mem stats gathering > has been added to the -mm tree. Its filename is > mm-proc-pid-smaps-factor-out-mem-stats-gathering.patch Reviewed-by: Alexey

Re: + mm-proc-pid-smaps-factor-out-mem-stats-gathering.patch added to -mm tree

2018-07-24 Thread Alexey Dobriyan
On Mon, Jul 23, 2018 at 04:55:43PM -0700, a...@linux-foundation.org wrote: > > The patch titled > Subject: mm: /proc/pid/smaps: factor out mem stats gathering > has been added to the -mm tree. Its filename is > mm-proc-pid-smaps-factor-out-mem-stats-gathering.patch Reviewed-by: Alexey

Re: [PATCH v2 4/8] NTB: ntb_pingpong: Choose doorbells based on port number

2018-07-24 Thread Logan Gunthorpe
On 24/07/18 12:12 PM, Allen Hubbe wrote: > On Tue, Jul 24, 2018 at 1:37 PM Logan Gunthorpe wrote: >> Not really. Given that we know there are only two peers, we always use >> the other side's doorbell register. You'd only use the nearby doorbell >> register if you wanted to trigger your own

Re: [PATCH v2 4/8] NTB: ntb_pingpong: Choose doorbells based on port number

2018-07-24 Thread Logan Gunthorpe
On 24/07/18 12:12 PM, Allen Hubbe wrote: > On Tue, Jul 24, 2018 at 1:37 PM Logan Gunthorpe wrote: >> Not really. Given that we know there are only two peers, we always use >> the other side's doorbell register. You'd only use the nearby doorbell >> register if you wanted to trigger your own

Re: + mm-proc-pid-maps-remove-is_pid-and-related-wrappers.patch added to -mm tree

2018-07-24 Thread Alexey Dobriyan
On Mon, Jul 23, 2018 at 04:55:40PM -0700, a...@linux-foundation.org wrote: > > The patch titled > Subject: mm: /proc/pid/*maps remove is_pid and related wrappers > has been added to the -mm tree. Its filename is > mm-proc-pid-maps-remove-is_pid-and-related-wrappers.patch Reviewed-by:

Re: + mm-proc-pid-maps-remove-is_pid-and-related-wrappers.patch added to -mm tree

2018-07-24 Thread Alexey Dobriyan
On Mon, Jul 23, 2018 at 04:55:40PM -0700, a...@linux-foundation.org wrote: > > The patch titled > Subject: mm: /proc/pid/*maps remove is_pid and related wrappers > has been added to the -mm tree. Its filename is > mm-proc-pid-maps-remove-is_pid-and-related-wrappers.patch Reviewed-by:

[RFC] PCI: imx: Add multi-pd support

2018-07-24 Thread Leonard Crestez
On some chips the PCIE and PCIE_PHY blocks are in separate power domains which can be power-gated independently. The driver needs to handle this by keeping both domain active. This is intended for imx6sx where PCIE is in DISPMIX and PCIE_PHY in it's own domain. Defining the DISPMIX domain

[RFC] PCI: imx: Add multi-pd support

2018-07-24 Thread Leonard Crestez
On some chips the PCIE and PCIE_PHY blocks are in separate power domains which can be power-gated independently. The driver needs to handle this by keeping both domain active. This is intended for imx6sx where PCIE is in DISPMIX and PCIE_PHY in it's own domain. Defining the DISPMIX domain

RE: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for ZynqMP core

2018-07-24 Thread Jolly Shah
Hi Michal, > -Original Message- > From: Michal Simek [mailto:michal.si...@xilinx.com] > Sent: Thursday, July 19, 2018 3:33 AM > To: Jolly Shah ; ard.biesheu...@linaro.org; > mi...@kernel.org; gre...@linuxfoundation.org; m...@codeblueprint.co.uk; > sudeep.ho...@arm.com;

RE: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for ZynqMP core

2018-07-24 Thread Jolly Shah
Hi Michal, > -Original Message- > From: Michal Simek [mailto:michal.si...@xilinx.com] > Sent: Thursday, July 19, 2018 3:33 AM > To: Jolly Shah ; ard.biesheu...@linaro.org; > mi...@kernel.org; gre...@linuxfoundation.org; m...@codeblueprint.co.uk; > sudeep.ho...@arm.com;

Re: [PATCH v2 4/8] NTB: ntb_pingpong: Choose doorbells based on port number

2018-07-24 Thread Allen Hubbe
On Tue, Jul 24, 2018 at 1:37 PM Logan Gunthorpe wrote: > Not really. Given that we know there are only two peers, we always use > the other side's doorbell register. You'd only use the nearby doorbell > register if you wanted to trigger your own interrupt -- that would be > weird and we don't

Re: [PATCH v2 4/8] NTB: ntb_pingpong: Choose doorbells based on port number

2018-07-24 Thread Allen Hubbe
On Tue, Jul 24, 2018 at 1:37 PM Logan Gunthorpe wrote: > Not really. Given that we know there are only two peers, we always use > the other side's doorbell register. You'd only use the nearby doorbell > register if you wanted to trigger your own interrupt -- that would be > weird and we don't

Re: [PATCH] input: pxrc - do not store USB device in private struct

2018-07-24 Thread Marcus Folkesson
Hello Dmitry, On Tue, Jul 24, 2018 at 02:38:04AM +, Dmitry Torokhov wrote: > Hi Marcus, > > On Mon, Jul 16, 2018 at 04:40:14PM +0200, Marcus Folkesson wrote: > > The USB device is only needed during setup, so put it back after > > initialization and do not store it in our private struct. > >

Re: [PATCH] input: pxrc - do not store USB device in private struct

2018-07-24 Thread Marcus Folkesson
Hello Dmitry, On Tue, Jul 24, 2018 at 02:38:04AM +, Dmitry Torokhov wrote: > Hi Marcus, > > On Mon, Jul 16, 2018 at 04:40:14PM +0200, Marcus Folkesson wrote: > > The USB device is only needed during setup, so put it back after > > initialization and do not store it in our private struct. > >

Re: [PATCH] ARM: dma-mapping: always clear allocated buffers

2018-07-24 Thread Christoph Hellwig
On Tue, Jul 24, 2018 at 10:04:35PM +0800, YueHaibing wrote: > Sean Wang report dma_zalloc_coherent doesn't work as expect on his > armv7,the allocated mem is not zeroed.The reason is __alloc_from_pool > doesn't honor __GFP_ZERO. Please explain the "why" a little more. All the explanations are in

Re: [PATCH] ARM: dma-mapping: always clear allocated buffers

2018-07-24 Thread Christoph Hellwig
On Tue, Jul 24, 2018 at 10:04:35PM +0800, YueHaibing wrote: > Sean Wang report dma_zalloc_coherent doesn't work as expect on his > armv7,the allocated mem is not zeroed.The reason is __alloc_from_pool > doesn't honor __GFP_ZERO. Please explain the "why" a little more. All the explanations are in

Re: VM boot failure on nodes not having DMA32 zone

2018-07-24 Thread Paolo Bonzini
On 24/07/2018 09:53, Liang C wrote: > Hi, > > We have a situation where our qemu processes need to be launched under > cgroup cpuset.mems control. This introduces an similar issue that was > discussed a few years ago. The difference here is that for our case, > not being able to allocate from

Re: VM boot failure on nodes not having DMA32 zone

2018-07-24 Thread Paolo Bonzini
On 24/07/2018 09:53, Liang C wrote: > Hi, > > We have a situation where our qemu processes need to be launched under > cgroup cpuset.mems control. This introduces an similar issue that was > discussed a few years ago. The difference here is that for our case, > not being able to allocate from

Re: [PATCH v6 1/9] Makefile: Prepare for using macros for inline asm

2018-07-24 Thread Nadav Amit
at 4:14 AM, Ingo Molnar wrote: > > * Masahiro Yamada wrote: > >> 2018-06-23 2:22 GMT+09:00 Nadav Amit : >>> Using macros for inline assembly improves both readability and >>> compilation decisions that are distorted by big assembly blocks that use >>> alternative sections. Compile macros.S

Re: [PATCH v6 1/9] Makefile: Prepare for using macros for inline asm

2018-07-24 Thread Nadav Amit
at 4:14 AM, Ingo Molnar wrote: > > * Masahiro Yamada wrote: > >> 2018-06-23 2:22 GMT+09:00 Nadav Amit : >>> Using macros for inline assembly improves both readability and >>> compilation decisions that are distorted by big assembly blocks that use >>> alternative sections. Compile macros.S

<    1   2   3   4   5   6   7   8   9   10   >