Re: [PATCH v1 09/10] Input: atmel_mxt_ts - tool type is ignored when slot is closed

2018-07-25 Thread Dmitry Torokhov
On Wed, Jul 25, 2018 at 03:26:41PM +1000, Peter Hutterer wrote: > On Tue, Jul 24, 2018 at 10:23:27AM +0200, Benjamin Tissoires wrote: > > On Tue, Jul 24, 2018 at 12:34 AM Dmitry Torokhov > > wrote: > > > > > > On Fri, Jul 20, 2018 at 10:51:21PM +0100, Nick Dyer wrote: > > > > From: Nick Dyer > >

Re: [PATCH v1 09/10] Input: atmel_mxt_ts - tool type is ignored when slot is closed

2018-07-25 Thread Dmitry Torokhov
On Wed, Jul 25, 2018 at 03:26:41PM +1000, Peter Hutterer wrote: > On Tue, Jul 24, 2018 at 10:23:27AM +0200, Benjamin Tissoires wrote: > > On Tue, Jul 24, 2018 at 12:34 AM Dmitry Torokhov > > wrote: > > > > > > On Fri, Jul 20, 2018 at 10:51:21PM +0100, Nick Dyer wrote: > > > > From: Nick Dyer > >

Re: [PATCH v5 1/3] thermal: qcom-spmi: Use PMIC thermal stage 2 for critical trip points

2018-07-25 Thread Doug Anderson
Hi, On Tue, Jul 24, 2018 at 4:46 PM, Matthias Kaehlcke wrote: > +static int qpnp_tm_update_critical_trip_temp(struct qpnp_tm_chip *chip, > +int temp) > +{ > + u8 reg; > + bool disable_s2_shutdown = false; > + int ret; > + > +

Re: [PATCH v5 1/3] thermal: qcom-spmi: Use PMIC thermal stage 2 for critical trip points

2018-07-25 Thread Doug Anderson
Hi, On Tue, Jul 24, 2018 at 4:46 PM, Matthias Kaehlcke wrote: > +static int qpnp_tm_update_critical_trip_temp(struct qpnp_tm_chip *chip, > +int temp) > +{ > + u8 reg; > + bool disable_s2_shutdown = false; > + int ret; > + > +

Re: linux-next: build failure after merge of the akpm-current tree

2018-07-25 Thread Omar Sandoval
On Mon, Jul 23, 2018 at 07:42:31PM +1000, Stephen Rothwell wrote: > Hi Andrew, > > After merging the akpm tree, today's linux-next build (sparc (32 bit) > defconfig) failed like this: > > In file included from kernel/crash_core.c:9:0: > kernel/crash_core.c: In function

Re: linux-next: build failure after merge of the akpm-current tree

2018-07-25 Thread Omar Sandoval
On Mon, Jul 23, 2018 at 07:42:31PM +1000, Stephen Rothwell wrote: > Hi Andrew, > > After merging the akpm tree, today's linux-next build (sparc (32 bit) > defconfig) failed like this: > > In file included from kernel/crash_core.c:9:0: > kernel/crash_core.c: In function

[PATCH v1] checkpatch: check for #if 0/#if 1

2018-07-25 Thread Prakruthi Deepak Heragu
The #if 0 or #if 1 is used to toggle features. Warn if #if 0 or #if 1 is present and suggest that they can be removed. Signed-off-by: Abhijeet Dharmapurikar Signed-off-by: Prakruthi Deepak Heragu --- Changes in v1: - Rephrase the warning message to fit in a single line without 80 column

[PATCH v1] checkpatch: check for #if 0/#if 1

2018-07-25 Thread Prakruthi Deepak Heragu
The #if 0 or #if 1 is used to toggle features. Warn if #if 0 or #if 1 is present and suggest that they can be removed. Signed-off-by: Abhijeet Dharmapurikar Signed-off-by: Prakruthi Deepak Heragu --- Changes in v1: - Rephrase the warning message to fit in a single line without 80 column

Re: [PATCH] x86/bugs: protect against userspace-userspace spectreRSB

2018-07-25 Thread Jiri Kosina
On Wed, 25 Jul 2018, Linus Torvalds wrote: > > Mitigate userspace-userspace attacks by always unconditionally filling RSB > > on > > context switch when generic spectrev2 mitigation has been enabled. > > Shouldn't this also do something like > > x86_spec_ctrl_base |= x86_spec_ctrl_mask &

Re: [PATCH] x86/bugs: protect against userspace-userspace spectreRSB

2018-07-25 Thread Jiri Kosina
On Wed, 25 Jul 2018, Linus Torvalds wrote: > > Mitigate userspace-userspace attacks by always unconditionally filling RSB > > on > > context switch when generic spectrev2 mitigation has been enabled. > > Shouldn't this also do something like > > x86_spec_ctrl_base |= x86_spec_ctrl_mask &

[PATCH] PCI: Equalize hotplug memory for non/occupied slots

2018-07-25 Thread Jon Derrick
Currently, a hotplug bridge will be given hpmemsize additional memory if available, in order to satisfy any future hotplug allocation requirements. These calculations don't consider the current memory size of the hotplug bridge/slot, so hotplug bridges/slots which have downstream devices will get

[PATCH] PCI: Equalize hotplug memory for non/occupied slots

2018-07-25 Thread Jon Derrick
Currently, a hotplug bridge will be given hpmemsize additional memory if available, in order to satisfy any future hotplug allocation requirements. These calculations don't consider the current memory size of the hotplug bridge/slot, so hotplug bridges/slots which have downstream devices will get

Re: [PATCH v1 2/3] thermal: tsens: switch from of_iomap() to devm_ioremap_resource()

2018-07-25 Thread Matthias Kaehlcke
On Wed, Jul 18, 2018 at 12:55:02PM +0530, Amit Kucheria wrote: > devm_ioremap_resources() automatically requests resources (so that the I/O > region shows up in /proc/iomem) and devm_ wrappers do better error handling > and unmapping of the I/O region when needed. > > Signed-off-by: Amit Kucheria

Re: [PATCH v1 2/3] thermal: tsens: switch from of_iomap() to devm_ioremap_resource()

2018-07-25 Thread Matthias Kaehlcke
On Wed, Jul 18, 2018 at 12:55:02PM +0530, Amit Kucheria wrote: > devm_ioremap_resources() automatically requests resources (so that the I/O > region shows up in /proc/iomem) and devm_ wrappers do better error handling > and unmapping of the I/O region when needed. > > Signed-off-by: Amit Kucheria

Re: [PATCH] tracing: Fix double free of event_trigger_data

2018-07-25 Thread Masami Hiramatsu
On Wed, 25 Jul 2018 15:53:21 -0400 Steven Rostedt wrote: > On Wed, 25 Jul 2018 15:29:04 -0400 > Steven Rostedt wrote: > > > Nope, this doesn't work. It's a little more complex than the other one. > > I'll just leave it, and fix the reg code for 4.19. > > I take this back. Looks like it just

Re: [PATCH] tracing: Fix double free of event_trigger_data

2018-07-25 Thread Masami Hiramatsu
On Wed, 25 Jul 2018 15:53:21 -0400 Steven Rostedt wrote: > On Wed, 25 Jul 2018 15:29:04 -0400 > Steven Rostedt wrote: > > > Nope, this doesn't work. It's a little more complex than the other one. > > I'll just leave it, and fix the reg code for 4.19. > > I take this back. Looks like it just

Re: [PATCH v1 1/3] thermal: tsens: Rename variable

2018-07-25 Thread Matthias Kaehlcke
On Wed, Jul 18, 2018 at 12:55:01PM +0530, Amit Kucheria wrote: > We're actually reading the temperature from the status register. Fix the > variable name to reflect that. > > Signed-off-by: Amit Kucheria > --- > drivers/thermal/qcom/tsens-common.c | 6 +++--- > drivers/thermal/qcom/tsens-v2.c

Re: [PATCH v1 1/3] thermal: tsens: Rename variable

2018-07-25 Thread Matthias Kaehlcke
On Wed, Jul 18, 2018 at 12:55:01PM +0530, Amit Kucheria wrote: > We're actually reading the temperature from the status register. Fix the > variable name to reflect that. > > Signed-off-by: Amit Kucheria > --- > drivers/thermal/qcom/tsens-common.c | 6 +++--- > drivers/thermal/qcom/tsens-v2.c

Re: [PATCH 1/1] rpmsg: virtio_rpmsg_bus: Fix rpmsg_create_channel memory leak

2018-07-25 Thread Suman Anna
Hi Loic, On 07/25/2018 04:08 PM, Loic Pallardy wrote: > In case of rpmsg_register_device() failure, vch previously > allocated must be free. > Isn't this already handled through the virtio_rpmsg_release_device() callback as part of the put_device() in rpmsg_register_device() failure. regards

Re: [PATCH 1/1] rpmsg: virtio_rpmsg_bus: Fix rpmsg_create_channel memory leak

2018-07-25 Thread Suman Anna
Hi Loic, On 07/25/2018 04:08 PM, Loic Pallardy wrote: > In case of rpmsg_register_device() failure, vch previously > allocated must be free. > Isn't this already handled through the virtio_rpmsg_release_device() callback as part of the put_device() in rpmsg_register_device() failure. regards

RE: [PATCH] clk: Add functions to get optional clocks

2018-07-25 Thread Stephen Boyd
Quoting Phil Edworthy (2018-07-18 06:56:26) > Hi Russell, > > On 18 July 2018 14:19, Geert Uytterhoeven wrote: > > On Wed, Jul 18, 2018 at 3:02 PM Russell King - ARM Linux wrote: > > > On Wed, Jul 18, 2018 at 01:57:38PM +0100, Phil Edworthy wrote: > > > > Behaves the same as (devm_)clk_get

RE: [PATCH] clk: Add functions to get optional clocks

2018-07-25 Thread Stephen Boyd
Quoting Phil Edworthy (2018-07-18 06:56:26) > Hi Russell, > > On 18 July 2018 14:19, Geert Uytterhoeven wrote: > > On Wed, Jul 18, 2018 at 3:02 PM Russell King - ARM Linux wrote: > > > On Wed, Jul 18, 2018 at 01:57:38PM +0100, Phil Edworthy wrote: > > > > Behaves the same as (devm_)clk_get

Re: [PATCH 1/1] rpmsg: virtio_rpmsg_bus: Fix rpmsg_remove() release order

2018-07-25 Thread Suman Anna
Hi Loic, On 07/25/2018 04:07 PM, Loic Pallardy wrote: > In rpmsg_remove() procedure, children are removed then Name > Service announcement endpoint is destroyed and device released. > > Issue with current implementation is if a NS announcement > creation request is ongoing (received before

Re: [PATCH 1/1] rpmsg: virtio_rpmsg_bus: Fix rpmsg_remove() release order

2018-07-25 Thread Suman Anna
Hi Loic, On 07/25/2018 04:07 PM, Loic Pallardy wrote: > In rpmsg_remove() procedure, children are removed then Name > Service announcement endpoint is destroyed and device released. > > Issue with current implementation is if a NS announcement > creation request is ongoing (received before

[PATCH v2 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-07-25 Thread Stephen Boyd
The interrupt controller hardware in this pin controller has two status enable bits. The first "normal" status enable bit enables or disables the summary interrupt line being raised when a gpio interrupt triggers and the "raw" status enable bit allows or prevents the hardware from latching an

[PATCH v2 3/3] pinctrl: msm: Configure interrupts as input and gpio mode

2018-07-25 Thread Stephen Boyd
When requesting a gpio as an interrupt, we should make sure to mux the pin as the GPIO function and configure it to be an input so that various functions or output signals don't affect the interrupt state of the pin. So far, we've relied on pinmux configurations in DT to handle this, but let's

[PATCH v2 3/3] pinctrl: msm: Configure interrupts as input and gpio mode

2018-07-25 Thread Stephen Boyd
When requesting a gpio as an interrupt, we should make sure to mux the pin as the GPIO function and configure it to be an input so that various functions or output signals don't affect the interrupt state of the pin. So far, we've relied on pinmux configurations in DT to handle this, but let's

[PATCH v2 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-07-25 Thread Stephen Boyd
The interrupt controller hardware in this pin controller has two status enable bits. The first "normal" status enable bit enables or disables the summary interrupt line being raised when a gpio interrupt triggers and the "raw" status enable bit allows or prevents the hardware from latching an

[PATCH v2 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-07-25 Thread Stephen Boyd
We rely on devices to use pinmuxing configurations in DT to select the GPIO function (function 0) if they're going to use the gpio in GPIO mode. Let's simplify things for driver authors by implementing gpio_request_enable() for this pinctrl driver to mux out the GPIO function when the gpio is use

[PATCH v2 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-07-25 Thread Stephen Boyd
We rely on devices to use pinmuxing configurations in DT to select the GPIO function (function 0) if they're going to use the gpio in GPIO mode. Let's simplify things for driver authors by implementing gpio_request_enable() for this pinctrl driver to mux out the GPIO function when the gpio is use

[PATCH v2 0/3] pinctrl: msm interrupt and muxing fixes

2018-07-25 Thread Stephen Boyd
Here's a collection of pinctrl fixes for the qcom driver that make things a little smoother for DT writers while also fixing a problem seen with level triggered interrupts. The first patch fixes an issue where we always see one extra level triggered interrupt when the interrupt triggers. The

[PATCH v2 0/3] pinctrl: msm interrupt and muxing fixes

2018-07-25 Thread Stephen Boyd
Here's a collection of pinctrl fixes for the qcom driver that make things a little smoother for DT writers while also fixing a problem seen with level triggered interrupts. The first patch fixes an issue where we always see one extra level triggered interrupt when the interrupt triggers. The

Re: [PATCH 5/7] x86/vdso: Add vDSO functions for direct store instructions

2018-07-25 Thread Fenghua Yu
On Mon, Jul 23, 2018 at 10:27:34PM -0700, Andy Lutomirski wrote: > On Mon, Jul 23, 2018 at 8:42 PM, Fenghua Yu wrote: > > On Mon, Jul 23, 2018 at 06:48:00PM -0700, Andy Lutomirski wrote: > >> On 07/23/2018 05:55 AM, Fenghua Yu wrote: > >> >The instructions can be implemented in intrinsic

Re: [PATCH 5/7] x86/vdso: Add vDSO functions for direct store instructions

2018-07-25 Thread Fenghua Yu
On Mon, Jul 23, 2018 at 10:27:34PM -0700, Andy Lutomirski wrote: > On Mon, Jul 23, 2018 at 8:42 PM, Fenghua Yu wrote: > > On Mon, Jul 23, 2018 at 06:48:00PM -0700, Andy Lutomirski wrote: > >> On 07/23/2018 05:55 AM, Fenghua Yu wrote: > >> >The instructions can be implemented in intrinsic

OOM in secondary cgroup leading to networking lose

2018-07-25 Thread Àbéjídé Àyodélé
Hi friends, We observed a sequence of events starting from an OOM in a secondary cgroup which ends up in the bond interface being down for a period of up to 12 seconds. Below is some piece of dmesg about when the bond interface went down: [Wed Jul 25 19:20:45 2018] Call Trace: [Wed Jul 25

[PATCH 03/10] staging:rtl8192u: Rename bit definition ISR_TxBcnOk - Style

2018-07-25 Thread John Whitmore
Rename the bit definition ISR_TxBcnOk to ISR_TX_BCN_OK. This change clears the checkpatch issue with CamelCase naming. The change is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +-

[PATCH 05/10] staging:rtl8192u: Rename ISR_TxBcnErr bit definition - Style

2018-07-25 Thread John Whitmore
Rename the bit definition ISR_TxBcnErr to ISR_TX_BCN_ERR. This change clears the checkpatch issue with CamelCase naming. The change is purely a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +-

[PATCH 03/10] staging:rtl8192u: Rename bit definition ISR_TxBcnOk - Style

2018-07-25 Thread John Whitmore
Rename the bit definition ISR_TxBcnOk to ISR_TX_BCN_OK. This change clears the checkpatch issue with CamelCase naming. The change is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +-

[PATCH 05/10] staging:rtl8192u: Rename ISR_TxBcnErr bit definition - Style

2018-07-25 Thread John Whitmore
Rename the bit definition ISR_TxBcnErr to ISR_TX_BCN_ERR. This change clears the checkpatch issue with CamelCase naming. The change is purely a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +-

OOM in secondary cgroup leading to networking lose

2018-07-25 Thread Àbéjídé Àyodélé
Hi friends, We observed a sequence of events starting from an OOM in a secondary cgroup which ends up in the bond interface being down for a period of up to 12 seconds. Below is some piece of dmesg about when the bond interface went down: [Wed Jul 25 19:20:45 2018] Call Trace: [Wed Jul 25

[PATCH 07/10] staging:rtl8192u: Remove multiple blank lines - Style

2018-07-25 Thread John Whitmore
Remove multiple blank lines, raise a checkpatch issue. This is purely a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.h | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH 08/10] staging:rtl8192u: Correct spelling in comments - style

2018-07-25 Thread John Whitmore
Correct the spelling of a number of comments, which caused a checkpatch issue. This is purely a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 06/10] staging:rtl8192u: Rename ISR_BcnTimerIntr - Style

2018-07-25 Thread John Whitmore
Rename the bit definition ISR_BcnTimerIntr to ISR_BCN_TIMER_INTR. This change clears the checkpatch issue with CamelCase naming. The change is purely a style change and should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +-

[PATCH 07/10] staging:rtl8192u: Remove multiple blank lines - Style

2018-07-25 Thread John Whitmore
Remove multiple blank lines, raise a checkpatch issue. This is purely a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.h | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH 08/10] staging:rtl8192u: Correct spelling in comments - style

2018-07-25 Thread John Whitmore
Correct the spelling of a number of comments, which caused a checkpatch issue. This is purely a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 06/10] staging:rtl8192u: Rename ISR_BcnTimerIntr - Style

2018-07-25 Thread John Whitmore
Rename the bit definition ISR_BcnTimerIntr to ISR_BCN_TIMER_INTR. This change clears the checkpatch issue with CamelCase naming. The change is purely a style change and should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +-

[PATCH 00/10] staging:rtl8192u: Coding style - r819xU_cmdpkt.h

2018-07-25 Thread John Whitmore
This series of patches contain purely simple coding style changes. I considered renaming the struct cmpk_set_cfg_t as it is never actually used. Following its definition however it is used in a #define: #define cmpk_query_cfg_tcmpk_set_cfg_t So whilst the struct cmpk_set_cfg_t

[PATCH 00/10] staging:rtl8192u: Coding style - r819xU_cmdpkt.h

2018-07-25 Thread John Whitmore
This series of patches contain purely simple coding style changes. I considered renaming the struct cmpk_set_cfg_t as it is never actually used. Following its definition however it is used in a #define: #define cmpk_query_cfg_tcmpk_set_cfg_t So whilst the struct cmpk_set_cfg_t

[PATCH 09/10] staging:rtl8192u: Remove typedef of struct cmpk_intr_sta_t - Style

2018-07-25 Thread John Whitmore
Remove the typedef of struct cmpk_intr_sta_t. This clears the checkpatch issue with creating new types in code. The change is purely a coding style change and should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 6 +++---

[PATCH 04/10] staging:rtl8192u: Removed unused CMPK_RX_DBG_MSG_SIZE - Style

2018-07-25 Thread John Whitmore
Remove the unused macro definition CMPK_RX_DBG_MSG_SIZE. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.h | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 10/10] staging:rtl8192u: Remove typedef from struct cmpk_set_cfg_t - Style

2018-07-25 Thread John Whitmore
Remove the typedef from struct cmpk_set_cfg_t. This change clears the checkpatch issue with defining new types. The change is purely a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +-

[PATCH 09/10] staging:rtl8192u: Remove typedef of struct cmpk_intr_sta_t - Style

2018-07-25 Thread John Whitmore
Remove the typedef of struct cmpk_intr_sta_t. This clears the checkpatch issue with creating new types in code. The change is purely a coding style change and should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 6 +++---

[PATCH 04/10] staging:rtl8192u: Removed unused CMPK_RX_DBG_MSG_SIZE - Style

2018-07-25 Thread John Whitmore
Remove the unused macro definition CMPK_RX_DBG_MSG_SIZE. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.h | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 10/10] staging:rtl8192u: Remove typedef from struct cmpk_set_cfg_t - Style

2018-07-25 Thread John Whitmore
Remove the typedef from struct cmpk_set_cfg_t. This change clears the checkpatch issue with defining new types. The change is purely a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +-

[PATCH 02/10] staging:rtl8192u: Remove unused CMPK_TX_SET_CONFIG_SIZE - Style

2018-07-25 Thread John Whitmore
Remove the unused macro CMPK_TX_SET_CONFIG_SIZE. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.h

[PATCH 01/10] staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style

2018-07-25 Thread John Whitmore
Remove the typedef of the structure cmpk_txfb_t. This clears the checkpatch issue with defining new types. This change is purely a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 8

[PATCH 01/10] staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style

2018-07-25 Thread John Whitmore
Remove the typedef of the structure cmpk_txfb_t. This clears the checkpatch issue with defining new types. This change is purely a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 8

[PATCH 02/10] staging:rtl8192u: Remove unused CMPK_TX_SET_CONFIG_SIZE - Style

2018-07-25 Thread John Whitmore
Remove the unused macro CMPK_TX_SET_CONFIG_SIZE. This is a coding style change which should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_cmdpkt.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.h

Re: [PATCH v2 1/1] remoteproc: correct rproc_free_vring() to avoid invalid kernel paging

2018-07-25 Thread Suman Anna
Hi Loic, On 07/06/2018 02:46 AM, Loic Pallardy wrote: > If rproc_start() failed, rproc_resource_cleanup() is called to clean > debugfs entries, then associated iommu mappings, carveouts and vdev. > Issue occurs when rproc_free_vring() is trying to reset vring resource > table entry. > At this

Re: [PATCH v2 1/1] remoteproc: correct rproc_free_vring() to avoid invalid kernel paging

2018-07-25 Thread Suman Anna
Hi Loic, On 07/06/2018 02:46 AM, Loic Pallardy wrote: > If rproc_start() failed, rproc_resource_cleanup() is called to clean > debugfs entries, then associated iommu mappings, carveouts and vdev. > Issue occurs when rproc_free_vring() is trying to reset vring resource > table entry. > At this

Re: [PATCH 10/14] arm64: dts: meson-axg: add linein codec

2018-07-25 Thread jbrunet
On Wed, 2018-07-25 at 21:18 +0200, Martin Blumenstingl wrote: > Hi Jerome, > > On Tue, Jul 24, 2018 at 3:09 PM Jerome Brunet wrote: > > > > Add the es7241 analog to digital converter which is fed by the > > lienin jack of the s400 > > > > Signed-off-by: Jerome Brunet > > --- > >

Re: [PATCH 10/14] arm64: dts: meson-axg: add linein codec

2018-07-25 Thread jbrunet
On Wed, 2018-07-25 at 21:18 +0200, Martin Blumenstingl wrote: > Hi Jerome, > > On Tue, Jul 24, 2018 at 3:09 PM Jerome Brunet wrote: > > > > Add the es7241 analog to digital converter which is fed by the > > lienin jack of the s400 > > > > Signed-off-by: Jerome Brunet > > --- > >

Re: [PATCHv3 0/2] Stackleak for arm64

2018-07-25 Thread Laura Abbott
On 07/25/2018 04:49 AM, Will Deacon wrote: Hi Laura, On Tue, Jul 24, 2018 at 05:38:07PM +0100, Will Deacon wrote: On Fri, Jul 20, 2018 at 02:41:52PM -0700, Laura Abbott wrote: This is the version of stackleak for arm64, hopefully ready for queueing Thanks. I'll push these into linux-next

Re: [PATCHv3 0/2] Stackleak for arm64

2018-07-25 Thread Laura Abbott
On 07/25/2018 04:49 AM, Will Deacon wrote: Hi Laura, On Tue, Jul 24, 2018 at 05:38:07PM +0100, Will Deacon wrote: On Fri, Jul 20, 2018 at 02:41:52PM -0700, Laura Abbott wrote: This is the version of stackleak for arm64, hopefully ready for queueing Thanks. I'll push these into linux-next

[PATCH v3 2/5] mm: access zone->node via zone_to_nid() and zone_set_nid()

2018-07-25 Thread osalvador
From: Pavel Tatashin zone->node is configured only when CONFIG_NUMA=y, so it is a good idea to have inline functions to access this field in order to avoid ifdef's in c files. Signed-off-by: Pavel Tatashin Signed-off-by: Oscar Salvador Reviewed-by: Oscar Salvador --- include/linux/mm.h

[PATCH v3 5/5] mm/page_alloc: Introduce memhotplug version of free_area_init_core

2018-07-25 Thread osalvador
From: Oscar Salvador Currently, we call free_area_init_node() from the memhotplug path. In there, we set some pgdat's fields, and call calculate_node_totalpages(). calculate_node_totalpages() calculates the # of pages the node has. Since the node is either new, or we are re-using it, the zones

[PATCH v3 1/5] mm/page_alloc: Move ifdefery out of free_area_init_core

2018-07-25 Thread osalvador
From: Oscar Salvador Moving the #ifdefs out of the function makes it easier to follow. Signed-off-by: Oscar Salvador Acked-by: Michal Hocko Reviewed-by: Pavel Tatashin --- mm/page_alloc.c | 50 +- 1 file changed, 37 insertions(+), 13

[PATCH v3 2/5] mm: access zone->node via zone_to_nid() and zone_set_nid()

2018-07-25 Thread osalvador
From: Pavel Tatashin zone->node is configured only when CONFIG_NUMA=y, so it is a good idea to have inline functions to access this field in order to avoid ifdef's in c files. Signed-off-by: Pavel Tatashin Signed-off-by: Oscar Salvador Reviewed-by: Oscar Salvador --- include/linux/mm.h

[PATCH v3 5/5] mm/page_alloc: Introduce memhotplug version of free_area_init_core

2018-07-25 Thread osalvador
From: Oscar Salvador Currently, we call free_area_init_node() from the memhotplug path. In there, we set some pgdat's fields, and call calculate_node_totalpages(). calculate_node_totalpages() calculates the # of pages the node has. Since the node is either new, or we are re-using it, the zones

[PATCH v3 1/5] mm/page_alloc: Move ifdefery out of free_area_init_core

2018-07-25 Thread osalvador
From: Oscar Salvador Moving the #ifdefs out of the function makes it easier to follow. Signed-off-by: Oscar Salvador Acked-by: Michal Hocko Reviewed-by: Pavel Tatashin --- mm/page_alloc.c | 50 +- 1 file changed, 37 insertions(+), 13

[PATCH v3 0/5] Refactor free_area_init_core and add free_area_init_core_hotplug

2018-07-25 Thread osalvador
From: Oscar Salvador This patchset does three things: 1) Clean ups/refactor free_area_init_core/free_area_init_node by moving the ifdefery out of the functions. 2) Move the pgdat/zone initialization in free_area_init_core to its own function. 3) Introduce free_area_init_core_hotplug,

[PATCH v3 4/5] mm/page_alloc: Move initialization of node and zones to an own function

2018-07-25 Thread osalvador
From: Oscar Salvador Currently, whenever a new node is created/re-used from the memhotplug path, we call free_area_init_node()->free_area_init_core(). But there is some code that we do not really need to run when we are coming from such path. free_area_init_core() performs the following

[PATCH v3 0/5] Refactor free_area_init_core and add free_area_init_core_hotplug

2018-07-25 Thread osalvador
From: Oscar Salvador This patchset does three things: 1) Clean ups/refactor free_area_init_core/free_area_init_node by moving the ifdefery out of the functions. 2) Move the pgdat/zone initialization in free_area_init_core to its own function. 3) Introduce free_area_init_core_hotplug,

[PATCH v3 4/5] mm/page_alloc: Move initialization of node and zones to an own function

2018-07-25 Thread osalvador
From: Oscar Salvador Currently, whenever a new node is created/re-used from the memhotplug path, we call free_area_init_node()->free_area_init_core(). But there is some code that we do not really need to run when we are coming from such path. free_area_init_core() performs the following

Re: [PATCH] serial: core: stop passing NULL in uart_resume_port

2018-07-25 Thread Andy Shevchenko
On Wed, Jul 25, 2018 at 1:04 PM, Chen Hu wrote: > We found the baud rate is changed after S3 on some Intel Broxton > platforms. The baud rate should be restored during resume. However, some > set_termios() callback such as dw8250_set_termios() for DesignWare 8250 > will skip setting if old

[PATCH v3 3/5] mm/page_alloc: Inline function to handle CONFIG_DEFERRED_STRUCT_PAGE_INIT

2018-07-25 Thread osalvador
From: Oscar Salvador Let us move the code between CONFIG_DEFERRED_STRUCT_PAGE_INIT to an inline function. Not having an ifdef in the function makes the code more readable. Signed-off-by: Oscar Salvador Acked-by: Michal Hocko --- mm/page_alloc.c | 25 - 1 file changed,

Re: [PATCH] serial: core: stop passing NULL in uart_resume_port

2018-07-25 Thread Andy Shevchenko
On Wed, Jul 25, 2018 at 1:04 PM, Chen Hu wrote: > We found the baud rate is changed after S3 on some Intel Broxton > platforms. The baud rate should be restored during resume. However, some > set_termios() callback such as dw8250_set_termios() for DesignWare 8250 > will skip setting if old

[PATCH v3 3/5] mm/page_alloc: Inline function to handle CONFIG_DEFERRED_STRUCT_PAGE_INIT

2018-07-25 Thread osalvador
From: Oscar Salvador Let us move the code between CONFIG_DEFERRED_STRUCT_PAGE_INIT to an inline function. Not having an ifdef in the function makes the code more readable. Signed-off-by: Oscar Salvador Acked-by: Michal Hocko --- mm/page_alloc.c | 25 - 1 file changed,

Re: [PATCH v1 1/4] igb: Remove unnecessary include of

2018-07-25 Thread Jeff Kirsher
On Wed, 2018-07-25 at 14:52 -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > The igb driver doesn't need anything provided by pci-aspm.h, so > remove > the unnecessary include of it. > > Signed-off-by: Bjorn Helgaas Acked-by: Jeff Kirsher I am fine with you picking up this change. >

Re: [PATCH v1 1/4] igb: Remove unnecessary include of

2018-07-25 Thread Jeff Kirsher
On Wed, 2018-07-25 at 14:52 -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > The igb driver doesn't need anything provided by pci-aspm.h, so > remove > the unnecessary include of it. > > Signed-off-by: Bjorn Helgaas Acked-by: Jeff Kirsher I am fine with you picking up this change. >

Re: [PATCH 1/6] RISC-V: simplify software interrupt / IPI code

2018-07-25 Thread Palmer Dabbelt
On Wed, 25 Jul 2018 02:36:44 PDT (-0700), Christoph Hellwig wrote: Rename handle_ipi to riscv_software_interrupt, drop the unused return value and provide a stub for the !SMP build. This allows simplifying the upcoming interrupt controller driver by not providing a wrapper for it.

Re: [PATCH 2/6] RISC-V: remove INTERRUPT_CAUSE_* defines from asm/irq.h

2018-07-25 Thread Palmer Dabbelt
On Wed, 25 Jul 2018 02:36:45 PDT (-0700), Christoph Hellwig wrote: These are only of use to the local irq controller driver, so add them in that driver implementation instead, which will be submitted soon. Signed-off-by: Christoph Hellwig --- arch/riscv/include/asm/irq.h | 4 1 file

Re: [PATCH 1/6] RISC-V: simplify software interrupt / IPI code

2018-07-25 Thread Palmer Dabbelt
On Wed, 25 Jul 2018 02:36:44 PDT (-0700), Christoph Hellwig wrote: Rename handle_ipi to riscv_software_interrupt, drop the unused return value and provide a stub for the !SMP build. This allows simplifying the upcoming interrupt controller driver by not providing a wrapper for it.

Re: [PATCH 2/6] RISC-V: remove INTERRUPT_CAUSE_* defines from asm/irq.h

2018-07-25 Thread Palmer Dabbelt
On Wed, 25 Jul 2018 02:36:45 PDT (-0700), Christoph Hellwig wrote: These are only of use to the local irq controller driver, so add them in that driver implementation instead, which will be submitted soon. Signed-off-by: Christoph Hellwig --- arch/riscv/include/asm/irq.h | 4 1 file

Re: [PATCH v2 0/6] kaddr and pfn can be NULL to ->direct_access()

2018-07-25 Thread Dave Jiang
Pretty straight forward series. Huaisheng, I can apply the whole series to libnvdimm if we can get ack's from maintainer of dcssblk and dm-writecache for the respective bits. On 07/25/2018 09:28 AM, Huaisheng Ye wrote: > From: Huaisheng Ye > > Changes since v1 [1]: > * Involve the previous

Re: [PATCH v2 0/6] kaddr and pfn can be NULL to ->direct_access()

2018-07-25 Thread Dave Jiang
Pretty straight forward series. Huaisheng, I can apply the whole series to libnvdimm if we can get ack's from maintainer of dcssblk and dm-writecache for the respective bits. On 07/25/2018 09:28 AM, Huaisheng Ye wrote: > From: Huaisheng Ye > > Changes since v1 [1]: > * Involve the previous

Re: [PATCH -next] fs/epoll: simply CONFIG_NET_RX_BUSY_POLL ifdefery

2018-07-25 Thread Andrew Morton
On Wed, 25 Jul 2018 13:06:33 -0700 Davidlohr Bueso wrote: > >> +#else > >> +#define ep_busy_loop(ep, nonblock)do { } while (0) > >> +#define ep_reset_busy_poll_napi_id(ep)do { } while (0) > >> +#define ep_set_busy_poll_napi_id(epi) do { } while (0) > >> +

Re: [PATCH -next] fs/epoll: simply CONFIG_NET_RX_BUSY_POLL ifdefery

2018-07-25 Thread Andrew Morton
On Wed, 25 Jul 2018 13:06:33 -0700 Davidlohr Bueso wrote: > >> +#else > >> +#define ep_busy_loop(ep, nonblock)do { } while (0) > >> +#define ep_reset_busy_poll_napi_id(ep)do { } while (0) > >> +#define ep_set_busy_poll_napi_id(epi) do { } while (0) > >> +

Re: [PATCH 2/3] mm: calculate deferred pages after skipping mirrored memory

2018-07-25 Thread Andrew Morton
On Tue, 24 Jul 2018 21:46:25 -0400 Pavel Tatashin wrote: > > > +static inline bool defer_init(int nid, unsigned long pfn, unsigned long > > > end_pfn) > > > { > > > + static unsigned long prev_end_pfn, nr_initialised; > > > > So answer me quick, what happens with a static variable in an

Re: [PATCH 2/3] mm: calculate deferred pages after skipping mirrored memory

2018-07-25 Thread Andrew Morton
On Tue, 24 Jul 2018 21:46:25 -0400 Pavel Tatashin wrote: > > > +static inline bool defer_init(int nid, unsigned long pfn, unsigned long > > > end_pfn) > > > { > > > + static unsigned long prev_end_pfn, nr_initialised; > > > > So answer me quick, what happens with a static variable in an

Re: Droid 4: suspend to RAM?

2018-07-25 Thread Pavel Machek
HI! > > > > I have two big problems with droid 4. #1 is that it lost 2 SMS.. and I > > have no idea why. Second is power consumption -- it seems to be rather > > Depend how do you set the SMS buffering using CNMI if I remember. Modem > has 1024bytes of memory most of the time that can buffer more

Re: Droid 4: suspend to RAM?

2018-07-25 Thread Pavel Machek
HI! > > > > I have two big problems with droid 4. #1 is that it lost 2 SMS.. and I > > have no idea why. Second is power consumption -- it seems to be rather > > Depend how do you set the SMS buffering using CNMI if I remember. Modem > has 1024bytes of memory most of the time that can buffer more

Re: [PATCH v6 4/4] clk: tegra: make sdmmc2 and sdmmc4 as sdmmc clocks

2018-07-25 Thread Stephen Boyd
Quoting Aapo Vienamo (2018-07-12 04:53:02) > From: Peter De-Schrijver > > These clocks have low jitter paths to certain parents. To model these > correctly, use the sdmmc mux divider clock type. > > Signed-off-by: Peter De-Schrijver > Signed-off-by: Aapo Vienamo > Acked-by: Peter De Schrijver

linux-next: Signed-off-by missing for commit in the xarray tree

2018-07-25 Thread Stephen Rothwell
Hi Matthew, Commits 890e537e2b42 ("filesystem-dax: Introduce dax_lock_mapping_entry()") aaf149902c79 ("filesystem-dax: Set page->index") are missing a Signed-off-by from their committers. -- Cheers, Stephen Rothwell pgpa_I_pOTy3F.pgp Description: OpenPGP digital signature

Re: [PATCH v6 4/4] clk: tegra: make sdmmc2 and sdmmc4 as sdmmc clocks

2018-07-25 Thread Stephen Boyd
Quoting Aapo Vienamo (2018-07-12 04:53:02) > From: Peter De-Schrijver > > These clocks have low jitter paths to certain parents. To model these > correctly, use the sdmmc mux divider clock type. > > Signed-off-by: Peter De-Schrijver > Signed-off-by: Aapo Vienamo > Acked-by: Peter De Schrijver

linux-next: Signed-off-by missing for commit in the xarray tree

2018-07-25 Thread Stephen Rothwell
Hi Matthew, Commits 890e537e2b42 ("filesystem-dax: Introduce dax_lock_mapping_entry()") aaf149902c79 ("filesystem-dax: Set page->index") are missing a Signed-off-by from their committers. -- Cheers, Stephen Rothwell pgpa_I_pOTy3F.pgp Description: OpenPGP digital signature

Re: [PATCH v6 3/4] clk: tegra: Add sdmmc mux divider clock

2018-07-25 Thread Stephen Boyd
Quoting Aapo Vienamo (2018-07-12 04:53:01) > From: Peter De-Schrijver > > Add a clock type to model the sdmmc switch divider clocks which have paths > to source clocks bypassing the divider (Low Jitter paths). These > are handled by selecting the lj path when the divider is 1 (ie the > rate is

Re: [PATCH v6 3/4] clk: tegra: Add sdmmc mux divider clock

2018-07-25 Thread Stephen Boyd
Quoting Aapo Vienamo (2018-07-12 04:53:01) > From: Peter De-Schrijver > > Add a clock type to model the sdmmc switch divider clocks which have paths > to source clocks bypassing the divider (Low Jitter paths). These > are handled by selecting the lj path when the divider is 1 (ie the > rate is

Re: [PATCH 00/14] arm64: dts: meson-axg: add audio support

2018-07-25 Thread Martin Blumenstingl
Hi Jerome, On Wed, Jul 25, 2018 at 11:19 PM wrote: > > On Wed, 2018-07-25 at 21:11 +0200, Martin Blumenstingl wrote: > > nit-pick: one patch uses "arm64: dts: meson-axg: s400" in the subject > > while other patches that are touching the s400 board aren't > > if you have to re-send this series:

Re: RISC-V irqchip drivers

2018-07-25 Thread Palmer Dabbelt
On Wed, 25 Jul 2018 02:36:43 PDT (-0700), Christoph Hellwig wrote: The RISC-V ISA mandantes the presence of a simple, per-hart (hardware thread) interrupt controller availiable to supervisor mode. In addition the RISC-V specification contains the definition of a programmable interrupt

<    1   2   3   4   5   6   7   8   9   10   >