Re: possible deadlock in __do_page_fault

2018-09-21 Thread Andrew Morton
On Thu, 20 Sep 2018 19:33:15 -0400 Joel Fernandes wrote: > On Thu, Sep 20, 2018 at 5:12 PM Todd Kjos wrote: > > > > +Joel Fernandes > > > > On Thu, Sep 20, 2018 at 2:11 PM Andrew Morton > > wrote: > > > > > > > > > Thanks. Let's cc the ashmem folks. > > > > > This should be fixed by

Re: possible deadlock in __do_page_fault

2018-09-21 Thread Andrew Morton
On Thu, 20 Sep 2018 19:33:15 -0400 Joel Fernandes wrote: > On Thu, Sep 20, 2018 at 5:12 PM Todd Kjos wrote: > > > > +Joel Fernandes > > > > On Thu, Sep 20, 2018 at 2:11 PM Andrew Morton > > wrote: > > > > > > > > > Thanks. Let's cc the ashmem folks. > > > > > This should be fixed by

Re: Code of Conduct: Let's revamp it.

2018-09-21 Thread Joey Pabalinas
On Fri, Sep 21, 2018 at 07:15:45PM -0400, Theodore Y. Ts'o wrote: > People can decide who they want to respond to, but I'm going to gently > suggest that before people think about responding to a particular > e-mail, that they do a quick check using "git log --author=xy...@example.com" > then

Re: Code of Conduct: Let's revamp it.

2018-09-21 Thread Joey Pabalinas
On Fri, Sep 21, 2018 at 07:15:45PM -0400, Theodore Y. Ts'o wrote: > People can decide who they want to respond to, but I'm going to gently > suggest that before people think about responding to a particular > e-mail, that they do a quick check using "git log --author=xy...@example.com" > then

Re: [PATCH v10 03/26] KVM: s390: refactor crypto initialization

2018-09-21 Thread Tony Krowiak
On 09/12/2018 03:42 PM, Tony Krowiak wrote: From: Tony Krowiak This patch refactors the code that initializes and sets up the crypto configuration for a guest. The following changes are implemented via this patch: 1. Prior to the introduction of AP device virtualization, it was not

Re: [PATCH v10 03/26] KVM: s390: refactor crypto initialization

2018-09-21 Thread Tony Krowiak
On 09/12/2018 03:42 PM, Tony Krowiak wrote: From: Tony Krowiak This patch refactors the code that initializes and sets up the crypto configuration for a guest. The following changes are implemented via this patch: 1. Prior to the introduction of AP device virtualization, it was not

Re: Code of Conduct: Let's revamp it.

2018-09-21 Thread Theodore Y. Ts'o
People can decide who they want to respond to, but I'm going to gently suggest that before people think about responding to a particular e-mail, that they do a quick check using "git log --author=xy...@example.com" then decide how much someone appears to be a member of the community before

Re: Code of Conduct: Let's revamp it.

2018-09-21 Thread Theodore Y. Ts'o
People can decide who they want to respond to, but I'm going to gently suggest that before people think about responding to a particular e-mail, that they do a quick check using "git log --author=xy...@example.com" then decide how much someone appears to be a member of the community before

linux-next: Signed-off-by missing for commit in the mali-dp tree

2018-09-21 Thread Stephen Rothwell
Hi Liviu, Commit fd75f5726f65 ("drm/mali-dp: Implement plane alpha and pixel blend on malidp") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgphJe0NQyFY4.pgp Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the mali-dp tree

2018-09-21 Thread Stephen Rothwell
Hi Liviu, Commit fd75f5726f65 ("drm/mali-dp: Implement plane alpha and pixel blend on malidp") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgphJe0NQyFY4.pgp Description: OpenPGP digital signature

[PATCH] selftests: watchdog: Add gettimeout and get|set pretimeout

2018-09-21 Thread Jerry Hoemann
Add command line arguments to call ioctl WDIOC_GETTIMEOUT, WDIOC_GETPRETIMEOUT and WDIOC_SETPRETIMEOUT. Signed-off-by: Jerry Hoemann --- tools/testing/selftests/watchdog/watchdog-test.c | 30 +++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git

[PATCH] selftests: watchdog: Add gettimeout and get|set pretimeout

2018-09-21 Thread Jerry Hoemann
Add command line arguments to call ioctl WDIOC_GETTIMEOUT, WDIOC_GETPRETIMEOUT and WDIOC_SETPRETIMEOUT. Signed-off-by: Jerry Hoemann --- tools/testing/selftests/watchdog/watchdog-test.c | 30 +++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v4] selftests: membarrier: reorganized test for LTS supportability

2018-09-21 Thread Shuah Khan
On 09/03/2018 01:04 PM, Rafael David Tinoco wrote: > This commit re-organizes membarrier test, solving issues when testing > LTS kernels. Now, the code: > > - always run the same amount of tests (even on older kernels). > - allows each test to succeed, fail or be skipped independently. > -

Re: [PATCH v4] selftests: membarrier: reorganized test for LTS supportability

2018-09-21 Thread Shuah Khan
On 09/03/2018 01:04 PM, Rafael David Tinoco wrote: > This commit re-organizes membarrier test, solving issues when testing > LTS kernels. Now, the code: > > - always run the same amount of tests (even on older kernels). > - allows each test to succeed, fail or be skipped independently. > -

Re: [PATCH 0/8] x86/mm/cpa: Further optimizations

2018-09-21 Thread Dave Hansen
BTW, on all of these: Reviewed-by: Dave Hansen

Re: [PATCH 0/8] x86/mm/cpa: Further optimizations

2018-09-21 Thread Dave Hansen
BTW, on all of these: Reviewed-by: Dave Hansen

[PATCH 0/8] x86/mm/cpa: Further optimizations

2018-09-21 Thread Dave Hansen
On 09/19/2018 01:50 AM, Peter Zijlstra wrote: > Dave, can you have a wee look at the Atom errata thing; this does grow the > amount of code between the page-table update and the TLB flush a bit, but all > that PTI crud we did a while back already made it a non-trivial amount of > code. Oh, were

[PATCH 0/8] x86/mm/cpa: Further optimizations

2018-09-21 Thread Dave Hansen
On 09/19/2018 01:50 AM, Peter Zijlstra wrote: > Dave, can you have a wee look at the Atom errata thing; this does grow the > amount of code between the page-table update and the TLB flush a bit, but all > that PTI crud we did a while back already made it a non-trivial amount of > code. Oh, were

Re: [PATCH v3] membarrier_test: work in progress

2018-09-21 Thread Shuah Khan
Hi Rafael, Thanks for the patch. Comments below. On 09/02/2018 08:12 PM, Rafael David Tinoco wrote: > Shuah, > > This is a draft only. I will remove summary from the top, run checkers, > etc. Im thinking in replacing membarrier_test entirely with this code > (compatible to existing one). Right

Re: [PATCH v3] membarrier_test: work in progress

2018-09-21 Thread Shuah Khan
Hi Rafael, Thanks for the patch. Comments below. On 09/02/2018 08:12 PM, Rafael David Tinoco wrote: > Shuah, > > This is a draft only. I will remove summary from the top, run checkers, > etc. Im thinking in replacing membarrier_test entirely with this code > (compatible to existing one). Right

Re: [PATCH v3] i2c: aspeed: fix invalid clock parameters for very large divisors

2018-09-21 Thread Jae Hyun Yoo
On 9/21/2018 3:34 PM, Brendan Higgins wrote: @@ -142,7 +142,8 @@ struct aspeed_i2c_bus { /* Synchronizes I/O mem access to base. */ spinlock_t lock; struct completion cmd_complete; - u32

Re: [PATCH v3] i2c: aspeed: fix invalid clock parameters for very large divisors

2018-09-21 Thread Jae Hyun Yoo
On 9/21/2018 3:34 PM, Brendan Higgins wrote: @@ -142,7 +142,8 @@ struct aspeed_i2c_bus { /* Synchronizes I/O mem access to base. */ spinlock_t lock; struct completion cmd_complete; - u32

[PATCHv3 6/6] mm/gup: Cache dev_pagemap while pinning pages

2018-09-21 Thread Keith Busch
Pinning pages from ZONE_DEVICE memory needs to check the backing device's live-ness, which is tracked in the device's dev_pagemap metadata. This metadata is stored in a radix tree and looking it up adds measurable software overhead. This patch avoids repeating this relatively costly operation

[PATCHv3 6/6] mm/gup: Cache dev_pagemap while pinning pages

2018-09-21 Thread Keith Busch
Pinning pages from ZONE_DEVICE memory needs to check the backing device's live-ness, which is tracked in the device's dev_pagemap metadata. This metadata is stored in a radix tree and looking it up adds measurable software overhead. This patch avoids repeating this relatively costly operation

[PATCHv3 0/6] mm: faster get user pages

2018-09-21 Thread Keith Busch
Changes since v2: Combine only the output parameters in a struct that need tracking, and squash to just one final kernel patch. Fixed compile bugs for all configs Keith Busch (6): mm/gup_benchmark: Time put_page mm/gup_benchmark: Add additional pinning methods tools/gup_benchmark:

[PATCHv3 0/6] mm: faster get user pages

2018-09-21 Thread Keith Busch
Changes since v2: Combine only the output parameters in a struct that need tracking, and squash to just one final kernel patch. Fixed compile bugs for all configs Keith Busch (6): mm/gup_benchmark: Time put_page mm/gup_benchmark: Add additional pinning methods tools/gup_benchmark:

[PATCHv3 2/6] mm/gup_benchmark: Add additional pinning methods

2018-09-21 Thread Keith Busch
This patch provides new gup benchmark ioctl commands to run different user page pinning methods, get_user_pages_longterm and get_user_pages, in addition to the existing get_user_pages_fast. Cc: Kirill Shutemov Cc: Dave Hansen Cc: Dan Williams Signed-off-by: Keith Busch --- mm/gup_benchmark.c

[PATCHv3 4/6] tools/gup_benchmark: Allow user specified file

2018-09-21 Thread Keith Busch
The gup benchmark by default maps anonymous memory. This patch allows a user to specify a file to map, providing a means to test various file backings, like device and filesystem DAX. Cc: Kirill Shutemov Cc: Dave Hansen Cc: Dan Williams Signed-off-by: Keith Busch ---

[PATCHv3 3/6] tools/gup_benchmark: Fix 'write' flag usage

2018-09-21 Thread Keith Busch
If the '-w' parameter was provided, the benchmark would exit due to a mssing 'break'. Cc: Kirill Shutemov Cc: Dave Hansen Cc: Dan Williams Signed-off-by: Keith Busch --- tools/testing/selftests/vm/gup_benchmark.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCHv3 2/6] mm/gup_benchmark: Add additional pinning methods

2018-09-21 Thread Keith Busch
This patch provides new gup benchmark ioctl commands to run different user page pinning methods, get_user_pages_longterm and get_user_pages, in addition to the existing get_user_pages_fast. Cc: Kirill Shutemov Cc: Dave Hansen Cc: Dan Williams Signed-off-by: Keith Busch --- mm/gup_benchmark.c

[PATCHv3 4/6] tools/gup_benchmark: Allow user specified file

2018-09-21 Thread Keith Busch
The gup benchmark by default maps anonymous memory. This patch allows a user to specify a file to map, providing a means to test various file backings, like device and filesystem DAX. Cc: Kirill Shutemov Cc: Dave Hansen Cc: Dan Williams Signed-off-by: Keith Busch ---

[PATCHv3 3/6] tools/gup_benchmark: Fix 'write' flag usage

2018-09-21 Thread Keith Busch
If the '-w' parameter was provided, the benchmark would exit due to a mssing 'break'. Cc: Kirill Shutemov Cc: Dave Hansen Cc: Dan Williams Signed-off-by: Keith Busch --- tools/testing/selftests/vm/gup_benchmark.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCHv3 5/6] tools/gup_benchmark: Add parameter for hugetlb

2018-09-21 Thread Keith Busch
Cc: Kirill Shutemov Cc: Dave Hansen Cc: Dan Williams Signed-off-by: Keith Busch --- tools/testing/selftests/vm/gup_benchmark.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/vm/gup_benchmark.c b/tools/testing/selftests/vm/gup_benchmark.c index

[PATCHv3 1/6] mm/gup_benchmark: Time put_page

2018-09-21 Thread Keith Busch
We'd like to measure time to unpin user pages, so this adds a second benchmark timer on put_page, separate from get_page. Adding the field will breaks this ioctl ABI, but should be okay since this an in-tree kernel selftest. Cc: Kirill Shutemov Cc: Dave Hansen Cc: Dan Williams Signed-off-by:

[PATCHv3 5/6] tools/gup_benchmark: Add parameter for hugetlb

2018-09-21 Thread Keith Busch
Cc: Kirill Shutemov Cc: Dave Hansen Cc: Dan Williams Signed-off-by: Keith Busch --- tools/testing/selftests/vm/gup_benchmark.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/vm/gup_benchmark.c b/tools/testing/selftests/vm/gup_benchmark.c index

[PATCHv3 1/6] mm/gup_benchmark: Time put_page

2018-09-21 Thread Keith Busch
We'd like to measure time to unpin user pages, so this adds a second benchmark timer on put_page, separate from get_page. Adding the field will breaks this ioctl ABI, but should be okay since this an in-tree kernel selftest. Cc: Kirill Shutemov Cc: Dave Hansen Cc: Dan Williams Signed-off-by:

[PATCH v3] i2c: aspeed: fix invalid clock parameters for very large divisors

2018-09-21 Thread Brendan Higgins
The function that computes clock parameters from divisors did not respect the maximum size of the bitfields that the parameters were written to. This fixes the bug. This bug can be reproduced with (and this fix verified with) the test at: https://kunit-review.googlesource.com/c/linux/+/1035/

[PATCH v3] i2c: aspeed: fix invalid clock parameters for very large divisors

2018-09-21 Thread Brendan Higgins
The function that computes clock parameters from divisors did not respect the maximum size of the bitfields that the parameters were written to. This fixes the bug. This bug can be reproduced with (and this fix verified with) the test at: https://kunit-review.googlesource.com/c/linux/+/1035/

Re: [PATCH v2] i2c: aspeed: fix invalid clock parameters for very large divisors

2018-09-21 Thread Brendan Higgins
On Fri, Sep 21, 2018 at 3:26 PM Jae Hyun Yoo wrote: > > > > + if (base_clk_divisor > ASPEED_I2CD_TIME_BASE_DIVISOR_MASK) { > > + base_clk_divisor = ASPEED_I2CD_TIME_BASE_DIVISOR_MASK; > > + clk_low = clk_high_low_mask; > > + clk_high = clk_high_low_mask; >

Re: [PATCH v2] i2c: aspeed: fix invalid clock parameters for very large divisors

2018-09-21 Thread Brendan Higgins
On Fri, Sep 21, 2018 at 3:26 PM Jae Hyun Yoo wrote: > > > > + if (base_clk_divisor > ASPEED_I2CD_TIME_BASE_DIVISOR_MASK) { > > + base_clk_divisor = ASPEED_I2CD_TIME_BASE_DIVISOR_MASK; > > + clk_low = clk_high_low_mask; > > + clk_high = clk_high_low_mask; >

Re: [PATCH V3 (resend) 4/7] CIFS: Add support for direct I/O write

2018-09-21 Thread Pavel Shilovsky
чт, 20 сент. 2018 г. в 14:22, Long Li : > > From: Long Li > > With direct I/O write, user supplied buffers are pinned to the memory and data > are transferred directly from user buffers to the transport layer. > > Change in v3: add support for kernel AIO > > Signed-off-by: Long Li > --- >

Re: [PATCH] ARM: dts: Add support for Liebherr's BK4 device (vf610 based)

2018-09-21 Thread Stefan Agner
On 21.09.2018 08:27, Lukasz Majewski wrote: > This commit adds DTS support for BK4 device from Liebherr. It > uses vf610 SoC from NXP. > > Signed-off-by: Lukasz Majewski > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/vf610-bk4.dts | 504 >

Re: [PATCH V3 (resend) 4/7] CIFS: Add support for direct I/O write

2018-09-21 Thread Pavel Shilovsky
чт, 20 сент. 2018 г. в 14:22, Long Li : > > From: Long Li > > With direct I/O write, user supplied buffers are pinned to the memory and data > are transferred directly from user buffers to the transport layer. > > Change in v3: add support for kernel AIO > > Signed-off-by: Long Li > --- >

Re: [PATCH] ARM: dts: Add support for Liebherr's BK4 device (vf610 based)

2018-09-21 Thread Stefan Agner
On 21.09.2018 08:27, Lukasz Majewski wrote: > This commit adds DTS support for BK4 device from Liebherr. It > uses vf610 SoC from NXP. > > Signed-off-by: Lukasz Majewski > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/vf610-bk4.dts | 504 >

Re: [PATCH v5 0/6] Move swapper_pg_dir to rodata section.

2018-09-21 Thread James Morse
Hi Jun, On 09/17/2018 05:43 AM, Jun Yao wrote: Version 5 changes: 1. Correct spelling and indentation errors[1]. 2. Update init_mm.pgd by assembly[2]. 3. Simplify set_p?d() by introducing set_swapper_pgd()[3]. 4. Reduce unnecessary tlbi for every write to

Re: [PATCH v5 0/6] Move swapper_pg_dir to rodata section.

2018-09-21 Thread James Morse
Hi Jun, On 09/17/2018 05:43 AM, Jun Yao wrote: Version 5 changes: 1. Correct spelling and indentation errors[1]. 2. Update init_mm.pgd by assembly[2]. 3. Simplify set_p?d() by introducing set_swapper_pgd()[3]. 4. Reduce unnecessary tlbi for every write to

Re: [PATCH v2] i2c: aspeed: fix invalid clock parameters for very large divisors

2018-09-21 Thread Jae Hyun Yoo
Hi, On 9/21/2018 3:10 PM, Brendan Higgins wrote: The function that computes clock parameters from divisors did not respect the maximum size of the bitfields that the parameters were written to. This fixes the bug. This bug can be reproduced with (and this fix verified with) the test at:

Re: [PATCH v2] i2c: aspeed: fix invalid clock parameters for very large divisors

2018-09-21 Thread Jae Hyun Yoo
Hi, On 9/21/2018 3:10 PM, Brendan Higgins wrote: The function that computes clock parameters from divisors did not respect the maximum size of the bitfields that the parameters were written to. This fixes the bug. This bug can be reproduced with (and this fix verified with) the test at:

Re: [PATCH V3 (resend) 3/7] CIFS: Add support for direct I/O read

2018-09-21 Thread Pavel Shilovsky
чт, 20 сент. 2018 г. в 14:22, Long Li : > > From: Long Li > > With direct I/O read, we transfer the data directly from transport layer to > the user data buffer. > > Change in v3: add support for kernel AIO > > Signed-off-by: Long Li > --- > fs/cifs/cifsfs.h | 1 + > fs/cifs/cifsglob.h |

Re: [PATCH V3 (resend) 3/7] CIFS: Add support for direct I/O read

2018-09-21 Thread Pavel Shilovsky
чт, 20 сент. 2018 г. в 14:22, Long Li : > > From: Long Li > > With direct I/O read, we transfer the data directly from transport layer to > the user data buffer. > > Change in v3: add support for kernel AIO > > Signed-off-by: Long Li > --- > fs/cifs/cifsfs.h | 1 + > fs/cifs/cifsglob.h |

Re: [PATCH] i2c: aspeed: fixed invalid clock parameters for very large divisors

2018-09-21 Thread Brendan Higgins
On Fri, Sep 21, 2018 at 10:46 AM Jae Hyun Yoo wrote: > > Hi Brendan, > > nit: > Title in imperative mood. I'd put 'fix' instead of 'fixed'. > > > One minor issue is, 'base_clk_divisor' instead of 'base_clk' could avoid > misreading on this code. > > With that, it looks nice to me. Thanks! > >

Re: [PATCH] i2c: aspeed: fixed invalid clock parameters for very large divisors

2018-09-21 Thread Brendan Higgins
On Fri, Sep 21, 2018 at 10:46 AM Jae Hyun Yoo wrote: > > Hi Brendan, > > nit: > Title in imperative mood. I'd put 'fix' instead of 'fixed'. > > > One minor issue is, 'base_clk_divisor' instead of 'base_clk' could avoid > misreading on this code. > > With that, it looks nice to me. Thanks! > >

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Sat 2018-09-22 00:11:29, Jacek Anaszewski wrote: > On 09/21/2018 11:17 PM, Pavel Machek wrote: > > On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > >> Hi Baolin, > >> > >> On 09/21/2018 05:31 AM, Baolin Wang wrote: > >>> Hi Jacek and Pavel, > >>> > >>> On 11 September 2018 at 10:47, Baolin

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Sat 2018-09-22 00:11:29, Jacek Anaszewski wrote: > On 09/21/2018 11:17 PM, Pavel Machek wrote: > > On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > >> Hi Baolin, > >> > >> On 09/21/2018 05:31 AM, Baolin Wang wrote: > >>> Hi Jacek and Pavel, > >>> > >>> On 11 September 2018 at 10:47, Baolin

Re: Linux 4.19-rc4 released, an apology, and a maintainership note

2018-09-21 Thread Michael Woods
Hi Pavel, and how about if we viewed the new Code of Conduct as about the same thing as BitKeeper was for the development process? You should view the Code of Conduct for what it is, as I referenced previously with real world examples, the evidence shows that it is just a ploy to take control

Re: Linux 4.19-rc4 released, an apology, and a maintainership note

2018-09-21 Thread Michael Woods
Hi Pavel, and how about if we viewed the new Code of Conduct as about the same thing as BitKeeper was for the development process? You should view the Code of Conduct for what it is, as I referenced previously with real world examples, the evidence shows that it is just a ploy to take control

[PATCH] staging: rtlwifi: Use proper enumerated types for Wi-Fi only interface

2018-09-21 Thread Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another. drivers/staging/rtlwifi/btcoexist/halbtcoutsrc.c:1264:34: warning: implicit conversion from enumeration type 'enum btc_chip_interface' to different enumeration type 'enum wifionly_chip_interface' [-Wenum-conversion]

[PATCH] staging: rtlwifi: Use proper enumerated types for Wi-Fi only interface

2018-09-21 Thread Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another. drivers/staging/rtlwifi/btcoexist/halbtcoutsrc.c:1264:34: warning: implicit conversion from enumeration type 'enum btc_chip_interface' to different enumeration type 'enum wifionly_chip_interface' [-Wenum-conversion]

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Jacek Anaszewski
On 09/21/2018 11:17 PM, Pavel Machek wrote: > On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: >> Hi Baolin, >> >> On 09/21/2018 05:31 AM, Baolin Wang wrote: >>> Hi Jacek and Pavel, >>> >>> On 11 September 2018 at 10:47, Baolin Wang wrote: This patch adds one new led trigger that LED

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Jacek Anaszewski
On 09/21/2018 11:17 PM, Pavel Machek wrote: > On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: >> Hi Baolin, >> >> On 09/21/2018 05:31 AM, Baolin Wang wrote: >>> Hi Jacek and Pavel, >>> >>> On 11 September 2018 at 10:47, Baolin Wang wrote: This patch adds one new led trigger that LED

[PATCH v2] i2c: aspeed: fix invalid clock parameters for very large divisors

2018-09-21 Thread Brendan Higgins
The function that computes clock parameters from divisors did not respect the maximum size of the bitfields that the parameters were written to. This fixes the bug. This bug can be reproduced with (and this fix verified with) the test at: https://kunit-review.googlesource.com/c/linux/+/1035/

[PATCH v2] i2c: aspeed: fix invalid clock parameters for very large divisors

2018-09-21 Thread Brendan Higgins
The function that computes clock parameters from divisors did not respect the maximum size of the bitfields that the parameters were written to. This fixes the bug. This bug can be reproduced with (and this fix verified with) the test at: https://kunit-review.googlesource.com/c/linux/+/1035/

Re: [PATCH v6 4/5] seccomp: add support for passing fds via USER_NOTIF

2018-09-21 Thread Tycho Andersen
On Fri, Sep 21, 2018 at 11:27:59AM -0700, Andy Lutomirski wrote: > On Fri, Sep 21, 2018 at 6:39 AM Tycho Andersen wrote: > > > > On Thu, Sep 20, 2018 at 07:18:45PM -0700, Andy Lutomirski wrote: > > > > > > I think we just want the operation to cover all the cases. Let PUT_FD > > > take a source

Re: [PATCH v6 4/5] seccomp: add support for passing fds via USER_NOTIF

2018-09-21 Thread Tycho Andersen
On Fri, Sep 21, 2018 at 11:27:59AM -0700, Andy Lutomirski wrote: > On Fri, Sep 21, 2018 at 6:39 AM Tycho Andersen wrote: > > > > On Thu, Sep 20, 2018 at 07:18:45PM -0700, Andy Lutomirski wrote: > > > > > > I think we just want the operation to cover all the cases. Let PUT_FD > > > take a source

[PATCH] clk: tegra: Return the exact clock rate from clk_round_rate

2018-09-21 Thread ryang
The current behavior is that clk_round_rate would return the same clock rate passed to it for valid PLL configurations. This change will return the exact rate the PLL will provide in accordance with clk API. Signed-off-by: ryang --- drivers/clk/tegra/clk-pll.c | 7 ++- 1 file changed, 6

[PATCH] clk: tegra: Return the exact clock rate from clk_round_rate

2018-09-21 Thread ryang
The current behavior is that clk_round_rate would return the same clock rate passed to it for valid PLL configurations. This change will return the exact rate the PLL will provide in accordance with clk API. Signed-off-by: ryang --- drivers/clk/tegra/clk-pll.c | 7 ++- 1 file changed, 6

[PATCH] clk: tegra: Fix an infinite loop when clock rate is zero

2018-09-21 Thread ryang
Calling clk_set_rate or clk_round_rate will lock up the kernel when the rate is zero. This avoids the infinite loop and uses a slightly more optimized p divider calculation. Signed-off-by: ryang --- drivers/clk/tegra/clk-pll.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

[PATCH] clk: tegra: Fix an infinite loop when clock rate is zero

2018-09-21 Thread ryang
Calling clk_set_rate or clk_round_rate will lock up the kernel when the rate is zero. This avoids the infinite loop and uses a slightly more optimized p divider calculation. Signed-off-by: ryang --- drivers/clk/tegra/clk-pll.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

Re: [PATCH] ARM: BCM63XX: Fix incorrect interrupt specifiers

2018-09-21 Thread Florian Fainelli
On Wed, 19 Sep 2018 17:14:01 -0700, Florian Fainelli wrote: > A number of our interrupts were incorrectly specified, fix both the PPI > and SPI interrupts to be correct. > > Fixes: b5762cacc411 ("ARM: bcm63138: add NAND DT support") > Fixes: 46d4bca0445a ("ARM: BCM63XX: add BCM63138 minimal

Re: [PATCH] ARM: BCM63XX: Fix incorrect interrupt specifiers

2018-09-21 Thread Florian Fainelli
On Wed, 19 Sep 2018 17:14:01 -0700, Florian Fainelli wrote: > A number of our interrupts were incorrectly specified, fix both the PPI > and SPI interrupts to be correct. > > Fixes: b5762cacc411 ("ARM: bcm63138: add NAND DT support") > Fixes: 46d4bca0445a ("ARM: BCM63XX: add BCM63138 minimal

[PATCH] iio: adc: imx25-gcq: Fix leak of device_node in mx25_gcq_setup_cfgs()

2018-09-21 Thread Alexey Khoroshilov
Leaving for_each_child_of_node loop we should release child device node, if it is not stored for future use. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/iio/adc/fsl-imx25-gcq.c | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH] iio: adc: imx25-gcq: Fix leak of device_node in mx25_gcq_setup_cfgs()

2018-09-21 Thread Alexey Khoroshilov
Leaving for_each_child_of_node loop we should release child device node, if it is not stored for future use. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/iio/adc/fsl-imx25-gcq.c | 6 ++ 1 file changed, 6 insertions(+) diff

Re: [PATCH v2, RESEND 2/3] tpm: modify tpm_pcr_read() definition to pass TPM hash algorithms

2018-09-21 Thread Jarkko Sakkinen
On Fri, Sep 21, 2018 at 12:24:15PM +0200, Roberto Sassu wrote: > On 9/17/2018 11:38 AM, Roberto Sassu wrote: > > Currently the TPM driver allows other kernel subsystems to read only the > > SHA1 PCR bank. This patch modifies the parameters of tpm_pcr_read() and > > tpm2_pcr_read() to pass an array

Re: [PATCH v2, RESEND 2/3] tpm: modify tpm_pcr_read() definition to pass TPM hash algorithms

2018-09-21 Thread Jarkko Sakkinen
On Fri, Sep 21, 2018 at 12:24:15PM +0200, Roberto Sassu wrote: > On 9/17/2018 11:38 AM, Roberto Sassu wrote: > > Currently the TPM driver allows other kernel subsystems to read only the > > SHA1 PCR bank. This patch modifies the parameters of tpm_pcr_read() and > > tpm2_pcr_read() to pass an array

Re: [PATCH v2 2/2] x86/cpu: Change query logic so cpuid is enabled before testing

2018-09-21 Thread Andy Lutomirski
On Fri, Sep 21, 2018 at 2:21 PM Matthew Whitehead wrote: > > Presently we check for cpuid to be enabled first. If it is not already > enabled, then we next call identify_cpu_without_cpuid() and clear > X86_FEATURE_CPUID. > > Unfortunately, identify_cpu_without_cpuid() is the function where cpuid

Re: [PATCH v2 2/2] x86/cpu: Change query logic so cpuid is enabled before testing

2018-09-21 Thread Andy Lutomirski
On Fri, Sep 21, 2018 at 2:21 PM Matthew Whitehead wrote: > > Presently we check for cpuid to be enabled first. If it is not already > enabled, then we next call identify_cpu_without_cpuid() and clear > X86_FEATURE_CPUID. > > Unfortunately, identify_cpu_without_cpuid() is the function where cpuid

Re: [PATCH 2/8] x86/mm/cpa: Move flush_tlb_all()

2018-09-21 Thread Dave Hansen
On 09/19/2018 01:50 AM, Peter Zijlstra wrote: > @@ -1528,28 +1538,8 @@ static int __change_page_attr(struct cpa >* We have to split the large page: >*/ > err = split_large_page(cpa, kpte, address); > - if (!err) { ... > - flush_tlb_all(); > + if (!err) >

Re: [PATCH 2/8] x86/mm/cpa: Move flush_tlb_all()

2018-09-21 Thread Dave Hansen
On 09/19/2018 01:50 AM, Peter Zijlstra wrote: > @@ -1528,28 +1538,8 @@ static int __change_page_attr(struct cpa >* We have to split the large page: >*/ > err = split_large_page(cpa, kpte, address); > - if (!err) { ... > - flush_tlb_all(); > + if (!err) >

Re: [PATCH v3 00/28] selftests/ftrace: Improve ftracetest with coverage check

2018-09-21 Thread Shuah Khan
Hi Masami, On 08/30/2018 08:12 AM, Masami Hiramatsu wrote: > Hi, > > Here is the 3rd version of the series for improving ftracetest > testcase using gcov/lcov. In this version I just fixed some > reported issues and dropped some tests which is not needed. > I also dropped a testcase for blktrace

Re: [PATCH v3 00/28] selftests/ftrace: Improve ftracetest with coverage check

2018-09-21 Thread Shuah Khan
Hi Masami, On 08/30/2018 08:12 AM, Masami Hiramatsu wrote: > Hi, > > Here is the 3rd version of the series for improving ftracetest > testcase using gcov/lcov. In this version I just fixed some > reported issues and dropped some tests which is not needed. > I also dropped a testcase for blktrace

[PATCH v2 1/2] x86/cpu: Use correct macros for Cyrix calls

2018-09-21 Thread Matthew Whitehead
There are comments in processor-cyrix.h advising you to _not_ make calls using the deprecated macros in this style: setCx86_old(CX86_CCR4, getCx86_old(CX86_CCR4) | 0x80); This is because it expands the macro into a non-functioning calling sequence. The calling order must be: outb(CX86_CCR2,

[PATCH v2 2/2] x86/cpu: Change query logic so cpuid is enabled before testing

2018-09-21 Thread Matthew Whitehead
Presently we check for cpuid to be enabled first. If it is not already enabled, then we next call identify_cpu_without_cpuid() and clear X86_FEATURE_CPUID. Unfortunately, identify_cpu_without_cpuid() is the function where cpuid becomes _enabled_ on Cyrix 6x86/6x86L cpus. So we must reverse the

[PATCH v2 1/2] x86/cpu: Use correct macros for Cyrix calls

2018-09-21 Thread Matthew Whitehead
There are comments in processor-cyrix.h advising you to _not_ make calls using the deprecated macros in this style: setCx86_old(CX86_CCR4, getCx86_old(CX86_CCR4) | 0x80); This is because it expands the macro into a non-functioning calling sequence. The calling order must be: outb(CX86_CCR2,

[PATCH v2 2/2] x86/cpu: Change query logic so cpuid is enabled before testing

2018-09-21 Thread Matthew Whitehead
Presently we check for cpuid to be enabled first. If it is not already enabled, then we next call identify_cpu_without_cpuid() and clear X86_FEATURE_CPUID. Unfortunately, identify_cpu_without_cpuid() is the function where cpuid becomes _enabled_ on Cyrix 6x86/6x86L cpus. So we must reverse the

[PATCH v2 0/2] x86/cpu: Enable cpuid on Cyrix 6x86/6x86L processors

2018-09-21 Thread Matthew Whitehead
On power up, the cpuid instruction is disabled on Cyrix 6x86 and 6x86L processors and needs to be enabled. This patchset enables it. Matthew Whitehead (2): x86/cpu: Use correct macros for Cyrix calls x86/cpu: Change query logic so cpuid is enabled before testing arch/x86/kernel/cpu/common.c

[PATCH v2 0/2] x86/cpu: Enable cpuid on Cyrix 6x86/6x86L processors

2018-09-21 Thread Matthew Whitehead
On power up, the cpuid instruction is disabled on Cyrix 6x86 and 6x86L processors and needs to be enabled. This patchset enables it. Matthew Whitehead (2): x86/cpu: Use correct macros for Cyrix calls x86/cpu: Change query logic so cpuid is enabled before testing arch/x86/kernel/cpu/common.c

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > Hi Baolin, > > On 09/21/2018 05:31 AM, Baolin Wang wrote: > > Hi Jacek and Pavel, > > > > On 11 September 2018 at 10:47, Baolin Wang wrote: > >> This patch adds one new led trigger that LED device can configure > >> the software or hardware

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > Hi Baolin, > > On 09/21/2018 05:31 AM, Baolin Wang wrote: > > Hi Jacek and Pavel, > > > > On 11 September 2018 at 10:47, Baolin Wang wrote: > >> This patch adds one new led trigger that LED device can configure > >> the software or hardware

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > Hi Baolin, > > On 09/21/2018 05:31 AM, Baolin Wang wrote: > > Hi Jacek and Pavel, > > > > On 11 September 2018 at 10:47, Baolin Wang wrote: > >> This patch adds one new led trigger that LED device can configure > >> the software or hardware

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > Hi Baolin, > > On 09/21/2018 05:31 AM, Baolin Wang wrote: > > Hi Jacek and Pavel, > > > > On 11 September 2018 at 10:47, Baolin Wang wrote: > >> This patch adds one new led trigger that LED device can configure > >> the software or hardware

Re: [PATCHv3 5/7] ARM: dts: exynos5422: use wp-gpio method to detect sd-card

2018-09-21 Thread Krzysztof Kozlowski
On Fri, Sep 21, 2018 at 06:01:07PM +0530, Anand Moon wrote: > Hi Krzysztof, > > On Fri, 21 Sep 2018 at 16:42, Krzysztof Kozlowski wrote: > > > > On Thu, 20 Sep 2018 at 19:59, Anand Moon wrote: > > > > > > add the Write Protect GPIO property for sdcard, to fix > > > the warning message during

Re: [PATCHv3 5/7] ARM: dts: exynos5422: use wp-gpio method to detect sd-card

2018-09-21 Thread Krzysztof Kozlowski
On Fri, Sep 21, 2018 at 06:01:07PM +0530, Anand Moon wrote: > Hi Krzysztof, > > On Fri, 21 Sep 2018 at 16:42, Krzysztof Kozlowski wrote: > > > > On Thu, 20 Sep 2018 at 19:59, Anand Moon wrote: > > > > > > add the Write Protect GPIO property for sdcard, to fix > > > the warning message during

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > Hi Baolin, > > On 09/21/2018 05:31 AM, Baolin Wang wrote: > > Hi Jacek and Pavel, > > > > On 11 September 2018 at 10:47, Baolin Wang wrote: > >> This patch adds one new led trigger that LED device can configure > >> the software or hardware

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > Hi Baolin, > > On 09/21/2018 05:31 AM, Baolin Wang wrote: > > Hi Jacek and Pavel, > > > > On 11 September 2018 at 10:47, Baolin Wang wrote: > >> This patch adds one new led trigger that LED device can configure > >> the software or hardware

[PATCH] ARM: dts: exynos: Add CD and WP pins to Odroid XU SD card

2018-09-21 Thread Krzysztof Kozlowski
Defining card-detect and write-protect GPIO pins in Odroid XU SD Card does not change anything from functional point of view - dw-mmc driver was reading the state from registers. Adding cd-gpios and wp-gpios properties changes only internal driver behavior to access the pins directly. Add them

[PATCH] ARM: dts: exynos: Add CD and WP pins to Odroid XU SD card

2018-09-21 Thread Krzysztof Kozlowski
Defining card-detect and write-protect GPIO pins in Odroid XU SD Card does not change anything from functional point of view - dw-mmc driver was reading the state from registers. Adding cd-gpios and wp-gpios properties changes only internal driver behavior to access the pins directly. Add them

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Jacek Anaszewski
Hi Baolin, On 09/21/2018 05:31 AM, Baolin Wang wrote: > Hi Jacek and Pavel, > > On 11 September 2018 at 10:47, Baolin Wang wrote: >> This patch adds one new led trigger that LED device can configure >> the software or hardware pattern and trigger it. >> >> Consumers can write 'pattern' file to

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Jacek Anaszewski
Hi Baolin, On 09/21/2018 05:31 AM, Baolin Wang wrote: > Hi Jacek and Pavel, > > On 11 September 2018 at 10:47, Baolin Wang wrote: >> This patch adds one new led trigger that LED device can configure >> the software or hardware pattern and trigger it. >> >> Consumers can write 'pattern' file to

[PATCH] watchdog/hpwdt: Disable PreTimeout when Timeout is smaller

2018-09-21 Thread Jerry Hoemann
During module install, disable pretimeout if the requested timeout value is not greater than the minimal pretimeout value that is supported by hardware. This makes the module load handling of pretimeout consistent with the ioctl handling of pretimeout. Signed-off-by: Jerry Hoemann ---

[PATCH] watchdog/hpwdt: Disable PreTimeout when Timeout is smaller

2018-09-21 Thread Jerry Hoemann
During module install, disable pretimeout if the requested timeout value is not greater than the minimal pretimeout value that is supported by hardware. This makes the module load handling of pretimeout consistent with the ioctl handling of pretimeout. Signed-off-by: Jerry Hoemann ---

<    1   2   3   4   5   6   7   8   9   10   >