On Thu, Sep 20, 2018 at 09:41:39AM +0100, Jonathan Cameron wrote:
>On Wed, 19 Sep 2018 18:58:37 +
>Sasha Levin wrote:
>
>> Hi,
>>
>> [This is an automated email]
>>
>> This commit has been processed because it contains a -stable tag.
>> The stable tag indicates that it's relevant for the
On Thu, Sep 20, 2018 at 09:41:39AM +0100, Jonathan Cameron wrote:
>On Wed, 19 Sep 2018 18:58:37 +
>Sasha Levin wrote:
>
>> Hi,
>>
>> [This is an automated email]
>>
>> This commit has been processed because it contains a -stable tag.
>> The stable tag indicates that it's relevant for the
Miklos Szeredi wrote:
> This subtype thing is specific to "fuse" and "fuseblk" filesystems. When
> these are switched over to the new context API, the handling of this
> parameter can be moved from legacy_parse_param() into fuse.
I think do_new_mount() should do:
Miklos Szeredi wrote:
> This subtype thing is specific to "fuse" and "fuseblk" filesystems. When
> these are switched over to the new context API, the handling of this
> parameter can be moved from legacy_parse_param() into fuse.
I think do_new_mount() should do:
On Fri, Sep 21, 2018 at 11:28 AM Maxime Ripard
wrote:
> Expanding a bit more that commit log would be helpful. What is the
> eMMC connected to that board? Do all versions have it? Which modes are
> supposed to be supported, and which one have been tested?
The terseness of the commit message was
On Fri, Sep 21, 2018 at 11:28 AM Maxime Ripard
wrote:
> Expanding a bit more that commit log would be helpful. What is the
> eMMC connected to that board? Do all versions have it? Which modes are
> supposed to be supported, and which one have been tested?
The terseness of the commit message was
Miklos Szeredi wrote:
> Subtype was initilized at the wrong place from the wrong source
> (fstype->fs_type->name, which does not ever contain a subtype).
>
> Set subtype from do_new_mount(), where it actually does something.
> Verified with fuse.
Folded.
Miklos Szeredi wrote:
> Subtype was initilized at the wrong place from the wrong source
> (fstype->fs_type->name, which does not ever contain a subtype).
>
> Set subtype from do_new_mount(), where it actually does something.
> Verified with fuse.
Folded.
On 2018/9/21 22:26, Maxime Ripard wrote:
> On Wed, Sep 19, 2018 at 05:01:32PM +0800, zhong jiang wrote:
>> On 2018/9/19 16:47, Maxime Ripard wrote:
>>> On Tue, Sep 18, 2018 at 03:25:20PM +0800, zhong jiang wrote:
Fix the following compile warning:
On 2018/9/21 22:26, Maxime Ripard wrote:
> On Wed, Sep 19, 2018 at 05:01:32PM +0800, zhong jiang wrote:
>> On 2018/9/19 16:47, Maxime Ripard wrote:
>>> On Tue, Sep 18, 2018 at 03:25:20PM +0800, zhong jiang wrote:
Fix the following compile warning:
On Fri, Sep 21, 2018 at 02:03:40PM +0800, Hanjie Lin wrote:
> From: Yue Wang
>
> The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare
> PCI core. This patch adds the driver support for Meson PCIe controller.
Please read:
https://marc.info/?l=linux-pci=150905742808166=2
On Fri, Sep 21, 2018 at 02:03:40PM +0800, Hanjie Lin wrote:
> From: Yue Wang
>
> The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare
> PCI core. This patch adds the driver support for Meson PCIe controller.
Please read:
https://marc.info/?l=linux-pci=150905742808166=2
Miklos Szeredi wrote:
> - return vfs_kern_mount(type, MS_SUBMOUNT, name, data, data_size);
> + return vfs_kern_mount(type, SB_SUBMOUNT, name, data, data_size);
Folded in.
David
Miklos Szeredi wrote:
> - return vfs_kern_mount(type, MS_SUBMOUNT, name, data, data_size);
> + return vfs_kern_mount(type, SB_SUBMOUNT, name, data, data_size);
Folded in.
David
On 09/21/2018 04:25 PM, Souptick Joarder wrote:
> On Fri, Sep 21, 2018 at 5:22 PM Andrey Ryabinin
> wrote:
>> On 09/21/2018 01:03 PM, Souptick Joarder wrote:
>>> On Fri, Sep 21, 2018 at 3:06 PM Andrey Ryabinin
>>> wrote:
On 09/20/2018 10:12 PM, Souptick Joarder wrote:
> @@
On 09/21/2018 04:25 PM, Souptick Joarder wrote:
> On Fri, Sep 21, 2018 at 5:22 PM Andrey Ryabinin
> wrote:
>> On 09/21/2018 01:03 PM, Souptick Joarder wrote:
>>> On Fri, Sep 21, 2018 at 3:06 PM Andrey Ryabinin
>>> wrote:
On 09/20/2018 10:12 PM, Souptick Joarder wrote:
> @@
syzbot has found a reproducer for the following crash on:
HEAD commit:234b69e3e089 ocfs2: fix ocfs2 read block panic
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=151d651140
kernel config: https://syzkaller.appspot.com/x/.config?x=5fa12be50bca08d8
syzbot has found a reproducer for the following crash on:
HEAD commit:234b69e3e089 ocfs2: fix ocfs2 read block panic
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=151d651140
kernel config: https://syzkaller.appspot.com/x/.config?x=5fa12be50bca08d8
This will conflict with my patch to remove a lot of this stuff.
You can find it on this branch:
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?h=btrfs-mount-api
with the subject "security: Remove the set_mnt_opts and clone_mnt_opts ops".
Note that both
This will conflict with my patch to remove a lot of this stuff.
You can find it on this branch:
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?h=btrfs-mount-api
with the subject "security: Remove the set_mnt_opts and clone_mnt_opts ops".
Note that both
On 9/21/2018 10:14 AM, Peter Zijlstra wrote:
On Fri, Sep 21, 2018 at 07:07:06AM -0700, kan.li...@linux.intel.com wrote:
From: Kan Liang
The counters on M3UPI Link 0 and Link 3 don't count. Writing 0 to
these counters may causes system crash on some machines.
The PCI BDF addresses of M3UPI
On 9/21/2018 10:14 AM, Peter Zijlstra wrote:
On Fri, Sep 21, 2018 at 07:07:06AM -0700, kan.li...@linux.intel.com wrote:
From: Kan Liang
The counters on M3UPI Link 0 and Link 3 don't count. Writing 0 to
these counters may causes system crash on some machines.
The PCI BDF addresses of M3UPI
On Wed, Sep 19, 2018 at 11:19:36AM -0300, Rodrigo Exterckötter Tjäder wrote:
> Without "allwinner,tx-delay-ps = <600>;" on the DTP it can receive packets
> but not send.
>
> Signed-off-by: Rodrigo Exterckötter Tjäder
Again, that commit log would be nice if it was a bit more
explicit. What is a
On Wed, Sep 19, 2018 at 11:19:36AM -0300, Rodrigo Exterckötter Tjäder wrote:
> Without "allwinner,tx-delay-ps = <600>;" on the DTP it can receive packets
> but not send.
>
> Signed-off-by: Rodrigo Exterckötter Tjäder
Again, that commit log would be nice if it was a bit more
explicit. What is a
Hi!
On Wed, Sep 19, 2018 at 11:18:13AM -0300, Rodrigo Exterckötter Tjäder wrote:
> Copied snippet from A64-TERES I.
>
> Signed-off-by: Rodrigo Exterckötter Tjäder
Expanding a bit more that commit log would be helpful. What is the
eMMC connected to that board? Do all versions have it? Which
Quoting John Garry (2018-09-21 09:11:19)
> On 21/09/2018 06:49, Liuxinliang (Matthew Liu) wrote:
> > Hi John,
> > Thank you for reporting bug.
> > I am now using 4.18.7. I haven't found this issue yet.
> > I will try linux-next and figure out what's wrong with it.
> >
> > Thanks,
> > Xinliang
> >
Hi!
On Wed, Sep 19, 2018 at 11:18:13AM -0300, Rodrigo Exterckötter Tjäder wrote:
> Copied snippet from A64-TERES I.
>
> Signed-off-by: Rodrigo Exterckötter Tjäder
Expanding a bit more that commit log would be helpful. What is the
eMMC connected to that board? Do all versions have it? Which
Quoting John Garry (2018-09-21 09:11:19)
> On 21/09/2018 06:49, Liuxinliang (Matthew Liu) wrote:
> > Hi John,
> > Thank you for reporting bug.
> > I am now using 4.18.7. I haven't found this issue yet.
> > I will try linux-next and figure out what's wrong with it.
> >
> > Thanks,
> > Xinliang
> >
On Wed, Sep 19, 2018 at 05:01:32PM +0800, zhong jiang wrote:
> On 2018/9/19 16:47, Maxime Ripard wrote:
> > On Tue, Sep 18, 2018 at 03:25:20PM +0800, zhong jiang wrote:
> >> Fix the following compile warning:
> >>
> >> drivers/gpu/drm/sun4i/sun4i_tcon.c:1088: warning: 'has_lvds_alt' may be
> >>
On Wed, Sep 19, 2018 at 05:01:32PM +0800, zhong jiang wrote:
> On 2018/9/19 16:47, Maxime Ripard wrote:
> > On Tue, Sep 18, 2018 at 03:25:20PM +0800, zhong jiang wrote:
> >> Fix the following compile warning:
> >>
> >> drivers/gpu/drm/sun4i/sun4i_tcon.c:1088: warning: 'has_lvds_alt' may be
> >>
On 9/21/18 9:26 AM, Oscar Salvador wrote:
> From: Oscar Salvador
>
> While looking at node_states_check_changes_online, I stumbled
> upon some confusing things.
>
> Right after entering the function, we find this:
>
> if (N_MEMORY == N_NORMAL_MEMORY)
> zone_last = ZONE_MOVABLE;
>
>
On 9/21/18 9:26 AM, Oscar Salvador wrote:
> From: Oscar Salvador
>
> While looking at node_states_check_changes_online, I stumbled
> upon some confusing things.
>
> Right after entering the function, we find this:
>
> if (N_MEMORY == N_NORMAL_MEMORY)
> zone_last = ZONE_MOVABLE;
>
>
On Fri, Sep 21, 2018 at 07:07:06AM -0700, kan.li...@linux.intel.com wrote:
> From: Kan Liang
>
> The counters on M3UPI Link 0 and Link 3 don't count. Writing 0 to
> these counters may causes system crash on some machines.
>
> The PCI BDF addresses of M3UPI in current code are incorrect.
> The
On Fri, Sep 21, 2018 at 07:07:06AM -0700, kan.li...@linux.intel.com wrote:
> From: Kan Liang
>
> The counters on M3UPI Link 0 and Link 3 don't count. Writing 0 to
> these counters may causes system crash on some machines.
>
> The PCI BDF addresses of M3UPI in current code are incorrect.
> The
see them :(
> >
> > > are available in the Git repository at:
> > >
> > > git://git.infradead.org/linux-ubifs.git tags/upstream-4.19-rc4
> >
> > Now pulled, but really, don't you think that they should at least go
> > through 0-day first? Maybe no one
see them :(
> >
> > > are available in the Git repository at:
> > >
> > > git://git.infradead.org/linux-ubifs.git tags/upstream-4.19-rc4
> >
> > Now pulled, but really, don't you think that they should at least go
> > through 0-day first? Maybe no one
From: Kan Liang
The counters on M3UPI Link 0 and Link 3 don't count. Writing 0 to
these counters may causes system crash on some machines.
The PCI BDF addresses of M3UPI in current code are incorrect.
The correct addresses should be
D18:F1 0x204D
D18:F2 0x204E
D18:F5 0x204D
Signed-off-by:
From: Kan Liang
The counters on M3UPI Link 0 and Link 3 don't count. Writing 0 to
these counters may causes system crash on some machines.
The PCI BDF addresses of M3UPI in current code are incorrect.
The correct addresses should be
D18:F1 0x204D
D18:F2 0x204E
D18:F5 0x204D
Signed-off-by:
> -Original Message-
> From: linux-rdma-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Parav Pandit
> Sent: Friday, September 21, 2018 8:53 AM
> To: syzbot ;
> Daniel Jurgens ; dledf...@redhat.com;
> j...@ziepe.ca; l...@kernel.org; linux-kernel@vger.kernel.org; linux-
>
> -Original Message-
> From: linux-rdma-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Parav Pandit
> Sent: Friday, September 21, 2018 8:53 AM
> To: syzbot ;
> Daniel Jurgens ; dledf...@redhat.com;
> j...@ziepe.ca; l...@kernel.org; linux-kernel@vger.kernel.org; linux-
>
Hi Suzuki,
On 2018/9/12 14:53, Suzuki K Poulose wrote:
> Switch to updated coresight bindings for hw ports.
>
> Cc: xuw...@hisilicon.com
> Cc: lipengche...@huawei.com
> Cc: Mathieu Poirier
> Tested-by: Leo Yan
> Signed-off-by: Suzuki K Poulose
Thanks!
Applied to the hisilicon dt tree.
Best
Hi Suzuki,
On 2018/9/12 14:53, Suzuki K Poulose wrote:
> Switch to updated coresight bindings for hw ports.
>
> Cc: xuw...@hisilicon.com
> Cc: lipengche...@huawei.com
> Cc: Mathieu Poirier
> Tested-by: Leo Yan
> Signed-off-by: Suzuki K Poulose
Thanks!
Applied to the hisilicon dt tree.
Best
Hi Suzuki,
On 2018/9/12 14:53, Suzuki K Poulose wrote:
> Switch to the new the hardware port bindings.
>
> Cc: Wei Xu
> Cc: Mathieu Poirier
> Signed-off-by: Suzuki K Poulose
Thanks!
Applied to the hisilicon dt tree.
Best Regards,
Wei
> ---
> arch/arm/boot/dts/hip04.dtsi | 346
Hi Suzuki,
On 2018/9/12 14:53, Suzuki K Poulose wrote:
> Switch to the new the hardware port bindings.
>
> Cc: Wei Xu
> Cc: Mathieu Poirier
> Signed-off-by: Suzuki K Poulose
Thanks!
Applied to the hisilicon dt tree.
Best Regards,
Wei
> ---
> arch/arm/boot/dts/hip04.dtsi | 346
On 09/21/2018 05:40 AM, Cornelia Huck wrote:
On Wed, 12 Sep 2018 15:42:56 -0400
Tony Krowiak wrote:
From: Tony Krowiak
Introduces two new sysfs attributes for the VFIO mediated
matrix device for assigning AP adapters to and unassigning
AP adapters from a mediated matrix device. The IDs of
On 09/21/2018 05:40 AM, Cornelia Huck wrote:
On Wed, 12 Sep 2018 15:42:56 -0400
Tony Krowiak wrote:
From: Tony Krowiak
Introduces two new sysfs attributes for the VFIO mediated
matrix device for assigning AP adapters to and unassigning
AP adapters from a mediated matrix device. The IDs of
Greg,
The following changes since commit 7876320f88802b22d4e2daf7eb027dd14175a0f8:
Linux 4.19-rc4 (2018-09-16 11:52:37 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus
for you to fetch changes up to
Greg,
The following changes since commit 7876320f88802b22d4e2daf7eb027dd14175a0f8:
Linux 4.19-rc4 (2018-09-16 11:52:37 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus
for you to fetch changes up to
Greg,
The following changes since commit 7876320f88802b22d4e2daf7eb027dd14175a0f8:
Linux 4.19-rc4 (2018-09-16 11:52:37 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus
for you to fetch changes up to
Greg,
The following changes since commit 7876320f88802b22d4e2daf7eb027dd14175a0f8:
Linux 4.19-rc4 (2018-09-16 11:52:37 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus
for you to fetch changes up to
On 21/09/2018 15:55, Greg KH wrote:
> On Fri, Sep 21, 2018 at 02:14:27PM +0200, Paolo Bonzini wrote:
>> Greg,
>>
>> The following changes since commit 7876320f88802b22d4e2daf7eb027dd14175a0f8:
>>
>> Linux 4.19-rc4 (2018-09-16 11:52:37 -0700)
>>
>> are available in the git repository at:
>>
>>
On 21/09/2018 15:55, Greg KH wrote:
> On Fri, Sep 21, 2018 at 02:14:27PM +0200, Paolo Bonzini wrote:
>> Greg,
>>
>> The following changes since commit 7876320f88802b22d4e2daf7eb027dd14175a0f8:
>>
>> Linux 4.19-rc4 (2018-09-16 11:52:37 -0700)
>>
>> are available in the git repository at:
>>
>>
Factor out tpm_get_timeouts() into tpm2_get_timeouts()
and tpm1_get_timeouts()
Signed-off-by: Tomas Winkler
---
V2-V3: Rebase.
V4: Fix the commit message.
drivers/char/tpm/tpm-interface.c | 127 ++-
drivers/char/tpm/tpm.h | 5 +-
Move tpm1_pcr_extend to tpm1-cmd.c and remove
unused pcrextend_header structure and
EXTEND_PCR_RESULT_SIZE and EXTEND_PCR_RESULT_BODY_SIZE
defines.
Fixes warning:
drivers/char/tpm/tpm-interface.c:609:38: warning: ‘pcrextend_header’ defined
but not used [-Wunused-const-variable=]
static const
Move tpm1_pcr_extend to tpm1-cmd.c and remove
unused pcrextend_header structure and
EXTEND_PCR_RESULT_SIZE and EXTEND_PCR_RESULT_BODY_SIZE
defines.
Fixes warning:
drivers/char/tpm/tpm-interface.c:609:38: warning: ‘pcrextend_header’ defined
but not used [-Wunused-const-variable=]
static const
Factor out tpm_get_timeouts() into tpm2_get_timeouts()
and tpm1_get_timeouts()
Signed-off-by: Tomas Winkler
---
V2-V3: Rebase.
V4: Fix the commit message.
drivers/char/tpm/tpm-interface.c | 127 ++-
drivers/char/tpm/tpm.h | 5 +-
1. Move tpm_getcap to tpm1-cmd. Rename the function to tpm1_getcap.
2. Remove unused tpm_getcap_header with unused constant
as this functionality is already implemented using tpm_buf construct.
Fixes warning:
drivers/char/tpm/tpm-interface.c:452:38: warning: ‘tpm_getcap_header’ defined
but not
1. Move tpm_getcap to tpm1-cmd. Rename the function to tpm1_getcap.
2. Remove unused tpm_getcap_header with unused constant
as this functionality is already implemented using tpm_buf construct.
Fixes warning:
drivers/char/tpm/tpm-interface.c:452:38: warning: ‘tpm_getcap_header’ defined
but not
Move the tpm1 selftest code functions to tpm1-cmd.c
and adjust callers to use the new function names.
1. tpm_pcr_read_dev() to tpm1_pcr_read_dev().
2. tpm_continue_selftest() to tpm1_continue_selftest().
3. tpm_do_selftest() to tpm1_do_selftest()
Signed-off-by: Tomas Winkler
Tested-by: Jarkko
This reverts commit 7e5d1fd75c3dde9fc10c4472b9368089d1b81d00 as it causes
regression with multiple pwm chip. It creates a new entry in
'/sys/class/pwm' every time a 'pwmX' is exported with 'echo X > export':
- 1st time export will create an entry in /sys/class/pwm/pwmX
- when another export
Move the tpm1 selftest code functions to tpm1-cmd.c
and adjust callers to use the new function names.
1. tpm_pcr_read_dev() to tpm1_pcr_read_dev().
2. tpm_continue_selftest() to tpm1_continue_selftest().
3. tpm_do_selftest() to tpm1_do_selftest()
Signed-off-by: Tomas Winkler
Tested-by: Jarkko
This reverts commit 7e5d1fd75c3dde9fc10c4472b9368089d1b81d00 as it causes
regression with multiple pwm chip. It creates a new entry in
'/sys/class/pwm' every time a 'pwmX' is exported with 'echo X > export':
- 1st time export will create an entry in /sys/class/pwm/pwmX
- when another export
Factor out get random implementation from tpm-interface.c
into tpm1_get_random function in tpm1-cmd.c.
No functional changes.
Signed-off-by: Tomas Winkler
Reviewed-by: Jarkko Sakkine
---
V2-V3: Rebase
V4: Resend
drivers/char/tpm/tpm-interface.c | 58 +---
Factor out get random implementation from tpm-interface.c
into tpm1_get_random function in tpm1-cmd.c.
No functional changes.
Signed-off-by: Tomas Winkler
Reviewed-by: Jarkko Sakkine
---
V2-V3: Rebase
V4: Resend
drivers/char/tpm/tpm-interface.c | 58 +---
Factor out TPM 1.x suspend flow from tpm-interface.c into a new function
tpm1_pm_suspend() in tpm1-cmd.c
Signed-off-by: Tomas Winkler
---
V2-V3: Rebase
V4: 1. Add kdoc for tpm1_pm_suspend().
2. Fix commit message.
drivers/char/tpm/tpm-interface.c | 55 -
Factor out TPM 1.x suspend flow from tpm-interface.c into a new function
tpm1_pm_suspend() in tpm1-cmd.c
Signed-off-by: Tomas Winkler
---
V2-V3: Rebase
V4: 1. Add kdoc for tpm1_pm_suspend().
2. Fix commit message.
drivers/char/tpm/tpm-interface.c | 55 -
The TPM specs defines PCR index a positive number, there is
no reason to use a signed number and it's also a possible security
issue as currently no functions check for a negative index,
which my into a large number when converted to u32.
Adjust the API to use u32 instead of int in all PCR
The TPM specs defines PCR index a positive number, there is
no reason to use a signed number and it's also a possible security
issue as currently no functions check for a negative index,
which my into a large number when converted to u32.
Adjust the API to use u32 instead of int in all PCR
Add tpm2_pcr_extend() function to tpm2-cmd.c with signature required
by tpm-interface.c. It wraps the original open code
implementation. The original original tpm2_pcr_extend() function
is renamed to __tpm2_pcr_extend() and made static, it is called
only from new tpm2_pcr_extend().
Fix warnings
In tpm1_pm_suspend() function reimplement,
TPM_ORD_SAVESTATE comamnd using tpm_buf.
Signed-off-by: Tomas Winkler
Reviewed-by: Jarkko Sakkinen
Tested-by: Jarkko Sakkinen
---
V3: New in the series.
V4: Resend.
drivers/char/tpm/tpm1-cmd.c | 22 --
1 file changed, 12
Reimplement tpm1_continue_selftest() using tpm_buf structure.
This is the last command using the old tpm_cmd_t structure
and now the structure can be removed.
Signed-off-by: Tomas Winkler
Reviewed-by: Jarkko Sakkinen
Tested-by: Jarkko Sakkinen
---
V3: New in the series.
V4: Resend.
Implement tpm1_pcr_read_dev() using tpm_buf and remove
now unneeded structures from tpm.h
Signed-off-by: Tomas Winkler
Reviewed-by: Jarkko Sakkinen
Tested-by: Jarkko Sakkinen
---
V3: New in the series.
V4: Resend.
drivers/char/tpm/tpm.h | 18 ++
Add wrapper tpm_auto_startup() to tpm-interface.c
instead of open coded decision between TPM 1.x and TPM 2.x
in tpm-chip.c
Signed-off-by: Tomas Winkler
Tested-by: Jarkko Sakkinen
---
V3: New in the series.
V4: Fix the commit message.
drivers/char/tpm/tpm-chip.c | 11 +++
1. Use tpm_buf in tpm1_get_random()
2. Fix comment in tpm_get_random() so it is clear that
the function is expected to return number of random bytes.
Signed-off-by: Tomas Winkler
Reviewed-by: Jarkko Sakkinen
Tested-by: Jarkko Sakkinen
---
V3: New in the series.
V4: Resend.
Remove unneeded semicolon in tpm2_map_response_header()
Signed-off-by: Tomas Winkler
Reviewed-by: Jarkko Sakkinen
---
V3: New in the series.
V4: Resend.
drivers/char/tpm/tpm2-space.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/tpm/tpm2-space.c
Add tpm2_pcr_extend() function to tpm2-cmd.c with signature required
by tpm-interface.c. It wraps the original open code
implementation. The original original tpm2_pcr_extend() function
is renamed to __tpm2_pcr_extend() and made static, it is called
only from new tpm2_pcr_extend().
Fix warnings
In tpm1_pm_suspend() function reimplement,
TPM_ORD_SAVESTATE comamnd using tpm_buf.
Signed-off-by: Tomas Winkler
Reviewed-by: Jarkko Sakkinen
Tested-by: Jarkko Sakkinen
---
V3: New in the series.
V4: Resend.
drivers/char/tpm/tpm1-cmd.c | 22 --
1 file changed, 12
Reimplement tpm1_continue_selftest() using tpm_buf structure.
This is the last command using the old tpm_cmd_t structure
and now the structure can be removed.
Signed-off-by: Tomas Winkler
Reviewed-by: Jarkko Sakkinen
Tested-by: Jarkko Sakkinen
---
V3: New in the series.
V4: Resend.
Implement tpm1_pcr_read_dev() using tpm_buf and remove
now unneeded structures from tpm.h
Signed-off-by: Tomas Winkler
Reviewed-by: Jarkko Sakkinen
Tested-by: Jarkko Sakkinen
---
V3: New in the series.
V4: Resend.
drivers/char/tpm/tpm.h | 18 ++
Add wrapper tpm_auto_startup() to tpm-interface.c
instead of open coded decision between TPM 1.x and TPM 2.x
in tpm-chip.c
Signed-off-by: Tomas Winkler
Tested-by: Jarkko Sakkinen
---
V3: New in the series.
V4: Fix the commit message.
drivers/char/tpm/tpm-chip.c | 11 +++
1. Use tpm_buf in tpm1_get_random()
2. Fix comment in tpm_get_random() so it is clear that
the function is expected to return number of random bytes.
Signed-off-by: Tomas Winkler
Reviewed-by: Jarkko Sakkinen
Tested-by: Jarkko Sakkinen
---
V3: New in the series.
V4: Resend.
Remove unneeded semicolon in tpm2_map_response_header()
Signed-off-by: Tomas Winkler
Reviewed-by: Jarkko Sakkinen
---
V3: New in the series.
V4: Resend.
drivers/char/tpm/tpm2-space.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/tpm/tpm2-space.c
The commit:
"tpm_tis: further simplify calculation of ordinal duration"
left unused macros, we can drop them now.
Fixes compilation warnings:
tpm-interface.c:37:0: warning: macro "TPM_PROTECTED_COMMAND" is not used
[-Wunused-macros]
tpm-interface.c:36:0: warning: macro "TSC_MAX_ORDINAL" is not
Rename tpm1_pcr_read_dev to tpm1_pcr_read() to match
the counterpart tpm2_pcr_read().
Signed-off-by: Tomas Winkler
---
V4: New in the series.
drivers/char/tpm/tpm-interface.c | 2 +-
drivers/char/tpm/tpm-sysfs.c | 2 +-
drivers/char/tpm/tpm.h | 2 +-
drivers/char/tpm/tpm1-cmd.c
The commit:
"tpm_tis: further simplify calculation of ordinal duration"
left unused macros, we can drop them now.
Fixes compilation warnings:
tpm-interface.c:37:0: warning: macro "TPM_PROTECTED_COMMAND" is not used
[-Wunused-macros]
tpm-interface.c:36:0: warning: macro "TSC_MAX_ORDINAL" is not
Rename tpm1_pcr_read_dev to tpm1_pcr_read() to match
the counterpart tpm2_pcr_read().
Signed-off-by: Tomas Winkler
---
V4: New in the series.
drivers/char/tpm/tpm-interface.c | 2 +-
drivers/char/tpm/tpm-sysfs.c | 2 +-
drivers/char/tpm/tpm.h | 2 +-
drivers/char/tpm/tpm1-cmd.c
TPM manual startup is used only from within TPM 1.x or TPM 2.x
code, hence remove tpm_startup() function from tpm-interface.c
and add two static functions implementations tpm1_startup()
and tpm2_startup() into to tpm1-cmd.c and tpm2-cmd.c respectively.
Signed-off-by: Tomas Winkler
Tested-by:
Add convenient wrapper for ordinal duration computation
to remove boiler plate if else statement over TPM2.
if (chip->flags & TPM_CHIP_FLAG_TPM2)
tpm2_calc_ordinal_duration(chip, ordinal);
else
tpm1_calc_ordinal_duration(chip, ordinal);
Signed-off-by: Tomas Winkler
Reviewed-by:
TPM manual startup is used only from within TPM 1.x or TPM 2.x
code, hence remove tpm_startup() function from tpm-interface.c
and add two static functions implementations tpm1_startup()
and tpm2_startup() into to tpm1-cmd.c and tpm2-cmd.c respectively.
Signed-off-by: Tomas Winkler
Tested-by:
Add convenient wrapper for ordinal duration computation
to remove boiler plate if else statement over TPM2.
if (chip->flags & TPM_CHIP_FLAG_TPM2)
tpm2_calc_ordinal_duration(chip, ordinal);
else
tpm1_calc_ordinal_duration(chip, ordinal);
Signed-off-by: Tomas Winkler
Reviewed-by:
/upstream-4.19-rc4
>
> Now pulled, but really, don't you think that they should at least go
> through 0-day first? Maybe no one runs ubifs on mainline kernels...
Huh? I checked this morning next-20180921 and saw all patches.
Thanks,
//richard
Make the tpm Makefile a bit more in order by putting
objects in one column.
Signed-off-by: Tomas Winkler
Tested-by: Jarkko Sakkinen
---
V2: 1. back to tpm-y notation
2. Partially sort files alphanumerically.
V3: Rebase
V4: Remove redunant sentence in commit message.
1. TPM2_CC_LAST has moved from 182 to 193
2. Convert tpm2_ordinal_duration from an array into a switch statement,
as there are not so many commands that require special duration
relative to a number of commands, the switch statement function
is called tpm2_ordinal_duration_index().
3. Fix
Factor out TPM 1.x commands calculation into tpm1-cmd.c file.
and change the prefix from tpm_ to tpm1_.
No functional change is done here.
Signed-off-by: Tomas Winkler
Tested-by: Jarkko Sakkinen
---
V2-V3: Rebase
V4: 1. Remove the licence statement it's already covered by SPDX.
2. Add kdoc
/upstream-4.19-rc4
>
> Now pulled, but really, don't you think that they should at least go
> through 0-day first? Maybe no one runs ubifs on mainline kernels...
Huh? I checked this morning next-20180921 and saw all patches.
Thanks,
//richard
Make the tpm Makefile a bit more in order by putting
objects in one column.
Signed-off-by: Tomas Winkler
Tested-by: Jarkko Sakkinen
---
V2: 1. back to tpm-y notation
2. Partially sort files alphanumerically.
V3: Rebase
V4: Remove redunant sentence in commit message.
1. TPM2_CC_LAST has moved from 182 to 193
2. Convert tpm2_ordinal_duration from an array into a switch statement,
as there are not so many commands that require special duration
relative to a number of commands, the switch statement function
is called tpm2_ordinal_duration_index().
3. Fix
Factor out TPM 1.x commands calculation into tpm1-cmd.c file.
and change the prefix from tpm_ to tpm1_.
No functional change is done here.
Signed-off-by: Tomas Winkler
Tested-by: Jarkko Sakkinen
---
V2-V3: Rebase
V4: 1. Remove the licence statement it's already covered by SPDX.
2. Add kdoc
This patch series provides initial separation of tpm 1.x and tpm 2.x
commands, in foresight that the tpm 1.x chips will eventually phase out
and can be compiled out for modern systems.
A new file is added tpm1-cmd.c that contains tpm 1.x specific commands.
In addition, tpm 1.x commands are now
This patch series provides initial separation of tpm 1.x and tpm 2.x
commands, in foresight that the tpm 1.x chips will eventually phase out
and can be compiled out for modern systems.
A new file is added tpm1-cmd.c that contains tpm 1.x specific commands.
In addition, tpm 1.x commands are now
701 - 800 of 1364 matches
Mail list logo
