Re: [PATCH] x86/fault: Print "SUPERVISOR" and "READ" when decoding #PF oops

2018-12-05 Thread Linus Torvalds
On Wed, Dec 5, 2018 at 11:27 AM Randy Dunlap wrote: > > BTW, what does PK mean? "Protection Key" Linus

Re: [PATCH] x86/fault: Print "SUPERVISOR" and "READ" when decoding #PF oops

2018-12-05 Thread Linus Torvalds
On Wed, Dec 5, 2018 at 11:27 AM Randy Dunlap wrote: > > BTW, what does PK mean? "Protection Key" Linus

Re: [PATCH v14 06/11] livepatch: Use lists to manage patches, objects and functions

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:26AM +0100, Petr Mladek wrote: > From: Jason Baron > > Currently klp_patch contains a pointer to a statically allocated array of > struct klp_object and struct klp_objects contains a pointer to a statically > allocated array of klp_func. In order to allow for the

Re: [PATCH v14 06/11] livepatch: Use lists to manage patches, objects and functions

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:26AM +0100, Petr Mladek wrote: > From: Jason Baron > > Currently klp_patch contains a pointer to a statically allocated array of > struct klp_object and struct klp_objects contains a pointer to a statically > allocated array of klp_func. In order to allow for the

Re: [PATCH v14 05/11] livepatch: Simplify API by removing registration step

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:25AM +0100, Petr Mladek wrote: > The possibility to re-enable a registered patch was useful for immediate > patches where the livepatch module had to stay until the system reboot. > The improved consistency model allows to achieve the same result by > unloading and

Re: [PATCH v14 05/11] livepatch: Simplify API by removing registration step

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:25AM +0100, Petr Mladek wrote: > The possibility to re-enable a registered patch was useful for immediate > patches where the livepatch module had to stay until the system reboot. > The improved consistency model allows to achieve the same result by > unloading and

Re: [PATCH 2/2] ARM: Wrap '--pic-veneer' with ld-option

2018-12-05 Thread Peter Smith
On Wed, 5 Dec 2018 at 18:22, Nick Desaulniers wrote: > > On Wed, Dec 5, 2018 at 12:10 AM Ard Biesheuvel > wrote: > > > > (+ Arnd) > > > > On Wed, 5 Dec 2018 at 09:06, Nathan Chancellor > > wrote: > > > > > > On Wed, Dec 05, 2018 at 08:37:05AM +0100, Ard Biesheuvel wrote: > > > > On Wed, 5 Dec

Re: [PATCH 2/2] ARM: Wrap '--pic-veneer' with ld-option

2018-12-05 Thread Peter Smith
On Wed, 5 Dec 2018 at 18:22, Nick Desaulniers wrote: > > On Wed, Dec 5, 2018 at 12:10 AM Ard Biesheuvel > wrote: > > > > (+ Arnd) > > > > On Wed, 5 Dec 2018 at 09:06, Nathan Chancellor > > wrote: > > > > > > On Wed, Dec 05, 2018 at 08:37:05AM +0100, Ard Biesheuvel wrote: > > > > On Wed, 5 Dec

Re: [PATCH] x86/fault: Print "SUPERVISOR" and "READ" when decoding #PF oops

2018-12-05 Thread Randy Dunlap
On 12/5/18 8:36 AM, Sean Christopherson wrote: > ...instead of manually handling the case where error_code=0, e.g. to > display "[SUPERVISOR] [READ]" instead of "normal kernel read fault". > > This makes the zero case consistent with all other messages and also > provides additional information

Re: [PATCH] x86/fault: Print "SUPERVISOR" and "READ" when decoding #PF oops

2018-12-05 Thread Randy Dunlap
On 12/5/18 8:36 AM, Sean Christopherson wrote: > ...instead of manually handling the case where error_code=0, e.g. to > display "[SUPERVISOR] [READ]" instead of "normal kernel read fault". > > This makes the zero case consistent with all other messages and also > provides additional information

Re: [patch 1/2 for-4.20] mm, thp: restore node-local hugepage allocations

2018-12-05 Thread David Rientjes
On Wed, 5 Dec 2018, Michal Hocko wrote: > > > At minimum do not remove the cleanup part which consolidates the gfp > > > hadnling to a single place. There is no real reason to have the > > > __GFP_THISNODE ugliness outside of alloc_hugepage_direct_gfpmask. > > > > > > > The __GFP_THISNODE usage

Re: [patch 1/2 for-4.20] mm, thp: restore node-local hugepage allocations

2018-12-05 Thread David Rientjes
On Wed, 5 Dec 2018, Michal Hocko wrote: > > > At minimum do not remove the cleanup part which consolidates the gfp > > > hadnling to a single place. There is no real reason to have the > > > __GFP_THISNODE ugliness outside of alloc_hugepage_direct_gfpmask. > > > > > > > The __GFP_THISNODE usage

[PATCH] kvm: x86: Report STIBP on GET_SUPPORTED_CPUID

2018-12-05 Thread Eduardo Habkost
Months ago, we have added code to allow direct access to MSR_IA32_SPEC_CTRL to the guest, which makes STIBP available to guests. This was implemented by commits d28b387fb74d ("KVM/VMX: Allow direct access to MSR_IA32_SPEC_CTRL") and b2ac58f90540 ("KVM/SVM: Allow direct access to

[PATCH] kvm: x86: Report STIBP on GET_SUPPORTED_CPUID

2018-12-05 Thread Eduardo Habkost
Months ago, we have added code to allow direct access to MSR_IA32_SPEC_CTRL to the guest, which makes STIBP available to guests. This was implemented by commits d28b387fb74d ("KVM/VMX: Allow direct access to MSR_IA32_SPEC_CTRL") and b2ac58f90540 ("KVM/SVM: Allow direct access to

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-05 Thread Greg KH
On Wed, Dec 05, 2018 at 10:39:56AM -0500, Sven Van Asbroeck wrote: > Hello Greg, thanks for the feedback! > > On Wed, Dec 5, 2018 at 5:17 AM Greg KH wrote: > > And why is this a class and not just a "normal" device and bus? Devices > > live on busses, not generally as a class. Can your devices

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-05 Thread Greg KH
On Wed, Dec 05, 2018 at 10:39:56AM -0500, Sven Van Asbroeck wrote: > Hello Greg, thanks for the feedback! > > On Wed, Dec 5, 2018 at 5:17 AM Greg KH wrote: > > And why is this a class and not just a "normal" device and bus? Devices > > live on busses, not generally as a class. Can your devices

Re: [LKP] [mm] ac5b2c1891: vm-scalability.throughput -61.3% regression

2018-12-05 Thread David Rientjes
On Wed, 5 Dec 2018, Michal Hocko wrote: > > It isn't specific to MADV_HUGEPAGE, it is the policy for all transparent > > hugepage allocations, including defrag=always. We agree that > > MADV_HUGEPAGE is not exactly defined: does it mean try harder to allocate > > a hugepage locally, try

Re: [LKP] [mm] ac5b2c1891: vm-scalability.throughput -61.3% regression

2018-12-05 Thread David Rientjes
On Wed, 5 Dec 2018, Michal Hocko wrote: > > It isn't specific to MADV_HUGEPAGE, it is the policy for all transparent > > hugepage allocations, including defrag=always. We agree that > > MADV_HUGEPAGE is not exactly defined: does it mean try harder to allocate > > a hugepage locally, try

Re: [PATCH v2] kmemleak: Turn kmemleak_lock to raw spinlock on RT

2018-12-05 Thread Sebastian Andrzej Siewior
On 2018-12-05 21:53:37 [+0800], He Zhe wrote: > For call trace 1: … > Since kmemleak would most likely be used to debug in environments where > we would not expect as great performance as without it, and kfree() has raw > locks > in its main path and other debug function paths, I suppose it

Re: [PATCH v2] kmemleak: Turn kmemleak_lock to raw spinlock on RT

2018-12-05 Thread Sebastian Andrzej Siewior
On 2018-12-05 21:53:37 [+0800], He Zhe wrote: > For call trace 1: … > Since kmemleak would most likely be used to debug in environments where > we would not expect as great performance as without it, and kfree() has raw > locks > in its main path and other debug function paths, I suppose it

Re: [RFC PATCH 02/14] mm/hms: heterogenenous memory system (HMS) documentation

2018-12-05 Thread Logan Gunthorpe
On 2018-12-05 11:55 a.m., Jerome Glisse wrote: > So now once next type of device shows up with the exact same thing > let say FPGA, we have to create a new subsystem for them too. Also > this make the userspace life much much harder. Now userspace must > go parse PCIE, subsystem1, subsystem2,

Re: [RFC PATCH 02/14] mm/hms: heterogenenous memory system (HMS) documentation

2018-12-05 Thread Logan Gunthorpe
On 2018-12-05 11:55 a.m., Jerome Glisse wrote: > So now once next type of device shows up with the exact same thing > let say FPGA, we have to create a new subsystem for them too. Also > this make the userspace life much much harder. Now userspace must > go parse PCIE, subsystem1, subsystem2,

Re: [PATCH v14 04/11] livepatch: Refuse to unload only livepatches available during a forced transition

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:24AM +0100, Petr Mladek wrote: > module_put() is currently never called in klp_complete_transition() when > klp_force is set. As a result, we might keep the reference count even when > klp_enable_patch() fails and klp_cancel_transition() is called. > > This might

Re: [PATCH v14 04/11] livepatch: Refuse to unload only livepatches available during a forced transition

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:24AM +0100, Petr Mladek wrote: > module_put() is currently never called in klp_complete_transition() when > klp_force is set. As a result, we might keep the reference count even when > klp_enable_patch() fails and klp_cancel_transition() is called. > > This might

Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-05 Thread Borislav Petkov
On Wed, Dec 05, 2018 at 07:01:58PM +0100, Ingo Molnar wrote: > Oh - I thought we'd have arch/x86/mce/ or so? > > There's machine check events that are not tied to any particular CPU, > correct? So this would be the right conceptual level - and it would also > remove the somewhat redundant

Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-05 Thread Borislav Petkov
On Wed, Dec 05, 2018 at 07:01:58PM +0100, Ingo Molnar wrote: > Oh - I thought we'd have arch/x86/mce/ or so? > > There's machine check events that are not tied to any particular CPU, > correct? So this would be the right conceptual level - and it would also > remove the somewhat redundant

Re: [PATCH 4.14 121/146] x86/fpu: Disable bottom halves while loading FPU registers

2018-12-05 Thread Borislav Petkov
On Wed, Dec 05, 2018 at 06:26:24PM +0200, Jari Ruusu wrote: > That same race appears to be present in older kernel branches also. > The context is sligthly different, so the patch for 4.14 does not > apply cleanly to older kernels. For 4.9 branch, this edit works: You could take the upstream one,

Re: [PATCH 4.14 121/146] x86/fpu: Disable bottom halves while loading FPU registers

2018-12-05 Thread Borislav Petkov
On Wed, Dec 05, 2018 at 06:26:24PM +0200, Jari Ruusu wrote: > That same race appears to be present in older kernel branches also. > The context is sligthly different, so the patch for 4.14 does not > apply cleanly to older kernels. For 4.9 branch, this edit works: You could take the upstream one,

Re: [PATCH v14 03/11] livepatch: Consolidate klp_free functions

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:23AM +0100, Petr Mladek wrote: > The code for freeing livepatch structures is a bit scattered and tricky: > > + direct calls to klp_free_*_limited() and kobject_put() are > used to release partially initialized objects > > + klp_free_patch() removes the

Re: [PATCH v14 03/11] livepatch: Consolidate klp_free functions

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:23AM +0100, Petr Mladek wrote: > The code for freeing livepatch structures is a bit scattered and tricky: > > + direct calls to klp_free_*_limited() and kobject_put() are > used to release partially initialized objects > > + klp_free_patch() removes the

Re: [PATCH] mm/alloc: fallback to first node if the wanted node offline

2018-12-05 Thread David Rientjes
On Wed, 5 Dec 2018, Pingfan Liu wrote: > > > And rather than using first_online_node, would next_online_node() work? > > > > > What is the gain? Is it for memory pressure on node0? > > > Maybe I got your point now. Do you try to give a cheap assumption on > nearest neigh of this node? > It's

Re: [PATCH] mm/alloc: fallback to first node if the wanted node offline

2018-12-05 Thread David Rientjes
On Wed, 5 Dec 2018, Pingfan Liu wrote: > > > And rather than using first_online_node, would next_online_node() work? > > > > > What is the gain? Is it for memory pressure on node0? > > > Maybe I got your point now. Do you try to give a cheap assumption on > nearest neigh of this node? > It's

Re: [RFC PATCH 02/14] mm/hms: heterogenenous memory system (HMS) documentation

2018-12-05 Thread Jerome Glisse
On Wed, Dec 05, 2018 at 11:48:37AM -0700, Logan Gunthorpe wrote: > > > On 2018-12-05 11:33 a.m., Jerome Glisse wrote: > > If i add a a fake driver for those what would i do ? under which > > sub-system i register them ? How i express the fact that they > > connect device X,Y and Z with some

Re: [RFC PATCH 02/14] mm/hms: heterogenenous memory system (HMS) documentation

2018-12-05 Thread Jerome Glisse
On Wed, Dec 05, 2018 at 11:48:37AM -0700, Logan Gunthorpe wrote: > > > On 2018-12-05 11:33 a.m., Jerome Glisse wrote: > > If i add a a fake driver for those what would i do ? under which > > sub-system i register them ? How i express the fact that they > > connect device X,Y and Z with some

Re: [PATCH v2 0/4] add uart DMA function

2018-12-05 Thread Greg Kroah-Hartman
On Wed, Dec 05, 2018 at 10:01:33PM +0530, Vinod Koul wrote: > Hi Greg, > > On 05-12-18, 11:03, Greg Kroah-Hartman wrote: > > On Wed, Dec 05, 2018 at 04:42:56PM +0800, Long Cheng wrote: > > > In Mediatek SOCs, the uart can support DMA function. > > > Base on DMA engine formwork, we add the DMA

Re: [PATCH v2 0/4] add uart DMA function

2018-12-05 Thread Greg Kroah-Hartman
On Wed, Dec 05, 2018 at 10:01:33PM +0530, Vinod Koul wrote: > Hi Greg, > > On 05-12-18, 11:03, Greg Kroah-Hartman wrote: > > On Wed, Dec 05, 2018 at 04:42:56PM +0800, Long Cheng wrote: > > > In Mediatek SOCs, the uart can support DMA function. > > > Base on DMA engine formwork, we add the DMA

Re: [GIT PULL] x86: remove Intel MPX

2018-12-05 Thread Dave Hansen
On 12/5/18 10:42 AM, Konrad Rzeszutek Wilk wrote: > On Wed, Dec 05, 2018 at 08:44:43AM -0800, Dave Hansen wrote: >> Hi x86 maintainers, >> >> Please pull from: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/daveh/x86-mpx.git >> mpx-remove >> >> There is only one commit, removing the

Re: [GIT PULL] x86: remove Intel MPX

2018-12-05 Thread Dave Hansen
On 12/5/18 10:42 AM, Konrad Rzeszutek Wilk wrote: > On Wed, Dec 05, 2018 at 08:44:43AM -0800, Dave Hansen wrote: >> Hi x86 maintainers, >> >> Please pull from: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/daveh/x86-mpx.git >> mpx-remove >> >> There is only one commit, removing the

Re: [RFC PATCH 02/14] mm/hms: heterogenenous memory system (HMS) documentation

2018-12-05 Thread Logan Gunthorpe
On 2018-12-05 11:33 a.m., Jerome Glisse wrote: > If i add a a fake driver for those what would i do ? under which > sub-system i register them ? How i express the fact that they > connect device X,Y and Z with some properties ? Yes this is exactly what I'm suggesting. I wouldn't call it a fake

Re: [RFC PATCH 02/14] mm/hms: heterogenenous memory system (HMS) documentation

2018-12-05 Thread Logan Gunthorpe
On 2018-12-05 11:33 a.m., Jerome Glisse wrote: > If i add a a fake driver for those what would i do ? under which > sub-system i register them ? How i express the fact that they > connect device X,Y and Z with some properties ? Yes this is exactly what I'm suggesting. I wouldn't call it a fake

Re: [PATCH 0/2] tracing: arm64: Make ftrace_replace_code() schedulable for arm64

2018-12-05 Thread Anders Roxell
On Wed, 5 Dec 2018 at 19:33, Steven Rostedt wrote: > > > This is a little more involved, and I would like to push this through my > tree. Can I get a reviewed-by/ack for the second (arm64) patch? > > Anders, can you also test this to make sure that it fixes the issue you > see? Yes of course,

Re: [PATCH 0/2] tracing: arm64: Make ftrace_replace_code() schedulable for arm64

2018-12-05 Thread Anders Roxell
On Wed, 5 Dec 2018 at 19:33, Steven Rostedt wrote: > > > This is a little more involved, and I would like to push this through my > tree. Can I get a reviewed-by/ack for the second (arm64) patch? > > Anders, can you also test this to make sure that it fixes the issue you > see? Yes of course,

Re: [PATCH v14 02/11] livepatch: Shuffle klp_enable_patch()/klp_disable_patch() code

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:22AM +0100, Petr Mladek wrote: > We are going to simplify the API and code by removing the registration > step. This would require calling init/free functions from enable/disable > ones. > > This patch just moves the code to prevent more forward declarations. > >

Re: [PATCH v14 02/11] livepatch: Shuffle klp_enable_patch()/klp_disable_patch() code

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:22AM +0100, Petr Mladek wrote: > We are going to simplify the API and code by removing the registration > step. This would require calling init/free functions from enable/disable > ones. > > This patch just moves the code to prevent more forward declarations. > >

Re: [PATCH v14 01/11] livepatch: Change unsigned long old_addr -> void *old_func in struct klp_func

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:21AM +0100, Petr Mladek wrote: > The address of the to be patched function and new function is stored > in struct klp_func as: > > void *new_func; > unsigned long old_addr; > > The different naming scheme and type is derived from the way how

Re: [PATCH v14 01/11] livepatch: Change unsigned long old_addr -> void *old_func in struct klp_func

2018-12-05 Thread Joe Lawrence
On Thu, Nov 29, 2018 at 10:44:21AM +0100, Petr Mladek wrote: > The address of the to be patched function and new function is stored > in struct klp_func as: > > void *new_func; > unsigned long old_addr; > > The different naming scheme and type is derived from the way how

Re: [GIT PULL] x86: remove Intel MPX

2018-12-05 Thread Konrad Rzeszutek Wilk
On Wed, Dec 05, 2018 at 08:44:43AM -0800, Dave Hansen wrote: > Hi x86 maintainers, > > Please pull from: > > git://git.kernel.org/pub/scm/linux/kernel/git/daveh/x86-mpx.git > mpx-remove > > There is only one commit, removing the Intel MPX implementation from the > tree. The benefits of

Re: [GIT PULL] x86: remove Intel MPX

2018-12-05 Thread Konrad Rzeszutek Wilk
On Wed, Dec 05, 2018 at 08:44:43AM -0800, Dave Hansen wrote: > Hi x86 maintainers, > > Please pull from: > > git://git.kernel.org/pub/scm/linux/kernel/git/daveh/x86-mpx.git > mpx-remove > > There is only one commit, removing the Intel MPX implementation from the > tree. The benefits of

Re: [PATCH 2/2] ARM: Wrap '--pic-veneer' with ld-option

2018-12-05 Thread Nick Desaulniers
On Wed, Dec 5, 2018 at 10:40 AM Ard Biesheuvel wrote: > > On Wed, 5 Dec 2018 at 19:36, Nathan Chancellor > wrote: > > > > On Wed, Dec 05, 2018 at 09:09:56AM +0100, Ard Biesheuvel wrote: > > > (+ Arnd) > > > > > > On Wed, 5 Dec 2018 at 09:06, Nathan Chancellor > > > wrote: > > > > > > > > On

Re: [PATCH 2/2] ARM: Wrap '--pic-veneer' with ld-option

2018-12-05 Thread Nick Desaulniers
On Wed, Dec 5, 2018 at 10:40 AM Ard Biesheuvel wrote: > > On Wed, 5 Dec 2018 at 19:36, Nathan Chancellor > wrote: > > > > On Wed, Dec 05, 2018 at 09:09:56AM +0100, Ard Biesheuvel wrote: > > > (+ Arnd) > > > > > > On Wed, 5 Dec 2018 at 09:06, Nathan Chancellor > > > wrote: > > > > > > > > On

Re: [PATCH 2/2] ARM: Wrap '--pic-veneer' with ld-option

2018-12-05 Thread Nick Desaulniers
On Wed, Dec 5, 2018 at 10:36 AM Nathan Chancellor wrote: > > On Wed, Dec 05, 2018 at 09:09:56AM +0100, Ard Biesheuvel wrote: > > (+ Arnd) > > > > On Wed, 5 Dec 2018 at 09:06, Nathan Chancellor > > wrote: > > > > > > On Wed, Dec 05, 2018 at 08:37:05AM +0100, Ard Biesheuvel wrote: > > > > On Wed,

Re: [PATCH 2/2] ARM: Wrap '--pic-veneer' with ld-option

2018-12-05 Thread Nick Desaulniers
On Wed, Dec 5, 2018 at 10:36 AM Nathan Chancellor wrote: > > On Wed, Dec 05, 2018 at 09:09:56AM +0100, Ard Biesheuvel wrote: > > (+ Arnd) > > > > On Wed, 5 Dec 2018 at 09:06, Nathan Chancellor > > wrote: > > > > > > On Wed, Dec 05, 2018 at 08:37:05AM +0100, Ard Biesheuvel wrote: > > > > On Wed,

Re: [PATCH 2/2] ARM: Wrap '--pic-veneer' with ld-option

2018-12-05 Thread Ard Biesheuvel
On Wed, 5 Dec 2018 at 19:36, Nathan Chancellor wrote: > > On Wed, Dec 05, 2018 at 09:09:56AM +0100, Ard Biesheuvel wrote: > > (+ Arnd) > > > > On Wed, 5 Dec 2018 at 09:06, Nathan Chancellor > > wrote: > > > > > > On Wed, Dec 05, 2018 at 08:37:05AM +0100, Ard Biesheuvel wrote: > > > > On Wed, 5

Re: [PATCH 2/2] ARM: Wrap '--pic-veneer' with ld-option

2018-12-05 Thread Ard Biesheuvel
On Wed, 5 Dec 2018 at 19:36, Nathan Chancellor wrote: > > On Wed, Dec 05, 2018 at 09:09:56AM +0100, Ard Biesheuvel wrote: > > (+ Arnd) > > > > On Wed, 5 Dec 2018 at 09:06, Nathan Chancellor > > wrote: > > > > > > On Wed, Dec 05, 2018 at 08:37:05AM +0100, Ard Biesheuvel wrote: > > > > On Wed, 5

Re: [PATCH 10/12] staging: rtl8188eu: correct indentation in update_wireless_mode()

2018-12-05 Thread Michael Straube
On 12/5/18 6:37 PM, Joe Perches wrote: On Wed, 2018-12-05 at 18:02 +0100, Michael Straube wrote: Correct indentation in update_wireless_mode() to clear a checkpatch warning. WARNING: Statements should start on a tabstop [] diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c

Re: [PATCH 10/12] staging: rtl8188eu: correct indentation in update_wireless_mode()

2018-12-05 Thread Michael Straube
On 12/5/18 6:37 PM, Joe Perches wrote: On Wed, 2018-12-05 at 18:02 +0100, Michael Straube wrote: Correct indentation in update_wireless_mode() to clear a checkpatch warning. WARNING: Statements should start on a tabstop [] diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c

Re: [PATCH 2/2] ARM: Wrap '--pic-veneer' with ld-option

2018-12-05 Thread Nathan Chancellor
On Wed, Dec 05, 2018 at 09:09:56AM +0100, Ard Biesheuvel wrote: > (+ Arnd) > > On Wed, 5 Dec 2018 at 09:06, Nathan Chancellor > wrote: > > > > On Wed, Dec 05, 2018 at 08:37:05AM +0100, Ard Biesheuvel wrote: > > > On Wed, 5 Dec 2018 at 02:42, Nathan Chancellor > > > wrote: > > > > > > > > This

Re: [PATCH 2/2] ARM: Wrap '--pic-veneer' with ld-option

2018-12-05 Thread Nathan Chancellor
On Wed, Dec 05, 2018 at 09:09:56AM +0100, Ard Biesheuvel wrote: > (+ Arnd) > > On Wed, 5 Dec 2018 at 09:06, Nathan Chancellor > wrote: > > > > On Wed, Dec 05, 2018 at 08:37:05AM +0100, Ard Biesheuvel wrote: > > > On Wed, 5 Dec 2018 at 02:42, Nathan Chancellor > > > wrote: > > > > > > > > This

[PATCH 0/2] tracing: arm64: Make ftrace_replace_code() schedulable for arm64

2018-12-05 Thread Steven Rostedt
This is a little more involved, and I would like to push this through my tree. Can I get a reviewed-by/ack for the second (arm64) patch? Anders, can you also test this to make sure that it fixes the issue you see? Thanks! -- Steve Steven Rostedt (VMware) (2): ftrace: Allow

[PATCH 0/2] tracing: arm64: Make ftrace_replace_code() schedulable for arm64

2018-12-05 Thread Steven Rostedt
This is a little more involved, and I would like to push this through my tree. Can I get a reviewed-by/ack for the second (arm64) patch? Anders, can you also test this to make sure that it fixes the issue you see? Thanks! -- Steve Steven Rostedt (VMware) (2): ftrace: Allow

Re: [PATCH v2] arm64: dts: qcom: sdm845: Add UART nodes

2018-12-05 Thread Andy Gross
On Tue, Dec 04, 2018 at 12:37:18PM -0800, Matthias Kaehlcke wrote: > Hi Andy, > > can this be landed or are any more changes needed? > > Thanks I'll see about adding it to the second pull request. Thank, Andy

[PATCH v2 01/12] staging: rtl8188eu: refactor cckrates_included()

2018-12-05 Thread Michael Straube
Refactor cckrates_included() to improve readability and slightly reduce object file size. Also change the return type to bool. Signed-off-by: Michael Straube --- v1 -> v2 Changed patch 10/12 in the series. v1: staging: rtl8188eu: correct indentation in update_wireless_mode() v2: staging:

[PATCH 2/2] arm64: ftrace: Set FTRACE_SCHEDULABLE before ftrace_modify_all_code()

2018-12-05 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" It has been reported that ftrace_replace_code() which is called by ftrace_modify_all_code() can cause a soft lockup warning for an allmodconfig kernel. This is because all the debug options enabled causes the loop in ftrace_replace_code() (which loops over all the

Re: perf: perf_fuzzer triggers GPF in perf_prepare_sample

2018-12-05 Thread Jiri Olsa
On Wed, Dec 05, 2018 at 12:11:19PM -0500, Vince Weaver wrote: > On Wed, 5 Dec 2018, Jiri Olsa wrote: > > > On Wed, Dec 05, 2018 at 01:45:38PM +0100, Jiri Olsa wrote: > > > On Tue, Dec 04, 2018 at 10:54:55AM -0500, Vince Weaver wrote: > > > > Hello, > > > > > > > > I was able to trigger another

Re: [PATCH v2] arm64: dts: qcom: sdm845: Add UART nodes

2018-12-05 Thread Andy Gross
On Tue, Dec 04, 2018 at 12:37:18PM -0800, Matthias Kaehlcke wrote: > Hi Andy, > > can this be landed or are any more changes needed? > > Thanks I'll see about adding it to the second pull request. Thank, Andy

[PATCH v2 01/12] staging: rtl8188eu: refactor cckrates_included()

2018-12-05 Thread Michael Straube
Refactor cckrates_included() to improve readability and slightly reduce object file size. Also change the return type to bool. Signed-off-by: Michael Straube --- v1 -> v2 Changed patch 10/12 in the series. v1: staging: rtl8188eu: correct indentation in update_wireless_mode() v2: staging:

[PATCH 2/2] arm64: ftrace: Set FTRACE_SCHEDULABLE before ftrace_modify_all_code()

2018-12-05 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" It has been reported that ftrace_replace_code() which is called by ftrace_modify_all_code() can cause a soft lockup warning for an allmodconfig kernel. This is because all the debug options enabled causes the loop in ftrace_replace_code() (which loops over all the

Re: perf: perf_fuzzer triggers GPF in perf_prepare_sample

2018-12-05 Thread Jiri Olsa
On Wed, Dec 05, 2018 at 12:11:19PM -0500, Vince Weaver wrote: > On Wed, 5 Dec 2018, Jiri Olsa wrote: > > > On Wed, Dec 05, 2018 at 01:45:38PM +0100, Jiri Olsa wrote: > > > On Tue, Dec 04, 2018 at 10:54:55AM -0500, Vince Weaver wrote: > > > > Hello, > > > > > > > > I was able to trigger another

Re: [RFC PATCH 02/14] mm/hms: heterogenenous memory system (HMS) documentation

2018-12-05 Thread Jerome Glisse
On Wed, Dec 05, 2018 at 11:20:30AM -0700, Logan Gunthorpe wrote: > > > On 2018-12-05 11:07 a.m., Jerome Glisse wrote: > >> Well multiple links are easy when you have a 'link' bus. Just add > >> another link device under the bus. > > > > So you are telling do what i am doing in this patchset but

Re: [RFC PATCH 02/14] mm/hms: heterogenenous memory system (HMS) documentation

2018-12-05 Thread Jerome Glisse
On Wed, Dec 05, 2018 at 11:20:30AM -0700, Logan Gunthorpe wrote: > > > On 2018-12-05 11:07 a.m., Jerome Glisse wrote: > >> Well multiple links are easy when you have a 'link' bus. Just add > >> another link device under the bus. > > > > So you are telling do what i am doing in this patchset but

[PATCH 1/2] ftrace: Allow ftrace_replace_code() to be schedulable

2018-12-05 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" The function ftrace_replace_code() is the ftrace engine that does the work to modify all the nops into the calls to the function callback in all the functions being traced. The generic version which is normally called from stop machine, but an architecture can

[PATCH 1/2] ftrace: Allow ftrace_replace_code() to be schedulable

2018-12-05 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" The function ftrace_replace_code() is the ftrace engine that does the work to modify all the nops into the calls to the function callback in all the functions being traced. The generic version which is normally called from stop machine, but an architecture can

[PATCH v2 06/12] staging: rtl8188eu: cleanup block comment in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Cleanup a block comment to clear a checkpatch warning. WARNING: Block comments use * on subsequent lines Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v2 04/12] staging: rtl8188eu: remove unnecessary parentheses in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Remove unnecessary parentheses reported by checkpatch. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_wlan_util.c| 64 +-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c

[PATCH v2 06/12] staging: rtl8188eu: cleanup block comment in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Cleanup a block comment to clear a checkpatch warning. WARNING: Block comments use * on subsequent lines Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v2 04/12] staging: rtl8188eu: remove unnecessary parentheses in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Remove unnecessary parentheses reported by checkpatch. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_wlan_util.c| 64 +-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c

[PATCH v2 09/12] staging: rtl8188eu: write out multiplying in wifirate2_ratetbl_inx()

2018-12-05 Thread Michael Straube
Write out multiplying in wifirate2_ratetbl_inx() to improve readabilitiy and clear checkpatch issues with missing spaces around '*' operator. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_wlan_util.c| 22 +-- 1 file changed, 11 insertions(+), 11

[PATCH v2 09/12] staging: rtl8188eu: write out multiplying in wifirate2_ratetbl_inx()

2018-12-05 Thread Michael Straube
Write out multiplying in wifirate2_ratetbl_inx() to improve readabilitiy and clear checkpatch issues with missing spaces around '*' operator. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_wlan_util.c| 22 +-- 1 file changed, 11 insertions(+), 11

[PATCH v2 05/12] staging: rtl8188eu: cleanup declarations in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Replace tabs with spaces and/or remove spaces in declarations to cleanup whitespace. Remove unused/commented declarations. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_wlan_util.c| 175 +- 1 file changed, 86 insertions(+), 89 deletions(-) diff --git

[PATCH v2 05/12] staging: rtl8188eu: cleanup declarations in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Replace tabs with spaces and/or remove spaces in declarations to cleanup whitespace. Remove unused/commented declarations. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_wlan_util.c| 175 +- 1 file changed, 86 insertions(+), 89 deletions(-) diff --git

Re: [PATCH v2 22/34] dt-bindings: arm: Convert QCom board/soc bindings to json-schema

2018-12-05 Thread Andy Gross
On Mon, Dec 03, 2018 at 03:32:11PM -0600, Rob Herring wrote: > Convert QCom SoC bindings to DT schema format using json-schema. > > Cc: Andy Gross > Cc: David Brown > Cc: Mark Rutland > Cc: devicet...@vger.kernel.org > Signed-off-by: Rob Herring Acked-by: Andy Gross

Re: [PATCH v2 22/34] dt-bindings: arm: Convert QCom board/soc bindings to json-schema

2018-12-05 Thread Andy Gross
On Mon, Dec 03, 2018 at 03:32:11PM -0600, Rob Herring wrote: > Convert QCom SoC bindings to DT schema format using json-schema. > > Cc: Andy Gross > Cc: David Brown > Cc: Mark Rutland > Cc: devicet...@vger.kernel.org > Signed-off-by: Rob Herring Acked-by: Andy Gross

[PATCH v2 10/12] staging: rtl8188eu: replace if else with ternary operator

2018-12-05 Thread Michael Straube
Replace if else with a single call and ternary operator to slightly reduce object file size. Also clears a checkpatch warning: WARNING: Statements should start on a tabstop Suggested-by: Joe Perches Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 7 +++

[PATCH v2 08/12] staging: rtl8188eu: add spaces around operators in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Add spaces around '+', '-', '&' and '>>' to follow kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_wlan_util.c| 21 +++ 1 file changed, 12 insertions(+), 9 deletions(-) diff --git

[PATCH v2 10/12] staging: rtl8188eu: replace if else with ternary operator

2018-12-05 Thread Michael Straube
Replace if else with a single call and ternary operator to slightly reduce object file size. Also clears a checkpatch warning: WARNING: Statements should start on a tabstop Suggested-by: Joe Perches Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 7 +++

[PATCH v2 08/12] staging: rtl8188eu: add spaces around operators in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Add spaces around '+', '-', '&' and '>>' to follow kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_wlan_util.c| 21 +++ 1 file changed, 12 insertions(+), 9 deletions(-) diff --git

[PATCH v2 02/12] staging: rtl8188eu: refactor cckratesonly_included()

2018-12-05 Thread Michael Straube
Refactor cckratesonly_included() to improve readability and slightly reduce object file size. Also change the return type to bool. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 10 +- drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 +- 2

[PATCH v2 07/12] staging: rtl8188eu: cleanup long lines in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Cleanup some lines over 80 characters by adding appropriate line breaks and removing commented code. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v2 02/12] staging: rtl8188eu: refactor cckratesonly_included()

2018-12-05 Thread Michael Straube
Refactor cckratesonly_included() to improve readability and slightly reduce object file size. Also change the return type to bool. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 10 +- drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 +- 2

[PATCH v2 07/12] staging: rtl8188eu: cleanup long lines in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Cleanup some lines over 80 characters by adding appropriate line breaks and removing commented code. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v2 11/12] staging: rtl8188eu: rename struct field Wifi_Error_Status

2018-12-05 Thread Michael Straube
Rename struct field Wifi_Error_Status to avoid CamelCase. Wifi_Error_Status -> wifi_error_status Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_sreset.c | 4 ++-- drivers/staging/rtl8188eu/include/rtw_sreset.h | 2 +-

[PATCH v2 12/12] staging: rtl8188eu: remove unused code in rtw_cmd.c

2018-12-05 Thread Michael Straube
Remove unused/commented code in rtw_cmd.c. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c index

[PATCH v2 11/12] staging: rtl8188eu: rename struct field Wifi_Error_Status

2018-12-05 Thread Michael Straube
Rename struct field Wifi_Error_Status to avoid CamelCase. Wifi_Error_Status -> wifi_error_status Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_sreset.c | 4 ++-- drivers/staging/rtl8188eu/include/rtw_sreset.h | 2 +-

[PATCH v2 12/12] staging: rtl8188eu: remove unused code in rtw_cmd.c

2018-12-05 Thread Michael Straube
Remove unused/commented code in rtw_cmd.c. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c index

[PATCH v2 03/12] staging: rtl8188eu: simplify array initializations

2018-12-05 Thread Michael Straube
Simplfy initialization of arrays with zero only values to improve readability and save a line. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH v2 03/12] staging: rtl8188eu: simplify array initializations

2018-12-05 Thread Michael Straube
Simplfy initialization of arrays with zero only values to improve readability and save a line. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v6 10/24] arm64: irqflags: Use ICC_PMR_EL1 for interrupt masking

2018-12-05 Thread Catalin Marinas
On Wed, Dec 05, 2018 at 04:55:54PM +, Julien Thierry wrote: > On 04/12/18 17:36, Catalin Marinas wrote: > > On Mon, Nov 12, 2018 at 11:57:01AM +, Julien Thierry wrote: > >> diff --git a/arch/arm64/include/asm/irqflags.h > >> b/arch/arm64/include/asm/irqflags.h > >> index 24692ed..e0a32e4

Re: [PATCH v6 10/24] arm64: irqflags: Use ICC_PMR_EL1 for interrupt masking

2018-12-05 Thread Catalin Marinas
On Wed, Dec 05, 2018 at 04:55:54PM +, Julien Thierry wrote: > On 04/12/18 17:36, Catalin Marinas wrote: > > On Mon, Nov 12, 2018 at 11:57:01AM +, Julien Thierry wrote: > >> diff --git a/arch/arm64/include/asm/irqflags.h > >> b/arch/arm64/include/asm/irqflags.h > >> index 24692ed..e0a32e4

Re: [PATCH 4.19 000/139] 4.19.7-stable review

2018-12-05 Thread Greg Kroah-Hartman
On Wed, Dec 05, 2018 at 07:51:28PM +0530, Harsh Shandilya wrote: > On 4 December 2018 4:18:01 PM IST, Greg Kroah-Hartman > wrote: > >This is the start of the stable review cycle for the 4.19.7 release. > >There are 139 patches in this series, all will be posted as a response > >to this one. If

Re: [PATCH 4.19 000/139] 4.19.7-stable review

2018-12-05 Thread Greg Kroah-Hartman
On Wed, Dec 05, 2018 at 07:51:28PM +0530, Harsh Shandilya wrote: > On 4 December 2018 4:18:01 PM IST, Greg Kroah-Hartman > wrote: > >This is the start of the stable review cycle for the 4.19.7 release. > >There are 139 patches in this series, all will be posted as a response > >to this one. If

<    4   5   6   7   8   9   10   11   12   13   >