On Fri, 2018-12-21 at 19:31 +0100, Matthias Brugger wrote:
>
> On 08/12/2018 09:39, Yong Wu wrote:
> > The M4U IP blocks in mt8183 is MediaTek's generation2 M4U which use
> > the ARM Short-descriptor like mt8173, and most of the HW registers
> > are the same.
> >
> > Here list main differences
On Fri, 2018-12-21 at 18:47 +0100, Matthias Brugger wrote:
>
> On 08/12/2018 09:39, Yong Wu wrote:
> > The config_port of mt2712 and mt8183 are the same. Use a general
> > config_port interface instead.
> >
> > In addition, in mt2712, larb8 and larb9 are the bdpsys larbs which
> > are not the
On Sat, 2018-12-22 at 08:31 +0800, Nicolas Boichat wrote:
> On Fri, Dec 21, 2018 at 4:02 PM Yong Wu wrote:
> >
> > On Fri, 2018-12-21 at 12:43 +0800, Nicolas Boichat wrote:
> > > On Sat, Dec 8, 2018 at 4:42 PM Yong Wu wrote:
> > > >
> > > > The M4U IP blocks in mt8183 is MediaTek's generation2
Remove inc_nlink in debugfs_create_automount, or this inode will never
be free.
Signed-off-by: yangerkun
---
fs/debugfs/inode.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
index 13b0135..9e6e225 100644
--- a/fs/debugfs/inode.c
+++
On 12/21/18 4:14 PM, Sinan Kaya wrote:
> IOSF_MBI driver depends on CONFIG_PCI set but this is not specified
> anywhere.
wrong patch description...?
> Signed-off-by: Sinan Kaya
> ---
> sound/soc/intel/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On Sat, Dec 22, 2018 at 10:12:21AM +0800, Yafang Shao wrote:
> The callers of insert_header() will drop sysctl table whatever
> insert_header() successes or fails.
> So we can't call drop_sysctl_table() in insert_header().
>
> The call sites of insert_header() are all in fs/proc/proc_sysctl.c.
According to The Guide To Mac Family Hardware, this is the correct way
to disable the VBL interrupt. The confusing comment here doesn't add any
value so remove it.
Signed-off-by: Finn Thain
---
arch/m68k/mac/via.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/m68k/mac/via.c
The comment says that calling the ROM routine doesn't work. But testing
shows that the 68030 fall-back reset method does work, so just use that.
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
arch/m68k/mac/misc.c | 18 --
1 file changed, 4 insertions(+), 14 deletions(-)
Those Mac models which don't connect their RTC to VIA1 port B probably
have something else connected to those pins. Just leave them the way we
found them. Make the port B setup conditional on via_type, to match the
RTC accessors in arch/m68k/mac/misc.c.
Signed-off-by: Finn Thain
---
Signed-off-by: Finn Thain
---
arch/m68k/include/asm/macints.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/m68k/include/asm/macints.h b/arch/m68k/include/asm/macints.h
index cddb2d3ea49b..4da172bd048c 100644
--- a/arch/m68k/include/asm/macints.h
+++
Hi,
On Fri, Dec 21, 2018 at 03:10:52PM -0600, Adam Ford wrote:
> On Fri, Dec 21, 2018 at 2:13 AM Sebastian Reichel wrote:
> >
> > From: Sebastian Reichel
> >
> > This driver has been superseded by the serdev based Bluetooth
> > hci_ll driver, which is initialized from DT. All mainline users
> >
Hi Li,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tty/tty-testing]
[also build test ERROR on v4.20-rc7 next-20181221]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
This is two simple target fixes and one discard related I/O starvation
problem in sd. The discard problem occurs because the discard page
doesn't have a mempool backing so if the allocation fails due to memory
pressure, we then lose the forward progress we require if the writeout
is on the same
Hi,
On Fri, Dec 21, 2018 at 10:02:05AM -0800, Tony Lindgren wrote:
> * Sebastian Reichel [181221 01:18]:
> > The new code has been tested on the Motorola Droid 4. For testing the audio
> > should be configured to route Ext to Speaker or Headphone. Then you need to
> > plug headphone, since its
On Fri, 21 Dec 2018 18:32:57 +0100
Gregory CLEMENT wrote:
> + PIN_GRP_GPIO("pcie1", 3, 1, BIT(5), "pcie"),
> + PIN_GRP_GPIO("pcie1_clkreq", 4, 1, BIT(9), "pcie"),
If the pair is split to clkreq and reset, shouldn't the first be called
pcie1_reset?
Marek
On Fri, 2018-12-07 at 09:22 +0100, Nicholas Mc Guire wrote:
> devm_kstrdup() may return NULL if internal allocation failed, but
> as machine is from the device tree, and thus RO, devm_kstrdup_const()
> can be used here, which will only copy the reference.
Is it really going to only copy the
Commit d5052a7130a6 ("x86/efi: Unmap EFI boot services code/data regions
from efi_pgd") forgets to take two EFI modes into consideration namely
EFI_OLD_MEMMAP and EFI_MIXED_MODE.
EFI_OLD_MEMMAP is a legacy way of mapping EFI regions into swapper_pg_dir
using ioremap() and init_memory_mapping().
On 2018/12/22 3:28, Martin Blumenstingl wrote:
> Treat "block_count" from struct f2fs_super_block as 64-bit little endian
> value in sanity_check_raw_super() because struct f2fs_super_block
> declares "block_count" as "__le64".
>
> This fixes a bug where the superblock validation fails on big
The callers of insert_header() will drop sysctl table whatever
insert_header() successes or fails.
So we can't call drop_sysctl_table() in insert_header().
The call sites of insert_header() are all in fs/proc/proc_sysctl.c.
Signed-off-by: Yafang Shao
---
fs/proc/proc_sysctl.c | 1 -
1 file
On Thu, 2018-11-15 at 23:26 +0530, Sabyasachi Gupta wrote:
> On Mon, Nov 5, 2018 at 7:52 AM Sabyasachi Gupta
> wrote:
> >
> > Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
> >
> > Signed-off-by: Sabyasachi Gupta
>
> Any comment on this patch?
Just that FSL patches should be
On Thu, Dec 20, 2018 at 11:32 AM Wendy Liang wrote:
> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c
> b/drivers/mailbox/zynqmp-ipi-mailbox.c
> new file mode 100644
> index 000..bbddfd5
> --- /dev/null
> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
> @@ -0,0 +1,764 @@
..
> +
> +/*
On Thu, Dec 20, 2018 at 08:16:35PM +0530, Balakrishna Godavarthi wrote:
> wcn3990 requires a power pulse to turn ON/OFF along with
> regulators. Sometimes we are observing the power pulses are sent
> out with some time delay, due to queuing these commands. This is
> causing synchronization issues
On 12/21/18 1:59 PM, Ben Greear wrote:
> On 12/21/18 9:44 AM, Tim Chen wrote:
>> Thomas,
>>
>> Andi and I have made an update to our draft of the Spectre admin guide.
>> We may be out on Christmas vacation for a while. But we want to
>> send it out for everyone to take a look.
>
> Can you add a
On 12/21/18 2:42 PM, Tim Chen wrote:
On 12/21/18 1:40 PM, Yang Shi wrote:
Swap readahead would read in a few pages regardless if the underlying
device is busy or not. It may incur long waiting time if the device is
congested, and it may also exacerbate the congestion.
Use
On Fri, Dec 21, 2018 at 03:05:29PM -0600, Kangjie Lu wrote:
> Hi Dmitry,
>
> Thanks for the feedback.
>
> On Fri, Dec 21, 2018 at 2:27 AM Dmitry Torokhov
> wrote:
>
> > Hi Kangjie,
> >
> > On Fri, Dec 21, 2018 at 12:59:16AM -0600, Kangjie Lu wrote:
> > > elants_i2c_send() may fail, let's check
On Fri, Dec 21, 2018 at 11:12:41PM +, Colin King wrote:
> From: Colin Ian King
>
> There are some statements that are indented incorrectly, fix this by
> removinf the extra tabs.
>
> Signed-off-by: Colin Ian King
Applied, thank you.
> ---
> drivers/input/misc/drv2667.c | 6 +++---
> 1
On 12/21/18 12:49 PM, Pierre-Louis Bossart wrote:
> Remove warnings by selecting SND_HDA_INTEL_DSP_DETECTION_XYZ only when
> SND_HDA_INTEL is part of the config.
>
> Fixes: c337104b1a16 ('ALSA: HD-Audio: SKL+: abort probe if DSP is present and
> Skylake driver selected')
> Reported-by: Randy
On Fri, Dec 21, 2018 at 10:55 AM Trent Piepho wrote:
>
> On Thu, 2018-12-20 at 23:27 -0800, Andrey Smirnov wrote:
> > Until commit 4d107d3b5a68 ("PCI: imx6: Move link up check into
> > imx6_pcie_wait_for_link()") the driver relied on both LINK_UP and
> > LINK_IN_TRAINING to determine if PCIE link
On Fri, 21 Dec 2018 16:32:58 -0800
Linus Torvalds wrote:
> On Fri, Dec 21, 2018, 16:06 Steven Rostedt
> > On Fri, 21 Dec 2018 18:13:16
> >
> > And I'll make a separate patch that adds:
> >
> > static __always_inline bool
> > str_has_prefix_len(const char *str, const char *prefix, unsigned int
On Fri, Dec 21, 2018 at 4:02 PM Yong Wu wrote:
>
> On Fri, 2018-12-21 at 12:43 +0800, Nicolas Boichat wrote:
> > On Sat, Dec 8, 2018 at 4:42 PM Yong Wu wrote:
> > >
> > > The M4U IP blocks in mt8183 is MediaTek's generation2 M4U which use
> > > the ARM Short-descriptor like mt8173, and most of
On Thu, Dec 20, 2018 at 08:16:36PM +0530, Balakrishna Godavarthi wrote:
> This patch will help to stop frame reassembly errors while changing
> the baudrate. This is because host send a change baudrate request
> command to the chip with 115200 bps, Whereas chip will change their
> UART clocks to
From: Sai Praneeth Prakhya
The basic resctrl file system operations and data are added for future
usage by resctrl selftest tool.
Signed-off-by: Sai Praneeth Prakhya
Signed-off-by: Arshiya Hayatkhan Pathan
Signed-off-by: Fenghua Yu
---
tools/testing/selftests/resctrl/Makefile| 10 +
From: Arshiya Hayatkhan Pathan
Cache Allocation Technology (CAT) selftest allocates a portion of
last level cache and starts a benchmark to read each cache
line in this portion of cache. Measure the cache misses in perf and
the misses should be equal to the number of cache lines in this
portion
From: Arshiya Hayatkhan Pathan
MBA (Memory Bandwidth Allocation) test starts a stressful memory
bandwidth benchmark and allocates memory bandwidth from 100% down
to 10% for the benchmark process. For each allocation, compare
perf IMC counter and mbm total bytes from resctrl. The difference
On Fri, Dec 21, 2018 at 11:57:53AM +0100, Jinpu Wang wrote:
+cc Greg, stable
Greensky, James J 于2018年12月21日周五 上午11:48写道：
Commit d38d272592737ea88a20 ("perf tools: Synthesize GROUP_DESC feature in pipe
mode") broke the LT 4.14 branch when using event groups in pipe-mode.
# perf record -e
resctrl tests will be implemented. README is added for the tool first.
Signed-off-by: Fenghua Yu
---
tools/testing/selftests/resctrl/README | 53 ++
1 file changed, 53 insertions(+)
create mode 100644 tools/testing/selftests/resctrl/README
diff --git
From: Sai Praneeth Prakhya
Total memory bandwidth can be monitored from perf IMC counter and from
resctrl file system. Later the two will be compared to verify the total
memory bandwidth read from resctrl is correct.
Signed-off-by: Sai Praneeth Prakhya
Signed-off-by: Arshiya Hayatkhan Pathan
From: Sai Praneeth Prakhya
The callback starts a child process and puts the child pid in created
resctrl group with specified memory bandwidth in schemata. The child
starts running benchmark.
Signed-off-by: Sai Praneeth Prakhya
Signed-off-by: Arshiya Hayatkhan Pathan
Signed-off-by: Fenghua Yu
With more and more resctrl features are being added by Intel, AMD
and ARM, a test tool is becoming more and more useful to validate
that both hardware and software functionalities work as expected.
We introduce resctrl selftest to cover resctrl features on both
X86 and ARM architectures. It first
From: Arshiya Hayatkhan Pathan
MBM (Memory Bandwidth Monitoring) test is the first implemented selftest.
It starts a stressful memory bandwidth benchmark and assigns the
bandwidth pid in a resctrl monitoring group. Read and compare perf IMC
counter and MBM total bytes for the benchmark. The
From: Arshiya Hayatkhan Pathan
Cache QoS Monitoring (CQM) selftest starts stressful cache benchmark
with specified size of memory to access the cache. Last Level cache
occupancy reported by CQM should be close to the size of the memory.
Signed-off-by: Arshiya Hayatkhan Pathan
Signed-off-by:
From: Sai Praneeth Prakhya
Built-in benchmark fill_buf generates stressful memory bandwidth
and cache traffic.
Later it will be used as a default benchmark by various resctrl tests
such as MBA (Memory Bandwidth Allocation) and MBM (Memory Bandwidth
Monitoring) tests.
Signed-off-by: Sai
The resctrl selftest will be maintained by RDT maintainers.
Signed-off-by: Fenghua Yu
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 842b697a1511..edafdecb1e41 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12650,6 +12650,7 @@ S:
(fixed "Palmpalmer" again, might want to check your script for sending
patches)
On Fri, 21 Dec 2018, Alistair Francis wrote:
> Enable generic PCIe by default in the RISC-V defconfig, this allows us
> to use QEMU's PCIe support out of the box.
>
> Signed-off-by: Alistair Francis
Thanks for
On Fri, 2018-12-21 at 19:06 -0500, Steven Rostedt wrote:
> On Fri, 21 Dec 2018 18:13:16 -0500
> Steven Rostedt wrote:
>
> > +static __always_inline int str_has_prefix(const char *str, const char
> > *prefix)
>
> I'm thinking it is cleaner to have two helper functions and have them
> both
This driver depends on the PCI infrastructure but the dependency has not
been explicitly called out.
Signed-off-by: Sinan Kaya
---
drivers/gpu/vga/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/vga/Kconfig b/drivers/gpu/vga/Kconfig
index b677e5d524e6..d5f1d8e1c6f8
This driver is both a platform and PCI driver. Hide PCI specific pieces
when CONFIG_PCI is unset.
Signed-off-by: Sinan Kaya
---
.../intel/int340x_thermal/processor_thermal_device.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
Code is scanning PCI bus to find out if it is switchable or not. If
CONFIG_PCI is not set, assume unswitchable.
Signed-off-by: Sinan Kaya
---
drivers/platform/x86/apple-gmux.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/platform/x86/apple-gmux.c
IOSF_MBI driver depends on CONFIG_PCI set but this is not specified
anywhere.
Signed-off-by: Sinan Kaya
---
sound/soc/intel/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index 2fd1b61e8331..b0764b2fe001 100644
---
PATA_ACPI is a PCI device driver but the PCI dependency has not been
explicitly called out.
Signed-off-by: Sinan Kaya
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 4ca7a6b4eaae..8218db17ebdb 100644
---
Select IOSF_MBI only when PCI is set.
Signed-off-by: Sinan Kaya
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index e26b8145efb3..4c5f037b246d 100644
--- a/drivers/mmc/host/Kconfig
+++
ipss driver is a PCI device driver but this has not been mentioned
anywhere in Kconfig.
Signed-off-by: Sinan Kaya
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index
Need CONFIG_PCI to be set in order to be able to use IOSF_MBI
functionality.
Signed-off-by: Sinan Kaya
---
arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index cc4f0c6ee1ed..322a58ababb0 100644
--- a/arch/x86/Kconfig
+++
IOSF_CORE depends on PCI. This was never mentioned.
Signed-off-by: Sinan Kaya
---
drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig
b/drivers/thermal/intel/int340x_thermal/Kconfig
We can now compile ACPI without PCI support. If code depends on CONFIG_PCI,
it needs to explicitly guard that piece.
Signed-off-by: Sinan Kaya
---
drivers/acpi/acpi_lpss.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
In the configuration where CONFIG_PCI is unset, this driver is failing to
compile due to PCI framework dependencies. Hide these behind CONFIG_PCI
ifdef.
Signed-off-by: Sinan Kaya
---
drivers/platform/x86/intel_pmc_ipc.c | 6 ++
1 file changed, 6 insertions(+)
diff --git
In these two cases, a value returned by rdmsr() or rdmsrl()
is ignored. Indicate that ignoring the value is intentional, so
that with the W=1 compilation option no warning is generated.
Signed-off-by: Michael Kelley
---
arch/x86/hyperv/hv_apic.c | 2 +-
arch/x86/hyperv/hv_spinlock.c | 2 +-
On Fri, 21 Dec 2018 18:13:16 -0500
Steven Rostedt wrote:
> +static __always_inline int str_has_prefix(const char *str, const char
> *prefix)
I'm thinking it is cleaner to have two helper functions and have them
both return bool.
static __always_inline bool str_has_prefix(const char *str,
On 12/21/2018 6:43 PM, Randy Dunlap wrote:
Any other issues?
There are a few Kconfig dependency issues. Here are 2 of them:
WARNING: unmet direct dependencies detected for VGA_ARB
Depends on [n]: HAS_IOMEM [=y] && PCI [=n] && !S390
Selected by [y]:
- VGA_SWITCHEROO [=y] && HAS_IOMEM
On 12/21/2018 7:28 PM, Randy Dunlap wrote:
Any other issues?
and on i386, there is this additional kconfig warning:
WARNING: unmet direct dependencies detected for INTEL_SOC_DTS_IOSF_CORE
Depends on [n]: THERMAL [=y] && (X86 [=y] || X86_INTEL_QUARK [=n] || COMPILE_TEST [=n])
&& X86 [=y]
If the cgroup destruction races with an exit() of a belonging
process(es), cg_kill_all() may fail. It's not a good reason to make
cg_destroy() fail and leave the cgroup in place, potentially causing
next test runs to fail.
Signed-off-by: Roman Gushchin
Cc: Shuah Khan
Cc: Tejun Heo
Cc:
This patch implements 8 tests for the freezer controller for
cgroup v2:
1) a simple test, which aims to freeze and unfreeze a cgroup with 100
processes
2) a more complicated tree test, which creates a hierarchy of cgroups,
puts some processes in some cgroups, and tries to freeze and unfreeze
Freezer.c will contain an implementation of cgroup v2 freezer,
so let's rename the v1 freezer to avoid naming conflicts.
Signed-off-by: Roman Gushchin
Cc: Tejun Heo
Cc: kernel-t...@fb.com
---
kernel/cgroup/Makefile| 2 +-
kernel/cgroup/{freezer.c => legacy_freezer.c} |
Cgroup v1 implements the freezer controller, which provides an ability
to stop the workload in a cgroup and temporarily free up some
resources (cpu, io, network bandwidth and, potentially, memory)
for some other tasks. Cgroup v2 lacks this functionality.
This patch implements freezer for cgroup
On Fri, Dec 21, 2018 at 10:40:09AM +0100, Roberto Sassu wrote:
> On 12/20/2018 3:55 PM, Jarkko Sakkinen wrote:
> > On Thu, Dec 13, 2018 at 11:29:41AM +0100, Roberto Sassu wrote:
> > > This patch renames active_banks (member of tpm_chip) to allocated_banks,
> > > stores the number of allocated PCR
Describe cgroup v2 freezer interface in the cgroup v2 admin guide.
Signed-off-by: Roman Gushchin
Reviewed-by: Mike Rapoport
Cc: Tejun Heo
Cc: linux-...@vger.kernel.org
Cc: kernel-t...@fb.com
---
Documentation/admin-guide/cgroup-v2.rst | 27 +
1 file changed, 27
The number of descendant cgroups and the number of dying
descendant cgroups are currently synchronized using the cgroup_mutex.
The number of descendant cgroups will be required by the cgroup v2
freezer, which will use it to determine if a cgroup is frozen
(depending on total number of descendants
The helper is identical to the existing cgroup_task_count()
except it doesn't take the css_set_lock by itself, assuming
that the caller does.
Also, move cgroup_task_count() implementation into
kernel/cgroup/cgroup.c, as there is nothing specific to cgroup v1.
Signed-off-by: Roman Gushchin
Cc:
This patchset implements freezer for cgroup v2.
It provides similar functionality as v1 freezer, but the interface
conforms to the cgroup v2 interface design principles, and it
provides a better user experience: tasks can be killed, ptrace works,
there is no separate controller, which has to be
On Fri, Dec 21, 2018 at 10:28:09AM -0800, Sean Christopherson wrote:
> > Why would you want to pass EPC through user space to KVM rather than
> > KVM allocating it through kernel interfaces?
>
> Delegating EPC management to userspace fits better with KVM's existing
> memory ABI. KVM provides a
On Fri, 21 Dec 2018 15:44:41 -0800
Joe Perches wrote:
> On Fri, 2018-12-21 at 18:25 -0500, Steven Rostedt wrote:
> > On Fri, 21 Dec 2018 15:19:33 -0800
> > Joe Perches wrote:
> >
> > > I believe this should be bool.
> > >
> > > I don't find a use for non-zero assigned len value in the
On Thu, Dec 20, 2018 at 09:12:43PM -0800, Joe Perches wrote:
> Care to submit a coding_style.rst patch or
> improve the one below this?
I took yours and revised it a little bit. I spent some time looking at
assembly and decided to drop the performance note, the number of cases
that run into
On Fri, 2018-12-21 at 18:25 -0500, Steven Rostedt wrote:
> On Fri, 21 Dec 2018 15:19:33 -0800
> Joe Perches wrote:
>
> > I believe this should be bool.
> >
> > I don't find a use for non-zero assigned len value in the kernel
> > for strncmp and I believe the function should simply be:
> >
> >
On Fri, Dec 21, 2018 at 10:24:54AM -0800, Sean Christopherson wrote:
> On Fri, Dec 21, 2018 at 09:12:46AM -0800, Andy Lutomirski wrote:
> > > On Dec 21, 2018, at 9:28 AM, Sean Christopherson
> > > wrote:
> > >
> > > On Wed, Dec 19, 2018 at 06:58:48PM -0800, Andy Lutomirski wrote:
> > >>> On Dec
On Fri, Dec 21, 2018 at 01:10:39PM -0600, Kangjie Lu wrote:
> In lm80_probe(), if lm80_read_value() fails, it returns a negative
> error number which is stored to data->fan[f_min] and will be further
> used. We should avoid using the data if the read fails.
>
> The fix checks if lm80_read_value()
On Fri, 21 Dec 2018 18:25:07 -0500
Steven Rostedt wrote:
> On Fri, 21 Dec 2018 15:19:33 -0800
> Joe Perches wrote:
>
> > I believe this should be bool.
> >
> > I don't find a use for non-zero assigned len value in the kernel
> > for strncmp and I believe the function should simply be:
> >
>
On Fri, Dec 21, 2018 at 09:12:46AM -0800, Andy Lutomirski wrote:
> Hmm. I guess this makes some sense. My instinct would be to do it a
> little differently and have:
>
> /dev/sgx/enclave: Each instance is an enclave.
>
> /dev/sgx/epc: Used to get raw EPC for KVM. Might have different
>
On Fri, Dec 21, 2018 at 01:01:33PM -0600, Kangjie Lu wrote:
> If lm80_read_value() fails, it returns a negative number instead of the
> correct read data. Therefore, we should avoid using the data if it
> fails.
>
> The fix checks if lm80_read_value() fails, and if so, returns with the
> error
The mm-of-the-moment snapshot 2018-12-21-15-28 has been uploaded to
http://www.ozlabs.org/~akpm/mmotm/
mmotm-readme.txt says
README for mm-of-the-moment:
http://www.ozlabs.org/~akpm/mmotm/
This is a snapshot of my -mm patch queue. Uploaded at random hopefully
more than once a week.
You
On Fri, Dec 21, 2018 at 09:57:26PM +0100, Florian Westphal wrote:
> skb->sp doesn't exist anymore in the next-next tree, so mips defconfig
> no longer builds. Use helper instead to reset the secpath.
>
> Not even compile tested.
>
It does fix the build error.
Tested-by: Guenter Roeck
> Cc:
Replaced bool in struct with unsigned int bitfield to conserve space and
more clearly define size of varibales
Signed-off-by: Amir Mahdi Ghorbanian
---
drivers/staging/iio/adc/ad7192.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
On Fri, 21 Dec 2018 15:19:33 -0800
Joe Perches wrote:
> I believe this should be bool.
>
> I don't find a use for non-zero assigned len value in the kernel
> for strncmp and I believe the function should simply be:
>
> static inline bool str_has_prefix(const char *str, const char prefix[])
> {
OUT endpoint requests may somtimes have this flag set when
preparing to be submitted to HW indicating that there is an
additional TRB chained to the request for alignment purposes.
If that request is removed before the controller can execute the
transfer (e.g. ep_dequeue/ep_disable), the request
On Fri, 2018-12-21 at 18:13 -0500, Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)"
>
> A discussion came up in the trace triggers thread about converting a
> bunch of:
>
> strncmp(str, "const", sizeof("const") - 1)
>
> use cases into a helper macro. It started with:
>
>
From: Colin Ian King
There is a hunk of code that is indented one level too deep, fix this
by removing the extra tabs.
Signed-off-by: Colin Ian King
---
drivers/md/bcache/super.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git
From: "Steven Rostedt (VMware)"
A discussion came up in the trace triggers thread about converting a
bunch of:
strncmp(str, "const", sizeof("const") - 1)
use cases into a helper macro. It started with:
strncmp(str, const, sizeof(const) - 1)
But then Joe Perches mentioned that if a
From: Colin Ian King
There are some statements that are indented incorrectly, fix this by
removinf the extra tabs.
Signed-off-by: Colin Ian King
---
drivers/input/misc/drv2667.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/input/misc/drv2667.c
On Fri, 2018-12-21 at 14:34 -0800, Paul Walmsley wrote:
>
> On Fri, 21 Dec 2018, Alistair Francis wrote:
>
> > On Fri, 2018-12-21 at 11:27 -0800, Paul Walmsley wrote:
> > > On Fri, 21 Dec 2018, Alistair Francis wrote:
> > >
> > > > When the MicroSemi driver does eventually go upstream this will
On Fri, 21 Dec 2018 14:57:13 -0800
Linus Torvalds wrote:
> On Fri, Dec 21, 2018 at 2:48 PM Steven Rostedt wrote:
> >
> > > Your patch actually had them, but in the body of your email you did
> > >
> > > > #define have_prefix(str, prefix) ({ \
> > > > const char *__pfx = (const char
On Fri, 21 Dec 2018 14:29:30 -0800
Linus Torvalds wrote:
> On Fri, Dec 21, 2018 at 2:20 PM Joe Perches wrote:
> >
> > Using
> >
> > static inline bool str_has_prefix(const char *str, const char prefix[])
> > {
> > return !strncmp(str, prefix, strlen(prefix));
> > }
> >
> > eliminates
On Fri, Dec 21, 2018 at 2:48 PM Steven Rostedt wrote:
>
> > Your patch actually had them, but in the body of your email you did
> >
> > > #define have_prefix(str, prefix) ({ \
> > > const char *__pfx = (const char *)prefix; \
> >
> > which is just completely wrong.
> >
> > Considering your
On Fri, 21 Dec 2018 14:20:25 -0800
Joe Perches wrote:
> static inline bool str_has_prefix(const char *str, const char prefix[])
> {
> return !strncmp(str, prefix, strlen(prefix));
> }
>
> eliminates the strlen with gcc 4.8 (oldest I still have)
I tested it a bit more before posting.
I
On Fri, 21 Dec 2018 14:08:11 -0800
Linus Torvalds wrote:
> On Fri, Dec 21, 2018 at 12:55 PM Steven Rostedt wrote:
> >
> > On Fri, 21 Dec 2018 12:41:17 -0800
> > Linus Torvalds wrote:
> >
> > > Parentheses
> >
> > ?
>
> Your patch actually had them, but in the body of your email you
On Thu, Dec 20, 2018 at 5:38 AM Andrzej Hajda wrote:
>
> On 20.12.2018 12:14, Greg Kroah-Hartman wrote:
> > On Thu, Dec 20, 2018 at 11:22:45AM +0100, Andrzej Hajda wrote:
> >> During probe every time driver gets resource it should usually check for
> >> error
> >> printk some message if it is
From: Colin Ian King
There are a couple of statements that have extra spaces in the identation,
fix this by removing them.
Signed-off-by: Colin Ian King
---
drivers/misc/sgi-gru/grufault.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/sgi-gru/grufault.c
This commit does not apply cleanly due to other changes. Is there something I
can do to make it easier.
This line:
If (data->is_pipe) {
Must be changed to:
If (file->is_pipe) {
Let me know if there is a more standard way of communicating cherry-picked
changes for inclusion.
On 12/21/18 1:40 PM, Yang Shi wrote:
> Swap readahead would read in a few pages regardless if the underlying
> device is busy or not. It may incur long waiting time if the device is
> congested, and it may also exacerbate the congestion.
>
> Use inode_read_congested() to check if the underlying
+ mingo.
On Fri, Dec 21, 2018 at 02:09:02PM +0100, Paolo Bonzini wrote:
> Linus,
>
> The following changes since commit 7566ec393f4161572ba6f11ad5171fd5d59b0fbd:
>
> Linux 4.20-rc7 (2018-12-16 15:46:55 -0800)
>
> are available in the git repository at:
>
>
From: Colin Ian King
There is a hunk of code in a case statement that is indented one level
too deeply, fix this by removing extra tabs. Also remove one empty line.
Signed-off-by: Colin Ian King
---
drivers/misc/ad525x_dpot.c | 24 +++-
1 file changed, 11 insertions(+), 13
On Fri, 21 Dec 2018, Alistair Francis wrote:
> On Fri, 2018-12-21 at 11:27 -0800, Paul Walmsley wrote:
> > On Fri, 21 Dec 2018, Alistair Francis wrote:
> >
> > > When the MicroSemi driver does eventually go upstream this will
> > > probably have to be discussed though as either the config or
1 - 100 of 729 matches
Mail list logo
