Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-27 Thread Baolin Wang
On Fri, 25 Jan 2019 at 21:03, Takashi Iwai wrote: > > On Fri, 25 Jan 2019 12:11:43 +0100, > Baolin Wang wrote: > > > > Hi Takashi, > > On Fri, 25 Jan 2019 at 18:10, Takashi Iwai wrote: > > > > > > On Fri, 25 Jan 2019 10:25:37 +0100, > > > Baolin Wang wrote: > > > > > > > > Hi Jaroslav, > > > > On

[PATCH v10 03/42] component: alloc component_match without any comp to match

2019-01-27 Thread Ramalingam C
If all the components associated to a component master is not added to the component framework due to the HW capability or Kconfig selection, component_match will be NULL at component_master_add_with_match(). To avoid this, component_match_alloc() is added to the framework, to allcoate the struct

[PATCH] mtd: spi-nor: cadence-quadspi: write upto 8-bytes data in STIG mode

2019-01-27 Thread Purna Chandra Mandal
cadence-quadspi controller allows upto eight bytes of data to be written in software Triggered Instruction generator (STIG) mode of operation. Lower 4 bytes are written through writedatalower and upper 4 bytes by writedataupper register. This patch allows all the 8 bytes to be written. Signed-off

Re: [PATCH 00/15] PCI: endpoint: Cleanup EPC features

2019-01-27 Thread Kishon Vijay Abraham I
Hi, On 24/01/19 8:22 PM, Lorenzo Pieralisi wrote: > On Mon, Jan 07, 2019 at 12:11:33PM +0530, Kishon Vijay Abraham I wrote: >> Hi Lorenzo, >> >> The Endpoint controller driver uses features member in 'struct pci_epc' >> to advertise the list of supported features to the endpoint function >> driver

Re: next-20190125 - objtool complains about dumpstack

2019-01-27 Thread valdis . kletnieks
On Sun, 27 Jan 2019 22:18:25 -0600, Josh Poimboeuf said: > On Sun, Jan 27, 2019 at 10:45:03PM -0500, valdis.kletni...@vt.edu wrote: > > Seen in a build: > > > > CC arch/x86/kernel/dumpstack.o > > arch/x86/kernel/dumpstack.o: warning: objtool: oops_begin()+0x9: undefined > > stack state > >

[PATCH] kernel/hung_task.c - fix sparse warnings

2019-01-27 Thread valdis . kletnieks
sparse complains: CHECK kernel/hung_task.c kernel/hung_task.c:28:19: warning: symbol 'sysctl_hung_task_check_count' was not declared. Should it be static? kernel/hung_task.c:42:29: warning: symbol 'sysctl_hung_task_timeout_secs' was not declared. Should it be static? kernel/hung_task.c:47:29

Re: [PATCH] Kbuild: Handle too long symbols in kallsyms.c

2019-01-27 Thread Masahiro Yamada
On Fri, Jan 25, 2019 at 10:30 PM Ard Biesheuvel wrote: > > (+ masahiro) > > On Fri, 25 Jan 2019 at 14:28, Ard Biesheuvel > wrote: > > > > On Thu, 17 Jan 2019 at 23:46, wrote: > > > > > > From: Eugene Loh > > > > > > When checking for symbols with excessively long names, > > > account for null

Re: [PATCH] mtd: spi-nor: cadence-quadspi: write upto 8-bytes data in STIG mode

2019-01-27 Thread Mandal, Purna Chandra
On 21-Jan-19 3:07 PM, tudor.amba...@microchip.com wrote: Hi, Purna, On 12/14/2018 04:15 AM, Purna Chandra Mandal wrote: cadence-quadspi controller allows upto eight bytes of data to be transferred in software Triggered Instruction generator (STIG) mode of operation. Lower 4 bytes are written

Re: next-20190125 - objtool complains about dumpstack

2019-01-27 Thread Josh Poimboeuf
On Sun, Jan 27, 2019 at 10:45:03PM -0500, valdis.kletni...@vt.edu wrote: > Seen in a build: > > CC arch/x86/kernel/dumpstack.o > arch/x86/kernel/dumpstack.o: warning: objtool: oops_begin()+0x9: undefined > stack state > arch/x86/kernel/dumpstack.o: warning: objtool: oops_begin()+0x0: stack

Re: [PATCH v5 4/4] hwrng: add OP-TEE based rng driver

2019-01-27 Thread Sumit Garg
Hi Herbert, On Thu, 24 Jan 2019 at 11:25, Sumit Garg wrote: > > On ARM SoC's with TrustZone enabled, peripherals like entropy sources > might not be accessible to normal world (linux in this case) and rather > accessible to secure world (OP-TEE in this case) only. So this driver > aims to provide

Re: [PATCH 00/10] Venus stateful Codec API

2019-01-27 Thread Tomasz Figa
On Mon, Jan 28, 2019 at 1:16 PM Alexandre Courbot wrote: > > On Fri, Jan 25, 2019 at 7:35 PM Stanimir Varbanov > wrote: > > > > Hi Alex, > > > > On 1/25/19 7:34 AM, Alexandre Courbot wrote: > > > On Thu, Jan 24, 2019 at 7:13 PM Stanimir Varbanov > > > wrote: > > >> > > >> Hi Alex, > > >> > > >>

[PATCH] bpf/core.c - silence warning messages

2019-01-27 Thread valdis . kletnieks
Compiling kernel/bpf/core.c with W=1 causes a flood of warnings: kernel/bpf/core.c:1198:65: warning: initialized field overwritten [-Woverride-init] 1198 | #define BPF_INSN_3_TBL(x, y, z) [BPF_##x | BPF_##y | BPF_##z] = true |

Re: [PATCH 00/10] Venus stateful Codec API

2019-01-27 Thread Alexandre Courbot
On Fri, Jan 25, 2019 at 7:35 PM Stanimir Varbanov wrote: > > Hi Alex, > > On 1/25/19 7:34 AM, Alexandre Courbot wrote: > > On Thu, Jan 24, 2019 at 7:13 PM Stanimir Varbanov > > wrote: > >> > >> Hi Alex, > >> > >> Thank you for review and valuable comments! > >> > >> On 1/24/19 10:43 AM, Alexandre

[PATCH] extcon: Fix build issues in ptn5150

2019-01-27 Thread Vijai Kumar K
- extcon-ptn5150 driver uses gpio libraries - Add GPIOLIB in depends section of Kconfig Error: - > CC drivers/extcon/extcon-ptn5150.o > ../drivers/extcon/extcon-ptn5150.c: In function ‘ptn5150_irq_work’: > ../drivers/extcon/extcon-ptn5150.c:130:5: error: implicit declaration of > funct

next-20190125 - objtool complains about dumpstack

2019-01-27 Thread valdis . kletnieks
Seen in a build: CC arch/x86/kernel/dumpstack.o arch/x86/kernel/dumpstack.o: warning: objtool: oops_begin()+0x9: undefined stack state arch/x86/kernel/dumpstack.o: warning: objtool: oops_begin()+0x0: stack state mismatch: cfa1=6+16 cfa2=7+8 Probably a gcc9 code generation that objtool do

Re: [PATCH net-next v2 0/2] mv88e6xxx DSA suspend to RAM support

2019-01-27 Thread David Miller
From: Andrew Lunn Date: Sun, 27 Jan 2019 22:46:52 +0100 > I think you are replying to the wrong patch? This comment fits to > > https://www.spinics.net/lists/netdev/msg546662.html I noticed that right after I hit send, you are right. Sorry for the confusion. > Although i don't like it, i think

Re: [PATCH v10 1/3] dmaengine: 8250_mtk_dma: add MediaTek uart DMA support

2019-01-27 Thread Long Cheng
On Fri, 2019-01-18 at 11:10 +0800, Long Cheng wrote: Hi Vinod Koul, Just a gentle ping! thanks. > In DMA engine framework, add 8250 uart dma to support MediaTek uart. > If MediaTek uart enabled(SERIAL_8250_MT6577), and want to improve > the performance, can enable the function. > > Signed-off-

[PATCH v3] ipmi_si: fix use-after-free of resource->name

2019-01-27 Thread Yang Yingliang
When we excute the following commands, we got oops rmmod ipmi_si cat /proc/ioports [ 1623.482380] Unable to handle kernel paging request at virtual address 0901d478 [ 1623.482382] Mem abort info: [ 1623.482383] ESR = 0x9607 [ 1623.482385] Exception class = DABT (current EL), IL =

Re: [PATCH 1/6] dt-bindings: timer: add Tegra210 timer

2019-01-27 Thread Joseph Lo
On 1/25/19 8:01 PM, Jon Hunter wrote: On 25/01/2019 03:23, Joseph Lo wrote: Hi Jon, Thanks for reviewing. On 1/24/19 6:30 PM, Jon Hunter wrote: On 07/01/2019 03:28, Joseph Lo wrote: The Tegra210 timer provides fourteen 29-bit timer counters and one 32-bit timestamp counter. The TMRs run at

Re: [PATCH] sched/debug: Show intergroup and hierarchy sum wait time of a task group

2019-01-27 Thread 王贇
On 2019/1/25 下午3:55, 禹舟键 wrote: Hi, Michael Actually, I just created a container which had just 1 CPU, and I ran two tasks(while 1 loop) in this container. Then I read cpu.stat at 1 second interval ,but the wait_sum difference is almost 0. Task competition inside a cgroup won't be consider

Re: [PATCH] staging:iio:ad7152: Rename misspelled RESEVERD -> RESERVED

2019-01-27 Thread valdis . kletnieks
On Fri, 25 Jan 2019 22:14:32 -0200, Rodrigo Ribeiro said: > Maybe, one checkstyle patch is enough, right? Which drivers can I truly > contribute to? I'll give you a pointer to the "How to contribute" the Kernel Newbies list and IRC channel uses: https://lists.kernelnewbies.org/pipermail/kernelne

Re: [Openipmi-developer] [PATCH v2] ipmi_si: fix use-after-free of resource->name

2019-01-27 Thread Corey Minyard
On Mon, Jan 28, 2019 at 09:53:30AM +0800, Yang Yingliang wrote: > > > On 2019/1/26 23:08, Corey Minyard wrote: > > On Sat, Jan 26, 2019 at 05:14:54PM +0800, Yang Yingliang wrote: > > > When we excute the following commands, we got oops > > > rmmod ipmi_si > > > cat /proc/ioports > > > > > snip..

[PATCH] mtd: nand: fix kernel-doc warnings

2019-01-27 Thread Randy Dunlap
From: Randy Dunlap Fix kernel-doc warnings in drivers/mtd/nand/raw: ../drivers/mtd/nand/raw/nand_base.c:420: warning: Function parameter or member 'chip' not described in 'nand_fill_oob' ../drivers/mtd/nand/raw/nand_bbt.c:173: warning: Function parameter or member 'this' not described in 'read

[PATCH 1/2] clk: ingenic: Fix round_rate misbehaving with non-integer dividers

2019-01-27 Thread Paul Cercueil
Take a parent rate of 180 MHz, and a requested rate of 4.285715 MHz. This results in a theorical divider of 41.93 which is then rounded up to 42. The .round_rate function would then return (180 MHz / 42) as the clock, rounded down, so 4.285714 MHz. Calling clk_set_rate on 4.285714 MHz would ro

[PATCH 2/2] clk: ingenic: Fix doc of ingenic_cgu_div_info

2019-01-27 Thread Paul Cercueil
The 'div' field does not represent a number of bits used to divide (understand: right-shift) the divider, but a number itself used to divide the divider. Signed-off-by: Paul Cercueil Signed-off-by: Maarten ter Huurne Cc: --- drivers/clk/ingenic/cgu.h | 2 +- 1 file changed, 1 insertion(+), 1 d

Re: [Openipmi-developer] [PATCH v2] ipmi_si: fix use-after-free of resource->name

2019-01-27 Thread Yang Yingliang
On 2019/1/26 23:08, Corey Minyard wrote: On Sat, Jan 26, 2019 at 05:14:54PM +0800, Yang Yingliang wrote: When we excute the following commands, we got oops rmmod ipmi_si cat /proc/ioports snip.. If io_setup is called successful in try_smi_init() but try_smi_init() goes out_err before call

Re: [PATCH] scsi: nsp32: Remove unnecessary self assignment in nsp32_set_sync_entry

2019-01-27 Thread Nathan Chancellor
On Sun, Jan 27, 2019 at 05:42:01PM +0900, Masanori Goto wrote: > Thanks for the fix! > > 2019年1月27日(日) 4:11 Nathan Chancellor : > > > > On Mon, Dec 10, 2018 at 04:51:56PM -0700, Nathan Chancellor wrote: > > > Clang warns: > > > > > > drivers/scsi/nsp32.c:2444:14: warning: explicitly assigning valu

[RFC PATCH v2] async: Add cmdline option to specify drivers to be async probed

2019-01-27 Thread Feng Tang
Asynchronous driver probing can help much on kernel fastboot, and this option can provide a flexible way to optimize and quickly verify async driver probe. Also it will help in below cases: * Some driver actually covers several families of HWs, some of which could use async probing while others

linux-next: Fixes tag needs some work in the hwmon-fixes tree

2019-01-27 Thread Stephen Rothwell
Hi Guenter, In commit 315fd42cc1f8 ("hwmon: (nct6775) Fix fan6 detection for NCT6793D") Fixes tag Fixes: 2d99925a15b6 ("hwmon: (nct6775) Separate fan/pwm configuration has these problem(s): - Subject has leading but no trailing quotes Pleas do not split the subject over more than 1 lin

Re: [PATCH] devfreq: Suspend all devices on system shutdown

2019-01-27 Thread Chanwoo Choi
Hi, On 19. 1. 25. 오후 10:54, Marek Szyprowski wrote: > This way devfreq core ensures that all its devices will be set to safe > operation points before reboot operation. There are board on which some > aggressive power saving operation points are behind the capabilities of > the bootloader to prope

Re: linux-next: no release today

2019-01-27 Thread Gustavo A. R. Silva
On 1/27/19 6:32 PM, Stephen Rothwell wrote: > Hi all, > > There will be no linux-next release today, normal service will resume > tomorrow. > Good to know. Thanks, Stephen. -- Gustavo

linux-next: no release today

2019-01-27 Thread Stephen Rothwell
Hi all, There will be no linux-next release today, normal service will resume tomorrow. -- Cheers, Stephen Rothwell pgpvdToo_0iGB.pgp Description: OpenPGP digital signature

Re: [PATCH] mm/mincore: allow for making sys_mincore() privileged

2019-01-27 Thread Dominique Martinet
Jiri Kosina wrote on Sun, Jan 27, 2019: > So, any objections to aproaching it this way? I'm not sure why I'm the main recipient of that mail but answering because I am -- let's get these patches in through the regular -mm tree though -- Dominique

Re: [PATCH] perf tools api fs: make xxx__mountpoint() more scalable

2019-01-27 Thread Arnaldo Carvalho de Melo
Em Wed, Jan 23, 2019 at 03:10:47PM -0800, Stephane Eranian escreveu: > The xxx_mountpoint() interface provided by fs.c finds > mount points for common pseudo filesystems. The first > time xxx_mountpoint() is invoked, it scans the mount > table (/proc/mounts) looking for a match. If found, it > is c

Re: [PATCH] selftests/seccomp: Actually sleep for 1/10th second

2019-01-27 Thread Guenter Roeck
On 1/27/19 11:36 AM, Nick Desaulniers wrote: On Sun, Jan 27, 2019 at 11:13 AM Kees Cook wrote: On Sun, Jan 27, 2019 at 11:25 PM Nick Desaulniers wrote: On Sun, Jan 27, 2019 at 1:44 AM Kees Cook wrote: Clang noticed that some none-zero sleep()s were actually using zero anyway. This switch

Linux 5.0-rc4

2019-01-27 Thread Linus Torvalds
Another week, another release candidate - this time from home. Nothing particularly stands out, except for the fact that the bulk of the pull requests came in late in the week. Which worked out ok, if only because it meant I could do a fair chunk of them on my main machine rather than on my laptop

Re: [PATCH] drivers: iio: industrialio-core: add check when kzalloc fails

2019-01-27 Thread valdis . kletnieks
On Thu, 24 Jan 2019 19:58:00 +0530, Bharath Vedartham said: > add code to handle the case when kzalloc fails to allocate memory to dev > > Signed-off-by: Bharath Vedartham > dev_set_name(&dev->dev, "iio:device%d", dev->id); > INIT_LIST_HEAD(&dev->buffer_list); > +

Re: [PATCH v3] oom, oom_reaper: do not enqueue same task twice

2019-01-27 Thread Roman Gushchin
On Sun, Jan 27, 2019 at 11:57:38PM +0900, Tetsuo Handa wrote: > On 2019/01/27 20:40, Michal Hocko wrote: > > On Sun 27-01-19 19:56:06, Tetsuo Handa wrote: > >> On 2019/01/27 17:37, Michal Hocko wrote: > >>> Thanks for the analysis and the patch. This should work, I believe but > >>> I am not really

Re: [PATCH] mm/mincore: allow for making sys_mincore() privileged

2019-01-27 Thread Jiri Kosina
On Thu, 24 Jan 2019, Jiri Kosina wrote: > > Jiri, you've offered resubmitting the last two patches properly, can you > > incorporate this change or should I just send this directly? (I'd take > > most of your commit message and add your name somewhere) > > I've been running some basic smoke tes

Re: [PATCH] arm64: dts: rockchip: enable usb-host regulators during boot

2019-01-27 Thread Heiko Stuebner
Am Dienstag, 22. Januar 2019, 23:38:48 CET schrieb Dmitry Voytik: > After commit ef05bcb60, boot from USB drives is broken. > Fix this problem by enabling usb-host regulators during boot time. > > Signed-off-by: Dmitry Voytik added a fixes and cc-stable tag and applied as fix for 5.0 Thanks Hei

Re: [PATCH net-next v2 0/2] mv88e6xxx DSA suspend to RAM support

2019-01-27 Thread Andrew Lunn
On Sun, Jan 27, 2019 at 01:22:50PM -0800, David Miller wrote: > From: Miquel Raynal > Date: Fri, 25 Jan 2019 10:55:05 +0100 > > > After a first attempt of bringing S2RAM support to the DSA switch, it > > has been reported that a part of the configuration was lost during the > > cycle. This second

Re: [regression -next0117] What is kcompactd and why is he eating 100% of my cpu?

2019-01-27 Thread valdis . kletnieks
On Sun, 27 Jan 2019 17:00:27 +0100, Pavel Machek said: > > > I've noticed this as well on earlier kernels (next-20181224 to 20190115) > > > Some more info: > > > 1) echo 3 > /proc/sys/vm/drop_caches unwedges kcompactd in 1-3 seconds. > > This aspect is curious as it indicates that kcompactd could

Re: KASAN: use-after-free Read in br_mdb_ip_get

2019-01-27 Thread Nikolay Aleksandrov
On 27/01/2019 22:26, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:    ba6069759381 Merge tag 'mmc-v5.0-rc2' of git://git.kernel... > git tree:   upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=17b342c4c0 > kernel config:  https://syz

[PATCH v3 1/1] int_sqrt() adjustments

2019-01-27 Thread Florian La Roche
Add __attribute_const__ and adjust to use (signed) int for the right param of "<<". Change the return value of int_sqrt() from "unsigned long" to u32 to be the same as int_sqrt64() and adjust some calling functions. Signed-off-by: Florian La Roche --- drivers/gpu/drm/i915/selftests/i915_gem_gtt

Re: [PATCH] net: phy: at803x: Use helpers to access MMD PHY registers

2019-01-27 Thread David Miller
From: Carlo Caione Date: Fri, 25 Jan 2019 12:35:10 + > Libphy provides a standard set of helpers to access the MMD PHY > registers. Use those instead of relying on custom driver-specific > functions. > > Signed-off-by: Carlo Caione Applied to net-next.

Re: [RFC][PATCH] Revert "ARM: dts: bcm2837: Fix polarity of wifi reset GPIOs"

2019-01-27 Thread Stefan Wahren
Hi Ioan-Adrian, > Ioan-Adrian Ratiu hat am 27. Januar 2019 um 21:28 > geschrieben: > > > This reverts commit bea8a160c621d19f7f78b13e14e03f4b8e44cd4b. > > Contrary to what the commit message says, on my rpi 3 b v1.2 changing > the polarity causes the exact behaviour this commit intends to fix

Re: [PATCH net-next v2 0/2] mv88e6xxx DSA suspend to RAM support

2019-01-27 Thread David Miller
From: Miquel Raynal Date: Fri, 25 Jan 2019 10:55:05 +0100 > After a first attempt of bringing S2RAM support to the DSA switch, it > has been reported that a part of the configuration was lost during the > cycle. This second version adds a first patch that saves the rules in > a per-chip list when

Re: [PATCH v2 1/1] int_sqrt() adjustments

2019-01-27 Thread Florian La Roche
Hello Joe, sending in a new patch with u32 as return value and some adjusted callers of int_sqrt(). best regards, Florian La Roche

Re: [PATCH v3 00/16] block: sed-opal: support shadow MBR done flag and write

2019-01-27 Thread Scott Bauer
On Tue, Jan 22, 2019 at 11:31:31PM +0100, David Kozub wrote: > This patch series extends OPAL support: it adds IOCTL for setting the shadow > MBR done flag which can be useful for unlocking an OPAL disk on boot and it > adds > IOCTL for writing to the shadow MBR. Also included are some minor fixes

Re: [PATCH v3 15/16] block: sed-opal: don't repeat opal_discovery0 in each steps array

2019-01-27 Thread Scott Bauer
On Tue, Jan 22, 2019 at 11:31:46PM +0100, David Kozub wrote: > Originally each of the opal functions that call next include > opal_discovery0 in the array of steps. This is superfluous and > can be done always inside next. > > Signed-off-by: David Kozub Reviewed-by: Scott Bauer

Re: [PATCH v3 14/16] block: sed-opal: pass steps via argument rather than via opal_dev

2019-01-27 Thread Scott Bauer
On Tue, Jan 22, 2019 at 11:31:45PM +0100, David Kozub wrote: > The steps argument is only read by the next function, so it can > be passed directly as an argument rather than via opal_dev. > > Normally, the steps is an array on the stack, so the pointer stops > being valid then the function that s

Re: [PATCH v3 13/16] block: sed-opal: check size of shadow mbr

2019-01-27 Thread Scott Bauer
On Tue, Jan 22, 2019 at 11:31:44PM +0100, David Kozub wrote: > From: Jonas Rabenstein > > Check whether the shadow mbr does fit in the provided space on the > target. Also a proper firmware should handle this case and return an > error we may prevent problems or even damage with crappy firmwares.

Re: [PATCH v3 12/16] block: sed-opal: unify retrieval of table columns

2019-01-27 Thread Scott Bauer
On Tue, Jan 22, 2019 at 11:31:43PM +0100, David Kozub wrote: > From: Jonas Rabenstein > > Instead of having multiple places defining the same argument list to get > a specific column of a sed-opal table, provide a generic version and > call it from those functions. > > Signed-off-by: Jonas Raben

Re: [PATCH v3 11/16] block: sed-opal: ioctl for writing to shadow mbr

2019-01-27 Thread Scott Bauer
On Tue, Jan 22, 2019 at 11:31:42PM +0100, David Kozub wrote: > From: Jonas Rabenstein > > Allow modification of the shadow mbr. If the shadow mbr is not marked as > done, this data will be presented read only as the device content. Only > after marking the shadow mbr as done and unlocking a locki

Re: [PATCH 1/3] arm64: dts: rockchip: fix rk3300-gru-bob graph_port warning

2019-01-27 Thread Heiko Stuebner
Am Samstag, 26. Januar 2019, 11:37:28 CET schrieb Enric Balletbo i Serra: > Ports are described by child 'port' nodes contained in the device node. > 'ports' is optional and is used to group all 'port' nodes which is not > the case here. > > This patch fixes the following warning: > > arch/arm64/

Re: [PATCH v3 10/16] block: sed-opal: add ioctl for done-mark of shadow mbr

2019-01-27 Thread Scott Bauer
On Tue, Jan 22, 2019 at 11:31:41PM +0100, David Kozub wrote: > From: Jonas Rabenstein > > Enable users to mark the shadow mbr as done without completely > deactivating the shadow mbr feature. This may be useful on reboots, > when the power to the disk is not disconnected in between and the shadow

Re: [PATCH v3 07/16] block: sed-opal: reuse response_get_token to decrease code duplication

2019-01-27 Thread Scott Bauer
On Tue, Jan 22, 2019 at 11:31:38PM +0100, David Kozub wrote: > response_get_token had already been in place, its functionality had > been duplicated within response_get_{u64,bytestring} with the same error > handling. Unify the handling by reusing response_get_token within the > other functions. >

Re: [PATCH v2 1/3] iio: chemical: add support for Plantower PMS7003 sensor

2019-01-27 Thread Tomasz Duszynski
On Sun, Jan 27, 2019 at 07:53:58PM +0100, Peter Meerwald-Stadler wrote: > On Sun, 27 Jan 2019, Tomasz Duszynski wrote: > > some minor comments below, looks good to me > Thanks for comments. > > Add support for Plantower PMS7003 particulate matter sensor. > > > > Signed-off-by: Tomasz Duszynski >

Re: [PATCH v3 09/16] block: sed-opal: split generation of bytestring header and content

2019-01-27 Thread Scott Bauer
On Tue, Jan 22, 2019 at 11:31:40PM +0100, David Kozub wrote: > From: Jonas Rabenstein > > Split the header generation from the (normal) memcpy part if a > bytestring is copied into the command buffer. This allows in-place > generation of the bytestring content. For example, copy_from_user may be

Re: [PATCH v3 08/16] block: sed-opal: print failed function address

2019-01-27 Thread Scott Bauer
On Tue, Jan 22, 2019 at 11:31:39PM +0100, David Kozub wrote: > From: Jonas Rabenstein > > Add function address (and if available its symbol) to the message if a > step function fails. > > Signed-off-by: Jonas Rabenstein Reviewed-by: Scott Bauer

Re: [PATCH v3 02/16] block: sed-opal: use correct macro for method length

2019-01-27 Thread Scott Bauer
On Tue, Jan 22, 2019 at 11:31:33PM +0100, David Kozub wrote: > From: Jonas Rabenstein > > Also the values of OPAL_UID_LENGTH and OPAL_METHOD_LENGTH are the same, > it is weird to use OPAL_UID_LENGTH for the definition of the methods. > > Signed-off-by: Jonas Rabenstein Reviewed-by: Scott Bauer

Re: [PATCH v3 03/16] block: sed-opal: unify space check in add_token_*

2019-01-27 Thread Scott Bauer
On Tue, Jan 22, 2019 at 11:31:34PM +0100, David Kozub wrote: > From: Jonas Rabenstein > > All add_token_* functions have a common set of conditions that have to > be checked. Use a common function for those checks in order to avoid > different behaviour as well as code duplication. > > Co-author

Re: [PATCH v3 05/16] block: sed-opal: unify cmd start

2019-01-27 Thread Scott Bauer
On Tue, Jan 22, 2019 at 11:31:36PM +0100, David Kozub wrote: > Every step starts with resetting the cmd buffer as well as the comid and > constructs the appropriate OPAL_CALL command. Consequently, those > actions may be combined into one generic function. On should take care > that the opening and

Re: [PATCH v3 06/16] block: sed-opal: unify error handling of responses

2019-01-27 Thread Scott Bauer
On Tue, Jan 22, 2019 at 11:31:37PM +0100, David Kozub wrote: > response_get_{string,u64} include error handling for argument resp being > NULL but response_get_token does not handle this. > > Make all three of response_get_{string,u64,token} handle NULL resp in > the same way. > > Co-authored-by:

Re: [PATCH v3 04/16] block: sed-opal: close parameter list in cmd_finalize

2019-01-27 Thread Scott Bauer
On Tue, Jan 22, 2019 at 11:31:35PM +0100, David Kozub wrote: > Every step ends by calling cmd_finalize (via finalize_and_send) > yet every step adds the token OPAL_ENDLIST on its own. Moving > this into cmd_finalize decreases code duplication. > > Co-authored-by: Jonas Rabenstein > Signed-off-by:

Re: [PATCH v3 01/16] block: sed-opal: fix typos and formatting

2019-01-27 Thread Scott Bauer
On Tue, Jan 22, 2019 at 11:31:32PM +0100, David Kozub wrote: > This should make no change in functionality. > The formatting changes were triggered by checkpatch.pl. > > Signed-off-by: David Kozub Reviewed-by: Scott Bauer

Re: [RFC][PATCH] Revert "ARM: dts: bcm2837: Fix polarity of wifi reset GPIOs"

2019-01-27 Thread Greg KH
On Sun, Jan 27, 2019 at 10:28:13PM +0200, Ioan-Adrian Ratiu wrote: > This reverts commit bea8a160c621d19f7f78b13e14e03f4b8e44cd4b. > > Contrary to what the commit message says, on my rpi 3 b v1.2 changing > the polarity causes the exact behaviour this commit intends to fix, as > described at the r

Re: [PATCH v2 1/1] int_sqrt() adjustments

2019-01-27 Thread Joe Perches
On Sun, 2019-01-27 at 21:32 +0100, Florian La Roche wrote: > Add __attribute_const__ and use normal ints for the right param of "<<". [] > diff --git a/include/linux/kernel.h b/include/linux/kernel.h [] > @@ -513,10 +513,10 @@ extern int __kernel_text_address(unsigned long addr); > extern int kern

[PATCH v2 2/2] staging: iio: ad7780: moving ad7780 out of staging

2019-01-27 Thread Renato Lui Geh
Move ad7780 ADC driver out of staging and into the mainline. The ad7780 is a sigma-delta analog to digital converter. This driver provides reading voltage values and status bits from both the ad778x and ad717x series. Its interface also allows writing on the FILTER and GAIN GPIO pins on the ad778

Re: [RFC][PATCH] Revert "ARM: dts: bcm2837: Fix polarity of wifi reset GPIOs"

2019-01-27 Thread Ioan-Adrian Ratiu
Link to the full 4.19.18 config I'm using: https://drive.google.com/open?id=1ZI3MeGB2fkYMsEjzGQYXUk2wqr0h9h7R On Sun, 27 Jan 2019, Ioan-Adrian Ratiu wrote: This reverts commit bea8a160c621d19f7f78b13e14e03f4b8e44cd4b. Contrary to what the commit message says, on my rpi 3 b v1.2 changing the p

[PATCH v2 1/1] int_sqrt() adjustments

2019-01-27 Thread Florian La Roche
Add __attribute_const__ and use normal ints for the right param of "<<". Signed-off-by: Florian La Roche --- include/linux/kernel.h | 4 ++-- lib/int_sqrt.c | 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/kernel.h b/include/linux/kernel.h index

Re: [PATCH] platform/x86: wmi: fix potential null pointer dereferences

2019-01-27 Thread Andy Shevchenko
On Tue, Jan 22, 2019 at 10:04 PM Mattias Jacobsson <2...@mok.nu> wrote: > > In the function wmi_dev_match() there are three variables that > potentially can result in a null pointer dereference. Namely: > dev/wblock, driver/wmi_driver, and wmi_driver->id_table. > > Check for NULL and return that th

[PATCH v2 1/2] staging: iio: ad7780: add gain & filter gpio support

2019-01-27 Thread Renato Lui Geh
Previously, the AD7780 driver only supported gpio for the 'powerdown' pin. This commit adds suppport for the 'gain' and 'filter' pin. Signed-off-by: Renato Lui Geh Signed-off-by: Giuliano Belinassi Co-developed-by: Giuliano Belinassi --- Changes in v2: - Filter reading changed to mHz

[PATCH v2 0/2] staging: iio: ad7780: move out of staging

2019-01-27 Thread Renato Lui Geh
This series of patches add user input to ad7780 'gain' & 'filter' gpio pins. It also includes a patch to move ad7780 out of staging and to the main tree. Renato Lui Geh (2): staging: iio: ad7780: add gain & filter gpio support staging: iio: ad7780: moving ad7780 out of staging drivers/iio/adc/

[RFC][PATCH] Revert "ARM: dts: bcm2837: Fix polarity of wifi reset GPIOs"

2019-01-27 Thread Ioan-Adrian Ratiu
This reverts commit bea8a160c621d19f7f78b13e14e03f4b8e44cd4b. Contrary to what the commit message says, on my rpi 3 b v1.2 changing the polarity causes the exact behaviour this commit intends to fix, as described at the referenced link below (wlan0 disapears). With reset-gpios = ... GPIO_ACTIVE_H

KASAN: use-after-free Read in br_mdb_ip_get

2019-01-27 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:ba6069759381 Merge tag 'mmc-v5.0-rc2' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17b342c4c0 kernel config: https://syzkaller.appspot.com/x/.config?x=505743eba4e4f68 das

Re: [PATCH v2 2/3] platform/x86: wmi: add WMI support to MODULE_DEVICE_TABLE()

2019-01-27 Thread Andy Shevchenko
On Sun, Jan 27, 2019 at 9:04 PM Mattias Jacobsson <2...@mok.nu> wrote: > > The kernel provides the macro MODULE_DEVICE_TABLE() where driver authors > can specify their device type and their array of device_ids and thereby > trigger the generation of the appropriate MODULE_ALIAS() output. This is >

Re: [PATCH v2 1/3] platform/x86: wmi: move struct wmi_device_id to mod_devicetable.h

2019-01-27 Thread Andy Shevchenko
On Sun, Jan 27, 2019 at 9:04 PM Mattias Jacobsson <2...@mok.nu> wrote: > > In preparation for adding WMI support to MODULE_DEVICE_TABLE() move the > definition of struct wmi_device_id to mod_devicetable.h and inline > guid_string in the struct. > > Changing guid_string to an inline char array chang

Re: [GIT pull] genirq updates for 5.0

2019-01-27 Thread pr-tracker-bot
The pull request you sent on Sun, 27 Jan 2019 12:05:05 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq-urgent-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/0d484375d73ad2ec39a395365449a70c200645b1 Thank you! -- Deet-doot-dot, I am a

Re: [GIT pull] locking updates for 5.0

2019-01-27 Thread pr-tracker-bot
The pull request you sent on Sun, 27 Jan 2019 12:05:06 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > locking-urgent-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9881051828375a872964f91bf985b8a35e4fbaef Thank you! -- Deet-doot-dot,

Re: [GIT pull] timer updates for 5.0

2019-01-27 Thread pr-tracker-bot
The pull request you sent on Sun, 27 Jan 2019 12:05:07 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > timers-urgent-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f907bb4c326d145c13504db184f38557d169f4bc Thank you! -- Deet-doot-dot,

Re: [GIT pull] x86/timer updates for 5.0

2019-01-27 Thread pr-tracker-bot
The pull request you sent on Sun, 27 Jan 2019 12:05:07 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-timers-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/351e1aa6cb4b136e3f772605071d7a8db3c5b4e0 Thank you! -- Deet-doot-dot, I am a

Re: [GIT pull] x86 updates for 5.0

2019-01-27 Thread pr-tracker-bot
The pull request you sent on Sun, 27 Jan 2019 12:05:08 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-urgent-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8a5f06056a25ac7dbca2b0505cc0fe8ffb6947c1 Thank you! -- Deet-doot-dot, I am a

[PATCH] staging: octeon: fix broken phylib usage

2019-01-27 Thread Aaro Koskinen
Commit 2b3e88ea6528 ("net: phy: improve phy state checking") added checks for phylib usage, and this triggers with OCTEON ethernet and results in broken networking. Fix by replacing phy_start_aneg() with phy_start(). Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking") Signed-off-by: Aaro

[PATCH v2 0/2] staging: iio: ad7780: move out of staging

2019-01-27 Thread Renato Lui Geh

Re: [PATCH] selftests/seccomp: Actually sleep for 1/10th second

2019-01-27 Thread Nick Desaulniers
On Sun, Jan 27, 2019 at 11:13 AM Kees Cook wrote: > > On Sun, Jan 27, 2019 at 11:25 PM Nick Desaulniers > wrote: > > > > On Sun, Jan 27, 2019 at 1:44 AM Kees Cook wrote: > > > > > > Clang noticed that some none-zero sleep()s were actually using zero > > > anyway. This switches to nanosleep() to

Re: [PATCH 0/3] platform/x86: wmi: add WMI support to MODULE_DEVICE_TABLE()

2019-01-27 Thread Mattias Jacobsson
Hi Darren, On 2019-01-26, Darren Hart wrote: > On Sat, Jan 19, 2019 at 12:55:52PM +0100, Mattias Jacobsson wrote: > > This patchset adds WMI support to MODULE_DEVICE_TABLE(). > > Hi Mattias, > > Thanks for the patch series. I've reviewed and found no major issues - but > what > I'm missing from

Re: [PATCH] selftests/seccomp: Actually sleep for 1/10th second

2019-01-27 Thread Kees Cook
On Sun, Jan 27, 2019 at 11:25 PM Nick Desaulniers wrote: > > On Sun, Jan 27, 2019 at 1:44 AM Kees Cook wrote: > > > > Clang noticed that some none-zero sleep()s were actually using zero > > anyway. This switches to nanosleep() to gain sub-second granularity. > > > > seccomp_bpf.c:2625:9: warning:

Re: [PATCH v5 2/2] drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel

2019-01-27 Thread Jagan Teki
On Sat, Jan 26, 2019 at 1:22 AM Sam Ravnborg wrote: > > Hi Jagan. > > Looks good, only very few nits left. > > On Sat, Jan 26, 2019 at 12:52:33AM +0530, Jagan Teki wrote: > > Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel. > > > > Add panel driver for it. > > > > Tested-by: Bhusha

[PATCH v2 3/3] platform/x86: wmi: use MODULE_DEVICE_TABLE() instead of MODULE_ALIAS()

2019-01-27 Thread Mattias Jacobsson
WMI drivers can if they have specified an array of struct wmi_device_id use the MODULE_DEVICE_TABLE() macro to automatically generate the appropriate MODULE_ALIAS() output. Thus avoiding to keep both the array of struct wmi_device_id and the MODULE_ALIAS() declaration(s) in sync. Change all driver

[PATCH v2 1/3] platform/x86: wmi: move struct wmi_device_id to mod_devicetable.h

2019-01-27 Thread Mattias Jacobsson
In preparation for adding WMI support to MODULE_DEVICE_TABLE() move the definition of struct wmi_device_id to mod_devicetable.h and inline guid_string in the struct. Changing guid_string to an inline char array changes the loop conditions when looping over an array of struct wmi_device_id. Therefo

Re: [GIT PULL] EDAC fix for 5.0

2019-01-27 Thread pr-tracker-bot
The pull request you sent on Sun, 27 Jan 2019 12:41:54 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git tags/edac_fix_for_5.0 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/983542434e6beef911d5ae4488c49080a177e5e4 Thank you! -- Deet-doot-dot, I am a

[PATCH v2 2/3] platform/x86: wmi: add WMI support to MODULE_DEVICE_TABLE()

2019-01-27 Thread Mattias Jacobsson
The kernel provides the macro MODULE_DEVICE_TABLE() where driver authors can specify their device type and their array of device_ids and thereby trigger the generation of the appropriate MODULE_ALIAS() output. This is opposed to having to specify one MODULE_ALIAS() for each device. The WMI device t

[PATCH v2 0/3] platform/x86: wmi: add WMI support to MODULE_DEVICE_TABLE()

2019-01-27 Thread Mattias Jacobsson
The kernel provides the macro MODULE_DEVICE_TABLE() which can help driver authors to generate the appropriate MODULE_ALIAS() output. The WMI device type is currently not supported by MODULE_DEVICE_TABLE(). While using MODULE_DEVICE_TABLE() does increase the complexity as well as spreading out the

Re: [PATCH v2 1/3] iio: chemical: add support for Plantower PMS7003 sensor

2019-01-27 Thread Peter Meerwald-Stadler
On Sun, 27 Jan 2019, Tomasz Duszynski wrote: some minor comments below, looks good to me > Add support for Plantower PMS7003 particulate matter sensor. > > Signed-off-by: Tomasz Duszynski > --- > drivers/iio/chemical/Kconfig | 10 + > drivers/iio/chemical/Makefile | 1 + > drivers/iio/ch

RE: [PATCH] kcov: convert kcov.refcount to refcount_t

2019-01-27 Thread Reshetova, Elena
> On Mon, Jan 21, 2019 at 11:05:03AM -0500, Alan Stern wrote: > > On Mon, 21 Jan 2019, Peter Zijlstra wrote: > > > > Any additional ordering; like the one you have above; are not strictly > > > required for the proper functioning of the refcount. Rather, you rely on > > > additional ordering and w

Re: [PATCH] net/rose: fix NULL ax25_cb kernel panic

2019-01-27 Thread David Miller
From: Dmitry Vyukov Date: Fri, 25 Jan 2019 11:46:40 +0100 > From: Bernard Pidoux > > When an internally generated frame is handled by rose_xmit(), > rose_route_frame() is called: > > if (!rose_route_frame(skb, NULL)) { > dev_kfree_skb(skb); > stats->tx_e

[PATCH v2 1/3] iio: chemical: add support for Plantower PMS7003 sensor

2019-01-27 Thread Tomasz Duszynski
Add support for Plantower PMS7003 particulate matter sensor. Signed-off-by: Tomasz Duszynski --- drivers/iio/chemical/Kconfig | 10 + drivers/iio/chemical/Makefile | 1 + drivers/iio/chemical/pms7003.c | 343 + 3 files changed, 354 insertions(+) create mode

[PATCH v2 3/3] dt-bindings: iio: chemical: pms7003: add device tree support

2019-01-27 Thread Tomasz Duszynski
Add device tree support for Plantower PMS7003 particulate matter sensor. Signed-off-by: Tomasz Duszynski --- .../iio/chemical/plantower,pms7003.txt| 19 +++ 1 file changed, 19 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/chemical/plantower,pms7

[PATCH v2 2/3] dt-bindings: add Plantower to the vendor prefixes

2019-01-27 Thread Tomasz Duszynski
Add Plantower to the vendor prefixes. Signed-off-by: Tomasz Duszynski Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings

<    1   2   3   >