[GIT PULL] Mailbox changes for v5.1

2019-03-12 Thread Jassi Brar
Hi Linus, The following changes since commit 3717f613f48df0222311f974cf8a06c8a6c97bae: Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip (2019-03-05 14:49:11 -0800) are available in the Git repository at:

Re: [PATCH v2 0/5] auxdisplay: Introduce charlcd_free()

2019-03-12 Thread Miguel Ojeda
On Tue, Mar 12, 2019 at 3:44 PM Andy Shevchenko wrote: > > I have found a memory leak in hd44780 and it becomes that we have no > counterpart to charlcd_alloc() that developers can easily miss. Side-note now that I see these patches: I forgot to CC you in a series for charlcd that we got from

Re: [PATCH] drivers: gpio: octeon: use devm_platform_ioremap_resource()

2019-03-12 Thread Enrico Weigelt, metux IT consult
On 12.03.19 14:45, Bartosz Golaszewski wrote: > Can you make this a part of the bigger series and resend together with > subject line fixes? tried to resend it as reply on the prev version. but somehow this didn't seem to work as intented. > Also: maybe consider adding a coccinelle script for

Re: [PATCH v3 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc

2019-03-12 Thread Dan Murphy
Rob On 3/12/19 9:55 AM, Rob Herring wrote: > On Tue, Mar 12, 2019 at 07:18:19AM -0500, Dan Murphy wrote: >> Add the lm3532 device tree documentation. >> Remove lm3532 device tree reference from the ti_lmu devicetree >> documentation. >> >> With the addition of the dedicated lm3532 documentation

Re: [PATCH v2 5/5] auxdisplay: hd44780: Convert to use charlcd_free()

2019-03-12 Thread Geert Uytterhoeven
On Tue, Mar 12, 2019 at 3:46 PM Andy Shevchenko wrote: > Convert to use charlcd_free() instead of kfree() for sake of type check. > > Signed-off-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of

Re: [PATCH 1/2] Staging: rtl8723bs: os_dep: Fix several coding style errors

2019-03-12 Thread Dan Carpenter
On Tue, Mar 12, 2019 at 11:39:13AM -0300, Guilherme T Maeoka wrote: > From: Guilherme T Maeoka > > Fix coding style errors and warns complained by checkpatck.pl. To list: > > - remove braces for single statements blocks, > - add space required around operators, > - replace

Re: [PATCH v2 4/5] auxdisplay: panel: Convert to use charlcd_free()

2019-03-12 Thread Geert Uytterhoeven
On Tue, Mar 12, 2019 at 3:46 PM Andy Shevchenko wrote: > Convert to use charlcd_free() instead of kfree() for sake of type check. > > Signed-off-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of

Re: [PATCH v2 3/5] auxdisplay: charlcd: Introduce charlcd_free() helper

2019-03-12 Thread Geert Uytterhoeven
On Tue, Mar 12, 2019 at 3:44 PM Andy Shevchenko wrote: > The charlcd_free() is a counterpart to charlcd_alloc() > and should be called symmetrically on tear down. > > Cc: Geert Uytterhoeven > Signed-off-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH v2 2/5] auxdisplay: charlcd: Move to_priv() to charlcd namespace

2019-03-12 Thread Geert Uytterhoeven
Hi Andy, On Tue, Mar 12, 2019 at 3:44 PM Andy Shevchenko wrote: > In order to be more particular in names, rename to_priv() macro > to charlcd_to_priv(). As this is a macro, not a function, the name doesn't end up as a symbol in the binary anyway, and it's for internal use by the driver only.

Re: [PATCH 9/9] drivers: ata: sata_rcar: use devm_platform_ioremap_resource()

2019-03-12 Thread Sergei Shtylyov
On 03/12/2019 12:19 PM, Enrico Weigelt, metux IT consult wrote: > Use the new helper that wraps the calls to platform_get_resource() > and devm_ioremap_resource() together. > > Signed-off-by: Enrico Weigelt, metux IT consult Reviewed-by: Sergei Shtylyov [...] MBR, Sergei

[PATCH] pinctrl: baytrail: Fix potential NULL pointer dereference

2019-03-12 Thread Aditya Pakki
saved-context in byt_gpio_probe is allocated via devm_kcalloc and is used without checking for NULL in later functions. This patch avoids such a scenario. Signed-off-by: Aditya Pakki --- drivers/pinctrl/intel/pinctrl-baytrail.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [RESEND PATCH] mm/hotplug: don't reset pagetype flags for offline

2019-03-12 Thread Michal Hocko
On Sun 10-03-19 16:01:02, Qian Cai wrote: > The commit f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded > memory to zones until online") introduced move_pfn_range_to_zone() which > calls memmap_init_zone() during onlining a memory block. > memmap_init_zone() will reset pagetype flags

Re: [PATCH v2 1/5] auxdisplay: hd44780: Fix memory leak on ->remove()

2019-03-12 Thread Geert Uytterhoeven
On Tue, Mar 12, 2019 at 3:44 PM Andy Shevchenko wrote: > We have to free on ->remove() the allocated resources on ->probe(). > > Fixes: d47d88361fee ("auxdisplay: Add HD44780 Character LCD support") > Cc: Geert Uytterhoeven > Signed-off-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeven

Re: [PATCH tip/core/rcu 06/19] rcu: Add warning to detect half-interrupts

2019-03-12 Thread Joel Fernandes
On Mon, Mar 11, 2019 at 03:29:03PM -0700, Paul E. McKenney wrote: > On Mon, Mar 11, 2019 at 09:39:39AM -0400, Joel Fernandes wrote: > > On Wed, Aug 29, 2018 at 03:20:34PM -0700, Paul E. McKenney wrote: > > > RCU's dyntick-idle code is written to tolerate half-interrupts, that it, > > > either an

Re: [PATCH 1/2] i2c: i2c-designware-platdrv: Allow a dynamic adap. nr without an ACPI fwnode

2019-03-12 Thread Andy Shevchenko
On Tue, Mar 12, 2019 at 04:47:48PM +0200, Jarkko Nikula wrote: > On 3/11/19 1:22 PM, Hans de Goede wrote: > > Before this commit the i2c-designware-platdrv assumes that if the pdev > > has an apci-companion it should use a dynamic adapter-nr and otherwise > > it will use pdev->id as adapter-nr. >

Re: [PATCH v1 1/4] auxdisplay: hd44780: Fix memory leak on ->remove()

2019-03-12 Thread Geert Uytterhoeven
Hi Andy, On Tue, Mar 12, 2019 at 3:40 PM Andy Shevchenko wrote: > On Tue, Mar 12, 2019 at 02:47:01PM +0100, Geert Uytterhoeven wrote: > > On Tue, Mar 12, 2019 at 2:18 PM Andy Shevchenko > > wrote: > > > We have to free on ->remove() the allocated resources on ->probe(). > > > > > > Fixes:

Re: [PATCH v3] zcrypt: handle AP Info notification from CHSC SEI command

2019-03-12 Thread Tony Krowiak
On 3/11/19 11:57 AM, Sebastian Ott wrote: On Mon, 11 Mar 2019, Tony Krowiak wrote: On 2/18/19 12:01 PM, Tony Krowiak wrote: The current AP bus implementation periodically polls the AP configuration to detect changes. When the AP configuration is dynamically changed via the SE or an SCLP

Re: [PATCH] kernel/trace/trace_kprobe.c - fix comment format

2019-03-12 Thread Steven Rostedt
On Tue, 12 Mar 2019 04:58:32 -0400 "Valdis Klētnieks" wrote: > CC kernel/trace/trace_kprobe.o > kernel/trace/trace_kprobe.c:41: warning: cannot understand function > prototype: 'struct trace_kprobe ' > > The real problem is that a comment looked like kerneldoc when it shouldn't > be...

Re: [PATCH] infiniband: i40iw: fix potential NULL pointer dereferences

2019-03-12 Thread Jason Gunthorpe
On Fri, Mar 08, 2019 at 11:27:50PM -0600, Kangjie Lu wrote: > alloc_ordered_workqueue may fail and return NULL. Let's check > its return value to ensure it is not NULL so as to avoid > potential NULL pointer dereferences. > > Signed-off-by: Kangjie Lu > drivers/infiniband/hw/i40iw/i40iw_cm.c |

Re: [PATCH] kernel/trace/trace_probe.c - make variable static

2019-03-12 Thread Steven Rostedt
On Tue, 12 Mar 2019 04:52:58 -0400 "Valdis Klētnieks" wrote: > sparse complains: > CHECK kernel/trace/trace_probe.c > kernel/trace/trace_probe.c:16:12: warning: symbol 'reserved_field_names' was > not declared. Should it be static? > > Yes, it should be static. Thanks, applied. Note, I

Re: [PATCH v9 perf,bpf 08/15] perf, bpf: save btf in a rbtree in perf_env

2019-03-12 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 11, 2019 at 10:30:44PM -0700, Song Liu escreveu: > static void perf_env__purge_bpf(struct perf_env *env) > { > @@ -83,6 +135,19 @@ static void perf_env__purge_bpf(struct perf_env *env) > rb_erase(>rb_node, root); > free(node); > } > + > + root =

Re: [PATCH 16/42] drivers: gpio: janz-ttl: drop unneccessary temp variable dev

2019-03-12 Thread Enrico Weigelt, metux IT consult
On 12.03.19 12:26, Thierry Reding wrote: > You're not consistent within the series itself. In patch 3 you went the > other way and dropped usage of pdev->dev in favour of the local dev > variable. ups, you got me :O -- Enrico Weigelt, metux IT consult Free software and Linux embedded

[PATCH 3/8] drivers: tty: serial: 8250_ingenic: use devm_ioremap_resource()

2019-03-12 Thread Enrico Weigelt, metux IT consult
Use helper devm_ioremap_resource() to make the code a little bit shorter and easier to read. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/tty/serial/8250/8250_ingenic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_ingenic.c

[PATCH 8/8] drivers: tty: serial: xilinx_uartps: use helpers

2019-03-12 Thread Enrico Weigelt, metux IT consult
--- drivers/tty/serial/xilinx_uartps.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 74089f5..92aff38 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++

[PATCH 1/8] drivers: tty: serial: 8250_bcm2835aux: use devm_platform_ioremap_resource()

2019-03-12 Thread Enrico Weigelt, metux IT consult
--- drivers/tty/serial/8250/8250_bcm2835aux.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/tty/serial/8250/8250_bcm2835aux.c b/drivers/tty/serial/8250/8250_bcm2835aux.c index bd53661..0738d14 100644 --- a/drivers/tty/serial/8250/8250_bcm2835aux.c +++

[PATCH 6/8] drivers: tty: serial: vt8500: use memres

2019-03-12 Thread Enrico Weigelt, metux IT consult
--- drivers/tty/serial/vt8500_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/vt8500_serial.c b/drivers/tty/serial/vt8500_serial.c index 3d58e9b..331a9dd 100644 --- a/drivers/tty/serial/vt8500_serial.c +++ b/drivers/tty/serial/vt8500_serial.c @@

[PATCH 5/8] drivers: tty: serial: introduce struct resource

2019-03-12 Thread Enrico Weigelt, metux IT consult
The standard data structure for holding io resources in the kernel is struct resource. Serial drivers yet don't really use it (except when retrieving from oftree). This patch introduces a new field in struct uart_port for that, plus several helpers. Yet it's up to the individual drivers for using

Re: [PATCH] mm/slab: protect cache_reap() against CPU and memory hot plug operations

2019-03-12 Thread Michal Hocko
On Mon 11-03-19 20:17:01, Laurent Dufour wrote: > The commit 95402b382901 ("cpu-hotplug: replace per-subsystem mutexes with > get_online_cpus()") remove the CPU_LOCK_ACQUIRE operation which was use to > grap the cache_chain_mutex lock which was protecting cache_reap() against > CPU hot plug

RFC: cleaning up the serial drivers and use struct resource

2019-03-12 Thread Enrico Weigelt, metux IT consult
Hello folks, I'm currently working on some cleanups in drivers/tty/serial. There're several cases where new helpers, like devm_platform_ioremap_resource can be used, other places can use devm_ioremap_resource() for a bit cleaner code. Another topic here is using struct resource, instead of

[PATCH 7/8] drivers: tty: serial: use memres

2019-03-12 Thread Enrico Weigelt, metux IT consult
--- drivers/tty/serial/zs.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/tty/serial/zs.c b/drivers/tty/serial/zs.c index b03d3e4..2fd4821 100644 --- a/drivers/tty/serial/zs.c +++ b/drivers/tty/serial/zs.c @@ -986,14 +986,13 @@ static void

Re: kernel 5.0 blk_clear_pm_only triggers a warning during resume

2019-03-12 Thread Bart Van Assche
On Tue, 2019-03-12 at 05:35 +, Jisheng Zhang wrote: > I got below warning during resume: > > [ 673.65] sd 0:0:0:0: [sda] Starting disk > [ 673.658899] WARNING: CPU: 3 PID: 1039 at blk_clear_pm_only+0x2a/0x30 > [ 673.658902] CPU: 3 PID: 1039 Comm: kworker/u8:49 Not tainted 5.0.0+ #1 > [

[PATCH 4/8] drivers: tty: serial: use devm_ioremap_resource()

2019-03-12 Thread Enrico Weigelt, metux IT consult
instead of fetching out start and len from a struct resource for passing it to devm_ioremap(), directly use devm_ioremap_resource() Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/tty/serial/8250/8250_lpc18xx.c | 3 +-- drivers/tty/serial/8250/8250_mtk.c | 3 +--

[PATCH 2/8] drivers: tty: serial: 8250_dw: use devm_ioremap_resource()

2019-03-12 Thread Enrico Weigelt, metux IT consult
Use helper devm_ioremap_resource() to make the code a little bit shorter and easier to read. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/tty/serial/8250/8250_dw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_dw.c

Re: [PATCH] rcu/tree: Fix self wakeups for grace period kthread

2019-03-12 Thread Steven Rostedt
On Tue, 12 Mar 2019 07:09:23 -0700 "Paul E. McKenney" wrote: > On Tue, Mar 12, 2019 at 05:25:28PM +0530, Neeraj Upadhyay wrote: > > On 3/12/19 7:20 AM, Steven Rostedt wrote: > > >On Fri, 8 Mar 2019 15:16:18 +0530 > > >Neeraj Upadhyay wrote: > > > > > >>Update the code to match the comment

Re: [PATCH v3 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc

2019-03-12 Thread Rob Herring
On Tue, Mar 12, 2019 at 07:18:19AM -0500, Dan Murphy wrote: > Add the lm3532 device tree documentation. > Remove lm3532 device tree reference from the ti_lmu devicetree > documentation. > > With the addition of the dedicated lm3532 documentation the device > can be removed from the ti_lmu.txt. >

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-12 Thread Jarkko Sakkinen
On Mon, Mar 11, 2019 at 04:54:04PM -0700, Calvin Owens wrote: > We're having lots of problems with TPM commands timing out, and we're > seeing these problems across lots of different hardware (both v1/v2). > > I instrumented the driver to collect latency data, but I wasn't able to > find any

Re: [PATCH v9 1/9] bitops: Introduce the for_each_set_clump8 macro

2019-03-12 Thread Andy Shevchenko
On Tue, Mar 12, 2019 at 04:22:22PM +0900, William Breathitt Gray wrote: > Since Andy appears to have hardware outside of the GPIO subsystem he's > testing, let's wait for that and see how it turns out. Since I have still not much time, here is the driver I'm talking about

Re: [PATCH 1/2] i2c: i2c-designware-platdrv: Allow a dynamic adap. nr without an ACPI fwnode

2019-03-12 Thread Hans de Goede
Hi, On 12-03-19 15:47, Jarkko Nikula wrote: Hi On 3/11/19 1:22 PM, Hans de Goede wrote: Before this commit the i2c-designware-platdrv assumes that if the pdev has an apci-companion it should use a dynamic adapter-nr and otherwise it will use pdev->id as adapter-nr. On some devices e.g. the

Re: [PATCH 1/2] i2c: i2c-designware-platdrv: Allow a dynamic adap. nr without an ACPI fwnode

2019-03-12 Thread Hans de Goede
Hi, On 11-03-19 13:52, Andy Shevchenko wrote: On Mon, Mar 11, 2019 at 12:22:15PM +0100, Hans de Goede wrote: Before this commit the i2c-designware-platdrv assumes that if the pdev has an apci-companion it should use a dynamic adapter-nr and otherwise it will use pdev->id as adapter-nr. On

Re: [PATCH v2 1/9] mfd: mt6397: clean up code

2019-03-12 Thread Matthias Brugger
On 11/03/2019 20:01, Sean Wang wrote: > Hi, > > On Sun, Mar 10, 2019 at 8:48 PM Hsin-Hsiung Wang > wrote: >> >> clean up code >> >> Signed-off-by: Hsin-Hsiung Wang >> --- >> drivers/mfd/mt6397-core.c | 16 >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git

Re: [PATCH 1/2] i2c: i2c-designware-platdrv: Allow a dynamic adap. nr without an ACPI fwnode

2019-03-12 Thread Jarkko Nikula
Hi On 3/11/19 1:22 PM, Hans de Goede wrote: Before this commit the i2c-designware-platdrv assumes that if the pdev has an apci-companion it should use a dynamic adapter-nr and otherwise it will use pdev->id as adapter-nr. On some devices e.g. the Apollo Lake using Acer TravelMate Spin B118,

Re: [PATCH v2 2/3] dt-bindings: mmc: Add a new property disable-cqe-dcmd.

2019-03-12 Thread Christoph Müllner
> On 12.03.2019, at 14:17, Heiko Stuebner wrote: > > Am Freitag, 8. März 2019, 14:10:45 CET schrieb Christoph Müllner: >> >>> On 08.03.2019, at 13:46, Adrian Hunter wrote: >>> >>> On 7/03/19 10:43 AM, Christoph Muellner wrote: This patch documents the new property disable-cqe-dcmd

Re: KASAN: null-ptr-deref Read in reclaim_high

2019-03-12 Thread Dmitry Vyukov
On Tue, Mar 12, 2019 at 2:46 PM Shakeel Butt wrote: > > On Tue, Mar 12, 2019 at 1:33 AM Dmitry Vyukov wrote: > > > > On Tue, Mar 12, 2019 at 7:25 AM Andrew Morton > > wrote: > > > > > > On Tue, 12 Mar 2019 07:08:38 +0100 Dmitry Vyukov > > > wrote: > > > > > > > On Tue, Mar 12, 2019 at 12:37

[PATCH v2 0/5] auxdisplay: Introduce charlcd_free()

2019-03-12 Thread Andy Shevchenko
I have found a memory leak in hd44780 and it becomes that we have no counterpart to charlcd_alloc() that developers can easily miss. So, this series fixes a leak and introduces the charlcd_free(). In v2: - add new patch to convert to_priv() to charlcd_to_priv() - address Geert's comment what

[PATCH v2 4/5] auxdisplay: panel: Convert to use charlcd_free()

2019-03-12 Thread Andy Shevchenko
Convert to use charlcd_free() instead of kfree() for sake of type check. Signed-off-by: Andy Shevchenko --- drivers/auxdisplay/panel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c index 21b9b2f2470a..e06de63497cf

[PATCH v2 1/5] auxdisplay: hd44780: Fix memory leak on ->remove()

2019-03-12 Thread Andy Shevchenko
We have to free on ->remove() the allocated resources on ->probe(). Fixes: d47d88361fee ("auxdisplay: Add HD44780 Character LCD support") Cc: Geert Uytterhoeven Signed-off-by: Andy Shevchenko --- drivers/auxdisplay/hd44780.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v2 5/5] auxdisplay: hd44780: Convert to use charlcd_free()

2019-03-12 Thread Andy Shevchenko
Convert to use charlcd_free() instead of kfree() for sake of type check. Signed-off-by: Andy Shevchenko --- drivers/auxdisplay/hd44780.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/auxdisplay/hd44780.c b/drivers/auxdisplay/hd44780.c index

[PATCH v2 2/5] auxdisplay: charlcd: Move to_priv() to charlcd namespace

2019-03-12 Thread Andy Shevchenko
In order to be more particular in names, rename to_priv() macro to charlcd_to_priv(). No functional change intended. Cc: Geert Uytterhoeven Signed-off-by: Andy Shevchenko --- drivers/auxdisplay/charlcd.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff

[PATCH v2 3/5] auxdisplay: charlcd: Introduce charlcd_free() helper

2019-03-12 Thread Andy Shevchenko
The charlcd_free() is a counterpart to charlcd_alloc() and should be called symmetrically on tear down. Cc: Geert Uytterhoeven Signed-off-by: Andy Shevchenko --- drivers/auxdisplay/charlcd.c | 6 ++ include/misc/charlcd.h | 1 + 2 files changed, 7 insertions(+) diff --git

Re: [PATCH 4/9] drivers: ata: ahci_xgene: use devm_platform_ioremap_resource()

2019-03-12 Thread Sergei Shtylyov
Hello! On 03/12/2019 12:19 PM, Enrico Weigelt, metux IT consult wrote: > Use the new helper that wraps the calls to platform_get_resource() > and devm_ioremap_resource() together. > > Signed-off-by: Enrico Weigelt, metux IT consult > --- > drivers/ata/ahci_xgene.c | 21 +++-- >

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-12 Thread James Bottomley
On Tue, 2019-03-12 at 14:50 +0200, Jarkko Sakkinen wrote: > On Mon, Mar 11, 2019 at 05:27:43PM -0700, James Bottomley wrote: > > On Mon, 2019-03-11 at 16:54 -0700, Calvin Owens wrote: > > > e're having lots of problems with TPM commands timing out, and > > > we're seeing these problems across lots

Re: [PATCH v8 1/2] dt-bindings: serial: Add compatible for Mediatek MT8183

2019-03-12 Thread Matthias Brugger
On 11/03/2019 09:54, Erin Lo wrote: > This adds dt-binding documentation of uart for Mediatek MT8183 SoC > Platform. > > Signed-off-by: Erin Lo > Acked-by: Rob Herring > --- > Documentation/devicetree/bindings/serial/mtk-uart.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v1 1/4] auxdisplay: hd44780: Fix memory leak on ->remove()

2019-03-12 Thread Andy Shevchenko
On Tue, Mar 12, 2019 at 02:47:01PM +0100, Geert Uytterhoeven wrote: > On Tue, Mar 12, 2019 at 2:18 PM Andy Shevchenko > wrote: > > We have to free on ->remove() the allocated resources on ->probe(). > > > > Fixes: d47d88361fee ("auxdisplay: Add HD44780 Character LCD support") > > Cc: Geert

[PATCH 2/2] Staging: rtl8723bs: os_dep: Invert if selection statement

2019-03-12 Thread Guilherme T Maeoka
From: Guilherme T Maeoka Change 'if (a)' to 'if (!a)' and return. Otherwise, continue with the previouly wrapped block of control. This reduces the indentation level by 2 and 1. I'm not if this commit contributes to the coding style. Signed-off-by: Guilherme T Maeoka ---

[PATCH 1/2] Staging: rtl8723bs: os_dep: Fix several coding style errors

2019-03-12 Thread Guilherme T Maeoka
From: Guilherme T Maeoka Fix coding style errors and warns complained by checkpatck.pl. To list: - remove braces for single statements blocks, - add space required around operators, - replace spaces with tabs to indent, - add blank line after declarations,

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-12 Thread Suren Baghdasaryan
On Tue, Mar 12, 2019 at 1:05 AM Michal Hocko wrote: > > On Mon 11-03-19 15:15:35, Suren Baghdasaryan wrote: > > On Mon, Mar 11, 2019 at 1:46 PM Sultan Alsawaf > > wrote: > > > > > > On Mon, Mar 11, 2019 at 01:10:36PM -0700, Suren Baghdasaryan wrote: > > > > The idea seems interesting although I

[PATCH] dmaengine: tegra210-adma: use devm_clk_*() helpers

2019-03-12 Thread Sameer Pujar
Usage of pm_clk_*() results in non-zero prepare_count for clocks and hence module clocks remain ON always. This is not desired as it will leak power unncessarily. This patch replaces pm_clk_*() with devm_clk_*() interface. This helps to keep refcounts balanced when device is not in use and runtime

[PATCH] bus: tegra-aconnect: use devm_clk_*() helpers

2019-03-12 Thread Sameer Pujar
aconnect bus driver is using pm_clk_*() for managing required clocks. With this, clocks seem to be always ON. This happens because, the clock prepare count is incremented in pm_clock_acquire() which is called during device probe(). The count is decremented during remove(). Hence the prepare_count

Re: INFO: rcu detected stall in sys_sendfile64 (2)

2019-03-12 Thread Tetsuo Handa
(Moving most recipients to bcc: in order to avoid flooding.) On 2019/03/12 13:08, Al Viro wrote: > Umm... Might be a good idea to add some plausibility filters - it is, > in theory, possible that adding a line in a comment changes behaviour > (without compiler bugs, even - playing with __LINE__

[PATCH] arm64: tegra: dts: enable aconnect, adma and agic

2019-03-12 Thread Sameer Pujar
Enable aconnect, adma and agic for Tegra Jetson TX1. Signed-off-by: Sameer Pujar --- arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts

Re: [PATCH v6 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-03-12 Thread Patrick Venture
On Mon, Mar 11, 2019 at 7:38 PM Rob Herring wrote: > > On Mon, Mar 11, 2019 at 6:49 PM Patrick Venture wrote: > > > > On Mon, Mar 11, 2019 at 3:20 PM Rob Herring wrote: > > > > > > On Mon, Mar 04, 2019 at 10:55:36AM -0800, Patrick Venture wrote: > > > > Document the ast2400, ast2500 PCI-to-AHB

Re: [PATCH 2/2] xfs: clean up xfs_dir2_leaf_addname

2019-03-12 Thread Bill O'Donnell
On Mon, Mar 11, 2019 at 09:22:32AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Remove typedefs and consolidate local variable initialization. > > Signed-off-by: Darrick J. Wong Reviewed-by: Bill O'Donnell > --- > fs/xfs/libxfs/xfs_dir2_leaf.c | 33

Re: [PATCH 1/2] xfs: zero initialize highstale and lowstale in xfs_dir2_leaf_addname

2019-03-12 Thread Bill O'Donnell
On Mon, Mar 11, 2019 at 09:19:48AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Smatch complains about the following: > > fs/xfs/libxfs/xfs_dir2_leaf.c:848 xfs_dir2_leaf_addname() error: > uninitialized symbol 'lowstale'. > > fs/xfs/libxfs/xfs_dir2_leaf.c:849

[PATCH] arm64: defconfig: build aconnect and adma drivers as modules

2019-03-12 Thread Sameer Pujar
Following configs/drivers are enabled as modules, - TEGRA_ACONNECT (drivers/bus/tegra-aconnect.c) - TEGRA210_ADMA (drivers/dma/tegra210-adma.c) Signed-off-by: Sameer Pujar --- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/configs/defconfig

[PATCH v2 2/2] ceph: quota: fix quota subdir mounts

2019-03-12 Thread Luis Henriques
The CephFS kernel client does not enforce quotas set in a directory that isn't visible from the mount point. For example, given the path '/dir1/dir2', if quotas are set in 'dir1' and the filesystem is mounted with mount -t ceph ::/dir1/ /mnt then the client won't be able to access 'dir1'

[PATCH v2 0/2] fix quota subdir mounts

2019-03-12 Thread Luis Henriques
Hi, As recently reported in the ceph-users mailing-list[1], the kernel client behaves differently from the fuse client regarding mounting subdirs where quotas are in effect. I've also created a bug to track this issue[2]. The following patches are a possible way of fixing this issue. The

[PATCH v2 1/2] ceph: factor out ceph_lookup_inode()

2019-03-12 Thread Luis Henriques
This function will be used by __fh_to_dentry and by the quotas code, to find quota realm inodes that are not visible in the mountpoint. Signed-off-by: Luis Henriques --- fs/ceph/export.c | 14 +- fs/ceph/super.h | 1 + 2 files changed, 14 insertions(+), 1 deletion(-) diff --git

[PATCH v2 0/2] prevent mincore() page cache leaks

2019-03-12 Thread Vlastimil Babka
Here's a new version of the mincore() patches, with feedback from Andrew Morton applied. The IOCB_NOWAIT patch was dropped since David Chinner pointed out it's incomplete. We definitely want the first patch, while for the second Linus said: I think that's fine, and probably the right thing to

[PATCH v2 1/2] mm/mincore: make mincore() more conservative

2019-03-12 Thread Vlastimil Babka
From: Jiri Kosina The semantics of what mincore() considers to be resident is not completely clear, but Linux has always (since 2.3.52, which is when mincore() was initially done) treated it as "page is available in page cache". That's potentially a problem, as that [in]directly exposes

[PATCH v2 2/2] mm/mincore: provide mapped status when cached status is not allowed

2019-03-12 Thread Vlastimil Babka
After "mm/mincore: make mincore() more conservative" we sometimes restrict the information about page cache residency, which needs to be done without breaking existing userspace, as much as possible. Instead of returning with error, we thus fake the results. For that we return residency values as

Re: [PATCH] mm: vmscan: show zone type in kswapd tracepoints

2019-03-12 Thread Yafang Shao
On Tue, Mar 12, 2019 at 9:38 PM Michal Hocko wrote: > > On Tue 12-03-19 19:04:43, Yafang Shao wrote: > > On Mon, Mar 11, 2019 at 4:47 PM Michal Hocko wrote: > > > > > > On Fri 01-03-19 15:38:54, Yafang Shao wrote: > > > > If we want to know the zone type, we have to check whether > > > >

Re: [PATCH] rcu/tree: Fix self wakeups for grace period kthread

2019-03-12 Thread Paul E. McKenney
On Tue, Mar 12, 2019 at 05:25:28PM +0530, Neeraj Upadhyay wrote: > On 3/12/19 7:20 AM, Steven Rostedt wrote: > >On Fri, 8 Mar 2019 15:16:18 +0530 > >Neeraj Upadhyay wrote: > > > >>Update the code to match the comment that self wakeup of > >>grace period kthread is allowed from interrupt handler,

Re: [PATCH] mm: remove unused variable

2019-03-12 Thread Bartosz Golaszewski
wt., 12 mar 2019 o 14:59 Khalid Aziz napisał(a): > > On 3/12/19 7:28 AM, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > The mm variable is set but unused. Remove it. > > It is used. Look further down for calls to set_pte_at(). > > -- > Khalid > > > > > Signed-off-by: Bartosz

Re: [RFC PATCH 1/2] Add support of imx7ulp to interconnect framework

2019-03-12 Thread Alexandre Bailon
Hi Georgi, Sorry for the late response, I have just seen today that you have reviewed my patch. On 1/21/19 6:41 PM, Georgi Djakov wrote: Thank you for working on this! I am expecting the next version. I'm going to send a new patchset soon. I have rewritten pretty much everything, to handle

Re: [LKP] [btrfs] 44fe89de7d: aim7.jobs-per-min -15.1% regression

2019-03-12 Thread Qu Wenruo
On 2019/3/12 下午9:50, kernel test robot wrote: > Greeting, > > FYI, we noticed a -15.1% regression of aim7.jobs-per-min due to commit: > > > commit: 44fe89de7d5157a4f31f13d94802c7619e23f462 ("btrfs: Do mandatory tree > block check before submitting bio") That commit will cause extra check

Re:Re: [PATCH] irqchip/gic: fix passing wrong start irq number to irq_alloc_descs() for secondary GICs

2019-03-12 Thread Liu Xiang
Hi, Marc Thanks for your reply! At 2019-03-11 23:55:11, "Marc Zyngier" wrote: >On 11/03/2019 14:52, Liu Xiang wrote: >> For secondary GICs, the start irq number should skip over SGIs >> and PPIs. Its value should be 32. So we should pass hwirq_base to >> irq_alloc_descs() rather than a

Re: [PATCH] mm: remove unused variable

2019-03-12 Thread Khalid Aziz
On 3/12/19 7:28 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The mm variable is set but unused. Remove it. It is used. Look further down for calls to set_pte_at(). -- Khalid > > Signed-off-by: Bartosz Golaszewski > --- > mm/mprotect.c | 1 - > 1 file changed, 1

Re: [RFC] sched/fair: hard lockup in sched_cfs_period_timer

2019-03-12 Thread Phil Auld
On Mon, Mar 11, 2019 at 04:25:36PM -0400 Phil Auld wrote: > On Mon, Mar 11, 2019 at 10:44:25AM -0700 bseg...@google.com wrote: > > Letting it spin for 100ms and then only increasing by 6% seems extremely > > generous. If we went this route I'd probably say "after looping N > > times, set the

Re: [PATCH 1/3] userfaultfd/sysctl: introduce unprivileged_userfaultfd

2019-03-12 Thread Mike Rapoport
On Tue, Mar 12, 2019 at 08:26:33PM +0800, Peter Xu wrote: > On Tue, Mar 12, 2019 at 08:58:30AM +0200, Mike Rapoport wrote: > > [...] > > > > +config USERFAULTFD_UNPRIVILEGED_DEFAULT > > > +string "Default behavior for unprivileged userfault syscalls" > > > +depends on USERFAULTFD

[GIT PULL RESEND] pidfd changes for v5.1-rc1

2019-03-12 Thread Christian Brauner
Hi Linus, This is a resend of the pull request for the pidfd_send_signal() syscall which I sent last Tuesday. I'm not sure whether you just wanted to take a closer look. The following changes since commit f17b5f06cb92ef2250513a1e154c47b78df07d40: Linux 5.0-rc4 (2019-01-27 15:18:05 -0800) are

Re: [PATCH 3/3] perf, tools, report: Set up samples correctly in hierarchy mode

2019-03-12 Thread Andi Kleen
On Tue, Mar 12, 2019 at 12:12:59PM +0100, Jiri Olsa wrote: > On Mon, Mar 11, 2019 at 08:52:24PM -0700, Andi Kleen wrote: > > From: Andi Kleen > > > > In hierarchy mode the res samples need to be cloned from the parent > > entry. Copy them in this case. This fixes res sample browsing > > with

Re: [PATCH v1 1/4] auxdisplay: hd44780: Fix memory leak on ->remove()

2019-03-12 Thread Geert Uytterhoeven
Hi Andy, On Tue, Mar 12, 2019 at 2:18 PM Andy Shevchenko wrote: > We have to free on ->remove() the allocated resources on ->probe(). > > Fixes: d47d88361fee ("auxdisplay: Add HD44780 Character LCD support") > Cc: Geert Uytterhoeven > Signed-off-by: Andy Shevchenko Thanks, nice catch! > ---

Re: KASAN: null-ptr-deref Read in reclaim_high

2019-03-12 Thread Shakeel Butt
On Tue, Mar 12, 2019 at 1:33 AM Dmitry Vyukov wrote: > > On Tue, Mar 12, 2019 at 7:25 AM Andrew Morton > wrote: > > > > On Tue, 12 Mar 2019 07:08:38 +0100 Dmitry Vyukov wrote: > > > > > On Tue, Mar 12, 2019 at 12:37 AM Andrew Morton > > > wrote: > > > > > > > > On Mon, 11 Mar 2019 06:08:01

Re: [PATCH] drivers: gpio: octeon: use devm_platform_ioremap_resource()

2019-03-12 Thread Bartosz Golaszewski
pon., 11 mar 2019 o 20:48 Enrico Weigelt, metux IT consult napisał(a): > > Use the new helper that wraps the calls to platform_get_resource() > and devm_ioremap_resource() together. > > Signed-off-by: Enrico Weigelt, metux IT consult > --- > drivers/gpio/gpio-octeon.c | 4 +--- > 1 file

Re: [PATCHv7 10/10] doc/mm: New documentation for memory performance

2019-03-12 Thread Jonathan Cameron
On Mon, 11 Mar 2019 14:16:33 -0600 Keith Busch wrote: > On Mon, Mar 11, 2019 at 04:38:43AM -0700, Jonathan Cameron wrote: > > On Wed, 27 Feb 2019 15:50:38 -0700 > > Keith Busch wrote: > > > > > Platforms may provide system memory where some physical address ranges > > > perform differently

Re: [PATCH] mm: vmscan: show zone type in kswapd tracepoints

2019-03-12 Thread Michal Hocko
On Tue 12-03-19 19:04:43, Yafang Shao wrote: > On Mon, Mar 11, 2019 at 4:47 PM Michal Hocko wrote: > > > > On Fri 01-03-19 15:38:54, Yafang Shao wrote: > > > If we want to know the zone type, we have to check whether > > > CONFIG_ZONE_DMA, CONFIG_ZONE_DMA32 and CONFIG_HIGHMEM are set or not, > >

Re: [PATCH] ata: pata_oldpiix: Add missing device ID for INTEL_82371AB

2019-03-12 Thread LABBE Corentin
On Tue, Mar 12, 2019 at 12:06:23PM +, Alan Cox wrote: > On Tue, 12 Mar 2019 11:41:02 +0100 > LABBE Corentin wrote: > > > On Mon, Dec 10, 2018 at 05:52:35PM +0300, Sergei Shtylyov wrote: > > > Hello! > > > > > > On 12/10/2018 04:46 PM, Corentin Labbe wrote: > > > > > > > When playing with

Re: [PATCHv4 26/28] PCI: mobiveil: ls_pcie_g4: add Workaround for A-011451

2019-03-12 Thread Bjorn Helgaas
On Tue, Mar 12, 2019 at 09:34:17AM +, Z.q. Hou wrote: > Hi Bjorn, > > Thanks a lot for your comments! > > > -Original Message- > > From: Bjorn Helgaas [mailto:helg...@kernel.org] > > Sent: 2019年3月12日 1:35 > > To: Z.q. Hou > > Cc: linux-...@vger.kernel.org;

[PATCH] um: remove unused variable

2019-03-12 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The buf variable is unused. Remove it. Signed-off-by: Bartosz Golaszewski --- arch/um/kernel/skas/uaccess.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/um/kernel/skas/uaccess.c b/arch/um/kernel/skas/uaccess.c index 7f06fdbc7ee1..bd3cb694322c 100644 ---

[PATCH] um: remove uses of variable length arrays

2019-03-12 Thread Bartosz Golaszewski
From: Bartosz Golaszewski While the affected code is run in user-mode, the build still warns about it. Convert all uses of VLA to dynamic allocations. Signed-off-by: Bartosz Golaszewski --- arch/um/os-Linux/umid.c | 36 +++- 1 file changed, 27 insertions(+), 9

[PATCH] mm: remove unused variable

2019-03-12 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The mm variable is set but unused. Remove it. Signed-off-by: Bartosz Golaszewski --- mm/mprotect.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/mprotect.c b/mm/mprotect.c index 028c724dcb1a..130dac3ad04f 100644 --- a/mm/mprotect.c +++ b/mm/mprotect.c @@

Re: [PATCH] ARM: dts: vf610: Add ZII SPB4 board

2019-03-12 Thread Fabio Estevam
Hi Andrey, On Mon, Mar 11, 2019 at 3:49 PM Andrey Smirnov wrote: > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index f4f5aeaf3298..035ad9fc49f3 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -607,7 +607,8 @@ dtb-$(CONFIG_SOC_VF610)

[PATCH v1 3/4] auxdisplay: panel: Convert to use charlcd_free()

2019-03-12 Thread Andy Shevchenko
Convert to use charlcd_free() instead of kfree() for sake of type check. Signed-off-by: Andy Shevchenko --- drivers/auxdisplay/panel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c index 21b9b2f2470a..e06de63497cf

[PATCH v1 2/4] auxdisplay: charlcd: Introduce charlcd_free() helper

2019-03-12 Thread Andy Shevchenko
The charlcd_free() is a counterpart to charlcd_alloc() and should be called symmetrically on tear down. Signed-off-by: Andy Shevchenko --- drivers/auxdisplay/charlcd.c | 6 ++ include/misc/charlcd.h | 1 + 2 files changed, 7 insertions(+) diff --git a/drivers/auxdisplay/charlcd.c

[PATCH v1 4/4] auxdisplay: hd44780: Convert to use charlcd_free()

2019-03-12 Thread Andy Shevchenko
Convert to use charlcd_free() instead of kfree() for sake of type check. Signed-off-by: Andy Shevchenko --- drivers/auxdisplay/hd44780.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/auxdisplay/hd44780.c b/drivers/auxdisplay/hd44780.c index

Re: [PATCH 1/3] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit

2019-03-12 Thread Angus Ainslie
Hi Fabio, On 2019-03-11 17:10, Fabio Estevam wrote: On Mon, Mar 11, 2019 at 8:47 PM Angus Ainslie (Purism) wrote: +/ { + model = "Purism Librem 5 devkit 1.0"; + compatible = "fsl,librem5-devkit", "fsl,imx8mq"; This board is not manufactured by FSL/NXP, so it should be

Re: [PATCH v2 2/3] dt-bindings: mmc: Add a new property disable-cqe-dcmd.

2019-03-12 Thread Heiko Stuebner
Am Freitag, 8. März 2019, 14:10:45 CET schrieb Christoph Müllner: > > > On 08.03.2019, at 13:46, Adrian Hunter wrote: > > > > On 7/03/19 10:43 AM, Christoph Muellner wrote: > >> This patch documents the new property disable-cqe-dcmd > >> for the Arasan eMMC 5.1 driver. > >> > >> Signed-off-by:

[PATCH v1 1/4] auxdisplay: hd44780: Fix memory leak on ->remove()

2019-03-12 Thread Andy Shevchenko
We have to free on ->remove() the allocated resources on ->probe(). Fixes: d47d88361fee ("auxdisplay: Add HD44780 Character LCD support") Cc: Geert Uytterhoeven Signed-off-by: Andy Shevchenko --- drivers/auxdisplay/hd44780.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH v2] drivers: uio: Kconfig: pedantic formatting

2019-03-12 Thread Greg KH
On Thu, Mar 07, 2019 at 03:22:34AM +0100, Enrico Weigelt, metux IT consult wrote: > Formatting of Kconfig doesn't look so pretty, so just take > a damp cloth and clean it up. > > Signed-off-by: Enrico Weigelt, metux IT consult As before, please fix up the s-o-b line. thanks, greg k-h

Re: [PATCH v9 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-03-12 Thread Uwe Kleine-König
On Tue, Mar 12, 2019 at 01:12:18PM +0100, Thierry Reding wrote: > On Tue, Mar 12, 2019 at 10:17:39AM +0100, Uwe Kleine-König wrote: > > Hello, > > > > there are just a few minor things left I commented below. > > > > On Tue, Mar 12, 2019 at 01:41:29PM +0530, Yash Shah wrote: > > > +#define

<    5   6   7   8   9   10   11   12   13   >