[PATCH] ARM: STi: at least warn if of_iomap fails

2019-04-13 Thread Nicholas Mc Guire
The call to of_iomap() is unchecked but scu_enable(), which the returned address is passed on to, assumes a valid mapping. If the mapping is invalid this could probably lead to undefined system state so at least a warning should be issued. Signed-off-by: Nicholas Mc Guire Fixes: commit

[PATCH 1/4 RFC] ARM: imx legacy: warn on failed allocation

2019-04-13 Thread Nicholas Mc Guire
Even in init the allocation can fail and thus should at least warn so that the cause can be identified. Signed-off-by: Nicholas Mc Guire --- Problem located with an experimental coccinelle script Note sure if there is a better solution as this is early in the boot process so not that could be

[PATCH 3/3] ARM: hisi: handle of_iomap and fix missing of_node_put

2019-04-13 Thread Nicholas Mc Guire
Relying on an unchecked of_iomap() which can return NULL is problematic here, an explicit check seems mandatory. Also the call to of_find_compatible_node() returns a device node with refcount incremented therefor an explicit of_node_put() is needed here. Signed-off-by: Nicholas Mc Guire Fixes:

[PATCH V2] ARM: STi: warn if scu mapping fails

2019-04-13 Thread Nicholas Mc Guire
If the device node is not found or the of_iomap() failed, calling scu_enable would not be safe and could lead to an undefined system state. So warn in both failure paths before returning. Signed-off-by: Nicholas Mc Guire Link: http://lkml.org/lkml/2018/7/16/219 Fixes: commit 65ebcc115889 ("ARM:

[PATCH 3/4 RFC] ARM: imx legacy: wrap complex macro in ()

2019-04-13 Thread Nicholas Mc Guire
Checkpatch suggests to place a parenthesis around this complex macro. Signed-off-by: Nicholas Mc Guire --- Problem reported by checkpatch I'm actually not sure this really is improving readability but by default checkpatch gets it right so... Patch was compile-tested with: imx_v4_v5_defconfig

[PATCH 4/4] ARM: imx legacy: add an SPDX license identifier

2019-04-13 Thread Nicholas Mc Guire
The header clearly identifies this code as GPL V2 or later - so pop in the SPDX license identifier. Signed-off-by: Nicholas Mc Guire --- arch/arm/mach-imx/mach-mx27ads.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/mach-mx27ads.c b/arch/arm/mach-imx/mach-mx27ads.c index

[PATCH 2/4] ARM: imx legacy: declare unsigned int rather than unsigned

2019-04-13 Thread Nicholas Mc Guire
provide the proper type for unsigned int. Signed-off-by: Nicholas Mc Guire --- Problem reported by checkpatch Patch was compile-tested with: imx_v4_v5_defconfig (implies CONFIG_MACH_MX27ADS=y) Patch is against 5.1-rc4 (localversion-next is 20190412) arch/arm/mach-imx/mach-mx27ads.c | 4 ++--

[PATCH] ARM: ux500: add missing of_node_put()

2019-04-13 Thread Nicholas Mc Guire
of_find_compatible_node() returns a pointer with refcount incremented so both in the error path as well as after usage in soc_info_populate() respectively actually b8500_read_soc_id() an explicit of_node_put is needed to release backupram. Signed-off-by: Nicholas Mc Guire Fixes: commit

[PATCH 0/4] ARM: imx legacy: cleanups

2019-04-13 Thread Nicholas Mc Guire
While preparing a proposed fix for a missing check on zmalloc a few other checkpatch warnings poped up - this little set fixes those warnings. There is one remaining checkpatch warning but that looks like a false-positive to me: ERROR: Use of __initconst requires a separate use of const #171:

[PATCH] ARM: u300: add missing check for kmalloc

2019-04-13 Thread Nicholas Mc Guire
kmalloc return for bigrxbuf_virtual was not being checked - in case of failure set status, cleanup bigtxbuf_virtual and baile out. Signed-off-by: Nicholas Mc Guire Fixes: c7c8c78fdf6e ("ARM: 5667/3: U300 SSP/SPI board setup and test") --- Issue found with experimental coccinelle script Not

[PATCH] ARM: add missing of_node_put()

2019-04-13 Thread Nicholas Mc Guire
The call to of_find_compatible_node() returns a node pointer with refcount incremented thus it must be explicitly decremented here after the last usage. (see drivers/of/base.c:of_find_compatible_node()) Signed-off-by: Nicholas Mc Guire --- Problem located with an experimental coccinelle script

[PATCH 0/3] ARM: hisi: fix of_iomap errors

2019-04-13 Thread Nicholas Mc Guire
This patch set addresses two issues in arch/arm/mach-hisi/hotplug.c 1) The hisi hotplug functions were using a few unchecked of_iomap() while at the same time the system relied on those mappings. Checks for !NULL were inserted. 2) Further some mandatory of_node_put() were missing and have

[PATCH 1/3] ARM: hisi: fix error handling and missing of_node_put

2019-04-13 Thread Nicholas Mc Guire
of_iomap() can return NULL which seems critical here and thus should be explicitly flagged so that the cause of system halting can be understood. As of_find_compatible_node() is returning a device node with refcount incremented it must be explicitly decremented here. Signed-off-by: Nicholas Mc

INFO: task hung in do_exit

2019-04-13 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:8ee15f32 Merge tag 'dma-mapping-5.1-1' of git://git.infrad.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15a512d320 kernel config: https://syzkaller.appspot.com/x/.config?x=4fb64439e07a1ec0

[PATCH v2] MAINTAINERS: mark simple firmware interface (SFI) obsolete

2019-04-13 Thread Lukas Bulwahn
Len Brown has not been active in this part since around 2010. The recent activity suggests that Thomas Gleixner and Jiang Lui were maintaining this part of the kernel sources. Jiang Lui has not been active in the kernel sources since beginning 2016. So, the maintainer's role seems to be now with

Re: [PATCH 4/4] locking/lockdep: Test all incompatible scenario at once in check_irq_usage()

2019-04-13 Thread Yuyang Du
On Wed, 3 Apr 2019 at 00:05, Frederic Weisbecker wrote: > > check_prev_add_irq() tests all incompatible scenarios one after the > other while adding a lock (@next) to a tree dependency (@prev): > > LOCK_USED_IN_HARDIRQ vs LOCK_ENABLED_HARDIRQ >

RE: perf tools:Is there any tools to found out the max latency by irq or cpu idle

2019-04-13 Thread Linhaifeng
Sorry, the value 131081408 is just for example. Actually the result is like this: sqrt 2019-04-10 23:53:50: 43968 sqrt 2019-04-10 23:53:51: 44060 sqrt 2019-04-10 23:53:52: 49012 sqrt 2019-04-10 23:53:53: 38172 sqrt 2019-04-10 23:53:54: 131081408 sqrt 2019-04-10 23:53:55: 43600 sqrt

<    1   2   3