Re: [PATCH 4/9] perf/x86/intel: Support hardware TopDown metrics

2019-05-28 Thread Peter Zijlstra
On Tue, May 21, 2019 at 02:40:50PM -0700, kan.li...@linux.intel.com wrote: > diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c > index e9075d57853d..07ecfe75f0e6 100644 > --- a/arch/x86/events/core.c > +++ b/arch/x86/events/core.c > @@ -91,16 +91,20 @@ u64 x86_perf_event_update(struct p

Re: [PATCH 8/9] KVM: s390: Do not report unusabled IDs via KVM_CAP_MAX_VCPU_ID

2019-05-28 Thread Cornelia Huck
On Tue, 28 May 2019 13:00:30 +0200 Christian Borntraeger wrote: > Paolo, Radim, > > would you consider this patch (or the full series) as 5.2 material or 5.3 > material? FWIW, I'd consider this patch 5.2 material, as we're currently relaying wrong values to userspace. > > > On 23.05.19 18:4

Re: [PATCH 25/44] tools headers UAPI: Sync drm/drm.h with the kernel

2019-05-28 Thread Arnaldo Carvalho de Melo
Em Tue, May 28, 2019 at 09:07:03AM +0100, Lionel Landwerlin escreveu: > On 27/05/2019 23:37, Arnaldo Carvalho de Melo wrote: > >From: Arnaldo Carvalho de Melo > > > >To pick up the changes in these csets: > > > > 060cebb20cdb ("drm: introduce a capability flag for syncobj timeline > > support")

Re: [PATCH 4/9] perf/x86/intel: Support hardware TopDown metrics

2019-05-28 Thread Peter Zijlstra
On Tue, May 21, 2019 at 02:40:50PM -0700, kan.li...@linux.intel.com wrote: > + x86_pmu.has_metric = x86_pmu.intel_cap.perf_metrics; It makes sense to duplicate that state because? > @@ -717,6 +729,8 @@ struct x86_pmu { > struct extra_reg *extra_regs; > unsigned int flags;

Re: [PATCH] arm64: dts: fsl: imx8mq: enable the svns power key

2019-05-28 Thread Lucas Stach
Hi Angus, Am Dienstag, den 28.05.2019, 05:44 -0700 schrieb Angus Ainslie (Purism): > Add the snvs power key. > > > Signed-off-by: Angus Ainslie (Purism) > --- >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 9 + >  1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/frees

[PATCH net-next v3 0/1] Add hw offload of TC police on MSCC ocelot

2019-05-28 Thread Joergen Andreasen
This patch series enables hardware offload of ingress port policing on the MSCC ocelot board. Changes v2 -> v3: v3 now incorporates the following changes suggested by Jakub Kicinski: - Add a check in ndo_set_features() in order to prevent users to clear the NETIF_F_HW_TC flag while offload i

[PATCH net-next v3 1/1] net: mscc: ocelot: Implement port policers via tc command

2019-05-28 Thread Joergen Andreasen
Hardware offload of matchall classifier and police action are now supported via the tc command. Supported police parameters are: rate and burst. Example: Add: tc qdisc add dev eth3 handle : ingress tc filter add dev eth3 parent : prio 1 handle 2 \ matchall skip_sw

Re: [Question: devm_kfree] When should devm_kfree() be used?

2019-05-28 Thread Gen Zhang
On Tue, May 28, 2019 at 02:41:38PM +0200, Greg KH wrote: > No, you are not leaking any memory if you do not call that function. > Try it and see :) > > The function is there if you just want to "free the memory now!", it's > not necessary if you return an error as when the device is removed the >

Re: [kvmtool PATCH v10 5/5] KVM: arm/arm64: Add a vcpu feature for pointer authentication

2019-05-28 Thread Amit Daniel Kachhap
Hi Dave, On 5/28/19 3:41 PM, Dave Martin wrote: On Wed, Apr 24, 2019 at 02:41:21PM +0100, Dave Martin wrote: On Wed, Apr 24, 2019 at 12:32:22PM +0530, Amit Daniel Kachhap wrote: Hi, On 4/23/19 9:16 PM, Dave Martin wrote: [...] diff --git a/arm/kvm-cpu.c b/arm/kvm-cpu.c index 7780251..acd1

[PATCH] vboxguest: check for private_data before trying to close it.

2019-05-28 Thread Young Xiao
vbg_misc_device_close doesn't check that filp->private_data is non-NULL before trying to close_session, where vbg_core_close_session uses pointer session whithout checking, too. That can cause an oops in certain error conditions that can occur on open or lookup before the private_data is set. This

[PATCH 2/3] mm: thp: remove THP destructor

2019-05-28 Thread Yang Shi
The THP destructor is used to delete THP from per node deferred split queue, now the operation is moved out of it, so the destructor is not used anymore, remove it. Cc: Kirill Tkhai Cc: Johannes Weiner Cc: Michal Hocko Cc: "Kirill A . Shutemov" Cc: Hugh Dickins Cc: Shakeel Butt Signed-off-by

[RFC PATCH 0/3] Make deferred split shrinker memcg aware

2019-05-28 Thread Yang Shi
I got some reports from our internal application team about memcg OOM. Even though the application has been killed by oom killer, there are still a lot THPs reside, page reclaim doesn't reclaim them at all. Some investigation shows they are on deferred split queue, memcg direct reclaim can't shr

[PATCH 1/3] mm: thp: make deferred split shrinker memcg aware

2019-05-28 Thread Yang Shi
Currently THP deferred split shrinker is not memcg aware, this may cause premature OOM with some configuration. For example the below test would run into premature OOM easily: $ cgcreate -g memory:thp $ echo 4G > /sys/fs/cgroup/memory/thp/memory/limit_in_bytes $ cgexec -g memory:thp transhuge-stre

[PATCH 3/3] mm: shrinker: make shrinker not depend on memcg kmem

2019-05-28 Thread Yang Shi
Currently shrinker is just allocated and can work when memcg kmem is enabled. But, THP deferred split shrinker is not slab shrinker, it doesn't make too much sense to have such shrinker depend on memcg kmem. It should be able to reclaim THP even though memcg kmem is disabled. Introduce a new shri

Re: [PATCH 4/9] perf/x86/intel: Support hardware TopDown metrics

2019-05-28 Thread Peter Zijlstra
On Tue, May 21, 2019 at 02:40:50PM -0700, kan.li...@linux.intel.com wrote: > The 8bit metrics ratio values lose precision when the measurement period > gets longer. > > To avoid this we always reset the metric value when reading, as we > already accumulate the count in the perf count value. > > F

[PATCH] arm64: dts: fsl: imx8mq: enable the svns power key

2019-05-28 Thread Angus Ainslie (Purism)
Add the snvs power key. Signed-off-by: Angus Ainslie (Purism) --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index 45d10d8efd14..5f93fd9662ae 100644

[PATCH v2] arm64: dts: ls1028a: fix watchdog device node

2019-05-28 Thread Chuanhua Han
ls1028a platform uses sp805 watchdog, and use 1/16 platform clock as timer clock, this patch fix device tree node. Signed-off-by: Chuanhua Han --- Changes in v2: - Replace 'wdt' with 'watchdog' as the node name. - Keep nodes sort in unit-address. .../arm64/boot/dts/freescale/fs

Re: [PATCH] libertas: fix spelling mistake "Donwloading" -> "Downloading"

2019-05-28 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > There is are two spelling mistakes in lbtf_deb_usb2 messages, fix these. > > Signed-off-by: Colin Ian King > Reviewed-by: Mukesh Ojha Patch applied to wireless-drivers-next.git, thanks. aeffda6b10f8 libertas: fix spelling mistake "Donwloading" -

Re: [Question: devm_kfree] When should devm_kfree() be used?

2019-05-28 Thread Greg KH
On Tue, May 28, 2019 at 03:14:00PM +0800, Gen Zhang wrote: > On Tue, May 28, 2019 at 08:49:49AM +0200, Greg KH wrote: > > On Tue, May 28, 2019 at 08:32:57AM +0800, Gen Zhang wrote: > > > devm_kmalloc() is used to allocate memory for a driver dev. Comments > > > above the definition and doc > > > (

Re: [PATCH] perf: Fix oops when kthread execs user process

2019-05-28 Thread Russell King - ARM Linux admin
On Tue, May 28, 2019 at 08:31:29PM +0800, Young Xiao wrote: > When a kthread calls call_usermodehelper() the steps are: > 1. allocate current->mm > 2. load_elf_binary() > 3. populate current->thread.regs > > While doing this, interrupts are not disabled. If there is a perf > interrupt in the

Re: [alsa-devel] [PATCH] ASoC: fsl: sai: Fix clock source for mclk0

2019-05-28 Thread Daniel Baluta
On Sun, Apr 21, 2019 at 11:26 AM Nicolin Chen wrote: > > On Sun, Apr 21, 2019 at 01:04:39AM -0700, Nicolin Chen wrote: > > On Sun, Apr 21, 2019 at 10:26:40AM +0300, Daniel Baluta wrote: > > > > Firstly, according to your commit message, neither imx8qm nor > > > > imx6sx has an "mclk0" clock in the

Re: [PATCH] wlcore: spi: Fix a memory leaking bug in wl1271_probe()

2019-05-28 Thread Gen Zhang
On Tue, May 28, 2019 at 03:33:09PM +0300, Kalle Valo wrote: > Yeah, I don't see how that thread proves that these patches are correct. > Sure, I didn't mean that we came to an agreement that these patches are correct. > > Further, I e-mailed Greg K-H about when should we use devm_kmalloc(). > > >

Re: [RFC 1/7] mm: introduce MADV_COOL

2019-05-28 Thread Minchan Kim
On Tue, May 28, 2019 at 08:15:23PM +0800, Hillf Danton wrote: < snip > > > > > + > > > > + get_page(page); > > > > + spin_unlock(ptl); > > > > + lock_page(page); > > > > + err = split_huge_page(page); > > > > +

Re: [RFC 7/7] mm: madvise support MADV_ANONYMOUS_FILTER and MADV_FILE_FILTER

2019-05-28 Thread Michal Hocko
On Tue 28-05-19 05:18:48, Daniel Colascione wrote: [...] > The important requirement, I think, is that we need to support > managing "memory-naive" uncooperative tasks (perhaps legacy ones > written before cross-process memory management even became possible), > and I think that the cooperative-vs-

Re: [PATCH] rtlwifi: btcoex: Remove set but not used variable 'len' and 'asso_type_v2'

2019-05-28 Thread Kalle Valo
YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/realtek/rtlwifi/btcoexist/rtl_btc.c: In function > rtl_btc_btmpinfo_notify: > drivers/net/wireless/realtek/rtlwifi/btcoexist/rtl_btc.c:319:17: warning: > variable len set but not used [-Wunused-but-set-

Re: [PATCH] rtlwifi: btcoex: remove unused function exhalbtc_stack_operation_notify

2019-05-28 Thread Kalle Valo
YueHaibing wrote: > There is no callers in tree, so can be removed. > > Signed-off-by: YueHaibing Patch applied to wireless-drivers-next.git, thanks. dfbe36197dbc rtlwifi: btcoex: remove unused function exhalbtc_stack_operation_notify -- https://patchwork.kernel.org/patch/10960845/ https:

Re: [PATCH] rtlwifi: rtl8821ae: Remove set but not used variables 'cur_txokcnt' and 'b_last_is_cur_rdl_state'

2019-05-28 Thread Kalle Valo
YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c: In function > rtl8821ae_dm_check_rssi_monitor: > drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:658:6: warning: variable > cur_txokcnt set but not used [-Wunused-but

[PATCH] cx231xx-dvb: fix memory leak in dvb_fini()

2019-05-28 Thread Young Xiao
In dvb_init(), dev->dvb is allocated by kzalloc. Therefore, it must be freed being set to NULL. Signed-off-by: Young Xiao <92siuy...@gmail.com> --- drivers/media/usb/cx231xx/cx231xx-dvb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/cx231xx/cx231xx-dvb.c b/drivers/media/

Re: [RFC PATCH] usb: host: xhci: allow __GFP_FS in dma allocation

2019-05-28 Thread Oliver Neukum
Am Donnerstag, den 23.05.2019, 10:01 -0400 schrieb Alan Stern: > On Wed, 22 May 2019, Oliver Neukum wrote: > > > On Mi, 2019-05-22 at 10:56 -0400, Alan Stern wrote: > > > On Wed, 22 May 2019, Oliver Neukum wrote: > > > > > > > I agree with the problem, but I fail to see why this issue would be >

[PATCH net-next] net: ethernet: ti: cpsw: correct .ndo_open error path

2019-05-28 Thread Ivan Khoronzhuk
It's found while review and probably never happens, but real number of queues is set per device, and error path should be per device. Also correct label name for shared error path. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 5 +++-- 1 file changed, 3 insertions(+), 2 del

Re: [PATCH] wlcore: spi: Fix a memory leaking bug in wl1271_probe()

2019-05-28 Thread Kalle Valo
Gen Zhang writes: > On Tue, May 28, 2019 at 11:39:22AM +, Kalle Valo wrote: >> Gen Zhang wrote: >> >> > In wl1271_probe(), 'glue->core' is allocated by platform_device_alloc(), >> > when this allocation fails, ENOMEM is returned. However, 'pdev_data' >> > and 'glue' are allocated by devm_kz

Re: [RFC 7/7] mm: madvise support MADV_ANONYMOUS_FILTER and MADV_FILE_FILTER

2019-05-28 Thread Michal Hocko
On Tue 28-05-19 05:11:16, Daniel Colascione wrote: > On Tue, May 28, 2019 at 4:49 AM Michal Hocko wrote: [...] > > > We have various system calls that provide hints for open files, but > > > the memory operations are distinct. Modeling anonymous memory as a > > > kind of file-backed memory for pur

[PATCH] perf: Fix oops when kthread execs user process

2019-05-28 Thread Young Xiao
When a kthread calls call_usermodehelper() the steps are: 1. allocate current->mm 2. load_elf_binary() 3. populate current->thread.regs While doing this, interrupts are not disabled. If there is a perf interrupt in the middle of this process (i.e. step 1 has completed but not yet reached to

RE: [PATCH] x86/entry/64: randomize kernel stack offset upon syscall

2019-05-28 Thread Reshetova, Elena
> > With 5 bits there's a ~96.9% chance of crashing the system in an attempt, > > the exploit cannot be used for a range of attacks, including spear > > attacks and fast-spreading worms, right? A crashed and inaccessible > > system also increases the odds of leaving around unfinished attack code >

Re: [RFC 7/7] mm: madvise support MADV_ANONYMOUS_FILTER and MADV_FILE_FILTER

2019-05-28 Thread Minchan Kim
On Tue, May 28, 2019 at 02:06:14PM +0200, Michal Hocko wrote: > On Tue 28-05-19 20:44:36, Minchan Kim wrote: > > On Tue, May 28, 2019 at 01:28:40PM +0200, Michal Hocko wrote: > > > On Tue 28-05-19 20:12:08, Minchan Kim wrote: > > > > On Tue, May 28, 2019 at 12:41:17PM +0200, Michal Hocko wrote: > >

Re: [PATCH 01/12] bus: ti-sysc: Support 16-bit writes too

2019-05-28 Thread Tony Lindgren
* David Laight [190528 11:06]: > From: Tony Lindgren > > Sent: 27 May 2019 13:14 > > We need to also support 16-bit writes for i2c in addition to the reads > > when we start configuring the sysconfig register for reset and idle modes. > > > > Signed-off-by: Tony Lindgren > > --- > > drivers/bus

Re: [PATCH] Smack: Restore the smackfsdef mount option

2019-05-28 Thread David Howells
Casey Schaufler wrote: > The change was made in commit c3300aaf95fb4 from Al Viro. This should be in a "Fixes:" tag? > + fsparam_string("fsdef", Opt_fsdefault), > fsparam_string("fsdefault", Opt_fsdefault), > fsparam_string("fsfloor", Opt_fsfloor), > fspa

Re: [PATCH] brcmfmac: use strlcpy() instead of strcpy()

2019-05-28 Thread Kalle Valo
neo...@gmail.com wrote: > From: Neo Jou > > The function strcpy() is inherently not safe. Though the function > works without problems here, it would be better to use other safer > function, e.g. strlcpy(), to replace strcpy() still. > > Signed-off-by: Neo Jou Patch applied to wireless-driver

Re: [PATCH v2] brcmfmac: fix typos in code comments

2019-05-28 Thread Kalle Valo
Weitao Hou wrote: > fix lengh to length > > Signed-off-by: Weitao Hou Patch applied to wireless-drivers-next.git, thanks. b07e1ae2ce53 brcmfmac: fix typos in code comments -- https://patchwork.kernel.org/patch/10950995/ https://wireless.wiki.kernel.org/en/developers/documentation/submittin

Re: test VIDIOC_G/S_PARM: FAIL on stable 4.14, 4.9 and 4.4

2019-05-28 Thread Naresh Kamboju
Hi Hans, On Tue, 28 May 2019 at 17:27, Hans Verkuil wrote: > Do you see test VIDIOC_G/S_PARM: FAIL on stable 4.14, 4.9 and 4.4 > kernel branches ? > >>> > >>> Probably related to commit 8a7c5594c0202 (media: v4l2-ioctl: clear fields > >>> in s_parm). > >> > >> I have cherry-picked on s

Re: [PATCH 3/9] perf/x86/intel: Support overflows on SLOTS

2019-05-28 Thread Peter Zijlstra
On Tue, May 21, 2019 at 02:40:49PM -0700, kan.li...@linux.intel.com wrote: > From: Andi Kleen > > The internal counters used for the metrics can overflow. If this happens > an overflow is triggered on the SLOTS fixed counter. Add special code > that resets all the slave metric counters in this ca

Re: [RFC 7/7] mm: madvise support MADV_ANONYMOUS_FILTER and MADV_FILE_FILTER

2019-05-28 Thread Daniel Colascione
On Tue, May 28, 2019 at 4:56 AM Michal Hocko wrote: > > On Tue 28-05-19 04:42:47, Daniel Colascione wrote: > > On Tue, May 28, 2019 at 4:28 AM Michal Hocko wrote: > > > > > > On Tue 28-05-19 20:12:08, Minchan Kim wrote: > > > > On Tue, May 28, 2019 at 12:41:17PM +0200, Michal Hocko wrote: > > > >

[PATCH] selftests: vm: install test_vmalloc.sh for run_vmtests

2019-05-28 Thread Naresh Kamboju
Add test_vmalloc.sh to TEST_FILES to make sure it gets installed for run_vmtests. Fixed below error: ./run_vmtests: line 217: ./test_vmalloc.sh: No such file or directory Tested with: make TARGETS=vm install INSTALL_PATH=$PWD/x Signed-off-by: Naresh Kamboju --- tools/testing/selftests/vm/Makef

Re: [PATCH 1/3] brcmfmac: re-enable command decode in sdio_aos for BRCM 4354

2019-05-28 Thread Kalle Valo
Douglas Anderson wrote: > In commit 29f6589140a1 ("brcmfmac: disable command decode in > sdio_aos") we disabled something called "command decode in sdio_aos" > for a whole bunch of Broadcom SDIO WiFi parts. > > After that patch landed I find that my kernel log on > rk3288-veyron-minnie and rk328

[PATCH] usb: gadget: fusb300_udc: Fix memory leak of fusb300->ep[i]

2019-05-28 Thread Young Xiao
There is no deallocation of fusb300->ep[i] elements, allocated at fusb300_probe. The patch adds deallocation of fusb300->ep array elements. Signed-off-by: Young Xiao <92siuy...@gmail.com> --- drivers/usb/gadget/udc/fusb300_udc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/us

Re: [PATCH 2/9] perf/x86/intel: Basic support for metrics counters

2019-05-28 Thread Peter Zijlstra
On Tue, May 21, 2019 at 02:40:48PM -0700, kan.li...@linux.intel.com wrote: > +/* > + * We model PERF_METRICS as more magic fixed-mode PMCs, one for each metric > + * and another for the whole slots counter > + * > + * Internally they all map to Fixed Ctr 3 (SLOTS), and allocate PERF_METRICS > + * a

Re: [PATCH] wlcore: spi: Fix a memory leaking bug in wl1271_probe()

2019-05-28 Thread Gen Zhang
On Tue, May 28, 2019 at 11:39:22AM +, Kalle Valo wrote: > Gen Zhang wrote: > > > In wl1271_probe(), 'glue->core' is allocated by platform_device_alloc(), > > when this allocation fails, ENOMEM is returned. However, 'pdev_data' > > and 'glue' are allocated by devm_kzalloc() before 'glue->core'

Re: [RFC 7/7] mm: madvise support MADV_ANONYMOUS_FILTER and MADV_FILE_FILTER

2019-05-28 Thread Daniel Colascione
On Tue, May 28, 2019 at 4:49 AM Michal Hocko wrote: > > On Tue 28-05-19 04:21:44, Daniel Colascione wrote: > > On Tue, May 28, 2019 at 3:33 AM Michal Hocko wrote: > > > > > > On Tue 28-05-19 02:39:03, Daniel Colascione wrote: > > > > On Tue, May 28, 2019 at 2:08 AM Michal Hocko wrote: > > > > >

Re: [PATCH] network: wireless: p54u: Fix race between disconnect and firmware loading

2019-05-28 Thread Kalle Valo
Alan Stern writes: > The syzbot fuzzer found a bug in the p54 USB wireless driver. The > issue involves a race between disconnect and the firmware-loader > callback routine, and it has several aspects. > > One big problem is that when the firmware can't be loaded, the > callback routine tries to

Re: [RFC 7/7] mm: madvise support MADV_ANONYMOUS_FILTER and MADV_FILE_FILTER

2019-05-28 Thread Minchan Kim
On Tue, May 28, 2019 at 04:42:47AM -0700, Daniel Colascione wrote: > On Tue, May 28, 2019 at 4:28 AM Michal Hocko wrote: > > > > On Tue 28-05-19 20:12:08, Minchan Kim wrote: > > > On Tue, May 28, 2019 at 12:41:17PM +0200, Michal Hocko wrote: > > > > On Tue 28-05-19 19:32:56, Minchan Kim wrote: > >

Re: [PATCH v2] cpuset: restore sanity to cpuset_cpus_allowed_fallback()

2019-05-28 Thread Michal Koutný
Thanks for digging through this. On Fri, May 24, 2019 at 11:33:55AM -0400, Joel Savitz wrote: > It is a bit ambiguous, but I performed no action on the task's cpuset > nor did I offline any cpus at point (a). So did you do any operation that left you with cpu_active_mask & 0xf0 == 0 ? (If s

Re: [RFC 7/7] mm: madvise support MADV_ANONYMOUS_FILTER and MADV_FILE_FILTER

2019-05-28 Thread Michal Hocko
On Tue 28-05-19 20:44:36, Minchan Kim wrote: > On Tue, May 28, 2019 at 01:28:40PM +0200, Michal Hocko wrote: > > On Tue 28-05-19 20:12:08, Minchan Kim wrote: > > > On Tue, May 28, 2019 at 12:41:17PM +0200, Michal Hocko wrote: > > > > On Tue 28-05-19 19:32:56, Minchan Kim wrote: > > > > > On Tue, Ma

Re: [PATCH 2/9] perf/x86/intel: Basic support for metrics counters

2019-05-28 Thread Peter Zijlstra
On Tue, May 21, 2019 at 02:40:48PM -0700, kan.li...@linux.intel.com wrote: > From: Andi Kleen > > Metrics counters (hardware counters containing multiple metrics) > are modeled as separate registers for each TopDown metric events, > with an extra reg being used for coordinating access to the > un

RE: [PATCH v2] signal: Adjust error codes according to restore_user_sigmask()

2019-05-28 Thread David Laight
From: Deepa Dinamani > Sent: 28 May 2019 12:38 > > On May 28, 2019, at 2:12 AM, David Laight wrote: > > > > From: Deepa Dinamani > >> Sent: 24 May 2019 18:02 > > ... > >> Look at the code before 854a6ed56839a: > >> > >> /* > >> * If we changed the signal mask, we need to restore the original

RE: [PATCH] ARC: [plat-hsdk]: enable creg-gpio controller

2019-05-28 Thread Alexey Brodkin
Hi Eugeniy, > -Original Message- > From: Eugeniy Paltsev > Sent: Tuesday, May 28, 2019 12:41 PM > To: linux-snps-...@lists.infradead.org; Vineet Gupta > Cc: linux-kernel@vger.kernel.org; Alexey Brodkin ; > Eugeniy Paltsev > > Subject: [PATCH] ARC: [plat-hsdk]: enable creg-gpio controll

[PATCH] unicore32: fix framepointer check in unwind_frame

2019-05-28 Thread Young Xiao
This patch fixes corner case when (fp + 4) overflows unsigned long, for example: fp = 0x -> fp + 4 == 3. Copy from commit 3abb6671a9c0 ("ARM: 7913/1: fix framepointer check in unwind_frame"). Signed-off-by: Young Xiao <92siuy...@gmail.com> --- arch/unicore32/kernel/stacktrace.c | 2 +- 1

RE: [PATCH] ARC: [plat-hsdk]: unify memory apertures configuration

2019-05-28 Thread Alexey Brodkin
Hi Eugeniy, > -Original Message- > From: Eugeniy Paltsev > Sent: Tuesday, May 28, 2019 11:55 AM > To: linux-snps-...@lists.infradead.org; Vineet Gupta > Cc: linux-kernel@vger.kernel.org; Alexey Brodkin ; > Eugeniy Paltsev > > Subject: [PATCH] ARC: [plat-hsdk]: unify memory apertures co

Re: test VIDIOC_G/S_PARM: FAIL on stable 4.14, 4.9 and 4.4

2019-05-28 Thread Hans Verkuil
On 5/28/19 12:16 PM, Naresh Kamboju wrote: > Hi Hans, > > On Mon, 20 May 2019 at 19:26, Naresh Kamboju > wrote: >> >> Hi Hans, >> >> On Mon, 13 May 2019 at 19:08, Hans Verkuil wrote: >>> >>> On 5/13/19 3:32 PM, Naresh Kamboju wrote: Do you see test VIDIOC_G/S_PARM: FAIL on stable 4.14, 4.9

[PATCH] ixgbevf: fix possible divide by zero in ixgbevf_update_itr

2019-05-28 Thread Young Xiao
The next call to ixgbevf_update_itr will continue to dynamically update ITR. Copy from commit bdbeefe8ea8c ("ixgbe: fix possible divide by zero in ixgbe_update_itr") Signed-off-by: Young Xiao <92siuy...@gmail.com> --- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 3 +++ 1 file changed, 3 i

Re: [RFC 7/7] mm: madvise support MADV_ANONYMOUS_FILTER and MADV_FILE_FILTER

2019-05-28 Thread Michal Hocko
On Tue 28-05-19 04:42:47, Daniel Colascione wrote: > On Tue, May 28, 2019 at 4:28 AM Michal Hocko wrote: > > > > On Tue 28-05-19 20:12:08, Minchan Kim wrote: > > > On Tue, May 28, 2019 at 12:41:17PM +0200, Michal Hocko wrote: > > > > On Tue 28-05-19 19:32:56, Minchan Kim wrote: > > > > > On Tue, M

[PATCH v4 1/2] dt-bindings: clock: renesas,r9a06g032-sysctrl: Document power Domains

2019-05-28 Thread Gareth Williams
The driver is gaining power domain support, so add the new property to the DT binding and update the examples. Signed-off-by: Gareth Williams Reviewed-by: Geert Uytterhoeven --- v4: - Added missing HCLK to UART0 example to show the clock added to the driver. - Added Geert's Reviewed-by line

Re: [PATCH] rtlwifi: Fix null-pointer dereferences in error handling code of rtl_pci_probe()

2019-05-28 Thread Kalle Valo
Jia-Ju Bai wrote: > *BUG 1: > In rtl_pci_probe(), when rtlpriv->cfg->ops->init_sw_vars() fails, > rtl_deinit_core() in the error handling code is executed. > rtl_deinit_core() calls rtl_free_entries_from_scan_list(), which uses > rtlpriv->scan_list.list in list_for_each_entry_safe(), but it has b

[PATCH v4 2/2] clk: renesas: r9a06g032: Add clock domain support

2019-05-28 Thread Gareth Williams
There are several clocks on the r9a06g032 which are currently not enabled in their drivers that can be delegated to clock domain system for power management. Therefore add support for clock domain functionality to the r9a06g032 clock driver. Signed-off-by: Gareth Williams --- v4: - Removed unne

My emacs problem -- was Re: [PATCH] x86/fpu: Use fault_in_pages_writeable() for pre-faulting

2019-05-28 Thread Pavel Machek
Hi! On Sun 2019-05-26 12:25:27, Hugh Dickins wrote: > On Sun, 26 May 2019, Sebastian Andrzej Siewior wrote: > > On 2019-05-26 19:33:25 [+0200], To Hugh Dickins wrote: > > From: Hugh Dickins > > … > > > Signed-off-by: Hugh Dickins > > > > Hugh, I took your patch, slapped a signed-off-by line. Pl

[PATCH v4 0/2] clk: renesas: r9a06g032: Add clock domain support

2019-05-28 Thread Gareth Williams
There are several clocks on the r9a06g032 which are currently not enabled in their drivers that can be delegated to clock domain system for power management. Therefore add support for clock domain functionality to the r9a06g032 clock driver after updating the relevant dt-bindings file. v4: - Remo

Re: LZ4 decompressor broken on ARM due to missing strchrnul() string traverse in cpumask_parse"

2019-05-28 Thread Sebastian Andrzej Siewior
On 2019-05-28 13:33:12 [+0200], Rasmus Villemoes wrote: > > How do we deal with this one? > > Urgh. The problem is really in arch/arm/boot/compressed/decompress.c > which does > > #define _LINUX_STRING_H_ > > preventing linux/string.h from providing strchrnul. It also #includes > asm/string.h, w

Re: [RFC 7/7] mm: madvise support MADV_ANONYMOUS_FILTER and MADV_FILE_FILTER

2019-05-28 Thread Daniel Colascione
On Tue, May 28, 2019 at 4:44 AM Minchan Kim wrote: > > On Tue, May 28, 2019 at 01:28:40PM +0200, Michal Hocko wrote: > > On Tue 28-05-19 20:12:08, Minchan Kim wrote: > > > On Tue, May 28, 2019 at 12:41:17PM +0200, Michal Hocko wrote: > > > > On Tue 28-05-19 19:32:56, Minchan Kim wrote: > > > > > O

Re: [RFC 7/7] mm: madvise support MADV_ANONYMOUS_FILTER and MADV_FILE_FILTER

2019-05-28 Thread Michal Hocko
On Tue 28-05-19 04:21:44, Daniel Colascione wrote: > On Tue, May 28, 2019 at 3:33 AM Michal Hocko wrote: > > > > On Tue 28-05-19 02:39:03, Daniel Colascione wrote: > > > On Tue, May 28, 2019 at 2:08 AM Michal Hocko wrote: > > > > > > > > On Tue 28-05-19 17:49:27, Minchan Kim wrote: > > > > > On T

Re: [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors

2019-05-28 Thread Adrian Hunter
On 28/05/19 2:21 PM, Arend Van Spriel wrote: > > > On 5/28/2019 12:04 PM, Adrian Hunter wrote: >> On 26/05/19 9:42 PM, Arend Van Spriel wrote: >>> On 5/18/2019 12:54 AM, Douglas Anderson wrote: Normally when the MMC core sees an "-EILSEQ" error returned by a host controller then it will

Re: [RFC 7/7] mm: madvise support MADV_ANONYMOUS_FILTER and MADV_FILE_FILTER

2019-05-28 Thread Minchan Kim
On Tue, May 28, 2019 at 01:28:40PM +0200, Michal Hocko wrote: > On Tue 28-05-19 20:12:08, Minchan Kim wrote: > > On Tue, May 28, 2019 at 12:41:17PM +0200, Michal Hocko wrote: > > > On Tue 28-05-19 19:32:56, Minchan Kim wrote: > > > > On Tue, May 28, 2019 at 11:08:21AM +0200, Michal Hocko wrote: > >

Re: [RFC 7/7] mm: madvise support MADV_ANONYMOUS_FILTER and MADV_FILE_FILTER

2019-05-28 Thread Daniel Colascione
On Tue, May 28, 2019 at 4:28 AM Michal Hocko wrote: > > On Tue 28-05-19 20:12:08, Minchan Kim wrote: > > On Tue, May 28, 2019 at 12:41:17PM +0200, Michal Hocko wrote: > > > On Tue 28-05-19 19:32:56, Minchan Kim wrote: > > > > On Tue, May 28, 2019 at 11:08:21AM +0200, Michal Hocko wrote: > > > > >

Re: [PATCH] rtw88: Make some symbols static

2019-05-28 Thread Kalle Valo
YueHaibing wrote: > Fix sparse warnings: > > drivers/net/wireless/realtek/rtw88/phy.c:851:4: warning: symbol > 'rtw_cck_size' was not declared. Should it be static? > drivers/net/wireless/realtek/rtw88/phy.c:852:4: warning: symbol > 'rtw_ofdm_size' was not declared. Should it be static? > driv

Re: [PATCH v2] powerpc/32: sstep: Move variable `rc` within CONFIG_PPC64 sentinels

2019-05-28 Thread Michael Ellerman
Mathieu Malaterre writes: > Fix warnings treated as errors with W=1: > > arch/powerpc/lib/sstep.c:1172:31: error: variable 'rc' set but not used > [-Werror=unused-but-set-variable] > > Suggested-by: Christophe Leroy > Signed-off-by: Mathieu Malaterre > --- > v2: as suggested prefer CONFIG_PP

Re: [PATCH] wlcore: spi: Fix a memory leaking bug in wl1271_probe()

2019-05-28 Thread Kalle Valo
Gen Zhang wrote: > In wl1271_probe(), 'glue->core' is allocated by platform_device_alloc(), > when this allocation fails, ENOMEM is returned. However, 'pdev_data' > and 'glue' are allocated by devm_kzalloc() before 'glue->core'. When > platform_device_alloc() returns NULL, we should also free 'pd

Re: [PATCH v2] signal: Adjust error codes according to restore_user_sigmask()

2019-05-28 Thread Deepa Dinamani
> On May 28, 2019, at 2:12 AM, David Laight wrote: > > From: Deepa Dinamani >> Sent: 24 May 2019 18:02 > ... >> Look at the code before 854a6ed56839a: >> >> /* >> * If we changed the signal mask, we need to restore the original one. >> * In case we've got a signal while waiting, w

Re: [PATCH] kasan: add memory corruption identification for software tag-based mode

2019-05-28 Thread Dmitry Vyukov
and On Tue, May 28, 2019 at 9:17 AM Walter Wu wrote: > > This patch adds memory corruption identification at bug report for > software tag-based mode, the report show whether it is "use-after-free" > or "out-of-bound" error instead of "invalid-access" error.This will make > it easier for progra

Re: [PATCH v3 1/9] leds: multicolor: Add sysfs interface definition

2019-05-28 Thread Dan Murphy
Pavel On 5/27/19 7:45 PM, Dan Murphy wrote: Pavel On 5/27/19 5:33 AM, Pavel Machek wrote: On Thu 2019-05-23 14:08:12, Dan Murphy wrote: Add a documentation of LED Multicolor LED class specific sysfs attributes. Signed-off-by: Dan Murphy ---   .../ABI/testing/sysfs-class-led-multicolor    |

Re: [PATCH v2 5.2] rsi: Properly initialize data in rsi_sdio_ta_reset

2019-05-28 Thread Kalle Valo
Nathan Chancellor wrote: > When building with -Wuninitialized, Clang warns: > > drivers/net/wireless/rsi/rsi_91x_sdio.c:940:43: warning: variable 'data' > is uninitialized when used here [-Wuninitialized] > put_unaligned_le32(TA_HOLD_THREAD_VALUE, data); >

[PATCH v2 1/3] x86/cpu: Create Zhaoxin processors architecture support file

2019-05-28 Thread Tony W Wang-oc
Add x86 architecture support for new Zhaoxin processors. Carve out initialization code needed by Zhaoxin processors into a separate compilation unit. To identify Zhaoxin CPU, add a new vendor type X86_VENDOR_ZHAOXIN for system recognition. Signed-off-by: Tony W Wang-oc --- MAINTAINERS

Re: LZ4 decompressor broken on ARM due to missing strchrnul() string traverse in cpumask_parse"

2019-05-28 Thread Rasmus Villemoes
On 28/05/2019 13.04, Sebastian Andrzej Siewior wrote: > | CC arch/arm/boot/compressed/decompress.o > |In file included from include/linux/mm_types_task.h:14, > | from include/linux/mm_types.h:5, > | from include/linux/mmzone.h:21, > | from inclu

Re: [PATCH 0/4 V3] ACPI: Support generic initiator proximity domains

2019-05-28 Thread Jonathan Cameron
Hi All, Anyone had a change to take a look at this? Thanks, Jonathan On Tue, 16 Apr 2019 01:49:03 +0800 Jonathan Cameron wrote: > Changes since RFC V2. > * RFC dropped as now we have x86 support, so the lack of guards in in the > ACPI code etc should now be fine. > * Added x86 support. Note

[PATCH v2 0/3] Add support for Zhaoxin Processors

2019-05-28 Thread Tony W Wang-oc
As a new x86 CPU Vendor, Shanghai Zhaoxin Semiconductor Co., Ltd. ("Zhaoxin") provide high performance general-purpose x86 processors. CPU Vendor ID "Shanghai" belongs to Zhaoxin. To enable the supports of Linux kernel to Zhaoxin's CPUs, add a new vendor type (X86_VENDOR_ZHAOXIN, with value of 1

Re: [RFC 7/7] mm: madvise support MADV_ANONYMOUS_FILTER and MADV_FILE_FILTER

2019-05-28 Thread Daniel Colascione
On Tue, May 28, 2019 at 3:41 AM Michal Hocko wrote: > > On Tue 28-05-19 19:32:56, Minchan Kim wrote: > > On Tue, May 28, 2019 at 11:08:21AM +0200, Michal Hocko wrote: > > > On Tue 28-05-19 17:49:27, Minchan Kim wrote: > > > > On Tue, May 28, 2019 at 01:31:13AM -0700, Daniel Colascione wrote: > > >

Re: [RFC 7/7] mm: madvise support MADV_ANONYMOUS_FILTER and MADV_FILE_FILTER

2019-05-28 Thread Michal Hocko
On Tue 28-05-19 20:12:08, Minchan Kim wrote: > On Tue, May 28, 2019 at 12:41:17PM +0200, Michal Hocko wrote: > > On Tue 28-05-19 19:32:56, Minchan Kim wrote: > > > On Tue, May 28, 2019 at 11:08:21AM +0200, Michal Hocko wrote: > > > > On Tue 28-05-19 17:49:27, Minchan Kim wrote: > > > > > On Tue, Ma

Re: [v6 2/3] mm/hotplug: make remove_memory() interface useable

2019-05-28 Thread Michal Hocko
On Fri 17-05-19 17:54:37, Pavel Tatashin wrote: > As of right now remove_memory() interface is inherently broken. It tries > to remove memory but panics if some memory is not offline. The problem > is that it is impossible to ensure that all memory blocks are offline as > this function also takes l

Re: [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors

2019-05-28 Thread Arend Van Spriel
On 5/28/2019 12:04 PM, Adrian Hunter wrote: On 26/05/19 9:42 PM, Arend Van Spriel wrote: On 5/18/2019 12:54 AM, Douglas Anderson wrote: Normally when the MMC core sees an "-EILSEQ" error returned by a host controller then it will trigger a retuning of the card.  This is generally a good idea

Re: [RFC 7/7] mm: madvise support MADV_ANONYMOUS_FILTER and MADV_FILE_FILTER

2019-05-28 Thread Daniel Colascione
On Tue, May 28, 2019 at 3:33 AM Michal Hocko wrote: > > On Tue 28-05-19 02:39:03, Daniel Colascione wrote: > > On Tue, May 28, 2019 at 2:08 AM Michal Hocko wrote: > > > > > > On Tue 28-05-19 17:49:27, Minchan Kim wrote: > > > > On Tue, May 28, 2019 at 01:31:13AM -0700, Daniel Colascione wrote: >

Re: [PATCH 4.19 082/114] fuse: Add FOPEN_STREAM to use stream_open()

2019-05-28 Thread Pavel Machek
Hi! > +++ b/include/uapi/linux/fuse.h > @@ -219,10 +219,12 @@ struct fuse_file_lock { > * FOPEN_DIRECT_IO: bypass page cache for this open file > * FOPEN_KEEP_CACHE: don't invalidate the data cache on open > * FOPEN_NONSEEKABLE: the file is not seekable > + * FOPEN_STREAM: the file is stream

Re: [PATCH 00/18] locking/atomic: atomic64 type cleanup

2019-05-28 Thread Andrea Parri
On Tue, May 28, 2019 at 12:47:19PM +0200, Peter Zijlstra wrote: > On Sat, May 25, 2019 at 12:43:40AM +0200, Andrea Parri wrote: > > > --- > > > Subject: Documentation/atomic_t.txt: Clarify pure non-rmw usage > > > > > > Clarify that pure non-RMW usage of atomic_t is pointless, there is > > > nothi

Re: memory leak in sctp_process_init

2019-05-28 Thread Neil Horman
On Mon, May 27, 2019 at 10:36:00PM -0300, Marcelo Ricardo Leitner wrote: > On Mon, May 27, 2019 at 05:48:06PM -0700, syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:9c7db500 Merge tag 'selinux-pr-20190521' of git://git.kern.. > > git tree: upstr

Re: [PATCH v2 2/6] i2c: acpi: Use available IRQ helper functions

2019-05-28 Thread Charles Keepax
On Tue, May 28, 2019 at 01:30:28PM +0300, Mika Westerberg wrote: > On Mon, May 27, 2019 at 04:19:28PM +0100, Charles Keepax wrote: > > static int i2c_acpi_get_info(struct acpi_device *adev, > > struct i2c_board_info *info, > > struct i2c_adapter *a

Re: [RFC 7/7] mm: madvise support MADV_ANONYMOUS_FILTER and MADV_FILE_FILTER

2019-05-28 Thread Minchan Kim
On Tue, May 28, 2019 at 12:41:17PM +0200, Michal Hocko wrote: > On Tue 28-05-19 19:32:56, Minchan Kim wrote: > > On Tue, May 28, 2019 at 11:08:21AM +0200, Michal Hocko wrote: > > > On Tue 28-05-19 17:49:27, Minchan Kim wrote: > > > > On Tue, May 28, 2019 at 01:31:13AM -0700, Daniel Colascione wrote

Re: [PATCH v3 0/7] Allwinner H6 DMA support

2019-05-28 Thread Maxime Ripard
On Mon, May 27, 2019 at 10:14:52PM +0200, Clément Péron wrote: > Hi, > > This series has been first proposed by Jernej Skrabec[1]. > As this series is mandatory for SPDIF/I2S support and because he is > busy on Cedrus stuff. I asked him to make the minor change requested > and repost it. > Authorsh

Re: [PATCH -next 0/2] Platform: OLPC: Fix two randbuild error

2019-05-28 Thread Lubomir Rintel
On Tue, 2019-05-28 at 17:28 +0800, YueHaibing wrote: > Fix two randbuild error: > 1) Fix build error with CONFIG_SPI is not set > 2) Fix build error with CONFIG_INPUT is set to m > > YueHaibing (2): > Platform: OLPC: Fix build error without CONFIG_SPI > Platform: OLPC: Add INPUT dependencies >

RE: [PATCH 01/12] bus: ti-sysc: Support 16-bit writes too

2019-05-28 Thread David Laight
From: Tony Lindgren > Sent: 27 May 2019 13:14 > We need to also support 16-bit writes for i2c in addition to the reads > when we start configuring the sysconfig register for reset and idle modes. > > Signed-off-by: Tony Lindgren > --- > drivers/bus/ti-sysc.c | 7 +++ > 1 file changed, 7 inse

Re: [PATCH v2 2/3] iio: common: cros_ec_sensors: add sysfs attribute for frequencies

2019-05-28 Thread Gwendal Grignou
On Mon, May 27, 2019 at 2:55 AM Fabien Lahoudere wrote: > > Le dimanche 26 mai 2019 à 18:45 +0100, Jonathan Cameron a écrit : > > On Thu, 23 May 2019 11:07:36 +0200 > > Fabien Lahoudere wrote: > > > > > In order to provide minimum and maximum frequencies for each > > > sensors, > > > we use a sta

LZ4 decompressor broken on ARM due to missing strchrnul() string traverse in cpumask_parse"

2019-05-28 Thread Sebastian Andrzej Siewior
| CC arch/arm/boot/compressed/decompress.o |In file included from include/linux/mm_types_task.h:14, | from include/linux/mm_types.h:5, | from include/linux/mmzone.h:21, | from include/linux/gfp.h:6, | from include/linux/umh.h:4,

Re: [PATCH 8/9] KVM: s390: Do not report unusabled IDs via KVM_CAP_MAX_VCPU_ID

2019-05-28 Thread Christian Borntraeger
Paolo, Radim, would you consider this patch (or the full series) as 5.2 material or 5.3 material? On 23.05.19 18:43, Thomas Huth wrote: > KVM_CAP_MAX_VCPU_ID is currently always reporting KVM_MAX_VCPU_ID on all > architectures. However, on s390x, the amount of usable CPUs is determined > during

Re: [PATCH 3/4] iio: adc: mediatek: SET_LATE_SYSTEM_SLEEP_PM_OPS support

2019-05-28 Thread Chun-Hung Wu
Hi Matthias: Thanks for your suggestion, I think device_links is a good way to make dependency of module's suspend/resume order. Hi Jonathan: Is it ok to keep using late_suspend and early_resume, or do you think it's better to use device_links? Thanks, Chun-Hung On Wed, 2019-05-22 at 18:28

Re: need company for kernel upgrade

2019-05-28 Thread Pavel Machek
On Fri 2019-05-24 01:01:16, Theodore Ts'o wrote: > On Thu, May 23, 2019 at 09:29:11AM +0200, walter harms wrote: > > > > No, > > the company i am working for has a custom build arm-board. > > We bought the kernel from the assembler but found it has > > some problems that need fixing. > > Basically

<    2   3   4   5   6   7   8   9   10   >