[PATCH v2 15/35] net/ethernet: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

[PATCH v2 16/35] net/wimax: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

[PATCH v2 11/35] media/dvb: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

[PATCH v2 12/35] media/tuners: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

Re: [PATCH 2/4] kvm: x86: allow set apic and ioapic debug dynamically

2019-07-03 Thread Liran Alon
> On 3 Jul 2019, at 19:23, Paolo Bonzini wrote: > > On 01/07/19 08:21, Yi Wang wrote: >> There are two *_debug() macros in kvm apic source file: >> - ioapic_debug, which is disable using #if 0 >> - apic_debug, which is commented >> >> Maybe it's better to control these two macros using

[PATCH v2 10/35] macintosh: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

Re: md-multipath: Replace a seq_printf() call by seq_putc() in multipath_status()

2019-07-03 Thread Markus Elfring
>> A single character (depending on a condition check) should be put >> into a sequence. Thus use the corresponding function “seq_putc”. … > Can you explain why this is necessary? I suggest another bit of software fine-tuning. * Pass only a relevant character instead of a string. * Omit the

[PATCH v2 13/35] media/usb: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

[PATCH v2 08/35] drm/i915: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

[PATCH v2 07/35] drm/amdgpu: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

[PATCH v2 09/35] infiniband: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

[PATCH v2 02/35] powerpc: Add an allocation failure check

2019-07-03 Thread Fuqian Huang
Add an allocation failure check. Signed-off-by: Fuqian Huang --- Changes in v2: - Split into two patches arch/powerpc/platforms/pseries/dlpar.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c index

[PATCH v2 04/35] block: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

[PATCH v2 06/35] crypto: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

[PATCH v2 03/35] powerpc: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

[PATCH v2 05/35] clk/ti: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

[PATCH v2 01/35] ia64/sn: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Fuqian Huang
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use

Re: [PATCH 0/4] kvm: x86: introduce CONFIG_KVM_DEBUG

2019-07-03 Thread Paolo Bonzini
On 01/07/19 08:21, Yi Wang wrote: > This series introduce CONFIG_KVM_DEBUG, using which we can make > the invoking *_debug in KVM simly and uniform. > > FYI: the former discussion can been found in: > https://www.spinics.net/lists/kvm/msg187026.html Basically everything except MMU_DEBUG can just

Re: [PATCH 4/4] kvm: x86: convert TSC pr_debugs to be gated by CONFIG_KVM_DEBUG

2019-07-03 Thread Paolo Bonzini
On 01/07/19 08:21, Yi Wang wrote: > There are some pr_debug in TSC code, which may affect > performance, so it may make sense to wrap them using a new > macro tsc_debug which takes effect only when CONFIG_KVM_DEBUG > is defined. > > Signed-off-by: Yi Wang > --- > arch/x86/kvm/x86.c | 18

Re: [PATCH 2/4] kvm: x86: allow set apic and ioapic debug dynamically

2019-07-03 Thread Paolo Bonzini
On 01/07/19 08:21, Yi Wang wrote: > There are two *_debug() macros in kvm apic source file: > - ioapic_debug, which is disable using #if 0 > - apic_debug, which is commented > > Maybe it's better to control these two macros using CONFIG_KVM_DEBUG, > which can be set in make menuconfig. > >

RE: [PATCH 17/30] pci: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread David Laight
From: Fuqian Huang > Sent: 03 July 2019 14:16 > > kmemdup is introduced to duplicate a region of memory in a neat way. > Rather than kmalloc/kzalloc + memset, which the programmer needs to > write the size twice (sometimes lead to mistakes), kmemdup improves > readability, leads to smaller code

Re: [PATCH RESEND v3] staging: erofs: remove unsupported ->datamode check in fill_inline_data()

2019-07-03 Thread Greg KH
On Tue, Jul 02, 2019 at 10:56:01AM +0800, Yue Hu wrote: > From: Yue Hu > > Already check if ->datamode is supported in read_inode(), no need to check > again in the next fill_inline_data() only called by fill_inode(). > > Signed-off-by: Yue Hu > Reviewed-by: Gao Xiang > Reviewed-by: Chao Yu

Re: [PATCH v4 0/5] x86 instruction emulator fuzzing

2019-07-03 Thread Paolo Bonzini
On 28/06/19 11:33, Alexander Graf wrote: > > > On 28.06.19 11:26, Sam Caccavale wrote: >> Dear all, >> >> This series aims to provide an entrypoint for, and fuzz KVM's x86 >> instruction >> emulator from userspace.  It mirrors Xen's application of the AFL >> fuzzer to >> it's instruction

Re: [PATCH 0/2] Use Media Dev Allocator to fix vimc dev lifetime bugs

2019-07-03 Thread Niklas Söderlund
Hi Shauah, Laurent, On 2019-06-30 14:41:02 +0300, Laurent Pinchart wrote: > Hi Shuah, > > On Fri, Jun 28, 2019 at 10:41:07AM -0600, Shuah Khan wrote: > > On 6/16/19 12:45 PM, Laurent Pinchart wrote: > > > On Fri, Jun 14, 2019 at 05:26:46PM -0600, Shuah Khan wrote: > > >> On 6/13/19 7:24 AM,

Re: [PATCH] mm, slab: Extend slab/shrink to shrink all the memcg caches

2019-07-03 Thread Waiman Long
On 7/3/19 11:53 AM, Michal Hocko wrote: > On Wed 03-07-19 11:21:16, Waiman Long wrote: >> On 7/2/19 5:33 PM, Andrew Morton wrote: >>> On Tue, 2 Jul 2019 16:44:24 -0400 Waiman Long wrote: >>> On 7/2/19 4:03 PM, Andrew Morton wrote: > On Tue, 2 Jul 2019 14:37:30 -0400 Waiman Long wrote:

Re: [PATCH] ARC: ARCv2: jump label: implement jump label patching

2019-07-03 Thread Vineet Gupta
On 6/18/19 9:16 AM, Vineet Gupta wrote: > On 6/14/19 9:41 AM, Eugeniy Paltsev wrote: >> Implement jump label patching for ARC. Jump labels provide >> an interface to generate dynamic branches using >> self-modifying code. >> >> This allows us to implement conditional branches where >> changing

Re: kernel panic: corrupted stack end in dput

2019-07-03 Thread John Fastabend
Eric Biggers wrote: > [+bpf and tls maintainers] > > On Wed, Jul 03, 2019 at 04:23:34PM +0100, Al Viro wrote: > > On Wed, Jul 03, 2019 at 03:40:00PM +0100, Al Viro wrote: > > > On Wed, Jul 03, 2019 at 02:43:07PM +0800, Hillf Danton wrote: > > > > > > > > This is very much *NOT* fine. > > > > >

Re: [PATCH] mm, slab: Extend slab/shrink to shrink all the memcg caches

2019-07-03 Thread Waiman Long
On 7/3/19 12:10 PM, Christopher Lameter wrote: > On Wed, 3 Jul 2019, Waiman Long wrote: > >> On 7/3/19 2:56 AM, Michal Hocko wrote: >>> On Tue 02-07-19 14:37:30, Waiman Long wrote: Currently, a value of '1" is written to /sys/kernel/slab//shrink file to shrink the slab by flushing all

Re: [PATCH] ARC: hide unused function unw_hdr_alloc

2019-07-03 Thread Vineet Gupta
On 7/3/19 6:39 AM, Arnd Bergmann wrote: > As kernelci.org reports, Curious, how are you getting these reports ? I want to see as well. > this function is not used in > vdk_hs38_defconfig: > > arch/arc/kernel/unwind.c:188:14: warning: 'unw_hdr_alloc' defined but not > used [-Wunused-function]

[PATCH] tpm: Document UEFI event log quirks

2019-07-03 Thread Jarkko Sakkinen
There are some weird quirks when it comes to UEFI event log. Provide a brief introduction to TPM event log mechanism and describe the quirks and how they can be sorted out. Signed-off-by: Jarkko Sakkinen --- Documentation/security/tpm/tpm-eventlog.rst | 53 + 1 file changed,

[PATCH 2/2] regulator: max77650: use vsel_step

2019-07-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the new vsel_step field in the regulator description to instruct the regulator API on the required voltage ramping. Switch to using the generic regmap helpers for voltage setting and remove the old set_voltage callback that handcoded the selector stepping.

Re: [PATCH] mm, slab: Extend slab/shrink to shrink all the memcg caches

2019-07-03 Thread Christopher Lameter
On Wed, 3 Jul 2019, Waiman Long wrote: > On 7/3/19 2:56 AM, Michal Hocko wrote: > > On Tue 02-07-19 14:37:30, Waiman Long wrote: > >> Currently, a value of '1" is written to /sys/kernel/slab//shrink > >> file to shrink the slab by flushing all the per-cpu slabs and free > >> slabs in partial

[PATCH 0/2] regulator: selector stepping for voltage regulators

2019-07-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Hi Mark, Liam, I know this won't make it for v5.3, but I thought I'd send it already for you to take a look. Some time ago we discussed implementing the voltage stepping in the regulator core. Here's a first go at that. The first user is the max77650 driver which

[PATCH 1/2] regulator: implement selector stepping

2019-07-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Some regulators require that the requested voltage be reached gradually by setting all or some of the intermediate values. Implement a new field in the regulator description struct that allows users to specify the number of selectors by which the regulator API should

Re: NO_HZ_IDLE causes consistently low cpu "iowait" time (and higher cpu "idle" time)

2019-07-03 Thread Alan Jenkins
On 03/07/2019 15:06, Doug Smythies wrote: On 2019.07.01 08:34 Alan Jenkins wrote: Hi Hi, I tried running a simple test: dd if=testfile iflag=direct bs=1M of=/dev/null With my default settings, `vmstat 10` shows something like 85% idle time to 15% iowait time. I have 4 CPUs, so this

Re: linux-next: Tree for Jul 3 (netfilter/ipvs/)

2019-07-03 Thread Randy Dunlap
On 7/3/19 4:49 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190702: > on i386: CC net/netfilter/ipvs/ip_vs_core.o ../net/netfilter/ipvs/ip_vs_core.c: In function ‘ipvs_gre_decap’: ../net/netfilter/ipvs/ip_vs_core.c:1618:22: error: storage size of ‘_greh’ isn’t known

[PATCH] arch: powerpc: Kconfig: pedantic formatting

2019-07-03 Thread Enrico Weigelt, metux IT consult
Formatting of Kconfig files doesn't look so pretty, so let the Great White Handkerchief come around and clean it up. Also convert "---help---" as requested on lkml. Signed-off-by: Enrico Weigelt, metux IT consult --- arch/powerpc/Kconfig | 40

Re: [PATCH] nfsd: Fix overflow causing non-working mounts on 1 TB machines

2019-07-03 Thread Paul Menzel
Dear Bruce, On 7/3/19 5:56 PM, J. Bruce Fields wrote: > Good catch! And thanks for the detailed explanation. Applying for 5.2 > and stable. Thanks. Please note, that in the last part are some guesses, and I am not well versed in the terminology. So please feel free to reword the commit

Re: [GIT PULL 1/9] intel_th: msu: Fix unused variable warning on arm64 platform

2019-07-03 Thread Alexander Shishkin
Greg Kroah-Hartman writes: >> > Does not apply to my tree :( >> >> It's the same one as the one in the fixes series. I just put it here for >> completeness. > > to be extra sure it was really applied? that's funny... It's also a pull request based on 5.2-rc1. I don't know any other ways to do

Re: [net/tls] Re: KMSAN: uninit-value in aesti_encrypt

2019-07-03 Thread Eric Biggers
On Thu, Jun 27, 2019 at 12:01:23PM -0700, Eric Biggers wrote: > On Thu, Jun 27, 2019 at 11:19:51AM -0700, John Fastabend wrote: > > Eric Biggers wrote: > > > [+TLS maintainers] > > > > > > Very likely a net/tls bug, not a crypto bug. > > > > > > Possibly a duplicate of other reports such as

Re: linux-next: Tree for Jul 3 (amdgpu)

2019-07-03 Thread Randy Dunlap
On 7/3/19 4:49 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190702: > on i386 or x86_64: ERROR: "dm_ip_block" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! or ld: drivers/gpu/drm/amd/amdgpu/nv.o: in function `nv_set_ip_blocks': nv.c:(.text+0x1660): undefined reference to

[PATCH 1/1] mm/vmalloc: do not keep unpurged areas in the busy tree

2019-07-03 Thread Uladzislau Rezki (Sony)
The busy tree can be quite big, even though the area is freed or unmapped it still stays there until "purge" logic removes it. 1) Optimize and reduce the size of "busy" tree by removing a node from it right away as soon as user triggers free paths. It is possible to do so, because the allocation

Re: [PATCH V2 1/2] serial/8250: Add support for NI-Serial PXI/PXIe+485 devices

2019-07-03 Thread Greg KH
On Wed, Jul 03, 2019 at 05:41:25PM +0200, Enrico Weigelt, metux IT consult wrote: > On 03.07.19 16:47, Greg KH wrote: > > On Wed, Jul 03, 2019 at 03:27:11PM +0200, Enrico Weigelt, metux IT consult > > wrote: > >>> /* UART Port Control Register */> -#define NI8430_PORTCON0x0f> > >>>

Re: [GIT PULL 1/9] intel_th: msu: Fix unused variable warning on arm64 platform

2019-07-03 Thread Greg Kroah-Hartman
On Wed, Jul 03, 2019 at 06:54:05PM +0300, Alexander Shishkin wrote: > Greg Kroah-Hartman writes: > > > On Thu, Jun 27, 2019 at 03:51:44PM +0300, Alexander Shishkin wrote: > >> From: Shaokun Zhang > >> > >> Commit ba39bd8306057 ("intel_th: msu: Switch over to scatterlist") > >> introduced the

Re: [GIT PULL 8/9] intel_th: msu-sink: An example msu buffer driver

2019-07-03 Thread Greg Kroah-Hartman
On Thu, Jun 27, 2019 at 03:51:51PM +0300, Alexander Shishkin wrote: > This patch adds an example "sink" MSU buffer driver, which consumes trace > data from MSC buffers. > > Functionally, it acts similarly to "multi" mode with automatic window > switching. > > Signed-off-by: Alexander Shishkin >

Re: [PATCH] nfsd: Fix overflow causing non-working mounts on 1 TB machines

2019-07-03 Thread J. Bruce Fields
Good catch! And thanks for the detailed explanation. Applying for 5.2 and stable. On Wed, Jul 03, 2019 at 02:54:43PM +0200, Paul Menzel wrote: > Date: Wed, 3 Jul 2019 13:28:15 +0200 > > Since commit 10a68cdf10 (nfsd: fix performance-limiting session > calculation) (Linux 5.1-rc1 and 4.19.31),

Re: [GIT PULL 5/9] intel_th: msu: Introduce buffer driver interface

2019-07-03 Thread Greg Kroah-Hartman
On Thu, Jun 27, 2019 at 03:51:48PM +0300, Alexander Shishkin wrote: > Introduces a concept of buffer drivers, which is a mechanism for creating > trace sinks that would receive trace data from MSC buffers and transfer it > elsewhere. > > A buffer driver can implement its own window

Re: [GIT PULL 1/9] intel_th: msu: Fix unused variable warning on arm64 platform

2019-07-03 Thread Alexander Shishkin
Greg Kroah-Hartman writes: > On Thu, Jun 27, 2019 at 03:51:44PM +0300, Alexander Shishkin wrote: >> From: Shaokun Zhang >> >> Commit ba39bd8306057 ("intel_th: msu: Switch over to scatterlist") >> introduced the following warnings on non-x86 architectures, as a result >> of reordering the multi

[PATCH] f2fs: support swap file w/ DIO

2019-07-03 Thread Jaegeuk Kim
Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 142 ++-- fs/f2fs/f2fs.h | 5 +- include/trace/events/f2fs.h | 11 +-- 3 files changed, 143 insertions(+), 15 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index

Re: [PATCH] mm, slab: Extend slab/shrink to shrink all the memcg caches

2019-07-03 Thread Michal Hocko
On Wed 03-07-19 11:21:16, Waiman Long wrote: > On 7/2/19 5:33 PM, Andrew Morton wrote: > > On Tue, 2 Jul 2019 16:44:24 -0400 Waiman Long wrote: > > > >> On 7/2/19 4:03 PM, Andrew Morton wrote: > >>> On Tue, 2 Jul 2019 14:37:30 -0400 Waiman Long wrote: > >>> > Currently, a value of '1" is

Re: [PATCH] filesystem-dax: Disable PMD support

2019-07-03 Thread Matthew Wilcox
On Mon, Jul 01, 2019 at 02:11:19PM +0200, Jan Kara wrote: > BTW, looking into the xarray code, I think I found another difference > between the old radix tree code and the new xarray code that could cause > issues. In the old radix tree code if we tried to insert PMD entry but > there was some PTE

Re: [GIT PULL 1/9] intel_th: msu: Fix unused variable warning on arm64 platform

2019-07-03 Thread Greg Kroah-Hartman
On Thu, Jun 27, 2019 at 03:51:44PM +0300, Alexander Shishkin wrote: > From: Shaokun Zhang > > Commit ba39bd8306057 ("intel_th: msu: Switch over to scatterlist") > introduced the following warnings on non-x86 architectures, as a result > of reordering the multi mode buffer allocation sequence: >

Re: kernel panic: corrupted stack end in dput

2019-07-03 Thread Eric Biggers
[+bpf and tls maintainers] On Wed, Jul 03, 2019 at 04:23:34PM +0100, Al Viro wrote: > On Wed, Jul 03, 2019 at 03:40:00PM +0100, Al Viro wrote: > > On Wed, Jul 03, 2019 at 02:43:07PM +0800, Hillf Danton wrote: > > > > > > This is very much *NOT* fine. > > > > 1) trylock can fail from any

Re: [GIT PULL 1/9] intel_th: msu: Fix unused variable warning on arm64 platform

2019-07-03 Thread Greg Kroah-Hartman
On Thu, Jun 27, 2019 at 03:51:44PM +0300, Alexander Shishkin wrote: > From: Shaokun Zhang > > Commit ba39bd8306057 ("intel_th: msu: Switch over to scatterlist") > introduced the following warnings on non-x86 architectures, as a result > of reordering the multi mode buffer allocation sequence: >

[PATCH V2 1/2] serial/8250: Add support for NI-Serial PXI/PXIe+485 devices

2019-07-03 Thread Enrico Weigelt, metux IT consult
On 03.07.19 16:47, Greg KH wrote: > On Wed, Jul 03, 2019 at 03:27:11PM +0200, Enrico Weigelt, metux IT consult > wrote: >>> /* UART Port Control Register */> -#define NI8430_PORTCON 0x0f> -#define >>> NI8430_PORTCON_TXVR_ENABLE (1 << 3) >> Can we have that renaming as a separate patch,

Re: [PATCH] checkpatch: avoid default n

2019-07-03 Thread Joe Perches
On Wed, 2019-07-03 at 17:03 +0800, Yingjoe Chen wrote: > On Wed, 2019-07-03 at 01:42 -0700, Joe Perches wrote: > > On Wed, 2019-07-03 at 16:30 +0800, Miles Chen wrote: > > > This change reports a warning when "default n" is used. > > > > > > I have seen several "remove default n" patches, so I

Re: [GIT PULL 3/4] intel_th: msu: Fix single mode with disabled IOMMU

2019-07-03 Thread Greg Kroah-Hartman
On Fri, Jun 21, 2019 at 07:19:29PM +0300, Alexander Shishkin wrote: > Commit 4e0eaf239fb3 ("intel_th: msu: Fix single mode with IOMMU") switched > the single mode code to use dma mapping pages obtained from the page > allocator, but with IOMMU disabled, that may lead to using SWIOTLB bounce >

Re: [GIT PULL 0/4] intel_th: Fixes for v5.2

2019-07-03 Thread Greg Kroah-Hartman
On Fri, Jun 21, 2019 at 07:19:26PM +0300, Alexander Shishkin wrote: > Hi Greg, > > Here are the fixes I have for v5.2 cycle: two gcc warnings, one dma mapping > issue and a new PCI ID. All issues were introduced in the same cycle, so no > -stable involvement. > > All patches are aiaiai-clean.

Re: [GIT PULL 0/4] intel_th: Fixes for v5.2

2019-07-03 Thread Greg Kroah-Hartman
On Wed, Jul 03, 2019 at 06:26:07PM +0300, Alexander Shishkin wrote: > Alexander Shishkin writes: > > > Hi Greg, > > Hi Greg, > > > Here are the fixes I have for v5.2 cycle: two gcc warnings, one dma mapping > > issue and a new PCI ID. All issues were introduced in the same cycle, so no > >

[PATCH v3] f2fs: avoid out-of-range memory access

2019-07-03 Thread Ocean Chen
blk_off might over 512 due to fs corrupt and should be checked before being used. Use ENTRIES_IN_SUM to protect invalid memory access. -- v2: - fix typo v3: - check blk_off before being used -- Signed-off-by: Ocean Chen --- fs/f2fs/segment.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH] soc: rockchip: work around clang warning

2019-07-03 Thread Arnd Bergmann
clang emits a warning about a negative shift count for an unused part of a conditional constant expression: drivers/soc/rockchip/pm_domains.c:795:21: error: shift count is negative [-Werror,-Wshift-count-negative] [RK3328_PD_VIO] = DOMAIN_RK3328(-1, 8, 8, false),

Re: [PATCH] s390/cio: introduce driver_override on the css bus

2019-07-03 Thread Cornelia Huck
On Wed, 3 Jul 2019 17:09:53 +0200 Vasily Gorbik wrote: > On Wed, Jul 03, 2019 at 04:55:06PM +0200, Cornelia Huck wrote: > > On Mon, 24 Jun 2019 09:17:40 +0200 > > Cornelia Huck wrote: > > > > > On Fri, 21 Jun 2019 18:19:36 +0200 (CEST) > > > Sebastian Ott wrote: > > > > > > > On Thu, 13

Re: [GIT PULL 0/4] intel_th: Fixes for v5.2

2019-07-03 Thread Alexander Shishkin
Alexander Shishkin writes: > Hi Greg, Hi Greg, > Here are the fixes I have for v5.2 cycle: two gcc warnings, one dma mapping > issue and a new PCI ID. All issues were introduced in the same cycle, so no > -stable involvement. > > All patches are aiaiai-clean. Signed git tag below. Individual

Re: [PATCH v2 1/4] net: dsa: Change DT bindings for Vitesse VSC73xx switches

2019-07-03 Thread Florian Fainelli
On 7/3/2019 1:57 AM, Pawel Dembicki wrote: > This commit introduce how to use vsc73xx platform driver. > > Signed-off-by: Pawel Dembicki Pawel, please resubmit your patches starting a new thread, not as reply to the existing ones, see

Re: [Intel-gfx] [PATCH v4 1/4] drm/panel: Add helper for reading DT rotation

2019-07-03 Thread kbuild test robot
/commits/Derek-Basehore/Panel-rotation-patches/20190703-172146 config: s390-debug_defconfig (attached as .config) compiler: s390-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross

Re: [Intel-gfx] [PATCH v4 1/4] drm/panel: Add helper for reading DT rotation

2019-07-03 Thread kbuild test robot
/commits/Derek-Basehore/Panel-rotation-patches/20190703-172146 config: i386-defconfig (attached as .config) compiler: gcc-7 (Debian 7.4.0-6) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported

Re: [PATCHv5 02/20] PCI: mobiveil: Format the code without functionality change

2019-07-03 Thread Lorenzo Pieralisi
On Wed, Jul 03, 2019 at 04:19:05PM +0100, Lorenzo Pieralisi wrote: > On Fri, Apr 12, 2019 at 08:35:24AM +, Z.q. Hou wrote: > > From: Hou Zhiqiang > > > > Just format the code without functionality change. > > > > Signed-off-by: Hou Zhiqiang > > Reviewed-by: Minghuan Lian > > --- > > V5: >

Re: kernel panic: corrupted stack end in dput

2019-07-03 Thread Al Viro
On Wed, Jul 03, 2019 at 03:40:00PM +0100, Al Viro wrote: > On Wed, Jul 03, 2019 at 02:43:07PM +0800, Hillf Danton wrote: > > > > This is very much *NOT* fine. > > > 1) trylock can fail from any number of reasons, starting > > > with "somebody is going through the hash chain doing a lookup on >

Re: [PATCH] mm, slab: Extend slab/shrink to shrink all the memcg caches

2019-07-03 Thread Waiman Long
On 7/2/19 5:33 PM, Andrew Morton wrote: > On Tue, 2 Jul 2019 16:44:24 -0400 Waiman Long wrote: > >> On 7/2/19 4:03 PM, Andrew Morton wrote: >>> On Tue, 2 Jul 2019 14:37:30 -0400 Waiman Long wrote: >>> Currently, a value of '1" is written to /sys/kernel/slab//shrink file to shrink the

Re: [PATCH 06/30] drm/amdgpu: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Emil Velikov
On Wed, 3 Jul 2019 at 14:15, Fuqian Huang wrote: > > kmemdup is introduced to duplicate a region of memory in a neat way. > Rather than kmalloc/kzalloc + memset, which the programmer needs to > write the size twice (sometimes lead to mistakes), kmemdup improves > readability, leads to smaller

Re: [PATCH 19/30] platform/x86: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Andy Shevchenko
On Wed, Jul 3, 2019 at 4:19 PM Fuqian Huang wrote: > > kmemdup is introduced to duplicate a region of memory in a neat way. > Rather than kmalloc/kzalloc + memset, which the programmer needs to > write the size twice (sometimes lead to mistakes), kmemdup improves > readability, leads to smaller

Re: [PATCHv5 02/20] PCI: mobiveil: Format the code without functionality change

2019-07-03 Thread Lorenzo Pieralisi
On Fri, Apr 12, 2019 at 08:35:24AM +, Z.q. Hou wrote: > From: Hou Zhiqiang > > Just format the code without functionality change. > > Signed-off-by: Hou Zhiqiang > Reviewed-by: Minghuan Lian > --- > V5: > - Retouched the subject. > > drivers/pci/controller/pcie-mobiveil.c | 261

[PATCH] media: v4l: Add packed YUV444 24bpp pixel format

2019-07-03 Thread Mirela Rabulea
The added format is V4L2_PIX_FMT_YUV24, this is a packed YUV 4:4:4 format, with 8 bits for each component, 24 bits per sample. This format is used by the i.MX 8QuadMax and i.MX 8DualXPlus/8QuadXPlus JPEG encoder/decoder. Signed-off-by: Mirela Rabulea ---

Re: [PATCH] cpuidle/drivers/mobile: Add new governor for mobile/embedded systems

2019-07-03 Thread Daniel Lezcano
Hi Doug, On 03/07/2019 16:23, Doug Smythies wrote: > Hi Daniel, > > I tried your "mobile" governor, albeit not on a mobile device. > > On 2019.06.20 04:58 Daniel Lezcano wrote: > > ... > >> The mobile governor is a new governor targeting embedded systems >> running on battery where the

[PATCH] media: v4l: Add packed YUV444 24bpp pixel format

2019-07-03 Thread Mirela Rabulea
The added format is V4L2_PIX_FMT_YUV24, this is a packed YUV 4:4:4 format, with 8 bits for each component, 24 bits per sample. This format is used by the i.MX 8QuadMax and i.MX 8DualXPlus/8QuadXPlus JPEG encoder/decoder. Signed-off-by: Mirela Rabulea ---

Re: [PATCH] mm, slab: Extend slab/shrink to shrink all the memcg caches

2019-07-03 Thread Waiman Long
On 7/3/19 10:37 AM, Michal Hocko wrote: > On Wed 03-07-19 09:12:13, Waiman Long wrote: >> On 7/3/19 2:56 AM, Michal Hocko wrote: >>> On Tue 02-07-19 14:37:30, Waiman Long wrote: Currently, a value of '1" is written to /sys/kernel/slab//shrink file to shrink the slab by flushing all the

[tip:x86/cpu] selftests/x86/fsgsbase: Fix some test case bugs

2019-07-03 Thread tip-bot for Andy Lutomirski
Commit-ID: 697096b1f458fb81212d1c82d7846e932455 Gitweb: https://git.kernel.org/tip/697096b1f458fb81212d1c82d7846e932455 Author: Andy Lutomirski AuthorDate: Tue, 2 Jul 2019 20:43:04 -0700 Committer: Thomas Gleixner CommitDate: Wed, 3 Jul 2019 16:24:56 +0200

Re: [PATCHv5 02/20] PCI: mobiveil: Format the code without functionality change

2019-07-03 Thread Lorenzo Pieralisi
On Fri, Apr 12, 2019 at 08:35:24AM +, Z.q. Hou wrote: > From: Hou Zhiqiang > > Just format the code without functionality change. > > Signed-off-by: Hou Zhiqiang > Reviewed-by: Minghuan Lian > --- > V5: > - Retouched the subject. > > drivers/pci/controller/pcie-mobiveil.c | 261

[PATCH 3/3] NFS: Three function calls less

2019-07-03 Thread Markus Elfring
From: Markus Elfring Date: Wed, 3 Jul 2019 16:45:25 +0200 Reduce function calls in two function implementations. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/nfs/nfs4xdr.c | 5 + fs/nfs/super.c | 23 +++ 2 files

Re: [PATCH] drm/msm/mdp5: Use drm_device for creating gem address space

2019-07-03 Thread Jeffrey Hugo
On Wed, Jul 3, 2019 at 6:25 AM Rob Clark wrote: > > On Tue, Jul 2, 2019 at 9:08 PM Bjorn Andersson > wrote: > > > > On Mon 01 Jul 10:39 PDT 2019, Jeffrey Hugo wrote: > > > > > Creating the msm gem address space requires a reference to the dev where > > > the iommu is located. The driver

[PATCH 2/3] NFS: Replace 16 seq_printf() calls by seq_puts()

2019-07-03 Thread Markus Elfring
From: Markus Elfring Date: Wed, 3 Jul 2019 15:50:37 +0200 Some strings should be put into a sequence. Thus use the corresponding function “seq_puts”. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/nfs/super.c | 32

Re: [PATCH] s390/cio: introduce driver_override on the css bus

2019-07-03 Thread Vasily Gorbik
On Wed, Jul 03, 2019 at 04:55:06PM +0200, Cornelia Huck wrote: > On Mon, 24 Jun 2019 09:17:40 +0200 > Cornelia Huck wrote: > > > On Fri, 21 Jun 2019 18:19:36 +0200 (CEST) > > Sebastian Ott wrote: > > > > > On Thu, 13 Jun 2019, Cornelia Huck wrote: > > > > Sometimes, we want to control which

Re: [PATCH v2 02/17] dt-bindings: soc: qcom: add IPA bindings

2019-07-03 Thread Alex Elder
On 6/10/19 9:11 PM, Alex Elder wrote: > On 6/10/19 5:08 PM, Rob Herring wrote: >> On Thu, May 30, 2019 at 9:53 PM Alex Elder wrote: >>> >>> Add the binding definitions for the "qcom,ipa" device tree node. >>> >>> Signed-off-by: Alex Elder >>> --- >>> .../devicetree/bindings/net/qcom,ipa.yaml

[PATCH 1/3] NFS: Use seq_putc() in nfs_show_stats()

2019-07-03 Thread Markus Elfring
From: Markus Elfring Date: Wed, 3 Jul 2019 15:33:09 +0200 A single character (line break) should be put into a sequence. Thus use the corresponding function “seq_putc”. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/nfs/super.c | 2 +- 1 file

[PATCH 0/3] NFS: Adjustments for three function implementations

2019-07-03 Thread Markus Elfring
From: Markus Elfring Date: Wed, 3 Jul 2019 17:02:05 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (3): Use seq_putc() in nfs_show_stats() Replace 16 seq_printf() calls by seq_puts() Three function calls less fs/nfs/nfs4xdr.c | 5

Re: [PATCH bpf v6 0/2] xdp: fix hang while unregistering device bound to xdp socket

2019-07-03 Thread Daniel Borkmann
On 06/28/2019 10:04 AM, Ilya Maximets wrote: > Version 6: > > * Better names for socket state. > > Version 5: > > * Fixed incorrect handling of rtnl_lock. > > Version 4: > > * 'xdp_umem_clear_dev' exposed to be used while unregistering. > * Added XDP socket state to track if

Re: [RESEND][PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1

2019-07-03 Thread Nicolas.Ferre
On 25/06/2019 at 11:10, Codrin Ciubotariu wrote: > In clk_generated_determine_rate(), if the divisor is greater than > GENERATED_MAX_DIV + 1, then the wrong best_rate will be returned. > If clk_generated_set_rate() will be called later with this wrong > rate, it will return -EINVAL, so the

Re: [PATCH v2] f2fs: avoid out-of-range memory access

2019-07-03 Thread Ocean Chen
Hi Yu Chao, The cur_data_segno only was checked in mount process. In terms of security concern, it's better to check value before using it. I know the risk is low. IMHO, it can be safer. BTW, I found we can only check blk_off before for loop instead of checking 'j' in each iteratoin. On Wed, Jul

Re: [PATCH 30/30] sound/soc: Use kmemdup rather than duplicating its implementation

2019-07-03 Thread Fuqian Huang
Ok, I will separate them into two patches in the v2 patch set. Also, there is a typo in the v1(memset should be memcpy). Richard Fitzgerald 於 2019年7月3日週三 下午9:55寫道: > > On 03/07/19 14:18, Fuqian Huang wrote: > > kmemdup is introduced to duplicate a region of memory in a neat way. > > Rather than

[PATCH 1/3] bus: fsl-mc: remove explicit device_link_del

2019-07-03 Thread Ioana Ciornei
Starting with commit 72175d4ea4c4 ("driver core: Make driver core own stateful device links") stateful device links are owned by the driver core and should not be explicitly removed on device unbind. Delete all device_link_del appearances from the fsl-mc bus. Signed-off-by: Ioana Ciornei ---

[PATCH 3/3] soc: fsl: FSL_MC_DPIO selects directly FSL_GUTS

2019-07-03 Thread Ioana Ciornei
Make FSL_MC_DPIO select directly FSL_GUTS. Without this change we could be in a situation where both FSL_MC_DPIO and SOC_BUS are enabled but FSL_GUTS is not. Signed-off-by: Ioana Ciornei --- drivers/soc/fsl/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/3] soc: fsl: dpio: remove explicit device_link_remove

2019-07-03 Thread Ioana Ciornei
Starting with commit 72175d4ea4c4 ("driver core: Make driver core own stateful device links") stateful device links are owned by the driver core and should not be explicitly removed on device unbind. Delete all device_link_remove appearances from the dpio driver. Signed-off-by: Ioana Ciornei ---

[PATCH 0/3] soc: fsl: dpio: small fixes

2019-07-03 Thread Ioana Ciornei
This patch set contains a couple of fixes that concern the dpio driver and the fsl-mc bus. The first two patches are adapting the usage of device links to match newer developments in the area. The third patch fixes the Kconfig of FSL_MC_DPIO by selecting directly FSL_GUTS instead of SOC_BUS.

Re: [PATCH] s390/cio: introduce driver_override on the css bus

2019-07-03 Thread Cornelia Huck
On Mon, 24 Jun 2019 09:17:40 +0200 Cornelia Huck wrote: > On Fri, 21 Jun 2019 18:19:36 +0200 (CEST) > Sebastian Ott wrote: > > > On Thu, 13 Jun 2019, Cornelia Huck wrote: > > > Sometimes, we want to control which of the matching drivers > > > binds to a subchannel device (e.g. for

[GIT PULL] tracing: A few fixes for this rc release

2019-07-03 Thread Steven Rostedt
Linus, This includes three fixes: - Fixes a deadlock from a previous fix to keep module loading and function tracing text modifications from stepping on each other. (this has a few patches to help document the issue in comments) - Fix a crash when the snapshot buffer gets out of sync

Re: [PATCH 2/2] debugfs: log errors when something goes wrong

2019-07-03 Thread Greg Kroah-Hartman
On Wed, Jul 03, 2019 at 11:35:50AM +0200, Takashi Iwai wrote: > On Wed, 03 Jul 2019 11:32:33 +0200, > Greg Kroah-Hartman wrote: > > > > On Wed, Jul 03, 2019 at 11:10:44AM +0200, Rafael J. Wysocki wrote: > > > On Wed, Jul 3, 2019 at 9:17 AM Greg Kroah-Hartman > > > wrote: > > > > > > > > As it is

[PATCH] media: technisat-usb2: break out of loop at end of buffer

2019-07-03 Thread Sean Young
Ensure we do not access the buffer beyond the end if no 0xff byte is encountered. Reported-by: syzbot+eaaaf38a95427be88...@syzkaller.appspotmail.com Signed-off-by: Sean Young --- drivers/media/usb/dvb-usb/technisat-usb2.c | 22 ++ 1 file changed, 10 insertions(+), 12

Re: [PATCH] perf tools: Do not rely on errno values for precise_ip fallback

2019-07-03 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 03, 2019 at 10:09:49AM +0200, Jiri Olsa escreveu: > Konstantin reported problem with default perf record command, > which fails on some AMD servers, because of the default maximum > precise config. > > The current fallback mechanism counts on getting ENOTSUP errno for > precise_ip

[for-linus][PATCH 5/5] ftrace/x86: Anotate text_mutex split between ftrace_arch_code_modify_post_process() and ftrace_arch_code_modify_prepare()

2019-07-03 Thread Steven Rostedt
From: Jiri Kosina ftrace_arch_code_modify_prepare() is acquiring text_mutex, while the corresponding release is happening in ftrace_arch_code_modify_post_process(). This has already been documented in the code, but let's also make the fact that this is intentional clear to the semantic analysis

[for-linus][PATCH 0/5] tracing: A few updates to fix bugs in the latest -rc release

2019-07-03 Thread Steven Rostedt
Will be sending out a pull request soon. Eiichi Tsukata (1): tracing/snapshot: Resize spare buffer if size changed Jiri Kosina (1): ftrace/x86: Anotate text_mutex split between ftrace_arch_code_modify_post_process() and ftrace_arch_code_modify_prepare() Petr Mladek (1):

<    1   2   3   4   5   6   7   8   9   10   >