Re: [PATCH v1] drivers/base/memory.c: Don't store end_section_nr in memory blocks

2019-07-31 Thread Michal Hocko
On Wed 31-07-19 15:42:53, David Hildenbrand wrote: > On 31.07.19 15:25, Michal Hocko wrote: [...] > > I know we have documented this as an ABI and it is really _sad_ that > > this ABI didn't get through normal scrutiny any user visible interface > > should go through but these are sins of the past.

Re: [PATCH v2 0/7] perf, intel: Add support for PEBS output to Intel PT

2019-07-31 Thread Alexander Shishkin
Alexander Shishkin writes: > Hi Peter, No, please disregard this one, it has brainfarts. Thanks, -- Alex

[PATCH v3] ARM: dts: vf610-bk4: Fix qspi node description

2019-07-31 Thread Lukasz Majewski
Before this change the device tree description of qspi node for second memory on BK4 board was wrong (applicable to old, removed fsl-quadspi.c driver). As a result this memory was not recognized correctly when used with the new spi-fsl-qspi.c driver. >From the dt-bindings: "Required SPI slave no

Re: [PATCH v3 02/14] mbox: qcom: add APCS child device for QCS404

2019-07-31 Thread Jorge Ramirez
On 7/11/19 16:44, Bjorn Andersson wrote: > On Tue 25 Jun 09:47 PDT 2019, Jorge Ramirez-Ortiz wrote: > >> There is clock controller functionality in the APCS hardware block of >> qcs404 devices similar to msm8916. >> >> Co-developed-by: Niklas Cassel >> Signed-off-by: Niklas Cassel >> Signed-off-

[PATCH -next] staging: rtl8723bs: remove set but not used variable 'FirstConnect'

2019-07-31 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs/hal/odm.c: In function 'odm_RSSIMonitorCheckCE': drivers/staging/rtl8723bs/hal/odm.c:1258:7: warning: variable 'FirstConnect' set but not used [-Wunused-but-set-variable] Reported-by: Hulk Robot Signed-off-by: YueHaibing

[PATCH v4 2/2] dt-bindings: iio: potentiometer: add max5432.yaml binding

2019-07-31 Thread Martin Kaiser
Add a binding for the Maxim Integrated MAX5432-MAX5435 family of digital potentiometers. Signed-off-by: Martin Kaiser --- changes in v4 - fix the dt bindings - replace ic20 with i2c - document the reg property - add additionalProperties and required changes in v3 - split dt bindings a

Re: [PATCH v6 32/57] perf: Remove dev_err() usage after platform_get_irq()

2019-07-31 Thread Stephen Boyd
Quoting Will Deacon (2019-07-31 01:40:57) > On Tue, Jul 30, 2019 at 11:15:32AM -0700, Stephen Boyd wrote: > > Cc: Mark Rutland > > Cc: linux-arm-ker...@lists.infradead.org > > Cc: Greg Kroah-Hartman > > Signed-off-by: Stephen Boyd > > Acked-by: Will Deacon > > Please let me know if you'd rath

[PATCH v4 1/2] iio: potentiometer: add a driver for Maxim 5432-5435

2019-07-31 Thread Martin Kaiser
Add a driver for the Maxim Integrated MAX5432-MAX5435 family of digital potentiometers. These potentiometers are connected via I2C and have 32 wiper positions. Supported functionality - set the volatile wiper position - read the potentiometer scale Datasheet: https://datasheets.maximintegrated.c

Re: [PATCH] udf: prevent allocation beyond UDF partition

2019-07-31 Thread Steve Magnani
On 7/31/19 4:59 AM, Jan Kara wrote: On Sun 28-07-19 14:19:12, Steve Magnani wrote: The UDF bitmap allocation code assumes that a recorded Unallocated Space Bitmap is compliant with ECMA-167 4/13, which requires that pad bytes between the end of the bitmap and the end of a logical block are all z

Re: [PATCH net-next v2 6/6] net: dsa: mv88e6xxx: add PTP support for MV88E6250 family

2019-07-31 Thread Richard Cochran
On Wed, Jul 31, 2019 at 10:23:51AM +0200, Hubert Feurstein wrote: > This adds PTP support for the MV88E6250 family. > > Signed-off-by: Hubert Feurstein > --- > drivers/net/dsa/mv88e6xxx/chip.c | 4 ++ > drivers/net/dsa/mv88e6xxx/chip.h | 4 ++ > drivers/net/dsa/mv88e6xxx/ptp.c | 79 ++

Re: [PATCH v1] drivers/base/memory.c: Don't store end_section_nr in memory blocks

2019-07-31 Thread David Hildenbrand
On 31.07.19 15:42, David Hildenbrand wrote: > On 31.07.19 15:25, Michal Hocko wrote: >> On Wed 31-07-19 15:12:12, David Hildenbrand wrote: >>> On 31.07.19 14:43, Michal Hocko wrote: On Wed 31-07-19 14:22:13, David Hildenbrand wrote: > Each memory block spans the same amount of sections/pag

Re: [PATCH v1 2/7] perf/x86/intel: Support PEBS output to PT

2019-07-31 Thread Alexander Shishkin
Peter Zijlstra writes: > On Thu, Jul 04, 2019 at 07:00:19PM +0300, Alexander Shishkin wrote: >> +/* >> + * In case there's a mix of PEBS->PT and PEBS->DS, fall back >> + * to DS. >> + */ > > I thought we disallowed that from happening !? Yes, that was a weird leftover. Thanks a

[PATCH -next] staging: rtl8723bs: remove set but not used variables 'prspbuf' and 'auth'

2019-07-31 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs/core/rtw_cmd.c: In function rtw_cmd_thread: drivers/staging/rtl8723bs/core/rtw_cmd.c:405:16: warning: variable prspbuf set but not used [-Wunused-but-set-variable] drivers/staging/rtl8723bs/core/rtw_cmd.c: In function rtw_jo

[PATCH v2 5/7] perf intel-pt: Process options for PEBS event synthesis

2019-07-31 Thread Alexander Shishkin
From: Adrian Hunter Process synth_opts.other_events and attr.aux_source to set up for synthesizing PEBs via Intel PT events. Signed-off-by: Adrian Hunter Signed-off-by: Alexander Shishkin --- tools/perf/arch/x86/util/intel-pt.c | 23 +++ tools/perf/util/intel-pt.c

[PATCH v2 7/7] perf intel-pt: Add brief documentation for PEBS via Intel PT

2019-07-31 Thread Alexander Shishkin
From: Adrian Hunter Document how to select PEBS via Intel PT and how to display synthesized PEBS samples. Signed-off-by: Adrian Hunter Signed-off-by: Alexander Shishkin --- tools/perf/Documentation/intel-pt.txt | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tools/perf/Do

[PATCH v2 2/7] perf/x86/intel: Support PEBS output to PT

2019-07-31 Thread Alexander Shishkin
If PEBS declares ability to output its data to Intel PT stream, use the aux_source attribute bit to enable PEBS data output to PT. This requires a PT event to be present and scheduled in the same context. Unlike the DS area, the kernel does not extract PEBS records from the PT stream to generate co

[PATCH v2 6/7] perf tools: Add aux-source config term

2019-07-31 Thread Alexander Shishkin
From: Adrian Hunter Expose the aux_source attribute flag to the user to configure, by adding a config term 'aux-source'. For events that support it, selection of 'aux-source' causes the generation of AUX records instead of event records. This requires that an AUX area event is also provided. Sig

[PATCH v2 4/7] perf tools: Add itrace option 'o' to synthesize aux-source events

2019-07-31 Thread Alexander Shishkin
From: Adrian Hunter Add itrace option 'o' to synthesize events recorded in the AUX area due to the use of perf record's aux-source config term. Signed-off-by: Adrian Hunter Signed-off-by: Alexander Shishkin --- tools/perf/Documentation/itrace.txt | 2 ++ tools/perf/util/auxtrace.c |

[PATCH v2 3/7] perf tools: Add aux_source attribute flag

2019-07-31 Thread Alexander Shishkin
From: Adrian Hunter Add aux_source attribute flag to match the kernel's perf_event.h file. Signed-off-by: Adrian Hunter Signed-off-by: Alexander Shishkin --- tools/include/uapi/linux/perf_event.h | 3 ++- tools/perf/util/evsel.c | 1 + 2 files changed, 3 insertions(+), 1 deletio

[PATCH v2 1/7] perf: Allow normal events to be sources of AUX data

2019-07-31 Thread Alexander Shishkin
In some cases, ordinary (non-AUX) events can generate data for AUX events. For example, PEBS events can come out as records in the Intel PT stream instead of their usual DS records, if configured to do so. One requirement for such events is to consistently schedule together, to ensure that the dat

[PATCH v2 0/7] perf, intel: Add support for PEBS output to Intel PT

2019-07-31 Thread Alexander Shishkin
Hi Peter, Third attempt at the PEBS-via-PT feature. The previous ones were [1], [2]. This one addresses review comments in patches 1/7 and 2/7, the tooling patches are intact, but I'm including them anyway. The PEBS feature: output to Intel PT stream instead of the DS area. It's theoretically use

RE: [PATCH V7 00/11] misc: xilinx sd-fec drive

2019-07-31 Thread Dragan Cvetic
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Wednesday 31 July 2019 13:49 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > mark.rutl...@arm.com; devicet...@vger.kernel.org; > linux

Re: [PATCH] Function stack size and its name mismatch in arm64

2019-07-31 Thread James Morse
Hi Jiping, (CC: +linux-arm-kernel) On 31/07/2019 11:57, Steven Rostedt wrote: > On Wed, 31 Jul 2019 17:04:37 +0800 > Jiping Ma wrote: > Note, the subject is not properly written, as it is missing the > subsystem. In this case, it should start with "tracing: " > > >> The PC of one the frame is

[PATCH 2/2] cxgb4: smt: Use refcount_t for refcount

2019-07-31 Thread Chuhong Yuan
refcount_t is better for reference counters since its implementation can prevent overflows. So convert atomic_t ref counters to refcount_t. Signed-off-by: Chuhong Yuan --- drivers/net/ethernet/chelsio/cxgb4/smt.c | 14 +++--- drivers/net/ethernet/chelsio/cxgb4/smt.h | 2 +- 2 files chan

[PATCH 1/2] cxgb4: sched: Use refcount_t for refcount

2019-07-31 Thread Chuhong Yuan
refcount_t is better for reference counters since its implementation can prevent overflows. So convert atomic_t ref counters to refcount_t. Signed-off-by: Chuhong Yuan --- drivers/net/ethernet/chelsio/cxgb4/sched.c | 8 drivers/net/ethernet/chelsio/cxgb4/sched.h | 2 +- 2 files changed,

Re: [PATCH 1/2] drivers: base: swnode: link devices to software nodes

2019-07-31 Thread Dmitry Torokhov
On Tue, Jul 30, 2019 at 04:49:50PM +0200, Rafael J. Wysocki wrote: > On 7/30/2019 1:52 PM, Heikki Krogerus wrote: > > On Mon, Jul 29, 2019 at 03:15:32PM +0200, Dmitry Torokhov wrote: > > > On Mon, Jul 29, 2019 at 03:07:15PM +0300, Heikki Krogerus wrote: > > > > On Sat, Jul 13, 2019 at 12:52:58AM -0

Re: [PATCH -next] mm/memcg: fix a -Wparentheses compilation warning

2019-07-31 Thread Michal Hocko
On Wed 31-07-19 09:45:53, Qian Cai wrote: > The linux-next commit ("mm/memcontrol.c: fix use after free in > mem_cgroup_iter()") [1] introduced a compilation warning, > > mm/memcontrol.c:1160:17: warning: using the result of an assignment as a > condition without parentheses [-Wparentheses] >

[PATCH v1] drivers/acpi/scan.c: Document why we don't need the device_hotplug_lock

2019-07-31 Thread David Hildenbrand
Let's document why the lock is not needed in acpi_scan_init(), right now this is not really obvious. Cc: Rafael J. Wysocki Cc: Michal Hocko Cc: Oscar Salvador Cc: Andrew Morton Signed-off-by: David Hildenbrand --- @Andrew, can you drop "drivers/acpi/scan.c: acquire device_hotplug_lock in acp

Re: [PATCH RFC 3/5] x86: KVM: svm: clear interrupt shadow on all paths in skip_emulated_instruction()

2019-07-31 Thread Vitaly Kuznetsov
Jim Mattson writes: > On Thu, Jun 20, 2019 at 4:02 AM Vitaly Kuznetsov wrote: >> >> Regardless of the way how we skip instruction, interrupt shadow needs to be >> cleared. > > This change is definitely an improvement, but the existing code seems > to assume that we never call skip_emulated_instr

Re: [PATCH v2] nbd: replace kill_bdev() with __invalidate_device() again

2019-07-31 Thread Josef Bacik
On Wed, Jul 31, 2019 at 08:13:10PM +0800, SunKe wrote: > From: Munehisa Kamata > > Commit abbbdf12497d ("replace kill_bdev() with __invalidate_device()") > once did this, but 29eaadc03649 ("nbd: stop using the bdev everywhere") > resurrected kill_bdev() and it has been there since then. So buffer

Re: [PATCH v2] ARM: dts: vf610-bk4: Fix qspi node description

2019-07-31 Thread Fabio Estevam
Hi Lukasz, On Tue, Jul 30, 2019 at 6:48 PM Lukasz Majewski wrote: > > Before this change the device tree description of qspi node for > second memory on BK4 board was wrong (applicable to old, removed > fsl-quadspi.c driver). > > As a result this memory was not recognized correctly when used > wi

Re: [PATCH v2] Input: applespi - Fix build error

2019-07-31 Thread Dmitry Torokhov
On Tue, Jul 30, 2019 at 09:34:14PM +0800, YueHaibing wrote: > If CONFIG_KEYBOARD_APPLESPI=y but CONFIG_LEDS_CLASS=m > building fails: > > drivers/input/keyboard/applespi.o: In function `applespi_probe': > applespi.c:(.text+0x1fcd): undefined reference to > `devm_led_classdev_register_ext' > > Ad

Re: [PATCH v3] sched/core: Don't use dying mm as active_mm of kthreads

2019-07-31 Thread Rik van Riel
On Tue, 2019-07-30 at 17:01 -0400, Waiman Long wrote: > On 7/29/19 8:26 PM, Rik van Riel wrote: > > On Mon, 2019-07-29 at 17:42 -0400, Waiman Long wrote: > > > > > What I have found is that a long running process on a mostly idle > > > system > > > with many CPUs is likely to cycle through a lot o

[PATCH -next] mm/memcg: fix a -Wparentheses compilation warning

2019-07-31 Thread Qian Cai
The linux-next commit ("mm/memcontrol.c: fix use after free in mem_cgroup_iter()") [1] introduced a compilation warning, mm/memcontrol.c:1160:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] } while (memcg = parent_mem_cgroup(memcg));

Re: [PATCH] net: bridge: Allow bridge to joing multicast groups

2019-07-31 Thread Andrew Lunn
> > 2) The interface is part of a bridge. There are a few sub-cases > > > > a) IGMP snooping is being performed. We can block multicast where > > there is no interest in the group. But this is limited to IP > > multicast. > Agree. And this is done today by installing an explicit offload rule to li

Re: [PATCH v1] drivers/acpi/scan.c: Fixup "acquire device_hotplug_lock in acpi_scan_init()"

2019-07-31 Thread Michal Hocko
On Wed 31-07-19 15:37:56, David Hildenbrand wrote: [...] > The other extreme I saw: People dropping locks because they think they > can be smart but end up making developers debug crashes for months (I am > not lying). Any lock removal should be accompanied with an explanation that is to be a subj

Re: [PATCH 3/5] sched/fair: rework load_balance

2019-07-31 Thread Srikar Dronamraju
* Vincent Guittot [2019-07-26 16:42:53]: > On Fri, 26 Jul 2019 at 15:59, Srikar Dronamraju > wrote: > > > @@ -7361,19 +7357,46 @@ static int detach_tasks(struct lb_env *env) > > > if (!can_migrate_task(p, env)) > > > goto next; > > > > > > - load =

Re: [PATCH] platform/x86/pcengines-apuv2: add mpcie reset gpio export

2019-07-31 Thread Enrico Weigelt, metux IT consult
On 31.07.19 11:42, Andy Shevchenko wrote: I'm not sure why you resend this, where is the changelog, where is the version bump?.. I've just resent Florian's patch from my queue, as he didn't respond for several days and I've already acked it. --mtx -- Enrico Weigelt, metux IT consult Free so

Re: [PATCH v1] drivers/base/memory.c: Don't store end_section_nr in memory blocks

2019-07-31 Thread David Hildenbrand
On 31.07.19 15:25, Michal Hocko wrote: > On Wed 31-07-19 15:12:12, David Hildenbrand wrote: >> On 31.07.19 14:43, Michal Hocko wrote: >>> On Wed 31-07-19 14:22:13, David Hildenbrand wrote: Each memory block spans the same amount of sections/pages/bytes. The size is determined before the f

Re: [PATCH v2 0/3] KVM: selftests: Enable ucall and dirty_log_test on s390x

2019-07-31 Thread Thomas Huth
On 31/07/2019 15.32, Thomas Huth wrote: > Implement the ucall() interface on s390x to be able to use the > dirty_log_test KVM selftest on s390x, too. > > v2: > - Split up ucall.c into architecture specific files > - Removed some #ifdef __s390x__ in the dirty_log patch > > Thomas Huth (3): >

Re: [PATCH v1] drivers/acpi/scan.c: Fixup "acquire device_hotplug_lock in acpi_scan_init()"

2019-07-31 Thread David Hildenbrand
On 31.07.19 15:33, Michal Hocko wrote: > On Wed 31-07-19 15:18:42, David Hildenbrand wrote: >> On 31.07.19 15:14, Michal Hocko wrote: >>> On Wed 31-07-19 15:02:49, David Hildenbrand wrote: On 31.07.19 14:53, Michal Hocko wrote: > On Wed 31-07-19 14:32:01, David Hildenbrand wrote: >> Le

[PATCH] arm64: Move TIF_* documentation to individual definitions

2019-07-31 Thread Geert Uytterhoeven
Some TIF_* flags are documented in the comment block at the top, some next to their definitions, some in both places. Move all documentation to the individual definitions for consistency, and for easy lookup. Signed-off-by: Geert Uytterhoeven --- The alternative is to move all of them to the com

Re: [PATCH v1] drivers/acpi/scan.c: Fixup "acquire device_hotplug_lock in acpi_scan_init()"

2019-07-31 Thread Michal Hocko
On Wed 31-07-19 15:18:42, David Hildenbrand wrote: > On 31.07.19 15:14, Michal Hocko wrote: > > On Wed 31-07-19 15:02:49, David Hildenbrand wrote: > >> On 31.07.19 14:53, Michal Hocko wrote: > >>> On Wed 31-07-19 14:32:01, David Hildenbrand wrote: > Let's document why we take the lock here. If

[PATCH v2 0/3] KVM: selftests: Enable ucall and dirty_log_test on s390x

2019-07-31 Thread Thomas Huth
Implement the ucall() interface on s390x to be able to use the dirty_log_test KVM selftest on s390x, too. v2: - Split up ucall.c into architecture specific files - Removed some #ifdef __s390x__ in the dirty_log patch Thomas Huth (3): KVM: selftests: Split ucall.c into architecture specific f

[PATCH v2 3/3] KVM: selftests: Enable dirty_log_test on s390x

2019-07-31 Thread Thomas Huth
To run the dirty_log_test on s390x, we have to make sure that we access the dirty log bitmap with little endian byte ordering and we have to properly align the memslot of the guest. Also all dirty bits of a segment are set once on s390x when one of the pages of a segment are written to for the firs

[PATCH v2 1/3] KVM: selftests: Split ucall.c into architecture specific files

2019-07-31 Thread Thomas Huth
The way we exit from a guest to userspace is very specific to the architecture: On x86, we use PIO, on aarch64 we are using MMIO and on s390x we're going to use an instruction instead. The possibility to select a type via the ucall_type_t enum is currently also completely unused, so the code in uca

[PATCH v2 2/3] KVM: selftests: Implement ucall() for s390x

2019-07-31 Thread Thomas Huth
On s390x, we can neither exit via PIO nor MMIO, but have to use an instruction like DIAGNOSE. Now that ucall() is implemented, we can use it in the sync_reg_test on s390x, too. Signed-off-by: Thomas Huth --- tools/testing/selftests/kvm/Makefile | 2 +- tools/testing/selftests/kvm/lib/s

Re: [PATCH] thermal: rcar_gen3_thermal: Use devm_add_action_or_reset() helper

2019-07-31 Thread Ulrich Hecht
> On July 31, 2019 at 2:50 PM Geert Uytterhoeven > wrote: > > > Use the devm_add_action_or_reset() helper instead of open-coding the > same operations. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/thermal/rcar_gen3_thermal.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deleti

[PATCH 2/3] pinctrl: lantiq: Use kasprintf() instead of fixed buffer formatting

2019-07-31 Thread Geert Uytterhoeven
Improve readability and maintainability by replacing a hardcoded string allocation and formatting by the use of the kasprintf() helper. Signed-off-by: Geert Uytterhoeven --- drivers/pinctrl/pinctrl-falcon.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/pinctrl/

[PATCH v2] regmap: no need to check return value of debugfs_create functions

2019-07-31 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. The debugfs core will warn if a file or directory can not be created, so there's no need to duplicate the warning, n

Re: [PATCH V2 4/9] vhost: reset invalidate_count in vhost_set_vring_num_addr()

2019-07-31 Thread Jason Wang
On 2019/7/31 下午8:41, Jason Gunthorpe wrote: On Wed, Jul 31, 2019 at 04:46:50AM -0400, Jason Wang wrote: The vhost_set_vring_num_addr() could be called in the middle of invalidate_range_start() and invalidate_range_end(). If we don't reset invalidate_count after the un-registering of MMU notifi

[PATCH 1/3] pinctrl: devicetree: Use strlen() instead of hardcoded number

2019-07-31 Thread Geert Uytterhoeven
Improve readability by replacing a hardcoded number requiring a comment by strlen(). Gcc is smart enough to evaluate the length of a constant string at compile-time. Signed-off-by: Geert Uytterhoeven --- drivers/pinctrl/devicetree.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) d

[PATCH 3/3] pinctrl: xway: Use devm_kasprintf() instead of fixed buffer formatting

2019-07-31 Thread Geert Uytterhoeven
Improve readability and maintainability by replacing a hardcoded string allocation and formatting by the use of the devm_kasprintf() helper. Signed-off-by: Geert Uytterhoeven --- drivers/pinctrl/pinctrl-xway.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pinctrl

[PATCH 0/3] pinctrl: Avoid hardcoded string offsets and buffer lengths

2019-07-31 Thread Geert Uytterhoeven
Hi Linus, This patch series gets rid of hardcoded string offsets and buffer lengths, in favor of using strlen() and (devm_)kasprintf(). Thanks! Geert Uytterhoeven (3): pinctrl: devicetree: Use strlen() instead of hardcoded number pinctrl: lantiq: Use kasprintf() instead of fixed buff

Re: [PATCH V2 7/9] vhost: do not use RCU to synchronize MMU notifier with worker

2019-07-31 Thread Jason Wang
On 2019/7/31 下午8:39, Jason Gunthorpe wrote: On Wed, Jul 31, 2019 at 04:46:53AM -0400, Jason Wang wrote: We used to use RCU to synchronize MMU notifier with worker. This leads calling synchronize_rcu() in invalidate_range_start(). But on a busy system, there would be many factors that may slow

Re: [PATCH v1] drivers/base/memory.c: Don't store end_section_nr in memory blocks

2019-07-31 Thread Michal Hocko
On Wed 31-07-19 15:12:12, David Hildenbrand wrote: > On 31.07.19 14:43, Michal Hocko wrote: > > On Wed 31-07-19 14:22:13, David Hildenbrand wrote: > >> Each memory block spans the same amount of sections/pages/bytes. The size > >> is determined before the first memory block is created. No need to s

Re: [PATCH] serial: sh-sci: Use DEVICE_ATTR_RW() for rx_fifo_trigger

2019-07-31 Thread Ulrich Hecht
> On July 31, 2019 at 2:45 PM Geert Uytterhoeven > wrote: > > > While commit b6b996b6cdeecf7e ("treewide: Use DEVICE_ATTR_RW") converted > the rx_fifo_timeout attribute, it forgot to convert rx_fifo_trigger due > to a slightly different function naming. > > Signed-off-by: Geert Uytterhoeven

Re: [RFC PATCH 3/3] hugetlbfs: don't retry when pool page allocations start to fail

2019-07-31 Thread Vlastimil Babka
On 7/25/19 7:15 PM, Mike Kravetz wrote: > On 7/25/19 1:13 AM, Mel Gorman wrote: >> On Wed, Jul 24, 2019 at 10:50:14AM -0700, Mike Kravetz wrote: >>> When allocating hugetlbfs pool pages via /proc/sys/vm/nr_hugepages, >>> the pages will be interleaved between all nodes of the system. If >>> nodes a

[PATCH 1/8] net: 8390: Fix manufacturer name in Kconfig help text

2019-07-31 Thread Geert Uytterhoeven
The help text refers to Western Digital instead of National Semiconductor 8390, presumably because it was copied from the former. Fixes: 644570b830266ff3 ("8390: Move the 8390 related drivers") Signed-off-by: Geert Uytterhoeven --- drivers/net/ethernet/8390/Kconfig | 4 ++-- 1 file changed, 2 in

Re: [PATCH v4 2/4] leds: Add managed API to get a LED from a device driver

2019-07-31 Thread Tomi Valkeinen
On 17/07/2019 17:15, Jean-Jacques Hiblot wrote: +struct led_classdev *__must_check devm_led_get(struct device *dev, + int index) +{ + struct led_classdev *led; + struct led_classdev **dr; + Should you check here if dev->of_node == NULL?

[PATCH 8/8] net: samsung: Spelling s/case/cause/

2019-07-31 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- drivers/net/ethernet/samsung/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/samsung/Kconfig b/drivers/net/ethernet/samsung/Kconfig index 027938017579130f..e92a178a76df0849 100644 --- a/drivers/net/ethernet/sa

[PATCH 3/8] net: apple: Fix manufacturer name in Kconfig help text

2019-07-31 Thread Geert Uytterhoeven
The help text refers to IBM instead of Apple, presumably because it was copied from the former. Fixes: 8fb6b0908176704a ("bmac/mace/macmace/mac89x0/cs89x0: Move the Macintosh (Apple) drivers") Signed-off-by: Geert Uytterhoeven --- drivers/net/ethernet/apple/Kconfig | 4 ++-- 1 file changed, 2 i

[PATCH 5/8] net: ixp4xx: Spelling s/XSacle/XScale/

2019-07-31 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- drivers/net/ethernet/xscale/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xscale/Kconfig b/drivers/net/ethernet/xscale/Kconfig index 2f354ba029a61491..cd0a8f46e7c6c143 100644 --- a/drivers/net/ethernet/xscal

[PATCH 4/8] net: broadcom: Fix manufacturer name in Kconfig help text

2019-07-31 Thread Geert Uytterhoeven
The help text refers to AMD instead of Broadcom, presumably because it was copied from the former. Fixes: adfc5217e9db68d3 ("broadcom: Move the Broadcom drivers") Signed-off-by: Geert Uytterhoeven --- drivers/net/ethernet/broadcom/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(

[PATCH 0/8] net: Manufacturer names and spelling fixes

2019-07-31 Thread Geert Uytterhoeven
Hi David, This is a set of fixes for (some blatantly) wrong manufacturer names and various spelling issues, mostly in Kconfig help texts. Thanks! Geert Uytterhoeven (8): net: 8390: Fix manufacturer name in Kconfig help text net: amd: Spelling s/case/cause/ net: apple: Fix manufactu

[PATCH 6/8] net: nixge: Spelling s/Instrument/Instruments/

2019-07-31 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- drivers/net/ethernet/ni/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ni/Kconfig b/drivers/net/ethernet/ni/Kconfig index 70b1a03c0953e696..01229190132d484f 100644 --- a/drivers/net/ethernet/ni/Kconfig +++ b/d

[PATCH 2/8] net: amd: Spelling s/case/cause/

2019-07-31 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- drivers/net/ethernet/amd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/Kconfig b/drivers/net/ethernet/amd/Kconfig index de4950d2022e0a6d..9f965cdfff5c99db 100644 --- a/drivers/net/ethernet/amd/Kconfig +++

[PATCH 7/8] net: packetengines: Fix manufacturer spelling and capitalization

2019-07-31 Thread Geert Uytterhoeven
Use "Packet Engines" consistently. Signed-off-by: Geert Uytterhoeven --- drivers/net/ethernet/packetengines/Kconfig | 6 +++--- drivers/net/ethernet/packetengines/Makefile | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/packetengines/Kconfig b/driver

Re: [PATCH v2 01/10] driver core: add dev_groups to all drivers

2019-07-31 Thread Greg Kroah-Hartman
On Wed, Jul 31, 2019 at 06:08:00AM -0700, Dmitry Torokhov wrote: > On Wed, Jul 31, 2019 at 02:51:04PM +0200, Greg Kroah-Hartman wrote: > > On Wed, Jul 31, 2019 at 02:49:26PM +0200, Takashi Iwai wrote: > > > On Wed, 31 Jul 2019 14:43:40 +0200, > > > Greg Kroah-Hartman wrote: > > > > > > > > From: D

Re: ARM: multi_v7_defconfig: Enable SPI_STM32_QSPI support

2019-07-31 Thread Olof Johansson
On Wed, Jul 31, 2019 at 3:20 PM Olof Johansson wrote: > > Hi, > > On Wed, Jul 31, 2019 at 8:48 AM Alexandre Torgue > wrote: > > > > Hi Olof > > > > On 7/30/19 7:36 PM, Olof Johansson wrote: > > > Hi Patrice, > > > > > > If you cc s...@kernel.org on patches you want us to apply, you'll get > > > t

[PATCH] ocfs: further debugfs cleanups

2019-07-31 Thread Greg Kroah-Hartman
There is no need to check return value of debugfs_create functions, but the last sweep through ocfs missed a number of places where this was happening. There is also no need to save the individual dentries for the debugfs files, as everything is can just be removed at once when the directory is re

Re: [PATCH v1 2/2] drm: Clear the fence pointer when writeback job signaled

2019-07-31 Thread Brian Starkey
Hi Lowry, Thanks for this cleanup. On Wed, Jul 31, 2019 at 11:04:45AM +, Lowry Li (Arm Technology China) wrote: > During it signals the completion of a writeback job, after releasing > the out_fence, we'd clear the pointer. > > Check if fence left over in drm_writeback_cleanup_job(), release

Re: ARM: multi_v7_defconfig: Enable SPI_STM32_QSPI support

2019-07-31 Thread Olof Johansson
Hi, On Wed, Jul 31, 2019 at 8:48 AM Alexandre Torgue wrote: > > Hi Olof > > On 7/30/19 7:36 PM, Olof Johansson wrote: > > Hi Patrice, > > > > If you cc s...@kernel.org on patches you want us to apply, you'll get > > them automatically tracked by patchwork. > > > > Does it means that you will take

Re: [PATCH v1] drivers/acpi/scan.c: Fixup "acquire device_hotplug_lock in acpi_scan_init()"

2019-07-31 Thread David Hildenbrand
On 31.07.19 15:14, Michal Hocko wrote: > On Wed 31-07-19 15:02:49, David Hildenbrand wrote: >> On 31.07.19 14:53, Michal Hocko wrote: >>> On Wed 31-07-19 14:32:01, David Hildenbrand wrote: Let's document why we take the lock here. If we're going to overhaul memory hotplug locking, we'll h

Re: [PATCH] watchdog: pc87413: Rewriting of pc87413_wdt driver to use watchdog subsystem

2019-07-31 Thread Guenter Roeck
On 7/30/19 10:06 PM, Mark Balantzyan wrote: Hi all, Guenter, Thank you for your email. Unfortunately, on my end, the indentation is straight and perhaps through protocol transfer there was stray modification. checkpatch --strict says: total: 13 errors, 13 warnings, 4 checks, 439 lines checke

[PATCH v2 3/3] ASoC: SOF: no need to check return value of debugfs_create functions

2019-07-31 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Also, if a debugfs call fails, userspace is notified with an error in the log, so no need to log the error again. B

[PATCH v2 2/3] ASoC: core: no need to check return value of debugfs_create functions

2019-07-31 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Also, there is no need to store the individual debugfs file name, just remove the whole directory all at once, savin

[PATCH v2 1/3] ASoC: Intel: SoC: skylake: no need to check return value of debugfs_create functions

2019-07-31 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Also, if a debugfs call fails, userspace is notified with an error in the log, so no need to log the error again. C

Re: [PATCH] printk: Use strlen/sizeof instead of hardcoded constants

2019-07-31 Thread Steven Rostedt
On Wed, 31 Jul 2019 14:39:22 +0200 Geert Uytterhoeven wrote: > Replace hardcoded string length or size constants by proper strlen() or > sizeof() constructs. As the strings are constant, gcc will reduce the > lengths or sizes to constants again. > > Signed-off-by: Geert Uytterhoeven > --- > As

Re: [PATCH RFC 4/5] x86: KVM: add xsetbv to the emulator

2019-07-31 Thread Paolo Bonzini
On 31/07/19 15:07, Vitaly Kuznetsov wrote: > Paolo Bonzini writes: > >> On 20/06/19 13:02, Vitaly Kuznetsov wrote: >>> To avoid hardcoding xsetbv length to '3' we need to support decoding it in >>> the emulator. >>> >>> Signed-off-by: Vitaly Kuznetsov >> >> Can you also emulate it properly? The

Re: [PATCH v2 0/2] leds: tlc591xx: switch to OF and managed API

2019-07-31 Thread Tomi Valkeinen
On 08/07/2019 13:06, Jean-Jacques Hiblot wrote: This mini-series updates the tlc591xx driver to use the managed API. The driver is also modified to pass the DT node to the LED core layer. The goal is to be able to the generic led-backlight [0] driver on top of it. changes in v2: - fixed LED inde

Re: [PATCH v1] drivers/acpi/scan.c: Fixup "acquire device_hotplug_lock in acpi_scan_init()"

2019-07-31 Thread Michal Hocko
On Wed 31-07-19 15:02:49, David Hildenbrand wrote: > On 31.07.19 14:53, Michal Hocko wrote: > > On Wed 31-07-19 14:32:01, David Hildenbrand wrote: > >> Let's document why we take the lock here. If we're going to overhaul > >> memory hotplug locking, we'll have to touch many places - this comment >

Re: [PATCH 1/3] KVM: Don't need to wakeup vCPU twice afer timer fire

2019-07-31 Thread Vitaly Kuznetsov
Paolo Bonzini writes: > On 31/07/19 13:27, Wanpeng Li wrote: >> From: Wanpeng Li >> >> kvm_set_pending_timer() will take care to wake up the sleeping vCPU which >> has pending timer, don't need to check this in apic_timer_expired() again. > > No, it doesn't. kvm_make_request never kicks the v

Re: [PATCH v1] drivers/base/memory.c: Don't store end_section_nr in memory blocks

2019-07-31 Thread David Hildenbrand
On 31.07.19 14:43, Michal Hocko wrote: > On Wed 31-07-19 14:22:13, David Hildenbrand wrote: >> Each memory block spans the same amount of sections/pages/bytes. The size >> is determined before the first memory block is created. No need to store >> what we can easily calculate - and the calculations

Re: [PATCH] regulator: of: Add of_node_put() before return in function

2019-07-31 Thread Nishka Dasgupta
On 26/07/19 4:15 PM, Mark Brown wrote: On Fri, Jul 26, 2019 at 01:02:52PM +0530, Nishka Dasgupta wrote: On 24/07/19 9:17 PM, Mark Brown wrote: On Wed, Jul 24, 2019 at 02:02:31PM +0530, Nishka Dasgupta wrote: The local variable search in regulator_of_get_init_node takes the value returned by

XFS segementation fault with new linux 4.19.63

2019-07-31 Thread Kinky Nekoboi
I am not subscribed, so if you want to contact me do Direkt Email. kern output: ul 31 13:51:53 lain kernel: [   71.660736] XFS: Assertion failed: xfs_perag_resv(pag, XFS_AG_RESV_METADATA)->ar_reserved + xfs_perag_resv(pag, XFS_AG_RESV_RMAPBT)->ar_reserved <= pag->pagf_freeblks + pag->pagf_flcoun

[PATCH v5 11/14] crypto: caam - free resources in case caam_rng registration failed

2019-07-31 Thread Iuliana Prodan
Check the return value of the hardware registration for caam_rng and free resources in case of failure. Fixes: e24f7c9e87d4 ("crypto: caam - hwrng support") Signed-off-by: Iuliana Prodan Reviewed-by: Horia Geanta --- drivers/crypto/caam/caamrng.c | 5 - 1 file changed, 4 insertions(+), 1 de

[PATCH v5 13/14] crypto: caam - unregister algorithm only if the registration succeeded

2019-07-31 Thread Iuliana Prodan
To know if a registration succeeded added a new struct, caam_akcipher_alg, that keeps, also, the registration status. This status is updated in caam_pkc_init and verified in caam_pkc_exit to unregister an algorithm. Fixes: 1b46c90c8e00 ("crypto: caam - convert top level drivers to libraries") Sign

Re: [PATCH v2 01/10] driver core: add dev_groups to all drivers

2019-07-31 Thread Dmitry Torokhov
On Wed, Jul 31, 2019 at 02:51:04PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 31, 2019 at 02:49:26PM +0200, Takashi Iwai wrote: > > On Wed, 31 Jul 2019 14:43:40 +0200, > > Greg Kroah-Hartman wrote: > > > > > > From: Dmitry Torokhov > > > > > > Add the ability for the driver core to create an

Re: [PATCH RFC 4/5] x86: KVM: add xsetbv to the emulator

2019-07-31 Thread Vitaly Kuznetsov
Paolo Bonzini writes: > On 20/06/19 13:02, Vitaly Kuznetsov wrote: >> To avoid hardcoding xsetbv length to '3' we need to support decoding it in >> the emulator. >> >> Signed-off-by: Vitaly Kuznetsov > > Can you also emulate it properly? The code from QEMU's > target/i386/fpu_helper.c can help

Re: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups()

2019-07-31 Thread Tudor.Ambarus
Hi, Naga, On 07/31/2019 03:31 PM, Naga Sureshkumar Relli wrote: >> +if (nor->info->flags & SPI_S3AN) >> +s3an_post_sfdp_fixups(nor); >> } >> > Instead of checking the flags, why can't we call directly the nor_fixups? > like Boris implementation nor->info->fixups->post_sfdp() > htt

Re: [PATCH] mailbox: zynqmp-ipi-mailbox: Add of_node_put() before goto

2019-07-31 Thread Nishka Dasgupta
On 31/07/19 2:01 PM, Michal Simek wrote: On 09. 07. 19 19:28, Nishka Dasgupta wrote: Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a goto from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the

Re: [PATCH v3 3/3] media: stm32-dcmi: add support of several sub-devices

2019-07-31 Thread Hugues FRUCHET
Hi Hans, I've just pushed v4 with subdev nodes registry removal as per your suggestion. On 7/25/19 5:09 PM, Hans Verkuil wrote: > On 7/25/19 4:56 PM, Benjamin Gaignard wrote: >> Le jeu. 25 juil. 2019 à 13:40, Hans Verkuil a écrit : >>> >>> On 7/2/19 5:52 PM, Hugues Fruchet wrote: Add suppo

Re: [PATCH 1/2] KVM: selftests: Implement ucall() for s390x

2019-07-31 Thread Andrew Jones
On Wed, Jul 31, 2019 at 02:57:38PM +0200, Paolo Bonzini wrote: > On 31/07/19 13:16, Thomas Huth wrote: > > Or maybe even better: Let's move this file into lib/x86_64/ and > > lib/aarch64/ instead, since there is more different code between the > > architectures here than common code. > > All good

Re: [PATCH v1] drivers/acpi/scan.c: Fixup "acquire device_hotplug_lock in acpi_scan_init()"

2019-07-31 Thread David Hildenbrand
On 31.07.19 14:53, Michal Hocko wrote: > On Wed 31-07-19 14:32:01, David Hildenbrand wrote: >> Let's document why we take the lock here. If we're going to overhaul >> memory hotplug locking, we'll have to touch many places - this comment >> will help to clairfy why it was added here. > > And how e

Re: [PATCH v3 0/7] habanalabs: support info queries by multiple processes

2019-07-31 Thread Greg KH
On Wed, Jul 31, 2019 at 03:58:54PM +0300, Oded Gabbay wrote: > v3 introduces a few fixes and changes the control char device's minor > number to be 1 above that of the main device. > > Original text: > > Today, the driver allows only a single user application (the deep-learning > application) to

Re: [PATCH v3 7/7] habanalabs: create two char devices per ASIC

2019-07-31 Thread Greg KH
On Wed, Jul 31, 2019 at 03:59:01PM +0300, Oded Gabbay wrote: > This patch changes the driver to create two char devices for each ASIC > it discovers. This is done to allow system/monitoring applications to > query the device for stats, information, idle state and more, while also > allowing the dee

Re: [PATCH] selftests: kvm: Adding config fragments

2019-07-31 Thread Paolo Bonzini
On 31/07/19 12:55, Naresh Kamboju wrote: > selftests kvm test cases need pre-required kernel configs for the test > to get pass. > > Signed-off-by: Naresh Kamboju Most of these are selected by other items. CONFIG_KVM should be enough on ARM and s390 but MIPS, x86 and PPC may also need to select

microblaze HAVE_MEMBLOCK_NODE_MAP dependency (was Re: [PATCH v2 0/5] mm: Enable CONFIG_NODES_SPAN_OTHER_NODES by default for NUMA)

2019-07-31 Thread Michal Hocko
On Wed 31-07-19 15:26:32, Mike Rapoport wrote: > On Wed, Jul 31, 2019 at 01:40:16PM +0200, Michal Hocko wrote: > > On Wed 31-07-19 14:14:22, Mike Rapoport wrote: > > > On Wed, Jul 31, 2019 at 10:03:09AM +0200, Michal Hocko wrote: > > > > On Wed 31-07-19 09:24:21, Mike Rapoport wrote: > > > > > [ so

Re: [RFC PATCH 01/11] devfreq: exynos-bus: Extract exynos_bus_profile_init()

2019-07-31 Thread Artur Świgoń
Hi, On Wed, 2019-07-24 at 21:07 +0200, Krzysztof Kozlowski wrote: > On Tue, Jul 23, 2019 at 02:20:06PM +0200, Artur Świgoń wrote: > > This patch adds a new static function, exynos_bus_profile_init(), extracted > > from exynos_bus_probe(). > > > > Signed-off-by: Artur Świgoń > > --- > > drivers/

<    4   5   6   7   8   9   10   11   12   13   >