In iso_packets_buffer_init(), 'b->packets' is allocated through
kmalloc_array(). Then, the aligned packet size is checked. If it is
larger than PAGE_SIZE, -EINVAL will be returned to indicate the error.
However, the allocated 'b->packets' is not deallocated on this path,
leading to a memory leak.
On Wed, 2019-08-07 at 21:36 -0400, Valdis Klētnieks wrote:
> commit 81398d99e9de80d9dbe65dfe7aadec9497f88242
> Author: Gilad Ben-Yossef
> Date: Wed Jul 31 14:44:23 2019 +1000
>
> checkpatch: add *_NOTIFIER_HEAD as var definition
>
> has a typo, resulting in a truly amazing error message:
On 08/07/2019 06:03 AM, Miles Chen wrote:
> This change prints the hexadecimal EC value in mem_abort_decode(),
> which makes it easier to lookup the corresponding EC in
> the ARM Architecture Reference Manual.
>
> The commit 1f9b8936f36f ("arm64: Decode information from ESR upon mem
> faults")
On Wed, Aug 7, 2019 at 6:55 PM Alexandre Belloni
wrote:
>
> Hi,
>
> On 06/08/2019 20:30:45+0200, Ondřej Jirman wrote:
> > Maybe whether XO or DCXO is used also matters if you want to do some fine
> > tunning of DCXO (control register has pletny of options), but that's
> > probably
> > better
On Wed, 7 Aug 2019 10:38:08 +0800
YueHaibing wrote:
> We should also enable bonding's vlan tx offload in hw_enc_features,
You mean team's vlan tx offload?
> pass the vlan packets to the slave devices with vlan tci, let them
s/let them to/let the slave/
> to handle vlan tunneling offload
Sparse warns about two tables not being declared.
CHECK net/netfilter/nf_nat_proto.c
net/netfilter/nf_nat_proto.c:725:26: warning: symbol 'nf_nat_ipv4_ops' was not
declared. Should it be static?
net/netfilter/nf_nat_proto.c:964:26: warning: symbol 'nf_nat_ipv6_ops' was not
declared. Should
On Wed, 31 Jul 2019 16:53:46 +0800
Ding Xiang wrote:
> "error" is unneeded,just return 0
>
> Signed-off-by: Ding Xiang
Reviewed-by: Jesse Brandeburg
On Wed, 31 Jul 2019 10:06:48 +0200
Christophe JAILLET wrote:
> There is no need to use GFP_ATOMIC here, GFP_KERNEL should be enough.
> The 'kcalloc()' just a few lines above, already uses GFP_KERNEL.
>
> Signed-off-by: Christophe JAILLET
Reviewed-by: Jesse Brandeburg
On Wed, 31 Jul 2019 10:06:38 +0200
Christophe JAILLET wrote:
> A few lines above, we have:
>tx_size = BIT(tx->order);
>
> So use 'tx_size' directly to be consistent with the way 'rx->descs_cpu' and
> 'rx->descs_dma' are computed below.
>
> Signed-off-by: Christophe JAILLET
Reviewed-by:
Sparse rightly complains about undeclared symbols.
CHECK net/netfilter/nft_set_hash.c
net/netfilter/nft_set_hash.c:647:21: warning: symbol 'nft_set_rhash_type' was
not declared. Should it be static?
net/netfilter/nft_set_hash.c:670:21: warning: symbol 'nft_set_hash_type' was
not declared.
On Wed, 31 Jul 2019 09:38:42 +0200
Christophe JAILLET wrote:
> There is no good reason to use GFP_ATOMIC here. Other memory allocations
> are performed with GFP_KERNEL (see other 'dma_alloc_coherent()' below and
> 'kzalloc()' in 'et131x_rx_dma_memory_alloc()')
>
> Use GFP_KERNEL which should be
On 08/07/2019 10:28 AM, Jia He wrote:
> Without this patch, the MAP_SYNC test case will cause a print_bad_pte
> warning on arm64 as follows:
> [ 25.542693] BUG: Bad page map in process mapdax333
> pte:2e8000448800f53 pmd:41ff5f003
> [ 25.546360] page:7e001022 refcount:1 mapcount:-1
Quoting Manivannan Sadhasivam (2019-07-05 08:14:39)
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index fc1e0cf44995..ffc61ed85ade 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -304,6 +304,12 @@ config COMMON_CLK_FIXED_MMIO
> help
> Support for
In sound_insert_unit(), the controlling structure 's' is allocated through
kmalloc(). Then it is added to the sound driver list by invoking
__sound_insert_unit(). Later on, if __register_chrdev() fails, 's' is
removed from the list through __sound_remove_unit(). If 'index' is not less
than 0,
On 07-08-19, 23:43, Taniya Das wrote:
> +static struct clk_alpha_pll gpll0;
> +static struct clk_alpha_pll gpll1;
> +static struct clk_alpha_pll gpll4;
> +static struct clk_alpha_pll gpll6;
> +static struct clk_alpha_pll gpll7;
> +static struct clk_alpha_pll_postdiv gpll0_out_even;
I am not sure
Stephen Rothwell writes:
> Hi all,
>
> Changes since 20190806:
>
> The arm64 tree introduced a patch that stopped the powerpc ppc64_defconfig
> build from completing so I reverted that commit.
>
> The mips tree gained a conflict against Linus' tree.
>
> The crypto tree still had its build failure
Hi Herbert,
On Thu, 8 Aug 2019 15:00:04 +1000 Herbert Xu
wrote:
>
> On Thu, Aug 08, 2019 at 01:17:10PM +1000, Stephen Rothwell wrote:
> >
> > Excellent, thanks. Should I add the crypto mailing list as a contact
> > for problems? Mostly the emails are just reporting conflicts and only
> > very
On 07-08-19, 23:43, Taniya Das wrote:
> Add compatible string and the include file for gcc clock
> controller for SC7180.
>
> Signed-off-by: Taniya Das
> ---
> .../devicetree/bindings/clock/qcom,gcc.txt| 1 +
> include/dt-bindings/clock/qcom,gcc-sc7180.h | 155 ++
> 2
Quoting Manivannan Sadhasivam (2019-07-05 08:14:36)
> Add devicetree binding for Bitmain BM1880 SoC clock controller.
>
> Signed-off-by: Manivannan Sadhasivam
> ---
> .../bindings/clock/bitmain,bm1880-clk.txt | 47 +++
Can you convert this to YAML? It's all the rage right now.
>
On Thu, Aug 08, 2019 at 01:17:10PM +1000, Stephen Rothwell wrote:
>
> Excellent, thanks. Should I add the crypto mailing list as a contact
> for problems? Mostly the emails are just reporting conflicts and only
> very occasionally do I actually send a useful patch. If so, what is
> its address?
octeon_mbox_process_cmd() directly writes the PCI_EXP_DEVCTL_BCR_FLR
bit, which bypasses timing requirements imposed by the PCIe spec.
This patch fixes the function to use the pcie_flr() interface instead.
Signed-off-by: Denis Efremov
---
drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c |
Quoting Andrey Smirnov (2019-07-17 07:56:51)
> The following functions:
>
> - clk_bulk_enable()
> - clk_bulk_prepare()
> - clk_bulk_disable()
> - clk_bulk_unprepare()
>
> already expect const clk_bulk_data * as a second parameter, however
> their no-op version have mismatching
On 07-08-19, 12:39, Sibi Sankar wrote:
> This patch series adds SCM, APSS shared mailbox and QMP AOSS PD/clock
> support on SM8150 and SC7180 SoCs.
>
> v2:
> * re-arrange the compatible lists in sort order
i checked these lgtm and tested on SM8150
Tested-by: Vinod Koul
Reviewed-by: Vinod Koul
On 8/7/19 10:36 AM, Vijay Khemka wrote:
> Lgtm except one small comment below.
>
> On 8/6/19, 5:22 PM, "openbmc on behalf of Tao Ren"
> tao...@fb.com> wrote:
>
> Currently BMC's MAC address is calculated by adding 1 to NCSI NIC's base
> MAC address when CONFIG_NCSI_OEM_CMD_GET_MAC
On Wed, Aug 07, 2019 at 11:29:16PM -0400, Qian Cai wrote:
> The commit 155433cb365e ("arm64: cache: Remove support for ASID-tagged
> VIVT I-caches") introduced some compiation warnings from GCC (and
> Clang) with -Winitializer-overrides),
>
> arch/arm64/kernel/cpuinfo.c:38:26: warning:
Hi all,
After merging the tip tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
kernel/locking/mutex-debug.c: In function 'debug_mutex_lock_common':
kernel/locking/mutex-debug.c:32:42: error: dereferencing pointer to incomplete
type 'struct mutex_waiter'
On 8/7/19 11:41 AM, Andrew Lunn wrote:
> On Wed, Aug 07, 2019 at 11:25:18AM -0700, Jakub Kicinski wrote:
>> On Tue, 6 Aug 2019 17:21:18 -0700, Tao Ren wrote:
>>> Currently BMC's MAC address is calculated by adding 1 to NCSI NIC's base
>>> MAC address when CONFIG_NCSI_OEM_CMD_GET_MAC option is
Quoting Jerome Brunet (2019-08-06 01:28:19)
> On Wed 31 Jul 2019 at 10:40, Neil Armstrong wrote:
>
> > Introduce the clk_hw_set_parent() provider call to change parent of
> > a clock by using the clk_hw pointers.
> >
> > This eases the clock reparenting from clock rate notifiers and
> >
Quoting Martin Blumenstingl (2019-07-02 16:28:55)
> Hi Stephen, Hi Neil,
>
> On Mon, Jul 1, 2019 at 11:13 AM Neil Armstrong
> wrote:
> >
> > In order to implement clock switching for the CLKID_CPU_CLK and
> > CLKID_CPUB_CLK, notifiers are added on specific points of the
> > clock tree :
> >
> >
Quoting Vinod Koul (2019-07-22 00:43:45)
> We want users to code properly and fix the post_div_table missing and
> not rely on core to check. So remove the post_div_table check.
>
> Signed-off-by: Vinod Koul
> Reviewed-by: Bjorn Andersson
> ---
Applied to clk-next
Quoting Vinod Koul (2019-07-22 00:43:47)
> From: Deepak Katragadda
>
> Document the global clock controller found on SM8150.
>
> Signed-off-by: Deepak Katragadda
> Signed-off-by: Taniya Das
> [vkoul: port to upstream and add external clocks
> split binding to this patch]]
>
Quoting Vinod Koul (2019-07-22 00:43:48)
> From: Deepak Katragadda
>
> Add the clocks supported in global clock controller which clock the
> peripherals like BLSPs, SDCC, USB, MDSS etc. Register all the clocks
> to the clock framework for the clients to be able to request for them.
>
>
Quoting Vinod Koul (2019-07-22 00:43:44)
> Commit 8f9fab480c7a ("linux/kernel.h: fix overflow for
> DIV_ROUND_UP_ULL") fixed the overflow for DIV_ROUND_UP_ULL, so we no
> longer need the cast for DIV_ROUND_UP_ULL, so remove the unnecessary
> u64 casts.
>
> Signed-off-by: Vinod Koul
> ---
Quoting Vinod Koul (2019-07-22 00:43:46)
> From: Deepak Katragadda
>
> Add programming sequence support for managing the Trion
> PLLs.
>
> Signed-off-by: Deepak Katragadda
> Signed-off-by: Taniya Das
> [vkoul: port to upstream and tidy-up
> use upstream way of specifying PLLs]
>
On 2019/8/7 21:03, Michael Ellerman wrote:
Jason Yan writes:
Now the kernel base is a fixed value - KERNELBASE. To support KASLR, we
need a variable to store the kernel base.
Signed-off-by: Jason Yan
Cc: Diana Craciun
Cc: Michael Ellerman
Cc: Christophe Leroy
Cc: Benjamin Herrenschmidt
Hi Heiner,
On 8/7/19 12:18 PM, Heiner Kallweit wrote:
> On 06.08.2019 23:42, Tao Ren wrote:
>> Hi Andrew / Heiner / Vladimir,
>>
>> On 8/6/19 2:09 PM, Tao Ren wrote:
>>> The BCM54616S PHY cannot work properly in RGMII->1000Base-KX mode (for
>>> example, on Facebook CMM BMC platform), mainly
Quoting Paul Cercueil (2019-07-16 10:08:00)
> By using CLK_OF_DECLARE_DRIVER instead of the CLK_OF_DECLARE macro, we
> allow the driver to probe also as a platform driver.
>
> While this driver does not have code to probe as a platform driver, this
> is still useful for probing children devices
Quoting Paul Cercueil (2019-08-07 16:28:10)
>
>
> Le mer. 7 août 2019 à 23:33, Stephen Boyd a écrit
> :
> > Quoting Paul Cercueil (2019-07-01 04:36:06)
> >> The code was setting the bit 21 of the CPCCR register to use a
> >> divider
> >> of 2 for the "pll half" clock, and clearing the bit
In Xen environment, if Xen-swiotlb is enabled, ixgbe driver
could possibly allocate a page, DMA memory buffer, for the first
fragment which is not suitable for Xen-swiotlb to do DMA operations.
Xen-swiotlb have to internally allocate another page for doing DMA
operations. This mechanism requires
On Thu, Aug 8, 2019 at 12:18 AM Atish Patra wrote:
>
> On Wed, 2019-08-07 at 12:28 +, Anup Patel wrote:
> > This patch adds riscv_isa bitmap which represents Host ISA features
> > common across all Host CPUs. The riscv_isa is not same as elf_hwcap
> > because elf_hwcap will only have ISA
The patch supports slave mode for imx I2C driver
Signed-off-by: Biwen Li
---
drivers/i2c/busses/i2c-imx.c | 199 ---
1 file changed, 185 insertions(+), 14 deletions(-)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index
When building with W=1, we get some warnings:
l CC lib/generic-radix-tree.o
lib/generic-radix-tree.c:39:10: warning: no previous prototype for
'genradix_root_to_depth' [-Wmissing-prototypes]
39 | unsigned genradix_root_to_depth(struct genradix_root *r)
|
On Wed, Aug 7, 2019 at 6:58 PM Jacob Wen wrote:
>
>
> On 8/7/19 4:38 PM, Firo Yang wrote:
> > The 08/07/2019 15:56, Jacob Wen wrote:
> >> I think the description is not correct. Consider using something like
> >> below.
> > Thank you for comments.
> >
> >> In Xen environment, due to memory
On Fri, Aug 2, 2019 at 8:04 AM Rikard Falkeborn
wrote:
>
> Be a little more verbose to improve readability.
>
> Signed-off-by: Rikard Falkeborn
BTW, I do not understand what the improvement is.
I tend to regard this as a noise commit.
> ---
> Changes in v2:
> - This patch is new in v2
>
>
When building with W=1, a number of warnings are issued:
CC lib/extable.o
lib/extable.c:63:6: warning: no previous prototype for 'sort_extable'
[-Wmissing-prototypes]
63 | void sort_extable(struct exception_table_entry *start,
| ^~~~
lib/extable.c:75:6: warning: no
From: Lori Hikichi
Add the full name of the devicetree node to the adapter name.
Without this change, all adapters have the same name making it difficult
to distinguish between multiple instances.
The most obvious way to see this is to use the utility i2c_detect.
e.g. "i2c-detect -l"
Before
From: Lori Hikichi
The driver does not support the SMBUS Quick command so remove the
flag that indicates that level of support.
By default the i2c_detect tool uses the quick command to try and
detect devices at some bus addresses. If the quick command is used
then we will not detect the device,
Hi,
This patchset contains following changes:
- Remove SMBUS quick command support
- Update full name of dt node to adapter name
Lori Hikichi (2):
i2c: iproc: Stop advertising support of SMBUS quick cmd
i2c: iproc: Add full name of devicetree node to adapter name
On Wed, Aug 07, 2019 at 05:05:33PM -0700, Mike Kravetz wrote:
> Li Wang discovered that LTP/move_page12 V2 sometimes triggers SIGBUS
> in the kernel-v5.2.3 testing. This is caused by a race between hugetlb
> page migration and page fault.
>
> If a hugetlb page can not be allocated to satisfy a
On 2019/8/7 21:02, Michael Ellerman wrote:
Jason Yan writes:
These two variables are both defined in init_32.c and init_64.c. Move
them to init-common.c.
Signed-off-by: Jason Yan
Cc: Diana Craciun
Cc: Michael Ellerman
Cc: Christophe Leroy
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
The commit 155433cb365e ("arm64: cache: Remove support for ASID-tagged
VIVT I-caches") introduced some compiation warnings from GCC (and
Clang) with -Winitializer-overrides),
arch/arm64/kernel/cpuinfo.c:38:26: warning: initialized field
overwritten [-Woverride-init]
[ICACHE_POLICY_VIPT] =
When building with W=1, we get warnings about missing prototypes:
CC arch/x86/lib/cpu.o
arch/x86/lib/cpu.c:5:14: warning: no previous prototype for 'x86_family'
[-Wmissing-prototypes]
5 | unsigned int x86_family(unsigned int sig)
| ^~
On Wed, Aug 07, 2019 at 09:51:01AM +0200, Michal Hocko wrote:
>On Wed 07-08-19 08:31:09, Wei Yang wrote:
>> On Tue, Aug 06, 2019 at 11:29:52AM +0200, Vlastimil Babka wrote:
>> >On 8/6/19 10:11 AM, Wei Yang wrote:
>> >> When addr is out of the range of the whole rb_tree, pprev will points to
>> >>
The global variable 'PLL_48K_RATE' is never used
so just remove it.
Signed-off-by: YueHaibing
---
sound/soc/codecs/tscs454.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/tscs454.c b/sound/soc/codecs/tscs454.c
index 93d84e5..c3587af 100644
--- a/sound/soc/codecs/tscs454.c
On Thu, Aug 1, 2019 at 5:53 PM Bin Meng wrote:
>
> On Sun, Jul 28, 2019 at 5:30 PM Bin Meng wrote:
> >
> > The base address of msi-controller@c should be set to c.
> >
> > Signed-off-by: Bin Meng
> > ---
> >
> > Documentation/devicetree/bindings/interrupt-controller/msi.txt | 2 +-
> > 1 file
On 2019/8/7 21:13, Michael Ellerman wrote:
Jason Yan writes:
M_IF_NEEDED is defined too many times. Move it to a common place.
The name is not great, can you call it MAS2_M_IF_NEEDED, which at least
gives a clue what it's for?
OK.
cheers
Signed-off-by: Jason Yan
Cc: Diana Craciun
On Thu, Aug 1, 2019 at 5:53 PM Bin Meng wrote:
>
> On Sun, Jul 28, 2019 at 5:30 PM Bin Meng wrote:
> >
> > The unit-address must match the first address specified in the
> > reg property of the node.
> >
> > Signed-off-by: Bin Meng
> > ---
> >
> >
On 2019/8/7 21:12, Michael Ellerman wrote:
Hi Jason,
Jason Yan writes:
This series implements KASLR for powerpc/fsl_booke/32, as a security
feature that deters exploit attempts relying on knowledge of the location
of kernel internals.
Thanks for doing this work.
Sorry I didn't get a
Hi Herbert,
On Thu, 8 Aug 2019 13:01:57 +1000 Herbert Xu
wrote:
>
> Sorry, I forgot about your patch as it wasn't cced to the crypto
> mailing list. It should be out there now.
Excellent, thanks. Should I add the crypto mailing list as a contact
for problems? Mostly the emails are just
Rob Herring writes:
> On Mon, Aug 5, 2019 at 3:46 PM Kevin Hilman wrote:
>>
>> Neil Armstrong writes:
>>
>> > Add a specific compatible for the Amlogic G12B family based S922X SoC
>> > to differentiate with the A311D SoC from the same family.
>> >
>> > Signed-off-by: Neil Armstrong
>> > ---
Mark switch cases where we are expecting to fall through.
Fix the following warnings (Building: arm-ep93xx_defconfig arm):
arch/arm/mach-ep93xx/crunch.c: In function 'crunch_do':
arch/arm/mach-ep93xx/crunch.c:46:3: warning: this statement may
fall through [-Wimplicit-fallthrough=]
On Thu, Aug 08, 2019 at 11:52:45AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> On Mon, 5 Aug 2019 14:57:36 +1000 Stephen Rothwell
> wrote:
> >
> > Hi all,
> >
> > After merging the crypto tree, today's linux-next build (sparc64
> > defconfig) failed like this:
> >
> >
Martin Blumenstingl writes:
> Hi Guillaume,
>
> On Mon, Aug 5, 2019 at 2:48 PM guillaume La Roque
> wrote:
>>
>> Hi Martin,
>>
>> again thanks for your review.
> you're welcome - thank you for working on the driver :-)
>
> [...]
>> > The IP block has more functionality, which may be added to
When building with W=1, fs/cifs throws a lot of 'set but not used' messages.
CC [M] fs/cifs/file.o
fs/cifs/file.c: In function 'cifs_lock':
fs/cifs/file.c:1698:8: warning: variable 'netfid' set but not used
[-Wunused-but-set-variable]
1698 | __u16 netfid;
|^~
Hi all,
Today's linux-next merge of the bpf-next tree got a conflict in:
tools/lib/bpf/libbpf.c
between commit:
1d4126c4e119 ("libbpf: sanitize VAR to conservative 1-byte INT")
from Linus' tree and commit:
b03bc6853c0e ("libbpf: convert libbpf code to use new btf helpers")
from the
On 8/7/19 7:24 PM, 裘稀石(稀石) wrote:
> Hi Mike,
>
> Do you mean the similar race is like the following?
>
> migration clearing the pte
> page fault(before we return error, and now we return 0, then try page fault
> again, right?)
> migration writing a migration entry
Yes, something like the
Hi Rikard,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.3-rc3 next-20190807]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
Hi Rikard,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.3-rc3 next-20190807]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
tree:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
dev.2019.07.31a
head: 71cf692f482ff45802352cf85a8880035fca9e52
commit: ab2ef5c7b4d1933ee53a66d981cb67974de46815 [110/123] rcu/nocb: Atomic
->len field in rcu_segcblist structure
reproduce:
# apt-get
Fixes: ab2ef5c7b4d1 ("rcu/nocb: Atomic ->len field in rcu_segcblist structure")
Signed-off-by: kbuild test robot
---
rcu_segcblist.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/rcu/rcu_segcblist.c b/kernel/rcu/rcu_segcblist.c
index
t;>
>> depends on BD70528_WATCHDOG || !BD70528_WATCHDOG
>>
>> which would allow building with or without watchdog, even when not
>> compile-testing, but still disallow the combination of
>> .
>
> Thanks for teaching me Arnd! That is clever :) We need something like
>
> depends on MFD_ROHM_BD70528 && (BD70528_WATCHDOG || !BD70528_WATCHDOG)
>
> (I'm not sure if parenthesis are Ok and respected in Kconfig). I would
> never have thought of BD70528_WATCHDOG || !BD70528_WATCHDOG - it looks
> awkward at first sight but indeed - depends on BD70528_WATCHDOG
> disallows BD70528_WATCHDOG=m with RTC_DRV_BD70528=y while
> !BD70528_WATCHDOG allows BD70528_WATCHDOG=n. Brilliant and exactly what
> we need :) Thanks a bunch!
Hello Vaittinen,
the issue still exists in linux-next 20190807, any plan?
>
>>
>>Arnd
From: xiao jin
commit 54648cf1ec2d7f4b6a71767799c45676a138ca24 upstream.
We find the memory use-after-free issue in __blk_drain_queue()
on the kernel 4.14. After read the latest kernel 4.18-rc6 we
think it has the same problem.
Memory is allocated for q->fq in the blk_init_allocated_queue().
Hi Gustavo,
FYI, the error/warning still remains.
tree:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: ecb095bff5d4b8711a81968625b3b4a235d3e477
commit: a035d552a93bb9ef6048733bb9f2a0dc857ff869 Makefile: Globally enable
fall-through warning
date:
For suspend-to-idle, send suspend message and set N0_D3 flag to put
the ISH into D0i3 state.
For suspend-to-mem, disable the DMA bit before ISH entering D3, and
NO_D3 flag is cleared by default, then the ISH would enter D3.
Signed-off-by: Zhang Lixu
---
drivers/hid/intel-ish-hid/ipc/pci-ish.c |
Currently, the NO_D3 flag is set in ish_probe(), and cleared in
ish_remove(). So even if the system goes into S3, ISH is still
in D0i3 state. It makes more sense that put ISH into D3 as system
goes into S3 and put ISH into D0i3 as system goes into suspend-to-idle.
I remove the NO_D3 setting in
Currently, the NO_D3 flag is set in ish_probe(), the intel-ish-ipc driver
puts the ISH into D0i3 when system enter both suspend-to-idle(S0ix) and
suspend-to-mem(S3). These patches are to put the ISH into D3 when system
enter S3 and put the ISH into D0i3 when system enter S0ix.
I tested these
The NO_D3 flag would be set if the ISH enter D0i3 in ish_suspend(),
The resume paths can be distinguished by checking the NO_D3 flag.
It's more reasonable than checking the FW status.
Signed-off-by: Zhang Lixu
---
drivers/hid/intel-ish-hid/ipc/pci-ish.c | 34 +++--
1 file
Colin,
> There are several occasions where variable rc is being initialized
> with a value that is never read and error is being re-assigned a
> little later on. Clean up the code by removing rc entirely and
> just returning the return value from the call to pm8001_issue_ssp_tmf
Applied to
John,
> This patchset incldues a set of misc changes for the driver.
>
> Nothing particularly stands out. Here's a quick overview:
> - minor optimisation in delivery path
> - some debugfs fixes and new minor features
> - some other very minor optimisations
> - and generally the rest are tidy-up
Hi Greg, Saravana,
On 8/1/19 11:37 PM, Greg Kroah-Hartman wrote:
> On Thu, Aug 01, 2019 at 12:59:25PM -0700, Frank Rowand wrote:
>> On 8/1/19 12:32 PM, Greg Kroah-Hartman wrote:
>>> On Thu, Aug 01, 2019 at 12:28:13PM -0700, Frank Rowand wrote:
Hi Greg,
On 7/31/19 11:12 PM, Greg
On 8/7/19 8:51 PM, Valdis Klētnieks wrote:
Fix spurious warning message when building with W=1:
CC [M] drivers/net/wireless/realtek/rtlwifi/usb.o
drivers/net/wireless/realtek/rtlwifi/usb.c:243: warning: Cannot understand *
on line 243 - I thought it was a doc line
> Date: Tue, 23 Jul 2019 17:10:55 -0700
> Subject: [PATCH v7 2/7] driver core: Add edit_links() callback for drivers
> From: Saravana Kannan
>
> The driver core/bus adding supplier-consumer dependencies by default
> enables functional dependencies to be tracked correctly even when the
>
> Date: Tue, 23 Jul 2019 17:10:54 -0700
> Subject: [PATCH v7 1/7] driver core: Add support for linking devices during
> device addition
> From: Saravana Kannan
>
> When devices are added, the bus might want to create device links to track
> functional dependencies between supplier and consumer
Hi Saravana,
On 7/23/19 5:10 PM, Saravana Kannan wrote:
> Add device-links to track functional dependencies between devices
> after they are created (but before they are probed) by looking at
> their common DT bindings like clocks, interconnects, etc.
>
< snip >
I know that this series has
Building without CONFIG_POWER_SUPPLY will fail:
drivers/regulator/act8865-regulator.o: In function `act8865_pmic_probe':
act8865-regulator.c:(.text+0x357): undefined reference to
`devm_power_supply_register'
drivers/regulator/act8865-regulator.o: In function
`act8600_charger_get_property':
On 8/7/19 4:38 PM, Firo Yang wrote:
The 08/07/2019 15:56, Jacob Wen wrote:
I think the description is not correct. Consider using something like below.
Thank you for comments.
In Xen environment, due to memory fragmentation ixgbe may allocate a 'DMA'
buffer with pages that are not
The 08/07/2019 09:06, Alexander Duyck wrote:
> On Wed, Aug 7, 2019 at 7:09 AM Maciej Fijalkowski
> wrote:
> >
> > On Wed, 7 Aug 2019 08:38:43 +
> > Firo Yang wrote:
> >
> > > The 08/07/2019 15:56, Jacob Wen wrote:
> > > > I think the description is not correct. Consider using something like
On 8/7/19 3:39 PM, Valdis Klētnieks wrote:
> Fix spurious warning message when building with W=1:
>
> CC [M] drivers/net/wireless/realtek/rtlwifi/usb.o
> drivers/net/wireless/realtek/rtlwifi/usb.c:243: warning: Cannot understand *
> on line 243 - I thought it was a doc line
>
errors.
I do not understand why Andrew picked up this so soon.
I think it makes complete sense to break -next (not mainline)
and force people to fix defects. Especially these types of
defects that are trivial to fix.
I don't think this (from next-20190807):
Build results:
total: 158 pass
Hi all,
On Mon, 5 Aug 2019 14:57:36 +1000 Stephen Rothwell
wrote:
>
> Hi all,
>
> After merging the crypto tree, today's linux-next build (sparc64
> defconfig) failed like this:
>
> drivers/char/hw_random/n2-drv.c: In function 'n2rng_probe':
> drivers/char/hw_random/n2-drv.c:771:29: error:
On Wed, Aug 07, 2019 at 07:22:34PM -0400, Valdis Klētnieks wrote:
> When building with W=1, we get some kerneldoc warnings:
>
> CC fs/fhandle.o
> fs/fhandle.c:259: warning: Function parameter or member 'flags' not described
> in 'sys_open_by_handle_at'
> fs/fhandle.c:259: warning: Excess
Anil,
> Configure CDNS_UFS_REG_HCLKDIV in .hce_enable_notify() instead of
> .setup_clock() because if UFSHCD resets the controller ip because
> of phy or device related errors then CDNS_UFS_REG_HCLKDIV is
> reset to default value and .setup_clock() is not called later
> in the sequence whereas
Fix spurious warning message when building with W=1:
CC [M] drivers/net/wireless/realtek/rtlwifi/usb.o
drivers/net/wireless/realtek/rtlwifi/usb.c:243: warning: Cannot understand *
on line 243 - I thought it was a doc line
drivers/net/wireless/realtek/rtlwifi/usb.c:760: warning: Cannot
Hi Kamil,
When I applied them to testing branch, those don't have the author name
only just have the email address as following:
You have to edit the your git author information with your name.
author k.koniec...@partner.samsung.com
2019-08-07 15:38:36 +0200
committer Chanwoo Choi
Tomas,
> Define new a type: uc_string_id for easier string handling and less
> casting. Reduce number or string copies in price of a dynamic
> allocation.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Gustavo,
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning (Building: m68k):
>
> drivers/scsi/wd33c93.c: In function ‘round_4’:
> drivers/scsi/wd33c93.c:1856:11: warning: this statement may fall through
> [-Wimplicit-fallthrough=]
>case
Gustavo,
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/scsi/sun3_scsi.c: warning: this statement may fall through
> [-Wimplicit-fallthrough=]: => 399:9, 403:9
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen
commit 81398d99e9de80d9dbe65dfe7aadec9497f88242
Author: Gilad Ben-Yossef
Date: Wed Jul 31 14:44:23 2019 +1000
checkpatch: add *_NOTIFIER_HEAD as var definition
has a typo, resulting in a truly amazing error message:
Unescaped left brace in regex is passed through in regex; marked by <--
Remove the redundant initialization code.
Signed-off-by: Fuqian Huang
---
drivers/scsi/lpfc/lpfc_bsg.c | 1 -
drivers/scsi/lpfc/lpfc_sli.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
index b7216d694bff..5f66a2da2599 100644
---
Gustavo,
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings (Building: sparc defconfig):
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
1 - 100 of 871 matches
Mail list logo
