Re: [PATCH 2/3] xen/ballon: Avoid calling dummy function __online_page_set_limits()

2019-09-07 Thread Juergen Gross
On 07.09.19 23:47, Souptick Joarder wrote: __online_page_set_limits() is a dummy function and an extra call to this function can be avoided. Signed-off-by: Souptick Joarder Reviewed-by: Juergen Gross Juergen

Re: [PATCH] VMCI: Release resource if the work is already queued

2019-09-07 Thread Nadav Amit
> On Sep 7, 2019, at 9:47 PM, Greg Kroah-Hartman > wrote: > > On Tue, Aug 20, 2019 at 01:26:38PM -0700, Nadav Amit wrote: >> Francois reported that VMware balloon gets stuck after a balloon reset, >> when the VMCI doorbell is removed. A similar error can occur when the >> balloon driver is

[PATCH] media: vim2m: Fix BUG_ON in vim2m_device_release()

2019-09-07 Thread Kefeng Wang
If v4l2_m2m_init() fails, m2m_dev pointer will be set ERR_PTR(-ENOMEM), then kfree m2m_dev will triger BUG_ON, see below, fix it by setting m2m_dev to NULL. vim2m vim2m.0: Failed to init mem2mem device [ cut here ] kernel BUG at mm/slub.c:3944! invalid opcode:

[PATCH v2] regulator: lp87565: Simplify lp87565_buck_set_ramp_delay

2019-09-07 Thread Axel Lin
Use rdev->regmap/>dev instead of lp87565->regmap/lp87565->dev. In additional, the lp87565->dev actually is the parent mfd device, so the dev_err message is misleading here with lp87565->dev. Signed-off-by: Axel Lin --- v2: Add lp87565 prefix in subject line

[PATCH] regulator: Simplify lp87565_buck_set_ramp_delay

2019-09-07 Thread Axel Lin
Use rdev->regmap/>dev instead of lp87565->regmap/lp87565->dev. In additional, the lp87565->dev actually is the parent mfd device, so the dev_err message is misleading here with lp87565->dev. Signed-off-by: Axel Lin --- drivers/regulator/lp87565-regulator.c | 5 ++--- 1 file changed, 2

Re: general protection fault in dev_map_hash_update_elem

2019-09-07 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:a2c11b03 kcm: use BPF_PROG_RUN git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=13d46ec160 kernel config: https://syzkaller.appspot.com/x/.config?x=cf0c85d15c20ade3 dashboard link:

Re: [patch for-5.3 0/4] revert immediate fallback to remote hugepages

2019-09-07 Thread David Rientjes
On Sat, 7 Sep 2019, Linus Torvalds wrote: > > Andrea acknowledges the swap storm that he reported would be fixed with > > the last two patches in this series > > The problem is that even you aren't arguing that those patches should > go into 5.3. > For three reasons: (a) we lack a test result

Re: [PATCH 0/8] kconfig/hacking: make 'kernel hacking' menu better structured

2019-09-07 Thread Changbin Du
This is a preview: │ ┌───┐ │ │ │printk and dmesg options ---> │ │ │ │Compile-time checks and compiler options ---> │ │ │ │Generic Kernel Debugging Instruments

[PATCH 8/8] kconfig/hacking: Move DEBUG_BUGVERBOSE to 'printk and dmesg options'

2019-09-07 Thread Changbin Du
I think DEBUG_BUGVERBOSE is a dmesg option which gives more debug info to dmesg. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 740ada6744f6..bb82a02f6172 100644

[PATCH 6/8] kconfig/hacking: Move SCHED_STACK_END_CHECK after DEBUG_STACK_USAGE

2019-09-07 Thread Changbin Du
They are both memory debug options to debug kernel stack issues. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 99c6dbd64ce7..458d2a4435a4 100644 ---

[PATCH 7/8] kconfig/hacking: Create a submenu for scheduler debugging options

2019-09-07 Thread Changbin Du
Create a submenu 'Scheduler Debugging' for scheduler debugging options. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 4 1 file changed, 4 insertions(+) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 458d2a4435a4..740ada6744f6 100644 --- a/lib/Kconfig.debug +++

[PATCH 5/8] kconfig/hacking: Move Oops into 'Lockups and Hangs'

2019-09-07 Thread Changbin Du
They are similar options so place them together. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 58 +++ 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index ca2083350178..99c6dbd64ce7 100644

[PATCH 3/8] kconfig/hacking: Group kernel data structures debugging together

2019-09-07 Thread Changbin Du
Group these similar runtime data structures verification options together. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 96047140be93..3c9674483ec2

[PATCH 1/8] kconfig/hacking: Group sysrq/kgdb/ubsan into 'Generic Kernel Debugging Instruments'

2019-09-07 Thread Changbin Du
Group generic kernel debugging instruments sysrq/kgdb/ubsan together into a new submenu. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 5960e2980a8a..868fa64a0901

[PATCH 2/8] kconfig/hacking: Create submenu for arch special debugging options

2019-09-07 Thread Changbin Du
The arch special options are a little long, so create a submenu for them. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 4 1 file changed, 4 insertions(+) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 868fa64a0901..96047140be93 100644 --- a/lib/Kconfig.debug +++

[PATCH 4/8] kconfig/hacking: Move kernel testing and coverage options to same submenu

2019-09-07 Thread Changbin Du
Move error injection, coverage, testing options to a new submenu 'Kernel Testing and Coverage'. They are all for test purpose. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 485 +++--- 1 file changed, 245 insertions(+), 240 deletions(-) diff --git

[PATCH 0/8] kconfig/hacking: make 'kernel hacking' menu better structured

2019-09-07 Thread Changbin Du
This series is a trivial improvment for the layout of 'kernel hacking' configuration menu. Now we have many items in it which makes takes a little time to look up them since they are not well structured yet. Early discussion is here: https://lkml.org/lkml/2019/9/1/39 Changbin Du (8):

drivers/power/reset/nvmem-reboot-mode.c:27:42: error: passing argument 2 of 'nvmem_cell_write' from incompatible pointer type

2019-09-07 Thread kbuild test robot
Hi Han, FYI, the error/warning still remains. tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git master head: 950b07c14e8c59444e2359f15fd70ed5112e11a0 commit: 7a78a7f7695bf9ef9cef3c06fbc5fa4573fd0eef power: reset: nvmem-reboot-mode: use NVMEM as reboot mode

Re: [PATCH] tpm_crb: fix fTPM on AMD Zen+ CPUs

2019-09-07 Thread Jarkko Sakkinen
On Sun, 2019-09-08 at 00:49 +0300, Jarkko Sakkinen wrote: > On Wed, 2019-09-04 at 22:03 +0300, ivan.laz...@gmail.com wrote: > > From: Ivan Lazeev > > > > Bug link: https://bugzilla.kernel.org/show_bug.cgi?id=195657 > > > > cmd/rsp buffers are expected to be in the same ACPI region. > > For Zen+

[PATCH v3 0/4] cpuidle, haltpoll: governor switching on idle register

2019-09-07 Thread Joao Martins
Hey, Presented herewith a series with aims to tie in together the haltpoll idle driver and governor, without sacrificing previous governor setups. In addition, there are a few fixes with respect to module loading for cpuidle-haltpoll. The series is organized as follows: Patch 1: Allows idle

Re: [PATCH -next 25/36] spi: s3c24xx: use devm_platform_ioremap_resource() to simplify code

2019-09-07 Thread Andi Shyti
Hi Yuehaibing, > >> Use devm_platform_ioremap_resource() to simplify the code a bit. > >> This is detected by coccinelle. > >> > >> Reported-by: Hulk Robot > > > > This tag does not look real... First of all where is the report? > > It is our internal CI robot, which is unavailable to external

[PATCH v3 4/4] cpuidle-haltpoll: do not set an owner to allow modunload

2019-09-07 Thread Joao Martins
cpuidle-haltpoll can be built as a module to allow optional late load. Given we are setting @owner to THIS_MODULE, cpuidle will attempt to grab a module reference every time a cpuidle_device is registered -- so essentially all online cpus get a reference. This prevents for the module to be

[PATCH v3 3/4] cpuidle-haltpoll: return -ENODEV on modinit failure

2019-09-07 Thread Joao Martins
When a user loads cpuidle-haltpoll on a non KVM guest the module will successfully load, even though idle driver registration didn't take place. We should instead return -ENODEV signaling the user that the driver can't be loaded, like other error paths in haltpoll_init(). An example of such

[PATCH v3 1/4] cpuidle: allow governor switch on cpuidle_register_driver()

2019-09-07 Thread Joao Martins
The recently introduced haltpoll driver is largely only useful with haltpoll governor. To allow drivers to associate with a particular idle behaviour, add a @governor property to 'struct cpuidle_driver' and thus allow a cpuidle driver to switch to a *preferred* governor on idle driver

[PATCH v3 2/4] cpuidle-haltpoll: set haltpoll as preferred governor

2019-09-07 Thread Joao Martins
Right now, guest current governors have the following ratings: * ladder-> 10 * teo -> 19 * menu -> 20 * haltpoll -> 21 * ladder + nohz=off -> 25 haltpoll governor got introduced and it is now the default governor given its highest rating --

Re: [PATCH v6 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-09-07 Thread Joel Fernandes
On Sat, Sep 07, 2019 at 11:12:59PM +0200, Viktor Rosendahl wrote: > On 9/6/19 4:17 PM, Joel Fernandes wrote: > > On Thu, Sep 05, 2019 at 03:25:45PM +0200, Viktor Rosendahl wrote: > > > > + > > > +__init static int latency_fsnotify_init(void) > > > +{ > > > + fsnotify_wq =

Re: perf_event wakeup_events = 0

2019-09-07 Thread Theodore Dubois
On Sep 7, 2019, at 3:45 PM, Valdis Klētnieks wrote: > So an entry is made in the buffer. It's not clear that this immediately > triggers > a signal… I think the documentation says it does when wakeup_events is 1. The code for perf backs this up:

Re: [PATCH] gpio: fix build failure: gpiochip_[un]lock*() static/non-static

2019-09-07 Thread Linus Walleij
On Sat, Sep 7, 2019 at 2:05 AM John Hubbard wrote: > While building with !CONFIG_GPIOLIB, I experienced a build failure, > because driver.h in that configuration supplies both a static and > a non-static version of these routines: I think this is fixed in my latest version of the "devel"

Re: [GIT PULL] Char/Misc driver fixes for 5.3-rc8

2019-09-07 Thread pr-tracker-bot
The pull request you sent on Sat, 7 Sep 2019 19:40:33 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git > tags/char-misc-5.3-rc8 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b3a9964cfa690150e49ae75ba16416ccaac3a8ba Thank you! --

Re: perf_event wakeup_events = 0

2019-09-07 Thread Valdis Klētnieks
On Sat, 07 Sep 2019 09:14:49 -0700, Theodore Dubois said: Reading what it actually says rather than what I thought it said.. :) Events come in two flavors: counting and sampled. A counting event is one that is used for counting the aggregate number of events that

Re: [PATCH AUTOSEL 4.19 126/167] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

2019-09-07 Thread Sasha Levin
On Sat, Sep 07, 2019 at 09:55:18PM +0300, Jarkko Sakkinen wrote: On Tue, 2019-09-03 at 15:43 -0400, Sasha Levin wrote: Right. I gave a go at backporting a few patches and this happens to be one of them. It will be a while before it goes in a stable tree (probably way after after LPC). It

Re: perf_event wakeup_events = 0

2019-09-07 Thread Valdis Klētnieks
On Sat, 07 Sep 2019 09:14:49 -0700, Theodore Dubois said: > If I’m reading this right, this is a sampling event which overflows 4000 > times a second. But perf then does a poll call which wakes up on this FD with > POLLIN after 1.637 seconds, instead of 0.00025 seconds. No, it *takes a sample*

Attention please

2019-09-07 Thread Mariam Kabore
Dear sir/madam My name is Mrs. Mariam Kabore. I have decided to seek a confidential co-operation with you for the execution of the deal described hereunder for our mutual benefit. I Hope you will keep it a secret due to the nature of the transaction. During the course of our audit last month, I

Re: [PATCH] tpm_crb: fix fTPM on AMD Zen+ CPUs

2019-09-07 Thread Jarkko Sakkinen
On Wed, 2019-09-04 at 22:03 +0300, ivan.laz...@gmail.com wrote: > From: Ivan Lazeev > > Bug link: https://bugzilla.kernel.org/show_bug.cgi?id=195657 > > cmd/rsp buffers are expected to be in the same ACPI region. > For Zen+ CPUs BIOS's might report two different regions, some of > them also

[PATCH 2/2 v2] staging: exfat: cleanup casts

2019-09-07 Thread Valentin Vidic
Use constants and fix checkpatch.pl warnings: CHECK: No space is necessary after a cast Signed-off-by: Valentin Vidic --- v2: Use constants where possible drivers/staging/exfat/exfat_core.c | 94 ++--- drivers/staging/exfat/exfat_super.c | 66 ++-- 2

Re: [GIT PULL] cpupower update for Linux 5.4-rc1

2019-09-07 Thread Rafael J. Wysocki
Hi Shuah, On Fri, Sep 6, 2019 at 5:36 PM Shuah Khan wrote: > > Hi Rafael, > > Please pull the following update for Linux 5.4-rc1 or 5.4-rc2 depending > on your pull request schedule for Linus. > > This cpupower update for Linux 5.4-rc1 consists of bug fixes and > German translation updates from

[PATCH 1/3] hv_ballon: Avoid calling dummy function __online_page_set_limits()

2019-09-07 Thread Souptick Joarder
__online_page_set_limits() is a dummy function and an extra call to this function can be avoided. Signed-off-by: Souptick Joarder --- drivers/hv/hv_balloon.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c index 6fb4ea5..9bab443 100644 ---

[PATCH 0/3] Remove __online_page_set_limits()

2019-09-07 Thread Souptick Joarder
__online_page_set_limits() is a dummy function and an extra call to this can be avoided. As both of the callers are now removed, __online_page_set_limits() can be removed permanently. Souptick Joarder (3): hv_ballon: Avoid calling dummy function __online_page_set_limits() xen/ballon: Avoid

[PATCH 2/3] xen/ballon: Avoid calling dummy function __online_page_set_limits()

2019-09-07 Thread Souptick Joarder
__online_page_set_limits() is a dummy function and an extra call to this function can be avoided. Signed-off-by: Souptick Joarder --- drivers/xen/balloon.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c index 4e11de6..05b1f7e 100644 ---

[PATCH 3/3] mm/memory_hotplug.c: Remove __online_page_set_limits()

2019-09-07 Thread Souptick Joarder
As both the callers of this dummy __online_page_set_limits() is removed, this can be removed permanently. Signed-off-by: Souptick Joarder --- include/linux/memory_hotplug.h | 1 - mm/memory_hotplug.c| 5 - 2 files changed, 6 deletions(-) diff --git

Re: [PATCH] x86/umip: Add emulation for 64-bit processes

2019-09-07 Thread Ricardo Neri
On Thu, Sep 05, 2019 at 04:22:21PM -0700, Brendan Shanks wrote: > Add emulation of the sgdt, sidt, and smsw instructions for 64-bit > processes. > > Wine users have encountered a number of 64-bit Windows games that use > these instructions (particularly sgdt), and were crashing when run on >

Re: [PATCH] tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts

2019-09-07 Thread Jarkko Sakkinen
On Fri, 2019-09-06 at 14:37 +0200, Jan Lübbe wrote: > This is due to the SPI accesses performed by tis_int_handler (which > will sleep). Switching to devm_request_threaded_irq fixes this and > leads to a successful IRQ probe. Aah, right through tpm_tis_read32/write32(). This is definitely a new

Re: [PATCH 0/6] Address issues with SPDX requirements and PEP-263

2019-09-07 Thread Thomas Gleixner
On Sat, 7 Sep 2019, Markus Heiser wrote: > Am 07.09.19 um 20:04 schrieb Mauro Carvalho Chehab: > > No idea. I would actually prefer to just remove the restriction, and let > > the SPDX header to be anywhere inside the first comment block inside a > > file [2]. > > > That's basically how this

Re: Linux 5.3-rc7

2019-09-07 Thread Linus Torvalds
On Sat, Sep 7, 2019 at 1:44 PM Thomas Gleixner wrote: > > That's what I just replied to Chris. Can you do it right away or should I > queue it up? Done. Thanks, Linus

Re: [PATCH v6 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-09-07 Thread Viktor Rosendahl
On 9/6/19 4:17 PM, Joel Fernandes wrote: On Thu, Sep 05, 2019 at 03:25:45PM +0200, Viktor Rosendahl wrote: + +__init static int latency_fsnotify_init(void) +{ + fsnotify_wq = alloc_workqueue("tr_max_lat_wq", + WQ_UNBOUND | WQ_HIGHPRI, 0); + if

Re: [PATCH] mostpost: don't warn about symbols from another file

2019-09-07 Thread Denis Efremov
On 06.09.2019 18:10, Arnd Bergmann wrote: > On architectures such as ARM that have a list of symbols exported > from assembler in a separate C file, we get a lot of new warnings: > > WARNING: "__ashrdi3" [vmlinux] is a static (unknown) WARNING: > "__lshrdi3" [vmlinux] is a static (unknown)

[PATCH] Documentation: kunit: Fix verification command

2019-09-07 Thread SeongJae Park
kunit wrapper script ('kunit.py') receives a sub-command (only 'run' for now) as its argument. If no sub-command is given, it prints help message and just quit. However, an example command in the kunit documentation for a verification of kunit is missing the sub-command. This commit fixes the

[PATCH] Staging: wlan-ng: parenthesis at end of line fix

2019-09-07 Thread Sandro Volery
Fixed open parenthesis at the end of the line on line 327. Signed-off-by: Sandro Volery --- drivers/staging/wlan-ng/cfg80211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c index

Re: [PATCH v3 0/6] ARM: dts: mmp2: devicetree updates

2019-09-07 Thread Pavel Machek
On Sat 2019-09-07 21:57:42, Arnd Bergmann wrote: > On Sat, Sep 7, 2019 at 9:40 PM Pavel Machek wrote: > > > > > > > Here's a couple of updates for the MMP2 SoC devicetree files. > > > I'm wondering if they could be applied to the armsoc tree? > > > > > > Compared to previous submission, the only

Re: Linux 5.3-rc7

2019-09-07 Thread Thomas Gleixner
On Sat, 7 Sep 2019, Linus Torvalds wrote: > On Sat, Sep 7, 2019 at 8:00 AM Thomas Gleixner wrote: > > So why wouldn't we just revert it? That's what I just replied to Chris. Can you do it right away or should I queue it up? Thanks, tglx

Re: [PATCH -next] scsi: ufs-hisi: use devm_platform_ioremap_resource() to simplify code

2019-09-07 Thread Martin K. Petersen
YueHaibing, > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. Applied to 5.4/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH -next] scsi: ufshcd: use devm_platform_ioremap_resource() to simplify code

2019-09-07 Thread Martin K. Petersen
YueHaibing, > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. Applied to 5.4/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH -next] scsi: hisi_sas: use devm_platform_ioremap_resource() to simplify code

2019-09-07 Thread Martin K. Petersen
YueHaibing, > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. Applied to 5.4/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH -next] scsi: ufs: Use kmemdup in ufshcd_read_string_desc()

2019-09-07 Thread Martin K. Petersen
YueHaibing, > Use kmemdup rather than duplicating its implementation Applied to 5.4/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v4 0/3] Qualcomm UFS device reset support

2019-09-07 Thread Martin K. Petersen
Bjorn, > This series adds a new ufs vops to allow platform specific methods for > resetting an attached UFS device, then implements this for the > Qualcomm driver. This reset seems to be necessary for the majority of > Dragonboard845c devices. Applied to 5.4/scsi-queue, thanks! -- Martin K.

Re: [PATCH] Fixed most indent issues in tty_io.c

2019-09-07 Thread Sandro Volery
Sandro V >> On 7 Sep 2019, at 22:04, Joe Perches wrote: >> >> On Sat, 2019-09-07 at 11:09 +0200, volery wrote: >> There were a lot of styling problems using space then tab or spaces >> instead of tabs in that file. Especially the entire function at line >> 2677. >> Also added a space before

Re: [PATCH 1/1] scsi: lpfc: Convert existing %pf users to %ps

2019-09-07 Thread Martin K. Petersen
Sakari, > Convert the remaining %pf users to %ps to prepare for the removal of > the old %pf conversion specifier support. Applied to 5.4/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]

2019-09-07 Thread Andy Shevchenko
On Sat, Sep 7, 2019 at 9:15 PM Joe Perches wrote: > > Standard integer promotion is already done and %hx and %hhx is useless > so do not encourage the use of %hh[xudi] or %h[xudi]. > > As Linus said in: > Link: >

Re: Linux 5.3-rc7

2019-09-07 Thread Thomas Gleixner
On Sat, 7 Sep 2019, Chris Wilson wrote: > Quoting Thomas Gleixner (2019-09-07 16:00:17) > > Does this only happen with that CPU0 hotplug stuff enabled or on CPUs other > > than CPU0 as well? That hotplug CPU0 stuff is a bandaid so I wouldn't be > > surprised if we broke that somehow. > > If I

Re: [PATCH] Fixed most indent issues in tty_io.c

2019-09-07 Thread Joe Perches
On Sat, 2019-09-07 at 11:09 +0200, volery wrote: > There were a lot of styling problems using space then tab or spaces > instead of tabs in that file. Especially the entire function at line > 2677. > Also added a space before the : on line 2221. You do not have an appropriate subject line. This

Re: [PATCH] Fixed most indent issues in tty_io.c

2019-09-07 Thread Joe Perches
On Sat, 2019-09-07 at 21:51 +0200, Sandro Volery wrote: > > On 7 Sep 2019, at 21:27, Joe Perches wrote: [] > > As long as git diff -w shows no difference and a compiled > > object comparison before and after the change shows no > > difference, I think it's fine. > > My thoughts, too. I didn't

Re: [PATCH v3 0/6] ARM: dts: mmp2: devicetree updates

2019-09-07 Thread Arnd Bergmann
On Sat, Sep 7, 2019 at 9:40 PM Pavel Machek wrote: > > > > Here's a couple of updates for the MMP2 SoC devicetree files. > > I'm wondering if they could be applied to the armsoc tree? > > > > Compared to previous submission, the only change is the addition of > > Acks from Pavel. > > Any news

Re: [patch for-5.3 0/4] revert immediate fallback to remote hugepages

2019-09-07 Thread Linus Torvalds
On Sat, Sep 7, 2019 at 12:51 PM David Rientjes wrote: > > Andrea acknowledges the swap storm that he reported would be fixed with > the last two patches in this series The problem is that even you aren't arguing that those patches should go into 5.3. So those fixes aren't going in, so "the swap

Re: [PATCH] Fixed most indent issues in tty_io.c

2019-09-07 Thread Sandro Volery
> On 7 Sep 2019, at 21:27, Joe Perches wrote: > > On Sat, 2019-09-07 at 18:42 +0100, Greg KH wrote: >>> On Sat, Sep 07, 2019 at 07:35:42PM +0200, Sandro Volery wrote: >>> >> On 7 Sep 2019, at 19:29, Greg KH wrote: > On Sat, Sep 07, 2019 at 07:23:59PM +0200, Sandro Volery wrote:

Re: [patch for-5.3 0/4] revert immediate fallback to remote hugepages

2019-09-07 Thread David Rientjes
Is there any objection from anybody to applying the first two patches, the reverts of the reverts that went into 5.3-rc5, for 5.3 and pursuing discussion and development using the last two patches in this series as a starting point for a sane allocation policy that just works by default for

Re: [PATCH 2/2] ipc: fix sparc64 ipc() wrapper

2019-09-07 Thread Arnd Bergmann
On Thu, Sep 5, 2019 at 5:24 PM Arnd Bergmann wrote: > diff --git a/arch/sparc/kernel/sys_sparc_64.c > b/arch/sparc/kernel/sys_sparc_64.c > index ccc88926bc00..5ad0494df367 100644 > --- a/arch/sparc/kernel/sys_sparc_64.c > +++ b/arch/sparc/kernel/sys_sparc_64.c > @@ -340,21 +340,21 @@

Re: [PATCH v3 0/6] ARM: dts: mmp2: devicetree updates

2019-09-07 Thread Pavel Machek
> Here's a couple of updates for the MMP2 SoC devicetree files. > I'm wondering if they could be applied to the armsoc tree? > > Compared to previous submission, the only change is the addition of > Acks from Pavel. Any news here? Having up-to-date dts is kind-of useful Best regards,

Re: Linux 5.3-rc7

2019-09-07 Thread Linus Torvalds
On Sat, Sep 7, 2019 at 12:17 PM Linus Torvalds wrote: > > I'm really not clear on why it's a good idea to clear the LDR bits on > shutdown, and commit 558682b52919 ("x86/apic: Include the LDR when > clearing out APIC registers") just looks pointless. And now it has > proven to break some

Re: [PATCH] Fixed most indent issues in tty_io.c

2019-09-07 Thread Joe Perches
On Sat, 2019-09-07 at 18:42 +0100, Greg KH wrote: > On Sat, Sep 07, 2019 at 07:35:42PM +0200, Sandro Volery wrote: > > > > > > > On 7 Sep 2019, at 19:29, Greg KH wrote: > > > > On Sat, Sep 07, 2019 at 07:23:59PM +0200, Sandro Volery wrote: > > > > Dear Greg, > > > > I am pretty sure the issue

Re: [PATCH 2/2] staging: exfat: cleanup spacing for casts

2019-09-07 Thread Joe Perches
On Sat, 2019-09-07 at 18:58 +, Valentin Vidic wrote: > Fixes checkpatch.pl warnings: > > CHECK: No space is necessary after a cast Please always try to improve the code rather than shutup checkpatch warnings. > diff --git a/drivers/staging/exfat/exfat_core.c >

Re: Linux 5.3-rc7

2019-09-07 Thread Linus Torvalds
On Sat, Sep 7, 2019 at 8:00 AM Thomas Gleixner wrote: > > Ok let me find a testbox to figure out whats wrong there. Honestly, it looks like we should just revert that commit, since we never used to clear the LDR bits before either, and the bug it "fixes" doesn't really seem to be a bug (well,

Re: [PATCH] usb: storage: Add ums-cros-aoa driver

2019-09-07 Thread Alan Stern
On Fri, 6 Sep 2019, Julius Werner wrote: > FWIW, I found a suitable workaround now to get my use case working > with existing kernels: I can do the mode switch from userspace, then > after the device reenumerates I can manually disable any interfaces I > don't like by writing 0 to their

Re: [PATCH v2] KEYS: trusted: correctly initialize digests and fix locking issue

2019-09-07 Thread Jarkko Sakkinen
On Sat, 2019-09-07 at 22:02 +0300, Jarkko Sakkinen wrote: > On Wed, 2019-09-04 at 20:50 +0200, Roberto Sassu wrote: > > This patch fixes two issues introduced with commit 0b6cf6b97b7e ("tpm: pass > > an array of tpm_extend_digest structures to tpm_pcr_extend()"). > > > > It initializes the

Re: [PATCH v2] KEYS: trusted: correctly initialize digests and fix locking issue

2019-09-07 Thread Jarkko Sakkinen
On Wed, 2019-09-04 at 20:50 +0200, Roberto Sassu wrote: > This patch fixes two issues introduced with commit 0b6cf6b97b7e ("tpm: pass > an array of tpm_extend_digest structures to tpm_pcr_extend()"). > > It initializes the algorithm in init_digests() for trusted keys, and moves > the algorithm

[PATCH 1/2] staging: exfat: cleanup spacing for operators

2019-09-07 Thread Valentin Vidic
Fixes checkpatch.pl warnings: CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '*' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) Signed-off-by: Valentin Vidic ---

[PATCH 2/2] staging: exfat: cleanup spacing for casts

2019-09-07 Thread Valentin Vidic
Fixes checkpatch.pl warnings: CHECK: No space is necessary after a cast Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat_core.c | 88 ++--- drivers/staging/exfat/exfat_super.c | 66 +++--- 2 files changed, 77 insertions(+), 77

Re: [PATCH AUTOSEL 4.19 126/167] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

2019-09-07 Thread Jarkko Sakkinen
On Tue, 2019-09-03 at 15:43 -0400, Sasha Levin wrote: > Right. I gave a go at backporting a few patches and this happens to be > one of them. It will be a while before it goes in a stable tree > (probably way after after LPC). It *semantically* depends on db4d8cb9c9f2 ("tpm: use

Re: [PATCH net-next] netfilter: nf_tables: avoid excessive stack usage

2019-09-07 Thread Pablo Neira Ayuso
On Sat, Sep 07, 2019 at 08:41:22PM +0200, Arnd Bergmann wrote: > On Sat, Sep 7, 2019 at 8:07 PM Pablo Neira Ayuso wrote: > > > > Hi Arnd, > > > > On Fri, Sep 06, 2019 at 05:12:30PM +0200, Arnd Bergmann wrote: > > > The nft_offload_ctx structure is much too large to put on the > > > stack: > > > >

Re: [PATCH] VMCI: Release resource if the work is already queued

2019-09-07 Thread Greg Kroah-Hartman
On Tue, Aug 20, 2019 at 01:26:38PM -0700, Nadav Amit wrote: > Francois reported that VMware balloon gets stuck after a balloon reset, > when the VMCI doorbell is removed. A similar error can occur when the > balloon driver is removed with the following splat: Note, google thinks your email is

Re: [PATCH] nvme: Restore device naming sanity

2019-09-07 Thread Chaitanya Kulkarni
Apart from the some nits, this looks okay. Reviewed-by: Chaitanya Kulkarni May be subject line should be 's/nvme/nvme-core/' ? On 09/04/2019 10:34 AM, Keith Busch wrote: > The namespace names must be unique for the lifetime of the subsystem. > This was accomplished by using their parent

Re: [PATCH net-next] netfilter: nf_tables: avoid excessive stack usage

2019-09-07 Thread Arnd Bergmann
On Sat, Sep 7, 2019 at 8:07 PM Pablo Neira Ayuso wrote: > > Hi Arnd, > > On Fri, Sep 06, 2019 at 05:12:30PM +0200, Arnd Bergmann wrote: > > The nft_offload_ctx structure is much too large to put on the > > stack: > > > > net/netfilter/nf_tables_offload.c:31:23: error: stack frame size of 1200 >

[GIT PULL] Char/Misc driver fixes for 5.3-rc8

2019-09-07 Thread Greg KH
The following changes since commit 089cf7f6ecb266b6a4164919a2e69bd2f938374a: Linux 5.3-rc7 (2019-09-02 09:57:40 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git tags/char-misc-5.3-rc8 for you to fetch changes up to

Re: [PATCH] Fixed most indent issues in tty_io.c

2019-09-07 Thread Sandro Volery LKML
Sandro V > On 7 Sep 2019, at 20:03, Greg KH wrote: > > On Sat, Sep 07, 2019 at 07:49:43PM +0200, Sandro Volery wrote: >> >> >> >> On 7 Sep 2019, at 19:42, Greg KH wrote: >>> >>> On Sat, Sep 07, 2019 at 07:35:42PM +0200, Sandro Volery wrote: On 7 Sep 2019, at

Re: [PATCH v2 1/3] software node: implement reference properties

2019-09-07 Thread Dmitry Torokhov
On Sat, Sep 07, 2019 at 09:03:48PM +0300, Andy Shevchenko wrote: > On Sat, Sep 07, 2019 at 10:37:24AM -0700, Dmitry Torokhov wrote: > > On Sat, Sep 07, 2019 at 08:12:51PM +0300, Andy Shevchenko wrote: > > > On Sat, Sep 07, 2019 at 09:32:40AM -0700, Dmitry Torokhov wrote: > > > > On Sat, Sep 07,

Re: [PATCH 2/2] tools/power/x86/intel-speed-select: Display core count for bucket

2019-09-07 Thread Andy Shevchenko
On Fri, Sep 6, 2019 at 10:47 PM Srinivas Pandruvada wrote: > > On Fri, 2019-09-06 at 07:50 -0700, Srinivas Pandruvada wrote: > > On Fri, 2019-09-06 at 16:46 +0300, Andy Shevchenko wrote: > > > On Fri, Sep 06, 2019 at 05:39:54AM -0400, Prarit Bhargava wrote: > > > > On 9/5/19 7:37 PM, Srinivas

Re: [PATCH v2 0/9] tools-power-x86-intel-speed-select: Fixes and updates for output

2019-09-07 Thread Andy Shevchenko
On Fri, Sep 6, 2019 at 10:58 AM Srinivas Pandruvada wrote: > > On Thu, 2019-09-05 at 08:03 -0400, Prarit Bhargava wrote: > > Some general fixes and updates for intel-speed-select. Fixes include > > some > > typos as well as an off-by-one cpu count reporting error. Updates > > for the > > output

Re: [PATCH net-next] netfilter: nf_tables: avoid excessive stack usage

2019-09-07 Thread Pablo Neira Ayuso
Hi Arnd, On Fri, Sep 06, 2019 at 05:12:30PM +0200, Arnd Bergmann wrote: > The nft_offload_ctx structure is much too large to put on the > stack: > > net/netfilter/nf_tables_offload.c:31:23: error: stack frame size of 1200 > bytes in function 'nft_flow_rule_create' [-Werror,-Wframe-larger-than=]

Re: [PATCH v2 1/3] software node: implement reference properties

2019-09-07 Thread Andy Shevchenko
On Sat, Sep 07, 2019 at 10:37:24AM -0700, Dmitry Torokhov wrote: > On Sat, Sep 07, 2019 at 08:12:51PM +0300, Andy Shevchenko wrote: > > On Sat, Sep 07, 2019 at 09:32:40AM -0700, Dmitry Torokhov wrote: > > > On Sat, Sep 07, 2019 at 07:08:19PM +0300, Andy Shevchenko wrote: > > > > On Fri, Sep 06,

Re: [PATCH] Fixed most indent issues in tty_io.c

2019-09-07 Thread Greg KH
On Sat, Sep 07, 2019 at 07:49:43PM +0200, Sandro Volery wrote: > > > > > > On 7 Sep 2019, at 19:42, Greg KH wrote: > > > > On Sat, Sep 07, 2019 at 07:35:42PM +0200, Sandro Volery wrote: > >> > >> > >> On 7 Sep 2019, at 19:29, Greg KH wrote: > > On Sat, Sep 07, 2019 at 07:23:59PM

Re: [PATCH] Fixed most indent issues in tty_io.c

2019-09-07 Thread Sandro Volery
> On 7 Sep 2019, at 19:42, Greg KH wrote: > > On Sat, Sep 07, 2019 at 07:35:42PM +0200, Sandro Volery wrote: >> >> >> On 7 Sep 2019, at 19:29, Greg KH wrote: > On Sat, Sep 07, 2019 at 07:23:59PM +0200, Sandro Volery wrote: > Dear Greg, > I am pretty sure the issue was,

[PATCH] arm64: dts: rockchip: add analog audio nodes on rk3399-rockpro64

2019-09-07 Thread Katsuhiro Suzuki
This patch adds audio codec (Everest ES8316) and I2S audio nodes for RK3399 RockPro64. Signed-off-by: Katsuhiro Suzuki --- .../boot/dts/rockchip/rk3399-rockpro64.dts| 28 +++ 1 file changed, 28 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts

[PATCH 1/4] cpufreq: ti-cpufreq: add support for omap34xx and omap36xx

2019-09-07 Thread H. Nikolaus Schaller
This adds code and tables to read the silicon revision and eFuse (speed binned / 720 MHz grade) bits for selecting opp-v2 table entries. Since these bits are not always part of the syscon register range (like for am33xx, am43, dra7), we add code to directly read the register values using

[PATCH 4/4] DTS: bindings: omap: update bindings documentation

2019-09-07 Thread H. Nikolaus Schaller
* clarify that we now need either "ti,omap3430" or "ti,omap3630" or "ti,am3517" for omap3 chips * clarify that "ti,omap3" has no default * clarify that AM33x is not an "ti,omap3" * clarify that the list of boards is incomplete * remove some "ti,am33xx", "ti,omap3" * add some missing "ti,omap4"

[PATCH 2/4] ARM: dts: replace opp-v1 tables by opp-v2 for omap34xx and omap36xx

2019-09-07 Thread H. Nikolaus Schaller
In addition, move omap3 from whitelist to blacklist in cpufreq-dt-platdev in the same patch, because doing either first breaks operation and may make trouble in bisect. We also can remove opp-v1 table for omap3-n950-n9 since it is now automatically detected. We also fix a wrong OPP4 voltage for

[PATCH 3/4] ARM: dts: omap3: bulk convert compatible to be explicitly ti,omap3430 or ti,omap3630 or ti,am3517

2019-09-07 Thread H. Nikolaus Schaller
For the ti-cpufreq driver we need a clear separation between omap34 and omap36 families since they have different silicon revisions and efuses. So far ti,omap3630/ti,omap36xx is just an additional flag to ti,omap3 while omap34 has no required entry. Therefore we can not match omap34 boards

[PATCH 0/4] OMAP3: convert opp-v1 to opp-v2 and read speed binned / 720MHz grade bits

2019-09-07 Thread H. Nikolaus Schaller
Changes V2: * fix ti-cpufreq to properly describe what compatible string is legacy * add some reviewed-by and acked-by Tony Lindgren PATCH V1 2019-09-07 08:56:19: * fix typo in omap3-ldp.dts (reported by Tony Lindgren ) * extend commit message to describe the bit patterns needed for

[PATCH] SoC: simple-card-utils: set 0Hz to sysclk when shutdown

2019-09-07 Thread Katsuhiro Suzuki
This patch set 0Hz to sysclk when shutdown the card. Some codecs set rate constraints that derives from sysclk. This mechanism works correctly if machine drivers give fixed frequency. But simple-audio and audio-graph card set variable clock rate if 'mclk-fs' property exists. In this case, rate

Re: [PATCH 2/2] platform/x86: intel_int0002_vgpio: Use device_init_wakeup

2019-09-07 Thread Andy Shevchenko
On Fri, Aug 23, 2019 at 8:48 PM Hans de Goede wrote: > > Use device_init_wakeup and pm_wakeup_hard_event instead of directly > calling pm_system_wakeup(). This is the preferred way to do this and > this will allow the user to disable wakeup through INT0002 events > through sysfs. > Pushed to my

[PATCH] ASoC: rockchip: ignore 0Hz sysclk

2019-09-07 Thread Katsuhiro Suzuki
This patch ignores sysclk setting if it is 0Hz. Some codecs treat 0Hz sysclk as signal of applying no constraints. This driver does not have such feature but current implementation outputs 'Failed to set mclk' error message if machine driver sets 0Hz sysclk to this driver. Signed-off-by:

Re: [PATCH] Fixed most indent issues in tty_io.c

2019-09-07 Thread Greg KH
On Sat, Sep 07, 2019 at 07:35:42PM +0200, Sandro Volery wrote: > > > >>> On 7 Sep 2019, at 19:29, Greg KH wrote: > >> On Sat, Sep 07, 2019 at 07:23:59PM +0200, Sandro Volery wrote: > >> Dear Greg, > >> I am pretty sure the issue was, that I did too many things at once. > >> However, all the

  1   2   3   >