linux-next: Fixes tag needs some work in the sound-asoc-fixes tree

2020-05-13 Thread Stephen Rothwell
Hi all, In commit 0e36f32f6b6c ("ASoC: tlv320adcx140: Fix bias config values") Fixes tag Fixes: 37bde5acf040 ("ASoC: tlv320adcx140: Add the tlv320adcx140 codec has these problem(s): - Target SHA1 does not exist Mabe you meant Fixes: 689c7655b50c ("ASoC: tlv320adcx140: Add the tlv320ad

Re: [patch V4 part 1 05/36] x86/entry: Flip _TIF_SIGPENDING and _TIF_NOTIFY_RESUME handling

2020-05-13 Thread Steven Rostedt
On Wed, 13 May 2020 16:56:41 -0400 (EDT) Mathieu Desnoyers wrote: > - On May 5, 2020, at 9:16 AM, Thomas Gleixner t...@linutronix.de wrote: > > > Make sure task_work runs before any kind of userspace -- very much > > including signals -- is invoked. > > What is missing from this patch des

Re: [PATCH v2] video: fbdev: ssd1307fb: Added support to Column offset

2020-05-13 Thread kbuild test robot
10137 base:e098d7762d602be640c53565ceca342f81e55ad2 config: parisc-randconfig-r022-20200513 (attached as .config) compiler: hppa-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/

Re: [PATCH v7 RESEND 13/13] dmaengine: imx-sdma: add uart rom script

2020-05-13 Thread Fabio Estevam
Hi Robin, On Mon, May 11, 2020 at 6:33 AM Robin Gong wrote: > Please get latest sdma firmware from the below and put them into the path > (/lib/firmware/imx/sdma/): > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git > /tree/imx/sdma "latest sdma firmware" is too vague

Re: [PATCH] perf tools: Replace zero-length array with flexible-array

2020-05-13 Thread Ian Rogers
On Tue, May 12, 2020 at 10:59 AM Gustavo A. R. Silva wrote: > > On Tue, May 12, 2020 at 10:06:07AM +0200, Peter Zijlstra wrote: > > On Mon, May 11, 2020 at 07:04:04PM -0500, Gustavo A. R. Silva wrote: > > > On Mon, May 11, 2020 at 05:20:08PM -0300, Arnaldo Melo wrote: > > > > > > > > Thanks, appli

Re: [PATCH 1/2] IB/sa: Resolving use-after-free in ib_nl_send_msg.

2020-05-13 Thread Divya Indi
Hi Jason, Please find my comments inline - On 5/13/20 8:00 AM, Jason Gunthorpe wrote: > On Mon, May 11, 2020 at 02:26:30PM -0700, Divya Indi wrote: @@ -1123,6 +1156,18 @@ int ib_nl_handle_resolve_resp(struct sk_buff *skb, send_buf = query->mad_buf; + /* +

Re: [PATCH 4.19 35/48] batman-adv: Fix refcnt leak in batadv_store_throughput_override

2020-05-13 Thread Pavel Machek
Hi! > From: Xiyu Yang > > commit 6107c5da0fca8b50b4d3215e94d619d38cc4a18c upstream. > > batadv_show_throughput_override() invokes batadv_hardif_get_by_netdev(), > which gets a batadv_hard_iface object from net_dev with increased refcnt > and its reference is assigned to a local pointer 'hard_if

Re: [PATCH 20/33] ipv4: add ip_sock_set_recverr

2020-05-13 Thread Joe Perches
On Wed, 2020-05-13 at 08:26 +0200, Christoph Hellwig wrote: > Add a helper to directly set the IP_RECVERR sockopt from kernel space > without going through a fake uaccess. This seems used only with true as the second arg. Is there reason to have that argument at all? > diff --git a/include/net/ip

Re: [PATCH V5 1/5] rpmsg: glink: Use complete_all for open states

2020-05-13 Thread Mathieu Poirier
Hi Arun, On Wed, May 13, 2020 at 10:40:02AM +0530, Arun Kumar Neelakantam wrote: > From: Chris Lew > > The open_req and open_ack completion variables are the state variables > to represet a remote channel as open. Use complete_all so there are no s/represet/represent > races with waiters and u

Re: [RFC PATCH] arm: Don't trap conditional UDF instructions

2020-05-13 Thread Robin Murphy
On 2020-05-13 7:56 pm, Fredrik Strupe wrote: On 13.05.2020 20:12, Russell King - ARM Linux admin wrote: On Wed, May 13, 2020 at 05:41:58PM +0200, Fredrik Strupe wrote: Hi, This is more of a question than a patch, but I hope the attached patch makes the issue a bit clearer. The arm port of Lin

Re: [patch V4 part 1 05/36] x86/entry: Flip _TIF_SIGPENDING and _TIF_NOTIFY_RESUME handling

2020-05-13 Thread Mathieu Desnoyers
- On May 5, 2020, at 9:16 AM, Thomas Gleixner t...@linutronix.de wrote: > Make sure task_work runs before any kind of userspace -- very much > including signals -- is invoked. What is missing from this patch description is: _why_ is this deemed useful ? Also, color me confused: is "do_signal

Re: [PATCH v3 1/2] timer: make deferrable cpu unbound timers really not bound to a cpu

2020-05-13 Thread psodagud
On 2020-05-13 13:28, Thomas Gleixner wrote: psoda...@codeaurora.org writes: On 2020-05-06 06:28, Thomas Gleixner wrote: #ifdef CONFIG_SMP +struct timer_base timer_base_deferrable; unsigned int sysctl_timer_migration = 1; DEFINE_STATIC_KEY_FALSE(timers_migration_enabled); @@ -841,8 +842,14 @

Re: [PATCH] kobject: Make sure the parent does not get released before its children

2020-05-13 Thread Randy Dunlap
On 5/13/20 1:18 PM, Brendan Higgins wrote: > On Wed, May 13, 2020 at 8:18 AM Heikki Krogerus > wrote: >> >> In the function kobject_cleanup(), kobject_del(kobj) is >> called before the kobj->release(). That makes it possible to >> release the parent of the kobject before the kobject itself. >> >>

Re: [PATCH net-next v3] net: phy: at803x: add cable diagnostics support

2020-05-13 Thread David Miller
From: Michael Walle Date: Wed, 13 May 2020 22:38:07 +0200 > The AR8031/AR8033 and the AR8035 support cable diagnostics. Adding > driver support is straightforward, so lets add it. > > The PHY just do one pair at a time, so we have to start the test four > times. The cable_test_get_status() can b

[PATCH] USB: dummy-hcd: use configurable endpoint naming scheme

2020-05-13 Thread Andrey Konovalov
From: Andrey Konovalov USB gadget subsystem uses the following naming convention for UDC endpoints: - "ep-a" names for fully configurable endpoints (address, direction and transfer type can be changed); - "ep1in", "ep12out-bulk" names for fixed function endpoints (fixed address, direction a

[PATCH] ia64: enable HAVE_COPY_THREAD_TLS, switch to kernel_clone_args

2020-05-13 Thread Christian Brauner
This is part of a larger series that aims at getting rid of the copy_thread()/copy_thread_tls() split that makes the process creation codepaths in the kernel more convoluted and error-prone than they need to be. I'm converting all the remaining arches that haven't yet switched and am collecting ind

Re: [PATCH net-next v3] net: phy: at803x: add cable diagnostics support

2020-05-13 Thread Florian Fainelli
On 5/13/2020 1:38 PM, Michael Walle wrote: > The AR8031/AR8033 and the AR8035 support cable diagnostics. Adding > driver support is straightforward, so lets add it. > > The PHY just do one pair at a time, so we have to start the test four > times. The cable_test_get_status() can block and there

[PATCH net-next v3] net: phy: at803x: add cable diagnostics support

2020-05-13 Thread Michael Walle
The AR8031/AR8033 and the AR8035 support cable diagnostics. Adding driver support is straightforward, so lets add it. The PHY just do one pair at a time, so we have to start the test four times. The cable_test_get_status() can block and therefore we can just busy poll the test completion and conti

Re: [PATCH v2 2/2] perf test: Improve pmu event metric testing

2020-05-13 Thread Ian Rogers
On Wed, May 13, 2020 at 8:39 AM Arnaldo Carvalho de Melo wrote: > > Em Tue, May 12, 2020 at 11:27:52PM -0700, Ian Rogers escreveu: > > Break pmu-events test into 2 and add a test to verify that all pmu metric > > expressions simply parse. Try to parse all metric ids/events, warning if > > metrics

Re: [PATCH v3 1/2] timer: make deferrable cpu unbound timers really not bound to a cpu

2020-05-13 Thread Thomas Gleixner
psoda...@codeaurora.org writes: > On 2020-05-06 06:28, Thomas Gleixner wrote: >>> #ifdef CONFIG_SMP >>> +struct timer_base timer_base_deferrable; >>> unsigned int sysctl_timer_migration = 1; >>> >>> DEFINE_STATIC_KEY_FALSE(timers_migration_enabled); >>> @@ -841,8 +842,14 @@ static inline struct

Re: [PATCH v2] uapi, posix-timers: provide clockid-related macros and functions to UAPI

2020-05-13 Thread Sergey Organov
John Stultz writes: > On Wed, May 13, 2020 at 2:13 AM Sergey Organov wrote: >> >> John Stultz writes: >> >> > On Tue, May 12, 2020 at 3:31 PM Eugene Syromiatnikov >> > wrote: >> >> On Tue, May 12, 2020 at 10:58:16PM +0300, Sergey Organov wrote: >> >> > Eugene Syromiatnikov writes: >> >> > >>

Re: [PATCH] arm64: dts: qcom: msm8916: Disable coresight by default

2020-05-13 Thread Jeffrey Hugo
On Wed, May 13, 2020 at 12:50 PM wrote: > > From: Michael Srba > > On some msm8916 devices, attempts at initializing coresight cause the boot to > fail. This was fixed by disabling the coresight-related nodes in the board dts > files. However, a cleaner approach was chosen for fixing the same iss

Re: [PATCH] kobject: Make sure the parent does not get released before its children

2020-05-13 Thread Brendan Higgins
On Wed, May 13, 2020 at 8:18 AM Heikki Krogerus wrote: > > In the function kobject_cleanup(), kobject_del(kobj) is > called before the kobj->release(). That makes it possible to > release the parent of the kobject before the kobject itself. > > To fix that, adding function __kboject_del() that doe

Re: [PATCH v3 0/6] allow ramoops to collect all kmesg_dump events

2020-05-13 Thread Kees Cook
On Wed, May 13, 2020 at 10:35:16AM -0400, Pavel Tatashin wrote: > > > + reason: panic, oops, emergency, shutdown(ordered by severity) > > > + handling: restart, halt, poweroff > > > > > > Or we might just replace KMSG_DUMP_RESTART, KMSG_DUMP_HALT, > > > KMSG_DUMP_POWEROFF with a single KMSG

[PATCH v2 2/3] ASoC: tlv320adcx140: Add device tree property for PDM edges

2020-05-13 Thread Dan Murphy
Add a device tree property to configure the PDM sampling edge for each digital microphone. CC: Rob Herring Signed-off-by: Dan Murphy --- .../devicetree/bindings/sound/tlv320adcx140.yaml | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/sound

[PATCH v2 3/3] ASoC: tlv320adcx140: Configure PDM sampling edge

2020-05-13 Thread Dan Murphy
Configure the PDM sampling edges based on the values from the firmware. Signed-off-by: Dan Murphy --- sound/soc/codecs/tlv320adcx140.c | 22 ++ sound/soc/codecs/tlv320adcx140.h | 3 +++ 2 files changed, 25 insertions(+) diff --git a/sound/soc/codecs/tlv320adcx140.c b/sound/

[PATCH v2 1/3] ASoC: tlv320adcx140: Add controls for PDM clk

2020-05-13 Thread Dan Murphy
Add ALSA controls to configure the PDM clocks. The clocks need to be configurable to accommodate various microphones that use clocks for low power/low resolution modes to high power/high resolution modes. Signed-off-by: Dan Murphy --- sound/soc/codecs/tlv320adcx140.c | 19 +++ 1

[PATCH] drivers/virt/fsl_hypervisor: Correcting error handling path

2020-05-13 Thread Souptick Joarder
First, when memory allocation for sg_list_unaligned failed, there is no point of calling put_pages() as we haven't pinned any pages. Second, if get_user_pages_fast() failed we should unpinned num_pinned pages, no point of checking till num_pages. This will address both. Signed-off-by: Souptick J

[PATCH] ath11k: Fix some resource leaks in error path in 'ath11k_thermal_register()'

2020-05-13 Thread Christophe JAILLET
If 'thermal_cooling_device_register()' fails, we must undo what has been allocated so far. So we must go to 'err_thermal_destroy' instead of returning directly In case of error in 'ath11k_thermal_register()', the previous 'thermal_cooling_device_register()' call must also be undone. Move the 'ar->

[PATCH] drm/vblank: remove outdated and noisy output

2020-05-13 Thread Wolfram Sang
The R-Car DU driver calls drm_vblank_init via some helper functions in probe(). From what I checked, most drivers do this as well. I have a config now where DU always stays in deferred_probe state because of a missing dependency. This means that every time I rebind another driver like MMC, the vbla

Re: [PATCH] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-13 Thread Jonas Falkevik
On Wed, May 13, 2020 at 6:01 PM Marcelo Ricardo Leitner wrote: > > On Wed, May 13, 2020 at 04:52:16PM +0200, Jonas Falkevik wrote: > > Do not generate SCTP_ADDR_{MADE_PRIM,ADDED} events for SCTP_FUTURE_ASSOC > > assocs. > > How did you get them? > I think one case is when receiving INIT chunk in

Re: [PATCH] HID: sony: Fix for broken buttons on DS3 USB dongles

2020-05-13 Thread Scott Shumate
Hi Roderick, The official DS3 has a Report Count(19) instead of Report Count(13) in the exact same offset. I have no idea what the silicon vendor for these dongles was thinking but it's suspicious that the official count of 19 (0x13) turned into 13 (0xd) in the knock-off. It makes you wonder

RE: [PATCH v2 10/10] cacheinfo: Move resctrl's get_cache_id() to the cacheinfo header file

2020-05-13 Thread Babu Moger
> -Original Message- > From: James Morse > Sent: Thursday, April 30, 2020 12:04 PM > To: x...@kernel.org; linux-kernel@vger.kernel.org > Cc: Fenghua Yu ; Reinette Chatre > ; Thomas Gleixner ; Ingo > Molnar ; Borislav Petkov ; H Peter Anvin > ; Moger, Babu ; James Morse > > Subject: [PA

RE: [PATCH v2 09/10] x86/resctrl: Add arch_has_sparse_bitmaps to explain AMD/Intel CAT difference

2020-05-13 Thread Babu Moger
> -Original Message- > From: Reinette Chatre > Sent: Monday, May 11, 2020 1:15 PM > To: James Morse ; x...@kernel.org; linux- > ker...@vger.kernel.org > Cc: Fenghua Yu ; Thomas Gleixner > ; Ingo Molnar ; Borislav Petkov > ; H Peter Anvin ; Moger, Babu > > Subject: Re: [PATCH v2 09/10]

RE: [PATCH v2 00/10] x86/resctrl: Misc cleanup

2020-05-13 Thread Babu Moger
Hi James, Patches all look good. Tested on AMD platform and working as expected. Reviewed-by: Babu Moger Thanks > -Original Message- > From: James Morse > Sent: Thursday, April 30, 2020 12:04 PM > To: x...@kernel.org; linux-kernel@vger.kernel.org > Cc: Fenghua Yu ; Reinette Chatre > ;

Re: [PATCH] [v2] ubsan, kcsan: don't combine sanitizer with kcov on clang

2020-05-13 Thread Paul E. McKenney
On Thu, May 07, 2020 at 06:25:31PM +0200, Arnd Bergmann wrote: > Clang does not allow -fsanitize-coverage=trace-{pc,cmp} together > with -fsanitize=bounds or with ubsan: > > clang: error: argument unused during compilation: > '-fsanitize-coverage=trace-pc' [-Werror,-Wunused-command-line-argument]

Re: [regression] TC_MD5SIG on established sockets

2020-05-13 Thread Eric Dumazet
On Wed, May 13, 2020 at 12:49 PM Eric Dumazet wrote: > > I do not think we want to transition sockets in the middle. since > packets can be re-ordered in the network. > > MD5 is about security (and a loose form of it), so better make sure > all packets have it from the beginning of the flow. > > A

Re: [PATCH stable-5.4.y] net: dsa: Do not make user port errors fatal

2020-05-13 Thread David Miller
From: Florian Fainelli Date: Wed, 13 May 2020 10:41:45 -0700 > commit 86f8b1c01a0a537a73d2996615133be63cdf75db upstream > > Prior to 1d27732f411d ("net: dsa: setup and teardown ports"), we would > not treat failures to set-up an user port as fatal, but after this > commit we would, which is a re

Re: [PATCH 14/18] maccess: allow architectures to provide kernel probing directly

2020-05-13 Thread Christoph Hellwig
On Wed, May 13, 2020 at 12:48:54PM -0700, Linus Torvalds wrote: > Looking at the current users of "probe_kernel_read()", it looks like > it's almost mostly things that just want a single byte or word. > > It's not 100% that: we definitely do several things that want the > "copy" semantics vs the "

Re: [PATCH net-next v2] net: phy: at803x: add cable diagnostics support

2020-05-13 Thread David Miller
From: Michael Walle Date: Wed, 13 May 2020 18:12:52 +0200 > The AR8031/AR8033 and the AR8035 support cable diagnostics. Adding > driver support is straightforward, so lets add it. > > The PHY just do one pair at a time, so we have to start the test four > times. The cable_test_get_status() can b

Re: [PATCH 3/5] exec: Remove recursion from search_binary_handler

2020-05-13 Thread Linus Torvalds
On Tue, May 12, 2020 at 7:32 PM Rob Landley wrote: > > On 5/12/20 7:20 PM, Linus Torvalds wrote: > > Ack. I think the AT_EXECFD thing is a sign that this isn't internal to > > binfmt_misc, but it also shouldn't be gating this issue. In reality, > > ELF is the only real binary format that matters -

Re: [PATCH net-next 0/4] net: phy: broadcom: cable tester support

2020-05-13 Thread David Miller
From: Michael Walle Date: Wed, 13 May 2020 18:35:20 +0200 > Add cable tester support for the Broadcom PHYs. Support for it was > developed on a BCM54140 Quad PHY which RDB register access. > > If there is a link partner the results are not as good as with an open > cable. I guess we could retry

Re: [regression] TC_MD5SIG on established sockets

2020-05-13 Thread Eric Dumazet
I do not think we want to transition sockets in the middle. since packets can be re-ordered in the network. MD5 is about security (and a loose form of it), so better make sure all packets have it from the beginning of the flow. A flow with TCP TS on can not suddenly be sending packets without TCP

Re: [PATCH net v2] net: broadcom: Select BROADCOM_PHY for BCMGENET

2020-05-13 Thread David Miller
From: Florian Fainelli Date: Wed, 13 May 2020 08:51:51 -0700 > The GENET controller on the Raspberry Pi 4 (2711) is typically > interfaced with an external Broadcom PHY via a RGMII electrical > interface. To make sure that delays are properly configured at the PHY > side, ensure that we the dedic

Re: [PATCH 14/18] maccess: allow architectures to provide kernel probing directly

2020-05-13 Thread Linus Torvalds
On Wed, May 13, 2020 at 12:40 PM Christoph Hellwig wrote: > > We do export something like it, currently it is called > probe_kernel_address, and the last patch renames it to > get_kernel_nofault. However it is implemented as a wrapper > around probe_kernel_address / copy_from_kernel_nofault and t

Re: [PATCH 7/9] fs/ext4: Make DAX mount option a tri-state

2020-05-13 Thread Ira Weiny
On Wed, May 13, 2020 at 11:17:17AM -0700, Darrick J. Wong wrote: > On Wed, May 13, 2020 at 04:35:26PM +0200, Jan Kara wrote: > > On Tue 12-05-20 22:43:22, ira.we...@intel.com wrote: > > > From: Ira Weiny > > > > > > We add 'always', 'never', and 'inode' (default). '-o dax' continue to > > > oper

Re: [PATCH v3 1/2] timer: make deferrable cpu unbound timers really not bound to a cpu

2020-05-13 Thread psodagud
Hi Tglx, On 2020-05-06 06:28, Thomas Gleixner wrote: Prasad Sodagudi writes: To make all cpu unbound deferrable timers are scalable, introduce a common timer base which is only for cpu unbound deferrable timers to make those are indeed cpu unbound so that can be scheduled by any of non idle

Re: [PATCH v10 1/5] usb: xhci: Change the XHCI link order in the Makefile

2020-05-13 Thread Alan Cooper
On Wed, May 13, 2020 at 1:46 PM Florian Fainelli wrote: > > > > On 5/13/2020 10:39 AM, Alan Stern wrote: > > On Wed, May 13, 2020 at 07:05:05PM +0200, Greg Kroah-Hartman wrote: > >> On Wed, May 13, 2020 at 09:31:11AM -0700, Florian Fainelli wrote: > >>> > >>> > >>> On 5/13/2020 9:27 AM, Greg Kroah

Re: [PATCH v5 1/7] fs: introduce kernel_pread_file* support

2020-05-13 Thread Scott Branden
On 2020-05-13 12:39 p.m., Mimi Zohar wrote: On Wed, 2020-05-13 at 12:18 -0700, Scott Branden wrote: On 2020-05-13 12:03 p.m., Mimi Zohar wrote: On Wed, 2020-05-13 at 11:53 -0700, Scott Branden wrote: Even if the kernel successfully verified the firmware file signature it would just be wasti

Re: [PATCH] HID: sony: Fix for broken buttons on DS3 USB dongles

2020-05-13 Thread Colenbrander, Roderick
Hi Scott, Thanks for sharing this patch. Do you know if for these controllers the data is at the same byte offsets in the reports as an official DS3? The reason I'm asking is that I have been considering for a while to redo some of the button / stick handling code and the issue you just pointed

Re: [PATCH 14/18] maccess: allow architectures to provide kernel probing directly

2020-05-13 Thread Christoph Hellwig
On Wed, May 13, 2020 at 12:36:18PM -0700, Linus Torvalds wrote: > > + arch_kernel_read(dst, src, type, err_label);\ > > I'm wondering if > > (a) we shouldn't expose this as an interface in general We do export something like it, currently it is called probe_kernel_addr

Re: [PATCH 2/3] remoteproc/k3-dsp: Add a remoteproc driver of K3 C66x DSPs

2020-05-13 Thread Mathieu Poirier
On Wed, 13 May 2020 at 12:14, Suman Anna wrote: > > Hi Mathieu, > > On 4/27/20 5:57 PM, Mathieu Poirier wrote: > > On Wed, Mar 25, 2020 at 03:18:38PM -0500, Suman Anna wrote: > >> The Texas Instrument's K3 J721E SoCs have two C66x DSP Subsystems in MAIN > >> voltage domain that are based on the TI

Re: [PATCH v5 1/7] fs: introduce kernel_pread_file* support

2020-05-13 Thread Mimi Zohar
On Wed, 2020-05-13 at 12:18 -0700, Scott Branden wrote: > On 2020-05-13 12:03 p.m., Mimi Zohar wrote: > > On Wed, 2020-05-13 at 11:53 -0700, Scott Branden wrote: > Even if the kernel successfully verified the firmware file signature it > would just be wasting its time.  The kernel in these use cas

[regression] TC_MD5SIG on established sockets

2020-05-13 Thread Mathieu Desnoyers
Hi, I am reporting a regression with respect to use of TCP_MD5SIG/TCP_MD5SIG_EXT on established sockets. It is observed by a customer. This issue is introduced by this commit: commit 721230326891 "tcp: md5: reject TCP_MD5SIG or TCP_MD5SIG_EXT on established sockets" The intent of this commit a

Re: [PATCH] greybus: audio: remove unused code

2020-05-13 Thread Vaibhav Agarwal
On Wed, May 13, 2020 at 11:15 PM Mark Greer wrote: > > On Thu, May 07, 2020 at 11:29:11PM +0200, Alexandre Belloni wrote: > > GREYBUS_AUDIO_MSM8994 is not an existing configuration option and as > > reported in September 2016, it depends on an "out-of-tree qualcomm audio > > driver". This driver n

Re: clean up and streamline probe_kernel_* and friends v2

2020-05-13 Thread Linus Torvalds
On Wed, May 13, 2020 at 9:00 AM Christoph Hellwig wrote: > > this series start cleaning up the safe kernel and user memory probing > helpers in mm/maccess.c, and then allows architectures to implement > the kernel probing without overriding the address space limit and > temporarily allowing access

Re: [PATCH 04/20] FIEMAP: don't bother with access_ok()

2020-05-13 Thread Christoph Hellwig
On Wed, May 13, 2020 at 08:02:07PM +0100, Al Viro wrote: > > https://lore.kernel.org/linux-fsdevel/20200507145924.ga28...@lst.de/T/#t > > > > which is waiting to be picked up [1], and also has some chance for conflicts > > due to changes next to the access_ok. > > > > [1] except for the first two

Re: [PATCH 14/18] maccess: allow architectures to provide kernel probing directly

2020-05-13 Thread Linus Torvalds
On Wed, May 13, 2020 at 9:01 AM Christoph Hellwig wrote: > > + arch_kernel_read(dst, src, type, err_label);\ I'm wondering if (a) we shouldn't expose this as an interface in general (b) it wouldn't be named differently.. The reason for (a) is that several users of t

Re: [PATCH net-next v1] net: phy: tja11xx: add cable-test support

2020-05-13 Thread David Miller
From: Oleksij Rempel Date: Wed, 13 May 2020 14:34:40 +0200 > Add initial cable testing support. > This PHY needs only 100usec for this test and it is recommended to run it > before the link is up. For now, provide at least ethtool support, so it > can be tested by more developers. > > This patch

Re: [PATCH net-next v1] net: phy: tja11xx: add cable-test support

2020-05-13 Thread Florian Fainelli
On 5/13/2020 5:34 AM, Oleksij Rempel wrote: > Add initial cable testing support. > This PHY needs only 100usec for this test and it is recommended to run it > before the link is up. For now, provide at least ethtool support, so it > can be tested by more developers. > > This patch was tested wi

Re: [PATCH] [media] tw686x: add a missing newline when printing parameter 'dma_mode'

2020-05-13 Thread Ezequiel Garcia
On Mon, 11 May 2020 at 05:49, Xiongfeng Wang wrote: > > When I cat module parameter 'dma_mode' by sysfs, it displays as follows. > It is better to add a newline for easy reading. > > [root@hulk-202 ~]# cat /sys/module/tw686x/parameters/dma_mode > memcpy[root@hulk-202 ~]# > > Signed-off-by: Xiongfe

Re: [RFC PATCH 1/3] drm/debugfs: create debugfs files during drm_dev_register().

2020-05-13 Thread Daniel Vetter
On Wed, May 13, 2020 at 8:12 PM Wambui Karuga wrote: > > > > On Wed, 13 May 2020, Thomas Zimmermann wrote: > > > Hi > > > > Am 13.05.20 um 13:41 schrieb Wambui Karuga: > >> Introduce the ability to track requests for the addition of drm debugfs > >> files at any time and have them added all at onc

Re: [PATCH v1 4/4] scsi: ufs: Fix WriteBooster flush during runtime suspend

2020-05-13 Thread Asutosh Das (asd)
On 5/12/2020 3:47 AM, Stanley Chu wrote: Currently UFS host driver promises VCC supply if UFS device needs to do WriteBooster flush during runtime suspend. However the UFS specification mentions, "While the flushing operation is in progress, the device is in Active power mode." Therefore UFS h

Re: [PATCH net-next v1] net: phy: tja11xx: add cable-test support

2020-05-13 Thread Andrew Lunn
> > Do these registers all conform to the standard? Can we pull this code > > out into a library which all standards conformant PHY drivers can use? > > According to opensig, this functionality should be present on all new T1 PHYs. > But the register/bit layout is no specified as standard. At leas

Re: [tracing] 06e0a548ba: WARNING:at_kernel/trace/ring_buffer.c:#ring_buffer_iter_peek

2020-05-13 Thread Steven Rostedt
On Wed, 13 May 2020 18:15:57 +0200 Sven Schnelle wrote: > Thanks for looking into this. I've attached my /proc/config.gz to this Mail. > The x86 system is my Laptop which is a Thinkpad X280 with 4 HT CPUs (so 8 cpus > in total). I've tried disabling preemption, but this didn't help. > > It's alw

RE: [PATCH 4.19 00/48] 4.19.123-rc1 review

2020-05-13 Thread Chris Paterson
Hello Greg, > From: stable-ow...@vger.kernel.org On > Behalf Of Greg Kroah-Hartman > Sent: 13 May 2020 10:44 > > This is the start of the stable review cycle for the 4.19.123 release. > There are 48 patches in this series, all will be posted as a response > to this one. If anyone has any issues

Re: [PATCH] mm/compaction: avoid VM_BUG_ON(PageSlab()) in page_mapcount()

2020-05-13 Thread Konstantin Khlebnikov
On 13/05/2020 21.32, Andrew Morton wrote: On Wed, 13 May 2020 17:05:25 +0300 Konstantin Khlebnikov wrote: Function isolate_migratepages_block() runs some checks out of lru_lock when choose pages for migration. After checking PageLRU() it checks extra page references by comparing page_count()

Re: [PATCH 11/18] maccess: remove strncpy_from_unsafe

2020-05-13 Thread Christoph Hellwig
On Wed, May 13, 2020 at 12:11:27PM -0700, Linus Torvalds wrote: > On Wed, May 13, 2020 at 9:01 AM Christoph Hellwig wrote: > > > > +static void bpf_strncpy(char *buf, long unsafe_addr) > > +{ > > + buf[0] = 0; > > + if (strncpy_from_kernel_nofault(buf, (void *)unsafe_addr, > > +

Re: [PATCH 6/6] ARM: dts: omap4-droid4: Configure modem for serdev-ngsm

2020-05-13 Thread Pavel Machek
On Tue 2020-05-12 14:47:13, Tony Lindgren wrote: > Let's enable the TS 27.010 /dev/gsmmux* interfaces via Linux n_gsm that > can be used for voice calls and SMS with commands using a custom Motorola > format. > > And let's also enable the kernel GNSS driver via serdev-ngsm that uses a > dedicated

Re: [PATCH 3/6] dt-bindings: serdev: ngsm: Add binding for GNSS child node

2020-05-13 Thread Pavel Machek
On Tue 2020-05-12 14:47:10, Tony Lindgren wrote: > For motorola modem case, we may have a GNSS device on channel 4. > Let's add that to the binding and example. > > Signed-off-by: Tony Lindgren Reviewed-by: Pavel Machek BTW it looks like Alan's email address no longer works. : host mail.llwyn

Re: [PATCH 1/6] tty: n_gsm: Add support for serdev drivers

2020-05-13 Thread Pavel Machek
On Tue 2020-05-12 14:47:08, Tony Lindgren wrote: > We can make use of serdev drivers to do simple device drivers for > TS 27.010 chanels, and we can handle vendor specific protocols on top > of TS 27.010 with serdev drivers. > > So far this has been tested with Motorola droid4 where there is a cus

Re: [PATCH v3 0/8] dwmac-meson8b Ethernet RX delay configuration

2020-05-13 Thread David Miller
From: Martin Blumenstingl Date: Tue, 12 May 2020 23:10:55 +0200 > The Ethernet TX performance has been historically bad on Meson8b and > Meson8m2 SoCs because high packet loss was seen. I found out that this > was related (yet again) to the RGMII TX delay configuration. > In the process of discus

Re: [PATCH 3/3] drm/bridge: Introduce LT9611 DSI to HDMI bridge

2020-05-13 Thread Emil Velikov
Hi Vinod, Few high-level comments: - handful of functions always return 0 and the return value is never checked - switch to return void - annotate all (nearly) arrays as static const - consistently use multi_reg_write - in some cases non-const array will be fine, overwriting a few entries as ne

[PATCH] ASoC: Intel: kbl_rt5663_rt5514_max98927: Split be_hw_params_fixup function

2020-05-13 Thread Lukasz Majczak
Split be_hw_params_fixup function for different codecs as current common function, leads to crash while trying to get snd_soc_dpcm with container_of() macro in kabylake_ssp_fixup(). The crash call path looks as below: soc_pcm_hw_params() snd_soc_dai_hw_params(codec_dai, substream, &codec_params); r

Re: [PATCH v5 1/7] fs: introduce kernel_pread_file* support

2020-05-13 Thread Scott Branden
On 2020-05-13 12:03 p.m., Mimi Zohar wrote: On Wed, 2020-05-13 at 11:53 -0700, Scott Branden wrote: Hi Mimi, On 2020-05-13 11:39 a.m., Mimi Zohar wrote: [Cc'ing linux-security-module, linux-integrity] On Thu, 2020-05-07 at 17:27 -0700, Scott Branden wrote: Add kernel_pread_file* support t

Re: [PATCH] lan743x: Added fixed link support

2020-05-13 Thread Florian Fainelli
On 5/13/2020 12:06 PM, Roelof Berg wrote: > Microchip lan7431 is frequently connected to a phy. However, it > can also be directly connected to a MII remote peer without > any phy in between. For supporting such a phyless hardware setup > in Linux we added the capability to the driver to underst

[tip: x86/entry] x86/idt: Annotate alloc_intr_gate() with __init

2020-05-13 Thread tip-bot2 for Vitaly Kuznetsov
The following commit has been merged into the x86/entry branch of tip: Commit-ID: 4c74d51dab3dd655062a4740af150c1835e19cff Gitweb: https://git.kernel.org/tip/4c74d51dab3dd655062a4740af150c1835e19cff Author:Vitaly Kuznetsov AuthorDate:Tue, 28 Apr 2020 11:38:23 +02:00 Commit

[PATCH] arm64: tegra: Fix flag for 64-bit resources in 'ranges' property

2020-05-13 Thread Vidya Sagar
Fix flag in PCIe controllers device-tree nodes 'ranges' property to correctly represent 64-bit resources. Signed-off-by: Vidya Sagar --- arch/arm64/boot/dts/nvidia/tegra194.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi b/

[tip: x86/entry] x86/xen: Split HVM vector callback setup and interrupt gate allocation

2020-05-13 Thread tip-bot2 for Vitaly Kuznetsov
The following commit has been merged into the x86/entry branch of tip: Commit-ID: fad1940a6a856f59b073e8650e02052ce531154c Gitweb: https://git.kernel.org/tip/fad1940a6a856f59b073e8650e02052ce531154c Author:Vitaly Kuznetsov AuthorDate:Tue, 28 Apr 2020 11:38:22 +02:00 Commit

[PATCH v3 2/2] staging: vt6655: vt6656: change order of makefile variable definitions

2020-05-13 Thread Matej Dujava
This patch will add indentation to multiline variable and put obj-$(CONFIG_X) at the beginning of the file. This order of variables is used in other drives, so this will make vt665x Makefiles fit into the pattern. Indentation is fixed in vt6655/Makefile. Order of variable declaration is changed i

[PATCH v3 1/2] staging: vt6656: vt6655: removing unused macros definition Makefiles

2020-05-13 Thread Matej Dujava
This patch is removing definition of CFLAGS in Makefile of vt6656 and vt6655, as those are defining macros that are not used. This will remove undef of one macro from vt6655/device_main.c, as it is only undef and it is not used anywhere else, so it is safe to remove it. Macros are removed from vt6

[PATCH v3 0/2] staging: vt6656: vt6655: cleaning Makefile

2020-05-13 Thread Matej Dujava
This patchset will remove unused definitions of C Macros, reorder variable definition in Makefiles and increase indentation to match visual block. Macros are removed from vt665x/Makefile and vt6655/device_main.c. Indentation is fixed in vt6655/Makefile. Order of variable declaration is changed i

[tip: x86/entry] x86/idt: Keep spurious entries unset in system_vectors

2020-05-13 Thread tip-bot2 for Vitaly Kuznetsov
The following commit has been merged into the x86/entry branch of tip: Commit-ID: 82ff351052bcc4bf49dc966960f563d25f54d22b Gitweb: https://git.kernel.org/tip/82ff351052bcc4bf49dc966960f563d25f54d22b Author:Vitaly Kuznetsov AuthorDate:Tue, 28 Apr 2020 11:38:24 +02:00 Commit

[PATCH] fpga: dfl: afu: Corrected error handling levels

2020-05-13 Thread Souptick Joarder
Corrected error handling goto sequnece. Level put_pages should be called when pinned pages >= 0 && pinned != npages. Level free_pages should be called when pinned pages < 0. Signed-off-by: Souptick Joarder --- drivers/fpga/dfl-afu-dma-region.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

Re: [PATCH] ath9k: release allocated buffer if timed out

2020-05-13 Thread Brian Norris
On Tue, May 12, 2020 at 8:25 PM Navid Emamdoost wrote: > I found this via static analysis and as a result, did had the inputs > to test it with (like the way fuzzing works). Fuzzing is dynamic analysis, so I'm not sure how that fits. > It may be beneficial if you could point me to any testing >

Re: [PATCH 11/18] maccess: remove strncpy_from_unsafe

2020-05-13 Thread Linus Torvalds
On Wed, May 13, 2020 at 9:01 AM Christoph Hellwig wrote: > > +static void bpf_strncpy(char *buf, long unsafe_addr) > +{ > + buf[0] = 0; > + if (strncpy_from_kernel_nofault(buf, (void *)unsafe_addr, > + BPF_STRNCPY_LEN)) > + strncpy_from_user_nofault(

Re: [PATCH v4] hugetlbfs: Get unmapped area below TASK_UNMAPPED_BASE for hugetlbfs

2020-05-13 Thread kbuild test robot
27; option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Shijie-Hu/hugetlbfs-Get-unmapped-area-below-TASK_UNMAPPED_BASE-for-hugetlbfs/20200513-221024 base: https://git.kernel.org/pub/scm/linux/

Re: remove kernel_setsockopt and kernel_getsockopt

2020-05-13 Thread David Miller
From: Christoph Hellwig Date: Wed, 13 May 2020 08:26:15 +0200 > Hi Dave, > > this series removes the kernel_setsockopt and kernel_getsockopt > functions, and instead switches their users to small functions that > implement setting (or in one case getting) a sockopt directly using > a normal kern

Re: [PATCHv8 0/6] n_gsm serdev support and GNSS driver for droid4

2020-05-13 Thread Pavel Machek
Hi! > Here's the updated set of these patches fixed up for Johan's and > Pavel's earlier comments. > > This series does the following: > > 1. Adds functions to n_gsm.c for serdev-ngsm.c driver to use > > 2. Adds a generic serdev-ngsm.c driver that brings up the TS 27.010 >TTY ports configur

Re: [PATCH v5 2/6] spi: spi-geni-qcom: Use OPP API to set clk/perf state

2020-05-13 Thread Bjorn Andersson
On Wed 13 May 04:12 PDT 2020, Rajendra Nayak wrote: > geni spi needs to express a perforamnce state requirement on CX > depending on the frequency of the clock rates. Use OPP table from > DT to register with OPP framework and use dev_pm_opp_set_rate() to > set the clk/perf state. > > Signed-off-b

[PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-13 Thread Vidya Sagar
commit 9e73fa02aa009 ("PCI: dwc: Warn if MEM resource size exceeds max for 32-bits") enables warning for MEM resources of size >4GB but prefetchable memory resources also come under this category where sizes can go beyond 4GB. Avoid logging a warning for prefetchable memory resources. Signed-off-

[PATCH] lan743x: Added fixed link support

2020-05-13 Thread Roelof Berg
Microchip lan7431 is frequently connected to a phy. However, it can also be directly connected to a MII remote peer without any phy in between. For supporting such a phyless hardware setup in Linux we added the capability to the driver to understand the fixed-link and the phy-connection-type entrie

Re: [PATCH] md/raid1: Replace zero-length array with flexible-array

2020-05-13 Thread Song Liu
On Thu, May 7, 2020 at 12:17 PM Gustavo A. R. Silva wrote: > > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99:

Re: [PATCH v5 1/7] fs: introduce kernel_pread_file* support

2020-05-13 Thread Mimi Zohar
On Wed, 2020-05-13 at 11:53 -0700, Scott Branden wrote: > Hi Mimi, > > On 2020-05-13 11:39 a.m., Mimi Zohar wrote: > > [Cc'ing linux-security-module, linux-integrity] > > > > On Thu, 2020-05-07 at 17:27 -0700, Scott Branden wrote: > >> Add kernel_pread_file* support to kernel to allow for partial

Re: [PATCH] ath9k: release allocated buffer if timed out

2020-05-13 Thread Brian Norris
On Wed, May 13, 2020 at 12:05 AM Kalle Valo wrote: > Actually it's already reverted in -next, nobody just realised that it's > a regression from commit 728c1e2a05e4: > > ced21a4c726b ath9k: Fix use-after-free Read in htc_connect_service Nice. > v5.8-rc1 should be the first release having the fix

Re: [PATCH v2 0/3] x86/idt: Minor alloc_intr_gate() sanitization

2020-05-13 Thread Thomas Gleixner
Vitaly Kuznetsov writes: > Vitaly Kuznetsov writes: > >> This series is a successor of "[PATCH] x86/idt: Keep spurious entries unset >> in system_vectors". >> >> The original issue I tried to address was that /proc/interrupts output >> was always containing all possible system vectors, including

Re: [PATCH 04/20] FIEMAP: don't bother with access_ok()

2020-05-13 Thread Al Viro
On Sun, May 10, 2020 at 12:02:41AM -0700, Christoph Hellwig wrote: > On Sun, May 10, 2020 at 12:45:41AM +0100, Al Viro wrote: > > From: Al Viro > > > > we use copy_to_user() on that thing anyway (and always had). > > I already have this patch in this series: > > https://lore.kernel.org/linux-fs

Re: [PATCH] Makefile: support compressed debug info

2020-05-13 Thread Nick Desaulniers
On Tue, May 12, 2020 at 1:01 PM Fangrui Song wrote: > > >Fangrui, I wasn't able to easily find what version of binutils first > >added support. Can you please teach me how to fish? > > I actually downloaded https://ftp.gnu.org/gnu/binutils/ archives and > located the sources... I think an easier

Re: [PATCH] Fix suspicious RCU usage warning

2020-05-13 Thread David Miller
From: madhuparnabhowmi...@gmail.com Date: Wed, 13 May 2020 11:46:10 +0530 > From: Madhuparna Bhowmik > > This patch fixes the following warning: > > = > WARNING: suspicious RCU usage > 5.7.0-rc4-next-20200507-syzkaller #0 Not tainted > - >

[PATCHv1 09/19] power: supply: sbs-battery: add POWER_SUPPLY_PROP_CURRENT_AVG support

2020-05-13 Thread Sebastian Reichel
Expose averaged current information, which is part of the SBS standard and should be supported by all batteries. Signed-off-by: Sebastian Reichel --- drivers/power/supply/sbs-battery.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply/sbs-batte

<    1   2   3   4   5   6   7   8   9   10   >