[PATCH v4 10/12] PCI: brcmstb: Accommodate MSI for older chips

2020-06-05 Thread Jim Quinlan
From: Jim Quinlan Older BrcmSTB chips do not have a separate register for MSI interrupts; the MSIs are in a register that also contains unrelated interrupts. In addition, the interrupts lie in bits [31..24] for these legacy chips. This commit provides common code for both legacy and non-legacy

[PATCH v4 12/12] PCI: brcmstb: Add bcm7211, bcm7216, bcm7445, bcm7278 to match list

2020-06-05 Thread Jim Quinlan
Now that the support is in place with previous commits, we add several chips that use the BrcmSTB driver. Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli --- drivers/pci/controller/pcie-brcmstb.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v4 11/12] PCI: brcmstb: Set bus max burst size by chip type

2020-06-05 Thread Jim Quinlan
From: Jim Quinlan The proper value of the parameter SCB_MAX_BURST_SIZE varies per chip. The 2711 family requires 128B whereas other devices can employ 512. The assignment is complicated by the fact that the values for this two-bit field have different meanings; Value Type_Generic

[PATCH v4 06/12] PCI: brcmstb: Add bcm7278 PERST support

2020-06-05 Thread Jim Quinlan
From: Jim Quinlan The PERST bit was moved to a different register in 7278-type STB chips. In addition, the polarity of the bit was also changed; for other chips writing a 1 specified assert; for 7278-type chips, writing a 0 specifies assert. Signal-wise, PERST is an asserted-low signal.

[PATCH v4 04/12] PCI: brcmstb: Add bcm7278 register info

2020-06-05 Thread Jim Quinlan
From: Jim Quinlan Add in compatibility strings and code for three Broadcom STB chips. Some of the register locations, shifts, and masks are different for certain chips, requiring the use of different constants based on of_id. We would like to add the following at this time to the match list

[PATCH v4 07/12] PCI: brcmstb: Add control of rescal reset

2020-06-05 Thread Jim Quinlan
From: Jim Quinlan Some STB chips have a special purpose reset controller named RESCAL (reset calibration). The PCIe HW can now control RESCAL to start and stop its operation. Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli --- drivers/pci/controller/pcie-brcmstb.c | 84

[PATCH v4 02/12] ata: ahci_brcm: Fix use of BCM7216 reset controller

2020-06-05 Thread Jim Quinlan
From: Jim Quinlan A reset controller "rescal" is shared between the AHCI driver and the PCIe driver for the BrcmSTB 7216 chip. The code is modified to allow this sharing and to deassert() properly. Signed-off-by: Jim Quinlan Fixes: 272ecd60a636 ("ata: ahci_brcm: BCM7216 reset is self

[PATCH v4 03/12] dt-bindings: PCI: Add bindings for more Brcmstb chips

2020-06-05 Thread Jim Quinlan
From: Jim Quinlan - Add compatible strings for three more Broadcom STB chips: 7278, 7216, 7211 (STB version of RPi4). - add new property 'brcm,scb-sizes' - add new property 'resets' - add new property 'reset-names' for 7216 only - allow 'ranges' and 'dma-ranges' to have more than one item and

[PATCH v4 05/12] PCI: brcmstb: Add suspend and resume pm_ops

2020-06-05 Thread Jim Quinlan
From: Jim Quinlan Broadcom Set-top (BrcmSTB) boards typically support S2, S3, and S5 suspend and resume. Now the PCIe driver may do so as well. Signed-off-by: Jim Quinlan --- drivers/pci/controller/pcie-brcmstb.c | 48 +++ 1 file changed, 48 insertions(+) diff --git

[PATCH v4 09/12] PCI: brcmstb: Set internal memory viewport sizes

2020-06-05 Thread Jim Quinlan
BrcmSTB PCIe controllers are intimately connected to the memory controller(s) on the SOC. There is a "viewport" for each memory controller that allows inbound accesses to CPU memory. Each viewport's size must be set to a power of two, and that size must be equal to or larger than the amount of

[PATCH v4 00/12] PCI: brcmstb: enable PCIe for STB chips

2020-06-05 Thread Jim Quinlan
v4: Commit "device core: Introduce multiple dma pfn offsets" -- of_dma_get_range() does not take a dev param but instead takes two "out" params: map and map_size. We do this so that the code that parses dma-ranges is separate from the code that modifies 'dev'. (Nicolas)

Re: [PATCH] kexec: dump kmessage before machine_kexec

2020-06-05 Thread Kees Cook
On Fri, Jun 05, 2020 at 03:46:42PM -0400, Pavel Tatashin wrote: > kmsg_dump(KMSG_DUMP_SHUTDOWN) is called before > machine_restart(), machine_halt(), machine_power_off(), the only one that > is missing is machine_kexec(). > > The dmesg output that it contains can be used to study the shutdown >

Re: [PATCH 04/12] x86/xen: add system core suspend and resume callbacks

2020-06-05 Thread Boris Ostrovsky
On 6/3/20 6:40 PM, Agarwal, Anchal wrote: > CAUTION: This email originated from outside of the organization. Do not > click links or open attachments unless you can confirm the sender and know > the content is safe. > > > > On 5/19/20 7:26 PM, Anchal Agarwal wrote: > > From: Munehisa

Re: [GIT PULL] first round of SCSI updates for the 5.6+ merge window

2020-06-05 Thread Linus Torvalds
On Fri, Jun 5, 2020 at 2:18 PM James Bottomley wrote: > > Um, no, shuffles feet ... I actually tagged the wrong branch: Ok, now I see the changes, but I see more than you reported. These seem to be new compared to your pull request: Al Viro (4): scsi: hpsa: Lift

Re: [PATCHSET v5 0/12] Add support for async buffered reads

2020-06-05 Thread Jens Axboe
On 6/5/20 3:13 PM, Jens Axboe wrote: > On 6/5/20 2:53 PM, Jens Axboe wrote: >> On 6/5/20 2:36 PM, Andres Freund wrote: >>> Hi, >>> >>> On 2020-06-05 13:20:28 -0700, Andres Freund wrote: I'll go and try to figure out why I don't see an oops... >>> >>> Err, that probably was a typo on my end in

Re: [PATCH v4 kunit-next 0/2] kunit: extend kunit resources API

2020-06-05 Thread Brendan Higgins
On Fri, May 29, 2020 at 2:46 PM Alan Maguire wrote: > > A recent RFC patch set [1] suggests some additional functionality > may be needed around kunit resources. It seems to require > > 1. support for resources without allocation > 2. support for lookup of such resources > 3. support for access

Re: + ipc-convert-ipcs_idr-to-xarray-update.patch added to -mm tree

2020-06-05 Thread Andrew Morton
On Fri, 5 Jun 2020 13:11:34 -0700 Matthew Wilcox wrote: > On Fri, Jun 05, 2020 at 03:58:48PM -0400, Qian Cai wrote: > > This will trigger, > > > > [ 8853.759549] LTP: starting semget05 > > [ 8867.257088] BUG: sleeping function called from invalid context at > > mm/slab.h:567 > > [ 8867.270259]

Re: [PATCH v4 06/11] gpio: add support for the sl28cpld GPIO controller

2020-06-05 Thread Andy Shevchenko
On Fri, Jun 5, 2020 at 9:44 PM Michael Walle wrote: > Am 2020-06-05 15:15, schrieb Andy Shevchenko: > > On Fri, Jun 05, 2020 at 02:42:53PM +0200, Michael Walle wrote: > >> Am 2020-06-05 14:00, schrieb Andy Shevchenko: > >> > On Fri, Jun 5, 2020 at 12:14 AM Michael Walle wrote: ... > >> > > +

Re: [Cocci] [PATCH] coccinelle: api: add kvfree script

2020-06-05 Thread Julia Lawall
On Sat, 6 Jun 2020, Denis Efremov wrote: > On 6/5/20 11:51 PM, Julia Lawall wrote: > > Is there a strong reason for putting the choice rule first? It may make > > things somewhat slower than necessary, if it matches in many places, > > because the opportunity rule will have to detect that it

[RFC][PATCH] slimbus: core: Set fwnode for a device when setting of_node

2020-06-05 Thread John Stultz
From: Saravana Kannan When setting the of_node for a newly created device, also set the fwnode. This allows fw_devlink to work for slimbus devices. Cc: Srinivas Kandagatla Cc: alsa-de...@alsa-project.org Signed-off-by: Saravana Kannan Signed-off-by: John Stultz --- drivers/slimbus/core.c |

Re: [GIT PULL] first round of SCSI updates for the 5.6+ merge window

2020-06-05 Thread James Bottomley
On Fri, 2020-06-05 at 14:11 -0700, Linus Torvalds wrote: > On Thu, Jun 4, 2020 at 9:55 PM James Bottomley > wrote: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi- > > misc > >"Already up to date." > > Did you forget to force a push? That scsi-misc tag is your tag

Re: [GIT PULL] Please pull RDMA subsystem changes

2020-06-05 Thread pr-tracker-bot
The pull request you sent on Thu, 4 Jun 2020 16:51:31 -0300: > git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git tags/for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/242b23319809e05170b3cc0d44d3b4bd202bb073 Thank you! -- Deet-doot-dot, I am a

Re: [GIT PULL] core/core updates for v5.8

2020-06-05 Thread pr-tracker-bot
The pull request you sent on Wed, 3 Jun 2020 23:34:52 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > tags/core_core_updates_for_5.8 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ac7b34218a0021bafd1d4c11c54217b930f516b0 Thank you! --

Re: [GIT PULL] VFIO updates for v5.8-rc1

2020-06-05 Thread pr-tracker-bot
The pull request you sent on Wed, 3 Jun 2020 11:23:04 -0600: > git://github.com/awilliam/linux-vfio.git tags/vfio-v5.8-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/5a36f0f3f518c60ccddf052e6c48862f357d126f Thank you! -- Deet-doot-dot, I am a bot.

Re: [GIT PULL] Bulk GPIO changes for v5.8

2020-06-05 Thread pr-tracker-bot
The pull request you sent on Thu, 4 Jun 2020 23:51:30 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git > tags/gpio-v5.8-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/3f7e82379fc91102d82ed89822bd4242c83e40d5 Thank you! --

Re: [GIT PULL] IPMI bug fixes for 5.8

2020-06-05 Thread pr-tracker-bot
The pull request you sent on Thu, 4 Jun 2020 13:59:12 -0500: > https://github.com/cminyard/linux-ipmi.git tags/for-linus-5.8-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/1f2dc7f5b6c1fffdb24e776b9d3529bd9414aa2c Thank you! -- Deet-doot-dot, I am a bot.

Re: [Cocci] [PATCH] coccinelle: api: add kvfree script

2020-06-05 Thread Denis Efremov
On 6/5/20 11:51 PM, Julia Lawall wrote: > Is there a strong reason for putting the choice rule first? It may make > things somewhat slower than necessary, if it matches in many places, > because the opportunity rule will have to detect that it doesn't care > about all of those places. No, I

Re: [PATCHSET v5 0/12] Add support for async buffered reads

2020-06-05 Thread Jens Axboe
On 6/5/20 2:53 PM, Jens Axboe wrote: > On 6/5/20 2:36 PM, Andres Freund wrote: >> Hi, >> >> On 2020-06-05 13:20:28 -0700, Andres Freund wrote: >>> I'll go and try to figure out why I don't see an oops... >> >> Err, that probably was a typo on my end in the serial console >> config. After fixing

Re: [GIT PULL] first round of SCSI updates for the 5.6+ merge window

2020-06-05 Thread Linus Torvalds
On Thu, Jun 4, 2020 at 9:55 PM James Bottomley wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-misc "Already up to date." Did you forget to force a push? That scsi-misc tag is your tag from April 10. Linus

Re: [PATCH net] net: dp83869: Reset return variable if PHY strap is read

2020-06-05 Thread Florian Fainelli
On 6/5/2020 1:51 PM, Dan Murphy wrote: > When the PHY's strap register is read to determine if lane swapping is > needed the phy_read_mmd returns the value back into the ret variable. > > If the call to read the strap fails the failed value is returned. If > the call to read the strap is

iscsi-target: hang if connection closed when processing LUN resets

2020-06-05 Thread Pavel Zakharov
This issue can be reproduced when running with a Windows initiator and is triggered by a 60 second disk IO timeout in Windows. This happens when the device that backs the backstore is extremely slow for a short period of time. From my observation, if an iSCSI request takes more than 60

Re: [PATCH] x86/cpu: Reinitialize IA32_FEAT_CTL MSR on BSP during wakeup

2020-06-05 Thread kernel test robot
Hi Sean, I love your patch! Yet something to improve: [auto build test ERROR on tip/x86/core] [also build test ERROR on tip/auto-latest v5.7 next-20200605] [cannot apply to bp/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we

Re: [PATCH] IMA: Add log statements for failure conditions

2020-06-05 Thread Lakshmi Ramasubramanian
On 6/5/20 1:49 PM, Paul Moore wrote: Since a pr_xyz() call was already present, I just wanted to change the log level to keep the code change to the minimum. But if audit log is the right approach for this case, I'll update. Generally we reserve audit for things that are required for

Re: [RFC PATCH 4/5] mm, slub: make remaining slub_debug related attributes read-only

2020-06-05 Thread Kees Cook
On Tue, Jun 02, 2020 at 04:15:18PM +0200, Vlastimil Babka wrote: > SLUB_DEBUG creates several files under /sys/kernel/slab// that can be > read to check if the respective debugging options are enabled for given cache. > Some options, namely sanity_checks, trace, and failslab can be also enabled >

Re: [RFC PATCH 5/5] mm, slub: make reclaim_account attribute read-only

2020-06-05 Thread Kees Cook
On Tue, Jun 02, 2020 at 04:15:19PM +0200, Vlastimil Babka wrote: > The attribute reflects the SLAB_RECLAIM_ACCOUNT cache flag. It's not clear why > this attribute was writable in the first place, as it's tied to how the cache > is used by its creator, it's not a user tunable. Furthermore: > > -

Re: [RFC PATCH 3/5] mm, slub: remove runtime allocation order changes

2020-06-05 Thread Kees Cook
On Tue, Jun 02, 2020 at 04:15:17PM +0200, Vlastimil Babka wrote: > SLUB allows runtime changing of page allocation order by writing into the > /sys/kernel/slab//order file. Jann has reported [1] that this interface > allows the order to be set too small, leading to crashes. > > While it's

Re: [RFC PATCH 2/5] mm, slub: make some slub_debug related attributes read-only

2020-06-05 Thread Kees Cook
On Tue, Jun 02, 2020 at 04:15:16PM +0200, Vlastimil Babka wrote: > SLUB_DEBUG creates several files under /sys/kernel/slab// that can be > read to check if the respective debugging options are enabled for given cache. > The options can be also toggled at runtime by writing into the files. Some of

Re: [RFC PATCH 1/5] mm, slub: extend slub_debug syntax for multiple blocks

2020-06-05 Thread Kees Cook
On Tue, Jun 02, 2020 at 04:15:15PM +0200, Vlastimil Babka wrote: > The slub_debug kernel boot parameter can either apply a single set of options > to all caches or a list of caches. There is a use case where debugging is > applied for all caches and then disabled at runtime for specific caches,

Re: [PATCH v10 5/6] ndctl/papr_scm,uapi: Add support for PAPR nvdimm specific methods

2020-06-05 Thread Dan Williams
On Fri, Jun 5, 2020 at 12:50 PM Ira Weiny wrote: > > On Fri, Jun 05, 2020 at 05:11:35AM +0530, Vaibhav Jain wrote: > > Introduce support for PAPR NVDIMM Specific Methods (PDSM) in papr_scm > > module and add the command family NVDIMM_FAMILY_PAPR to the white list > > of NVDIMM command sets. Also

Re: [PATCHSET v5 0/12] Add support for async buffered reads

2020-06-05 Thread Jens Axboe
On 6/5/20 2:36 PM, Andres Freund wrote: > Hi, > > On 2020-06-05 13:20:28 -0700, Andres Freund wrote: >> I'll go and try to figure out why I don't see an oops... > > Err, that probably was a typo on my end in the serial console > config. After fixing that, I did get the below. > > If helpful I

Re: [Cocci] [PATCH] coccinelle: api: add kvfree script

2020-06-05 Thread Julia Lawall
On Fri, 5 Jun 2020, Denis Efremov wrote: > Check that alloc and free types of functions match each other. Is there a strong reason for putting the choice rule first? It may make things somewhat slower than necessary, if it matches in many places, because the opportunity rule will have to

[PATCH net] net: dp83869: Reset return variable if PHY strap is read

2020-06-05 Thread Dan Murphy
When the PHY's strap register is read to determine if lane swapping is needed the phy_read_mmd returns the value back into the ret variable. If the call to read the strap fails the failed value is returned. If the call to read the strap is successful then ret is possibly set to a non-zero

[PATCH v3] Bluetooth: Allow suspend even when preparation has failed

2020-06-05 Thread Abhishek Pandit-Subedi
It is preferable to allow suspend even when Bluetooth has problems preparing for sleep. When Bluetooth fails to finish preparing for suspend, log the error and allow the suspend notifier to continue instead. To also make it clearer why suspend failed, change bt_dev_dbg to bt_dev_err when handling

Re: [PATCH] IMA: Add log statements for failure conditions

2020-06-05 Thread Paul Moore
On Fri, Jun 5, 2020 at 3:54 PM Lakshmi Ramasubramanian wrote: > On 6/5/20 12:37 PM, Paul Moore wrote: > > > If it's audit related, it's generally best to CC the linux-audit list, > > not just me (fixed). > > > > It's not clear to me what this pr_err() is trying to indicate other > > than

Re: [PATCH 3/3] Bluetooth: hci_qca: Refactor error handling in qca_suspend()

2020-06-05 Thread Abhishek Pandit-Subedi
Reviewed-by: Abhishek Pandit-Subedi On Fri, Jun 5, 2020 at 11:46 AM Matthias Kaehlcke wrote: > > If waiting for IBS sleep times out jump to the error handler, this is > easier to read than multiple 'if' branches and a fall through to the > error handler. > > Signed-off-by: Matthias Kaehlcke >

Re: [GIT PULL] core/core updates for v5.8

2020-06-05 Thread Linus Torvalds
On Wed, Jun 3, 2020 at 2:35 PM Borislav Petkov wrote: > > please pull the set disabling automatic READ_IMPLIES_EXEC on x86-64 and > arm64. Ok, let's see if anybody hollers... Linus

Re: [PATCH 2/3] Bluetooth: hci_qca: Skip serdev wait when no transfer is pending

2020-06-05 Thread Abhishek Pandit-Subedi
Reviewed-by: Abhishek Pandit-Subedi On Fri, Jun 5, 2020 at 11:46 AM Matthias Kaehlcke wrote: > > qca_suspend() calls serdev_device_wait_until_sent() regardless of > whether a transfer is pending. While it does no active harm since > the function should return immediately it makes the code more

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.8-1 tag

2020-06-05 Thread Linus Torvalds
On Fri, Jun 5, 2020 at 12:01 PM Linus Torvalds wrote: > > ..and then when I actually compared whether I otherwise got the same > result as you, I realized that this all depends on the module tree. > > I'll go merge that first, and then re-do this all. Oh well. Ok, redone and pushed out. Can you

Re: [PATCH v2] Bluetooth: Allow suspend even when preparation has failed

2020-06-05 Thread Jakub Kicinski
On Thu, 4 Jun 2020 21:28:50 -0700 Abhishek Pandit-Subedi wrote: > It is preferable to allow suspend even when Bluetooth has problems > preparing for sleep. When Bluetooth fails to finish preparing for > suspend, log the error and allow the suspend notifier to continue > instead. > > To also make

Re: [PATCH 1/3] Bluetooth: hci_qca: Only remove TX clock vote after TX is completed

2020-06-05 Thread Abhishek Pandit-Subedi
Hi, On Fri, Jun 5, 2020 at 11:46 AM Matthias Kaehlcke wrote: > > qca_suspend() removes the vote for the UART TX clock after > writing an IBS sleep request to the serial buffer. This is > not a good idea since there is no guarantee that the request > has been sent at this point. Instead remove

[PATCH] coccinelle: api: add kvfree script

2020-06-05 Thread Denis Efremov
Check that alloc and free types of functions match each other. Signed-off-by: Denis Efremov --- List of patches to stable: - https://lkml.org/lkml/2020/6/1/713 - https://lkml.org/lkml/2020/6/5/200 - https://lkml.org/lkml/2020/6/5/838 - https://lkml.org/lkml/2020/6/5/887 Other patches: -

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.8-1 tag

2020-06-05 Thread pr-tracker-bot
The pull request you sent on Sat, 06 Jun 2020 02:38:49 +1000: > https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git > tags/powerpc-5.8-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7ae77150d94d3b535c7b85e6b3647113095e79bf Thank you! --

Re: [GIT PULL] Modules updates for v5.8

2020-06-05 Thread pr-tracker-bot
The pull request you sent on Fri, 5 Jun 2020 11:33:56 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux.git > tags/modules-for-v5.8 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/084623e468d535d98f883cc2ccf2c4fdf2108556 Thank you! -- Deet-doot-dot,

Re: [GIT PULL v3] x86/mm changes for v5.8

2020-06-05 Thread pr-tracker-bot
The pull request you sent on Fri, 5 Jun 2020 10:11:37 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-mm-2020-06-05 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f4dd60a3d4c7656dcaa0ba2afb503528c86f913f Thank you! -- Deet-doot-dot, I am a

Re: [PATCH v10 0/3] perf x86: Exposing IO stack to IO PMON mapping through sysfs

2020-06-05 Thread Andi Kleen
On Fri, Jun 05, 2020 at 07:53:14PM +0200, Peter Zijlstra wrote: > On Mon, Jun 01, 2020 at 11:35:40AM +0300, alexander.anto...@linux.intel.com > wrote: > > Didn't GregKH have comments on earlier versions of these patches? I > don't see him on Cc anymore. Were all his comments addressed? I

Re: [GIT PULL] Modules updates for v5.8

2020-06-05 Thread Linus Torvalds
On Fri, Jun 5, 2020 at 2:34 AM Jessica Yu wrote: > > Please pull below to receive modules updates for the v5.8 merge window. Done. Considering the confusion this merge window with the dependencies of trees with each other, can you verify that what I got matches what you expect?

Re: [PATCHSET v5 0/12] Add support for async buffered reads

2020-06-05 Thread Andres Freund
Hi, On 2020-06-05 13:20:28 -0700, Andres Freund wrote: > I'll go and try to figure out why I don't see an oops... Err, that probably was a typo on my end in the serial console config. After fixing that, I did get the below. If helpful I can try with debugging enabled or such. [ 67.910265]

Re: linux-next: Signed-off-by missing for commit in the jc_docs tree

2020-06-05 Thread Jonathan Corbet
On Fri, 5 Jun 2020 22:28:54 +0200 "Alexander A. Klimov" wrote: > Am I completely blind or did the patch completely disappear? > > $ git log v5.0..docs-5.8 |grep -Fwe 'Alexander A. Klimov' > $ git log v5.0..lwn/docs-next |grep -Fwe 'Alexander A. Klimov' > $ git log v5.0..lwn/docs-next-merge

Re: schedutil issue with serial workloads

2020-06-05 Thread Peter Zijlstra
On Fri, Jun 05, 2020 at 06:51:12PM +0200, Rafael J. Wysocki wrote: > On 6/4/2020 11:29 PM, Alexander Monakov wrote: > > this is a question/bugreport about behavior of schedutil on serial workloads > > such as rsync, or './configure', or 'make install'. These workloads are > > such that there's no

Re: [PATCH 19/30] KVM: nSVM: extract svm_set_gif

2020-06-05 Thread Qian Cai
too large for 64-bit type 'long long unsigned int' [ 1362.310715][ T2195] CPU: 51 PID: 2195 Comm: qemu-kvm Not tainted 5.7.0-next-20200605 #6 [ 1362.319244][ T2195] Hardware name: HPE ProLiant DL385 Gen10/ProLiant DL385 Gen10, BIOS A40 03/09/2018 [ 1362.328530][ T2195] Call Trace: [ 1362.331710

Re: linux-next: Signed-off-by missing for commit in the jc_docs tree

2020-06-05 Thread Alexander A. Klimov
Am I completely blind or did the patch completely disappear? $ git log v5.0..docs-5.8 |grep -Fwe 'Alexander A. Klimov' $ git log v5.0..lwn/docs-next |grep -Fwe 'Alexander A. Klimov' $ git log v5.0..lwn/docs-next-merge |grep -Fwe 'Alexander A. Klimov' $ git log v5.0..torvalds/master |grep -Fwe

Re: [PATCH] cxgb4: Use kfree() instead kvfree() where appropriate

2020-06-05 Thread David Miller
From: Denis Efremov Date: Fri, 5 Jun 2020 22:11:44 +0300 > Use kfree(buf) in blocked_fl_read() because the memory is allocated with > kzalloc(). Use kfree(t) in blocked_fl_write() because the memory is > allocated with kcalloc(). > > Signed-off-by: Denis Efremov Applied.

[PATCH 1/2] habanalabs: block scalar load_and_exe on external queue

2020-06-05 Thread Oded Gabbay
In Gaudi, the user can't execute scalar load_and_exe on external queue because it can be a security hole. The driver doesn't parse the commands being loaded and it can be msg_prot, which the user isn't allowed to use. Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/gaudi/gaudi.c

[GIT PULL] PCI changes for v5.8

2020-06-05 Thread Bjorn Helgaas
The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136: Linux 5.7-rc1 (2020-04-12 12:35:55 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git tags/pci-v5.8-changes for you to fetch changes up to

[PATCH 2/2] habanalabs: use PI in MMU cache invalidation

2020-06-05 Thread Oded Gabbay
From: Omer Shpigelman The PS flow for MMU cache invalidation caused timeouts in stress tests. Use PS + PI flow so no timeouts should happen whatsoever. Signed-off-by: Omer Shpigelman Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/gaudi/gaudi.c | 8

Re: [PATCHSET v5 0/12] Add support for async buffered reads

2020-06-05 Thread Jens Axboe
On 6/5/20 2:20 PM, Andres Freund wrote: > Hi, > > On 2020-06-05 08:42:28 -0600, Jens Axboe wrote: >> Can you try with async-buffered.7? I've rebased it on a new mechanism, >> and doing something like what you describe above I haven't been able >> to trigger anything bad. I'd try your test case

[GIT PULL] workqueue changes for v5.8-rc1

2020-06-05 Thread Tejun Heo
Hello, Linus. Mostly cleanups and other trivial changes. The only interesting change is Sebastian's rcuwait conversion for RT which was already discussed. Thanks. The following changes since commit 47cf1b422e6093aee2a3e55d5e162112a2c69870: Merge branch 'for-linus' of

Re: [PATCHSET v5 0/12] Add support for async buffered reads

2020-06-05 Thread Andres Freund
Hi, On 2020-06-05 08:42:28 -0600, Jens Axboe wrote: > Can you try with async-buffered.7? I've rebased it on a new mechanism, > and doing something like what you describe above I haven't been able > to trigger anything bad. I'd try your test case specifically, so do let > know if it's something I

Re: [PATCH net] vsock/vmci: make vmci_vsock_transport_cb() static

2020-06-05 Thread David Miller
From: Stefano Garzarella Date: Fri, 5 Jun 2020 17:12:41 +0200 > Fix the following gcc-9.3 warning when building with 'make W=1': > net/vmw_vsock/vmci_transport.c:2058:6: warning: no previous prototype > for ‘vmci_vsock_transport_cb’ [-Wmissing-prototypes] > 2058 | void

Re: [PATCH resend] fs/namei.c: micro-optimize acl_permission_check

2020-06-05 Thread Linus Torvalds
On Fri, Jun 5, 2020 at 7:23 AM Rasmus Villemoes wrote: > > + /* > +* If the "group" and "other" permissions are the same, > +* there's no point calling in_group_p() to decide which > +* set to use. > +*/ > +

Re: [PATCH] net: ethtool: Fix comment mentioning typo in IS_ENABLED()

2020-06-05 Thread David Miller
From: Kees Cook Date: Fri, 5 Jun 2020 07:21:22 -0700 > This has no code changes, but it's a typo noticed in other clean-ups, > so we might as well fix it. IS_ENABLED() takes full names, and should > have the "CONFIG_" prefix. > > Reported-by: Joe Perches > Link: >

Re: [PATCH net] net: phy: mscc: fix Serdes configuration in vsc8584_config_init

2020-06-05 Thread David Miller
From: Antoine Tenart Date: Fri, 5 Jun 2020 16:00:09 +0200 > When converting the MSCC PHY driver to shared PHY packages, the Serdes > configuration in vsc8584_config_init was modified to use 'base_addr' > instead of 'base' as the port number. But 'base_addr' isn't equal to > 'addr' for all PHYs

Re: [PATCH net 0/4] Fixes for OF_MDIO flag

2020-06-05 Thread David Miller
From: Dan Murphy Date: Fri, 5 Jun 2020 09:01:03 -0500 > There are some residual drivers that check the CONFIG_OF_MDIO flag using the > if defs. Using this check does not work when the OF_MDIO is configured as a > module. Using the IS_ENABLED macro checks if the flag is declared as built-in > or

Re: [PATCH net] net: ethernet: mvneta: fix MVNETA_SKB_HEADROOM alignment

2020-06-05 Thread David Miller
From: Alexander Lobakin Date: Fri, 5 Jun 2020 15:53:24 +0300 > Commit ca23cb0bc50f ("mvneta: MVNETA_SKB_HEADROOM set last 3 bits to zero") > added headroom alignment check against 8. > Hovewer (if we imagine that NET_SKB_PAD or XDP_PACKET_HEADROOM is not > aligned to cacheline size), it

Re: + ipc-convert-ipcs_idr-to-xarray-update.patch added to -mm tree

2020-06-05 Thread Matthew Wilcox
On Fri, Jun 05, 2020 at 03:58:48PM -0400, Qian Cai wrote: > This will trigger, > > [ 8853.759549] LTP: starting semget05 > [ 8867.257088] BUG: sleeping function called from invalid context at > mm/slab.h:567 > [ 8867.270259] in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 22556, > name:

Re: [PATCH v32 12/21] x86/sgx: Add provisioning

2020-06-05 Thread Darren Kenny
Hi Jarkko, Just a couple of nits below... On Monday, 2020-06-01 at 10:52:09 +03, Jarkko Sakkinen wrote: > In order to provide a mechanism for devilering provisoning rights: TYPO: s/devilering/delivering/? > > 1. Add a new device file /dev/sgx/provision that works as a token for >allowing

Re: [PATCH v1 5/5] kselftests: cgroup: add perpcu memory accounting test

2020-06-05 Thread Dennis Zhou
On Thu, May 28, 2020 at 04:25:08PM -0700, Roman Gushchin wrote: > Add a simple test to check the percpu memory accounting. > The test creates a cgroup tree with 1000 child cgroups > and checks values of memory.current and memory.stat::percpu. > > Signed-off-by: Roman Gushchin > --- >

Re: [PATCH v4 02/11] mfd: Add support for Kontron sl28cpld management controller

2020-06-05 Thread Michael Walle
Hi, Am 2020-06-05 12:50, schrieb Mark Brown: On Fri, Jun 05, 2020 at 07:57:09AM +0100, Lee Jones wrote: On Thu, 04 Jun 2020, Michael Walle wrote: > + sl28cpld->regmap = devm_regmap_init_i2c(i2c, _regmap_config); > + if (IS_ERR(sl28cpld->regmap)) > + return

[PATCH] x86/cpu: Reinitialize IA32_FEAT_CTL MSR on BSP during wakeup

2020-06-05 Thread Sean Christopherson
Reinitialize IA32_FEAT_CTL on the BSP during wakeup to handle the case where firmware doesn't initialize or save/restore across S3. This fixes a bug where IA32_FEAT_CTL is left uninitialized and results in VMXON taking a #GP due to VMX not being fully enabled, i.e. breaks KVM. Use

Re: [PATCH v2 1/2] KVM: nVMX: Properly handle kvm_read/write_guest_virt*() result

2020-06-05 Thread Sean Christopherson
On Fri, Jun 05, 2020 at 01:59:05PM +0200, Vitaly Kuznetsov wrote: > Introduce vmx_handle_memory_failure() as an interim solution. Heh, "interim". I'll take the over on that :-D. > Note, nested_vmx_get_vmptr() now has three possible outcomes: OK, PF, > KVM_EXIT_INTERNAL_ERROR and callers need to

[PATCH v3 1/2] scsi: ufs: Add SPDX GPL-2.0 to replace GPL v2 boilerplate

2020-06-05 Thread Bean Huo
From: Bean Huo Add SPDX GPL-2.0 to UFS driver files that specified the GPL version 2 license, remove the full boilerplate text. Signed-off-by: Bean Huo --- drivers/scsi/ufs/ufs.h | 27 +-- drivers/scsi/ufs/ufshcd-pci.c| 25 +

[PATCH v3 0/2] scsi: ufs: cleanup UFS driver

2020-06-05 Thread Bean Huo
From: Bean Huo Cleanup, no functional change Changelog: v2 -v3: 1. Change SPDX-License-Identifier: GPL-2.0 to SPDX-License-Identifier: GPL-2.0-or-later (Eric Biggers) v1 - v2: 1. Split patch (Tomas Winkler) Bean Huo (2): scsi: ufs: Add SPDX GPL-2.0 to replace GPL v2

[PATCH v3 2/2] scsi: ufs: remove wrapper function ufshcd_setup_clocks()

2020-06-05 Thread Bean Huo
From: Bean Huo The static function ufshcd_setup_clocks() is just a wrapper around __ufshcd_setup_clocks(), remove it. Rename original function wrapped __ufshcd_setup_clocks() to new ufshcd_setup_clocks(). Signed-off-by: Bean Huo --- drivers/scsi/ufs/ufshcd.c | 32

[GIT PULL] cgroup changes for v5.8-rc1

2020-06-05 Thread Tejun Heo
Hello, Linus. Just two patches. One to add system-level cpu.stat to the root cgroup for convenience and a trivial comment update. Thanks. The following changes since commit eec8fd0277e37cf447b88c6be181e81df867bcf1: device_cgroup: Cleanup cgroup eBPF device filter code (2020-04-13 14:41:54

Re: + ipc-convert-ipcs_idr-to-xarray-update.patch added to -mm tree

2020-06-05 Thread Qian Cai
ocks held by semget05/22556: [ 8867.270345] #0: 512de7e0 (>rwsem){}-{3:3}, at: ipcget+0x4e/0x230 [ 8867.270426] #1: 552b9018 (>lock){+.+.}-{2:2}, at: ipc_addid+0xf4/0xf50 [ 8867.270495] CPU: 0 PID: 22556 Comm: semget05 Not tainted 5.7.0-next-20200605 #4

Re: [PATCH] net/mlx5: Use kfree(ft->g) in arfs_create_groups()

2020-06-05 Thread Eric Dumazet
On 6/5/20 12:22 PM, Denis Efremov wrote: > Use kfree() instead of kvfree() on ft->g in arfs_create_groups() because > the memory is allocated with kcalloc(). > > Signed-off-by: Denis Efremov > --- > drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCHSET v5 0/12] Add support for async buffered reads

2020-06-05 Thread Andres Freund
Hi, On 2020-06-03 18:30:45 -0700, Andres Freund wrote: > > I'll try and reproduce this, any chance you have a test case that can > > be run so I don't have to write one from scratch? The more detailed > > instructions the better. > > It shouldn't be too hard to write you a detailed script for

Re: [PATCH v1 4/5] mm: memcg: charge memcg percpu memory to the parent cgroup

2020-06-05 Thread Dennis Zhou
On Thu, May 28, 2020 at 04:25:07PM -0700, Roman Gushchin wrote: > Memory cgroups are using large chunks of percpu memory to store > vmstat data. Yet this memory is not accounted at all, so in the > case when there are many (dying) cgroups, it's not exactly clear > where all the memory is. > >

Re: [PATCH] IMA: Add log statements for failure conditions

2020-06-05 Thread Lakshmi Ramasubramanian
On 6/5/20 12:37 PM, Paul Moore wrote: If it's audit related, it's generally best to CC the linux-audit list, not just me (fixed). It's not clear to me what this pr_err() is trying to indicate other than *something* failed. Can someone provide some more background on this message?

Re: [PATCH v1 3/5] mm: memcg/percpu: per-memcg percpu memory statistics

2020-06-05 Thread Dennis Zhou
On Thu, May 28, 2020 at 04:25:06PM -0700, Roman Gushchin wrote: > Percpu memory can represent a noticeable chunk of the total > memory consumption, especially on big machines with many CPUs. > Let's track percpu memory usage for each memcg and display > it in memory.stat. > > A percpu allocation

Re: [PATCH v3 5/7] iio: adc: exynos: Use input_device_enabled()

2020-06-05 Thread Michał Mirosław
On Fri, Jun 05, 2020 at 07:33:33PM +0200, Andrzej Pietrasiewicz wrote: > A new helper is available, so use it. Inspecting 'users' member of > input_dev requires taking device's mutex. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/iio/adc/exynos_adc.c | 11 +-- > 1 file

Re: [PATCH v10 5/6] ndctl/papr_scm,uapi: Add support for PAPR nvdimm specific methods

2020-06-05 Thread Ira Weiny
On Fri, Jun 05, 2020 at 05:11:35AM +0530, Vaibhav Jain wrote: > Introduce support for PAPR NVDIMM Specific Methods (PDSM) in papr_scm > module and add the command family NVDIMM_FAMILY_PAPR to the white list > of NVDIMM command sets. Also advertise support for ND_CMD_CALL for the > nvdimm command

Re: [PATCH v1 2/5] mm: memcg/percpu: account percpu memory to memory cgroups

2020-06-05 Thread Dennis Zhou
On Thu, May 28, 2020 at 04:25:05PM -0700, Roman Gushchin wrote: > Percpu memory is becoming more and more widely used by various > subsystems, and the total amount of memory controlled by the percpu > allocator can make a good part of the total memory. > > As an example, bpf maps can consume a

Re: [PATCH v10 4/6] powerpc/papr_scm: Improve error logging and handling papr_scm_ndctl()

2020-06-05 Thread Dan Williams
On Fri, Jun 5, 2020 at 10:13 AM Ira Weiny wrote: > > On Fri, Jun 05, 2020 at 05:11:34AM +0530, Vaibhav Jain wrote: > > Since papr_scm_ndctl() can be called from outside papr_scm, its > > exposed to the possibility of receiving NULL as value of 'cmd_rc' > > argument. This patch updates

[PATCH] kexec: dump kmessage before machine_kexec

2020-06-05 Thread Pavel Tatashin
kmsg_dump(KMSG_DUMP_SHUTDOWN) is called before machine_restart(), machine_halt(), machine_power_off(), the only one that is missing is machine_kexec(). The dmesg output that it contains can be used to study the shutdown performance of both kernel and systemd during kexec reboot. Here is example

Re: [PATCH v1 1/5] percpu: return number of released bytes from pcpu_free_area()

2020-06-05 Thread Dennis Zhou
On Thu, May 28, 2020 at 04:25:04PM -0700, Roman Gushchin wrote: > To implement accounting of percpu memory we need the information > about the size of freed object. Return it from pcpu_free_area(). > > Signed-off-by: Roman Gushchin > --- > mm/percpu.c | 13 ++--- > 1 file changed, 10

Re: [RFT][PATCH] ACPI: OSL: Use rwlock instead of RCU for memory management

2020-06-05 Thread Andy Shevchenko
On Fri, Jun 5, 2020 at 5:11 PM Rafael J. Wysocki wrote: ... > + if (!refcount) { > + write_lock_irq(_ioremaps_list_lock); > + > + list_del(>list); > + > + write_unlock_irq(_ioremaps_list_lock); > + } > return refcount; It seems we

Re: [PATCH] IMA: Add log statements for failure conditions

2020-06-05 Thread Paul Moore
On Fri, Jun 5, 2020 at 2:46 PM Mimi Zohar wrote: > > [Cc'ing Paul Moore] If it's audit related, it's generally best to CC the linux-audit list, not just me (fixed). It's not clear to me what this pr_err() is trying to indicate other than *something* failed. Can someone provide some more

Re: [PATCH 2/2][RFC] PM-runtime: add tracepoints to cover all usage_count changes

2020-06-05 Thread Michal Miroslaw
On Sat, Jun 06, 2020 at 03:05:52AM +0800, Chen Yu wrote: > Commit d229290689ae ("PM-runtime: add tracepoints for usage_count changes") > has added some tracepoints to monitor the change of runtime usage, and > there is something to improve: > 1. There are some places that adjust the usage count

Re: [PATCH v2] docs: deprecated.rst: Add zero-length and one-element arrays

2020-06-05 Thread Kees Cook
On Fri, Jun 05, 2020 at 11:21:42AM -0500, Gustavo A. R. Silva wrote: > Add zero-length and one-element arrays to the list. > > While I continue replacing zero-length and one-element arrays with > flexible-array members, I need a reference to point people to, so > they don't introduce more

<    1   2   3   4   5   6   7   8   9   10   >