Re: [PATCH v2] x86/asm: Replace __force_order with memory clobber

2020-09-02 Thread Arvind Sankar
On Wed, Sep 02, 2020 at 08:19:25PM +0200, Miguel Ojeda wrote: > On Wed, Sep 2, 2020 at 5:33 PM Arvind Sankar wrote: > > > > + * The compiler should not reorder volatile asm, however older versions of > > GCC > > + * had a bug (which was fixed in 8.1, 7.3 and 6.5) where they could > > sometimes

Re: [PATCH] kconfig: streamline_config.pl: check defined(ENV variable) before using it

2020-09-02 Thread Nathan Royce
Thanks, but I'd just as soon not be acknowledged/credited. All I did was submit a report. On Wed, Sep 2, 2020 at 11:47 AM Masahiro Yamada wrote: > > Applied to linux-kbuild/fixes with Nathan's tag > > Reported-by: Nathan Royce > > > > Nathan, > I think adding your tag is OK to credit your

Re: [PATCH 2/7] arm64: dts: ti: k3-am65*: Use generic clock for serdes clock name

2020-09-02 Thread Nishanth Menon
On 12:45-20200902, Suman Anna wrote: > On 9/1/20 5:30 PM, Nishanth Menon wrote: > > Use clock@ naming for nodes following standard conventions of device > > tree (section 2.2.2 Generic Names recommendation in [1]). > > > > [1] https://github.com/devicetree-org/devicet

Re: [RFC PATCH] tools/x86: add kcpuid tool to show raw CPU features

2020-09-02 Thread Borislav Petkov
On Wed, Sep 02, 2020 at 10:18:38AM -0700, Dave Hansen wrote: > All good points. > > Personally, I think I'd be OK if kcpuid _focused_ on single-bit values > only. Those are the vast majority of the things that we need from such > a tool. I don't think there's nearly as much demand for the

Re: [PATCH v2] x86/asm: Replace __force_order with memory clobber

2020-09-02 Thread Miguel Ojeda
On Wed, Sep 2, 2020 at 5:33 PM Arvind Sankar wrote: > > + * The compiler should not reorder volatile asm, however older versions of > GCC > + * had a bug (which was fixed in 8.1, 7.3 and 6.5) where they could sometimes > + * reorder volatile asm. The write functions are not a problem since they

Re: [PATCH 6/7] arm64: dts: ti: k3-*: Use generic adc for node names

2020-09-02 Thread Nishanth Menon
On 11:51-20200902, Suman Anna wrote: > On 9/1/20 5:30 PM, Nishanth Menon wrote: > > Use adc@ naming for nodes following standard conventions of device > > tree (section 2.2.2 Generic Names recommendation in [1]). > > > > [1] https://github.com/devicetree-org/devicet

WARNING: ODEBUG bug in process_one_work (2)

2020-09-02 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:4d41ead6 Merge tag 'block-5.9-2020-08-28' of git://git.ker.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1196ce6190 kernel config: https://syzkaller.appspot.com/x/.config?x=978db74cb30aa994

Re: [PATCH net-next] net: dp83869: Add ability to advertise Fiber connection

2020-09-02 Thread Dan Murphy
On 9/2/20 8:25 AM, Dan Murphy wrote: Add the ability to advertise the Fiber connection if the strap or the op-mode is configured for 100Base-FX. Auto negotiation is not supported on this PHY when in fiber mode. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 35

Re: [PATCH 3/5] KVM: nVMX: Update VMX controls MSR according to guest CPUID after setting VMX MSRs

2020-09-02 Thread Sean Christopherson
On Fri, Aug 28, 2020 at 01:39:39PM -0700, Jim Mattson wrote: > On Fri, Aug 28, 2020 at 1:54 AM Chenyi Qiang wrote: > > > > Update the fields (i.e. VM_{ENTRY_LOAD, EXIT_CLEAR}_BNDCFGS and > > VM_{ENTRY, EXIT}_LOAD_IA32_PERF_GLOBAL_CTRL) in > > nested MSR_IA32_VMX_TRUE_{ENTRY, EXIT}_CTLS according

Re: [PATCH 7/7] arm64: dts: ti: k3-*: Fix up node_name_chars_strict errors

2020-09-02 Thread Nishanth Menon
On 11:54-20200902, Suman Anna wrote: > On 9/1/20 5:30 PM, Nishanth Menon wrote: > > Building with W=2 throws up a bunch of easy to fixup errors.. > > node_name_chars_strict is one of them.. Knock those out. > > > > Signed-off-by: Nishanth Menon > > --- &g

Re: [PATCH][next] staging: media: atomisp: fix memory leak of object flash

2020-09-02 Thread Andy Shevchenko
On Wed, Sep 2, 2020 at 8:02 PM Colin King wrote: > > From: Colin Ian King > > In the case where the call to lm3554_platform_data_func returns an > error there is a memory leak on the error return path of object > flash. Fix this by adding an error return path that will free > flash and rename

Re: [PATCH 5/7] arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for node name

2020-09-02 Thread Nishanth Menon
On 11:55-20200902, Suman Anna wrote: > On 9/1/20 5:30 PM, Nishanth Menon wrote: > > Use temperature-sensor@ naming for nodes following standard conventions of > > device > > tree (section 2.2.2 Generic Names recommendation in [1]). > > > > [1] https://git

Re: [PATCH v2 2/2] MAINTAINERS: Move Hartmut Knaack to Credits

2020-09-02 Thread Andy Shevchenko
On Wed, Sep 2, 2020 at 6:01 PM Krzysztof Kozlowski wrote: > > Hartmut Knaack was an active reviewer and contributor to the IIO > subsystem and drivers. However his last message on LKML is from > October 2015. > > In thanks for Hartmut's effort, move him name to the Credits. Reviewed-by: Andy

[PATCH v4 3/4] arm64: dts: rockchip: rk3328 usb3 controller node

2020-09-02 Thread lindsey . stanpoor
From: Cameron Nemo RK3328 SoCs have one USB 3.0 OTG controller which uses DWC_USB3 core's general architecture. It can act as static xHCI host controller, static device controller, USB 3.0/2.0 OTG basing on ID of USB3.0 PHY. Signed-off-by: William Wu Signed-off-by: Heiko Stuebner

[PATCH v4 4/4] arm64: dts: rockchip: enable rk3328-rock64 usb3 nodes

2020-09-02 Thread lindsey . stanpoor
From: Cameron Nemo Enable USB3 nodes for the rk3328-based PINE Rock64 board. Signed-off-by: Heiko Stuebner Signed-off-by: Cameron Nemo --- arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH v4 2/4] usb: dwc3: of-simple: Add compatible for rk3328

2020-09-02 Thread lindsey . stanpoor
From: Cameron Nemo Add a compatible to be hooked into by the Rockchip rk3328 device tree. The rk3399 compatible cannot be reused because the rk3328 SoCs may require a specialized driver in the future, and old device trees must remain compatible with newer kernels. Signed-off-by: Cameron Nemo

[PATCH v4 1/4] dt-bindings: usb: add rk3328 dwc3 docs

2020-09-02 Thread lindsey . stanpoor
From: Cameron Nemo Document compatible for dwc3 on the Rockchip rk3328 platform. Signed-off-by: Cameron Nemo --- Documentation/devicetree/bindings/usb/dwc3.txt | 1 + Documentation/devicetree/bindings/usb/rockchip,dwc3.txt | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)

Re: [PATCH v2 1/2] MAINTAINERS: Consolidate Analog Devices IIO entries and remove Beniamin Bia

2020-09-02 Thread Andy Shevchenko
On Wed, Sep 2, 2020 at 6:04 PM Krzysztof Kozlowski wrote: > > Emails to Beniamin Bia bounce with no such address so remove him from > maintainers. After this removal, many entries for Analog Devices Inc > IIO drivers look exactly the same so consolidate them. > Reviewed-by: Andy Shevchenko But

[RFC PATCH 07/16] mm: stats: make smap stats understand PUD THPs.

2020-09-02 Thread Zi Yan
From: Zi Yan Signed-off-by: Zi Yan --- fs/proc/task_mmu.c | 63 ++ 1 file changed, 58 insertions(+), 5 deletions(-) diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 7fc9b3cc48d3..2ff80a9c8b57 100644 --- a/fs/proc/task_mmu.c +++

[RFC PATCH 11/16] mm: thp: 1GB THP follow_p*d_page() support.

2020-09-02 Thread Zi Yan
From: Zi Yan Add follow_page support for 1GB THPs. Signed-off-by: Zi Yan --- include/linux/huge_mm.h | 11 +++ mm/gup.c| 60 - mm/huge_memory.c| 73 - 3 files changed, 142 insertions(+), 2

Re: [RFC PATCH] USB: misc: Add usb_hub_pwr driver

2020-09-02 Thread Matthias Kaehlcke
Hi Greg, On Wed, Sep 02, 2020 at 08:07:44AM +0200, Greg Kroah-Hartman wrote: > On Tue, Sep 01, 2020 at 01:21:43PM -0700, Matthias Kaehlcke wrote: > > diff --git a/drivers/usb/misc/Makefile b/drivers/usb/misc/Makefile > > index da39bddb0604..2bd02388ca62 100644 > > --- a/drivers/usb/misc/Makefile

[RFC PATCH 09/16] mm: thp: 1GB THP support in try_to_unmap().

2020-09-02 Thread Zi Yan
From: Zi Yan Unmap different subpages in different sized THPs properly in the try_to_unmap() function. Signed-off-by: Zi Yan --- mm/migrate.c | 2 +- mm/rmap.c| 159 +-- 2 files changed, 116 insertions(+), 45 deletions(-) diff --git

Re: [PATCH v2 5/9] libperf: Add support for user space counter access

2020-09-02 Thread Ian Rogers
On Fri, Aug 28, 2020 at 1:56 PM Rob Herring wrote: > > x86 and arm64 can both support direct access of event counters in > userspace. The access sequence is less than trivial and currently exists > in perf test code (tools/perf/arch/x86/tests/rdpmc.c) with copies in > projects such as PAPI and

[RFC PATCH 12/16] mm: support 1GB THP pagemap support.

2020-09-02 Thread Zi Yan
From: Zi Yan Print page flags properly. Signed-off-by: Zi Yan --- fs/proc/task_mmu.c | 59 ++ 1 file changed, 59 insertions(+) diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 2ff80a9c8b57..7254c7ecf659 100644 --- a/fs/proc/task_mmu.c +++

[RFC PATCH 14/16] mm: page_alloc: >=MAX_ORDER pages allocation an deallocation.

2020-09-02 Thread Zi Yan
From: Zi Yan Use alloc_contig_pages for allocation and destroy_compound_gigantic_page for deallocation, so 1GB THP can be created and destroyed without changing MAX_ORDER. Signed-off-by: Zi Yan --- mm/hugetlb.c| 22 -- mm/internal.h | 2 ++ mm/mempolicy.c | 15

[RFC PATCH 13/16] mm: thp: add a knob to enable/disable 1GB THPs.

2020-09-02 Thread Zi Yan
From: Zi Yan It does not affect existing 1GB THPs. It is similar to the knob for 2MB THPs. Signed-off-by: Zi Yan --- include/linux/huge_mm.h | 14 ++ mm/huge_memory.c| 40 mm/memory.c | 2 +- 3 files changed, 55

[RFC PATCH 06/16] mm: thp: add 1GB THP split_huge_pud_page() function.

2020-09-02 Thread Zi Yan
From: Zi Yan It mimics PMD-level THP split. In addition, to support PMD-mapped PUD THP, PMDPageInPUD() is used. For the mapcount of PMD-mapped PUD THP, sub_compound_mapcount() is used, which uses (head_page+3).compound_mapcount, since each base page's mapcount is used for PTE mapping.

[RFC PATCH 16/16] mm: thp: use cma reservation for pud thp allocation.

2020-09-02 Thread Zi Yan
From: Zi Yan Sharing hugepage_cma reservation with hugetlb for pud thp allocaiton. The reserved cma regions still can be used for moveable page allocations. During 1GB page split, all subpages are cleared from the CMA bitmap, since they are no more 1GB pages and will be freed via the normal

drivers/video/fbdev/sstfb.c:337:23: sparse: expected void

2020-09-02 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 9c7d619be5a002ea29c172df5e3c1227c22cbb41 commit: 80591e61a0f7e88deaada69844e4a31280c4a38f kbuild: tell sparse about the $ARCH date: 10 months ago config: s390-randconfig-s031-20200902 (attached as .config

[RFC PATCH 15/16] hugetlb: cma: move cma reserve function to cma.c.

2020-09-02 Thread Zi Yan
From: Zi Yan It will be used by other allocations, like 1GB THP allocation in the upcoming commit. Signed-off-by: Zi Yan --- .../admin-guide/kernel-parameters.txt | 2 +- arch/arm64/mm/hugetlbpage.c | 2 +- arch/powerpc/mm/hugetlbpage.c | 2 +-

[RFC PATCH 05/16] mm: thp: handling 1GB THP reference bit.

2020-09-02 Thread Zi Yan
From: Zi Yan Add PUD-level TLB flush ops and teach page_vma_mapped_talk about 1GB THPs. Signed-off-by: Zi Yan --- arch/x86/include/asm/pgtable.h | 3 +++ arch/x86/mm/pgtable.c | 13 + include/linux/mmu_notifier.h | 13 + include/linux/pgtable.h| 14

[RFC PATCH 08/16] mm: page_vma_walk: teach it about PMD-mapped PUD THP.

2020-09-02 Thread Zi Yan
From: Zi Yan We now have PMD-mapped PUD THP and PTE-mapped PUD THP, page_vma_walk should handle them properly. Signed-off-by: Zi Yan --- mm/page_vma_mapped.c | 116 ++- 1 file changed, 82 insertions(+), 34 deletions(-) diff --git a/mm/page_vma_mapped.c

[RFC PATCH 10/16] mm: thp: split 1GB THPs at page reclaim.

2020-09-02 Thread Zi Yan
From: Zi Yan We cannot swap 1GB THPs, so split them before swap them out. Signed-off-by: Zi Yan --- mm/swap_slots.c | 2 ++ mm/vmscan.c | 58 + 2 files changed, 46 insertions(+), 14 deletions(-) diff --git a/mm/swap_slots.c

[RFC PATCH 00/16] 1GB THP support on x86_64

2020-09-02 Thread Zi Yan
From: Zi Yan Hi all, This patchset adds support for 1GB THP on x86_64. It is on top of v5.9-rc2-mmots-2020-08-25-21-13. 1GB THP is more flexible for reducing translation overhead and increasing the performance of applications with large memory footprint without application changes compared to

[RFC PATCH 02/16] mm: thp: 1GB anonymous page implementation.

2020-09-02 Thread Zi Yan
From: Zi Yan This adds 1GB THP support for anonymous pages. Applications can get 1GB pages during page faults when their VMAs are larger than 1GB. For read-only 1GB zero THP, a shared 1GB zero THP is created for all readers. Signed-off-by: Zi Yan --- arch/x86/include/asm/pgalloc.h | 59

[RFC PATCH 01/16] mm: add pagechain container for storing multiple pages.

2020-09-02 Thread Zi Yan
From: Zi Yan When depositing page table pages for 1GB THPs, we need 512 PTE pages + 1 PMD page. Instead of counting and depositing 513 pages, we can use the PMD page as a leader page and chain the rest 512 PTE pages with ->lru. This, however, prevents us depositing PMD pages with ->lru, which is

[RFC PATCH 04/16] mm: thp: 1GB THP copy on write implementation.

2020-09-02 Thread Zi Yan
From: Zi Yan COW on 1GB THPs will fall back to 2MB THPs if 1GB THP is not available. Signed-off-by: Zi Yan --- arch/x86/include/asm/pgalloc.h | 9 ++ include/linux/huge_mm.h| 5 mm/huge_memory.c | 54 ++ mm/memory.c

[RFC PATCH 03/16] mm: proc: add 1GB THP kpageflag.

2020-09-02 Thread Zi Yan
From: Zi Yan Bit 27 is used to identify 1GB THP. Signed-off-by: Zi Yan --- fs/proc/page.c | 2 ++ include/uapi/linux/kernel-page-flags.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/fs/proc/page.c b/fs/proc/page.c index f3b39a7d2bf3..e4e2ad3612c9 100644 ---

Re: [linux-sunxi] [PATCH 05/16] ASoc: sun4i-i2s: Add 20 and 24 bit support

2020-09-02 Thread Jernej Škrabec
Hi Samuel! Dne petek, 10. julij 2020 ob 07:44:51 CEST je Samuel Holland napisal(a): > On 7/4/20 6:38 AM, Clément Péron wrote: > > From: Marcus Cooper > > > > Extend the functionality of the driver to include support of 20 and > > 24 bits per sample. > > > > Signed-off-by: Marcus Cooper > >

Re: [PATCH] iio: adc: ad7124: Fix typo in device name

2020-09-02 Thread Andy Shevchenko
On Wed, Sep 2, 2020 at 4:45 PM Mircea Caprioru wrote: > > This patch fixes the device name typo. > Luckily it's part of v5.9-rcX, so if Jonathan sends this within v5.9 time frame, we are good. Reviewed-by: Andy Shevchenko > Fixes: 951ad4700313 ("iio: adc: ad7124: move chip ID & name on the

Re: [PATCH 10/10] powerpc: remove address space overrides using set_fs()

2020-09-02 Thread Linus Torvalds
On Wed, Sep 2, 2020 at 8:17 AM Christophe Leroy wrote: > > > With this fix, I get > > root@vgoippro:~# time dd if=/dev/zero of=/dev/null count=1M > 536870912 bytes (512.0MB) copied, 6.776327 seconds, 75.6MB/s > > That's still far from the 91.7MB/s I get with 5.9-rc2, but better than > the

Re: [PATCH 1/2] powerpc/vdso64: link vdso64 with linker

2020-09-02 Thread Christophe Leroy
Le 02/09/2020 à 19:41, Nick Desaulniers a écrit : On Wed, Sep 2, 2020 at 5:14 AM Michael Ellerman wrote: Nick Desaulniers writes: Fixes: commit f2af201002a8 ("powerpc/build: vdso linker warning for orphan sections") I think I'll just revert that for v5.9 ? SGTM; you'll probably

Re: [PATCH v4 13/78] drm/vc4: kms: Convert to for_each_new_crtc_state

2020-09-02 Thread Maxime Ripard
Hi! On Wed, Jul 29, 2020 at 04:02:06PM +0100, Dave Stevenson wrote: > Hi Maxime > > On Wed, 8 Jul 2020 at 18:42, Maxime Ripard wrote: > > > > The vc4 atomic commit loop has an handrolled loop that is basically > > identical to for_each_new_crtc_state, let's convert it to that helper. > > > >

Re: [PATCH 6/9] i2c: imx: Simplify with dev_err_probe()

2020-09-02 Thread Uwe Kleine-König
On Wed, Sep 02, 2020 at 05:06:40PM +0200, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Uwe Kleine-König Thanks Uwe -- Pengutronix

Re: [Patch v4 5/7] mm/hugetlb: a page from buddy is not on any list

2020-09-02 Thread Vlastimil Babka
On 9/2/20 7:25 PM, Mike Kravetz wrote: > On 9/2/20 3:49 AM, Vlastimil Babka wrote: >> On 9/1/20 3:46 AM, Wei Yang wrote: >>> The page allocated from buddy is not on any list, so just use list_add() >>> is enough. >>> >>> Signed-off-by: Wei Yang >>> Reviewed-by: Baoquan He >>> Reviewed-by: Mike

Re: [PATCH] net: bcmgenet: fix mask check in bcmgenet_validate_flow()

2020-09-02 Thread Florian Fainelli
On 9/2/2020 4:18 AM, Denis Efremov wrote: VALIDATE_MASK(eth_mask->h_source) is checked twice in a row in bcmgenet_validate_flow(). Add VALIDATE_MASK(eth_mask->h_dest) instead. Fixes: 3e370952287c ("net: bcmgenet: add support for ethtool rxnfc flows") Cc: sta...@vger.kernel.org Signed-off-by:

Re: [PATCH -rc 0/4] Protect from GCC garbage input in GCOV

2020-09-02 Thread Leon Romanovsky
On Wed, Sep 02, 2020 at 10:42:55AM -0700, Linus Torvalds wrote: > On Wed, Sep 2, 2020 at 1:55 AM Leon Romanovsky wrote: > > > > Bottom line, GCOV is broken on GCC 10.2. > > The patches don't really make sense to me. > > How about we just disable GCOV with the known-broken compiler version >

Re: [PATCH] mm/memory_hotplug: drain per-cpu pages again during memory offline

2020-09-02 Thread Vlastimil Babka
On 9/2/20 5:13 PM, Michal Hocko wrote: > On Wed 02-09-20 16:55:05, Vlastimil Babka wrote: >> On 9/2/20 4:26 PM, Pavel Tatashin wrote: >> > On Wed, Sep 2, 2020 at 10:08 AM Michal Hocko wrote: >> >> >> >> > >> >> > Thread#1 - continue >> >> > free_unref_page_commit >> >> >

Re: [PATCH] net: bcmgenet: fix mask check in bcmgenet_validate_flow()

2020-09-02 Thread Doug Berger
On 9/2/2020 4:18 AM, Denis Efremov wrote: > VALIDATE_MASK(eth_mask->h_source) is checked twice in a row in > bcmgenet_validate_flow(). Add VALIDATE_MASK(eth_mask->h_dest) > instead. > > Fixes: 3e370952287c ("net: bcmgenet: add support for ethtool rxnfc flows") > Cc: sta...@vger.kernel.org >

[PATCH 2/2] irqchip/ti-sci-inta: Fix kerneldoc

2020-09-02 Thread Krzysztof Kozlowski
Fix kerneldoc W=1 warnings: drivers/irqchip/irq-ti-sci-inta.c:144: warning: Function parameter or member 'vint_id' not described in 'ti_sci_inta_xlate_irq' drivers/irqchip/irq-ti-sci-inta.c:144: warning: Excess function parameter 'irq' description in 'ti_sci_inta_xlate_irq' Signed-off-by:

[PATCH 1/2] irqchip/ti-sci: Simplify with dev_err_probe()

2020-09-02 Thread Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. There is also no need to assign NULL to 'intr->sci' as it is part of devm-allocated memory. Signed-off-by: Krzysztof Kozlowski --- drivers/irqchip/irq-ti-sci-inta.c |

Re: [PATCH 2/7] arm64: dts: ti: k3-am65*: Use generic clock for serdes clock name

2020-09-02 Thread Suman Anna
On 9/1/20 5:30 PM, Nishanth Menon wrote: > Use clock@ naming for nodes following standard conventions of device > tree (section 2.2.2 Generic Names recommendation in [1]). > > [1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3 > > Suggested-by: Suman Anna > Signed-off-by:

Re: [RFC PATCH] USB: misc: Add usb_hub_pwr driver

2020-09-02 Thread Matthias Kaehlcke
Hi Peter, On Wed, Sep 02, 2020 at 05:31:06AM +, Peter Chen wrote: > On 20-09-01 13:21:43, Matthias Kaehlcke wrote: > > The driver combo usb_hub_pwr/usb_hub_psupply allows to control > > the power supply of an onboard USB hub. > > > > The drivers address two issues: > > - a USB hub needs to

Re: [PATCH rdma-next 1/4] gcov: Open-code kmemdup() to work correctly with kernel and user space pointers

2020-09-02 Thread Leon Romanovsky
On Wed, Sep 02, 2020 at 10:38:20AM -0700, Linus Torvalds wrote: > On Wed, Sep 2, 2020 at 1:55 AM Leon Romanovsky wrote: > > > > The kernel with KASAN and GCOV enabled generates the following splat > > due to the situation that gcov_info can be both user and kernel pointer. > > I can't parse the

Re: [PATCH 1/2] phy: marvell: comphy: Convert internal SMCC firmware return codes to errno

2020-09-02 Thread Pali Rohár
On Wednesday 02 September 2020 19:20:29 Andrew Lunn wrote: > On Wed, Sep 02, 2020 at 07:05:25PM +0200, Pali Rohár wrote: > > On Wednesday 02 September 2020 19:00:10 Andrew Lunn wrote: > > > > > > + switch (ret) { > > > > > > + case SMCCC_RET_SUCCESS: > > > > > > + return 0; > > > > >

Re: [PATCH -rc 0/4] Protect from GCC garbage input in GCOV

2020-09-02 Thread Linus Torvalds
On Wed, Sep 2, 2020 at 1:55 AM Leon Romanovsky wrote: > > Bottom line, GCOV is broken on GCC 10.2. The patches don't really make sense to me. How about we just disable GCOV with the known-broken compiler version instead? As mentioned in the replies to individual patches, it looks like the

Re: [PATCH] Fix khugepaged's request size in collapse_file()

2020-09-02 Thread Yang Shi
On Wed, Sep 2, 2020 at 7:16 AM David Howells wrote: > > collapse_file() in khugepaged passes PAGE_SIZE as the number of pages to be > read ahead to page_cache_sync_readahead(). It seems this was expressed as a > number of bytes rather than a number of pages. > > Fix it to use the number of pages

Re: [PATCH rdma-next 3/4] gcov: Protect from uninitialized number of functions provided by GCC 10.2

2020-09-02 Thread Linus Torvalds
On Wed, Sep 2, 2020 at 1:55 AM Leon Romanovsky wrote: > > This trace is seen because n_function value provided by GCC through > __gcov_init() is ridiculously high, in my case it was 2698213824, > which probably means that the field is not initialized. This seems to be wrong - since a different

Re: [PATCH 1/2] powerpc/vdso64: link vdso64 with linker

2020-09-02 Thread Nick Desaulniers
On Wed, Sep 2, 2020 at 5:14 AM Michael Ellerman wrote: > > Nick Desaulniers writes: > > Fixes: commit f2af201002a8 ("powerpc/build: vdso linker warning for orphan > > sections") > > I think I'll just revert that for v5.9 ? SGTM; you'll probably still want these changes with some modifications

Re: [PATCH v2 0/3] arm64: Convert to ARCH_STACKWALK

2020-09-02 Thread Mark Brown
On Tue, Sep 01, 2020 at 05:06:26PM +0100, Mark Rutland wrote: > Just to check, has the skipping logic been tested to work equivalently > to what we had before? By inspection I think it should, but since it > relies on function call boundaries it always strikes me as fragile. > If you could

Re: [PATCH rdma-next 1/4] gcov: Open-code kmemdup() to work correctly with kernel and user space pointers

2020-09-02 Thread Linus Torvalds
On Wed, Sep 2, 2020 at 1:55 AM Leon Romanovsky wrote: > > The kernel with KASAN and GCOV enabled generates the following splat > due to the situation that gcov_info can be both user and kernel pointer. I can't parse the above explanation.. > It is triggered by the memcpy() inside kmemdup(), so

Re: [PATCH v2] x86/asm: Replace __force_order with memory clobber

2020-09-02 Thread Arvind Sankar
On Wed, Sep 02, 2020 at 12:16:24PM -0500, Segher Boessenkool wrote: > On Wed, Sep 02, 2020 at 11:33:46AM -0400, Arvind Sankar wrote: > > The CRn accessor functions use __force_order as a dummy operand to > > prevent the compiler from reordering the inline asm. > > > > The fact that the asm is

Re: [Patch v4 5/7] mm/hugetlb: a page from buddy is not on any list

2020-09-02 Thread Mike Kravetz
On 9/2/20 3:49 AM, Vlastimil Babka wrote: > On 9/1/20 3:46 AM, Wei Yang wrote: >> The page allocated from buddy is not on any list, so just use list_add() >> is enough. >> >> Signed-off-by: Wei Yang >> Reviewed-by: Baoquan He >> Reviewed-by: Mike Kravetz >> --- >> mm/hugetlb.c | 2 +- >> 1

[PATCH 2/2] interconnect: imx: Simplify with dev_err_probe()

2020-09-02 Thread Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski --- drivers/interconnect/imx/imx.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH 1/2] interconnect: core: Simplify with dev_err_probe()

2020-09-02 Thread Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski --- drivers/interconnect/core.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

Re: general protection fault in snd_ctl_release

2020-09-02 Thread Takashi Iwai
On Wed, 02 Sep 2020 17:46:58 +0200, Takashi Iwai wrote: > > > See vfs.git#work.epoll > > for fix > > Thanks! I'll try to run with this fix. Just confirming that the patch worked. And I saw you've already sent a pull request to Linus, thanks! Takashi

Re: [PATCH] x86/uaccess: Use pointer masking to limit uaccess speculation

2020-09-02 Thread Mark Rutland
On Wed, Sep 02, 2020 at 03:32:31PM +0200, Christoph Hellwig wrote: > On Wed, Sep 02, 2020 at 12:43:48PM +0100, Mark Rutland wrote: > > I'll see what I can do. > > > > At first glance it looks like we might need to flesh out or refactor the > > arm64 kernel maccess routines first (since we want

Re: [PATCH 1/2] phy: marvell: comphy: Convert internal SMCC firmware return codes to errno

2020-09-02 Thread Andrew Lunn
On Wed, Sep 02, 2020 at 07:05:25PM +0200, Pali Rohár wrote: > On Wednesday 02 September 2020 19:00:10 Andrew Lunn wrote: > > > > > + switch (ret) { > > > > > + case SMCCC_RET_SUCCESS: > > > > > + return 0; > > > > > + case SMCCC_RET_NOT_SUPPORTED: > > > > > +

Re: [RFC PATCH] tools/x86: add kcpuid tool to show raw CPU features

2020-09-02 Thread Dave Hansen
On 9/2/20 9:52 AM, Borislav Petkov wrote: >> I was *really* hoping that we could eventually feed kcpuid and the >> X86_FEATURE_* bits from the same source. > But X86_FEATURE_* won't be all bits in all CPUID leafs - only the ones the > kernel has enabled/use for/needs/... > > Also you have CPUID

Re: [PATCH v2] x86/asm: Replace __force_order with memory clobber

2020-09-02 Thread Segher Boessenkool
On Wed, Sep 02, 2020 at 11:33:46AM -0400, Arvind Sankar wrote: > The CRn accessor functions use __force_order as a dummy operand to > prevent the compiler from reordering the inline asm. > > The fact that the asm is volatile should be enough to prevent this > already, however older versions of

[PATCHv3 net-next] dropwatch: Support monitoring of dropped frames

2020-09-02 Thread izabela . bakollari
From: Izabela Bakollari Dropwatch is a utility that monitors dropped frames by having userspace record them over the dropwatch protocol over a file. This augument allows live monitoring of dropped frames using tools like tcpdump. With this feature, dropwatch allows two additional commands

Re: [PATCH v2 2/2] staging: gdm724x: gdm_tty: replaced macro with a function

2020-09-02 Thread Randy Dunlap
On 9/2/20 10:07 AM, antoni.przyby...@wp.pl wrote: > On 02.09.2020 18:21, Randy Dunlap wrote: >> On 9/2/20 9:16 AM, Antoni Przybylik wrote: >>> Changed return type to bool and removed inline specifier. Also added >>>   static specifier. >> why remove the inline specifier? > > Greg KH wrote to me:

Re: [PATCH v11 5/5] kdump: update Documentation about crashkernel

2020-09-02 Thread Catalin Marinas
On Sat, Aug 01, 2020 at 09:08:56PM +0800, Chen Zhou wrote: > diff --git a/Documentation/admin-guide/kdump/kdump.rst > b/Documentation/admin-guide/kdump/kdump.rst > index 2da65fef2a1c..4b58f97351d5 100644 > --- a/Documentation/admin-guide/kdump/kdump.rst > +++

Re: [PATCH v11 3/5] arm64: kdump: reimplement crashkernel=X

2020-09-02 Thread Catalin Marinas
On Sat, Aug 01, 2020 at 09:08:54PM +0800, Chen Zhou wrote: > There are following issues in arm64 kdump: > 1. We use crashkernel=X to reserve crashkernel below 4G, which > will fail when there is no enough low memory. > 2. If reserving crashkernel above 4G, in this case, crash dump > kernel will

Re: [PATCH v2 3/4] kselftests/arm64: add PAuth test for whether exec() changes keys

2020-09-02 Thread Dave Martin
On Mon, Aug 31, 2020 at 12:04:49PM +0100, Boyan Karatotev wrote: > Kernel documentation states that it will change PAuth keys on exec() calls. > > Verify that all keys are correctly switched to new ones. > > Cc: Shuah Khan > Cc: Catalin Marinas > Cc: Will Deacon > Reviewed-by: Vincenzo

Re: [PATCH v7 2/5] perf/jevents: Add new structure to pass json fields.

2020-09-02 Thread John Garry
On 02/09/2020 17:04, Kajol Jain wrote: This patch adds new structure called 'json_event' inside jevents.h file to improve the callback prototype inside jevent files. Initially, whenever user want to add new field, they need to update in all function callback which make it more and more complex

[PATCH] padata: fix possible padata_works_lock deadlock

2020-09-02 Thread Daniel Jordan
syzbot reports, WARNING: inconsistent lock state 5.9.0-rc2-syzkaller #0 Not tainted inconsistent {IN-SOFTIRQ-W} -> {SOFTIRQ-ON-W} usage. syz-executor.0/26715 takes: (padata_works_lock){+.?.}-{2:2}, at: padata_do_parallel kernel/padata.c:220

Re: [PATCH v2 2/2] staging: gdm724x: gdm_tty: replaced macro with a function

2020-09-02 Thread antoni.przyby...@wp.pl
On 02.09.2020 18:21, Randy Dunlap wrote: On 9/2/20 9:16 AM, Antoni Przybylik wrote: Changed return type to bool and removed inline specifier. Also added static specifier. why remove the inline specifier? Greg KH wrote to me: And really, no need to make it inline, just make it a normal

Re: [PATCH 1/2] phy: marvell: comphy: Convert internal SMCC firmware return codes to errno

2020-09-02 Thread Pali Rohár
On Wednesday 02 September 2020 19:00:10 Andrew Lunn wrote: > > > > + switch (ret) { > > > > + case SMCCC_RET_SUCCESS: > > > > + return 0; > > > > + case SMCCC_RET_NOT_SUPPORTED: > > > > + return -EOPNOTSUPP; > > > > + default: > > > > +

Re: [PATCH V3 4/6] perf tools: Add FIFO file names as alternative options to --control

2020-09-02 Thread Alexey Budankov
On 02.09.2020 13:57, Adrian Hunter wrote: > Enable the --control option to accept file names as an alternative to > file descriptors. > > Example: > > $ mkfifo perf.control > $ mkfifo perf.ack > $ cat perf.ack & > [1] 6808 > $ perf record --control fifo:perf.control,perf.ack -- sleep 300

Re: [PATCH v7 1/5] perf/jevents: Remove jevents.h file

2020-09-02 Thread John Garry
On 02/09/2020 17:04, Kajol Jain wrote: This patch removes jevents.h file. Signed-off-by: Kajol Jain Reviewed-by: John Garry

Re: [PATCH V2 5/6] perf record: Add 'snapshot' control command

2020-09-02 Thread Alexey Budankov
On 01.09.2020 12:37, Adrian Hunter wrote: > Add 'snapshot' control command to create an AUX area tracing snapshot the > same as if sending SIGUSR2. The advantage of the FIFO is that access is > governed by access to the FIFO. > > Example: > > $ mkfifo perf.control > $ mkfifo perf.ack > $

Re: [PATCH] x86/special_insn: reverse __force_order logic

2020-09-02 Thread Nadav Amit
> On Sep 2, 2020, at 9:56 AM, pet...@infradead.org wrote: > > On Wed, Sep 02, 2020 at 03:32:18PM +, Nadav Amit wrote: > >> Thanks for pointer. I did not see the discussion, and embarrassingly, I have >> also never figured out how to reply on lkml emails without registering to >> lkml. > >

Re: [PATCH 01/13] x86/entry: Fix AC assertion

2020-09-02 Thread Brian Gerst
On Wed, Sep 2, 2020 at 12:31 PM wrote: > > On Wed, Sep 02, 2020 at 06:24:27PM +0200, Jürgen Groß wrote: > > On 02.09.20 17:58, Brian Gerst wrote: > > > On Wed, Sep 2, 2020 at 9:38 AM Peter Zijlstra > > > wrote: > > > > > > > > From: Peter Zijlstra > > > > > > > > The WARN added in commit

Re: [RFC PATCH] tools/x86: add kcpuid tool to show raw CPU features

2020-09-02 Thread peterz
On Wed, Sep 02, 2020 at 06:55:01PM +0200, Borislav Petkov wrote: > On Wed, Sep 02, 2020 at 06:45:38PM +0200, pet...@infradead.org wrote: > > We really should clear the CPUID bits when the kernel explicitly > > disables things. > > Actually, you want to *disable* the functionality behind it by

Re: [PATCH 3/4] kselftests/arm64: add PAuth test for whether exec() changes keys

2020-09-02 Thread Dave Martin
On Fri, Aug 28, 2020 at 02:16:05PM +0100, Boyan Karatotev wrote: > Kernel documentation states that it will change PAuth keys on exec() calls. > > Verify that all keys are correctly switched to new ones. > > Cc: Shuah Khan > Cc: Catalin Marinas > Cc: Will Deacon > Signed-off-by: Boyan

[PATCH v2 2/7] mm/migrate: move migrate_vma_collect_skip()

2020-09-02 Thread Ralph Campbell
Move the definition of migrate_vma_collect_skip() to make it callable by migrate_vma_collect_hole(). This helps make the next patch easier to read. Signed-off-by: Ralph Campbell --- mm/migrate.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git

Re: [PATCH v2 5/9] libperf: Add support for user space counter access

2020-09-02 Thread Rob Herring
On Mon, Aug 31, 2020 at 3:11 AM Jiri Olsa wrote: > > On Fri, Aug 28, 2020 at 02:56:10PM -0600, Rob Herring wrote: > > SNIP > > > > > +void *perf_evsel__mmap(struct perf_evsel *evsel) > > +{ > > + int ret; > > + struct perf_mmap *map; > > + struct perf_mmap_param mp = { > > +

Re: WARNING: suspicious RCU usage - sdhci-pltfm: SDHCI platform and OF driver helper

2020-09-02 Thread Paul E. McKenney
On Wed, Sep 02, 2020 at 06:07:05PM +0200, Ulf Hansson wrote: > On Wed, 2 Sep 2020 at 15:52, Paul E. McKenney wrote: > > > > On Wed, Sep 02, 2020 at 08:49:11AM +0200, Ulf Hansson wrote: > > > On Tue, 1 Sep 2020 at 17:00, Paul E. McKenney wrote: > > > > [ . . . ] > > > > > > Here is the list,

[PATCH v2 3/7] mm: support THP migration to device private memory

2020-09-02 Thread Ralph Campbell
Support transparent huge page migration to ZONE_DEVICE private memory. A new selection flag (MIGRATE_VMA_SELECT_COMPOUND) is added to request THP migration. Otherwise, THPs are split when filling in the source PFN array. A new flag (MIGRATE_PFN_COMPOUND) is added to the source PFN array to

[PATCH v2 0/7] mm/hmm/nouveau: add THP migration to migrate_vma_*

2020-09-02 Thread Ralph Campbell
This series adds support for transparent huge page migration to migrate_vma_*() and adds nouveau SVM and HMM selftests as consumers. An earlier version was posted previously [1]. This version now supports splitting a THP midway in the migration process which led to a number of changes. The

Re: [PATCH v2 5/9] libperf: Add support for user space counter access

2020-09-02 Thread Rob Herring
On Mon, Aug 31, 2020 at 3:11 AM Jiri Olsa wrote: > > On Fri, Aug 28, 2020 at 02:56:10PM -0600, Rob Herring wrote: > > SNIP > > +int perf_mmap__read_self(struct perf_mmap *map, struct perf_counts_values > > *count) > > +{ > > + struct perf_event_mmap_page *pc = map->base; > > + u32 seq,

[GIT PULL] xfs: small fixes for 5.9

2020-09-02 Thread Darrick J. Wong
Hi Linus, Please pull these various corruption fixes that have come in during the past month. The branch merges cleanly with upstream as of a few minutes ago, so please let me know if anything strange happens. --D The following changes since commit 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5:

[PATCH v2 6/7] mm/hmm/test: add self tests for THP migration

2020-09-02 Thread Ralph Campbell
Add some basic stand alone self tests for migrating system memory to device private memory and back. Signed-off-by: Ralph Campbell --- lib/test_hmm.c | 439 + lib/test_hmm_uapi.h| 3 + tools/testing/selftests/vm/hmm-tests.c |

Re: [PATCH 1/2] phy: marvell: comphy: Convert internal SMCC firmware return codes to errno

2020-09-02 Thread Andrew Lunn
> > > + switch (ret) { > > > + case SMCCC_RET_SUCCESS: > > > + return 0; > > > + case SMCCC_RET_NOT_SUPPORTED: > > > + return -EOPNOTSUPP; > > > + default: > > > + return -EINVAL; > > > + } > > > } > > > > Hi Pali > > > > Maybe this should be a global helper translating

Re: [RFC PATCH] tools/x86: add kcpuid tool to show raw CPU features

2020-09-02 Thread peterz
On Wed, Sep 02, 2020 at 09:52:33AM -0700, Dave Hansen wrote: > On 9/2/20 9:45 AM, pet...@infradead.org wrote: > > On Thu, Aug 27, 2020 at 03:49:03PM +0800, Feng Tang wrote: > >> End users frequently want to know what features their processor > >> supports, independent of what the kernel supports.

[PATCH v11 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-09-02 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Ben Levinsky Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek --- v3: - update zynqmp_r5 yaml

[PATCH v11 3/5] firmware: xilinx: Add RPU configuration APIs

2020-09-02 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

[PATCH][next] staging: media: atomisp: fix memory leak of object flash

2020-09-02 Thread Colin King
From: Colin Ian King In the case where the call to lm3554_platform_data_func returns an error there is a memory leak on the error return path of object flash. Fix this by adding an error return path that will free flash and rename labels fail2 to fail3 and fail1 to fail2. Fixes: 9289cdf39992

[PATCH v11 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-09-02 Thread Ben Levinsky
R5 is included in Xilinx Zynq UltraScale MPSoC so by adding this remotproc driver, we can boot the R5 sub-system in different 2 configurations: split or lock-step. The Xilinx R5 Remoteproc Driver boots the R5's via calls to the Xilinx Platform Management Unit that handles the R5 configuration,

<    1   2   3   4   5   6   7   8   9   10   >