Re: [PATCH] s390/vfio-ap: fix unregister GISC when KVM is already gone results in OOPS

2020-09-25 Thread Halil Pasic
On Fri, 25 Sep 2020 18:29:16 -0400 Tony Krowiak wrote: > > > On 9/21/20 11:45 AM, Halil Pasic wrote: > > On Fri, 18 Sep 2020 13:02:34 -0400 > > Tony Krowiak wrote: > > > >> Attempting to unregister Guest Interruption Subclass (GISC) when the > >> link between the matrix mdev and KVM has been r

Re: [PATCH] HID: hid-input: fix stylus battery reporting

2020-09-25 Thread Kenneth Albanowski
[Re-send to appease the mail daemons] Confirmed, I've validated this on a 4.19 derivative, this fixes the problem and battery strength gets reported again. - Kenneth Albanowski On Fri, Sep 25, 2020 at 4:35 PM Dmitry Torokhov wrote: > > With commit 4f3882177240 hid-input started clearing of "ig

Re: [PATCH] HID: hid-input: fix stylus battery reporting

2020-09-25 Thread Jiri Kosina
On Fri, 25 Sep 2020, Dmitry Torokhov wrote: > With commit 4f3882177240 hid-input started clearing of "ignored" usages > to avoid using garbage that might have been left in them. However > "battery strength" usages should not be ignored, as we do want to > use them. > > Fixes: 4f3882177240 ("HID:

Re: [PATCH 02/22] kvm: mmu: Introduce tdp_iter

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > + bool done; > + > + done = try_step_down(iter); > + if (done) > + return; > + > + done = try_step_side(iter); > + while (!done) { > + if (!try_step_up(iter)) { > + iter->valid = false; > +

[PATCH v2] leds: tlc591xx: fix leak of device node iterator

2020-09-25 Thread Tobias Jordan
In one of the error paths of the for_each_child_of_node loop in tlc591xx_probe, add missing call to of_node_put. Fixes: 1ab4531ad132 ("leds: tlc591xx: simplify driver by using the managed led API") Signed-off-by: Tobias Jordan --- v2: rebased to Pavel's for-next branch drivers/leds/leds-tlc591

Re: [PATCH 16/22] kvm: mmu: Add dirty logging handler for changed sptes

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > +static void handle_changed_spte_dlog(struct kvm *kvm, int as_id, gfn_t gfn, > + u64 old_spte, u64 new_spte, int level) > +{ > + bool pfn_changed; > + struct kvm_memory_slot *slot; _dlog is a new abbreviation... I think

Re: [PATCH 1/5] mm: Introduce mm_struct.has_pinned

2020-09-25 Thread Jason Gunthorpe
On Fri, Sep 25, 2020 at 02:06:59PM -0700, Linus Torvalds wrote: > On Fri, Sep 25, 2020 at 12:56 PM Linus Torvalds > wrote: > > > > And honestly, since this is all getting fairly late in the rc, and it > > took longer than I thought, I think we should do the GFP_ATOMIC > > approach for now - not gr

Re: RGMII timing calibration (on 12nm Amlogic SoCs) - integration into dwmac-meson8b

2020-09-25 Thread Andrew Lunn
> The reference code I linked tries to detect the RGMII interface mode. > However, for each board we know the phy-mode as well as the RX and TX > delay - so I'm not trying to port the RGMII interface detection part > to the mainline driver. > > on X96 Air (which I'm using for testing) Amlogic conf

Re: [PATCH 05/22] kvm: mmu: Add functions to handle changed TDP SPTEs

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > + > + /* > + * Recursively handle child PTs if the change removed a subtree from > + * the paging structure. > + */ > + if (was_present && !was_leaf && (pfn_changed || !is_present)) { > + pt = spte_to_child_pt(old_spte, level

Re: [PATCH v2 seccomp 3/6] seccomp/cache: Add "emulator" to check if filter is arg-dependent

2020-09-25 Thread Andy Lutomirski
> On Sep 25, 2020, at 4:49 PM, Kees Cook wrote: > > On Fri, Sep 25, 2020 at 02:07:46PM -0700, Andy Lutomirski wrote: >>> On Fri, Sep 25, 2020 at 1:37 PM Kees Cook wrote: >>> >>> On Fri, Sep 25, 2020 at 12:51:20PM -0700, Andy Lutomirski wrote: > On Sep 25, 2020, at 12:42 PM,

Re: [PATCH 15/22] kvm: mmu: Support changed pte notifier in tdp MMU

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > @@ -1708,6 +1695,21 @@ static int kvm_unmap_rmapp(struct kvm *kvm, struct > kvm_rmap_head *rmap_head, > return kvm_zap_rmapp(kvm, rmap_head); > } > > +u64 kvm_mmu_changed_pte_notifier_make_spte(u64 old_spte, kvm_pfn_t new_pfn) > +{ > + u64 new_sp

Re: [PATCH 14/22] kvm: mmu: Add access tracking for tdp_mmu

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > @@ -332,7 +331,7 @@ static inline bool kvm_vcpu_ad_need_write_protect(struct > kvm_vcpu *vcpu) > return vcpu->arch.mmu == &vcpu->arch.guest_mmu; > } > > -static inline bool spte_ad_enabled(u64 spte) > +inline bool spte_ad_enabled(u64 spte) > { >

Re: general protection fault in perf_misc_flags

2020-09-25 Thread Nick Desaulniers
On Fri, Sep 25, 2020 at 5:22 AM Dmitry Vyukov wrote: > > On Wed, Sep 23, 2020 at 5:20 PM Dmitry Vyukov wrote: > > > > On Wed, Sep 23, 2020 at 12:34 PM Borislav Petkov wrote: > > > > > > On Wed, Sep 23, 2020 at 11:24:48AM +0200, Dmitry Vyukov wrote: > > > > 3. Run syzkaller locally with custom pa

Re: [PATCH] mfd: syscon: Don't free allocated name for regmap_config

2020-09-25 Thread Suman Anna
On 9/24/20 7:39 AM, Lee Jones wrote: > On Thu, 03 Sep 2020, Marc Zyngier wrote: > >> The name allocated for the regmap_config structure is freed >> pretty early, right after the registration of the MMIO region. >> >> Unfortunately, that doesn't follow the life cycle that debugfs >> expects, as it

Re: [PATCH 10/22] kvm: mmu: Add TDP MMU PF handler

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > > -static bool is_nx_huge_page_enabled(void) > +bool is_nx_huge_page_enabled(void) > { > return READ_ONCE(nx_huge_pages); > } > @@ -381,7 +361,7 @@ static inline u64 spte_shadow_dirty_mask(u64 spte) > return spte_ad_enabled(spte) ? shadow_dirty

Re: [PATCH 11/22] kvm: mmu: Factor out allocating a new tdp_mmu_page

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > Move the code to allocate a struct kvm_mmu_page for the TDP MMU out of the > root allocation code to support allocating a struct kvm_mmu_page for every > page of page table memory used by the TDP MMU, in the next commit. > > Tested by running kvm-unit-tests a

[PATCH] f2fs: remove unneeded parameter in find_in_block()

2020-09-25 Thread Chao Yu
From: Chao Yu We can relocate @res_page assignment in find_in_block() to its caller, so unneeded parameter could be removed for cleanup. Signed-off-by: Chao Yu --- fs/f2fs/dir.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c

Re: [GIT PULL] Second batch of KVM fixes for Linux 5.9-rc7

2020-09-25 Thread pr-tracker-bot
The pull request you sent on Fri, 25 Sep 2020 19:36:52 -0400: > https://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7c7ec3226f5f33f9c050d85ec20f18419c622ad6 Thank you! -- Deet-doot-dot, I am a bot. https://ko

Re: [PATCH][next] dpaa2-mac: Fix potential null pointer dereference

2020-09-25 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 25 Sep 2020 12:03:23 -0500 > There is a null-check for _pcs_, but it is being dereferenced > prior to this null-check. So, if _pcs_ can actually be null, > then there is a potential null pointer dereference that should > be fixed by null-checking _pcs_ befor

Re: [PATCH 09/11] drivers/char/ipmi: convert stats to use counter_atomic32

2020-09-25 Thread Corey Minyard
On Fri, Sep 25, 2020 at 05:47:23PM -0600, Shuah Khan wrote: > counter_atomic* is introduced to be used when a variable is used as > a simple counter and doesn't guard object lifetimes. This clearly > differentiates atomic_t usages that guard object lifetimes. > > counter_atomic* variables will wra

Re: [PATCH 07/22] kvm: mmu: Support zapping SPTEs in the TDP MMU

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > +/* > + * If the MMU lock is contended or this thread needs to yield, flushes > + * the TLBs, releases, the MMU lock, yields, reacquires the MMU lock, > + * restarts the tdp_iter's walk from the root, and returns true. > + * If no yield is needed, returns fals

Re: [f2fs-dev] [PATCH] f2fs: point man pages for some f2fs utils

2020-09-25 Thread Jaegeuk Kim
On 09/26, Chao Yu wrote: > On 2020-9-26 7:26, Jaegeuk Kim wrote: > > On 09/25, Jaegeuk Kim wrote: > > > This patch adds some missing contexts related to f2fs-tools in f2fs > > > documentation. > > > > > > Signed-off-by: Jaegeuk Kim > > > --- > > > Documentation/filesystems/f2fs.rst | 46

Re: [PATCH 00/11] Introduce Simple atomic and non-atomic counters

2020-09-25 Thread Shuah Khan
On 9/25/20 5:52 PM, Kees Cook wrote: On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote: -- Addressed Kees's comments: 1. Non-atomic counters renamed to counter_simple32 and counter_simple64 to clearly indicate size. 2. Added warning for counter_simple* usage and it should

Re: [PATCH v2] net: usb: ax88179_178a: add Toshiba usb 3.0 adapter

2020-09-25 Thread David Miller
From: Wilken Gottwalt Date: Fri, 25 Sep 2020 15:58:57 +0200 > Adds the driver_info and usb ids of the AX88179 based Toshiba USB 3.0 > ethernet adapter. > > Signed-off-by: Wilken Gottwalt Applied.

[RESEND PATCH v5 0/2] Add a Himax HX8837 display controller driver

2020-09-25 Thread Lubomir Rintel
Hi, please take a look at the patches chained to this messages and consider applying them. They add support for the controller that drives the panel on the OLPC XO laptops. The only change since the previous version is the Reviewed-by tag in DT bindings. Compared to v3 the bindings have been con

[RESEND PATCH v5 2/2] drm/bridge: hx8837: add a Himax HX8837 display controller driver

2020-09-25 Thread Lubomir Rintel
Himax HX8837 is used to drive the LCD panel on OLPC platforms. It controls the panel backlight and is able to refresh it when the LCD controller (and the rest of the plaform) is powered off. It also converts regular RGB color data from the LCDC so that it looks reasonable on the OLPC LCD panel wi

[RESEND PATCH v5 1/2] dt-bindings: display: himax,hx8837: Add Himax HX8837 bindings

2020-09-25 Thread Lubomir Rintel
Himax HX8837 is a secondary display controller used to drive the panel on OLPC platforms. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v4: - Rob's Reviewed-by Changes since v3: - Moved to bindings/display/ - Added the ports - Converted to YAML - Removed Pavel's Ack,

Re: [PATCH 03/22] kvm: mmu: Init / Uninit the TDP MMU

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > +static bool __read_mostly tdp_mmu_enabled = true; > +module_param_named(tdp_mmu, tdp_mmu_enabled, bool, 0644); > + This would need some custom callbacks to avoid the warning in is_tdp_mmu_enabled(). Paolo

Re: [PATCH 02/22] kvm: mmu: Introduce tdp_iter

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > EXPORT_SYMBOL_GPL(kvm_mmu_set_mmio_spte_mask); > > -static bool is_mmio_spte(u64 spte) > +bool is_mmio_spte(u64 spte) > { > return (spte & SPTE_SPECIAL_MASK) == SPTE_MMIO_MASK; > } > @@ -623,7 +612,7 @@ static int is_nx(struct kvm_vcpu *vcpu) >

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2020-09-25 Thread Bjorn Andersson
On Fri 25 Sep 11:29 PDT 2020, Amit Pundir wrote: > There are firmware versions which do not support host capability > QMI request. We suspect either the host cap is not implemented or > there may be firmware specific issues, but apparently there seem > to be a generation of firmware that has this

Re: [PATCH v2] x86/mce: Add Skylake quirk for patrol scrub reported errors

2020-09-25 Thread Luck, Tony
On Fri, Sep 25, 2020 at 09:19:12PM +0200, Borislav Petkov wrote: > And after staring at this a bit, it looks like all it wants to do is to > adjust the severity. And we have a severity grading mechanism. So let's > see how ugly it would become if we extended it to check that too. > > So how's that

[RESEND 2 PATCH v3 0/3] phy: Add USB HSIC PHY driver for Marvell MMP3 SoC

2020-09-25 Thread Lubomir Rintel
Hi, please consider applying this patch set. It adds the HSIC PHY driver for Marvell MMP3 along with related DT binding changes. In response to previous submission it was suggested that a cast of private data be removed, but it actually serves a purpose: https://lore.kernel.org/lkml/2020090320140

Re: [PATCH V2 0/5 net-next] vxlan: clean-up

2020-09-25 Thread David Miller
From: Fabian Frederick Date: Fri, 25 Sep 2020 15:15:41 +0200 > This small patchet does some clean-up on vxlan. > Second version removes VXLAN_NL2FLAG macro relevant patches as suggested by > Michal and David > > I hope to have some feedback/ACK from vxlan developers. Series applied, thanks.

[RESEND 2 PATCH v3 3/3] phy: Add USB HSIC PHY driver for Marvell MMP3 SoC

2020-09-25 Thread Lubomir Rintel
Add PHY driver for the HSICs found on Marvell MMP3 SoC. The driver is rather straightforward -- the PHY essentially just needs to be enabled. Signed-off-by: Lubomir Rintel --- Changes since v1: - Explicitely cast drvdata pointer to make sparse happy drivers/phy/marvell/Kconfig | 12 +++

[RESEND 2 PATCH v3 2/3] dt-bindings: phy: Allow BSD licensing of marvell,mmp3-hsic-phy.yaml

2020-09-25 Thread Lubomir Rintel
I wrote this binding and I'm fine with it being GPL + BSD dual-licensed, as is recommended for new DT bindings. Signed-off-by: Lubomir Rintel Acked-by: Rob Herring --- Changes since v2: - Add Rob's ack .../devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml | 2 +- 1 file changed, 1 i

[RESEND 2 PATCH v3 1/3] dt-bindings: phy: Drop reset-gpios from marvell,mmp3-hsic-phy

2020-09-25 Thread Lubomir Rintel
This has been added in error -- the PHY block doesn't have a reset pin. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v2: - Add Rob's Reviewed-by tag .../devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml | 7 --- 1 file changed, 7 deletions(-) diff --git a

[PATCH] perf: sched: Show start of latency as well

2020-09-25 Thread Joel Fernandes (Google)
perf sched latency is really useful at showing worst-case latencies that task encountered since wakeup. However it shows only the end of the latency. Often times the start of a latency is interesting as it can show what else was going on at the time to cause the latency. I certainly myself spending

[PATCH] bus: arm: integrator: fix device node iterator leak

2020-09-25 Thread Tobias Jordan
In the for_each_available_child_of_node loop of integrator_lm_populate, add a call to of_node_put to avoid leaking the iterator if we bail out. Fixes: ccea5e8a5918 ("bus: Add driver for Integrator/AP logic modules") Signed-off-by: Tobias Jordan --- drivers/bus/arm-integrator-lm.c | 1 + 1 file c

Re: [PATCH] net: ethernet: cavium: octeon_mgmt: use phy_start and phy_stop

2020-09-25 Thread David Miller
From: Ivan Khoronzhuk Date: Fri, 25 Sep 2020 15:44:39 +0300 > To start also "phy state machine", with UP state as it should be, > the phy_start() has to be used, in another case machine even is not > triggered. After this change negotiation is supposed to be triggered > by SM workqueue. > > It's

Re: [PATCH v3] Documentation: Chinese translation of Documentation/arm64/amu.rst

2020-09-25 Thread Alex Shi
在 2020/9/25 下午11:17, Bailu Lin 写道: > This is a Chinese translated version of Documentation/arm64/amu.rst > > Signed-off-by: Bailu Lin > --- > Changes in v3: > - Remove Documentation/arm64/amu.rst's inappropriate License claim. > Changes in v2: > - Add index to arm64 directoy. > - Fix a docu

Re: [PATCH] drm/nouveau/kms/nv50-: Fix clock checking algorithm in nv50_dp_mode_valid()

2020-09-25 Thread Ilia Mirkin
On Fri, Sep 25, 2020 at 6:08 PM Lyude Paul wrote: > > On Tue, 2020-09-22 at 17:22 -0400, Ilia Mirkin wrote: > > On Tue, Sep 22, 2020 at 5:14 PM Lyude Paul wrote: > > > On Tue, 2020-09-22 at 17:10 -0400, Ilia Mirkin wrote: > > > > Can we use 6bpc on arbitrary DP monitors, or is there a capability

Re: [PATCH 00/11] Introduce Simple atomic and non-atomic counters

2020-09-25 Thread Kees Cook
On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote: > -- Addressed Kees's comments: >1. Non-atomic counters renamed to counter_simple32 and counter_simple64 > to clearly indicate size. >2. Added warning for counter_simple* usage and it should be used only > when there is

Re: [f2fs-dev] [PATCH] f2fs: point man pages for some f2fs utils

2020-09-25 Thread Chao Yu
On 2020-9-26 7:26, Jaegeuk Kim wrote: On 09/25, Jaegeuk Kim wrote: This patch adds some missing contexts related to f2fs-tools in f2fs documentation. Signed-off-by: Jaegeuk Kim --- Documentation/filesystems/f2fs.rst | 46 -- 1 file changed, 44 insertions(+), 2 dele

Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call

2020-09-25 Thread Sinan Kaya
On 9/25/2020 2:16 PM, Kuppuswamy, Sathyanarayanan wrote: >> One approach is to share the restore code between hotplug driver and >> DPC driver. >> >> If this is a too involved change, DPC driver should restore state >> when hotplug is not supported. > Yes. we can add a condition for hotplug capabil

Re: [PATCH net 1/1] net: stmmac: Fix clock handling on remove path

2020-09-25 Thread David Miller
From: Wong Vee Khee Date: Fri, 25 Sep 2020 17:54:06 +0800 > While unloading the dwmac-intel driver, clk_disable_unprepare() is > being called twice in stmmac_dvr_remove() and > intel_eth_pci_remove(). This causes kernel panic on the second call. > > Removing the second call of clk_disable_unprep

Re: [PATCH v2 seccomp 3/6] seccomp/cache: Add "emulator" to check if filter is arg-dependent

2020-09-25 Thread Kees Cook
On Fri, Sep 25, 2020 at 02:07:46PM -0700, Andy Lutomirski wrote: > On Fri, Sep 25, 2020 at 1:37 PM Kees Cook wrote: > > > > On Fri, Sep 25, 2020 at 12:51:20PM -0700, Andy Lutomirski wrote: > > > > > > > > > > On Sep 25, 2020, at 12:42 PM, Kees Cook wrote: > > > > > > > > On Fri, Sep 25, 2020 at

Re: [PATCH net-next 1/1] net: stmmac: Add option for VLAN filter fail queue enable

2020-09-25 Thread David Miller
From: Wong Vee Khee Date: Fri, 25 Sep 2020 17:40:41 +0800 > From: "Chuah, Kim Tatt" > > Add option in plat_stmmacenet_data struct to enable VLAN Filter Fail > Queuing. This option allows packets that fail VLAN filter to be routed > to a specific Rx queue when Receive All is also set. > > When

[PATCH] clk: mmp2: Fix the display clock divider base

2020-09-25 Thread Lubomir Rintel
The LCD clock dividers are apparently based on one. No datasheet, determined empirically, but seems to be confirmed by line 19 of lcd.fth in OLPC laptop's Open Firmware [1]: h# 0700 value pmua-disp-clk-sel \ PLL1 / 7 -> 113.86 MHz [1] https://raw.githubusercontent.com/quozl/openfirmware/

Re: KASLR support on ARM with Kernel 4.9 and 4.14

2020-09-25 Thread Kees Cook
On Fri, Sep 25, 2020 at 11:09:10PM +0200, Ard Biesheuvel wrote: > On Fri, 25 Sep 2020 at 22:47, Kees Cook wrote: > > > > On Fri, Sep 25, 2020 at 10:37:01PM +0200, Ard Biesheuvel wrote: > > > On Fri, 25 Sep 2020 at 22:28, Kees Cook wrote: > > > > > > > > On Fri, Sep 25, 2020 at 08:33:59PM +0530, P

[PATCH 06/11] drivers/acpi/apei: convert seqno counter_atomic32

2020-09-25 Thread Shuah Khan
counter_atomic* is introduced to be used when a variable is used as a simple counter and doesn't guard object lifetimes. This clearly differentiates atomic_t usages that guard object lifetimes. counter_atomic* variables will wrap around to 0 when it overflows and should not be used to guard resour

[PATCH 11/11] drivers/edac: convert pci counters to counter_atomic32

2020-09-25 Thread Shuah Khan
counter_atomic* is introduced to be used when a variable is used as a simple counter and doesn't guard object lifetimes. This clearly differentiates atomic_t usages that guard object lifetimes. counter_atomic* variables will wrap around to 0 when it overflows and should not be used to guard resour

[PATCH 09/11] drivers/char/ipmi: convert stats to use counter_atomic32

2020-09-25 Thread Shuah Khan
counter_atomic* is introduced to be used when a variable is used as a simple counter and doesn't guard object lifetimes. This clearly differentiates atomic_t usages that guard object lifetimes. counter_atomic* variables will wrap around to 0 when it overflows and should not be used to guard resour

[PATCH 2/2] ARM: dts: mmp2-olpc-xo-1-75: Use plural form of "-gpios"

2020-09-25 Thread Lubomir Rintel
This makes validation happier. Signed-off-by: Lubomir Rintel --- arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts b/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts index f1a41152e9dd7..adde62d6fce73 1

[PATCH 10/11] drivers/misc/vmw_vmci: convert num guest devices counter to counter_atomic32

2020-09-25 Thread Shuah Khan
counter_atomic* is introduced to be used when a variable is used as a simple counter and doesn't guard object lifetimes. This clearly differentiates atomic_t usages that guard object lifetimes. counter_atomic* variables will wrap around to 0 when it overflows and should not be used to guard resour

[PATCH 07/11] drivers/android/binder: convert stats, transaction_log to counter_atomic32

2020-09-25 Thread Shuah Khan
counter_atomic* is introduced to be used when a variable is used as a simple counter and doesn't guard object lifetimes. This clearly differentiates atomic_t usages that guard object lifetimes. counter_atomic* variables will wrap around to 0 when it overflows and should not be used to guard resour

[PATCH 05/11] drivers/acpi: convert seqno counter_atomic32

2020-09-25 Thread Shuah Khan
counter_atomic* is introduced to be used when a variable is used as a simple counter and doesn't guard object lifetimes. This clearly differentiates atomic_t usages that guard object lifetimes. counter_atomic* variables will wrap around to 0 when it overflows and should not be used to guard resour

[PATCH 08/11] drivers/base/test/test_async_driver_probe: convert to use counter_atomic32

2020-09-25 Thread Shuah Khan
counter_atomic* is introduced to be used when a variable is used as a simple counter and doesn't guard object lifetimes. This clearly differentiates atomic_t usages that guard object lifetimes. counter_atomic* variables will wrap around to 0 when it overflows and should not be used to guard resour

[PATCH 1/2] ARM: dts: mmp3: Add power domain for the camera

2020-09-25 Thread Lubomir Rintel
The camera interfaces on MMP3 are on a separate power island that needs to be turned on for them to operate and, ideally, turned off when the cameras are not in use. This hooks the power island with the camera interfaces in the device tree. Signed-off-by: Lubomir Rintel --- arch/arm/boot/dts/mm

[PATCH 04/11] drivers/base/devcoredump: convert devcd_count to counter_atomic32

2020-09-25 Thread Shuah Khan
counter_atomic* is introduced to be used when a variable is used as a simple counter and doesn't guard object lifetimes. This clearly differentiates atomic_t usages that guard object lifetimes. counter_atomic* variables will wrap around to 0 when it overflows and should not be used to guard resour

[PATCH 03/11] drivers/base: convert deferred_trigger_count and probe_count to counter_atomic32

2020-09-25 Thread Shuah Khan
counter_atomic* is introduced to be used when a variable is used as a simple counter and doesn't guard object lifetimes. This clearly differentiates atomic_t usages that guard object lifetimes. counter_atomic* variables will wrap around to 0 when it overflows and should not be used to guard resour

[PATCH 02/11] selftests:lib:test_counters: add new test for counters

2020-09-25 Thread Shuah Khan
Add a new selftest for testing counter_simple* and counter_atomic* Counters API. This test load test_counters test modules and unloads. The test module runs tests and prints results in dmesg. There are a number of atomic_t usages in the kernel where atomic_t api is used strictly for counting and

[PATCH 0/2] ARM: dts: A couple of mmp devicetree updates

2020-09-25 Thread Lubomir Rintel
Hi, please take a look at two patches chaned to this message and consider applying them to arm/dt. Thank you Lubo

[PATCH 00/11] Introduce Simple atomic and non-atomic counters

2020-09-25 Thread Shuah Khan
This patch series is a result of discussion at the refcount_t BOF the Linux Plumbers Conference. In this discussion, we identified a need for looking closely and investigating atomic_t usages in the kernel when it is used strictly as a counter without it controlling object lifetimes and state chang

Re: [PATCHv5 kselftest next] selftests/run_kselftest.sh: make each test individually selectable

2020-09-25 Thread Kees Cook
On Fri, Sep 25, 2020 at 05:06:02PM -0600, Shuah Khan wrote: > On 9/25/20 3:16 PM, Kees Cook wrote: > > On Fri, Sep 25, 2020 at 01:51:53PM +0530, Naresh Kamboju wrote: > > > On Mon, 14 Sep 2020 at 07:53, Hangbin Liu wrote: > > > > > > > > Currently, after generating run_kselftest.sh, there is no w

[PATCH 01/11] counters: Introduce counter_simple* and counter_atomic* counters

2020-09-25 Thread Shuah Khan
Introduce Simple atomic and non-atomic counters. There are a number of atomic_t usages in the kernel where atomic_t api is used strictly for counting and not for managing object lifetime. In some cases, atomic_t might not even be needed. The purpose of these counters is twofold: 1. clearly differ

[PATCH 0/2] selftests: Extract run_kselftest.sh and generate stand-alone test list

2020-09-25 Thread Kees Cook
Hi! I really like Hangbin Liu's intent[1] but I think we need to be a little more clean about the implementation. This extracts run_kselftest.sh from the Makefile so it can actually be changed without embeds, etc. Instead, generate the test list into a text file. Everything gets much simpler. :)

[PATCH 2/2] selftests/run_kselftest.sh: Make each test individually selectable

2020-09-25 Thread Kees Cook
Currently with run_kselftest.sh there is no way to choose which test we could run. All the tests listed in kselftest-list.txt are all run every time. This patch enhanced the run_kselftest.sh to make the test collections (or tests) individually selectable. e.g.: $ ./run_kselftest.sh -c seccomp -t t

[PATCH 1/2] selftests: Extract run_kselftest.sh and generate stand-alone test list

2020-09-25 Thread Kees Cook
Instead of building a script on the fly (which just repeats the same thing for each test collection), move the script out of the Makefile and into run_kselftest.sh, which reads kselftest-list.txt. Adjust the emit_tests target to report each test on a separate line so that test running tools (e.g.

[PATCH] bus: qcom: ebi2: fix device node iterator leak

2020-09-25 Thread Tobias Jordan
In the for_each_available_child_of_node loop of qcom_ebi2_probe, add a call to of_node_put to avoid leaking the iterator if we bail out. Fixes: 335a12754808 ("bus: qcom: add EBI2 driver") Signed-off-by: Tobias Jordan --- drivers/bus/qcom-ebi2.c | 4 +++- 1 file changed, 3 insertions(+), 1 delet

Re: [PATCH net] vmxnet3: fix cksum offload issues for non-udp tunnels

2020-09-25 Thread David Miller
From: Ronak Doshi Date: Thu, 24 Sep 2020 23:11:29 -0700 > Commit dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload > support") added support for encapsulation offload. However, the inner > offload capability is to be restrictued to UDP tunnels. > > This patch fixes the issue for non-ud

Re: [f2fs-dev] [PATCH] f2fs: fix slab leak of rpages pointer

2020-09-25 Thread Chao Yu
On 2020-9-26 7:25, Jaegeuk Kim wrote: I missed the f2fs mailing list by gitconfig. :) On 09/23, Jaegeuk Kim wrote: This fixes the below mem leak. [ 130.157600] = [ 130.159662] BUG f2fs_page_array_entry-252:16 (Taint

[PATCH v2] f2fs: fix uninit-value in f2fs_lookup

2020-09-25 Thread Chao Yu
From: Chao Yu As syzbot reported: Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x21c/0x280 lib/dump_stack.c:118 kmsan_report+0xf7/0x1e0 mm/kmsan/kmsan_report.c:122 __msan_warning+0x58/0xa0 mm/kmsan/kmsan_instr.c:219 f2fs_lookup+0xe05/0x1a80 fs/f2fs/namei.c:503 lookup_op

[GIT PULL] Second batch of KVM fixes for Linux 5.9-rc7

2020-09-25 Thread Paolo Bonzini
Linus, The following changes since commit 32251b07d532174d66941488c112ec046f646157: Merge tag 'kvm-s390-master-5.9-1' of git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux into kvm-master (2020-09-20 17:31:15 -0400) are available in the Git repository at: https://git.kernel.org/p

[PATCH] HID: hid-input: fix stylus battery reporting

2020-09-25 Thread Dmitry Torokhov
With commit 4f3882177240 hid-input started clearing of "ignored" usages to avoid using garbage that might have been left in them. However "battery strength" usages should not be ignored, as we do want to use them. Fixes: 4f3882177240 ("HID: hid-input: clear unmapped usages") Reported-by: Kenneth A

Re: [f2fs-dev] [PATCH] f2fs: fix uninit-value in f2fs_lookup

2020-09-25 Thread Chao Yu
On 2020-9-26 1:14, Eric Biggers wrote: On Fri, Sep 25, 2020 at 11:19:26PM +0800, Chao Yu wrote: From: Chao Yu As syzbot reported: Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x21c/0x280 lib/dump_stack.c:118 kmsan_report+0xf7/0x1e0 mm/kmsan/kmsan_report.c:122 __msan_wa

Re: [PATCH] leds: omnia: fix leak of device node iterator

2020-09-25 Thread Marek Behun
Already fixed in Pavel's for-next https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/commit/?h=for-next&id=62aa40d0e907849d740ceba2a7f6bcc88896699f

Re: [PATCH] arm64: dts: mt8173-elm: Remove ddc property from panel

2020-09-25 Thread Bilal Wasim
On Wed, 26 Aug 2020 11:02:17 +0200 Enric Balletbo i Serra wrote: > The elm and hana devices uses an Embedded DisplayPort (eDP) as > interface for its panel, so the DDC channel specified in the binding > is useless. > > Signed-off-by: Enric Balletbo i Serra > --- > > arch/arm64/boot/dts/medi

[PATCH] leds: aw2013: fix leak of device node iterator

2020-09-25 Thread Tobias Jordan
In the error path of the for_each_available_child_of_node loop in aw2013_probe_dt, add missing call to of_node_put to avoid leaking the iterator. Fixes: 59ea3c9faf32 ("leds: add aw2013 driver") Signed-off-by: Tobias Jordan --- drivers/leds/leds-aw2013.c | 4 +++- 1 file changed, 3 insertions(+),

Re: [PATCH] net: stmmac: dwmac-meson8b: add calibration registers

2020-09-25 Thread David Miller
From: Martin Blumenstingl Date: Fri, 25 Sep 2020 23:56:29 +0200 > The Amlogic dwmac Ethernet IP glue has two registers: > - PRG_ETH0 with various configuration bits > - PRG_ETH1 with various calibration and information related bits > > Add the register definitions with comments from different dr

Re: [PATCH] f2fs: fix slab leak of rpages pointer

2020-09-25 Thread Jaegeuk Kim
I missed the f2fs mailing list by gitconfig. :) On 09/23, Jaegeuk Kim wrote: > This fixes the below mem leak. > > [ 130.157600] > = > [ 130.159662] BUG f2fs_page_array_entry-252:16 (Tainted: GW O > ): Obj

Re: [PATCH] f2fs: point man pages for some f2fs utils

2020-09-25 Thread Jaegeuk Kim
On 09/25, Jaegeuk Kim wrote: > This patch adds some missing contexts related to f2fs-tools in f2fs > documentation. > > Signed-off-by: Jaegeuk Kim > --- > Documentation/filesystems/f2fs.rst | 46 -- > 1 file changed, 44 insertions(+), 2 deletions(-) > > diff --git a/

[PATCH] f2fs: point man pages for some f2fs utils

2020-09-25 Thread Jaegeuk Kim
This patch adds some missing contexts related to f2fs-tools in f2fs documentation. Signed-off-by: Jaegeuk Kim --- Documentation/filesystems/f2fs.rst | 46 -- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git a/Documentation/filesystems/f2fs.rst b/Documenta

Re: [PATCH] leds: tlc591xx: fix leak of device node iterator

2020-09-25 Thread Marek Behun
On Sat, 26 Sep 2020 01:10:11 +0200 Tobias Jordan wrote: > In one of the error paths of the for_each_child_of_node loop in > tlc591xx_probe, add missing call to of_node_put. > > Fixes: 1ab4531ad132 ("leds: tlc591xx: simplify driver by using the > managed led API") > > Signed-off-by: Tobias Jorda

Re: [PATCH v3 4/4] PCI: Limit pci_alloc_irq_vectors() to housekeeping CPUs

2020-09-25 Thread Nitesh Narayan Lal
On 9/25/20 5:38 PM, Nitesh Narayan Lal wrote: > On 9/25/20 4:23 PM, Bjorn Helgaas wrote: [...] >>> + /* >>> +* If we have isolated CPUs for use by real-time tasks, to keep the >>> +* latency overhead to a minimum, device-specific IRQ vectors are moved >>> +* to the housekeeping CPU

[PATCH] leds: omnia: fix leak of device node iterator

2020-09-25 Thread Tobias Jordan
In the error path of the for_each_available_child_of_node loop in omnia_leds_probe, add missing call to of_node_put to fix leaking the iterator. Fixes: 089381b27abe ("leds: initial support for Turris Omnia LEDs") Signed-off-by: Tobias Jordan --- drivers/leds/leds-turris-omnia.c | 4 +++- 1 file

Re: [f2fs-dev] KMSAN: uninit-value in f2fs_lookup

2020-09-25 Thread Chao Yu
On 2020-9-26 0:45, Eric Biggers wrote: On Fri, Sep 25, 2020 at 09:38:19AM -0700, Eric Biggers wrote: On Fri, Sep 25, 2020 at 05:06:33PM +0800, Chao Yu wrote: Hi, I don't see any problem here, thanks for your report. :) Thanks, What about if max_depth == 0 in __f2fs_find_entry()? Then __f2f

Re: [PATCH] leds: lp55xx: fix device node iterator memory leaks

2020-09-25 Thread Marek Behun
On Sat, 26 Sep 2020 00:59:05 +0200 Tobias Jordan wrote: > Fix error paths in for_each_child_of_node loops that were missing an > of_node_put call. > > Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to > lp55xx") > Signed-off-by: Tobias Jordan > --- > drivers/leds/leds-lp5

Re: [patch V2 00/46] x86, PCI, XEN, genirq ...: Prepare for device MSI

2020-09-25 Thread Thomas Gleixner
On Fri, Sep 25 2020 at 17:49, Peter Zijlstra wrote: > Here it looks like this: > > [1.830276] BUG: kernel NULL pointer dereference, address: > [1.838043] #PF: supervisor instruction fetch in kernel mode > [1.844357] #PF: error_code(0x0010) - not-present page > [1.85

[PATCH] nios2: Take mmap lock in cacheflush syscall

2020-09-25 Thread Jann Horn
We need to take the mmap lock around find_vma() and subsequent use of the VMA. Otherwise, we can race with concurrent operations like munmap(), which can lead to use-after-free accesses to freed VMAs. Fixes: 1000197d8013 ("nios2: System calls handling") Signed-off-by: Jann Horn --- To the maintai

Re: [PATCH v3] mm: cma: indefinitely retry allocations in cma_alloc

2020-09-25 Thread Chris Goldsworthy
On 2020-09-25 05:18, David Hildenbrand wrote: On 24.09.20 07:16, Chris Goldsworthy wrote: -GFP_KERNEL | (no_warn ? __GFP_NOWARN : 0)); +GFP_KERNEL | (gfp_mask & __GFP_NOWARN)); Right, we definetly don't want to pass the fl

[PATCH] leds: tlc591xx: fix leak of device node iterator

2020-09-25 Thread Tobias Jordan
In one of the error paths of the for_each_child_of_node loop in tlc591xx_probe, add missing call to of_node_put. Fixes: 1ab4531ad132 ("leds: tlc591xx: simplify driver by using the managed led API") Signed-off-by: Tobias Jordan --- drivers/leds/leds-tlc591xx.c | 1 + 1 file changed, 1 insertion(

[PATCH 1/1] pci: pciehp: Handle MRL interrupts to enable slot for hotplug.

2020-09-25 Thread Ashok Raj
When Mechanical Retention Lock (MRL) is present, Linux doesn't process those change events. The following changes need to be enabled when MRL is present. 1. Subscribe to MRL change events in SlotControl. 2. When MRL is closed, - If there is no ATTN button, then POWER on the slot. - If there

Re: [PATCHv5 kselftest next] selftests/run_kselftest.sh: make each test individually selectable

2020-09-25 Thread Shuah Khan
On 9/25/20 3:16 PM, Kees Cook wrote: On Fri, Sep 25, 2020 at 01:51:53PM +0530, Naresh Kamboju wrote: On Mon, 14 Sep 2020 at 07:53, Hangbin Liu wrote: Currently, after generating run_kselftest.sh, there is no way to choose which test we could run. All the tests are listed together and we have

[PATCH 1/1] pci: pciehp: Handle MRL interrupts to enable slot for hotplug.

2020-09-25 Thread Ashok Raj
When Mechanical Retention Lock (MRL) is present, Linux doesn't process those change events. The following changes need to be enabled when MRL is present. 1. Subscribe to MRL change events in SlotControl. 2. When MRL is closed, - If there is no ATTN button, then POWER on the slot. - If there

Re: [PATCH printk v5 6/6] printk: reimplement log_cont using record extension

2020-09-25 Thread John Ogness
On 2020-09-25, Marek Szyprowski wrote: > This patch landed recently in linux-next as commit f5f022e53b87 > ("printk: reimplement log_cont using record extension"). I've noticed > that it causes a regression on my test system (ARM 32bit Samsung Exynos > 4412-based Trats2 board). The messages are

Re: [PATCH v4 1/6] timer: kasan: record timer stack

2020-09-25 Thread Thomas Gleixner
On Fri, Sep 25 2020 at 17:15, Walter Wu wrote: > On Fri, 2020-09-25 at 10:55 +0200, Thomas Gleixner wrote: >> > We don't want to replace DEBUG_OBJECTS_TIMERS with this patches, only >> > hope to use low overhead(compare with DEBUG_OBJECTS_TIMERS) to debug >> >> KASAN has lower overhead than DEBUG_

[PATCH] leds: lp55xx: fix device node iterator memory leaks

2020-09-25 Thread Tobias Jordan
Fix error paths in for_each_child_of_node loops that were missing an of_node_put call. Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") Signed-off-by: Tobias Jordan --- drivers/leds/leds-lp55xx-common.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)

[PATCH] nds32: Take mmap lock in cacheflush syscall

2020-09-25 Thread Jann Horn
We need to take the mmap lock around find_vma() and subsequent use of the VMA. Otherwise, we can race with concurrent operations like munmap(), which can lead to use-after-free accesses to freed VMAs. Fixes: 1932fbe36e02 ("nds32: System calls handling") Signed-off-by: Jann Horn --- To the maintai

Re: [PATCH 2/2] printk: Make the console flush configurable in hotplug path

2020-09-25 Thread Thomas Gleixner
On Fri, Sep 25 2020 at 16:16, Adam Borowski wrote: > On Fri, Sep 25, 2020 at 11:27:54AM +0200, Greg KH wrote: >> On Thu, Sep 24, 2020 at 08:21:07PM +0200, Thomas Gleixner wrote: >> > On Thu, Sep 24 2020 at 08:33, Greg KH wrote: >> > > On Wed, Sep 23, 2020 at 05:08:32PM -0700, Prasad Sodagudi wrote:

Re: [PATCH v6 05/10] PCI/AER: Apply function level reset to RCiEP on fatal error

2020-09-25 Thread Sean V Kelley
On 25 Sep 2020, at 14:58, Bjorn Helgaas wrote: On Tue, Sep 22, 2020 at 02:38:54PM -0700, Sean V Kelley wrote: From: Qiuxu Zhuo Attempt to do function level reset for an RCiEP associated with an RCEC device on fatal error. Signed-off-by: Qiuxu Zhuo --- drivers/pci/pcie/err.c | 31 ++

<    1   2   3   4   5   6   7   8   9   10   >