can the idle value of /proc/stat decrease?

2020-12-27 Thread xuqiang (M)
Our recent test shows that the idle value of /proc/stat can decrease. Is this an unreported bug? or it has been reported and the solution is waiting to get merged. The results of the two readings from /proc/stat are shown as below, the interval between the two readings is 150 ms: cat

Re: [PATCH] m68k: let clk_enable() return immediately if clk is NULL

2020-12-27 Thread Geert Uytterhoeven
Hi Defang, On Mon, Dec 28, 2020 at 3:08 AM Defang Bo wrote: > Similar to commit<742859adc721>("m68k: let clk_disable() return immediately > if clk is NULL"). > there should be a check for clk to prevent NULL pointer dereference. > > Signed-off-by: Defang Bo Thanks for your patch! > ---

[PATCH] drm/hisilicon: Use simple encoder

2020-12-27 Thread Tian Tao
The hibmc driver uses empty implementations for its encoders. Replace the code with the generic simple encoder. Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

Re: Linux 5.11-rc1

2020-12-27 Thread Sedat Dilek
[ Please CC me I am not subscribed to LKML and linux-kbuild ML ] Hi Linus, Hi Mashiro, thanks for the Linux v5.11-rc1 release. With a new release I always do my first builds with my distro's default compiler and linker (GCC v10.2.1 and GNU/ld BFD v2.35.1). ( It's approx. 40% faster than LLVM

Re: [PATCH 2/2] arm64: mm: fix kdump broken with ZONE_DMA reintroduced

2020-12-27 Thread chenzhou
Hi Nicolas, Thanks for your review. On 2020/12/26 18:34, Nicolas Saenz Julienne wrote: > Hi Chen, thanks for looking at this. > > On Sat, 2020-12-26 at 11:35 +0800, Chen Zhou wrote: >> If the memory reserved for crash dump kernel falled in ZONE_DMA32, >> the devices in crash dump kernel need to

[PATCH] dm snap : add sanity checks to snapshot_ctr

2020-12-27 Thread Defang Bo
Similar to commit<70de2cbda8a5>("dm thin: add sanity checks to thin-pool and external snapshot creation"),there should be a check for argc and argv to prevent Null pointer dereferencing when the dm_get_device invoked twice on the same device path with differnt mode. Signed-off-by: Defang Bo ---

[PATCH] net: remove disc_data_lock in ppp line discipline

2020-12-27 Thread Gao Yan
In tty layer, it use tty->ldisc_sem to proect tty_ldisc_ops. So I think tty->ldisc_sem can also protect tty->disc_data; For examlpe, When cpu A is running ppp_synctty_ioctl that hold the tty->ldisc_sem, at the same time if cpu B calls ppp_synctty_close, it will wait until cpu A release

[PATCH] dm-snapshot: Flush merged data before committing metadata

2020-12-27 Thread Akilesh Kailash
If the origin device has a volatile write-back cache and the following events occur: 1: After finishing merge operation of one set of exceptions, merge_callback() is invoked. 2: Update the metadata in COW device tracking the merge completion. This update to COW device is flushed cleanly. 3:

Re: [PATCH 1/1] ARM: LPAE: use phys_addr_t instead of unsigned long in outercache hooks

2020-12-27 Thread Arnd Bergmann
On Fri, Dec 25, 2020 at 12:48 PM Zhen Lei wrote: > > The outercache of some Hisilicon SOCs support physical addresses wider > than 32-bits. The unsigned long datatype is not sufficient for mapping > physical addresses >= 4GB. The commit ad6b9c9d78b9 ("ARM: 6671/1: LPAE: > use phys_addr_t instead

[PATCH] pinctrl: ralink: rt2880: fix '-Wmissing-prototypes' in init function

2020-12-27 Thread Sergio Paracuellos
Kernel test robot reported the following warning: 'warning: no previous prototype for 'rt2880_pinmux_init''. This function is the entry point for the platform driver and it is private to this driver. Hence declare it 'static' which is the correct thing to do fixing also this warning. Reported-by:

Re: [PATCH] ASoC: audio-graph-card: Drop remote-endpoint as required property

2020-12-27 Thread Sameer Pujar
Hi Rob, The remote-endpoint may not be available if it is part of some pluggable module. One such example would be an audio card, the Codec endpoint will not be available until it is plugged in. Hence drop 'remote-endpoint' as a required property. Please hold off on this. I have more changes

Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting

2020-12-27 Thread Hugh Dickins
On Sun, 27 Dec 2020, Linus Torvalds wrote: > On Sun, Dec 27, 2020 at 3:48 PM Kirill A. Shutemov > wrote: > > > > I did what Hugh proposed and it got clear to my eyes. It gets somewhat > > large, but take a look. > > Ok, it's not that much bigger, and the end result is certainly much > clearer

Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword

2020-12-27 Thread Greg Kroah-Hartman
On Mon, Dec 28, 2020 at 12:13:00AM -0500, jovin555 wrote: > Warning found by checkpatch.pl script. > > Signed-off-by: jovin555 > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c >

Re: [PATCH] cpuset: Remove stale URLs in the MAINTAINERS entry

2020-12-27 Thread Zefan Li
On 2020/12/28 14:01, Joe Perches wrote: > On Mon, 2020-12-28 at 11:17 +0800, Zefan Li wrote: >> Those URLs are no longer accessable. >> >> Reported-by: Steve Wahl >> Signed-off-by: Zefan Li >> --- >>  MAINTAINERS | 2 -- >>  1 file changed, 2 deletions(-) >> >> diff --git a/MAINTAINERS

Re: Commit 4257f7e0 ("PCI/ASPM: Save/restore L1SS Capability for suspend/resume") causing hibernate resume failures

2020-12-27 Thread Kenneth R. Crudup
On Sun, 27 Dec 2020, Kenneth R. Crudup wrote: > I'll try your patch after the revert and see if anything changes. I just realized today's patch makes no sense if it's reverted, so nevermind. -Kenny -- Kenneth R. Crudup Sr. SW Engineer, Scott County Consulting, Orange County CA

ERROR: ".of_device_get_match_data" undefined!

2020-12-27 Thread kernel test robot
Hi Shengjiu, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5c8fe583cce542aa0b84adc939ce85293de36e5e commit: c05f10f28ef697aae8f1d82012d660af3cfc8cf9 ASoC: fsl_asrc: Add support for imx8qm & imx8qxp date: 12

Re: [PATCH v2 11/48] opp: Add dev_pm_opp_find_level_ceil()

2020-12-27 Thread Viresh Kumar
On 24-12-20, 16:00, Dmitry Osipenko wrote: > In a device driver I want to set PD to the lowest performance state by > removing the performance vote when dev_pm_opp_set_rate(dev, 0) is > invoked by the driver. > > The OPP core already does this, but if OPP levels don't start from 0 in > a

RE: [PATCH] scsi: qedi: add printf attribute to log function

2020-12-27 Thread Manish Rangankar
> -Original Message- > From: t...@redhat.com > Sent: Monday, December 21, 2020 9:54 PM > To: Nilesh Javali ; Manish Rangankar > ; j...@linux.ibm.com; > martin.peter...@oracle.com > Cc: GR-QLogic-Storage-Upstream upstr...@marvell.com>; linux-s...@vger.kernel.org; linux- >

Re: [PATCH] cpuset: Remove stale URLs in the MAINTAINERS entry

2020-12-27 Thread Joe Perches
On Mon, 2020-12-28 at 11:17 +0800, Zefan Li wrote: > Those URLs are no longer accessable. > > Reported-by: Steve Wahl > Signed-off-by: Zefan Li > --- >  MAINTAINERS | 2 -- >  1 file changed, 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ae9b1dd748c4..2fe8eb54639e 100644 >

Re: Commit 4257f7e0 ("PCI/ASPM: Save/restore L1SS Capability for suspend/resume") causing hibernate resume failures

2020-12-27 Thread Kenneth R. Crudup
OK, got more info: On Sun, 27 Dec 2020, Bjorn Helgaas wrote: > If it's convenient, can you try the patch below? If the debug patch > doesn't help: > - Are you seeing the hibernate/resume problem when on AC or on > battery? OK, so: - on TLP, before your patch, it panic()s on AC, but

Re: [External] [PATCH 1/2] mm: memcg: fix memcg file_dirty numa stat

2020-12-27 Thread Muchun Song
On Mon, Dec 28, 2020 at 2:13 AM Shakeel Butt wrote: > > The kernel updates the per-node NR_FILE_DIRTY stats on page migration > but not the memcg numa stats. That was not an issue until recently the > commit 5f9a4f4a7096 ("mm: memcontrol: add the missing numa_stat interface > for cgroup v2")

Re: [PATCH] cpufreq: brcmstb-avs-cpufreq: Fix some resource leaks in the error handling path of the probe function

2020-12-27 Thread Viresh Kumar
On 27-12-20, 18:22, Christophe JAILLET wrote: > Le 22/12/2020 à 05:35, Viresh Kumar a écrit : > > On 19-12-20, 11:17, Christophe JAILLET wrote: > > > If 'cpufreq_register_driver()' fails, we must release the resources > > > allocated in 'brcm_avs_prepare_init()' as already done in the remove > > >

[PATCH] opp: Call the missing clk_put() on error

2020-12-27 Thread Viresh Kumar
Fix the clock reference counting by calling the missing clk_put() in the error path. Cc: v5.10 # v5.10 Fixes: dd461cd9183f ("opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER") Signed-off-by: Viresh Kumar --- drivers/opp/core.c | 5 - 1 file changed, 4 insertions(+), 1

Re: [PATCH] opp: fix memory leak in _allocate_opp_table

2020-12-27 Thread Viresh Kumar
On 24-12-20, 18:49, quanyang.w...@windriver.com wrote: > From: Quanyang Wang > > In function _allocate_opp_table, opp_dev is allocated and referenced > by opp_table via _add_opp_dev. But in the case that the subsequent calls > return -EPROBE_DEFER, it will jump to err label and opp_table will be

[PATCH] staging: android: ashmem: Declared file operation with const keyword

2020-12-27 Thread jovin555
Warning found by checkpatch.pl script. Signed-off-by: jovin555 --- drivers/staging/android/ashmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c index c05a214191da..f9cfa15b785f 100644 ---

Re: Commit 4257f7e0 ("PCI/ASPM: Save/restore L1SS Capability for suspend/resume") causing hibernate resume failures

2020-12-27 Thread Kenneth R. Crudup
On Sun, 27 Dec 2020, Bjorn Helgaas wrote: > If it's convenient, can you try the patch below? Will do! Also: > - Are you seeing the hibernate/resume problem when on AC or on > battery? Um, I forget :) but want to say "both". I'll try both ways and let you know. > - If you revert

Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

2020-12-27 Thread Vijayanand Jitta
On 12/23/2020 8:10 PM, Alexander Potapenko wrote: >> >> Michan, We would still need config option so that we can reduce the >> memory consumption on low ram devices using config. >> >> Alex, On this, >> "I also suppose device vendors may prefer setting a fixed (maybe >> non-default) hash size

dmaengine : xilinx_dma two issues

2020-12-27 Thread Paul Thomas
Hello, I'm trying to get the 5.10 kernel up and running for our system, and I'm running into a couple of issues with xilinx_dma. First, commit 14ccf0aab46e 'dmaengine: xilinx_dma: In dma channel probe fix node order dependency' breaks our usage. Before this commit a call to:

[PATCH] selftests/powerpc: make the test check in eeh-basic.sh posix compliant

2020-12-27 Thread Po-Hsu Lin
The == operand is a bash extension, thus this will fail on Ubuntu with As the /bin/sh on Ubuntu is pointed to DASH. Use -eq to fix this posix compatibility issue. Fixes: 996f9e0f93f162 ("selftests/powerpc: Fix eeh-basic.sh exit codes") Signed-off-by: Po-Hsu Lin ---

Re: [PATCH v5 10/15] sched: Introduce force_compatible_cpus_allowed_ptr() to limit CPU affinity

2020-12-27 Thread Suren Baghdasaryan
Just a couple minor nits. On Tue, Dec 8, 2020 at 5:29 AM Will Deacon wrote: > > Asymmetric systems may not offer the same level of userspace ISA support > across all CPUs, meaning that some applications cannot be executed by > some CPUs. As a concrete example, upcoming arm64 big.LITTLE designs

Re: BUG: unable to handle kernel NULL pointer dereference in call_rcu

2020-12-27 Thread Walter Wu
On Sun, 2020-12-27 at 20:51 +0100, Dmitry Vyukov wrote: > /\/\/\/\On Sun, Dec 27, 2020 at 8:45 PM Andrew Morton > wrote: > > > > (cc KASAN developers) > > > > On Sat, 26 Dec 2020 15:25:14 -0800 syzbot > > wrote: > > > > > Hello, > > > > > > syzbot found the following issue on: > > > > > > HEAD

Re: Commit 4257f7e0 ("PCI/ASPM: Save/restore L1SS Capability for suspend/resume") causing hibernate resume failures

2020-12-27 Thread Bjorn Helgaas
> From: Kenneth R. Crudup > > I've been running Linus' master branch on my laptop (Dell XPS 13 > 2-in-1). With this commit in place, after resuming from hibernate > my machine is essentially useless, with a torrent of disk I/O errors > on my NVMe device (at least, and possibly other devices

[PATCH] drm/amd/display: avoid null pointer dereference in dm_set_vblank

2020-12-27 Thread Defang Bo
[Why] Similar to commit("drm/amd/display: Guard against null crtc in CRC IRQ"), a null pointer deference can occur if crtc is null in dm_set_vblank. [How] Check that CRTC is non-null before accessing its fields. Signed-off-by: Defang Bo --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |

Re: [PATCH v5 08/15] cpuset: Honour task_cpu_possible_mask() in guarantee_online_cpus()

2020-12-27 Thread Suren Baghdasaryan
On Tue, Dec 8, 2020 at 5:29 AM Will Deacon wrote: > > Asymmetric systems may not offer the same level of userspace ISA support > across all CPUs, meaning that some applications cannot be executed by > some CPUs. As a concrete example, upcoming arm64 big.LITTLE designs do > not feature support for

[PATCH V1] nohz: exit nohz idle before invoking softirq

2020-12-27 Thread chenshiyan
From: "shiyan.csy" exit nohz idle before invoking softirq, or it maymiss some ticks during softirq. Signed-off-by: Shiyan Chen --- kernel/softirq.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/kernel/softirq.c b/kernel/softirq.c index 9d71046..59bd6fe 100644

[PATCH] fs: amend SLAB_RECLAIM_ACCOUNT on gfs2_quotad_cachep

2020-12-27 Thread Huangzhaoyang
From: Zhaoyang Huang As gfs2_quotad_cachep has registered the shrinker, amending SLAB_RECLAIM_ACCOUNT when create gfs2_quotad_cachep, which make the slab acount to be presiced. Signed-off-by: Zhaoyang Huang --- fs/gfs2/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] x86: Include thunk_$(BITS).o only if CONFIG_PREEMPTION=y

2020-12-27 Thread H.J. Lu
The newer GNU assembler may not generate a symbol table for the empty object file. Since objtool doesn't like empty object files without symbol table and thunk_$(BITS).o doesn't have a symbol table when CONFIG_PREEMPTION isn't enabled, include thunk_$(BITS).o only if CONFIG_PREEMPTION is enabled.

[PATCH] perf record: Tweak "Lowering..." warning in record_opts__config_freq

2020-12-27 Thread Hans-Peter Nilsson
That is, instead of "Lowering default frequency rate to " say "Lowering default frequency rate from to ", specifying the overridden default frequency , so you don't have to grep through the source to "remember" that was e.g. 4000. Signed-off-by: Hans-Peter Nilsson Cc: Peter Zijlstra Cc: Ingo

[PATCH] locking/qspinlock: Modify comments to adapt to code modification.

2020-12-27 Thread Xiangyang Yu
The function 'pv_wait_head_or_lock' comment is not modified in commit 625e88be1f41 ("locking/qspinlock: Merge 'struct __qspinlock' into 'struct qspinlock'"). Fix it. Signed-off-by: Xiangyang Yu --- kernel/locking/qspinlock_paravirt.h | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH] cpuset: Remove stale URLs in the MAINTAINERS entry

2020-12-27 Thread Zefan Li
Those URLs are no longer accessable. Reported-by: Steve Wahl Signed-off-by: Zefan Li --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index ae9b1dd748c4..2fe8eb54639e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4477,8 +4477,6 @@ CONTROL GROUP -

arch/sh/kernel/cpu/irq/ipr.c:35:9: sparse: sparse: incorrect type in argument 1 (different base types)

2020-12-27 Thread kernel test robot
Hi Luc, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5c8fe583cce542aa0b84adc939ce85293de36e5e commit: e5fc436f06eef54ef512ea55a9db8eb9f2e76959 sparse: use static inline for __chk_{user,io}_ptr() date: 4

[PATCH] powerpc/mm: add sanity check to avoid null pointer dereference

2020-12-27 Thread Defang Bo
Similar to commit<0dc294f717d4>("powerpc/mm: bail out early when flushing TLB page"), there should be a check for 'mm' to prevent Null pointer dereference in case of 'mm' argument was legitimately passed. Signed-off-by: Defang Bo --- arch/powerpc/mm/nohash/tlb.c | 11 ++- 1 file

Re: Re: [PATCH] net/mlx5e: Fix two double free cases

2020-12-27 Thread dinghao . liu
> On Mon, Dec 21, 2020 at 04:50:31PM +0800, Dinghao Liu wrote: > > mlx5e_create_ttc_table_groups() frees ft->g on failure of > > kvzalloc(), but such failure will be caught by its caller > > in mlx5e_create_ttc_table() and ft->g will be freed again > > in mlx5e_destroy_flow_table(). The same issue

[PATCH V3] drm/ast: Fixed CVE for DP501

2020-12-27 Thread KuoHsiang Chou
[Bug][DP501] If ASPEED P2A (PCI to AHB) bridge is disabled and disallowed for CVE_2019_6260 item3, and then the monitor's EDID is unable read through Parade DP501. The reason is the DP501's FW is mapped to BMC addressing space rather than Host addressing space. The resolution is that using

Re: Re: [PATCH] IB/sa: Fix memleak in ib_nl_make_request

2020-12-27 Thread dinghao . liu
> On Sun, Dec 20, 2020 at 04:13:14PM +0800, Dinghao Liu wrote: > > When rdma_nl_multicast() fails, skb should be freed > > just like when ibnl_put_msg() fails. > > It is not so simple as you wrote in the description. > > There are no other places in the linux kernel that free > SKBs after

[PATCH V3] drm/ast: Fixed CVE for DP501

2020-12-27 Thread KuoHsiang Chou
[Bug][DP501] If ASPEED P2A (PCI to AHB) bridge is disabled and disallowed for CVE_2019_6260 item3, and then the monitor's EDID is unable read through Parade DP501. The reason is the DP501's FW is mapped to BMC addressing space rather than Host addressing space. The resolution is that using

[PATCH v6 3/4] MIPS: Loongson64: DTS: Add SPI support to LS7A

2020-12-27 Thread Qing Zhang
Add spi support. Reviewed-by: Huacai Chen Signed-off-by: Qing Zhang --- v2: - Add spi about pci device DT v3: - Remove spiflash node v4: - Remove useless compatible v5: - Remove num-chipselects v6: - No changes --- arch/mips/boot/dts/loongson/ls7a-pch.dtsi | 9 + 1 file changed,

[PATCH v6 4/4] MIPS: Loongson: Enable Loongson LS7A SPI in loongson3_defconfig

2020-12-27 Thread Qing Zhang
This is now supported, enable for Loongson systems. Reviewed-by: Huacai Chen Signed-off-by: Qing Zhang --- v2: - Modify CONFIG_SPI_LOONGSON to CONFIG_SPI_LS7A v3: - No changes v4: - No changes v5: - No changes v6: - No changes --- arch/mips/configs/loongson3_defconfig | 3 +++ 1 file

[PATCH v6 1/4] spi: LS7A: Add Loongson LS7A SPI controller driver support

2020-12-27 Thread Qing Zhang
The SPI controller has the following characteristics: - Full-duplex synchronous serial data transmission - Support up to 4 variable length byte transmission - Main mode support - Mode failure generates an error flag and issues an interrupt request - Double buffer receiver - Serial clock with

[PATCH v6 2/4] spi: ls7a: Add YAML schemas

2020-12-27 Thread Qing Zhang
Switch the DT binding to a YAML schema to enable the DT validation. Reviewed-by: Huacai Chen Signed-off-by: Qing Zhang --- v4: - fix warnings/errors about running 'make dt_binding_check' v5: - remove num-chipelects v6: - No changes --- .../devicetree/bindings/spi/loongson,spi-ls7a.yaml |

[PATCH net v2] net: hdlc_ppp: Fix issues when mod_timer is called while timer is running

2020-12-27 Thread Xie He
ppp_cp_event is called directly or indirectly by ppp_rx with "ppp->lock" held. It may call mod_timer to add a new timer. However, at the same time ppp_timer may be already running and waiting for "ppp->lock". In this case, there's no need for ppp_timer to continue running and it can just exit. If

Re: [PATCH v2 0/3] RFC: Solve several problems in stage 2 translation

2020-12-27 Thread wangyanan (Y)
Hi Will, Marc, Gently Ping. Is there any comments about this V2 series? Many thanks, Yanan. On 2020/12/16 20:28, Yanan Wang wrote: Hi, this is the second version, thanks for reading. PATCH1/3: Procedures of hyp stage 1 mapping and guest stage 2 mapping are different, but they are tied

[PATCH] perf arm64: Simplify mksyscalltbl

2020-12-27 Thread Hans-Peter Nilsson
This patch isn't intended to have any effect on the compiled code. It just removes one level of indirection: calling the *host* compiler to build and then run a program that just printf:s the numerical entries of the syscall-table. In other words, the generated syscalls.c changes from:

[PATCH] m68k: let clk_enable() return immediately if clk is NULL

2020-12-27 Thread Defang Bo
Similar to commit<742859adc721>("m68k: let clk_disable() return immediately if clk is NULL"). there should be a check for clk to prevent NULL pointer dereference. Signed-off-by: Defang Bo --- arch/m68k/coldfire/clk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

{standard input}:533: Error: opcode not supported on this processor: mips3 (mips3) `dins $8,$11,32,32'

2020-12-27 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5c8fe583cce542aa0b84adc939ce85293de36e5e commit: c7e2d71dda7ac4731bae54a25c49cd81fe7b9046 MIPS: Fix set_pte() for Netlogic XLR using cmpxchg64() date: 1 year, 11 months ago config:

[PATCH] perf arm64: Fix mksyscalltbl, don't lose syscalls due to sort -nu

2020-12-27 Thread Hans-Peter Nilsson
When using "sort -nu", arm64 syscalls were lost. That is, the io_setup syscall (number 0) and all but one (typically ftruncate; 64) of the syscalls that are defined symbolically (like "#define __NR_ftruncate __NR3264_ftruncate") at the point where "sort" is applied. This

Re: [linux-sunxi] Re: [PATCH RESEND] ARM: configs: sunxi: enable brcm wireless

2020-12-27 Thread Chen-Yu Tsai
On Mon, Dec 28, 2020 at 4:03 AM Jernej Škrabec wrote: > > Hi! > > Dne nedelja, 27. december 2020 ob 21:00:00 CET je Corentin Labbe napisal(a): > > Lot of sunxi boards have BRCM wireless device, so let's enable necessary > > options for it in our defconfig. > > Idea is good but modules (=m)

arch/sh/mm/cache-sh7705.c:116:32: sparse: sparse: incorrect type in argument 1 (different base types)

2020-12-27 Thread kernel test robot
Hi Luc, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5c8fe583cce542aa0b84adc939ce85293de36e5e commit: e5fc436f06eef54ef512ea55a9db8eb9f2e76959 sparse: use static inline for __chk_{user,io}_ptr() date: 4

RE: regmap: debugfs: fix a memory leak when calling regmap_attach_dev

2020-12-27 Thread Wang, Xiaolei
> Do you mean so? > > commit: > 9b947a13e7f6 ("regmap: use debugfs even when no device") > Please take another look at known information sources. >

Re: [PATCH 4/5] irqtime: Move irqtime entry accounting after irq offset incrementation

2020-12-27 Thread Qais Yousef
Hi Frederic On 12/02/20 12:57, Frederic Weisbecker wrote: > #endif /* _LINUX_KERNEL_VTIME_H */ > diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c > index 02163d4260d7..5f611658eeab 100644 > --- a/kernel/sched/cputime.c > +++ b/kernel/sched/cputime.c > @@ -44,12 +44,13 @@ static void

Re: [PATCH -next] regulator: qcom-rpmh: fix build after QCOM_COMMAND_DB is tristate

2020-12-27 Thread Lina Iyer
On Fri, Dec 25 2020 at 11:50 -0700, Randy Dunlap wrote: Restrict REGULATOR_QCOM_RPMH to QCOM_COMMAND_DB it the latter is enabled. Fixes this build error: microblaze-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_probe': (.text+0x354): undefined reference to

[PATCH] Revert "mfd: syscon: Don't free allocated name for regmap_config"

2020-12-27 Thread Meng . Li
From: Limeng This reverts commit 529a1101212a785c5df92c314b0e718287150c3b. The reverted patch moves the memory free to error path, but introduce a memory leak. There is another commit 94cc89eb8fa5("regmap: debugfs: Fix handling of name string for debugfs init delays") fixing this debugfs init

[PATCH] ARM64: RAS: Update code to trace out more data for ARM processor

2020-12-27 Thread Jason Tian
The original arm_event trace code only traces out ARM processor error information data. According to UEFI_2_8_A_Feb14 specification chapter N2.4.4, the ARM processor error section includes several ARM processor error information, several ARM processor context information and several vendor

Re: [PATCH v1] scsi: ufs-mediatek: Enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL

2020-12-27 Thread Stanley Chu
Hi Asutosh, On Sun, 2020-12-27 at 17:32 -0800, Asutosh Das (asd) wrote: > On 12/24/2020 5:47 AM, Stanley Chu wrote: > > Hi Avri, Bean, > > > > On Thu, 2020-12-24 at 13:01 +0100, Bean Huo wrote: > >> On Thu, 2020-12-24 at 11:03 +, Avri Altman wrote: > > Do you see any substantial benefit

Re: [PATCH 1/3] blk-mq: allow hardware queue to get more tag while sharing a tag set

2020-12-27 Thread yukuai (C)
Hi, On 2020/12/27 19:58, Ming Lei wrote: Hi Yu Kuai, On Sat, Dec 26, 2020 at 06:28:06PM +0800, Yu Kuai wrote: When sharing a tag set, if most disks are issuing small amount of IO, and only a few is issuing a large amount of IO. Current approach is to limit the max amount of tags a disk can

Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting

2020-12-27 Thread Linus Torvalds
On Sun, Dec 27, 2020 at 3:48 PM Kirill A. Shutemov wrote: > > I did what Hugh proposed and it got clear to my eyes. It gets somewhat > large, but take a look. Ok, it's not that much bigger, and the end result is certainly much clearer wrt locking. So that last version of yours with the fix for

Re: [PATCH v2 2/3] scsi: ufs: Add handling of the return value of pm_runtime_get_sync()

2020-12-27 Thread Can Guo
On 2020-12-25 01:20, Bean Huo wrote: From: Bean Huo The race issue may exist between UFS access in UFS sysfs context and UFS shutdown, thus will cause pm_runtime_get_sync() resume failure. Are you trying to fix the race condition by adding these checks or just adding these checks in case

Re: [PATCH v1 02/19] x86/insn: Add @buf_len param to insn_init() kernel-doc comment

2020-12-27 Thread Masami Hiramatsu
On Wed, 23 Dec 2020 18:42:16 +0100 Borislav Petkov wrote: > From: Borislav Petkov > > It wasn't documented so add it. No functional changes. > Thank you for fixing! Acked-by: Masami Hiramatsu > Signed-off-by: Borislav Petkov > --- > arch/x86/lib/insn.c | 1 + >

[PATCH net-next] net: nfc: nci: Change the NCI close sequence

2020-12-27 Thread Bongsu Jeon
From: Bongsu Jeon Change the NCI close sequence because the NCI Command timer should be deleted after flushing the NCI command work queue. Signed-off-by: Bongsu Jeon --- net/nfc/nci/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/nfc/nci/core.c

Re: [PATCH v1] scsi: ufs-mediatek: Enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL

2020-12-27 Thread Asutosh Das (asd)
On 12/24/2020 5:47 AM, Stanley Chu wrote: Hi Avri, Bean, On Thu, 2020-12-24 at 13:01 +0100, Bean Huo wrote: On Thu, 2020-12-24 at 11:03 +, Avri Altman wrote: Do you see any substantial benefit of having fWriteBoosterBufferFlushEn disabled? 1. The definition of fWriteBoosterBufferFlushEn

Re: [PATCH v1] scsi: ufs-mediatek: Enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL

2020-12-27 Thread Can Guo
On 2020-12-24 21:47, Stanley Chu wrote: Hi Avri, Bean, On Thu, 2020-12-24 at 13:01 +0100, Bean Huo wrote: On Thu, 2020-12-24 at 11:03 +, Avri Altman wrote: > > > Do you see any substantial benefit of having > > > fWriteBoosterBufferFlushEn > > > disabled? > > > > 1. The definition of

Re: [PATCH v5 1/4] spi: LS7A: Add Loongson LS7A SPI controller driver support

2020-12-27 Thread zhangqing
Hi, Huacai On 12/28/2020 08:32 AM, Huacai Chen wrote: Hi, Qing, On Sat, Dec 26, 2020 at 5:13 PM Qing Zhang wrote: The SPI controller has the following characteristics: - Full-duplex synchronous serial data transmission - Support up to 4 variable length byte transmission - Main mode support

Re: [PATCH v1 03/19] x86/insn: Add an insn_decode() API

2020-12-27 Thread Masami Hiramatsu
Hi, On Wed, 23 Dec 2020 18:42:17 +0100 Borislav Petkov wrote: > From: Borislav Petkov > > Users of the instruction decoder should use this to decode instruction > bytes. For that, have insn*() helpers return an int value to denote > success/failure. When there's an error fetching the next

Re: [PATCH] mm: add prototype for __add_to_page_cache_locked()

2020-12-27 Thread Alexei Starovoitov
On Wed, Dec 23, 2020 at 7:54 AM Christoph Hellwig wrote: > > On Wed, Dec 23, 2020 at 12:11:36PM +, Matthew Wilcox wrote: > > On Wed, Dec 23, 2020 at 08:31:26AM +, Christoph Hellwig wrote: > > > Can we please make the eBPF code stop referencing this function instead > > > of papering over

Re: [PATCH v5 1/4] spi: LS7A: Add Loongson LS7A SPI controller driver support

2020-12-27 Thread Huacai Chen
Hi, Qing, On Sat, Dec 26, 2020 at 5:13 PM Qing Zhang wrote: > > The SPI controller has the following characteristics: > > - Full-duplex synchronous serial data transmission > - Support up to 4 variable length byte transmission > - Main mode support > - Mode failure generates an error flag and

Re: [PATCH v5 3/4] MIPS: Loongson64: DTS: Add SPI support to LS7A

2020-12-27 Thread Huacai Chen
Reviewed-by: Huacai Chen On Sat, Dec 26, 2020 at 5:16 PM Qing Zhang wrote: > > Add spi support. > > Signed-off-by: Qing Zhang > --- > > v2: > - Add spi about pci device DT > > v3: > - Remove spiflash node > > v4: > - Remove useless compatible > > v5: > - Remove num-chipselects > > --- >

Re: [PATCH v5 2/4] spi: ls7a: Add YAML schemas

2020-12-27 Thread Huacai Chen
Reviewed-by: Huacai Chen On Sat, Dec 26, 2020 at 5:13 PM Qing Zhang wrote: > > Switch the DT binding to a YAML schema to enable the DT validation. > > Signed-off-by: Qing Zhang > --- > > v4: > - fix warnings/errors about running 'make dt_binding_check' > > v5: > - remove num-chipelects > >

[PATCH net] net: hdlc_ppp: Fix issues when mod_timer is called while timer is running

2020-12-27 Thread Xie He
ppp_cp_event is called directly or indirectly by ppp_rx with "ppp->lock" held. It may call mod_timer to add a new timer. However, at the same time ppp_timer may be already running and waiting for "ppp->lock". In this case, there's no need for ppp_timer to continue running and it can just exit. If

Linux 5.11-rc1

2020-12-27 Thread Linus Torvalds
Two weeks have passed, Christmas is over, and so is the merge window. I want to thank all the maintainers who sent in their pull requests early: we all wanted to get things done before the holidays really hit, and mostly it seemed to work quite well. In fact, it was rather nice to handle the big

Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting

2020-12-27 Thread Kirill A. Shutemov
On Sun, Dec 27, 2020 at 03:40:36PM -0800, Linus Torvalds wrote: > I think Kirill was intending to move the "if (ret)" up into the path > that sets it, IOW something like > > + if (!(vma->vm_flags & VM_SHARED)) { > + ret = check_stable_address_space(vma->vm_mm); > +

Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting

2020-12-27 Thread Kirill A. Shutemov
On Sun, Dec 27, 2020 at 11:38:22AM -0800, Linus Torvalds wrote: > On Sat, Dec 26, 2020 at 6:38 PM Hugh Dickins wrote: > > > > This patch (like its antecedents) moves the pte_unmap_unlock() from > > after do_fault_around()'s "check if the page fault is solved" into > > filemap_map_pages() itself

Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting

2020-12-27 Thread Linus Torvalds
On Sun, Dec 27, 2020 at 3:12 PM Linus Torvalds wrote: > > Ok, your fix for that folded in, and here's yet another version. Still not good. I don't know what happened, but the change of - vm_fault_t ret = 0; + vm_fault_t ret; is very very wrong. The next user is + if

[PATCH 3/3] fs/btrfs: avoid null pointer dereference if reloc control has not been initialized

2020-12-27 Thread Defang Bo
Similar to commmit<389305b2>, it turns out that fs_info::reloc_ctl can be NULL , so there should be a check for rc to prevent null pointer dereference. Signed-off-by: Defang Bo --- fs/btrfs/relocation.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/fs/btrfs/relocation.c

Re: LXC broken with 5.10-stable?, ok with 5.9-stable (Re: Linux 5.10.3)

2020-12-27 Thread Linus Torvalds
On Sun, Dec 27, 2020 at 1:25 PM Al Viro wrote: > > > Is there any point in not doing the same (scripted, obviously) for > all instances with .read == seq_read? IIRC, Christoph even posted > something along those lines, but it went nowhere for some reason... I'd rather limit splice (and

Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting

2020-12-27 Thread Linus Torvalds
On Sun, Dec 27, 2020 at 2:35 PM Hugh Dickins wrote: > > Yes, this one passes my testing on x86_64 and on i386. Ok, good. > But... > > ... Damian very helpfully reports that it does not build when > CONFIG_TRANSPARENT_HUGEPAGE is not set, since the "static " has > not been removed from the

Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting

2020-12-27 Thread Hugh Dickins
On Sun, 27 Dec 2020, Damian Tometzki wrote: > On Sun, 27. Dec 11:38, Linus Torvalds wrote: > > On Sat, Dec 26, 2020 at 6:38 PM Hugh Dickins wrote: > > > > > > This patch (like its antecedents) moves the pte_unmap_unlock() from > > > after do_fault_around()'s "check if the page fault is solved"

Re: [PATCH 1/5] clump_bits: Introduce the for_each_set_clump macro

2020-12-27 Thread Arnd Bergmann
On Sat, Dec 26, 2020 at 7:42 AM Syed Nayyar Waris wrote: > > This macro iterates for each group of bits (clump) with set bits, > within a bitmap memory region. For each iteration, "start" is set to > the bit offset of the found clump, while the respective clump value is > stored to the location

Re: PROBLEM: Recent raid10 block discard patchset causes filesystem corruption on fstrim

2020-12-27 Thread Song Liu
Hi Xiao, On Thu, Dec 24, 2020 at 2:18 AM Xiao Ni wrote: > > > [...] > > [ 789.709501] discard bio start : 70968, size : 191176 > [ 789.709507] first stripe index 69, start disk index 0, start disk > offset 70968 > [ 789.709509] last stripe index 256, end disk index 0, end disk offset > 262144

drivers/platform/x86/amd-pmc.c:88:5: warning: "CONFIG_DEBUG_FS" is not defined, evaluates to 0

2020-12-27 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f838f8d2b694cf9d524dc4423e9dd2db13892f3f commit: 156ec4731cb22b06c08e27debc1ef9f16f4bbb5e platform/x86: amd-pmc: Add AMD platform support for S2Idle date: 7 weeks ago config: i386-randconfig-p002-20201222

Re: [PATCH] gpiolib: cdev: fix frame size warning in gpio_ioctl()

2020-12-27 Thread Linus Walleij
On Sun, Dec 27, 2020 at 5:11 PM Kent Gibson wrote: > The kernel test robot reports the following warning in [1]: > > drivers/gpio/gpiolib-cdev.c: In function 'gpio_ioctl': > >>drivers/gpio/gpiolib-cdev.c:1437:1: warning: the frame size of 1040 bytes > is larger than 1024 bytes

Re: [RFC please help] membarrier: Rewrite sync_core_before_usermode()

2020-12-27 Thread Andy Lutomirski
On Sun, Dec 27, 2020 at 12:18 PM Mathieu Desnoyers wrote: > > - On Dec 27, 2020, at 1:28 PM, Andy Lutomirski l...@kernel.org wrote: > > > > > I admit that I'm rather surprised that the code worked at all on arm64, > > and I'm suspicious that it has never been very well tested. My apologies

Re: [PATCH 5.10 00/40] 5.10.3-rc1 review

2020-12-27 Thread Jeffrin Jose T
On Sun, 2020-12-27 at 17:05 +0100, Greg Kroah-Hartman wrote: > On Sun, Dec 27, 2020 at 09:20:07PM +0530, Jeffrin Jose T wrote: > > On Sat, 2020-12-26 at 16:06 +0100, Greg Kroah-Hartman wrote: > > > On Thu, Dec 24, 2020 at 03:13:38PM +0530, Jeffrin Jose T wrote: > > > > On Wed, 2020-12-23 at 16:33

Re: [PATCH 4/5] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-12-27 Thread Linus Walleij
On Sat, Dec 26, 2020 at 7:44 AM Syed Nayyar Waris wrote: > This patch reimplements the xgpio_set_multiple() function in > drivers/gpio/gpio-xilinx.c to use the new generic functions: > bitmap_get_value() and bitmap_set_value(). The code is now simpler > to read and understand. Moreover, instead

Re: [PATCH AUTOSEL 5.4 075/130] net/lapb: fix t1 timer handling for LAPB_STATE_0

2020-12-27 Thread Sasha Levin
On Thu, Dec 24, 2020 at 01:49:47AM -0800, Xie He wrote: On Wed, Dec 23, 2020 at 9:01 AM Xie He wrote: I don't think this patch is suitable for stable branches. This patch is part of a patch series that changes the lapb module from "establishing the L2 connection only when needed by L3", to

Re: [PATCH 0/5] Introduce the for_each_set_clump macro

2020-12-27 Thread Linus Walleij
On Sat, Dec 26, 2020 at 7:41 AM Syed Nayyar Waris wrote: > Since this patchset primarily affects GPIO drivers, would you like > to pick it up through your GPIO tree? Actually Bartosz is handling the GPIO patches for v5.12. I tried to merge the patch series before but failed for various reasons.

Re: LXC broken with 5.10-stable?, ok with 5.9-stable (Re: Linux 5.10.3)

2020-12-27 Thread Al Viro
On Sun, Dec 27, 2020 at 12:12:00PM -0800, Linus Torvalds wrote: > On Sun, Dec 27, 2020 at 11:05 AM Linus Torvalds > wrote: > > > > On Sun, Dec 27, 2020 at 10:39 AM Jussi Kivilinna > > wrote: > > > > > > 5.10.3 with patch compiles fine, but does not solve the issue. > > > > Duh. adding the

Re: [RFC PATCH 3/3] gpio: ep93xx: specify gpio_irq_chip->first

2020-12-27 Thread Linus Walleij
On Thu, Dec 24, 2020 at 12:22 PM Nikita Shubin wrote: > Port F irq's should be statically mapped to EP93XX_GPIO_F_IRQ_BASE. > > So we need to specify girq->first otherwise: > > "If device tree is used, then first_irq will be 0 and > irqs get mapped dynamically on the fly" > > And that's not the

Re: [RFC PATCH 2/3] gpio: ep93xx: drop to_irq binding

2020-12-27 Thread Linus Walleij
On Thu, Dec 24, 2020 at 12:22 PM Nikita Shubin wrote: > As ->to_irq is redefined in gpiochip_add_irqchip, having it defined in > driver is useless, so let's drop it. > > Also i think it is worth to give a gentle warning in > gpiochip_add_irqchip, to prevent people relying on to_irq. > > For

Re: [PATCH v6 08/12] gpio: bd9571mwv: Add BD9574MWF support

2020-12-27 Thread Linus Walleij
On Wed, Dec 23, 2020 at 11:22 AM Yoshihiro Shimoda wrote: > Add support for BD9574MWF which is similar chip with BD9571MWV. > Note that BD9574MWF has additional features "RECOV_GPOUT", > "FREQSEL" and "RTC_IN", but supports GPIO function only. > > Signed-off-by: Yoshihiro Shimoda > Reviewed-by:

Re: [PATCH v6 07/12] gpio: bd9571mwv: rid of using struct bd9571mwv

2020-12-27 Thread Linus Walleij
On Wed, Dec 23, 2020 at 11:22 AM Yoshihiro Shimoda wrote: > To simplify this driver, use dev_get_regmap() and > rid of using struct bd9571mwv. > > Signed-off-by: Yoshihiro Shimoda > Reviewed-by: Matti Vaittinen Acked-by: Linus Walleij Is this patch depending on other patches in the series

  1   2   3   >