Re: [PATCH] sysctl: use min() helper for namecmp()

2021-02-27 Thread Masahiro Yamada
(CC: Andrew Morton) A friendly reminder. This is just a minor clean-up. If nobody picks it up, I hope perhaps Andrew Morton will do. This patch: https://lore.kernel.org/patchwork/patch/1360092/ On Mon, Jan 4, 2021 at 5:33 PM Masahiro Yamada wrote: > > Make it slightly readable by using

Re: [PATCH 5/5] HID: apple-touchbar - Add driver for the Touch Bar on MacBook Pro's.

2021-02-27 Thread kernel test robot
Hi "Ronald, Thank you for the patch! Yet something to improve: [auto build test ERROR on hid/for-next] [also build test ERROR on iio/togreg jikos-trivial/for-next v5.11 next-20210226] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

Re: [PATCH] copy_file_range.2: Kernel v5.12 updates

2021-02-27 Thread Amir Goldstein
On Sun, Feb 28, 2021 at 1:08 AM Steve French wrote: > > On Fri, Feb 26, 2021 at 11:43 PM Amir Goldstein wrote: > > > > On Sat, Feb 27, 2021 at 12:19 AM Alejandro Colomar (man-pages) > > wrote: > > > > > > Hello Amir, Luis, > > > > > > On 2/24/21 5:10 PM, Amir Goldstein wrote: > > > > On Wed,

drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:1403:12: warning: stack frame size of 1088 bytes in function 'cdns_mhdp_link_up'

2021-02-27 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5695e51619745d4fe3ec2506a2f0cd982c5e27a4 commit: fb43aa0acdfd600c75b8c877bdf9f6e9893ffc9b drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge date: 5 months ago config:

Re: [PATCH RFC] x86: remove toolchain check for X32 ABI capability

2021-02-27 Thread Masahiro Yamada
On Sun, Feb 28, 2021 at 3:53 PM Nathan Chancellor wrote: > > On Sat, Feb 27, 2021 at 11:49:36PM -0700, Nathan Chancellor wrote: > > On Sun, Feb 28, 2021 at 12:15:16PM +0900, Masahiro Yamada wrote: > > > On Sun, Feb 28, 2021 at 3:41 AM Masahiro Yamada > > > wrote: > > > > > > > > This commit

Re: [PATCH 4/4] kbuild: include Makefile.compiler only when compiler is required

2021-02-27 Thread Masahiro Yamada
On Sun, Feb 28, 2021 at 3:10 PM Masahiro Yamada wrote: > > Since commit f2f02ebd8f38 ("kbuild: improve cc-option to clean up all > temporary files"), running 'make kernelversion' in a read-only source > tree emits a bunch of warnings: > > mkdir: cannot create directory '.tmp_12345': Permission

Re: [PATCH] devfreq: rk3399_dmc: Simplify with dev_err_probe()

2021-02-27 Thread Chanwoo Choi
On 21. 2. 28. 오전 1:35, Krzysztof Kozlowski wrote: On Sat, 29 Aug 2020 at 15:10, Chanwoo Choi wrote: On Sat, Aug 29, 2020 at 12:31 AM Krzysztof Kozlowski wrote: Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed.

Re: [PATCH RFC] x86: remove toolchain check for X32 ABI capability

2021-02-27 Thread Nathan Chancellor
On Sat, Feb 27, 2021 at 11:49:36PM -0700, Nathan Chancellor wrote: > On Sun, Feb 28, 2021 at 12:15:16PM +0900, Masahiro Yamada wrote: > > On Sun, Feb 28, 2021 at 3:41 AM Masahiro Yamada > > wrote: > > > > > > This commit reverts 0bf6276392e9 ("x32: Warn and disable rather than > > > error if

Re: [PATCH RFC] x86: remove toolchain check for X32 ABI capability

2021-02-27 Thread Nathan Chancellor
On Sun, Feb 28, 2021 at 12:15:16PM +0900, Masahiro Yamada wrote: > On Sun, Feb 28, 2021 at 3:41 AM Masahiro Yamada wrote: > > > > This commit reverts 0bf6276392e9 ("x32: Warn and disable rather than > > error if binutils too old"). > > > > The help text in arch/x86/Kconfig says enabling the X32

[RFC PATCH 17/18] docs: cgroup-v1: Add IOASIDs controller

2021-02-27 Thread Jacob Pan
Signed-off-by: Jacob Pan --- Documentation/admin-guide/cgroup-v1/index.rst | 1 + .../admin-guide/cgroup-v1/ioasids.rst | 110 ++ 2 files changed, 111 insertions(+) create mode 100644 Documentation/admin-guide/cgroup-v1/ioasids.rst diff --git

[RFC PATCH 18/18] ioasid: Add /dev/ioasid for userspace

2021-02-27 Thread Jacob Pan
From: Liu Yi L I/O Address Space IDs (IOASIDs) is used to tag DMA requests to target multiple DMA address spaces for physical devices. Its PCI terminology is called PASID (Process Address Space ID). Platforms with PASID support can provide PASID granularity DMA isolation, which is very useful

[RFC PATCH 16/18] iommu/ioasid: Consult IOASIDs cgroup for allocation

2021-02-27 Thread Jacob Pan
Once IOASIDs cgroup is active, we must consult the limitation set up by the cgroups during allocation. Freeing IOASIDs also need to return the quota back to the cgroup. Signed-off-by: Jacob Pan --- drivers/iommu/ioasid.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[RFC PATCH 15/18] cgroup: Introduce ioasids controller

2021-02-27 Thread Jacob Pan
IOASIDs are used to associate DMA requests with virtual address spaces. They are a system-wide limited resource made available to the userspace applications. Let it be VMs or user-space device drivers. This RFC patch introduces a cgroup controller to address the following problems: 1. Some user

[PATCH V4 12/18] iommu/vt-d: Remove mm reference for guest SVA

2021-02-27 Thread Jacob Pan
Now that IOASID core keeps track of the IOASID to mm_struct ownership in the forms of ioasid_set with IOASID_SET_TYPE_MM token type, there is no need to keep the same mapping in VT-d driver specific data. Native SVM usage is not affected by the change. Signed-off-by: Jacob Pan ---

[PATCH V4 14/18] iommu/vt-d: Listen to IOASID notifications

2021-02-27 Thread Jacob Pan
On Intel Scalable I/O Virtualization (SIOV) enabled platforms, IOMMU driver is one of the users of IOASIDs. In normal flow, callers will perform IOASID allocation, bind, unbind, and free in order. However, for guest SVA, IOASID free could come before unbind as guest is untrusted. This patch

[PATCH V4 13/18] iommu/ioasid: Add a workqueue for cleanup work

2021-02-27 Thread Jacob Pan
An IOASID can have multiple users, such as IOMMU driver, KVM, and device drivers. The atomic IOASID notifier is used to inform users of IOASID state change. For example, the IOASID_NOTIFY_UNBIND event is issued when the IOASID is no longer bound to an address space. This requires ordered actions

[PATCH V4 11/18] iommu/ioasid: Add ownership check in guest bind

2021-02-27 Thread Jacob Pan
Bind guest page table call comes with an IOASID provided by the userspace. To prevent attacks by malicious users, we must ensure the IOASID was allocated under the same process. This patch adds a new API that will perform an ownership check that is based on whether the IOASID belongs to the

[PATCH V4 10/18] iommu/ioasid: Support mm token type ioasid_set notifications

2021-02-27 Thread Jacob Pan
As a system-wide resource, IOASID is often shared by multiple kernel subsystems that are independent of each other. However, at the ioasid_set level, these kernel subsystems must communicate with each other for ownership checking, event notifications, etc. For example, on Intel Scalable IO

[PATCH V4 09/18] iommu/ioasid: Introduce notification APIs

2021-02-27 Thread Jacob Pan
Relations among IOASID users largely follow a publisher-subscriber pattern. E.g. to support guest SVA on Intel Scalable I/O Virtualization (SIOV) enabled platforms, VFIO, IOMMU, device drivers, KVM are all users of IOASIDs. When a state change occurs, VFIO publishes the change event that needs to

[PATCH V4 06/18] iommu/ioasid: Add free function and states

2021-02-27 Thread Jacob Pan
When an actively used IOASID is freed due to exceptions, users must be notified to perform the cleanup. The IOASID shall be put in a pending state until all users completed their cleanup work. This patch adds ioasid_free() function to let the caller initiate the freeing process. Both

[PATCH V4 08/18] iommu/ioasid: Introduce ioasid_set private ID

2021-02-27 Thread Jacob Pan
When an IOASID set is used for guest SVA, each VM will acquire its ioasid_set for IOASID allocations. IOASIDs within the VM must have a host/physical IOASID backing, mapping between guest and host IOASIDs can be non-identical. IOASID set private ID (SPID) is introduced in this patch to be used as

[PATCH V4 05/18] iommu/ioasid: Redefine IOASID set and allocation APIs

2021-02-27 Thread Jacob Pan
ioasid_set was introduced as an arbitrary token that is shared by a group of IOASIDs. For example, two IOASIDs allocated via the same ioasid_set pointer belong to the same set. For guest SVA usages, system-wide IOASID resources need to be partitioned such that each VM can have its own quota and

[PATCH V4 07/18] iommu/ioasid: Add ioasid_set iterator helper functions

2021-02-27 Thread Jacob Pan
Users of an ioasid_set may not keep track of all the IOASIDs allocated under the set. When collective actions are needed for each IOASIDs, it is useful to iterate over all the IOASIDs within the set. For example, when the ioasid_set is freed, the user might perform the same cleanup operation on

[PATCH V4 02/18] iommu/ioasid: Rename ioasid_set_data()

2021-02-27 Thread Jacob Pan
Rename ioasid_set_data() to ioasid_attach_data() to avoid confusion with struct ioasid_set. ioasid_set is a group of IOASIDs that share a common token. Reviewed-by: Jean-Philippe Brucker Signed-off-by: Jacob Pan --- drivers/iommu/intel/svm.c | 6 +++--- drivers/iommu/ioasid.c| 6 +++---

[PATCH V4 01/18] docs: Document IO Address Space ID (IOASID) APIs

2021-02-27 Thread Jacob Pan
IOASID is used to identify address spaces that can be targeted by device DMA. It is a system-wide resource that is essential to its many users. This document is an attempt to help developers from all vendors navigate the APIs. At this time, ARM SMMU and Intel’s Scalable IO Virtualization (SIOV)

[PATCH V4 00/18] IOASID extensions for guest SVA

2021-02-27 Thread Jacob Pan
I/O Address Space ID (IOASID) core code was introduced in v5.5 as a generic kernel allocator service for both PCIe Process Address Space ID (PASID) and ARM SMMU's Substream ID. IOASIDs are used to associate DMA requests with virtual address spaces, including both host and guest. In addition to

[PATCH V4 04/18] iommu/ioasid: Support setting system-wide capacity

2021-02-27 Thread Jacob Pan
IOASID is a system-wide resource that could vary on different systems. The default capacity is 20 bits as defined in the PCI-E specifications. This patch adds a function to allow adjusting system IOASID capacity. For VT-d this is set during boot as part of the Intel IOMMU initialization. APIs also

[PATCH V4 03/18] iommu/ioasid: Add a separate function for detach data

2021-02-27 Thread Jacob Pan
IOASID private data can be cleared by ioasid_attach_data() with a NULL data pointer. A common use case is for a caller to free the data afterward. ioasid_attach_data() calls synchronize_rcu() before return such that free data can be sure without outstanding readers. However, since

Re: [PATCH v4 2/3] media: uapi: Add VP9 stateless decoder controls

2021-02-27 Thread Alexandre Courbot
Hi Nicolas, On Thu, Feb 25, 2021 at 6:08 AM Nicolas Dufresne wrote: > > Le jeudi 10 septembre 2020 à 15:04 +0900, Alexandre Courbot a écrit : > > Hi Ezequiel, sorry for the late review! > > > > On Tue, May 19, 2020 at 2:40 AM Ezequiel Garcia > > wrote: > > > > > > From: Boris Brezillon > > > >

[PATCH 3/4] kbuild: spilt cc-option and friends to scripts/Makefile.compiler

2021-02-27 Thread Masahiro Yamada
scripts/Kbuild.include is included everywhere, but macros such as cc-option are needed by build targets only. For example, when 'make clean' traverses the tree, it does not need to evaluate $(call cc-option,). Split cc-option, ld-option, etc. to scripts/Makefile.compiler, which is only included

[PATCH 2/4] kbuild: prefix $(srctree)/ to some included Makefiles

2021-02-27 Thread Masahiro Yamada
VPATH is used in Kbuild to make pattern rules to search for prerequisites in both $(objtree) and $(srctree). Some source files may not be real sources, but generated by tools such as flex, bison, perl. In contrast, I doubt the benefit of --include-dir=$(abs_srctree) because it is always clear

[PATCH 4/4] kbuild: include Makefile.compiler only when compiler is required

2021-02-27 Thread Masahiro Yamada
Since commit f2f02ebd8f38 ("kbuild: improve cc-option to clean up all temporary files"), running 'make kernelversion' in a read-only source tree emits a bunch of warnings: mkdir: cannot create directory '.tmp_12345': Permission denied Non-build targets such as kernelversion, clean, help, etc.

[PATCH 1/4] kbuild: add image_name to no-sync-config-targets

2021-02-27 Thread Masahiro Yamada
'make image_name' needs include/config/auto.conf to show the correct output because KBUILD_IMAGE depends on CONFIG options, but should not attempt to resync the configuration. Signed-off-by: Masahiro Yamada --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH RFC] x86: remove toolchain check for X32 ABI capability

2021-02-27 Thread Fangrui Song
On 2021-02-28, Masahiro Yamada wrote: This commit reverts 0bf6276392e9 ("x32: Warn and disable rather than error if binutils too old"). The help text in arch/x86/Kconfig says enabling the X32 ABI support needs binutils 2.22 or later. This is met because the minimal binutils version is 2.23

RE: [PATCH 2/2] drivers: misc: add ripple counter driver

2021-02-27 Thread Chen, Mike Ximing
> -Original Message- > From: Rasmus Villemoes > Sent: Friday, February 26, 2021 9:14 AM > To: Greg Kroah-Hartman ; Rob Herring > > Cc: devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; Arnd Bergmann > ; linux-...@vger.kernel.org; Rasmus Villemoes > > Subject: [PATCH 2/2]

[PATCH] video: fbdev: sis: catch out of bounds in SiS_DoCalcDelay

2021-02-27 Thread Tong Zhang
idx1 is read from hardware and the range is [0, 30], the size of ThLowA and ThLowB is 24, so there could possibly an out of bounds access. This patch catches the OOB access and print a warning. [4.771691] == [4.771693] BUG:

Re: [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst

2021-02-27 Thread Jaegeuk Kim
On 02/04, Chao Yu wrote: > Jaegeuk, > > On 2021/2/2 16:00, Chao Yu wrote: > > - for (i = 0; i < dic->nr_cpages; i++) { > > + for (i = 0; i < cc->nr_cpages; i++) { > > struct page *page = dic->cpages[i]; > > por_fsstress still hang in this line? I'm stuck on testing the patches,

Re: [PATCH RFC] f2fs: fix to avoid selecting full segment w/ {AT,}SSR allocator

2021-02-27 Thread Jaegeuk Kim
On 02/23, Chao Yu wrote: > Jaegeuk, > > Could you please help to review this patch? since I doubt that this > issue can happen in real world... :( Let me take a look as soon as I have some time. Sorry for the delay. > > Thanks, > > On 2021/2/22 21:43, Chao Yu wrote: > > Ping, > > > > On

Re: hppa64-linux-ld: kernel/rcu/refscale.o(.init.text+0x228): cannot reach schedule_timeout_uninterruptible

2021-02-27 Thread Paul E. McKenney
On Sun, Feb 28, 2021 at 12:08:08PM +0800, kernel test robot wrote: > Hi Paul, > > First bad commit (maybe != root cause): > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 5695e51619745d4fe3ec2506a2f0cd982c5e27a4 > commit:

Re: [f2fs-dev] [PATCH][next] f2fs: Replace one-element array with flexible-array member

2021-02-27 Thread Jaegeuk Kim
On 02/25, Chao Yu wrote: > Hello, Gustavo, > > On 2021/2/25 3:03, Gustavo A. R. Silva wrote: > > There is a regular need in the kernel to provide a way to declare having > > a dynamically sized set of trailing elements in a structure. Kernel code > > should always use “flexible array members”[1]

[PATCH] drm/fb-helper: only unmap if buffer not null

2021-02-27 Thread Tong Zhang
drm_fbdev_cleanup() can be called when fb_helper->buffer is null, hence fb_helper->buffer should be checked before calling drm_client_buffer_vunmap(). This buffer is also checked in drm_client_framebuffer_delete(), so we should also do the same thing for drm_client_buffer_vunmap(). [ 199.128742]

Re: [PATCH v2 2/2] memblock: do not start bottom-up allocations with kernel_end

2021-02-27 Thread Florian Fainelli
On 12/17/2020 12:12 PM, Roman Gushchin wrote: > With kaslr the kernel image is placed at a random place, so starting > the bottom-up allocation with the kernel_end can result in an > allocation failure and a warning like this one: > > [0.002920] hugetlb_cma: reserve 2048 MiB, up to 2048

Re: [PATCH 5/5] HID: apple-touchbar - Add driver for the Touch Bar on MacBook Pro's.

2021-02-27 Thread kernel test robot
Hi "Ronald, Thank you for the patch! Yet something to improve: [auto build test ERROR on hid/for-next] [also build test ERROR on iio/togreg jikos-trivial/for-next v5.11 next-20210226] [cannot apply to jikos-hid/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And

hppa64-linux-ld: kernel/rcu/refscale.o(.init.text+0x228): cannot reach schedule_timeout_uninterruptible

2021-02-27 Thread kernel test robot
Hi Paul, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5695e51619745d4fe3ec2506a2f0cd982c5e27a4 commit: 1fbeb3a8c4de29433a8d230ee600b13d369b6c0f refperf: Rename refperf.c to refscale.c and change internal names

[PATCH] atm: lanai: dont run lanai_dev_close if not open

2021-02-27 Thread Tong Zhang
lanai_dev_open() can fail. When it fail, lanai->base is unmapped and the pci device is disabled. The caller, lanai_init_one(), then tries to run atm_dev_deregister(). This will subsequently call lanai_dev_close() and use the already released MMIO area. To fix this issue, set the lanai->base to

Re: [PATCH 5/5] HID: apple-touchbar - Add driver for the Touch Bar on MacBook Pro's.

2021-02-27 Thread kernel test robot
Hi "Ronald, Thank you for the patch! Yet something to improve: [auto build test ERROR on hid/for-next] [also build test ERROR on iio/togreg jikos-trivial/for-next v5.11 next-20210226] [cannot apply to jikos-hid/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And

[GIT PULL] csky changes for v5.12-rc1

2021-02-27 Thread guoren
Hi Linus, The following changes since commit 7c53f6b671f4aba70ff15e1b05148b10d58c2837: Linux 5.11-rc3 (2021-01-10 14:34:50 -0800) are available in the Git repository at: https://github.com/c-sky/csky-linux.git tags/csky-for-linus-5.12-rc1 for you to fetch changes up to

Re: [PATCH RFC] x86: remove toolchain check for X32 ABI capability

2021-02-27 Thread Masahiro Yamada
On Sun, Feb 28, 2021 at 3:41 AM Masahiro Yamada wrote: > > This commit reverts 0bf6276392e9 ("x32: Warn and disable rather than > error if binutils too old"). > > The help text in arch/x86/Kconfig says enabling the X32 ABI support > needs binutils 2.22 or later. This is met because the minimal

Re:reply

2021-02-27 Thread Ms. Reem
Hello, My name is Ms. Reem Ebrahim Al-Hashimi, I am the "Minister of state and Petroleum" also "Minister of State for International Cooperation" in UAE. I write to you on behalf of my other "three (3) colleagues" who has approved me to solicit for your "partnership in claiming of

Re: [PATCH v8 20/22] counter: Implement events_queue_size sysfs attribute

2021-02-27 Thread William Breathitt Gray
On Sat, Feb 27, 2021 at 03:18:47PM +, Jonathan Cameron wrote: > On Fri, 26 Feb 2021 09:03:48 +0900 > William Breathitt Gray wrote: > > > On Sun, Feb 21, 2021 at 03:51:40PM +, Jonathan Cameron wrote: > > > On Thu, 18 Feb 2021 19:32:16 +0900 > > > William Breathitt Gray wrote: > > > >

mm/compaction.c:463:20: warning: unused function 'isolation_suitable'

2021-02-27 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5695e51619745d4fe3ec2506a2f0cd982c5e27a4 commit: 9df41314390b81a541ca6e84c8340bad0959e4b5 mm/compaction: do page isolation first in compaction date: 2 months ago config: mips-randconfig-r004-20210228

Re: [PATCH V2] fs: dlm: Spellings fixed throughout the file lock.c

2021-02-27 Thread Randy Dunlap
On 2/27/21 5:02 PM, Bhaskar Chowdhury wrote: > > Few spelling fixes throughout the file. > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > Changes from V1: > Fixed the subject line typo. > Measured unwanted blank lines insertion. > > fs/dlm/lock.c | 6 +++--- > 1 file

rmem.c:undefined reference to `memremap'

2021-02-27 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5695e51619745d4fe3ec2506a2f0cd982c5e27a4 commit: 5a3fa75a4d9cb6bcfc9081ef224a4cdcd4b3eafe nvmem: Add driver to expose reserved memory as nvmem date: 3 weeks ago config: s390-randconfig-r013-20210228

Re: [PATCH] [v2] Input: Add "Share" button to Microsoft Xbox One controller.

2021-02-27 Thread Cameron Gutman
On 2/24/21 11:32 PM, Chris Ye wrote: > Add "Share" button input capability and input event mapping for > Microsoft Xbox One controller. > Fixed Microsoft Xbox One controller share button not working under USB > connection. > > Signed-off-by: Chris Ye > --- > drivers/input/joystick/xpad.c | 9

Re: [PATCH v1] xen: ACPI: Get rid of ACPICA message printing

2021-02-27 Thread Boris Ostrovsky
On 2/24/21 1:47 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The ACPI_DEBUG_PRINT() macro is used in a few places in > xen-acpi-cpuhotplug.c and xen-acpi-memhotplug.c for printing debug > messages, but that is questionable, because that macro belongs to > ACPICA and it should not

Re: [PATCH] Input: Add "Share" button to Microsoft Xbox One controller.

2021-02-27 Thread Cameron Gutman
On 2/25/21 12:26 AM, Dmitry Torokhov wrote: > On Wed, Feb 24, 2021 at 08:44:37PM -0800, Chris Ye wrote: >> Hi Dmitry, >> The latest Xbox One X series has this button, I can add a new >> XTYPE_XBOXONE_X and only apply the change to the new type. > > Sounds good to me. Cameron, what do you think? >

[PATCH] cpufreq: qcom-hw: fix dereferencing freed memory 'data'

2021-02-27 Thread Shawn Guo
Commit 67fc209b527d ("cpufreq: qcom-hw: drop devm_xxx() calls from init/exit hooks") introduces an issue of dereferencing freed memory 'data'. Fix it. Fixes: 67fc209b527d ("cpufreq: qcom-hw: drop devm_xxx() calls from init/exit hooks") Reported-by: kernel test robot Reported-by: Dan Carpenter

[PATCH 1/5] HID: Recognize sensors with application collections too.

2021-02-27 Thread Ronald Tschalär
According to HUTRR39 logical sensor devices may be nested inside physical collections or may be specified in multiple top-level application collections (see page 59, strategies 1 and 2). However, the current code was only recognizing those with physical collections. This issue turned up in recent

[PATCH 4/5] HID: apple-ibridge: Add Apple iBridge HID driver for T1 chip.

2021-02-27 Thread Ronald Tschalär
The iBridge device provides access to several devices, including: - the Touch Bar - the iSight webcam - the light sensor - the fingerprint sensor This driver provides the core support for managing the iBridge device and the access to the underlying devices. In particular, the functionality for

[PATCH 5/5] HID: apple-touchbar - Add driver for the Touch Bar on MacBook Pro's.

2021-02-27 Thread Ronald Tschalär
This driver enables basic touch bar functionality: enabling it, switching between modes on FN key press, and dimming and turning the display off/on when idle/active. Signed-off-by: Ronald Tschalär --- drivers/hid/Kconfig | 10 + drivers/hid/Makefile |1 +

[PATCH 3/5] HID: core: Export some report item parsing functions.

2021-02-27 Thread Ronald Tschalär
These are useful to drivers that need to scan or parse reports themselves. Signed-off-by: Ronald Tschalär --- drivers/hid/hid-core.c | 54 +- include/linux/hid.h| 4 2 files changed, 36 insertions(+), 22 deletions(-) diff --git

[PATCH 2/5] iio: hid-sensor-als: Support change sensitivity in illuminance too.

2021-02-27 Thread Ronald Tschalär
Recent MacBook Pro's specify the usage of the change sensitivity field as illuminance (with a change sensitivity modifier) rather than as light. Signed-off-by: Ronald Tschalär --- drivers/iio/light/hid-sensor-als.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH 0/5] Touch Bar and ALS support for MacBook Pro's

2021-02-27 Thread Ronald Tschalär
This patch set provides Touch Bar and ALS support on MacBook Pro's 13,*, 14,*, and 15,*. Some time a go an earlier version of these were posted to the list; all code comments from there have been incorporated. In addition the approach has been cleaned up, especially given that we now know how the

Re: [PATCH] kbuild: Fix for empty SUBLEVEL or PATCHLEVEL again

2021-02-27 Thread Sasha Levin
On Sat, Feb 27, 2021 at 11:20:23PM +0900, Masahiro Yamada wrote: Commit 9b82f13e7ef3 ("kbuild: clamp SUBLEVEL to 255") breaks the build if SUBLEVEL or PATCHLEVEL is empty. Commit 78d3bb4483ba ("kbuild: Fix for empty SUBLEVEL or PATCHLEVEL") fixed the issue by prepending a zero. This time, we

Re: drivers/cpufreq/qcom-cpufreq-hw.c:377 qcom_cpufreq_hw_cpu_init() error: we previously assumed 'data' could be null (see line 327)

2021-02-27 Thread Shawn Guo
On Sat, Feb 27, 2021 at 12:26:20PM +0300, Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 8b83369ddcb3fb9cab5c1088987ce477565bb630 > commit: 67fc209b527d023db4d087c68e44e9790aa089ef cpufreq: qcom-hw: drop > devm_xxx() calls

Re: INFO: task hung in switchdev_deferred_process_work (2)

2021-02-27 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:5695e516 Merge tag 'io_uring-worker.v3-2021-02-25' of git:.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=135da5cad0 kernel config:

[PATCH] staging: rtl8192u avoid flex array of flex array

2021-02-27 Thread Darryl T. Agostinelli
Undo the flex array in struct ieee80211_info_element. It is used as the flex array type in other structs (creating a flex array of flex arrays) making sparse unhappy. This change maintains the intent of the code and satisfies sparse. Signed-off-by: Darryl T. Agostinelli ---

[PATCH V2] fs: dlm: Spellings fixed throughout the file lock.c

2021-02-27 Thread Bhaskar Chowdhury
Few spelling fixes throughout the file. Signed-off-by: Bhaskar Chowdhury --- Changes from V1: Fixed the subject line typo. Measured unwanted blank lines insertion. fs/dlm/lock.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index

linux-next: Fixes tag needs some work in the netfilter tree

2021-02-27 Thread Stephen Rothwell
Hi all, In commit 8e24edddad15 ("netfilter: x_tables: gpf inside xt_find_revision()") Fixes tag Fixes: 656caff20e1 ("netfilter 04/09: x_tables: fix match/target revision lookup") has these problem(s): - SHA1 should be at least 12 digits long I don't think it is worth rebasing to fix

Re: [PATCH v3 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support

2021-02-27 Thread Nobuhiro Iwamatsu
Hi, 2021年2月12日(金) 21:10 Sai Krishna Potthuri : > > Adding pinctrl driver for Xilinx ZynqMP platform. > This driver queries pin information from firmware and registers > pin control accordingly. > > Signed-off-by: Sai Krishna Potthuri > --- > drivers/pinctrl/Kconfig | 13 + >

Re: possible deadlock in io_poll_double_wake (2)

2021-02-27 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:5695e516 Merge tag 'io_uring-worker.v3-2021-02-25' of git:.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=114e3866d0 kernel config:

Re: [PATCH RESEND] ide/falconide: Fix module unload

2021-02-27 Thread Finn Thain
On Sun, 3 Jan 2021, Jens Axboe wrote: > > > > This patch was sent in September and subsequently resent in November. > > I've since learned that the maintainer has been ill. What's the best > > way forward for fixes like this? > > I can queue it up. > That would be great.

Re: [PATCH v3 1/3] firmware: xilinx: Add pinctrl support

2021-02-27 Thread Nobuhiro Iwamatsu
Hi, 2021年2月12日(金) 21:10 Sai Krishna Potthuri : > > Adding pinctrl support to query platform specific information (pins) > from firmware. > > Signed-off-by: Sai Krishna Potthuri > Acked-by: Michal Simek > --- > drivers/firmware/xilinx/zynqmp.c | 114 +++ >

Re: [PATCH] fs: dlm: Spellings fixed throughout the fle lock.c

2021-02-27 Thread Randy Dunlap
On 2/27/21 3:33 PM, Bhaskar Chowdhury wrote: > > Few spelling fixes throughout the file. > in Subject: s/fle/file/ > Signed-off-by: Bhaskar Chowdhury > --- > fs/dlm/lock.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c >

Re: [PATCH 0/2] tracing: Detect unsafe dereferencing of pointers from trace events

2021-02-27 Thread Steven Rostedt
[ Resending with an address that should work for Felipe ] On Sat, 27 Feb 2021 14:18:02 -0500 Steven Rostedt wrote: > On Fri, 26 Feb 2021 14:21:00 -0800 > Linus Torvalds wrote: > > > On Fri, Feb 26, 2021 at 11:07 AM Steven Rostedt > > wrote: > > > > > > The first patch scans the print

kernel/sched/core.c:6854:20: warning: unused function 'balance_hotplug_wait'

2021-02-27 Thread kernel test robot
Hi Thomas, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5695e51619745d4fe3ec2506a2f0cd982c5e27a4 commit: 1cf12e08bc4d50a76b80c42a3109c53d8794a0c9 sched/hotplug: Consolidate task migration on CPU unplug date: 4

arch/x86/kvm/mmu/tdp_mmu.c:533:9: sparse: sparse: cast removes address space '__rcu' of expression

2021-02-27 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5695e51619745d4fe3ec2506a2f0cd982c5e27a4 commit: 08f07c800e9d35b59d0c8346333f189160bd67d4 KVM: x86/mmu: Flush TLBs after zap in TDP MMU PF handler date: 3 weeks ago config: x86_64-randconfig-s022-20210228

Re: Question about the "EXPERIMENTAL" tag for dax in XFS

2021-02-27 Thread Dan Williams
On Sat, Feb 27, 2021 at 2:36 PM Dave Chinner wrote: > > On Fri, Feb 26, 2021 at 02:41:34PM -0800, Dan Williams wrote: > > On Fri, Feb 26, 2021 at 1:28 PM Dave Chinner wrote: > > > On Fri, Feb 26, 2021 at 12:59:53PM -0800, Dan Williams wrote: > > > > On Fri, Feb 26, 2021 at 12:51 PM Dave Chinner

Re: linux-next: Signed-off-by missing for commits in Linus' tree

2021-02-27 Thread Linus Walleij
On Wed, Feb 24, 2021 at 10:30 PM Kees Cook wrote: > I wonder if we need this in Documentation/maintainer/configure-git.rst That is generally a good idea. > and to put check_commits and check_fixes into tools/ somewhere? People keep saying we should put git hooks somewhere where they can be

general protection fault in crypto_destroy_tfm

2021-02-27 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:29c395c7 Merge tag 'x86-entry-2021-02-24' of git://git.ker.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15246466d0 kernel config: https://syzkaller.appspot.com/x/.config?x=c581c545cb4ffac7

[PATCH] fs: dlm: Spellings fixed throughout the fle lock.c

2021-02-27 Thread Bhaskar Chowdhury
Few spelling fixes throughout the file. Signed-off-by: Bhaskar Chowdhury --- fs/dlm/lock.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 002123efc6b0..efcd84faca14 100644 --- a/fs/dlm/lock.c +++ b/fs/dlm/lock.c @@ -91,7

mtk_mdp_comp.c:undefined reference to `mtk_smi_larb_get'

2021-02-27 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5695e51619745d4fe3ec2506a2f0cd982c5e27a4 commit: 50fc8d9232cdc64b9e9d1b9488452f153de52b69 memory: mtk-smi: Allow building as module date: 5 weeks ago config: openrisc-randconfig-r004-20210228 (attached as

Re: [PATCH] copy_file_range.2: Kernel v5.12 updates

2021-02-27 Thread Steve French
On Fri, Feb 26, 2021 at 11:43 PM Amir Goldstein wrote: > > On Sat, Feb 27, 2021 at 12:19 AM Alejandro Colomar (man-pages) > wrote: > > > > Hello Amir, Luis, > > > > On 2/24/21 5:10 PM, Amir Goldstein wrote: > > > On Wed, Feb 24, 2021 at 4:22 PM Luis Henriques wrote: > > >> > > >> Update

drivers/gpu/drm/kmb/kmb_dsi.c:812:2: warning: unused function 'set_test_mode_src_osc_freq_target_low_bits'

2021-02-27 Thread kernel test robot
Hi Geert, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5695e51619745d4fe3ec2506a2f0cd982c5e27a4 commit: ade896460e4a62f5e4a892a98d254937f6f5b64c drm: DRM_KMB_DISPLAY should depend on ARCH_KEEMBAY date: 4

[PATCH v2] MIPS: select CPU_MIPS64 for remaining MIPS64 CPUs

2021-02-27 Thread Jason A. Donenfeld
CPU_MIPS64 is supposed to be selected for CPUs that implement a revision of the MIPS64 ISA. While it contains the generic ones, it forgot about Octeon and Loongson in its list, which are indeed MIPS64 processors. This commit adds these missing CPUs to the auto-selection list. Cc: Maciej W.

Re: [PATCH] tools: include: nolibc: Fix a typo occured to occurred in the file nolibc.h

2021-02-27 Thread Randy Dunlap
On 2/27/21 2:44 PM, Bhaskar Chowdhury wrote: > > s/occured/occurred/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > Stolen result from Colin's finding and share from the other places. :) > > tools/include/nolibc/nolibc.h | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] MIPS: select CPU_MIPS64 for remaining MIPS64 CPUs

2021-02-27 Thread Jason A. Donenfeld
On Sat, Feb 27, 2021 at 2:41 PM Maciej W. Rozycki wrote: > > On Sat, 27 Feb 2021, Jason A. Donenfeld wrote: > > > The CPU_MIPS64 and CPU_MIPS32 variables are supposed to be able to > > distinguish broadly between 64-bit and 32-bit MIPS CPUs. However, they > > That is not true. The purpose of

[PATCH] tools: include: nolibc: Fix a typo occured to occurred in the file nolibc.h

2021-02-27 Thread Bhaskar Chowdhury
s/occured/occurred/ Signed-off-by: Bhaskar Chowdhury --- Stolen result from Colin's finding and share from the other places. :) tools/include/nolibc/nolibc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/include/nolibc/nolibc.h b/tools/include/nolibc/nolibc.h

Re: Question about the "EXPERIMENTAL" tag for dax in XFS

2021-02-27 Thread Dave Chinner
On Fri, Feb 26, 2021 at 02:41:34PM -0800, Dan Williams wrote: > On Fri, Feb 26, 2021 at 1:28 PM Dave Chinner wrote: > > On Fri, Feb 26, 2021 at 12:59:53PM -0800, Dan Williams wrote: > > > On Fri, Feb 26, 2021 at 12:51 PM Dave Chinner wrote: > > > > > My immediate concern is the issue Jason

Hello okay

2021-02-27 Thread Ms. Reem
Hello, My name is Ms. Reem Ebrahim Al-Hashimi, I am the "Minister of state and Petroleum" also "Minister of State for International Cooperation" in UAE. I write to you on behalf of my other "three (3) colleagues" who has approved me to solicit for your "partnership in claiming of {us$47=Million}"

[PATCH 4/4] staging:rtl8712: replace cap_* definitions with native kernel WLAN_CAPABILITY_*

2021-02-27 Thread Ivan Safonov
cap_* definitions duplicate WLAN_CAPABILITY_*. Remove cap_* definitions, improve code consistency. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8712/ieee80211.c | 6 +++--- drivers/staging/rtl8712/wifi.h | 7 --- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git

[PATCH 1/4] staging:rtl8712: replace get_(d|s)a with ieee80211_get_(D|S)A

2021-02-27 Thread Ivan Safonov
get_da()/get_sa() duplicate native ieee80211_get_(D|S)A functions. Remove get_(d|s)a, use ieee80211_get_(D|S)A instead. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8712/rtl871x_recv.c | 4 +-- drivers/staging/rtl8712/wifi.h | 45 -- 2 files changed, 2

[PATCH 2/4] staging:rtl8712: remove unused definitions from wifi.h

2021-02-27 Thread Ivan Safonov
These definitions are not used and will not be useful in the future. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8712/wifi.h | 74 -- 1 file changed, 74 deletions(-) diff --git a/drivers/staging/rtl8712/wifi.h b/drivers/staging/rtl8712/wifi.h index

[PATCH 3/4] staging:rtl8712: use IEEE80211_FCTL_* kernel definitions

2021-02-27 Thread Ivan Safonov
_TO_DS_, _FROM_DS_, _MORE_FRAG_, _RETRY_, _PWRMGT_, _MORE_DATA_, _PRIVACY_, _ORDER_ definitions are duplicate IEEE80211_FCTL_* kernel definitions. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8712/wifi.h | 52 ++ 1 file changed, 22 insertions(+), 30

[PATCH 0/4] staging:rtl8712: avoid unnecessary definitions in wifi.h

2021-02-27 Thread Ivan Safonov
wifi.h contains unnecessary definitions. Some of them are not used at all, some can be replaced with native definitions. Ivan Safonov (4): staging:rtl8712: replace get_(d|s)a with ieee80211_get_(D|S)A staging:rtl8712: remove unused definitions from wifi.h staging:rtl8712: use

[PATCH] staging: rtl8723bs: Fixed indentation and coding style

2021-02-27 Thread chakravarthikulkarni
This clean up indentaion issue as well as coding style issue. Signed-off-by: chakravarthikulkarni --- drivers/staging/rtl8723bs/include/rtw_cmd.h | 30 ++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/rtw_cmd.h

[PATCH] usb: dwc2: Add STM32 related debugfs entries

2021-02-27 Thread Martin Devera
These are entries related to STM32MP1 PHY control. Signed-off-by: Martin Devera --- drivers/usb/dwc2/debugfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc2/debugfs.c b/drivers/usb/dwc2/debugfs.c index aaafd463d72a..f13eed4231e1 100644 --- a/drivers/usb/dwc2/debugfs.c

arch/x86/kvm/mmu/tdp_mmu.c:388:49: sparse: sparse: incorrect type in argument 2 (different address spaces)

2021-02-27 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5695e51619745d4fe3ec2506a2f0cd982c5e27a4 commit: 7cca2d0b7e7d9f3cd740d41afdc00051c9b508a0 KVM: x86/mmu: Protect TDP MMU page table memory with RCU date: 3 weeks ago config: x86_64-randconfig-s022-20210228

Re: [PATCH] uapi: nfnetlink_cthelper.h: fix userspace compilation error

2021-02-27 Thread Pablo Neira Ayuso
On Mon, Feb 22, 2021 at 08:00:00AM +, Dmitry V. Levin wrote: > Apparently, and > could not be included into the same > compilation unit because of a cut-and-paste typo in the former header. Applied, thanks.

[PATCH] atm: eni: dont release is never initialized

2021-02-27 Thread Tong Zhang
label err_eni_release is reachable when eni_start() fail. In eni_start() it calls dev->phy->start() in the last step, if start() fail we don't need to call phy->stop(), if start() is never called, we neither need to call phy->stop(), otherwise null-ptr-deref will happen. In order to fix this

  1   2   3   >