Re: [PATCH v7 7/8] fsdax: Introduce dax_iomap_ops for end of reflink

2021-08-26 Thread Shiyang Ruan
On 2021/8/27 13:04, Dan Williams wrote: On Thu, Aug 26, 2021 at 8:30 PM Shiyang Ruan wrote: On 2021/8/20 23:18, Dan Williams wrote: On Thu, Aug 19, 2021 at 11:13 PM ruansy.fnst wrote: On 2021/8/20 上午11:01, Dan Williams wrote: On Sun, Aug 15, 2021 at 11:05 PM Shiyang Ruan wrote:

Re: [PATCH v7 3/8] fsdax: Replace mmap entry in case of CoW

2021-08-26 Thread Shiyang Ruan
On 2021/8/27 13:00, Dan Williams wrote: On Thu, Aug 26, 2021 at 8:22 PM Shiyang Ruan wrote: On 2021/8/23 20:57, Christoph Hellwig wrote: On Thu, Aug 19, 2021 at 03:54:01PM -0700, Dan Williams wrote: static void *dax_insert_entry(struct xa_state *xas, struct vm_fault *vmf,

Re: [PATCH v7 7/8] fsdax: Introduce dax_iomap_ops for end of reflink

2021-08-26 Thread Dan Williams
On Thu, Aug 26, 2021 at 8:30 PM Shiyang Ruan wrote: > > > > On 2021/8/20 23:18, Dan Williams wrote: > > On Thu, Aug 19, 2021 at 11:13 PM ruansy.fnst > > wrote: > >> > >> > >> > >> On 2021/8/20 上午11:01, Dan Williams wrote: > >>> On Sun, Aug 15, 2021 at 11:05 PM Shiyang Ruan > >>> wrote: >

Re: [PATCH v7 3/8] fsdax: Replace mmap entry in case of CoW

2021-08-26 Thread Dan Williams
On Thu, Aug 26, 2021 at 8:22 PM Shiyang Ruan wrote: > > > > On 2021/8/23 20:57, Christoph Hellwig wrote: > > On Thu, Aug 19, 2021 at 03:54:01PM -0700, Dan Williams wrote: > >> > >> static void *dax_insert_entry(struct xa_state *xas, struct vm_fault *vmf, > >>const s

Re: [PATCH v7 8/8] fs/xfs: Add dax dedupe support

2021-08-26 Thread Shiyang Ruan
On 2021/8/20 11:08, Dan Williams wrote: On Sun, Aug 15, 2021 at 11:05 PM Shiyang Ruan wrote: Introduce xfs_mmaplock_two_inodes_and_break_dax_layout() for dax files who are going to be deduped. After that, call compare range function only when files are both DAX or not. Signed-off-by: Shiy

Re: [PATCH v7 7/8] fsdax: Introduce dax_iomap_ops for end of reflink

2021-08-26 Thread Shiyang Ruan
On 2021/8/20 23:18, Dan Williams wrote: On Thu, Aug 19, 2021 at 11:13 PM ruansy.fnst wrote: On 2021/8/20 上午11:01, Dan Williams wrote: On Sun, Aug 15, 2021 at 11:05 PM Shiyang Ruan wrote: After writing data, reflink requires end operations to remap those new allocated extents. The cur

Re: [PATCH v7 4/8] fsdax: Add dax_iomap_cow_copy() for dax_iomap_zero

2021-08-26 Thread Shiyang Ruan
On 2021/8/20 10:39, Dan Williams wrote: On Sun, Aug 15, 2021 at 11:04 PM Shiyang Ruan wrote: Punch hole on a reflinked file needs dax_iomap_cow_copy() too. Otherwise, data in not aligned area will be not correct. So, add the srcmap to dax_iomap_zero() and replace memset() as dax_iomap_cow_

Re: [PATCH v7 3/8] fsdax: Replace mmap entry in case of CoW

2021-08-26 Thread Shiyang Ruan
On 2021/8/23 20:57, Christoph Hellwig wrote: On Thu, Aug 19, 2021 at 03:54:01PM -0700, Dan Williams wrote: static void *dax_insert_entry(struct xa_state *xas, struct vm_fault *vmf, const struct iomap_iter *iter, void *entry, pfn_t pfn,