Re: [PATCH v3] dax/kmem: Pass valid argument to memory_group_register_static

2023-06-29 Thread Tarun Sahu
Hi, This is just a gentle reminder, If any other information is needed. Tarun Sahu writes: > memory_group_register_static takes maximum number of pages as the argument > while dev_dax_kmem_probe passes total_len (in bytes) as the argument. > > IIUC, I don't see any crash/panic impact as

RE: [PATCH v5 09/10] acpi/nfit: Move handler installing logic to driver

2023-06-29 Thread Dan Williams
Michal Wilczynski wrote: > Currently logic for installing notifications from ACPI devices is > implemented using notify callback in struct acpi_driver. Preparations > are being made to replace acpi_driver with more generic struct > platform_driver, which doesn't contain notify callback.

RE: [PATCH v5 08/10] acpi/nfit: Improve terminator line in acpi_nfit_ids

2023-06-29 Thread Dan Williams
Michal Wilczynski wrote: > Currently terminator line contains redunant characters. Remove them and > also remove a comma at the end. > > Signed-off-by: Michal Wilczynski > --- > drivers/acpi/nfit/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v5 09/10] acpi/nfit: Move handler installing logic to driver

2023-06-29 Thread Rafael J. Wysocki
On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski wrote: > > Currently logic for installing notifications from ACPI devices is > implemented using notify callback in struct acpi_driver. Preparations > are being made to replace acpi_driver with more generic struct > platform_driver, which doesn't

Re: [PATCH v5 08/10] acpi/nfit: Improve terminator line in acpi_nfit_ids

2023-06-29 Thread Rafael J. Wysocki
On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski wrote: > > Currently terminator line contains redunant characters. Well, they are terminating the list properly AFAICS, so they aren't redundant and the size of it before and after the change is actually the same, isn't it? > Remove them and

Re: [PATCH v5 07/10] acpi/nfit: Move acpi_nfit_notify() before acpi_nfit_add()

2023-06-29 Thread Rafael J. Wysocki
On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski wrote: > > To use new style of installing event handlers acpi_nfit_notify() needs > to be known inside acpi_nfit_add(). Move acpi_nfit_notify() upwards in > the file, so it can be used inside acpi_nfit_add(). > > Signed-off-by: Michal Wilczynski

Re: [PATCH v5 05/10] acpi/battery: Move handler installing logic to driver

2023-06-29 Thread Rafael J. Wysocki
On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski wrote: > > Currently logic for installing notifications from ACPI devices is > implemented using notify callback in struct acpi_driver. Preparations > are being made to replace acpi_driver with more generic struct > platform_driver, which doesn't

Re: [PATCH v5 04/10] acpi/video: Move handler installing logic to driver

2023-06-29 Thread Rafael J. Wysocki
On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski wrote: > > Currently logic for installing notifications from ACPI devices is > implemented using notify callback in struct acpi_driver. Preparations > are being made to replace acpi_driver with more generic struct > platform_driver, which doesn't

Re: [PATCH v5 03/10] acpi/ac: Move handler installing logic to driver

2023-06-29 Thread Rafael J. Wysocki
On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski wrote: > > Currently logic for installing notifications from ACPI devices is > implemented using notify callback in struct acpi_driver. Preparations > are being made to replace acpi_driver with more generic struct > platform_driver, which doesn't