Re: [PATCH v6 7/9] acpi/nfit: Move handler installing logic to driver

Hi Michal, kernel test robot noticed the following build warnings: [auto build test WARNING on rafael-pm/linux-next] [also build test WARNING on nvdimm/libnvdimm-for-next] [cannot apply to nvdimm/dax-misc] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[GIT PULL] NVDIMM and DAX for 6.5

Hi Linus, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git tags/libnvdimm-for-6.5 ... to receive the libnvdimm and DAX update for v6.5. This is mostly small cleanups and fixes, with the biggest change being the change to the DAX fault handler allowing it to

[PATCH v6 9/9] acpi/thermal: Move handler installing logic to driver

Currently logic for installing notifications from ACPI devices is implemented using notify callback in struct acpi_driver. Preparations are being made to replace acpi_driver with more generic struct platform_driver, which doesn't contain notify callback. Furthermore as of now handlers are being

[PATCH v6 8/9] acpi/nfit: Remove unnecessary .remove callback

Nfit driver doesn't use .remove() callback and provide an empty function as it's .remove() callback. Remove empty acpi_nfit_remove() and initialization of callback. Suggested-by: Dan Williams Signed-off-by: Michal Wilczynski --- drivers/acpi/nfit/core.c | 6 -- 1 file changed, 6

[PATCH v6 7/9] acpi/nfit: Move handler installing logic to driver

Currently logic for installing notifications from ACPI devices is implemented using notify callback in struct acpi_driver. Preparations are being made to replace acpi_driver with more generic struct platform_driver, which doesn't contain notify callback. Furthermore as of now handlers are being

[PATCH v6 6/9] acpi/hed: Move handler installing logic to driver

Currently logic for installing notifications from ACPI devices is implemented using notify callback in struct acpi_driver. Preparations are being made to replace acpi_driver with more generic struct platform_driver, which doesn't contain notify callback. Furthermore as of now handlers are being

[PATCH v6 5/9] acpi/battery: Move handler installing logic to driver

Currently logic for installing notifications from ACPI devices is implemented using notify callback in struct acpi_driver. Preparations are being made to replace acpi_driver with more generic struct platform_driver, which doesn't contain notify callback. Furthermore as of now handlers are being

[PATCH v6 4/9] acpi/video: Move handler installing logic to driver

Currently logic for installing notifications from ACPI devices is implemented using notify callback in struct acpi_driver. Preparations are being made to replace acpi_driver with more generic struct platform_driver, which doesn't contain notify callback. Furthermore as of now handlers are being

[PATCH v6 3/9] acpi/ac: Move handler installing logic to driver

Currently logic for installing notifications from ACPI devices is implemented using notify callback in struct acpi_driver. Preparations are being made to replace acpi_driver with more generic struct platform_driver, which doesn't contain notify callback. Furthermore as of now handlers are being

[PATCH v6 2/9] acpi/bus: Set driver_data to NULL every time .add() fails

Most drivers set driver_data during .add() callback, but usually they don't set it back to NULL in case of a failure. Set driver_data to NULL in acpi_device_probe() to avoid code duplication. Signed-off-by: Michal Wilczynski --- drivers/acpi/bus.c | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH v6 1/9] acpi/bus: Introduce wrappers for ACPICA event handler install/remove

Introduce new acpi_dev_install_notify_handler() and acpi_dev_remove_notify_handler(). Those functions are replacing old installers, and after all drivers switch to the new model, old installers will be removed. Make acpi_dev_install_notify_handler() and acpi_dev_remove_notify_handler()

[PATCH v6 0/9] Remove .notify callback in acpi_device_ops

*** IMPORTANT *** This is part 1 - only drivers in acpi directory to ease up review process. Rest of the drivers will be handled in separate patchsets. Currently drivers support ACPI event handlers by defining .notify callback in acpi_device_ops. This solution is suboptimal as event handler

Re: [PATCH v5 09/10] acpi/nfit: Move handler installing logic to driver

On 6/30/2023 7:19 PM, Dan Williams wrote: > Wilczynski, Michal wrote: >> >> On 6/29/2023 10:54 PM, Dan Williams wrote: >>> Michal Wilczynski wrote: Currently logic for installing notifications from ACPI devices is implemented using notify callback in struct acpi_driver. Preparations

Re: [PATCH v5 09/10] acpi/nfit: Move handler installing logic to driver

Wilczynski, Michal wrote: > > > On 6/29/2023 10:54 PM, Dan Williams wrote: > > Michal Wilczynski wrote: > >> Currently logic for installing notifications from ACPI devices is > >> implemented using notify callback in struct acpi_driver. Preparations > >> are being made to replace acpi_driver

Re: [PATCH v5 09/10] acpi/nfit: Move handler installing logic to driver

On 6/29/2023 10:54 PM, Dan Williams wrote: > Michal Wilczynski wrote: >> Currently logic for installing notifications from ACPI devices is >> implemented using notify callback in struct acpi_driver. Preparations >> are being made to replace acpi_driver with more generic struct >>

Re: [PATCH v5 08/10] acpi/nfit: Improve terminator line in acpi_nfit_ids

On 6/30/2023 1:13 PM, Rafael J. Wysocki wrote: > On Fri, Jun 30, 2023 at 1:04 PM Rafael J. Wysocki wrote: >> On Fri, Jun 30, 2023 at 11:52 AM Wilczynski, Michal >> wrote: >>> >>> >>> On 6/29/2023 6:14 PM, Rafael J. Wysocki wrote: On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski

Re: [PATCH v5 08/10] acpi/nfit: Improve terminator line in acpi_nfit_ids

On Fri, Jun 30, 2023 at 1:04 PM Rafael J. Wysocki wrote: > > On Fri, Jun 30, 2023 at 11:52 AM Wilczynski, Michal > wrote: > > > > > > > > On 6/29/2023 6:14 PM, Rafael J. Wysocki wrote: > > > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski > > > wrote: > > >> Currently terminator line contains

Re: [PATCH v5 08/10] acpi/nfit: Improve terminator line in acpi_nfit_ids

On Fri, Jun 30, 2023 at 11:52 AM Wilczynski, Michal wrote: > > > > On 6/29/2023 6:14 PM, Rafael J. Wysocki wrote: > > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski > > wrote: > >> Currently terminator line contains redunant characters. > > Well, they are terminating the list properly AFAICS,

Re: [PATCH v5 09/10] acpi/nfit: Move handler installing logic to driver

On Fri, Jun 30, 2023 at 11:55 AM Wilczynski, Michal wrote: > > > > On 6/29/2023 6:18 PM, Rafael J. Wysocki wrote: > > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski > > wrote: > >> Currently logic for installing notifications from ACPI devices is > >> implemented using notify callback in

Re: [PATCH v5 07/10] acpi/nfit: Move acpi_nfit_notify() before acpi_nfit_add()

On Fri, Jun 30, 2023 at 11:48 AM Wilczynski, Michal wrote: > > > > On 6/29/2023 6:06 PM, Rafael J. Wysocki wrote: > > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski > > wrote: > >> To use new style of installing event handlers acpi_nfit_notify() needs > >> to be known inside acpi_nfit_add().

Re: [PATCH v5 08/10] acpi/nfit: Improve terminator line in acpi_nfit_ids

On 6/29/2023 10:51 PM, Dan Williams wrote: > Michal Wilczynski wrote: >> Currently terminator line contains redunant characters. Remove them and >> also remove a comma at the end. >> >> Signed-off-by: Michal Wilczynski >> --- >> drivers/acpi/nfit/core.c | 2 +- >> 1 file changed, 1

Re: [PATCH v5 09/10] acpi/nfit: Move handler installing logic to driver

On 6/29/2023 6:18 PM, Rafael J. Wysocki wrote: > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski > wrote: >> Currently logic for installing notifications from ACPI devices is >> implemented using notify callback in struct acpi_driver. Preparations >> are being made to replace acpi_driver

Re: [PATCH v5 08/10] acpi/nfit: Improve terminator line in acpi_nfit_ids

On 6/29/2023 6:14 PM, Rafael J. Wysocki wrote: > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski > wrote: >> Currently terminator line contains redunant characters. > Well, they are terminating the list properly AFAICS, so they aren't > redundant and the size of it before and after the

Re: [PATCH v5 05/10] acpi/battery: Move handler installing logic to driver

On 6/29/2023 6:05 PM, Rafael J. Wysocki wrote: > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski > wrote: >> Currently logic for installing notifications from ACPI devices is >> implemented using notify callback in struct acpi_driver. Preparations >> are being made to replace acpi_driver

Re: [PATCH v5 07/10] acpi/nfit: Move acpi_nfit_notify() before acpi_nfit_add()

On 6/29/2023 6:06 PM, Rafael J. Wysocki wrote: > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski > wrote: >> To use new style of installing event handlers acpi_nfit_notify() needs >> to be known inside acpi_nfit_add(). Move acpi_nfit_notify() upwards in >> the file, so it can be used inside

Re: [PATCH v5 03/10] acpi/ac: Move handler installing logic to driver

On Fri, Jun 30, 2023 at 11:41 AM Rafael J. Wysocki wrote: > > On Fri, Jun 30, 2023 at 11:39 AM Wilczynski, Michal > wrote: > > > > > > > > On 6/29/2023 5:55 PM, Rafael J. Wysocki wrote: > > > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski > > > wrote: > > >> Currently logic for installing

Re: [PATCH v5 04/10] acpi/video: Move handler installing logic to driver

On 6/29/2023 5:58 PM, Rafael J. Wysocki wrote: > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski > wrote: >> Currently logic for installing notifications from ACPI devices is >> implemented using notify callback in struct acpi_driver. Preparations >> are being made to replace acpi_driver

Re: [PATCH v5 03/10] acpi/ac: Move handler installing logic to driver

On Fri, Jun 30, 2023 at 11:39 AM Wilczynski, Michal wrote: > > > > On 6/29/2023 5:55 PM, Rafael J. Wysocki wrote: > > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski > > wrote: > >> Currently logic for installing notifications from ACPI devices is > >> implemented using notify callback in

Re: [PATCH v5 03/10] acpi/ac: Move handler installing logic to driver

On 6/29/2023 5:55 PM, Rafael J. Wysocki wrote: > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski > wrote: >> Currently logic for installing notifications from ACPI devices is >> implemented using notify callback in struct acpi_driver. Preparations >> are being made to replace acpi_driver