RE: [PATCH 2/2] ASoC: DA7219: Implement error check on reg read and write

2018-12-04 Thread Adam Thomson
On 04 December 2018 18:36, Akshu Agrawal wrote: > Failed i2c transaction can lead to failure in reg read or write. > Need to have error check for each read write operation. > I'm not really clear what this gains you. If I2C is broken this won't solve anything, and you have far deeper problems.

RE: [PATCH v2 1/2] power: supply: add input voltage limit property.

2018-11-22 Thread Adam Thomson
evel > knowledge or user input. > > Signed-off-by: Enric Balletbo i Serra > Reviewed-by: Guenter Roeck Acked-by: Adam Thomson > --- > > Changes in v2: > - Document the new property in ABI/testing/sysfs-class-power. > - Add the Reviewed-by Guenter Roeck ta

RE: [PATCH v2 1/2] power: supply: add input voltage limit property.

2018-11-22 Thread Adam Thomson
evel > knowledge or user input. > > Signed-off-by: Enric Balletbo i Serra > Reviewed-by: Guenter Roeck Acked-by: Adam Thomson > --- > > Changes in v2: > - Document the new property in ABI/testing/sysfs-class-power. > - Add the Reviewed-by Guenter Roeck ta

RE: [PATCH 1/2] power: supply: add input voltage limit property.

2018-11-21 Thread Adam Thomson
On 21 November 2018 15:35, Enric Balletbo i Serra wrote: > We have a problem with USBPD chargers which under certain conditions > can result in system overheating if the voltage provided by the USBPD > port is too high. While the preferred means to control this would be > through devicetree or

RE: [PATCH 1/2] power: supply: add input voltage limit property.

2018-11-21 Thread Adam Thomson
On 21 November 2018 15:35, Enric Balletbo i Serra wrote: > We have a problem with USBPD chargers which under certain conditions > can result in system overheating if the voltage provided by the USBPD > port is too high. While the preferred means to control this would be > through devicetree or

[PATCH] ASoC: da7219: Add delays to capture path to remove DC offset noise

2018-08-09 Thread Adam Thomson
the problem by adding delays post Mic PGA and post Mixin PGA. The post Mic PGA delay is determined based on Mic Bias voltage, and is only applied the first time after a headset jack is inserted. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7219-aad.c | 5 + sound/soc/codecs/da7219.c

[PATCH] ASoC: da7219: Add delays to capture path to remove DC offset noise

2018-08-09 Thread Adam Thomson
the problem by adding delays post Mic PGA and post Mixin PGA. The post Mic PGA delay is determined based on Mic Bias voltage, and is only applied the first time after a headset jack is inserted. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7219-aad.c | 5 + sound/soc/codecs/da7219.c

RE: [PATCH v2] ASoC: da7219: Allow pdata to specify a VDDIO

2018-07-23 Thread Adam Thomson
On 23 July 2018 00:28, Daniel Kurtz wrote: > Some systems do not have software controllable regulators driving the > DA7219's supplies, nor can they use device tree to create "always-on fixed > regulators" to easily pretend like they do. > > On these systems the call to devm_regulator_bulk_get()

RE: [PATCH v2] ASoC: da7219: Allow pdata to specify a VDDIO

2018-07-23 Thread Adam Thomson
On 23 July 2018 00:28, Daniel Kurtz wrote: > Some systems do not have software controllable regulators driving the > DA7219's supplies, nor can they use device tree to create "always-on fixed > regulators" to easily pretend like they do. > > On these systems the call to devm_regulator_bulk_get()

[PATCH 2/2] typec: tcpm: Provide fwnode pointer as part of psy_cfg

2018-05-22 Thread Adam Thomson
platforms when the relevant support is added to the power_supply core. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> Suggested-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/typec/tcpm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drive

[PATCH 2/2] typec: tcpm: Provide fwnode pointer as part of psy_cfg

2018-05-22 Thread Adam Thomson
platforms when the relevant support is added to the power_supply core. Signed-off-by: Adam Thomson Suggested-by: Heikki Krogerus --- drivers/usb/typec/tcpm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c index 72996cc..0ccd2ce 100644

[PATCH 1/2] power: supply: Add fwnode pointer to power_supply_config struct

2018-05-22 Thread Adam Thomson
then it will automatically resolve down to of_node on platforms which support it, otherwise it will be NULL. In the future, when ACPI support is added, this can be modified to accommodate ACPI without the need to change calling code which already provides the fwnode handle in this manner. Signed-off-by: Adam

[PATCH 1/2] power: supply: Add fwnode pointer to power_supply_config struct

2018-05-22 Thread Adam Thomson
then it will automatically resolve down to of_node on platforms which support it, otherwise it will be NULL. In the future, when ACPI support is added, this can be modified to accommodate ACPI without the need to change calling code which already provides the fwnode handle in this manner. Signed-off-by: Adam

[PATCH 0/2] typec: tcpm: Populate fwnode for use in power_supply core

2018-05-22 Thread Adam Thomson
. For now the main FW support in the psy core is still just DT based but in the future ACPI will likely be added and can use this field. Adam Thomson (2): power: supply: Add fwnode pointer to power_supply_config struct typec: tcpm: Provide fwnode pointer as part of psy_cfg drivers/power/supply

[PATCH 0/2] typec: tcpm: Populate fwnode for use in power_supply core

2018-05-22 Thread Adam Thomson
. For now the main FW support in the psy core is still just DT based but in the future ACPI will likely be added and can use this field. Adam Thomson (2): power: supply: Add fwnode pointer to power_supply_config struct typec: tcpm: Provide fwnode pointer as part of psy_cfg drivers/power/supply

RE: [PATCH] typec: tcpm: Provide of_node pointer as part of psy_cfg

2018-05-21 Thread Adam Thomson
On 21 May 2018 15:56, Heikki Krogerus wrote: > On Mon, May 21, 2018 at 01:58:16PM +0000, Adam Thomson wrote: > > Hi Heikki, > > > > On 21 May 2018 14:20, Heikki Krogerus wrote: > > > > > On Wed, May 16, 2018 at 05:00:46PM +0100, Adam Thomson wrote: > > &g

RE: [PATCH] typec: tcpm: Provide of_node pointer as part of psy_cfg

2018-05-21 Thread Adam Thomson
On 21 May 2018 15:56, Heikki Krogerus wrote: > On Mon, May 21, 2018 at 01:58:16PM +0000, Adam Thomson wrote: > > Hi Heikki, > > > > On 21 May 2018 14:20, Heikki Krogerus wrote: > > > > > On Wed, May 16, 2018 at 05:00:46PM +0100, Adam Thomson wrote: > > &g

RE: [PATCH] typec: tcpm: Provide of_node pointer as part of psy_cfg

2018-05-21 Thread Adam Thomson
Hi Heikki, On 21 May 2018 14:20, Heikki Krogerus wrote: > On Wed, May 16, 2018 at 05:00:46PM +0100, Adam Thomson wrote: > > For supply registration, provide of_node pointer of the port device, > > via the power_supply_config structure, to allow other psy drivers > > to add u

RE: [PATCH] typec: tcpm: Provide of_node pointer as part of psy_cfg

2018-05-21 Thread Adam Thomson
Hi Heikki, On 21 May 2018 14:20, Heikki Krogerus wrote: > On Wed, May 16, 2018 at 05:00:46PM +0100, Adam Thomson wrote: > > For supply registration, provide of_node pointer of the port device, > > via the power_supply_config structure, to allow other psy drivers > > to add u

[PATCH] typec: tcpm: Provide of_node pointer as part of psy_cfg

2018-05-16 Thread Adam Thomson
For supply registration, provide of_node pointer of the port device, via the power_supply_config structure, to allow other psy drivers to add us as a supplier using the 'power-supplies' DT property. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> --- drivers/usb/typec/

[PATCH] typec: tcpm: Provide of_node pointer as part of psy_cfg

2018-05-16 Thread Adam Thomson
For supply registration, provide of_node pointer of the port device, via the power_supply_config structure, to allow other psy drivers to add us as a supplier using the 'power-supplies' DT property. Signed-off-by: Adam Thomson --- drivers/usb/typec/tcpm.c | 1 + 1 file changed, 1 insertion

RE: [PATCH v3] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-16 Thread Adam Thomson
On 07 May 2018 05:50, Agrawal, Akshu wrote: Apologies for the delay in response. Please see comments below. > On 5/4/2018 2:45 PM, Adam Thomson wrote: > > On 03 May 2018 08:59, Akshu Agrawal wrote: > > > >> Non-dts based systems can use ACPI DSDT to pass on

RE: [PATCH v3] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-16 Thread Adam Thomson
On 07 May 2018 05:50, Agrawal, Akshu wrote: Apologies for the delay in response. Please see comments below. > On 5/4/2018 2:45 PM, Adam Thomson wrote: > > On 03 May 2018 08:59, Akshu Agrawal wrote: > > > >> Non-dts based systems can use ACPI DSDT to pass on

RE: [PATCH v3] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-04 Thread Adam Thomson
On 03 May 2018 08:59, Akshu Agrawal wrote: > Non-dts based systems can use ACPI DSDT to pass on the mclk > to da7219. > This enables da7219 mclk to be linked to system clock. > Enable/Disable of the mclk is already handled in the codec so > platform drivers don't have to explicitly do handling of

RE: [PATCH v3] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-04 Thread Adam Thomson
On 03 May 2018 08:59, Akshu Agrawal wrote: > Non-dts based systems can use ACPI DSDT to pass on the mclk > to da7219. > This enables da7219 mclk to be linked to system clock. > Enable/Disable of the mclk is already handled in the codec so > platform drivers don't have to explicitly do handling of

RE: [alsa-devel] [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-03 Thread Adam Thomson
On 03 May 2018 02:39, Mark Brown wrote: > On Wed, May 02, 2018 at 10:13:55AM +0000, Adam Thomson wrote: > > On 01 May 2018 21:50, Mark Brown wrote: > > > > There's a lot of things that ACPI *should* do but doesn't - it's a bit > > > of a shambles how ACPI st

RE: [alsa-devel] [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-03 Thread Adam Thomson
On 03 May 2018 02:39, Mark Brown wrote: > On Wed, May 02, 2018 at 10:13:55AM +0000, Adam Thomson wrote: > > On 01 May 2018 21:50, Mark Brown wrote: > > > > There's a lot of things that ACPI *should* do but doesn't - it's a bit > > > of a shambles how ACPI st

RE: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-02 Thread Adam Thomson
On 01 May 2018 21:50, Mark Brown wrote: > On Mon, Apr 30, 2018 at 07:05:19PM +0000, Adam Thomson wrote: > > > There is already a means via DT to specify the MCLK for a device using the > > generic clock DT bindings, and this driver already uses that. Should ACPI > >

RE: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-02 Thread Adam Thomson
On 01 May 2018 21:50, Mark Brown wrote: > On Mon, Apr 30, 2018 at 07:05:19PM +0000, Adam Thomson wrote: > > > There is already a means via DT to specify the MCLK for a device using the > > generic clock DT bindings, and this driver already uses that. Should ACPI > >

RE: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-04-30 Thread Adam Thomson
On 30 April 2018 10:23, Akshu Agrawal wrote: > Non-dts based systems can use ACPI DSDT to pass on the mclk > to da7219. > This enables da7219 mclk to be linked to system clock. > Enable/Disable of the mclk is already handled in the codec so > platform drivers don't have to explicitly do handling

RE: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-04-30 Thread Adam Thomson
On 30 April 2018 10:23, Akshu Agrawal wrote: > Non-dts based systems can use ACPI DSDT to pass on the mclk > to da7219. > This enables da7219 mclk to be linked to system clock. > Enable/Disable of the mclk is already handled in the codec so > platform drivers don't have to explicitly do handling

RE: [PATCH] typec: tcpm: Fix incorrect 'and' operator

2018-04-30 Thread Adam Thomson
typec: tcpm: Add support for sink PPS related > messages") > Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> > --- Good spot. :( Acked-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> > drivers/usb/typec/tcpm.c | 2 +- > 1 file changed, 1 inserti

RE: [PATCH] typec: tcpm: Fix incorrect 'and' operator

2018-04-30 Thread Adam Thomson
typec: tcpm: Add support for sink PPS related > messages") > Signed-off-by: Gustavo A. R. Silva > --- Good spot. :( Acked-by: Adam Thomson > drivers/usb/typec/tcpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm.c

RE: [PATCH v8 0/6] typec: tcpm: Add sink side support for PPS

2018-04-25 Thread Adam Thomson
On 25 April 2018 13:31, Greg Kroah-Hartman wrote: > On Wed, Apr 25, 2018 at 01:26:33AM +0200, Sebastian Reichel wrote: > > Hi Greg, > > > > On Tue, Apr 24, 2018 at 03:57:49PM +0200, Greg Kroah-Hartman wrote: > > > On Mon, Apr 23, 2018 at 03:10:55PM +0100, Adam Tho

RE: [PATCH v8 0/6] typec: tcpm: Add sink side support for PPS

2018-04-25 Thread Adam Thomson
On 25 April 2018 13:31, Greg Kroah-Hartman wrote: > On Wed, Apr 25, 2018 at 01:26:33AM +0200, Sebastian Reichel wrote: > > Hi Greg, > > > > On Tue, Apr 24, 2018 at 03:57:49PM +0200, Greg Kroah-Hartman wrote: > > > On Mon, Apr 23, 2018 at 03:10:55PM +0100, Adam Tho

[PATCH v8 1/6] typec: tcpm: Add core support for sink side PPS

2018-04-23 Thread Adam Thomson
This commit adds code to handle requesting of PPS APDOs. Switching between standard PDOs and APDOs, and re-requesting an APDO to modify operating voltage/current will be triggered by an external call into TCPM. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> Acked-by:

[PATCH v8 1/6] typec: tcpm: Add core support for sink side PPS

2018-04-23 Thread Adam Thomson
This commit adds code to handle requesting of PPS APDOs. Switching between standard PDOs and APDOs, and re-requesting an APDO to modify operating voltage/current will be triggered by an external call into TCPM. Signed-off-by: Adam Thomson Acked-by: Heikki Krogerus Reviewed-by: Guenter Roeck

[PATCH v8 3/6] power: supply: Add error checking of psy desc during registration

2018-04-23 Thread Adam Thomson
the registration code to add some basic checks on the desc pointer validity, name, and presence of properties. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> --- drivers/power/supply/power_supply_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/power/

[PATCH v8 3/6] power: supply: Add error checking of psy desc during registration

2018-04-23 Thread Adam Thomson
the registration code to add some basic checks on the desc pointer validity, name, and presence of properties. Signed-off-by: Adam Thomson --- drivers/power/supply/power_supply_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power

[PATCH v8 0/6] typec: tcpm: Add sink side support for PPS

2018-04-23 Thread Adam Thomson
t multiple connected types (e.g. USB), as discussed with Heikki. Changes in v2: - Use USB_PD and usb_pd prefixes for macros and inline functions in headers. - Negotiate spec revision of PD headers during initial contract agreement. - New headers now use SPDX tags for referencing correct lice

[PATCH v8 0/6] typec: tcpm: Add sink side support for PPS

2018-04-23 Thread Adam Thomson
t multiple connected types (e.g. USB), as discussed with Heikki. Changes in v2: - Use USB_PD and usb_pd prefixes for macros and inline functions in headers. - Negotiate spec revision of PD headers during initial contract agreement. - New headers now use SPDX tags for referencing correct lice

[PATCH v8 2/6] Documentation: power: Initial effort to document power_supply ABI

2018-04-23 Thread Adam Thomson
This commit adds generic ABI information regarding power_supply properties. This is an initial attempt to try and align the usage of these properties between drivers. As part of this commit, common Battery and USB related properties have been listed. Signed-off-by: Adam Thomson

[PATCH v8 2/6] Documentation: power: Initial effort to document power_supply ABI

2018-04-23 Thread Adam Thomson
This commit adds generic ABI information regarding power_supply properties. This is an initial attempt to try and align the usage of these properties between drivers. As part of this commit, common Battery and USB related properties have been listed. Signed-off-by: Adam Thomson

[PATCH v8 5/6] typec: tcpm: Represent source supply through power_supply

2018-04-23 Thread Adam Thomson
' Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> Reviewed-by: Guenter Roeck <li...@roeck-us.net> --- drivers/usb/typec/Kconfig | 1 + drivers/usb/typec/fusb302/Kconfig | 2 +- drivers/usb/typec/fusb302/fusb302.c | 63 + drivers/usb/

[PATCH v8 5/6] typec: tcpm: Represent source supply through power_supply

2018-04-23 Thread Adam Thomson
' Signed-off-by: Adam Thomson Reviewed-by: Guenter Roeck --- drivers/usb/typec/Kconfig | 1 + drivers/usb/typec/fusb302/Kconfig | 2 +- drivers/usb/typec/fusb302/fusb302.c | 63 + drivers/usb/typec/tcpm.c| 251 +++- 4 files

[PATCH v8 6/6] typec: tcpm: Add support for sink PPS related messages

2018-04-23 Thread Adam Thomson
. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> Acked-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Reviewed-by: Guenter Roeck <li...@roeck-us.net> --- drivers/usb/typec/tcpm.c | 143 --- 1 file changed, 134 insertio

[PATCH v8 6/6] typec: tcpm: Add support for sink PPS related messages

2018-04-23 Thread Adam Thomson
. Signed-off-by: Adam Thomson Acked-by: Heikki Krogerus Reviewed-by: Guenter Roeck --- drivers/usb/typec/tcpm.c | 143 --- 1 file changed, 134 insertions(+), 9 deletions(-) diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c index 7547097

[PATCH v8 4/6] power: supply: Add 'usb_type' property and supporting code

2018-04-23 Thread Adam Thomson
that exist for the 'type' enum at this time, and in addition has SDP and PPS types. The mirroring is intentional so as to not impact existing usage of the 'type' property. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> --- Documentation/ABI/testing/sysfs-class-powe

[PATCH v8 4/6] power: supply: Add 'usb_type' property and supporting code

2018-04-23 Thread Adam Thomson
that exist for the 'type' enum at this time, and in addition has SDP and PPS types. The mirroring is intentional so as to not impact existing usage of the 'type' property. Signed-off-by: Adam Thomson --- Documentation/ABI/testing/sysfs-class-power | 12 drivers/power/supply

RE: [PATCH v7 1/6] typec: tcpm: Add core support for sink side PPS

2018-04-23 Thread Adam Thomson
On 23 April 2018 12:28, Greg Kroah-Hartman wrote: > On Mon, Apr 23, 2018 at 11:06:25AM +0000, Adam Thomson wrote: > > On 23 April 2018 09:25, Greg Kroah-Hartman wrote: > > > > > On Mon, Apr 23, 2018 at 07:49:38AM +, Adam Thomson wrote: > > > > On 22

RE: [PATCH v7 1/6] typec: tcpm: Add core support for sink side PPS

2018-04-23 Thread Adam Thomson
On 23 April 2018 12:28, Greg Kroah-Hartman wrote: > On Mon, Apr 23, 2018 at 11:06:25AM +0000, Adam Thomson wrote: > > On 23 April 2018 09:25, Greg Kroah-Hartman wrote: > > > > > On Mon, Apr 23, 2018 at 07:49:38AM +, Adam Thomson wrote: > > > > On 22

RE: [PATCH v7 1/6] typec: tcpm: Add core support for sink side PPS

2018-04-23 Thread Adam Thomson
On 23 April 2018 09:25, Greg Kroah-Hartman wrote: > On Mon, Apr 23, 2018 at 07:49:38AM +0000, Adam Thomson wrote: > > On 22 April 2018 21:58, Adam Thomson wrote: > > > > > On 22 April 2018 15:05, Greg Kroah-Hartman wrote: > > > > > > > On Fri, Mar 23,

RE: [PATCH v7 1/6] typec: tcpm: Add core support for sink side PPS

2018-04-23 Thread Adam Thomson
On 23 April 2018 09:25, Greg Kroah-Hartman wrote: > On Mon, Apr 23, 2018 at 07:49:38AM +0000, Adam Thomson wrote: > > On 22 April 2018 21:58, Adam Thomson wrote: > > > > > On 22 April 2018 15:05, Greg Kroah-Hartman wrote: > > > > > > > On Fri, Mar 23,

RE: [PATCH v7 1/6] typec: tcpm: Add core support for sink side PPS

2018-04-23 Thread Adam Thomson
On 22 April 2018 21:58, Adam Thomson wrote: > On 22 April 2018 15:05, Greg Kroah-Hartman wrote: > > > On Fri, Mar 23, 2018 at 10:12:20AM +, Adam Thomson wrote: > > > This commit adds code to handle requesting of PPS APDOs. Switching > > > between standard PDO

RE: [PATCH v7 1/6] typec: tcpm: Add core support for sink side PPS

2018-04-23 Thread Adam Thomson
On 22 April 2018 21:58, Adam Thomson wrote: > On 22 April 2018 15:05, Greg Kroah-Hartman wrote: > > > On Fri, Mar 23, 2018 at 10:12:20AM +, Adam Thomson wrote: > > > This commit adds code to handle requesting of PPS APDOs. Switching > > > between standard PDO

RE: [PATCH v7 1/6] typec: tcpm: Add core support for sink side PPS

2018-04-22 Thread Adam Thomson
On 22 April 2018 15:05, Greg Kroah-Hartman wrote: > On Fri, Mar 23, 2018 at 10:12:20AM +0000, Adam Thomson wrote: > > This commit adds code to handle requesting of PPS APDOs. Switching > > between standard PDOs and APDOs, and re-requesting an APDO to > > modify oper

RE: [PATCH v7 1/6] typec: tcpm: Add core support for sink side PPS

2018-04-22 Thread Adam Thomson
On 22 April 2018 15:05, Greg Kroah-Hartman wrote: > On Fri, Mar 23, 2018 at 10:12:20AM +0000, Adam Thomson wrote: > > This commit adds code to handle requesting of PPS APDOs. Switching > > between standard PDOs and APDOs, and re-requesting an APDO to > > modify oper

RE: [PATCH v7 2/6] Documentation: power: Initial effort to document power_supply ABI

2018-03-26 Thread Adam Thomson
On 26 March 2018 10:57, Greg Kroah-Hartman wrote: > On Fri, Mar 23, 2018 at 10:12:21AM +0000, Adam Thomson wrote: > > This commit adds generic ABI information regarding power_supply > > properties. This is an initial attempt to try and align the usage > > of these prope

RE: [PATCH v7 2/6] Documentation: power: Initial effort to document power_supply ABI

2018-03-26 Thread Adam Thomson
On 26 March 2018 10:57, Greg Kroah-Hartman wrote: > On Fri, Mar 23, 2018 at 10:12:21AM +0000, Adam Thomson wrote: > > This commit adds generic ABI information regarding power_supply > > properties. This is an initial attempt to try and align the usage > > of these prope

[PATCH v7 0/6] typec: tcpm: Add sink side support for PPS

2018-03-23 Thread Adam Thomson
tiate spec revision of PD headers during initial contract agreement. - New headers now use SPDX tags for referencing correct license. NOTE: Code changes based on usb-next (027bd6cafd9a1e3a109b5e5682c85ac84e804a8d) Adam Thomson (6): typec: tcpm: Add core support for sink side PPS Documentat

[PATCH v7 0/6] typec: tcpm: Add sink side support for PPS

2018-03-23 Thread Adam Thomson
tiate spec revision of PD headers during initial contract agreement. - New headers now use SPDX tags for referencing correct license. NOTE: Code changes based on usb-next (027bd6cafd9a1e3a109b5e5682c85ac84e804a8d) Adam Thomson (6): typec: tcpm: Add core support for sink side PPS Documentat

[PATCH v7 2/6] Documentation: power: Initial effort to document power_supply ABI

2018-03-23 Thread Adam Thomson
This commit adds generic ABI information regarding power_supply properties. This is an initial attempt to try and align the usage of these properties between drivers. As part of this commit, common Battery and USB related properties have been listed. Signed-off-by: Adam Thomson

[PATCH v7 2/6] Documentation: power: Initial effort to document power_supply ABI

2018-03-23 Thread Adam Thomson
This commit adds generic ABI information regarding power_supply properties. This is an initial attempt to try and align the usage of these properties between drivers. As part of this commit, common Battery and USB related properties have been listed. Signed-off-by: Adam Thomson

[PATCH v7 6/6] typec: tcpm: Add support for sink PPS related messages

2018-03-23 Thread Adam Thomson
. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> Acked-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/typec/tcpm.c | 143 --- 1 file changed, 134 insertions(+), 9 deletions(-) diff --git a/drivers/usb/ty

[PATCH v7 6/6] typec: tcpm: Add support for sink PPS related messages

2018-03-23 Thread Adam Thomson
. Signed-off-by: Adam Thomson Acked-by: Heikki Krogerus --- drivers/usb/typec/tcpm.c | 143 --- 1 file changed, 134 insertions(+), 9 deletions(-) diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c index 57a7d1a..7025a16 100644 --- a/drivers/usb

[PATCH v7 5/6] typec: tcpm: Represent source supply through power_supply

2018-03-23 Thread Adam Thomson
' Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> --- drivers/usb/typec/Kconfig | 1 + drivers/usb/typec/fusb302/Kconfig | 2 +- drivers/usb/typec/fusb302/fusb302.c | 63 +- drivers/usb/typec/tcpm.c| 245 +

[PATCH v7 5/6] typec: tcpm: Represent source supply through power_supply

2018-03-23 Thread Adam Thomson
' Signed-off-by: Adam Thomson --- drivers/usb/typec/Kconfig | 1 + drivers/usb/typec/fusb302/Kconfig | 2 +- drivers/usb/typec/fusb302/fusb302.c | 63 +- drivers/usb/typec/tcpm.c| 245 +++- 4 files changed, 248 insertions(+), 63

[PATCH v7 1/6] typec: tcpm: Add core support for sink side PPS

2018-03-23 Thread Adam Thomson
This commit adds code to handle requesting of PPS APDOs. Switching between standard PDOs and APDOs, and re-requesting an APDO to modify operating voltage/current will be triggered by an external call into TCPM. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> Acked-by:

[PATCH v7 1/6] typec: tcpm: Add core support for sink side PPS

2018-03-23 Thread Adam Thomson
This commit adds code to handle requesting of PPS APDOs. Switching between standard PDOs and APDOs, and re-requesting an APDO to modify operating voltage/current will be triggered by an external call into TCPM. Signed-off-by: Adam Thomson Acked-by: Heikki Krogerus --- drivers/usb/typec/tcpm.c

[PATCH v7 4/6] power: supply: Add 'usb_type' property and supporting code

2018-03-23 Thread Adam Thomson
that exist for the 'type' enum at this time, and in addition has SDP and PPS types. The mirroring is intentional so as to not impact existing usage of the 'type' property. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> --- Documentation/ABI/testing/sysfs-class-powe

[PATCH v7 4/6] power: supply: Add 'usb_type' property and supporting code

2018-03-23 Thread Adam Thomson
that exist for the 'type' enum at this time, and in addition has SDP and PPS types. The mirroring is intentional so as to not impact existing usage of the 'type' property. Signed-off-by: Adam Thomson --- Documentation/ABI/testing/sysfs-class-power | 12 drivers/power/supply

[PATCH v7 3/6] power: supply: Add error checking of psy desc during registration

2018-03-23 Thread Adam Thomson
the registration code to add some basic checks on the desc pointer validity, name, and presence of properties. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> --- drivers/power/supply/power_supply_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/power/

[PATCH v7 3/6] power: supply: Add error checking of psy desc during registration

2018-03-23 Thread Adam Thomson
the registration code to add some basic checks on the desc pointer validity, name, and presence of properties. Signed-off-by: Adam Thomson --- drivers/power/supply/power_supply_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power

[PATCH v6 1/6] typec: tcpm: Add core support for sink side PPS

2018-03-22 Thread Adam Thomson
This commit adds code to handle requesting of PPS APDOs. Switching between standard PDOs and APDOs, and re-requesting an APDO to modify operating voltage/current will be triggered by an external call into TCPM. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> Acked-by:

[PATCH v6 2/6] Documentation: power: Initial effort to document power_supply ABI

2018-03-22 Thread Adam Thomson
This commit adds generic ABI information regarding power_supply properties. This is an initial attempt to try and align the usage of these properties between drivers. As part of this commit, common Battery and USB related properties have been listed. Signed-off-by: Adam Thomson

[PATCH v6 1/6] typec: tcpm: Add core support for sink side PPS

2018-03-22 Thread Adam Thomson
This commit adds code to handle requesting of PPS APDOs. Switching between standard PDOs and APDOs, and re-requesting an APDO to modify operating voltage/current will be triggered by an external call into TCPM. Signed-off-by: Adam Thomson Acked-by: Heikki Krogerus --- drivers/usb/typec/tcpm.c

[PATCH v6 2/6] Documentation: power: Initial effort to document power_supply ABI

2018-03-22 Thread Adam Thomson
This commit adds generic ABI information regarding power_supply properties. This is an initial attempt to try and align the usage of these properties between drivers. As part of this commit, common Battery and USB related properties have been listed. Signed-off-by: Adam Thomson

[PATCH v6 3/6] power: supply: Add error checking of psy desc during registration

2018-03-22 Thread Adam Thomson
the registration code to add some basic checks on the desc pointer validity, name, and presence of properties. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> --- drivers/power/supply/power_supply_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/power/

[PATCH v6 3/6] power: supply: Add error checking of psy desc during registration

2018-03-22 Thread Adam Thomson
the registration code to add some basic checks on the desc pointer validity, name, and presence of properties. Signed-off-by: Adam Thomson --- drivers/power/supply/power_supply_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power

[PATCH v6 5/6] typec: tcpm: Represent source supply through power_supply

2018-03-22 Thread Adam Thomson
' Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> --- drivers/usb/typec/Kconfig | 1 + drivers/usb/typec/fusb302/Kconfig | 2 +- drivers/usb/typec/fusb302/fusb302.c | 63 +- drivers/usb/typec/tcpm.c| 242 +

[PATCH v6 5/6] typec: tcpm: Represent source supply through power_supply

2018-03-22 Thread Adam Thomson
' Signed-off-by: Adam Thomson --- drivers/usb/typec/Kconfig | 1 + drivers/usb/typec/fusb302/Kconfig | 2 +- drivers/usb/typec/fusb302/fusb302.c | 63 +- drivers/usb/typec/tcpm.c| 242 +++- 4 files changed, 245 insertions(+), 63

[PATCH v6 0/6] typec: tcpm: Add sink side support for PPS

2018-03-22 Thread Adam Thomson
nt. - New headers now use SPDX tags for referencing correct license. NOTE: Code changes based on usb-next (027bd6cafd9a1e3a109b5e5682c85ac84e804a8d) Adam Thomson (6): typec: tcpm: Add core support for sink side PPS Documentation: power: Initial effort to document power_supply ABI power: s

[PATCH v6 0/6] typec: tcpm: Add sink side support for PPS

2018-03-22 Thread Adam Thomson
nt. - New headers now use SPDX tags for referencing correct license. NOTE: Code changes based on usb-next (027bd6cafd9a1e3a109b5e5682c85ac84e804a8d) Adam Thomson (6): typec: tcpm: Add core support for sink side PPS Documentation: power: Initial effort to document power_supply ABI power: s

[PATCH v6 6/6] typec: tcpm: Add support for sink PPS related messages

2018-03-22 Thread Adam Thomson
. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> Acked-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/typec/tcpm.c | 143 --- 1 file changed, 134 insertions(+), 9 deletions(-) diff --git a/drivers/usb/ty

[PATCH v6 4/6] power: supply: Add 'usb_type' property and supporting code

2018-03-22 Thread Adam Thomson
that exist for the 'type' enum at this time, and in addition has SDP and PPS types. The mirroring is intentional so as to not impact existing usage of the 'type' property. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> --- Documentation/ABI/testing/sysfs-class-powe

[PATCH v6 6/6] typec: tcpm: Add support for sink PPS related messages

2018-03-22 Thread Adam Thomson
. Signed-off-by: Adam Thomson Acked-by: Heikki Krogerus --- drivers/usb/typec/tcpm.c | 143 --- 1 file changed, 134 insertions(+), 9 deletions(-) diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c index c859cba..fffe97d 100644 --- a/drivers/usb

[PATCH v6 4/6] power: supply: Add 'usb_type' property and supporting code

2018-03-22 Thread Adam Thomson
that exist for the 'type' enum at this time, and in addition has SDP and PPS types. The mirroring is intentional so as to not impact existing usage of the 'type' property. Signed-off-by: Adam Thomson --- Documentation/ABI/testing/sysfs-class-power | 12 drivers/power/supply

RE: [PATCH v5 4/5] typec: tcpm: Represent source supply through power_supply

2018-03-22 Thread Adam Thomson
On 22 March 2018 04:09, Guenter Roeck wrote: > > +static int tcpm_psy_set_prop(struct power_supply *psy, > > +enum power_supply_property psp, > > +const union power_supply_propval *val) > > +{ > > + struct tcpm_port *port =

RE: [PATCH v5 4/5] typec: tcpm: Represent source supply through power_supply

2018-03-22 Thread Adam Thomson
On 22 March 2018 04:09, Guenter Roeck wrote: > > +static int tcpm_psy_set_prop(struct power_supply *psy, > > +enum power_supply_property psp, > > +const union power_supply_propval *val) > > +{ > > + struct tcpm_port *port =

RE: [PATCH v5 3/5] power: supply: Add 'usb_type' property and supporting code

2018-03-22 Thread Adam Thomson
On 22 March 2018 04:08, Guenter Roeck wrote: > > +static ssize_t power_supply_show_usb_type(struct device *dev, > > + enum power_supply_usb_type > *usb_types, > > + ssize_t num_usb_types, > > +

RE: [PATCH v5 3/5] power: supply: Add 'usb_type' property and supporting code

2018-03-22 Thread Adam Thomson
On 22 March 2018 04:08, Guenter Roeck wrote: > > +static ssize_t power_supply_show_usb_type(struct device *dev, > > + enum power_supply_usb_type > *usb_types, > > + ssize_t num_usb_types, > > +

RE: [PATCH v5 1/5] typec: tcpm: Add core support for sink side PPS

2018-03-22 Thread Adam Thomson
On 22 March 2018 04:03, Guenter Roeck wrote: > > static enum pdo_err tcpm_caps_err(struct tcpm_port *port, const u32 *pdo, > > @@ -1308,6 +1347,26 @@ static enum pdo_err tcpm_caps_err(struct tcpm_port > *port, const u32 *pdo, > > pdo_min_voltage(pdo[i -

RE: [PATCH v5 1/5] typec: tcpm: Add core support for sink side PPS

2018-03-22 Thread Adam Thomson
On 22 March 2018 04:03, Guenter Roeck wrote: > > static enum pdo_err tcpm_caps_err(struct tcpm_port *port, const u32 *pdo, > > @@ -1308,6 +1347,26 @@ static enum pdo_err tcpm_caps_err(struct tcpm_port > *port, const u32 *pdo, > > pdo_min_voltage(pdo[i -

RE: [PATCH v5 5/5] typec: tcpm: Add support for sink PPS related messages

2018-03-22 Thread Adam Thomson
On 22 March 2018 03:53, Guenter Roeck wrote: > > +static void tcpm_pd_ext_msg_request(struct tcpm_port *port, > > + const struct pd_message *msg) > > +{ > > + enum pd_ext_msg_type type = pd_header_type_le(msg->header); > > + unsigned int data_size =

RE: [PATCH v5 5/5] typec: tcpm: Add support for sink PPS related messages

2018-03-22 Thread Adam Thomson
On 22 March 2018 03:53, Guenter Roeck wrote: > > +static void tcpm_pd_ext_msg_request(struct tcpm_port *port, > > + const struct pd_message *msg) > > +{ > > + enum pd_ext_msg_type type = pd_header_type_le(msg->header); > > + unsigned int data_size =

[PATCH v5 3/5] power: supply: Add 'usb_type' property and supporting code

2018-03-20 Thread Adam Thomson
that exist for the 'type' enum at this time, and in addition has SDP and PPS types. The mirroring is intentional so as to not impact existing usage of the 'type' property. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> Acked-by: Heikki Krogerus <heikki.kroge...@linux.

[PATCH v5 3/5] power: supply: Add 'usb_type' property and supporting code

2018-03-20 Thread Adam Thomson
that exist for the 'type' enum at this time, and in addition has SDP and PPS types. The mirroring is intentional so as to not impact existing usage of the 'type' property. Signed-off-by: Adam Thomson Acked-by: Heikki Krogerus Reviewed-by: Sebastian Reichel --- Documentation/ABI/testing/sysfs-class

[PATCH v5 1/5] typec: tcpm: Add core support for sink side PPS

2018-03-20 Thread Adam Thomson
This commit adds code to handle requesting of PPS APDOs. Switching between standard PDOs and APDOs, and re-requesting an APDO to modify operating voltage/current will be triggered by an external call into TCPM. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> Acked-by:

[PATCH v5 0/5] typec: tcpm: Add sink side support for PPS

2018-03-20 Thread Adam Thomson
and inline functions in headers. - Negotiate spec revision of PD headers during initial contract agreement. - New headers now use SPDX tags for referencing correct license. NOTE: Code changes based on usb-next (027bd6cafd9a1e3a109b5e5682c85ac84e804a8d) Adam Thomson (5): typec: tcpm: Add co

[PATCH v5 4/5] typec: tcpm: Represent source supply through power_supply

2018-03-20 Thread Adam Thomson
' Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> --- drivers/usb/typec/Kconfig | 1 + drivers/usb/typec/fusb302/Kconfig | 2 +- drivers/usb/typec/fusb302/fusb302.c | 63 +- drivers/usb/typec/tcpm.c| 242 +

<    1   2   3   4   5   6   7   8   9   10   >