[PATCH] mfd: rn5t618: fix IRQ trigger by changing it to level mode

2021-04-05 Thread Andreas Kemnade
: Add IRQ support") Signed-off-by: Andreas Kemnade --- drivers/mfd/rn5t618.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c index ecddd7b6500e..a852eef1f4d2 100644 --- a/drivers/mfd/rn5t618.c +++ b/drivers/mfd/rn5t618.c @@ -10

[PATCH v4] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-15 Thread Andreas Kemnade
be successfully configured despite of that error. Signed-off-by: Andreas Kemnade Reviewed-by: Jonathan Neuschäfer --- Changes in v4: - rename subdevices back to v2 (suggested by Jonathan) - initialize subdevs in switch Changes in v3: - remove have_rtc variable - rename subdevices again Changes in v2

Re: [PATCH v3] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-15 Thread Andreas Kemnade
On Mon, 15 Mar 2021 08:12:31 + Lee Jones wrote: [...] > > static int ntxec_probe(struct i2c_client *client) > > { > > struct ntxec *ec; > > unsigned int version; > > int res; > > + const struct mfd_cell *subdevs = ntxec_subdev; > > + size_t n_subdevs =

[PATCH] mfd: rn5t618: Do not cache various USB related registers

2021-03-14 Thread Andreas Kemnade
These register get reset to their OTP defaults after USB plugging. And while at it, also add a missing register for detecting the charger type. Signed-off-by: Andreas Kemnade --- drivers/mfd/rn5t618.c | 3 +++ include/linux/mfd/rn5t618.h | 1 + 2 files changed, 4 insertions(+) diff --git

Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-13 Thread Andreas Kemnade
On Sat, 13 Mar 2021 12:17:34 +0100 Jonathan Neuschäfer wrote: > On Wed, Mar 10, 2021 at 09:55:45AM +, Lee Jones wrote: > > On Mon, 08 Mar 2021, Andreas Kemnade wrote: > [...] > > > -static const struct mfd_cell ntxec_subdevices[] = { > > > +static cons

[PATCH v3] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-13 Thread Andreas Kemnade
be successfully configured despite of that error. Signed-off-by: Andreas Kemnade Reviewed-by: Jonathan Neuschäfer --- Changes in v3: - remove have_rtc variable - rename subdevices again Changes in v2: - more comments about stacking regmap construction - fix accidential line removal - better naming

[PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-08 Thread Andreas Kemnade
be successfully configured despite of that error. Signed-off-by: Andreas Kemnade --- Changes in v2: - more comments about stacking regmap construction - fix accidential line removal - better naming for subdevices drivers/mfd/ntxec.c | 61 +-- include/linux/mfd

Re: [PATCH -next] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-06 Thread Andreas Kemnade
On Sat, 6 Mar 2021 21:19:38 +0100 Jonathan Neuschäfer wrote: [...] > > > > + case NTXEC_VERSION_TOLINO_SHINE2: > > > > + has_rtc = false; > > > > + ec->regmap = devm_regmap_init(ec->dev, NULL, > > > > + ec->regmap, > >

Re: [PATCH -next] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-06 Thread Andreas Kemnade
On Sat, 6 Mar 2021 20:14:46 +0100 Jonathan Neuschäfer wrote: > Hi, > > (Cc'ing Mark Brown because of the regmap related questions) > > On Sat, Mar 06, 2021 at 07:13:14PM +0100, Andreas Kemnade wrote: > > Add the version of the EC in the Tolino Shine 2 HD > > to the s

[PATCH -next] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-06 Thread Andreas Kemnade
be successfully configured despite of that error. Signed-off-by: Andreas Kemnade --- drivers/mfd/ntxec.c | 57 --- include/linux/mfd/ntxec.h | 1 + 2 files changed, 55 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/ntxec.c b/drivers/mfd/ntxec.c index

Re: [PATCH 1/3] power: supply: bq27xxx: fix sign of current_now for newer ICs

2021-02-23 Thread Andreas Kemnade
The GTA04/Openmoko device that was used for testing uses a BQ27000 or > BQ27010 IC, so I assume only the BQ27XXX_O_ZERO code path was incorrect. > Revert the behaviour for newer ICs. > > Fixes: cd060b4d0868 "power: supply: bq27xxx: fix polarity of current_now" > Signed-off-

Re: [PATCH v9 0/7] Netronix embedded controller driver for Kobo and Tolino ebook readers

2021-02-08 Thread Andreas Kemnade
On Sun, 24 Jan 2021 22:41:20 +0100 Jonathan Neuschäfer wrote: > This patchset adds basic support for the embedded controller found on > older ebook reader boards designed by/with the ODM Netronix Inc.[1] and > sold by Kobo or Tolino, for example the Kobo Aura and the Tolino Shine. > These

Re: [Letux-kernel] BOG: commit 89c7cb1608ac3 ("of/device: Update dma_range_map only when dev has valid dma-ranges") seems to break Pinephone display or LCDC

2021-02-06 Thread Andreas Kemnade
On Fri, 5 Feb 2021 16:10:18 +0100 Paul Kocialkowski wrote: > Hey, > > On Tue 02 Feb 21, 16:07, H. Nikolaus Schaller wrote: > > Hi Paul, > > > > > Am 02.02.2021 um 14:42 schrieb Paul Kocialkowski > > > : > > > > > > Hi Nikolaus, > > > > > > On Tue 02 Feb 21, 11:50, H. Nikolaus Schaller

[PATCH RESEND v2] dt-bindings: mfd: Convert rn5t618 to json-schema

2021-01-31 Thread Andreas Kemnade
Convert the RN5T618 binding to DT schema format. Also clearly state which regulators are available. Signed-off-by: Andreas Kemnade Reviewed-by: Rob Herring --- https://lore.kernel.org/lkml/cal_jsqjwt91+azwaweuvjobqgsyw6gbhqmohwu_t5qzabxx...@mail.gmail.com/ Changes in v2: - drop irq description

Re: [PATCH] dts: ARM: add kobo glo hd ebook reader

2021-01-26 Thread Andreas Kemnade
[resent with some more complete address list, get_maintainer.pl provides more] Hi, On Tue, 26 Jan 2021 18:31:31 +0100 Armin Preiml wrote: > This patch adds basic support for the kobo glo hd reader. It defines CPU, > memory, UART and storage.Also add pin control settings for i2c and sdhc. >

Re: [PATCH] dts: ARM: add kobo glo hd ebook reader

2021-01-26 Thread Andreas Kemnade
Hi, On Tue, 26 Jan 2021 18:31:31 +0100 Armin Preiml wrote: > This patch adds basic support for the kobo glo hd reader. It defines CPU, > memory, UART and storage.Also add pin control settings for i2c and sdhc. > > All values where extracted from the vendor kernel and u-boot sources. > >

[PATCH] ARM: dts: imx6sl-tolino-shine2hd: Add Netronix embedded controller

2021-01-25 Thread Andreas Kemnade
For now, the driver detects an incompatible version, but since that can be handled by auto-detection, add the controller to the devicetree now. Only PWM seems to be available, there is no RTC in that controller. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts | 7

[PATCH] regulator: core: avoid error messages for deferred probing

2021-01-25 Thread Andreas Kemnade
by DCDC1 [3.877211] vddsoc: bypassed regulator has no supply! [3.882538] vddsoc: failed to get the current voltage: -EPROBE_DEFER [3.888975] vddsoc: supplied by DCDC1 Handle such issues silently. Signed-off-by: Andreas Kemnade --- drivers/regulator/core.c | 8 +++- 1 file

Re: [PATCH v7 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2021-01-13 Thread Andreas Kemnade
On Tue, 12 Jan 2021 20:39:02 +0100 Andreas Kemnade wrote: [...] > > +static int ntxec_pwm_probe(struct platform_device *pdev) > > +{ > > + struct ntxec *ec = dev_get_drvdata(pdev->dev.parent); > > + struct ntxec_pwm *priv; > > + struct pwm_chip *chip; >

Re: [PATCH 3/4] ARM: dts: imx6sl-tolino-shine2hd: correct console uart pinmux

2021-01-13 Thread Andreas Kemnade
please ignore, that was accidentially sent. On Wed, 13 Jan 2021 00:15:47 +0100 Andreas Kemnade wrote: > Configuration was correct enough to work with the pre-configuration done by > uboot. While at it, also document the location. > > Signed-off-by: Andreas Kemnade > --- >

[PATCH 1/4] ARM: dts: imx6sl-tolino-shine2hd: correct console uart pinmux

2021-01-12 Thread Andreas Kemnade
Configuration was correct enough to work with the pre-configuration done by uboot. While at it, also document the location. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts

[PATCH 3/4] ARM: dts: imx6sl-tolino-shine3: correct console uart pinmux

2021-01-12 Thread Andreas Kemnade
Configuration was correct enough to work with the pre-configuration done by uboot. While at it, also document the location. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6sl

[PATCH 4/4] ARM: dts: imx: e60k02: add second uart

2021-01-12 Thread Andreas Kemnade
There is another uart next to the console uart used by vendor uboot and kernel, enable it and document its location. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/e60k02.dtsi | 6 ++ arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 13 - arch/arm/boot/dts

[PATCH 3/4] ARM: dts: imx6sl-tolino-shine2hd: correct console uart pinmux

2021-01-12 Thread Andreas Kemnade
Configuration was correct enough to work with the pre-configuration done by uboot. While at it, also document the location. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6sl

[PATCH 0/4] ARM: dts: imx: uart improvements for ebookreaders

2021-01-12 Thread Andreas Kemnade
- add second uart - correct pinmux for console uart (it was working before because of setup by uboot) - document locations on board Andreas Kemnade (4): ARM: dts: imx6sl-tolino-shine2hd: correct console uart pinmux ARM: dts: imx6sl-tolino-shine2hd: add second uart ARM: dts: imx6sl-tolino

[PATCH 2/4] ARM: dts: imx6sl-tolino-shine2hd: add second uart

2021-01-12 Thread Andreas Kemnade
There is another uart next to the console uart used by vendor uboot and kernel, enable it and document its location. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot

Re: [PATCH v7 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2021-01-12 Thread Andreas Kemnade
On Sat, 9 Jan 2021 19:02:17 +0100 Jonathan Neuschäfer wrote: > The Netronix EC provides a PWM output which is used for the backlight > on some ebook readers. This patches adds a driver for the PWM output. > > The .get_state callback is not implemented, because the PWM state can't > be read

Re: [PATCH v7 3/7] mfd: Add base driver for Netronix embedded controller

2021-01-12 Thread Andreas Kemnade
On Sat, 9 Jan 2021 19:02:16 +0100 Jonathan Neuschäfer wrote: > The Netronix embedded controller is a microcontroller found in some > e-book readers designed by the original design manufacturer Netronix, > Inc. It contains RTC, battery monitoring, system power management, and > PWM

Re: [PATCH] ARM: OMAP2+: omap_device: fix idling of devices during probe

2021-01-08 Thread Andreas Kemnade
Hi, On Fri, 8 Jan 2021 13:17:06 -0600 Adam Ford wrote: > On Mon, Dec 7, 2020 at 8:01 AM Tony Lindgren wrote: > > > > * Doug Anderson [201204 16:43]: > > > Hi, > > > > > > On Fri, Dec 4, 2020 at 8:14 AM Andreas Kemnade > > > wrote: &

Re: [PATCH] spi: dt-bindings: clarify CS behavior for spi-cs-high and gpio descriptors

2020-12-09 Thread Andreas Kemnade
On Wed, 9 Dec 2020 14:04:26 -0500 Sven Van Asbroeck wrote: > On Wed, Dec 9, 2020 at 1:16 PM H. Nikolaus Schaller > wrote: > > > > This is also what made me wonder if that is really intended because then > > the whole discussion about the cs-gpio-flags and inversion and the fixes > > would not

Re: [BUG] SPI broken for SPI based panel drivers

2020-12-09 Thread Andreas Kemnade
Hi, On Sat, 5 Dec 2020 08:04:25 +0100 "H. Nikolaus Schaller" wrote: > Hi Linus, > > > Am 05.12.2020 um 01:25 schrieb Linus Walleij : > > > > On Fri, Dec 4, 2020 at 5:52 PM H. Nikolaus Schaller > > wrote: > > > >> But what I don't know is if I can omit spi-cs-high and have to keep > >>

Re: [PATCH] ARM: OMAP2+: omap_device: fix idling of devices during probe

2020-12-04 Thread Andreas Kemnade
On Fri, 4 Dec 2020 07:44:33 -0800 Doug Anderson wrote: > Hi, > > On Fri, Dec 4, 2020 at 1:55 AM Andreas Kemnade wrote: > > > > On the GTA04A5 od->_driver_status was not set to BUS_NOTIFY_BIND_DRIVER > > during probe of the second mmc used for wifi. Therefore &

[PATCH] power: bq27xxx: fix polarity of current_now

2020-12-04 Thread Andreas Kemnade
current_now has to be negative during discharging and positive during charging, the behavior seen is the other way round. Tested on GTA04 with Openmoko battery Signed-off-by: Andreas Kemnade --- drivers/power/supply/bq27xxx_battery.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH] ARM: OMAP2+: omap_device: fix idling of devices during probe

2020-12-04 Thread Andreas Kemnade
t PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.4") Signed-off-by: Andreas Kemnade --- arch/arm/mach-omap2/omap_device.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c index f

[PATCH] ARM: imx_v6_v7_defconfig: enable power driver of RN5T618 PMIC family

2020-12-01 Thread Andreas Kemnade
There is a driver now for the power supply and fuel gauge functionality of that chip family, so enable them, since they are used by various i.MX6 boards, especially ebook-readers. Signed-off-by: Andreas Kemnade --- arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff

[PATCH] ARM: omap2plus_defconfig: enable SPI GPIO

2020-12-01 Thread Andreas Kemnade
GTA04 uses that for controlling the td028ttec1 panel. So for easier testing/bisecting it is useful to have it enabled in the defconfig. Signed-off-by: Andreas Kemnade --- arch/arm/configs/omap2plus_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs

Re: [Letux-kernel] [BUG] SPI broken for SPI based panel drivers

2020-12-01 Thread Andreas Kemnade
On Tue, 1 Dec 2020 11:10:49 -0500 Sven Van Asbroeck wrote: > Nikolaus, > > On Tue, Dec 1, 2020 at 9:38 AM H. Nikolaus Schaller > wrote: > > > > Let's work on a fix for the fix now. > > > > Are you quite sure the chip-select of the tpo,td028ttec1 panel > is active-high? A quick google

[PATCH] ARM: dts: omap3-gta04: fix twl4030-power settings

2020-11-30 Thread Andreas Kemnade
Things are wired up for powersaving, so lets use the corresponding compatible and also update a deprecated property name. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/omap3-gta04.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/omap3-gta04

Re: [PATCH] regulator: ti-abb: Fix array out of bound read access on the first transition

2020-11-18 Thread Andreas Kemnade
Hi, On Wed, 18 Nov 2020 08:50:09 -0600 Nishanth Menon wrote: > At the start of driver initialization, we do not know what bias > setting the bootloader has configured the system for and we only know > for certain the very first time we do a transition. > > However, since the initial value of

Re: [PATCH v3] applesmc: Re-work SMC comms

2020-11-09 Thread Andreas Kemnade
communication to remove the timing > dependencies and restore function with the changes previously > committed. > > Tested on : MacbookAir6,2 MacBookPro11,1 iMac12,2, MacBookAir1,1, > MacBookAir3,1 > > Fixes: fff2d0f701e6 ("hwmon: (applesmc) avoid overlong udelay()"

[REGRESSION] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER

2020-11-05 Thread Andreas Kemnade
Hi, On the GTA04 (DM3730, devicetree omap3-gta04*) I get my console flooded up with the following: [ 24.517211] cpu cpu0: multiple regulators are not supported [ 24.523040] cpufreq: __target_index: Failed to change cpu frequency: -22 [ 24.537231] [ cut here ] [

Re: [PATCH] applesmc: Re-work SMC comms v2

2020-11-05 Thread Andreas Kemnade
On Thu, 5 Nov 2020 08:56:04 +0100 Henrik Rydberg wrote: > Hi Brad, > > Great to see this effort, it is certainly an area which could be > improved. After having seen several generations of Macbooks while > modifying much of that code, it became clear that the SMC communication > got

Re: [PATCH] applesmc: Re-work SMC comms v2

2020-11-05 Thread Andreas Kemnade
timing changes in the aforementioned commit. > > This patch re-factors the SMC communication to remove the timing > dependencies and restore function with the changes previously committed. > > v2 : Address logic and coding style > > Reported-by: Andreas Kemnade > Fixes: fff2d0f701e6

Re: [REGRESSION] hwmon: (applesmc) avoid overlong udelay()

2020-11-04 Thread Andreas Kemnade
On Tue, 3 Nov 2020 16:56:32 +1100 Brad Campbell wrote: > On 3/11/20 10:56 am, Brad Campbell wrote: > > > > > I've examined the code in VirtualSMC and I'm not convinced we were not > > waiting on the wrong bits. > > > > #define SMC_STATUS_AWAITING_DATA  BIT0  ///< Ready to read data. > >

Re: [REGRESSION] hwmon: (applesmc) avoid overlong udelay()

2020-10-06 Thread Andreas Kemnade
On Thu, 1 Oct 2020 21:07:51 -0700 Guenter Roeck wrote: > On 10/1/20 3:22 PM, Andreas Kemnade wrote: > > On Wed, 30 Sep 2020 22:00:09 +0200 > > Arnd Bergmann wrote: > > > >> On Wed, Sep 30, 2020 at 6:44 PM Guenter Roeck wrote: > >>> > >>

Re: [PATCHv1] power: supply: document current direction

2020-10-02 Thread Andreas Kemnade
On Thu, 27 Aug 2020 16:02:48 +0200 Sebastian Reichel wrote: > Currently the sign for CURRENT_NOW and CURRENT_AVG is a bit > of a mess. There are basically 3 different ways battery fuel > gauges report the current: > > 1. uses negative values for discharging and positive values >for charging

Re: [REGRESSION] hwmon: (applesmc) avoid overlong udelay()

2020-10-01 Thread Andreas Kemnade
On Wed, 30 Sep 2020 22:00:09 +0200 Arnd Bergmann wrote: > On Wed, Sep 30, 2020 at 6:44 PM Guenter Roeck wrote: > > > > On Wed, Sep 30, 2020 at 10:54:42AM +0200, Andreas Kemnade wrote: > > > Hi, > > > > > > after the $subject patch I get lots of

[REGRESSION] hwmon: (applesmc) avoid overlong udelay()

2020-09-30 Thread Andreas Kemnade
Hi, after the $subject patch I get lots of errors like this: [ 120.378614] applesmc: send_byte(0x00, 0x0300) fail: 0x40 [ 120.378621] applesmc: LKSB: write data fail [ 120.512782] applesmc: send_byte(0x00, 0x0300) fail: 0x40 [ 120.512787] applesmc: LKSB: write data fail CPU sticks at low

Re: [PATCH v3 5/7] rtc: New driver for RTC in Netronix embedded controller

2020-09-24 Thread Andreas Kemnade
On Thu, 24 Sep 2020 21:24:53 +0200 Jonathan Neuschäfer wrote: > With this driver, mainline Linux can keep its time and date in sync with > the vendor kernel. > > Advanced functionality like alarm and automatic power-on is not yet > supported. > > Signed-off-by: Jonathan Neuschäfer > --- > >

Re: [PATCH v2] omap3: enable off mode automatically

2020-09-24 Thread Andreas Kemnade
On Fri, 11 Sep 2020 18:12:09 +0200 Andreas Kemnade wrote: > Enabling off mode was only reachable deeply hidden > in the debugfs. As powersaving is an important feature, > move the option out of its shady place. > The debugfs file can still be used to override the default. > >

Re: [PATCH v2] dt-bindings: mfd: Convert rn5t618 to json-schema

2020-09-23 Thread Andreas Kemnade
On Tue, 22 Sep 2020 19:40:41 -0600 Rob Herring wrote: > On Wed, Sep 16, 2020 at 08:17:57AM +0200, Andreas Kemnade wrote: > > Convert the RN5T618 binding to DT schema format. Also > > clearly state which regulators are available. > > > > Signed-off-by: Andreas Kemnade

[PATCH v2] dt-bindings: mfd: Convert rn5t618 to json-schema

2020-09-16 Thread Andreas Kemnade
Convert the RN5T618 binding to DT schema format. Also clearly state which regulators are available. Signed-off-by: Andreas Kemnade --- Changes in v2: - drop irq description Due to its .txt-format history BSD license was not added. .../bindings/mfd/ricoh,rn5t618.yaml | 111

Re: [PATCH] dt-bindings: mfd: Convert rn5t618 to json-schema

2020-09-15 Thread Andreas Kemnade
On Tue, 15 Sep 2020 11:11:52 -0600 Rob Herring wrote: > On Tue, Sep 08, 2020 at 10:13:03PM +0200, Andreas Kemnade wrote: > > Convert the RN5T618 binding to DT schema format. Also > > clearly state which regulators are available. > > > > Signed-off-by: Andreas Kemnad

Re: [PATCH v2 04/10] dt-bindings: pwm: Add bindings for PWM function in Netronix EC

2020-09-15 Thread Andreas Kemnade
Hi, On Mon, 14 Sep 2020 18:54:43 -0600 Rob Herring wrote: > On Sat, Sep 05, 2020 at 03:32:24PM +0200, Jonathan Neuschäfer wrote: > > The Netronix embedded controller as found in Kobo Aura and Tolino Shine > > supports one PWM channel, which is used to control the frontlight > > brightness on

Re: [PATCH] omap3: enable off mode automatically

2020-09-11 Thread Andreas Kemnade
On Fri, 11 Sep 2020 13:33:37 +0300 Tony Lindgren wrote: > * Andreas Kemnade [200911 09:50]: > > --- a/arch/arm/mach-omap2/pm.h > > +++ b/arch/arm/mach-omap2/pm.h > > @@ -49,11 +49,7 @@ static inline int omap4_opp_init(void) > > extern int omap3_pm_get_suspend_stat

[PATCH v2] omap3: enable off mode automatically

2020-09-11 Thread Andreas Kemnade
as an indicator that the board is wired correctly for off mode. Signed-off-by: Andreas Kemnade --- An earlier version of this patch was here: https://patchwork.kernel.org/patch/10794121/ A config option was used instead of the suggested devicetree check. Changes in v2: - fix compile without

[PATCH] omap3: enable off mode automatically

2020-09-11 Thread Andreas Kemnade
as an indicator that the board is wired correctly for off mode. Signed-off-by: Andreas Kemnade --- An earlier version of this patch was here: https://patchwork.kernel.org/patch/10794121/ A config option was used instead of the suggested devicetree check. arch/arm/mach-omap2/pm.h | 4 arch

Re: [PATCH V2 1/2] thermal: ti-soc-thermal: Enable addition power management

2020-09-10 Thread Andreas Kemnade
On Thu, 10 Sep 2020 14:33:13 -0500 Adam Ford wrote: > On Thu, Sep 10, 2020 at 2:14 PM Daniel Lezcano > wrote: > > > On 10/09/2020 20:01, Andreas Kemnade wrote: > > > On Wed, 19 Aug 2020 07:59:23 -0500 > > > Adam Ford wrote: > > > > > >&

Re: [PATCH V2 1/2] thermal: ti-soc-thermal: Enable addition power management

2020-09-10 Thread Andreas Kemnade
On Wed, 19 Aug 2020 07:59:23 -0500 Adam Ford wrote: > The bandgap sensor can be idled when the processor is too, but it > isn't currently being done, so the power consumption of OMAP3 > boards can elevated if the bangap sensor is enabled. > > This patch attempts to use some additional power

[PATCH] dt-bindings: mfd: Convert rn5t618 to json-schema

2020-09-08 Thread Andreas Kemnade
Convert the RN5T618 binding to DT schema format. Also clearly state which regulators are available. Signed-off-by: Andreas Kemnade --- I have noted myself here as maintainer because I wrote most of the code of the several subdevices, although not of the .txt-binding. Due to its .txt-format

Re: [PATCH v2 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD

2020-08-31 Thread Andreas Kemnade
Hi, On Thu, 27 Aug 2020 20:33:23 +0200 Jonathan Neuschäfer wrote: > On Wed, Aug 26, 2020 at 10:42:51PM +0200, Andreas Kemnade wrote: > > This adds a devicetree for the Tolino Shine 2 HD Ebook reader. It is based > > on boards marked with "37NB-E60QF0+4A2". It is equippe

[PATCH v3] power: supply: Add support for RN5T618/RC5T619 charger and fuel gauge

2020-08-28 Thread Andreas Kemnade
which disable the fuel gauge at shutdown. If a kernel is booted without fuel gauge support, after such a driver has been used, the fuel gauge will stay off and decalibrate. If this driver is used after that, it might display wrong values for charge level. Signed-off-by: Andreas Kemnade --- Changes

[PATCH v2] power: supply: Add support for RN5T618/RC5T619 charger and fuel gauge

2020-08-27 Thread Andreas Kemnade
which disable the fuel gauge at shutdown. If a kernel is booted without fuel gauge support, after such a driver has been used, the fuel gauge will stay off and decalibrate. If this driver is used after that, it might display wrong values for charge level. Signed-off-by: Andreas Kemnade --- Changes

Re: [PATCH 1/2] power: supply: Add support for RN5T618/RC5T619 charger and fuel gauge

2020-08-26 Thread Andreas Kemnade
Hi, On Wed, 26 Aug 2020 23:59:50 +0200 Sebastian Reichel wrote: > Hi, > > On Wed, Aug 26, 2020 at 08:28:34PM +0200, Andreas Kemnade wrote: > > On Wed, 26 Aug 2020 19:48:17 +0200 > > Sebastian Reichel wrote: > > > On Sat, Aug 15, 2020 at 06:56:09P

[PATCH v2 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD

2020-08-26 Thread Andreas Kemnade
XEC driver) - EPD Not working due to unknown reasons: - deep sleep (echo standby >/sys/power/state works), wakeup fails when imx_gpc_pre_suspend(true) was called. Signed-off-by: Andreas Kemnade --- Changes in v2: - better comments about internals - avoid confusion about polarity of wi

[PATCH v2 1/2] dt-bindings: arm: fsl: add compatible string for Tolino Shine 2 HD

2020-08-26 Thread Andreas Kemnade
This adds a compatible string for the Tolino Shine 2 HD eBook reader. Signed-off-by: Andreas Kemnade Acked-by: Rob Herring --- Documentation/devicetree/bindings/arm/fsl.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation

[PATCH v2 0/2] ARM: dts: add Tolino Shine 2 HD

2020-08-26 Thread Andreas Kemnade
This adds a device tree for the Tolino Shine 2 HD Ebook reader. It is equipped with an i.MX6SL SoC. Except for backlight (via an EC) and the EPD, drivers are available and therefore things are defined in the dts. Andreas Kemnade (2): dt-bindings: arm: fsl: add compatible string for Tolino

Re: [PATCH 1/2] power: supply: Add support for RN5T618/RC5T619 charger and fuel gauge

2020-08-26 Thread Andreas Kemnade
On Wed, 26 Aug 2020 19:48:17 +0200 Sebastian Reichel wrote: > Hi, > > Driver looks mostly good. > > On Sat, Aug 15, 2020 at 06:56:09PM +0200, Andreas Kemnade wrote: > > [...] > > +static int rn5t618_battery_current_now(stru

Re: [PATCH RFC 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD

2020-08-26 Thread Andreas Kemnade
On Sun, 16 Aug 2020 14:54:41 +0200 Jonathan Neuschäfer wrote: > On Sat, Aug 15, 2020 at 09:33:36PM +0200, Andreas Kemnade wrote: > > This adds a devicetree for the Tolino Shine 2 HD Ebook reader. It is based > > on boards marked with "37NB-E60QF0+4A2". It is equippe

Re: [PATCH RFC 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD

2020-08-23 Thread Andreas Kemnade
On Sun, 23 Aug 2020 09:42:31 +0800 Shawn Guo wrote: > On Sat, Aug 15, 2020 at 09:33:36PM +0200, Andreas Kemnade wrote: > > This adds a devicetree for the Tolino Shine 2 HD Ebook reader. It is based > > on boards marked with "37NB-E60QF0+4A2". It is equippe

Re: [PATCH V2 1/2] thermal: ti-soc-thermal: Enable addition power management

2020-08-19 Thread Andreas Kemnade
>dss_pwrdm (1) d2d_clkdm->core_pwrdm (0) iva2_clkdm->iva2_pwrdm (0) mpu_clkdm->mpu_pwrdm (0) core_l4_clkdm->core_pwrdm (20) core_l3_clkdm->core_pwrdm (1) neon_clkdm->neon_pwrdm (0) root@(none):/# So things still turn off. Tested-by: Andreas Kemnade # GTA04 > diff --git a/drivers

[PATCH] ARM: omap2plus_defconfig: enable twl4030_madc as a loadable module

2020-08-19 Thread Andreas Kemnade
The ADC is used by twl4030_charger to read voltages. If a dtb contains the ADC but the module is not build, probing twl4030_charger will be endlessly deferred, so just enable CONFIG_TWL4030_MADC in the config. Signed-off-by: Andreas Kemnade --- arch/arm/configs/omap2plus_defconfig | 1 + 1 file

Re: [PATCH V2] ARM: dts: omap3: Add cpu trips and cooling map for omap34/36 families

2020-08-17 Thread Andreas Kemnade
On Mon, 17 Aug 2020 15:02:27 -0500 Adam Ford wrote: > On Mon, Aug 17, 2020 at 2:59 PM Andreas Kemnade wrote: > > > > On Mon, 17 Aug 2020 08:39:31 -0500 > > Adam Ford wrote: > > > > > The OMAP3530, OMAP3630, and DM3730 all show thresholds of 90C an

Re: [PATCH V2] ARM: dts: omap3: Add cpu trips and cooling map for omap34/36 families

2020-08-17 Thread Andreas Kemnade
On Mon, 17 Aug 2020 08:39:31 -0500 Adam Ford wrote: > The OMAP3530, OMAP3630, and DM3730 all show thresholds of 90C and 105C > depending on commercial or industrial temperature ratings. > > This patch expands the thermal information to include the limits of 90 > and 105C for alert and critical.

Re: [PATCH RFC 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD

2020-08-16 Thread Andreas Kemnade
Hi, On Sun, 16 Aug 2020 17:57:51 +0200 Jonathan Neuschäfer wrote: > On Sun, Aug 16, 2020 at 04:50:58PM +0200, Andreas Kemnade wrote: > > Hi, > > > > Seems that we have different hardware, so the first question is > > first the most interesting thing: how much

Re: [PATCH RFC 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD

2020-08-16 Thread Andreas Kemnade
Hi, Seems that we have different hardware, so the first question is first the most interesting thing: how much does the hw actually differ, especially do they require different device trees? Can you provide me a photo of your hardware? Or is it a Shine 3? Mine is at

[PATCH 1/2] power: supply: Add support for RN5T618/RC5T619 charger and fuel gauge

2020-08-15 Thread Andreas Kemnade
which disable the fuel gauge at shutdown. If a kernel is booted without fuel gauge support, after such a driver has been used, the fuel gauge will stay off and decalibrate. If this driver is used after that, it might display wrong values for charge level. Signed-off-by: Andreas Kemnade --- drivers

[PATCH 2/2] mfd: rn5t618: Add a power supply subdevice

2020-08-15 Thread Andreas Kemnade
The RN5T618 and RC5T619 both have a charger and a fuel gauge, so add a subdevice for it. According to drivers in the wild, things should be at least similar, but since it is not tested, add it only to the RC5T619. Signed-off-by: Andreas Kemnade --- drivers/mfd/rn5t618.c | 1 + 1 file changed, 1

[PATCH 0/2] power: supply: RN5T618/RC5T619

2020-08-15 Thread Andreas Kemnade
This series adds support for the RN5T618/RC5T619 charger and fuel gauge. Battery and input power status can be read. Andreas Kemnade (2): power: supply: Add support for RN5T618/RC5T619 charger and fuel gauge mfd: rn5t618: Add a power supply subdevice drivers/mfd/rn5t618.c

[PATCH 1/2] dt-bindings: arm: fsl: add compatible string for Tolino Shine 2 HD

2020-08-15 Thread Andreas Kemnade
This adds a compatible string for the Tolino Shine 2 HD eBook reader. Signed-off-by: Andreas Kemnade --- Documentation/devicetree/bindings/arm/fsl.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm

[PATCH RFC 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD

2020-08-15 Thread Andreas Kemnade
XEC driver) - EPD Not working due to unknown reasons: - deep sleep (echo standby >/sys/power/state works), wakeup fails when imx_gpc_pre_suspend(true) was called. Signed-off-by: Andreas Kemnade --- Reason for RFC: The suspend trouble might be caused by bad devicetree. But as the devicetr

[PATCH 0/2] ARM: dts: add Tolino Shine 2 HD

2020-08-15 Thread Andreas Kemnade
This adds a device tree for the Tolino Shine 2 HD Ebook reader. It is equipped with an i.MX6SL SoC. Except for backlight (via an EC) and the EPD, drivers are available and therefore things are defined in the dts. Andreas Kemnade (2): dt-bindings: arm: fsl: add compatible string for Tolino

[PATCH v2] mfd: rn5t618: Make restart handler atomic safe

2020-07-21 Thread Andreas Kemnade
to 0xd80a5ff0) [ 165.388420] 5fa0: 00406948 fee1dead 28121969 01234567 73299b00 [ 165.396602] 5fc0: 00406948 0058 be91abc8 be91ab60 004056f8 [ 165.404781] 5fe0: 0058 be91aabc b6ed4d45 b6e56746 Signed-off-by: Andreas Kemnade --- Changes

[PATCH] mfd: rn5t618: Make restart handler atomic safe

2020-07-18 Thread Andreas Kemnade
to 0xd80a5ff0) [ 165.388420] 5fa0: 00406948 fee1dead 28121969 01234567 73299b00 [ 165.396602] 5fc0: 00406948 0058 be91abc8 be91ab60 004056f8 [ 165.404781] 5fe0: 0058 be91aabc b6ed4d45 b6e56746 Signed-off-by: Andreas Kemnade --- drivers/

[PATCH] mfd: rn5t618: Fix caching of battery related registers

2020-07-17 Thread Andreas Kemnade
Battery status changes dynamically, so the corresponding registers need to be considered volatile. Affected registers are: - fuel gauge - battery status - battery interrupt Signed-off-by: Andreas Kemnade --- drivers/mfd/rn5t618.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers

Re: [PATCH 3/3] ARM: imx_v6_v7_defconfig: Build in CONFIG_GPIO_MXC by default

2020-07-10 Thread Andreas Kemnade
Hi, On Wed, 8 Jul 2020 07:25:23 +0800 Anson Huang wrote: > i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC > as built-in manually. > > Signed-off-by: Anson Huang > --- > arch/arm/configs/imx_v6_v7_defconfig | 1 + > 1 file changed, 1 insertion(+) > shouldn't this be done

Re: [RFC PATCH 00/10] Netronix embedded controller driver for Kobo and Tolino ebook readers

2020-07-06 Thread Andreas Kemnade
On Sat, 4 Jul 2020 22:58:08 +0200 Jonathan Neuschäfer wrote: > On Tue, Jun 30, 2020 at 10:14:47PM +0200, Andreas Kemnade wrote: > > On Tue, 30 Jun 2020 09:15:23 +0200 > > Jonathan Neuschäfer wrote: > > > > > On Tue, Jun 30, 2020 at 08:40:51A

Re: [RFC PATCH 00/10] Netronix embedded controller driver for Kobo and Tolino ebook readers

2020-06-30 Thread Andreas Kemnade
On Tue, 30 Jun 2020 09:15:23 +0200 Jonathan Neuschäfer wrote: > On Tue, Jun 30, 2020 at 08:40:51AM +0200, Andreas Kemnade wrote: > [...] > > got a chance to test it on a Tolino Shine 2 HD. > > It uses the RTC from the RC5T619 but backlight seems to go via MSP430 >

Re: [RFC PATCH 00/10] Netronix embedded controller driver for Kobo and Tolino ebook readers

2020-06-30 Thread Andreas Kemnade
On Tue, 30 Jun 2020 09:15:23 +0200 Jonathan Neuschäfer wrote: > On Tue, Jun 30, 2020 at 08:40:51AM +0200, Andreas Kemnade wrote: > [...] > > got a chance to test it on a Tolino Shine 2 HD. > > It uses the RTC from the RC5T619 but backlight seems to go via MSP430 >

Re: [RFC PATCH 00/10] Netronix embedded controller driver for Kobo and Tolino ebook readers

2020-06-30 Thread Andreas Kemnade
Hi, On Sun, 21 Jun 2020 00:39:04 +0200 Jonathan Neuschäfer wrote: > Hi, > > This patchset adds basic support for the embedded controller found on > older ebook reader boards designed by/with the ODM Netronix Inc.[1] and > sold by Kobo or Tolino, for example the Kobo Aura and the Tolino Shine.

Re: [RFC PATCH 04/10] mfd: Add base driver for Netronix embedded controller

2020-06-27 Thread Andreas Kemnade
On Sun, 21 Jun 2020 00:42:15 +0200 Jonathan Neuschäfer wrote: > Third-party hardware documentation is available at > https://github.com/neuschaefer/linux/wiki/Netronix-MSP430-embedded-controller > > The EC supports interrupts, but the driver doesn't make use of them so > far. > > Known

Re: [RFC PATCH 07/10] dt-bindings: rtc: Add bindings for Netronix embedded controller RTC

2020-06-26 Thread Andreas Kemnade
On Sun, 21 Jun 2020 02:02:20 +0200 Alexandre Belloni wrote: > Hi, > > On 21/06/2020 00:42:18+0200, Jonathan Neuschäfer wrote: > > The Netronix EC implements an RTC with the following functionality: > > > > - Calendar-based time keeping with single-second resolution > > - Automatic power-on

Re: [RFC PATCH 05/10] dt-bindings: pwm: Add bindings for PWM function in Netronix EC

2020-06-21 Thread Andreas Kemnade
On Sun, 21 Jun 2020 00:42:16 +0200 Jonathan Neuschäfer wrote: > The Netronix embedded controller as found in Kobo Aura and Tolino Shine > supports one PWM channel, which is used to control the frontlight > brightness on these devices. > > Known problems: > - `make dt_binding_check` shows the

[PATCH] ARM: imx_v6_v7_defconfig: extend RN5T618 PMIC family support

2020-05-07 Thread Andreas Kemnade
There are new drivers for functionality of that family (RTC and ADC), so enable them, since they are used by various i.MX6 boards. Signed-off-by: Andreas Kemnade --- arch/arm/configs/imx_v6_v7_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig

Re: [PATCH 5/5] rtc: rtc-rc5t583: add ricoh rc5t619 RTC driver

2019-10-21 Thread Andreas Kemnade
Hi, On Mon, 21 Oct 2019 12:15:28 +0200 Alexandre Belloni wrote: > Hi, > > The subject line is weird, how is it related to rc5t583? > well, yes, rc5t583 driver source was opened next to the window where I wrote the commit message... > On 21/10/2019 07:41:04+0200, Andrea

Re: [PATCH 5/5] rtc: rtc-rc5t583: add ricoh rc5t619 RTC driver

2019-10-21 Thread Andreas Kemnade
On Mon, 21 Oct 2019 15:50:28 +0200 Alexandre Belloni wrote: > On 21/10/2019 15:19:09+0200, Stefan Agner wrote: > > On 2019-10-21 07:41, Andreas Kemnade wrote: > > > Add an RTC driver for the RTC device on Ricoh MFD rc5t619, > > > which is implemented as a variant of

Re: [PATCH 2/5] mfd: rn5t618: add irq support

2019-10-21 Thread Andreas Kemnade
On Mon, 21 Oct 2019 11:07:10 +0200 Alexandre Belloni wrote: > Hi, > > On 21/10/2019 07:41:01+0200, Andreas Kemnade wrote: > > +#if 0 > > +/* > > + * REVISIT when implementing charger: > > + * according to some other implementation it needs special treatment,

[PATCH 0/5] Add rtc support for rn5t618 mfd

2019-10-20 Thread Andreas Kemnade
. Andreas Kemnade (5): mfd: rn5t618: prepare for irq handling mfd: rn5t618: add irq support mfd: rn5t618: add rtc related registers mfd: rn5t618: add more subdevices rtc: rtc-rc5t583: add ricoh rc5t619 RTC driver drivers/mfd/Kconfig | 1 + drivers/mfd/Makefile

[PATCH 5/5] rtc: rtc-rc5t583: add ricoh rc5t619 RTC driver

2019-10-20 Thread Andreas Kemnade
Add an RTC driver for the RTC device on Ricoh MFD rc5t619, which is implemented as a variant of rn5t618 Signed-off-by: Andreas Kemnade --- drivers/rtc/Kconfig | 10 + drivers/rtc/Makefile | 1 + drivers/rtc/rtc-rc5t619.c | 476 ++ 3

[PATCH 4/5] mfd: rn5t618: add more subdevices

2019-10-20 Thread Andreas Kemnade
The rc5t619 has a rtc which are missing in the rn5t618. Add it as subdevice to prepare for their implementation Signed-off-by: Andreas Kemnade --- drivers/mfd/rn5t618-core.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/rn5t618-core.c b/drivers/mfd

  1   2   3   4   5   >