[PATCH 21/38] mwifiex: fix comparison expression

2015-09-21 Thread Andrzej Hajda
To avoid underflows signed variables should be used in expression. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/net

[PATCH 34/38] perf: remove invalid check

2015-09-21 Thread Andrzej Hajda
Unsigned values cannot be lesser than zero. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- arch/sh/kernel/ptrace_32.c | 3

[PATCH 35/38] ptrace: remove invalid check

2015-09-21 Thread Andrzej Hajda
Unsigned values cannot be lesser than zero. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- arch/sh/kernel/ptrace_64.c | 4

[PATCH 37/38] zlib_deflate/deftree: change always true condition to 1

2015-09-21 Thread Andrzej Hajda
Unsigned value is always greater of equal zero. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- lib/zlib_deflate/deftree.c | 2

[PATCH 22/38] orinoco: fix checking for default value

2015-09-21 Thread Andrzej Hajda
/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/net/wireless/orinoco/cfg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/orinoco/cfg.c b/drivers/net/wireless/orinoco/cfg.c index a9e94b6..0f6ea31 100644 --- a/drivers/net/wireless/orinoco/cfg.c

[PATCH 32/38] fs/cachefiles: remove invalid checks

2015-09-21 Thread Andrzej Hajda
Unsigned values cannot be lesser than zero. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- fs/cachefiles/bind.c | 9

[PATCH 36/38] MIPS: remove invalid check

2015-09-21 Thread Andrzej Hajda
Unsigned values cannot be lesser than zero. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- arch/mips/mm/sc-mips.c | 4 ++-- 1

Re: [PATCH v3] coccinelle: tests: unsigned value cannot be lesser than zero

2015-09-21 Thread Andrzej Hajda
On 09/21/2015 03:02 PM, SF Markus Elfring wrote: >> v3: added bool type > I would appreciate a bit more feedback for my concerns around your > evolving approach. Ups, I have missed your email. > * Reuse of "long int"? If you mean adding int to 'unsigned long [long]' types, it does not work. For s

[PATCH v3] coccinelle: tests: unsigned value cannot be lesser than zero

2015-09-21 Thread Andrzej Hajda
noise. Signed-off-by: Andrzej Hajda Acked-by: Julia Lawall --- v3: added bool type v2: added --all-includes option --- .../tests/unsigned_lesser_than_zero.cocci | 37 ++ 1 file changed, 37 insertions(+) create mode 100644 scripts/coccinelle

[tip:x86/platform] arch/x86/intel-mid: Use kmemdup rather than duplicating its implementation

2015-09-17 Thread tip-bot for Andrzej Hajda
Commit-ID: c9e69c8c58eb8671e9f6cee728088e4c5abc9115 Gitweb: http://git.kernel.org/tip/c9e69c8c58eb8671e9f6cee728088e4c5abc9115 Author: Andrzej Hajda AuthorDate: Fri, 7 Aug 2015 09:59:14 +0200 Committer: Thomas Gleixner CommitDate: Thu, 17 Sep 2015 23:38:59 +0200 arch/x86/intel-mid

[PATCH v2] coccinelle: tests: unsigned value cannot be lesser than zero

2015-09-16 Thread Andrzej Hajda
noise. Signed-off-by: Andrzej Hajda --- v2: added --all-includes option As we discussed earlier I have dropped idea of adding v <= 0 as it is widely used in checking ranges, counters, quantities. Regards Andrzej --- .../tests/unsigned_lesser_than_zero.cocci | 37 +

Re: [PATCH 22/31] fs/ntfs: use kmemdup rather than duplicating its implementation

2015-09-16 Thread Andrzej Hajda
Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda >

Re: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its implementation

2015-09-16 Thread Andrzej Hajda
Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda

Re: [PATCH 23/31] fs/ocfs2: use kmemdup rather than duplicating its implementation

2015-09-16 Thread Andrzej Hajda
Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda

Re: [PATCH 24/31] fs/omfs: use kmemdup rather than duplicating its implementation

2015-09-16 Thread Andrzej Hajda
Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > -

Re: [PATCH 18/31] scsi/aic7xxx: use kmemdup rather than duplicating its implementation

2015-09-16 Thread Andrzej Hajda
Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda >

Re: [PATCH 20/31] fs/cifs: use kmemdup rather than duplicating its implementation

2015-09-16 Thread Andrzej Hajda
Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda

Re: [PATCH 16/31] net/cavium/liquidio: use kmemdup rather than duplicating its implementation

2015-09-16 Thread Andrzej Hajda
Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda &g

Re: [PATCH 17/31] scsi/aacraid: use kmemdup rather than duplicating its implementation

2015-09-16 Thread Andrzej Hajda
Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda >

Re: [PATCH 21/31] fs/dlm: use kmemdup rather than duplicating its implementation

2015-09-16 Thread Andrzej Hajda
Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajd

Re: [PATCH 15/31] misc/vmw_vmci: use kmemdup rather than duplicating its implementation

2015-09-16 Thread Andrzej Hajda
Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda >

Re: [PATCH 14/31] message/fusion: use kmemdup rather than duplicating its implementation

2015-09-16 Thread Andrzej Hajda
Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > -

Re: [PATCH 13/31] memstick: use kmemdup rather than duplicating its implementation

2015-09-16 Thread Andrzej Hajda
Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda

Re: [PATCH 12/31] drm/amdgpu: use kmemdup rather than duplicating its implementation

2015-09-16 Thread Andrzej Hajda
Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > -

Re: [PATCH 08/31] arch/x86/intel-mid: use kmemdup rather than duplicating its implementation

2015-09-16 Thread Andrzej Hajda
Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda

Re: [PATCH 01/31] arch/arm/mach-lpc32xx: use kmemdup rather than duplicating its implementation

2015-09-16 Thread Andrzej Hajda
Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda >

Re: [PATCH 02/31] arch/ia64/tioce: use kmemdup rather than duplicating its implementation

2015-09-16 Thread Andrzej Hajda
Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --

Re: [PATCH] coccinelle: tests: unsigned value cannot be lesser than zero

2015-09-16 Thread Andrzej Hajda
On 09/15/2015 03:57 PM, Julia Lawall wrote: > > > On Tue, 15 Sep 2015, Andrzej Hajda wrote: > >> On 09/15/2015 03:31 PM, Julia Lawall wrote: >>> On Tue, 15 Sep 2015, SF Markus Elfring wrote: >>> >>>>>> v@p >>>>>> (

Re: [PATCH] coccinelle: tests: unsigned value cannot be lesser than zero

2015-09-15 Thread Andrzej Hajda
On 09/15/2015 03:31 PM, Julia Lawall wrote: > On Tue, 15 Sep 2015, SF Markus Elfring wrote: > v@p ( *< 0 | *<= 0 ) >>> It does not, and is not intended to, work. The branches of a disjunction >>> should be complete expressions. >> Will the following SmPL approach be

Re: [PATCH] coccinelle: tests: unsigned value cannot be lesser than zero

2015-09-15 Thread Andrzej Hajda
On 09/15/2015 03:01 PM, SF Markus Elfring wrote: >> +@r depends on context || org || report@ >> +position p; >> +typedef u8, u16, u32, u64; > Can the involved data types be restricted for unsigned types for such > a source code analysis in a more general way? I am not sure if I understand correctl

[PATCH] coccinelle: tests: unsigned value cannot be lesser than zero

2015-09-15 Thread Andrzej Hajda
noise. Signed-off-by: Andrzej Hajda --- Hi Julia, This test finds 93 issues in kernel code (with --all-includes) which could be corrected. Some of them are harmless, just unnecessary code, but there are also serious bugs, like: u32 irq = platform_get_irq(...) if (i

Re: [PATCH 08/18] [media] s5c73m3: Export OF module alias information

2015-09-11 Thread Andrzej Hajda
On 09/11/2015 03:19 AM, Javier Martinez Canillas wrote: > Hello, > > On 08/20/2015 09:07 AM, Javier Martinez Canillas wrote: >> The SPI core always reports the MODALIAS uevent as "spi:" >> regardless of the mechanism that was used to register the device >> (i.e: OF or board code) and the table that

Re: [PATCH 08/18] [media] s5c73m3: Export OF module alias information

2015-09-11 Thread Andrzej Hajda
gt; @@ -31,6 +31,7 @@ static const struct of_device_id s5c73m3_spi_ids[] = { >> { .compatible = "samsung,s5c73m3" }, >> { } >> }; >> +MODULE_DEVICE_TABLE(of, s5c73m3_spi_ids;); >> >> enum spi_direction { >> SPI_DIR_RX, >> >

Re: [RFC 0/2] drm/dsi: DSI for devices with different control bus

2015-09-08 Thread Andrzej Hajda
On 09/07/2015 01:46 PM, Archit Taneja wrote: > Thierry, > > On 08/21/2015 11:39 AM, Archit Taneja wrote: >> >> >> On 08/20/2015 05:18 PM, Thierry Reding wrote: >>> On Thu, Aug 20, 2015 at 09:46:14AM +0530, Archit Taneja wrote: Hi Thierry, Lucas, On 08/19/2015 08:32 PM, Thierry

[tip:x86/microcode] x86/microcode: Use kmemdup() rather than duplicating its implementation

2015-08-22 Thread tip-bot for Andrzej Hajda
Commit-ID: d4e963644768b33aa3db7f470c35d74ed78d8354 Gitweb: http://git.kernel.org/tip/d4e963644768b33aa3db7f470c35d74ed78d8354 Author: Andrzej Hajda AuthorDate: Mon, 10 Aug 2015 12:19:52 +0200 Committer: Ingo Molnar CommitDate: Sat, 22 Aug 2015 14:49:35 +0200 x86/microcode: Use

Re: [RFC 2/2] drm/dsi: Get DSI host by DT device node

2015-08-19 Thread Andrzej Hajda
s only the list, there is no guarantee that mipi_dsi_host returned by of_find_mipi_dsi_host_by_node is still valid, or will be valid long enough. But this issue affects many kernel frameworks so I am not sure if it should block this particular patch. Reviewed-by: Andrzej Hajda Regards And

Re: [RFC 1/2] drm/dsi: Create dummy DSI devices

2015-08-19 Thread Andrzej Hajda
On 06/30/2015 07:24 AM, Archit Taneja wrote: > We can have devices where the data bus is MIPI DSI, but the control bus > is something else (i2c, spi etc). A typical example is i2c controlled > encoder bridge chips. > > Such devices too require passing DSI specific parameters (number of data > lanes

[PATCH 06/31] arch/powerpc/pseries: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- arch/powerpc/platforms/pseries/hotplug-memory.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH 04/31] arch/mips/bcm47xx: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- arch/mips/bcm47xx/buttons.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a

[PATCH 11/31] cpufreq/sfi: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- drivers/cpufreq/sfi-cpufreq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH 10/31] clk/mmp: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- drivers/clk/mmp/clk-mix.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH 03/31] arch/m68k/bootinfo: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- arch/m68k/kernel/bootinfo_proc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[PATCH 05/31] arch/powerpc/nvram: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- arch/powerpc/kernel/nvram_64.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 12/31] drm/amdgpu: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

[PATCH 14/31] message/fusion: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- drivers/message/fusion/mptbase.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH 15/31] misc/vmw_vmci: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- drivers/misc/vmw_vmci/vmci_datagram.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH 17/31] scsi/aacraid: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- drivers/scsi/aacraid/commctrl.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff

[PATCH 18/31] scsi/aic7xxx: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- drivers/scsi/aic7xxx/aic79xx_core.c | 4 ++-- drivers/scsi/aic7xxx/aic7xxx_core.c | 4 ++-- 2 files

[PATCH 22/31] fs/ntfs: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- fs/ntfs/dir.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/ntfs

[PATCH 01/31] arch/arm/mach-lpc32xx: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- arch/arm/mach-lpc32xx/pm.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

[PATCH 20/31] fs/cifs: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- fs/cifs/smb2pdu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/cifs

[PATCH 19/31] staging/lustre: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- drivers/staging/lustre/lustre/obdclass/acl.c | 6 ++ 1 file changed, 2 insertions(+), 4

[PATCH 24/31] fs/omfs: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- fs/omfs/inode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/omfs

[PATCH 08/31] arch/x86/intel-mid: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- arch/x86/platform/intel-mid/sfi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH 07/31] arch/x86/microcode: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- arch/x86/kernel/cpu/microcode/amd.c | 4 +--- arch/x86/kernel/cpu/microcode/intel_early.c

[PATCH 02/31] arch/ia64/tioce: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- arch/ia64/sn/pci/tioce_provider.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 21/31] fs/dlm: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- fs/dlm/lowcomms.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/dlm

[PATCH 26/31] net/sched: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- net/sched/act_bpf.c | 4 +--- net/sched/cls_bpf.c | 4 +--- 2 files changed, 2 insertions(+), 6

[PATCH 27/31] net/tipc: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- net/tipc/server.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/tipc

[PATCH 23/31] fs/ocfs2: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- fs/ocfs2/localalloc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs

[PATCH 29/31] sound/oxfw: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- sound/firewire/oxfw/oxfw-stream.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions

[PATCH 13/31] memstick: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- drivers/memstick/core/mspro_block.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH 28/31] net/xfrm: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- net/xfrm/xfrm_user.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net

[PATCH 09/31] crypto: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- crypto/echainiv.c | 7 ++- crypto/seqiv.c| 6 ++ 2 files changed, 4 insertions(+), 9

[PATCH 25/31] fs/ubifs: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- fs/ubifs/lpt.c | 6 ++ fs/ubifs/tnc.c | 3 +-- 2 files changed, 3 insertions(+), 6 deletions

[PATCH 31/31] sound/soc: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- sound/soc/soc-topology.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH 16/31] net/cavium/liquidio: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- drivers/net/ethernet/cavium/liquidio/octeon_device.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH 30/31] sound/atom: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda --- sound/soc/intel/atom/sst/sst_ipc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH 00/31] use kmemdup rather than duplicating its implementation

2015-08-07 Thread Andrzej Hajda
Hi, This patchset was created using fixed version of memdup.cocci semantic patch [1]. It was compile tested only. It is based on latest linux-next. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Regards Andrzej Andrzej Hajda (31): arch/arm/mach-lpc32xx: use kmemdup rather than

[PATCH] coccinelle: memdup.cocci: fix matching rules

2015-08-06 Thread Andrzej Hajda
message. Signed-off-by: Andrzej Hajda --- Hi Julia, I guess 1st and 3rd changes are OK. I am not sure about 2nd change, without it I was not able to catch cases containing unlikely macro. For example fs/ntfs/dir.c:1175: ir = kmalloc(rc, GFP_NOFS); if (unlikely(!ir)) { err = -ENOMEM; goto

[PATCH RESEND v2 2/6] drm/exynos/mixer: fix interrupt clearing

2015-07-09 Thread Andrzej Hajda
The driver used incorrect flags to clear interrupt status. The patch fixes it. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_mixer.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos

[PATCH RESEND 2/6] drm/exynos/mixer: fix interrupt clearing

2015-07-08 Thread Andrzej Hajda
The driver used incorrect flags to clear interrupt status. The patch fixes it. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_mixer.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos

[PATCH RESEND 6/6] drm/exynos/mixer: replace MXR_INT_EN register cache with flag

2015-07-08 Thread Andrzej Hajda
Driver uses only VSYNC interrupts, so we need to cache VSYNC bit state only. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_mixer.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm

[PATCH RESEND 5/6] drm/exynos/mixer: simplify poweron flag

2015-07-08 Thread Andrzej Hajda
The driver uses bool protected by mutex to track power state. The patch replaces this combo with single bit and atomic bitops. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_mixer.c | 52 ++- 1 file changed, 14 insertions(+), 38 deletions(-) diff

[PATCH RESEND 4/6] drm/exynos/mixer: always update INT_EN cache

2015-07-08 Thread Andrzej Hajda
INT_EN cache field was updated only by mixer_enable_vblank. The patch adds update also by mixer_disable_vblank function. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_mixer.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b

[PATCH RESEND 1/6] drm/exynos/hdmi: fix edid memory leak

2015-07-08 Thread Andrzej Hajda
edid returned by drm_get_edid should be freed. The patch fixes it. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_hdmi.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index

[PATCH RESEND 3/6] drm/exynos/mixer: correct vsync configuration sequence

2015-07-08 Thread Andrzej Hajda
Specification advises to clear vsync indicator before configuring vsync. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_mixer.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos

[PATCH RESEND 0/6] drm/exynos: HDMI related fixes

2015-07-08 Thread Andrzej Hajda
Andrzej Hajda (6): drm/exynos/hdmi: fix edid memory leak drm/exynos/mixer: fix interrupt clearing drm/exynos/mixer: correct vsync configuration sequence drm/exynos/mixer: always update INT_EN cache drm/exynos/mixer: simplify poweron flag drm/exynos/mixer: replace MXR_INT_EN register

Re: [PATCH 6/6] [media] s5c73m3: Remove redundant spi driver bus initialization

2015-06-23 Thread Andrzej Hajda
eo > To: Mauro Carvalho Chehab > To: Kyungmin Park > To: Andrzej Hajda > To: linux-me...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org Reviewed-by: Andrzej Hajda Regards Andrzej > --- > drivers/media/i2c/s5c73m3/s5c73m3-spi.c | 1 - > 1 file changed, 1 deletion(-) >

Re: [PATCH 00/13] Discover and probe dependencies

2015-06-18 Thread Andrzej Hajda
On 06/18/2015 12:36 PM, Mark Brown wrote: > On Thu, Jun 18, 2015 at 11:42:01AM +0200, Andrzej Hajda wrote: > > There's something really messed up with how your mailer is word wrapping > paragraphs, might want to check it out - it looks like it's making lines > that are l

Re: [PATCH 00/13] Discover and probe dependencies

2015-06-18 Thread Andrzej Hajda
Hi Tomeu, I have few comments about the design. On 06/17/2015 03:42 PM, Tomeu Vizoso wrote: > Hi, > > this is another attempt at preventing deferred probe from obscuring why your > devices aren't probing and from delaying to the end of the boot process the > probe of the device you care the most.

Re: [PATCH 00/21] On-demand device registration

2015-06-10 Thread Andrzej Hajda
On 06/10/2015 12:19 PM, Tomeu Vizoso wrote: > On 10 June 2015 at 09:30, Linus Walleij wrote: >> On Tue, Jun 2, 2015 at 12:14 PM, Tomeu Vizoso >> wrote: >>> On 2 June 2015 at 10:48, Linus Walleij wrote: >> This is what systemd is doing in userspace for starting services: ask for your de

Re: [PATCH] [media] s5k5baf: Convert use of __constant_cpu_to_be16 to cpu_to_be16

2015-06-07 Thread Andrzej Hajda
Signed-off-by: Vaishali Thakkar Reviewed-by: Andrzej Hajda > --- > drivers/media/i2c/s5k5baf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/s5k5baf.c b/drivers/media/i2c/s5k5baf.c > index 297ef04..7a43b55 100644 > --- a/drivers/m

Re: [PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD

2015-05-04 Thread Andrzej Hajda
Hi, On 05/04/2015 02:43 PM, Krzysztof Kozlowski wrote: > 2015-05-04 20:34 GMT+09:00 Daniel Stone : >> Hi, >> >> On 4 May 2015 at 08:43, Inki Dae wrote: >>> On 2015년 05월 02일 13:08, Krzysztof Kozlowski wrote: Selecting CONFIG_FB_S3C disables CONFIG_DRM_EXYNOS_FIMD leading to build error:

Re: [PATCH 1/2] ARM: EXYNOS: Get current parent clock for power domain on/off

2015-04-03 Thread Andrzej Hajda
On 04/02/2015 02:44 PM, Krzysztof Kozlowski wrote: > 2015-04-02 14:29 GMT+02:00 Javier Martinez Canillas > : >> Hello Krzysztof, >> >> On 04/02/2015 10:06 AM, Krzysztof Kozlowski wrote: >>> Using a fixed (by DTS) parent for clocks when turning on the power domain >>> may introduce issues in other d

[PATCH v2 RESEND 1/4] arm/exynos: add asynchronous bridge clock bindings

2015-03-12 Thread Andrzej Hajda
The patch adds bindings for clocks required by async-bridges present in the particular power domain. Signed-off-by: Andrzej Hajda Reviewed-by: Javier Martinez Canillas Tested-by: Javier Martinez Canillas --- Documentation/devicetree/bindings/arm/exynos/power_domain.txt | 3 +++ 1 file changed

[PATCH v2 RESEND 2/4] arm/exynos/pm_domains: add support for async-bridge clocks

2015-03-12 Thread Andrzej Hajda
Since Exynos5420 there are async-bridges (ASB) between different IPs. These bridges must be operational during power domain on/off, ie. clocks used by these bridges should be enabled. This patch enabled these clocks during domain on/off. Signed-off-by: Andrzej Hajda Reviewed-by: Javier Martinez

[PATCH v2 RESEND 3/4] ARM: dts: exynos5420: add async-bridge clocks to disp1 power domain

2015-03-12 Thread Andrzej Hajda
FIMD and MIXER IPs in disp1 power domain have async-bridges (to GSCALER), therefore their clocks should be enabled during power domain switch. Signed-off-by: Andrzej Hajda Reviewed-by: Javier Martinez Canillas Tested-by: Javier Martinez Canillas Reviewed-by: Sylwester Nawrocki --- arch/arm

[PATCH v2 RESEND 4/4] ARM: dts: exynos5420: add async-bridge clocks to gsc power domain

2015-03-12 Thread Andrzej Hajda
Both GSCALER IPs in gsc power domain have async-bridges (to FIMD and MIXER), therefore their clocks should be enabled during power domain switch. Signed-off-by: Andrzej Hajda Reviewed-by: Javier Martinez Canillas Tested-by: Javier Martinez Canillas --- arch/arm/boot/dts/exynos5420.dtsi | 2

[PATCH v2 RESEND 0/4] Fix power domains handling on exynos542x

2015-03-12 Thread Andrzej Hajda
abort" faults. The patchset is based on samsung-fixes-dt tag from kgene/linux-samsung. It was successfully tested on OdroidXU3. Regards Andrzej Andrzej Hajda (4): arm/exynos: add asynchronous bridge clock bindings arm/exynos/pm_domains: add support for async-bridge clocks ARM: dts:

Re: [PATCHv3 1/2] drm: atmel-hlcdc: Add PM suspend/resume support

2015-02-23 Thread Andrzej Hajda
On 02/22/2015 06:51 PM, Sylvain Rochet wrote: > On suspend: switch off CRTC if not already suspended with runtime PM > > On resume: switch on CRTC if we were not already suspended from runtime > PM while suspending. > > Signed-off-by: Sylvain Rochet Reviewed-by: Andrzej Hajda

Re: [PATCHv2 1/2] drm: atmel-hlcdc: Add PM suspend/resume support

2015-02-17 Thread Andrzej Hajda
Hi Sylvain, Few comments below. On 02/12/2015 09:49 PM, Sylvain Rochet wrote: > On suspend: switch off CRTC if not already suspended with runtime PM > > On resume: switch on CRTC if we were not already suspended from runtime > PM while suspending. > > Signed-off-by: Sylvain Rochet > --- > dri

Re: [PATCH v2 1/2] mmc: dw_mmc: fix bug that cause 'Timeout sending command'

2015-02-12 Thread Andrzej Hajda
On 02/12/2015 12:20 AM, Alim Akhtar wrote: > Hi Andrzej, > > On Wed, Feb 11, 2015 at 5:28 PM, Andrzej Hajda wrote: >> Hi Alim, >> >> On 02/11/2015 03:57 AM, Addy wrote: >>> On 2015/02/10 23:22, Alim Akhtar wrote: >>>> Hi Addy, >>&

Re: [PATCH v2 1/2] mmc: dw_mmc: fix bug that cause 'Timeout sending command'

2015-02-12 Thread Andrzej Hajda
On 02/12/2015 03:28 AM, addy ke wrote: > Hi Andrzej and Alim > > On 2015/2/12 07:20, Alim Akhtar wrote: >> Hi Andrzej, >> >> On Wed, Feb 11, 2015 at 5:28 PM, Andrzej Hajda wrote: >>> Hi Alim, >>> >>> On 02/11/2015 03:57 AM, Addy wrote: >

Re: [PATCH v2 1/2] mmc: dw_mmc: fix bug that cause 'Timeout sending command'

2015-02-11 Thread Andrzej Hajda
Hi Alim, On 02/11/2015 03:57 AM, Addy wrote: > > On 2015/02/10 23:22, Alim Akhtar wrote: >> Hi Addy, >> >> On Mon, Feb 9, 2015 at 12:55 PM, Addy Ke wrote: >>> Because of some uncertain factors, such as worse card or worse hardware, >>> DAT[3:0](the data lines) may be pulled down by card, and mmc

[RFC PATCH v2 3/3] ARM: dts: exynos5420: add async-bridge clocks to disp1 power domain

2015-02-06 Thread Andrzej Hajda
FIMD and MIXER IPs in disp1 power domain have async-bridges (to GSCALER), therefore their clocks should be enabled during power domain switch. Signed-off-by: Andrzej Hajda --- Hi, This is 2nd version of the patch. After decrypting manual and discussion with Marek I guess this set of clocks is

[RFC PATCH 2/3] arm/exynos/pm_domains: add support for async-bridge clocks

2015-02-05 Thread Andrzej Hajda
Since Exynos5420 there are async-bridges (ASB) between different IPs. These bridges must be operational during power domain on/off, ie. clocks used by these bridges should be enabled. This patch enabled these clocks during domain on/off. Signed-off-by: Andrzej Hajda --- arch/arm/mach-exynos

[RFC PATCH 3/3] ARM: dts: exynos5420: add async-bridge clock to disp1 power domain

2015-02-05 Thread Andrzej Hajda
disp1 power domain requires operational async-bridge associated with HDMI, ie its clock should be enabled during power on/off. This patch fixes broken Odroid XU3 HDMI support. Signed-off-by: Andrzej Hajda --- arch/arm/boot/dts/exynos5420.dtsi | 6 -- 1 file changed, 4 insertions(+), 2

[RFC PATCH 1/3] arm/exynos: add asynchronous bridge clock bindings

2015-02-05 Thread Andrzej Hajda
The patch adds bindings for clocks required by async-bridges present in the particular power domain. Signed-off-by: Andrzej Hajda --- Documentation/devicetree/bindings/arm/exynos/power_domain.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/exynos

[RFC PATCH 0/3] Fix power domains handling on exynos542x

2015-02-05 Thread Andrzej Hajda
forms' [1]. It was successfully tested on OdroidXU3. [1]: http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/42743 Regards Andrzej Andrzej Hajda (3): arm/exynos: add asynchronous bridge clock bindings arm/exynos/pm_domains: add support for async-bridge clocks ARM: dts: exynos54

<    2   3   4   5   6   7   8   9   10   >