Re: [RESEND PATCH v5 3/7] dt-bindings: remoteproc: Add processor identifier property

2024-06-04 Thread Arnaud POULIQUEN
Hello Rob On 6/3/24 16:35, Rob Herring wrote: > On Tue, May 21, 2024 at 02:24:54PM +0200, Arnaud Pouliquen wrote: >> Add the "st,proc-id" property allowing to identify the remote processor. >> This ID is used to define an unique ID, common between Linux, U-boot

Re: [PATCH v5 5/7] remoteproc: core: support of the tee interface

2024-06-03 Thread Arnaud POULIQUEN
Hello Mathieu, On 5/31/24 19:28, Mathieu Poirier wrote: > On Thu, May 30, 2024 at 09:42:26AM +0200, Arnaud POULIQUEN wrote: >> Hello Mathieu, >> >> On 5/29/24 22:35, Mathieu Poirier wrote: >>> On Wed, May 29, 2024 at 09:13:26AM +0200, Arnaud POULIQUEN wrote: >>

Re: [PATCH v5 5/7] remoteproc: core: support of the tee interface

2024-05-30 Thread Arnaud POULIQUEN
Hello Mathieu, On 5/29/24 22:35, Mathieu Poirier wrote: > On Wed, May 29, 2024 at 09:13:26AM +0200, Arnaud POULIQUEN wrote: >> Hello Mathieu, >> >> On 5/28/24 23:30, Mathieu Poirier wrote: >>> On Tue, May 21, 2024 at 10:09:59AM +0200, Arnaud Pouliquen wrote: >>

Re: [PATCH v5 5/7] remoteproc: core: support of the tee interface

2024-05-29 Thread Arnaud POULIQUEN
Hello Mathieu, On 5/28/24 23:30, Mathieu Poirier wrote: > On Tue, May 21, 2024 at 10:09:59AM +0200, Arnaud Pouliquen wrote: >> 1) on start: >> - Using the TEE loader, the resource table is loaded by an external entity. >> In such case the resource table address is not f

[RESEND PATCH v5 7/7] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-05-21 Thread Arnaud Pouliquen
defined by the TEE. Signed-off-by: Arnaud Pouliquen --- Update from V4: - remove hard coded remote proc ID STM32_MP1_M4_PROC_ID, get the ID from the DT, - replace find_loaded_rsc_table by get_loaded_rsc_table. --- drivers/remoteproc/stm32_rproc.c | 65 ++-- 1 file

[RESEND PATCH v5 4/7] remoteproc: core introduce rproc_set_rsc_table_on_start function

2024-05-21 Thread Arnaud Pouliquen
in rproc_reset_rsc_table_on_stop(). - rename rproc_set_rsc_table in rproc_set_rsc_table_on_attach() - move rproc_reset_rsc_table_on_stop() to be close to the rproc_set_rsc_table_on_start() function Suggested-by: Mathieu Poirier Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 116

[RESEND PATCH v5 2/7] dt-bindings: remoteproc: Add compatibility for TEE support

2024-05-21 Thread Arnaud Pouliquen
evice tree with the st,stm32mp1-m4-tee to support signed remoteproc firmware. Based on DT properties, OP-TEE authenticates, loads, starts, and stops the firmware. - On Linux, when the compatibility is set, the Cortex-M resets should not be declared in the device tree. Signed-off-by: Arnaud Pouliquen

[RESEND PATCH v5 1/7] remoteproc: Add TEE support

2024-05-21 Thread Arnaud Pouliquen
application. Signed-off-by: Arnaud Pouliquen --- update from V4 - fix commit message, - fix Kconfig typo, - introduce tee_rproc_release_loaded_rsc_table function to release the resource table, - reorder function variables in declaration in reverse ascending order, - introduce try_module_get

[RESEND PATCH v5 0/7] Introduction of a remoteproc tee to load signed firmware

2024-05-21 Thread Arnaud Pouliquen
ed image has evolved between the presentation and the integration in OP-TEE). https://resources.linaro.org/en/resource/6c5bGvZwUAjX56fvxthxds Arnaud Pouliquen (7): remoteproc: Add TEE support dt-bindings: remoteproc: Add compatibility for TEE support dt-bindings: remoteproc: Add processor identifier

[RESEND PATCH v5 6/7] remoteproc: stm32: Create sub-functions to request shutdown and release

2024-05-21 Thread Arnaud Pouliquen
To prepare for the support of TEE remoteproc, create sub-functions that can be used in both cases, with and without remoteproc TEE support. Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/stm32_rproc.c | 84 +++- 1 file changed, 51 insertions(+), 33 deletions

[RESEND PATCH v5 5/7] remoteproc: core: support of the tee interface

2024-05-21 Thread Arnaud Pouliquen
een shutdown. However if the TEE interface is being used, we first need to unmap the table_ptr before setting it to rproc->cached_table. The update of rproc->table_ptr to rproc->cached_table is performed in tee_remoteproc. Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc

[RESEND PATCH v5 3/7] dt-bindings: remoteproc: Add processor identifier property

2024-05-21 Thread Arnaud Pouliquen
Signed-off-by: Arnaud Pouliquen --- .../devicetree/bindings/remoteproc/st,stm32-rproc.yaml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml index 36

Re: [PATCH v5 2/7] dt-bindings: remoteproc: Add compatibility for TEE support

2024-05-21 Thread Arnaud POULIQUEN
On 5/21/24 11:24, Krzysztof Kozlowski wrote: > On 21/05/2024 10:09, Arnaud Pouliquen wrote: >> The "st,stm32mp1-m4-tee" compatible is utilized in a system configuration >> where the Cortex-M4 firmware is loaded by the Trusted execution Environment >> (TEE). &

[PATCH v5 4/7] remoteproc: core introduce rproc_set_rsc_table_on_start function

2024-05-21 Thread Arnaud Pouliquen
in rproc_reset_rsc_table_on_stop(). - rename rproc_set_rsc_table in rproc_set_rsc_table_on_attach() - move rproc_reset_rsc_table_on_stop() to be close to the rproc_set_rsc_table_on_start() function Suggested-by: Mathieu Poirier Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 116

[PATCH v5 6/7] remoteproc: stm32: Create sub-functions to request shutdown and release

2024-05-21 Thread Arnaud Pouliquen
To prepare for the support of TEE remoteproc, create sub-functions that can be used in both cases, with and without remoteproc TEE support. Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/stm32_rproc.c | 84 +++- 1 file changed, 51 insertions(+), 33 deletions

[PATCH v5 1/7] remoteproc: Add TEE support

2024-05-21 Thread Arnaud Pouliquen
application. Signed-off-by: Arnaud Pouliquen --- update from V4 - fix commit message, - fix Kconfig typo, - introduce tee_rproc_release_loaded_rsc_table function to release the resource table, - reorder function variables in declaration in reverse ascending order, - introduce try_module_get

[PATCH v5 7/7] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-05-21 Thread Arnaud Pouliquen
defined by the TEE. Signed-off-by: Arnaud Pouliquen --- Update from V4: - remove hard coded remote proc ID STM32_MP1_M4_PROC_ID, get the ID from the DT, - replace find_loaded_rsc_table by get_loaded_rsc_table. --- drivers/remoteproc/stm32_rproc.c | 65 ++-- 1 file

[PATCH v5 2/7] dt-bindings: remoteproc: Add compatibility for TEE support

2024-05-21 Thread Arnaud Pouliquen
evice tree with the st,stm32mp1-m4-tee to support signed remoteproc firmware. Based on DT properties, OP-TEE authenticates, loads, starts, and stops the firmware. - On Linux, when the compatibility is set, the Cortex-M resets should not be declared in the device tree. Signed-off-by: Arnaud Pouliquen

[PATCH v5 0/7] Introduction of a remoteproc tee to load signed firmware

2024-05-21 Thread Arnaud Pouliquen
ed image has evolved between the presentation and the integration in OP-TEE). https://resources.linaro.org/en/resource/6c5bGvZwUAjX56fvxthxds Arnaud Pouliquen (7): remoteproc: Add TEE support dt-bindings: remoteproc: Add compatibility for TEE support dt-bindings: remoteproc: Add processor identifier

[PATCH v5 3/7] dt-bindings: remoteproc: Add processor identifier property

2024-05-21 Thread Arnaud Pouliquen
Signed-off-by: Arnaud Pouliquen --- .../devicetree/bindings/remoteproc/st,stm32-rproc.yaml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml index 36

[PATCH v5 5/7] remoteproc: core: support of the tee interface

2024-05-21 Thread Arnaud Pouliquen
een shutdown. However if the TEE interface is being used, we first need to unmap the table_ptr before setting it to rproc->cached_table. The update of rproc->table_ptr to rproc->cached_table is performed in tee_remoteproc. Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc

[PATCH] rpmsg: char: fix rpmsg_eptdev structure documentation

2024-05-17 Thread Arnaud Pouliquen
or struct member 'remote_flow_updated' not described in 'rpmsg_eptdev' Fixes: 5550201c0fe2 ("rpmsg: char: Add RPMSG GET/SET FLOWCONTROL IOCTL support") Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_char.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v4 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-04-03 Thread Arnaud POULIQUEN
On 4/1/24 17:46, Mathieu Poirier wrote: > On Fri, Mar 29, 2024 at 11:57:43AM +0100, Arnaud POULIQUEN wrote: >> >> >> On 3/27/24 18:14, Mathieu Poirier wrote: >>> On Tue, Mar 26, 2024 at 08:31:33PM +0100, Arnaud POULIQUEN wrote: >>>> >>

Re: [PATCH v4 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-03-29 Thread Arnaud POULIQUEN
On 3/27/24 18:14, Mathieu Poirier wrote: > On Tue, Mar 26, 2024 at 08:31:33PM +0100, Arnaud POULIQUEN wrote: >> >> >> On 3/25/24 17:51, Mathieu Poirier wrote: >>> On Fri, Mar 08, 2024 at 03:47:08PM +0100, Arnaud Pouliquen wrote: >>>> The new TEE

Re: [PATCH v4 1/4] remoteproc: Add TEE support

2024-03-29 Thread Arnaud POULIQUEN
Hello Mathieu, On 3/27/24 18:07, Mathieu Poirier wrote: > On Tue, Mar 26, 2024 at 08:18:23PM +0100, Arnaud POULIQUEN wrote: >> Hello Mathieu, >> >> On 3/25/24 17:46, Mathieu Poirier wrote: >>> On Fri, Mar 08, 2024 at 03:47:05PM +0100, Arnaud Pouliquen wrote: >

Re: [PATCH v4 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-03-26 Thread Arnaud POULIQUEN
On 3/25/24 17:51, Mathieu Poirier wrote: > On Fri, Mar 08, 2024 at 03:47:08PM +0100, Arnaud Pouliquen wrote: >> The new TEE remoteproc device is used to manage remote firmware in a >> secure, trusted context. The 'st,stm32mp1-m4-tee' compatibility is >> introduced to

Re: [PATCH v4 1/4] remoteproc: Add TEE support

2024-03-26 Thread Arnaud POULIQUEN
Hello Mathieu, On 3/25/24 17:46, Mathieu Poirier wrote: > On Fri, Mar 08, 2024 at 03:47:05PM +0100, Arnaud Pouliquen wrote: >> Add a remoteproc TEE (Trusted Execution Environment) driver >> that will be probed by the TEE bus. If the associated Trusted >> application is sup

[PATCH v4 1/4] remoteproc: Add TEE support

2024-03-08 Thread Arnaud Pouliquen
application. Signed-off-by: Arnaud Pouliquen --- Updates from V3: - rework TEE_REMOTEPROC description in Kconfig - fix some namings - add tee_rproc_parse_fw to support rproc_ops::parse_fw - add proc::tee_interface; - add rproc struct as parameter of the tee_rproc_register() function --- drivers

[PATCH v4 2/4] dt-bindings: remoteproc: Add compatibility for TEE support

2024-03-08 Thread Arnaud Pouliquen
evice tree with the st,stm32mp1-m4-tee to support signed remoteproc firmware. Based on DT properties, OP-TEE authenticates, loads, starts, and stops the firmware. - On Linux, when the compatibility is set, the Cortex-M resets should not be declared in the device tree. Signed-off-by: Arnaud Pouliquen

[PATCH v4 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-03-08 Thread Arnaud Pouliquen
defined by the TEE. Signed-off-by: Arnaud Pouliquen --- Updates from V3: - remove support of the attach use case. Will be addressed in a separate thread, - add st_rproc_tee_ops::parse_fw ops, - inverse call of devm_rproc_alloc()and tee_rproc_register() to manage cross reference between

[PATCH v4 3/4] remoteproc: stm32: Create sub-functions to request shutdown and release

2024-03-08 Thread Arnaud Pouliquen
To prepare for the support of TEE remoteproc, create sub-functions that can be used in both cases, with and without TEE support. Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/stm32_rproc.c | 84 +++- 1 file changed, 51 insertions(+), 33 deletions(-) diff

[PATCH v4 0/4] Introduction of a remoteproc tee to load signed firmware

2024-03-08 Thread Arnaud Pouliquen
about the implementation, a presentation is available here (note that the format of the signed image has evolved between the presentation and the integration in OP-TEE). https://resources.linaro.org/en/resource/6c5bGvZwUAjX56fvxthxds Arnaud Pouliquen (4): remoteproc: Add TEE support dt-bindings

Re: [PATCH v3 1/7] remoteproc: Add TEE support

2024-02-29 Thread Arnaud POULIQUEN
Hello Mathieu, On 2/29/24 17:19, Mathieu Poirier wrote: > Good morning, > > On Wed, Feb 28, 2024 at 09:20:28AM +0100, Arnaud POULIQUEN wrote: >> Hello Mathieu, >> >> >> On 2/23/24 19:27, Mathieu Poirier wrote: >>> On Wed, Feb 14, 2024 at 06:21:21P

Re: [PATCH v3 7/7] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-02-29 Thread Arnaud POULIQUEN
On 2/23/24 19:37, Mathieu Poirier wrote: > On Fri, Feb 23, 2024 at 02:54:13PM +0100, Arnaud POULIQUEN wrote: >> Hello Mathieu, >> >> On 2/22/24 20:02, Mathieu Poirier wrote: >>> Hi, >>> >>> On Wed, Feb 14, 2024 at 06:21:27PM +0100, Arnaud Pou

Re: [PATCH v3 1/7] remoteproc: Add TEE support

2024-02-28 Thread Arnaud POULIQUEN
Hello Mathieu, On 2/23/24 19:27, Mathieu Poirier wrote: > On Wed, Feb 14, 2024 at 06:21:21PM +0100, Arnaud Pouliquen wrote: >> From: Arnaud Pouliquen >> >> Add a remoteproc TEE (Trusted Execution Environment) driver >> that will be probed by the TEE bus. If the associ

Re: [PATCH v3 0/7] Introduction of a remoteproc tee to load signed firmware

2024-02-23 Thread Arnaud POULIQUEN
On 2/22/24 10:55, Naman Jain wrote: > On 2/22/2024 2:17 PM, Arnaud POULIQUEN wrote: >> Hello Naman, >> >> On 2/22/24 06:43, Naman Jain wrote: >>> On 2/14/2024 10:51 PM, Arnaud Pouliquen wrote: >>>> Updates from the previous version [1]: >>>

Re: [PATCH v3 7/7] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-02-23 Thread Arnaud POULIQUEN
Hello Mathieu, On 2/22/24 20:02, Mathieu Poirier wrote: > Hi, > > On Wed, Feb 14, 2024 at 06:21:27PM +0100, Arnaud Pouliquen wrote: >> The new TEE remoteproc device is used to manage remote firmware in a >> secure, trusted context. The 'st,stm32mp1-m4-tee' compatibi

Re: [PATCH v3 0/7] Introduction of a remoteproc tee to load signed firmware

2024-02-22 Thread Arnaud POULIQUEN
Hello Naman, On 2/22/24 06:43, Naman Jain wrote: > On 2/14/2024 10:51 PM, Arnaud Pouliquen wrote: >> Updates from the previous version [1]: >> >> This version proposes another approach based on an alternate load and boot >> of the coprocessor. Therefore

Re: [PATCH v3 1/7] remoteproc: Add TEE support

2024-02-21 Thread Arnaud POULIQUEN
Hi Mathieu, On 2/20/24 19:58, Mathieu Poirier wrote: > Good morning, > > On Wed, Feb 14, 2024 at 06:21:21PM +0100, Arnaud Pouliquen wrote: >> From: Arnaud Pouliquen >> >> Add a remoteproc TEE (Trusted Execution Environment) driver >> that will be probed by the T

[PATCH v3 2/7] remoteproc: Extract the firmware load from the start

2024-02-14 Thread Arnaud Pouliquen
segments authenticated after being copied to the destination memory). Removing rproc_load_segments will allow it to be called earlier in the boot sequence. Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions

[PATCH v3 4/7] remoteproc: core: Implement the support of an alternative boot

2024-02-14 Thread Arnaud Pouliquen
Implement a new method to load a firmware and start the remote processor. In this method the firmware is loaded first and then the loaded resource table is obtained. Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 86 +++- include/linux

[PATCH v3 7/7] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-02-14 Thread Arnaud Pouliquen
defined by the TEE. A new "to_attach" field is introduced to differentiate the use cases "firmware loaded by the boot stage" and "firmware loaded by the TEE". Signed-off-by: Arnaud Pouliquen --- V2 to V3 update: - remove stm32_rproc_tee_elf_sanity_che

[PATCH v3 6/7] remoteproc: stm32: Create sub-functions to request shutdown and release

2024-02-14 Thread Arnaud Pouliquen
To prepare for the support of TEE remoteproc, create sub-functions that can be used in both cases, with and without TEE support. Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/stm32_rproc.c | 84 +++- 1 file changed, 51 insertions(+), 33 deletions(-) diff

[PATCH v3 1/7] remoteproc: Add TEE support

2024-02-14 Thread Arnaud Pouliquen
From: Arnaud Pouliquen Add a remoteproc TEE (Trusted Execution Environment) driver that will be probed by the TEE bus. If the associated Trusted application is supported on secure part this device offers a client interface to load a firmware in the secure part. This firmware could

[PATCH v3 0/7] Introduction of a remoteproc tee to load signed firmware

2024-02-14 Thread Arnaud Pouliquen
tation is available here (note that the format of the signed image has evolved between the presentation and the integration in OP-TEE). https://resources.linaro.org/en/resource/6c5bGvZwUAjX56fvxthxds Arnaud Pouliquen (7): remoteproc: Add TEE support remoteproc: Extract the firmware load

[PATCH v3 5/7] dt-bindings: remoteproc: Add compatibility for TEE support

2024-02-14 Thread Arnaud Pouliquen
evice tree with the st,stm32mp1-m4-tee to support signed remoteproc firmware. Based on DT properties, OP-TEE authenticates, loads, starts, and stops the firmware. - On Linux, when the compatibility is set, the Cortex-M resets should not be declared in the device tree. Signed-off-by: Arnaud Pouliqu

[PATCH v3 3/7] remoteproc: core: Add check on cached_table pointer

2024-02-14 Thread Arnaud Pouliquen
ration on stop and re-apply the configuration on the re-start. Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 283ca0

Re: [Linux-stm32] [PATCH v2 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-02-13 Thread Arnaud POULIQUEN
Hello Mathieu, On 2/5/24 10:13, Arnaud POULIQUEN wrote: > > > On 2/2/24 20:53, Mathieu Poirier wrote: >> On Thu, Feb 01, 2024 at 07:33:35PM +0100, Arnaud POULIQUEN wrote: >>> >>> >>> On 2/1/24 17:02, Mathieu Poirier wrote: >>>> On Thu, Fe

Re: [PATCH v2 2/4] dt-bindings: remoteproc: Add compatibility for TEE support

2024-02-13 Thread Arnaud POULIQUEN
Hello Rob, On 1/30/24 18:51, Rob Herring wrote: > On Thu, Jan 18, 2024 at 11:04:31AM +0100, Arnaud Pouliquen wrote: >> The "st,stm32mp1-m4-tee" compatible is utilized in a system configuration >> where the Cortex-M4 firmware is loaded by the Trusted execution Environment

Re: [PATCH v2 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-02-05 Thread Arnaud POULIQUEN
On 2/2/24 20:53, Mathieu Poirier wrote: > On Thu, Feb 01, 2024 at 07:33:35PM +0100, Arnaud POULIQUEN wrote: >> >> >> On 2/1/24 17:02, Mathieu Poirier wrote: >>> On Thu, Feb 01, 2024 at 04:06:37PM +0100, Arnaud POULIQUEN wrote: >>>> hello Mathieu, &

Re: [PATCH v2 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-02-01 Thread Arnaud POULIQUEN
On 2/1/24 17:02, Mathieu Poirier wrote: > On Thu, Feb 01, 2024 at 04:06:37PM +0100, Arnaud POULIQUEN wrote: >> hello Mathieu, >> >> On 1/31/24 19:52, Mathieu Poirier wrote: >>> On Tue, Jan 30, 2024 at 10:13:48AM +0100, Arnaud POULIQUEN wrote: >>>> &

Re: [PATCH v2 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-02-01 Thread Arnaud POULIQUEN
hello Mathieu, On 1/31/24 19:52, Mathieu Poirier wrote: > On Tue, Jan 30, 2024 at 10:13:48AM +0100, Arnaud POULIQUEN wrote: >> >> >> On 1/26/24 18:11, Mathieu Poirier wrote: >>> On Thu, Jan 18, 2024 at 11:04:33AM +0100, Arnaud Pouliquen wrote: >>>> The n

Re: [PATCH v2 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-01-30 Thread Arnaud POULIQUEN
On 1/26/24 18:11, Mathieu Poirier wrote: > On Thu, Jan 18, 2024 at 11:04:33AM +0100, Arnaud Pouliquen wrote: >> The new TEE remoteproc device is used to manage remote firmware in a >> secure, trusted context. The 'st,stm32mp1-m4-tee' compatibility is >> introduced to

Re: [PATCH v2 1/4] remoteproc: Add TEE support

2024-01-30 Thread Arnaud POULIQUEN
On 1/29/24 19:55, Mathieu Poirier wrote: > On Thu, Jan 18, 2024 at 11:04:30AM +0100, Arnaud Pouliquen wrote: >> From: Arnaud Pouliquen >> >> Add a remoteproc TEE (Trusted Execution Environment) device >> that will be probed by the TEE bus. If the associated Trusted

Re: [PATCH v2 2/4] dt-bindings: remoteproc: Add compatibility for TEE support

2024-01-26 Thread Arnaud POULIQUEN
Hello Krzysztof, On 1/26/24 12:03, Krzysztof Kozlowski wrote: > On 18/01/2024 11:04, Arnaud Pouliquen wrote: >> The "st,stm32mp1-m4-tee" compatible is utilized in a system configuration >> where the Cortex-M4 firmware is loaded by the Trusted execution Environment

Re: [PATCH v2 1/4] remoteproc: Add TEE support

2024-01-26 Thread Arnaud POULIQUEN
Hi Mathieu, On 1/25/24 19:55, Mathieu Poirier wrote: > Hi Arnaud, > > On Thu, Jan 18, 2024 at 11:04:30AM +0100, Arnaud Pouliquen wrote: >> From: Arnaud Pouliquen >> >> Add a remoteproc TEE (Trusted Execution Environment) device > > Device or driver? Seems t

[PATCH v2 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-01-18 Thread Arnaud Pouliquen
defined by the TEE. Signed-off-by: Arnaud Pouliquen --- V1 to V2 update: - remove the select "TEE_REMOTEPROC" in STM32_RPROC config as detected by the kernel test robot: WARNING: unmet direct dependencies detected for TEE_REMOTEPROC Depends on [n]: REMOTEPROC [=y] &a

[PATCH v2 3/4] remoteproc: stm32: Create sub-functions to request shutdown and release

2024-01-18 Thread Arnaud Pouliquen
To prepare for the support of TEE remoteproc, create sub-functions that can be used in both cases, with and without TEE support. Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/stm32_rproc.c | 84 +++- 1 file changed, 51 insertions(+), 33 deletions(-) diff

[PATCH v2 2/4] dt-bindings: remoteproc: Add compatibility for TEE support

2024-01-18 Thread Arnaud Pouliquen
evice tree with the st,stm32mp1-m4-tee to support signed remoteproc firmware. Based on DT properties, OP-TEE authenticates, loads, starts, and stops the firmware. - On Linux, when the compatibility is set, the Cortex-M resets should not be declared in the device tree. Signed-off-by: Arnaud Pouliqu

[PATCH v2 1/4] remoteproc: Add TEE support

2024-01-18 Thread Arnaud Pouliquen
From: Arnaud Pouliquen Add a remoteproc TEE (Trusted Execution Environment) device that will be probed by the TEE bus. If the associated Trusted application is supported on secure part this device offers a client interface to load a firmware in the secure part. This firmware could

[PATCH v2 0/4] Introduction of a remoteproc tee to load signed firmware

2024-01-18 Thread Arnaud Pouliquen
of the ELF image. For more information about the implementation, a presentation is available here (note that the format of the signed image has evolved between the presentation and the integration in OP-TEE). https://resources.linaro.org/en/resource/6c5bGvZwUAjX56fvxthxds Arnaud Pouliquen (4

[PATCH 2/2] remoteproc: stm32: Fix incorrect type assignment returned by stm32_rproc_get_loaded_rsc_tablef

2024-01-17 Thread Arnaud Pouliquen
are then managed by the remoteproc core as a pointer to a resource_table structure. Fixes: 8a471396d21c ("remoteproc: stm32: Move resource table setup to rproc_ops") Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/stm32_rproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/2] remoteproc: stm32: Fix incorrect type in assignment for va

2024-01-17 Thread Arnaud Pouliquen
/oe-kbuild-all/202312150052.hcinklqb-...@intel.com/ Fixes: 13140de09cc2 ("remoteproc: stm32: add an ST stm32_rproc driver") Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/stm32_rproc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/stm

[PATCH 0/2] remoteproc: stm32: Fix sparse warnings

2024-01-17 Thread Arnaud Pouliquen
Fix warnings reported by sparse using make option "C=1" Arnaud Pouliquen (2): remoteproc: stm32: Fix incorrect type in assignment for va remoteproc: stm32: Fix incorrect type assignment returned by stm32_rproc_get_loaded_rsc_tablef drivers/remoteproc/stm32_rproc.c | 6 +++-

Re: [PATCH 0/2] remoteproc: stm32: Fix sparse warnings

2024-01-17 Thread Arnaud POULIQUEN
Hi, On 1/17/24 14:18, Arnaud Pouliquen wrote: > Fix warnings reported by sparse using make option "C=1" > > Arnaud Pouliquen (2): > remoteproc: stm32: Fix incorrect type in assignment for va > remoteproc: stm32: Fix incorrect

[PATCH 1/2] remoteproc: stm32: Fix incorrect type in assignment for va

2024-01-17 Thread Arnaud Pouliquen
/oe-kbuild-all/202312150052.hcinklqb-...@intel.com/ Fixes: 13140de09cc2 ("remoteproc: stm32: add an ST stm32_rproc driver") Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/stm32_rproc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/stm

[PATCH 0/2] remoteproc: stm32: Fix sparse warnings

2024-01-17 Thread Arnaud Pouliquen
Fix warnings reported by sparse using make option "C=1" Arnaud Pouliquen (2): remoteproc: stm32: Fix incorrect type in assignment for va remoteproc: stm32: Fix incorrect type assignment returned by stm32_rproc_get_loaded_rsc_tablef drivers/remoteproc/stm32_rproc.c | 6 +++-

Re: [PATCH 2/4] dt-bindings: remoteproc: add compatibility for TEE support

2024-01-16 Thread Arnaud POULIQUEN
On 1/16/24 20:21, Rob Herring wrote: > On Mon, Jan 15, 2024 at 02:52:47PM +0100, Arnaud Pouliquen wrote: >> The "st,stm32mp1-m4-tee" compatible is utilized in a system configuration >> where the Cortex-M4 firmware is loaded by the Trusted execution Environment >

[PATCH 3/4] remoteproc: stm32: create sub-functions to request shutdown and release

2024-01-15 Thread Arnaud Pouliquen
To prepare for the support of TEE remoteproc, create sub-functions that can be used in both cases, with and without TEE support. Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/stm32_rproc.c | 84 +++- 1 file changed, 51 insertions(+), 33 deletions(-) diff

[PATCH 1/4] remoteproc: Add TEE support

2024-01-15 Thread Arnaud Pouliquen
From: Arnaud Pouliquen Add a remoteproc TEE (Trusted Execution Environment) device that will be probed by the TEE bus. If the associated Trusted application is supported on secure part this device offers a client interface to load a firmware in the secure part. This firmware could

[PATCH 2/4] dt-bindings: remoteproc: add compatibility for TEE support

2024-01-15 Thread Arnaud Pouliquen
tm32mp1-m4-tee to support signed remoteproc firmware. Based on DT properties, OP-TEE authenticates, loads, starts, and stops the firmware. - On Linux, when the compatibility is set, the Cortex-M resets should not be declared in the device tree. Signed-off-by: Arnaud Pouliquen --- ..

[PATCH 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-01-15 Thread Arnaud Pouliquen
defined by the TEE. Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/Kconfig | 3 +- drivers/remoteproc/stm32_rproc.c | 149 +-- 2 files changed, 146 insertions(+), 6 deletions(-) diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig index

[PATCH 0/4] Introduction of a remoteproc tee to load signed firmware

2024-01-15 Thread Arnaud Pouliquen
://resources.linaro.org/en/resource/6c5bGvZwUAjX56fvxthxds Arnaud Pouliquen (4): remoteproc: Add TEE support dt-bindings: remoteproc: add compatibility for TEE support remoteproc: stm32: create sub-functions to request shutdown and release remoteproc: stm32: Add support of an OP-TEE TA to load

Re: [PATCH V3] remoteproc: virtio: Fix wdg cannot recovery remote processor

2024-01-09 Thread Arnaud POULIQUEN
ate buffer again. > > Releasing reserved memory from rproc_virtio_dev_release(), instead of > rproc_virtio_remove(). > > Fixes: 1d7b61c06dc3 ("remoteproc: virtio: Create platform device for the > remoteproc_virtio") > Signed-off-by: Joakim Zhang

Re: [PATCH V2] remoteproc: virtio: Fix wdg cannot recovery remote processor

2023-12-15 Thread Arnaud POULIQUEN
Hello Joakim, On 12/15/23 15:50, joakim.zh...@cixtech.com wrote: > From: Joakim Zhang > > Recovery remote processor failed when wdg irq received: > [0.842574] remoteproc remoteproc0: crash detected in cix-dsp-rproc: type > watchdog > [0.842750] remoteproc remoteproc0: handling crash

[PATCH] remoteproc: stm32: fix mbox_send_message call

2021-04-20 Thread Arnaud Pouliquen
comments are removed because rproc should not have to deal with the behavior of the mailbox frame. Reported-by: Bjorn Andersson Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/stm32_rproc.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/remoteproc

Re: [PATCH v4 2/2] remoteproc: stm32: add capability to detach

2021-04-14 Thread Arnaud POULIQUEN
Hello Bjorn On 4/13/21 11:34 PM, Bjorn Andersson wrote: > On Wed 31 Mar 02:33 CDT 2021, Arnaud Pouliquen wrote: > >> A mechanism similar to the shutdown mailbox signal is implemented to >> detach a remote processor. >> >> Upon detachment, a signal is sent to

[PATCH v2 4/7] rpmsg: char: Introduce __rpmsg_chrdev_create_eptdev function

2021-04-13 Thread Arnaud Pouliquen
Introduce the __rpmsg_chrdev_create_eptdev internal function that returns the rpmsg_eptdev context structure. This patch prepares the introduction of a rpmsg channel device for the char device. The rpmsg device will need a reference to the context. Signed-off-by: Arnaud Pouliquen --- update

[PATCH v2 5/7] rpmsg: char: Introduce a rpmsg driver for the rpmsg char device

2021-04-13 Thread Arnaud Pouliquen
A rpmsg char device allows to probe the endpoint device on a remote name service announcement. With this patch the /dev/rpmsgX interface is created either by a user application or by the remote firmware. Signed-off-by: Arnaud Pouliquen --- update from V1: - add missing unregister_rpmsg_driver

[PATCH v2 2/7] rpmsg: Move the rpmsg control device from rpmsg_char to rpmsg_ctrl

2021-04-13 Thread Arnaud Pouliquen
Create the rpmsg_ctrl.c module and move the code related to the rpmsg_ctrldev device in this new module. Add the dependency between rpmsg_char and rpmsg_ctrl in the kconfig file. Signed-off-by: Arnaud Pouliquen --- update from v1: - keep "rpmsg_chrdev" driver name in rpmsg_ct

[PATCH v2 1/7] rpmsg: char: Export eptdev create an destroy functions

2021-04-13 Thread Arnaud Pouliquen
is provided as parameter in rpmsg_chrdev_create_eptdev, because the class is associated to the control part. Suggested-by: Mathieu Poirier Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_char.c | 19 +-- drivers/rpmsg/rpmsg_char.h | 50 ++ 2

[PATCH v2 0/7] Restructure the rpmsg char and introduce the rpmsg-raw channel

2021-04-13 Thread Arnaud Pouliquen
k.kernel.org/project/linux-remoteproc/list/?series=453805 [2]: https://patchwork.kernel.org/project/linux-remoteproc/list/?series=435523 Arnaud Pouliquen (7): rpmsg: char: Export eptdev create an destroy functions rpmsg: Move the rpmsg control device from rpmsg_char to rpmsg_

[PATCH v2 6/7] rpmsg: char: No dynamic endpoint management for the default one

2021-04-13 Thread Arnaud Pouliquen
Do not dynamically manage the default endpoint associated to the rpmsg device. The ept address must not change. This update is needed to manage the rpmsg-raw channel. In this case a default endpoint is used and its address must not change or been reused by another service. Signed-off-by: Arnaud

[PATCH v2 7/7] rpmsg: char: Return error if user tries to destroy a default endpoint.

2021-04-13 Thread Arnaud Pouliquen
he channel does not make sense. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_char.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c index fa59abfa8878..d4316bb904f2 100644 --- a/drivers/rpmsg/rpmsg_char.c +++ b/dri

[PATCH v2 3/7] rpmsg: Update rpmsg_chrdev_register_device function

2021-04-13 Thread Arnaud Pouliquen
prefix. The platform drivers are updated accordingly. Signed-off-by: Arnaud Pouliquen --- update from v1 - move the rename of the rpmsg_ctrl driver from previous patch to this one. --- drivers/rpmsg/qcom_glink_native.c | 2 +- drivers/rpmsg/qcom_smd.c | 2 +- drivers/rpmsg/rpmsg_ctrl.c

Re: [PATCH 0/7] Restructure the rpmsg char and introduce the rpmsg-raw channel

2021-04-13 Thread Arnaud POULIQUEN
Hello Mathieu, On 4/12/21 10:02 PM, Mathieu Poirier wrote: > On Tue, Mar 23, 2021 at 01:27:30PM +0100, Arnaud Pouliquen wrote: >> This series is the second step in the division of the series [1]: >> "Introducing a Generic IOCTL Interface for RPMsg Channel Management

Re: [PATCH -next] ASoC: sti: sti_uniperif: add missing MODULE_DEVICE_TABLE

2021-04-09 Thread Arnaud POULIQUEN
On 4/9/21 3:59 AM, Chen Lifu wrote: > This patch adds missing MODULE_DEVICE_TABLE definition which generates > correct modalias for automatic loading of this driver when it is built > as an external module. > > Reported-by: Hulk Robot > Signed-off-by: Chen Lifu Reviewed-by

[PATCH v4 2/2] remoteproc: stm32: add capability to detach

2021-03-31 Thread Arnaud Pouliquen
processor to restart in case of crash. Signed-off-by: Arnaud Pouliquen Reviewed-by: Mathieu Poirier Tested-by: Mathieu Poirier --- drivers/remoteproc/stm32_rproc.c | 39 ++-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/stm32_rproc.c

[PATCH v4 0/2] remoteproc: stm32: add support of detaching a remote processor

2021-03-31 Thread Arnaud Pouliquen
. Applied and tested on Bjorn's "for_next" branch (2b81aa17008e) [1] https://patchwork.kernel.org/project/linux-remoteproc/list/?series=447171 Arnaud Pouliquen (2): dt-bindings: remoteproc: stm32-rproc: add new mailbox channel for detach remoteproc: stm32: add capability to detach ..

[PATCH v4 1/2] dt-bindings: remoteproc: stm32-rproc: add new mailbox channel for detach

2021-03-31 Thread Arnaud Pouliquen
Add the "detach" mailbox item, that allows to define a mailbox to send a IPCC signal to the remote processor on remoteproc detach action. Signed-off-by: Arnaud Pouliquen Reviewed-by: Rob Herring --- .../bindings/remoteproc/st,stm32-rproc.yaml | 11 +-- 1 file

Re: [PATCH v2 1/2] dt-bindings: remoteproc: stm32-rproc: add new mailbox channel for detach

2021-03-31 Thread Arnaud POULIQUEN
On 3/30/21 4:41 PM, Rob Herring wrote: > On Mon, 22 Mar 2021 10:26:50 +0100, Arnaud Pouliquen wrote: >> Add the "detach" mailbox item, that allows to define a mailbox to >> send a IPCC signal to the remote processor on remoteproc detach action. >> >

Re: [PATCH v3 1/2] dt-bindings: remoteproc: stm32-rproc: add new mailbox channel for detach

2021-03-30 Thread Arnaud POULIQUEN
Hello Rob, Seems I made a mistake in my mailing list, you are not in... Please could you review the bindings? if it is easier for you i can resend the series. Thanks, Arnaud On 3/26/21 10:42 AM, Arnaud Pouliquen wrote: > Add the "detach" mailbox item, that allows to define a mail

RE: [PATCH 08/17] ASoC: sti: sti_uniperif: add missing error check

2021-03-29 Thread Arnaud POULIQUEN
> -Original Message- > From: Pierre-Louis Bossart > Sent: vendredi 26 mars 2021 22:59 > To: alsa-de...@alsa-project.org > Cc: ti...@suse.de; broo...@kernel.org; linux-kernel@vger.kernel.org; Pierre- > Louis Bossart ; Arnaud POULIQUEN > ; Liam Girdwood ; > Jarosl

RE: [PATCH 09/17] ASoC: sti: uniperif: align function prototypes

2021-03-29 Thread Arnaud POULIQUEN
Hi, > -Original Message- > From: Pierre-Louis Bossart > Sent: vendredi 26 mars 2021 22:59 > To: alsa-de...@alsa-project.org > Cc: ti...@suse.de; broo...@kernel.org; linux-kernel@vger.kernel.org; Pierre- > Louis Bossart ; Arnaud POULIQUEN > ; Liam Girdwood ; > J

[PATCH v3 1/2] dt-bindings: remoteproc: stm32-rproc: add new mailbox channel for detach

2021-03-26 Thread Arnaud Pouliquen
Add the "detach" mailbox item, that allows to define a mailbox to send a IPCC signal to the remote processor on remoteproc detach action. Signed-off-by: Arnaud Pouliquen --- No Update from V2. Update from V1: Fix indentation error reported by 'make dt_binding_check'. --- ..

[PATCH v3 0/2] remoteproc: stm32: add support of detaching a remote processor

2021-03-26 Thread Arnaud Pouliquen
on Bjorn's "for_next" branch (2b81aa17008e) [1] https://patchwork.kernel.org/project/linux-remoteproc/list/?series=447171 Arnaud Pouliquen (2): dt-bindings: remoteproc: stm32-rproc: add new mailbox channel for detach remoteproc: stm32: add capability to detach .../bindings/rem

[PATCH v3 2/2] remoteproc: stm32: add capability to detach

2021-03-26 Thread Arnaud Pouliquen
processor to restart in case of crash. Signed-off-by: Arnaud Pouliquen Reviewed-by: Mathieu Poirier Tested-by: Mathieu Poirier --- drivers/remoteproc/stm32_rproc.c | 39 ++-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/stm32_rproc.c

Re: [PATCH v2 2/2] remoteproc: stm32: add capability to detach

2021-03-24 Thread Arnaud POULIQUEN
Hi Mathieu, On 3/23/21 10:19 PM, Mathieu Poirier wrote: > Good day Arnaud, > > On Mon, Mar 22, 2021 at 10:26:51AM +0100, Arnaud Pouliquen wrote: >> From: Arnaud Pouliquen >> >> A mechanism similar to the shutdown mailbox signal is implemented to >> deta

[PATCH 5/7] rpmsg: char: Introduce a rpmsg driver for the rpmsg char device

2021-03-23 Thread Arnaud Pouliquen
A rpmsg char device allows to probe the endpoint device on a remote name service announcement. With this patch the /dev/rpmsgX interface is created either by a user application or by the remote firmware. Signed-off-by: Arnaud Pouliquen --- drivers/rpmsg/rpmsg_char.c | 58

[PATCH 4/7] rpmsg: char: Introduce __rpmsg_chrdev_create_eptdev function

2021-03-23 Thread Arnaud Pouliquen
Introduce the __rpmsg_chrdev_create_eptdev internal function that returns the rpmsg_eptdev context structure. This patch prepares the introduction of a rpmsg channel device for the char device. The rpmsg device will need a reference to the context. Signed-off-by: Arnaud Pouliquen --- update

  1   2   3   4   5   6   >