[GIT PULL] chrome-platform changes for v5.12

insertions(+), 79 deletions(-) -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH] platform/chrome: cros_ec_typec: Flush pending work

hanks! [1/1] platform/chrome: cros_ec_typec: Flush pending work commit: a59e12218c4f5498d5669a0ee0c725101ca89d52 Best regards, -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH 0/2] Add support for Type-C mux events without port partners

n configure_mux() commit: 38f56061c892c237ad4ee733cf3981a84f6b6aea [2/2] platform/chrome: cros_ec_types: Support disconnect events without partners commit: b4b06c97729547d03a8f49c6774c8bd69150ea4d Best regards, -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@goog

[GIT PULL] Fix for cros_ec_typec for USB for v5.12 merge window

/platform_data/cros_ec_commands.h | 26 +++ 2 files changed, 52 insertions(+), 3 deletions(-) -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH v2 1/2] platform/chrome: cros_ec: Import Type C control command

ec-clear-pd-discovery-events-after-handled I will send a PR to Greg for these too. Best regards, -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH v2 1/2] platform/chrome: cros_ec: Import Type C control command

c events commit: d521119c8b0d70b91971d632430ec1143e5d2e26 Best regards, -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH] platform/chrome: cros_ec_typec: Decouple partner removal

t; > Update the check to remove a partner if one was registered, but continue > after that instead of returning. Applied to for-kernelci, thanks! [1/1] platform/chrome: cros_ec_typec: Decouple partner removal commit: d9f12f9e6c3695c32e681e9d266c4dc1c9016f66 Best regards, -- Benson Le

Re: [PATCH v5 2/8] usb: pd: Update VDO definitions

efine ACAB2_U3U0_U3S 1 > +#define ACAB2_PHY_COPPER 0 > +#define ACAB2_PHY_OPTICAL 1 > +#define ACAB2_REDRIVER 0 > +#define ACAB2_RETIMER 1 > +#define ACAB2_USB4_SUPP0 > +#define ACAB2_USB4_NOT_SUPP1 > +#define ACAB2_USB2_SUPP0 > +#define ACAB2_USB2_NOT_SUPP1 > +#define ACAB2_USB32_SUPP 0 > +#define ACAB2_USB32_NOT_SUPP 1 > +#define ACAB2_LANES_ONE0 > +#define ACAB2_LANES_TWO1 > +#define ACAB2_OPT_ISO_NO 0 > +#define ACAB2_OPT_ISO_YES 1 > +#define ACAB2_GEN_10 > +#define ACAB2_GEN_2_PLUS 1 > + > +#define VDO_ACABLE2(mtemp, stemp, u3p, trans, phy, ele, u4, hops, u2, u32, > lane, iso, gen) \ > + (((mtemp) & 0xff) << 24 | ((stemp) & 0xff) << 16 | ((u3p) & 0x7) << > 12 \ > +| (trans) << 11 | (phy) << 10 | (ele) << 9 | (u4) << 8 > \ > +| ((hops) & 0x3) << 6 | (u2) << 5 | (u32) << 4 | (lane) << 3 > \ > +| (iso) << 2 | (gen)) > > -#define AMA_VCONN_PWR_1W 0 > -#define AMA_VCONN_PWR_1W5 1 > -#define AMA_VCONN_PWR_2W 2 > -#define AMA_VCONN_PWR_3W 3 > -#define AMA_VCONN_PWR_4W 4 > -#define AMA_VCONN_PWR_5W 5 > -#define AMA_VCONN_PWR_6W 6 > -#define AMA_USBSS_U2_ONLY 0 > -#define AMA_USBSS_U31_GEN1 1 > -#define AMA_USBSS_U31_GEN2 2 > -#define AMA_USBSS_BBONLY 3 > +/* > + * VPD VDO > + * - > + * <31:28> :: HW version > + * <27:24> :: FW version > + * <23:21> :: VDO version > + * <20:17> :: Reserved, Shall be set to zero > + * <16:15> :: Maximum Vbus voltage (00b == 20V, 01b == 30V, 10b == 40V, 11b > == 50V) > + * <14>:: Charge through current support (0b == 3A, 1b == 5A) > + * <13>:: Reserved, Shall be set to zero > + * <12:7> :: Vbus impedance > + * <6:1> :: Ground impedance > + * <0> :: Charge through support (0b == no, 1b == yes) > + */ > +#define VPD_VDO_VER1_0 0 > +#define VPD_MAX_VBUS_20V 0 > +#define VPD_MAX_VBUS_30V 1 > +#define VPD_MAX_VBUS_40V 2 > +#define VPD_MAX_VBUS_50V 3 > +#define VPDCT_CURR_3A 0 > +#define VPDCT_CURR_5A 1 > +#define VPDCT_NOT_SUPP 0 > +#define VPDCT_SUPP 1 > + > +#define VDO_VPD(hw, fw, ver, vbm, curr, vbi, gi, ct) \ > + (((hw) & 0xf) << 28 | ((fw) & 0xf) << 24 | ((ver) & 0x7) << 21 \ > +| ((vbm) & 0x3) << 15 | (curr) << 14 | ((vbi) & 0x3f) << 7 \ > +| ((gi) & 0x3f) << 1 | (ct)) > > /* > * SVDM Discover SVIDs request -> response > -- > 2.30.0.365.g02bc693789-goog > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org

Re: linux-next: build warning after merge of the usb tree

g/r/20210202095512.761214-1-kyle...@google.com, already in Greg's usb-testing. Thanks Kyle for the quick fix yesterday. Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH v2] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision

On Tue, Feb 02, 2021 at 07:30:06PM +0100, Greg KH wrote: > On Tue, Feb 02, 2021 at 09:52:13AM -0800, Benson Leung wrote: > > Hi Greg, > > > > On Tue, Feb 2, 2021 at 9:02 AM Greg KH wrote: > > > > > > On Tue, Feb 02, 2021

Re: [PATCH v2] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision

Hi Greg, On Tue, Feb 2, 2021 at 9:02 AM Greg KH wrote: > > On Tue, Feb 02, 2021 at 08:45:31AM -0800, Benson Leung wrote: > > typec_partner_set_pd_revision returns void now. > > > > Fixes: cefc011f8daf ("platform/chrome: cros_ec_typec: Set Partner PD > > re

Re: [PATCH] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision

On Tue, Feb 02, 2021 at 05:37:36PM +0100, Greg KH wrote: > On Tue, Feb 02, 2021 at 08:32:48AM -0800, Benson Leung wrote: > > typec_partner_set_pd_revision returns void now. > > > > Fixes: cefc011f8daf platform/chrome: cros_ec_typec: Set Partner PD revision > > from sta

[PATCH v2] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision

typec_partner_set_pd_revision returns void now. Fixes: cefc011f8daf ("platform/chrome: cros_ec_typec: Set Partner PD revision from status") Signed-off-by: Benson Leung --- drivers/platform/chrome/cros_ec_typec.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

Re: [PATCH] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision

Hi Greg, On Tue, Feb 02, 2021 at 08:32:48AM -0800, Benson Leung wrote: > typec_partner_set_pd_revision returns void now. > > Fixes: cefc011f8daf platform/chrome: cros_ec_typec: Set Partner PD revision > from status > Signed-off-by: Benson Leung This one needs to be taken too a

[PATCH] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision

typec_partner_set_pd_revision returns void now. Fixes: cefc011f8daf platform/chrome: cros_ec_typec: Set Partner PD revision from status Signed-off-by: Benson Leung --- drivers/platform/chrome/cros_ec_typec.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers

Re: [PATCH] usb: typec: Return void in typec_partner_set_pd_revision

On Tue, Feb 02, 2021 at 04:09:13PM +0100, Greg KH wrote: > On Tue, Feb 02, 2021 at 07:02:52AM -0800, Benson Leung wrote: > > Hi Kyle, > > > > On Tue, Feb 02, 2021 at 05:55:12PM +0800, Kyle Tso wrote: > > > typec_partner_set_pd_revision doesn't need any re

Re: [PATCH] usb: typec: Return void in typec_partner_set_pd_revision

; }; > > -int typec_partner_set_pd_revision(struct typec_partner *partner, u16 > pd_revision); > +void typec_partner_set_pd_revision(struct typec_partner *partner, u16 > pd_revision); > int typec_partner_set_num_altmodes(struct typec_partner *partner, int > num_altmodes); > struct typec_altmod

[GIT PULL] Immutable Branch between platform/chrome and USB for v5.12 merge window

a new host command * Reporting SOP' and Partner PD revisions Benson Leung (4): Merge remote-tracking branch 'origin/cros-ec-typec-for-5.12' into ib-usb-typec-chrome-platform-cros-ec-typec-changes-for-5.12 platform/chrome

Re: [PATCH 0/6] usb: typec: and platform/chrome: Add PD revision numbers

Hi Greg, On Mon, Feb 01, 2021 at 03:32:47PM +0100, Greg KH wrote: > On Thu, Jan 28, 2021 at 10:14:00PM -0800, Benson Leung wrote: > > USB Power Delivery has a 3 entity handshake (port, cable, partner), and as > > of USB PD R3.0, each entity may independently support ei

[PATCH 4/6] platform/chrome: cros_ec_typec: Report SOP' PD revision from status

cros_typec_handle_sop_prime_disc now takes the PD revision provided by the EC_CMD_TYPEC_STATUS command response for the SOP'. Attach the properly formatted pd_revision to the cable desc before registering the cable. Signed-off-by: Benson Leung --- drivers/platform/chrome/cros_ec_typec.c | 9

[PATCH 1/6] usb: typec: Standardize PD Revision format with Type-C Revision

: - "2.0": USB Power Delivery Release 2.0 - "3.0": USB Power Delivery Release 3.0 - "3.1": USB Power Delivery Release 3.1 Signed-off-by: Benson Leung --- Documentation/ABI/testing/sysfs-class-typec | 7 ++- drivers/usb/typec/class.c | 3 ++- 2 fi

[PATCH 6/6] platform/chrome: cros_ec_typec: Set opmode to PD on SOP connected

When SOP Discovery is done, set the opmode to PD if status indicates SOP is connected. SOP connected indicates a PD contract is in place, and is a solid indication we have transitioned to PD power negotiation, either as source or sink. Signed-off-by: Benson Leung --- drivers/platform/chrome

[PATCH 2/6] usb: typec: Provide PD Specification Revision for cable and partner

independently. Signed-off-by: Benson Leung --- Documentation/ABI/testing/sysfs-class-typec | 13 + drivers/usb/typec/class.c | 30 ++--- include/linux/usb/typec.h | 10 +++ 3 files changed, 49 insertions(+), 4 deletions(-) diff --git

[PATCH 5/6] platform/chrome: cros_ec_typec: Set Partner PD revision from status

Status provides sop_revision. Process it, and set it using the new setter in the typec class. Signed-off-by: Benson Leung --- drivers/platform/chrome/cros_ec_typec.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_typec.c b

[PATCH 3/6] usb: typec: Add typec_partner_set_pd_revision

it becomes available. If the revision is set to a valid version (not 0), the setter will also refresh the partner's usb_pd flag and notify on "supports_usb_power_delivery" sysfs property as well. Signed-off-by: Benson Leung --- drivers/usb/typec/class.c | 30 +

[PATCH 0/6] usb: typec: and platform/chrome: Add PD revision numbers

status messages convey the SOP and SOP' revisions already. Thanks, Benson Benson Leung (6): usb: typec: Standardize PD Revision format with Type-C Revision usb: typec: Provide PD Specification Revision for cable and partner usb: typec: Add typec_partner_set_pd_revision platform/chrome

Re: [PATCH v2 1/2] power: supply: PCHG: Peripheral device charger

mmands.h > +++ b/include/linux/platform_data/cros_ec_commands.h > @@ -4225,6 +4225,7 @@ enum ec_device_event { > EC_DEVICE_EVENT_TRACKPAD, > EC_DEVICE_EVENT_DSP, > EC_DEVICE_EVENT_WIFI, > + EC_DEVICE_EVENT_WLC, > }; > > enum ec_device_event_param { > @@ -5456,6 +5457,53 @@ struct ec_response_rollback_info { > /* Issue AP reset */ > #define EC_CMD_AP_RESET 0x0125 > > +/** > + * Get the number of peripheral charge ports > + */ > +#define EC_CMD_PCHG_COUNT 0x0134 > + > +#define EC_PCHG_MAX_PORTS 8 > + > +struct ec_response_pchg_count { > + uint8_t port_count; > +} __ec_align1; > + > +/** > + * Get the status of a peripheral charge port > + */ > +#define EC_CMD_PCHG 0x0135 > + > +struct ec_params_pchg { > + uint8_t port; > +} __ec_align1; > + > +struct ec_response_pchg { > + uint32_t error; /* enum pchg_error */ > + uint8_t state; /* enum pchg_state state */ > + uint8_t battery_percentage; > +} __ec_align2; > + > +enum pchg_state { > + /* Charger is reset and not initialized. */ > + PCHG_STATE_RESET = 0, > + /* Charger is initialized or disabled. */ > + PCHG_STATE_INITIALIZED, > + /* Charger is enabled and ready to detect a device. */ > + PCHG_STATE_ENABLED, > + /* Device is detected in proximity. */ > + PCHG_STATE_DETECTED, > + /* Device is being charged. */ > + PCHG_STATE_CHARGING, > +}; > + > +#define EC_PCHG_STATE_TEXT { \ > + [PCHG_STATE_RESET] = "RESET", \ > + [PCHG_STATE_INITIALIZED] = "INITIALIZED", \ > + [PCHG_STATE_ENABLED] = "ENABLED", \ > + [PCHG_STATE_DETECTED] = "DETECTED", \ > + [PCHG_STATE_CHARGING] = "CHARGING", \ > + } > + > > /*/ > /* Locate peripheral chips > * > -- > 2.29.2.684.gfbc64c5ab5-goog > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH 2/2] platform/chrome: cros_ec_typec: Send mux configuration acknowledgment to EC

t_code % 32) > @@ -6054,6 +6064,13 @@ struct ec_params_charger_control { > uint8_t allow_charging; > } __ec_align_size1; > > +/* Get ACK from the USB-C SS muxes */ > +#define EC_CMD_USB_PD_MUX_ACK 0x0603 > + > +struct ec_params_usb_pd_mux_ack { > + uint8_t port; /* USB-C port number */ > +} __ec_align1; > + > > /*/ > /* > * Reserve a range of host commands for board-specific, experimental, or > -- > 2.25.1 > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH 2/2] platform/chrome: cros_ec_typec: Send mux configuration acknowledgment to EC

but the change here is well contained, so it minimally adds to the delta between the EC codebase's header and the kernel's. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH 0/2] Send acknowledgment to ec from cors_ec_typec

4e1fc5e73ff8989c18c596a3449fef [2/2] platform/chrome: cros_ec_typec: Send mux configuration acknowledgment to EC commit: 8553a979fcd03448a4096c7d431b7ee1a52bfca3 Best regards, -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project bl

Re: [PATCH v3 00/11] chrome/platform: cros_ec_typec: Register cables, partner altmodes and plug altmodes

plug (no commit info) [11/11] platform/chrome: cros_ec_typec: Register plug altmodes (no commit info) Best regards, -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

[GIT PULL] chrome-platform changes for v5.11

/platform/chrome/cros_ec_proto.c| 14 +- drivers/platform/chrome/cros_ec_typec.c| 336 +++-- include/linux/platform_data/cros_ec_commands.h | 155 3 files changed, 427 insertions(+), 78 deletions(-) -- Benson Leung Staff Software Engineer Chrome OS

Re: [PATCH v2] usb: typec: Add class for plug alt mode device

> Signed-off-by: Prashant Malani > Cc: Heikki Krogerus Reviewed-by: Benson Leung > --- > > Changes in v2: > - Changed code to set the class member instead of bus. > - Removed the alteration to typec_bus.rst since it's not longer > required. > - Updated the commit me

Re: [PATCH] platform/chrome: cros_ec_typec: Tolerate unrecognized mux flags

not pollute the kernel logs. Applied, thanks! [1/1] platform/chrome: cros_ec_typec: Tolerate unrecognized mux flags commit: 6ae9b5ffcaeba64c290dfb8bd7b0194b1fdf0c92 Best regards, -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS

Re: [RFC PATCH 2/3] usb: typec: Add product_type sysfs attribute file for partners and cables

return is_typec_partner(dev); > +} > + > /** > * typec_set_data_role - Report data role change > * @port: The USB Type-C Port where the role was changed > @@ -1361,12 +1473,23 @@ const struct device_type typec_port_dev_type = { > */ > void typec_set_data_role(struct typec_port *port, enum typec_data_role role) > { > + struct device *partner_dev; > + > if (port->data_role == role) > return; > > port->data_role = role; > sysfs_notify(>dev.kobj, NULL, "data_role"); > kobject_uevent(>dev.kobj, KOBJ_CHANGE); > + > + partner_dev = device_find_child(>dev, NULL, partner_match); > + if (!partner_dev) > + return; > + > + if (to_typec_partner(partner_dev)->identity) > + typec_product_type_notify(partner_dev); > + > + put_device(partner_dev); > } > EXPORT_SYMBOL_GPL(typec_set_data_role); > > @@ -1407,11 +1530,6 @@ void typec_set_vconn_role(struct typec_port *port, > enum typec_role role) > } > EXPORT_SYMBOL_GPL(typec_set_vconn_role); > > -static int partner_match(struct device *dev, void *data) > -{ > - return is_typec_partner(dev); > -} > - > /** > * typec_set_pwr_opmode - Report changed power operation mode > * @port: The USB Type-C Port where the mode was changed > -- > 2.29.2 > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH v2 5/6] usb: pd: Add captive Type C cable type

; > Add the corresponding definition to the Cable VDO header. Also add a > helper macro to get the Type C cable connector type, when provided > the cable VDO. > > Cc: Heikki Krogerus > Signed-off-by: Prashant Malani Reviewed-by: Benson Leung Looks good, to modify the Cable VDO d

Re: [PATCH 07/20] input: keyboard: cros_ec_keyb: Struct headers should start with 'struct '

Hi Lee, On Wed, Nov 04, 2020 at 04:24:14PM +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/input/keyboard/cros_ec_keyb.c:72: warning: cannot understand > function prototype: 'struct cros_ec_bs_map ' > > Cc: Dmitry Torokhov > C

Re: [PATCH 02/20] input: mouse: cyapa: Fix misnaming of 'cyapa_i2c_write's 'reg' param

warning: Excess function parameter 'ret' > description in 'cyapa_i2c_write' > > Cc: Dmitry Torokhov > Cc: Henrik Rydberg > Cc: Dudley Du > Cc: Daniel Kurtz > Cc: Benson Leung > Cc: linux-in...@vger.kernel.org > Signed-off-by: Lee Jones Reviewed-by: Benson Leung > -

[PATCH] typec: Provide USB PD Specification Revision for cable and partner

independently. This will also enable future changes which change cable identifier decoding and visible sysfs nodes based on revision 2 or 3. Signed-off-by: Benson Leung --- Documentation/ABI/testing/sysfs-class-typec | 8 + drivers/usb/typec/class.c | 38

Re: [PATCH v2] usb: typec: Expose Product Type VDOs via sysfs

livery/document/10967). Since the different spec versions need to all be supported (since the firmware of PD devices are baked for a particular version of the PD spec at the time they are released and don't change in practice), the software on USB PD hosts should provide these objects up to the n

[GIT PULL] chrome-platform changes for v5.10

--- 11 files changed, 154 insertions(+), 115 deletions(-) -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH] usb: typec: Expose Product Type VDOs via sysfs

. > > Cc: Benson Leung > Cc: Heikki Krogerus > Signed-off-by: Prashant Malani Reviewed-by: Benson Leung > --- > drivers/usb/typec/class.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.

[GIT PULL] chrome-platform changes for v5.9

(-) -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

[GIT PULL] chrome-platform changes for v5.8

Benson Leung (1): Merge remote-tracking branch 'origin/chrome-platform-5.7-fixes' into for-kernelci Bernardo Perez Priego (1): platform/chrome: wilco_ec: Provide correct output format to 'h1_gpio' file Christophe JAILLET (1

Re: [PATCH] usb: typec: mux: intel: Fix DP_HPD_LVL bit field

eld is changing, explicitly define a field for the > HPD_HIGH mode data bit. > > Signed-off-by: Prashant Malani > Fixes: 6701adfa9693 ("usb: typec: driver for Intel PMC mux control") Reviewed-by: Benson Leung > --- > drivers/usb/typec/mux/intel_pmc_mux.c | 6 +

[GIT PULL] chrome-platform fixes for v5.7-rc5

/platform/chrome/cros_ec_sensorhub.c | 80 ++-- drivers/platform/chrome/cros_ec_sensorhub_ring.c | 73 + include/linux/platform_data/cros_ec_sensorhub.h | 1 + 3 files changed, 93 insertions(+), 61 deletions(-) -- Benson Leung Staff Software Engineer

Re: [PATCH 1/2] dt-bindings: chrome: Add cros-ec-typec mux props

to USB PD > information (like orientation, alt mode etc.) provided by the Chrome OS > EC controller. > > Signed-off-by: Prashant Malani Acked-By: Benson Leung Thanks, Benson > --- > .../bindings/chrome/google,cros-ec-typec.yaml | 27 ++- > 1 file changed

Re: [PATCH] platform/chrome: cros_usbpd_logger: Add __printf annotation to append_str()

ros_usbpd_logger.c > @@ -46,6 +46,7 @@ static const char * const fault_names[] = { > "---", "OCP", "fast OCP", "OVP", "Discharge" > }; > > +__printf(3, 4) > static int append_str(char *buf, int pos, const char *fmt, ...)

Re: [PATCH] platform/chrome: cros_ec_i2c: Appease the kernel-doc deity

ex 6119eccd8a18..30c8938c27d5 100644 > --- a/drivers/platform/chrome/cros_ec_i2c.c > +++ b/drivers/platform/chrome/cros_ec_i2c.c > @@ -16,7 +16,7 @@ > > #include "cros_ec.h" > > -/** > +/* > * Request format for protocol v3 > * byte 00xda (EC_COMMAND_PROT

Re: [PATCH -next] platform/chrome: wilco_ec: Use kmemdup in enqueue_events()

return -ENOMEM; > > - memcpy(queue_event, event, event_size); > > event_queue_push(dev_data->events, queue_event); > > } > > > > > > Looks like this was already incorporated into your commit, platform/chrome: wilco_ec: Use kmemdup in enqueue_events(). Thanks! Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org

Re: [PATCH v5] platform/chrome: wilco_ec: Add debugfs test_event file

ommon helper between h1_gpio_get and test_event_set. > > Signed-off-by: Daniel Campello LGTM. Reviewed-by: Benson Leung Merge window is open right now for v5.4, so we can't quite merge this change for chrome-platform-5.5 yet. Enric, can you queue this for the next branch if you have no o

Re: [PATCH v4] platform/chrome: wilco_ec: Add debugfs test_event file

d in core.c > @@ -226,6 +250,8 @@ static int wilco_ec_debugfs_probe(struct platform_device > *pdev) > debugfs_create_file("raw", 0644, debug_info->dir, NULL, _raw); > debugfs_create_file("h1_gpio", 0444, debug_info->dir, ec, > _h1_gpio); > + debugfs_create_file("test_event", 0200, debug_info->dir, ec, > + _test_event); > > return 0; > } > -- > 2.23.0.237.gc6a4ce50a0-goog > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

[GIT PULL] chrome-platform changes for v5.4

to receive MKBP events * Misc: - bugfixes in cros_usbpd_logger and cros_ec_ishtp Benson Leung (1): Merge tag 'tag-chrome-platform-fixes-for-v5.3-rc6' into for-next Enric Balletbo i Serra (12): mfd / platform: cros_ec

[GIT PULL] chrome-platform fixes for v5.3-rc6

changed, 2 insertions(+), 2 deletions(-) -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH] iio: cros_ec_accel_legacy: Always release lock when returning from _read()

h the end of cros_ec_accel_legacy_read. > default: > return -EINVAL; > } > -- > 2.22.0.510.g264f2c817a-goog > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

[GIT PULL] chrome-platform changes for v5.3

/cros_ec_lpc_reg.h create mode 100644 drivers/platform/chrome/wilco_ec/event.c create mode 100644 drivers/platform/chrome/wilco_ec/properties.c create mode 100644 drivers/platform/chrome/wilco_ec/sysfs.c create mode 100644 drivers/platform/chrome/wilco_ec/telemetry.c -- Benson Leung Staff Software

Re: [PATCH][next] platform/chrome: wilco_ec: fix null pointer dereference on failed kzalloc

ueue_new(queue_size); > + if (!dev_data->events) { > + kfree(dev_data); > + error = -ENOMEM; > + goto free_minor; > + } > init_waitqueue_head(_data->wq); > dev_data->exist = true; > atomic_set(_data->available, 1); > -- > 2.20.1 > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH][next] platform/chrome: wilco_ec: fix null pointer dereference on failed kzalloc

Hi Nick, On Tue, Jun 18, 2019 at 11:15:03AM -0600, Nick Crews wrote: > Thanks Colin, good catch. > > Enric, could you squash this into the real commit? I've applied this to for-next and for-kernelci in chrome-platform. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome

Re: linux-next: Signed-off-by missing for commits in the chrome-platform tree

s_ec: add ec_align macros") > bf96c5f1276c ("mfd: cros_ec: set comments properly") > 6b854d5fbda9 ("mfd: cros_ec: Zero BUILD_ macro") > 5a0d32c91830 ("mfd: cros_ec: Update license term") > > are missing a Signed-off-by from their committer. > > These were all rebased. > Yup, Enric and I caught this this morning. You're right, this was an inadvertent rebase. We'll fix the for-next branch for tomorrow. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH] Input: cros_ec_keyb: mask out extra flags in event_type

eviewed-by: Benson Leung Looks good for chrome-platform, once ib-mfd-cros-v5.3 is merged. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH] Input: cros_ec_keyb: mask out extra flags in event_type

30f mfd: cros_ec: Fix event processing API That commit is in the immutable branch for v5.3 here: git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-cros-v5.3 I'd recommend the chrome-platform tree since we'll be pulling in that IB too for some other refactoring Enric is working on. Thanks, Benson

Re: [PATCH v9 5/7] dt-bindings: Add binding for cros-ec-rpmsg.

On Fri, May 31, 2019 at 03:38:46PM +0800, Pi-Hsun Shih wrote: > Add a DT binding documentation for ChromeOS EC driver over rpmsg. > > Signed-off-by: Pi-Hsun Shih > Acked-by: Rob Herring Reviewed-by: Benson Leung > > --- > Changes from v8, v7, v6: > - No chan

Re: [PATCH v9 6/7] mfd: cros_ec: differentiate SCP from EC by feature bit.

ifferentiate between them for the userspace, or they would both be > registered at /dev/cros_ec, causing a conflict. > > Signed-off-by: Pi-Hsun Shih Reviewed-by: Benson Leung > > --- > Changes from v8: > - No change. > > Changes from v7: > - Address comment

Re: [PATCH v2 -next] platform/chrome: cros_ec: Make some symbols static

os_ec_lpc_pm_ops' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Reviewed-by: Benson Leung > --- > v2: fix patch title > --- > drivers/platform/chrome/cros_ec_debugfs.c | 4 ++-- > drivers/platform/chrome/cros_ec_lightbar.c | 2

Re: [PATCH v4 1/2] power: supply: add input power and voltage limit properties

nfigure the maximum voltage from the external supply at runtime > based on system-level knowledge or user input. > > Signed-off-by: Enric Balletbo i Serra > Reviewed-by: Guenter Roeck > Acked-by: Adam Thomson Reviewed-by: Benson Leung > --- > > Changes in v4: >

Re: [PATCH 1/3] iio: common: cros_ec_sensors: support protocol v3 message

struct __ec_todo_unpacked { > + /* Should be element of enum motionsensor_type. */ > + uint8_t type; > + > + /* Should be element of enum motionsensor_location. */ > + uint8_t location; > + > +

Re: [PATCH v3 00/30] Update cros_ec_commands.h

the whole series. Enric and I are OK with this going in for 5.3, and as Gwendal mentioned, he's landed these changes into our production kernels for Chrome OS as well, so this is what we want to sync on. Let me know if you have any other concerns. Thanks, Benson -- Benson Leung Staff Software Engi

[GIT PULL] chrome-platform changes for v5.2

-- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH] platform/chrome: cros_ec_spi: Always add of_match_table

string under the hood and match on that. > > The cros_ec_spi driver needs to provide the of_match_table regardless > of whether CONFIG_OF is enabled or not, since the table is used by > ACPI for PRP0001 devices. > > Signed-off-by: Evan Green Looks good to me. Reviewed-by: Benson Le

Re: [PATCH v3 4/4] mfd: cros_ec: instantiate properly CrOS Touchpad MCU device

gt; Signed-off-by: Enric Balletbo i Serra Reviewed-by: Benson Leung > --- > > Changes in v3: None > Changes in v2: None > > drivers/mfd/cros_ec_dev.c | 10 ++ > include/linux/mfd/cros_ec.h | 1 + > 2 files changed, 11 insertions(+) > > diff --git

Re: [PATCH v3 3/4] mfd: cros_ec: instantiate properly CrOS FP MCU device

; Signed-off-by: Enric Balletbo i Serra Reviewed-by: Benson Leung > --- > > Changes in v3: None > Changes in v2: None > > drivers/mfd/cros_ec_dev.c | 10 ++ > include/linux/mfd/cros_ec.h | 1 + > 2 files changed, 11 insertions(+) > > diff --git

Re: [PATCH] mfd: cros_ec: Only register a positive IRQ number

; ec_irq_thread, IRQF_TRIGGER_LOW | IRQF_ONESHOT, > "chromeos-ec", ec_dev); > -- > 2.21.0.225.g810b269d1ac-goog > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [BUG] cros_ec_debugfs causes a WARNING trace during suspend on ASUS C201

ized. > > > > Thanks a lot for the note. I'll send a fix later today. > > Guenter > Thanks for the report and quick fix. Guenter's fix has been merged and should be in 5.1-rc2 when Linus cuts it. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Ke

[GIT PULL] chrome platform fixes for v5.1-rc2

pattern in wilco_ec_mailbox() drivers/platform/chrome/cros_ec_debugfs.c | 10 +++--- drivers/platform/chrome/wilco_ec/mailbox.c | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble

Re: [PATCH] platform/chrome: cros_ec_debugfs: cancel/schedule logging work only if supported

Calling cancel/schedule functions > conditionally fixes the problem. > > While at it, also fix error handling in the probe function. > > Reported-by: Urja Rannikko > Cc: Urja Rannikko > Fixes: 6fce0a2cf5a05 ("mfd / platform: cros_ec: Move debugfs attributes to > i

Re: [PATCH] rtc: cros-ec: Fail suspend/resume if wake IRQ can't be configured

't wakeup from suspend on this line but the user has > chosen to do so. > > Cc: Enric Balletbo i Serra > Cc: Evan Green > Cc: Benson Leung > Cc: Guenter Roeck > Signed-off-by: Stephen Boyd Acked-By: Benson Leung -- Benson Leung Staff Software Engineer Chrome OS Kernel Google

Re: [GIT PULL] chrome-platform updates for v5.1

Hi Linus, On Tue, Mar 12, 2019 at 09:56:18AM -0700, Linus Torvalds wrote: > On Mon, Mar 11, 2019 at 9:39 PM Benson Leung wrote: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git > > tags/tag-chrome-platform-for-v5.1 > > No d

[GIT PULL] chrome-platform updates for v5.1

dependency in lpc_mec platform/chrome: Add new driver for Wilco EC Thank you, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [GIT PULL] Immutable branch between MFD and Platform due for the v5.1 merge window

Applied to chrome-platform-5.1. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH v2] mfd: cros_ec_dev: Return number of bytes read with CROS_EC_DEV_IOCRDMEM

Roeck > Signed-off-by: Enric Balletbo i Serra Reviewed-by: Benson Leung > --- > Hi, > > This patch was send long time ago and never landed to mainline [1]. This > is a second attempt. Originally was made to apply on platform/chrome but > after the recent changes we did it

Re: [PATCH] MAINTAINERS: chrome-platform: change the git tree to a chrome-platform group git tree

m-5.1 branch. > --- > > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 51029a425dbe..a3c8b094228c 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3675,7 +3675,7 @@ CHROME HARDWARE PLATFORM S

[GIT PULL] chrome-platform updates for v4.21

in. Benson Leung (1): MAINTAINERS: platform/chrome: Add Enric as a maintainer Brian Norris (2): platform/chrome: straighten out cros_ec_get_{next,host}_event() error codes platform/chrome: don't report EC_MKBP_EVENT_SENSOR_FIFO

Re: [PATCH v2] MAINTAINERS: add maintainers for ChromeOS EC sub-drivers

d-off-by: Enric Balletbo i Serra Signed-off-by: Benson Leung Thanks for sending this, Enric. > --- > > Changes in v2: > - Fix typo in Benson email address. > > MAINTAINERS | 24 > 1 file changed, 24 insertions(+) > > diff --git a/MAIN

[PATCH 1/1] MAINTAINERS: platform/chrome: Add Enric as a maintainer

Enric has volunteered to help me with maintaining chrome-platform as we change the development model toward strictly upstream-first for any chrome-platform and cros_ec driver. Signed-off-by: Benson Leung Signed-off-by: Enric Balletbo i Serra --- MAINTAINERS | 1 + 1 file changed, 1 insertion

[PATCH 1/1] MAINTAINERS: platform/chrome: Add Enric as a maintainer

Enric has volunteered to help me with maintaining chrome-platform as we change the development model toward strictly upstream-first for any chrome-platform and cros_ec driver. Signed-off-by: Benson Leung Signed-off-by: Enric Balletbo i Serra --- MAINTAINERS | 1 + 1 file changed, 1 insertion

Re: [PATCH] MAINTAINERS: platform/chrome: remove myself as maintainer

diff --git a/MAINTAINERS b/MAINTAINERS > index b5a72848a3af..57764aa57437 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3547,7 +3547,6 @@ F: drivers/input/touchscreen/chipone_icn8505.c > > CHROME HARDWARE PLATFORM SUPPORT > M: Benson Leung > -M: Ol

Re: [PATCH] MAINTAINERS: platform/chrome: remove myself as maintainer

diff --git a/MAINTAINERS b/MAINTAINERS > index b5a72848a3af..57764aa57437 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3547,7 +3547,6 @@ F: drivers/input/touchscreen/chipone_icn8505.c > > CHROME HARDWARE PLATFORM SUPPORT > M: Benson Leung > -M: Ol

Re: [PATCH v2 1/2] power: supply: add input voltage limit property.

supply properties because the feature does exist in the Emedded Controller firmware of the Pixel C and all of Google's Chromebooks with USB-C made since 2015 in case someone running an up to date kernel wanted to limit the charging power for thermal or other reasons. Thanks, Benson -- Benson

Re: [PATCH v2 1/2] power: supply: add input voltage limit property.

supply properties because the feature does exist in the Emedded Controller firmware of the Pixel C and all of Google's Chromebooks with USB-C made since 2015 in case someone running an up to date kernel wanted to limit the charging power for thermal or other reasons. Thanks, Benson -- Benson

Re: [PATCH v2 2/2] platform/chrome: don't report EC_MKBP_EVENT_SENSOR_FIFO as wakeup

*wake_event = false; > + /* Consider all other events as wake events. */ > + else > + *wake_event = true; > } > > return ret; > -- > 2.19.1.930.g4563a0d9d0-goog > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH v2 2/2] platform/chrome: don't report EC_MKBP_EVENT_SENSOR_FIFO as wakeup

*wake_event = false; > + /* Consider all other events as wake events. */ > + else > + *wake_event = true; > } > > return ret; > -- > 2.19.1.930.g4563a0d9d0-goog > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH v2 1/2] platform/chrome: straighten out cros_ec_get_{next,host}_event() error codes

t; @@ -329,7 +331,7 @@ int cros_ec_get_next_event(struct cros_ec_device *ec_dev, > bool *wake_event); > * events raised and call the functions in the ec notifier. This function > * is a helper to know which events are raised. > * > - * Return: 0 on success or negative error co

Re: [PATCH v2 1/2] platform/chrome: straighten out cros_ec_get_{next,host}_event() error codes

t; @@ -329,7 +331,7 @@ int cros_ec_get_next_event(struct cros_ec_device *ec_dev, > bool *wake_event); > * events raised and call the functions in the ec notifier. This function > * is a helper to know which events are raised. > * > - * Return: 0 on success or negative error co

[PATCH] HID: input: Ignore battery reported by Symbol DS4308

is almost out of power and warn the user that they need to charge their wired barcode scanner. Reported here: https://bugs.chromium.org/p/chromium/issues/detail?id=804720 Signed-off-by: Benson Leung --- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-input.c | 3 +++ 2 files changed, 4 insertions

[PATCH] HID: input: Ignore battery reported by Symbol DS4308

is almost out of power and warn the user that they need to charge their wired barcode scanner. Reported here: https://bugs.chromium.org/p/chromium/issues/detail?id=804720 Signed-off-by: Benson Leung --- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-input.c | 3 +++ 2 files changed, 4 insertions

[GIT PULL] chrome-platform updates for v4.20

) chrome-platform for v4.20 * Move mfd/cros_ec_lpc* includes to drivers/platform from mfd * Adding a new interrupt path for cros_ec_lpc Benson Leung (1): Merge remote-tracking

[GIT PULL] chrome-platform updates for v4.20

) chrome-platform for v4.20 * Move mfd/cros_ec_lpc* includes to drivers/platform from mfd * Adding a new interrupt path for cros_ec_lpc Benson Leung (1): Merge remote-tracking

Re: [PATCH] platform/chrome: chromeos_tbmc - Remove unneeded const

ce_id > chromeos_tbmc_acpi_device_ids[] = { > }; > MODULE_DEVICE_TABLE(acpi, chromeos_tbmc_acpi_device_ids); > > -static const SIMPLE_DEV_PM_OPS(chromeos_tbmc_pm_ops, NULL, > +static SIMPLE_DEV_PM_OPS(chromeos_tbmc_pm_ops, NULL, > chromeos_tbmc_resume); > > static struct acpi_dri

Re: [PATCH] platform/chrome: chromeos_tbmc - Remove unneeded const

ce_id > chromeos_tbmc_acpi_device_ids[] = { > }; > MODULE_DEVICE_TABLE(acpi, chromeos_tbmc_acpi_device_ids); > > -static const SIMPLE_DEV_PM_OPS(chromeos_tbmc_pm_ops, NULL, > +static SIMPLE_DEV_PM_OPS(chromeos_tbmc_pm_ops, NULL, > chromeos_tbmc_resume); > > static struct acpi_dri

Re: [PATCH v3] mfd: cros-ec: copy the whole event in get_next_event_xfer

Increase maximum mkbp event size") > > Acked-by: Enric Balletbo i Serra > Tested-by: Emil Renner Berthing > Signed-off-by: Emil Karlson Applied. Sent to Greg for rc8, hopefully. -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org

  1   2   3   4   5   6   7   8   >