On Mon, 10 Dec 2018 09:41:51 +
Yogesh Narayan Gaur wrote:
> > > +/* Instead of busy looping invoke readl_poll_timeout functionality.
> > > +*/ static int fspi_readl_poll_tout(struct nxp_fspi *f, void __iomem
> > > *base,
> > > + u32 mask, u32 delay_us,
> > > +
On Mon, 10 Dec 2018 08:39:20 +
Yogesh Narayan Gaur wrote:
> Hi Boris,
>
> Sorry for confusion.
>
> My intention was just to point to the correct patch number only. Earlier you
> have asked Mark to pick the patch [1] but that patch number was not correct.
Look at the context in [1] (we hav
On Sun, 9 Dec 2018 14:17:18 +0530
Vignesh R wrote:
> Hi Boris,
>
> On 03/10/18 10:26 PM, Vignesh R wrote:
> > This series adds support for octal mode of mt35x flash. Also, adds
> > support for OSPI version of Cadence QSPI controller.
> >
> > Based on top of patches adding basic support for mt35
On Wed, 3 Oct 2018 22:26:03 +0530
Vignesh R wrote:
> Cadence OSPI controller IP supports Octal IO (x8 IO lines),
> It also has an integrated PHY. IP register layout is very
> similar to existing QSPI IP except for additional bits to support Octal
> and Octal DDR mode. Therefore, extend current dr
Hi Yogesh,
On Mon, 10 Dec 2018 04:13:28 +
Yogesh Narayan Gaur wrote:
> Hi Mark,
>
> Patch has been resend [1], this patch is depends on the series of patch[2]
> and this series has been applied by Boris already.
You're still not asking the right person. Every patches touching
things in dr
On Sat, 20 Oct 2018 19:07:53 +0800
Hou Tao wrote:
> When jffs2_xattr_ref is dead, xref->ic or xref->xd will be invalid
> because these fields will be reused as xref->ino or xref->xid,
> so access xref->ic->ino or xref->xd->xid will lead to Oops.
>
> Fix the problem by checking whether or not it
On Thu, 2018-12-06 at 14:43:39 UTC, wrote:
> From: Cyrille Pitchen
>
> Add support for SFDP (JESD216B) 4-byte Address Instruction Table. This
> table is optional but when available, we parse it to get the 4-byte
> address op codes supported by the memory.
> Using these op codes is stateless as o
On Wed, 2018-11-14 at 12:55:18 UTC, Liu Xiang wrote:
> The is25lp256 supports 4-byte opcodes and quad output.
>
> Suggested-by: Boris Brezillon
> Signed-off-by: Liu Xiang
> Reviewed-by: Tudor Ambarus
Applied to http://git.infradead.org/linux-mtd.git spi-nor/next, thanks.
Boris
Hi Tudor,
On Thu, 6 Dec 2018 14:43:39 +
wrote:
> /**
> * spi_nor_parse_sfdp() - parse the Serial Flash Discoverable Parameters.
> * @nor: pointer to a 'struct spi_nor'
> @@ -3276,6 +3462,10 @@ static int spi_nor_parse_sfdp(struct spi_nor *nor,
> err = s
On Thu, 29 Nov 2018 14:29:54 +0800
Ryder Lee wrote:
> From: Guochun Mao
>
> Replace mtd_device_register with mtd_device_parse_register for
> parsing partitions and add ofpart support.
What's the problem with the default partition parser table [1]?
[1]https://elixir.bootlin.com/linux/latest/so
On Thu, 6 Dec 2018 04:20:26 +
Yogesh Narayan Gaur wrote:
> Hi Boris,
>
> > -Original Message-
> > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com]
> > Sent: Wednesday, December 5, 2018 6:16 PM
> > To: Vignesh R ; broo...@kernel.org
>
On Wed, 5 Dec 2018 17:25:12 +0530
Vignesh R wrote:
> >> mtd: spi-nor: add opcodes for octal Read/Write commands
> >> mtd: spi-nor: add octal read flag for flash mt35xu512aba
>
> Could you consider merging these two patches alone for v4.21?
> These can be applied independent of other patche
Hi Mathieu,
The subject prefix should be "mtd: rawnand: jz4780:" not "mips:"
Regards,
Boris
On Mon, 3 Dec 2018 22:22:13 +0100
Mathieu Malaterre wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> these places in the code produced warnings. Fix them up.
>
> Signed-
Hi Tomer;
On Mon, 3 Dec 2018 16:09:19 +0200
Tomer Maimon wrote:
> A few comments/input:
>
>
>1. We have been working on this driver for quite a long time to port it
>to the latest Linux conventions, polish the code, run tests and reach high
>quality.
>Our partners and customer
On Mon, 3 Dec 2018 08:51:54 +0100
Boris Brezillon wrote:
> On Wed, 2018-11-28 at 08:02:14 UTC, Huijin Park wrote:
> > From: "huijin.park"
> >
> > The "params->size" is defined as "u64".
> > And "info->sector_size" and
Use my korg address instead of the bootlin one.
Signed-off-by: Boris Brezillon
---
.mailmap| 7 ---
MAINTAINERS | 8
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/.mailmap b/.mailmap
index 28fecafa6506..b4b0b0b768dd 100644
--- a/.mailmap
+++ b/.mailmap
@@ -36,9
Hi Vitor,
On Mon, 26 Nov 2018 09:45:14 +0100
Boris Brezillon wrote:
> Follow the naming scheme introduced by the Cadence driver to keep things
> consistent.
>
> Signed-off-by: Boris Brezillon
> ---
> drivers/i3c/master/Makefile | 2 +-
> drive
On Mon, 3 Dec 2018 11:14:54 +0200
Tomer Maimon wrote:
> This patch set adds Flash Interface Unit(FIU) SPI-NOR
> support for the Nuvoton NPCM Baseboard Management
> Controller (BMC).
>
> The FIU supports single, dual or quad communication interface.
>
> the FIU controller can operate i
Hi Mark,
On Mon, 3 Dec 2018 08:39:00 +
Yogesh Narayan Gaur wrote:
>
> Yogesh Gaur (7):
> spi: add support for octal mode I/O data transfer
> spi: spi-mem: add support for octal mode I/O data transfer
Can you take those 2 patches in your tree for 4.21/5.0?
> mtd: spi-nor: add opcodes
t; SPI_RX_OCTO: receive with 8 wires
>
> Signed-off-by: Yogesh Gaur
> Reviewed-by: Boris Brezillon
> ---
> Changes for v4:
> - Rebase on top of v4.20-rc2
> Changes for v3:
> - Modified string 'octal' with 'octo'.
When I listed the differences between your
On Fri, 2018-10-19 at 08:30:20 UTC, Daniel Santos wrote:
> jffs2_sync_fs makes the assumption that if CONFIG_JFFS2_FS_WRITEBUFFER
> is defined then a write buffer is available and has been initialized.
> However, this does is not the case when the mtd device has no
> out-of-band buffer:
>
> int jf
On Sun, 2018-11-18 at 16:36:56 UTC, Colin King wrote:
> From: Colin Ian King
>
> The hunk of code is indented too much by one level, fix this by
> removing the extraneous tabs. Also terminate block comment using
> the recommended coding style to clean up checkpatch warning.
>
> Signed-off-by: Co
On Thu, 2018-11-29 at 04:19:51 UTC, Huijin Park wrote:
> From: "huijin.park"
>
> Callers of erase_write() always pass an unsigned int.
> So this patch avoids a cast to an int.
>
> Signed-off-by: huijin.park
> Reviewed-by: Miquel Raynal
Applied to http://git.infradead.org/linux-mtd.git mtd/nex
On Wed, 2018-11-28 at 08:02:14 UTC, Huijin Park wrote:
> From: "huijin.park"
>
> The "params->size" is defined as "u64".
> And "info->sector_size" and "info->n_sectors" are defined as
> unsigned int and u16.
> Thus, u64 data might have strange data(loss data) if the result
> overflows an unsigned
On Sun, 2018-12-02 at 08:33:58 UTC, Yangtao Li wrote:
> DEFINE_SHOW_ATTRIBUTE macro can help us simplify the code,so change
> to it.And change the DEBUGFS_RO_ATTR macro defined in some file to a
> standard macro.
>
> Signed-off-by: Yangtao Li
Applied to http://git.infradead.org/linux-mtd.git mtd
Should be [PATCH v4]
On Sun, 2 Dec 2018 03:33:58 -0500
Yangtao Li wrote:
> DEFINE_SHOW_ATTRIBUTE macro can help us simplify the code,so change
> to it.And change the DEBUGFS_RO_ATTR macro defined in some file to a
> standard macro.
You still don't put spaces after commas or periods
>
> Signe
Looks like getting rid of DEBUGFS_RO_ATTR() is just one of the change
you do. I think you should change the subject line:
"mtd: use DEFINE_SHOW_ATTRIBUTE() instead of open-coding it"
This way it covers all of your changes.
On Sun, 2 Dec 2018 02:32:02 -0500
Yangtao Li wrote:
> We already have
On Sat, 1 Dec 2018 20:54:17 -0500
Yangtao Li wrote:
> We already have the DEFINE_SHOW_ATTRIBUTE.There is no need to define
> such a macro,so remove DEBUGFS_RO_ATTR.Also use DEFINE_SHOW_ATTRIBUTE
> to simplify some code.
>
> Signed-off-by: Yangtao Li
> ---
> Changes in v2:
> -Remove a missing D
On Fri, 30 Nov 2018 11:27:18 -0800
Jarkko Sakkinen wrote:
> In order to comply with the CoC, replace with a hug.
>
> Signed-off-by: Jarkko Sakkinen
> ---
> drivers/mtd/mtd_blkdevs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/mtd_blkdevs.c b/drive
Hello Linus,
Here is the MTD fixes PR for 4.20-rc5.
Regards,
Boris
The following changes since commit 2e6e902d185027f8e3cb8b7305238f7e35d6a436:
Linux 4.20-rc4 (2018-11-25 14:19:31 -0800)
are available in the Git repository at:
git://git.infradead.org/linux-mtd.git tags/mtd/fixes-for-4.20
On Tue, 2018-11-27 at 07:44:52 UTC, Schrempf Frieder wrote:
> Fix the size of the buffer allocated to store the in-memory BBT.
> This bug was previously hidden by a different bug, that was fixed in
> d098093ba06e.
>
> Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal with NAND
> de
On Mon, 2018-11-26 at 12:45:44 UTC, wrote:
> From: Tudor Ambarus
>
> BFPT advertises all the erase types supported by all the possible
> map configurations. Mask out the erase types that are not supported
> by the current map configuration.
>
> Backward compatibility test done on sst26vf064b.
>
On Thu, 29 Nov 2018 15:35:58 +0100
Bartosz Golaszewski wrote:
> czw., 29 lis 2018 o 15:32 Srinivas Kandagatla
> napisał(a):
> >
> >
> > >
> > > Hi Srinivas,
> > >
> > > if there are no objections - can you Ack this patch for Greg to pick
> > > up into char-misc?
> >
> > Patch is fine for me.
On Wed, 28 Nov 2018 15:19:37 +
Schrempf Frieder wrote:
> On 28.11.18 16:02, Boris Brezillon wrote:
> > On Wed, 28 Nov 2018 14:55:45 +
> > Schrempf Frieder wrote:
> >
> >> Hi Boris,
> >>
> >> On 28.11.18 15:41, Boris Brezillon w
On Wed, 28 Nov 2018 14:55:45 +
Schrempf Frieder wrote:
> Hi Boris,
>
> On 28.11.18 15:41, Boris Brezillon wrote:
> > On Tue, 27 Nov 2018 07:44:52 +
> > Schrempf Frieder wrote:
> >
> >> Fix the size of the buffer allocated to store the in-memo
On Tue, 27 Nov 2018 07:44:52 +
Schrempf Frieder wrote:
> Fix the size of the buffer allocated to store the in-memory BBT.
> This bug was previously hidden by a different bug, that was fixed in
> d098093ba06e.
>
> Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal with NAND
> d
On Wed, 28 Nov 2018 14:17:12 +
wrote:
> On 11/28/2018 09:57 AM, Boris Brezillon wrote:
> > On Tue, 20 Nov 2018 11:55:21 +
> > wrote:
> >
> >> +
> >> + /*
> >> + * We set nor->addr_width here to skip spi_nor_set_4byte_opco
Hi Alexander,
On Mon, 26 Nov 2018 13:04:45 +
"Sverdlin, Alexander (Nokia - DE/Ulm)"
wrote:
> Hello Tudor and all,
>
> On 26/11/2018 13:45, tudor.amba...@microchip.com wrote:
> > From: Tudor Ambarus
> >
> > BFPT advertises all the erase types supported by all the possible
> > map configura
On Tue, 27 Nov 2018 16:41:56 +
Schrempf Frieder wrote:
> >>> +static int tc58cvg2s0h_ooblayout_ecc(struct mtd_info *mtd, int section,
> >>> + struct mtd_oob_region *region)
> >>> +{
> >>> + if (section > 7)
> >>> + return -ERANGE;
> >>> +
> >>>
the new one does.
>
> Fixes: 32608703310 ("UBI: Extend UBI layer debug/messaging capabilities")
>
Unnecessary blank line here.
> Signed-off-by: Pan Bian
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/ubi/kapi.c | 2 +-
> 1 file changed, 1 insertion(+),
On Wed, 28 Nov 2018 10:57:33 +0800
Pan Bian wrote:
> The MTD device reference is dropped via put_mtd_device, however its
> field ->index is read and passed to ubi_msg. To fix this, the patch
> moves the reference dropping after calling ubi_msg.
>
> Signed-off-by: Pan Bian
On Tue, 20 Nov 2018 11:55:21 +
wrote:
> +
> + /*
> + * We set nor->addr_width here to skip spi_nor_set_4byte_opcodes()
> + * later because this latest function implements a legacy quirk for
> + * the erase size of Spansion memory. However this quirk is no longer
> + *
On Tue, 27 Nov 2018 07:44:52 +
Schrempf Frieder wrote:
> Fix the size of the buffer allocated to store the in-memory BBT.
> This bug was previously hidden by a different bug, that was fixed in
> d098093ba06e.
Oops :-/.
>
> Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal wi
s first
> > argument (i.e. the node of the device being probed).
> >
> > While at it, also fix a related nfc-node reference leak.
> >
> > Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver")
> > Cc: stable # 4.11
> > Cc: Nic
On Fri, 23 Nov 2018 10:15:05 +0300
Dan Carpenter wrote:
> This should be >= ARRAY_SIZE() to avoid reading one element beyond the
> end of the array.
>
> Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
> Signed-off-by: Dan Carpenter
Queued to i3c/next.
Thanks,
Boris
> ---
> drivers
On Fri, 23 Nov 2018 10:14:42 +0300
Dan Carpenter wrote:
> We should return "ret" as-is. The "newdev" variable is a valid pointer.
>
> Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
> Signed-off-by: Dan Carpenter
Queued to i3c/next.
Thanks,
Boris
> ---
> drivers/i3c/master.c | 4
Follow the naming scheme introduced by the Cadence driver to keep things
consistent.
Signed-off-by: Boris Brezillon
---
drivers/i3c/master/Makefile | 2 +-
drivers/i3c/master/{dw-i3c-master.c => i3c-master-dw.c} | 0
2 files changed, 1 insertion(+), 1 delet
On Fri, 23 Nov 2018 11:17:29 +0100
Boris Brezillon wrote:
> On Fri, 23 Nov 2018 09:42:55 +
> "Sverdlin, Alexander (Nokia - DE/Ulm)"
> wrote:
>
> > Hello Tudor,
> >
> > On 22/11/2018 13:36, tudor.amba...@microchip.com wrote:
> > > From: Tud
On Fri, 23 Nov 2018 09:42:55 +
"Sverdlin, Alexander (Nokia - DE/Ulm)"
wrote:
> Hello Tudor,
>
> On 22/11/2018 13:36, tudor.amba...@microchip.com wrote:
> > From: Tudor Ambarus
> >
> > Bug reported for the out-of-tree S25FS128S flash memory.
> >
> > BFPT table advertises all the erase type
Hello Linus,
Here is the MTD fixes PR for 4.20-rc4.
Regards,
Boris
The following changes since commit ccda4af0f4b92f7b4c308d3acc262f4a7e3affad:
Linux 4.20-rc2 (2018-11-11 17:12:31 -0600)
are available in the Git repository at:
git://git.infradead.org/linux-mtd.git tags/mtd/fixes-for-4.20
On Wed, 21 Nov 2018 12:08:02 +0100
Janusz Krzysztofik wrote:
> Finalize implementation of the idea suggested by Artem Bityutskiy and
> Tony Lindgren, described in commit b027274d2e3a ("mtd: ams-delta: fix
> request_mem_region() failure"). Use pure GPIO consumer API, as
ly OMAP.
>
> Signed-off-by: Janusz Krzysztofik
> Reviewed-by: Linus Walleij
Reviewed-by: Boris Brezillon
And thanks a lot for keeping up with that. I like the new ams-delta
driver, and I wonder if we couldn't extend it to replace the gpio-nand
driver.
> ---
>
On Fri, 2018-10-12 at 02:23:13 UTC, Yogesh Narayan Gaur wrote:
> Add entry for mt35xu512aba Micron NOR flash.
> This flash is having uniform sector erase size of 128KB, have
> support of FSR(flag status register), flash size is 64MB and
> supports 4-byte commands.
>
> Signed-off-by: Yogesh Gaur
>
On Fri, 2018-10-12 at 02:23:08 UTC, Yogesh Narayan Gaur wrote:
> Some MICRON related macros in spi-nor domain were ST.
> Rename entries related to STMicroelectronics under macro SNOR_MFR_ST.
>
> Added entry of MFR Id for Micron flashes, 0x002C.
>
> Signed-off-by: Yogesh Gaur
> Reviewed-by: Tudor
On Fri, 2018-11-16 at 17:46:37 UTC, wrote:
> There are uniform, non-uniform and flexible erase flash configurations.
>
> The non-uniform erase types, are the erase types that can _not_ erase
> the entire flash by their own.
>
> As the code was, in case flashes had flexible erase capabilities
> (
On Fri, 9 Nov 2018 10:30:41 +0530
Naga Sureshkumar Relli wrote:
> +static int anfc_setup_data_interface(struct nand_chip *chip, int csline,
> + const struct nand_data_interface *conf)
> +{
> + struct anfc_nand_controller *nfc = to_anfc(chip->controller);
> +
On Tue, 20 Nov 2018 12:48:46 +0100
Krzysztof Kozlowski wrote:
> On Tue, 20 Nov 2018 at 11:33, Miquel Raynal wrote:
> >
> > Hi Krzysztof,
> >
> > Krzysztof Kozłowski wrote on Tue, 20 Nov 2018
> > 10:46:33 +0100:
> >
> > > Hi all,
> > >
> > > Since few days linux-next has problem on Freescale V
On Tue, 20 Nov 2018 07:02:08 +
Naga Sureshkumar Relli wrote:
> >
> > Can you please run nandbiterrs (availaible in mtd-utils). I fear your
> > device won't pass the test.
> Yes, nandbiterror test is passing till 24bit, after that it is failing.
Can you paste the output of nandbiterrs ple
On Fri, 2018-11-16 at 14:25:49 UTC, thor.tha...@linux.intel.com wrote:
> From: Thor Thayer
>
> The current Cadence QSPI driver caused a kernel panic sporadically
> when writing to QSPI. The problem was caused by writing more bytes
> than needed because the QSPI operated on 4 bytes at a time.
>
>
On Mon, 19 Nov 2018 12:41:10 +
vitor wrote:
> Hi Coling,
>
>
> Thanks for your report.
>
> On 16/11/18 18:42, Colin King wrote:
> > From: Colin Ian King
> >
> > The masking operation on status is using a bitwise 'or' rather than
> > a bitwise 'and' operator, and hence the result is always
On Mon, 19 Nov 2018 16:12:41 +0100
Marek Vasut wrote:
> On 11/19/2018 03:43 PM, Boris Brezillon wrote:
> > On Mon, 19 Nov 2018 15:14:07 +0100
> > Marek Vasut wrote:
> >
> >> On 11/19/2018 03:10 PM, Boris Brezillon wrote:
> >>> On Mon, 19 Nov 20
On Mon, 19 Nov 2018 15:14:07 +0100
Marek Vasut wrote:
> On 11/19/2018 03:10 PM, Boris Brezillon wrote:
> > On Mon, 19 Nov 2018 14:49:31 +0100
> > Marek Vasut wrote:
> >
> >> On 11/19/2018 11:01 AM, Mason Yang wrote:
> >>> Document the bindings u
On Mon, 19 Nov 2018 14:49:31 +0100
Marek Vasut wrote:
> On 11/19/2018 11:01 AM, Mason Yang wrote:
> > Document the bindings used by the Renesas R-Car D3 RPC controller.
> >
> > Signed-off-by: Mason Yang
> > ---
> > .../devicetree/bindings/spi/spi-renesas-rpc.txt| 33
> > ++
On Mon, 19 Nov 2018 12:35:42 +
vitor wrote:
> Hi Boris,
>
> On 16/11/18 13:16, Boris Brezillon wrote:
> > On Fri, 16 Nov 2018 12:31:42 +
> > vitor wrote:
> >
> >> Hi Boris,
> >>
> >>
> >> On 15/11/18 19:00, Boris Brezillo
On Mon, 19 Nov 2018 09:58:46 +0100
Bartosz Golaszewski wrote:
> niedz., 18 lis 2018 o 17:03 Boris Brezillon
> napisał(a):
> >
> > On Tue, 13 Nov 2018 15:01:08 +0100
> > Bartosz Golaszewski wrote:
> >
> > > As far as merging of this series goes: I'
On Mon, 19 Nov 2018 06:20:28 +
Naga Sureshkumar Relli wrote:
> H Boris,
>
> > -Original Message-
> > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com]
> > Sent: Monday, November 19, 2018 1:13 AM
> > To: Naga Sureshkumar Relli
> >
On Thu, 15 Nov 2018 09:34:16 +
Naga Sureshkumar Relli wrote:
> Hi Boris & Miquel,
>
> I am updating the driver by addressing your comments, and I have one concern,
> especially in anfc_read_page_hwecc(),
> there I am checking for erased pages bit flips.
> Since Arasan NAND controller does
On Thu, 15 Nov 2018 15:26:48 +0100
Johan Hovold wrote:
> On Tue, Oct 23, 2018 at 08:51:17PM +0200, Boris Brezillon wrote:
> > On Tue, 23 Oct 2018 13:28:09 -0500
> > Rob Herring wrote:
> >
> > > On Mon, Aug 27, 2018 at 4:44 AM Johan Hovold wrote:
> > &g
On Sat, 2018-11-17 at 03:43:27 UTC, Olof Johansson wrote:
> PAGE_READ is used by RISC-V arch code included through mm headers,
> and it makes sense to bring in a prefix on these in the driver.
>
> drivers/mtd/nand/raw/qcom_nandc.c:153: warning: "PAGE_READ" redefined
> #define PAGE_READ 0x2
> In
On Fri, 2018-11-09 at 16:56:56 UTC, wrote:
> The entire smpt array is initialized with data read from sfdp,
> there is no need to init it with zeroes before.
>
> Signed-off-by: Tudor Ambarus
Applied to http://git.infradead.org/linux-mtd.git spi-nor/next, thanks.
Boris
On Thu, 15 Nov 2018 00:07:10 -0500
Huijin Park wrote:
> From: "huijin.park"
>
> This patch casts the "len" parameter to an unsigned int.
Hm, that's not really what this patch actually. Actually it avoids the
cast from an int to an unsigned int.
> The callers of erase_write() pass the "len" pa
On Fri, 2018-11-09 at 16:56:52 UTC, wrote:
> Don't overwrite the errno from spi_nor_read_raw().
>
> Signed-off-by: Tudor Ambarus
Applied to http://git.infradead.org/linux-mtd.git mtd/fixes, thanks.
Boris
; parser fails. In case of failing, each optional parser is responsible
> to roll back to the previously known spi_nor data.
>
> Fixes: b038e8e3be72 ("mtd: spi-nor: parse SFDP Sector Map Parameter Table")
> Reported-by: Yogesh Gaur
> Suggested-by: Boris Brezillon
r manufacturers, misrepresent smpt
> array fields.
>
> Fixes: b038e8e3be72 ("mtd: spi-nor: parse SFDP Sector Map Parameter Table")
> Suggested-by: Boris Brezillon
> Signed-off-by: Tudor Ambarus
Applied to http://git.infradead.org/linux-mtd.git mtd/fixes, thanks.
Boris
On Fri, 2018-11-09 at 16:56:54 UTC, wrote:
> spi_nor_read_raw() calls nor->read() which might be implemented
> by the m25p80 driver. m25p80 uses the spi-mem layer which requires
> DMA-able in/out buffers. Pass kmalloc'ed dma buffer to spi_nor_read_raw().
>
> Fixes: b038e8e3be72 ("mtd: spi-nor: pa
On Thu, 15 Nov 2018 11:43:05 +
Schrempf Frieder wrote:
> On 15.11.18 07:22, Yogesh Narayan Gaur wrote:
> > Hi Frieder,
> >
> > With below patch on top of your v5, Read/Write/Erase on CS1 is working fine
> > for me.
>
> Ok, are you sure, that AHB read is working too with this patch?
> You
On Thu, 15 Nov 2018 14:04:00 +0100
Miquel Raynal wrote:
> Hi Liang,
>
> Liang Yang wrote on Thu, 15 Nov 2018 19:25:07
> +0800:
>
> > Hi Boris,
> >
> > I have implemented dma access base on these helpers you provided below.
> > we prepare to send v7 version now, so when will these helpers be p
On Thu, 15 Nov 2018 10:54:39 +
wrote:
> Hi, Liu, Boris, Cyrille,
>
> On 11/14/2018 03:51 PM, Boris Brezillon wrote:
> > On Wed, 14 Nov 2018 20:56:05 +0800
> > Liu Xiang wrote:
> >
> >> In is25lp256, the DWORD1 of JEDEC Basic Flash Parameter Header
>
On Wed, 14 Nov 2018 06:10:47 +
YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/i3c/master/i3c-master-cdns.c: In function 'cdns_i3c_master_do_daa':
> drivers/i3c/master/i3c-master-cdns.c:1137:16: warning:
> variable 'old_i3c_scl_lim' set but not used [-Wunused-
On Wed, 14 Nov 2018 20:55:18 +0800
Liu Xiang wrote:
> The is25lp256 supports 4-byte opcodes and quad output.
>
> Suggested-by: Boris Brezillon
> Signed-off-by: Liu Xiang
This one looks good. Tudor, can you have a look?
> ---
> drivers/mtd/spi-nor/spi-nor.c | 2 +-
&g
size in spi_nor_parse_sfdp().
>
> Suggested-by: Boris Brezillon
> Signed-off-by: Liu Xiang
> ---
> drivers/mtd/spi-nor/spi-nor.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 3eba13a..77eaf2
On Wed, 14 Nov 2018 10:43:00 +
Yogesh Narayan Gaur wrote:
> Hi Frieder,
>
> [..]
> > >
> > > Ok, I will have a look at what could make the chip selection fail in
> > > case of AHB read.
> >
> > Could you try with this change applied:
> >
> > @@ -503,7 +503,7 @@ static void fsl_qspi_selec
On Thu, 8 Nov 2018 08:16:53 -0800
Eric Anholt wrote:
> The extra to_v3d_bo() calls came from copying this from the vc4
> driver, which stored the cma gem object in the structs.
>
> Signed-off-by: Eric Anholt
Reviewed-by: Boris Brezillon
> ---
> drivers/gpu/drm/
On Mon, 12 Nov 2018 17:54:16 +0100
Boris Brezillon wrote:
> +Wolfram to give some inputs on the DMA issue.
>
> On Mon, 12 Nov 2018 17:13:51 +0100
> Miquel Raynal wrote:
>
> > Hello,
> >
> > Boris Brezillon wrote on Tue, 6 Nov 2018
> > 11:22:06 +0100:
&
+Wolfram to give some inputs on the DMA issue.
On Mon, 12 Nov 2018 17:13:51 +0100
Miquel Raynal wrote:
> Hello,
>
> Boris Brezillon wrote on Tue, 6 Nov 2018
> 11:22:06 +0100:
>
> > On Tue, 6 Nov 2018 18:00:37 +0800
> > Liang Yang wrote:
> >
> > >
On Mon, 12 Nov 2018 11:55:36 +0100
Martin Lund wrote:
> Hi Naga,
>
> Just a few review comments for the v12 version.
>
> On Fri, Nov 9, 2018 at 6:00 AM Naga Sureshkumar Relli
> wrote:
> > +#define PKT_OFST 0x00
> > +#define PKT_CNT_SHIFT 12
> > +
> > +#define MEM_ADDR1_O
On Mon, 12 Nov 2018 10:46:45 +
Schrempf Frieder wrote:
> On 08.11.18 09:34, Boris Brezillon wrote:
> > On Wed, 7 Nov 2018 16:36:13 +
> > Schrempf Frieder wrote:
> >
> >> Hi Olof,
> >>
> >> On 07.11.18 17:20, Olof Johansson wrote
Hi Liu,
On Fri, 24 Aug 2018 22:41:41 +0800
Liu Xiang wrote:
> The is25lp256 supports 4-byte opcodes and quad output.
> In is25lp256, the DWORD1 of JEDEC Basic Flash Parameter Header
> is 0xfff920e5. So the DWORD1[18:17] Address Bytes bits are 0b00,
> means that 3-Byte only addressing. Now this l
On Wed, 2018-08-15 at 17:02:26 UTC, "Gustavo A. R. Silva" wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 114857 ("Missing break in switch")
> Addresses-Coverity-ID: 114858 ("Missing break in switch"
On Thu, 2018-08-09 at 16:05:13 UTC, "Gustavo A. R. Silva" wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 402015 ("Missing break in switch")
> Addresses-Coverity-ID: 402016 ("Missing break in switch"
On Tue, 2018-09-11 at 12:42:34 UTC, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in the Kconfig text
>
> Signed-off-by: Colin Ian King
Applied to http://git.infradead.org/linux-mtd.git mtd/next, thanks.
Thanks!
Hi Naga,
Just a preliminary review. I still think we have problems with how you
execute NAND operations. You seem to assume that read/write operation
are always page write/read operation with a size aligned on a page
size. This is wrong, either the controller is able to execute the exact
operation
On Fri, 9 Nov 2018 10:30:39 +0530
Naga Sureshkumar Relli wrote:
> This patch adds the dts binding document for arasan nand flash controller
>
> Signed-off-by: Naga Sureshkumar Relli
> ---
> Changes in v12:
> - Removed interrupt-parent description as it is implied as suggested by
>Rob Herri
On Thu, 8 Nov 2018 14:48:11 +
wrote:
> +
> >>>
> >>> Maybe I missed something but it sounds like this change is just
> >>> optimizing the SPMT parsing a bit, and to be honest, I'm not sure this
> >>> is really needed. Most of the time, smpt_len will be rather small, so
> >>> trying
On Wed, 7 Nov 2018 23:16:19 +0100
Richard Weinberger wrote:
> +/**
> + * ubi_bitflip_check - Check an eraseblock for bitflips and scrub it if
> needed.
> + * @ubi: UBI device description object
> + * @pnum: the physical eraseblock to schedule
> + * @force_scrub: force scrubbing if non-zero, sch
On Thu, 8 Nov 2018 13:58:45 +
wrote:
> On 11/08/2018 02:54 PM, Boris Brezillon wrote:
> > On Thu, 8 Nov 2018 11:07:11 +
> > wrote:
> >
> >> The map selector is limited to a maximum of 8 bits, allowing
> >> for a maximum of 256 possible map confi
On Thu, 8 Nov 2018 13:54:47 +0100
Boris Brezillon wrote:
> > - while (i < smpt_len) {
> > + for (nmaps = 0; i < smpt_len; nmaps++) {
> > + /*
> > +* The map selector is limited to a maximum of 8 bits, allowing
> > +
On Thu, 8 Nov 2018 11:07:18 +
wrote:
> Use GFP_DMA to ensure that the memory we allocate for transfers in
> nor->read() can be DMAed.
See my comment on patch 5.
On Thu, 8 Nov 2018 11:07:16 +
wrote:
> spi_nor_read_raw() calls nor->read() which might be implemented
> by the m25p80 driver. m25p80 uses the spi-mem layer which requires
> DMA-able in/out buffers. Pass kmalloc'ed dma buffer to spi_nor_read_raw().
>
> Signed-off-by: Tudor Ambarus
> ---
>
ntly in use.
>
> Suggested-by: Boris Brezillon
I don't remember suggesting this :-).
> Signed-off-by: Tudor Ambarus
> ---
> drivers/mtd/spi-nor/spi-nor.c | 15 +--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mt
501 - 600 of 3098 matches
Mail list logo
