ned-off-by: Krzysztof Kozlowski
> ---
Acked-by: Charles Keepax
Thanks,
Charles
get(), which will not change the runtime
> PM counter on error.
>
> Signed-off-by: Dinghao Liu
> ---
Acked-by: Charles Keepax
Wow, did not realise that was how that worked. Thanks for fixing
up.
Thanks,
Charles
s accordingly.
>
> Fixes: 5513b411ea5b ("Documentation: rename pinctl to pin-control")
> Signed-off-by: Mauro Carvalho Chehab
> ---
Acked-by: Charles Keepax
Thanks,
Charles
he best choice.
>
> So search available sysclk_divs from 2 to 1 other than from 1 to 2.
>
> Fixes: 84fdc00d519f ("ASoC: codec: wm9860: Refactor PLL out freq search")
> Signed-off-by: Shengjiu Wang
> ---
Acked-by: Charles Keepax
Thanks,
Charles
gt;
> wm8962 3-001a: Unsupported BCLK ratio 9
>
> Fix this by relaxing bitclk divider searching, so that when
> no exact value can be derived from sysclk pick the closest
> value greater than expected bitclk.
>
> Signed-off-by: Shengjiu Wang
> Reviewed-by: Daniel Baluta
&
On Sat, Mar 06, 2021 at 05:21:51PM +0530, Bhaskar Chowdhury wrote:
>
> s/sortd/sorted/
>
> Signed-off-by: Bhaskar Chowdhury
> ---
> sound/soc/codecs/wm8955.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/wm8955.c b/sound/soc/codecs/wm8955.c
> index
On Wed, Mar 03, 2021 at 07:21:28PM +0800, Shengjiu Wang wrote:
> With S20_3LE format case, the sysclk = rate * 384,
> the bclk = rate * 20 * 2, there is no proper bclk divider
> for 384 / 40, because current condition needs exact match.
> So driver fails to configure the clocking:
>
> wm8962
moved in wm8960_configure_sysclk,
> then wm8960_configure_pll can be called, and there is also bitclk relax
> function in wm8960_configure_pll.
>
> Fixes: 3c01b9ee2ab9 ("ASoC: codec: wm8960: Relax bit clock computation")
> Signed-off-by: Shengjiu Wang
> Signed-off-by: Daniel Baluta
> ---
Acked-by: Charles Keepax
Thanks,
Charles
On Tue, Mar 02, 2021 at 07:18:11PM +0800, Shengjiu Wang wrote:
> From: Daniel Baluta
>
> Using a higher bitclk then expected doesn't always work.
> Here is an example:
>
> aplay -Dhw:0,0 -d 5 -r 48000 -f S24_LE -c 2 audio48k24b2c.wav
>
> In this case, the required bitclk is 48000 * 24 * 2 =
This callback structure has never been used and it is not clear why it
was added in the first place. Remove it to clear up the code a little.
Signed-off-by: Charles Keepax
---
sound/soc/codecs/wm_adsp.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/sound/soc/codecs/wm_adsp.c b
Robot
> Signed-off-by: Wei Yongjun
> ---
Acked-by: Charles Keepax
Thanks,
Charles
t; Suggested-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Thanks,
Charles
vices.
>
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Thanks,
Charles
rough snd_soc_card_jack_new() and register
> this jack with the codec through snd_soc_component_set_jack().
>
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Thanks,
Charles
n on the next jack insertion, which in turn
> causes the EXTCON_JACK_HEADPHONE state to never get set
>
> This fixes both issues by skipping these 2 steps when arizona_hpdet_irq
> runs after the jack has been unplugged.
>
> Reviewed-by: Andy Shevchenko
> Acked-by: Charles Keepax
> Signed-off-by: Hans de Goede
> ---
Tested-by: Charles Keepax
Thanks,
Charles
zona extcon driver into
> a helper library for letting the arizona codec-drivers directly report
> jack state through the standard sound/soc/soc-jack.c functions.
>
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Thanks,
Charles
a codec-drivers directly report jack
> state through the standard sound/soc/soc-jack.c functions.
>
> Reviewed-by: Andy Shevchenko
> Acked-by: Charles Keepax
> Signed-off-by: Hans de Goede
> ---
Tested-by: Charles Keepax
Thanks,
Charles
on a Lenovo Yoga Tablet 2 1051L with a WM5102 codec.
>
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Thanks,
Charles
gh pdata (or defaults)
> and cannot be overridden from devicetree. All in-kernel users of the
> pdata (and the fallback defaults) define 6 or less buttons/ranges.
>
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Thanks,
Charles
On Sat, Jan 23, 2021 at 01:17:20PM +0100, Hans de Goede wrote:
> Add jack detect support by creating a jack and calling
> snd_soc_component_set_jack to register the created jack
> with the codec.
>
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
> +static struct
eoretically possible races caused
> by the wrong ordering inside arizona_extcon_remove(), this fixes the
> ordering fixing all possible races, including the reported oops.
>
> Reviewed-by: Andy Shevchenko
> Acked-by: Charles Keepax
> Signed-off-by: Hans de Goede
> ---
Tested-by: Charles Keepax
Thanks,
Charles
mediately after the call.
> This means that we should always use pm_runtime_get_sync().
>
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Tested-by: Charles Keepax
Thanks,
Charles
tly report jack
> state through the standard sound/soc/soc-jack.c functions.
>
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Thanks,
Charles
mediately after the call.
> This means that we should always use pm_runtime_get_sync().
>
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Thanks,
Charles
skip the debugfs_create_dir() call in that case, avoiding
> this error getting logged.
>
> Fixes: c33d442328f5 ("debugfs: make error message a bit more verbose")
> Cc: Charles Keepax
> Signed-off-by: Hans de Goede
> ---
Reviewed-by: Charles Keepax
Thanks,
Charles
On Thu, Jan 21, 2021 at 05:55:00PM +0100, Hans de Goede wrote:
> On 1/19/21 10:51 AM, Richard Fitzgerald wrote:
> > On 18/01/2021 17:24, Andy Shevchenko wrote:
> >> On Sun, Jan 17, 2021 at 6:06 PM Hans de Goede wrote:
> 1. Keep the code as is, live with the debugfs error. This might be
> best for
On Fri, Jan 22, 2021 at 01:23:44PM +0100, Hans de Goede wrote:
> On 1/22/21 12:26 PM, Charles Keepax wrote:
> > On Thu, Jan 21, 2021 at 05:55:00PM +0100, Hans de Goede wrote:
> >> On 1/19/21 10:51 AM, Richard Fitzgerald wrote:
> >>> On 18/01/2021 17:24, Andy Shevchenk
On Thu, Jan 21, 2021 at 05:55:00PM +0100, Hans de Goede wrote:
> Hi,
>
> On 1/19/21 10:51 AM, Richard Fitzgerald wrote:
> > On 18/01/2021 17:24, Andy Shevchenko wrote:
> >> On Sun, Jan 17, 2021 at 6:06 PM Hans de Goede wrote:
> >>>
> >>> Convert the arizona extcon driver into a helper library
a codec-drivers directly report jack
> state through the standard sound/soc/soc-jack.c functions.
>
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Thanks,
Charles
n on the next jack insertion, which in turn
> causes the EXTCON_JACK_HEADPHONE state to never get set
>
> This fixes both issues by skipping these 2 steps when arizona_hpdet_irq
> runs after the jack has been unplugged.
>
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Thanks,
Charles
es need will be added in a separate patch.
>
> BugLink: https://github.com/thesofproject/linux/issues/2485
> Co-authored-by: Pierre-Louis Bossart
> Signed-off-by: Pierre-Louis Bossart
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Reviewed-by: Charles Keepax
Thanks,
Charles
ndroid_Yoga_Tablet_2-1051F_Kernel
>
> Cc: Christian Hartmann
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Thanks,
Charles
.
>
> While at it also fix a possible NULL pointer deref of the id
> argument to the probe functions (this could happen on e.g. manual
> driver binding through sysfs).
>
> Suggested-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Thanks,
Charles
On Wed, Dec 30, 2020 at 05:44:41PM +0100, Andrew Lunn wrote:
> On Wed, Dec 30, 2020 at 10:33:09AM +0000, Charles Keepax wrote:
> > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of
> > macb_set_tx_clk were gated on the presence of this flag.
> >
> > - if (
On Thu, Dec 17, 2020 at 10:27:40AM -0600, Adam Ford wrote:
> The driver can request an optional clock for mclk.
> Update the txt file to reflect this.
>
> Suggested-by: Geert Uytterhoeven
> Signed-off-by: Adam Ford
Acked-by: Charles Keepax
Thanks,
Charles
ot absence of the flag. Update the if statement to
this effect, which repairs the existing users.
Fixes: daafa1d33cc9 ("net: macb: add capability to not set the clock rate")
Suggested-by: Andrew Lunn
Signed-off-by: Charles Keepax
---
Changes since v1:
- Updated flag semantics to skip
On Wed, Dec 30, 2020 at 05:44:41PM +0100, Andrew Lunn wrote:
> On Wed, Dec 30, 2020 at 10:33:09AM +0000, Charles Keepax wrote:
> > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of
> > macb_set_tx_clk were gated on the presence of this flag.
> >
> > - if (
ot absence of the flag. Update the if statement to
this effect, which repairs the existing users.
Fixes: daafa1d33cc9 ("net: macb: add capability to not set the clock rate")
Suggested-by: Andrew Lunn
Signed-off-by: Charles Keepax
---
Changes since v1:
- Updated flag semantics to skip
On Tue, Dec 29, 2020 at 02:57:38PM +0100, Hans de Goede wrote:
> On 12/29/20 2:06 PM, Charles Keepax wrote:
> > On Mon, Dec 28, 2020 at 04:28:07PM +, Mark Brown wrote:
> >> On Mon, Dec 28, 2020 at 02:16:04PM +0100, Hans de Goede wrote:
> >>
> >>> A
On Sun, Dec 27, 2020 at 10:12:31PM +0100, Hans de Goede wrote:
> From: Pierre-Louis Bossart
>
> Add a new ASoc Machine driver for Intel Baytrail platforms with a
> Wolfson Microelectronics WM5102 codec.
>
> This is based on a past contributions [1] from Paulo Sergio Travaglia
> based on the
On Mon, Dec 28, 2020 at 04:28:07PM +, Mark Brown wrote:
> On Mon, Dec 28, 2020 at 02:16:04PM +0100, Hans de Goede wrote:
>
> > And more in general AFAIK extcon is sort of deprecated and it is
> > not advised to use it for new code. I would esp. not expect it to
> > be used for new
On Sun, Dec 27, 2020 at 10:12:27PM +0100, Hans de Goede wrote:
> All the callers of extcon_set_state_sync() log an error on failure,
> without doing any further error-handling (as there is nothing they
> can do about the error).
>
> Factor this out into a helper to remove some duplicate code.
>
t; it was using a hardcoded GPIOD_OUT_LOW.
>
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Thanks,
Charles
eoretically possible races caused
> by the wrong ordering inside arizona_extcon_remove(), this fixes the
> ordering fixing all possible races, including the reported oops.
>
> Signed-off-by: Hans de Goede
> ---
Sorry yes there are a few rough corners on the extcon stuff, I
have
-extcon" and the
> modalias must match that.
>
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Thanks,
Charles
On Sun, Dec 27, 2020 at 10:12:22PM +0100, Hans de Goede wrote:
> There is no reason why the arizona core,irq and codec model specific
> regmap bits cannot be build as a module. All they do is export symbols
> which are used by the arizona-spi and/or arizona-i2c modules, which
> themselves can be
e existing MODULE_SOFTDEP("pre: wm8994_regulator")
> in the wm8994 code, which has a similar init sequence.
>
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Thanks,
Charles
On Wed, Dec 23, 2020 at 08:24:41PM +0100, Andrew Lunn wrote:
> On Wed, Dec 23, 2020 at 06:41:44PM +0000, Charles Keepax wrote:
> > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of
> > macb_set_tx_clk were gated on the presence of this flag.
> >
> > if
afa1d33cc9 ("net: macb: add capability to not set the clock rate")
Signed-off-by: Charles Keepax
---
drivers/net/ethernet/cadence/macb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb_main.c
b/drivers/net/ethernet/caden
>
> >From the user perspective, everything seems fine but no data is produced.
>
> Connecting the Loopback DAI to a dummy DAPM endpoint solves the problem.
>
> Fixes: 8dd26dff00c0 ("ASoC: dapm: Fix handling of custom_stop_condition on
> DAPM graph walks")
> Cc:
rty);
I can't help but wonder if we should be taking the DAPM lock for
snd_soc_dapm_free_widgets. However your patch doesn't look like it
is making that any more scary and looks like we should be making
sure we remove the widget from the dirty list.
Reviewed-by: Charles Keepax
Thanks,
Charles
it's still on the list,
> leading to a use after free.
>
> Fixes: 78bb3688ea18 ("mfd: Support multiple active WM831x AUXADC conversions")
> Signed-off-by: Dan Carpenter
> ---
Acked-by: Charles Keepax
Thanks,
Charles
On Fri, Dec 11, 2020 at 04:44:40PM +0800, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Zheng Yongjun
> ---
Acked-by: Charles Keepax
Thanks,
Charles
On Tue, Nov 24, 2020 at 06:23:13PM +0100, Lukas F. Hartmann wrote:
> The WM8960 DAC has a "DAC Slope" switch that can toggle between two
> different output filter curves. This patch adds support for it.
>
> Signed-off-by: Lukas F. Hartmann
> ---
> +static int wm8960_put_dacslope(struct
his fixes
> compile warning (!CONFIG_OF on x86_64):
>
> drivers/mfd/wm8994-core.c:618:34: warning: ‘wm8994_of_match’ defined but
> not used [-Wunused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski
> ---
Acked-by: Charles Keepax
Thanks,
Charles
ly logs in case of
> success
>
> Signed-off-by: Lucas Tanure
> ---
Reviewed-by: Charles Keepax
Thanks,
Charles
n.
>
> Another candidate for revert is
> commit ada9e3fcc175 ("spi: dw: Correct handling of native chipselect")
> although I don't understand that code well enough to be sure.
>
> Adding Charles Keepax.
Looks like the code has changed a fair amount since my patch. The
On Thu, Oct 29, 2020 at 03:43:00PM +0800, Coiby Xu wrote:
> SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
>
> Signed-off-by: Coiby Xu
> ---
> sound/soc/codecs/wm8994.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8994.c
recommended by the datasheet for DCVDD supplies that take longer than
2mS to rise.
Signed-off-by: Charles Keepax
---
drivers/mfd/madera-core.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/madera-core.c b/drivers/mfd/madera-core.c
index 4ed6ad8ce0020
-by: Charles Keepax
---
drivers/mfd/madera-core.c | 25 -
include/linux/mfd/madera/core.h | 1 +
2 files changed, 21 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/madera-core.c b/drivers/mfd/madera-core.c
index a9c6f0833f327..a2abc0094def7 100644
On Mon, Oct 19, 2020 at 11:59:37AM -0700, t...@redhat.com wrote:
> From: Tom Rix
>
> A break is not needed if it is preceded by a goto
>
> Signed-off-by: Tom Rix
> ---
Acked-by: Charles Keepax
Thanks,
Charles
... when any
> //
>
> Signed-off-by: Julia Lawall
>
> ---
Acked-by: Charles Keepax
Thanks,
Charles
... when any
> //
>
> Signed-off-by: Julia Lawall
>
> ---
Acked-by: Charles Keepax
Thanks,
Charles
recommended by the datasheet for DCVDD supplies that take longer than
2mS to rise.
Signed-off-by: Charles Keepax
---
drivers/mfd/madera-core.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/madera-core.c b/drivers/mfd/madera-core.c
index 4ed6ad8ce0020
-by: Charles Keepax
---
drivers/mfd/madera-core.c | 25 -
include/linux/mfd/madera/core.h | 1 +
2 files changed, 21 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/madera-core.c b/drivers/mfd/madera-core.c
index a9c6f0833f327..a2abc0094def7 100644
On Mon, Sep 28, 2020 at 09:30:11PM -0400, Sasha Levin wrote:
> From: Charles Keepax
>
> [ Upstream commit 94cc89eb8fa5039fcb6e3e3d50f929ddcccee095 ]
>
> In regmap_debugfs_init the initialisation of the debugfs is delayed
> if the root node isn't ready yet. Most callers of r
memory. Done with the help of Coccinelle.
>
> Signed-off-by: Rikard Falkeborn
> ---
Acked-by: Charles Keepax
Thanks,
Charles
On Mon, Sep 21, 2020 at 10:50:15PM +0200, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski
> -
On Mon, Sep 21, 2020 at 10:50:16PM +0200, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski
> -
On Mon, Sep 21, 2020 at 10:49:35PM +0200, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski
> -
On Thu, Sep 17, 2020 at 06:52:57PM +0200, Krzysztof Kozlowski wrote:
> Include the common GPIO schema in GPIO controllers to be sure all common
> properties are properly validated.
>
> Signed-off-by: Krzysztof Kozlowski
>
> ---
For the Cirrus bits:
Acked-by: Charles Keepax
Thanks,
Charles
On Thu, Sep 17, 2020 at 06:52:56PM +0200, Krzysztof Kozlowski wrote:
> Include the common GPIO schema in GPIO controllers to be sure all common
> properties are properly validated.
>
> Signed-off-by: Krzysztof Kozlowski
>
> ---
For the Cirrus/Wolfson bits:
Acked-by: Charl
Many error paths in __regmap_init rely on ret being pre-initialised to
-EINVAL, add an extra initialisation in after the new call to
regmap_set_name.
Fixes: 94cc89eb8fa5 ("regmap: debugfs: Fix handling of name string for debugfs
init delays")
Reported-by: Dan Carpenter
Signed-off-b
On Fri, Sep 18, 2020 at 03:38:43PM +0300, Dan Carpenter wrote:
> On Fri, Sep 18, 2020 at 12:20:02PM +0100, Charles Keepax wrote:
> > Fixes: 94cc89eb8fa5 ("regmap: debugfs: Fix handling of name string for
> > debugfs init delays")
> > Reported-by: kernel test robot
Fixes: 94cc89eb8fa5 ("regmap: debugfs: Fix handling of name string for debugfs
init delays")
Reported-by: kernel test robot
Reported-by: Dan Carpenter
Signed-off-by: Charles Keepax
---
drivers/base/regmap/regmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
te the cache to match the exact
hardware. Whilst no users do currently update the name here, given the
use-case it seemed reasonable the name might want to be updated once
the device is better identified.
Signed-off-by: Charles Keepax
---
drivers/base/regmap/internal.h | 4 ++--
drivers/base/r
up the
regmap debugfs root isn't ready yet. Although this doesn't crash it
does result in the debugfs entry not having the correct name.
Signed-off-by: Charles Keepax
---
drivers/base/regmap/regmap-debugfs.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/base/reg
On Wed, Sep 16, 2020 at 05:14:18PM +0100, Mark Brown wrote:
> On Wed, Sep 16, 2020 at 04:44:33PM +0100, Charles Keepax wrote:
>
> > - node->name = name;
> > + node->name = kstrdup(name, GFP_KERNEL);
> > + if (!node->n
On Thu, Sep 03, 2020 at 09:40:23AM +0200, Maxime Ripard wrote:
> On Wed, Sep 02, 2020 at 09:22:33PM -0500, Samuel Holland wrote:
> > On 9/2/20 1:10 PM, Jernej Škrabec wrote:
> > > Hi Samuel!
> > >
> > > Dne petek, 10. julij 2020 ob 07:44:51 CEST je Samuel Holland napisal(a):
> > >> On 7/4/20 6:38
-by: Charles Keepax
---
drivers/regulator/lochnagar-regulator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/regulator/lochnagar-regulator.c
b/drivers/regulator/lochnagar-regulator.c
index 5ea3e41416849..cb71fa5f43c3e 100644
--- a/drivers/regulator/lochnagar-regulator.c
+++ b/drivers
e_only flag being set.
>
> Signed-off-by: Sylwester Nawrocki
> ---
Acked-by: Charles Keepax
Thanks,
Charles
onent_update_bits on wm8994-codec"
>
> Signed-off-by: Sylwester Nawrocki
> ---
Acked-by: Charles Keepax
Thanks,
Charles
On Wed, Aug 26, 2020 at 04:49:33PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.
>
> Signed-off-by: Krzysztof Kozlowski
> ---
Acked-by: Charles Keepax
Thanks,
Charles
f-by: Sebastian Krzyszkowiak
> ---
Acked-by: Charles Keepax
Thanks,
Charles
the new MFD mfd_remove_devices_late functionality to split
the DCVDD regulator off from the other drivers.
Signed-off-by: Charles Keepax
---
drivers/mfd/madera-core.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/mfd/madera-core.c b/drivers/mfd
/20200616075834.GF2608702@dell/
Suggested-by: Lee Jones
Signed-off-by: Charles Keepax
---
drivers/mfd/mfd-core.c | 16 +++-
include/linux/mfd/core.h | 5 +
2 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index
> ---
Worth noting I haven't actually tested the gapless, but keeps all
the compressed capture stuff happy.
Tested-by: Charles Keepax
Reviewed-by: Charles Keepax
Thanks,
Charles
On Thu, Jun 25, 2020 at 09:16:49PM +0530, Vinod Koul wrote:
> So we had some discussions of the stream states, so I thought it is a
> good idea to document the state transitions, so add it documentation
>
> Signed-off-by: Vinod Koul
> ---
Reviewed-by: Charles Keepax
Thanks,
Charles
rning: Function parameter or
> member 'pdata' not described in 'wm8350_register_led'
>
> Cc: patc...@opensource.cirrus.com
> Signed-off-by: Lee Jones
> ---
Acked-by: Charles Keepax
Thanks,
Charles
On Thu, Jun 25, 2020 at 09:16:51PM +0530, Vinod Koul wrote:
> On partial_drain completion we should be in SNDRV_PCM_STATE_RUNNING
> state, so set that for partially draining streams in
> snd_compr_drain_notify() and use a flag for partially draining streams
>
> While at it, add locks for stream
bed in 'wm8400_register_regulator'
> drivers/regulator/wm8400-regulator.c:243: warning: Function parameter or
> member 'initdata' not described in 'wm8400_register_regulator'
>
> Cc: patc...@opensource.cirrus.com
> Signed-off-by: Lee Jones
> ---
Acked-by: Charles Keepax
Thanks,
Charles
ck'
> drivers/mfd/wm831x-core.c:145: warning: Function parameter or member
> 'wm831x' not described in 'wm831x_reg_unlock'
>
> Cc:
> Cc: Mark Brown
> Cc: patc...@opensource.cirrus.com
> Signed-off-by: Lee Jones
> ---
Acked-by: Charles Keepax
Thanks,
Charles
et_codec_reg_cache'
>
> Cc:
> Cc: Mark Brown
> Cc: patc...@opensource.cirrus.com
> Signed-off-by: Lee Jones
> ---
Acked-by: Charles Keepax
Thanks,
Charles
On Mon, Jun 22, 2020 at 08:28:48AM -0500, Pierre-Louis Bossart wrote:
> On 6/22/20 1:58 AM, Vinod Koul wrote:
> >++--+
> >+| |
> >+| OPEN |
> >+
When a register patch is registered the reg_sequence is copied but the
memory allocated is never freed. Add a kfree in regmap_exit to clean it
up.
Fixes: 22f0d90a3482 ("regmap: Support register patch sets")
Signed-off-by: Charles Keepax
---
drivers/base/regmap/regmap.c | 1 +
1 file
/20200616075834.GF2608702@dell/
Suggested-by: Lee Jones
Signed-off-by: Charles Keepax
---
Changes since v2:
- Removed old tag system and now just have 2 levels, one removed
by new mfd_remove_devices_late
Thanks,
Charles
drivers/mfd/mfd-core.c | 16 +++-
include/linux/mfd
the new MFD mfd_remove_devices_late functionality to split
the DCVDD regulator off from the other drivers.
Signed-off-by: Charles Keepax
---
Changes since v2:
- Moved to new mfd_remove_devices_late
Thanks,
Charles
drivers/mfd/madera-core.c | 23 +++
1 file changed, 15
On Tue, Jun 16, 2020 at 02:22:59PM +0100, Lee Jones wrote:
> On Tue, 16 Jun 2020, Charles Keepax wrote:
> > On Tue, Jun 16, 2020 at 10:15:45AM +0100, Lee Jones wrote:
> > > On Tue, 16 Jun 2020, Charles Keepax wrote:
> > > > On Tue, Jun 16, 2020 at 08:
On Tue, Jun 16, 2020 at 10:15:45AM +0100, Lee Jones wrote:
> On Tue, 16 Jun 2020, Charles Keepax wrote:
> > On Tue, Jun 16, 2020 at 08:58:34AM +0100, Lee Jones wrote:
> > > On Mon, 15 Jun 2020, Charles Keepax wrote:
> > Does this match how you would expect this to be u
On Tue, Jun 16, 2020 at 08:58:34AM +0100, Lee Jones wrote:
> On Mon, 15 Jun 2020, Charles Keepax wrote:
> > Happy to discuss other approaches as well, but this one
1 - 100 of 3151 matches
Mail list logo
