Checkpatch doesn't like kmalloc with multiply very much:
drivers/staging/comedi/drivers/das1800.c:1377: WARNING: Prefer kmalloc_array
over kmalloc with multiply
So this patch swaps that use out for kmalloc_array instead.
Signed-off-by: Chase Southwood
---
drivers/staging/comedi/drivers
Checkpatch doesn't like kmalloc with multiply very much:
drivers/staging/comedi/drivers/das1800.c:1377: WARNING: Prefer kmalloc_array
over kmalloc with multiply
So this patch swaps that use out for kmalloc_array instead.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
---
drivers
There are a handful of calls to printk in ni_stc.h without specified log
levels, as well as one in ni_mio_common.c. This patch converts these
calls to pr_err() instead, so that they are now explicitly log level
ERR.
Signed-off-by: Chase Southwood
---
I tacked the change to ni_mio_common.c
There are a handful of calls to printk in ni_stc.h without specified log
levels, as well as one in ni_mio_common.c. This patch converts these
calls to pr_err() instead, so that they are now explicitly log level
ERR.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
---
I tacked the change
Returns at the end of void functions are useless. Remove this one.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi-data
The statement nested in an else after a return may be brought out one
indent level, the else is useless.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c
b/drivers/staging/comedi/drivers/addi-data
This patchset begins by cleaning up the mess of the comments in
this driver, then follows that with three very small and trivial
checkpatch warning fixes.
Chase Southwood (4):
staging: comedi: hwdrv_apci3120: clean up comments
staging: comedi: hwdrv_apci3120: add a blank line after
This patch fixes improper comment indentation, removes dead code and
obsolete comments, and conforms remaining comments to a consistent kernel
commenting style.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
.../comedi/drivers/addi-data/hwdrv_apci3120.c | 364
This patch fixes improper comment indentation, removes dead code and
obsolete comments, and conforms remaining comments to a consistent kernel
commenting style.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee
This patchset begins by cleaning up the mess of the comments in
this driver, then follows that with three very small and trivial
checkpatch warning fixes.
Chase Southwood (4):
staging: comedi: hwdrv_apci3120: clean up comments
staging: comedi: hwdrv_apci3120: add a blank line after
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/comedi/drivers/addi-data
Returns at the end of void functions are useless. Remove this one.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 2 --
1 file changed, 2
The statement nested in an else after a return may be brought out one
indent level, the else is useless.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers/addi-data
igned-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
As an aside, it looks like lots of these cases are actually error
conditions that might be more appropriate use cases for dev_err(). But
they could be changed in a follow on patch, this is enough for this one.
.../comedi/drivers/
git-grep reveals that hwdrv_apci1500.c is the only file in comedi that uses
dev-hw_dev in calls to dev_{err,warn}(). The rest of the drivers pass
dev-class_dev to these macros instead. Switch the dev_warn() calls in
this driver to use dev-class_dev as well, for consistency.
Signed-off-by: Chase
This patch completes two final matters of cleanup which are each too small
for their own patch. It corrects a couple of indentation issues and
removes a return statement at the end of a void function.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
.../staging/comedi
Now that commented out code has been removed, else statements can move to
the same line as the close brace of the if statement. Also, a blank line
has been added between declarations and code where needed.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
.../comedi
This patchset begins by removing unneeded braces and commented out lines
of code, and then tidies whitespace issues that are revealed after the
braces/dead code is removed.
Chase Southwood (4):
staging: comedi: hwdrv_apci1500: remove unneeded braces
staging: comedi: hwdrv_apci1500: remove
We don't need braces around single-statement blocks.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
.../comedi/drivers/addi-data/hwdrv_apci1500.c | 30 +-
1 file changed, 12 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/comedi
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
.../comedi/drivers/addi-data/hwdrv_apci1500.c | 249 ++---
1 file changed, 123 insertions(+), 126 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c
b/drivers/staging
dev_err() is preferred to printk() in device drivers.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/addi-data
Checkpatch pointed out a void function with a return statement. It can be
removed.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/comedi
:889:20:got restricted __le16
[usertype]
This is the result of a couple of calls to cpu_to_le16() being assigned to
uint16_t typed variables. Switch the types of these variables/pointers to
__le16 accordingly.
Signed-off-by: Chase Southwood
Suggested-by: Ian Abbott
Cc: H Hartley Sweeten
Sparse shows a couple of warnings like:
drivers/staging/comedi/drivers/usbduxsigma.c:787:23: warning: cast to
restricted __be32
Looking at the indicated lines shows that the issue is caused by an
incorrect cast to uint32_t instead of __be32. Fix this cast.
Signed-off-by: Chase Southwood
Cc
On Sat, Aug 30, 2014 at 5:40 AM, Ian Abbott wrote:
>
> That seems fine. Perhaps the variable 'p' in usbdux_ao_insn_write() should
> also be of type '__le16 *'?
>
You're entirely correct. I had seen this in the output from Sparse,
but for some reason at first glance I had convinced myself that
On Sat, Aug 30, 2014 at 5:40 AM, Ian Abbott abbo...@mev.co.uk wrote:
That seems fine. Perhaps the variable 'p' in usbdux_ao_insn_write() should
also be of type '__le16 *'?
You're entirely correct. I had seen this in the output from Sparse,
but for some reason at first glance I had convinced
/usbdux.c:889:20:got restricted __le16
[usertype] noident
This is the result of a couple of calls to cpu_to_le16() being assigned to
uint16_t typed variables. Switch the types of these variables/pointers to
__le16 accordingly.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Suggested
Sparse shows a couple of warnings like:
drivers/staging/comedi/drivers/usbduxsigma.c:787:23: warning: cast to
restricted __be32
Looking at the indicated lines shows that the issue is caused by an
incorrect cast to uint32_t instead of __be32. Fix this cast.
Signed-off-by: Chase Southwood
Checkpatch pointed out a void function with a return statement. It can be
removed.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c | 2 --
1
dev_err() is preferred to printk() in device drivers.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +-
1 file changed, 1 insertion
We don't need braces around single-statement blocks.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
.../comedi/drivers/addi-data/hwdrv_apci1500.c | 30 +-
1 file changed, 12
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
.../comedi/drivers/addi-data/hwdrv_apci1500.c | 249 ++---
1 file changed, 123 insertions(+), 126 deletions(-)
diff --git
This patchset begins by removing unneeded braces and commented out lines
of code, and then tidies whitespace issues that are revealed after the
braces/dead code is removed.
Chase Southwood (4):
staging: comedi: hwdrv_apci1500: remove unneeded braces
staging: comedi: hwdrv_apci1500: remove
This patch completes two final matters of cleanup which are each too small
for their own patch. It corrects a couple of indentation issues and
removes a return statement at the end of a void function.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H
Now that commented out code has been removed, else statements can move to
the same line as the close brace of the if statement. Also, a blank line
has been added between declarations and code where needed.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 23 --
drivers/staging/comedi/drivers/addi_apci_1564.c| 23 ++
2 files changed, 23 insertions(+), 23 deletions(-)
diff --git
ed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
This is, as usual, compile tested only. I tried to verify as best as I
could that this is a sane change, but I am unable to test on the hardware.
drivers/staging/comedi/drivers/usbdux.c | 4 ++--
1 file changed, 2 insertions(+), 2 del
Sparse has many warnings like:
drivers/staging/comedi/drivers/usbduxsigma.c:293:21: warning: cast to
restricted __be32
on lines on which devpriv->in_buf is passed to be32_to_cpu(). This
suggests that this variable should actually be of type __be32.
Signed-off-by: Chase Southwood
Cc:
Sparse has many warnings like:
drivers/staging/comedi/drivers/usbdux.c:366:32: warning: cast to
restricted __le16
on lines on which devpriv-in_buf or devpriv-insn_buf are passed to
le16_to_cpu(). This suggests that both of these variables should actually
be of type __le16.
Signed-off-by: Chase
Sparse has many warnings like:
drivers/staging/comedi/drivers/usbduxsigma.c:293:21: warning: cast to
restricted __be32
on lines on which devpriv-in_buf is passed to be32_to_cpu(). This
suggests that this variable should actually be of type __be32.
Signed-off-by: Chase Southwood chase.southw
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 23 --
drivers/staging/comedi/drivers/addi_apci_1564.c| 23
We initialize 'irqbit' to 0, only to properly set it immediately
afterwards. Just remove the zero-initialization.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/s626.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging
the return type for this function from int to void, and remove
the two assignments to 'stat'.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/dt2801.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging
the return type for this function from int to void, and remove
the two assignments to 'stat'.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers/dt2801.c | 8 +++-
1 file
We initialize 'irqbit' to 0, only to properly set it immediately
afterwards. Just remove the zero-initialization.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers/s626
en removes the variable.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
It occurred to me while doing this that zero might be or'd twice to
indicate "no information" in order to maintain some three-part structure
used elsewhere. If this is the case, I thi
A recent commit introduced a typo in the definition of
APCI1564_DO_CC_INT_DISABLE. The macro is not use yet, so not a huge deal,
but this patch corrects it.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 2
For purely aesthetic purposes, add some whitespace to subdevice initialization.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 78 -
1 file changed, 39 insertions(+), 39 deletions(-)
diff --git
For purely aesthetic purposes, add some whitespace to subdevice initialization.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 78
A recent commit introduced a typo in the definition of
APCI1564_DO_CC_INT_DISABLE. The macro is not use yet, so not a huge deal,
but this patch corrects it.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee
the variable.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
It occurred to me while doing this that zero might be or'd twice to
indicate no information in order to maintain some three-part structure
e only offsets to counter registers (since
only the counters are offset from dev->iobase).
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 70 --
drivers/staging/comedi/drivers/addi_apci_1564.
will also make future work on the timer and counter subdevices easier.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 54 +-
1 file changed, 12 insertions(+), 42 deletions(-)
diff --git a/drive
The DO config function served the purpose of configuring the diagnostic
interrupts for the board. As the driver currently does not support
diagnostic interrupts, the digital output subdevice does not need an
insn_config operation and this function can be safely removed.
Signed-off-by: Chase
This patchset removes an uncorrect and unneeded insn_config operation,
strips out remaining in-driver watchdog subdevice code, and cleans up the
driver's register map defines.
Chase Southwood (3):
staging: comedi: addi_apci_1564: remove apci1564_do_config
staging: comedi: addi_apci_1564
This patchset removes an uncorrect and unneeded insn_config operation,
strips out remaining in-driver watchdog subdevice code, and cleans up the
driver's register map defines.
Chase Southwood (3):
staging: comedi: addi_apci_1564: remove apci1564_do_config
staging: comedi: addi_apci_1564
The DO config function served the purpose of configuring the diagnostic
interrupts for the board. As the driver currently does not support
diagnostic interrupts, the digital output subdevice does not need an
insn_config operation and this function can be safely removed.
Signed-off-by: Chase
offsets to counter registers (since
only the counters are offset from dev-iobase).
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengraver.com
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 70
future work on the timer and counter subdevices easier.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 54 +-
1 file changed
. So it is safe to simply remove this function.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
.../staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 14 --
drivers/staging/comedi/drivers/addi_apci_1564.c| 18 --
2 files changed, 32
subdevice with an insn_bits handler to access this information.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi
This patchset creates a simple subdevice to allow for reading of the
board's diagnostic status, and then removes any code which is related to
diagnostic interrupts, as the driver will not support these at this time.
Chase Southwood (2):
staging: comedi: addi_apci_1564: add subdevice to check
subdevice with an insn_bits handler to access this information.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 23 ++-
1 file changed, 22
This patchset creates a simple subdevice to allow for reading of the
board's diagnostic status, and then removes any code which is related to
diagnostic interrupts, as the driver will not support these at this time.
Chase Southwood (2):
staging: comedi: addi_apci_1564: add subdevice to check
. So it is safe to simply remove this function.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
.../staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 14 --
drivers/staging/comedi/drivers
On Tue, Jul 15, 2014 at 5:14 AM, Ian Abbott wrote:
> On 2014-07-15 05:00, Chase Southwood wrote:
>>
>> On Mon, Jul 14, 2014 at 4:22 AM, Ian Abbott wrote:
>>>
>>> On 2014-07-12 23:44, Chase Southwood wrote:
>>>>
>>>>
>>>
On Tue, Jul 15, 2014 at 5:14 AM, Ian Abbott abbo...@mev.co.uk wrote:
On 2014-07-15 05:00, Chase Southwood wrote:
On Mon, Jul 14, 2014 at 4:22 AM, Ian Abbott abbo...@mev.co.uk wrote:
On 2014-07-12 23:44, Chase Southwood wrote:
Use the addi_watchdog module to provide support for the watchdog
On Mon, Jul 14, 2014 at 4:22 AM, Ian Abbott wrote:
> On 2014-07-12 23:44, Chase Southwood wrote:
>>
>> Use the addi_watchdog module to provide support for the watchdog
>> subdevice.
>>
>> Also, rearrange the subdevice init blocks so that the order makes sense.
&
On Mon, Jul 14, 2014 at 4:22 AM, Ian Abbott abbo...@mev.co.uk wrote:
On 2014-07-12 23:44, Chase Southwood wrote:
Use the addi_watchdog module to provide support for the watchdog
subdevice.
Also, rearrange the subdevice init blocks so that the order makes sense.
Digital input/output
On Sun, Jul 13, 2014 at 2:17 PM, Hartley Sweeten
wrote:
> On Saturday, July 12, 2014 3:44 PM, Chase Southwood wrote:
>> Use the addi_watchdog module to provide support for the watchdog
>> subdevice.
>>
>> Also, rearrange the subdevice init blocks so that the order ma
On Sun, Jul 13, 2014 at 2:17 PM, Hartley Sweeten
hartl...@visionengravers.com wrote:
On Saturday, July 12, 2014 3:44 PM, Chase Southwood wrote:
Use the addi_watchdog module to provide support for the watchdog
subdevice.
Also, rearrange the subdevice init blocks so that the order makes sense
-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 34 +++--
1 file changed, 20 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi_apci_1564.c
b/drivers/staging/comedi/drivers
This driver no longer depends on anything in addi_common.h, save for a
few headers that it was including indirectly. Remove the include of
addi_common.h and add the includes of
and directly.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi
This driver no longer depends on anything in addi_common.h, save for a
few headers that it was including indirectly. Remove the include of
addi_common.h and add the includes of linux/interrupt.h
and linux/sched.h directly.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott
-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 34 +++--
1 file changed, 20 insertions(+), 14 deletions(-)
diff --git a/drivers/staging
s->maxdata for the do subdevice should be 1, however currently it is
being set to 0x. Fix this.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
This patch is at the end because I'm somewhat uncertain of its
correctness. Every other addi_apci_* dri
The dev->board_name is now initialized by the comedi core before calling
the(*attach) or (*auto_attach) function in a driver. As long as the driver
does no additional probing, it's no longer necessary initialize the board_name.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Swee
There is no need to test whether devpriv is null in this function. The
check looks left over and we can just remove it.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 12
1 file changed, 4 insertions
This value is only needed for subdevices that support async commands.
The comedi core will default the value to 1 when it is not initialized.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 2 --
1 file changed, 2
This is a small patchset containing a handful of fixes to the ADDI-DATA
APCI1564 driver that I would like to get out of the way before I forget
to take care of them. From here, I will move to start fixing the
digital input/timer/counters/watchdog functionality of the board.
Chase Southwood (4
This is a small patchset containing a handful of fixes to the ADDI-DATA
APCI1564 driver that I would like to get out of the way before I forget
to take care of them. From here, I will move to start fixing the
digital input/timer/counters/watchdog functionality of the board.
Chase Southwood (4
This value is only needed for subdevices that support async commands.
The comedi core will default the value to 1 when it is not initialized.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers
s-maxdata for the do subdevice should be 1, however currently it is
being set to 0x. Fix this.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
This patch is at the end because I'm somewhat
The dev-board_name is now initialized by the comedi core before calling
the(*attach) or (*auto_attach) function in a driver. As long as the driver
does no additional probing, it's no longer necessary initialize the board_name.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian
There is no need to test whether devpriv is null in this function. The
check looks left over and we can just remove it.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers
On Thu, Jul 3, 2014 at 4:39 AM, Ian Abbott wrote:
> On 2014-07-03 03:15, Chase Southwood wrote:
>>
>> This patchset moves a misplaced include to the proper file, swaps out an
>> overly
>> aggressive placement of apci1564_reset(), and cleans up
>> apci1564_inte
On Thu, Jul 3, 2014 at 4:39 AM, Ian Abbott abbo...@mev.co.uk wrote:
On 2014-07-03 03:15, Chase Southwood wrote:
This patchset moves a misplaced include to the proper file, swaps out an
overly
aggressive placement of apci1564_reset(), and cleans up
apci1564_interrupt().
Chase Southwood (3
for the register is is accessing, so we can handle all four counters
with a for loop.
Finally, the interrupt handler is incorrectly setting and then checking
devpriv->timer_select_mode before processing some of the triggered
interrupts, so just remove all occurrences of this.
Signed-off-by: Ch
Commit aed3f9d (staging: comedi: addi_apci_1564: absorb apci1564_reset()) moved
the only use of addi_watchdog.h from hwdrv_apci1564.c to addi_apci_1564.c, but
left the include statement itself in the former file. Move this include to the
file which actually uses it.
Signed-off-by: Chase
, and
counters as well. Replace the reset function call with a direct disabling of
just the digital input interrupts.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff
This patchset moves a misplaced include to the proper file, swaps out an overly
aggressive placement of apci1564_reset(), and cleans up apci1564_interrupt().
Chase Southwood (3):
staging: comedi: addi_apci_1564: move addi_watchdog.h include to
addi_apci_1564.c
staging: comedi
This patchset moves a misplaced include to the proper file, swaps out an overly
aggressive placement of apci1564_reset(), and cleans up apci1564_interrupt().
Chase Southwood (3):
staging: comedi: addi_apci_1564: move addi_watchdog.h include to
addi_apci_1564.c
staging: comedi
Commit aed3f9d (staging: comedi: addi_apci_1564: absorb apci1564_reset()) moved
the only use of addi_watchdog.h from hwdrv_apci1564.c to addi_apci_1564.c, but
left the include statement itself in the former file. Move this include to the
file which actually uses it.
Signed-off-by: Chase
, and
counters as well. Replace the reset function call with a direct disabling of
just the digital input interrupts.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers/addi_apci_1564
for the register is is accessing, so we can handle all four counters
with a for loop.
Finally, the interrupt handler is incorrectly setting and then checking
devpriv-timer_select_mode before processing some of the triggered
interrupts, so just remove all occurrences of this.
Signed-off-by: Chase
Hi all,
On Mon, Jun 30, 2014 at 5:25 AM, Ian Abbott wrote:
> On 2014-06-28 05:47, Chase Southwood wrote:
>>
>> This patchset moves a misplaced include to the proper file, swaps out an
>> overly
>> aggressive placement of apci1564_reset(), and cleans up
>>
Hi all,
On Mon, Jun 30, 2014 at 5:25 AM, Ian Abbott abbo...@mev.co.uk wrote:
On 2014-06-28 05:47, Chase Southwood wrote:
This patchset moves a misplaced include to the proper file, swaps out an
overly
aggressive placement of apci1564_reset(), and cleans up
apci1564_interrupt().
Chase
of
devpriv->timer_select_mode before processing any triggered interrupts, remove
all occurrences of this.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
Hartley,
I remember that you mentioned that the counters could be handled using a for
loop here. Is there a better
, and
counters as well. Replace the reset function call with a direct disabling of
just the digital input interrupts.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff
1 - 100 of 412 matches
Mail list logo
