Re: config option for SQUASHFS_CACHED_BLKS,

2018-05-02 Thread Daniel Walker
On 04/25/2018 01:34 PM, Daniel Walker wrote: Hi, We have found that we can attain a better boot time by increasing SQUASHFS_CACHED_BLKS from 8 to 11. We also noticed that you made a special config option for allow people to configure fragment cache size (i.e. SQUASHFS_FRAGMENT_CACHE_SIZE

config option for SQUASHFS_CACHED_BLKS,

2018-04-25 Thread Daniel Walker
Hi, We have found that we can attain a better boot time by increasing SQUASHFS_CACHED_BLKS from 8 to 11. We also noticed that you made a special config option for allow people to configure fragment cache size (i.e. SQUASHFS_FRAGMENT_CACHE_SIZE). Is there anything unsafe about altering the

Re: Detecting page cache trashing state

2017-10-25 Thread Daniel Walker
On 09/28/2017 08:49 AM, Ruslan Ruslichenko -X (rruslich - GLOBALLOGIC INC at Cisco) wrote: Hi Johannes, Hopefully I was able to rebase the patch on top v4.9.26 (latest supported version by us right now) and test a bit. The overall idea definitely looks promising, although I have one question

Re: Detecting page cache trashing state

2017-09-15 Thread Daniel Walker
On 09/15/2017 09:38 AM, Taras Kondratiuk wrote: Quoting Daniel Walker (2017-09-15 07:22:27) On 09/14/2017 05:16 PM, Taras Kondratiuk wrote: Hi In our devices under low memory conditions we often get into a trashing state when system spends most of the time re-reading pages of .text sections

Re: Detecting page cache trashing state

2017-09-15 Thread Daniel Walker
On 09/14/2017 05:16 PM, Taras Kondratiuk wrote: Hi In our devices under low memory conditions we often get into a trashing state when system spends most of the time re-reading pages of .text sections from a file system (squashfs in our case). Working set doesn't fit into available page cache, so

unstable /sys interface from hmon

2017-01-30 Thread Daniel Walker
Hi, Cisco recently upgraded to kernel 4.4.. We have applications which use the /sys interfaces for some hmon drivers. We found that the following patches, https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=bab2243ce1897865e31ea6d59b0478391f51812b https://git.kernel.org/c

Re: [PATCH] sd: assign appropriate log level

2016-10-17 Thread Daniel Walker
On 10/17/2016 10:19 AM, James Bottomley wrote: On Mon, 2016-10-17 at 09:51 -0700, David Singleton wrote: From: Shikhar Dogra Reduce chatter on console for usb hotplug. KERN_ERR is too high severity for these messages, moving them to KERN_WARNING It's an error because we have several USB to ID

Re: checkpatch false positon on EXPORT_SYMBOL

2016-04-12 Thread Daniel Walker
On 04/12/2016 10:49 AM, Joe Perches wrote: On Tue, 2016-04-12 at 13:59 +0100, Andy Whitcroft wrote: diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] @@ -3000,7 +3000,7 @@ sub process { $realline_next = $line_nr_next; if (defined $rea

Re: checkpatch false positon on EXPORT_SYMBOL

2016-04-12 Thread Daniel Walker
On 04/12/2016 05:59 AM, Andy Whitcroft wrote: On Mon, Apr 11, 2016 at 03:09:42PM -0700, Joe Perches wrote: On Mon, 2016-04-11 at 14:51 -0700, Daniel Walker wrote: On 03/31/2016 12:21 PM, Joe Perches wrote: On Thu, 2016-03-31 at 08:01 -0700, Daniel Walker wrote: The below looks like normal

Re: checkpatch false positon on EXPORT_SYMBOL

2016-04-11 Thread Daniel Walker
On 03/31/2016 12:21 PM, Joe Perches wrote: On Thu, 2016-03-31 at 08:01 -0700, Daniel Walker wrote: The below looks like normal code but the last export symbol gets the warning, WARNING:EXPORT_SYMBOL: EXPORT_SYMBOL(foo); should immediately follw its function/variable #16: FILE: kernel/acct.c

[PATCH -v2] drivers: net: ethernet: intel: e1000e: fix ethtool autoneg off for non-copper

2016-04-05 Thread Daniel Walker
call would not fail with -EOPNOTSUPP. e1000_set_spd_dplx should not automatically turn autoneg back on for forced 1000 Mbps full duplex settings for non-copper media. Cc: xe-ker...@external.cisco.com Cc: Daniel Walker Signed-off-by: Steve Shih --- drivers/net/ethernet/intel/e1000e/ethtool.c

Re: [Intel-wired-lan] [PATCH-RFC] drivers: net: ethernet: intel: e1000e: fix ethtool autoneg off for fiber

2016-04-04 Thread Daniel Walker
On 04/03/2016 07:23 AM, Ruinskiy, Dima wrote: I have a couple of comments (sorry for not getting to it a bit sooner). For fiber media, e1000_get_settings should return ETH_TP_MDI_INVALID for eth_tp_mdix_ctrl instead of ETH_TP_MDI_AUTO so subsequent e1000_set_settings call would not fail with -E

checkpatch false positon on EXPORT_SYMBOL

2016-03-31 Thread Daniel Walker
The below looks like normal code but the last export symbol gets the warning, WARNING:EXPORT_SYMBOL: EXPORT_SYMBOL(foo); should immediately follw its function/variable #16: FILE: kernel/acct.c:70: +EXPORT_SYMBOL(test_export);/* Error ! */ It seems to have to do with the comments at the

Re: [PATCH-RFC] drivers: net: ethernet: intel: e1000e: fix ethtool autoneg off for fiber

2016-03-30 Thread Daniel Walker
So Intel maintainers (Jeff, Jesse, Shannon, Carolyn, Don, Bruce, and John) I'm assuming no comments means this patch is acceptable , and I will resubmit it without the RFC. Is that acceptable ? On 03/25/2016 02:58 PM, Daniel Walker wrote: From: Steve Shih This patch fixes the issue

[PATCH-RFC] drivers: net: ethernet: intel: e1000e: fix ethtool autoneg off for fiber

2016-03-25 Thread Daniel Walker
From: Steve Shih This patch fixes the issues for disabling auto-negotiation and forcing speed and duplex settings for the fiber media. For fiber media, e1000_get_settings should return ETH_TP_MDI_INVALID for eth_tp_mdix_ctrl instead of ETH_TP_MDI_AUTO so subsequent e1000_set_settings call would

Re: [PATCH] kernel: fs: drop_caches: add dds drop_caches_count

2016-02-15 Thread Daniel Walker
On 02/15/2016 03:05 PM, Dave Chinner wrote: On Mon, Feb 15, 2016 at 10:19:54AM -0800, Daniel Walker wrote: On 02/14/2016 01:18 PM, Dave Chinner wrote: On Fri, Feb 12, 2016 at 12:14:39PM -0800, Daniel Walker wrote: From: Khalid Mughal Currently there is no way to figure out the droppable

Re: [PATCH] kernel: fs: drop_caches: add dds drop_caches_count

2016-02-15 Thread Daniel Walker
On 02/14/2016 01:18 PM, Dave Chinner wrote: On Fri, Feb 12, 2016 at 12:14:39PM -0800, Daniel Walker wrote: From: Khalid Mughal Currently there is no way to figure out the droppable pagecache size from the meminfo output. The MemFree size can shrink during normal system operation, when some of

Re: computing drop-able caches

2016-02-12 Thread Daniel Walker
On 02/12/2016 10:18 AM, Dave Hansen wrote: On 02/12/2016 10:15 AM, Daniel Walker wrote: On 02/12/2016 10:06 AM, Dave Hansen wrote: On 01/28/2016 03:42 PM, Daniel Walker wrote: My colleague Khalid and I are working on a patch which will provide a /proc file to output the size of the drop-able

[PATCH] kernel: fs: drop_caches: add dds drop_caches_count

2016-02-12 Thread Daniel Walker
drop any pages. Therefore it does not have any impact on system performance. The computation does not include the size of reclaimable slab. Cc: xe-ker...@external.cisco.com Cc: dave.han...@intel.com Cc: han...@cmpxchg.org Cc: r...@redhat.com Signed-off-by: Khalid Mughal Signed-off-by: Daniel Wa

Re: computing drop-able caches

2016-02-12 Thread Daniel Walker
On 02/12/2016 10:18 AM, Dave Hansen wrote: On 02/12/2016 10:15 AM, Daniel Walker wrote: On 02/12/2016 10:06 AM, Dave Hansen wrote: On 01/28/2016 03:42 PM, Daniel Walker wrote: My colleague Khalid and I are working on a patch which will provide a /proc file to output the size of the drop-able

Re: computing drop-able caches

2016-02-12 Thread Daniel Walker
On 02/12/2016 10:06 AM, Dave Hansen wrote: On 01/28/2016 03:42 PM, Daniel Walker wrote: My colleague Khalid and I are working on a patch which will provide a /proc file to output the size of the drop-able page cache. One way to implement this is to use the current drop_caches /proc routine, but

Re: computing drop-able caches

2016-02-10 Thread Daniel Walker
On 02/10/2016 10:13 AM, Dave Hansen wrote: On 02/10/2016 10:04 AM, Daniel Walker wrote: [Linux_0:/]$ echo 3 > /proc/sys/vm/drop_caches [Linux_0:/]$ cat /proc/meminfo MemTotal:3977836 kB MemFree: 1095012 kB MemAvailable:1434148 kB I suspect MemAvailable takes into acco

Re: computing drop-able caches

2016-02-10 Thread Daniel Walker
On 02/08/2016 12:57 PM, Khalid Mughal (khalidm) wrote: How do we explain the discrepancy between MemAvaiable and MemFree count after we drop cache? In following output, which one represents correct data? [Linux_0:/]$ cat /proc/meminfo MemTotal:3977836 kB MemFree: 747832 kB MemAv

Re: computing drop-able caches

2016-01-29 Thread Daniel Walker
On 01/28/2016 05:55 PM, Johannes Weiner wrote: On Thu, Jan 28, 2016 at 05:29:41PM -0800, Daniel Walker wrote: On 01/28/2016 05:03 PM, Daniel Walker wrote: [regarding MemAvaiable] This new metric purportedly helps usrespace assess available memory. But, its again based on heuristic, it takes 1

Re: computing drop-able caches

2016-01-28 Thread Daniel Walker
On 01/28/2016 03:58 PM, Johannes Weiner wrote: On Thu, Jan 28, 2016 at 03:42:53PM -0800, Daniel Walker wrote: "Currently there is no way to figure out the droppable pagecache size from the meminfo output. The MemFree size can shrink during normal system operation, when some of the memory

computing drop-able caches

2016-01-28 Thread Daniel Walker
Hi, My colleague Khalid and I are working on a patch which will provide a /proc file to output the size of the drop-able page cache. One way to implement this is to use the current drop_caches /proc routine, but instead of actually droping the caches just add up the amount. Here's a quote Kha

[PATCH] powerpc: platform: 85xx: mpc85xx ADS: remove pci exclude

2015-11-05 Thread Daniel Walker
xtensively debugged by David Beazley. Cc: xe-ker...@external.cisco.com Cc: dbeaz...@cisco.com Cc: dwal...@fifo99.com Signed-off-by: Daniel Walker --- arch/powerpc/platforms/85xx/mpc85xx_ads.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ads

Re: [PATCH-RFC 5/7] arm: convert to generic builtin command line

2015-10-20 Thread Daniel Walker
On 10/07/2015 02:48 PM, Rob Herring wrote: #ifndef MEM_SIZE > #define MEM_SIZE (16*1024*1024) >@@ -125,16 +126,9 @@ __tagtable(ATAG_REVISION, parse_tag_revision); > > static int __init parse_tag_cmdline(const struct tag *tag) > { >-#if defined(CONFIG_CMDLINE_EXTEND) >- strlcat(de

Re: [PATCH-RFC 6/7] drivers: of: ifdef out cmdline section

2015-10-14 Thread Daniel Walker
On 10/14/2015 10:57 AM, Rob Herring wrote: On Wed, Oct 14, 2015 at 9:48 AM, Daniel Walker wrote: There's one last little wrinkle .. In the current setup the defconfig CONFIG_CMDLINE="" is used as a default in case the device tree has nothing in it. In my changes, there

Re: [PATCH-RFC 6/7] drivers: of: ifdef out cmdline section

2015-10-14 Thread Daniel Walker
There's one last little wrinkle .. In the current setup the defconfig CONFIG_CMDLINE="" is used as a default in case the device tree has nothing in it. In my changes, there is no identical functionality. The only similar thing I have is the the CONFIG_CMDLINE_APPEND="" . The main difference

Re: [PATCH-RFC 6/7] drivers: of: ifdef out cmdline section

2015-10-13 Thread Daniel Walker
On 10/07/2015 02:48 PM, Rob Herring wrote: On Wed, Oct 7, 2015 at 11:27 AM, wrote: On Tue, Oct 06, 2015 at 12:14:43PM -0500, Rob Herring wrote: On Tue, Oct 6, 2015 at 10:47 AM, Daniel Walker wrote: It looks like there's some seepage of cmdline stuff into the generic device tree code.

[PATCH-RFC 6/7] drivers: of: ifdef out cmdline section

2015-10-06 Thread Daniel Walker
It looks like there's some seepage of cmdline stuff into the generic device tree code. This conflicts with the generic cmdline implementation so I remove it in the case when that's enabled. Cc: xe-ker...@external.cisco.com Cc: Daniel Walker Signed-off-by: Daniel Walker --- drivers/of

[PATCH-RFC 3/7] powerpc: convert to generic builtin command line

2015-10-06 Thread Daniel Walker
This updates the powerpc code to use the CONFIG_GENERIC_CMDLINE option. Cc: xe-ker...@external.cisco.com Cc: Daniel Walker Signed-off-by: Daniel Walker --- arch/powerpc/Kconfig| 23 +-- arch/powerpc/kernel/prom.c | 4 arch/powerpc/kernel/prom_init.c

[PATCH-RFC 5/7] arm: convert to generic builtin command line

2015-10-06 Thread Daniel Walker
This updates the arm 32bit code to use the CONFIG_GENERIC_CMDLINE option. Cc: xe-ker...@external.cisco.com Cc: Daniel Walker Signed-off-by: Daniel Walker --- arch/arm/Kconfig | 38 +- arch/arm/kernel/atags_parse.c | 14 -- arch/arm

[PATCH-RFC 4/7] mips: convert to generic builtin command line

2015-10-06 Thread Daniel Walker
This updates the mips code to use the CONFIG_GENERIC_CMDLINE option. Cc: xe-ker...@external.cisco.com Cc: Daniel Walker Signed-off-by: Daniel Walker --- arch/mips/Kconfig| 1 + arch/mips/Kconfig.debug | 47 --- arch/mips/kernel/setup.c | 20

[PATCH-RFC 7/7] arm64: convert to generic builtin command line

2015-10-06 Thread Daniel Walker
This updates the arm64 code to use the CONFIG_GENERIC_CMDLINE option. Cc: xe-ker...@external.cisco.com Cc: Daniel Walker Signed-off-by: Daniel Walker --- arch/arm64/Kconfig| 17 + arch/arm64/kernel/setup.c | 3 +++ 2 files changed, 4 insertions(+), 16 deletions

[PATCH-RFC 2/7] x86: convert to generic builtin command line

2015-10-06 Thread Daniel Walker
This updates the x86 code to use the CONFIG_GENERIC_CMDLINE option. Cc: xe-ker...@external.cisco.com Cc: Daniel Walker Signed-off-by: Daniel Walker --- arch/x86/Kconfig| 44 +--- arch/x86/kernel/setup.c | 19 +++ 2 files changed

[PATCH-RFC 1/7] add generic builtin command line

2015-10-06 Thread Daniel Walker
...@external.cisco.com Cc: Daniel Walker Signed-off-by: Daniel Walker --- include/linux/cmdline.h | 69 + init/Kconfig| 68 2 files changed, 137 insertions(+) create mode 100644 include/linux

Re: [PATCH 2/4] ARM: msm: Remove 7x00 support

2013-10-31 Thread Daniel Walker
On Thu, Oct 31, 2013 at 07:23:30PM +, Russell King - ARM Linux wrote: > On Thu, Oct 31, 2013 at 10:35:06AM -0700, Daniel Walker wrote: > > ARM and the sub-architectures is already confusing I don't think we need > > to start compounding the problem by allowing random whate

Re: [PATCH 2/4] ARM: msm: Remove 7x00 support

2013-10-31 Thread Daniel Walker
On Thu, Oct 31, 2013 at 11:51:34AM -0700, Kevin Hilman wrote: > Daniel Walker writes: > > > On Thu, Oct 31, 2013 at 10:12:03AM -0700, Kevin Hilman wrote: > >> Daniel Walker writes: > >> > >> > >> No. The idea behind splitting them is to allow c

Re: [PATCH 2/4] ARM: msm: Remove 7x00 support

2013-10-31 Thread Daniel Walker
On Thu, Oct 31, 2013 at 10:12:03AM -0700, Kevin Hilman wrote: > Daniel Walker writes: > > > No. The idea behind splitting them is to allow current platforms with > active maintainers to progress without being held back. The older > platforms can stay and have an opport

Re: [PATCH 2/4] ARM: msm: Remove 7x00 support

2013-10-31 Thread Daniel Walker
On Thu, Oct 31, 2013 at 08:53:58AM -0700, Olof Johansson wrote: > On Thu, Oct 31, 2013 at 5:07 AM, Daniel Walker wrote: > > On Wed, Oct 30, 2013 at 10:19:30PM -0700, Olof Johansson wrote: > >> On Wed, Oct 30, 2013 at 7:45 PM, Daniel Walker wrote: > >> > On Wed, Oc

Re: [PATCH 2/4] ARM: msm: Remove 7x00 support

2013-10-31 Thread Daniel Walker
On Wed, Oct 30, 2013 at 10:19:30PM -0700, Olof Johansson wrote: > On Wed, Oct 30, 2013 at 7:45 PM, Daniel Walker wrote: > > On Wed, Oct 30, 2013 at 05:36:58PM -0700, Olof Johansson wrote: > >> On Wed, Oct 30, 2013 at 4:25 PM, Daniel Walker wrote: > >> > >

Re: [PATCH 2/4] ARM: msm: Remove 7x00 support

2013-10-30 Thread Daniel Walker
On Wed, Oct 30, 2013 at 05:36:58PM -0700, Olof Johansson wrote: > On Wed, Oct 30, 2013 at 4:25 PM, Daniel Walker wrote: > > > So the current users of those platforms are, what SOL ? > > What users? Show me one. > What am I chop liver ? Daniel -- To unsubscribe from thi

Re: [PATCH 2/4] ARM: msm: Remove 7x00 support

2013-10-30 Thread Daniel Walker
On Wed, Oct 30, 2013 at 04:08:27PM -0700, Kevin Hilman wrote: > Olof Johansson writes: > > > I would be very happy to take more code for the older Qualcomm chipset > > to enable full functionality for them, but it's been my impression > > that far from all that is needed to make it a useful platf

Re: [PATCH] drivers: misc: stcam: Renesas stcam device

2013-10-30 Thread Daniel Walker
On Wed, Oct 30, 2013 at 02:22:51PM -0700, Greg Kroah-Hartman wrote: > On Wed, Oct 30, 2013 at 12:50:16PM -0700, Daniel Walker wrote: > > On Wed, Oct 30, 2013 at 12:42:06PM -0700, Greg Kroah-Hartman wrote: > > > On Wed, Oct 30, 2013 at 12:17:48PM -0700, Daniel Walker wrote: > &

Re: [PATCH] drivers: misc: stcam: Renesas stcam device

2013-10-30 Thread Daniel Walker
On Wed, Oct 30, 2013 at 12:42:06PM -0700, Greg Kroah-Hartman wrote: > On Wed, Oct 30, 2013 at 12:17:48PM -0700, Daniel Walker wrote: > > This is a driver for the ternary content addressable memory unit from > > Renesas. It > > allows filtering on bits, and wildcards thru the

[PATCH] drivers: misc: stcam: Renesas stcam device

2013-10-30 Thread Daniel Walker
This is a driver for the ternary content addressable memory unit from Renesas. It allows filtering on bits, and wildcards thru the chip. Signed-off-by: Daniel Walker --- drivers/misc/Kconfig | 7 + drivers/misc/Makefile | 1 + drivers/misc/stcam.c | 348

Re: [PATCH 4/4] ARM: msm: Remove 8x50 support

2013-10-30 Thread Daniel Walker
On Wed, Oct 30, 2013 at 02:30:23PM +0100, Arnd Bergmann wrote: > On Tuesday 29 October 2013, Daniel Walker wrote: > > Isn't this the Nexus one platform ? Same as the last one , why don't you > > just update it to use the device tree? This doesn't seem like it w

Re: [PATCH 4/4] ARM: msm: Remove 8x50 support

2013-10-29 Thread Daniel Walker
Isn't this the Nexus one platform ? Same as the last one , why don't you just update it to use the device tree? This doesn't seem like it would be all that difficult. On Mon, Oct 28, 2013 at 01:43:26PM -0700, David Brown wrote: > The MSM8x50 SoC support was added in 2010 based on code from Go

Re: [PATCH 3/4] ARM: msm: Remove 7x30 supporty

2013-10-29 Thread Daniel Walker
Why wouldn't you just update it to use the device tree ? There are lots of phones our there using 7x30 .. This is one that Qualcomm specifically upstreamed, so what was the point of upstreaming it ? On Mon, Oct 28, 2013 at 01:43:25PM -0700, David Brown wrote: > The MSM7x30 SoC support was adde

Re: [PATCH 2/4] ARM: msm: Remove 7x00 support

2013-10-29 Thread Daniel Walker
On Tue, Oct 29, 2013 at 10:39:45AM -0700, Olof Johansson wrote: > On Tue, Oct 29, 2013 at 10:08 AM, Daniel Walker wrote: > > > Personally I think splitting mach- stuff isn't very useful or > > interesting.. There's just no technical reason for it, for example x86 >

Re: [PATCH 2/4] ARM: msm: Remove 7x00 support

2013-10-29 Thread Daniel Walker
On Tue, Oct 29, 2013 at 08:37:28AM -0700, Olof Johansson wrote: > Daniel, > > I would be very happy to take more code for the older Qualcomm chipset > to enable full functionality for them, but it's been my impression > that far from all that is needed to make it a useful platform is in > the upst

Re: [PATCH 2/4] ARM: msm: Remove 7x00 support

2013-10-29 Thread Daniel Walker
That's not very nice .. You know there is a device connect with this that several of us have.. On Mon, Oct 28, 2013 at 01:43:24PM -0700, David Brown wrote: > Support for the MSM7x00 SoCs was added starting in 2008 based on code > from Google's Android kernels. Platform support is fairly minimal

Re: [PATCH 3/3] cgroups: remove calls to simple_kstrtoll

2013-10-27 Thread Daniel Walker
Sure , I can add it .. It's because simple_strtoll is obsolete .. On Sun, Oct 27, 2013 at 07:39:25AM -0400, Tejun Heo wrote: > On Fri, Oct 25, 2013 at 07:33:13PM -0700, Daniel Walker wrote: > > Signed-off-by: Daniel Walker > > Can you please briefly explain why this conver

Re: [PATCH 2/3] fs: nfsd: remove calls to simple_strtoll

2013-10-27 Thread Daniel Walker
On Sat, Oct 26, 2013 at 02:41:24PM -0400, J. Bruce Fields wrote: > On Fri, Oct 25, 2013 at 07:33:12PM -0700, Daniel Walker wrote: > > Signed-off-by: Daniel Walker > > --- > > fs/nfsd/fault_inject.c | 12 > > 1 file changed, 8 insertions(+), 4 deletions(

[PATCH 3/3] cgroups: remove calls to simple_kstrtoll

2013-10-25 Thread Daniel Walker
Signed-off-by: Daniel Walker --- kernel/cgroup.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/kernel/cgroup.c b/kernel/cgroup.c index 41f71c3..bf8b891 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c @@ -2276,7 +2276,7 @@ static ssize_t cgroup_write_X64

[PATCH 2/3] fs: nfsd: remove calls to simple_strtoll

2013-10-25 Thread Daniel Walker
Signed-off-by: Daniel Walker --- fs/nfsd/fault_inject.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/fs/nfsd/fault_inject.c b/fs/nfsd/fault_inject.c index d620e7f..41165f0 100644 --- a/fs/nfsd/fault_inject.c +++ b/fs/nfsd/fault_inject.c @@ -125,20 +125,24

[PATCH 1/3] fs: libfs: remove calls to simple_strtoll

2013-10-25 Thread Daniel Walker
Signed-off-by: Daniel Walker --- fs/libfs.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/fs/libfs.c b/fs/libfs.c index 8c50184..0467f6e 100644 --- a/fs/libfs.c +++ b/fs/libfs.c @@ -845,10 +845,13 @@ ssize_t simple_attr_write(struct file *file, const char

Re: latencytop.org defunkt ?

2013-10-16 Thread Daniel Walker
On Sun, Oct 13, 2013 at 12:09:42PM -0700, Arjan van de Ven wrote: > somehow the domain no longer points to the right spot/etc > > my attempts to get that fixed have failed so far ;-( > Should we put the source into linux/tools/ ? With the site down it took some effort to find the source. Danie

latencytop.org defunkt ?

2013-10-09 Thread Daniel Walker
Hi, Are you aware that http://www.latencytop.org/ is not functioning ? I was trying to get the update source code, but seem there is no place to do that. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More ma

[PATCH 2/2] drivers: edac: octeon: add error injection support

2013-09-20 Thread Daniel Walker
This adds an ad-hoc error injection method. Octeon II doesn't have hardware support for injection, so this simulates it. Signed-off-by: Daniel Walker --- drivers/edac/octeon_edac-lmc.c | 177 +++-- 1 file changed, 171 insertions(+), 6 deletions(-) diff

[PATCH 1/2] drivers: edac: octeon: fix lack of opstate_init

2013-09-20 Thread Daniel Walker
If the opstate_init() isn't called the driver won't start properly. I just added it in what appears to be an appropriate place. Signed-off-by: Daniel Walker --- drivers/edac/octeon_edac-lmc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/edac/octeon_edac-lmc.c b/dr

crash in sys_get_curr_temp

2013-07-10 Thread Daniel Walker
Hi, I get this crash on linux-next as of today .. [4.678947] general protection fault: [#1] SMP 2 [4.678953] CPU: 0 PID: 1 C

Re: ptracing a task from core_pattern pipe

2013-03-26 Thread Daniel Walker
On Mon, Mar 25, 2013 at 10:48:07AM +0100, Denys Vlasenko wrote: > On 03/19/2013 09:19 PM, Oleg Nesterov wrote: > >> The above is regarding the situation which I'm running my corepipe_app , > >> i.e. my system doesn't have a disk to save a core file for parsing. > > > > Can't you process the data i

Re: ptracing a task from core_pattern pipe

2013-03-18 Thread Daniel Walker
On Mon, Mar 18, 2013 at 06:03:02PM +0100, Oleg Nesterov wrote: > > Assume that's not happening, why would ptrace give me -ESRCH, yet > > /proc//status would show me ptrace attached to the thread. > > And why do you think this should be explained by SIGKILL? It's an assumption, if I knew before yo

Re: ptracing a task from core_pattern pipe

2013-03-17 Thread Daniel Walker
On Sun, Mar 17, 2013 at 03:34:46PM +0100, Oleg Nesterov wrote: > > > (Just in case, this was recently changed. After > > > coredump-ensure-that-sigkill-always-kills-the-dumping-thread.patch in -mm > > > tree the dumper doesn't run in SIGNAL_GROUP_EXIT, but probably this > > > doesn't matter) > >

Re: ptracing a task from core_pattern pipe

2013-03-16 Thread Daniel Walker
On Sat, Mar 16, 2013 at 06:58:45PM +0100, Oleg Nesterov wrote: > On 03/15, Daniel Walker wrote: > > > > I was writing an application to ptrace a process which is dumping core > > from inside the pipe application for core_pattern. > > This was never possible. And never w

ptracing a task from core_pattern pipe

2013-03-15 Thread Daniel Walker
Hi, I was writing an application to ptrace a process which is dumping core from inside the pipe application for core_pattern. So for example you make core pattern equal to something like "|/bin/corepipe_app" then the kernel runs that app prior to actually killing the process that failed. Before

Re: [patch 2/3] Convert ccp->readmutex in a mutex

2008-02-19 Thread Daniel Walker
On Mon, Feb 18, 2008 at 08:45:35PM +0100, [EMAIL PROTECTED] wrote: > @@ -1391,7 +1391,7 @@ > > /* Initialize device descriptor */ > init_MUTEX( &ccp->mutex); > - init_MUTEX( &ccp->readmutex); > + mutex_init(&ccp->readmutex); > auerbuf_init (&ccp->bufctl); > c

Re: 2.6.25-rc2-mm1: new create_proc_entry() users

2008-02-18 Thread Daniel Walker
On Sun, Feb 17, 2008 at 01:50:50PM +0300, Alexey Dobriyan wrote: > > profile-likely-unlikely-macros > > page-owner-tracking-leak-detector > > cciss-procfs-updates-to-display-info-about-many-volumes > > Guys, create_proc_entry() is slightly racy in case of modular code and > proc_create() was inven

Re: CPU hotplug and IRQ affinity with 2.6.24-rt1

2008-02-05 Thread Daniel Walker
On Tue, Feb 05, 2008 at 11:25:18AM -0700, Gregory Haskins wrote: > @@ -6241,7 +6242,7 @@ static void rq_attach_root(struct rq *rq, struct > root_domain *rd) > cpu_clear(rq->cpu, old_rd->online); > > if (atomic_dec_and_test(&old_rd->refcount)) > -

Re: CPU hotplug and IRQ affinity with 2.6.24-rt1

2008-02-05 Thread Daniel Walker
On Mon, Feb 04, 2008 at 10:02:12PM -0700, Gregory Haskins wrote: > >>> On Mon, Feb 4, 2008 at 9:51 PM, in message > <[EMAIL PROTECTED]>, Daniel Walker > <[EMAIL PROTECTED]> wrote: > > I get the following when I tried it, > > > > BUG: sleeping fu

Re: CPU hotplug and IRQ affinity with 2.6.24-rt1

2008-02-04 Thread Daniel Walker
On Mon, Feb 04, 2008 at 03:35:13PM -0800, Max Krasnyanskiy wrote: > This is just an FYI. As part of the "Isolated CPU extensions" thread Daniel > suggest for me > to check out latest RT kernels. So I did or at least tried to and immediately > spotted a couple > of issues. > > The machine I'm runn

[PATCH] fix workqueue plist init to include a spinlock

2008-01-29 Thread Daniel Walker
The lock field in plist_head_init() is used for debugging the plist, and if a NULL is sent in it spews constant errors with debugging enabled .. So I added what looks like the correct spinlocks into the plist_head_init(). Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- kernel/workq

Re: [CPUISOL] CPU isolation extensions

2008-01-28 Thread Daniel Walker
On Mon, 2008-01-28 at 16:12 -0800, Max Krasnyanskiy wrote: > Not accurate enough and way too much overhead for what I need. I know at this > point it probably > sounds like I'm talking BS :). I wish I've released the engine and examples > by now. Anyway let > me just say that SW MAC has crazy

Re: [CPUISOL] CPU isolation extensions

2008-01-28 Thread Daniel Walker
On Mon, 2008-01-28 at 10:32 -0800, Max Krasnyanskiy wrote: > Just this patches. RT patches cannot achieve what I needed. Even RTAI/Xenomai > can't do that. > For example I have separate tasks with hard deadlines that must be enforced > in 50usec kind > of range and basically no idle time whatso

Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interrupts disabled

2008-01-23 Thread Daniel Walker
On Wed, 2008-01-23 at 10:50 -0800, Daniel Walker wrote: > On Wed, 2008-01-23 at 13:43 -0500, Steven Rostedt wrote: > > On Wed, 23 Jan 2008, Daniel Walker wrote: > > > > > > > > On Wed, 2008-01-23 at 13:18 -0500, Steven Rostedt wrote: > > > > > >

Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interrupts disabled

2008-01-23 Thread Daniel Walker
On Wed, 2008-01-23 at 13:43 -0500, Steven Rostedt wrote: > On Wed, 23 Jan 2008, Daniel Walker wrote: > > > > > On Wed, 2008-01-23 at 13:18 -0500, Steven Rostedt wrote: > > > > > The wakeup hook in schedule is when we find out that we hit our max. I > >

Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interrupts disabled

2008-01-23 Thread Daniel Walker
On Wed, 2008-01-23 at 13:18 -0500, Steven Rostedt wrote: > The wakeup hook in schedule is when we find out that we hit our max. I > could postpone that somehow, but that would require more glue code than I > would like to add. Which hook specifically ? > As for -rt, we've disabled printk for co

Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interrupts disabled

2008-01-23 Thread Daniel Walker
> if (wake_klogd && !runqueue_is_locked()) > wake_up_klogd(); > > This probably is the cleanest solution since it simply prevents the > deadlock from occurring. Do you really need to call it with the runqueue lock held .. There are other issue with the calls at that level.. F

Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interrupts disabled

2008-01-23 Thread Daniel Walker
On Wed, 2008-01-23 at 11:02 -0500, Steven Rostedt wrote: > + if (!irqs_disabled() && wake_klogd) > wake_up_klogd(); This causes a regression .. When printk is called during an OOPS in kernels without this change then the OOPS will get logged, since the logging process (klogd) i

Re: 2.6.24-rc8-rt1: Strange latencies on mpc5200 powerpc

2008-01-23 Thread Daniel Walker
On Wed, 2008-01-23 at 15:53 +0100, Luotao Fu wrote: > I was doing some tests on my mpc5200b Board to reproduce the high latency as > measured by wolfgang. > > I ran some tests with > while [ 1 ]; do ls /bin;done > as non-rt workload, as in Wolfgangs Scenario. > Can you try enabling CRITICAL_P

Re: [PATCH] fix wrong sized spinlock flags argument

2008-01-17 Thread Daniel Walker
On Thu, 2008-01-17 at 15:48 -0800, Linus Torvalds wrote: > Applied. > > However, the patch itself didn't apply cleanly, because in my souce tree, > these two lines are in a different order: > > On Thu, 17 Jan 2008, Daniel Walker wrote: > > > >

Re: setting jiffies as the clocksource stops time

2008-01-17 Thread Daniel Walker
On Thu, 2008-01-17 at 23:34 +0100, Jan Engelhardt wrote: > On Jan 16 2008 13:20, Daniel Walker wrote: > >On Thu, 2008-01-17 at 02:09 +0530, Balaji Rao wrote: > >> Hi, > >> > >> When i set jiffies as the current_clocksource, date(1) tells me > >> th

[PATCH] fix wrong sized spinlock flags argument

2008-01-17 Thread Daniel Walker
Correct wrong sized spinlock flags, form int to unsigned long. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- drivers/media/video/saa7134/saa7134-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.23/drivers/media/video/saa7134/saa7134-

Re: 2.6.24-rc8-rt1

2008-01-17 Thread Daniel Walker
On Thu, 2008-01-17 at 19:17 +0100, Wolfgang Grandegger wrote: > [0.733248] TCP bind hash table entries: 2048 (order: 3, 57344 > bytes) > [0.741132] TCP: Hash tables configured (established 2048 bind > 2048) > [0.747981] TCP reno registered > [0.805896] krcupreemptd setsched 0 > [

Re: 2.6.24-rc8-rt1

2008-01-17 Thread Daniel Walker
On Thu, 2008-01-17 at 11:13 +0100, Wolfgang Grandegger wrote: > Steven Rostedt wrote: > > We are pleased to announce the 2.6.24-rc8-rt1 tree, which can be > > downloaded from the location: > > > > http://rt.et.redhat.com/download/ > > It builds and runs fine on my Icecube-MPC5200 board, now al

Re: setting jiffies as the clocksource stops time

2008-01-16 Thread Daniel Walker
On Thu, 2008-01-17 at 02:09 +0530, Balaji Rao wrote: > Hi, > > When i set jiffies as the current_clocksource, date(1) tells me that > wallclock time has stopped, and soon after that, the > system becomes unresponsive. This is not seen with CONFIG_NO_HZ disabled. > > This happens in 2.6.24-rc4,

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Daniel Walker
On Mon, 2008-01-14 at 20:31 +0100, Stefan Richter wrote: > AFAIU Daniel's patch still leaves the possibility to use the '-' > syntax, > doesn't it? > > (The program 'cat' is of the kind which always reads from stdin if no > file name is given, or if '-' is given instead of a file name. So, > 'ca

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Daniel Walker
On Mon, 2008-01-14 at 19:12 +, Andy Whitcroft wrote: > So it does, however that of itself differs from the unix norm; as with > this I cannot run checkpatch and "type" (ie paste) a patch fragment to > check it. So I don't think we want the semantics as you have there, > as its confusing to th

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Daniel Walker
On Mon, 2008-01-14 at 17:17 +, Andy Whitcroft wrote: > On Fri, Jan 11, 2008 at 06:06:35PM +0100, Stefan Richter wrote: > > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > > Acked-by: Jiri Slaby <[EMAIL PROTECTED]> > > As an absolute minimum this seems reasonable to me. I guess we could >

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-11 Thread Daniel Walker
On Fri, 2008-01-11 at 18:29 +0100, Stefan Richter wrote: > Daniel Walker wrote: > > On Fri, 2008-01-11 at 18:06 +0100, Stefan Richter wrote: > >> Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > >> + print "When patchfile is -, read standard input.\n&

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-11 Thread Daniel Walker
On Fri, 2008-01-11 at 18:06 +0100, Stefan Richter wrote: > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > Acked-by: Jiri Slaby <[EMAIL PROTECTED]> > --- > scripts/checkpatch.pl |1 + > 1 file changed, 1 insertion(+) > > Index: linux/scripts/checkpatch.pl > ==

Re: [PATCH] checkpatch.pl: allow piping

2008-01-11 Thread Daniel Walker
On Fri, 2008-01-11 at 10:41 +0100, Jiri Slaby wrote: > On 01/11/2008 10:36 AM, Daniel Walker wrote: > > On Fri, 2008-01-11 at 10:34 +0100, Jiri Slaby wrote: > >> If somebody is hacking kernel, I think he should know the - trick used in > >> many > >> programs

Re: [PATCH] checkpatch.pl: allow piping

2008-01-11 Thread Daniel Walker
On Fri, 2008-01-11 at 10:34 +0100, Jiri Slaby wrote: > On 01/11/2008 10:30 AM, Daniel Walker wrote: > > On Fri, 2008-01-11 at 10:23 +0100, Bernd Petrovitsch wrote: > >> On Fre, 2008-01-11 at 10:21 +0100, Jiri Slaby wrote: > >>> git show 9914cad54c79d0b89b1f066c089

Re: [PATCH] checkpatch.pl: allow piping

2008-01-11 Thread Daniel Walker
On Fri, 2008-01-11 at 10:23 +0100, Bernd Petrovitsch wrote: > On Fre, 2008-01-11 at 10:21 +0100, Jiri Slaby wrote: > > On 01/11/2008 10:17 AM, Daniel Walker wrote: > > > On Fri, 2008-01-11 at 09:52 +0100, Jiri Slaby wrote: > > >> On 01/11/2008 05:10 AM, Daniel

Re: [PATCH] checkpatch.pl: allow piping

2008-01-11 Thread Daniel Walker
On Fri, 2008-01-11 at 09:52 +0100, Jiri Slaby wrote: > On 01/11/2008 05:10 AM, Daniel Walker wrote: > > A little feature addition to allow checkpatch.pl to check patches piped > > into it, in addition to specific file arguments. > > You can still add - as an argument to chec

[PATCH] checkpatch.pl: allow piping

2008-01-10 Thread Daniel Walker
A little feature addition to allow checkpatch.pl to check patches piped into it, in addition to specific file arguments. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- scripts/checkpatch.pl | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) Index: linux-2.6.23/s

Re: [x86] list of style offenders

2008-01-10 Thread Daniel Walker
On Fri, 2008-01-11 at 00:40 +0100, Paolo Ciarrocchi wrote: > On Jan 11, 2008 12:08 AM, Daniel Walker <[EMAIL PROTECTED]> wrote: > > > The git logs also show that arch/x86/math-emu/fpu_trig.c hasn't been > > modified since it was pull in on Oct. 11 .. > > D

<    1   2   3   4   5   6   7   8   9   >