Re: KASAN: use-after-free Read in erspan_build_header

[ cc William Tu] On 1/22/18 12:58 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 0d665e7b109d512b7cae3ccef6e8654714887844 (Fri Jan 19 12:49:24 2018 +) > mm, page_vma_mapped: Drop faulty pointer arithmetics in check_pte() > > So far this crash happened 11

lightweight netdevs Jan 2018 edition [Re: [PATCH net-next v2] net: core: Expose number of link up/down transitions]

On 1/22/18 1:46 PM, Florian Fainelli wrote: >> >> Like David Ahern I am strongly against the proliferation of sysfs files >> attached to network devices and the per-netdevice costs associated with >> that. >> >> However, dealing with that is a longer term i

lightweight netdevs Jan 2018 edition [Re: [PATCH net-next v2] net: core: Expose number of link up/down transitions]

On 1/22/18 1:46 PM, Florian Fainelli wrote: >> >> Like David Ahern I am strongly against the proliferation of sysfs files >> attached to network devices and the per-netdevice costs associated with >> that. >> >> However, dealing with that is a longer term i

Re: [PATCH net-next] net: core: Expose number of link up/down transitions

On 1/17/18 3:06 PM, Florian Fainelli wrote: > diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c > index 7bf8b85ade16..9f732c3dc2ce 100644 > --- a/net/core/net-sysfs.c > +++ b/net/core/net-sysfs.c > @@ -295,10 +295,29 @@ static ssize_t carrier_changes_show(struct device *dev, > struct

Re: [PATCH net-next] net: core: Expose number of link up/down transitions

On 1/17/18 3:06 PM, Florian Fainelli wrote: > diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c > index 7bf8b85ade16..9f732c3dc2ce 100644 > --- a/net/core/net-sysfs.c > +++ b/net/core/net-sysfs.c > @@ -295,10 +295,29 @@ static ssize_t carrier_changes_show(struct device *dev, > struct

Re: [PATCH net-next] net: core: Expose number of link up/down transitions

On 1/17/18 3:52 PM, Jiri Pirko wrote: > Thu, Jan 18, 2018 at 12:06:57AM CET, f.faine...@gmail.com wrote: >> From: David Decotigny >> >> Expose the number of times the link has been going UP or DOWN, and >> update the "carrier_changes" counter to be the sum of these two events.

Re: [PATCH net-next] net: core: Expose number of link up/down transitions

On 1/17/18 3:52 PM, Jiri Pirko wrote: > Thu, Jan 18, 2018 at 12:06:57AM CET, f.faine...@gmail.com wrote: >> From: David Decotigny >> >> Expose the number of times the link has been going UP or DOWN, and >> update the "carrier_changes" counter to be the sum of these two events. >> While at it,

Re: KASAN: stack-out-of-bounds Read in __nla_put

On 1/17/18 2:39 AM, Xin Long wrote: > I guess you need to move up your memset(0) a little bit: > > @@ -2427,6 +2443,7 @@ int netlink_rcv_skb(struct sk_buff *skb, int > (*cb)(struct sk_buff *, > nlh = nlmsg_hdr(skb); > err = 0; > > + memset(, 0,

Re: KASAN: stack-out-of-bounds Read in __nla_put

On 1/17/18 2:39 AM, Xin Long wrote: > I guess you need to move up your memset(0) a little bit: > > @@ -2427,6 +2443,7 @@ int netlink_rcv_skb(struct sk_buff *skb, int > (*cb)(struct sk_buff *, > nlh = nlmsg_hdr(skb); > err = 0; > > + memset(, 0,

Re: WARNING in netlink_ack (2)

On 1/12/18 4:34 AM, Xin Long wrote: >> audit: type=1400 audit(1515595879.379:7): avc: denied { map } for >> pid=3498 comm="syzkaller002174" path="/root/syzkaller002174137" dev="sda1" >> ino=16481 scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 >>

Re: WARNING in netlink_ack (2)

On 1/12/18 4:34 AM, Xin Long wrote: >> audit: type=1400 audit(1515595879.379:7): avc: denied { map } for >> pid=3498 comm="syzkaller002174" path="/root/syzkaller002174137" dev="sda1" >> ino=16481 scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 >>

Re: general protection fault in fib6_add (2)

[ +wei...@google.com ] On 1/2/18 3:58 PM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 61233580f1f33c50e159c50e24d80ffd2ba2e06b > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: general protection fault in fib6_add (2)

[ +wei...@google.com ] On 1/2/18 3:58 PM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 61233580f1f33c50e159c50e24d80ffd2ba2e06b > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: INFO: task hung in bpf_exit_net

On 12/19/17 5:47 AM, Dmitry Vyukov wrote: > On Tue, Dec 19, 2017 at 1:36 PM, syzbot > > wrote: >> Hello, >> >> syzkaller hit the following crash on >> 7ceb97a071e80f1b5e4cd5a36de135612a836388 >>

Re: INFO: task hung in bpf_exit_net

On 12/19/17 5:47 AM, Dmitry Vyukov wrote: > On Tue, Dec 19, 2017 at 1:36 PM, syzbot > > wrote: >> Hello, >> >> syzkaller hit the following crash on >> 7ceb97a071e80f1b5e4cd5a36de135612a836388 >> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master >> compiler: gcc (GCC) 7.1.1

Re: INFO: task hung in cleanup_net

On 12/19/17 5:47 AM, Dmitry Vyukov wrote: > On Tue, Dec 19, 2017 at 1:33 PM, syzbot > > wrote: >> Hello, >> >> syzkaller hit the following crash on >> e40fd8d6b4d9f59b160faa1736f78fc07533ff37 >>

Re: INFO: task hung in cleanup_net

On 12/19/17 5:47 AM, Dmitry Vyukov wrote: > On Tue, Dec 19, 2017 at 1:33 PM, syzbot > > wrote: >> Hello, >> >> syzkaller hit the following crash on >> e40fd8d6b4d9f59b160faa1736f78fc07533ff37 >> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master >> compiler: gcc (GCC) 7.1.1

Re: [PATCH v4 net-next 4/4] bpftool: implement cgroup bpf operations

akub Kicinski <jakub.kicin...@netronome.com> > Cc: Martin KaFai Lau <ka...@fb.com> > Cc: Quentin Monnet <quentin.mon...@netronome.com> > Reviewed-by: David Ahern <dsah...@gmail.com> > --- The updates for attach flags and man page look great. Very user friendly. Thanks for the work on it.

Re: [PATCH v4 net-next 4/4] bpftool: implement cgroup bpf operations

gt; $ bpftool cgroup attach CGROUP ATTACH_TYPE PROG [ATTACH_FLAGS] > $ bpftool cgroup detach CGROUP ATTACH_TYPE PROG > > Signed-off-by: Roman Gushchin > Cc: Alexei Starovoitov > Cc: Daniel Borkmann > Cc: Jakub Kicinski > Cc: Martin KaFai Lau > Cc: Quentin Monnet > R

Re: [PATCH net-next] libbpf: add function to setup XDP

On 12/10/17 1:34 PM, Eric Leblond wrote: >> Would it be possible to print out or preferably return to the caller >> the ext ack error message? A couple of drivers are using it for XDP >> mis-configuration reporting instead of printks. We should encourage >> other to do the same and support it in

Re: [PATCH net-next] libbpf: add function to setup XDP

On 12/10/17 1:34 PM, Eric Leblond wrote: >> Would it be possible to print out or preferably return to the caller >> the ext ack error message? A couple of drivers are using it for XDP >> mis-configuration reporting instead of printks. We should encourage >> other to do the same and support it in

Re: [PATCH net-next] libbpf: add function to setup XDP

On 12/9/17 7:43 AM, Eric Leblond wrote: > + /* started nested attribute for XDP */ > + nla = (struct nlattr *)(((char *)) > + + NLMSG_ALIGN(req.nh.nlmsg_len)); > + nla->nla_type = NLA_F_NESTED | 43/*IFLA_XDP*/; as a part of the move into libbpf can the

Re: [PATCH net-next] libbpf: add function to setup XDP

On 12/9/17 7:43 AM, Eric Leblond wrote: > + /* started nested attribute for XDP */ > + nla = (struct nlattr *)(((char *)) > + + NLMSG_ALIGN(req.nh.nlmsg_len)); > + nla->nla_type = NLA_F_NESTED | 43/*IFLA_XDP*/; as a part of the move into libbpf can the

Re: [PATCH v3 net-next 4/4] bpftool: implement cgroup bpf operations

On 12/8/17 4:46 PM, Jakub Kicinski wrote: >> +argc -= 2; >> +argv = [2]; >> +prog_fd = prog_parse_fd(, ); >> +if (prog_fd < 0) >> +goto exit_cgroup; >> + >> +for (i = 0; i < argc; i++) { >> +if (strcmp(argv[i], "allow_multi") == 0) { >> +

Re: [PATCH v3 net-next 4/4] bpftool: implement cgroup bpf operations

On 12/8/17 4:46 PM, Jakub Kicinski wrote: >> +argc -= 2; >> +argv = [2]; >> +prog_fd = prog_parse_fd(, ); >> +if (prog_fd < 0) >> +goto exit_cgroup; >> + >> +for (i = 0; i < argc; i++) { >> +if (strcmp(argv[i], "allow_multi") == 0) { >> +

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

On 12/8/17 8:39 AM, Quentin Monnet wrote: > I don't believe compatibility is an issue here, since the program and > its documentation come together (so they should stay in sync) and are > part of the kernel tree (so the tool should be compatible with the > kernel sources it comes with). My concern

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

On 12/8/17 8:39 AM, Quentin Monnet wrote: > I don't believe compatibility is an issue here, since the program and > its documentation come together (so they should stay in sync) and are > part of the kernel tree (so the tool should be compatible with the > kernel sources it comes with). My concern

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

akub Kicinski <jakub.kicin...@netronome.com> > Cc: Martin KaFai Lau <ka...@fb.com> > Cc: Quentin Monnet <quentin.mon...@netronome.com> > Cc: David Ahern <dsah...@gmail.com> > --- LGTM. Reviewed-by: David Ahern <dsah...@gmail.com>

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

gt; $ bpftool cgroup attach CGROUP ATTACH_TYPE PROG [ATTACH_FLAGS] > $ bpftool cgroup detach CGROUP ATTACH_TYPE PROG > > Signed-off-by: Roman Gushchin > Cc: Alexei Starovoitov > Cc: Daniel Borkmann > Cc: Jakub Kicinski > Cc: Martin KaFai Lau > Cc: Quentin Monnet &

Re: [PATCH] netlink: Add netns check on taps

On 12/5/17 3:46 PM, Kevin Cernekee wrote: > Currently, a nlmon link inside a child namespace can observe systemwide > netlink activity. Filter the traffic so that in a non-init netns, > nlmon can only sniff netlink messages from its own netns. > > Test case: > > vpnns -- bash -c "ip link

Re: [PATCH] netlink: Add netns check on taps

On 12/5/17 3:46 PM, Kevin Cernekee wrote: > Currently, a nlmon link inside a child namespace can observe systemwide > netlink activity. Filter the traffic so that in a non-init netns, > nlmon can only sniff netlink messages from its own netns. > > Test case: > > vpnns -- bash -c "ip link

Re: [PATCH net-next 3/5] bpftool: implement cgattach command

On 11/30/17 6:43 AM, Roman Gushchin wrote: > + if (bpf_prog_attach(prog_fd, cgroup_fd, attach_type, 0)) { > + bpf_object__close(obj); > + close(prog_fd); > + close(cgroup_fd); > + p_err("Failed to attach program"); > + return -1; > +

Re: [PATCH net-next 3/5] bpftool: implement cgattach command

On 11/30/17 6:43 AM, Roman Gushchin wrote: > + if (bpf_prog_attach(prog_fd, cgroup_fd, attach_type, 0)) { > + bpf_object__close(obj); > + close(prog_fd); > + close(cgroup_fd); > + p_err("Failed to attach program"); > + return -1; > +

Re: [PATCH net-next 3/5] bpftool: implement cgattach command

On 11/30/17 6:43 AM, Roman Gushchin wrote: > @@ -75,12 +80,13 @@ static int do_help(int argc, char **argv) > fprintf(stderr, > "Usage: %s [OPTIONS] OBJECT { COMMAND | help }\n" > " %s batch file FILE\n" > + " %s cgattach FILE CGROUP TYPE\n"

Re: [PATCH net-next 3/5] bpftool: implement cgattach command

On 11/30/17 6:43 AM, Roman Gushchin wrote: > @@ -75,12 +80,13 @@ static int do_help(int argc, char **argv) > fprintf(stderr, > "Usage: %s [OPTIONS] OBJECT { COMMAND | help }\n" > " %s batch file FILE\n" > + " %s cgattach FILE CGROUP TYPE\n"

Re: [PATCH] net-sysfs: export gso_max_size attribute

On 11/24/17 11:32 AM, Eric Dumazet wrote: > On Fri, 2017-11-24 at 10:14 -0700, David Ahern wrote: >> On 11/22/17 5:30 PM, Solio Sarabia wrote: >>> The netdevice gso_max_size is exposed to allow users fine-control >>> on >>> systems with multiple NICs with diffe

Re: [PATCH] net-sysfs: export gso_max_size attribute

On 11/24/17 11:32 AM, Eric Dumazet wrote: > On Fri, 2017-11-24 at 10:14 -0700, David Ahern wrote: >> On 11/22/17 5:30 PM, Solio Sarabia wrote: >>> The netdevice gso_max_size is exposed to allow users fine-control >>> on >>> systems with multiple NICs with diffe

Re: [PATCH] net-sysfs: export gso_max_size attribute

On 11/22/17 5:30 PM, Solio Sarabia wrote: > The netdevice gso_max_size is exposed to allow users fine-control on > systems with multiple NICs with different GSO buffer sizes, and where > the virtual devices like bridge and veth, need to be aware of the GSO > size of the underlying devices. > > In

Re: [PATCH] net-sysfs: export gso_max_size attribute

On 11/22/17 5:30 PM, Solio Sarabia wrote: > The netdevice gso_max_size is exposed to allow users fine-control on > systems with multiple NICs with different GSO buffer sizes, and where > the virtual devices like bridge and veth, need to be aware of the GSO > size of the underlying devices. > > In

Re: [RFC] perf script: modify field selection option

On 11/20/17 1:53 PM, Stephane Eranian wrote: > Hi, > > I have been using the perf script -F option on the latest perf and I > find it not very convenient to use. I appreciate the + and - prefix to > field names to add or suppress them. But most of the time, I want to > print only one or two

Re: [RFC] perf script: modify field selection option

On 11/20/17 1:53 PM, Stephane Eranian wrote: > Hi, > > I have been using the perf script -F option on the latest perf and I > find it not very convenient to use. I appreciate the + and - prefix to > field names to add or suppress them. But most of the time, I want to > print only one or two

Re: IPv6 issue in next-20171102 - lockdep and BUG handling RA packet.

On 11/7/17 9:31 AM, Eric Dumazet wrote: > On Mon, Nov 6, 2017 at 4:29 PM, David Ahern <dsah...@gmail.com> wrote: >> On 11/7/17 5:56 AM, valdis.kletni...@vt.edu wrote: >>> I've hit this 6 times now, across 3 boots: >>> >>> Nov 3 11:04:54 turing-police ker

Re: IPv6 issue in next-20171102 - lockdep and BUG handling RA packet.

On 11/7/17 9:31 AM, Eric Dumazet wrote: > On Mon, Nov 6, 2017 at 4:29 PM, David Ahern wrote: >> On 11/7/17 5:56 AM, valdis.kletni...@vt.edu wrote: >>> I've hit this 6 times now, across 3 boots: >>> >>> Nov 3 11:04:54 turing-police kernel: [ 547.814748] BUG

Re: IPv6 issue in next-20171102 - lockdep and BUG handling RA packet.

On 11/7/17 5:56 AM, valdis.kletni...@vt.edu wrote: > I've hit this 6 times now, across 3 boots: > > Nov 3 11:04:54 turing-police kernel: [ 547.814748] BUG: sleeping function > called from invalid context at mm/slab.h:422 > > Nov 3 20:24:11 turing-police kernel: [ 60.093793] BUG: sleeping

Re: IPv6 issue in next-20171102 - lockdep and BUG handling RA packet.

On 11/7/17 5:56 AM, valdis.kletni...@vt.edu wrote: > I've hit this 6 times now, across 3 boots: > > Nov 3 11:04:54 turing-police kernel: [ 547.814748] BUG: sleeping function > called from invalid context at mm/slab.h:422 > > Nov 3 20:24:11 turing-police kernel: [ 60.093793] BUG: sleeping

Re: IPv6 issue in next-20171102 - lockdep and BUG handling RA packet.

On 11/7/17 9:31 AM, Eric Dumazet wrote: > Do you have CONFIG_DEBUG_ATOMIC_SLEEP=y in your .config ? dsa@kenny:mgmt:~/kernel-2.git$ grep CONFIG_DEBUG_ATOMIC_SLEEP kbuild/rcu-lock-debug/.config CONFIG_DEBUG_ATOMIC_SLEEP=y Yep, that is on.

Re: IPv6 issue in next-20171102 - lockdep and BUG handling RA packet.

On 11/7/17 9:31 AM, Eric Dumazet wrote: > Do you have CONFIG_DEBUG_ATOMIC_SLEEP=y in your .config ? dsa@kenny:mgmt:~/kernel-2.git$ grep CONFIG_DEBUG_ATOMIC_SLEEP kbuild/rcu-lock-debug/.config CONFIG_DEBUG_ATOMIC_SLEEP=y Yep, that is on.

Re: [PATCH] perf script: Add option to display guest samples in host

On 10/18/17 1:09 AM, Mengting Zhang wrote: > @@ -2771,6 +2772,8 @@ int cmd_script(int argc, const char **argv) > "Show context switch events (if recorded)"), > OPT_BOOLEAN('\0', "show-namespace-events", > _namespace_events, > "Show namespace events (if

Re: [PATCH] perf script: Add option to display guest samples in host

On 10/18/17 1:09 AM, Mengting Zhang wrote: > @@ -2771,6 +2772,8 @@ int cmd_script(int argc, const char **argv) > "Show context switch events (if recorded)"), > OPT_BOOLEAN('\0', "show-namespace-events", > _namespace_events, > "Show namespace events (if

[PATCH v2 perf] tools: Update rbtree files

Update rbtree files to 4.14. Changes made after copy: - update guards in header files - remove rcu references - kept rb_erase_init in rbtree.h Signed-off-by: David Ahern <dsah...@gmail.com> --- v2 - kept rb_erase_init after the update tools/include/linux/rbtree.h

[PATCH v2 perf] tools: Update rbtree files

Update rbtree files to 4.14. Changes made after copy: - update guards in header files - remove rcu references - kept rb_erase_init in rbtree.h Signed-off-by: David Ahern --- v2 - kept rb_erase_init after the update tools/include/linux/rbtree.h | 47 - tools/include/linux

Re: [PATCH perf] tools: Update rbtree files

hi Arnaldo: On 9/29/17 2:26 PM, David Ahern wrote: > Update rbtree files to 4.14. Haven't seen this one in your perf/core branch. You added the existing version, so assuming an update goes through you as well. > > Changes made after copy: > - update guards in header files &g

Re: [PATCH perf] tools: Update rbtree files

hi Arnaldo: On 9/29/17 2:26 PM, David Ahern wrote: > Update rbtree files to 4.14. Haven't seen this one in your perf/core branch. You added the existing version, so assuming an update goes through you as well. > > Changes made after copy: > - update guards in header files &g

Re: [PATCH][net-next] net: mpls: make function ipgre_mpls_encap_hlen static

_NET_IP_TUNNEL) > -size_t ipgre_mpls_encap_hlen(struct ip_tunnel_encap *e) > +static size_t ipgre_mpls_encap_hlen(struct ip_tunnel_encap *e) > { > return sizeof(struct mpls_shim_hdr); > } > Acked-by: David Ahern <dsah...@gmail.com>

Re: [PATCH][net-next] net: mpls: make function ipgre_mpls_encap_hlen static

_tunnel_encap *e) > +static size_t ipgre_mpls_encap_hlen(struct ip_tunnel_encap *e) > { > return sizeof(struct mpls_shim_hdr); > } > Acked-by: David Ahern

Re: [PATCH 1/1] xdp: Sample xdp program implementing ip forward

On 10/3/17 12:37 AM, cjacob wrote: > diff --git a/samples/bpf/xdp3_kern.c b/samples/bpf/xdp3_kern.c > new file mode 100644 > index 000..62d905d > --- /dev/null > +++ b/samples/bpf/xdp3_kern.c > @@ -0,0 +1,204 @@ > +/* Copyright (c) 2016 PLUMgrid 2016 PLUMgrid? > + * > + * This program is

Re: [PATCH 1/1] xdp: Sample xdp program implementing ip forward

On 10/3/17 12:37 AM, cjacob wrote: > diff --git a/samples/bpf/xdp3_kern.c b/samples/bpf/xdp3_kern.c > new file mode 100644 > index 000..62d905d > --- /dev/null > +++ b/samples/bpf/xdp3_kern.c > @@ -0,0 +1,204 @@ > +/* Copyright (c) 2016 PLUMgrid 2016 PLUMgrid? > + * > + * This program is

[PATCH perf] tools: Update rbtree files

Update rbtree files to 4.14. Changes made after copy: - update guards in header files - remove rcu references Signed-off-by: David Ahern <dsah...@gmail.com> --- tools/include/linux/rbtree.h | 59 --- tools/include/linux/rbtree_augmented.h | 58 +-- tools/lib/rb

[PATCH perf] tools: Update rbtree files

Update rbtree files to 4.14. Changes made after copy: - update guards in header files - remove rcu references Signed-off-by: David Ahern --- tools/include/linux/rbtree.h | 59 --- tools/include/linux/rbtree_augmented.h | 58 +-- tools/lib/rbtree.c

Re: [PATCH v2 1/4] Add a new element for the struct perf_tool, and add the --per-event-dump option for perf script

On 9/25/17 8:41 PM, 禹舟键 wrote: > The changelogs are in the cover-letter. > changes in v2: >         - remove the set of script.tool.per_event_dump variable. >         - add the __maybe_unused attribute for the fp argument in the > second patch. >         - remove the fp_selection_helper function

Re: [PATCH v2 1/4] Add a new element for the struct perf_tool, and add the --per-event-dump option for perf script

On 9/25/17 8:41 PM, 禹舟键 wrote: > The changelogs are in the cover-letter. > changes in v2: >         - remove the set of script.tool.per_event_dump variable. >         - add the __maybe_unused attribute for the fp argument in the > second patch. >         - remove the fp_selection_helper function

[tip:perf/core] perf sched timehist: Add pid and tid options

Commit-ID: 0f59d7a352c11712de0f226b46cb82775b4fcece Gitweb: http://git.kernel.org/tip/0f59d7a352c11712de0f226b46cb82775b4fcece Author: David Ahern <dsah...@gmail.com> AuthorDate: Fri, 1 Sep 2017 10:49:12 -0700 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> CommitDate:

[tip:perf/core] perf sched timehist: Add pid and tid options

Commit-ID: 0f59d7a352c11712de0f226b46cb82775b4fcece Gitweb: http://git.kernel.org/tip/0f59d7a352c11712de0f226b46cb82775b4fcece Author: David Ahern AuthorDate: Fri, 1 Sep 2017 10:49:12 -0700 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 13 Sep 2017 09:49:12 -0300 perf sched

Re: [PATCH 2/3] Makes all those related functions receive the FILE pointer

On 9/13/17 9:10 AM, yuzhoujian wrote: > @@ -1621,8 +1634,12 @@ static int process_comm_event(struct perf_tool *tool, > sample->tid = event->comm.tid; > sample->pid = event->comm.pid; > } > - print_sample_start(sample, thread, evsel); > -

Re: [PATCH 2/3] Makes all those related functions receive the FILE pointer

On 9/13/17 9:10 AM, yuzhoujian wrote: > @@ -1621,8 +1634,12 @@ static int process_comm_event(struct perf_tool *tool, > sample->tid = event->comm.tid; > sample->pid = event->comm.pid; > } > - print_sample_start(sample, thread, evsel); > -

Re: [PATCH 1/3] Add a new element for the struct perf_tool, and add the --per-event-dump option for perf script

On 9/13/17 9:10 AM, yuzhoujian wrote: > @@ -2797,7 +2801,12 @@ int cmd_script(int argc, const char **argv) > > file.path = input_name; > file.force = symbol_conf.force; > - > + for (i = 1; argv[i] != NULL; i++) { > + if (strcmp(argv[i], "-O") == 0) { > +

Re: [PATCH 1/3] Add a new element for the struct perf_tool, and add the --per-event-dump option for perf script

On 9/13/17 9:10 AM, yuzhoujian wrote: > @@ -2797,7 +2801,12 @@ int cmd_script(int argc, const char **argv) > > file.path = input_name; > file.force = symbol_conf.force; > - > + for (i = 1; argv[i] != NULL; i++) { > + if (strcmp(argv[i], "-O") == 0) { > +

Re: [PATCH] perf: support running perf binaries with a dash in their name

-e): > ... > ~ > > Cc: Arnaldo Carvalho de Melo <a...@redhat.com> > Cc: David Ahern <dsah...@gmail.com> > Cc: Namhyung Kim <namhy...@kernel.org> > Cc: Peter Zijlstra <a.p.zijls...@chello.nl> > Cc: Yao Jin <yao@linux.intel.com> > Signed-

Re: [PATCH] perf: support running perf binaries with a dash in their name

> ... > ~ > > Cc: Arnaldo Carvalho de Melo > Cc: David Ahern > Cc: Namhyung Kim > Cc: Peter Zijlstra > Cc: Yao Jin > Signed-off-by: Milian Wolff > --- > tools/perf/perf.c | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > &g

Re: [PATCH] perf sched timehist: Add pid and tid options

Hi Arnaldo: are you ok with this change? On 9/1/17 11:49 AM, David Ahern wrote: > Add options to only show event for specific pid(s) and tid(s). > > Signed-off-by: David Ahern <dsah...@gmail.com> > --- > tools/perf/Documentation/perf-sched.txt | 8 > to

Re: [PATCH] perf sched timehist: Add pid and tid options

Hi Arnaldo: are you ok with this change? On 9/1/17 11:49 AM, David Ahern wrote: > Add options to only show event for specific pid(s) and tid(s). > > Signed-off-by: David Ahern > --- > tools/perf/Documentation/perf-sched.txt | 8 > tools/perf/builtin-sched.c

[PATCH] perf sched timehist: Add pid and tid options

Add options to only show event for specific pid(s) and tid(s). Signed-off-by: David Ahern <dsah...@gmail.com> --- tools/perf/Documentation/perf-sched.txt | 8 tools/perf/builtin-sched.c | 4 2 files changed, 12 insertions(+) diff --git a/tools/perf/Documentatio

[PATCH] perf sched timehist: Add pid and tid options

Add options to only show event for specific pid(s) and tid(s). Signed-off-by: David Ahern --- tools/perf/Documentation/perf-sched.txt | 8 tools/perf/builtin-sched.c | 4 2 files changed, 12 insertions(+) diff --git a/tools/perf/Documentation/perf-sched.txt b/tools

Re: linux-next: Signed-off-by missing for commit in the net-next tree

On 8/30/17 10:51 AM, Stephen Rothwell wrote: > Hi all, > > Commit > > 1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local > address") > > is missing a Signed-off-by from its author. > Eric pointed this out last night. The commit message copied output from a command that

Re: linux-next: Signed-off-by missing for commit in the net-next tree

On 8/30/17 10:51 AM, Stephen Rothwell wrote: > Hi all, > > Commit > > 1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local > address") > > is missing a Signed-off-by from its author. > Eric pointed this out last night. The commit message copied output from a command that

Re: boot failure with 4.13.0-rc6 due to ATA errors

ion(id) <= 7) > + return false; > + return id[ATA_ID_TRUSTED] & (1 << 0); > +} > + > static inline bool ata_id_has_unload(const u16 *id) > { > if (ata_id_major_version(id) >= 7 && > That works for me. Tested-by: David Ahern <dsah...@gmail.com>

Re: boot failure with 4.13.0-rc6 due to ATA errors

se; > + return id[ATA_ID_TRUSTED] & (1 << 0); > +} > + > static inline bool ata_id_has_unload(const u16 *id) > { > if (ata_id_major_version(id) >= 7 && > That works for me. Tested-by: David Ahern

Re: boot failure with 4.13.0-rc6 due to ATA errors

On 8/28/17 1:59 PM, Tejun Heo wrote: > Can you please verify whether 818831c8b22f ("libata: implement > SECURITY PROTOCOL IN/OUT") is the culprit? ie. try to boot the commit > to verify that the problem is there, and try the one prior? That commit is the problem.

Re: boot failure with 4.13.0-rc6 due to ATA errors

On 8/28/17 1:59 PM, Tejun Heo wrote: > Can you please verify whether 818831c8b22f ("libata: implement > SECURITY PROTOCOL IN/OUT") is the culprit? ie. try to boot the commit > to verify that the problem is there, and try the one prior? That commit is the problem.

boot failure with 4.13.0-rc6 due to ATA errors

Not sure why mailing list to direct this bug report to, so starting with libata based on the error messages. Some where between v4.12 and 4.13.0-rc6 a Celestica redstone switch fails to boot due to ATA errors: [9.185203] ata1.00: failed to set xfermode (err_mask=0x40) [9.500825] ata1.00:

boot failure with 4.13.0-rc6 due to ATA errors

Not sure why mailing list to direct this bug report to, so starting with libata based on the error messages. Some where between v4.12 and 4.13.0-rc6 a Celestica redstone switch fails to boot due to ATA errors: [9.185203] ata1.00: failed to set xfermode (err_mask=0x40) [9.500825] ata1.00:

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On 8/13/17 2:56 PM, Wei Wang wrote: >> Looking at my patch to move host routes from loopback to device with the >> address, I have this: >> >> @@ -2789,7 +2808,8 @@ static int fib6_ifdown(struct rt6_info *rt, void *arg) >> const struct arg_dev_net *adn = arg; >> const struct

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On 8/13/17 2:56 PM, Wei Wang wrote: >> Looking at my patch to move host routes from loopback to device with the >> address, I have this: >> >> @@ -2789,7 +2808,8 @@ static int fib6_ifdown(struct rt6_info *rt, void *arg) >> const struct arg_dev_net *adn = arg; >> const struct

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On 8/12/17 1:42 PM, Wei Wang wrote: > Hi Ido, > >>> - if ((rt->dst.dev == dev || !dev) && >>> + if ((rt->dst.dev == dev || !dev || >>> + rt->rt6i_idev->dev == dev) && >> >> Can you please explain why this line is needed? While host routes aren't >> removed from the FIB by

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On 8/12/17 1:42 PM, Wei Wang wrote: > Hi Ido, > >>> - if ((rt->dst.dev == dev || !dev) && >>> + if ((rt->dst.dev == dev || !dev || >>> + rt->rt6i_idev->dev == dev) && >> >> Can you please explain why this line is needed? While host routes aren't >> removed from the FIB by

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On 8/11/17 6:25 PM, Wei Wang wrote: > By "a patch to fix that" do you mean after your patch, for every rt6, > rt6->rt6i_idev will be the same as rt6->dst.dev? FIB entries should have them the same device with my patch. The copies done (ip6_rt_cache_alloc and ip6_rt_pcpu_alloc) will have to set

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On 8/11/17 6:25 PM, Wei Wang wrote: > By "a patch to fix that" do you mean after your patch, for every rt6, > rt6->rt6i_idev will be the same as rt6->dst.dev? FIB entries should have them the same device with my patch. The copies done (ip6_rt_cache_alloc and ip6_rt_pcpu_alloc) will have to set

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On 8/11/17 6:10 PM, Wei Wang wrote: > I think we have a potential fix for this issue. > Martin and I found that when addrconf_dst_alloc() creates a rt6, it is > possible that rt6->dst.dev points to loopback device while > rt6->rt6i_idev->dev points to a real device. > When the real device goes

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On 8/11/17 6:10 PM, Wei Wang wrote: > I think we have a potential fix for this issue. > Martin and I found that when addrconf_dst_alloc() creates a rt6, it is > possible that rt6->dst.dev points to loopback device while > rt6->rt6i_idev->dev points to a real device. > When the real device goes

Re: [PATCH v5 00/16] perf tool: add meta-data header support for pipe-mode

u mappings: intel_bts = 6, cpu = 4, msr = 49, uncore_cbox_10 = 36, > [SNIP] > [ perf record: Woken up 1 times to write data ] > [ perf record: Captured and wrote 0.000 MB - ] > ... I like it; much needed functionality. Acked-by: David Ahern <dsah...@gmail.com>

Re: [PATCH v5 00/16] perf tool: add meta-data header support for pipe-mode

u mappings: intel_bts = 6, cpu = 4, msr = 49, uncore_cbox_10 = 36, > [SNIP] > [ perf record: Woken up 1 times to write data ] > [ perf record: Captured and wrote 0.000 MB - ] > ... I like it; much needed functionality. Acked-by: David Ahern

Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink

On 6/26/17 7:45 AM, Matthias Schiffer wrote: > > Please read my patch again, I *am* changing br_port_slave_changelink to > match the new signature (this is the net/bridge/br_netlink.c change > appearing in the diffstat). > Hmmm right you are. sorry for the confusion.

Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink

On 6/26/17 7:45 AM, Matthias Schiffer wrote: > > Please read my patch again, I *am* changing br_port_slave_changelink to > match the new signature (this is the net/bridge/br_netlink.c change > appearing in the diffstat). > Hmmm right you are. sorry for the confusion.

Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink

On 6/26/17 2:43 AM, Matthias Schiffer wrote: > On 06/26/2017 06:08 AM, David Ahern wrote: >> On 6/25/17 10:04 PM, David Ahern wrote: >>> On 6/25/17 3:56 PM, Matthias Schiffer wrote: >>>> Add support for extended error reporting. >>>> >>>>

Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink

On 6/26/17 2:43 AM, Matthias Schiffer wrote: > On 06/26/2017 06:08 AM, David Ahern wrote: >> On 6/25/17 10:04 PM, David Ahern wrote: >>> On 6/25/17 3:56 PM, Matthias Schiffer wrote: >>>> Add support for extended error reporting. >>>

Re: [PATCH net-next v2 5/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_validate

On 6/25/17 10:05 PM, David Ahern wrote: > On 6/25/17 3:56 PM, Matthias Schiffer wrote: >> Add support for extended error reporting. >> >> Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> >> --- > > Acked-by: David Ahern <dsah...@gma

Re: [PATCH net-next v2 5/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_validate

On 6/25/17 10:05 PM, David Ahern wrote: > On 6/25/17 3:56 PM, Matthias Schiffer wrote: >> Add support for extended error reporting. >> >> Signed-off-by: Matthias Schiffer >> --- > > Acked-by: David Ahern > And slave_validate is not used; it should be removed.

Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink

On 6/25/17 10:04 PM, David Ahern wrote: > On 6/25/17 3:56 PM, Matthias Schiffer wrote: >> Add support for extended error reporting. >> >> Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> >> --- > > > Acked-by: David Ahern <dsa

Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink

On 6/25/17 10:04 PM, David Ahern wrote: > On 6/25/17 3:56 PM, Matthias Schiffer wrote: >> Add support for extended error reporting. >> >> Signed-off-by: Matthias Schiffer >> --- > > > Acked-by: David Ahern > Actually, you are missing the chagne to br_port_slave_changelink.

Re: [PATCH net-next v2 5/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_validate

On 6/25/17 3:56 PM, Matthias Schiffer wrote: > Add support for extended error reporting. > > Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> > --- Acked-by: David Ahern <dsah...@gmail.com>

<    1   2   3   4   5   6   7   8   9   10   >