Re: [PATCH] flow_dissector: work around stack frame size warning

2020-06-01 Thread David Miller
From: Arnd Bergmann Date: Fri, 29 May 2020 22:13:58 +0200 > The fl_flow_key structure is around 500 bytes, so having two of them > on the stack in one function now exceeds the warning limit after an > otherwise correct change: > > net/sched/cls_flower.c:298:12: error: stack frame size of 1056

Re: [PATCH] lan743x: Added fixed link and RGMII support

2020-06-01 Thread David Miller
From: Roelof Berg Date: Fri, 29 May 2020 21:30:02 +0200 > Microchip lan7431 is frequently connected to a phy. However, it > can also be directly connected to a MII remote peer without > any phy in between. For supporting such a phyless hardware setup > in Linux we utilized phylib, which supports

Re: [PATCH] ipv4: nexthop: Fix deadcode issue by performing a proper NULL check

2020-06-01 Thread David Miller
From: patrickeigens...@gmail.com Date: Mon, 1 Jun 2020 13:12:01 +0200 > From: Patrick Eigensatz > > After allocating the spare nexthop group it should be tested for kzalloc() > returning NULL, instead the already used nexthop group (which cannot be > NULL at this point) had been tested so far.

Re: [PATCH net-next] tipc: Fix NULL pointer dereference in __tipc_sendstream()

2020-06-01 Thread David Miller
From: YueHaibing Date: Thu, 28 May 2020 22:34:07 +0800 > tipc_sendstream() may send zero length packet, then tipc_msg_append() > do not alloc skb, skb_peek_tail() will get NULL, msg_set_ack_required > will trigger NULL pointer dereference. > > Reported-by:

Re: [PATCH v3 0/2] regmap: provide simple bitops and use them in a driver

2020-06-01 Thread David Miller
From: Bartosz Golaszewski Date: Thu, 28 May 2020 17:45:01 +0200 > From: Bartosz Golaszewski > > I noticed that oftentimes I use regmap_update_bits() for simple bit > setting or clearing. In this case the fourth argument is superfluous as > it's always 0 or equal to the mask argument. > > This

Re: [PATCH] drivers/net/wan/lapbether.c: Fixed kernel panic when used with AF_PACKET sockets

2020-06-01 Thread David Miller
From: Xie He Date: Wed, 27 May 2020 20:21:33 -0700 > When we use "AF_PACKET" sockets to send data directly over LAPB over > Ethernet using this driver, the kernel will panic because of > insufficient header space allocated in the "sk_buff" struct. > > The header space needs 18 bytes because: >

Re: [PATCH net-next v5] hinic: add set_channels ethtool_ops support

2020-06-01 Thread David Miller
From: Luo bin Date: Mon, 1 Jun 2020 18:57:48 +0800 > @@ -470,6 +470,11 @@ netdev_tx_t hinic_xmit_frame(struct sk_buff *skb, struct > net_device *netdev) > struct hinic_txq *txq; > struct hinic_qp *qp; > > + if (unlikely(!netif_carrier_ok(netdev))) { > +

[GIT] Networking

2020-05-30 Thread David Miller
Another week, another set of bug fixes: 1) Fix pskb_pull length in __xfrm_transport_prep(), from Xin Long. 2) Fix double xfrm_state put in esp{4,6}_gro_receive(), also from Xin Long. 3) Re-arm discovery timer properly in mac80211 mesh code, from Linus Lüssing. 4) Prevent buffer

Re: [PATCH RFT] ravb: Mask PHY mode to avoid inserting delays twice

2020-05-30 Thread David Miller
From: Geert Uytterhoeven Date: Fri, 29 May 2020 14:25:40 +0200 > Until recently, the Micrel KSZ9031 PHY driver ignored any PHY mode > ("RGMII-*ID") settings, but used the hardware defaults, augmented by > explicit configuration of individual skew values using the "*-skew-ps" > DT properties.

Re: [PATCH] net: qrtr: Allocate workqueue before kernel_bind

2020-05-30 Thread David Miller
From: Chris Lew Date: Thu, 28 May 2020 16:05:26 -0700 > A null pointer dereference in qrtr_ns_data_ready() is seen if a client > opens a qrtr socket before qrtr_ns_init() can bind to the control port. > When the control port is bound, the ENETRESET error will be broadcasted > and clients will

Re: [PATCH net-next v3] hinic: add set_channels ethtool_ops support

2020-05-30 Thread David Miller
From: Luo bin Date: Fri, 29 May 2020 18:11:50 + > add support to change TX/RX queue number with ethtool -L ethx combined > > Signed-off-by: Luo bin Luo, I am not applying any of your patches until you fix the time on your computer. This causes a lot of issues and slows down my workflow

Re: [PATCH v3] virtio_vsock: Fix race condition in virtio_transport_recv_pkt

2020-05-30 Thread David Miller
From: Jia He Date: Sat, 30 May 2020 09:38:28 +0800 > When client on the host tries to connect(SOCK_STREAM, O_NONBLOCK) to the > server on the guest, there will be a panic on a ThunderX2 (armv8a server): ... > The race condition is as follows: > Task1Task2 > =

Re: [PATCH net-next 0/6] net: hns3: adds some cleanups for -next

2020-05-30 Thread David Miller
From: Huazhong Tan Date: Sat, 30 May 2020 09:08:26 +0800 > There are some cleanups for the HNS3 ethernet driver, fix an > incorrect print format, an incorrect comment and some coding > style issues, also remove some unused codes and macros. Series applied, thanks.

Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-05-29 Thread David Miller
Please remove all of the __packed attributes. I looked at your data structures and all of them use fixed sized types and are multiples of 4 so the __packed attribute is completely unnecessary. The alignment attribute is also unnecessary so please remove that too.

Re: [PATCH][net-next] nexthop: fix incorrect allocation failure on nhg->spare

2020-05-29 Thread David Miller
From: Colin King Date: Thu, 28 May 2020 15:51:14 +0100 > @@ -1185,7 +1185,7 @@ static struct nexthop *nexthop_create_group(struct net > *net, > > /* spare group used for removals */ > nhg->spare = nexthop_grp_alloc(num_nh); I don't even see this line in the current net-next tree

Re: [PATCH net-next v2] dt-bindings: net: rename the bindings document for MediaTek STAR EMAC

2020-05-29 Thread David Miller
From: Bartosz Golaszewski Date: Thu, 28 May 2020 15:59:02 +0200 > From: Bartosz Golaszewski > > The driver itself was renamed before getting merged into mainline, but > the binding document kept the old name. This makes both names consistent. > > Signed-off-by: Bartosz Golaszewski > --- > v1

Re: [PATCH] NFC: st21nfca: add missed kfree_skb() in an error path

2020-05-29 Thread David Miller
From: Chuhong Yuan Date: Thu, 28 May 2020 18:20:37 +0800 > st21nfca_tm_send_atr_res() misses to call kfree_skb() in an error path. > Add the missed function call to fix it. > > Fixes: 1892bf844ea0 ("NFC: st21nfca: Adding P2P support to st21nfca in > Initiator & Target mode") > Signed-off-by:

Re: [RFC][PATCH v3 1/5] sparc64: Fix asm/percpu.h build error

2020-05-29 Thread David Miller
From: Peter Zijlstra Date: Fri, 29 May 2020 23:35:51 +0200 > ../arch/sparc/include/asm/percpu_64.h:7:24: warning: call-clobbered register > used for global register variable > register unsigned long __local_per_cpu_offset asm("g5"); The "-ffixed-g5" option on the command line tells gcc that we

Re: remove kernel_setsockopt v4

2020-05-29 Thread David Miller
From: Christoph Hellwig Date: Fri, 29 May 2020 14:09:39 +0200 > now that only the dlm calls to sctp are left for kernel_setsockopt, > while we haven't really made much progress with the sctp setsockopt > refactoring, how about this small series that splits out a > sctp_setsockopt_bindx_kernel

Re: [PATCH net-next] net: phy: mscc: fix PHYs using the vsc8574_probe

2020-05-29 Thread David Miller
From: Antoine Tenart Date: Fri, 29 May 2020 11:49:09 +0200 > PHYs using the vsc8574_probe fail to be initialized and their > config_init return -EIO leading to errors like: > "could not attach PHY: -5". > > This is because when the conversion of the MSCC PHY driver to use the > shared PHY

Re: [PATCH] net: ethernet: mtk-star-emac: remove unused variable

2020-05-29 Thread David Miller
From: Bartosz Golaszewski Date: Fri, 29 May 2020 10:26:48 +0200 > From: Bartosz Golaszewski > > The desc pointer is set but not used. Remove it. > > Reported-by: kbuild test robot > Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver") > Signed-off-by: Bartosz Golaszewski

Re: [PATCH net-next] vmxnet3: use correct hdr reference when packet is encapsulated

2020-05-29 Thread David Miller
From: Ronak Doshi Date: Thu, 28 May 2020 19:53:52 -0700 > 'Commit dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload > support")' added support for encapsulation offload. However, while > preparing inner tso packet, it uses reference to outer ip headers. > > This patch fixes this issue

Re: [PATCH net-next 00/12] net: hns3: misc updates for -next

2020-05-28 Thread David Miller
From: Huazhong Tan Date: Thu, 28 May 2020 21:48:07 +0800 > This patchset includes some updates for the HNS3 ethernet driver. > > #1 removes an unnecessary 'goto'. > #2 adds a missing mutex destroy. > #3&4 refactor two function, make them more readable and maintainable. > #5&6 fix unsuitable

Re: [PATCH v4 net-next 0/4] vmxnet3: upgrade to version 4

2020-05-28 Thread David Miller
From: Ronak Doshi Date: Thu, 28 May 2020 14:53:18 -0700 > vmxnet3 emulation has recently added several new features which includes > offload support for tunnel packets, support for new commands the driver > can issue to emulation, change in descriptor fields, etc. This patch > series extends the

Re: [PATCH v3 net-next 3/4] vmxnet3: add geneve and vxlan tunnel offload support

2020-05-28 Thread David Miller
From: Ronak Doshi Date: Thu, 28 May 2020 14:32:02 -0700 > + BUG_ON(!(gdesc->rcd.tcp || gdesc->rcd.udp) && > +!(le32_to_cpu(gdesc->dword[0]) & > + (1UL << VMXNET3_RCD_HDR_INNER_SHIFT))); > +

Re: [PATCH v2 net-next 3/4] vmxnet3: add geneve and vxlan tunnel offload support

2020-05-28 Thread David Miller
From: Ronak Doshi Date: Thu, 28 May 2020 21:18:34 + > > On 5/28/20, 12:35 PM, "Jakub Kicinski" wrote: >>On Thu, 28 May 2020 11:36:14 -0700 Ronak Doshi wrote: >>> @@ -1168,13 +1220,21 @@ vmxnet3_rx_csum(struct vmxnet3_adapter *adapter, >>>

Re: [PATCH] [net-next] sfc: avoid an unused-variable warning

2020-05-28 Thread David Miller
From: Arnd Bergmann Date: Wed, 27 May 2020 15:41:06 +0200 > 'nic_data' is no longer used outside of the #ifdef block > in efx_ef10_set_mac_address: > > drivers/net/ethernet/sfc/ef10.c:3231:28: error: unused variable 'nic_data' > [-Werror,-Wunused-variable] > struct efx_ef10_nic_data

Re: [PATCH v2] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-28 Thread David Miller
From: Jonas Falkevik Date: Wed, 27 May 2020 11:56:40 +0200 > Make sure SCTP_ADDR_{MADE_PRIM,ADDED} are sent only for associations > that have been established. > > These events are described in rfc6458#section-6.1 > SCTP_PEER_ADDR_CHANGE: > This tag indicates that an address that is > part of

Re: remove most callers of kernel_setsockopt v3

2020-05-28 Thread David Miller
From: Christoph Hellwig Date: Thu, 28 May 2020 07:12:08 +0200 > this series removes most callers of the kernel_setsockopt functions, and > instead switches their users to small functions that implement setting a > sockopt directly using a normal kernel function call with type safety and > all

Re: [PATCH net-next 0/4] vmxnet3: upgrade to version 4

2020-05-28 Thread David Miller
From: David Miller Date: Thu, 28 May 2020 11:07:46 -0700 (PDT) > Series applied, thank you. This doesn't even compile successfully, reverted... :( drivers/net/vmxnet3/vmxnet3_drv.c: In function ‘vmxnet3_tq_xmit’: drivers/net/vmxnet3/vmxnet3_drv.c:1145:5: error: expected ‘}’ before ‘else’ 1

Re: [PATCH] bonding: Fix reference count leak in bond_sysfs_slave_add.

2020-05-28 Thread David Miller
From: wu000...@umn.edu Date: Wed, 27 May 2020 22:10:29 -0500 > From: Qiushi Wu > > kobject_init_and_add() takes reference even when it fails. > If this function returns an error, kobject_put() must be called to > properly clean up the memory associated with the object. Previous > commit

Re: [PATCH net-next 0/4] vmxnet3: upgrade to version 4

2020-05-28 Thread David Miller
From: Ronak Doshi Date: Wed, 27 May 2020 18:54:22 -0700 > vmxnet3 emulation has recently added several new features which includes > offload support for tunnel packets, support for new commands the driver > can issue to emulation, change in descriptor fields, etc. This patch > series extends the

Re: remove kernel_getsockopt

2020-05-27 Thread David Miller
From: Christoph Hellwig Date: Wed, 27 May 2020 20:22:27 +0200 > this series reduces scope from the last round and just removes > kernel_getsockopt to avoid conflicting with the sctp cleanup series. Series applied to net-next, thanks.

Re: [PATCH] sctp: fix typo sctp_ulpevent_nofity_peer_addr_change

2020-05-27 Thread David Miller
From: Jonas Falkevik Date: Wed, 27 May 2020 11:59:43 +0200 > change typo in function name "nofity" to "notify" > sctp_ulpevent_nofity_peer_addr_change -> > sctp_ulpevent_notify_peer_addr_change > > Signed-off-by: Jonas Falkevik Applied to net-next, thanks.

Re: [PATCH] drivers: ipa: remove discription of nonexistent element

2020-05-27 Thread David Miller
From: Wang Wenhu Date: Tue, 26 May 2020 20:32:22 -0700 > No element named "client" exists within "struct ipa_endpoint". > It might be a heritage forgotten to be removed. Delete it now. > > Signed-off-by: Wang Wenhu Applied.

Re: [PATCH] drivers: ipa: fix typoes for ipa

2020-05-27 Thread David Miller
From: Wang Wenhu Date: Tue, 26 May 2020 20:19:24 -0700 > Change "transactio" -> "transaction". Also an alignment correction. > > Signed-off-by: Wang Wenhu Applied.

Re: [PATCH V2 net-next 0/4] net: hns3: misc updates for -next

2020-05-27 Thread David Miller
From: Huazhong Tan Date: Wed, 27 May 2020 08:59:13 +0800 > This patchset includes some misc updates for the HNS3 ethernet driver. > > #1 adds a resetting check in hclgevf_init_nic_client_instance(). > #2 adds a preparatory work for RMDA VF's driver. > #3 removes some unnecessary operations in

Re: [PATCH net-next 0/2] net: mscc: allow forwarding ioctl operations to attached PHYs

2020-05-27 Thread David Miller
From: Antoine Tenart Date: Tue, 26 May 2020 17:01:47 +0200 > These two patches allow forwarding ioctl to the PHY MII implementation, > and support is added for offloading timestamping operations to > compatible attached PHYs. Series applied, thanks.

Re: [PATCH] bridge: multicast: work around clang bug

2020-05-27 Thread David Miller
From: Arnd Bergmann Date: Wed, 27 May 2020 15:51:13 +0200 > Clang-10 and clang-11 run into a corner case of the register > allocator on 32-bit ARM, leading to excessive stack usage from > register spilling: > > net/bridge/br_multicast.c:2422:6: error: stack frame size of 1472 bytes in >

Re: [PATCH] [net-next] mtk-star-emac: mark PM functions as __maybe_unused

2020-05-27 Thread David Miller
From: Arnd Bergmann Date: Wed, 27 May 2020 15:34:45 +0200 > Without CONFIG_PM, the compiler warns about two unused functions: > > drivers/net/ethernet/mediatek/mtk_star_emac.c:1472:12: error: unused function > 'mtk_star_suspend' [-Werror,-Wunused-function] >

Re: [PATCH] net: dsa: b53: remove redundant premature assignment to new_pvid

2020-05-27 Thread David Miller
From: Colin King Date: Wed, 27 May 2020 13:01:29 +0100 > From: Colin Ian King > > Variable new_pvid is being assigned with a value that is never read, > the following if statement updates new_pvid with a new value in both > of the if paths. The assignment is redundant and can be removed. > >

Re: [PATCH net-next v2] bridge: mrp: Rework the MRP netlink interface

2020-05-27 Thread David Miller
From: Horatiu Vultur Date: Wed, 27 May 2020 12:34:30 + > This patch reworks the MRP netlink interface. Before, each attribute > represented a binary structure which made it hard to be extended. > Therefore update the MRP netlink interface such that each existing > attribute to be a nested

Re: [PATCH] net: ethernet: mtk-star-emac: fix error path in RX handling

2020-05-27 Thread David Miller
From: Bartosz Golaszewski Date: Wed, 27 May 2020 11:24:04 +0200 > From: Bartosz Golaszewski > > The dma_addr field in desc_data must not be overwritten until after the > new skb is mapped. Currently we do replace it with uninitialized value > in error path. This change fixes it by moving the

Re: [PATCH][V2][net-next] mlxsw: spectrum_router: remove redundant initialization of pointer br_dev

2020-05-27 Thread David Miller
From: Colin King Date: Wed, 27 May 2020 09:15:55 +0100 > From: Colin Ian King > > The pointer br_dev is being initialized with a value that is never read > and is being updated with a new value later on. The initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused

Re: [PATCH net-next] nexthop: Fix type of event_type in call_nexthop_notifiers

2020-05-27 Thread David Miller
From: Nathan Chancellor Date: Wed, 27 May 2020 01:00:20 -0700 > Clang warns: > > net/ipv4/nexthop.c:841:30: warning: implicit conversion from enumeration > type 'enum nexthop_event_type' to different enumeration type 'enum > fib_event_type' [-Wenum-conversion] >

Re: [PATCH net] vsock: fix timeout in vsock_accept()

2020-05-27 Thread David Miller
From: Stefano Garzarella Date: Wed, 27 May 2020 09:56:55 +0200 > The accept(2) is an "input" socket interface, so we should use > SO_RCVTIMEO instead of SO_SNDTIMEO to set the timeout. > > So this patch replace sock_sndtimeo() with sock_rcvtimeo() to > use the right timeout in the

Re: [PATCH v2] net: phy: at803x: add cable diagnostics support for ATH9331 and ATH8032

2020-05-27 Thread David Miller
From: Oleksij Rempel Date: Wed, 27 May 2020 07:08:43 +0200 > Add support for Atheros 100Base-T PHYs. The only difference seems to be > the ability to test 2 pairs instead of 4 and the lack of 1000Base-T > specific register. > > Only the ATH9331 was tested with this patch. > > Signed-off-by:

Re: [PATCH] macvlan: Skip loopback packets in RX handler

2020-05-27 Thread David Miller
From: Alexander A Sverdlin Date: Tue, 26 May 2020 14:27:51 +0200 > From: Alexander Sverdlin > > Ignore loopback-originatig packets soon enough and don't try to process L2 > header where it doesn't exist. The very similar br_handle_frame() in bridge > code performs exactly the same check. > >

Re: [PATCH] sparc32: register memory occupied by kernel as memblock.memory

2020-05-26 Thread David Miller
From: Mike Rapoport Date: Wed, 27 May 2020 07:52:19 +0300 > Andrew, David, > > Any comments on this? No objections from me: Acked-by: David S. Miller

Re: [PATCH] net: sctp: Fix spelling in Kconfig help

2020-05-26 Thread David Miller
From: Chris Packham Date: Tue, 26 May 2020 10:55:59 +1200 > Change 'handeled' to 'handled' in the Kconfig help for SCTP. > > Signed-off-by: Chris Packham Applied.

Re: [PATCH] net/smc: mark smc_pnet_policy as const

2020-05-26 Thread David Miller
From: Dmitry Vyukov Date: Mon, 25 May 2020 17:31:58 +0200 > Netlink policies are generally declared as const. > This is safer and prevents potential bugs. > > Signed-off-by: Dmitry Vyukov Applied to net-next, thanks.

Re: [PATCH net-next 0/4] net: phy: mscc-miim: reduce waiting time between MDIO transactions

2020-05-26 Thread David Miller
From: Antoine Tenart Date: Tue, 26 May 2020 18:22:52 +0200 > This series aims at reducing the waiting time between MDIO transactions > when using the MSCC MIIM MDIO controller. > > I'm not sure we need patch 4/4 and we could reasonably drop it from the > series. I'm including the patch as it

Re: [PATCH] bridge: mrp: Fix out-of-bounds read in br_mrp_parse

2020-05-25 Thread David Miller
From: Horatiu Vultur Date: Mon, 25 May 2020 09:55:41 + > The issue was reported by syzbot. When the function br_mrp_parse was > called with a valid net_bridge_port, the net_bridge was an invalid > pointer. Therefore the check br->stp_enabled could pass/fail > depending where it was pointing

Re: [PATCH] qlcnic: fix missing release in qlcnic_83xx_interrupt_test.

2020-05-25 Thread David Miller
From: wu000...@umn.edu Date: Mon, 25 May 2020 03:24:39 -0500 > From: Qiushi Wu > > In function qlcnic_83xx_interrupt_test(), function > qlcnic_83xx_diag_alloc_res() is not handled by function > qlcnic_83xx_diag_free_res() after a call of the function > qlcnic_alloc_mbx_args() failed. Fix this

Re: [PATCH] drivers: ipa: print dev_err info accurately

2020-05-25 Thread David Miller
From: Wang Wenhu Date: Sun, 24 May 2020 23:29:51 -0700 > Print certain name string instead of hard-coded "memory" for dev_err > output, which would be more accurate and helpful for debugging. > > Signed-off-by: Wang Wenhu Applied to net-next, thanks.

[GIT] Networking

2020-05-23 Thread David Miller
1) Fix RCU warnings in ipv6 multicast router code, from Madhuparna Bhowmik. 2) Nexthop attributes aren't being checked properly because of mis-initialized iterator, from David Ahern. 3) Revert iop_idents_reserve() change as it caused performance regressions and was just working around

Re: [PATCH v2 0/5] net: provide a devres variant of register_netdev()

2020-05-23 Thread David Miller
From: Bartosz Golaszewski Date: Sat, 23 May 2020 15:27:06 +0200 > From: Bartosz Golaszewski > > Using devres helpers allows to shrink the probing code, avoid memory leaks in > error paths make sure the order in which resources are freed is the exact > opposite of their allocation. This series

Re: [PATCH] net: smsc911x: Fix runtime PM imbalance on error

2020-05-23 Thread David Miller
From: Dinghao Liu Date: Sat, 23 May 2020 16:08:20 +0800 > Remove runtime PM usage counter decrement when the > increment function has not been called to keep the > counter balanced. > > Signed-off-by: Dinghao Liu Applied, thank you.

Re: [PATCH net-next v2] net: psample: fix build error when CONFIG_INET is not enabled

2020-05-23 Thread David Miller
From: Randy Dunlap Date: Fri, 22 May 2020 13:05:26 -0700 > From: Randy Dunlap > > Fix psample build error when CONFIG_INET is not set/enabled by > bracketing the tunnel code in #ifdef CONFIG_NET / #endif. > > ../net/psample/psample.c: In function ‘__psample_ip_tun_to_nlattr’: >

Re: [PATCH v2] net/mlx4_core: fix a memory leak bug.

2020-05-23 Thread David Miller
From: wu000...@umn.edu Date: Fri, 22 May 2020 14:07:15 -0500 > From: Qiushi Wu > > In function mlx4_opreq_action(), pointer "mailbox" is not released, > when mlx4_cmd_box() return and error, causing a memory leak bug. > Fix this issue by going to "out" label, mlx4_free_cmd_mailbox() can > free

Re: [PATCH] net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning during suspend

2020-05-23 Thread David Miller
From: Grygorii Strashko Date: Fri, 22 May 2020 19:39:31 +0300 > vlan_for_each() are required to be called with rtnl_lock taken, otherwise > ASSERT_RTNL() warning will be triggered - which happens now during System > resume from suspend: > cpsw_suspend() > |- cpsw_ndo_stop() > |-

Re: [PATCH net v2] net: phy: mscc: fix initialization of the MACsec protocol mode

2020-05-23 Thread David Miller
From: Antoine Tenart Date: Fri, 22 May 2020 17:55:45 +0200 > At the very end of the MACsec block initialization in the MSCC PHY > driver, the MACsec "protocol mode" is set. This setting should be set > based on the PHY id within the package, as the bank used to access the > register used depends

Re: [PATCH] net: stmmac: don't attach interface until resume finishes

2020-05-23 Thread David Miller
From: Leon Yu Date: Fri, 22 May 2020 23:29:43 +0800 > Commit 14b41a2959fb ("net: stmmac: Delete txtimer in suspend") was the > first attempt to fix a race between mod_timer() and setup_timer() > during stmmac_resume(). However the issue still exists as the commit > only addressed half of the

Re: [PATCH] net: Fix return value about devm_platform_ioremap_resource()

2020-05-23 Thread David Miller
From: Tiezhu Yang Date: Fri, 22 May 2020 19:03:21 +0800 > When call function devm_platform_ioremap_resource(), we should use IS_ERR() > to check the return value and return PTR_ERR() if failed. > > Signed-off-by: Tiezhu Yang Applied, thanks.

Re: [PATCH net-next] net: phy: at803x: fix PHY ID masks

2020-05-23 Thread David Miller
From: Michael Walle Date: Fri, 22 May 2020 11:53:31 +0200 > Ever since its first commit 0ca7111a38f05 ("phy: add AT803x driver") the > PHY ID mask was set to 0xffef. It is unclear to me why this mask was > chosen in the first place. Both the AR8031/AR8033 and the AR8035 > datasheets mention

Re: [PATCH net 0/2] rxrpc: Fix a warning and a leak [ver #2]

2020-05-22 Thread David Miller
From: David Howells Date: Sat, 23 May 2020 00:42:32 +0100 > > Here are a couple of fixes for AF_RXRPC: > > (1) Fix an uninitialised variable warning. > > (2) Fix a leak of the ticket on error in rxkad. > > The patches are tagged here: > >

Re: [PATCH net 0/3] rxrpc: Fix retransmission timeout and ACK discard

2020-05-22 Thread David Miller
From: David Howells Date: Sat, 23 May 2020 00:26:46 +0100 > David Miller wrote: > >> Pulled, thanks David. > > Thanks. I'll rebase my two extra patches I've just sent you a pull request > for when you've updated the branch. Please respin and fix the Subject lin

Re: [PATCH] net: sun: fix missing release regions in cas_init_one().

2020-05-22 Thread David Miller
From: wu000...@umn.edu Date: Fri, 22 May 2020 16:50:27 -0500 > From: Qiushi Wu > > In cas_init_one(), "pdev" is requested by "pci_request_regions", but it > was not released after a call of the function “pci_write_config_byte” > failed. Thus replace the jump target “err_write_cacheline” by >

Re: [PATCH v2 0/3] bridge: mrp: Add br_mrp_unique_ifindex function

2020-05-22 Thread David Miller
From: Horatiu Vultur Date: Thu, 21 May 2020 23:19:04 + > This patch series adds small fixes to MRP implementation. > The following are fixed in this patch series: > - now is not allow to add the same port to multiple MRP rings > - remove unused variable > - restore the port state according

Re: [PATCH net-next v3 0/2] DP83869 Enhancements

2020-05-22 Thread David Miller
From: Dan Murphy Date: Thu, 21 May 2020 12:47:36 -0500 > These are improvements to the DP83869 Ethernet PHY driver. OP-mode and port > mirroring may be strapped on the device but the software only retrives these > settings from the device tree. Reading the straps and initializing the >

Re: [PATCH] net: ethernet: stmmac: Enable interface clocks on probe for IPQ806x

2020-05-22 Thread David Miller
From: Jonathan McDowell Date: Thu, 21 May 2020 12:49:34 +0100 > The ipq806x_gmac_probe() function enables the PTP clock but not the > appropriate interface clocks. This means that if the bootloader hasn't > done so attempting to bring up the interface will fail with an error > like: > > [

Re: [PATCH net 0/3] rxrpc: Fix retransmission timeout and ACK discard

2020-05-22 Thread David Miller
From: David Howells Date: Thu, 21 May 2020 00:21:42 +0100 > > Here are a couple of fixes and an extra tracepoint for AF_RXRPC: > > (1) Calculate the RTO pretty much as TCP does, rather than making > something up, including an initial 4s timeout (which causes return > probes from the

Re: [PATCH 0/5] net: provide a devres variant of register_netdev()

2020-05-22 Thread David Miller
From: Bartosz Golaszewski Date: Wed, 20 May 2020 13:44:10 +0200 > net: ethernet: mtk_eth_mac: use devm_register_netdev() This patch doesn't apply to net-next. Neither the source file drivers/net/ethernet/mediatek/mtk_eth_mac.c, nor the function mtk_mac_probe() even exist in the net-next GIT

Re: [PATCH v5 00/11] mediatek: add support for MediaTek Ethernet MAC

2020-05-22 Thread David Miller
From: Matthias Brugger Date: Fri, 22 May 2020 23:31:50 +0200 > > > On 22/05/2020 23:20, David Miller wrote: >> From: Bartosz Golaszewski >> Date: Fri, 22 May 2020 14:06:49 +0200 >> >>> This series adds support for the STAR Ethernet Controller present on

Re: [PATCH net-next 1/5] net: hns3: add support for VF to query ring and vector mapping

2020-05-22 Thread David Miller
From: Huazhong Tan Date: Fri, 22 May 2020 10:49:42 +0800 > From: Guangbin Huang > > This patch adds support for VF to query the mapping of ring and > vector. > > Signed-off-by: Guangbin Huang > Signed-off-by: Huazhong Tan As Jakub said nothing is making this request, please remove it until

Re: [PATCH v5 00/11] mediatek: add support for MediaTek Ethernet MAC

2020-05-22 Thread David Miller
From: Bartosz Golaszewski Date: Fri, 22 May 2020 14:06:49 +0200 > This series adds support for the STAR Ethernet Controller present on MediaTeK > SoCs from the MT8* family. Series applied to net-next, thank you.

Re: [PATCH net-next] net: phy: mscc: fix initialization of the MACsec protocol mode

2020-05-21 Thread David Miller
From: Antoine Tenart Date: Wed, 20 May 2020 12:03:55 +0200 > What's the best way to handle this? I can provide all the patches. Resubmit this against 'net' please, then I'll deal with the fallout when I merge net into net-next.

Re: [PATCH] net: sgi: ioc3-eth: Fix return value check in ioc3eth_probe()

2020-05-21 Thread David Miller
From: Tang Bin Date: Wed, 20 May 2020 17:55:32 +0800 > In the function devm_platform_ioremap_resource(), if get resource > failed, the return value is ERR_PTR() not NULL. Thus it must be > replaced by IS_ERR(), or else it may result in crashes if a critical > error path is encountered. > >

Re: [PATCH net-next v3 0/2] provide KAPI for SQI

2020-05-21 Thread David Miller
From: Oleksij Rempel Date: Wed, 20 May 2020 08:29:13 +0200 > This patches are extending ethtool netlink interface to export Signal > Quality Index (SQI). SQI provided by 100Base-T1 PHYs and can be used for > cable diagnostic. Compared to a typical cable tests, this value can be > only used after

Re: [PATCH] net: qrtr: Fix passing invalid reference to qrtr_local_enqueue()

2020-05-21 Thread David Miller
From: Manivannan Sadhasivam Date: Tue, 19 May 2020 23:44:16 +0530 > Once the traversal of the list is completed with list_for_each_entry(), > the iterator (node) will point to an invalid object. So passing this to > qrtr_local_enqueue() which is outside of the iterator block is erroneous >

Re: [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature

2020-05-21 Thread David Miller
From: Jakub Kicinski Date: Thu, 21 May 2020 12:17:07 -0700 > On Thu, 21 May 2020 19:38:23 +0800 Huazhong Tan wrote: >> This patchset adds two new VLAN feature. >> >> [patch 1] adds a new dynamic VLAN mode. >> [patch 2] adds support for 'QoS' field to PVID. >> >> Change log: >> V1->V2: modifies

Re: [RFC][PATCHES] uaccess-related stuff in net/*

2020-05-20 Thread David Miller
From: Al Viro Date: Thu, 21 May 2020 01:36:57 +0100 > On Mon, May 11, 2020 at 05:02:51PM -0700, David Miller wrote: >> From: Al Viro >> Date: Mon, 11 May 2020 05:43:28 +0100 >> >> >Assorted uaccess-related work in net/*. First, there's >> > gettin

Re: [PATCH 31/33] sctp: add sctp_sock_set_nodelay

2020-05-20 Thread David Miller
From: Marcelo Ricardo Leitner Date: Wed, 20 May 2020 20:10:01 -0300 > The duplication with sctp_setsockopt_nodelay() is quite silly/bad. > Also, why have the 'true' hardcoded? It's what dlm uses, yes, but the > API could be a bit more complete than that. The APIs are being designed based upon

Re: [PATCH] rds: fix crash in rds_info_getsockopt()

2020-05-20 Thread David Miller
From: John Hubbard Date: Wed, 20 May 2020 12:41:47 -0700 > The conversion to pin_user_pages() had a bug: it overlooked > the case of allocation of pages failing. Fix that by restoring > an equivalent check. > > Reported-by: syzbot+118ac0af4ac7f785a...@syzkaller.appspotmail.com > Fixes:

Re: [PATCH net-next v1] hinic: add support to set and get pause param

2020-05-20 Thread David Miller
From: "luobin (L)" Date: Wed, 20 May 2020 12:39:27 +0800 > It's because I made this patch based on the previous patch > ([PATCH net-next v1] hinic: add set_channels ethtool_ops support), so Don't ever silently create dependencies like this. Either submit new dependant patches after the

Re: [PATCH net-next v1] hinic: add support to set and get pause param

2020-05-19 Thread David Miller
From: "luobin (L)" Date: Wed, 20 May 2020 09:51:02 +0800 > Sorry,I'm afraid I haven't got what you mean. Please don't top-post. What I said was: >> This doesn't apply cleanly to net-next. Which simply means that when I try to apply your patch to net-next with 'git am' it fails.

Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

2020-05-19 Thread David Miller
From: Thomas Gleixner Date: Wed, 20 May 2020 01:42:30 +0200 > Stephen Hemminger writes: >> On Wed, 20 May 2020 00:23:48 +0200 >> Thomas Gleixner wrote: >>> No. We did not. -ENOTESTCASE >> >> Please try, it isn't that hard.. >> >> # time for ((i=0;i<1000;i++)); do ip li add dev dummy$i type

Re: add a new ->ndo_tunnel_ctl method to avoid a few set_fs calls v2

2020-05-19 Thread David Miller
From: Christoph Hellwig Date: Tue, 19 May 2020 15:03:10 +0200 > both the ipv4 and ipv6 code have an ioctl each that can be used to create > a tunnel using code that doesn't live in the core kernel or ipv6 module. > Currently they call ioctls on the tunnel devices to create these, for > which the

Re: [PATCH] net/amd: Remove the extra blank lines

2020-05-19 Thread David Miller
Please put these patches into a proper, numbered, patch series with an appropriate header posting. Some of these patches do not apply cleanly to the net-next tree, which is where these changes should be targetted. Please respin. Thank you.

Re: [PATCH net-next v1] hinic: add support to set and get pause param

2020-05-19 Thread David Miller
From: Luo bin Date: Mon, 18 May 2020 23:38:48 + > add support to set pause param with ethtool -A and get pause > param with ethtool -a. Also remove set_link_ksettings ops for VF. > > Signed-off-by: Luo bin This doesn't apply cleanly to net-next.

Re: [PATCH net-next v3 0/2] realtek ethernet : use generic power management.

2020-05-19 Thread David Miller
From: Vaibhav Gupta Date: Mon, 18 May 2020 20:32:12 +0530 > The purpose of this patch series is to remove legacy power management > callbacks > from realtek ethernet drivers. > > The callbacks performing suspend() and resume() operations are still calling > pci_save_state(),

Re: [PATCH] net: bmac: Fix read of MAC address from ROM

2020-05-19 Thread David Miller
From: Jeremy Kerr Date: Tue, 19 May 2020 09:05:58 +0800 > In bmac_get_station_address, We're reading two bytes at a time from ROM, > but we do that six times, resulting in 12 bytes of read & writes. This > means we will write off the end of the six-byte destination buffer. > > This change fixes

Re: [PATCH 4/4] ipv6: symbol_get to access a sit symbol

2020-05-18 Thread David Miller
From: Christoph Hellwig Date: Mon, 18 May 2020 08:30:43 +0200 > I'll look into implenenting the tunnel_ctl method just for kernel > callers (plus maybe a generic helper for the ioctl), and we'll see if > you like that better. Ok, thank you.

Re: move the SIOCDELRT and SIOCADDRT compat_ioctl handlers v3

2020-05-18 Thread David Miller
From: Christoph Hellwig Date: Mon, 18 May 2020 08:28:04 +0200 > this series moves the compat_ioctl handlers into the protocol handlers, > avoiding the need to override the address space limited as in the current > handler. > > Changes since v3: > - moar variable reordering > > Changes since

Re: [PATCH net-next] net: phy: simplify phy_link_change arguments

2020-05-18 Thread David Miller
From: Doug Berger Date: Mon, 18 May 2020 15:23:59 -0700 > This function was introduced to allow for different handling of > link up and link down events particularly with regard to the > netif_carrier. The third argument do_carrier allowed the flag to > be left unchanged. > > Since then the

Re: [PATCH] oradax: convert get_user_pages() --> pin_user_pages()

2020-05-17 Thread David Miller
From: John Hubbard Date: Sat, 16 May 2020 19:08:29 -0700 > This code was using get_user_pages_fast(), in a "Case 2" scenario > (DMA/RDMA), using the categorization from [1]. That means that it's > time to convert the get_user_pages_fast() + put_page() calls to > pin_user_pages_fast() +

Re: [PATCH] rds: convert get_user_pages() --> pin_user_pages()

2020-05-17 Thread David Miller
From: John Hubbard Date: Sat, 16 May 2020 18:23:36 -0700 > This code was using get_user_pages_fast(), in a "Case 2" scenario > (DMA/RDMA), using the categorization from [1]. That means that it's > time to convert the get_user_pages_fast() + put_page() calls to > pin_user_pages_fast() +

Re: [PATCH v2] net: revert "net: get rid of an signed integer overflow in ip_idents_reserve()"

2020-05-17 Thread David Miller
From: Shaokun Zhang Date: Sat, 16 May 2020 11:46:49 +0800 > From: Yuqi Jin > > Commit adb03115f459 ("net: get rid of an signed integer overflow in > ip_idents_reserve()") > used atomic_cmpxchg to replace "atomic_add_return" inside the function > "ip_idents_reserve". The reason was to avoid

Re: [PATCH net-next] net: dsa: sja1105: disable rxvlan offload for the DSA master

2020-05-17 Thread David Miller
I've asked Eric to look at this twice and no response, so I'm marking this deferred because I'm not applying this without someone knowledgable about the quoted VLAN change can take a look at this.

Re: [PATCH net-next 0/2] net: ipa: sc7180 suspend/resume

2020-05-16 Thread David Miller
From: Alex Elder Date: Fri, 15 May 2020 15:07:29 -0500 > This series permits suspend/resume to work for the IPA driver > on the Qualcomm SC7180 SoC. The IPA version on this SoC requires > interrupts to be enabled when the suspend and resume callbacks are > made, and the first patch moves away

<    7   8   9   10   11   12   13   14   15   16   >