Re: [regression] TCP_MD5SIG on established sockets

2020-06-30 Thread David Miller
From: Eric Dumazet Date: Tue, 30 Jun 2020 13:39:27 -0700 > The (C) & (B) case are certainly doable. > > A) case is more complex, I have no idea of breakages of various TCP > stacks if a flow got SACK > at some point (in 3WHS) but suddenly becomes Reno. I agree that C and B are the easiest to

Re: [PATCH][next] net/mlx5e: fix memory leak of tls

2020-06-30 Thread David Miller
From: Colin King Date: Tue, 30 Jun 2020 16:16:46 +0100 > From: Colin Ian King > > The error return path when create_singlethread_workqueue fails currently > does not kfree tls and leads to a memory leak. Fix this by kfree'ing > tls before returning -ENOMEM. > > Addresses-Coverity: ("Resource

Re: [PATCH][next] net/tls: fix sign extension issue when left shifting u16 value

2020-06-30 Thread David Miller
From: Colin King Date: Tue, 30 Jun 2020 15:27:46 +0100 > From: Colin Ian King > > Left shifting the u16 value promotes it to a int and then it > gets sign extended to a u64. If len << 16 is greater than 0x7fff > then the upper bits get set to 1 because of the implicit sign extension. >

Re: [regression] TCP_MD5SIG on established sockets

2020-06-30 Thread David Miller
From: Linus Torvalds Date: Tue, 30 Jun 2020 12:43:21 -0700 > If you're not willing to do the work to fix it, I will revert that > commit. Please let me handle this situation instead of making threats, this just got reported. Thank you.

Re: [PATCH net v2 0/3] net: ipa: three bug fixes

2020-06-30 Thread David Miller
From: Alex Elder Date: Tue, 30 Jun 2020 07:44:41 -0500 > This series contains three bug fixes for the Qualcomm IPA driver. > In practice these bugs are unlikke.y to be harmful, but they do > represent incorrect code. > > Version 2 adds "Fixes" tags to two of the patches and fixes a typo > in

Re: [PATCH net-next] net: dsa: Improve subordinate PHY error message

2020-06-30 Thread David Miller
From: Florian Fainelli Date: Mon, 29 Jun 2020 21:43:13 -0700 > It is not very informative to know the DSA master device when a > subordinate network device fails to get its PHY setup. Provide the > device name and capitalize PHY while we are it. > > Signed-off-by: Florian Fainelli Applied,

Re: [PATCH net-next] hinic: remove unused but set variable

2020-06-30 Thread David Miller
From: Luo bin Date: Tue, 30 Jun 2020 10:30:34 +0800 > remove unused but set variable to avoid auto build test WARNING > > Signed-off-by: Luo bin > Reported-by: kernel test robot Applied, thanks.

Re: [PATCH net-next 1/5] net: ipa: head-of-line block registers are RX only

2020-06-30 Thread David Miller
From: Alex Elder Date: Mon, 29 Jun 2020 20:09:58 -0500 > But the reason I was > considering it conditional on a config option is that Qualcomm > has a crash analysis tool that expects a BUG() call to stop the > system so its instant state can be captured. I don't use this > tool, and I might be

Re: [PATCH net-next 1/5] net: ipa: head-of-line block registers are RX only

2020-06-29 Thread David Miller
From: Alex Elder Date: Mon, 29 Jun 2020 20:01:20 -0500 > On 6/29/20 7:35 PM, Jakub Kicinski wrote: >> On Mon, 29 Jun 2020 16:49:15 -0500 Alex Elder wrote: >>> The INIT_HOL_BLOCK_EN and INIT_HOL_BLOCK_TIMER endpoint registers >>> are only valid for RX endpoints. >>> >>> Have

Re: [v2,net-next] net:qos: police action offloading parameter 'burst' change to the original value

2020-06-29 Thread David Miller
From: Po Liu Date: Mon, 29 Jun 2020 14:54:16 +0800 > Since 'tcfp_burst' with TICK factor, driver side always need to recover > it to the original value, this patch moves the generic calculation and > recover to the 'burst' original value before offloading to device driver. > > Signed-off-by: Po

Re: [PATCH net-next 0/6] net: ethernet: ti: am65-cpsw: update and enable sr2.0 soc

2020-06-29 Thread David Miller
From: Grygorii Strashko Date: Fri, 26 Jun 2020 21:17:03 +0300 > This series contains set of improvements for TI AM654x/J721E CPSW2G driver and > adds support for TI AM654x SR2.0 SoC. > > Patch 1: adds vlans restoration after "if down/up" > Patches 2-5: improvments > Patch 6: adds support for TI

Re: [PATCH 00/15] always use netdev_tx_t for xmit()'s return type

2020-06-29 Thread David Miller
From: Luc Van Oostenryck Date: Sun, 28 Jun 2020 21:53:22 +0200 > The ndo_start_xmit() methods should return a 'netdev_tx_t', not > an int, and so should return NETDEV_TX_OK, not 0. > The patches in the series fix most of the remaning drivers and > subsystems (those included in allyesconfig on

Re: [PATCH net-next] sctp: use list_is_singular in sctp_list_single_entry

2020-06-29 Thread David Miller
From: Geliang Tang Date: Sun, 28 Jun 2020 17:32:25 +0800 > Use list_is_singular() instead of open-coding. > > Signed-off-by: Geliang Tang Applied, thanks.

Re: [PATCH net-next] liquidio: use list_empty_careful in lio_list_delete_head

2020-06-29 Thread David Miller
From: Geliang Tang Date: Sun, 28 Jun 2020 18:14:13 +0800 > Use list_empty_careful() instead of open-coding. > > Signed-off-by: Geliang Tang Also applied, thank you.

Re: [PATCH net] lib: packing: add documentation for pbuflen argument

2020-06-28 Thread David Miller
From: Vladimir Oltean Date: Sun, 28 Jun 2020 17:49:35 +0300 > Fixes sparse warning: > > Function parameter or member 'pbuflen' not described in 'packing' > > Fixes: 554aae35007e ("lib: Add support for generic packing operations") > Signed-off-by: Vladimir Oltean > --- > Hi David, since the

Re: [PATCH net] bridge: mrp: Fix endian conversion and some other warnings

2020-06-28 Thread David Miller
From: Horatiu Vultur Date: Sun, 28 Jun 2020 15:45:16 +0200 > The following sparse warnings are fixed: > net/bridge/br_mrp.c:106:18: warning: incorrect type in assignment (different > base types) > net/bridge/br_mrp.c:106:18:expected unsigned short [usertype] > net/bridge/br_mrp.c:106:18:

Re: [PATCH net-next v4 0/5] hinic: add some ethtool ops support

2020-06-28 Thread David Miller
From: Luo bin Date: Sun, 28 Jun 2020 20:36:19 +0800 > patch #1: support to set and get pause params with > "ethtool -A/a" cmd > patch #2: support to set and get irq coalesce params with > "ethtool -C/c" cmd > patch #3: support to do self test with "ethtool -t" cmd > patch #4:

Re: [PATCH] net: ipv4: Fix wrong type conversion from hint to rt in ip_route_use_hint()

2020-06-27 Thread David Miller
From: linmiaohe Date: Sat, 27 Jun 2020 15:47:51 +0800 > From: Miaohe Lin > > We can't cast sk_buff to rtable by (struct rtable *)hint. Use skb_rtable(). > > Fixes: 02b24941619f ("ipv4: use dst hint for ipv4 list receive") > > Signed-off-by: Miaohe Lin Please do not put empty lines between

Re: [PATCH net-next v3 0/5] hinic: add some ethtool ops support

2020-06-27 Thread David Miller
From: Luo bin Date: Sat, 27 Jun 2020 14:52:37 +0800 > patch #1: support to set and get pause params with > "ethtool -A/a" cmd > patch #2: support to set and get irq coalesce params with > "ethtool -C/c" cmd > patch #3: support to do self test with "ethtool -t" cmd > patch #4:

Re: [PATCH 0/2] sparc32: srmmu: improve type safety of __nocache_fix()

2020-06-26 Thread David Miller
From: Mike Rapoport Date: Fri, 26 Jun 2020 21:17:13 +0300 > Any comments on this? Sorry I didn't see this in my patchwork queue, could you please just resubmit it to sparcli...@vger.kernel.org Thank you.

Re: [PATCH 0/6] net: phy: relax PHY and MDIO reset handling

2020-06-26 Thread David Miller
From: Bartosz Golaszewski Date: Fri, 26 Jun 2020 17:53:19 +0200 > From: Bartosz Golaszewski > > Previously these patches were submitted as part of a larger series[1] > but since the approach in it will have to be reworked I'm resending > the ones that were non-controversial and have been

Re: [PATCH 1/2] net: stmmac: change Kconfig menu entry to STMMAC/DWMAC

2020-06-26 Thread David Miller
From: Johan Jonker Date: Fri, 26 Jun 2020 14:05:26 +0200 > When a Rockchip user wants to enable support for > the ethernet controller one has to search for > something with STMicroelectronics. > Change the Kconfig menu entry to STMMAC/DWMAC, > so that it better reflects the options it enables. >

Re: [PATCH net-next v3 0/2] bridge: mrp: Extend MRP netlink interface with IFLA_BRIDGE_MRP_CLEAR

2020-06-26 Thread David Miller
From: Horatiu Vultur Date: Fri, 26 Jun 2020 09:33:47 +0200 > This patch series extends MRP netlink interface with IFLA_BRIDGE_MRP_CLEAR. > To allow the userspace to clear all MRP instances when is started. The > second patch in the series fix different sparse warnings. > > v3: > - add the

Re: [PATCH net-next] bonding: Remove extraneous parentheses in bond_setup

2020-06-26 Thread David Miller
From: Nathan Chancellor Date: Thu, 25 Jun 2020 21:10:02 -0700 > Clang warns: > > drivers/net/bonding/bond_main.c:4657:23: warning: equality comparison > with extraneous parentheses [-Wparentheses-equality] > if ((BOND_MODE(bond) == BOND_MODE_ACTIVEBACKUP)) >

Re: [PATCH] net: stmmac: dwmac-meson8b: use clk_parent_data for clock registration

2020-06-26 Thread David Miller
From: Martin Blumenstingl Date: Thu, 25 Jun 2020 20:21:42 +0200 > Simplify meson8b_init_rgmii_tx_clk() by using struct clk_parent_data to > initialize the clock parents. No functional changes intended. > > Signed-off-by: Martin Blumenstingl Applied to net-next, thank you.

Re: [PATCH v1] bnx2x: use generic power management

2020-06-26 Thread David Miller
From: Vaibhav Gupta Date: Wed, 24 Jun 2020 23:21:17 +0530 > With legacy PM, drivers themselves were responsible for managing the > device's power states and takes care of register states. > > After upgrading to the generic structure, PCI core will take care of > required tasks and drivers

Re: [Patch v4 3/3] net: Restrict receive packets queuing to housekeeping CPUs

2020-06-26 Thread David Miller
From: Peter Zijlstra Date: Fri, 26 Jun 2020 13:14:01 +0200 > On Thu, Jun 25, 2020 at 06:34:43PM -0400, Nitesh Narayan Lal wrote: >> From: Alex Belits >> >> With the existing implementation of store_rps_map(), packets are queued >> in the receive path on the backlog queues of other CPUs

[GIT] Networking

2020-06-25 Thread David Miller
1) Don't insert ESP trailer twice in IPSEC code, from Huy Nguyen. 2) The default crypto algorithm selection in Kconfig for IPSEC is out of touch with modern reality, fix this up. From Eric Biggers. 3) bpftool is missing an entry for BPF_MAP_TYPE_RINGBUF, from Andrii Nakryiko. 4)

Re: [PATCH net-next 0/8] net: phy: mscc: multiple improvements

2020-06-25 Thread David Miller
From: Antoine Tenart Date: Thu, 25 Jun 2020 17:42:03 +0200 > This series contains various improvements to the MSCC PHY driver, fixing > sparse and smatch warnings, using functions provided by the PHY core, > and improving the driver consistency and maintenance. > > I don't think any of those

Re: [PATCH net] sctp: Don't advertise IPv4 addresses if ipv6only is set on the socket

2020-06-25 Thread David Miller
From: Marcelo Ricardo Leitner Date: Wed, 24 Jun 2020 17:34:18 -0300 > If a socket is set ipv6only, it will still send IPv4 addresses in the > INIT and INIT_ACK packets. This potentially misleads the peer into using > them, which then would cause association termination. > > The fix is to not

Re: [PATCH net-next v11 0/5] RGMII Internal delay common property

2020-06-25 Thread David Miller
From: Dan Murphy Date: Wed, 24 Jun 2020 07:16:00 -0500 > The RGMII internal delay is a common setting found in most RGMII capable PHY > devices. It was found that many vendor specific device tree properties exist > to do the same function. This creates a common property to be used for PHY's >

Re: [PATCH v2 1/2] net: macb: call pm_runtime_put_sync on failure path

2020-06-25 Thread David Miller
From: Claudiu Beznea Date: Wed, 24 Jun 2020 13:08:17 +0300 > Call pm_runtime_put_sync() on failure path of at91ether_open. > > Fixes: e6a41c23df0d ("net: macb: ensure interface is not suspended on > at91rm9200") > Signed-off-by: Claudiu Beznea Applied and queued up for -stable.

Re: [PATCH v2 2/2] net: macb: free resources on failure path of at91ether_open()

2020-06-25 Thread David Miller
From: Claudiu Beznea Date: Wed, 24 Jun 2020 13:08:18 +0300 > DMA buffers were not freed on failure path of at91ether_open(). > Along with changes for freeing the DMA buffers the enable/disable > interrupt instructions were moved to at91ether_start()/at91ether_stop() > functions and the

Re: [PATCH][V2] qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE

2020-06-25 Thread David Miller
From: Colin King Date: Thu, 25 Jun 2020 17:45:05 +0100 > From: Colin Ian King > > The error DBG_STATUS_NO_MATCHING_FRAMING_MODE was added to the enum > enum dbg_status however there is a missing corresponding entry for > this in the array s_status_str. This causes an out-of-bounds read when >

Re: [PATCH v1] ptp_pch: use generic power management

2020-06-25 Thread David Miller
From: Vaibhav Gupta Date: Thu, 25 Jun 2020 17:40:43 +0530 > With legacy PM, drivers themselves were responsible for managing the > device's power states and takes care of register states. > > After upgrading to the generic structure, PCI core will take care of > required tasks and drivers

Re: [v2,net-next 2/4] net: enetc: add support max frame size for tc flower offload

2020-06-24 Thread David Miller
From: Po Liu Date: Wed, 24 Jun 2020 17:36:29 +0800 > From: Po Liu > > Base on the tc flower offload police action add max frame size by the > parameter 'mtu'. Tc flower device driver working by the IEEE 802.1Qci > stream filter can implement the max frame size filtering. Add it to the >

Re: [v2,net-next 1/4] net: qos: add tc police offloading action with max frame size limit

2020-06-24 Thread David Miller
From: Po Liu Date: Wed, 24 Jun 2020 17:36:28 +0800 > From: Po Liu > > Current police offloading support the 'burst'' and 'rate_bytes_ps'. Some > hardware own the capability to limit the frame size. If the frame size > larger than the setting, the frame would be dropped. For the police > action

Re: [v2,net-next 4/4] net: enetc add tc flower offload flow metering policing action

2020-06-24 Thread David Miller
From: Po Liu Date: Wed, 24 Jun 2020 17:36:31 +0800 > From: Po Liu > > Flow metering entries in IEEE 802.1Qci is an optional function for a > flow filtering module. Flow metering is two rates two buckets and three > color marker to policing the frames. This patch only enable one rate one >

Re: [v2,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-24 Thread David Miller
From: Po Liu Date: Wed, 24 Jun 2020 17:36:30 +0800 > From: Po Liu > > Hardware device may include more than one police entry. Specifying the > action's index make it possible for several tc filters to share the same > police action when installing the filters. > > Propagate this index to

Re: [PATCH net 0/3] net: bcmgenet: use hardware padding of runt frames

2020-06-24 Thread David Miller
From: Doug Berger Date: Wed, 24 Jun 2020 18:14:52 -0700 > Now that scatter-gather and tx-checksumming are enabled by default > it revealed a packet corruption issue that can occur for very short > fragmented packets. > > When padding these frames to the minimum length it is possible for > the

Re: [PATCH v3 0/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-24 Thread David Miller
From: Florian Fainelli Date: Wed, 24 Jun 2020 15:10:51 -0700 > Did you mean that you applied v4? It does not look like you pushed your > local changes to net-next yet, so I cannot tell for sure. I ended up applying v4, yes.

Re: [PATCH] qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE

2020-06-24 Thread David Miller
From: Colin King Date: Wed, 24 Jun 2020 11:13:02 +0100 > From: Colin Ian King > > The error DBG_STATUS_NO_MATCHING_FRAMING_MODE was added to the enum > enum dbg_status however there is a missing corresponding entry for > this in the array s_status_str. This causes an out-of-bounds read when >

Re: [PATCH 2/2] net: ethernet: mvneta: Add back interface mode validation

2020-06-24 Thread David Miller
From: Sascha Hauer Date: Wed, 24 Jun 2020 09:00:45 +0200 > When writing the serdes configuration register was moved to > mvneta_config_interface() the whole code block was removed from > mvneta_port_power_up() in the assumption that its only purpose was to > write the serdes configuration

Re: [PATCH 1/2] net: ethernet: mvneta: Do not error out in non serdes modes

2020-06-24 Thread David Miller
From: Sascha Hauer Date: Wed, 24 Jun 2020 09:00:44 +0200 > In mvneta_config_interface() the RGMII modes are catched by the default > case which is an error return. The RGMII modes are valid modes for the > driver, so instead of returning an error add a break statement to return > successfully. >

Re: [PATCH v3 0/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-24 Thread David Miller
From: Jisheng Zhang Date: Wed, 24 Jun 2020 11:25:16 +0800 > We face an issue with rtl8211f, a pin is shared between INTB and PMEB, > and the PHY Register Accessible Interrupt is enabled by default, so > the INTB/PMEB pin is always active in polling mode case. > > As Heiner pointed out "I was

Re: [PATCH net-next v4 0/8] net: phy: mscc: PHC and timestamping support

2020-06-24 Thread David Miller
From: Antoine Tenart Date: Tue, 23 Jun 2020 16:30:06 +0200 > This series aims at adding support for PHC and timestamping operations > in the MSCC PHY driver, for the VSC858x and VSC8575. Those PHYs are > capable of timestamping in 1-step and 2-step for both L2 and L4 traffic. ... Series

Re: [PATCH v1 0/5] ethernet: dec: tulip: use generic power management

2020-06-23 Thread David Miller
From: Vaibhav Gupta Date: Mon, 22 Jun 2020 17:12:23 +0530 > Linux Kernel Mentee: Remove Legacy Power Management. > > The purpose of this patch series is to remove legacy power management > callbacks and invocation of PCI helper functions, from tulip ethernet drivers. > > With legacy PM,

Re: [PATCH v2 0/3] ethernet: amd: Convert to generic power management

2020-06-23 Thread David Miller
From: Vaibhav Gupta Date: Mon, 22 Jun 2020 16:43:57 +0530 > Linux Kernel Mentee: Remove Legacy Power Management. > > The purpose of this patch series is to remove legacy power management > callbacks > from amd ethernet drivers. > > The callbacks performing suspend() and resume() operations

Re: [PATCH] [net] dcb_doit: remove redundant skb check

2020-06-23 Thread David Miller
From: Gaurav Singh Date: Mon, 22 Jun 2020 22:50:39 -0400 > skb cannot be NULL here since its already being accessed > before: sock_net(skb->sk). Remove the redundant null check. > > Signed-off-by: Gaurav Singh Applied.

Re: [PATCH] [net/decnet] dn_route_rcv: remove redundant dev null check

2020-06-23 Thread David Miller
From: Gaurav Singh Date: Mon, 22 Jun 2020 23:41:19 -0400 > dev cannot be NULL here since its already being accessed > before. Remove the redundant null check. > > Signed-off-by: Gaurav Singh Applied.

Re: [PATCH][next] net: ipv6: Use struct_size() helper and kcalloc()

2020-06-23 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 22 Jun 2020 18:07:41 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. Also, remove unnecessary > function ipv6_rpl_srh_alloc_size() and replace kzalloc() with kcalloc(), > which

Re: [PATCH] net: qrtr: free flow in __qrtr_node_release

2020-06-23 Thread David Miller
From: Carl Huang Date: Tue, 23 Jun 2020 11:22:03 +0800 > @@ -168,6 +168,7 @@ static void __qrtr_node_release(struct kref *kref) > struct radix_tree_iter iter; > unsigned long flags; > void __rcu **slot; > + struct qrtr_tx_flow *flow; Please retain the reverse christmas

Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()

2020-06-23 Thread David Miller
From: Kaige Li Date: Wed, 24 Jun 2020 10:07:16 +0800 > You are right. Should I do spin_unlock before the enic_open, or remove > spin_lock in enic_reset? You need to learn how this driver's locking works and design a correct adjustment.

Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()

2020-06-23 Thread David Miller
From: Kaige Li Date: Wed, 24 Jun 2020 09:56:47 +0800 > > On 06/24/2020 06:26 AM, David Miller wrote: >> From: David Miller >> Date: Tue, 23 Jun 2020 14:33:11 -0700 (PDT) >> >>> Calling a NIC driver open function from a context holding a spinlock >>&

Re: [PATCH] [net/wan] cosa_init: check bounds before access

2020-06-23 Thread David Miller
From: Gaurav Singh Date: Tue, 23 Jun 2020 21:04:49 -0400 > Check i < io bounds before accessing io[i]. > > Signed-off-by: Gaurav Singh The io[] array is intentionally zero terminated, there is no problem.

Re: [PATCH] [net/ethernet] do_reset: remove dev null check

2020-06-23 Thread David Miller
From: Gaurav Singh Date: Tue, 23 Jun 2020 20:55:45 -0400 > dev cannot be NULL here since its already being accessed > before. Remove the redundant null check. > > Signed-off-by: Gaurav Singh I changed your Subject to be: [PATCH net-next] xirc2ps_cs: remove dev null check from do_reset().

Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()

2020-06-23 Thread David Miller
From: David Miller Date: Tue, 23 Jun 2020 14:33:11 -0700 (PDT) > Calling a NIC driver open function from a context holding a spinlock > is very much the real problem, so many operations have to sleep and > in face that ->ndo_open() method is defined as being allowed to sleep >

Re: [PATCH net-next] bonding/xfrm: use real_dev instead of slave_dev

2020-06-23 Thread David Miller
From: Jarod Wilson Date: Tue, 23 Jun 2020 16:40:01 -0400 > Rather than requiring every hw crypto capable NIC driver to do a check for > slave_dev being set, set real_dev in the xfrm layer and xso init time, and > then override it in the bonding driver as needed. Then NIC drivers can > always use

Re: [PATCH v2 net-next 2/2] ipv6: fib6: avoid indirect calls from fib6_rule_lookup

2020-06-23 Thread David Miller
From: Brian Vazquez Date: Tue, 23 Jun 2020 09:42:32 -0700 > It was reported that a considerable amount of cycles were spent on the > expensive indirect calls on fib6_rule_lookup. This patch introduces an > inline helper called pol_route_func that uses the indirect_call_wrappers > to avoid the

Re: [PATCH v2 net-next 1/2] indirect_call_wrapper: extend indirect wrapper to support up to 4 calls

2020-06-23 Thread David Miller
From: Brian Vazquez Date: Tue, 23 Jun 2020 09:42:31 -0700 > There are many places where 2 annotations are not enough. This patch > adds INDIRECT_CALL_3 and INDIRECT_CALL_4 to cover such cases. > > Signed-off-by: Brian Vazquez Applied.

Re: [PATCH net-next] mlxsw: spectrum_dcb: Fix a spelling typo in spectrum_dcb.c

2020-06-23 Thread David Miller
From: Masanari Iida Date: Tue, 23 Jun 2020 23:13:01 +0900 > This patch fixes a spelling typo in spectrum_dcb.c > > Signed-off-by: Masanari Iida Applied, thank you.

Re: [PATCH net-next v10 2/5] net: phy: Add a helper to return the index for of the internal delay

2020-06-23 Thread David Miller
From: Dan Murphy Date: Tue, 23 Jun 2020 08:48:33 -0500 > diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c > index 29ef4456ac25..96f242eed058 100644 > --- a/drivers/net/phy/phy_device.c > +++ b/drivers/net/phy/phy_device.c ... > +static inline int

Re: [PATCH v2 net 0/9] net: qed/qede: various stability fixes

2020-06-23 Thread David Miller
From: Alexander Lobakin Date: Tue, 23 Jun 2020 16:51:28 +0300 > This set addresses several near-critical issues that were observed > and reproduced on different test and production configurations. > > v2: > - don't split the "Fixes:" tag across several lines in patch 9; > - no functional

Re: [PATCH v3 net] net: ethtool: add missing string for NETIF_F_GSO_TUNNEL_REMCSUM

2020-06-23 Thread David Miller
From: Alexander Lobakin Date: Tue, 23 Jun 2020 10:43:48 + > Commit e585f2363637 ("udp: Changes to udp_offload to support remote > checksum offload") added new GSO type and a corresponding netdev > feature, but missed Ethtool's 'netdev_features_strings' table. > Give it a name so it will be

Re: [PATCH net v2 0/2] bridge: mrp: Update MRP_PORT_ROLE

2020-06-23 Thread David Miller
From: Horatiu Vultur Date: Tue, 23 Jun 2020 11:05:39 +0200 > This patch series does the following: > - fixes the enum br_mrp_port_role_type. It removes the port role none(0x2) > because this is in conflict with the standard. The standard defines the > interconnect port role as value 0x2. > -

Re: [PATCH v4 3/8] sparc64: Fix asm/percpu.h build error

2020-06-23 Thread David Miller
From: Peter Zijlstra Date: Tue, 23 Jun 2020 10:36:48 +0200 > In order to break a header dependency between lockdep and task_struct, > I need per-cpu stuff from lockdep. > > Signed-off-by: Peter Zijlstra (Intel) Acked-by: David S. Miller

Re: [PATCH v2 1/2] net: phy: export phy_disable_interrupts()

2020-06-23 Thread David Miller
From: Jisheng Zhang Date: Tue, 23 Jun 2020 15:41:04 +0800 > +EXPORT_SYMBOL_GPL(phy_disable_interrupts); phy.o and phy_device.o are always linked together, therefore you don't need a module symbol export. If you plan to use it later in a device, submit the symbol export with the driver change

Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()

2020-06-23 Thread David Miller
From: Kaige Li Date: Tue, 23 Jun 2020 16:13:09 +0800 > The kernel module may sleep with holding a spinlock. > > The function call paths (from bottom to top) are: > > [FUNC] zalloc_cpumask_var(GFP_KERNEL) > drivers/net/ethernet/cisco/enic/enic_main.c, 125: zalloc_cpumask_var in >

Re: [PATCH v2] GUE: Fix a typo

2020-06-22 Thread David Miller
From: Aiden Leong Date: Mon, 22 Jun 2020 20:04:58 -0700 > Fix a typo in gue.h > > Signed-off-by: Aiden Leong Applied, thank you.

Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()

2020-06-22 Thread David Miller
Networking changes must be submitted with net...@vger.kernel.org Thank you.

Re: [PATCH net v2] mptcp: drop sndr_key in mptcp_syn_options

2020-06-22 Thread David Miller
From: Geliang Tang Date: Mon, 22 Jun 2020 19:45:58 +0800 > In RFC 8684, we don't need to send sndr_key in SYN package anymore, so drop > it. > > Fixes: cc7972ea1932 ("mptcp: parse and emit MP_CAPABLE option according to v1 > spec") > Signed-off-by: Geliang Tang Applied and queued up for

Re: [PATCH] [net/sched] tcindex_change: Remove redundant null check

2020-06-22 Thread David Miller
From: Gaurav Singh Date: Sun, 21 Jun 2020 22:24:30 -0400 > arg cannot be NULL since its already being dereferenced > before. Remove the redundant NULL check. > > Signed-off-by: Gaurav Singh Applied, thank you.

Re: linux-next: build failure after merge of the kspp tree

2020-06-22 Thread David Miller
From: Stephen Rothwell Date: Tue, 23 Jun 2020 13:51:34 +1000 > I have added the following merge fix patch. > > From: Stephen Rothwell > Date: Tue, 23 Jun 2020 13:43:06 +1000 > Subject: [PATCH] net/core/devlink.c: remove new uninitialized_var() usage > > Signed-off-by: Stephen Rothwell

Re: [PATCH] Fix check in ethtool_rx_flow_rule_create

2020-06-22 Thread David Miller
From: Gaurav Singh Date: Sun, 21 Jun 2020 11:30:17 -0400 > Fix check in ethtool_rx_flow_rule_create > > Signed-off-by: Gaurav Singh Applied and queued up for -stable with the following Fixes: tag added: Fixes: eca4205f9ec3 ("ethtool: add ethtool_rx_flow_spec to flow_rule structure

Re: [PATCH 02/17] sparc64: enable HAVE_COPY_THREAD_TLS

2020-06-22 Thread David Miller
From: Christian Brauner Date: Tue, 23 Jun 2020 01:43:11 +0200 > diff --git a/arch/sparc/kernel/syscalls.S b/arch/sparc/kernel/syscalls.S > index db42b4fb3708..192f3a28a2b7 100644 > --- a/arch/sparc/kernel/syscalls.S > +++ b/arch/sparc/kernel/syscalls.S > @@ -86,19 +86,22 @@ sys32_rt_sigreturn: >

Re: [PATCH] usbnet: smsc95xx: Fix use-after-free after removal

2020-06-22 Thread David Miller
From: Tuomas Tynkkynen Date: Sun, 21 Jun 2020 13:43:26 +0300 > Syzbot reports an use-after-free in workqueue context: > > BUG: KASAN: use-after-free in mutex_unlock+0x19/0x40 > kernel/locking/mutex.c:737 > mutex_unlock+0x19/0x40 kernel/locking/mutex.c:737 > __smsc95xx_mdio_read

Re: [PATCH v2 net 0/3] net: ethtool: netdev_features_strings[] cleanup

2020-06-22 Thread David Miller
From: Alexander Lobakin Date: Sun, 21 Jun 2020 09:55:50 + > This little series adds the last forgotten feature string for > NETIF_F_GSO_TUNNEL_REMCSUM and attempts to prevent such losses > in future. > > Patches 2-3 seem more like net-next candidates rather than net-fixes, > but for me it

Re: [PATCH 0/2] prepare dwmac-meson8b for G12A specific initialization

2020-06-22 Thread David Miller
From: Martin Blumenstingl Date: Sat, 20 Jun 2020 21:26:39 +0200 > Some users are reporting that RGMII (and sometimes also RMII) Ethernet > is not working for them on G12A/G12B/SM1 boards. Upon closer inspection > of the vendor code for these SoCs new register bits are found. > > It's not clear

Re: [PATCH net v3] net: phy: smsc: fix printing too many logs

2020-06-22 Thread David Miller
From: Dejin Zheng Date: Sat, 20 Jun 2020 22:55:34 +0800 > Commit 7ae7ad2f11ef47 ("net: phy: smsc: use phy_read_poll_timeout() > to simplify the code") will print a lot of logs as follows when Ethernet > cable is not connected: > > [4.473105] SMSC LAN8710/LAN8720 2188000.ethernet-1:00: >

Re: [Resend PATCH net] bridge: uapi: mrp: Fix MRP_PORT_ROLE

2020-06-22 Thread David Miller
From: Horatiu Vultur Date: Sat, 20 Jun 2020 15:14:03 +0200 > Currently the MRP_PORT_ROLE_NONE has the value 0x2 but this is in conflict > with the IEC 62439-2 standard. The standard defines the following port > roles: primary (0x0), secondary(0x1), interconnect(0x2). > Therefore remove the port

Re: [PATCH net-next v5 0/3] net: dsa: qca8k: Improve SGMII interface handling

2020-06-22 Thread David Miller
From: Jonathan McDowell Date: Sat, 20 Jun 2020 11:30:03 +0100 > This 3 patch series migrates the qca8k switch driver over to PHYLINK, > and then adds the SGMII clean-ups (i.e. the missing initialisation) on > top of that as a second patch. The final patch is a simple spelling fix > in a comment.

Re: [PATCH] sparc: piggyback: handle invalid image

2020-06-22 Thread David Miller
From: Corentin Labbe Date: Wed, 10 Jun 2020 07:55:19 + > With an old elftoaout, the generation of tftpboot.img fail with "lseek: > invalid argument". > This is due to offset being negative. > > Instead of printing this error message, let's print a better one. > > Signed-off-by: Corentin

Re: [PATCH][next] sparc64: viohs: Use struct_size() helper

2020-06-22 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 19 Jun 2020 20:14:06 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. Also, remove unnecessary > variable _len_. > > This code was detected with the help of Coccinelle and,

Re: [PATCH net-next v9 1/5] dt-bindings: net: Add tx and rx internal delays

2020-06-22 Thread David Miller
From: Dan Murphy Date: Fri, 19 Jun 2020 11:18:09 -0500 > @@ -162,6 +162,19 @@ properties: > description: >Specifies a reference to a node representing a SFP cage. > > + > + rx-internal-delay-ps: Do you really want two empty lines between these two sections?

Re: [PATCH net-next v9 2/5] net: phy: Add a helper to return the index for of the internal delay

2020-06-22 Thread David Miller
From: Dan Murphy Date: Fri, 19 Jun 2020 11:18:10 -0500 > +s32 phy_get_internal_delay(struct phy_device *phydev, struct device *dev, > +const int *delay_values, int size, bool is_rx) > +{ > + int i; > + s32 delay; Please use reverse christmas tree ordering for

Re: [PATCH net-next v3 0/4] bonding: initial support for hardware crypto offload

2020-06-22 Thread David Miller
From: Jarod Wilson Date: Fri, 19 Jun 2020 10:31:51 -0400 > This is an initial functional implementation for doing pass-through of > hardware encryption from bonding device to capable slaves, in active-backup > bond setups. This was developed and tested using ixgbe-driven Intel x520 > interfaces

Re: [PATCH net] rxrpc: Fix notification call on completion of discarded calls

2020-06-20 Thread David Miller
From: David Howells Date: Fri, 19 Jun 2020 23:38:16 +0100 > When preallocated service calls are being discarded, they're passed to > ->discard_new_call() to have the caller clean up any attached higher-layer > preallocated pieces before being marked completed. However, the act of > marking them

Re: [PATCH] [net/sched] Remove redundant skb null check

2020-06-20 Thread David Miller
From: Gaurav Singh Date: Fri, 19 Jun 2020 15:24:13 -0400 > Remove the redundant null check for skb. > > Signed-off-by: Gaurav Singh Applied to net-next.

Re: [PATCH net 0/3] net: ethtool: netdev_features_strings[] cleanup

2020-06-20 Thread David Miller
Please submit this again, I have two copies in my inbox and I have no idea what is different between them. Also, in some of your patches you cut the Fixes: tag into mutliple lines please do not do that. The Fixes: tag line should be one single line no matter how long it is. Thank you.

Re: [PATCH net-next] of: mdio: preserve phy dev_flags in of_phy_connect()

2020-06-20 Thread David Miller
From: rentao.b...@gmail.com Date: Thu, 18 Jun 2020 15:04:44 -0700 > From: Tao Ren > > Replace assignment "=" with OR "|=" for "phy->dev_flags" so "dev_flags" > configured in phy probe() function can be preserved. > > The idea is similar to commit e7312efbd5de ("net: phy: modify assignment > to

Re: [PATCH] [net/sched]: Remove redundant condition in qdisc_graft

2020-06-20 Thread David Miller
From: Gaurav Singh Date: Thu, 18 Jun 2020 16:36:31 -0400 > parent cannot be NULL here since its in the else part > of the if (parent == NULL) condition. Remove the extra > check on parent pointer. > > Signed-off-by: Gaurav Singh Applied to net-next, thanks.

Re: [net-next,v1,0/5] Strict mode for VRF

2020-06-20 Thread David Miller
From: David Ahern Date: Sat, 20 Jun 2020 16:32:53 -0700 > On 6/19/20 3:54 PM, Andrea Mayer wrote: >> This patch set adds the new "strict mode" functionality to the Virtual >> Routing and Forwarding infrastructure (VRF). Hereafter we discuss the >> requirements and the main features of the

Re: [PATCH][next] net/sched: cls_u32: Use struct_size() in kzalloc()

2020-06-19 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 18 Jun 2020 09:53:42 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > >

Re: [PATCH][next] taprio: Use struct_size() in kzalloc()

2020-06-19 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 18 Jun 2020 09:46:48 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. Also, remove unnecessary > variable _size_. > > This code was detected with the help of Coccinelle and,

Re: [PATCH][next] tipc: Use struct_size() helper

2020-06-19 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 18 Jun 2020 08:35:00 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > >

Re: [PATCH -next] macvlan: Fix memleak in macvlan_changelink_sources

2020-06-19 Thread David Miller
From: Zheng Bin Date: Thu, 18 Jun 2020 21:26:29 +0800 > macvlan_changelink_sources > if (addr) > ret = macvlan_hash_add_source(vlan, addr) > nla_for_each_attr(nla, head, len, rem) > ret = macvlan_hash_add_source(vlan, addr) > -->If fail, need to free previous malloc memory > >

Re: [PATCH v2] net: macb: undo operations in case of failure

2020-06-19 Thread David Miller
From: Claudiu Beznea Date: Thu, 18 Jun 2020 11:37:40 +0300 > Undo previously done operation in case macb_phylink_connect() > fails. Since macb_reset_hw() is the 1st undo operation the > napi_exit label was renamed to reset_hw. > > Fixes: 7897b071ac3b ("net: macb: convert to phylink") >

Re: [PATCH net] bridge: uapi: mrp: Fix MRP_PORT_ROLE

2020-06-19 Thread David Miller
Please send networking patches for review to net...@vger.kernel.org Thank you.

Re: [PATCH net 0/3] rxrpc: Performance drop fix and other fixes

2020-06-19 Thread David Miller
From: David Howells Date: Thu, 18 Jun 2020 08:50:15 +0100 > > Here are three fixes for rxrpc: > > (1) Fix a trace symbol mapping. It doesn't seem to let you map to "". > > (2) Fix the handling of the remote receive window size when it increases > beyond the size we can support for our

Re: [PATCH net v2 0/2] net: phy: MDIO bus scanning fixes

2020-06-19 Thread David Miller
From: Florian Fainelli Date: Fri, 19 Jun 2020 11:47:45 -0700 > This patch series fixes two problems with the current MDIO bus scanning > logic which was identified while moving from 4.9 to 5.4 on devices that > do rely on scanning the MDIO bus at runtime because they use pluggable > cards. > >

<    5   6   7   8   9   10   11   12   13   14   >